Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-06-30 08:45:01 +02:00
Code Issues Projects Releases Wiki Activity
39,722 Commits 49 Branches 744 Tags 928 MiB
55d05b56c3
Commit Graph

26930 Commits

Author SHA1 Message Date
desrosj
b431b2ff62 Update the package-lock.json file to 5.3.0. 
Built from https://develop.svn.wordpress.org/trunk@45283


git-svn-id: http://core.svn.wordpress.org/trunk@45092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-03 16:52:52 +00:00
Aaron Jorbin
d0364fc65a Trunk is now 5.3 alpha 
Built from https://develop.svn.wordpress.org/trunk@45282


git-svn-id: http://core.svn.wordpress.org/trunk@45091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-02 16:28:55 +00:00
desrosj
a1f4b046d7 Post WordPress 5.2 RC2 version bump. 
Built from https://develop.svn.wordpress.org/trunk@45280


git-svn-id: http://core.svn.wordpress.org/trunk@45089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-02 16:13:54 +00:00
desrosj
0aa044f0e1 WordPress 5.2 RC2. 
Built from https://develop.svn.wordpress.org/trunk@45279


git-svn-id: http://core.svn.wordpress.org/trunk@45088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-02 16:04:51 +00:00
desrosj
3360974ad2 Help/About: Polish the About page for 5.2. 
- The About page now uses a CSS grid to layout its design, making the page’s structure more obvious and hopefully easier for contributors in the future.
- Removes some code that is no longer used (such as videos, mejs elements, etc.).
- Update images.
- Unnecessary HTML is removed from a string on the page. This was a regression.
- Only users with the correct capability should be instructed to check their site status.
- Fixes the placement of commas.

Reviewed by melchoyce, afercia, jeremyfelt, and desrosj.

Props ryelle, melchoyce, cathibosco1, man4toman, SergeyBiryukov, afercia, ramiy, kjellr, tellyworth, earnjam, andreamiddleton, marybaum.
See #46901.
Built from https://develop.svn.wordpress.org/trunk@45278


git-svn-id: http://core.svn.wordpress.org/trunk@45087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-02 15:44:53 +00:00
desrosj
d48b709071 Bootstrap/Load: Ensure recovery link email and related notices are properly translated. 
When recovery mode is triggered before the site’s locale has been initialized, the message displayed to the user and the email sent to the site administrator with the recovery mode link are always rendered in `en_US`. This change ensures the site’s locale is used even when an error happens early in the loading process.

Reviewed by swissspidy, SergeyBiryukov, and desrosj.

Props wolly, TimothyBlynJacobs, fierevere.
Fixes #47093.
Built from https://develop.svn.wordpress.org/trunk@45277


git-svn-id: http://core.svn.wordpress.org/trunk@45086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-02 10:53:52 +00:00
desrosj
d53659ed71 Help/About: Fix tab display issues. 
This change restores About page tab heights and fixes bugs with the tab bottom border caused by [44905] and [45243].

Reviewed by SergeyBiryukov and desrosj.

Props ixkaito, ianbelanger, afercia, SergeyBiryukov.
See #46901.
Fixes #47075.
Built from https://develop.svn.wordpress.org/trunk@45276


git-svn-id: http://core.svn.wordpress.org/trunk@45085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-02 10:37:51 +00:00
desrosj
6ac1d4ec1a Site Health: Disable recommendations that could be problematic on multisite installs. 
When viewing Site Health for a multisite install, there are a few recommendations that are not appropriate and could have negative implications for other sites on the install if the administrator follows the advice provided.

For example, Site Health recommends that inactive plugins and themes for a site should be removed. On a single site install, this is a great recommendation. However, on a multisite install, inactive plugins and themes for one site should not be removed because they could be active for other sites on the network.

This change also disables the `test_wp_version_check_attached()` test for multisite. This test checks for the presence of the `wp_version_check()` function on the `wp_version_check` hook, which is not present for every site on multisite.

Reviewed by jeremyfelt and desrosj.

Props iandunn, Clorith, azaozz, jeremyfelt.
Fixes #47084.
Built from https://develop.svn.wordpress.org/trunk@45275


git-svn-id: http://core.svn.wordpress.org/trunk@45084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-05-01 18:08:53 +00:00
Aaron Jorbin
e4a0fd4c01 Admin: Add some additional clarity to some about page links 
It's important for links to have enough information in them in order to be clearly actionable. Destination and purpose should be clear. For example, `debug` isn't nearly as useful as `learn how to debug issues`.

This was signed off on by chanthaboune and jorbin.

Props afercia.
See: #46901.


Built from https://develop.svn.wordpress.org/trunk@45274


git-svn-id: http://core.svn.wordpress.org/trunk@45083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-30 17:31:55 +00:00
Gary Pendergast
0344202063 Post WordPress 5.2 RC1 version bump 
Built from https://develop.svn.wordpress.org/trunk@45273


git-svn-id: http://core.svn.wordpress.org/trunk@45082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-26 01:23:53 +00:00
Gary Pendergast
754dca460c WordPress 5.2 RC1 
Built from https://develop.svn.wordpress.org/trunk@45272


git-svn-id: http://core.svn.wordpress.org/trunk@45081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-26 01:15:52 +00:00
Gary Pendergast
d86524f09d Admin: Add the text for the WordPress 5.2 About page. 
This changes includes placeholder images for now, they'll be replaced by the final images before final release.

Props chanthaboune, melchoyce, karmatosed, pento, marybaum, birgire, earnjam, andreamiddleton.
See #46901.


Built from https://develop.svn.wordpress.org/trunk@45271


git-svn-id: http://core.svn.wordpress.org/trunk@45080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-26 00:57:53 +00:00
Gary Pendergast
0bbfe42ab1 Media: Revert [44947]. 
`get_available_post_mime_types()` uses a query that's extremely slow on sites with lots of posts. The original fix can be revisited after those performance issues are tackled.

See #43658.

Built from https://develop.svn.wordpress.org/trunk@45270


git-svn-id: http://core.svn.wordpress.org/trunk@45079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-26 00:44:52 +00:00
Andrea Fercia
700f891c36 Accessibility: Remove redundant title attribute from the "Exit Recovery Mode" link. 
Fixes #47045.

Built from https://develop.svn.wordpress.org/trunk@45269


git-svn-id: http://core.svn.wordpress.org/trunk@45078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-25 16:04:53 +00:00
Gary Pendergast
3b5307339d Bootstrap/Load: Tweak the recovery mode email text and behaviour. 
- Change the recovery mode link expiry to 1 day.
- Improve the email text.
- Add a new `recovery_email_support_info` filter, for hosts to be able to customise their support contact information.

Props pento, chanthaboune, michelleweber, matt.
Fixes #46898.


Built from https://develop.svn.wordpress.org/trunk@45268


git-svn-id: http://core.svn.wordpress.org/trunk@45077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-25 00:47:52 +00:00
K. Adam White
0b6f00fde2 REST API: Always urlencode_deep() query args in get_items methods. 
Passing all received query arguments through urlencode_deep ensures that the full set of query arguments are encoded in the same way.

Props dmsnell.
Fixes #46199

Built from https://develop.svn.wordpress.org/trunk@45267


git-svn-id: http://core.svn.wordpress.org/trunk@45076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-25 00:08:52 +00:00
Sergey Biryukov
8b333f8c20 Docs: Use 3-digit, x.x.x style semantic versioning for @since 5.2.0 entries in wp-admin/includes/file.php. 
See #46543.
Built from https://develop.svn.wordpress.org/trunk@45266


git-svn-id: http://core.svn.wordpress.org/trunk@45075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-24 23:36:51 +00:00
Andrew Ozz
655c21bbea Fix parsing of inner blocks when auto-generating an excerpt. Helps to prevent cases where dynamic inner blocks may cause an infinite loop if trying to auto-generate an excerpt. 
Props desrosj, pento, gziolo, azaozz.
Fixes #46133.
Built from https://develop.svn.wordpress.org/trunk@45265


git-svn-id: http://core.svn.wordpress.org/trunk@45074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-24 21:39:53 +00:00
Sergey Biryukov
ac7877ce6f Twenty Nineteen: Fix padding discrepancies in responsive styles for Column block. 
Props kjellr, dianeco.
Fixes #46643, #46999.
Built from https://develop.svn.wordpress.org/trunk@45264


git-svn-id: http://core.svn.wordpress.org/trunk@45073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-24 18:37:52 +00:00
Sergey Biryukov
54c7c76836 Bootstrap/Load: Modify the fatal error template to indicate to the user that they can check the admin email address for further instructions. 
Props spacedmonkey, TimothyBlynJacobs.
Fixes #46950.
Built from https://develop.svn.wordpress.org/trunk@45263


git-svn-id: http://core.svn.wordpress.org/trunk@45072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-24 18:14:53 +00:00
tellyworth
ed802428e3 Upgrade/install: fix verification bugs and scale back signature checks. 
This fixes several bugs in the signature verification code:
Disables signature checks on certain incompatible PHP versions that cause math errors when opcache is enabled;
Prevents a spurious URL and subsequent error when downloading a zip file with query arguments;
Prevents errors triggered by third-party upgrade scripts as per #46615;
Disables signature tests for Plugins, Themes, and Translations, leaving only core updates.

At the 5.2 release the API servers will only provide signatures for core update packages, which is why messages are suppressed for plugins and other package types. Signatures for those other items will become available later.

Props dd32.
See #39309, #46615


Built from https://develop.svn.wordpress.org/trunk@45262


git-svn-id: http://core.svn.wordpress.org/trunk@45071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-24 07:44:51 +00:00
Andrew Ozz
df438d90a0 Remove the core/more block delimiters when splitting post_content on the <!--more--> tag. 
Fixes:
- Parsing of blocks in the second half of post_content.
- Outputting malformed HTML when `the_content( null, true )` or  `<!--noteaser-->` is used.

Props lukecarbis, garrett-eclipse, birgire.
Fixes #46471.
Built from https://develop.svn.wordpress.org/trunk@45261


git-svn-id: http://core.svn.wordpress.org/trunk@45070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-24 05:40:52 +00:00
Andrew Ozz
0da8c2265f Site Health: Fix count of inactive themes and the recommendation to remove them when the default theme is active or is a parent of the active child theme. 
Props sudhiryadav, ianbelanger, mukesh27, azaozz.
Fixes #46900.
Built from https://develop.svn.wordpress.org/trunk@45260


git-svn-id: http://core.svn.wordpress.org/trunk@45069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-23 21:37:53 +00:00
Andrew Ozz
2548263bac Site Health: Allow some HTML (inline tags only) in the section descriptions. Add some more docs about expected formatting of the gathered data. 
Props kraftbj, jeherve, mukesh27, audrasjb, azaozz.
Fixes #46878.
Built from https://develop.svn.wordpress.org/trunk@45259


git-svn-id: http://core.svn.wordpress.org/trunk@45068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-23 21:05:52 +00:00
laurelfulford
c7f2bda6f2 Twenty Nineteen: Prevent too-long strings from causing horizontal scrolling. 
Add hyphen and word-wrap styles to the site title, comments, and widget areas to break too-long strings and prevent horizontal scrolling.

Props ianbelanger, dswebsme, mukesh27.
Fixes #46704.


Built from https://develop.svn.wordpress.org/trunk@45258


git-svn-id: http://core.svn.wordpress.org/trunk@45067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-23 19:48:53 +00:00
laurelfulford
9950f8b71e Twenty Seventeen: Prevent too-long strings from causing horizontal scrolling. 
Add a `max-width` to the site title, so too-long strings will wrap instead of causing horizontal scrolling. 

Props ianbelanger, dswebsme.
Fixes #46703.


Built from https://develop.svn.wordpress.org/trunk@45257


git-svn-id: http://core.svn.wordpress.org/trunk@45066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-23 16:44:52 +00:00
Adam Silverstein
18ccaf962e Bundled Theme: add a wp_body_open shim for older WordPress versions. 
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.

Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679.


Built from https://develop.svn.wordpress.org/trunk@45256


git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-23 13:04:56 +00:00
aduth
0feb55f633 Editor: Update packages to apply bugfixes from Gutenberg 5.5. 
- @wordpress/block-editor@2.0.1
- @wordpress/block-library@2.4.4
- @wordpress/blocks@6.2.4
- @wordpress/components@7.3.1
- @wordpress/dom@2.2.4
- @wordpress/e2e-tests@1.1.4
- @wordpress/edit-post@3.3.4
- @wordpress/editor@9.2.4
- @wordpress/format-library@1.4.4
- @wordpress/list-reusable-blocks@1.3.4
- @wordpress/nux@3.2.4

Props iseulde, kjellr, aduth, get_dave, talldanwp, jorgefilipecosta, afercia, nosolosw, jasmussen, netweb .

See https://github.com/WordPress/gutenberg/pull/14987 .
See https://github.com/WordPress/gutenberg/pull/15020 .
Fixes #46951 .

Built from https://develop.svn.wordpress.org/trunk@45255


git-svn-id: http://core.svn.wordpress.org/trunk@45064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-22 12:40:04 +00:00
Sergey Biryukov
355d5f9bb7 Docs: Correct @param type for $deprecated and $plugin_rel_path arguments of load_plugin_textdomain(). 
Props sudar.
Fixes #43304.
Built from https://develop.svn.wordpress.org/trunk@45254


git-svn-id: http://core.svn.wordpress.org/trunk@45063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-19 14:21:53 +00:00
Sergey Biryukov
d5c77c833a Docs: Add missing @since tag for WP_Recovery_Mode_Cookie_Service::parse_cookie(). 
Props mukesh27.
Fixes #46993.
Built from https://develop.svn.wordpress.org/trunk@45253


git-svn-id: http://core.svn.wordpress.org/trunk@45062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-19 14:00:51 +00:00
Sergey Biryukov
bd9421104a Networks and Sites: Use correct escaping function for classes added via ms_user_list_site_class filter. 
Props david.binda.
Fixes #46990. See #41146.
Built from https://develop.svn.wordpress.org/trunk@45252


git-svn-id: http://core.svn.wordpress.org/trunk@45061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-19 13:51:51 +00:00
Sergey Biryukov
c9efbc89be Docs: Correct @return description for get_privacy_policy_template(). 
Props tmatsuur.
Fixes #46989. See #44005.
Built from https://develop.svn.wordpress.org/trunk@45251


git-svn-id: http://core.svn.wordpress.org/trunk@45060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-19 13:46:51 +00:00
Sergey Biryukov
8fdb4c2b0c Bundled Themes: Update readme.txt files to pass Theme Review guidelines. 
Props rabmalin.
Fixes #45871.
Built from https://develop.svn.wordpress.org/trunk@45250


git-svn-id: http://core.svn.wordpress.org/trunk@45059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-19 13:41:54 +00:00
Sergey Biryukov
643ec358a4 Docs: Correct @return description for get_dirsize(). 
Props wpboss, tmatsuur.
Fixes #46987.
Built from https://develop.svn.wordpress.org/trunk@45249


git-svn-id: http://core.svn.wordpress.org/trunk@45058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-19 13:39:52 +00:00
Andrea Fercia
22d8c0af3c Accessibility: Improve the "Alt text" description styles for small screens. 
Amends [44900].
See #41612.

Built from https://develop.svn.wordpress.org/trunk@45248


git-svn-id: http://core.svn.wordpress.org/trunk@45057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 21:43:52 +00:00
Adam Silverstein
b287642342 Feeds: improve structure and naming of feed build date helper function. 
Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming `get_last_build_date` to `get_feed_build_date`.

Props pento, spacedmonkey.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@45247


git-svn-id: http://core.svn.wordpress.org/trunk@45056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 17:08:52 +00:00
Dominik Schilling
2d58638ba0 Site Health: Fix debug data with nested fields for copying. 
* Use `$debug_data` instead of `$field['value']` to retrieve the debug data.
* Rename inner variables to avoid overriding the output variable.

Props Clorith, ocean90.
See #46573.
Built from https://develop.svn.wordpress.org/trunk@45246


git-svn-id: http://core.svn.wordpress.org/trunk@45055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 16:26:51 +00:00
Dominik Schilling
3e6183c69c Site Health: Provide context for tab headings to be able to distinguish them from existing strings. 
See #46573.
Built from https://develop.svn.wordpress.org/trunk@45245


git-svn-id: http://core.svn.wordpress.org/trunk@45054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 16:06:51 +00:00
Dominik Schilling
bfc2be39e6 Site Health: Enable JavaScript translations for the site-health script. 
See #46683.
Built from https://develop.svn.wordpress.org/trunk@45244


git-svn-id: http://core.svn.wordpress.org/trunk@45053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 15:41:51 +00:00
Gary Pendergast
6fcd281707 CSS: Remove the units from line-height properties in common.css. 
Props ianbelanger, talldanwp.
Fixes #46493.


Built from https://develop.svn.wordpress.org/trunk@45243


git-svn-id: http://core.svn.wordpress.org/trunk@45052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 06:02:53 +00:00
Gary Pendergast
4325de4629 KSES: Add background-position and grid-template-columns as safe CSS properties. 
Props aduth.
Fixes #46597.


Built from https://develop.svn.wordpress.org/trunk@45242


git-svn-id: http://core.svn.wordpress.org/trunk@45051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 05:56:51 +00:00
Andrew Ozz
3a0563e853 Site Health info tab: fix replacing the size strings in the copied info. 
Props xkon.
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45241


git-svn-id: http://core.svn.wordpress.org/trunk@45050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 04:51:52 +00:00
Gary Pendergast
699f028f21 Emoji: Upgrade Twemoji to 12.0.1. 
As this point release doesn't modify any images, only adding a few missing ones, we don't need to change the CDN location.

Props earnjam.
Fixes #46805.


Built from https://develop.svn.wordpress.org/trunk@45240


git-svn-id: http://core.svn.wordpress.org/trunk@45049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 02:11:52 +00:00
Andrew Ozz
9659676fca Site Health info tab: Remove the "Directories and Sizes" section on Multisite installations. Most of the info shown there doesn't apply for multisite. 
Props xkon, desrosj, azaozz.
Built from https://develop.svn.wordpress.org/trunk@45239


git-svn-id: http://core.svn.wordpress.org/trunk@45048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 00:34:51 +00:00
Sergey Biryukov
2d81c95f73 Bootstrap/Load: Only send the recovery mode email if the error occurs on a protected endpoint. 
This reduces the potential email noise to places where the fatal error could be interfering with the login and admin experience.

Once the user is in recovery mode, any fatal errors (even if they aren't in a protected endpoint) are handled and the plugin or theme will be paused.

Props TimothyBlynJacobs.
See #46950.
Built from https://develop.svn.wordpress.org/trunk@45238


git-svn-id: http://core.svn.wordpress.org/trunk@45047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 23:04:53 +00:00
Andrew Ozz
2a5c2a2cce Site health info tab: replace "Not calculated" with "Loading..." in the "Directories and Sizes" section (that's an existing string and wouldn't cause problems for translators). 
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45237


git-svn-id: http://core.svn.wordpress.org/trunk@45046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 21:26:52 +00:00
Jeremy Felt
7ec74901d3 Docs: Add arguments passed by wp_insert_site() to wp_initialize_site(). 
Props codemascot.
Fixes #45061.

Built from https://develop.svn.wordpress.org/trunk@45236


git-svn-id: http://core.svn.wordpress.org/trunk@45045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 20:57:52 +00:00
Sergey Biryukov
2e0e63f923 Users: In wp_list_authors(), check for author's post count before getting author's metadata. 
This significantly reduces the number of SQL queries when `wp_list_authors()` is called on a site where the majority of users don't have any posts, e.g. a membership site.

Props billerickson, ianbelanger, dswebsme.
Fixes #45105.
Built from https://develop.svn.wordpress.org/trunk@45235


git-svn-id: http://core.svn.wordpress.org/trunk@45044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 14:50:50 +00:00
Sergey Biryukov
23de32062e Site Health: Allow any callable added via site_status_tests filter to return test results for direct tests. 
Async tests still need to be a string for the AJAX action.

Props kraftbj.
Fixes #46836.
Built from https://develop.svn.wordpress.org/trunk@45234


git-svn-id: http://core.svn.wordpress.org/trunk@45043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 14:35:50 +00:00
Sergey Biryukov
1be34a234f Docs: Remove @global tag for $wpdb from wp-admin/install.php and wp-admin/upgrade.php. 
Per the documentation standards, the `@global` tag is meant to list PHP globals used within functions or methods.

The code in question uses the variable in global namespace, but does not explicitly declare it.

Props jayupadhyay01, dswebsme.
Fixes #46602.
Built from https://develop.svn.wordpress.org/trunk@45233


git-svn-id: http://core.svn.wordpress.org/trunk@45042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 14:07:53 +00:00
Sergey Biryukov
d2ccaacedf Docs: Correct spelling in various comments and DocBlocks, per the conventions in Core Contributor Handbook. 
Props man4toman, samanehmirrajabi.
Fixes #45857.
Built from https://develop.svn.wordpress.org/trunk@45232


git-svn-id: http://core.svn.wordpress.org/trunk@45041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 13:26:51 +00:00
Sergey Biryukov
e1de58320d Themes: Standardize on passing frontpage and privacypolicy as the $type parameter to get_query_template(). 
These keys are used in `{$type}_template_hierarchy` and `{$type}_template` filters.

Previously, `front_page` and `privacy_policy` were passed, but `get_query_template()` stripped the underscores before passing the values to the filters.

Props rinatkhaziev, tmatsuur, johnbillion.
Fixes #21213, #46958.
Built from https://develop.svn.wordpress.org/trunk@45231


git-svn-id: http://core.svn.wordpress.org/trunk@45040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 12:58:51 +00:00
Sergey Biryukov
604769cca5 Site Health: Group WP_DEBUG-related constants together. 
Props tmatsuur.
Fixes #46955.
Built from https://develop.svn.wordpress.org/trunk@45230


git-svn-id: http://core.svn.wordpress.org/trunk@45039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 12:00:54 +00:00
Andrea Fercia
d89a302503 Site Health: Improve the accordions styles for small screens. 
Also, changes the hex color values to lowercase.

Props subrataemfluence, man4toman, garrett-eclipse, chetan200891, mukesh27, melchoyce, karmatosed, Clorith.
Fixes #46949.

Built from https://develop.svn.wordpress.org/trunk@45229


git-svn-id: http://core.svn.wordpress.org/trunk@45038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 11:00:53 +00:00
Andrea Fercia
65ab4e7607 Site Health: Remove title attribute from the directory sizes spinner. 
Amends [45176].
See #46707.

Built from https://develop.svn.wordpress.org/trunk@45228


git-svn-id: http://core.svn.wordpress.org/trunk@45037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 10:09:52 +00:00
Andrea Fercia
4ead9880b0 Accessibility: Make the Tags meta box better support Input Method Editor (IME) converters. 
Also, restores the keyboard interaction behavior prior to [41988] by requesting one single Enter key press to add a tag.

Props ryanshoover, miyauchi.
Fixes #45371.

Built from https://develop.svn.wordpress.org/trunk@45227


git-svn-id: http://core.svn.wordpress.org/trunk@45036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 07:18:51 +00:00
Sergey Biryukov
74e9c3d20d Docs: Improve documentation for various WP_Filesystem_Base methods and extending classes. 
Props jaydeep-rami, man4toman, SaeedFard, mukesh27, mohadeseghasemi, ebrahimzadeh, juiiee8487, SergeyBiryukov.
Fixes #42227, #46806, #46840. See #46543.
Built from https://develop.svn.wordpress.org/trunk@45226


git-svn-id: http://core.svn.wordpress.org/trunk@45035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 04:13:51 +00:00
desrosj
13345d12e9 Administration: Add missing :before to two Dashicon class definitions. 
Introduced in [45040].

Props builtbynorthby.
Fixes #41074.
Built from https://develop.svn.wordpress.org/trunk@45225


git-svn-id: http://core.svn.wordpress.org/trunk@45034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 02:09:52 +00:00
desrosj
f807a098b1 Administration: Improve the accuracy of is_block_editor(). 
Currently, there are a number of scenarios where `is_block_editor()` (and `WP_Screen::is_block_editor`) would incorrectly indicate block editor support at different points of the loading process. Most notably, checking `is_block_editor` when hooking into the `current_screen` action will always result in `false`, even when the block editor is being loaded. This is because `is_block_editor` is not set to `true` until `edit-form-blocks.php` is included.

This change adds logic to `WP_Screen` to ensure the accuracy of `is_block_editor` on block editor pages earlier in the load process.

While edit screens will now be accurate 100% of the time from `current_screen` on, there are still a few edge cases where `is_block_editor` could contain an incorrect value when creating a new post.

Because a `WP_Post` object is a required parameter for the `replace_editor` filter and `use_block_editor_for_post()` function, `WP_Screen` will fall back to the value returned by `use_block_editor_for_post_type()` for the post being created. To eliminate these edge cases, the `use_block_editor_for_post_type` filter can be used to return the appropriate boolean value to indicate support.

Props Chouby, desrosj, aduth, johnbillion.
Fixes #46195.
Built from https://develop.svn.wordpress.org/trunk@45224


git-svn-id: http://core.svn.wordpress.org/trunk@45033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 01:56:52 +00:00
Sergey Biryukov
893be2cf11 Site Health: Remove reference to an undefined variable in WP_Site_Health_Auto_Updates::test_constants(). 
Props diddledan.
Fixes #46952.
Built from https://develop.svn.wordpress.org/trunk@45223


git-svn-id: http://core.svn.wordpress.org/trunk@45032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 01:10:52 +00:00
Sergey Biryukov
01dec9af0b Docs: Fix typo in WP_Site_Health_Auto_Updates::test_constants() description. 
See #46543.
Built from https://develop.svn.wordpress.org/trunk@45222


git-svn-id: http://core.svn.wordpress.org/trunk@45031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 01:00:51 +00:00
Sergey Biryukov
6ad0bf33ec PHPCS: Fix WPCS violations in [45220]. 
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45221


git-svn-id: http://core.svn.wordpress.org/trunk@45030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-17 00:45:50 +00:00
Andrew Ozz
9a316c6ea4 Site health, info tab: 
- Change `recurse_dirsize()` to accept an array of excluded paths.
- Change so we don't calculate the sizes of dirs in wp-content twice.
- Add the size in bytes to the "debug" into.
- Add a custom DOM event after the dir sizes request is done. Can be used by plugins to "daisy chain" more requests.
- Move "WordPress directory location" and "WordPress directory size" to the top in the "Directories and Sizes" section.
- Move "Theme directory location" to the "Active Theme" section.
- Fix labels capitalization.

Props xkon, afercia, Clorith, azaozz.
Fixes #46707.
Built from https://develop.svn.wordpress.org/trunk@45220


git-svn-id: http://core.svn.wordpress.org/trunk@45029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 23:02:51 +00:00
Adam Silverstein
8e9315f51e Media: move get_available_post_mime_types to wp-includes/post.php making it more generally available. 
Address an issue since r44947 where calling `wp_enqueue_media` on the front-end would result in a PHP fatal.

Props david.binda.
Fixes #46795.

Built from https://develop.svn.wordpress.org/trunk@45219


git-svn-id: http://core.svn.wordpress.org/trunk@45028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 20:30:51 +00:00
desrosj
47ad9774e3 Bundled Themes: Reverts [45213]. 
Reverting to address backward compatibility concerns in Twenty Eleven and Twenty Ten.

See #39997.
Built from https://develop.svn.wordpress.org/trunk@45218


git-svn-id: http://core.svn.wordpress.org/trunk@45027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 18:22:52 +00:00
Andrea Fercia
fc7a8f7194 Administration: Improve the Site Health "Passed tests" button style for small screens. 
Props chetan200891.
Fixes #46939.

Built from https://develop.svn.wordpress.org/trunk@45217


git-svn-id: http://core.svn.wordpress.org/trunk@45026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 16:23:52 +00:00
Sergey Biryukov
c28e516c80 Export: Remove extra whitespace from <title>, <content:encoded>, and <excerpt:encoded> elements in WXR files. 
Props sgastard, juliarrr, aristath, SergeyBiryukov.
Fixes #46575.
Built from https://develop.svn.wordpress.org/trunk@45216


git-svn-id: http://core.svn.wordpress.org/trunk@45025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 15:57:53 +00:00
Sergey Biryukov
373a759c6b Feeds: Amend [45208] to avoid phpcs:ignore. 
See #46922.
Built from https://develop.svn.wordpress.org/trunk@45215


git-svn-id: http://core.svn.wordpress.org/trunk@45024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 15:46:52 +00:00
Sergey Biryukov
39b82b89be Permalinks: Avoid a PHP notice in wp_resolve_numeric_slug_conflicts() when visiting a day archive with the /%postname%/ permalink structure. 
Props thakkarhardik, thomstark.
Fixes #46828.
Built from https://develop.svn.wordpress.org/trunk@45214


git-svn-id: http://core.svn.wordpress.org/trunk@45023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 15:34:52 +00:00
desrosj
464535d0d3 Bundled Themes: Use the theme version when enqueuing theme specific stylesheets. 
For many bundled theme related stylesheets, a version is either not specified, or specified as a hardcoded date string when enqueued. This is problematic when a stylesheet is updated and the version number is not (which has happened several times recently). This change ensures that all bundled theme related stylesheets use the theme’s version as the stylesheet version. This ensures cache busting for theme stylesheets every time a theme is updated and guarantees that users receive any new or updated styles included in the update when visiting the site for the first time after an update.

Props parsmizban, ianbelanger, dswebsme.
Fixes #39997.
Built from https://develop.svn.wordpress.org/trunk@45213


git-svn-id: http://core.svn.wordpress.org/trunk@45022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 14:56:51 +00:00
desrosj
69362abeac Twenty Thirteen: Correct Genericons stylesheet version number. 
In [28693], the Genericons stylesheet was updated to `3.0.3`, but the version was incorrectly indicated as `3.03`.

See #39997.
Built from https://develop.svn.wordpress.org/trunk@45212


git-svn-id: http://core.svn.wordpress.org/trunk@45021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 14:07:51 +00:00
Felix Arntz
6067088848 Bootstrap/Load: Allow more than one recovery link to be valid at a time. 
While currently a recovery link is only made available via the admin email address, this will be expanded in the future. In order to accomplish that, the mechanisms to store and validate recovery keys must support multiple keys to be valid at the same time.

This changeset adds that support, adding an additional token parameter which is part of a recovery link in addition to the key. A key itself is always associated with a token, so the two are only valid in combination. These associations are stored in a new `recovery_keys` option, which is regularly cleared in a new Cron hook, to prevent potential cluttering from unused recovery keys.

This changeset does not have any user-facing implications otherwise.

Props pbearne, timothyblynjacobs.
Fixes #46595. See #46130.

Built from https://develop.svn.wordpress.org/trunk@45211


git-svn-id: http://core.svn.wordpress.org/trunk@45020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 05:09:51 +00:00
Felix Arntz
f1352827f8 General: Display fatal error handler notice in admin backend even if headers have been sent. 
This ensures that at least for the admin, which is more predictable than the frontend, the user-friendlier error notice from the fatal error handler still shows if a runtime fatal error happens within the page generation process.

Props axaak.
Fixes #46811.

Built from https://develop.svn.wordpress.org/trunk@45210


git-svn-id: http://core.svn.wordpress.org/trunk@45019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 04:38:51 +00:00
Sergey Biryukov
37f04694d5 Bundled Themes: Use consistent HTML comments after closing HTML tags. 
Props iamdmitrymayorov.
Fixes #46871.
Built from https://develop.svn.wordpress.org/trunk@45209


git-svn-id: http://core.svn.wordpress.org/trunk@45018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 01:30:53 +00:00
Sergey Biryukov
f25f241573 Feeds: Remove whitespace from <updated> elements in Atom feeds. 
Per Atom format's RFC, there must not be any whitespace in a Date construct or in any IRI.

Props josephwa.
Fixes #46922.
Built from https://develop.svn.wordpress.org/trunk@45208


git-svn-id: http://core.svn.wordpress.org/trunk@45017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 00:46:51 +00:00
Sergey Biryukov
6efa2cd724 I18N: Fix typo in a translator comment. 
See #46920.
Built from https://develop.svn.wordpress.org/trunk@45207


git-svn-id: http://core.svn.wordpress.org/trunk@45016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 23:56:52 +00:00
Sergey Biryukov
7af011a5f0 Bootstrap/Load: After [45016], make sure wp_die() does not cause _doing_it_wrong() notices if called before $wp_query global is set. 
Props tmdesigned, TimothyBlynJacobs.
Fixes #46813.
Built from https://develop.svn.wordpress.org/trunk@45206


git-svn-id: http://core.svn.wordpress.org/trunk@45015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 23:49:53 +00:00
Sergey Biryukov
c75d21589d Bootstrap/Load: Remove WP_Recovery_Mode_Cookie_Service constructor to avoid referencing cookie constants before they are defined. 
Instantiating `WP_Recovery_Mode` should no longer have any required timing.

Props TimothyBlynJacobs, lkraav.
Fixes #46882.
Built from https://develop.svn.wordpress.org/trunk@45205


git-svn-id: http://core.svn.wordpress.org/trunk@45014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 22:44:52 +00:00
John Blackbourn
d4d1267847 I18N: Improvements to and additions of translator comments for various email subject strings. 
Props ramiy

Fixes #46920

Built from https://develop.svn.wordpress.org/trunk@45204


git-svn-id: http://core.svn.wordpress.org/trunk@45013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 22:39:50 +00:00
Sergey Biryukov
60bf5fefff Docs: Adjust comments in wp_initial_constants() to conform to WPCS. 
See #46543.
Built from https://develop.svn.wordpress.org/trunk@45203


git-svn-id: http://core.svn.wordpress.org/trunk@45012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 22:10:52 +00:00
Mel Choyce
df276c333a Administration: Update chevron color in Site Health. 
Props afercia.
Fixes #46934. See #46730.

Built from https://develop.svn.wordpress.org/trunk@45202


git-svn-id: http://core.svn.wordpress.org/trunk@45011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 18:56:54 +00:00
Andrea Fercia
10239ba45d Administration: Add a chevron icon to the Site Health "Passed tests" button. 
The chevron icon helps clarify what the button does.

Props garrett-eclipse, Clorith, xkon, melchoyce.
Fixes #46730.

Built from https://develop.svn.wordpress.org/trunk@45201


git-svn-id: http://core.svn.wordpress.org/trunk@45010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 18:01:53 +00:00
Andrea Fercia
5ac2b28396 Administration: Provide translatable strings for the Site Health comment status report. 
Props ocean90.
Fixes #46909.

Built from https://develop.svn.wordpress.org/trunk@45200


git-svn-id: http://core.svn.wordpress.org/trunk@45009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 15:08:51 +00:00
Andrea Fercia
5b530e903d Site Health: Add missing translator comments. 
Amends [45178].
See #46683.

Built from https://develop.svn.wordpress.org/trunk@45199


git-svn-id: http://core.svn.wordpress.org/trunk@45008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-15 14:39:55 +00:00
Andrea Fercia
b0ef0ae305 Site health: Improve jQuery selectors so that they don't depend on a specific markup. 
Amends [45178].
See #46683.

Built from https://develop.svn.wordpress.org/trunk@45198


git-svn-id: http://core.svn.wordpress.org/trunk@45007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-14 14:30:51 +00:00
Andrea Fercia
a9542cd60a Coding standards: Site health: Avoid to use var in the middle of JavaScript function blocks. 
Amends [45178].
See #46683.

Built from https://develop.svn.wordpress.org/trunk@45197


git-svn-id: http://core.svn.wordpress.org/trunk@45006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-14 13:49:55 +00:00
Sergey Biryukov
394d3b2f9b Site Health: Merge duplicate "utf8mb4 requires a newer client library" strings. 
Props ramiy.
Fixes #46917.
Built from https://develop.svn.wordpress.org/trunk@45196


git-svn-id: http://core.svn.wordpress.org/trunk@45005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 18:18:52 +00:00
Sergey Biryukov
f94f0684b1 Site Health: Merge duplicate "Error" strings. 
Props ramiy.
Fixes #46915.
Built from https://develop.svn.wordpress.org/trunk@45195


git-svn-id: http://core.svn.wordpress.org/trunk@45004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 18:12:52 +00:00
Sergey Biryukov
38f3607c53 Users: Merge duplicate "Download failed" strings. 
Props ramiy.
Fixes #46914.
Built from https://develop.svn.wordpress.org/trunk@45194


git-svn-id: http://core.svn.wordpress.org/trunk@45003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 18:08:52 +00:00
Sergey Biryukov
cbe1c88485 Site Health: Merge duplicate "Latest version" strings. 
Props ramiy.
Fixes #46913.
Built from https://develop.svn.wordpress.org/trunk@45193


git-svn-id: http://core.svn.wordpress.org/trunk@45002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 18:04:52 +00:00
Sergey Biryukov
845977ed1f Site Health: Merge duplicate "Learn more about updating PHP" strings. 
Props ramiy.
Fixes #46912.
Built from https://develop.svn.wordpress.org/trunk@45192


git-svn-id: http://core.svn.wordpress.org/trunk@45001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 17:59:52 +00:00
Dominik Schilling
ae779fc980 Docs: Add missing @since tag for [45031]. 
Props dimadin.
See #46667.
Built from https://develop.svn.wordpress.org/trunk@45191


git-svn-id: http://core.svn.wordpress.org/trunk@45000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 14:17:55 +00:00
Sergey Biryukov
b6471e9be4 Bootstrap/Load: Remove duplicate leading slashes on inclusion of various files under ABSPATH. 
Props dmsnell, birgire, szepe.viktor.
Fixes #46327.
Built from https://develop.svn.wordpress.org/trunk@45190


git-svn-id: http://core.svn.wordpress.org/trunk@44999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 04:46:52 +00:00
Sergey Biryukov
b2a9bb4e78 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-controls.css. 
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46494. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45189


git-svn-id: http://core.svn.wordpress.org/trunk@44998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 04:36:51 +00:00
Sergey Biryukov
77ff117d7f CSS Coding Standards: Use unitless values for line-height in wp-admin/css/themes.css. 
Props ianbelanger, mukesh27, audrasjb, pbiron, afercia.
Fixes #46518. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45188


git-svn-id: http://core.svn.wordpress.org/trunk@44997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 04:32:51 +00:00
Sergey Biryukov
5fe5733f38 CSS Coding Standards: Use unitless values for line-height for count bubbles in wp-admin/css/admin-menu.css. 
Missed in [45186].

Props ianbelanger.
See #46489, #44643.
Built from https://develop.svn.wordpress.org/trunk@45187


git-svn-id: http://core.svn.wordpress.org/trunk@44996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 04:20:50 +00:00
Sergey Biryukov
b76772b9a7 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/admin-menu.css. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46489. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45186


git-svn-id: http://core.svn.wordpress.org/trunk@44995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-13 00:17:50 +00:00
Sergey Biryukov
88fdfae793 Plugins: Introduce is_wp_version_compatible() and is_php_version_compatible() for checking compatibility with the current WordPress or PHP version. 
Props afragen.
Fixes #46599.
Built from https://develop.svn.wordpress.org/trunk@45185


git-svn-id: http://core.svn.wordpress.org/trunk@44994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 23:56:52 +00:00
Sergey Biryukov
a2e273944a Plugins: In list_plugin_updates(), only display the annotation and the surrounding tags if it's not empty. 
Props afragen.
Fixes #46680.
Built from https://develop.svn.wordpress.org/trunk@45184


git-svn-id: http://core.svn.wordpress.org/trunk@44993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 21:52:52 +00:00
desrosj
b9c927411a Post WordPress 5.2 Beta 3 version bump. 
Built from https://develop.svn.wordpress.org/trunk@45183


git-svn-id: http://core.svn.wordpress.org/trunk@44992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 21:27:53 +00:00
desrosj
1845aeb2c8 WordPress 5.2 Beta 3. 
Built from https://develop.svn.wordpress.org/trunk@45182


git-svn-id: http://core.svn.wordpress.org/trunk@44991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 21:06:51 +00:00
Sergey Biryukov
65da064055 Bootstrap/Load: Finalize recovery mode email language. 
Props TimothyBlynJacobs, miss_jwo, desrosj.
Fixes #46898.
Built from https://develop.svn.wordpress.org/trunk@45181


git-svn-id: http://core.svn.wordpress.org/trunk@44990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 20:49:51 +00:00
aduth
41022dc6f2 Privacy: Remove unnecessary translation from help notice action label. 
As static markup, the Privacy Policy editor help notice link no longer needs to be translateable with the revisions included in [45174].

Props garrett-eclipse.
Fixes #46098. See [45174].

Built from https://develop.svn.wordpress.org/trunk@45180


git-svn-id: http://core.svn.wordpress.org/trunk@44989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 20:44:52 +00:00
Sergey Biryukov
7e4b4e1089 Site Health: Use _n() for %s Items with no issues detected string, missed in [45178]. 
See #46683.
Built from https://develop.svn.wordpress.org/trunk@45179


git-svn-id: http://core.svn.wordpress.org/trunk@44988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 20:40:51 +00:00
Sergey Biryukov
1ae11820fc Site Health: i18n audit, take 2. 
* Use `wp.i18n` to translate JavaScript strings.
* Use `_n()` for proper plural forms support.

Props TimothyBlynJacobs, ocean90, afercia.
Fixes #46683.
Built from https://develop.svn.wordpress.org/trunk@45178


git-svn-id: http://core.svn.wordpress.org/trunk@44987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 20:34:51 +00:00
Joe McGill
1b35ea6978 Media: Fix deletion of files when using stream wrappers. 
This fixes a bug introduced in [43392] which breaks file deletion on systems using stream wrappers, due to limitations of `realpath()`.

Props antonypuckey, pfiled.
Fixes #44563.

Built from https://develop.svn.wordpress.org/trunk@45177


git-svn-id: http://core.svn.wordpress.org/trunk@44986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 20:01:52 +00:00
Andrew Ozz
30ccfd540f Site health: Load the "Info" tab immediately and notify the user while gathering site data. Changes the Info tab to work similarly to the Status tab: it does separate request to fetch the directories sizes and doesn't "block" the loading of the page. 
Props xkon, afercia, Clorith, azaozz.
See #46707.
Built from https://develop.svn.wordpress.org/trunk@45176


git-svn-id: http://core.svn.wordpress.org/trunk@44985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 19:24:51 +00:00
desrosj
105277f93e Administration: Move “Recovery Mode” to the beginning of the document title. 
This improves accessibility, ensuring users utilizing screen readers are informed that the site is in recovery mode.

Props: afercia, TimothyBlynJacobs.
See #46608.
Built from https://develop.svn.wordpress.org/trunk@45175


git-svn-id: http://core.svn.wordpress.org/trunk@44984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 19:05:51 +00:00
aduth
7f456cab7d Privacy: Display help notice on block editor screen. 
Use the Notices data module when viewing the block editor screen for the assigned Privacy Policy page to display a help notice.

Props garrett-eclipse, joen, xkon.
Fixes #46098.

Built from https://develop.svn.wordpress.org/trunk@45174


git-svn-id: http://core.svn.wordpress.org/trunk@44983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 18:19:51 +00:00
desrosj
79f8d9786d Text Changes: Use simpler language for login detail email subjects. 
Props: peterwilsoncc, desrosj.
Fixes #37940.
Built from https://develop.svn.wordpress.org/trunk@45173


git-svn-id: http://core.svn.wordpress.org/trunk@44982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 18:16:52 +00:00
Andrew Ozz
77e87830ae TinyMCE: Fix keyboard navigation when the dfw button is present but hidden. Ensure that button is added last in the DOM to match where it appears visually. 
Props afercia, azaozz.
Fixes #46640.
Built from https://develop.svn.wordpress.org/trunk@45172


git-svn-id: http://core.svn.wordpress.org/trunk@44981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 18:08:53 +00:00
desrosj
44d977b2af Site Health: Correctly refer to an .htaccess file as hidden. 
The preceding period (`.`) should always be included when referring to an `.htaccess` file.

Props: ianbelanger, garrett-eclipse, subrataemfluence, burhandodhy.
Fixes #46841.
Built from https://develop.svn.wordpress.org/trunk@45171


git-svn-id: http://core.svn.wordpress.org/trunk@44980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 17:50:52 +00:00
desrosj
6afe73667c Site Health: Add missing actions to tests. 
This change adds missing actions for several tests. This ensures that the user is provided with a next step, whenever possible.

Also, change the URL displayed in the WordPress.org communication test description to `api.wordpress.org` for accuracy.

Props: garrett-eclipse, Clorith, vaishalipanchal.
Fixes #46734.
Built from https://develop.svn.wordpress.org/trunk@45170


git-svn-id: http://core.svn.wordpress.org/trunk@44979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 17:40:53 +00:00
desrosj
5bafb4ea2d Site Health: Improve the test badge implementation. 
Label badges for each Site Health test currently display in either red, orange, or green, regardless of if the test passed or failed. This is confusing, as seeing red labels in the “Passed Test” section could alarm users (when really everything is OK and no action is required), and seeing green labels in the “Failed Tests” section would not appropriately encourage the user to take appropriate action.

This change makes several improvements to the label badges:

- Always right align the badges for consistent display.
- Remove background fill for badges. Instead, use a border.
- Use a consistent styling for all tests (passed and failed).
- The text color no longer uses true black (#000000).
- The `.badge.pink` CSS definition has been switched to `.badge.purple`, and the definitions for blue, gray, and green have also been updated to more closely follow the official WordPress color palette.

Props: pbiron, garrett-eclipse, hedgefield, Clorith, xkon, melchoyce, mdwolinski, alexdenning.
Fixes #46623.
Built from https://develop.svn.wordpress.org/trunk@45169


git-svn-id: http://core.svn.wordpress.org/trunk@44978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 17:04:52 +00:00
desrosj
21da589622 Site Health: Ensure Site Health pages are correctly displayed for RTL locales. 
Props: ebrahimzadeh, afercia, mohadeseghasemi.
Fixes #46868.
Built from https://develop.svn.wordpress.org/trunk@45168


git-svn-id: http://core.svn.wordpress.org/trunk@44977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 16:39:52 +00:00
desrosj
e04ffc348b Administration: Remove unnecessary numbered placeholders. 
Props: tobifjellner, thrijith.
Fixes #46824.
Built from https://develop.svn.wordpress.org/trunk@45167


git-svn-id: http://core.svn.wordpress.org/trunk@44976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 16:32:50 +00:00
desrosj
501234ebe0 Site Health: Include both site and user locales in debug information. 
Previously, only the site’s locale was displayed in the Site Health debug information. Moving forward, both the site’s default locale and the user’s locale will be specified.

This change also removes the `@param` tag for `WP_Debug_Data::debug_data()`. This parameter was previously removed in [45156].

Props: mukesh27, ianbelanger, Clorith, desrosj.
Fixes #46803.
Built from https://develop.svn.wordpress.org/trunk@45166


git-svn-id: http://core.svn.wordpress.org/trunk@44975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 15:49:52 +00:00
desrosj
8d04086af3 Upgrade/Install: Prevent plugin auto updates if PHP version requirements are not satisfied. 
In [44937] and [44939], changes were made to prevent a user from updating any plugin that requires a higher version of PHP than the site is running. This compliments those changes to also prevent plugins from being auto updated when the same requirements are not met.

Props: TimothyBlynJacobs, davidbaumwald.
Fixes #46613.
Built from https://develop.svn.wordpress.org/trunk@45165


git-svn-id: http://core.svn.wordpress.org/trunk@44974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 14:02:53 +00:00
Mike Schroder
8b0cc1c90f Site Health: Clarify WP_DEBUG warning and translation contexts. 
Clarifies that `WP_DEBUG` can cause `WP_DEBUG_DISPLAY` to be enabled,
and uses the constants themselves in related translation contexts.

Props mukesh27, ocean90, clorith, SergeyBiryukov, mikeschroder.
Fixes #46877.
Built from https://develop.svn.wordpress.org/trunk@45164


git-svn-id: http://core.svn.wordpress.org/trunk@44973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-12 02:27:51 +00:00
Sergey Biryukov
3ab2803af2 Docs: Add missing @since tags for wp_targeted_link_rel() and wp_targeted_link_rel_callback(). 
See #43187, #46543.
Built from https://develop.svn.wordpress.org/trunk@45163


git-svn-id: http://core.svn.wordpress.org/trunk@44972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-11 21:16:51 +00:00
Sergey Biryukov
b3057080e8 Networks and Sites: Use numbered placeholder in a mailto: link in ms_site_check(). 
Props diddledan.
Fixes #46849.
Built from https://develop.svn.wordpress.org/trunk@45162


git-svn-id: http://core.svn.wordpress.org/trunk@44971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-11 20:15:52 +00:00
Sergey Biryukov
ed4f394b67 Docs: Correct type for WP_Object_Cache::$blog_prefix. 
Props diddledan.
Fixes #46851.
Built from https://develop.svn.wordpress.org/trunk@45161


git-svn-id: http://core.svn.wordpress.org/trunk@44970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-11 20:10:53 +00:00
John Blackbourn
15684a84db Build/Test tools: Add some docs to the test functions. 
Props andizer

Fixes #46501

Built from https://develop.svn.wordpress.org/trunk@45160


git-svn-id: http://core.svn.wordpress.org/trunk@44969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-11 17:30:52 +00:00
John Blackbourn
17bdafca77 General: Fix a typo in the docs for _restore_wpautop_hook(). 
Props manzoorwani.jk

Fixes #46864

Built from https://develop.svn.wordpress.org/trunk@45159


git-svn-id: http://core.svn.wordpress.org/trunk@44968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-11 17:27:52 +00:00
Andrea Fercia
2887cea50f Accessibility: Improve the image "Alternative Text" field in the Edit Media screen. 
Brings parity with the changes for the Media Views introduced in [44900].
- moves the alt text field to the top as first field
- adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
- adds `aria-describedby` to target the explanatory text
- adjusts the CSS and indentation

Props chetan200891.
Fixes #46875.

Built from https://develop.svn.wordpress.org/trunk@45158


git-svn-id: http://core.svn.wordpress.org/trunk@44967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-10 20:00:50 +00:00
Andrea Fercia
f27917373c Login and Registration: improve the CSS padding on the login input fields. 
The right padding added in [44895] needs to be set only on the input fields in the Reset Password screen and exclude other login screens.

Amends [44895].
Fixes #42853.

Built from https://develop.svn.wordpress.org/trunk@45157


git-svn-id: http://core.svn.wordpress.org/trunk@44966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-10 16:12:51 +00:00
Andrew Ozz
8ffebab3e6 Site health: Fix gathering the site data twice on non-English locales. Introduces two sets of data: 
- More verbose set used to generate the admin page.
- More concise set that is copied when clicking the "Copy the site info" button intended mostly for support and developers.

Props xkon, azaozz.
Fixes #46726.
Built from https://develop.svn.wordpress.org/trunk@45156


git-svn-id: http://core.svn.wordpress.org/trunk@44965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-10 05:07:51 +00:00
desrosj
447b956bb8 Site Health: Add missing i18n for “Copied!” string. 
Props: Soean, mukesh27, davidbaumwald.
Fixes #46847.
Built from https://develop.svn.wordpress.org/trunk@45155


git-svn-id: http://core.svn.wordpress.org/trunk@44964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 15:24:53 +00:00
desrosj
dd0785d3f9 Privacy: Pass admin URLs for data export and erase forms through esc_url(). 
Introduced in [45149].

Props: birgire.
Fixes #44047.
Built from https://develop.svn.wordpress.org/trunk@45154


git-svn-id: http://core.svn.wordpress.org/trunk@44963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 14:07:51 +00:00
Gary Pendergast
33c82208a2 Media: Remove an extra verb context missed in [45147]. 
Props garrett-eclipse.
See #44675.


Built from https://develop.svn.wordpress.org/trunk@45153


git-svn-id: http://core.svn.wordpress.org/trunk@44962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 03:59:51 +00:00
Gary Pendergast
af86d95778 Post WordPress 5.2 Beta version bump 
Built from https://develop.svn.wordpress.org/trunk@45152


git-svn-id: http://core.svn.wordpress.org/trunk@44961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 01:23:51 +00:00
Gary Pendergast
02d97f51c1 WordPress 5.2 Beta 2 
Built from https://develop.svn.wordpress.org/trunk@45151


git-svn-id: http://core.svn.wordpress.org/trunk@44960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 01:12:51 +00:00
Gary Pendergast
ed8723fd8f UI: Remove vertical alignment from active primary buttons. 
This caused the post-plugin installation actions to jump around when the "Activate Plugin" primary button became active.

Props seedsca, pratikthink, ianbelanger, mukesh27.
Fixes #44836.


Built from https://develop.svn.wordpress.org/trunk@45150


git-svn-id: http://core.svn.wordpress.org/trunk@44959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 00:16:53 +00:00
Gary Pendergast
d6c90ca7d7 Privacy: Add a missing <form> action on the Export/Erasure screens. 
This lack of action could cause an expired nonce to end up in the URL.

Props garrett-eclipse, saimonh, xkon.
Fixes #44047.


Built from https://develop.svn.wordpress.org/trunk@45149


git-svn-id: http://core.svn.wordpress.org/trunk@44958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 00:08:54 +00:00
Gary Pendergast
cbc0240cd6 Privacy: Only mark a personal data export as complete when the user downloads it. 
An admin may download an export to check that it's all correct, but this action shouldn't mark the request as complete.

Props garrett-eclipse, JoshuaWold, birgire.
Fixes #44644.


Built from https://develop.svn.wordpress.org/trunk@45148


git-svn-id: http://core.svn.wordpress.org/trunk@44957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-09 00:04:50 +00:00
Gary Pendergast
4b1ff1c298 Media: Update the media bulk action labels for consistency. 
Props ianbelanger, garrett-eclipse, afercia, Presskopp.
Fixes #44675.


Built from https://develop.svn.wordpress.org/trunk@45147


git-svn-id: http://core.svn.wordpress.org/trunk@44956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:54:52 +00:00
Gary Pendergast
9292802d92 Twenty Seventeeen: Fix MediaElement control hover colours in the customiser. 
When selecting custom colour schemes in the customiser, the hover colour is incorrectly applied to MediaElement controls.

Props xkon, ianbelanger.
Fixes #40843.


Built from https://develop.svn.wordpress.org/trunk@45146


git-svn-id: http://core.svn.wordpress.org/trunk@44955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:38:51 +00:00
Gary Pendergast
5b8db48734 Site Health: Remove animated ellipsis from the status loading indicator. 
This animation wasn't particularly reliable across browsers.

Props Clorith, afercia.
Fixes #46684.


Built from https://develop.svn.wordpress.org/trunk@45145


git-svn-id: http://core.svn.wordpress.org/trunk@44954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:29:51 +00:00
Gary Pendergast
8c8c1f8984 Widgets: Add rel="noopener noreferrer" to links with target="_blank" in the Image widget. 
Props audrasjb, welcher, afercia.
Fixes #43280.


Built from https://develop.svn.wordpress.org/trunk@45144


git-svn-id: http://core.svn.wordpress.org/trunk@44953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:23:51 +00:00
Gary Pendergast
822e8b1a95 Widgets: Add rel="noopener noreferrer" to links with target="_blank" in the Text and HTML widgets. 
Props audrasjb, birgire, mukesh27.
Fixes #46421.


Built from https://develop.svn.wordpress.org/trunk@45143


git-svn-id: http://core.svn.wordpress.org/trunk@44952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:18:52 +00:00
Gary Pendergast
f584cc2f67 Privacy: Remove the privacy changes bubble. 
This notification was a little too intrustive, and suffered from being difficult to dismiss.

Props garrett-eclipse, xkon, ianbelanger.
Fixes #46819.


Built from https://develop.svn.wordpress.org/trunk@45142


git-svn-id: http://core.svn.wordpress.org/trunk@44951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:12:51 +00:00
Gary Pendergast
a932e9921b Menus: Add rel="noopener" to target="_blank" links by default in menus. 
This expands upon `rel="noopener"` being previously added to links in the content.

Props audrasjb, welcher.
Fixes #43290.


Built from https://develop.svn.wordpress.org/trunk@45141


git-svn-id: http://core.svn.wordpress.org/trunk@44950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 23:06:52 +00:00
Gary Pendergast
4487551344 Help: Update support forum links. 
There are a lot of places in Core that link to https://wordpress.org/support/ for the support forums, but that's now the URL for HelpHub. The new forums link is https://wordpress.org/support/forums/.

Props jitendrabanjara1991, dilipbheda, mukesh27, ianbelanger.
Fixes #46790.


Built from https://develop.svn.wordpress.org/trunk@45140


git-svn-id: http://core.svn.wordpress.org/trunk@44949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 22:59:56 +00:00
Gary Pendergast
affceae936 Blocks: Allow for nested the_content calls within do_blocks(). 
When `do_blocks()` is run, it sets up some special handling of the `wpautop` filter, as we don't want `wpautop` to run on block content, but we do want it to be available for subsequent runs of `the_content`, which may be happening on non-block content.

As we set this up before rendering dynamic blocks, however, a dynamic block choosing to run `the_content` will cause unintentially structural deficiences in this particular recursive block tower.

Moving this handling to after dynamic blocks are rendered makes our tower lean a little less.

Props aldavigdis, pento.
Fixes #45495.


Built from https://develop.svn.wordpress.org/trunk@45139


git-svn-id: http://core.svn.wordpress.org/trunk@44948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:54:54 +00:00
Gary Pendergast
95df8fa792 Block Editor: Update packages to bring a selection of bugfixes in. 
Props iseulde, kjellr, aduth, 0mirka00, mcsf, nosolosw, gziolo, jasmussen, talldanwp, notnownikki, swissspidy, jorgefilipecosta, noisysocks.
See https://github.com/WordPress/gutenberg/pull/14796.
Fixes #46801.


Built from https://develop.svn.wordpress.org/trunk@45138


git-svn-id: http://core.svn.wordpress.org/trunk@44947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:37:57 +00:00
Gary Pendergast
9a80e2095b Text Changes: Tweak the wording of email notification subjects. 
This change brings more coherence between the subject lines of the various emails WordPress will send.

Props ramiy, pento.
Fixes #37940.

Built from https://develop.svn.wordpress.org/trunk@45137


git-svn-id: http://core.svn.wordpress.org/trunk@44946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:17:51 +00:00
Gary Pendergast
f6128eb7e6 Post Formats: Remove the post format icons from the post list table. 
Props mukesh27, melchoyce, karmatosed, afercia, mapk.
Fixes #46591.

Built from https://develop.svn.wordpress.org/trunk@45136


git-svn-id: http://core.svn.wordpress.org/trunk@44945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 06:04:50 +00:00
Gary Pendergast
cbdffc4a1e HTTP: Add support for the host-only flag to Wp_Http_Cookie. 
Props soulseekah.
Fixes #43231.

Built from https://develop.svn.wordpress.org/trunk@45135


git-svn-id: http://core.svn.wordpress.org/trunk@44944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 05:32:51 +00:00
Gary Pendergast
a125989772 Emoji: Update Twemoji to version 12.0.0. 
Props pento, superpoincare.
Fixes #46404, #46805.

Built from https://develop.svn.wordpress.org/trunk@45134


git-svn-id: http://core.svn.wordpress.org/trunk@44943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 05:22:51 +00:00
Gary Pendergast
625d1694a3 Canonical: Ensure redirect query keys are URL encoded. 
This prevents an infinite redirect loop when a request containing URL-encoded characters triggers `is_404()`.

Props soulseekah, wrwrwr0.
Fixes #43745.

Built from https://develop.svn.wordpress.org/trunk@45133


git-svn-id: http://core.svn.wordpress.org/trunk@44942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-08 01:10:55 +00:00
Sergey Biryukov
965941ab3a Twenty Nineteen: Fix inconsistent tab/space indentation in style files. 
Props iamdmitrymayorov, mukesh27.
Fixes #46821.
Built from https://develop.svn.wordpress.org/trunk@45132


git-svn-id: http://core.svn.wordpress.org/trunk@44941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 06:18:51 +00:00
Sergey Biryukov
78340f315d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/color-picker.css. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46492. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45131


git-svn-id: http://core.svn.wordpress.org/trunk@44940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:54:50 +00:00
Sergey Biryukov
c33b18b721 CSS Coding Standards: Use unitless values for line-height in wp-admin/css/about.css. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45130


git-svn-id: http://core.svn.wordpress.org/trunk@44939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:51:51 +00:00
Sergey Biryukov
7eafd6d81a CSS Coding Standards: Use unitless values for line-height in wp-admin/css/customize-nav-menus.css. 
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46495. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45129


git-svn-id: http://core.svn.wordpress.org/trunk@44938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:49:51 +00:00
Sergey Biryukov
7eecc96e2d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/site-health.css. 
Props mukesh27, ianbelanger, pbiron, afercia.
Fixes #46760. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45128


git-svn-id: http://core.svn.wordpress.org/trunk@44937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:44:50 +00:00
Sergey Biryukov
7639acc7b7 Docs: Fix typo in a comment in editor/dfw.js. 
Props garrett-eclipse, mattnyeus.
Fixes #46485.
Built from https://develop.svn.wordpress.org/trunk@45127


git-svn-id: http://core.svn.wordpress.org/trunk@44936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:39:50 +00:00
Sergey Biryukov
94b3dcc605 Bundled Themes: Link to an updated documentation on post thumbnails on developer.wordpress.org, instead of Codex. 
Props samanehmirrajabi.
Fixes #46823.
Built from https://develop.svn.wordpress.org/trunk@45126


git-svn-id: http://core.svn.wordpress.org/trunk@44935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-07 05:23:51 +00:00
John Blackbourn
9ab303dbdf Bootstrap/Load: Ignore wp-content/fatal-error-handler.php and wp-content/php-error.php from version control. 
See #44458

Built from https://develop.svn.wordpress.org/trunk@45125


git-svn-id: http://core.svn.wordpress.org/trunk@44934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 18:43:51 +00:00
Sergey Biryukov
3215ab96ce Twenty Twelve: Correct linear-gradient direction argument syntax. 
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, joyously, man4toman.
Fixes #46786.
Built from https://develop.svn.wordpress.org/trunk@45124


git-svn-id: http://core.svn.wordpress.org/trunk@44933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:17:50 +00:00
Sergey Biryukov
95d13df56d CSS Coding Standards: Use unitless values for line-height in wp-admin/css/nav-menus.css. 
Props ianbelanger, audrasjb, pbiron, afercia.
Fixes #46516. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45123


git-svn-id: http://core.svn.wordpress.org/trunk@44932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:10:51 +00:00
Sergey Biryukov
5810543816 PHPCS: Fix WPCS violation in [45119]. 
See #46809.
Built from https://develop.svn.wordpress.org/trunk@45122


git-svn-id: http://core.svn.wordpress.org/trunk@44931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:02:52 +00:00
Sergey Biryukov
80e638ad0e Site Health: Update recommendation labels to highlight Performance instead of Security when using a supported and actively maintained version of WordPress, PHP, or MySQL. 
Props Clorith, earnjam.
Fixes #46789.
Built from https://develop.svn.wordpress.org/trunk@45121


git-svn-id: http://core.svn.wordpress.org/trunk@44930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 16:00:51 +00:00
Sergey Biryukov
d36c01909a Site Health: Use a consistent heading and description when referring to Info and Status pages. 
Props chetan200891, afercia.
Fixes #46728.
Built from https://develop.svn.wordpress.org/trunk@45120


git-svn-id: http://core.svn.wordpress.org/trunk@44929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 15:42:52 +00:00
Sergey Biryukov
4d3fb9b22b Site Health: Restore backticks in "Copy to clipboard" functionality, accidentally removed in [45044]. 
The backticks ensure that the data is formatted accordingly on pasting whenever possible.

Props Clorith.
Fixes #46809.
Built from https://develop.svn.wordpress.org/trunk@45119


git-svn-id: http://core.svn.wordpress.org/trunk@44928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 15:36:51 +00:00
Sergey Biryukov
a431028795 Site Health: Display a correct error message for a failing request in wp_version_check() test. 
Props Clorith, axaak.
Fixes #46814.
Built from https://develop.svn.wordpress.org/trunk@45118


git-svn-id: http://core.svn.wordpress.org/trunk@44927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-06 15:28:50 +00:00
Felix Arntz
5754da106b Administration: Improve user experience and clarify when in recovery mode. 
This changeset introduces several changes around usability when recovery mode is active:

* Display a notice in the admin clarifying that the user is in recovery mode.
* Use a highlight color for the admin bar link to exit recovery mode.
* Exit recovery mode automatically when logging out.
* Include a recovery mode indicator in the title tag.

Props aandrewdixon, azaozz, dhanukanuwan, flixos90, henrywright, karmatosed, mapk, melchoyce, spacedmonkey, TimothyBlynJacobs, tinkerbelly.
See #46608.

Built from https://develop.svn.wordpress.org/trunk@45117


git-svn-id: http://core.svn.wordpress.org/trunk@44926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 17:00:52 +00:00
Felix Arntz
52354f3f0b Bootstrap/Load: Do not redefine constants because tests don't like it. 
See #46045.

Built from https://develop.svn.wordpress.org/trunk@45116


git-svn-id: http://core.svn.wordpress.org/trunk@44925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 15:53:50 +00:00
Felix Arntz
5d2c761568 Bootstrap/Load: Remove extension from the list of paused extensions when it is deactivated. 
With this change, fatal errors recorded before a plugin was deactivated or a theme was switched away from do not persist. This ensures that re-enabling it re-checks for fatal errors correctly.

Props aandrewdixon, dhanukanuwan, henrywright.
Fixes #46812.

Built from https://develop.svn.wordpress.org/trunk@45115


git-svn-id: http://core.svn.wordpress.org/trunk@44924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 15:33:52 +00:00
Felix Arntz
6d58109b09 Bootstrap/Load: Ensure WP_Fatal_Error_Handler does not conflict with existing mechanisms treating fatal errors. 
Prior to this change, resuming or activating a plugin or theme that is still broken would result in a redirect loop if in recovery mode. If outside recovery mode, it would cause the error template to be displayed.

Furthermore this applies to breaking a plugin or theme when editing from the backend.

Props aandrewdixon, azaozz, dhanukanuwan, henrywright, ocean90, ohiosierra, PandelisZ, xkon.
Fixes #46045, #46751.

Built from https://develop.svn.wordpress.org/trunk@45114


git-svn-id: http://core.svn.wordpress.org/trunk@44923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 15:20:55 +00:00
Pascal Birchler
ec05cd3168 Site Health: Remove unused $wp_config_path variable. 
Discovered and fixed during WordCamp London 2019 contributor day.

Props m_uysl.
Fixes #46808.

Built from https://develop.svn.wordpress.org/trunk@45113


git-svn-id: http://core.svn.wordpress.org/trunk@44922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 11:09:51 +00:00
tellyworth
23fe2800cc Upgrade/Install: Add more context in signature verify failures. 
This includes version numbers and signature counts in error reports, to help diagnose isolated failures that have no apparent cause.

Props dd32.
See #39309.

Built from https://develop.svn.wordpress.org/trunk@45112


git-svn-id: http://core.svn.wordpress.org/trunk@44921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-05 05:20:51 +00:00
Andrew Ozz
4601e178e5 Site health: fix usage of max_execution_time. When PHP is run from the cli the default is 0. 
Fixes #46645.
Built from https://develop.svn.wordpress.org/trunk@45111


git-svn-id: http://core.svn.wordpress.org/trunk@44920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-04 21:54:53 +00:00
desrosj
adbaba7d56 Site Health: Ensure the user locale is listed in debug information. 
This change switches to using `get_user_locale()` when adding the language to the Site Health debug information to ensure the user’s locale preference is reflected.

Also, `function_exists()` checks for `switch_to_locale()` and `restore_previous_locale()` were required in the plugin to support older versions of WordPress, but they are not required in core/

Props: Clorith, desrosj.
Fixes #46694.
Built from https://develop.svn.wordpress.org/trunk@45110


git-svn-id: http://core.svn.wordpress.org/trunk@44919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-04 21:24:52 +00:00
desrosj
fc2c675582 Twenty Eleven: Correct linear-gradient direction argument syntax. 
In CSS, the `linear-gradient` function requires that the direction value explicitly use `to` instead of an implicit `from`.

Props: ianbelanger, Malae, man4toman.
Fixes #46770.
Built from https://develop.svn.wordpress.org/trunk@45109


git-svn-id: http://core.svn.wordpress.org/trunk@44918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-04 18:26:52 +00:00
Sergey Biryukov
4ee7d453fa Site Health: Use wp_get_upload_dir() instead of wp_upload_dir(), remove duplicate call. 
Props m_uysl.
Fixes #46729.
Built from https://develop.svn.wordpress.org/trunk@45108


git-svn-id: http://core.svn.wordpress.org/trunk@44917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 11:20:51 +00:00
Sergey Biryukov
991eb4258d Site Health: Use correct property for database-related messages. 
Props mukesh27, birgire.
Fixes #46783.
Built from https://develop.svn.wordpress.org/trunk@45107


git-svn-id: http://core.svn.wordpress.org/trunk@44916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 11:01:53 +00:00
Sergey Biryukov
ef948cbfd6 PHPCS: Fix WPCS violations in [45104]. 
See #46645.
Built from https://develop.svn.wordpress.org/trunk@45106


git-svn-id: http://core.svn.wordpress.org/trunk@44915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 02:14:51 +00:00
Sergey Biryukov
5d0bd0ec47 Site Health: Use a consistent verbiage for the suggestion to remove inactive plugins and themes. 
Props garrett-eclipse, marybaum, Clorith.
Fixes #46735.
Built from https://develop.svn.wordpress.org/trunk@45105


git-svn-id: http://core.svn.wordpress.org/trunk@44914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-03 02:01:51 +00:00
Andrew Ozz
2cdc22aded Site health: 
- Prevent fatal errors from timeouts on the Tools => Site Health => Info tab.
- Use the `get_dirsize()` and `recurse_dirsize()` functions to calculate directory sizes. The results are cached.
- Introduce "timeout protection" in `recurse_dirsize()`.

Props pento, Clorith, xkon, afercia, jeremyfelt, azaozz.
Fixes #46645.
Built from https://develop.svn.wordpress.org/trunk@45104


git-svn-id: http://core.svn.wordpress.org/trunk@44913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 23:33:53 +00:00
Sergey Biryukov
1909df67a7 Docs: Remove an empty line between @param and @return in the tests added in [45101], per documentation coding standards. 
See #45029.
Built from https://develop.svn.wordpress.org/trunk@45103


git-svn-id: http://core.svn.wordpress.org/trunk@44912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:22:50 +00:00
Sergey Biryukov
0c92764023 Site Health: Use an established pattern for numbered placeholders in translator comments in WP_Debug_Data. 
See #46683.
Built from https://develop.svn.wordpress.org/trunk@45102


git-svn-id: http://core.svn.wordpress.org/trunk@44911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:18:52 +00:00
Sergey Biryukov
cbbe38c09c Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses. 
Add unit tests missed in [45100].

Props Toro_Unit, birgire.
See #45029.
Built from https://develop.svn.wordpress.org/trunk@45101


git-svn-id: http://core.svn.wordpress.org/trunk@44910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:15:51 +00:00
Sergey Biryukov
2931a2d95e Widgets: Make sure changes to media widgets' instance schema via widget_{$this->id_base}_instance_schema filter are not overridden by subclasses. 
Previously, `WP_Widget_Media_Audio`, `WP_Widget_Media_Image`, and `WP_Widget_Media_Video` used to override the changes due to reversed arguments in `array_merge()` call.

Props Toro_Unit, birgire.
Fixes #45029.
Built from https://develop.svn.wordpress.org/trunk@45100


git-svn-id: http://core.svn.wordpress.org/trunk@44909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 22:13:52 +00:00
Sergey Biryukov
f7357d3957 Site Health: i18n audit, take 1. 
* Split plural strings with multiple sentences to avoid duplicating translations.
* Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
* Use an established pattern for numbered placeholders in translator comments.
* Replace constants in translatable strings with placeholders, mark them as code.
* Make sure sentences are translated as a whole, not as separate string parts.
* Remove unnecessary context and escaping.

Props ocean90, SergeyBiryukov.
See #46683.
Built from https://develop.svn.wordpress.org/trunk@45099


git-svn-id: http://core.svn.wordpress.org/trunk@44908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 21:32:53 +00:00
Sergey Biryukov
5291f46c8a Docs: Fix typo in a comment in unzip_file(). 
Props mukesh27.
Fixes #46766.
Built from https://develop.svn.wordpress.org/trunk@45098


git-svn-id: http://core.svn.wordpress.org/trunk@44907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 13:34:53 +00:00
desrosj
6d1f493d1d Administration: Remove unnecessary transition-delay values from Dashicons. 
A unitless `0` value for a `<time>` CSS data type was reintroduced in [45040]. This is allowed for `<length>` data types, but is invalid for `<time>`.

See #43195.
Fixes #46774.
Built from https://develop.svn.wordpress.org/trunk@45097


git-svn-id: http://core.svn.wordpress.org/trunk@44906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 13:19:52 +00:00
Sergey Biryukov
45cd565be3 Twenty Fifteen: Fix typo in a comment for print styles. 
Props mukesh27.
Fixes #46767.
Built from https://develop.svn.wordpress.org/trunk@45096


git-svn-id: http://core.svn.wordpress.org/trunk@44905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 13:07:51 +00:00
Sergey Biryukov
474f57e0fa Site Health: Add missing i18n for Security and Performance badge labels. 
Props iworks.
Fixes #46755. See #46683.
Built from https://develop.svn.wordpress.org/trunk@45095


git-svn-id: http://core.svn.wordpress.org/trunk@44904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-02 10:08:56 +00:00
Sergey Biryukov
ccbf084609 Docs: Fix more typos in WP_Site_Health DocBlocks. 
See #46753.
Built from https://develop.svn.wordpress.org/trunk@45094


git-svn-id: http://core.svn.wordpress.org/trunk@44903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 20:30:52 +00:00
Sergey Biryukov
12a2bf946a Docs: Fix typos in WP_Site_Health DocBlocks. 
Props mukesh27.
Fixes #46753.
Built from https://develop.svn.wordpress.org/trunk@45093


git-svn-id: http://core.svn.wordpress.org/trunk@44902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 20:23:50 +00:00
Sergey Biryukov
9c8e9354b1 Docs: Add missing @since tag for WP_Site_Health::get_test_php_extensions(). 
Props mukesh27.
Fixes #46752.
Built from https://develop.svn.wordpress.org/trunk@45092


git-svn-id: http://core.svn.wordpress.org/trunk@44901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 20:17:54 +00:00
Andrea Fercia
83546a04f5 Administration: Site Health: reserve some space for the admin notices. 
Props xkon, Clorith, hedgefield, mapk, karmatosed, afercia.
Fixes #46651.

Built from https://develop.svn.wordpress.org/trunk@45091


git-svn-id: http://core.svn.wordpress.org/trunk@44900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 18:01:52 +00:00
Sergey Biryukov
57a8f51e06 PHPCS: Fix WPCS violation in [45088]. 
See #38168.
Built from https://develop.svn.wordpress.org/trunk@45090


git-svn-id: http://core.svn.wordpress.org/trunk@44899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 16:49:50 +00:00
Sergey Biryukov
130495e1c4 Docs: Correct @param description for remove_theme_support(). 
Add `@return` description for `current_theme_supports()`.

See #46543.
Built from https://develop.svn.wordpress.org/trunk@45089


git-svn-id: http://core.svn.wordpress.org/trunk@44898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 16:21:50 +00:00
Sergey Biryukov
3f3593aa6c Customize: Only add custom-background to body_class() if the current theme supports custom background. 
Props wido, swissspidy, ocean90, Mte90.
Fixes #38168.
Built from https://develop.svn.wordpress.org/trunk@45088


git-svn-id: http://core.svn.wordpress.org/trunk@44897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 16:18:52 +00:00
Andrea Fercia
d8b8994336 Accessibility: Improve the Site Health accordions. 
- removes the definition list and uses the markup from the ARIA Authoring Practices example
- removes incorrect ARIA roles
- avoids ARIA landmark regions proliferation

Props mukesh27 for the initial patch.
Fixes #46714.

Built from https://develop.svn.wordpress.org/trunk@45087


git-svn-id: http://core.svn.wordpress.org/trunk@44896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 15:08:58 +00:00
Sergey Biryukov
95541a86ff Docs: Correct parameter types for the_author(), get_the_author_meta(), and the_author_meta(). 
Props subrataemfluence.
Fixes #45596.
Built from https://develop.svn.wordpress.org/trunk@45086


git-svn-id: http://core.svn.wordpress.org/trunk@44895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 14:23:53 +00:00
Sergey Biryukov
0aedea9470 Docs: Improve documentation for get_plugin_page_hook() and get_plugin_page_hookname(). 
Props subrataemfluence, desrosj.
Fixes #44224.
Built from https://develop.svn.wordpress.org/trunk@45085


git-svn-id: http://core.svn.wordpress.org/trunk@44894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 14:09:52 +00:00
Sergey Biryukov
06d8f376ea PHPCS: Fix WPCS violation in [45082]. 
See #42223.
Built from https://develop.svn.wordpress.org/trunk@45084


git-svn-id: http://core.svn.wordpress.org/trunk@44893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 13:30:52 +00:00
Sergey Biryukov
733ec3da48 Docs: Improve documentation for postbox_classes(). 
Rename `$page` and `$id` variables to `$screen_id` and `$box_id` for clarity.

Props sharifkiberu, DrewAPicture.
Fixes #45179.
Built from https://develop.svn.wordpress.org/trunk@45083


git-svn-id: http://core.svn.wordpress.org/trunk@44892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 12:47:51 +00:00
Sergey Biryukov
2f5b5baa07 I18N: Merge similar strings about allowed space allocation in Multisite. 
Props ramiy, Jonathandejong, pento.
Fixes #42223.
Built from https://develop.svn.wordpress.org/trunk@45082


git-svn-id: http://core.svn.wordpress.org/trunk@44891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 12:24:51 +00:00
Sergey Biryukov
76e6cc67c2 Bundled Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex. 
Props man4toman, andraganescu.
Fixes #46450.
Built from https://develop.svn.wordpress.org/trunk@45081


git-svn-id: http://core.svn.wordpress.org/trunk@44890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 11:56:52 +00:00
Sergey Biryukov
de95fac19c Themes: Link to an updated documentation on child themes on developer.wordpress.org, instead of Codex. 
Props man4toman.
See #46450.
Built from https://develop.svn.wordpress.org/trunk@45080


git-svn-id: http://core.svn.wordpress.org/trunk@44889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 11:55:52 +00:00
Sergey Biryukov
5cca79f806 Site Health: If WP_DEBUG_LOG contains a file path, display it on Site Info tab. 
Props xkon, knutsp, ocean90.
Fixes #46692.
Built from https://develop.svn.wordpress.org/trunk@45079


git-svn-id: http://core.svn.wordpress.org/trunk@44888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 01:26:51 +00:00
Sergey Biryukov
c241c16846 Site Health: Simplify the checks for constants that are always defined by default. 
Props xkon.
Fixes #46738.
Built from https://develop.svn.wordpress.org/trunk@45078


git-svn-id: http://core.svn.wordpress.org/trunk@44887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-01 00:10:53 +00:00
Sergey Biryukov
63d0abd5ff Administration: Fix typo in fatal error email notification. 
Props kraftbj.
Fixes #46722.
Built from https://develop.svn.wordpress.org/trunk@45077


git-svn-id: http://core.svn.wordpress.org/trunk@44886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 18:54:51 +00:00
Andrea Fercia
61628dbd8b Administration: Display a notice in the Site Health pages when JavaScript is off. 
- displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
- keeps the main `h1` visible

Minor clean-ups:
- makes code indentation consistent in `site-health.php` and `site-health-info.php`
- removes a couple of `<div class="wp-clearfix"></div>` as that's not the intended usage of `wp-clearfix` (those divs didn't do anything anyways)

Fixes #46717.

Built from https://develop.svn.wordpress.org/trunk@45076


git-svn-id: http://core.svn.wordpress.org/trunk@44885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 15:38:51 +00:00
Andrea Fercia
2737a54374 Accessibility: Make sure the Site Health layout tables are correctly linearized. 
Adds `role="presentation"` to the `<table>` elements used in the Site Health reports.

Ideally, HTML tables should be used for tabular data. When tables are used for layout purposes, it's important to remove any native semantics so that assistive technologies can correctly announce the table content in a linearized fashion.

Props chetan200891.
Fixes #46725.

Built from https://develop.svn.wordpress.org/trunk@45075


git-svn-id: http://core.svn.wordpress.org/trunk@44884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 14:42:51 +00:00
Andrea Fercia
fdda9ca9dd Coding Standards: Improve the Site Health CSS for small screens. 
Amends #45071.
See #46685.

Built from https://develop.svn.wordpress.org/trunk@45074


git-svn-id: http://core.svn.wordpress.org/trunk@44883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 14:09:51 +00:00
Sergey Biryukov
44602b5ed9 Docs: Fix typos in site_status_tests filter DocBlock. 
Props kraftbj.
Fixes #46727.
Built from https://develop.svn.wordpress.org/trunk@45073


git-svn-id: http://core.svn.wordpress.org/trunk@44882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-30 10:58:52 +00:00
Andrea Fercia
0942dfc6d4 Administration: Improve the CSS for the Site Health pages header. 
Avoids the Site Health pages header layout to break when the Hello Dolly plugin or other floated content is printed out at the top of the page.

Props xkon.
Fixes #46650.

Built from https://develop.svn.wordpress.org/trunk@45072


git-svn-id: http://core.svn.wordpress.org/trunk@44881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 18:55:50 +00:00
Andrea Fercia
2a99454732 Coding Standards: Clean up the Site Health stylesheet. 
- reduces selectors specificity to avoid over-qualified selectors
- removes unused rulesets / properties
- renames some CSS classes

Fixes #46685.

Built from https://develop.svn.wordpress.org/trunk@45071


git-svn-id: http://core.svn.wordpress.org/trunk@44880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 18:44:51 +00:00
Andrea Fercia
d56f81fe45 Accessibility: Make sure the Site Health pages have a unique document title. 
The document `<title>` gives a name to a web document. In the context of the WordPress admin, a unique, meaningful, title is important for various reasons:
- it allows browser's history to store meaningful entries 
- when multiple browser's tabs are open, it allows users to better identify the tab content 
- it's the first thing screen readers announce when navigating to a web page, thus helping users to identify the nature of the page content

Props chetan200891, mukesh27.
Fixes #46699.

Built from https://develop.svn.wordpress.org/trunk@45070


git-svn-id: http://core.svn.wordpress.org/trunk@44879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 18:27:51 +00:00
Andrea Fercia
9f09fcb1c2 Accessibility: Remove arrows navigation from the Site Health accordions. 
Arrows navigation on accordions is an optional keyboard interaction feature mentioned in the WAI-ARIA Authoring Practices. While it can add some value in some specific cases, it's not so discoverable and it's unlikely users, including assistive technologies users, would really "expect" this kind of interaction.

See #46573.
Fixes #46682.

Built from https://develop.svn.wordpress.org/trunk@45069


git-svn-id: http://core.svn.wordpress.org/trunk@44878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 11:27:51 +00:00
Sergey Biryukov
02983a458d Site Health: Add missing <ul> tags for lists on Site Info page. 
Props mukesh27, chetan200891, afercia.
Fixes #46693.
Built from https://develop.svn.wordpress.org/trunk@45068


git-svn-id: http://core.svn.wordpress.org/trunk@44877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 11:14:51 +00:00
Mike Schroder
672372d118 Media: Improve and fix rotate/flip image tests 
Fix off-by-one error in pixel color checks for rotate and flip image tests.
Change to using PNG with single pixel to ensure that errors are caught in the future, rather than lost in JPEG noise.

Props Fuegas, mikeschroder.
Fixes #46073.
Built from https://develop.svn.wordpress.org/trunk@45067


git-svn-id: http://core.svn.wordpress.org/trunk@44876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 02:49:51 +00:00
Andrew Ozz
7ab495bfed TinyMCE: 
- Fix adding the keyboard shortcuts to all button tooltips in the classic editor and classic block.
- Fix translating the aria labels for all buttons.

Fixes #35710;
Built from https://develop.svn.wordpress.org/trunk@45066


git-svn-id: http://core.svn.wordpress.org/trunk@44875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-29 00:49:51 +00:00
John Blackbourn
5a481ea118 Options, Meta APIs: Remove an accidental short array syntax in the tests. 
See #43561

Built from https://develop.svn.wordpress.org/trunk@45065


git-svn-id: http://core.svn.wordpress.org/trunk@44874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 22:03:52 +00:00
John Blackbourn
8f5d82df7b Options, Meta APIs: Ensure the $object_id parameter passed to the delete_{$meta_type}_meta and deleted_{$meta_type}_meta filters is always an integer. 
Props salcode

Fixes #43561

Built from https://develop.svn.wordpress.org/trunk@45064


git-svn-id: http://core.svn.wordpress.org/trunk@44873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:59:52 +00:00
Sergey Biryukov
2bb2af2731 PHPCS: Fix WPCS violations in [45062]. 
See #46056.
Built from https://develop.svn.wordpress.org/trunk@45063


git-svn-id: http://core.svn.wordpress.org/trunk@44872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:57:51 +00:00
Sergey Biryukov
10409c0f7c Privacy: Ensure the personal data export email is sent in the locale of the user whose data is being exported (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale. 
Props garrett-eclipse.
Fixes #46056.
Built from https://develop.svn.wordpress.org/trunk@45062


git-svn-id: http://core.svn.wordpress.org/trunk@44871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:29:50 +00:00
John Blackbourn
437285dba4 Embeds: Update the Crowdsignal embed handler so that surveys on subdomains are supported. 
Props kraftbj

Fixes #46467

Built from https://develop.svn.wordpress.org/trunk@45061


git-svn-id: http://core.svn.wordpress.org/trunk@44870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:27:51 +00:00
Sergey Biryukov
459aef1fa5 Build/Test Tools: Exclude twentynineteen/node_modules from jsvalidate:build task. 
Fixes #46706.
Built from https://develop.svn.wordpress.org/trunk@45060


git-svn-id: http://core.svn.wordpress.org/trunk@44869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:17:52 +00:00
John Blackbourn
94e4da6aec Themes: Introduce a generic action that's fired when a template part is loaded. 
This action allows debugging mechanisms to perform greater introspection into which template parts are loaded for any given request. It also exposes the array of candidate template part file names for each template part instance.

Props pcfreak30, jdeeburke

Fixes #41575

Built from https://develop.svn.wordpress.org/trunk@45059


git-svn-id: http://core.svn.wordpress.org/trunk@44868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:13:54 +00:00
Aaron Jorbin
9ca5ec97b1 PHP: Finish updating PHP Minimum version 
Previous [44982] and [44950].

This bumps the minimum version down slightly based on some research into the usage of php 5.6. This also brings the recommended version in line with https://wordpress.org/about/requirements/ . 

The travis matrix is also being reduced in order to speed up builds. This is a hard break. PHP 5.2 - 5.5 we are never ever, ever, getting back together. You go talk to your friends, talk to my friends, talk to me, But we are never ever, ever, ever getting back together.

Props DD32, afergen for research.
Fixes #46594.


Built from https://develop.svn.wordpress.org/trunk@45058


git-svn-id: http://core.svn.wordpress.org/trunk@44867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 21:12:52 +00:00
Sergey Biryukov
9ebc5e85fd Twenty Nineteen: Update Theme URI to point to the Theme Directory instead of the archived GitHub repository. 
Update `style.scss` and `style-rtl.css`, missed in [45032].

Props dimadin.
See #46668.
Built from https://develop.svn.wordpress.org/trunk@45057


git-svn-id: http://core.svn.wordpress.org/trunk@44866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 20:58:51 +00:00
Sergey Biryukov
4e4e8fa110 Bootstrap/Load: Ensure the fatal error handler is registered after WP_CONTENT_DIR is defined, so the custom error handler drop-in could be properly loaded. 
Props sebastian.pisula, diddledan.
Fixes #46069.
Built from https://develop.svn.wordpress.org/trunk@45056


git-svn-id: http://core.svn.wordpress.org/trunk@44865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 19:04:51 +00:00
Sergey Biryukov
a2577854e6 Site Health: Declare ClipboardJS global to fix JSHint issue. 
See #46647.
Built from https://develop.svn.wordpress.org/trunk@45055


git-svn-id: http://core.svn.wordpress.org/trunk@44864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 18:38:51 +00:00
Sergey Biryukov
5cb984d371 Docs: Fix typo in xmlrpc_chunk_parsing_size filter description. 
Props lord_viper.
Fixes #46701.
Built from https://develop.svn.wordpress.org/trunk@45054


git-svn-id: http://core.svn.wordpress.org/trunk@44863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 16:53:51 +00:00
Sergey Biryukov
774ac73a1f CSS Coding Standards: Use unitless values for line-height in wp-admin/css/widgets.css. 
Props ianbelanger, audrasjb.
Fixes #46531. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45053


git-svn-id: http://core.svn.wordpress.org/trunk@44862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 16:39:51 +00:00
Sergey Biryukov
a02494a80f Site Health: Add description for a successful HTTPS check. 
Props Clorith, xkon.
Fixes #46617.
Built from https://develop.svn.wordpress.org/trunk@45052


git-svn-id: http://core.svn.wordpress.org/trunk@44861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 16:15:51 +00:00
Sergey Biryukov
07d5eda632 Twenty Seventeen: Make <th> styling in table block consistent between back end and front end. 
Props ianbelanger.
Fixes #46568.
Built from https://develop.svn.wordpress.org/trunk@45051


git-svn-id: http://core.svn.wordpress.org/trunk@44860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 15:25:50 +00:00
Sergey Biryukov
e2115d62b6 Site Health: Use a consistent wording and response code for capability checks. 
Props mukesh27 for initial patch.
Fixes #46691.
Built from https://develop.svn.wordpress.org/trunk@45050


git-svn-id: http://core.svn.wordpress.org/trunk@44859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 15:11:51 +00:00
Sergey Biryukov
d69165bd3b Site Health: Correct wp_version_check() existence verification by performing a request to the Site Health page instead of Dashboard. 
Props Clorith, audrasjb.
Fixes #46616.
Built from https://develop.svn.wordpress.org/trunk@45049


git-svn-id: http://core.svn.wordpress.org/trunk@44858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-28 14:31:51 +00:00
Gary Pendergast
ffc064d82d Post WordPress 5.2 Beta 1 version bump. 
Built from https://develop.svn.wordpress.org/trunk@45048


git-svn-id: http://core.svn.wordpress.org/trunk@44857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 23:36:52 +00:00
Gary Pendergast
d0445ead0c WordPress 5.2 Beta 1. 
Built from https://develop.svn.wordpress.org/trunk@45047


git-svn-id: http://core.svn.wordpress.org/trunk@44856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 23:20:51 +00:00
Gary Pendergast
0a4d431e11 Upgrades: Allow upgrades to proceed when a soft failure occurs on package signatures. 
In particular, this allows downgrading from WordPress 5.2 to 5.1.1, if sites wish to opt out of the beta.

Props dd32.
See #46615.


Built from https://develop.svn.wordpress.org/trunk@45046


git-svn-id: http://core.svn.wordpress.org/trunk@44855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 23:05:54 +00:00
Sergey Biryukov
d5f198676b Plugins: In wp_update_php_annotation(), only display the annotation and the surrounding tags if it's not empty. 
Props afragen.
Fixes #46678.
Built from https://develop.svn.wordpress.org/trunk@45045


git-svn-id: http://core.svn.wordpress.org/trunk@44854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 22:37:51 +00:00
Gary Pendergast
65f7cdbce0 Site Health: Improve the "Copy to clipboard" button. 
The previous method for copying the debug report to the clipboard involved having a hidden `<textarea>`, but this shows up in screen readers and can't be reliably hidden.

To work around this, the button now uses the `clipboard.js` library, which automatically handles browser differences in the Clipboard API, and can load the text to copy from a `data-` attribute on the button.

Props pento, hedgefield, afercia.
Fixes #46647.


Built from https://develop.svn.wordpress.org/trunk@45044


git-svn-id: http://core.svn.wordpress.org/trunk@44853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 22:31:52 +00:00
Sergey Biryukov
179c2ea230 Plugins: Disable "Update Now" button for plugins that require a higher version of PHP or WordPress. 
This complements disabling the "Install Now" button in [43436].

Props afragen.
Fixes #46677. See #43986.
Built from https://develop.svn.wordpress.org/trunk@45043


git-svn-id: http://core.svn.wordpress.org/trunk@44852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 22:11:53 +00:00
Adam Silverstein
418afaa938 Bundled Theme: trigger a new wp_body_open action immediately after the opening body tag. 
* Enables inserting (asynchronous) JavaScript right after the opening `body` tag.
* Add a `wp_body_open` helper function that triggers the `wp_body_open` action.
* Call `wp_body_open` in core themes immediately after the opening `body` tag.

Props joostdevalk, valendesigns, nacin, saracup, jorbin, mikeschinkel, jonnybojangles, lgedeon, Willscrlt, Denis-de-Bernardy, lexiqueen, sky_76, welcher, westonruter, ramiy, joyously.
Fixes #12563.

Built from https://develop.svn.wordpress.org/trunk@45042


git-svn-id: http://core.svn.wordpress.org/trunk@44851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 21:59:52 +00:00
Andrea Fercia
9b15549b1c Accessibility: Simplify the Site Health score indicator. 
The Site Health score indicator isn't exactly a "progress bar" and shouldn't use ARIA roles and properties related to progress bars. Also, some browser / screen reader combinations don't announce the score properly.
- removes any ARIA
- adds a screen-reader-text "Current health score:"
- adds `role="img" aria-hidden="true" focusable="false"` to the SVG
- reduces CSS specificity simplifying unnecessary overqualified selectors
- fixes the syntax for ::after and ::before (double colon)

Fixes #46621.

Built from https://develop.svn.wordpress.org/trunk@45041


git-svn-id: http://core.svn.wordpress.org/trunk@44850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 20:39:51 +00:00
desrosj
f9de2f860d Administration: Fix Dashicon backwards compatibility issues. 
In [44940], the Dashicon files in core were updated to contain the latest version of the font from the GitHub repo. This change follows that up by fixing several backwards compatibility issues caused by the new build process used to generate the font files and fixes the missing menu icon when viewing the admin on small screens.

- `buddicons-bbpress-logo (f12b)` was moved back to the correct location of `f477`.
- `editor-ltr (f129)` was moved back to the correct location of `f10c`.
- `email-alt2 (f10a)` was moved to the correct location of `f467`. 

The following icons were restored to their previous locations:

- `camera-alt (f129)`
- `edit-large (f327)`
- `editor-distractionfree (f211)`
- `update-alt (f113)`
- `twitter-alt (f302)`
- `text-page (f121)`
- `plugins-checked (f485)`
- `menu-alt3 (f349)`
- `menu-alt2 (f329)`
- `menu-alt (f228)`
- Duplicate lock icon at location `f315`
- Duplicate `editor-code` icon at location `f494`
- `arrow-up` at `f143`.

The `editor-ltr` and `editor-rtl` icons had also been switched. The arrows now point in the correct directions at the correct Unicode locations (`f10c` and `f320` respectively).

And, lastly, this change also introduces the `code-standards (f13a)` icon that was not included in the previous build.

Props afercia, earnjam, oztaser, joen, cathibosco1, ianbelanger, desrosj.
See #41074.
Fixes #46611.
Built from https://develop.svn.wordpress.org/trunk@45040


git-svn-id: http://core.svn.wordpress.org/trunk@44849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 19:59:52 +00:00
Sergey Biryukov
b6a145ccb5 Privacy: Ensure the privacy data erase fulfillment email is sent in the locale of the user whose data is being erased (or the site's default locale if they are not a registered user) when the administrator fulfilling the request uses a different locale. 
Props desrosj, birgire, garrett-eclipse.
Fixes #44721.
Built from https://develop.svn.wordpress.org/trunk@45039


git-svn-id: http://core.svn.wordpress.org/trunk@44848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 19:41:53 +00:00
Andrea Fercia
7bedcf0bee Accessibility: Improve the "Alt text" description. 
Moves the word "Describe" within the link.

Amends [44900].
See #41612.

Built from https://develop.svn.wordpress.org/trunk@45038


git-svn-id: http://core.svn.wordpress.org/trunk@44847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 18:47:51 +00:00
John Blackbourn
8190f1f0f8 Docs: Correct the documentation for the oEmbed HTML filtering. 
See #46543

Built from https://develop.svn.wordpress.org/trunk@45037


git-svn-id: http://core.svn.wordpress.org/trunk@44846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 17:14:52 +00:00
John Blackbourn
c155b2a833 Docs: Improve the documentation for metadata related filter parameters. 
See #46543

Built from https://develop.svn.wordpress.org/trunk@45036


git-svn-id: http://core.svn.wordpress.org/trunk@44845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 17:10:53 +00:00
John Blackbourn
9e67ba895d Docs: Correct some documentation typos. 
See #46543

Built from https://develop.svn.wordpress.org/trunk@45035


git-svn-id: http://core.svn.wordpress.org/trunk@44844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 17:09:52 +00:00
Sergey Biryukov
7807324652 Taxonomy: Initialize $noparents variable in wp_ajax_add_tag() to avoid a notice with compact() in PHP 7.3. 
Props pilou69.
Fixes #46670.
Built from https://develop.svn.wordpress.org/trunk@45034


git-svn-id: http://core.svn.wordpress.org/trunk@44843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 15:33:52 +00:00
Sergey Biryukov
06bb67be06 Docs: Correct back-compat reference to $excluded_categories in get_adjacent_post(). 
See #46543, #17673.
Built from https://develop.svn.wordpress.org/trunk@45033


git-svn-id: http://core.svn.wordpress.org/trunk@44842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-27 14:45:51 +00:00