WordPress

mirror of https://github.com/WordPress/WordPress.git synced 2024-11-06 19:01:44 +01:00

Author	SHA1	Message	Date
Sergey Biryukov	897f004a9c	General: Replace older-style PHP type conversion functions with type casts. This improves performance, readability, and consistency throughout core. * `intval()` → `(int)` * `strval()` → `(string)` * `floatval()` → `(float)` Props ayeshrajans. Fixes #42918. Built from https://develop.svn.wordpress.org/trunk@49108 git-svn-id: http://core.svn.wordpress.org/trunk@48870 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-08 21:15:13 +00:00
Sergey Biryukov	aef2b539cd	Docs: Correct `@since` version for `add_allowed_options()`. Follow-up to [48121]. Props coffee2code. Fixes #51450. Built from https://develop.svn.wordpress.org/trunk@49096 git-svn-id: http://core.svn.wordpress.org/trunk@48858 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-06 15:55:05 +00:00
Sergey Biryukov	bea55db921	Docs: Add missing `@return` tag to `Language_Pack_Upgrader::check_package()`. Synchronize documentation of the `::check_package()` method between `Plugin_Upgrader`, `Theme_Upgrader`, and `Language_Pack_Upgrader`. Props ankitmaru, mukesh27, desrosj. Fixes #51448. Built from https://develop.svn.wordpress.org/trunk@49091 git-svn-id: http://core.svn.wordpress.org/trunk@48853 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-05 13:44:11 +00:00
Sergey Biryukov	1651342d2b	Privacy: Improve clarity of privacy error strings. Primarily this adds "user privacy" to the strings for privacy requests, so they are more easily distinguished from other system actions within logs. Props garrett-eclipse, carike, birgire. Fixes #51351. Built from https://develop.svn.wordpress.org/trunk@49090 git-svn-id: http://core.svn.wordpress.org/trunk@48852 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-04 03:23:09 +00:00
Sergey Biryukov	b3b8942dfc	Docs: Correct description for `wp_ajax_update_widget()`. Follow-up to [28355]. Props burhandodhy, sabernhardt. Fixes #44583. Built from https://develop.svn.wordpress.org/trunk@49071 git-svn-id: http://core.svn.wordpress.org/trunk@48833 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-30 09:44:09 +00:00
Sergey Biryukov	2cbcc5d548	Media: Make the "Copy URL" button implementation more consistent with other instances in core: * Make the "Copied!" text green. * Make the button verbiage clear that it's copied "to clipboard". Props garrett-eclipse, mukesh27. Fixes #51355. Built from https://develop.svn.wordpress.org/trunk@49064 git-svn-id: http://core.svn.wordpress.org/trunk@48826 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-27 20:48:05 +00:00
Sergey Biryukov	c298458751	Docs: Add missing `@return` tags for some `WP_Automatic_Updater` methods: * `::is_vcs_checkout()` * `::should_update()` * `::send_core_update_notification_email()` Props ankitmaru, mukesh27. Fixes #51385. Built from https://develop.svn.wordpress.org/trunk@49061 git-svn-id: http://core.svn.wordpress.org/trunk@48823 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-27 08:36:06 +00:00
John Blackbourn	eaf325e386	Upgrade/Install: Introduce the `wp_installed_email` filter for filtering the contents of the email sent when WordPress is installed, without needing to override the `wp_new_blog_notification()` pluggable function. Props Dharm1025, nikolam, johnbillion Fixes #42133 Built from https://develop.svn.wordpress.org/trunk@49048 git-svn-id: http://core.svn.wordpress.org/trunk@48810 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-25 22:33:08 +00:00
desrosj	a16faa6989	Privacy: Ensure bulk action related strings end with periods. Props garrett-eclipse, mukesh27. Fixes #51371. Built from https://develop.svn.wordpress.org/trunk@49035 git-svn-id: http://core.svn.wordpress.org/trunk@48797 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-22 18:40:04 +00:00
John Blackbourn	aef504acfd	Docs: Correct the indentation for some array type docs. See #50768 Built from https://develop.svn.wordpress.org/trunk@49028 git-svn-id: http://core.svn.wordpress.org/trunk@48790 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-21 16:46:06 +00:00
Sergey Biryukov	29c0edfbba	Privacy: Check if the accumulated data in `wp_privacy_process_personal_data_export_page()` is not empty. This avoids an error on PHP 8 caused by passing an empty string to `array_merge()`, instead of an array. See #50913. Built from https://develop.svn.wordpress.org/trunk@49026 git-svn-id: http://core.svn.wordpress.org/trunk@48788 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-21 13:51:03 +00:00
John Blackbourn	aba2165aae	Media: Standardise the description for image size parameters. This brings continuity to all the image related functions and filters which accept or pass a size parameter. Props dilipbheda, johnbillion Fixes #47364 Built from https://develop.svn.wordpress.org/trunk@49021 git-svn-id: http://core.svn.wordpress.org/trunk@48783 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 16:23:07 +00:00
John Blackbourn	0b2e31a7f8	Docs: Inline documentation improvements for media related functions and hooks. See #47364, #50768 Built from https://develop.svn.wordpress.org/trunk@49020 git-svn-id: http://core.svn.wordpress.org/trunk@48782 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 15:55:10 +00:00
John Blackbourn	43b11121de	Media: Correct some types for attachment ID parameters passed to functions and filters. See #47364, #50768 Built from https://develop.svn.wordpress.org/trunk@49017 git-svn-id: http://core.svn.wordpress.org/trunk@48779 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 14:05:05 +00:00
John Blackbourn	123806ff28	Themes: Remove the ability to delete themes from the single site Appearance screen on Multisite installations. This brings theme deletion inline with plugin deletion and theme and plugin editing, which can only be performed from within Network Admin. Props Mista-Flo, williampatton, johnbillion Fixes #41441 Built from https://develop.svn.wordpress.org/trunk@49011 git-svn-id: http://core.svn.wordpress.org/trunk@48773 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 12:03:05 +00:00
Sergey Biryukov	d5b8d282e8	Docs: Update the URL for PHP date formats table in translator comments. Props hareesh-pillai, iandunn. Fixes #51332. Built from https://develop.svn.wordpress.org/trunk@48991 git-svn-id: http://core.svn.wordpress.org/trunk@48753 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-18 10:37:08 +00:00
Sergey Biryukov	282c813259	Coding Standards: Explicitly declare the `$wp_version` global used in some core files. Props jaydeep-rami, sabernhardt. Fixes #44932. Built from https://develop.svn.wordpress.org/trunk@48971 git-svn-id: http://core.svn.wordpress.org/trunk@48733 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-12 00:12:08 +00:00
Sergey Biryukov	f29d62012d	Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-plugin-install-list-table.php`. See #50767. Built from https://develop.svn.wordpress.org/trunk@48970 git-svn-id: http://core.svn.wordpress.org/trunk@48732 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-11 01:05:08 +00:00
Sergey Biryukov	e36c7f0ba0	Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-plugins-list-table.php`. See #50767. Built from https://develop.svn.wordpress.org/trunk@48968 git-svn-id: http://core.svn.wordpress.org/trunk@48730 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-10 14:23:08 +00:00
Sergey Biryukov	7dada5df2f	Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-ms-themes-list-table.php`. See #50767. Built from https://develop.svn.wordpress.org/trunk@48967 git-svn-id: http://core.svn.wordpress.org/trunk@48729 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-10 14:21:09 +00:00
Sergey Biryukov	93b8183327	Media: In `wp_ajax_image_editor()`, check if the `error` property exists before accessing it. This avoids a PHP notice when editing an image. Follow-up to [48375]. Props Mista-Flo. Fixes #51251. Built from https://develop.svn.wordpress.org/trunk@48946 git-svn-id: http://core.svn.wordpress.org/trunk@48708 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-05 18:12:08 +00:00
Sergey Biryukov	e05edbcd53	Comments: Rename `WP_Comments_List_Table::comment_status_dropdown()` to `::comment_type_dropdown()`. This better reflects the purpose of the method, which doesn't have anything to do with a comment status. Follow-up to [48521]. Props davidbaumwald, johnbillion, SergeyBiryukov. Fixes #51248. Built from https://develop.svn.wordpress.org/trunk@48943 git-svn-id: http://core.svn.wordpress.org/trunk@48705 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-05 00:33:05 +00:00
John Blackbourn	d0a32c5111	Docs: Various docblock corrections and improvements. See #50768 Built from https://develop.svn.wordpress.org/trunk@48941 git-svn-id: http://core.svn.wordpress.org/trunk@48703 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-04 20:41:07 +00:00
Sergey Biryukov	d4d3e23ad0	Themes: Normalize the installed theme path in `Theme_Installer_Skin::do_overwrite()` before comparing with the uploaded theme. This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows. Follow-up to [48390]. Props bobbingwide, wpamitkumar, mukesh27. Fixes #51182. Built from https://develop.svn.wordpress.org/trunk@48913 git-svn-id: http://core.svn.wordpress.org/trunk@48675 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-31 17:11:04 +00:00
Sergey Biryukov	ee33a7b019	Docs: Add a `@since` note to the `display_post_states` filter to clarify that it is now also applied in the Customizer context. If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used. Follow-up to [47763], [48620]. Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov. Fixes #51081. Built from https://develop.svn.wordpress.org/trunk@48910 git-svn-id: http://core.svn.wordpress.org/trunk@48672 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-31 13:32:04 +00:00
Sergey Biryukov	94555079eb	Docs: Clarify the usage of `null` for `auto_update_{$type}` filter. The value is internally used to detect whether nothing has hooked into this filter. Props audrasjb, pbiron, johnbillion, SergeyBiryukov. Fixes #50848. Built from https://develop.svn.wordpress.org/trunk@48909 git-svn-id: http://core.svn.wordpress.org/trunk@48671 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-31 13:20:07 +00:00
Sergey Biryukov	af523447f4	Media: Make the `is_gd_image()` function available on front end. This avoids a fatal error if a plugin calls image creation or editing functions like `wp_imagecreatetruecolor()` outside of the admin. Follow-up to [48798] Props BackuPs. Fixes #51174. See #50833. Built from https://develop.svn.wordpress.org/trunk@48905 git-svn-id: http://core.svn.wordpress.org/trunk@48667 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-28 16:45:06 +00:00
Sergey Biryukov	71ffaac835	Docs: Correct formatting of the `auto_theme_update_send_email` filter DocBlock. Synchronize description of the `$enabled` parameter with the `auto_plugin_update_send_email` filter. Follow-up to [48889]. See #50768, #50988. Built from https://develop.svn.wordpress.org/trunk@48903 git-svn-id: http://core.svn.wordpress.org/trunk@48665 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-28 02:38:05 +00:00
Sergey Biryukov	308f752596	Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature. Follow-up to [48669], [48688]. Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov. Fixes #51129. Built from https://develop.svn.wordpress.org/trunk@48899 git-svn-id: http://core.svn.wordpress.org/trunk@48661 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-27 22:24:07 +00:00
desrosj	2aba7550c4	Upgrade/Install: Pass details about the specific plugin and theme updates attempted to filters. This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner’s liking. Props audrasjb, Paddy Landau, desrosj. Fixes #50988. Built from https://develop.svn.wordpress.org/trunk@48888 git-svn-id: http://core.svn.wordpress.org/trunk@48650 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-27 19:27:03 +00:00
Sergey Biryukov	604b273c0f	Taxonomy: Make sure `wp_terms_checklist()` and `Walker_Category_Checklist::start_el()` properly handle an array of strings as `selected_cats` or `popular_cats` values. Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results. Add a unit test. Props brianhogg, TimothyBlynJacobs, SergeyBiryukov. Fixes #51137. Built from https://develop.svn.wordpress.org/trunk@48880 git-svn-id: http://core.svn.wordpress.org/trunk@48642 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-27 02:48:06 +00:00
Sergey Biryukov	aa803be1ec	Upgrade/Install: Make the check for empty `home` option in `__get_option()` more resilient. This addresses a regression in [47808], where the `home` check expected an empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns `null` if the option is empty. Props fjarrett. Fixes #51011. Built from https://develop.svn.wordpress.org/trunk@48868 git-svn-id: http://core.svn.wordpress.org/trunk@48630 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-26 16:57:16 +00:00
Sergey Biryukov	9700ca0f55	Quick/Bulk Edit: Revert [48134] to address the bottom "Bulk actions" dropdown not functioning properly on Posts and Users list tables. A better solution for the original issue will be explored in a future release. Props audrasjb, garrett-eclipse, webzunft, Krstarica, chunkysteveo, SergeyBiryukov. Fixes #50882, #50998. See #46872. Built from https://develop.svn.wordpress.org/trunk@48866 git-svn-id: http://core.svn.wordpress.org/trunk@48628 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-26 14:18:04 +00:00
Felix Arntz	5918f7e11d	Taxonomy: Allow for `wp_count_terms( $args )` signature, making passing a taxonomy optional. This brings `wp_count_terms()` in line with other taxonomy functions such as `get_terms()` which technically no longer require a taxonomy. Similar to the previously modified functions, no deprecation warning is triggered when using the legacy signature. Fixes #36399. Built from https://develop.svn.wordpress.org/trunk@48840 git-svn-id: http://core.svn.wordpress.org/trunk@48602 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-21 22:32:06 +00:00
Sergey Biryukov	0c0e39d8bf	Privacy: Avoid a PHP 7.4 notice in `WP_Privacy_Policy_Content::text_change_check()`. When iterating over the items stored in '_wp_suggested_privacy_policy_content` meta value for the Privacy Policy page, make sure the item is an array before accessing its properties. Props treibstoff. Fixes #51084. Built from https://develop.svn.wordpress.org/trunk@48836 git-svn-id: http://core.svn.wordpress.org/trunk@48598 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-21 01:13:05 +00:00
Sergey Biryukov	25b0783629	Docs: Correct references to `WP_Filesystem_Base` methods in various DocBlocks. Props pbiron. Fixes #51087. Built from https://develop.svn.wordpress.org/trunk@48835 git-svn-id: http://core.svn.wordpress.org/trunk@48597 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-21 00:43:05 +00:00
Sergey Biryukov	c66d70f2a5	Comments: Revert unintended changes from [48822]. See #51044. Built from https://develop.svn.wordpress.org/trunk@48823 git-svn-id: http://core.svn.wordpress.org/trunk@48585 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-19 01:59:04 +00:00
Sergey Biryukov	3e16f7510a	Comments: Make sure the comment data passed to the `preprocess_comment` filter includes the `comment_agent` and `comment_author_IP` values. Props zodiac1978, SergeyBiryukov. Fixes #51044. Built from https://develop.svn.wordpress.org/trunk@48822 git-svn-id: http://core.svn.wordpress.org/trunk@48584 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-19 01:57:08 +00:00
Sergey Biryukov	8b3a813e1a	Plugins: Avoid a PHP notice if the `update-supported` key in plugin data is not set. Props sanzeeb3. Fixes #51052. Built from https://develop.svn.wordpress.org/trunk@48820 git-svn-id: http://core.svn.wordpress.org/trunk@48582 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-18 20:38:09 +00:00
Sergey Biryukov	e50ac120a3	Site Health: Ensure that the tests returned by `WP_Site_Health::get_tests()` always have the required array keys: `direct` and `async`. This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter. Props khag7, Ov3rfly, desrosj, Clorith. Fixes #50858. Built from https://develop.svn.wordpress.org/trunk@48808 git-svn-id: http://core.svn.wordpress.org/trunk@48570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-17 02:03:04 +00:00
Sergey Biryukov	d9135ad9d0	Site Health: Add site environment type to the debug information. Follow-up to [47919], [48188], [48372]. Props joostdevalk, Clorith. Fixes #50887. Built from https://develop.svn.wordpress.org/trunk@48802 git-svn-id: http://core.svn.wordpress.org/trunk@48564 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 18:27:04 +00:00
Sergey Biryukov	7cb2ca73a2	Site Health: Rename the `$upload_max_size` variable to `$upload_max_filesize`, for consistency with the PHP setting name. Follow-up to [48535], [48538], [48539], [48544], [48800]. See #50945. Built from https://develop.svn.wordpress.org/trunk@48801 git-svn-id: http://core.svn.wordpress.org/trunk@48563 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 17:54:05 +00:00
Sergey Biryukov	88e668d8e6	Site Health: Only display the warning about the `post_max_size` PHP value when it's lower than `upload_max_filesize`. Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match. Props oakesjosh, jeroenrotty, desrosj, Clorith. Fixes #50945. Built from https://develop.svn.wordpress.org/trunk@48800 git-svn-id: http://core.svn.wordpress.org/trunk@48562 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 17:48:08 +00:00
Sergey Biryukov	54184bf872	Docs: Fix typo in the `$image` parameter description in `is_gd_image()`. Follow-up to [48798]. See #50833. Built from https://develop.svn.wordpress.org/trunk@48799 git-svn-id: http://core.svn.wordpress.org/trunk@48561 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 14:02:03 +00:00
Sergey Biryukov	12c8f0e678	Code Modernization: Introduce `is_gd_image()` to check for PHP 8 `GdImage` object instances. In PHP 8, the GD extension uses `GdImage` objects instead of resources for its underlying data structures. This updates the existing `is_resource()` calls for image resources in core to accomodate for `GdImage` instances as well. Props ayeshrajans, jrf. Fixes #50833. Built from https://develop.svn.wordpress.org/trunk@48798 git-svn-id: http://core.svn.wordpress.org/trunk@48560 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 13:33:09 +00:00
Sergey Biryukov	a5edb2a8a1	Filesystem API: Use correct variable when closing the file handle in `WP_Filesystem_FTPext::get_contents()`. Props gothick@gothick.org.uk. Fixes #51029. Built from https://develop.svn.wordpress.org/trunk@48797 git-svn-id: http://core.svn.wordpress.org/trunk@48559 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-15 20:56:02 +00:00
Sergey Biryukov	440eb31bb7	Site Health: Recognize `define( 'WP_AUTO_UPDATE_CORE', 'minor' )` as an acceptable value. Previously, it was only incidentally recognized as valid due to a loose comparison with `true`. With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case. Follow-up to [47841]. Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov. Fixes #50912. Built from https://develop.svn.wordpress.org/trunk@48792 git-svn-id: http://core.svn.wordpress.org/trunk@48554 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-14 20:39:08 +00:00
Sergey Biryukov	1f85e7484f	Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards. See #50768. Built from https://develop.svn.wordpress.org/trunk@48782 git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-11 00:34:08 +00:00
Sergey Biryukov	5c0361aeb1	Coding Standards: Remove a few more extra brackets from some conditions in `wp-admin/includes/plugin.php`. Follow-up to [48764]. See #50767. Built from https://develop.svn.wordpress.org/trunk@48766 git-svn-id: http://core.svn.wordpress.org/trunk@48528 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-09 01:56:05 +00:00
Sergey Biryukov	004e3f897f	Coding Standards: Fix WPCS issues in `wp-admin/includes/plugin.php`. Includes minor code layout fixes for better readability. Props rnaby for initial patch. See #50767, #43848. Built from https://develop.svn.wordpress.org/trunk@48764 git-svn-id: http://core.svn.wordpress.org/trunk@48526 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-08 21:04:04 +00:00
Sergey Biryukov	f5a4ac614e	Coding Standards: Simplify some parts of `user_can_access_admin_page()` for better readability. Props rnaby, valentinbora, khag7. Fixes #43848. Built from https://develop.svn.wordpress.org/trunk@48762 git-svn-id: http://core.svn.wordpress.org/trunk@48524 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-08 20:24:05 +00:00
Sergey Biryukov	132942b9fa	Docs: Document the return value of `get_settings_errors()` using hash notation. Props stevenlinx, webdevmattcrom, atachibana. Fixes #42786. Built from https://develop.svn.wordpress.org/trunk@48760 git-svn-id: http://core.svn.wordpress.org/trunk@48522 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-08 12:39:06 +00:00
Sergey Biryukov	961f455a00	Comments: Update DB version number used to trigger the upgrade routine for changing the `comment_type` DB field value in comments table. Follow-up to [47597], [47626], [48225], [48227], [48748]. Props desrosj. See #49236. Built from https://develop.svn.wordpress.org/trunk@48751 git-svn-id: http://core.svn.wordpress.org/trunk@48513 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-07 16:32:03 +00:00
Sergey Biryukov	6b5e748dee	Docs: Correct usage of the dynamic `auto_update_{$type}` filter. This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct. Props johnbillion. Fixes #50868. Built from https://develop.svn.wordpress.org/trunk@48750 git-svn-id: http://core.svn.wordpress.org/trunk@48512 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-07 16:14:03 +00:00
Sergey Biryukov	5221a27593	Site Health: Consistently pass an object to the `auto_update_{$type}` filter in Site Health debug data. Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices. Props bpayton, pbiron. Fixes #50852. Built from https://develop.svn.wordpress.org/trunk@48745 git-svn-id: http://core.svn.wordpress.org/trunk@48507 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-07 13:28:05 +00:00
Sergey Biryukov	3a32284b26	Posts, Post Types: Use a consistent wording in messages about a locked post. Props ramiy. Fixes #50859. Built from https://develop.svn.wordpress.org/trunk@48743 git-svn-id: http://core.svn.wordpress.org/trunk@48505 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-06 13:14:08 +00:00
Sergey Biryukov	7e1e4f379a	Site Health: Check if `session_status()` exists before calling it. Props bgermann. Fixes #50862. Built from https://develop.svn.wordpress.org/trunk@48742 git-svn-id: http://core.svn.wordpress.org/trunk@48504 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-06 00:25:07 +00:00
Sergey Biryukov	ee213e333b	Comments: Remove a few more unnecessary instances of `esc_html()` in `WP_Comments_List_Table::comment_status_dropdown()`. Core translations are considered safe, and these labels are not escaped in any other instances. Follow-up to [48521], [48722], [48724]. See #40188, #50815. Built from https://develop.svn.wordpress.org/trunk@48741 git-svn-id: http://core.svn.wordpress.org/trunk@48503 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-05 13:53:06 +00:00
Sergey Biryukov	aaf49752b2	Plugins: Move the "Successfully installed the plugin" string to the correct `Plugin_Upgrader` method. The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`. Props sswebster, nateinaction, SergeyBiryukov. Fixes #50837. Built from https://develop.svn.wordpress.org/trunk@48734 git-svn-id: http://core.svn.wordpress.org/trunk@48496 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 17:54:04 +00:00
whyisjake	b84d7f1fd3	Site Health: Display auto-update properly for plugins that don't support auto-updates. Properly filter `auto_update_plugin` when displaying the table. Fixes #50822. Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48731 git-svn-id: http://core.svn.wordpress.org/trunk@48493 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 17:37:02 +00:00
Sergey Biryukov	315db55458	Comments: Restore the `::has_items()` call in `WP_Comments_List_Table::extra_tablenav()` for now, until unit tests are updated accordingly. Follow-up to [48722]. Fixes #40188. See #50815. Built from https://develop.svn.wordpress.org/trunk@48724 git-svn-id: http://core.svn.wordpress.org/trunk@48486 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 16:26:03 +00:00
Sergey Biryukov	b615c45103	Comments: Use the existing static variable instead of calling `::has_items()` again in `WP_Comments_List_Table::extra_tablenav()`. Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance. Props whyisjake, SergeyBiryukov. Fixes #40188. Built from https://develop.svn.wordpress.org/trunk@48722 git-svn-id: http://core.svn.wordpress.org/trunk@48484 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 15:58:06 +00:00
Sergey Biryukov	e2c8e2fa5a	Administration: Allow `wp_credits()` to accept `$version` and `$locale` parameters. This can be helpful for plugin developers to get credits information for older versions or different locales. Props ramiy. Fixes #35910. Built from https://develop.svn.wordpress.org/trunk@48715 git-svn-id: http://core.svn.wordpress.org/trunk@48477 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-03 12:53:08 +00:00
whyisjake	224fdb27b8	Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled. As certain plugins may not support updates, this count needs to accurately reflect that in the navbar. Fixes 50808. Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@48703 git-svn-id: http://core.svn.wordpress.org/trunk@48465 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-31 17:21:04 +00:00
whyisjake	b4497ef13f	Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons. Fixes #50824. Props dd32, whyisjake, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@48701 git-svn-id: http://core.svn.wordpress.org/trunk@48463 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-31 17:03:05 +00:00
whyisjake	078db63c4b	Upgrade/Install: Pass the plugin file path into the `plugin_auto_update_debug_string` filter. Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot. Fixes #50821. Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48696 git-svn-id: http://core.svn.wordpress.org/trunk@48458 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-30 21:50:02 +00:00
Sergey Biryukov	cf137e7c1b	Comments: Pass the `$which` parameter to the `manage_comments_nav` action. This brings some consistency with the `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions. Props Tkama, wpgurudev. Fixes #50736. Built from https://develop.svn.wordpress.org/trunk@48693 git-svn-id: http://core.svn.wordpress.org/trunk@48455 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-30 13:27:04 +00:00
Sergey Biryukov	72b87b3d74	Themes: Pass correct variable to `is_php_version_compatible()` in `wp_theme_update_row()`. This applies to the Themes screen in Multisite network admin. Follow-up to [48660]. Props pbiron, afragen. Fixes #48507. See #48491. Built from https://develop.svn.wordpress.org/trunk@48689 git-svn-id: http://core.svn.wordpress.org/trunk@48451 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-29 21:08:02 +00:00
whyisjake	e6bfdde581	Upgrade/Install: Only show auto-update for themes that support the feature. Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme. See #50280. Props dd32. Built from https://develop.svn.wordpress.org/trunk@48688 git-svn-id: http://core.svn.wordpress.org/trunk@48450 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-29 20:01:08 +00:00
Sergey Biryukov	d351100eba	Upgrade/Install: Pass correct argument to `clear_destination` in `Theme_Upgrader::install()`. Follow-up to [48390]. Props afragen, sabernhardt. Fixes #9757. Built from https://develop.svn.wordpress.org/trunk@48685 git-svn-id: http://core.svn.wordpress.org/trunk@48447 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-29 13:09:04 +00:00
Sergey Biryukov	c5ef3b7976	Media: Pass the `$rel` parameter to `image_send_to_editor` filter. Props mihdan, pputzer. Fixes #50765. Built from https://develop.svn.wordpress.org/trunk@48684 git-svn-id: http://core.svn.wordpress.org/trunk@48446 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 21:21:05 +00:00
whyisjake	d8fd6d05a3	Upgrade/Install: Swap `auto-update-supported` to `update-supported` in update checks. Ensures backwards compatability with external updaters. See #50280. Props everyone-in-the-core-updates-channel. Built from https://develop.svn.wordpress.org/trunk@48678 git-svn-id: http://core.svn.wordpress.org/trunk@48440 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 18:28:06 +00:00
desrosj	6209a40fd9	Upgrade/Install: Clarify the descriptions for `install_(plugin\|theme)_overwrite_actions`. See #9757. Built from https://develop.svn.wordpress.org/trunk@48677 git-svn-id: http://core.svn.wordpress.org/trunk@48439 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 18:16:07 +00:00
desrosj	1aa48c68f5	Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes. See #9757. Built from https://develop.svn.wordpress.org/trunk@48676 git-svn-id: http://core.svn.wordpress.org/trunk@48438 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 17:56:04 +00:00
Sergey Biryukov	e4b2ad02b6	Administration: Don't override the `$mode` global in `WP_Screen::render_view_mode()` if it's already set. Follow-up to [48398], [48423], [48424], [48450]. See #49715. Built from https://develop.svn.wordpress.org/trunk@48670 git-svn-id: http://core.svn.wordpress.org/trunk@48432 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:55:04 +00:00
whyisjake	0f1f9bdb03	Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates. This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available. See #50798. Fixes #50280. Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj. Built from https://develop.svn.wordpress.org/trunk@48669 git-svn-id: http://core.svn.wordpress.org/trunk@48431 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:32:01 +00:00
Sergey Biryukov	2bf5b5749f	Administration: Pull the `table_view_mode` filter for now. The extensibility of list table view modes will be explored in a future release. Props audrasjb. See #49715. Built from https://develop.svn.wordpress.org/trunk@48668 git-svn-id: http://core.svn.wordpress.org/trunk@48430 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:19:03 +00:00
Sergey Biryukov	3db534a988	Upgrade/Install: Disable the plugin/theme auto-updates UI if `AUTOMATIC_UPDATER_DISABLED` is defined and set as `true`. Props pbiron, dd32. Fixes #50798. See #50280. Built from https://develop.svn.wordpress.org/trunk@48667 git-svn-id: http://core.svn.wordpress.org/trunk@48429 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:15:03 +00:00
Sergey Biryukov	4cfc383544	Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file. Props mariovalney, desrosj. See #50593. Built from https://develop.svn.wordpress.org/trunk@48666 git-svn-id: http://core.svn.wordpress.org/trunk@48428 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:07:02 +00:00
Sergey Biryukov	0dd2f9f5c5	Docs: Add missing documentation for various upgrade/install class properties and methods. Props ramiy. Fixes #42923. Built from https://develop.svn.wordpress.org/trunk@48661 git-svn-id: http://core.svn.wordpress.org/trunk@48423 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 11:57:03 +00:00
Sergey Biryukov	a745f035ab	Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress. This applies to the Themes screen in Multisite network admin. Props afragen, SergeyBiryukov. Fixes #48507. See #48491. Built from https://develop.svn.wordpress.org/trunk@48660 git-svn-id: http://core.svn.wordpress.org/trunk@48422 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 11:34:04 +00:00
Sergey Biryukov	e349d92b53	Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages. Follow-up to [48652-48654]. See #48491. Built from https://develop.svn.wordpress.org/trunk@48659 git-svn-id: http://core.svn.wordpress.org/trunk@48421 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 11:31:01 +00:00
Mike Schroder	8c3d56919e	Upgrade/Install: Improve `wp_opcache_invalidate()` performance. Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`. Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder. Fixes #50784. Built from https://develop.svn.wordpress.org/trunk@48657 git-svn-id: http://core.svn.wordpress.org/trunk@48419 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 08:09:05 +00:00
whyisjake	26b706e27f	Site Health: Incorrect file path in `require_once`. Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates. Fixes #50793. Props dd32. Built from https://develop.svn.wordpress.org/trunk@48655 git-svn-id: http://core.svn.wordpress.org/trunk@48417 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 02:21:06 +00:00
Sergey Biryukov	0122e035b0	Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress. This applies to the Themes screen and the Customizer theme browser. Props afragen, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@48652 git-svn-id: http://core.svn.wordpress.org/trunk@48414 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 00:09:02 +00:00
Sergey Biryukov	1f89186a3d	Themes: Display a message in Theme Details modal if a theme requires a higher version of PHP or WordPress. Props afragen, desrosj, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@48636 git-svn-id: http://core.svn.wordpress.org/trunk@48398 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 13:12:04 +00:00
Mike Schroder	9ec7f2febd	Docs: Correct `wp_opcache_invalidate_file` filter docs. Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs. See #36455. Built from https://develop.svn.wordpress.org/trunk@48632 git-svn-id: http://core.svn.wordpress.org/trunk@48394 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 09:08:05 +00:00
Sergey Biryukov	d8c62b5647	Posts, Post Types: Move `get_post_states()` back to the admin for now, require the file in `WP_Customize_Nav_Menus::customize_register()` instead. This provides a minor performance improvement by only running the function in contexts where it's needed. Follow-up to [47211], [47213], [47763], [48619]. See #46829, #49374. Built from https://develop.svn.wordpress.org/trunk@48620 git-svn-id: http://core.svn.wordpress.org/trunk@48382 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-26 10:51:06 +00:00
Sergey Biryukov	aab535a576	Posts, Post Types: Make `get_post_states()` available on frontend. This allows special pages to be denoted as such when editing a menu in the Customizer. This applies to the Front Page, Posts Page, and Privacy Policy Page. Follow-up to [47211], [47213], [47763]. Props dlh, whyisjake, SergeyBiryukov. Fixes #46829. See #49374. Built from https://develop.svn.wordpress.org/trunk@48619 git-svn-id: http://core.svn.wordpress.org/trunk@48381 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-26 01:14:06 +00:00
Sergey Biryukov	609acd89ed	I18N: Merge duplicate "List view" and "Grid view" strings. Props ramiy. Fixes #50757. Built from https://develop.svn.wordpress.org/trunk@48618 git-svn-id: http://core.svn.wordpress.org/trunk@48380 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 21:32:05 +00:00
Sergey Biryukov	c40a645510	Docs: Correct `@see` references for privacy hooks: * `wp_privacy_personal_data_export_page` * `wp_privacy_personal_data_erasure_page` Hooks should be single-quoted when referenced. Props pbiron, coffee2code. See #49572, #meta5318. Built from https://develop.svn.wordpress.org/trunk@48616 git-svn-id: http://core.svn.wordpress.org/trunk@48378 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 19:14:03 +00:00
Sergey Biryukov	7d305c8ff9	Docs: Correct `@since` tags for some `WP_List_Table` hooks: * `views_{$this->screen->id}` * `bulk_actions-{$this->screen->id}` * `manage_{$this->screen->id}_sortable_columns` Follow-up to [15491], [15578], [26401]. See #49572. Built from https://develop.svn.wordpress.org/trunk@48615 git-svn-id: http://core.svn.wordpress.org/trunk@48377 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 18:55:03 +00:00
Sergey Biryukov	0ef0a1905b	Docs: Remove outdated statement in `bulk_actions-{$this->screen->id}` filter description. As of WordPress 4.7, developers can register their own bulk actions on list table screens. Follow-up to [17297], [38647]. Props joyously, pbiron. See #49572. Built from https://develop.svn.wordpress.org/trunk@48614 git-svn-id: http://core.svn.wordpress.org/trunk@48376 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 18:13:02 +00:00
Sergey Biryukov	ef382e6aaf	Site Health: Escape the displayed result of the request in REST API availability test. Props siliconforks, gisselfeldt. Fixes #50588. Built from https://develop.svn.wordpress.org/trunk@48608 git-svn-id: http://core.svn.wordpress.org/trunk@48370 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 15:38:06 +00:00
Sergey Biryukov	b6f52721ed	Administration: Use sentence case for "Mark as spam" bulk action links for sites and users, for consistency with comments. Follow-up to [48352]. See #40244. Built from https://develop.svn.wordpress.org/trunk@48595 git-svn-id: http://core.svn.wordpress.org/trunk@48357 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-24 00:27:03 +00:00
Sergey Biryukov	703a978a77	Administration: Capitalize `Trash` consistently in various messages. When used as a noun referring to the "virtual" place, `Trash` should be capitalized. Follow-up to [47233], [48352]. See #45317, #40244. Built from https://develop.svn.wordpress.org/trunk@48594 git-svn-id: http://core.svn.wordpress.org/trunk@48356 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-24 00:21:03 +00:00
John Blackbourn	9bc7d0a776	Docs: Another pass at some inline docs fixes mostly made by PHPCBF. See #49572, #50744 Built from https://develop.svn.wordpress.org/trunk@48590 git-svn-id: http://core.svn.wordpress.org/trunk@48352 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 21:11:05 +00:00
Sergey Biryukov	3f04e3bf5c	I18N: Further adjust some update/install strings for consistency. Follow-up to [48568], [48569]. See #50708, #50714. Built from https://develop.svn.wordpress.org/trunk@48589 git-svn-id: http://core.svn.wordpress.org/trunk@48351 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 21:08:01 +00:00
Sergey Biryukov	5950e15042	I18N: Merge two "Return to top" strings. Props ramiy, carike, whyisjake. Fixes #50743. Built from https://develop.svn.wordpress.org/trunk@48588 git-svn-id: http://core.svn.wordpress.org/trunk@48350 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 20:21:07 +00:00
Sergey Biryukov	161821d155	Site Health: Correct the quotes for the `tested` value of mock plugin data in auto-updates test. Follow-up to [48584]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48587 git-svn-id: http://core.svn.wordpress.org/trunk@48349 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 20:13:05 +00:00
John Blackbourn	57a3f803ae	Docs: First pass at some inline docs fixes mostly made by PHPCBF. See #49572, #50744 Built from https://develop.svn.wordpress.org/trunk@48586 git-svn-id: http://core.svn.wordpress.org/trunk@48348 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 20:01:04 +00:00
John Blackbourn	7f898dd9c4	Docs: Use more appropriate variable names in the inline docs for action and filter parameters. See #49572 Built from https://develop.svn.wordpress.org/trunk@48585 git-svn-id: http://core.svn.wordpress.org/trunk@48347 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 19:06:03 +00:00
desrosj	231d21ebcd	Site Health: Pass all expected parameters to `auto_update_{$type}`. This prevents fatal errors when other hooked functions are expecting both parameters. Props dd32, desrosj, audrasjb, pbiron. Fixes #50662. Built from https://develop.svn.wordpress.org/trunk@48584 git-svn-id: http://core.svn.wordpress.org/trunk@48346 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 19:03:04 +00:00
Sergey Biryukov	0eb1b2a447	I18N: Update "Default Template" string to match the sentence case used in the block editor. Props ramiy. Fixes #50742. Built from https://develop.svn.wordpress.org/trunk@48583 git-svn-id: http://core.svn.wordpress.org/trunk@48345 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 18:55:01 +00:00
desrosj	2c2508f98c	General: Ensure the database upgrades from [48575] are run. This corrects the database version to match the commit number the upgrade changes were made. See #50413. Built from https://develop.svn.wordpress.org/trunk@48582 git-svn-id: http://core.svn.wordpress.org/trunk@48344 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 18:43:04 +00:00
John Blackbourn	124972f2c6	Docs: Further corrections and improvements to various inline docblocks. See #49572 Built from https://develop.svn.wordpress.org/trunk@48576 git-svn-id: http://core.svn.wordpress.org/trunk@48338 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 07:39:02 +00:00
Aaron Jorbin	6cab8cce22	General: Update code for readability and inclusion There are two pieces in here: 1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks. 2) This improves backwards compatibility for code that was accessing the now deprecated code. Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566] Props: desrosj, SergeyBiryukov, johnjamesjacoby Fixes: #50413 Built from https://develop.svn.wordpress.org/trunk@48575 git-svn-id: http://core.svn.wordpress.org/trunk@48337 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 03:14:06 +00:00
John Blackbourn	0bf9b04c53	Docs: Various formatting improvements to inline docblocks. See #49572 Built from https://develop.svn.wordpress.org/trunk@48574 git-svn-id: http://core.svn.wordpress.org/trunk@48336 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 00:52:05 +00:00
John Blackbourn	1fbcdb2213	Docs: Various corrections to inline docblocks. See #49572 Built from https://develop.svn.wordpress.org/trunk@48573 git-svn-id: http://core.svn.wordpress.org/trunk@48335 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 00:48:06 +00:00
whyisjake	dd642e7b00	i18n: Merge similar translation strings to "Update failed". Fixes #50714. Props ramiy, ocean90. Built from https://develop.svn.wordpress.org/trunk@48569 git-svn-id: http://core.svn.wordpress.org/trunk@48331 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 22:10:02 +00:00
whyisjake	921ddab889	I18N: Merge similar "Installation failed" strings Fixes #50708. Props ramiy, ocean90, audrasjb. Built from https://develop.svn.wordpress.org/trunk@48568 git-svn-id: http://core.svn.wordpress.org/trunk@48330 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 21:59:05 +00:00
desrosj	2cebcb6144	General: Rename `remove_option_allowed_list()` to `remove_allowed_options()`. This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names. See #50413. Built from https://develop.svn.wordpress.org/trunk@48566 git-svn-id: http://core.svn.wordpress.org/trunk@48328 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 18:52:02 +00:00
Sergey Biryukov	1373b2056d	Docs: Correct type for the `$theme` parameter of `theme_auto_update_debug_string` filter. Follow-up to [48546], [48549], [48552]. See #50663. Built from https://develop.svn.wordpress.org/trunk@48561 git-svn-id: http://core.svn.wordpress.org/trunk@48323 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:29:03 +00:00
Sergey Biryukov	88e046f1e8	Site Health: Fix some typos in the test for plugin and theme auto-updates. Follow-up to [48548], [48558], [48559]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48560 git-svn-id: http://core.svn.wordpress.org/trunk@48322 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:17:04 +00:00
Sergey Biryukov	c6034be779	Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates. Follow-up to [48548], [48558]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48559 git-svn-id: http://core.svn.wordpress.org/trunk@48321 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:15:02 +00:00
Sergey Biryukov	93bf0c3b83	Site Health: Add the test for plugin and theme auto-updates to `WP_Site_Health::get_tests()`. This ensures that the test actually runs. Follow-up to [48548]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48558 git-svn-id: http://core.svn.wordpress.org/trunk@48320 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:07:02 +00:00
Sergey Biryukov	a68d462439	Site Health: Use a consistent label for theme auto-updates in debug data. Props audrasjb. Fixes #50728. Built from https://develop.svn.wordpress.org/trunk@48554 git-svn-id: http://core.svn.wordpress.org/trunk@48316 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 21:06:02 +00:00
Sergey Biryukov	94d4561906	Site Health: Simplify the logic for displaying whether auto-updates are enabled for plugins and themes. Remove some extra variables. Follow-up to [48546], [48549]. See #50663. Built from https://develop.svn.wordpress.org/trunk@48552 git-svn-id: http://core.svn.wordpress.org/trunk@48314 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 18:44:04 +00:00
Sergey Biryukov	8a58ab36cc	Site Health: Rename the filters added in [48546] for clarity. See #50663. Built from https://develop.svn.wordpress.org/trunk@48549 git-svn-id: http://core.svn.wordpress.org/trunk@48311 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 17:09:03 +00:00
whyisjake	9d2b92be26	Site Health: Add tests to check for potential issues with plugin and theme auto-updates. Fixes #50662. Props desrosj, audrasjb. Built from https://develop.svn.wordpress.org/trunk@48548 git-svn-id: http://core.svn.wordpress.org/trunk@48310 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 17:07:05 +00:00
whyisjake	32f791da49	Site Health: Add auto-update information to for plugins and themes. New filters: * `plugin_auto_update_debug_str` * `theme_auto_update_debug_str` Fixes #50663. Props pbiron, audrasjb, davidbaumwald. Built from https://develop.svn.wordpress.org/trunk@48546 git-svn-id: http://core.svn.wordpress.org/trunk@48308 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 16:54:02 +00:00
Sergey Biryukov	548df4e3e6	I18N: Add context to some theme strings for consistency. Props ramiy, ocean90. Fixes #50709. Built from https://develop.svn.wordpress.org/trunk@48545 git-svn-id: http://core.svn.wordpress.org/trunk@48307 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 16:33:05 +00:00
Sergey Biryukov	48841f9ab3	Site Health: Rename `upload_max` array key in file upload checks to `max_effective_size` for clarity. Follow-up to [48535]. See #50038. Built from https://develop.svn.wordpress.org/trunk@48544 git-svn-id: http://core.svn.wordpress.org/trunk@48306 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 16:20:03 +00:00
Sergey Biryukov	1c52ad8d3f	Site Health: Move `post_max_size` and `upload_max_filesize` out of a translatable string in file upload checks. Simplify some other strings, use a consistent format for translator comments. Follow-up to [48535]. See #50038. Built from https://develop.svn.wordpress.org/trunk@48539 git-svn-id: http://core.svn.wordpress.org/trunk@48301 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 15:53:04 +00:00
Sergey Biryukov	bec9fa5010	Site Health: Remove `parse_ini_size()`, use the existing `wp_convert_hr_to_bytes()` function instead. Follow-up to [48535]. See #50038. Built from https://develop.svn.wordpress.org/trunk@48538 git-svn-id: http://core.svn.wordpress.org/trunk@48300 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 15:40:03 +00:00
whyisjake	73a8fb4cc3	Site Health: Include new tests to check for the ability to upload files. Several new checks: * `max_file_uploads` * `file_uploads` * `post_max_size` * `upload_max_filesize` * `upload_max` * `max_file_uploads` In addition, new function `parse_ini_size()` that converts shorthand byte strings to bytes. Useful for size comparisons. Fixes #50038. Props dd32, donmhico, JavierCasares, SergeyBiryukov, ayeshrajans, Clorith, ipstenu, sabernhardt, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48535 git-svn-id: http://core.svn.wordpress.org/trunk@48297 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 15:21:02 +00:00
Sergey Biryukov	d1822e81ba	Site Health: Use consistent error messages when switching plugin or theme auto-updates on or off. Props ramiy. Fixes #50721. Built from https://develop.svn.wordpress.org/trunk@48534 git-svn-id: http://core.svn.wordpress.org/trunk@48296 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 14:42:05 +00:00
Sergey Biryukov	9ce7bd633b	Docs: Improve description for `edit_post()`. Props stevenlinx. Fixes #50713. Built from https://develop.svn.wordpress.org/trunk@48529 git-svn-id: http://core.svn.wordpress.org/trunk@48291 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 12:49:03 +00:00
whyisjake	5c836585d1	Comments: Don't show the filter/pagination actions if there are no comments to list. It doesn't make sense to be able to filter the comments list table when there are are no (trashed/spam) comments available. Fixes #40188. Props swissspidy, Jim_Panse, menakas, akbarhusen429, dinhtungdu, birgire, SergeyBiryukov, davidbaumwald, rebasaurus, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48521 git-svn-id: http://core.svn.wordpress.org/trunk@48283 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 00:29:02 +00:00
Sergey Biryukov	e4ce35dd11	I18N: Add context to some plugin and theme strings for consistency. Props ramiy, audrasjb. Fixes #50710. Built from https://develop.svn.wordpress.org/trunk@48520 git-svn-id: http://core.svn.wordpress.org/trunk@48282 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-20 23:14:05 +00:00
Sergey Biryukov	82ce41ff51	I18N: Mark the strings with plugin and theme names in email notifications for translation. Follow-up to [48517]. See #50350. Built from https://develop.svn.wordpress.org/trunk@48519 git-svn-id: http://core.svn.wordpress.org/trunk@48281 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-20 21:25:06 +00:00
desrosj	02f200df1d	Administration: Include the new plugin and theme versions in email notifications. This helps administrators keep track of which versions of plugins and themes are running on their site when auto-updates occur. Props audrasjb, pbiron. Fixes #50350. Built from https://develop.svn.wordpress.org/trunk@48517 git-svn-id: http://core.svn.wordpress.org/trunk@48279 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-20 18:28:03 +00:00
Andrew Ozz	efb77b4a65	Upgrade/install: Fix/clarify the "Upload in a zip format" string. Props greenshady, mariovalney. See #9757. Built from https://develop.svn.wordpress.org/trunk@48509 git-svn-id: http://core.svn.wordpress.org/trunk@48271 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-19 17:11:02 +00:00
John Blackbourn	c3f787b8ff	Docs: Miscellaneous docblock corrections. See #49572 Built from https://develop.svn.wordpress.org/trunk@48508 git-svn-id: http://core.svn.wordpress.org/trunk@48270 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-18 22:11:02 +00:00
whyisjake	da7a54d206	Administration: Fix an index inconsistency in `get_admin_page_title()` function. Ensure that `get_admin_page_title()` returns a value from pages registered using `add_menu_page()`. Fixes #46081. Props grapestain, valentinbora, SergeyBiryukov, audrasjb. Built from https://develop.svn.wordpress.org/trunk@48500 git-svn-id: http://core.svn.wordpress.org/trunk@48262 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-16 22:15:07 +00:00
whyisjake	a53b741359	Coding Standards: Update the docblock to remove superflous `since`. The `@deprecated` DocBlock tag should start with the version followed by the description of what to use instead. Fixes #44959. Props keesiemeijer, sabernhardt. Built from https://develop.svn.wordpress.org/trunk@48495 git-svn-id: http://core.svn.wordpress.org/trunk@48257 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-16 21:12:08 +00:00
Sergey Biryukov	64a4066874	Upgrade/Install: Check if the theme installer skin's `overwrite` property exists in `Theme_Upgrader::install_strings()`. This ensures consistency with `Plugin_Upgrader::install_strings()` and resolves an issue caused by the property not existing in other upgrader implementations. Props schlessera, azaozz. See #50670. Built from https://develop.svn.wordpress.org/trunk@48493 git-svn-id: http://core.svn.wordpress.org/trunk@48255 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-16 13:19:03 +00:00
desrosj	fdd88e24ed	General: Rename the `$new_whitelist_options` global variable. This change renames `$new_whitelist_options` to `$new_allowed_options`. This makes the variable’s purpose more clear, and promotes using more inclusive language. For backwards compatibility, the new variable is passed by reference to the old one. Follow up to [48121]. Props ayeshrajans, desrosj, jorbin, SergeyBiryukov. See #50413. Fixes #50434. Built from https://develop.svn.wordpress.org/trunk@48477 git-svn-id: http://core.svn.wordpress.org/trunk@48246 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-14 12:33:02 +00:00
John Blackbourn	5eb3f0ffcb	Docs: Improve docs for arguments that accept a numerically indexed array of associative arrays. See #49572 Built from https://develop.svn.wordpress.org/trunk@48475 git-svn-id: http://core.svn.wordpress.org/trunk@48244 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-14 12:10:05 +00:00
John Blackbourn	4ff1233e75	Docs: Correct and improve inline docs for parameters that accept a callback function. See #49572 Built from https://develop.svn.wordpress.org/trunk@48473 git-svn-id: http://core.svn.wordpress.org/trunk@48242 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-14 11:56:04 +00:00
John Blackbourn	6b21db7fb9	Docs: Miscellaneous docblock corrections and improvements. See #49572 Built from https://develop.svn.wordpress.org/trunk@48462 git-svn-id: http://core.svn.wordpress.org/trunk@48231 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-13 22:10:07 +00:00
Sergey Biryukov	7c09c153d5	Upgrade/Install: Simplify compatibility checks for uploaded plugins and themes for better readability. Use `$new_plugin_data` and `$new_theme_data` as a shorthand for the corresponding `$this->upgrader` properties. Follow-up to [48390], [48448]. Props afragen. See #9757. Built from https://develop.svn.wordpress.org/trunk@48455 git-svn-id: http://core.svn.wordpress.org/trunk@48224 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-13 13:35:05 +00:00
Andrew Ozz	63a2cb3060	Upgrade/Install: Use `wp_strip_all_tags()` for the fields in the compare table on the "Update theme/plugin from uploaded zip" screen. Some may contain HTML. See #9757. Built from https://develop.svn.wordpress.org/trunk@48453 git-svn-id: http://core.svn.wordpress.org/trunk@48222 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 20:00:03 +00:00
Sergey Biryukov	9848b6b3e9	Plugins: Make delete plugin message less scary. This adds a check if the plugin actually has an uninstall routine before saying that its data will be deleted too. Props samful, joostdevalk, joyously, Chouby, SergeyBiryukov. Fixes #50346. Built from https://develop.svn.wordpress.org/trunk@48451 git-svn-id: http://core.svn.wordpress.org/trunk@48220 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 13:22:04 +00:00
Sergey Biryukov	c4543704e2	Administration: Restore the `excerpt` key for the Extended view mode for backward compatibility for now. Props Offereins. See #49715. Built from https://develop.svn.wordpress.org/trunk@48450 git-svn-id: http://core.svn.wordpress.org/trunk@48219 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 11:36:04 +00:00
Sergey Biryukov	1556ecc000	Docs: Add a `@since` entry for the `$hook_extra` parameter added to `WP_Upgrader::download_package()`. Follow-up to [48399]. See #49686. Built from https://develop.svn.wordpress.org/trunk@48449 git-svn-id: http://core.svn.wordpress.org/trunk@48218 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 11:02:03 +00:00
Sergey Biryukov	707534c2d8	Upgrade/Install: Use `is_php_version_compatible()` and `is_wp_version_compatible()` in plugin and theme requirement checks. Follow-up to [48390]. Props afragen. See #9757. Built from https://develop.svn.wordpress.org/trunk@48448 git-svn-id: http://core.svn.wordpress.org/trunk@48217 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 10:55:03 +00:00
Sergey Biryukov	f83b8775b3	I18N: Move the "WordPress Backups" support URL to its own translatable string. Follow-up to [48390]. See #9757. Built from https://develop.svn.wordpress.org/trunk@48447 git-svn-id: http://core.svn.wordpress.org/trunk@48216 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 10:34:05 +00:00
Sergey Biryukov	3f1650122a	Docs: Miscellaneous DocBlock corrections for plugin and theme updates. See #49572. Built from https://develop.svn.wordpress.org/trunk@48446 git-svn-id: http://core.svn.wordpress.org/trunk@48215 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 01:19:03 +00:00
Sergey Biryukov	cecf7b9823	Administration: Handle the result of `Plugin_Upgrader::bulk_upgrade()` for a plugin that is already at the latest version in the same way it is handled for themes. This corrects a fragile check of the result in `wp_ajax_update_plugin()` that depended on the internal array pointer, and brings some consistency with `wp_ajax_update_theme()`. Follow-up to [37714], [48401]. See #50448. Built from https://develop.svn.wordpress.org/trunk@48445 git-svn-id: http://core.svn.wordpress.org/trunk@48214 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-12 01:16:05 +00:00
Sergey Biryukov	7b61df725e	Revisions: Replace `array_shift()` with `reset()` in `register_and_do_post_meta_boxes()` for better performance. Follow-up to [31829], [48422]. See #34560. Built from https://develop.svn.wordpress.org/trunk@48436 git-svn-id: http://core.svn.wordpress.org/trunk@48205 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-11 12:30:02 +00:00
Sergey Biryukov	51856d435b	Administration: Bring some consistency to handling list table view modes. * Remove duplicate variables and DocBlocks. * Add missing description for the `$mode` global. * Use sentence case for "Compact view" and "Extended view" labels. Follow-up to [48398], [48423]. Props afercia, Offereins, SergeyBiryukov. See #49715. Built from https://develop.svn.wordpress.org/trunk@48424 git-svn-id: http://core.svn.wordpress.org/trunk@48193 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-10 16:04:05 +00:00
Sergey Biryukov	0f92086ca0	Administration: Make some adjustments to `WP_Screen::render_view_mode()`: * Restore the `$mode` global for backward compatibility. * Remove redundant check, as `$mode` is already set at this point, and already defaults to `list` via `get_user_setting()`'s second argument. * Use sentence case for "View mode" and "Extended view" labels. Follow-up to [48398]. See #49715. Built from https://develop.svn.wordpress.org/trunk@48423 git-svn-id: http://core.svn.wordpress.org/trunk@48192 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-10 16:02:05 +00:00
Adam Silverstein	7d0162bc2e	Revisions: optimize performance when post has large number of revisions. Improve speed and reduce the memory footprint when loading posts with many revisions. * Use a direct query in `wp_get_post_autosave` to avoid loading all revisions. * Query for IDs vs full objects in `register_and_do_post_meta_boxes`. Props pdfernhout, johnnyb, miqrogroove, ocean90, senatorman, DBrumbaugh10Up, martijn-van-der-kooij, pavelevap, mackensen, mikeyarce, whyisjake. Fixes #34560. Built from https://develop.svn.wordpress.org/trunk@48422 git-svn-id: http://core.svn.wordpress.org/trunk@48191 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-10 15:13:07 +00:00
Sergey Biryukov	b03053eb2a	Docs: Correct documentation for `customize_controls_head` hook and `_customizer_mobile_viewport_meta()` function. Follow-up to [48412]. See #47369. Built from https://develop.svn.wordpress.org/trunk@48420 git-svn-id: http://core.svn.wordpress.org/trunk@48189 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-10 11:36:07 +00:00
whyisjake	28a390c2b2	Upgrade/Install: Use ARIA button class on plugin and theme auto-updates action links According to the [accesability guidelines](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/#semantics-for-controls), the control should be a link when JavaScript is not available and a button the rest of the time. In addition, handlers were added for spacebar usage, and some changes to the a11y speak verbiage. Fixes #50516. Props ryokuhi, audrasjb, afercia, whyisjake/ Built from https://develop.svn.wordpress.org/trunk@48418 git-svn-id: http://core.svn.wordpress.org/trunk@48187 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-10 06:18:04 +00:00
whyisjake	836ad98276	Upgrade/Install: Ensure cleanup after canceled update. Ensure that the uploaded zip is hidden from the media library, where a task will remove failed installs after two hours. Fixes #50612. Props psykro, desrosj, joyously, azaozz, noisysocks, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48417 git-svn-id: http://core.svn.wordpress.org/trunk@48186 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-10 06:08:06 +00:00
whyisjake	9397ad46ba	Coding Standards: Some missed code formatting. Unprops: whyisjake. Built from https://develop.svn.wordpress.org/trunk@48415 git-svn-id: http://core.svn.wordpress.org/trunk@48184 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-10 01:01:03 +00:00
whyisjake	1158166d9c	Administration: Remove multiple viewport meta tags from mobile pages. In addition, add the `wp_admin_viewport_meta()` function, paired to the `admin_viewport_meta` filter to control attributes of the meta tag. Fixes #47369. Props BettyJJ, mukesh27, SergeyBiryukov, ajayghaghretiya1, msaggiorato, talldanwp, davidbaumwald, donmhico, audrasjb. Built from https://develop.svn.wordpress.org/trunk@48412 git-svn-id: http://core.svn.wordpress.org/trunk@48181 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-09 23:29:08 +00:00
Sergey Biryukov	6bf6bc451f	Docs: Miscellaneous DocBlock corrections. See #49572. Built from https://develop.svn.wordpress.org/trunk@48408 git-svn-id: http://core.svn.wordpress.org/trunk@48177 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-08 13:15:03 +00:00
Sergey Biryukov	c358ba7112	Upgrade/Install: Prevent the upgrade routine for updating the `comment_type` field in the comments table from running twice. Follow-up to [47597], [48400]. See #50413, #49236. Built from https://develop.svn.wordpress.org/trunk@48405 git-svn-id: http://core.svn.wordpress.org/trunk@48174 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-08 10:58:05 +00:00
desrosj	500508884e	Administration: Fix failing tests as a result of [48397]. Because of changes to how PHP handles arrays used in `foreach()` loops in PHP >= 7.0, [48397] resulted in a failing test for PHP 5.6. This calls `reset()` after using the `$results` array in the `foreach()` to ensure the array is treated the same and as expected. Props azaozz, desrosj, SergeyBiryukov, xknown. See #50448. Built from https://develop.svn.wordpress.org/trunk@48401 git-svn-id: http://core.svn.wordpress.org/trunk@48170 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 20:38:03 +00:00
desrosj	a8521d48ac	Upgrade/Install: Prevent some 5.5.0 upgrade routines from running twice. This will prevent the options renamed for 5.5.0 from being converted twice. If a new update routine is added before 5.5 is released, the option values would be erased for anyone running `trunk` or nightlies without this change. Props azaozz, desrosj, SergeyBiryukov, whyisjake. Fixes #50413. Built from https://develop.svn.wordpress.org/trunk@48400 git-svn-id: http://core.svn.wordpress.org/trunk@48169 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 19:21:06 +00:00
desrosj	8381fad76e	Upgrade/Install: Add `hook_extra` parameter to the `upgrader_pre_download` filter. This provides additional context to code running on this hook, including which plugin or theme update will be downloaded. It also brings consistency to this filter with others throughout the upgrade process. Props obliviousharmony, desrosj. Fixes #49686. Built from https://develop.svn.wordpress.org/trunk@48399 git-svn-id: http://core.svn.wordpress.org/trunk@48168 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 19:15:06 +00:00
whyisjake	dcdabb5bb3	Administration: Introduce extensibility to posts and comments list table views, for accessibility purposes. At default, expands the excerpt view to become an extended view. Includes a new `table_view_mode` filter to allow further configuration. Fixes #49715. Props joedolson, audrasjb, afercia, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48398 git-svn-id: http://core.svn.wordpress.org/trunk@48167 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 19:12:03 +00:00
desrosj	48da753ff0	Administration: Prevent repeat emails for identical plugin or theme auto-update attempt failures. This change adds a throttle mechanism to plugin and theme auto-update failure emails using similar logic to the email sent for a Core auto-update. The first time a plugin or theme auto-update fails, the package and `new_version` will be tracked in the `auto_plugin_theme_update_emails` option. An email for this specific update attempt will not be resent. However, if this update fails again and non-repeat failures or successful updates are also present, then the failure information will be included in that email (an email needs to be sent for the new events regardless). Props johnbillion, arpitgshah, desrosj, audrasjb, pbiron, earnjam. Fixes #50448. Built from https://develop.svn.wordpress.org/trunk@48397 git-svn-id: http://core.svn.wordpress.org/trunk@48166 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 19:00:02 +00:00
Andrew Ozz	49bbff551b	Upgrade/install: Allow plugin and theme updates from a uploaded .zip file. Props mariovalney, cyberhobo, imath, shaunandrews, mariovalney, earnjam, desrosj, dd32, folletto, swissspidy, melchoyce, pento, joshuawold, psykro, clorith, ahortin, galbaras, pingram3541, joyously, doobeedoo, karmatosed, poena, whyisjake, earnjam, sergeybiryukov, audrasjb, azaozz. Fixes #9757. Built from https://develop.svn.wordpress.org/trunk@48390 git-svn-id: http://core.svn.wordpress.org/trunk@48159 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 17:49:05 +00:00
John Blackbourn	3c41801c5c	Administration: Reinstate the description for the `admin_xml_ns` hook which was accidentally removed in [47771]. See #46015. Built from https://develop.svn.wordpress.org/trunk@48380 git-svn-id: http://core.svn.wordpress.org/trunk@48149 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 14:57:02 +00:00
John Blackbourn	913f5aaab9	Docs: Correct some `@since` entries added in 5.5. See #49572 Built from https://develop.svn.wordpress.org/trunk@48377 git-svn-id: http://core.svn.wordpress.org/trunk@48146 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 14:14:04 +00:00
Andrea Fercia	aee4324b9e	Accessibility: Media: Improve accessibility of the status and error messages in the Image Editor. - improves focus management by moving focus to the notices, if any, or to the first "tabbable" element - this avoids a focus loss and helps Braille-only and screen magnification users to be aware of the messages - adds an ARIA role `alert` to all the notices - uses `wp.a11y.speak()` to announce messages to assistive technology - this way, all visual users will see the messages while assistive technology users will get an audible message - uses `wp.i18n` for translatable strings in `wp-admin/js/image-edit.js` Props anevins, ryanshoover, antpb, SergeyBiryukov, afercia. See #20491. Fixes #47147. Built from https://develop.svn.wordpress.org/trunk@48375 git-svn-id: http://core.svn.wordpress.org/trunk@48144 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 13:45:02 +00:00
Sergey Biryukov	181717c9ab	Plugins: Make sure the HTML ID attributes in plugin action links are unique. Follow-up to [47588]. Props mukesh27, roytanck, SergeyBiryukov. Fixes #49916. Built from https://develop.svn.wordpress.org/trunk@48374 git-svn-id: http://core.svn.wordpress.org/trunk@48143 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 13:43:02 +00:00
Andrea Fercia	22d0cd6c96	Accessibility: Allow post boxes on the Dashboard and Classic Editor pages to be reordered by using the keyboard. So far, it has been possible to rearrange into a new order the post boxes (also known as "widgets" on the Dashboard and "meta boxes" on the Edit post page) only by using a pointing device, for example a mouse. This change adds new controls and functionality to allow the boxes to be rearranged also with the keyboard. Additionally, audible messages are sent to the admin ARIA live region to notify screen reader users of the reorder action result. Props joedolson, anevins, antpb, audrasjb, xkon, MarcoZ, karmatosed, afercia. Fixes #39074. Built from https://develop.svn.wordpress.org/trunk@48373 git-svn-id: http://core.svn.wordpress.org/trunk@48142 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-07 13:00:02 +00:00
whyisjake	81b809e3d6	Administration: Move more table strings to sentence casing. WordPress as a project has moved largely to sentence casing for UI elements in the admin. This commit moves several string$ * Move to trash * Mark as spam * Permanently delete comment * Approve comment * In response to * Bulk actions * Not spam * Sumitted on * Delete permanently * Add media * Upload files * Upload images * Add media * Bulk select * Restore from trash * Search media * Attachment details * Create gallery * Edit gallery * Cancel gallery * Add to gallery * Image details * Replace image * Cancel edit * Edit image * Choose image * Select and crop * Skip cropping * Crop image * Audio details * Replace audio * Add audio source * Video details * Replace video * Add video source * Select poster image * Add subtitles * Create audio playlist * Edit audio playlist. * Cancel audio playlist * Create video playlist * Edit video playlist * Add to video playlist * Filter media Fixes #40244. Props afercia, bhargavbhandari90, rcutmore, webzunft, manojlovic, jeremyfelt, desrosj, lschuyler, SergeyBiryukov, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48352 git-svn-id: http://core.svn.wordpress.org/trunk@48121 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-06 21:52:21 +00:00
desrosj	bc7de32645	Coding Standards: Correct two coding standards issues introduced in [48277] and [48334]. See #50504, #50550. Built from https://develop.svn.wordpress.org/trunk@48345 git-svn-id: http://core.svn.wordpress.org/trunk@48114 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-06 19:23:02 +00:00
desrosj	77af0e5982	Docs: Correct instances of “auto update” with “auto-update” for consistency. See #49572. Built from https://develop.svn.wordpress.org/trunk@48344 git-svn-id: http://core.svn.wordpress.org/trunk@48113 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-06 19:15:03 +00:00
Sergey Biryukov	8a815f22e7	Privacy: Simplify the logic for updating the meta values for personal data export requests from absolute to relative paths. Follow-up to [48127]. See #44038. Built from https://develop.svn.wordpress.org/trunk@48330 git-svn-id: http://core.svn.wordpress.org/trunk@48099 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-06 00:34:04 +00:00
Sergey Biryukov	87f464c283	Plugins: Use `include_once` instead of `include` in `uninstall_plugin()`, in case the plugin file is already included. Props valchovski, pcfreak30. Fixes #47796. Built from https://develop.svn.wordpress.org/trunk@48326 git-svn-id: http://core.svn.wordpress.org/trunk@48095 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-05 20:32:03 +00:00
Dominik Schilling	56afcf2d68	Posts: Provide a HiDPI version for the avatar used in post locked dialogs. Props wpdesk, audrasjb, ocean90. Fixes #39633. Built from https://develop.svn.wordpress.org/trunk@48318 git-svn-id: http://core.svn.wordpress.org/trunk@48087 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-05 13:00:07 +00:00
Sergey Biryukov	201c7fbf97	Administration: Bring the update nag in line with other admin notices. In addition to more consistent display, this gives it a visible border on the About page. Props desrosj, nikhilbhansi, afercia, SergeyBiryukov. Fixes #50372. Built from https://develop.svn.wordpress.org/trunk@48316 git-svn-id: http://core.svn.wordpress.org/trunk@48085 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-05 11:57:04 +00:00
Dominik Schilling	5b7774722e	Users: Pass the `WP_User` object to the `wpmu_delete_user`, `delete_user`, and `deleted_user` actions. See #43232. Built from https://develop.svn.wordpress.org/trunk@48313 git-svn-id: http://core.svn.wordpress.org/trunk@48082 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-05 10:57:01 +00:00
Sergey Biryukov	6adad022e2	Docs: Correct spelling of "backward compatibility" per the Core Contributor Handbook glossary. Follow-up to [45232]. See #49572. Built from https://develop.svn.wordpress.org/trunk@48302 git-svn-id: http://core.svn.wordpress.org/trunk@48071 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-04 20:42:06 +00:00
Sergey Biryukov	43cbe21a3e	Administration: Use HTTPS for XHTML Friends Network URL. Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb. Fixes #48002. Built from https://develop.svn.wordpress.org/trunk@48292 git-svn-id: http://core.svn.wordpress.org/trunk@48061 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-04 09:33:01 +00:00
Andrew Ozz	86317e3e85	Media: Show an error message when a `.heic` file is uploaded that this type of files cannot be displayed in a web browser and suggesting to convert to JPEG. The message is shown by using filters, plugins that want to handle uploading of `.heic` files can remove it. Props mattheweppelsheimer, mikeschroder, jeffr0, andraganescu, desrosj, azaozz. Fixes #42775. Built from https://develop.svn.wordpress.org/trunk@48288 git-svn-id: http://core.svn.wordpress.org/trunk@48057 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-03 23:15:03 +00:00
Sergey Biryukov	054610e276	Text Changes: Remove use of "normal" in user-facing output. This clarifies some messages referring to Site Health checks and maintenance mode, and makes them more accurate. Props dartiss. Fixes #50549. Built from https://develop.svn.wordpress.org/trunk@48287 git-svn-id: http://core.svn.wordpress.org/trunk@48056 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-03 21:59:03 +00:00
Sergey Biryukov	8e43a329d4	Privacy: Hide views that have a count of 0 on privacy request tables, for consistency with other list tables. Props pbiron, garrett-eclipse, mapk, melchoyce, estelaris. Fixes #47495. Built from https://develop.svn.wordpress.org/trunk@48284 git-svn-id: http://core.svn.wordpress.org/trunk@48053 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-03 16:28:04 +00:00
Andrea Fercia	b8e3d63fdd	Accessibility: Plugins: Accessibility and CSS improvements for the Plugins pages. - improves checkboxes alignment on the "Plugins" page table in the responsive view - improves spacing between form controls on the "Add Plugins" page in the responsive view - the layout of the "filter bar" on the "Add Plugins" page is now based on CSS Flexbox - removes italic type from a paragraph in the "Favorites" page Props passoniate, garethgillman, maxpertici, audrasjb, sabernhardt, afercia. See #47327. Fixes #49231. Built from https://develop.svn.wordpress.org/trunk@48281 git-svn-id: http://core.svn.wordpress.org/trunk@48050 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-03 08:51:05 +00:00
youknowriad	bbe8f41de2	Color schemes: Add new modern color scheme option. This PR adds a new color scheme option, which uses a high luminosity blue spot color, almost-black menu, and pure white for menu items. This helps increase contrast, and bring more consistency with some of the higher contrast colors used in the block editor. Props joen, ibdz, shaunandrews. Fixes #50504. Built from https://develop.svn.wordpress.org/trunk@48277 git-svn-id: http://core.svn.wordpress.org/trunk@48046 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-02 14:55:05 +00:00
Andrea Fercia	45d19872fc	Accessibility: Media: Fix the Image Editor mismatching keyboard focus order and visual reading order. Swaps the DOM order of the two main columns within the admin Image Editor. When the sequence in which content is presented affects its meaning and the navigation sequences affect meaning or operation, visual order and DOM order must match. See WCAG 2.1 Success Criterion 1.3.2 Meaningful Sequence and Success Criterion 2.4.3 Focus Order. Props sabernhardt, anevins, audrasjb, afercia. Fixes #47136. Built from https://develop.svn.wordpress.org/trunk@48265 git-svn-id: http://core.svn.wordpress.org/trunk@48034 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-01 14:29:01 +00:00
TimothyBlynJacobs	083134f694	REST API: Introduce plugin management and block directory endpoints. These endpoints facilitate the Block Directory Inserter feature in Gutenberg. Users can now install, activate, deactivate, and delete plugins over the REST API. The block directoryendpoint allows searching for available blocks from the WordPress.org block directory. Props cklee, talldanwp, noisysocks, joen, soean, youknowriad, dufresnesteven, gziolo, dd32, tellyworth, ryelle, spacedmonkey, TimothyBlynJacobs. Fixes #50321. Built from https://develop.svn.wordpress.org/trunk@48242 git-svn-id: http://core.svn.wordpress.org/trunk@48011 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-01 04:24:03 +00:00
Sergey Biryukov	7ac100615f	Administration: Pass the result of `set-screen-option` filter to the new `set_screen_option_{$option}` filter to ensure backward compatibility. Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose. Props Chouby, sswells, SergeyBiryukov. Fixes #50392. Built from https://develop.svn.wordpress.org/trunk@48241 git-svn-id: http://core.svn.wordpress.org/trunk@48010 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-30 21:53:03 +00:00
Sergey Biryukov	e61075ad2a	Administration: Always show the filters on media and post list tables. Previously, the filters were hidden for single posts or attachments, which could only be achieved by editing the URL manually. The `is_singular()` check was added long before the list tables were introduced, and appears to no longer serve any purpose in the current code. As a side effect, this resolves an issue where a non-existing attachment ID in the URL would block further search in Media Library. Props afercia, tomdude, audrasjb, bencroskery, desrosj, SergeyBiryukov. Fixes #38221. Built from https://develop.svn.wordpress.org/trunk@48240 git-svn-id: http://core.svn.wordpress.org/trunk@48009 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-30 20:36:05 +00:00
Andrea Fercia	c4f6669d69	Accessibility: Privacy: Accessibility improvements for the Privacy Policy Guide page. Improves accessibility of the "Copy this section" button and "Return to Top" link: - uses `setTimeout()` and `clearTimeout()` to properly handle the "Copied!" text - simplifies the button text by removing the redundant visually hidden text - fixes the mismatching visual and DOM order of the Copy button and the "Return to Top" link - improves the "Return to Top" links by providing real page fragment identifiers, when possible - hides the "Return to Top" up arrow from assistive technologies - minor coding standards Props afercia, garrett-eclipse. See #48463, #50322. Fixes #50335. Built from https://develop.svn.wordpress.org/trunk@48234 git-svn-id: http://core.svn.wordpress.org/trunk@48003 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-30 13:56:03 +00:00
Andrea Fercia	eebf187963	Accessibility: Media: Add a "Copy URL" button to the attachment File URL fields. For a number of years, various screens in the WordPress admin provided users with a readonly input field to copy the attachment file URL. Manually copying from a readonly field is an annoying task at best even for mouser users. It's a usability and accessibility issue at the same time. These fields now have a new "Copy URL" button that is easy to use and accessible to everyone. Props theolg, markdubois, vabrashev, sajjad67, xkon, nrqsnchz, melchoyce, audrasjb, afercia. See #41612, #50322, #50335. Fixes #48463. Built from https://develop.svn.wordpress.org/trunk@48232 git-svn-id: http://core.svn.wordpress.org/trunk@48001 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-30 13:16:04 +00:00
Sergey Biryukov	0a805dbee6	Docs: Add a `@since` note to `edit_comment()` about the new return value. Follow-up to [48154]. See #39732. Built from https://develop.svn.wordpress.org/trunk@48223 git-svn-id: http://core.svn.wordpress.org/trunk@47992 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-30 01:04:03 +00:00
Sergey Biryukov	3a6eeef571	Posts, Post Types: Return early from `WP_Posts_List_Table::formats_dropdown()` if the post type does not support post formats. This avoids an unnecessary database query for the `post_format` taxonomy. Props Chouby. Fixes #50496. Built from https://develop.svn.wordpress.org/trunk@48203 git-svn-id: http://core.svn.wordpress.org/trunk@47972 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-28 14:30:07 +00:00
Sergey Biryukov	42f06389c0	Security: Improve the wording of messages in `wp_get_auto_update_message()`. Props burhandodhy, johnbillion, apedog. Fixes #50489. Built from https://develop.svn.wordpress.org/trunk@48202 git-svn-id: http://core.svn.wordpress.org/trunk@47971 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-28 14:18:03 +00:00
Sergey Biryukov	00a40b1ef2	Docs: Capitalize "ID", when referring to a user ID, term ID, etc. in a more consistent way. Follow-up to [48104] See #49572. Built from https://develop.svn.wordpress.org/trunk@48200 git-svn-id: http://core.svn.wordpress.org/trunk@47969 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-28 14:09:04 +00:00
Sergey Biryukov	3336009e34	Docs: Replace "html" and "xhtml" instances in DocBlocks and comments with "HTML" and "XHTML". This ensures consistent capitalization where appropriate. Props navidos, desrosj. Fixes #50473. Built from https://develop.svn.wordpress.org/trunk@48199 git-svn-id: http://core.svn.wordpress.org/trunk@47968 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-28 14:02:06 +00:00
Sergey Biryukov	c892c420b7	Docs: Miscellaneous DocBlock corrections. See #49572. Built from https://develop.svn.wordpress.org/trunk@48198 git-svn-id: http://core.svn.wordpress.org/trunk@47967 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-28 11:53:04 +00:00
Sergey Biryukov	58ad216087	Docs: Improve documentation for optional parameters per the documentation standards. See #49572. Built from https://develop.svn.wordpress.org/trunk@48197 git-svn-id: http://core.svn.wordpress.org/trunk@47966 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-28 11:49:02 +00:00
Sergey Biryukov	abe112c750	Administration: Correct the URL for "Learn more about getting started" link in "Welcome to WordPress" panel. Props hareesh-pillai, johnbillion. Fixes #50484. Built from https://develop.svn.wordpress.org/trunk@48191 git-svn-id: http://core.svn.wordpress.org/trunk@47960 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-27 12:45:04 +00:00
Sergey Biryukov	40c389c95e	Docs: Standardize on "Returning a value from the filter" vs. "Passing a value to the filter". The filter is the callback function added with `add_filter()`, therefore the hook passes a value to the filter, and the filter returns a value to change its behaviour. The documentation is referring to the latter. Props johnbillion. See #49572, #16557. Built from https://develop.svn.wordpress.org/trunk@48185 git-svn-id: http://core.svn.wordpress.org/trunk@47954 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-26 18:49:09 +00:00
John Blackbourn	eb9a6c9690	Docs: Miscellaneous docblock improvements. See #49572. Built from https://develop.svn.wordpress.org/trunk@48184 git-svn-id: http://core.svn.wordpress.org/trunk@47953 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-26 18:40:04 +00:00
ellatrix	c0db9a2f3d	Editor: update JavaScript packages Also update default block categories Props youknowriad, gziolo, aduth. Fixes #50420, #50278. Built from https://develop.svn.wordpress.org/trunk@48177 git-svn-id: http://core.svn.wordpress.org/trunk@47946 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-26 13:33:47 +00:00
Sergey Biryukov	16b35340f4	Site Health: Improve the error message displayed when activating a plugin that requires a higher version of PHP or WordPress. This adds some extra details to the message: * The current PHP or WordPress version. * The plugin's minimum required PHP or WordPress version. * A link to the support documentation on how to update PHP. Props stuffradio, johnbillion, garrett-eclipse, sabernhardt, williampatton, SergeyBiryukov. Fixes #48245. Built from https://develop.svn.wordpress.org/trunk@48172 git-svn-id: http://core.svn.wordpress.org/trunk@47941 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-26 00:27:09 +00:00
Sergey Biryukov	56342b8e8f	Docs: Replace "AJAX" with "Ajax" in DocBlocks and comments, per the spelling glossary. Props mukesh27, sabernhardt, SergeyBiryukov. Fixes #50064. Built from https://develop.svn.wordpress.org/trunk@48168 git-svn-id: http://core.svn.wordpress.org/trunk@47937 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 12:43:07 +00:00
Sergey Biryukov	d38a32bfac	Coding Standards: Reformat some long `apply_filters_deprecated()` and `do_action_deprecated()` calls for better readability. See #49542. Built from https://develop.svn.wordpress.org/trunk@48167 git-svn-id: http://core.svn.wordpress.org/trunk@47936 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 12:06:07 +00:00
Sergey Biryukov	bfafc0aecb	Administration: Correct and simplify the logic for `asc` and `desc` arguments in `WP_List_Table::get_sortable_columns()`. Setting the initial order didn't work as expected due to reversed logic. Follow-up to [48151]. See #45089. Built from https://develop.svn.wordpress.org/trunk@48165 git-svn-id: http://core.svn.wordpress.org/trunk@47934 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 11:35:13 +00:00
Sergey Biryukov	178059c1cb	Docs: Improve DocBlocks in `wp-admin/includes/file.php` per the documentation standards. See #49572. Built from https://develop.svn.wordpress.org/trunk@48164 git-svn-id: http://core.svn.wordpress.org/trunk@47933 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 09:39:13 +00:00
Sergey Biryukov	f8c59f3152	Docs: Synchronize documentation and variable names in `wp_get_(plugin\|theme)_file_editable_extensions()` for consistency. Add missing `@since` tag to `wp_get_theme_file_editable_extensions()`. See #49572. Built from https://develop.svn.wordpress.org/trunk@48163 git-svn-id: http://core.svn.wordpress.org/trunk@47932 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 09:31:15 +00:00
Sergey Biryukov	5162a10959	Docs: Improve DocBlocks in `wp-admin/includes/class-wp-list-table.php` per the documentation standards. See #49572. Built from https://develop.svn.wordpress.org/trunk@48162 git-svn-id: http://core.svn.wordpress.org/trunk@47931 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 08:56:16 +00:00
Mike Schroder	0792fb37db	Upgrade/Install: Fix Yoda condition in `wp_opcache_invalidate()`. Fixes linting failure due to Yoda condition in `wp_opcache_invalidate()` following [48160]. See #36455. Built from https://develop.svn.wordpress.org/trunk@48161 git-svn-id: http://core.svn.wordpress.org/trunk@47930 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 07:55:12 +00:00
Mike Schroder	dd11076dc7	Upgrade/Install: Invalidate OPcache for PHP files during updates. When files are copied into place, check whether opcode invalidation is available and attempt to invalidate to avoid unintended behavior or fatal errors from themes, plugins, or core. Introduces `wp_opcache_invalidate()` to allow safe invalidation of PHP files from opcode cache, and a filter, `wp_opcache_invalidate_file` to override the behavior. Replaces the existing calls to `opcache_invalidate()` in the plugin and theme editors to use the new function. Thanks to jnylen0 for porting over a patch from ClassicPress that provided much of the approach for what is being committed. Props nigro.simone, dd32, JasWSInc, szepe.viktor, swissspidy, JanR, asalce, Garavani, pavelevap, pputzer, GregLone, benoitchantre, jadonn, doc987, kraftbj, Krstarica, jnylen0, nextendweb, williampatton, ayeshrajans, joostdevalk, stevenkussmaul, boogah, jorbin, mikeschroder. Fixes #36455, #50354. Built from https://develop.svn.wordpress.org/trunk@48160 git-svn-id: http://core.svn.wordpress.org/trunk@47929 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-25 07:15:12 +00:00
whyisjake	bb7601f6d0	Comments: Allow `wp_update_comment()` to return `WP_Error()`. The `wp_update_comment_data` filter introduced in 4.7 allows comment data to be filtered before it is updated in the database. The patch aims to handle `WP_Error` as the filter above return value in a similar manner as is done for `wp_new_comment()`. Fixes #39732. Props: enricosorcinelli, swissspidy, gkloveweb, jnylen0, jbpaul17, afercia, SergeyBiryukov, audrasjb, imath, davidbaumwald. Built from https://develop.svn.wordpress.org/trunk@48154 git-svn-id: http://core.svn.wordpress.org/trunk@47923 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-24 00:05:12 +00:00
whyisjake	4f69c150b7	Cache API: Cache the results of `get_uploaded_header_images()`. Fixes #49446. Props pbiron, SergeyBiryukov, desrosj. Built from https://develop.svn.wordpress.org/trunk@48152 git-svn-id: http://core.svn.wordpress.org/trunk@47921 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 23:34:06 +00:00
whyisjake	cb553e4747	Administration: Update `WP_List_Table::get_sortable_columns()` to support `asc` and `desc` arguments. This makes the API a little more clear, whereas setting `false` used to mean `asc` and `true` meant `desc`, you can now use those directly, while maintaining back-compat. Fixes #45089. Props Tkama, SergeyBiryukov, shital-patel, desrosj, birgire, davidbaumwald. Built from https://develop.svn.wordpress.org/trunk@48151 git-svn-id: http://core.svn.wordpress.org/trunk@47920 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 23:15:10 +00:00
whyisjake	517f6501df	Security: Don't display the plugin auto-update options for mu-plugins or dropins. They can't be updated, so we shouldn't be showing the buttons. Fixes #50459. Props Chouby, audrasjb, pbiron. Built from https://develop.svn.wordpress.org/trunk@48149 git-svn-id: http://core.svn.wordpress.org/trunk@47918 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 22:58:09 +00:00
Sergey Biryukov	ce784f7ad4	I18N: Include placeholder in translator comments in `wp_get_auto_update_message()`. See #50436, #50052. Built from https://develop.svn.wordpress.org/trunk@48148 git-svn-id: http://core.svn.wordpress.org/trunk@47917 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 22:30:09 +00:00
whyisjake	8dad73a5b6	Security: Remove unnecessary `DISABLE_WP_CRON` check in plugin and theme automatic updates. Fixes #50436. Props johnbillion, audrasjb, bookdude13, pbiron, arpitgshah. Built from https://develop.svn.wordpress.org/trunk@48147 git-svn-id: http://core.svn.wordpress.org/trunk@47916 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 22:24:09 +00:00
Sergey Biryukov	840d1c796b	Accessibility: Administration: Give the link to meetup organizer handbook in the WordPress Events and News dashboard widget a more meaningful label. This ensures that the link still makes sense when read out of context by assistive technologies. Additionally, underline the link per the accessibility coding standards. Props samful, afercia, williampatton, audrasjb. Fixes #50338. Built from https://develop.svn.wordpress.org/trunk@48146 git-svn-id: http://core.svn.wordpress.org/trunk@47915 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 21:53:09 +00:00
Sergey Biryukov	a86cfefecb	Accessibility: Privacy: Improve the readability of the removed text in Privacy Policy Guide. Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility. Additionally, replace the legacy `.error` class for "You deactivated this plugin and may no longer need this policy" message with `.notice-info`. Follow-up to [47147], [48116]. Props afercia, audrasjb. See #47327, #44621. Built from https://develop.svn.wordpress.org/trunk@48145 git-svn-id: http://core.svn.wordpress.org/trunk@47914 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 20:57:11 +00:00
desrosj	c5b1a12a55	General: Rename `(add\|remove)_option_allowed_list()` to `(add\|remove)_allowed_option()`. The new names make the purpose more clear. It also adds consistency with the `$allowed_options` global variable. Also in this change, the `wp-deprecated` dependency has been removed from the password strength meter in favor of a `window.console.log()` call to avoid adding 3 dependencies for one deprecated notice. Props SergeyBiryukov, ocean90, desrosj Fixes #50413. Built from https://develop.svn.wordpress.org/trunk@48142 git-svn-id: http://core.svn.wordpress.org/trunk@47911 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 18:54:16 +00:00
whyisjake	a918d853aa	Quick/Bulk Edit: Ensure the proper actions is triggered when using the bulk updater. If a user selects the top option, then chooses a different option, the top selection takes precedence. This update gives a new name to the bottom action, ensuring the proper update is carried out. Fixes 46872. Props clayray, garrett-eclipse, subrataemfluence. Built from https://develop.svn.wordpress.org/trunk@48134 git-svn-id: http://core.svn.wordpress.org/trunk@47903 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 05:56:08 +00:00
noisysocks	e7f9aca8dd	Editor: Revert [48119]. This commit caused the majority of blocks in the block editor to no longer register as they reference the old category names. See #50278. Built from https://develop.svn.wordpress.org/trunk@48130 git-svn-id: http://core.svn.wordpress.org/trunk@47899 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-23 00:15:11 +00:00
whyisjake	84f39df101	Privacy: Use relative paths for exported personal data. Ensures back-compat while moving to paths off of the /exports directory. Fixes: #44038. Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake, davidbaumwald. Built from https://develop.svn.wordpress.org/trunk@48127 git-svn-id: http://core.svn.wordpress.org/trunk@47896 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 22:40:11 +00:00
Sergey Biryukov	f27cb65e1e	Administration: Remove the `xmlns` attribute on the `<html>` tag. The attribute is specific to XHTML and is not needed in HTML5. Props audrasjb, diddledan, hommealone, joyously, mukesh27, valentinbora, peterwilsoncc, SergeyBiryukov. Fixes #49126. Built from https://develop.svn.wordpress.org/trunk@48126 git-svn-id: http://core.svn.wordpress.org/trunk@47895 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 21:26:16 +00:00
Sergey Biryukov	89e99f57a2	Site Health: Correct the check of whether the theme directory is writable when the current theme is symlinked into the theme directory. This ensures that the check is done on a sub-directory within `WP_CONTENT_DIR`, rather than outside of `ABSPATH`. Props pbiron, Clorith. Fixes #48199. Built from https://develop.svn.wordpress.org/trunk@48125 git-svn-id: http://core.svn.wordpress.org/trunk@47894 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 20:15:14 +00:00
desrosj	35545bee43	Administration: Improve the plugin and theme auto-update emails. This makes several improvements to the emails sent to site admins when plugin and theme auto-updates are attempted. - Emails are now specifically tailored to the three results (success, failed, or mixed). - Subject lines and body copy for mixed and failed results now correctly convey the importance of double checking the site in question. - The site’s URL is now included in all emails. - When failures occur, links to the Plugins and/or Themes pages in the admin are now included so that site owners can easily take action. Props audrasjb, desrosj, azaozz, garrett-eclipse, paaljoachim, johnbillion, marybaum, pbiron. Follow up to [47835]. See #50052. Fixes #50268. Built from https://develop.svn.wordpress.org/trunk@48123 git-svn-id: http://core.svn.wordpress.org/trunk@47892 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 18:18:08 +00:00
desrosj	acc97eae32	General: Reference the correct database version for 5.5.0 upgrades. Follow up to [48121]. See #50413. Built from https://develop.svn.wordpress.org/trunk@48122 git-svn-id: http://core.svn.wordpress.org/trunk@47891 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 17:33:08 +00:00
desrosj	4b60af1a6a	General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language. “The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.” With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the `$new_whitelist_options` global variable) are removed. A new ticket has been opened to explore renaming the `$new_whitelist_options` variable (#50434). Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase. Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort. Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam. See #48900, #50434. Fixes #50413. Built from https://develop.svn.wordpress.org/trunk@48121 git-svn-id: http://core.svn.wordpress.org/trunk@47890 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 17:26:13 +00:00
ellatrix	2349d1f999	Editor: Update default block categories See https://github.com/WordPress/gutenberg/pull/19279. Props aduth, gziolo. Fixes #50278. Built from https://develop.svn.wordpress.org/trunk@48119 git-svn-id: http://core.svn.wordpress.org/trunk@47888 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 14:07:10 +00:00
gziolo	29ffb31cb3	Blocks: Add context fields to WP_Block_Type New block context related fields were added as part of https://github.com/WordPress/gutenberg/pull/22686. This changest backports them to WP_Block_Type class. Props aduth, spacedmonkey, mcsf, epiqueras. Fixes #47656. Built from https://develop.svn.wordpress.org/trunk@48117 git-svn-id: http://core.svn.wordpress.org/trunk@47886 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-22 10:26:14 +00:00
Andrea Fercia	ae447adaf4	I18N: Restore the "Error:" prefix for error messages. Partially reverts [48059] as there's no full consensus on the removal of the text prefix. Further actions should be taken to improve consistency and accessibility of the admin notices. Keeps some improvements to the translatable strings from [48059]. Fixes #47656. Built from https://develop.svn.wordpress.org/trunk@48115 git-svn-id: http://core.svn.wordpress.org/trunk@47884 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-21 14:00:09 +00:00
Sergey Biryukov	be16bb9fba	Docs: Remove extra spaces from `@param` tags. Per the documentation standards, `@param` tags should be aligned with each other, but not with the `@return` tag. See #49572. Built from https://develop.svn.wordpress.org/trunk@48110 git-svn-id: http://core.svn.wordpress.org/trunk@47879 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-20 12:58:10 +00:00
Sergey Biryukov	b16368c268	Docs: Remove `@staticvar` tags from core. The tag was supported in phpDocumentor 1.x, but is no longer supported in 2.x and 3.x. Usage of static variables is considered an internal implementation detail and has no information value for someone reading the docs. Props alishanvr, jrf. Fixes #50426. Built from https://develop.svn.wordpress.org/trunk@48109 git-svn-id: http://core.svn.wordpress.org/trunk@47878 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-20 12:40:12 +00:00
Sergey Biryukov	65724cf380	Docs: Correct DocBlock placement for `allow_subdirectory_install` filter. See #49572. Built from https://develop.svn.wordpress.org/trunk@48108 git-svn-id: http://core.svn.wordpress.org/trunk@47877 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-20 12:24:08 +00:00
Sergey Biryukov	26621b3b44	Docs: Miscellaneous DocBlock corrections for plugin and theme installation and updates. See #49572. Built from https://develop.svn.wordpress.org/trunk@48105 git-svn-id: http://core.svn.wordpress.org/trunk@47874 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-20 12:14:09 +00:00
Sergey Biryukov	e13c363b17	Docs: Capitalize "ID", when referring to a post ID, term ID, etc. in a more consistent way. See #49572. Built from https://develop.svn.wordpress.org/trunk@48104 git-svn-id: http://core.svn.wordpress.org/trunk@47873 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-20 12:02:12 +00:00
Sergey Biryukov	a576a13246	Docs: Remove an empty line between `@param` and `@return` tags, per the documentation standards. See #49572. Built from https://develop.svn.wordpress.org/trunk@48102 git-svn-id: http://core.svn.wordpress.org/trunk@47871 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-20 11:18:09 +00:00
John Blackbourn	1a77bb81d8	Docs: Remove unnecessary variables names from `@return` tags. See #49572. Built from https://develop.svn.wordpress.org/trunk@48100 git-svn-id: http://core.svn.wordpress.org/trunk@47869 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-19 22:55:12 +00:00
John Blackbourn	acb8983ac1	Docs: Corrections and improvements to inline docs related to plugin and theme auto-updates. See #50052, #49572 Built from https://develop.svn.wordpress.org/trunk@48097 git-svn-id: http://core.svn.wordpress.org/trunk@47866 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-19 22:17:07 +00:00
Andrew Ozz	aca919f007	Plugins and Themes Auto-Updates: - Fix displaying of errors on the Themes screen. - Correct the classes used for the error messages, and use `notice-alt` as notices are mostly shown on a white background. Props afercia, azaozz. Fixes #50405. Built from https://develop.svn.wordpress.org/trunk@48092 git-svn-id: http://core.svn.wordpress.org/trunk@47859 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-19 16:51:14 +00:00
Sergey Biryukov	0050998801	Filesystem API: Expicitly set directory permissions in `WP_Filesystem_SSH2::mkdir()`. This ensures the permissions are correct after a directory is created with `ssh2_sftp_mkdir()`, which appears to be affected by system `umask` settings. Props bbrdaric. Fixes #49218. Built from https://develop.svn.wordpress.org/trunk@48090 git-svn-id: http://core.svn.wordpress.org/trunk@47857 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-19 10:38:08 +00:00
Sergey Biryukov	527696af3b	Coding Standards: Add some space around control structures in `WP_Filesystem_*` classes for consistency and better readability. Additionally, synchronize `$tempfile` and `$temphandle` variable names in `WP_Filesystem_FTPext` and `WP_Filesystem_ftpsockets`. See #49542. Built from https://develop.svn.wordpress.org/trunk@48089 git-svn-id: http://core.svn.wordpress.org/trunk@47856 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-19 10:36:12 +00:00
whyisjake	1e3d4921fb	Privacy: Revert use relative paths for exported personal data. Tests need to be updated to pass. See: #44038. Unprops: whyisjake. Built from https://develop.svn.wordpress.org/trunk@48088 git-svn-id: http://core.svn.wordpress.org/trunk@47855 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-18 23:02:10 +00:00
whyisjake	2d514c83d5	Privacy: Use relative paths for exported personal data. Ensures back-compat while moving to paths off of the `/exports` directory. Fixes: #44038. Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48087 git-svn-id: http://core.svn.wordpress.org/trunk@47854 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-18 21:40:14 +00:00
Andrew Ozz	d61790f9dc	Fix empty line phpcs error. See #50280. Built from https://develop.svn.wordpress.org/trunk@48078 git-svn-id: http://core.svn.wordpress.org/trunk@47845 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-18 00:46:09 +00:00
Andrew Ozz	7757ad5e94	Plugins and Themes Auto-Updates: allow overriding of the HTML for the auto-update setting link. This will let plugins show better/specific information when they are overriding the auto-update settings, for example "Updates are managed by ... plugin". Introduces: `theme_auto_update_setting_html`, `plugin_auto_update_setting_html`, and `theme_auto_update_setting_template` filters. Props audrasjb, pbiron, azaozz. Fixes #50280. Built from https://develop.svn.wordpress.org/trunk@48077 git-svn-id: http://core.svn.wordpress.org/trunk@47844 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-18 00:00:13 +00:00
Sergey Biryukov	cb72d22d67	Menus: Check the correct variable in `Walker_Nav_Menu_Edit::start_el()` when menu item is a taxonomy term. Follow-up to [45891]. Props ashour. Fixes #50415. Built from https://develop.svn.wordpress.org/trunk@48076 git-svn-id: http://core.svn.wordpress.org/trunk@47843 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-17 19:47:14 +00:00
desrosj	689fdc6319	Site Health: Verify PHP version requirements when auto-updating themes. Follow up of [47819]. See #49653. Fixes #50411. Built from https://develop.svn.wordpress.org/trunk@48071 git-svn-id: http://core.svn.wordpress.org/trunk@47838 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-17 14:48:07 +00:00
Sergey Biryukov	de59ad23a4	Docs: Consistently include an empty line between `@since` tag and `@see`, `@link`, or `@global`, per the documentation standards. See #49572. Built from https://develop.svn.wordpress.org/trunk@48067 git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-16 21:07:14 +00:00
Andrea Fercia	f83c504b88	I18N: Remove the "Error:" prefix from error messages. For a number of years, most of the WordPress error messages have been prefixed with "Error:". However, these messages appear in a context where it's already clear an error occurred. Whether it's an error, a warning, or any other classification, that's not so relevant for users. The content of the message is the relevant part. The "Error:" prefix doesn't add great value while it does add unnecessary complexity for the message readability. Also, revises some of these messages to improve clarity and removes HTML from translatable strings. Props garrett-eclipse, ramiy, SergeyBiryukov, afercia, sabernhardt, quadthemes, audrasjb. See #47003, #43037, #42945, #15887. Fixes #47656. Built from https://develop.svn.wordpress.org/trunk@48059 git-svn-id: http://core.svn.wordpress.org/trunk@47826 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-16 15:35:13 +00:00
whyisjake	28d29b35f7	Comments: Don't display edit links to trashed post comments. If a post is in the trash, the comments bubble won't link to the comments list. Fixes: #37826. Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion. Built from https://develop.svn.wordpress.org/trunk@48050 git-svn-id: http://core.svn.wordpress.org/trunk@47817 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-15 23:06:08 +00:00
Dominik Schilling	9f7a7f8d57	Coding Standards: Fix code indentation in `post_submit_meta_box()` to improve readability. See #49542. Built from https://develop.svn.wordpress.org/trunk@48041 git-svn-id: http://core.svn.wordpress.org/trunk@47808 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-14 16:31:08 +00:00
Sergey Biryukov	4cc11cdbdd	Filesystem API: Avoid a PHP notice in `WP_Filesystem_Direct::owner()` and `::group()` methods and their `WP_Filesystem_SSH2` counterparts. Although not officially documented in the PHP manual, `posix_getpwuid()` and `posix_getgrgid()` can return `false` in some circumstances. Props logig. Fixes #50373. Built from https://develop.svn.wordpress.org/trunk@48031 git-svn-id: http://core.svn.wordpress.org/trunk@47798 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-12 12:35:09 +00:00
whyisjake	dda0ccdd18	Administration: Add a new filter to extend `set-screen-option`. Props: xknown, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@47951 git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-10 17:24:51 +00:00
whyisjake	7e9267567f	Editor: Prevent HTML decoding on by setting the proper editor context. Props: sstoqnov. Built from https://develop.svn.wordpress.org/trunk@47948 git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-10 17:21:20 +00:00
desrosj	784908ae5f	Coding Standards: PHP short ternary operator syntax is not allowed. WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook. Follow up of [47927]. Fixes #50258. Built from https://develop.svn.wordpress.org/trunk@47929 git-svn-id: http://core.svn.wordpress.org/trunk@47702 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-08 21:27:10 +00:00
Sergey Biryukov	18a9359c06	Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database. Props shital-patel, Presskopp, ocean90. Fixes #50325. Built from https://develop.svn.wordpress.org/trunk@47922 git-svn-id: http://core.svn.wordpress.org/trunk@47696 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-07 09:24:11 +00:00
Adam Silverstein	0b9a800512	Media: remove any `attachment-filter` query param when switching views. Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view. Props itzmekhokan, netsurfer2705, zodiac1978. Fixes #43656. Built from https://develop.svn.wordpress.org/trunk@47915 git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-05 21:13:10 +00:00
Sergey Biryukov	4bbb7fb852	Docs: Update the DocBlock for the `wp_media_attach_action` hook per the documentation standards. Rename the `$att_id` variable to `$attachment_id` for clarity. Follow-up to [47909]. See #49614. Built from https://develop.svn.wordpress.org/trunk@47913 git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-05 08:30:10 +00:00
desrosj	b013a15d43	Accessibility: Add the `aria-hidden` attribute to the auto-update related icons. `<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative. Props audrasjb, ryokuhi. Fixes #50293. Built from https://develop.svn.wordpress.org/trunk@47910 git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-04 15:47:09 +00:00
whyisjake	00d3696923	Media: Add an action for `wp_media_attach_action`. This action fires when media is attached/detached from a post. Fixes: #49614. Props: jonoaldersonwp, antpb, rebasaurus, donmhico. Built from https://develop.svn.wordpress.org/trunk@47909 git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-04 15:00:09 +00:00
Sergey Biryukov	b50e87d52b	Docs: Add missing `@global` reference for the `$post_id` global in `wp_admin_bar_edit_menu()`. Follow-up to [47903]. Props davidbaumwald. See #50312. Built from https://develop.svn.wordpress.org/trunk@47906 git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 21:27:09 +00:00
desrosj	27485fd7aa	General: Continuing to work towards a passing PHP Compatibility scan. This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments. With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750). Props desrosj, johnbillion, jrf. See #49922. Built from https://develop.svn.wordpress.org/trunk@47902 git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 17:40:12 +00:00
Sergey Biryukov	f22e113e95	File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors. Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL. Follow-up to [46230]. Props munyagu. Fixes #50309. See #47957. Built from https://develop.svn.wordpress.org/trunk@47896 git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 11:43:15 +00:00
Sergey Biryukov	cf597dcf7c	Plugins: Make the message displayed when no plugins are installed more concise. Props johnjamesjacoby, Presskopp. Fixes #42336. Built from https://develop.svn.wordpress.org/trunk@47894 git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-03 10:51:13 +00:00
whyisjake	69a866a1a9	Administration: Unify the date structure in list view and excerpt view. Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`. Fixes: #35391. Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson. Built from https://develop.svn.wordpress.org/trunk@47879 git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-01 19:15:08 +00:00
gziolo	c704057e0d	Add fields to WP_Block_Type As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them. Props spacedmonkey, aduth. Fixes #48529. Built from https://develop.svn.wordpress.org/trunk@47875 git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-06-01 12:27:08 +00:00
Andrea Fercia	38b7495af7	Administration and Site Health: Make information on Search engine visibility more prominent. - makes the "Search engines discouraged" message on the Dashboard more prominent - adds "Search engine visibility" information under Site Health > Info > WordPress - removes title case in favor of sentence case in all the related strings Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce. Fixes #35288. Built from https://develop.svn.wordpress.org/trunk@47859 git-svn-id: http://core.svn.wordpress.org/trunk@47635 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-27 14:33:11 +00:00
whyisjake	57fb3c6cf0	Coding Standards: Change auto-update filters to be more consistent. * send_theme_auto_update_email 👉 auto_theme_update_send_email * wp_plugins_auto_update_enabled 👉 plugins_auto_update_enabled * wp_themes_auto_update_enabled 👉 themes_auto_update_enabled Want to make sure that @ronalfy gets props for his work in #50052 too. See #50052. Props: ronalfy, pbiron, azaozz, audrasjb, whyisjake. Built from https://develop.svn.wordpress.org/trunk@47857 git-svn-id: http://core.svn.wordpress.org/trunk@47633 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-26 18:03:08 +00:00
Sergey Biryukov	7b192d406a	Coding Standards: Fix instances of `Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47855 git-svn-id: http://core.svn.wordpress.org/trunk@47631 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-26 09:37:10 +00:00
Sergey Biryukov	5b4174e409	Coding Standards: Use strict comparison for more `count()` calls. Follow-up to [47848]. Props mukesh27. Fixes #50232. See #49542. Built from https://develop.svn.wordpress.org/trunk@47851 git-svn-id: http://core.svn.wordpress.org/trunk@47627 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-23 16:22:07 +00:00
Sergey Biryukov	b9751d4efe	Coding Standards: Use strict comparison for `count()` calls. See #49542. Built from https://develop.svn.wordpress.org/trunk@47848 git-svn-id: http://core.svn.wordpress.org/trunk@47624 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-23 11:38:08 +00:00
Sergey Biryukov	5850f5f6ef	Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-site-health-auto-updates.php`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47841 git-svn-id: http://core.svn.wordpress.org/trunk@47617 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-22 17:56:08 +00:00
Sergey Biryukov	64ed8a7355	Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-debug-data.php`. Follow-up to [47550], [47557], [47835]. See #50052. Built from https://develop.svn.wordpress.org/trunk@47840 git-svn-id: http://core.svn.wordpress.org/trunk@47616 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-22 17:26:07 +00:00
Sergey Biryukov	ba03c426db	Docs: Add missing `@since` tag for `auto_plugin_theme_update_email` filter. See #50052. Built from https://develop.svn.wordpress.org/trunk@47836 git-svn-id: http://core.svn.wordpress.org/trunk@47612 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-20 19:33:10 +00:00
whyisjake	661b929e1e	Security: Add user interface to auto-update themes and plugins. Building on core update mechanisms, this adds the ability to enable automatic updates for themes and plugins to the WordPress admin. Fixes: #50052. Props: afercia, afragen, audrasjb, azaozz, bookdude13, davidperonne, desrosj, gmays, gmays, javiercasares, karmatosed, knutsp, mapk, mukesh27, netweb, nicolaskulka, nielsdeblaauw, paaljoachim, passoniate, pbiron, pedromendonca, whodunitagency, whyisjake, wpamitkumar, and xkon. Built from https://develop.svn.wordpress.org/trunk@47835 git-svn-id: http://core.svn.wordpress.org/trunk@47611 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-20 18:49:09 +00:00
Sergey Biryukov	307725883a	Themes: Prevent installation of themes that require a higher version of PHP or WordPress. Props afragen. Fixes #49653. See #48491. Built from https://develop.svn.wordpress.org/trunk@47819 git-svn-id: http://core.svn.wordpress.org/trunk@47595 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 16:03:09 +00:00
Sergey Biryukov	54cdfaef59	Themes: Remove extra whitespace from `wp-admin/includes/ajax-actions.php` and `wp-admin/includes/theme.php`. Follow-up to [47816]. See #48491. Built from https://develop.svn.wordpress.org/trunk@47818 git-svn-id: http://core.svn.wordpress.org/trunk@47594 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 12:55:06 +00:00
Sergey Biryukov	b73bbd8139	Themes: Prevent activation and live preview of themes that require a higher version of PHP or WordPress. Props afragen, jorbin, TimothyBlynJacobs, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@47816 git-svn-id: http://core.svn.wordpress.org/trunk@47592 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 12:32:10 +00:00
Sergey Biryukov	d528d7a044	Site Health: Use `WP_Theme::parent()` in the inactive themes test as a more reliable check that the parent theme exists. This is also more consistent with the other instances of directly referencing `WP_Theme::parent()` properties or methods in core. Props mukesh27, juanlopez4691, davidbaumwald, afragen, SergeyBiryukov. Fixes #49934. Built from https://develop.svn.wordpress.org/trunk@47815 git-svn-id: http://core.svn.wordpress.org/trunk@47591 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-18 04:38:10 +00:00
Sergey Biryukov	91936df3d1	Coding Standards: Fix WPCS issues in plugin and theme upgrader classes. See #49542. Built from https://develop.svn.wordpress.org/trunk@47814 git-svn-id: http://core.svn.wordpress.org/trunk@47590 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-17 09:39:11 +00:00
Sergey Biryukov	7932193708	Coding Standards: Use strict comparison where static strings are involved. This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890. Includes minor code layout fixes for better readability. See #49542. Built from https://develop.svn.wordpress.org/trunk@47808 git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-16 18:42:12 +00:00
Sergey Biryukov	16a8128765	Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-screen.php`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47802 git-svn-id: http://core.svn.wordpress.org/trunk@47578 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-15 18:13:09 +00:00
Sergey Biryukov	69adb593a2	Themes: Add "Block Editor Patterns" and "Full Site Editing" to the list of WordPress theme features. Follow-up to [meta9876]. Props dingo_d. Fixes #50164. See #meta5212. Built from https://develop.svn.wordpress.org/trunk@47797 git-svn-id: http://core.svn.wordpress.org/trunk@47573 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 14:43:08 +00:00
Sergey Biryukov	fb0e6531ab	Docs: Add `@since` notes for theme features added or removed in `get_theme_feature_list()` after its introduction in WordPress 3.1. See #50165. Built from https://develop.svn.wordpress.org/trunk@47794 git-svn-id: http://core.svn.wordpress.org/trunk@47570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 12:50:08 +00:00
Sergey Biryukov	04e3fd6995	Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features. These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now. Follow-up to [meta8273]. See #46272. Built from https://develop.svn.wordpress.org/trunk@47790 git-svn-id: http://core.svn.wordpress.org/trunk@47566 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 09:18:08 +00:00
Sergey Biryukov	5e42a6c9e5	Export: Use correct escaping function for term IDs in `<wp:term>` nodes. Follow-up to [34333]. Props DrLightman, marcio-zebedeu. Fixes #50113. Built from https://develop.svn.wordpress.org/trunk@47789 git-svn-id: http://core.svn.wordpress.org/trunk@47565 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-14 07:55:12 +00:00
Sergey Biryukov	bfba3fc458	Docs: Improve documentation for functions in `wp-admin/install-helper.php` per the documentation standards. Synchronize descriptions with the functions' counterparts from `wp-admin/includes/upgrade.php`. See #49572. Built from https://develop.svn.wordpress.org/trunk@47786 git-svn-id: http://core.svn.wordpress.org/trunk@47562 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-12 18:40:07 +00:00
Sergey Biryukov	aa69c25d5f	Coding Standards: Use strict comparison in some `wp-admin` files. Props pikamander2, mukesh27, SergeyBiryukov. Fixes #49239. Built from https://develop.svn.wordpress.org/trunk@47785 git-svn-id: http://core.svn.wordpress.org/trunk@47561 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-12 18:32:08 +00:00
Sergey Biryukov	3fc1b33d53	Docs: Use 3-digit, x.x.x style semantic versioning for inline comments in `populate_options()`. See #49572. Built from https://develop.svn.wordpress.org/trunk@47782 git-svn-id: http://core.svn.wordpress.org/trunk@47558 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-11 17:26:08 +00:00
Sergey Biryukov	5511b43e2c	Administration: Avoid a PHP 7.4 notice in `add_meta_box()` when attempting to re-add a previously removed box. The logic for skipping previously removed meta boxes with the `core` priority should also apply to the `sorted` priority that is used when the boxes were manually reordered. Add a unit test. Props coolmann, franzarmas, SergeyBiryukov. Fixes #50019. Built from https://develop.svn.wordpress.org/trunk@47777 git-svn-id: http://core.svn.wordpress.org/trunk@47553 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-09 12:26:12 +00:00
Sergey Biryukov	1cde7d86f9	Coding Standards: Fix WPCS issues in `wp-admin/includes/template.php`. See #49542. Built from https://develop.svn.wordpress.org/trunk@47775 git-svn-id: http://core.svn.wordpress.org/trunk@47551 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-08 16:36:18 +00:00
Dominik Schilling	7ded6c2d2a	Administration: Remove any CSS related to Internet Explorer versions 6 – 10. In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks! * Removes ie.css and `ie` style handle. * Removes IE specific class names and any related CSS. * Drops support for IE8 and older in `wp_customize_support_script()`. * Updates compatibility mode for CSS minification to `ie11`. Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90. Fixes #17232, #46015. Built from https://develop.svn.wordpress.org/trunk@47771 git-svn-id: http://core.svn.wordpress.org/trunk@47547 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-06 20:15:07 +00:00
Sergey Biryukov	9782eb82ad	Site Health: Display the original PHP memory limit on Site Health Info screen. This ensures that if the limit has been modified for admin screens by `wp_raise_memory_limit()`, the original value is displayed along with the current value. Props Clorith, espiat, zodiac1978, SergeyBiryukov. Fixes #49329. Built from https://develop.svn.wordpress.org/trunk@47762 git-svn-id: http://core.svn.wordpress.org/trunk@47538 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-05 18:58:09 +00:00
John Blackbourn	1a27d51b48	Menus: Allow empty taxonomy terms to be surfaced when searching for items. This brings the behaviour inline with that of browsing terms or using the All Items tab, which correctly shows empty terms. Props birgire, audrasjb Fixes #45298 Built from https://develop.svn.wordpress.org/trunk@47747 git-svn-id: http://core.svn.wordpress.org/trunk@47523 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-02 22:36:07 +00:00
Dominik Schilling	a6f3ad2d21	Users: Don't reset user language preference on user update. Props johnbillion. Fixes #38665. Built from https://develop.svn.wordpress.org/trunk@47739 git-svn-id: http://core.svn.wordpress.org/trunk@47515 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-02 16:29:06 +00:00
desrosj	89ddd19884	General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset. As part of the continued effort to improve PHP compatibility, the following improvments are being made: - Removing deprecated PHP `safe_mode` checks not found in bundled external libraries. - Change the remaining `while` loops using `each()` to `foreach` loops. - Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way. - Add inline comments to not flag deprecated PHP directives in the getID3 library. Props desrosj, earnjam, dryanpress. See #49922. Built from https://develop.svn.wordpress.org/trunk@47735 git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-01 19:07:09 +00:00
Sergey Biryukov	10945d2f3d	Taxonomy: Restore (un-deprecate) the `tag_row_actions` filter. The filter provides a simple way for plugin authors to add actions generically for all taxonomy list tables without looping through each taxonomy individually. Props joemcgill, delowardev. Fixes #49808. Built from https://develop.svn.wordpress.org/trunk@47734 git-svn-id: http://core.svn.wordpress.org/trunk@47510 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-05-01 16:45:09 +00:00

... 4 5 6 7 8 ...

8039 Commits