Aaron Jorbin
2d64637ff8
Request FTP and SSH credentials when needed during shiny updates
...
This is a restoration of [31749] which was reverted in [31755].
It includes a number of enhancements from the original version. Namely:
* Not doing a credential check in src/wp-includes/script-loader.php
* Add new function `wp_print_request_filesystem_credentials_modal`
* update the version number in the list table when a plugin is updated
UI still needs further work, but this basic version should enable more testing
Props ericlewis, jorbin
See #31528
Built from https://develop.svn.wordpress.org/trunk@31811
git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 03:18:27 +00:00
Dominik Schilling
474f001c42
Revert [31749], see #31528 .
...
Built from https://develop.svn.wordpress.org/trunk@31755
git-svn-id: http://core.svn.wordpress.org/trunk@31736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 17:51:26 +00:00
Aaron Jorbin
5b658df402
Request FTP and SSH credentials when needed during shiny updates
...
This is a first pass at requesting FTP and SSH credentials when needed during shiny updates. Styling and some UX improvements are still needed, but we do show the prompt and use the passed data when doing plugin installs and updates for shiny updates. There are also a couple of areas that we could improve code wise such how we create the requestFilesystemCredentials part of the localized _wpUpdatesSettings. Over the past half century, we've split the atom, we've spliced the gene and we've roamed Tranquility Base. We've reached for the stars and never have we been closer to having them in our grasp. That has nothing to do with shiny updates.
Props ericlewis, jorbin, and drewapicture for testing
Fixes #31528
Built from https://develop.svn.wordpress.org/trunk@31749
git-svn-id: http://core.svn.wordpress.org/trunk@31730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 08:53:26 +00:00
Dominik Schilling
13ad2d4e16
Screen Options: Improve items per page option label.
...
Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to `WP_Screen->render_per_page_options()` and removes all the existing one-word labels.
props afercia.
fixes #31349 , #15576 .
Built from https://develop.svn.wordpress.org/trunk@31696
git-svn-id: http://core.svn.wordpress.org/trunk@31677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 15:32:27 +00:00
Scott Taylor
0ec87e4584
There are a few functions that have the ability to return false
instead of a string, so the return value should be checked before being passed to functions that expect string.
...
These are trivial, but they clear out some Scrutinizer issues.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31681
git-svn-id: http://core.svn.wordpress.org/trunk@31662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 02:11:28 +00:00
Gary Pendergast
9c69213f2b
Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page.
...
This also includes JS architecture that can be expanded to support theme, core and language pack updates.
Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture
See #29820
Built from https://develop.svn.wordpress.org/trunk@31333
git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-05 04:19:23 +00:00
Scott Taylor
7f8b548df1
In HTML5, the action
attribute is no longer required. Remove this attribute when empty.
...
The admin HTML is served with the HTML5 doctype.
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action
Props voldemortensen.
Fixes #30126 .
Built from https://develop.svn.wordpress.org/trunk@31200
git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Sergey Biryukov
94fa6e1615
Use correct file name in a hook comment.
...
props wedi.
fixes #30200 .
Built from https://develop.svn.wordpress.org/trunk@30117
git-svn-id: http://core.svn.wordpress.org/trunk@30117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 18:35:28 +00:00
Dominik Schilling
57c41263d7
Language packs: Remove translations when deleting a theme or a plugin.
...
This is for translation files in WP_LANG_DIR which are installed through a language pack.
Change `wp_get_installed_translations()` to only return a translation if the .mo file also exists.
fixes #29860 .
Built from https://develop.svn.wordpress.org/trunk@29856
git-svn-id: http://core.svn.wordpress.org/trunk@29619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-08 19:05:20 +00:00
Sergey Biryukov
dc6b95589a
Plugin activation/deletion errors should be styled as such.
...
props johnbillion.
fixes #28260 .
Built from https://develop.svn.wordpress.org/trunk@28646
git-svn-id: http://core.svn.wordpress.org/trunk@28464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-31 20:10:15 +00:00
Scott Taylor
327b38f298
In wp-admin/plugins.php
, break
is unreachabled after exit
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28311
git-svn-id: http://core.svn.wordpress.org/trunk@28139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 18:13:14 +00:00
Andrew Nacin
dce0b9adea
Use SSL when linking to WordPress.org. see #27115 .
...
Built from https://develop.svn.wordpress.org/trunk@27469
git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
John Blackbourn
4676621110
Fix bulk activation of network-only plugins. Fixes #26487 . Props dd32.
...
Built from https://develop.svn.wordpress.org/trunk@27413
git-svn-id: http://core.svn.wordpress.org/trunk@27260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 18:26:15 +00:00
Andrew Nacin
13e868ac55
Decrement update count bubbles as plugins/themes are updated, live.
...
props gcorne, mitchoyoshitaka.
fixes #17703 .
Built from https://develop.svn.wordpress.org/trunk@27280
git-svn-id: http://core.svn.wordpress.org/trunk@27136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 06:55:14 +00:00
Andrew Nacin
5f0981788d
Detect and handle symlinking of plugins in plugin_basename().
...
props rmccue, MikeSchinkel, jdgrimes.
see #16953 .
Built from https://develop.svn.wordpress.org/trunk@27158
git-svn-id: http://core.svn.wordpress.org/trunk@27024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-10 23:00:15 +00:00
Andrew Ozz
8d6059b383
Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
...
Built from https://develop.svn.wordpress.org/trunk@26518
git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Drew Jaynes
2768466674
Inline documentation for hooks in wp-admin/plugins.php.
...
Props a.hoereth and kpdesign for the initial patches.
Fixes #25836 .
Built from https://develop.svn.wordpress.org/trunk@26345
git-svn-id: http://core.svn.wordpress.org/trunk@26246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 23:04:10 +00:00
Dion Hulse
0fc053528f
Plugin Deletion: Remove the correct transient after demoving plugins. Props jdgrimes. Fixes #26069
...
Built from https://develop.svn.wordpress.org/trunk@26263
git-svn-id: http://core.svn.wordpress.org/trunk@26169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 04:17:09 +00:00
Andrew Nacin
fd57b239d2
Don't rely on include_path to include files.
...
Always use dirname() or, once available, ABSPATH.
props ketwaroo, hakre.
fixes #17092 .
Built from https://develop.svn.wordpress.org/trunk@25616
git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Andrew Nacin
797ee34bc3
Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Ryan Boren
c1bd9e3795
Show plugin activation message when activating a network only plugin on a single site installation.
...
Props nacin
fixes #22576
git-svn-id: http://core.svn.wordpress.org/trunk@22871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-27 16:08:35 +00:00
Andrew Nacin
7e4d3d4136
Only allow operations on network plugins through the network admin. see #21187 , for trunk.
...
git-svn-id: http://core.svn.wordpress.org/trunk@21740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 20:51:33 +00:00
nacin
9d20dfc4e1
Enforce multisite plugins menu preference in map_meta_cap(). This means a simple current_user_can('activate_plugins') check will handle the 'Enable administration menus' setting.
...
Remove bogus checks for enabling/disabling the 'themes' menu (something core does not handle out of the box) when in the network admin.
fixes #21123 .
git-svn-id: http://core.svn.wordpress.org/trunk@21198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-30 12:40:25 +00:00
nacin
9dc633d261
Add space between 'Plugins' title and 'Add New' button on plugins.php, like all other screens. [20868] was not meant to hit the 3.3 branch.
...
git-svn-id: http://core.svn.wordpress.org/trunk@20871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-24 07:05:32 +00:00
nacin
3dadfd1316
Add missing variable.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-19 06:38:19 +00:00
nacin
c23bf21079
Clean up plugins.php with regards to recently edited files, deactivations, and the network admin. see #20468 , #20104 .
...
* Limit recently_activated to the site dashboard, and properly remove bulk-activated plugins from the array.
* Remove code used from before the network admin, such as the unused 'network' plugin_status.
* Don't try to deactivate a plugin already deactivated.
* Use more specific caps (manage_network_plugins) rather than is_super_admin().
git-svn-id: http://svn.automattic.com/wordpress/trunk@20525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-19 03:41:29 +00:00
ryan
616c35e71c
One newline is enough.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan
07ff8b216b
Use one space, not two, after trailing punctuation. fixes #19537
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan
6bba5a265b
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 04:51:35 +00:00
nacin
65a10cedbb
Help tweaks for themes, plugins screens. props jane, see #19020 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 01:24:39 +00:00
ryan
efbbab1b3c
Help tabs. Props chexee. see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-24 00:21:39 +00:00
nacin
bfb98c193e
s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020 , #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan
3ad1f67958
Use add_help_sidebar(). see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
ryan
f1ec92751f
Use get method for plugin search form. Avoid lingering notices. Props garyc40. fixes #16549
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-18 19:18:08 +00:00
nacin
795ca8d394
Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 04:57:12 +00:00
nacin
653a6c1108
Match plugins-per-page viewed defaults when no user option exists. fixes #18878 for trunk.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-06 23:43:20 +00:00
azaozz
bbafdfa0e5
Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-03 04:00:57 +00:00
azaozz
3575537e5f
Add screen_options with contextual content, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 06:59:36 +00:00
ryan
3c930bc018
Fix redirects for plugin searches containing spaces in the search string. Props SergeyBiryukov. fixes #16548
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-21 21:04:12 +00:00
nacin
57a5e26a27
Search Installed Plugins, Search Installed Themes. props garyc40, fixes #16543 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-14 19:41:42 +00:00
westi
65e341d0cb
Fix typos and inconsistencies in PHPdoc / function declarations. See #17414 props duck_
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-14 09:50:20 +00:00
markjaquith
0e57bd3a37
Centralize pagination bound exceeding redirects for list tables. props garyc40. props johnjamesjacoby. fixes #16208
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 06:09:42 +00:00
koopersmith
2207bfe689
Admin Header 2: The Return of 32px Icons. Props, iammattthomas. see #17324 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 00:22:22 +00:00
ryan
e5ec44416a
Remove favorite_actions() from h2s. Restore Add New buttons. see #17324
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-10 19:18:16 +00:00
dd32
dad316dccc
* Allow Pagination for Must-Use/Dropin plugins
...
* Respect WP_CONTENT_DIR & WPMU_PLUGIN_DIR for help text
* Move help text into WP_Plugins_List_Table
See #17327
git-svn-id: http://svn.automattic.com/wordpress/trunk@17806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-05 05:24:15 +00:00
markjaquith
8d87f5dcb4
Big UI style update. props koopersmith. see #17324
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 20:15:05 +00:00
nacin
1cdd5ad41a
Remove more E_RECOVERABLE_ERROR checks. props duck_, see #16920 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-12 09:21:13 +00:00
nacin
37075f7f71
Remove AJAX from list tables. first pass. see #16262 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
markjaquith
8e2683d127
Add "paged param is greater than total pages" redirects to a few more screens. props greuben. fixes #16187
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 00:03:38 +00:00
nacin
a4306e1f57
br tags must self close. props blamescribu. see #16095 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-05 03:52:36 +00:00