Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Sergey Biryukov
203b275658
Bundled Themes: Change tag cloud format to a list (<ul>
) for better semantics and accessibility.
...
List markup allows screen reader users to know in advance how many tags are within the list.
Props xkon, davidakennedy.
Fixes #40138 .
Built from https://develop.svn.wordpress.org/trunk@41756
git-svn-id: http://core.svn.wordpress.org/trunk@41590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 23:53:47 +00:00
Dominik Schilling
64fc7294b6
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@32116
git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Lance Willett
ff5628169e
Twenty Ten: fix escaping and minor code style issues. See #29127 .
...
Built from https://develop.svn.wordpress.org/trunk@31266
git-svn-id: http://core.svn.wordpress.org/trunk@31247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:42:44 +00:00
Lance Willett
609335eef1
Twenty Ten and Eleven: don't display modified excerpt link in wp-admin.
...
Props kraftbj, fixes #30026 .
Built from https://develop.svn.wordpress.org/trunk@30145
git-svn-id: http://core.svn.wordpress.org/trunk@30145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 03:40:25 +00:00
Andrew Nacin
f5eb32ec6b
Default themes: Don't use /** docblocks for simple multiline comments.
...
props DrewAPicture, ericlewis.
fixes #25256 .
Built from https://develop.svn.wordpress.org/trunk@25746
git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett
6268f714e0
Twenty Ten: update code comments to reflect WP inline docs standards. Props DrewAPicture, closes #25256 .
...
Built from https://develop.svn.wordpress.org/trunk@25627
git-svn-id: http://core.svn.wordpress.org/trunk@25544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 17:04:10 +00:00
Lance Willett
0767933d3a
Twenty Ten: call get_post_galleries()
correctly now that it has new arguments, and use a more accurate function_exists
call. Props kovshenin, closes #23617 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 21:57:49 +00:00
Lance Willett
3066066fae
Twenty Ten: fix style element ID attribute value, see #24033 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 21:02:53 +00:00
Lance Willett
245c2111f0
Bundled themes: add identifier to style
elements added by the theme. Fixes #24033 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-16 17:18:30 +00:00
Lance Willett
5697b2f828
Twenty Ten: improve how gallery image IDs are retrieved for use in the Gallery post format template. Props to obenland for original patch, fixes #23617 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-27 20:37:34 +00:00
Lance Willett
399ab4bb59
Twenty Ten and Twenty Eleven: revert r23720 and r23721 ( closes #23772 ) and r23718 and r23719 ( closes #23774 ).
...
Unfortunately, it's too late for these improvements in older themes since it's very likely they'll adversely affect child themes.
git-svn-id: http://core.svn.wordpress.org/trunk@23778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-22 16:15:24 +00:00
Lance Willett
f4b2484cc9
Twenty Ten: use callback in functions.php to enqueue scripts and styles rather than putting them directly in header.php template file. Props obenland, fixes #23772 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 18:24:45 +00:00
Lance Willett
24e099bb3e
Twenty Ten: use a filter to modify the output of wp_title()
. Props obenland, closes #23774 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 18:16:47 +00:00
Lance Willett
c615bf76e4
Twenty Ten: add helpful descriptions to sidebars. Fixes #15401 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-22 17:32:48 +00:00
Lance Willett
f3cfd63822
Bundled Themes: allow show_home
argument to be overridden when using wp_page_menu
as a fallback to a Custom Menu. Props SergeyBiryukov and kovshenin, fixes #22331 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-02 16:52:53 +00:00
lancewillett
27281f6fd1
Twenty Ten and Eleven: *_continue_reading_link() should be pluggable, fixes #16500 . Props nacin and SergeyBiryukov.
...
git-svn-id: http://core.svn.wordpress.org/trunk@21490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 18:21:58 +00:00
lancewillett
3c586888ad
Twenty Ten: code readability in twentyten_comment, props kovshenin, fixes #21474 . (And minor pinking shears.)
...
git-svn-id: http://core.svn.wordpress.org/trunk@21486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-09 17:22:44 +00:00
ryan
55958522c1
Back compat for bundled themes. Props nacin, SergeyBiryukov, kobenland. fixes #20768
...
git-svn-id: http://core.svn.wordpress.org/trunk@20983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 14:43:19 +00:00
ryan
0f1f59b092
Custom background fixes:
...
* Specify default background colors for the bundled themes.
* Change the default custom background callback to only operate on saved values, rather than default values.
* Prevent an unsaved default value from overriding a manually modified style.css file.
Props nacin, kobenland
fixes #20448
git-svn-id: http://core.svn.wordpress.org/trunk@20973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:31:50 +00:00
nacin
fa631702a6
Flexible heights for Twenty Ten's custom headers. see #20448 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-15 20:51:24 +00:00
nacin
0393394451
Twenty Ten: Remove $locale.php file support. see #20448 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-15 20:46:09 +00:00
nacin
359ed454b7
Callbacks for custom headers and custom backgrounds registered through add_theme_support() are now wp-head-callback, admin-head-callback, and admin-preview-callback. see #19910 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-21 03:36:17 +00:00
nacin
1a265e464c
Move Twenty Ten and the rest of Twenty Eleven to add_theme_support() for headers and backgrounds. props sabreuse for initial patch. fixes #20265 . see #20249 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 21:32:42 +00:00
ryan
dd64f17ab7
More consistent attribute escaping. Props nacin.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-10 19:18:51 +00:00
nacin
1154e4b468
Use get_template_directory() instead of TEMPLATEPATH in Twentys Ten and Eleven. props solarisssmoke, fixes #18071 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-25 04:42:16 +00:00
nacin
1687dd21b2
Back compat with the gallery_style filter in Twenty Ten. fixes #16610 for trunk.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-22 08:23:30 +00:00
nacin
4066dde395
Correct docs for TT version number. props Jayjdk, fixes #16087 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-03 22:47:05 +00:00
nacin
d1cc06bac1
Deprecate twentyten_remove_gallery_css in favor of the use_default_gallery_style filter. see #15103 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-10 19:27:12 +00:00
nacin
56264e107b
Allow the various header constants to be redefined in Twenty Ten. see #14903 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-02 00:17:12 +00:00
nacin
72a354331b
Add a simple filter to allow removing the recent comments default widget styles. fixes #15493 , see #14876 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-21 13:55:11 +00:00
nacin
27cb70434a
Twenty Ten code cleanups. props lancewillett, fixes #15476 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 05:37:47 +00:00
markjaquith
7616a6cafb
Add Post Format support to TwentyTen. Can now use this to designate an Aside or a Gallery! see #14746
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-05 02:25:41 +00:00
markjaquith
17fbb0e123
add_theme_support( 'post-formats', array( 'aside', 'image', 'etc' ) ); Add UI for choosing a post format, and save the choice. see #14746
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 07:41:07 +00:00
nacin
a07ec69bce
Add a class to 'Your comment is awaiting moderation' in the comment walker and Twenty Ten's callback. fixes #15206 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 03:58:51 +00:00
nacin
9f9f5205b0
Fix some encoding issues. props hakre, fixes #14735 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 09:54:17 +00:00
nacin
c43b5bc26b
Update to Twenty Ten 1.0.3 from theme dir. see #14284 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-12 19:40:21 +00:00
nacin
0b6be7ff26
In Twenty Ten, don't use the filter on wp_title in feeds.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-15 12:27:07 +00:00
wpmuguru
b7432248ba
arrange twentyten strings for easier translation, props zeo, fixes #13824
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 16:15:25 +00:00
nacin
4e15eaa830
Use a switch. props jdub, see #13812 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 03:34:52 +00:00
iammattthomas
848d51b83a
Avoid displaying custom comment types as pingbacks/trackbacks in Twenty Ten. Fixes #13812 . Props jdub.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 02:17:26 +00:00
nacin
4c53975440
Use wp_title() proper in Twenty Ten, and move the janky stuff to a filter. see #13751 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-10 18:26:53 +00:00
nacin
e13e6254dc
Switch to current_theme_supports(menus) internally. Adding theme support for 'nav-menus' is deprecated in favor of register_nav_menu(s). fixes #13825 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-10 17:57:30 +00:00
nacin
338a869b8f
Don't show 'Continue reading' in Twenty Ten on attachment pages. props iandstewart, fixes #13361 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-02 22:41:14 +00:00
wpmuguru
84739b1583
continue reading link on custom excerpt in TwentyTen, props iandstewart, fixes #13361
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-28 17:01:27 +00:00
markjaquith
e18c9ba08a
Do not display category blurb for post types that do not support that taxonomy.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 20:06:54 +00:00
ryan
d017a8aa0e
Custom header fixes and rework. Props ocean90. fixes #13231
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-25 22:05:51 +00:00
nacin
aefb552495
Always show 'Continue reading' link when dealing with excerpts in Twenty Ten. props iandstewart, fixes #13361 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-25 16:08:44 +00:00
nacin
c83e17c1ce
Some menu string improvements. props JohnONolan. see #13378 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-24 09:26:41 +00:00