Commit Graph

64 Commits

Author SHA1 Message Date
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Andrew Ozz
35d5911ae8 Privacy: fixes for the privacy policy guide and suggested content:
- Separate the guide text form the suggested policy text.
- Add table of content for easier navigation.
- Move the content to tools.php (prevents the settings menu of being open).
- Add a link to the guide from the Privacy settings screen.

Props melchoyce, azaozz.
See #43980.
Built from https://develop.svn.wordpress.org/trunk@43203


git-svn-id: http://core.svn.wordpress.org/trunk@43032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-05-09 20:51:23 +00:00
Andrew Ozz
a5f8097899 Retire Press This and extract it to a plugin. First run.
Props kraftbj, azaozz.
See #41689.
Built from https://develop.svn.wordpress.org/trunk@41584


git-svn-id: http://core.svn.wordpress.org/trunk@41417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-09-24 14:22:54 +00:00
Andrea Fercia
d65a038ca3 Accessibility: Remove target=_blank from the Plugins, Themes, Media, Update, and Tools screens help tabs links.
Stop taking control of users' browsers.

Props rianrietveld.
Fixes #38215. See #23432.

Built from https://develop.svn.wordpress.org/trunk@38722


git-svn-id: http://core.svn.wordpress.org/trunk@38665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-04 07:08:29 +00:00
Andrea Fercia
eeefec932f Administration: Improve the usage of the button CSS classes.
Introduces some consistency in the usage of the button CSS classes, fixes the
focus style for accessibility and responsiveness of the buttons.

- Adds the `button` class to all primary buttons make them responsive
- Removes all `secondary-button` classes and replaces it with button when needed. `button-secondary` shouldn't be used and exists just for backward compatibility reasons
- Replaces classes inside `submit_button()` with a shorthand for some buttons, and use an empty string for the default `button` class. Passing `button` is unnecessary
- Adjusts `get_submit_button()` to remove empty items

Props iseulde, dimchik, chris_d2d, mhowell, afercia.
Fixes #27314, #37138, #37448.

Built from https://develop.svn.wordpress.org/trunk@38672


git-svn-id: http://core.svn.wordpress.org/trunk@38615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-28 19:54:28 +00:00
Sergey Biryukov
82a8cec3b3 Bump H3 headings to H2 on Tools screen for better accessibility.
props Cheffheid.
fixes #33607.
Built from https://develop.svn.wordpress.org/trunk@33819


git-svn-id: http://core.svn.wordpress.org/trunk@33787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 03:32:21 +00:00
Konstantin Obenland
7dc1d06e64 Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Dominik Schilling
64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Sergey Biryukov
633241e60d Press This: Use more accurate wording on Tools screen.
props kraftbj.
see #31836.
Built from https://develop.svn.wordpress.org/trunk@31980


git-svn-id: http://core.svn.wordpress.org/trunk@31959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 01:30:28 +00:00
Andrew Ozz
7d9eee8920 Press This: fix styling on the Tools screen.
Props Michael-Arestad, see #31462.
Built from https://develop.svn.wordpress.org/trunk@31806


git-svn-id: http://core.svn.wordpress.org/trunk@31788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 01:58:27 +00:00
Andrew Ozz
5080f1e3af PressThis: improve translatable strings on the Tools screen.
Props: afercia. See #28873.
Built from https://develop.svn.wordpress.org/trunk@31768


git-svn-id: http://core.svn.wordpress.org/trunk@31748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 17:31:28 +00:00
Andrew Ozz
4593319ea7 PressThis: accessibility enhancements:
- Add missing form labels.
- Add some screen-reader-text and aria-hidden attributes.
- Focus handling improvements.
- Change tagcloud-link into a button.
- Add missing ID attribute in tools.php.
Props afercia. Fixes #31449.
Built from https://develop.svn.wordpress.org/trunk@31566


git-svn-id: http://core.svn.wordpress.org/trunk@31547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 02:50:25 +00:00
Andrew Ozz
1857055bb8 PressThis v2, first run. Props michael-arestad, stephdau, marcelomazza, DrewAPicture, iseulde, afercia, kraftbj, rachelbaker, AramZS, dd32. See #31373.
Built from https://develop.svn.wordpress.org/trunk@31534


git-svn-id: http://core.svn.wordpress.org/trunk@31515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-25 01:50:26 +00:00
Andrew Nacin
dce0b9adea Use SSL when linking to WordPress.org. see #27115.
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Andrew Ozz
8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Drew Jaynes
7ea6cb4dd6 Inline documentation for hooks in wp-admin/tool.php.
Props dougwollison for the initial patch.
Fixes #25496.

Built from https://develop.svn.wordpress.org/trunk@25937


git-svn-id: http://core.svn.wordpress.org/trunk@25896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 19:23:09 +00:00
Andrew Nacin
fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Helen Hou-Sandí
b538d6163f Make sure .widefat border and background coloring only applies to tables. props MikeHansenMe. fixes #21936.
git-svn-id: http://core.svn.wordpress.org/trunk@23315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-22 14:44:04 +00:00
ryan
7492cefdf5 Update contextual help for Tools screen. Props SergeyBiryukov, ajacommerce, DrewAPicture. fixes #19523
git-svn-id: http://core.svn.wordpress.org/trunk@20727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-05 19:09:08 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan
340e93324c Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-14 17:36:38 +00:00
nacin
3d51303ca3 Help tweaks for users, tools. props jane, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 01:17:14 +00:00
koopersmith
68a166cca7 Update help content for tools page. props Ipstenu, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-28 16:44:08 +00:00
azaozz
96681a7e56 Extend the workaround for adding the Press This bookmarklet to IE, props dllh SergeyBiryukov, fixes #18487
git-svn-id: http://svn.automattic.com/wordpress/trunk@19387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 22:23:39 +00:00
nacin
bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan
3ad1f67958 Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
azaozz
d697ce638b Make copying the PressThis bookmarklet code easier in WebKit browsers, fixes #17184
git-svn-id: http://svn.automattic.com/wordpress/trunk@18187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-08 01:33:07 +00:00
azaozz
af360e4077 Remove the title attribute from the Press This link as it needlessly repeats the text, props johnjamesjacoby, fixes #17184
git-svn-id: http://svn.automattic.com/wordpress/trunk@18160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-06 02:36:00 +00:00
westi
1443193079 Help Tab text updatates. Fixes #17312 prop dougwrites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-01 15:37:04 +00:00
nacin
9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
markjaquith
cefee535db Do not allow the Press This links to be click-activated when they are meant to be dragged. fixes #17192. see #17184
git-svn-id: http://svn.automattic.com/wordpress/trunk@17666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 17:43:01 +00:00
azaozz
b3bb537735 Press This bookmarklet redesign, props chexee, fixes #17184
git-svn-id: http://svn.automattic.com/wordpress/trunk@17662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 07:24:11 +00:00
nacin
1cd758dc89 Help text edits. props dougwrites, fixes #15346.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:37:03 +00:00
nacin
6f289a7be8 Check for the import cap before showing links to the tag/cat converter. props kpdesign, fixes #13834.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 00:00:47 +00:00
nacin
34c1fa6d0b target=blank for help. props jorbin, see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 21:00:39 +00:00
nacin
7fd6e707da Help text typo fixes. props jorbin, dougwrites. see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 19:20:52 +00:00
nbachiyski
bb00d56a67 Menu translatable strings cleanup.
* Take out <strong> of the translatable part of For more information:
 * Include support forums and Codex links inside translations, because most translators would want to change them to their local documentation sites or Codex prefixes


git-svn-id: http://svn.automattic.com/wordpress/trunk@14989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 11:52:15 +00:00
nacin
9b5a7d01be Remove stray tag. props Daniel Koskinen, fixes #13570.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 06:16:48 +00:00
nacin
5398fafd1b Revert [14853], [14778], returning tag/cat converter to tools.php and edit-tags.php. Link to import.php instead of the converter directly as it may not be installed. see #13566.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 04:35:11 +00:00
ryan
9ed7d1337e Tools help. Props duck_. see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@14966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 22:18:19 +00:00
ryan
52b3a741d5 Remove cat/tag importer from list of tools. see #13465
git-svn-id: http://svn.automattic.com/wordpress/trunk@14778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-21 14:17:41 +00:00
nacin
af91e5264a Move taxonomy object properties for capabilities into a cap object. Capabilities can be specified via ['capabilities'] (an array keyed by the generic cap name) for register_taxonomy. fixes #13358.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-13 04:10:17 +00:00
nacin
e64a657575 s/blog/site/ in even more places. props PeteMall, see #11644.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-30 03:17:49 +00:00
nacin
6ec7cb4540 Use relative paths when including files, avoiding include_path. fixes #12594, props sorich87.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 06:14:45 +00:00
nacin
2501fac129 Remove Gears from UI. see #11301
git-svn-id: http://svn.automattic.com/wordpress/trunk@13981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-04 00:48:28 +00:00
nacin
2ab1e7d4e8 Update string to better reflect the times. see #11301
git-svn-id: http://svn.automattic.com/wordpress/trunk@13834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 21:07:12 +00:00
ryan
e25a65b36a Trim trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@13733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-17 16:27:25 +00:00
nacin
0c4cbd663a Remove orphaned Turbo/Gears message in Opera. see #11301
git-svn-id: http://svn.automattic.com/wordpress/trunk@13524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-01 07:15:15 +00:00
dd32
2cc01f59cb Add Tag::Cat converters to the Tools page. Props ninjaWR. Add Tag->Cat converter links on Manage Tags page. Fixes #8634
git-svn-id: http://svn.automattic.com/wordpress/trunk@13450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-27 04:04:36 +00:00
azaozz
de6b730d1f screen_icon() after <div class="wrap">, props johnbillion, fixes #10795
git-svn-id: http://svn.automattic.com/wordpress/trunk@11940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-09-16 03:13:21 +00:00