Commit Graph

20 Commits

Author SHA1 Message Date
Sergey Biryukov
7932193708 Coding Standards: Use strict comparison where static strings are involved.
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47808


git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
38676936ba Coding Standards: Use strict type check for in_array() and array_search() where strings are involved.
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.

Includes minor code layout fixes for better readability.

See #49542.
Built from https://develop.svn.wordpress.org/trunk@47550


git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov
e199663322 I18N: Capitalize translator comments consistently, add trailing punctuation.
Includes minor code layout fixes.

See #44360.
Built from https://develop.svn.wordpress.org/trunk@45932


git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Gary Pendergast
c71bc1513e Coding Standards: Add missing translator comments to the default themes.
All default themes now have translator comments for all strings with placeholders!

See #46732.

Built from https://develop.svn.wordpress.org/trunk@45609


git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Sergey Biryukov
37f04694d5 Bundled Themes: Use consistent HTML comments after closing HTML tags.
Props iamdmitrymayorov.
Fixes #46871.
Built from https://develop.svn.wordpress.org/trunk@45209


git-svn-id: http://core.svn.wordpress.org/trunk@45018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-16 01:30:53 +00:00
Gary Pendergast
7a617078fa Coding Standards: Upgrade WPCS to 1.2.1.
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.


Built from https://develop.svn.wordpress.org/trunk@44574


git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
John Blackbourn
64fb3e7175 In Twenty Fourteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised.
See #30641

Built from https://develop.svn.wordpress.org/trunk@30796


git-svn-id: http://core.svn.wordpress.org/trunk@30786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-09 18:57:24 +00:00
Lance Willett
f398bd07ce Twenty Fourteen: replace ellipses appended to automatically generated excerpts with both ellipses and a "Continue Reading" link to meet accessibility-ready requirements.
Props davidakennedy, lancewillett. Fixes #30176.
Built from https://develop.svn.wordpress.org/trunk@30389


git-svn-id: http://core.svn.wordpress.org/trunk@30386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 18:27:22 +00:00
Lance Willett
2291d479af Twenty Fourteen: simplify tags output in content templates, props nacin. See #26093.
Built from https://develop.svn.wordpress.org/trunk@26258


git-svn-id: http://core.svn.wordpress.org/trunk@26164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 22:48:10 +00:00
Lance Willett
0f8be808ff Twenty Fourteen: fix case of featured posts has_tag() check that was adding an empty footer element. See #25868, props iamtakashi.
Built from https://develop.svn.wordpress.org/trunk@26048


git-svn-id: http://core.svn.wordpress.org/trunk@25973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-08 05:54:10 +00:00
Lance Willett
26c7409f9c Twenty Fourteen: clean up inconsistencies in content template files. Props iamtakashi, fixes #25868.
Built from https://develop.svn.wordpress.org/trunk@26036


git-svn-id: http://core.svn.wordpress.org/trunk@25965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-07 19:05:09 +00:00
Andrew Nacin
d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Lance Willett
f98e6f60fb Twenty Fourteen: better logic for featured image HTML output, and add fallback message for focusable anchor elements, for accessibility. Fixes #25325.
Built from https://develop.svn.wordpress.org/trunk@25802


git-svn-id: http://core.svn.wordpress.org/trunk@25714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-15 23:24:10 +00:00
Lance Willett
eaf78d3f7c Twenty Fourteen: first pass for updating code comments to reflect WP inline docs standards, see #25257.
Built from https://develop.svn.wordpress.org/trunk@25769


git-svn-id: http://core.svn.wordpress.org/trunk@25682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 22:02:11 +00:00
Lance Willett
c78cbb19ce Twenty Fourteen: allow pages to have featured images, props iamtakashi. Fixes #25325.
Built from https://develop.svn.wordpress.org/trunk@25735


git-svn-id: http://core.svn.wordpress.org/trunk@25648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-08 21:22:10 +00:00
Lance Willett
7a05f8d19c Twenty Fourteen: Align post format handling with Twenty Thirteen. Props Frank Klein and obenland, see #24877.
Built from https://develop.svn.wordpress.org/trunk@25088


git-svn-id: http://core.svn.wordpress.org/trunk@25072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 17:03:10 +00:00
Lance Willett
e5c55b09e9 Twenty Fourteen: first pass at matching code standards achieved with Twenty Thirteen development. See #24858, props obenland.
Built from https://develop.svn.wordpress.org/trunk@25021


git-svn-id: http://core.svn.wordpress.org/trunk@25012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:29 +00:00
Lance Willett
7d35419e62 Importing the Further theme, first pass at the new default theme for 2014.
A magazine theme with clean, responsive design focused on highlighting featured content prominently on home page.

This is slated for 3.8. Development will occur in trunk for the theme, and in plugins for the nice-to-have features.

Nice-to-have improvements include:

- Add a Contributors page template to highlight authors.
- Easy-to-manage featured content.
- Add support for an Authors widget to highlight authors.

Welcome, Twenty Fourteen né Further. Props iamtakashi, see #24858.


git-svn-id: http://core.svn.wordpress.org/trunk@24832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 22:55:10 +00:00