Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-17 16:15:24 +01:00
Code Issues Projects Releases Wiki Activity
30,029 Commits 50 Branches 748 Tags 792 MiB
5c6b63d3a6
Commit Graph

112 Commits

Author SHA1 Message Date
Dominik Schilling
df11970e18 Nav menus: Introduce a wp_get_nav_menu_object filter in wp_get_nav_menu_object() to filter the retrieved nav_menu term. 
props westonruter.
fixes #32629.
Built from https://develop.svn.wordpress.org/trunk@32764


git-svn-id: http://core.svn.wordpress.org/trunk@32735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 17:37:25 +00:00
Dominik Schilling
55f3b68c75 Nav Menus: Update wp_setup_nav_menu_item() to stop overriding empty properties from supplied $menu_item. 
Update docs for `WP_Post` constructor to indicate that `WP_Post|object` can be the supplied param, as opposed to just `WP_Post`.

props westonruter.
fixes #32632.
Built from https://develop.svn.wordpress.org/trunk@32762


git-svn-id: http://core.svn.wordpress.org/trunk@32733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 10:53:25 +00:00
Dominik Schilling
792295d077 Nav menus: Apply the wp_get_nav_menu_items filter also on an empty list of menu items. 
props westonruter.
fixes #32631.
Built from https://develop.svn.wordpress.org/trunk@32748


git-svn-id: http://core.svn.wordpress.org/trunk@32719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:38:25 +00:00
Dominik Schilling
33c1c76001 Nav menu: Introduce a has_nav_menu filter in has_nav_menu() to filter whether a nav menu is assigned to a specified location. 
props westonruter.
fixes #32630.
Built from https://develop.svn.wordpress.org/trunk@32746


git-svn-id: http://core.svn.wordpress.org/trunk@32717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-13 14:15:25 +00:00
Scott Taylor
cb0b0b109d Fix doc blocks for nav-menu*.php files. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32612


git-svn-id: http://core.svn.wordpress.org/trunk@32582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-26 22:10:25 +00:00
Boone Gorges
fbf16573ee When priming the cache for taxonomy term nav items, don't fetch term descendants. 
Descending the term tree causes unnecessary database queries when priming the
cache for a term with many descendants.

Fixes #31724.
Built from https://develop.svn.wordpress.org/trunk@32294


git-svn-id: http://core.svn.wordpress.org/trunk@32265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-24 18:58:27 +00:00
Helen Hou-Sandí
296dba2804 Nav menus: Return to calling links "Custom Links". 
It was like this before 3.6 and got a bit lost during that development cycle. Also uses the terminology more consistently in the nav menu UI.

props tyxla.
fixes #31344.

Built from https://develop.svn.wordpress.org/trunk@31748


git-svn-id: http://core.svn.wordpress.org/trunk@31729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-12 06:15:27 +00:00
Sergey Biryukov
6221fc86a3 Fix a typo in wp_update_nav_menu_item hook documentation. 
props tyxla.
fixes #31338.
Built from https://develop.svn.wordpress.org/trunk@31521


git-svn-id: http://core.svn.wordpress.org/trunk@31502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-23 16:51:25 +00:00
Scott Taylor
60b0cd7943 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Drew Jaynes
4fd64b94d7 4.1 Docs Audit: Formatting, line-wrap, and other fixes for the wp_get_nav_menus() DocBlock. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30619


git-svn-id: http://core.svn.wordpress.org/trunk@30609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:15:23 +00:00
Sergey Biryukov
aad05ece16 Set min-height for menu item title. Add a fallback for empty-titled items. 
props philiparthurmoore.
fixes #30283.
Built from https://develop.svn.wordpress.org/trunk@30500


git-svn-id: http://core.svn.wordpress.org/trunk@30489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 05:57:22 +00:00
Drew Jaynes
f8657d5890 Remove redundant and erroneous @uses tag from most core inline documentation. 
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.

Built from https://develop.svn.wordpress.org/trunk@30105


git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 01:05:24 +00:00
Drew Jaynes
96fb9e36a2 Fix the $location parameter type in the unregister_nav_menu() DocBlock. 
`$location` is a string, not an array.

Props ipm-frommen.
Fixes #30098.

Built from https://develop.svn.wordpress.org/trunk@30019


git-svn-id: http://core.svn.wordpress.org/trunk@30019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-25 13:43:18 +00:00
Drew Jaynes
cdf9456b79 Clarify inline documentation for the _is_valid_nav_menu_item() and wp_get_nav_menu_items() in wp-includes/nav-menu.php. 
Props morganestes for the initial patch.
Fixes #29914.

Built from https://develop.svn.wordpress.org/trunk@29868


git-svn-id: http://core.svn.wordpress.org/trunk@29628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-10 17:14:19 +00:00
Drew Jaynes
bf52618636 Update documentation for wp_get_nav_menus() to reflect that the default value for the the 'orderby' argument was changed from 'none' to 'name' in 4.1. 
Props curtjen.
Fixes #29460.

Built from https://develop.svn.wordpress.org/trunk@29796


git-svn-id: http://core.svn.wordpress.org/trunk@29565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 23:35:17 +00:00
Sergey Biryukov
504d4ad5eb Change the default orderby value in wp_get_nav_menus() to 'name'. 
props voldemortensen, igmoweb.
fixes #29460.
Built from https://develop.svn.wordpress.org/trunk@29792


git-svn-id: http://core.svn.wordpress.org/trunk@29564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-29 15:45:16 +00:00
Sergey Biryukov
f84cbb4ba8 Use get_registered_nav_menus() in has_nav_menu(). 
props voldemortensen.
fixes #29461.
Built from https://develop.svn.wordpress.org/trunk@29717


git-svn-id: http://core.svn.wordpress.org/trunk@29491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-09-07 10:04:16 +00:00
Scott Taylor
69b0077edf return false in has_nav_menu() if the $location does not exist in the $_wp_registered_nav_menus global. 
Props SergeyBiryukov.
Fixes #27735.

Built from https://develop.svn.wordpress.org/trunk@28836


git-svn-id: http://core.svn.wordpress.org/trunk@28640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-26 00:57:15 +00:00
Scott Taylor
7b83df547d Simplify the setting of $args['include'] in wp_get_nav_menu_items(). 
Props UmeshSingla.
Fixes #28515.

Built from https://develop.svn.wordpress.org/trunk@28825


git-svn-id: http://core.svn.wordpress.org/trunk@28629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 17:17:14 +00:00
Sergey Biryukov
7214648764 Correct @return value for wp_create_nav_menu() and wp_delete_nav_menu(). 
props Tmeister.
fixes #27745.
Built from https://develop.svn.wordpress.org/trunk@28242


git-svn-id: http://core.svn.wordpress.org/trunk@28070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-02 11:59:14 +00:00
Drew Jaynes
513d8702f6 Inline documentation for hooks in wp-includes/nav-menu.php. 
Props dustyf, kpdesign.
Fixes #27367.

Built from https://develop.svn.wordpress.org/trunk@27700


git-svn-id: http://core.svn.wordpress.org/trunk@27539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-25 09:04:14 +00:00
Andrew Nacin
08db3b53c5 Explicitly assign menu term relationship rather than piggybacking on wp_insert_post() with the tax_input argument. 
That argument currently depends on user context (see #19373).

Adds unit test for properly updating orphaned menu items.

props danielbachhuber.
fixes #27113.

Built from https://develop.svn.wordpress.org/trunk@27556


git-svn-id: http://core.svn.wordpress.org/trunk@27399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-15 06:07:16 +00:00
Sergey Biryukov
19be701a86 Consistently return a WP_Error object in case of an error in wp_update_nav_menu_item(). 
props bootsz, ocean90.
fixes #21652.
Built from https://develop.svn.wordpress.org/trunk@27251


git-svn-id: http://core.svn.wordpress.org/trunk@27108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 00:51:13 +00:00
Andrew Nacin
635e50d9a1 Remove theme support for 'menus' in unregister_nav_menu() when there are no more menus. 
props kovshenin.
fixes #26900.

Built from https://develop.svn.wordpress.org/trunk@27220


git-svn-id: http://core.svn.wordpress.org/trunk@27077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-21 18:14:14 +00:00
Dominik Schilling
31d1f909a4 Nav Menu: Remove post/page items from the Nav Menu when the post/page is deleted. 
This was broken through a change in [25163]. `_menu_item_object` in wp_get_associated_nav_menu_items() is not relevant for post types.
Adds unit tests.

props UmeshSingla for initial patch.
fixes #26795.
Built from https://develop.svn.wordpress.org/trunk@27150


git-svn-id: http://core.svn.wordpress.org/trunk@27017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-09 21:37:11 +00:00
Scott Taylor
d7cc1f506a Introduce wp_using_ext_object_cache() - mimic wp_suspend_cache_invalidation() and discourage direct access to $_wp_using_ext_object_cache, cleaning up importing of globals in functions and provides function to modify that global. Loads the packaged object cache when an external cache hasn't been loaded or doesn't contain wp_cache_init(). 
Fixes #21401.


Built from https://develop.svn.wordpress.org/trunk@25289


git-svn-id: http://core.svn.wordpress.org/trunk@25253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-06 18:10:09 +00:00
Andrew Nacin
0d9fcbd841 Use get_nav_menu_locations() in wp_delete_nav_menu(). 
props nofearinc.
see #25064.

Built from https://develop.svn.wordpress.org/trunk@25196


git-svn-id: http://core.svn.wordpress.org/trunk@25168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-31 01:39:09 +00:00
Scott Taylor
eeb3b15936 Pass the taxonomy around to relevant nav menu actions to avoid arbitrarily deleting all items with menu-item-type of taxonomy. Adds unit test for wp_get_associated_nav_menu_items(). 
Props garyc40, SergeyBiryukov.
Fixes #15264.


Built from https://develop.svn.wordpress.org/trunk@25163


git-svn-id: http://core.svn.wordpress.org/trunk@25142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-29 16:45:10 +00:00
Mark Jaquith
92af914abe Keep the Nav Menu walker from blowing up the layout on empty-titled items. 
fixes #23254. props cais, SergeyBiryukov.

git-svn-id: http://core.svn.wordpress.org/trunk@24560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-05 15:41:46 +00:00
Sergey Biryukov
4b174612ab Prevent menu items with '0' label from being removed on menu saving. props MikeHansenMe, kovshenin. fixes #23051. 
git-svn-id: http://core.svn.wordpress.org/trunk@24235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-10 18:03:09 +00:00
Sergey Biryukov
15e919bd24 Use correct variable. fixes #24014. see #23119. 
git-svn-id: http://core.svn.wordpress.org/trunk@23941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-09 20:50:45 +00:00
Andrew Nacin
10d898ecbb Remove _wp_delete_nav_menu(). wp_delete_nav_menu() should instead remove the menu from theme locations, which was the only difference between the functions. see #23119. 
git-svn-id: http://core.svn.wordpress.org/trunk@23897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-04 04:28:12 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Sergey Biryukov
87f2c02462 Ensure that get_nav_menu_locations() always returns an array. props JustinSainton for initial patch. fixes #23508. 
git-svn-id: http://core.svn.wordpress.org/trunk@23550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 15:51:16 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Jon Cave
ae96b842f9 Correctly associate new menu items with a menu when using wp_update_nav_menu_item() 
wp_update_nav_menu_item() must pass tax_input to wp_insert_post() when creating items
otherwise the menu-item relationship isn't made.

See #22189.


git-svn-id: http://core.svn.wordpress.org/trunk@22399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-06 14:46:56 +00:00
Andrew Nacin
0ae808509c Optimize wp_update_nav_menu_item() for high performance. Only query items for a menu when we need them. Update items after updating its meta so the meta cache can be leveraged. see #22189. 
git-svn-id: http://core.svn.wordpress.org/trunk@22235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-15 14:27:16 +00:00
Andrew Nacin
6c56e0573c Prime post term caches for nav menu items. Avoid doing so in frontend template functions as it remains unneeded there. see #22189. 
git-svn-id: http://core.svn.wordpress.org/trunk@22233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-15 14:17:50 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
duck_
b225e5b626 Rescue those who created menu items before r18733. Trim menu item descriptions. See #16799. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-20 22:57:47 +00:00
duck_
bc3b3aed4d Make new nav menu items have a blank description and attr_title. See #16799. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-20 21:58:37 +00:00
nacin
61afb5def3 Check for WP_Error return values when using get_term_field() to set up nav menu items. fixes #17958 for trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-11 19:03:04 +00:00
ryan
4bb54d8f68 Improvements to invalid menu item handling. Props ocean90. fixes #13958 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-11 15:52:15 +00:00
ryan
46f63a6b1e Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-11 15:44:06 +00:00
nacin
d648585363 Mark menu items tied to invalid taxonomies and post types as invalid. props ocean90, see #13958. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-11 00:55:48 +00:00
nacin
148dac95df s/showposts/posts_per_page/ 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-13 05:25:00 +00:00
nacin
5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-07 11:21:11 +00:00
nacin
9f1d1ba7fa Add unregister_nav_menu(). props jorbin, fixes #14001 for 3.1. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-07-22 20:50:11 +00:00
nacin
f98fc6e766 Add missing filter to wp_get_nav_menu_items(). props filosofo, fixes #13858. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-14 20:50:55 +00:00