Sergey Biryukov
746ba4c9c4
Replace a second instance of <code>
in translatable string left in [35440].
...
Props ramiy.
See #34498 .
Built from https://develop.svn.wordpress.org/trunk@35445
git-svn-id: http://core.svn.wordpress.org/trunk@35409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:56:25 +00:00
Sergey Biryukov
2920285225
Don't use <strong>
in translatable string in wp-admin/includes/nav-menu.php
.
...
Add translator commment.
Props ramiy.
Fixes #34500 .
Built from https://develop.svn.wordpress.org/trunk@35444
git-svn-id: http://core.svn.wordpress.org/trunk@35408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:37:24 +00:00
Sergey Biryukov
bfbd9e3ec3
Don't use <a>
in translatable strings in `wp-admin/includes/dashboard.php'.
...
Add translator commments.
Props ramiy.
Fixes #34501 .
Built from https://develop.svn.wordpress.org/trunk@35443
git-svn-id: http://core.svn.wordpress.org/trunk@35407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:33:25 +00:00
Sergey Biryukov
a83a250ee0
Don't use <strong>
in translatable string in wp-admin/includes/nav-menu.php
.
...
Add translator commment.
Props ramiy.
Fixes #34500 .
Built from https://develop.svn.wordpress.org/trunk@35442
git-svn-id: http://core.svn.wordpress.org/trunk@35406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:17:26 +00:00
Sergey Biryukov
87105cdf24
Add <code>
tag missed in [35440].
...
See #34498 .
Built from https://develop.svn.wordpress.org/trunk@35441
git-svn-id: http://core.svn.wordpress.org/trunk@35405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:12:24 +00:00
Sergey Biryukov
58db99b512
Don't use <code>
in translatable strings in wp-admin/includes/class-wp-plugins-list-table.php
.
...
Add translator commments.
Props ramiy.
Fixes #34498 .
Built from https://develop.svn.wordpress.org/trunk@35440
git-svn-id: http://core.svn.wordpress.org/trunk@35404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 01:08:25 +00:00
Sergey Biryukov
1c21783283
Don't use <code>
in translatable string in wp-admin/includes/media.php
.
...
Add translator commment.
Props ramiy.
Fixes #34499 .
Built from https://develop.svn.wordpress.org/trunk@35439
git-svn-id: http://core.svn.wordpress.org/trunk@35403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 00:58:24 +00:00
Sergey Biryukov
e51f9061c5
Don't use <code>
in translatable strings in options-general.php
.
...
Add translator commments.
Props ramiy.
Fixes #34497 .
Built from https://develop.svn.wordpress.org/trunk@35438
git-svn-id: http://core.svn.wordpress.org/trunk@35402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-30 00:52:26 +00:00
Andrea Fercia
db8b09c40d
Media: Improve the headings hierarchy in the Media Views for better accessibility.
...
Fixes #34273 .
Built from https://develop.svn.wordpress.org/trunk@35427
git-svn-id: http://core.svn.wordpress.org/trunk@35391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 23:08:24 +00:00
Helen Hou-Sandí
68951bd30c
Buttons: Screen Options/Help shouldn't have active styling.
...
see #31459 .
Built from https://develop.svn.wordpress.org/trunk@35422
git-svn-id: http://core.svn.wordpress.org/trunk@35386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:26:24 +00:00
Scott Taylor
fc440ef0f0
Dashboard: cleanup after [35414].
...
Props afercia.
Fixes #33558 .
Built from https://develop.svn.wordpress.org/trunk@35420
git-svn-id: http://core.svn.wordpress.org/trunk@35384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 20:08:25 +00:00
Scott Taylor
f507751a40
Thickbox: spinner should disappear when loading is done.
...
Props niklasbr, afercia.
Fixes #33311 .
Built from https://develop.svn.wordpress.org/trunk@35418
git-svn-id: http://core.svn.wordpress.org/trunk@35382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 18:19:26 +00:00
Scott Taylor
70689237f3
Admin Menu: after [34861], prevent adjacent separators.
...
Props johnjamesjacoby.
Fixes #24104 .
Built from https://develop.svn.wordpress.org/trunk@35416
git-svn-id: http://core.svn.wordpress.org/trunk@35380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 18:06:24 +00:00
Scott Taylor
843d1c003b
Dashboard: make tags used for headings more semantic.
...
Props Cheffheid, afercia.
Fixes #33558 .
Built from https://develop.svn.wordpress.org/trunk@35414
git-svn-id: http://core.svn.wordpress.org/trunk@35378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 17:57:25 +00:00
Sergey Biryukov
8d0f76bc11
Settings: Don't display Site Address field description if WP_HOME
is defined and the field is disabled.
...
Props dipesh.kakadiya.
Fixes #33354 .
Built from https://develop.svn.wordpress.org/trunk@35411
git-svn-id: http://core.svn.wordpress.org/trunk@35375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-28 04:54:26 +00:00
Drew Jaynes
887dca222c
Docs: Standardize the file header for wp-admin/includes/ms-deprecated.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35407
git-svn-id: http://core.svn.wordpress.org/trunk@35371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-27 20:08:27 +00:00
Drew Jaynes
e3989c6194
Docs: Add a @subpackage
tag to the file header for wp-admin/includes/ms-admin-filters.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35403
git-svn-id: http://core.svn.wordpress.org/trunk@35367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-26 18:06:26 +00:00
Drew Jaynes
7a49f64cb9
Docs: Add a version to the file header for wp-admin/includes/revision.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35387
git-svn-id: http://core.svn.wordpress.org/trunk@35351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-24 18:29:25 +00:00
Scott Taylor
dc1e85a540
Nav Menus: show custom post type Archive item at the top of the View All
tab for the post type on the legacy Nav Menu screen.
...
Props aaroncampbell, DrewAPicture, seanchayes, hlashbrooke, paulwilde, ericlewis, raulillana
See #16075 .
Built from https://develop.svn.wordpress.org/trunk@35382
git-svn-id: http://core.svn.wordpress.org/trunk@35346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-24 17:46:25 +00:00
Sergey Biryukov
db2189e717
After [34891], rename new post type and taxonomy label keys to match the default strings.
...
See #32147 .
Built from https://develop.svn.wordpress.org/trunk@35376
git-svn-id: http://core.svn.wordpress.org/trunk@35340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 16:48:25 +00:00
Sergey Biryukov
654cb6542f
Docs: Correct the type and description of $post
parameter passed to the attachment_fields_to_save
filter.
...
Props swissspidy.
Fixes #34404 .
Built from https://develop.svn.wordpress.org/trunk@35374
git-svn-id: http://core.svn.wordpress.org/trunk@35338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 13:01:25 +00:00
Sergey Biryukov
dcf2676b16
Docs: Use consistent naming and capitalization of menu names in add_submenu_page()
wrappers.
...
Props atomicjack, Mckilem.
Fixes #34360 .
Built from https://develop.svn.wordpress.org/trunk@35373
git-svn-id: http://core.svn.wordpress.org/trunk@35337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 12:02:24 +00:00
Dion Hulse
c9d0c0a9bd
Updates: Add a generic failure case to the ajax update endpoint for when the WP_Error
value hasn't been found.
...
See #34403
Built from https://develop.svn.wordpress.org/trunk@35371
git-svn-id: http://core.svn.wordpress.org/trunk@35335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 07:35:25 +00:00
Dion Hulse
d2aca078b6
Comments: Use a full URL rather than a relative one for links which can contain IPv6 addresses to avoid an issue where the URL was being eaten by escaping functions.
...
See #34407 , #34202
Fixes #34054
Built from https://develop.svn.wordpress.org/trunk@35368
git-svn-id: http://core.svn.wordpress.org/trunk@35332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-23 05:14:25 +00:00
Scott Taylor
2afbf378d9
Plugins: after [35151], set default $restrict_network_*
values to prevent notices.
...
Props johnjamesjacoby.
Fixes #20104 .
Built from https://develop.svn.wordpress.org/trunk@35361
git-svn-id: http://core.svn.wordpress.org/trunk@35327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:56:23 +00:00
Scott Taylor
e31c837d70
Options: remove old 'gzipcompression' and 'advanced_edit' options.
...
Props chriscct7, solarissmoke.
Fixes #12996 .
Built from https://develop.svn.wordpress.org/trunk@35360
git-svn-id: http://core.svn.wordpress.org/trunk@35326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:49:24 +00:00
Drew Jaynes
56c81005fe
Docs: Add a proper file header to wp-admin/includes/continents-cities.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35359
git-svn-id: http://core.svn.wordpress.org/trunk@35325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:43:25 +00:00
Helen Hou-Sandí
6ca92efe23
List tables: Move the view mode switcher into screen options for posts.
...
Having a view mode switcher nestled within table navigation makes no sense, especially now that it's a sticky user option. While less convenient for frequent switching, there is no evidence as of yet that there is a large userbase of frequent view mode switchers.
Introduces a filter for `view_mode_post_types`, which by default is all hierarchical post types with edit UI on.
props Oxymoron.
fixes #22222 .
Built from https://develop.svn.wordpress.org/trunk@35357
git-svn-id: http://core.svn.wordpress.org/trunk@35323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-22 19:25:25 +00:00
Andrea Fercia
cfa07d28af
Plugins: Improve the "Install Now" button vertical alignment in the Plugin Details modal dialog.
...
Props paulwilde.
Fixes #34199 .
Built from https://develop.svn.wordpress.org/trunk@35343
git-svn-id: http://core.svn.wordpress.org/trunk@35309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 21:55:29 +00:00
Helen Hou-Sandí
28c77bec72
RIP #21759b
, the old WordPress Blue.
...
The final lingering instances were all for hidden accessibility helper text.
fixes #34388 .
Built from https://develop.svn.wordpress.org/trunk@35340
git-svn-id: http://core.svn.wordpress.org/trunk@35306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:36:28 +00:00
Andrea Fercia
223afd7e04
Press This: Improve the "choose tags" button focus style.
...
Props adamholisky for the initial patch.
Fixes 34241.
Built from https://develop.svn.wordpress.org/trunk@35338
git-svn-id: http://core.svn.wordpress.org/trunk@35304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:34:26 +00:00
Dominik Schilling
253646fcd1
Options: Hide the week starts on setting for installs that have the default setting already.
...
The default setting is the value of `$wp_locale->start_of_week` which holds the value per locale, see [35336].
Props swissspidy, ocean90.
Fixes #28344 .
Built from https://develop.svn.wordpress.org/trunk@35337
git-svn-id: http://core.svn.wordpress.org/trunk@35303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 17:39:25 +00:00
Boone Gorges
3eab09a694
Don't force comment pagination.
...
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.
The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.
This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.
See #8071 .
Built from https://develop.svn.wordpress.org/trunk@35331
git-svn-id: http://core.svn.wordpress.org/trunk@35297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:26:42 +00:00
Dominik Schilling
4d0759afae
List Tables: Replace the hyphen separator for titles and post/media states with a —
.
...
Props McGuive7.
Fixes #23230 .
Built from https://develop.svn.wordpress.org/trunk@35326
git-svn-id: http://core.svn.wordpress.org/trunk@35292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 14:33:27 +00:00
Drew Jaynes
81524f3bfc
Filesystem: Following the introduction of the KB|MB|GB|TB_IN_BYTES
constants in [35286], use them in various places in core.
...
Props sudar.
Fixes #22405 .
Built from https://develop.svn.wordpress.org/trunk@35325
git-svn-id: http://core.svn.wordpress.org/trunk@35291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 14:03:25 +00:00
Andrew Ozz
de881c4a97
Precommit cleanup, see r35313.
...
Built from https://develop.svn.wordpress.org/trunk@35318
git-svn-id: http://core.svn.wordpress.org/trunk@35284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:33:24 +00:00
Andrew Ozz
71ac079074
Widgets: add a button to delete all inactive widgets simultaneously for better UX.
...
Props cdog.
Fixes #19159 .
Built from https://develop.svn.wordpress.org/trunk@35317
git-svn-id: http://core.svn.wordpress.org/trunk@35283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 05:23:26 +00:00
Scott Taylor
47879dc83a
Export: add missing labels and improvement accessibility of the Export screen.
...
Props afercia.
Fixes #33046 .
Built from https://develop.svn.wordpress.org/trunk@35316
git-svn-id: http://core.svn.wordpress.org/trunk@35282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:57:24 +00:00
Scott Taylor
85d21feca6
Plugins/Updates: in request_filesystem_credentials()
, alter the heading HTML tag based on the current screen for improved semantics.
...
Props afercia.
Fixes #34267 .
Built from https://develop.svn.wordpress.org/trunk@35315
git-svn-id: http://core.svn.wordpress.org/trunk@35281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:51:24 +00:00
Scott Taylor
8eb3de46c9
Formatting: move url_shorten()
from wp-admin/includes/misc.php
to wp-includes/formatting.php
for more global access.
...
Adds unit tests.
Props mulvane, chriscct7.
Fixes #20166 .
Built from https://develop.svn.wordpress.org/trunk@35314
git-svn-id: http://core.svn.wordpress.org/trunk@35280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:48:24 +00:00
Scott Taylor
e525ab849d
Administration: the current admin menu item should have an aria-haspopup
attribute when the menu is folded.
...
Unify the jQuery selector caching for `window`, `document`, and `body`.
Props afercia.
Fixes #32578 .
Built from https://develop.svn.wordpress.org/trunk@35313
git-svn-id: http://core.svn.wordpress.org/trunk@35279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:41:24 +00:00
Scott Taylor
e6015a31ab
Site Icon: make the default value for the site_icon
option 0
in schema.php
.
...
Props swissspidy, sebastian.pisula.
Fixes #34339 .
Built from https://develop.svn.wordpress.org/trunk@35312
git-svn-id: http://core.svn.wordpress.org/trunk@35278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:28:25 +00:00
Sergey Biryukov
9fa88a7f27
Autoprefixer for [35281].
...
See #33322 .
Built from https://develop.svn.wordpress.org/trunk@35310
git-svn-id: http://core.svn.wordpress.org/trunk@35276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 03:02:24 +00:00
Weston Ruter
bee05e0cdc
Customizer: Introduce customize_loaded_components
filter to allow core components to be disabled.
...
Also move style rule from `customize-nav-menus.css` to `customize-controls.css` so that widgets button is properly styled when `nav_menus` component is excluded from loading. See [35304]. See #33327 .
Props westonruter, DrewAPicture.
Fixes #33552 .
Built from https://develop.svn.wordpress.org/trunk@35307
git-svn-id: http://core.svn.wordpress.org/trunk@35273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 22:16:25 +00:00
Andrea Fercia
1e1e7a9fc9
Customizer: Make the widgets "Reorder" and "Add a Widget" buttons... buttons.
...
For accessibility, UI controls should preferably be native controls. Adds
ARIA attributes and labels to improve accessibility and pair these buttons
with the ones in the Menu Customizer.
Props obenland, TomHarrigan, sanket.parmar, metodiew, afercia.
Fixes #33327 .
Built from https://develop.svn.wordpress.org/trunk@35304
git-svn-id: http://core.svn.wordpress.org/trunk@35270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 20:15:26 +00:00
Weston Ruter
6d9d18315d
Customizer: Implement indicators for invalid nav menu items.
...
The same indicator on the nav menus admin page is now present for nav menu items in the Customizer. When a menu item is present for a post type that is no longer registered, the menu item will appear with the indicator.
Props kucrut, westonruter.
Fixes #33665 .
Built from https://develop.svn.wordpress.org/trunk@35302
git-svn-id: http://core.svn.wordpress.org/trunk@35268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 19:08:25 +00:00
Konstantin Obenland
f6941fddf4
Site Icon: Get site icon ID only when needed.
...
Cuts down on unnecessary queries, especially in environments that rely on
post meta a lot. Reverts [32997].
Props ap.koponen, swissspidy.
Fixes #34368 .
Built from https://develop.svn.wordpress.org/trunk@35299
git-svn-id: http://core.svn.wordpress.org/trunk@35265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 18:23:44 +00:00
Sergey Biryukov
e0af554638
Tags: Avoid a double trailing space after tags separator in auto-suggest.
...
Props afercia.
Fixes #33881 .
Built from https://develop.svn.wordpress.org/trunk@35292
git-svn-id: http://core.svn.wordpress.org/trunk@35258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 16:00:30 +00:00
Scott Taylor
b0561ed6e4
Dashboard: use the create_posts
cap on the post type object when determining if the Quick Press widget can be displayed.
...
Props jim912, ocean90, chriscct7.
Fixes #25681 .
Built from https://develop.svn.wordpress.org/trunk@35282
git-svn-id: http://core.svn.wordpress.org/trunk@35248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:49:24 +00:00
Scott Taylor
f89b90a1c9
Theme Installer: toggle iframe-ready
on the overlay to control the spinner animated GIF and high CPU usage.
...
Props afercia, adamsilverstein.
Fixes #33322 .
Built from https://develop.svn.wordpress.org/trunk@35281
git-svn-id: http://core.svn.wordpress.org/trunk@35247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:36:25 +00:00
Scott Taylor
62d8b8c5bc
List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns).
...
See #31634 .
Built from https://develop.svn.wordpress.org/trunk@35277
git-svn-id: http://core.svn.wordpress.org/trunk@35243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:29:24 +00:00
Andrea Fercia
e074209a3d
Accessibility: Improve the headings hierarchy in the Add Themes screen.
...
Fixes #33819 .
Built from https://develop.svn.wordpress.org/trunk@35273
git-svn-id: http://core.svn.wordpress.org/trunk@35239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:04:25 +00:00
Drew Jaynes
9f0f213d5e
Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35271
git-svn-id: http://core.svn.wordpress.org/trunk@35237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 20:09:26 +00:00
Dion Hulse
85258bb914
In insert_with_markers()
restore the 4.3 behaviour of creating the file if it doesn't exist.
...
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.
Props willmot tigertech kevinatelement
See #31767
Built from https://develop.svn.wordpress.org/trunk@35267
git-svn-id: http://core.svn.wordpress.org/trunk@35233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 00:53:24 +00:00
Andrea Fercia
579246ab4a
Multisite: Improve the Admin Bar parent menu items color on hover and focus.
...
Props Nikschavan for the initial patch.
Fixes #34040 .
Built from https://develop.svn.wordpress.org/trunk@35265
git-svn-id: http://core.svn.wordpress.org/trunk@35231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 16:22:24 +00:00
Drew Jaynes
b37bb95aad
Administration: Introduce the manage_posts_extra_tablenav
action, which fires inside the tablenav for the posts list table, and just outside the "actions" container.
...
Props hlashbrooke, wonderboymusic.
Fixes #30341 .
Built from https://develop.svn.wordpress.org/trunk@35263
git-svn-id: http://core.svn.wordpress.org/trunk@35229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:56:23 +00:00
Drew Jaynes
0aaa2900eb
Docs: Add a version to the file header for wp-admin/includes/comment.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35262
git-svn-id: http://core.svn.wordpress.org/trunk@35228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:34:25 +00:00
Weston Ruter
f676fdcee3
Customizer: Fix margin-top
calculation for Themes section.
...
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].
See #33567 .
Built from https://develop.svn.wordpress.org/trunk@35251
git-svn-id: http://core.svn.wordpress.org/trunk@35217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:41:25 +00:00
Drew Jaynes
8a386cb24f
Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35241
git-svn-id: http://core.svn.wordpress.org/trunk@35207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 15:13:25 +00:00
Ella Iseulde Van Dorpe
08f71faac3
JSHint after [35238]
...
Built from https://develop.svn.wordpress.org/trunk@35239
git-svn-id: http://core.svn.wordpress.org/trunk@35205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:11:24 +00:00
Ella Iseulde Van Dorpe
47e364de42
Admin: fix repositioning notices
...
Fixes #34294 .
Props afercia.
Built from https://develop.svn.wordpress.org/trunk@35238
git-svn-id: http://core.svn.wordpress.org/trunk@35204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:04:26 +00:00
Drew Jaynes
10d94ea673
Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35237
git-svn-id: http://core.svn.wordpress.org/trunk@35203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 06:07:24 +00:00
Sergey Biryukov
1157540283
Replace Quick Edit and Bulk Edit headings with <legend>
elements.
...
Props afercia.
Fixes #34289 .
Built from https://develop.svn.wordpress.org/trunk@35234
git-svn-id: http://core.svn.wordpress.org/trunk@35200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:45:25 +00:00
Sergey Biryukov
7c2919c02b
Merge two strings for expanding accordion and Customizer sections.
...
Props pavelevap.
Fixes #33939 .
Built from https://develop.svn.wordpress.org/trunk@35232
git-svn-id: http://core.svn.wordpress.org/trunk@35198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:28:25 +00:00
Weston Ruter
6bcd8ad757
Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
...
Widgets panel will not wait to display until the preview loads.
Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.
Fixes #33052 .
Fixes #33567 .
Built from https://develop.svn.wordpress.org/trunk@35231
git-svn-id: http://core.svn.wordpress.org/trunk@35197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:48:25 +00:00
Sergey Biryukov
f98136c1b5
Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
...
Props afercia.
Fixes #34255 .
Built from https://develop.svn.wordpress.org/trunk@35229
git-svn-id: http://core.svn.wordpress.org/trunk@35195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:02:25 +00:00
Sergey Biryukov
7fdbebdd7d
In WP_Posts_List_Table
, correct the type for $comment_pending_count
.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@35223
git-svn-id: http://core.svn.wordpress.org/trunk@35189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:25:25 +00:00
Sergey Biryukov
dcf23c5e2a
In WP_Media_List_Table
, rename $pending_count
to $comment_pending_count
and mark it as protected, for consistency with WP_Posts_List_Table
.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@35222
git-svn-id: http://core.svn.wordpress.org/trunk@35188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:23:27 +00:00
Drew Jaynes
1cb39b180f
Docs: Standardize the file header summary for wp-admin/includes/file.php.
...
Also adds an `@since` version and corrects the `@subpackage` value.
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35221
git-svn-id: http://core.svn.wordpress.org/trunk@35187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 16:56:26 +00:00
Andrea Fercia
dc0e7e1a79
Accessibility: Improve headings hierarchy in the Theme browser modal dialog.
...
Fixes #34288 .
Built from https://develop.svn.wordpress.org/trunk@35220
git-svn-id: http://core.svn.wordpress.org/trunk@35186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:56:25 +00:00
Andrea Fercia
7f4a0ebbf3
Bump H4 headings to H2 in the Updates screen for better accessibility.
...
Fixes #34265 .
Built from https://develop.svn.wordpress.org/trunk@35219
git-svn-id: http://core.svn.wordpress.org/trunk@35185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:45:28 +00:00
Helen Hou-Sandí
fc02ca2d01
Account for icon alignment using text-indent in RTL.
...
fixes #33808 .
Built from https://develop.svn.wordpress.org/trunk@35215
git-svn-id: http://core.svn.wordpress.org/trunk@35181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 00:58:25 +00:00
Helen Hou-Sandí
7aabfdaca4
Circular focus styling for widgets and menus in the customizer.
...
see #33808 .
Built from https://develop.svn.wordpress.org/trunk@35207
git-svn-id: http://core.svn.wordpress.org/trunk@35173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 18:53:25 +00:00
Helen Hou-Sandí
395258bcaa
Make the database update button primary.
...
see #23738 .
Built from https://develop.svn.wordpress.org/trunk@35204
git-svn-id: http://core.svn.wordpress.org/trunk@35170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:35:24 +00:00
Drew Jaynes
0905e847ae
Docs: Walker_Nav_Menu_Checklist
and Walker_Nav_Menu_Edit
are part of the Navigation Menu API, but intended for use in the scope of administration.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35202
git-svn-id: http://core.svn.wordpress.org/trunk@35168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:26:24 +00:00
Helen Hou-Sandí
12290303a8
Box shadows still need -webkit-
, turns out.
...
see #33808 , [35200].
Built from https://develop.svn.wordpress.org/trunk@35201
git-svn-id: http://core.svn.wordpress.org/trunk@35167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:09:26 +00:00
Helen Hou-Sandí
50288dea5a
Circular focus styling for expand/collapse arrows.
...
Affects postboxes, widgets, and nav menus, all in the admin.
props grvrulz for the initial patch.
see #33808 .
Built from https://develop.svn.wordpress.org/trunk@35200
git-svn-id: http://core.svn.wordpress.org/trunk@35166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 16:47:25 +00:00
Ella Iseulde Van Dorpe
3babb1682a
Fix close button plugin modal after [18590]
...
See #18590 .
Built from https://develop.svn.wordpress.org/trunk@35198
git-svn-id: http://core.svn.wordpress.org/trunk@35164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 14:52:26 +00:00
Sergey Biryukov
8aa7fb88f0
Remove a one-time variable from edit_user()
added in [35189].
...
See #27317 .
Built from https://develop.svn.wordpress.org/trunk@35190
git-svn-id: http://core.svn.wordpress.org/trunk@35156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:46:24 +00:00
Sergey Biryukov
7f08716c16
Users: Add 'illegal_user_logins'
filter to allow certain usernames to be blacklisted.
...
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317 .
Built from https://develop.svn.wordpress.org/trunk@35189
git-svn-id: http://core.svn.wordpress.org/trunk@35155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:43:26 +00:00
Sergey Biryukov
09ee95ea49
Themes: Add Install Parent Theme button for child themes that are missing a parent theme.
...
Props rabmalin for initial patch.
Fixes #32668 .
Built from https://develop.svn.wordpress.org/trunk@35187
git-svn-id: http://core.svn.wordpress.org/trunk@35153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:11:24 +00:00
Sergey Biryukov
e63ba31f93
Acessibility: Add back-compat styles for plugins that use h3
inside the .metabox-holder
container.
...
Props afercia.
Fixes #33557 .
Built from https://develop.svn.wordpress.org/trunk@35184
git-svn-id: http://core.svn.wordpress.org/trunk@35150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:38:25 +00:00
Helen Hou-Sandí
f3107e5842
Make some primary action buttons look primary.
...
* User deletion/removal
* Site status change (multisite)
* Network upgrade
* Import file upload
* Media browser upload
props Dezzy for the initial patch.
fixes #23738 .
Built from https://develop.svn.wordpress.org/trunk@35182
git-svn-id: http://core.svn.wordpress.org/trunk@35148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:08:24 +00:00
Sergey Biryukov
6d91caa931
Theme Editor: Repurpose the 'wp_theme_editor_filetypes'
filter added in [35134] to actually filter file types instead of files.
...
Default types include 'php' and 'css' and cannot be removed, only new types can be added.
Props DrewAPicture, SergeyBiryukov.
Fixes #22924 .
Built from https://develop.svn.wordpress.org/trunk@35180
git-svn-id: http://core.svn.wordpress.org/trunk@35146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 02:20:24 +00:00
Drew Jaynes
217b661703
Docs: Add missing descriptions for the $wpdb
global in DocBlocks all the places.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35170
git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:44:25 +00:00
Drew Jaynes
43c10f7d35
Docs: Fix third-person singular verbs for summaries in wp-admin/includes/bookmarks.php.
...
Also adds some missing parameter, return, and global descriptions, and one missing summary.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35169
git-svn-id: http://core.svn.wordpress.org/trunk@35135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 23:25:25 +00:00
Drew Jaynes
c78ee60edd
Docs: Standardize file header summary for wp-admin/includes/ajax-actions.php.
...
See #33701 .
[ci skip]
Built from https://develop.svn.wordpress.org/trunk@35168
git-svn-id: http://core.svn.wordpress.org/trunk@35134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:49:24 +00:00
Drew Jaynes
c3ee28ea06
Docs: wp-admin/includes/admin-filters.php is part of the Administration subpackage, update the summary.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35167
git-svn-id: http://core.svn.wordpress.org/trunk@35133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:35:24 +00:00
Drew Jaynes
2e2e898802
Docs: Add a version and standardize the file header summary for wp-admin/includes/admin.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35166
git-svn-id: http://core.svn.wordpress.org/trunk@35132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 22:32:24 +00:00
Helen Hou-Sandí
6820130e33
Screen options: Improve the "Apply" button
...
Previously the button was output as a part of the per-page option rendering, inline with that input. While this was appropriate for core's usage, the `screen_settings` filter has allowed plugins to place additional items at the bottom of the panel, which a number take advantage of. This leads to confusing situations where plugins that don't save settings via Ajax either have to add their own button or piggyback onto the existing button, which doesn't make any sense in the flow of additional options. It also hinders core from adding any other options that need to be submitted.
Also, when the screen options panel is open, a submit button there is the primary action at that moment. The "Apply" button also does a full page load, which a primary button indicates better.
fixes #34295 . see #22222 , #23738 .
Built from https://develop.svn.wordpress.org/trunk@35161
git-svn-id: http://core.svn.wordpress.org/trunk@35127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 18:58:25 +00:00
Andrea Fercia
f1787056de
Bump the "Status" H3 heading to H2 on the Edit Comment screen for better accessibility.
...
Fixes #34286 .
Built from https://develop.svn.wordpress.org/trunk@35160
git-svn-id: http://core.svn.wordpress.org/trunk@35126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:44:24 +00:00
Andrea Fercia
c4ff6317a7
Bump H3 headings to H2 on the legacy Link Manager screen for better accessibility.
...
Fixes #34285 .
Built from https://develop.svn.wordpress.org/trunk@35158
git-svn-id: http://core.svn.wordpress.org/trunk@35124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 17:32:24 +00:00
Andrea Fercia
19eb905f58
Accessibility: update a jQuery selector used for the Plugin Cards after [35009].
...
When updating a plugin from its details modal dialog, focus should be moved back to the plugin title which now is a H3 heading.
Fixes #33818 .
Built from https://develop.svn.wordpress.org/trunk@35155
git-svn-id: http://core.svn.wordpress.org/trunk@35121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-14 15:27:27 +00:00
John Blackbourn
87aa982824
Include network-active plugins and inactive network-only plugins on the Plugins listing screen for individual sites on Multisite.
...
These plugins are only shown to users with the `manage_network_plugins` capability, which is Super Admins by default. This new feature lowers the blood pressure of Super Admins who may browse or search the Plugins listing screen of an individual site, having forgotten that a particular plugin is network-active. Showing inactive network-only plugins here also reduces friction when searching the Plugins listing screen on individual sites.
This change introduces a `show_network_active_plugins` filter which controls whether the network-active plugins and inactive network-only plugins are shown. This can be used to enable this functionality for regular site admininstrators, or, indeed, to disable this functionality for Super Admins.
Fixes #20104
Built from https://develop.svn.wordpress.org/trunk@35151
git-svn-id: http://core.svn.wordpress.org/trunk@35117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 22:12:25 +00:00
Drew Jaynes
57e69d4a3f
Upgrader: Introduce a new action hook pre_auto_update
, which fires immediately prior to an auto-update for core, themes, plugins, or translations.
...
Props DavidAnderson, welcher.
Fixes #30441 .
Built from https://develop.svn.wordpress.org/trunk@35144
git-svn-id: http://core.svn.wordpress.org/trunk@35110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 18:58:25 +00:00
Sergey Biryukov
4ef12c7814
Correct the error message displayed on setup when wp-config-sample.php
does not exist.
...
Props bradparbs.
Fixes #23247 .
Built from https://develop.svn.wordpress.org/trunk@35143
git-svn-id: http://core.svn.wordpress.org/trunk@35109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 17:36:25 +00:00
Scott Taylor
45a0c26091
Taxonomy: get_terms_to_edit()
can also return false
or WP_Error
. Vars using it should be set to empty string when errors are returned to avoid producing fatal errors when used in string operations.
...
Props valendesigns.
Fixes #30472 .
Built from https://develop.svn.wordpress.org/trunk@35139
git-svn-id: http://core.svn.wordpress.org/trunk@35104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 16:40:26 +00:00
Scott Taylor
7c88e86bf6
Theme Editor: add a filter, wp_theme_editor_filetypes
, to allow more filetypes to be edited via the Theme Editor. Usage of the Theme Editor is strenuously discouraged, but we should allow you to add whatever filetypes (.less
, .scss
) you would like.
...
Props MikeHansenMe, pross.
Fixes #22924 .
Built from https://develop.svn.wordpress.org/trunk@35134
git-svn-id: http://core.svn.wordpress.org/trunk@35099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 14:14:24 +00:00
Scott Taylor
357b916211
Theme Installer: fix the theme "Install"/"Installed" button's vertical alignment for HiDPI displays.
...
Props paulwilde.
Fixes #34198 .
Built from https://develop.svn.wordpress.org/trunk@35133
git-svn-id: http://core.svn.wordpress.org/trunk@35098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 13:52:27 +00:00
Sergey Biryukov
be10375eb6
Accessibility: Add back-compat styles for plugins that still use h2
as a main heading in their screens.
...
Props afercia.
Fixes #33559 .
Built from https://develop.svn.wordpress.org/trunk@35131
git-svn-id: http://core.svn.wordpress.org/trunk@35096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:17:24 +00:00
Sergey Biryukov
1c9ea9bb4a
Accessibility: Correct the style for Popular Tags header on Edit Tags screen after [33917].
...
Props afercia.
See #33559 . See #33658 .
Built from https://develop.svn.wordpress.org/trunk@35130
git-svn-id: http://core.svn.wordpress.org/trunk@35095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:14:25 +00:00
Sergey Biryukov
7ebbe03a1f
Acessibility: "Add New Category" links on Edit Post screen should not be a header.
...
Props afercia.
Fixes #33557 .
Built from https://develop.svn.wordpress.org/trunk@35129
git-svn-id: http://core.svn.wordpress.org/trunk@35094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:00:25 +00:00
Sergey Biryukov
1c5d327676
Accessibility: bump headings one level up in post meta boxes for a better headings hierarchy.
...
Props afercia, joedolson, wonderboymusic.
See #33557 .
Built from https://develop.svn.wordpress.org/trunk@35128
git-svn-id: http://core.svn.wordpress.org/trunk@35093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:57:24 +00:00
Sergey Biryukov
3cd956f9bb
Add the CSS changes missed in [35126].
...
Props afercia.
See #34263 .
Built from https://develop.svn.wordpress.org/trunk@35127
git-svn-id: http://core.svn.wordpress.org/trunk@35092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:51:24 +00:00
Sergey Biryukov
8688df4306
Accessibility: bump headings one level up on Credits screen for a better headings hierarchy.
...
Props afercia.
Fixes #34263 .
Built from https://develop.svn.wordpress.org/trunk@35126
git-svn-id: http://core.svn.wordpress.org/trunk@35091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 06:49:26 +00:00
Sergey Biryukov
2c12662eff
Remove obsolete code from `WP_Users_List_Table::get_sortable_columns().
...
Sorting by post count was disabled in [17024].
Props jdgrimes.
See #15861 .
Built from https://develop.svn.wordpress.org/trunk@35110
git-svn-id: http://core.svn.wordpress.org/trunk@35075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:25:25 +00:00
Sergey Biryukov
319d0e8bf0
Replace get_bloginfo( 'wpurl' )
with admin_url()
for plugin activation error message.
...
Use `add_query_arg()` instead of constructing the URL manually.
Props johnbillion.
Fixes #34280 .
Built from https://develop.svn.wordpress.org/trunk@35109
git-svn-id: http://core.svn.wordpress.org/trunk@35074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:12:24 +00:00
Sergey Biryukov
34732f5a80
Replace get_bloginfo( 'wpurl' )
with admin_url()
in plugin editor.
...
Use `add_query_arg()` instead of constructing the URL manually.
Props johnbillion.
See #34280 .
Built from https://develop.svn.wordpress.org/trunk@35107
git-svn-id: http://core.svn.wordpress.org/trunk@35072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 02:05:24 +00:00
Scott Taylor
aa92c9555a
Widgets: add a function, is_registered_sidebar()
- helps us avoid touching the $wp_registered_sidebars
global.
...
Props GaryJ, wonderboymusic.
Fixes #24878 .
Built from https://develop.svn.wordpress.org/trunk@35102
git-svn-id: http://core.svn.wordpress.org/trunk@35067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:33:25 +00:00
Scott Taylor
a31d7e37dc
Color Picker: when opening and closing, toggle a wp-picker-active
class on the wrapper.
...
Props norcross.
Fixes #29471 .
Built from https://develop.svn.wordpress.org/trunk@35099
git-svn-id: http://core.svn.wordpress.org/trunk@35064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 01:08:25 +00:00
Drew Jaynes
bcc7f8d079
Plugins: Introduce the delete_plugin
transactional hook, which fires immediately after a plugin deletion attempt occurs.
...
Props Veraxus for the initial patch.
Fixes #26904 .
Built from https://develop.svn.wordpress.org/trunk@35094
git-svn-id: http://core.svn.wordpress.org/trunk@35059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 00:57:25 +00:00
Drew Jaynes
8b49acdd0e
Docs: Specify the default image size in the $size
parameter description for the image_send_to_editor
hook.
...
See #34257 . See #32246 . See [35058].
Built from https://develop.svn.wordpress.org/trunk@35080
git-svn-id: http://core.svn.wordpress.org/trunk@35045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 17:18:24 +00:00
Drew Jaynes
f7e92fc346
Docs: Normalize spacing in the DocBlock for get_image_send_to_editor()
following [35056].
...
See #34257 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35079
git-svn-id: http://core.svn.wordpress.org/trunk@35044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 17:16:24 +00:00
Drew Jaynes
ee544e44d5
Docs: Adjust documentation for the $size
parameter in the admin_post_thumbnail_size
hook doc to clarify the required order of width and height values when an array is passed.
...
See #34257 . See #28512 .
Built from https://develop.svn.wordpress.org/trunk@35060
git-svn-id: http://core.svn.wordpress.org/trunk@35025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:22:25 +00:00
Drew Jaynes
9f5d887934
Docs: Normalize spacing in the image_send_to_editor
hook doc following [35058].
...
See #34257 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35059
git-svn-id: http://core.svn.wordpress.org/trunk@35024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:19:23 +00:00
Drew Jaynes
c12f0caefd
Docs: Adjust documentation for the $size
parameter in the image_send_to_editor
hook doc to clarify the required order of width and height values when an array is passed.
...
Also adds the `array` type to the parameter documentation (already supported).
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35058
git-svn-id: http://core.svn.wordpress.org/trunk@35023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:17:24 +00:00
Drew Jaynes
4aea111b29
Docs: Fix syntax and properly mark optional parameters as such in the DocBlock for get_image_send_to_editor()
.
...
Also fixes the return description, and adds the `$size` default value, missed in [35055].
See #34257 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35056
git-svn-id: http://core.svn.wordpress.org/trunk@35021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:11:24 +00:00
Drew Jaynes
16738bf325
Docs: Adjust documentation for the $size
parameter in get_image_send_to_editor()
to clarify the required order of width and height values when passing an array.
...
Also adds the `array` type to the parameter documentation (already supported).
See #34257 .
Built from https://develop.svn.wordpress.org/trunk@35055
git-svn-id: http://core.svn.wordpress.org/trunk@35020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 16:08:25 +00:00
Drew Jaynes
f60bd8d827
Docs: Wrap a couple of hook name references in inline @see
tags in the hook docs for custom_menu_order
and menu_order
.
...
Inline `@see` tags in the context of hooks are parsed as links to hook pages in the Code Reference.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35027
git-svn-id: http://core.svn.wordpress.org/trunk@34992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 03:39:26 +00:00
Jeremy Felt
270d3f422c
MS: Reflect falsy values for upload_space_check_disabled
in UI.
...
If the network option for `upload_space_check_disabled` is missing or an empty string, we should reflect how it will be treated elsewhere in the UI.
Props stephenharris.
Fixes #33986 .
Built from https://develop.svn.wordpress.org/trunk@35026
git-svn-id: http://core.svn.wordpress.org/trunk@34991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-12 00:01:24 +00:00
Drew Jaynes
2c6e416159
Media: Remove logic for unnecessarily overloading the $content_width
global when passing default dimensions used to display the post thumbnail image in the 'Featured Image' meta box.
...
Updates documentation for the `$size` parameter in `admin_post_thumbnail_size` filter doc.
See #28512 .
Built from https://develop.svn.wordpress.org/trunk@35023
git-svn-id: http://core.svn.wordpress.org/trunk@34988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 17:10:25 +00:00
Drew Jaynes
889a89c2a2
Media: Introduce the admin_post_thumbnail_size
filter, which enables manipulation of the image size used to display the post thumbnail in the 'Featured Image' meta box.
...
This filter has no effect on the image size used to display post thumbnails on the front-end.
Props dboulet, DrewAPicture.
Fixes #28512 .
Built from https://develop.svn.wordpress.org/trunk@35022
git-svn-id: http://core.svn.wordpress.org/trunk@34987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 16:54:26 +00:00
Drew Jaynes
fb2a4bf9fb
Docs: Fix some syntactical issues in property DocBlocks for WP_List_Table
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35021
git-svn-id: http://core.svn.wordpress.org/trunk@34986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-11 03:34:26 +00:00
Jeremy Felt
3b42b801f8
MS: Handle the possibility of 0 when checking a user's upload quota.
...
Upload space of 0 is now more possible via r35016 and should be respected rather than modified to a default of 10MB.
Fixes #34037 .
Built from https://develop.svn.wordpress.org/trunk@35017
git-svn-id: http://core.svn.wordpress.org/trunk@34982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 23:17:25 +00:00
Andrea Fercia
6b449abadc
Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.
...
Props mrahmadawais, afercia.
Fixes #33659 .
Built from https://develop.svn.wordpress.org/trunk@35015
git-svn-id: http://core.svn.wordpress.org/trunk@34980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 16:34:25 +00:00
Scott Taylor
5fdf928bcf
Admin JS: after [34977], avoid variable names conflicts with e
.
...
Props afercia.
Fixes #18590 .
Built from https://develop.svn.wordpress.org/trunk@35014
git-svn-id: http://core.svn.wordpress.org/trunk@34979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:50:24 +00:00
Scott Taylor
00ade45fd1
Docs: some @global object
vernaculars should be converted to the actual object type.
...
See #33491 .
Built from https://develop.svn.wordpress.org/trunk@35013
git-svn-id: http://core.svn.wordpress.org/trunk@34978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:45:25 +00:00
Scott Taylor
57c2ef2655
Users List Table: after [35011], just use wp_roles()
, no global import. #winning
...
See #22959 .
Built from https://develop.svn.wordpress.org/trunk@35012
git-svn-id: http://core.svn.wordpress.org/trunk@34977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:36:26 +00:00
Scott Taylor
ab2905da84
Users List Table: after [34963], remove unused code/add doc for global import.
...
See #22959 .
Built from https://develop.svn.wordpress.org/trunk@35011
git-svn-id: http://core.svn.wordpress.org/trunk@34976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:26:24 +00:00
Scott Taylor
d021cb8bc0
WP Screen: after [34991], avoid unnecessary nesting levels and remove unused global import.
...
See #33646 .
Built from https://develop.svn.wordpress.org/trunk@35010
git-svn-id: http://core.svn.wordpress.org/trunk@34975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:20:24 +00:00
Andrea Fercia
6ec8174ca1
Accessibility: bump headings one level up on the Add Plugins screen for a better headings hierarchy.
...
Fixes #33818 .
Built from https://develop.svn.wordpress.org/trunk@35009
git-svn-id: http://core.svn.wordpress.org/trunk@34974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 15:17:26 +00:00
Sergey Biryukov
a5c1f545c4
Users: Remove redundant error message when password is only entered once.
...
"Please enter the same password in both password fields" should cover all the scenarios.
Props MikeHansenMe, jmayhak, desrosj, gounder.
Fixes #33101 .
Built from https://develop.svn.wordpress.org/trunk@35008
git-svn-id: http://core.svn.wordpress.org/trunk@34973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 13:22:26 +00:00
Sergey Biryukov
ac9a85a45e
Use wp_star_rating()
on Add Themes screen:
...
* It works correctly for RTL
* Requires less CSS styling
* Is visually consistent with plugin ratings
* Is more accessible
Fixes #34080 .
Built from https://develop.svn.wordpress.org/trunk@35006
git-svn-id: http://core.svn.wordpress.org/trunk@34971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:51:24 +00:00
Sergey Biryukov
24219160f1
Add echo
parameter for wp_star_rating()
.
...
See #34080 .
Built from https://develop.svn.wordpress.org/trunk@35005
git-svn-id: http://core.svn.wordpress.org/trunk@34970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:43:24 +00:00
Drew Jaynes
c6bffb6264
Docs: Fix some minor formatting in the $query_args
parameter description for the `` filter doc.
...
See #8243 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35004
git-svn-id: http://core.svn.wordpress.org/trunk@34969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:39:24 +00:00
Drew Jaynes
504ff07656
Dashboard: Introduce the dashboard_recent_drafts_query_args
filter, making it possible to manipulate the post query arguments used in the 'Recent Drafts' dashboard widget.
...
Props iamfriendly.
Fixes #8243 .
Built from https://develop.svn.wordpress.org/trunk@35003
git-svn-id: http://core.svn.wordpress.org/trunk@34968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 06:33:25 +00:00
Sergey Biryukov
5399881b18
Merge two database update strings for consistency.
...
Props pavelevap.
Fixes #33514 .
Built from https://develop.svn.wordpress.org/trunk@35000
git-svn-id: http://core.svn.wordpress.org/trunk@34965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 05:14:23 +00:00
Jeremy Felt
f8a05879e8
MS: Show an error if a new site slug conflicts with an existing username.
...
Props utkarshpatel, dipesh.kakadiya.
Fixes #33804 .
Built from https://develop.svn.wordpress.org/trunk@34996
git-svn-id: http://core.svn.wordpress.org/trunk@34961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 01:42:26 +00:00
Sergey Biryukov
662ad721ec
Remove stray closing tag in wp-admin/themes.php
.
...
Props tfrommen.
Fixes #34237 .
Built from https://develop.svn.wordpress.org/trunk@34994
git-svn-id: http://core.svn.wordpress.org/trunk@34959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 21:17:25 +00:00
Andrea Fercia
42b33e1645
Administration: Convert H5 usage in Screen Options to use fieldsets and legends.
...
These H5 (heading level 5) don't allow for a good headings hierarchy and shouldn't be headings in the first place. Each group of options has now its own fieldset and legend.
In `render_screen_options()`, introduce two new "render" methods: `render_meta_boxes_preferences()` and `render_list_table_columns_preferences()` for consistency with already existing render methods and cleaner code.
Props joedolson, afercia.
Fixes #33646 .
Built from https://develop.svn.wordpress.org/trunk@34991
git-svn-id: http://core.svn.wordpress.org/trunk@34956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 18:05:24 +00:00
Drew Jaynes
7e26ee2e3c
Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions.
...
The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because `localhost` is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.
Props ankit-k-gupta, iamfriendly.
Fixes #30317 .
Built from https://develop.svn.wordpress.org/trunk@34987
git-svn-id: http://core.svn.wordpress.org/trunk@34952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 15:43:27 +00:00
Sergey Biryukov
95da3826b9
Media: Return early from media_sideload_image()
if $file
didn't match the pattern for images.
...
Props MikeHansenMe, serpent7776.
Fixes #32755 .
Built from https://develop.svn.wordpress.org/trunk@34984
git-svn-id: http://core.svn.wordpress.org/trunk@34949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:46:24 +00:00
Sergey Biryukov
dfc4654172
Dashboard: Display year in Activity widget if the post date year is not the same as the current one.
...
Props GaryJ, chriscct7.
Fixes #26502 .
Built from https://develop.svn.wordpress.org/trunk@34980
git-svn-id: http://core.svn.wordpress.org/trunk@34945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 04:26:24 +00:00
Sergey Biryukov
6595b1b080
My Sites: Make "Create a New Site" link consistent with other "Add New" links.
...
Props JeffMatson.
Fixes #34179 .
Built from https://develop.svn.wordpress.org/trunk@34979
git-svn-id: http://core.svn.wordpress.org/trunk@34944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 03:50:24 +00:00
Sergey Biryukov
3c7b7f7133
After [34529], if a compatible termmeta
table is found on database upgrade, convert it to utf8mb4
collation.
...
Props dboulet.
Fixes #34224 .
Built from https://develop.svn.wordpress.org/trunk@34978
git-svn-id: http://core.svn.wordpress.org/trunk@34943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 02:07:25 +00:00
Andrew Ozz
a6cf0b41a6
JS: in event callbacks replace the very outdated return false
with preventDefault()
.
...
Props adamsilverstein.
Fixes #18590 .
Built from https://develop.svn.wordpress.org/trunk@34977
git-svn-id: http://core.svn.wordpress.org/trunk@34942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 01:27:27 +00:00
Helen Hou-Sandí
b23005d7c1
Revisions: Update slider handle styling.
...
This brings them in line with updated buttons as done in [34948] for #31459 . It also gives it secondary action styling as opposed to primary, as restoring is considered the primary action.
props hugobaeta.
fixes #34220 .
Built from https://develop.svn.wordpress.org/trunk@34976
git-svn-id: http://core.svn.wordpress.org/trunk@34941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-09 00:25:25 +00:00
John Blackbourn
44da78be26
Remove HTML escaping for the plugin name and author fields that are displayed when deleting a plugin.
...
While it might seem counter-intuitive to remove HTML escaping, these fields are already safe (they originate in `_get_plugin_data_markup_translate()` which handles sanitization and escaping), and the AuthorName field actually allows some HTML. This change prevents escaped HTML from appearing here.
Fixes #25422
Built from https://develop.svn.wordpress.org/trunk@34973
git-svn-id: http://core.svn.wordpress.org/trunk@34938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 23:13:24 +00:00
John Blackbourn
b62e798c17
Introduce the ability to filter the Users admin listing screen by users with no role, if such users exist.
...
Fixes #22993
Props spmlucas, johnbillion
Built from https://develop.svn.wordpress.org/trunk@34965
git-svn-id: http://core.svn.wordpress.org/trunk@34930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 22:07:47 +00:00
John Blackbourn
1451ebc0d1
On the Users list table, show all the roles of a user in a comma-separated list if they have more than one role. This prevents role obfuscation in situations where a user has had more than one role programmatically assigned to them.
...
Fixes #22959
Props scribu, JustinSainton, DrewAPicture, johnbillion
Built from https://develop.svn.wordpress.org/trunk@34963
git-svn-id: http://core.svn.wordpress.org/trunk@34928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 21:59:25 +00:00
Drew Jaynes
a07cd8b386
Docs: Normalize documentation spacing in the DocBlocks for add_meta_box()
and remove_meta_box()
following [34951].
...
Fixes #15000 .
Built from https://develop.svn.wordpress.org/trunk@34952
git-svn-id: http://core.svn.wordpress.org/trunk@34917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 19:13:24 +00:00
Drew Jaynes
6e4268e6fa
Administration: Add the ability to pass an array of screen IDs to add_meta_box()
and remove_meta_box()
.
...
The `$screen` parameter in both functions can now accept a single screen ID, `WP_Screen` object, or an array of screen IDs.
Adds tests.
Props coffee2code, iamfriendly, madalinungureanu, mordauk, igmoweb, meloniq, DrewAPicture.
See #15000 .
Built from https://develop.svn.wordpress.org/trunk@34951
git-svn-id: http://core.svn.wordpress.org/trunk@34916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 19:07:24 +00:00
Helen Hou-Sandí
5b40bd827c
Buttons: Update styles and colors.
...
* Aligns with the color standards. See https://make.wordpress.org/design/handbook/foundations/colors/
* Creates a consistent interaction experience between states.
* Improves contrast and accessibility.
props hugobaeta, afercia, melchoyce, michael-arestad.
fixes #31459 .
Built from https://develop.svn.wordpress.org/trunk@34948
git-svn-id: http://core.svn.wordpress.org/trunk@34913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 17:31:24 +00:00
Dominik Schilling
f8c467e07a
Term Meta: Prevent a "Multiple primary key defined" error during database upgrades.
...
You must have two spaces between the words `PRIMARY KEY` and the definition of your primary key. Yes, seriously.
See [34529].
Fixes #34210 .
Built from https://develop.svn.wordpress.org/trunk@34936
git-svn-id: http://core.svn.wordpress.org/trunk@34901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 11:09:26 +00:00
John Blackbourn
0e1ecdcbf3
Revert [34917] until the broken test is fixed.
...
See #13382
Built from https://develop.svn.wordpress.org/trunk@34925
git-svn-id: http://core.svn.wordpress.org/trunk@34890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-08 01:04:25 +00:00
Boone Gorges
b0e0323337
Add tests for update_user_caches()
.
...
See #24635 .
Built from https://develop.svn.wordpress.org/trunk@34918
git-svn-id: http://core.svn.wordpress.org/trunk@34883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 22:35:26 +00:00
Andrea Fercia
17f53091ed
Bump H3 headings to H2 on the Network Admin > Sites > Edit Site screens.
...
The navigation tabs appear in an `<h3>` heading immediately following the main `<h1>` and need to have a proper hierarchy.
Also, fix the tabs focus style and introduce a new `.nav-tab-small` CSS class.
Fixes #34079 .
Built from https://develop.svn.wordpress.org/trunk@34913
git-svn-id: http://core.svn.wordpress.org/trunk@34878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 17:35:24 +00:00
Jeremy Felt
9926983b66
Revert [34778], continue using _site_option()
for the current network.
...
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.
See #28290 .
Built from https://develop.svn.wordpress.org/trunk@34912
git-svn-id: http://core.svn.wordpress.org/trunk@34877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 17:11:25 +00:00
Drew Jaynes
feb2267a13
Docs: Improve documentation for post_submit_meta_box()
, which serves as the display callback for the 'Publish' meta box.
...
* `$post` is now correctly defined as being of the `WP_Post` type
* Adds a hash notation for the `$args` array
* Other minor fixes.
Props drebbitsweb.
Fixes #34171 .
Built from https://develop.svn.wordpress.org/trunk@34911
git-svn-id: http://core.svn.wordpress.org/trunk@34876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 16:34:24 +00:00
Scott Taylor
a1ead3c7e3
List Tables: in _WP_List_Table_Compat::get_column_info()
, also return $primary
, which is expected since [33016].
...
Props tyxla.
Fixes #34148 .
Built from https://develop.svn.wordpress.org/trunk@34897
git-svn-id: http://core.svn.wordpress.org/trunk@34862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 03:12:24 +00:00
Scott Taylor
ae813883f5
Meta Boxes: add an action, post_submitbox_minor_actions
. post_submitbox_misc_actions
already exists. Pass $post
to both for context - avoids having to check for a global post.
...
Props jonathanbardo, chriscct7, DrewAPicture.
Fixes #26267 .
Built from https://develop.svn.wordpress.org/trunk@34895
git-svn-id: http://core.svn.wordpress.org/trunk@34860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 02:45:25 +00:00
Scott Taylor
2783773775
Meta Boxes: reboot some of the code in postbox.js
to support aria-expanded
attribute toggling and to properly reference static class properties.
...
Props afercia, wonderboymusic.
Fixes #33754 .
Built from https://develop.svn.wordpress.org/trunk@34893
git-svn-id: http://core.svn.wordpress.org/trunk@34858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 01:58:25 +00:00
Scott Taylor
a3ec4d45f3
List Tables: after [34276], decrease horizontal padding for sorted column headers (causing weirdness in the Count column of tax list tables) - the vertical padding change suffices in fixing the original issue.
...
Fixes #27945 .
Built from https://develop.svn.wordpress.org/trunk@34892
git-svn-id: http://core.svn.wordpress.org/trunk@34857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 01:40:24 +00:00
Scott Taylor
0c2b2a0e3d
List Tables/WP_Screen: in WP_Screen
, add methods to store, retrieve, and render screen reader text, primarily used by list table screens.
...
These additions are based on an audit and recommendations by the Accessibility team. #a11y'all
Props afercia.
Fixes #32147 .
Built from https://develop.svn.wordpress.org/trunk@34891
git-svn-id: http://core.svn.wordpress.org/trunk@34856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 01:28:25 +00:00
Scott Taylor
7547dc5125
Posts List Table: ensure that "All" gets the "current" CSS class when applicable.
...
Props afercia.
Fixes #19609 .
Built from https://develop.svn.wordpress.org/trunk@34889
git-svn-id: http://core.svn.wordpress.org/trunk@34854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-07 00:09:24 +00:00
Weston Ruter
aa044b054e
Customizer: Ensure that wp.customize.Widgets.savedWidgetIds
is defined up front.
...
In 4.3 the widget controls were fully initialized up front along with the sidebar controls. The sidebar control depended (unnecessarily) on the widget control to ensure that `wp.customize.Widgets.savedWidgetIds` was defined. So after [34563] there could be a situation where the widgets are added/removed from a sidebar before their controls are initialized (if the sidebar section is never expanded), resulting in an error attempting to get a property off of an undefined value. So this change does the right thing and defines `savedWidgetIds` up front.
Also changes the `savedWidgetIds` variable type from an array to an object, to match how it is used as a dictionary lookup.
See #33901 .
Built from https://develop.svn.wordpress.org/trunk@34883
git-svn-id: http://core.svn.wordpress.org/trunk@34848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 21:59:25 +00:00
Dominik Schilling
0bc1d84fc7
MS Themes List Table: Fix inverted logic for displaying the "No items" message.
...
Fixes #25464 .
Built from https://develop.svn.wordpress.org/trunk@34873
git-svn-id: http://core.svn.wordpress.org/trunk@34838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 17:35:23 +00:00
Scott Taylor
2d1fff2c75
Setup/Config: some dirname( ABSPATH )
file lookups should have errors suppressed due to possibility of open_basedir
restrictions on hosts.
...
Props chriscct7, misterunknown.
Fixes #29680 .
Built from https://develop.svn.wordpress.org/trunk@34867
git-svn-id: http://core.svn.wordpress.org/trunk@34832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 14:20:25 +00:00
Scott Taylor
ddbd67a22e
Media: in wp_read_video|audio_metadata()
, set GETID3_TEMP_DIR
to get_temp_dir()
if it is not defined. This is a workaround for when safe_mode
is enabled pre-PHP 5.3.
...
Props chriscct7, tomsommer.
Fixes #26265 .
Built from https://develop.svn.wordpress.org/trunk@34866
git-svn-id: http://core.svn.wordpress.org/trunk@34831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 14:14:25 +00:00
Scott Taylor
c5475fbfc2
Admin Menu: remove duplicated separators, and use strpos()
(instead of strcmp()
) when determining if the separator CSS class is present.
...
Props rilwis, chriscct7.
Fixes #24104 .
Built from https://develop.svn.wordpress.org/trunk@34861
git-svn-id: http://core.svn.wordpress.org/trunk@34826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 13:46:25 +00:00
Drew Jaynes
65133a89c1
Multisite: Introduce get_subdirectory_reserved_names()
, which returns a filterable list of reserved subdirectory site names.
...
The function encapsulates the existing `subdirectory_reserved_names` filter and reduces the maintenance burden of keeping the value of (currently) two instances of the same hook in sync.
See #33615 .
Built from https://develop.svn.wordpress.org/trunk@34854
git-svn-id: http://core.svn.wordpress.org/trunk@34819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 04:35:25 +00:00
Scott Taylor
3ef27f7929
oEmbed: add embed
to $subdirectory_reserved_names
.
...
Props jeremyfelt.
See #32522 .
Built from https://develop.svn.wordpress.org/trunk@34850
git-svn-id: http://core.svn.wordpress.org/trunk@34815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-06 03:45:25 +00:00
Dominik Schilling
fcc36d1adf
Media List Table: Remove the date display in column_parent()
.
...
It should be the time at which the post was written, but it was never because of the missing `$parent` argument.
Fixes #33238 .
Built from https://develop.svn.wordpress.org/trunk@34839
git-svn-id: http://core.svn.wordpress.org/trunk@34804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 22:25:26 +00:00
John Blackbourn
1e90e58da3
Correct pagination when viewing the 'Mine' link on the post listing screen.
...
Fixes #19609
Props ocean90
Built from https://develop.svn.wordpress.org/trunk@34837
git-svn-id: http://core.svn.wordpress.org/trunk@34802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 21:36:25 +00:00
Weston Ruter
31a394fcf7
Customizer: Reset horizontal scroll position when finished dragging a nav menu item.
...
Props karinedo, austinginder, adamsilverstein, tyxla.
Fixes #33367 .
Built from https://develop.svn.wordpress.org/trunk@34834
git-svn-id: http://core.svn.wordpress.org/trunk@34799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 20:46:27 +00:00
Helen Hou-Sandí
60431ae239
Permalinks: Slightly lengthen the truncated slug for display.
...
This brings it closer to the width of the input so there is less jumping around of buttons. We can afford the space now that other buttons in the space are typically no longer there.
fixes #18306 .
Built from https://develop.svn.wordpress.org/trunk@34833
git-svn-id: http://core.svn.wordpress.org/trunk@34798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 19:29:24 +00:00
Drew Jaynes
3f747a6395
Revisions: Also pass the $revision
post object to the wp_prepare_revision_for_js
filter, introduced in [34541].
...
Props helen.
Fixes #28627 .
Built from https://develop.svn.wordpress.org/trunk@34832
git-svn-id: http://core.svn.wordpress.org/trunk@34797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 18:33:28 +00:00
Drew Jaynes
a134491455
Docs: Document the $revision_data
parameter passed to the wp_prepare_revision_for_js
filter with a hash notation.
...
The hook was introduced in [34541].
See #28627 .
Built from https://develop.svn.wordpress.org/trunk@34831
git-svn-id: http://core.svn.wordpress.org/trunk@34796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 18:03:26 +00:00
Weston Ruter
31d02887b6
Customizer: Fix moving focus to available nav menu items search.
...
Fixes regression introduced in [34219].
Props tyxla.
See #33360 .
Fixes #34125 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34829
git-svn-id: http://core.svn.wordpress.org/trunk@34794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 15:27:24 +00:00
Boone Gorges
0e7c1d3b14
Use wp_installing()
instead of WP_INSTALLING
constant.
...
The `WP_INSTALLING` constant is a flag that WordPress sets in a number of
places, telling the system that options should be fetched directly from the
database instead of from the cache, that WP should not ping wordpress.org for
updates, that the normal "not installed" checks should be bypassed, and so on.
A constant is generally necessary for this purpose, because the flag is
typically set before the WP bootstrap, meaning that WP functions are not yet
available. However, it is possible - notably, during `wpmu_create_blog()` -
for the "installing" flag to be set after WP has already loaded. In these
cases, `WP_INSTALLING` would be set for the remainder of the process, since
there's no way to change a constant once it's defined. This, in turn, polluted
later function calls that ought to have been outside the scope of site
creation, particularly the non-caching of option data. The problem was
particularly evident in the case of the automated tests, where `WP_INSTALLING`
was set the first time a site was created, and remained set for the rest of the
suite.
The new `wp_installing()` function allows developers to fetch the current
installation status (when called without any arguments) or to set the
installation status (when called with a boolean `true` or `false`). Use of
the `WP_INSTALLING` constant is still supported; `wp_installing()` will default
to `true` if the constant is defined during the bootstrap.
Props boonebgorges, jeremyfelt.
See #31130 .
Built from https://develop.svn.wordpress.org/trunk@34828
git-svn-id: http://core.svn.wordpress.org/trunk@34793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 15:06:28 +00:00
Drew Jaynes
aa6fbdaa92
Docs: Add a missing DocBlock summary for wp_list_widget_controls_dynamic_sidebar()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34827
git-svn-id: http://core.svn.wordpress.org/trunk@34792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 03:06:24 +00:00
Drew Jaynes
b1b2ec30e2
Docs: Add missing DocBlock summaries for five functions in wp-admin/includes/template-functions.php.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34826
git-svn-id: http://core.svn.wordpress.org/trunk@34791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 03:03:25 +00:00
Drew Jaynes
0b332f6d7a
Docs: Add missing DocBlock summaries to three functions in wp-admin/includes/plugin.php.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34825
git-svn-id: http://core.svn.wordpress.org/trunk@34790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 02:55:24 +00:00
Drew Jaynes
4c2203b370
Docs: Add missing summaries for functions in wp-admin/includes/misc.php.
...
Also restructures the summary for `update_home_siteurl()`.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34824
git-svn-id: http://core.svn.wordpress.org/trunk@34789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 02:52:24 +00:00
Drew Jaynes
2de4cc7149
Docs: Add missing DocBlock summaries for a multitude of functions in wp-admin/includes/media.php.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34823
git-svn-id: http://core.svn.wordpress.org/trunk@34788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 02:44:25 +00:00
Drew Jaynes
3866a8cf58
Docs: Add missing method summaries for the deprecated WP_User_Search
class, including prepare_query()
, query()
, prepare_vars_for_template_usage()
, do_paging()
, and get_results()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34822
git-svn-id: http://core.svn.wordpress.org/trunk@34787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 02:35:25 +00:00
Drew Jaynes
1f1c2335ad
Docs: Add missing summaries for three deprecated admin functions: dropdown_categories()
, dropdown_link_categories()
, and wp_dropdown_cats()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34821
git-svn-id: http://core.svn.wordpress.org/trunk@34786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 02:29:26 +00:00
Drew Jaynes
6650dfea4f
Docs: Document the plugin data array returned by get_plugin_data()
with a hash-notation.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34818
git-svn-id: http://core.svn.wordpress.org/trunk@34783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-04 19:06:27 +00:00
Drew Jaynes
b453c9e976
Users: Don't pass the current WP_Users_List_Table
or WP_MS_Users_List_Table
instance to the users_list_table_query_args
filter after all.
...
After some discussion, it was decided that Multisite vs single site context can just as easily be derived using available functions like `is_network_admin()`, `get_current_screen()`, etc., rendering the second parameter moot. The hook was introduced in [34796].
Fixes #25360 .
Built from https://develop.svn.wordpress.org/trunk@34813
git-svn-id: http://core.svn.wordpress.org/trunk@34778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 21:49:24 +00:00
Sergey Biryukov
6b71b2304b
Merge some strings in wp-admin/upload.php
with existing strings with the same meaning.
...
Props pavelevap.
Fixes #31727 .
Built from https://develop.svn.wordpress.org/trunk@34797
git-svn-id: http://core.svn.wordpress.org/trunk@34762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 13:57:27 +00:00
Drew Jaynes
b38569a5fc
Users: Introduce the users_list_table_query_args
filter, for modifying the WP_User_Query
arguments used within the prepare_items()
methods in the users list tables.
...
The current list table is passed as a second parameter, `$this`, and can take the form of either a `WP_Users_List_Table` or `WP_MS_Users_List_Table` instance depending on the context in which the filter was evaluated.
Props juliobox for the initial patch.
Fixes #25360 .
Built from https://develop.svn.wordpress.org/trunk@34796
git-svn-id: http://core.svn.wordpress.org/trunk@34761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 07:24:25 +00:00
Sergey Biryukov
d6865505d5
Respect the force_delete
parameter of get_delete_post_link()
.
...
Previously, it only worked if `EMPTY_TRASH_DAYS` was disabled.
Props johnbillion, chriscct7.
Fixes #26832 .
Built from https://develop.svn.wordpress.org/trunk@34794
git-svn-id: http://core.svn.wordpress.org/trunk@34759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 01:50:25 +00:00
Weston Ruter
d9cca27386
Customize: Fix nav_menu_item
CSS classes
array being incorrectly presented in input field as comma-delimited list.
...
Instead of using `Array.toString()` to serialize an array with comma delimiters, explicitly `join` the array using spaces instead. Also ensure that `xfn` is handled properly if it ever gets stored as an array.
Props tyxla, westonruter.
Fixes #34111 .
Built from https://develop.svn.wordpress.org/trunk@34788
git-svn-id: http://core.svn.wordpress.org/trunk@34753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 00:15:24 +00:00
John Blackbourn
9bc54c9442
Remove the unnecessary dynamic prefix used in the plugin_action_links
filter name, and in those of its brethren. This way, network_admin_plugin_action_links
gets listed as a separate filter.
...
Fixes #34117
Built from https://develop.svn.wordpress.org/trunk@34786
git-svn-id: http://core.svn.wordpress.org/trunk@34751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 23:44:26 +00:00
John Blackbourn
815635548a
Switch the remaining user-facing links to wordpress.org over to HTTPS.
...
Fixes #27115
Built from https://develop.svn.wordpress.org/trunk@34783
git-svn-id: http://core.svn.wordpress.org/trunk@34748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 22:46:28 +00:00
Jeremy Felt
54512d64cb
MS: Use *_network_option()
functions throughout core.
...
Replaces all uses of `*_site_option()` with the corresponding "network" function.
This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.
Props spacedmonkey.
See #28290 .
Built from https://develop.svn.wordpress.org/trunk@34778
git-svn-id: http://core.svn.wordpress.org/trunk@34743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 19:08:26 +00:00
Drew Jaynes
769ad80521
Docs: Also clarify the expected element types depending on the value of $action
in the hook doc for the plugins_api
filter.
...
See [34763] for context.
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34764
git-svn-id: http://core.svn.wordpress.org/trunk@34729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 04:52:25 +00:00
Drew Jaynes
8478a1341b
Docs: Clarify the expected replacement element type if replacing the object or array in plugins_api()
via the plugins_api
hook.
...
If the `$action` type is 'query_plugins' or 'plugin_information', the API will return an object, thus an object should be passed if replacing it. For 'hot_tags' and 'hot_categories', the same logic applies, but with arrays instead.
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34763
git-svn-id: http://core.svn.wordpress.org/trunk@34728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 04:48:25 +00:00
Scott Taylor
da1c938a5c
Plugins: on the Install page, move the name of each plugin into the <h4>
to accommodate screen readers.
...
Props afercia, ChrisMKindred.
Fixes #32400 .
Built from https://develop.svn.wordpress.org/trunk@34760
git-svn-id: http://core.svn.wordpress.org/trunk@34725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-02 04:16:27 +00:00
Dominik Schilling
25b1dd594a
Install: Replace the "Privacy" setting with the "Search Engine Visibility" setting from Reading Settings.
...
Props Clorith, ocean90.
Fixes #27628 .
See #16416 .
Built from https://develop.svn.wordpress.org/trunk@34752
git-svn-id: http://core.svn.wordpress.org/trunk@34717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 21:35:25 +00:00
Dominik Schilling
18413f3e81
Upgrader: Clear plugin/theme caches directly after a plugin/theme has been installed.
...
`wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
To reset the caches `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.
Fixes #34029 .
Built from https://develop.svn.wordpress.org/trunk@34751
git-svn-id: http://core.svn.wordpress.org/trunk@34716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 21:21:25 +00:00
Jeremy Felt
7c7eee01ef
MS: Remove registration of ID column in Sites and Users list tables.
...
Reverts a portion of [34289] and leaves the render for the column behind. A plugin can register these fields for display via filter.
Fixes #18661 .
Built from https://develop.svn.wordpress.org/trunk@34750
git-svn-id: http://core.svn.wordpress.org/trunk@34715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 20:58:24 +00:00
Jeremy Felt
f69396c229
MS: Provide better UI when a main site's /blog
prefix is changed.
...
The main site on a new network is forced by default into using `/blog` as the prefix for its permalink structure. This can be changed easily through the network admin, though the `options-permalink.php` screen is then unusable to make further changes to the structure.
Now, if `/blog/` is not at the beginning of the `permalink_structure` option, we do not force `/blog` as a prefix in the UI.
Fixes #12002 .
Built from https://develop.svn.wordpress.org/trunk@34749
git-svn-id: http://core.svn.wordpress.org/trunk@34714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 20:39:24 +00:00
Dominik Schilling
113a9d4517
Language Upgrader: Re-use the automatic upgrader skin if the parent upgrader is using it.
...
Prevents broken Ajax responses when `Language_Pack_Upgrader::async_upgrade()` gets triggered during a shiny update.
Fixes #34048 .
Built from https://develop.svn.wordpress.org/trunk@34748
git-svn-id: http://core.svn.wordpress.org/trunk@34713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 20:25:26 +00:00
Andrea Fercia
0acededa82
In wp_comment_reply()
change the H5 headings in fieldset legends for better accessibility.
...
Also, add a "Edit Comment" legend before the Quick Edit form to pair it with "Reply to Comment" and "Add new Comment" and move the Name, Email, and URL fields after the Comment textarea.
Props joedolson, afercia.
Fixes #33757 .
Built from https://develop.svn.wordpress.org/trunk@34743
git-svn-id: http://core.svn.wordpress.org/trunk@34708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 14:52:25 +00:00
Andrea Fercia
5a2627d38a
Bump H3 headings to H2 on the Network Site Users screen for better accessibility.
...
Fixes #34081 .
Built from https://develop.svn.wordpress.org/trunk@34742
git-svn-id: http://core.svn.wordpress.org/trunk@34707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 14:33:26 +00:00
Dion Hulse
dc9203d753
Rewrite insert_with_markers()
to use flock()
when available, significant cleanup of the function too.
...
The call to `flock()` is an exclusive advisory lock, which in my testing only PHP respects (apache continues to read it).
Not all filesystems support locking (remote NFS mounts for example) so this offers minimal benefit to those platforms, but offers much better protection against file corruption on systems which do support it.
The call is blocking, so a second process will wait for the first to complete before writing if supported.
See #31767
Built from https://develop.svn.wordpress.org/trunk@34740
git-svn-id: http://core.svn.wordpress.org/trunk@34704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 07:46:27 +00:00
Dion Hulse
a4c41f6ee4
Updates: SSH2 Transport: Add a connection error when the SFTP subsystem cannot be initialized.
...
Fixes #33478
Built from https://develop.svn.wordpress.org/trunk@34739
git-svn-id: http://core.svn.wordpress.org/trunk@34703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 05:43:25 +00:00
Dion Hulse
d8aaf01b97
Updates: SSH2 Transport: Use a work around to avoid a bug where PHP's SSH2 extension fails to list the contents of the /
directory.
...
This fixes issues where SSH2 with chrooted environments runs into a `Unable to locate WordPress Content directory (wp-content).` error.
The workaround is to simply list the contents of the `/./` directory instead of `/`.
Fixes #33919
Built from https://develop.svn.wordpress.org/trunk@34738
git-svn-id: http://core.svn.wordpress.org/trunk@34702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 05:40:25 +00:00
Dion Hulse
9caa7c4ba7
Press This: Make the regular expressions for matching images easier to read by not requiring escaping.
...
Fixes #32878
Built from https://develop.svn.wordpress.org/trunk@34736
git-svn-id: http://core.svn.wordpress.org/trunk@34700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 05:16:25 +00:00
Dion Hulse
731b51ee7f
Updates: Try a more compatible method to detect if a file exists when using the FTP Extension.
...
This change causes it to list the parent directories files, and assets that the node exists within the returned listing, this is a little more compatible than relying upon the FTP server to correctly filter the returned resultset to the specific file/node being requested.
Fixes #28013
Built from https://develop.svn.wordpress.org/trunk@34733
git-svn-id: http://core.svn.wordpress.org/trunk@34697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 05:09:25 +00:00
Scott Taylor
594a208753
Post List Table: Ensure that edit.php
with no query string produces the proper markup and links in the date
column header.
...
Add 2 methods to `WP_List_Table`, `->get_orderby()` and `->get_order()`. Override the methods in `WP_Posts_List_Table`.
`WP_Posts_List_Table` calls `wp_edit_posts_query()` in `->prepare_items()` which is a wrapper for `wp()`. As such, we can obtain `orderby` and `order` via `get_query_var()`, instead of the URL.
Fixes #25493 .
Built from https://develop.svn.wordpress.org/trunk@34728
git-svn-id: http://core.svn.wordpress.org/trunk@34692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 02:10:25 +00:00
Helen Hou-Sandí
1bacb00c01
Comments: Trash blacklisted comments by default.
...
If trash is disabled, they wil continue to go into spam like they do now.
props wonderboymusic, solarissmoke, MikeHansenMe.
fixes #7051 .
Built from https://develop.svn.wordpress.org/trunk@34726
git-svn-id: http://core.svn.wordpress.org/trunk@34690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 01:49:25 +00:00
Drew Jaynes
3d6f53da06
Docs: Document declaration of the $submenu_file
global in wp-admin/menu-header.php.
...
See #24531 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34725
git-svn-id: http://core.svn.wordpress.org/trunk@34689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 01:48:25 +00:00
Drew Jaynes
2a0a841a13
Declare the $submenu_file
global to avoid a notice generated by passing it as a parameter to the submenu_file
hook, introduced in [34722].
...
Fixes #24531 .
Built from https://develop.svn.wordpress.org/trunk@34724
git-svn-id: http://core.svn.wordpress.org/trunk@34688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 01:23:25 +00:00
Helen Hou-Sandí
7365e0ebbb
Don't show the "Add New" link on post-new.php
.
...
Using the same `$post_new_file` global variable name in `wp-admin/menu.php` in [33723] was unintentional, but we're already unsetting other variables that are in global scope so we can just unset this one as well. Someday the admin menu won't be a big pile of sad and cryptic globals. Maybe.
props johnjamesjacoby, norcross.
fixes #34045 .
Built from https://develop.svn.wordpress.org/trunk@34723
git-svn-id: http://core.svn.wordpress.org/trunk@34687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 00:48:25 +00:00
Sergey Biryukov
145deeeada
Add 'submenu_file'
filter for the file of an admin menu sub-menu item.
...
This complements the `'parent_file'` filter added in [12712].
Props swissspidy, kraftbj.
Fixes #24531 .
Built from https://develop.svn.wordpress.org/trunk@34722
git-svn-id: http://core.svn.wordpress.org/trunk@34686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 00:23:28 +00:00
Weston Ruter
35631aeeeb
Customize: Style the nav menu "Add Items" button as disabled when reordering.
...
Fixes CSS selector to match what is being used for the "Add Widget" button in the customizer.
Props umesh.nevase.
Fixes #34102 .
Built from https://develop.svn.wordpress.org/trunk@34721
git-svn-id: http://core.svn.wordpress.org/trunk@34685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 22:55:26 +00:00
Drew Jaynes
8b4c499664
Docs: There are quite alot of typos in core inline comments.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34717
git-svn-id: http://core.svn.wordpress.org/trunk@34681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 04:13:48 +00:00
Drew Jaynes
5ec1077a38
Widgets: Introduce a delete_widget
action, which fires after a widget has been marked for deletion.
...
Props afercia for the initial patch.
Fixes #27444 .
Built from https://develop.svn.wordpress.org/trunk@34714
git-svn-id: http://core.svn.wordpress.org/trunk@34678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 03:21:26 +00:00
Scott Taylor
21752923f0
List Tables: .column-date
needs to become wider at smaller screen sizes, bump it from 10%
to 14%
at the breakpoint to prevent wrapping.
...
Fixes #32691 .
Built from https://develop.svn.wordpress.org/trunk@34710
git-svn-id: http://core.svn.wordpress.org/trunk@34674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 01:25:25 +00:00
Scott Taylor
41bc0aee88
Revert [34083], I was willing to try this out for the greater good. The good was not greater. There is too much baggage associated with this specific change as pertains to BC and expected layout.
...
See #32691 .
Built from https://develop.svn.wordpress.org/trunk@34709
git-svn-id: http://core.svn.wordpress.org/trunk@34673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 01:19:24 +00:00
Scott Taylor
882c34d555
List Tables: only hide bulk actions when there are no items, don't hide all of the extra table nav.
...
Fixes #33824 .
Built from https://develop.svn.wordpress.org/trunk@34707
git-svn-id: http://core.svn.wordpress.org/trunk@34671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-30 00:47:27 +00:00
Scott Taylor
84dbb036d1
Network Upgrade: switch <h3>
to <h2>
.
...
Props afercia.
Fixes #34082 .
Built from https://develop.svn.wordpress.org/trunk@34701
git-svn-id: http://core.svn.wordpress.org/trunk@34665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 21:29:13 +00:00
Andrea Fercia
9bb09f0e08
Bump H3 headings to H2 on the Network Settings screen for better accessibility.
...
Fixes #34078 .
Built from https://develop.svn.wordpress.org/trunk@34695
git-svn-id: http://core.svn.wordpress.org/trunk@34659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 18:52:26 +00:00
John Blackbourn
4d377dd4a1
On the Permalink Settings screen, add a link to the Nginx documentation when the current site is running Nginx. This is in lieu of showing actual Nginx configuration like we do for mod_rewrite or IIS.
...
Fixes #18852
Built from https://develop.svn.wordpress.org/trunk@34691
git-svn-id: http://core.svn.wordpress.org/trunk@34655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 11:15:26 +00:00
Gary Pendergast
cf173408cd
Permalinks: Add pretty permalinks for unattached attachments.
...
Previously, unattached attachments would have unsightly `/?attachment_id=1` URLs. As we've moved away from attachments being specifically attached to posts, instead being Media items, this has made the unattached URLs a more common occurrence.
We can breath easy once more, knowing that the world is a little bit safer from the horror of unnecessarily ugly URLs.
Props SergeyBiryukov, wonderboymusic, pento.
Fixes #1914 .
Built from https://develop.svn.wordpress.org/trunk@34690
git-svn-id: http://core.svn.wordpress.org/trunk@34654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 09:42:26 +00:00
Scott Taylor
7efab8df3f
Edit Media: wrap long filenames in the Publish meta box.
...
Fixes #34069 .
Built from https://develop.svn.wordpress.org/trunk@34684
git-svn-id: http://core.svn.wordpress.org/trunk@34648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-29 04:51:25 +00:00
Jeremy Felt
ea03ecbe66
Fixes #33816 .
...
MS: Adjust formatting of code in `site-new.php` to improve readability.
Fixes #34066 .
Built from https://develop.svn.wordpress.org/trunk@34673
git-svn-id: http://core.svn.wordpress.org/trunk@34637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 23:30:24 +00:00
Jeremy Felt
5397416276
MS: Delete rewrite_rules
when updating a switched site's URL.
...
Previously, rewrite rules could be flushed and regenerated in the context of another site. Deleting the rules when in a switched state allows for them to be generated properly on the next page view.
Fixes #33816 .
Built from https://develop.svn.wordpress.org/trunk@34672
git-svn-id: http://core.svn.wordpress.org/trunk@34636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 23:24:27 +00:00
Helen Hou-Sandí
02703fae19
Sample permalink: Buttons still need the .button
class.
...
Also fixes unit tests post-[34670]. The test methods have been slightly renamed because it is no longer a button. Hopefully this name will be more future-proof.
see #18306 .
Built from https://develop.svn.wordpress.org/trunk@34671
git-svn-id: http://core.svn.wordpress.org/trunk@34635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 22:07:25 +00:00
Helen Hou-Sandí
e976f9b503
Edit: Remove the redundant "View Post" button-link and link the sample permalink.
...
Previously there were two persistent "View Post" links on an edit screen: next to the permalink and in the toolbar. This would then become three links after a post was published or updated, as a link is also included in the admin notice. This is a lot of redundancy and visual noise for a flow that is not your primary action upon starting to edit a post. The "View Post" link next to the sample permalink was particularly bad because it is styled like a button, but unlike a button, does not keep you on the current screen.
Because the permalink is now linked, there is no highlighted slug that you can click to edit, but rather just the "Edit" button.
props scribu, lessbloat, sabreuse, SergeyBiryukov, DrewAPicture, helen.
see #18306 .
Built from https://develop.svn.wordpress.org/trunk@34670
git-svn-id: http://core.svn.wordpress.org/trunk@34634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 20:10:26 +00:00
John Blackbourn
2571b6dcec
Correct the logic used when determining whether to display the 'Mine' link on post list tables. It should only be shown when the count for the user's posts differs for the total count of posts. is_multi_author()
cannot be used because it only considers Posts.
...
Fixes #19609
Built from https://develop.svn.wordpress.org/trunk@34667
git-svn-id: http://core.svn.wordpress.org/trunk@34631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 19:15:24 +00:00
Scott Taylor
8bb4c2c2e9
Theme Editor: ensure that files named index.php
in theme subfolders are not labeled as "Main Index Template"
...
Props MikeHansenMe, wonderboymusic, bravokeyl, Shelob9.
Fixes #27201 .
Built from https://develop.svn.wordpress.org/trunk@34658
git-svn-id: http://core.svn.wordpress.org/trunk@34622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-28 03:11:24 +00:00
Drew Jaynes
a908b87996
Docs: Improve the hook documentation for the plugins_api_args
filter.
...
Standardizes the hook doc summary and expands on the expected type for the `$args` parameter.
See #34035 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34652
git-svn-id: http://core.svn.wordpress.org/trunk@34616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 23:03:24 +00:00
Drew Jaynes
9c46e6605e
Docs: Improve the hook documentation for the themes_api
filter.
...
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.
Also updates the expected types on the `$override` parameter.
See #34036 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34651
git-svn-id: http://core.svn.wordpress.org/trunk@34615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 23:01:24 +00:00
Drew Jaynes
0d447249c3
Docs: Normalize the data table spacing in the themes_api()
DocBlock following a typo fix in [34649].
...
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34650
git-svn-id: http://core.svn.wordpress.org/trunk@34614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:49:24 +00:00
Drew Jaynes
ad33a92b6b
Docs: Fix two typos in the DocBlock description for themes_api()
:
...
* The fourth `$action` type is 'feature_list'
* The first `$action` type in the data table should be 'query_themes'
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34649
git-svn-id: http://core.svn.wordpress.org/trunk@34613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:47:25 +00:00
Drew Jaynes
b27d14ccf3
Docs: Adjust the themes_api()
DocBlock description to clarify the "second" available hook, themes_api
, and add new information for the "third" hook, themes_api_result
.
...
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34648
git-svn-id: http://core.svn.wordpress.org/trunk@34612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:45:25 +00:00
Drew Jaynes
ed719e4d32
Docs: Improve the hook documentation for the plugins_api
filter.
...
Standardizes the hook doc summary and expands on expected behavior when short-circuiting the request, which is dependent on the `$action` type.
See #34035 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34647
git-svn-id: http://core.svn.wordpress.org/trunk@34611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:29:24 +00:00
Drew Jaynes
e7294234b9
Docs: Adjust the plugins_api()
DocBlock description to clarify the "second" available hook, plugins_api
, and add new information for the "third" hook, plugins_api_result
.
...
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34645
git-svn-id: http://core.svn.wordpress.org/trunk@34609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:23:24 +00:00
Drew Jaynes
61196c4862
Docs: Update the DocBlock summary for plugins_api()
to reflect the "WordPress.org" Plugins API.
...
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34642
git-svn-id: http://core.svn.wordpress.org/trunk@34606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:07:24 +00:00
Drew Jaynes
5b07b691f7
Docs: Further improve documentation for plugins_api()
.
...
* Adds a matrix-like data table demonstrating which arguments are available for the different `$action` types
* Adjusts the return types to accommodate an `array` for the 'hot_tags' `$action` choice
Props ocean90.
See #34035 .
Built from https://develop.svn.wordpress.org/trunk@34641
git-svn-id: http://core.svn.wordpress.org/trunk@34605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 22:00:25 +00:00
Drew Jaynes
b6de1478fd
Docs: Vastly improve documentation for themes_api()
.
...
Adds:
* A hash notation with descriptions for all accepted arguments
* A matrix-like data table demonstrating which arguments are available for the different `$action` types
* A better summary and description with linked hooks
* An improved return description with a link to external information
Props ocean90.
See #34036 .
Built from https://develop.svn.wordpress.org/trunk@34640
git-svn-id: http://core.svn.wordpress.org/trunk@34604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 21:52:25 +00:00
Helen Hou-Sandí
9cfddb6c3b
Autoprefixer for [34634].
...
Normally when there are multiple comma-separated values in CSS, each one would go on its own indented line. However, Autoprefixer appears to be tripping up on gradients at the moment, so it's going to stay on one line until we investigate upstream.
see #33299 .
Built from https://develop.svn.wordpress.org/trunk@34637
git-svn-id: http://core.svn.wordpress.org/trunk@34601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 19:17:25 +00:00
Scott Taylor
f78170934a
Users List Table: show the "Change role to" dropdown on the top and bottom. Currently only shows on top.
...
See #27743 .
Built from https://develop.svn.wordpress.org/trunk@34636
git-svn-id: http://core.svn.wordpress.org/trunk@34600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 19:11:26 +00:00
Scott Taylor
1c74c7108f
Feature Image: Improve the preview for transparent background images by using CSS3 to show a checkered background.
...
Props metodiew.
Fixes #33299 .
Built from https://develop.svn.wordpress.org/trunk@34634
git-svn-id: http://core.svn.wordpress.org/trunk@34598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:41:25 +00:00
Drew Jaynes
ccef2fc743
Docs: Add documentation for the $browse
, $user
, $search
, $author
, $tag
, $installed_plugins
, and $page
parameters in plugins_api()
.
...
Props ocean90.
Fixes #34035 .
Built from https://develop.svn.wordpress.org/trunk@34631
git-svn-id: http://core.svn.wordpress.org/trunk@34595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 18:13:48 +00:00
Weston Ruter
7493641f86
Customize: Prevent showing "Front Page" and "Posts Page" states for pages in list table when show_on_front
is not "page".
...
Changing the `show_on_front` option back to "posts" also resets the `page_on_front` and `page_for_posts` options when updating via the Reading settings page. In the Customizer, however, this is not the case as these other options remain unchanged. This change accounts for this difference in behavior.
Fixes #34004 .
Built from https://develop.svn.wordpress.org/trunk@34605
git-svn-id: http://core.svn.wordpress.org/trunk@34569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 20:54:25 +00:00
Dominik Schilling
7b33ad2a99
Plugins: Don't request all fields via plugins_api( 'plugin_information' )
for plugin installs and update checks.
...
The Plugins API returns a lot of data by default (see [34596]) but when installing or checking for updates we don't need all of it. To save bandwidth, memory and time request only required fields.
Fixes #34030 .
Built from https://develop.svn.wordpress.org/trunk@34598
git-svn-id: http://core.svn.wordpress.org/trunk@34562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 15:50:25 +00:00
Drew Jaynes
ae91c35cb3
Docs: Add much-needed (and awesome) hash-notation-style documentation for the $args
parameter in the plugins_api()
DocBlock.
...
Also fixes up some formatting in the DocBlock summary and description, and adds a link to the function reference, where supplementary information on return object structs and formatting will live.
Props ocean90.
Fixes #34035 .
Built from https://develop.svn.wordpress.org/trunk@34596
git-svn-id: http://core.svn.wordpress.org/trunk@34560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 15:13:25 +00:00
Sergey Biryukov
cef2439453
Replace a stray semicolon on Edit Page screen with a full stop.
...
Props manolis09, sjmur.
Fixes #33297 .
Built from https://develop.svn.wordpress.org/trunk@34594
git-svn-id: http://core.svn.wordpress.org/trunk@34558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:44:26 +00:00
Drew Jaynes
1a91ac752a
Docs: Fix a minor typo from [34592]. Meant to be past-tense, not present.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34593
git-svn-id: http://core.svn.wordpress.org/trunk@34557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:14:25 +00:00
Drew Jaynes
231b6f4d5b
Docs: Add missing parameter documentation for $profileuser
in the hook doc for show_password_fields
, added in [11302].
...
Also adds a changelog entry for when the parameter was introduced.
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34592
git-svn-id: http://core.svn.wordpress.org/trunk@34556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:11:49 +00:00
Sergey Biryukov
b28dd45f3d
Network Admin: Properly pass the number of delete plugins to the corresponding message.
...
Fixes #33239 .
Built from https://develop.svn.wordpress.org/trunk@34591
git-svn-id: http://core.svn.wordpress.org/trunk@34555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:11:25 +00:00
Drew Jaynes
efad273513
Docs: Relocate the hook doc for the show_password_fields
filter to its duplicate, since the original was removed in [34582].
...
Adds a changelog entry noting the adjustment in behavior, and simplifies the conditional logic.
Fixes #15115 .
Built from https://develop.svn.wordpress.org/trunk@34590
git-svn-id: http://core.svn.wordpress.org/trunk@34554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 13:05:26 +00:00
Scott Taylor
75b1dde362
Posts List Table: check is_multi_author()
before attempting to set ->user_posts_count
. Also, don't show "Mine" when the count is the same as "All."
...
Fixes #19609 .
Built from https://develop.svn.wordpress.org/trunk@34584
git-svn-id: http://core.svn.wordpress.org/trunk@34548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 06:51:26 +00:00
Scott Taylor
0d8a80b14c
Profile: on user-new.php
, don't allow the password fields to be hidden. When hidden, you can't add a user.
...
Props coffee2code.
Fixes #15115 .
Built from https://develop.svn.wordpress.org/trunk@34582
git-svn-id: http://core.svn.wordpress.org/trunk@34546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 06:15:26 +00:00
John Blackbourn
aa35e473f7
callback
is not a valid type in PHP, PSR-5, or phpDocumentor. callable
should be used instead.
...
Fixes #34032
Built from https://develop.svn.wordpress.org/trunk@34566
git-svn-id: http://core.svn.wordpress.org/trunk@34530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 23:58:25 +00:00
Drew Jaynes
3229785656
Docs: Fix the syntax for a mid-file sectional comment in wp-admin/includes/dashboard.php.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34565
git-svn-id: http://core.svn.wordpress.org/trunk@34529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 22:51:24 +00:00
Drew Jaynes
115c382132
Docs: Remove an inline comment duplicated by the DocBlock summary for wp_dashboard_trigger_widget_control()
.
...
Props tyxla.
Fixes #34014 .
Built from https://develop.svn.wordpress.org/trunk@34564
git-svn-id: http://core.svn.wordpress.org/trunk@34528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 22:50:26 +00:00
Weston Ruter
208330f2dc
Customizer: Defer embedding widget controls to improve DOM performance and initial load time.
...
The Menu Customizer feature includes a performance technique whereby the controls for nav menu items are only embedded into the DOM once the containing menu section is expanded. This commit implements the same DOM deferral for widgets but goes a step further than just embedding the controls once the widget area's Customizer section is expanded: it also defers the embedding of the widget control's form until the widget is expanded, at which point the `widget-added` event also fires to allow any additional widget initialization to be done. The deferred DOM embedding can speed up initial load time by 10x or more. This DOM deferral also yields a reduction in overall memory usage in the browser process.
Includes changes to `wp_widget_control()` to facilitate separating out the widget form from the surrounding accordion container; also includes unit tests for this previously-untested function. Also included are initial QUnit tests (finally) for widgets in the Customizer.
Fixes #33901 .
Built from https://develop.svn.wordpress.org/trunk@34563
git-svn-id: http://core.svn.wordpress.org/trunk@34527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 21:02:27 +00:00
Boone Gorges
4e051fa421
After [35461], remove 'page_comments' from database.
...
* Don't set as part of initial schema.
* Delete as part of the `$unusedoptions` routine.
Props ocean90.
See #8071 .
Built from https://develop.svn.wordpress.org/trunk@34562
git-svn-id: http://core.svn.wordpress.org/trunk@34526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 20:50:25 +00:00
Boone Gorges
18d6b3c8dc
Force comment pagination on single posts.
...
Previously, the 'page_comments' toggle allowed users to disable comment
pagination. This toggle was only superficial, however. Even with
'page_comments' turned on, `comments_template()` loaded all of a post's
comments into memory, and passed them to `wp_list_comments()` and
`Walker_Comment`, the latter of which produced markup for only the
current page of comments. In other words, it was possible to enable
'page_comments', thereby showing only a subset of a post's comments on a given
page, but all comments continued to be loaded in the background. This technique
scaled poorly. Posts with hundreds or thousands of comments would load slowly,
or not at all, even when the 'comments_per_page' setting was set to a
reasonable number.
Recent changesets have addressed this problem through more efficient tree-
walking, better descendant caching, and more selective queries for top-level
post comments. The current changeset completes the project by addressing the
root issue: that loading a post causes all of its comments to be loaded too.
Here's the breakdown:
* Comment pagination is now forced. Setting 'page_comments' to false leads to evil things when you have many comments. If you want to avoid pagination, set 'comments_per_page' to something high.
* The 'page_comments' setting has been expunged from options-discussion.php, and from places in the codebase where it was referenced. For plugins relying on 'page_comments', we now force the value to `true` with a `pre_option` filter.
* `comments_template()` now queries for an appropriately small number of comments. Usually, this means the `comments_per_page` value.
* To preserve the current (odd) behavior for comment pagination links, some unholy hacks have been inserted into `comments_template()`. The ugliness is insulated in this function for backward compatibility and to minimize collateral damage. A side-effect is that, for certain settings of 'default_comments_page', up to 2x the value of `comments_per_page` might be fetched at a time.
* In support of these changes, a `$format` parameter has been added to `WP_Comment::get_children()`. This param allows you to request a flattened array of comment children, suitable for feeding into `Walker_Comment`.
* `WP_Query` loops are now informed about total available comment counts and comment pages by the `WP_Comment_Query` (`found_comments`, `max_num_pages`), instead of by `Walker_Comment`.
Aside from radical performance improvements in the case of a post with many
comments, this changeset fixes a bug that caused the first page of comments to
be partial (`found_comments` % `comments_per_page`), rather than the last, as
you'd expect.
Props boonebgorges, wonderboymusic.
Fixes #8071 .
Built from https://develop.svn.wordpress.org/trunk@34561
git-svn-id: http://core.svn.wordpress.org/trunk@34525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 20:40:25 +00:00
Weston Ruter
885944f79f
Customizer: Fix usage of jQuery.contains()
allowing active
state changes to again animate control visibility.
...
Aligns usage of `jQuery.contains()` in a control's `onChangeActive` method with the existing usage in the corresponding `onChangeActive` method for panels and sections.
Props nikeo.
Fixes #33509 .
Built from https://develop.svn.wordpress.org/trunk@34557
git-svn-id: http://core.svn.wordpress.org/trunk@34521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 19:54:50 +00:00
Helen Hou-Sandí
e3dd4b7f4f
Shortlinks: Hide the Get Shortlink button by default.
...
Shortlinks had their day in the popular usage sun before all these services moved to their own shorteners and running your own custom one became a lot easier. Shortlinks are still useful in some contexts, such as analytics or when links need to be shared verbally or copied down by hand.
If any filters are hooked onto `pre_get_shortlink` or `get_shortlink` and produce a non-empty value (with an exception described below), the button will magically reappear. This allows any custom shortlinks to keep the button without hiccups.
If you're in need of the default shortlinks, the fastest way to reenable them is `add_filter( 'pre_get_shortlink', '__return_false' )`. Note that it must return false in order to continue on to the rest of `wp_get_shortlink()`.
props grvrulz for the initial patch.
fixes #33495 .
Built from https://develop.svn.wordpress.org/trunk@34556
git-svn-id: http://core.svn.wordpress.org/trunk@34520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 19:54:25 +00:00
John Blackbourn
a729efa688
Implement 'Recently Active' functionality for network-wide plugins in the Network Admin.
...
Fixes #20468
Thanks to WordCamp RI attendees for testing!
Built from https://develop.svn.wordpress.org/trunk@34551
git-svn-id: http://core.svn.wordpress.org/trunk@34515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 19:16:27 +00:00
Sergey Biryukov
105d99613a
Plugin Editor: Don't split the strings with plugin file name and remove unnecessary context.
...
Partially reverts [34341].
Fixes #31862 .
Built from https://develop.svn.wordpress.org/trunk@34547
git-svn-id: http://core.svn.wordpress.org/trunk@34511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 15:19:24 +00:00
John Blackbourn
c69ec5a19a
Introduce a send_update_notification_email
which controls whether an update notification email is sent for background updates. This filter allows control over each of the update types (plugin, theme, translation) and compliments the automatic_updates_send_debug_email
and send_core_update_notification_email
filters.
...
Fixes #33932
Props ronalfy
Built from https://develop.svn.wordpress.org/trunk@34543
git-svn-id: http://core.svn.wordpress.org/trunk@34507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 14:29:23 +00:00
Scott Taylor
8a8e6557d0
Revisions: add a 'wp_prepare_revision_for_js'
filter.
...
Props jtsternberg, adamsilverstein.
Fixes #28627 .
Built from https://develop.svn.wordpress.org/trunk@34541
git-svn-id: http://core.svn.wordpress.org/trunk@34505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 14:04:24 +00:00
Scott Taylor
fa58223b49
Profile: when clicking "Generate Password", toggling visibility, then canceling, ensure that the UI resets properly for when the "Generate Password" button is clicked again.
...
Props umesh.nevase.
Fixes #33897 .
Built from https://develop.svn.wordpress.org/trunk@34539
git-svn-id: http://core.svn.wordpress.org/trunk@34503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 13:54:24 +00:00
Boone Gorges
fd946a9b5a
Pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@34534
git-svn-id: http://core.svn.wordpress.org/trunk@34498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 04:44:25 +00:00
Boone Gorges
8b4a5d1ec0
Introduce metadata for taxonomy terms.
...
Adds a new table to the database schema (`wp_termmeta`), and a set of
`*_term_meta()` API functions. `get_terms()` and `wp_get_object_terms()`
now also support 'meta_query' parameters, with syntax identical to other
uses of `WP_Meta_Query`.
When fetching terms via `get_terms()` or `wp_get_object_terms()`, metadata for
matched terms is preloaded into the cache by default. Disable this behavior
by setting the new `$update_term_meta_cache` paramater to `false`.
To maximize performance, within `WP_Query` loops, the termmeta cache is *not*
primed by default. Instead, we use a lazy-loading technique: metadata for all
terms belonging to posts in the loop is loaded into the cache the first time
that `get_term_meta()` is called within the loop.
Props boonebgorges, sirzooro.
See #10142 .
Built from https://develop.svn.wordpress.org/trunk@34529
git-svn-id: http://core.svn.wordpress.org/trunk@34493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 03:59:27 +00:00
Scott Taylor
e87150fc06
Comments List Table: after [34179], scope the <th>
s and <td>
s as direct descendants of their parent row.
...
Fixes #33943 .
Built from https://develop.svn.wordpress.org/trunk@34527
git-svn-id: http://core.svn.wordpress.org/trunk@34491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 02:21:26 +00:00
Dominik Schilling
df3098f36d
Plugins: Don't use _n()
for singular/plural strings which have no placeholder for a number.
...
Fixes #33239 .
See #28502 .
Built from https://develop.svn.wordpress.org/trunk@34521
git-svn-id: http://core.svn.wordpress.org/trunk@34485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 21:07:25 +00:00
Scott Taylor
44822831fe
Comments List Table JS: move the dynamic count functions into closure scope so that setCommentsList
AND commentReply
can access them. Update counts when replying inline.
...
Fixes #33403 .
Built from https://develop.svn.wordpress.org/trunk@34517
git-svn-id: http://core.svn.wordpress.org/trunk@34481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:16:49 +00:00
Scott Taylor
79974ac413
Edit Post: in the logic determining whether to display the Comments meta box, check for the current post status in get_post_stati( array( 'public' => true ) )
instead of just checking publish
and private
. Ensure that private
is checked in both instances.
...
Props Thaicloud, wonderboymusic.
Fixes #24486 .
Built from https://develop.svn.wordpress.org/trunk@34515
git-svn-id: http://core.svn.wordpress.org/trunk@34479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:02:24 +00:00
Scott Taylor
bf04b211a4
Widgets: use input[type="number"]
for the number
prop in the Recent Posts and Recent Comments widget forms.
...
Props helen, obenland, mordauk.
Fixes #22965 .
Built from https://develop.svn.wordpress.org/trunk@34514
git-svn-id: http://core.svn.wordpress.org/trunk@34478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 19:53:26 +00:00
Andrea Fercia
6fdd384fe0
Comments List Table: fix the translators comment for all count after [34506].
...
See #17275 .
Built from https://develop.svn.wordpress.org/trunk@34508
git-svn-id: http://core.svn.wordpress.org/trunk@34472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 18:40:24 +00:00
Scott Taylor
4671e03766
Comments List Table: include count for "All". Dynamically update.
...
Fixes #17275 .
Built from https://develop.svn.wordpress.org/trunk@34506
git-svn-id: http://core.svn.wordpress.org/trunk@34470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:57:25 +00:00
John Blackbourn
41edf2bc22
Correctly present an error to the user if the nickname field is empty when updating a user profile. It's strange that this field is required, but it is, so be it.
...
Fixes #33310
Props prasad-nevase, metodiew
Built from https://develop.svn.wordpress.org/trunk@34505
git-svn-id: http://core.svn.wordpress.org/trunk@34469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:49:25 +00:00
Scott Taylor
bc5eb3a623
Comments: add date
column to WP_Comments_List_Table
to allow sorting and to break out the date/time from the comment content column.
...
Props jshreve.
Fixes #15520 .
Built from https://develop.svn.wordpress.org/trunk@34504
git-svn-id: http://core.svn.wordpress.org/trunk@34468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:27:26 +00:00
Scott Taylor
5b9af35c4c
Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
...
Fixes #10422 .
Built from https://develop.svn.wordpress.org/trunk@34500
git-svn-id: http://core.svn.wordpress.org/trunk@34464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 15:53:25 +00:00
Drew Jaynes
9dba452afc
Docs: Standardize and clarify class DocBlocks for all of the Upgrade API classes.
...
Standardizes summaries and tags for the following classes:
* `WP_Upgrader`
* `Plugin_Upgrader`
* `Theme_Upgrader`
* `Language_Pack_Upgrader`
* `Core_Upgrader`
* `File_Upload_Upgrader`
* `WP_Automatic_Updater`
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34499
git-svn-id: http://core.svn.wordpress.org/trunk@34463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:54:25 +00:00
Drew Jaynes
dae68e1485
Docs: Clarify the file header for wp-admin/includes/class-wp-upgrader.php.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34498
git-svn-id: http://core.svn.wordpress.org/trunk@34462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:44:25 +00:00
Drew Jaynes
8c0a805273
Docs: Mark the optional $upgrader
parameter as such and add a description in the DocBlock for Language_Pack_Upgrader::async_upgrade()
.
...
See [32655].
See #30989 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34497
git-svn-id: http://core.svn.wordpress.org/trunk@34461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:35:25 +00:00
Drew Jaynes
0fc9bed46e
Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_ftpsockets::get_contents()
.
...
Also reverses the return types as `string` is expected, `false` is the outlier.
See [30978].
See #30989 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34495
git-svn-id: http://core.svn.wordpress.org/trunk@34459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:22:24 +00:00
Drew Jaynes
fbb6ef1922
Docs: Add a summary, version, and parameter and return descriptions to the DocBlock for WP_Filesystem_FTPext::get_contents()
.
...
Also reverses the return types as `string` is expected, `false` is the outlier.
See [30978].
See #30989 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34493
git-svn-id: http://core.svn.wordpress.org/trunk@34457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 14:11:26 +00:00
Drew Jaynes
f1532ccde8
Docs: Add a summary, version, and @access
tag to the property DocBlock for Custom_Image_Header->updated
.
...
See [14907] for where the property was initially introduced.
See [30187] for where the property was actually declared.
Props brentvr.
See #30224 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34491
git-svn-id: http://core.svn.wordpress.org/trunk@34455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 13:39:25 +00:00
Drew Jaynes
caf3df03bc
Docs: Add a summary, version, and @access
tag to the property DocBlock for Custom_Background->updated
.
...
See [13765] for where the property was initially introduced.
See [30186] for where the property was actually declared.
Props brentvr.
See #30224 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34490
git-svn-id: http://core.svn.wordpress.org/trunk@34454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 13:34:24 +00:00
Dominik Schilling
340b7a5289
Edit Post: Add missing periods.
...
See #31858 .
Built from https://develop.svn.wordpress.org/trunk@34486
git-svn-id: http://core.svn.wordpress.org/trunk@34450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 08:54:26 +00:00
Scott Taylor
b6e70baa04
Plugins: on the plugins admin screen, the "has been deleted" string needs a plural.
...
Props jmayhak.
Fixes #33239 .
Built from https://develop.svn.wordpress.org/trunk@34475
git-svn-id: http://core.svn.wordpress.org/trunk@34439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:42:25 +00:00
Scott Taylor
d6155dd405
Edit Post: After [33666], separate the translation string for pages, avoiding HTML usage.
...
Props ramiy.
Fixes #31858 .
Built from https://develop.svn.wordpress.org/trunk@34473
git-svn-id: http://core.svn.wordpress.org/trunk@34437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:28:24 +00:00
Scott Taylor
2071978a3f
After [34341], add translation strings.
...
Props ramiy.
Fixes #31862 .
Built from https://develop.svn.wordpress.org/trunk@34469
git-svn-id: http://core.svn.wordpress.org/trunk@34433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 03:09:24 +00:00
Scott Taylor
25f206e01f
List Tables: add JS code to dynamically toggle the disabled
attribute of the Bulk Actions dropdown and Apply button.
...
Props wonderboymusic, pareshradadiya.
Fixes #31634 .
Built from https://develop.svn.wordpress.org/trunk@34467
git-svn-id: http://core.svn.wordpress.org/trunk@34431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 01:07:24 +00:00
Scott Taylor
652a3030e1
Comments: allow meta boxes for Discussion and Comments in extenuating circumstances.
...
* Discussion: Post Type stops supporting comments, but comments and/or pings are open on a post.
* Comments: Post is published or private, the post type has stopped supporting comments, but comments and/or pings are open on a post.
Currently, there is no way to toggle those settings off.
Props couturefreak, wonderboymusic, rachelbaker.
Fixes #28080 .
Built from https://develop.svn.wordpress.org/trunk@34461
git-svn-id: http://core.svn.wordpress.org/trunk@34425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 19:49:26 +00:00
Boone Gorges
3c028a80d4
Allow comment_exists()
to match based on GMT date.
...
The `comment_date_gmt` field of the `wp_comments` table is indexed, which makes
`WHERE` matches against the field much faster than against the unindexed
`comment_date`. For bulk operations like data import, the speed difference can
be meaningful.
We continue to default to 'blog' for `$timezone`, to preserve compatibility
with existing uses.
Props apokalyptik.
Fixes #33871 .
Built from https://develop.svn.wordpress.org/trunk@34460
git-svn-id: http://core.svn.wordpress.org/trunk@34424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 18:16:26 +00:00
John Blackbourn
af1517279e
Avoid a PHP notice if the last_updated
property isn't present in a plugin's data from the Plugins API.
...
Fixes #33024
Props icetee
Built from https://develop.svn.wordpress.org/trunk@34458
git-svn-id: http://core.svn.wordpress.org/trunk@34422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-23 15:10:25 +00:00
Scott Taylor
939d9b7395
Remove some unused globals and/or their docs.
...
See ##33491.
Built from https://develop.svn.wordpress.org/trunk@34446
git-svn-id: http://core.svn.wordpress.org/trunk@34410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 20:27:25 +00:00
Drew Jaynes
fc3ec39515
Docs: Clarify the file header summary for wp-admin/includes/template-functions.php, introduced in [34241].
...
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34427
git-svn-id: http://core.svn.wordpress.org/trunk@34391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:37:25 +00:00
Drew Jaynes
b168337aab
Docs: Clarify the file header summary for wp-admin/includes/class-wp-internal-pointers.php, introduced in [34241].
...
Also adds a missing class DocBlock to `WP_Internal_Pointers`. See [19388].
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34426
git-svn-id: http://core.svn.wordpress.org/trunk@34390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:35:25 +00:00
Drew Jaynes
2a37e00b92
Docs: Clarify the file header summary for wp-admin/includes/class-walker-category-checklist.php, introduced in [34241].
...
Also clarifies the class DocBlock summary for `Walker_Category_Checklist`.
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34425
git-svn-id: http://core.svn.wordpress.org/trunk@34389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:33:48 +00:00
Sergey Biryukov
8db1c75a7e
Remove extra HTML from translatable strings in WP_Comments_List_Table::get_views()
.
...
Add a context and translator comments.
Props Tmeister for initial patch.
Fixes #31859 .
Built from https://develop.svn.wordpress.org/trunk@34424
git-svn-id: http://core.svn.wordpress.org/trunk@34388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:33:25 +00:00
Drew Jaynes
c7022a334d
Docs: Clarify the file header summary for wp-admin/includes/class-wp-post-comments-list-table.php, introduced in [34223].
...
Also clarifies the class DocBlock summary and tags for `WP_Post_Comments_List_Table`.
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34423
git-svn-id: http://core.svn.wordpress.org/trunk@34387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:31:24 +00:00
Drew Jaynes
d7624168cd
Docs: Clarify the class DocBlock summary for WP_Screen
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34422
git-svn-id: http://core.svn.wordpress.org/trunk@34386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:28:24 +00:00
Drew Jaynes
ee97475edb
Docs: Add a file header to wp-admin/includes/nav-menus.php.
...
See [34168]. See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34421
git-svn-id: http://core.svn.wordpress.org/trunk@34385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 14:27:24 +00:00
Drew Jaynes
35246a957f
Docs: The User API is singular.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34393
git-svn-id: http://core.svn.wordpress.org/trunk@34357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 12:31:26 +00:00
Drew Jaynes
783876bd1a
Docs: The Widget API is singular.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@34392
git-svn-id: http://core.svn.wordpress.org/trunk@34356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 12:28:27 +00:00
Drew Jaynes
e845a6ed97
Docs: Update the file path in the duplicate hook comment for the admin_xml_ns
hook in wp-admin/includes/template-functions.php.
...
The hook was "moved" to the newly-created template-functions.php file via `svn cp` in [34241].
Props dimadin.
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34391
git-svn-id: http://core.svn.wordpress.org/trunk@34355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 10:32:26 +00:00
Scott Taylor
f9c2a88a8a
List Tables: when comparing string literals (non-numeric in nature) against vars, strict comparison can/should be used.
...
Props wonderboymusic, Viper007Bond.
Fixes #21249 .
Built from https://develop.svn.wordpress.org/trunk@34383
git-svn-id: http://core.svn.wordpress.org/trunk@34347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 06:06:25 +00:00
Scott Taylor
3c1e05f7c9
Dashboard: 2 submit buttons don't need names.
...
Props garyc40, gizburdt.
Fixes #16345 .
Built from https://develop.svn.wordpress.org/trunk@34382
git-svn-id: http://core.svn.wordpress.org/trunk@34346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 05:45:26 +00:00
Scott Taylor
aa8c76258a
After [34374], ensure that $iptc
is defined.
...
See #33772 .
Built from https://develop.svn.wordpress.org/trunk@34378
git-svn-id: http://core.svn.wordpress.org/trunk@34342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:49:24 +00:00
Scott Taylor
c60b00fc20
Multisite: as a precaution, make wp-json
a reserved subdirectory name.
...
Props austinginder.
Fixes #33789 .
Built from https://develop.svn.wordpress.org/trunk@34375
git-svn-id: http://core.svn.wordpress.org/trunk@34339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:21:25 +00:00
Scott Taylor
1d513fe737
Media: In wp_read_image_metadata()
, include IPTC Keywords when available in $meta
.
...
Adds unit test.
Props swissspidy, dbru, SteveHoneyNZ.
Fixes #33772 .
Built from https://develop.svn.wordpress.org/trunk@34374
git-svn-id: http://core.svn.wordpress.org/trunk@34338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 04:19:24 +00:00
Scott Taylor
39552b63ca
Passwords: fix the markup on the Reset Password Form for user-pass1
so the JavaScript operates properly.
...
Props ldinclaux.
See #33892 .
Fixes #33908 .
Built from https://develop.svn.wordpress.org/trunk@34371
git-svn-id: http://core.svn.wordpress.org/trunk@34335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 03:57:24 +00:00
Scott Taylor
3ad78c4ec5
Help Tabs: when returning help tabs, return them in order of priority, but also return the items in each priority in the order that they were added.
...
Fixes #33941 .
Built from https://develop.svn.wordpress.org/trunk@34370
git-svn-id: http://core.svn.wordpress.org/trunk@34334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-22 03:37:25 +00:00
Drew Jaynes
8241813825
Docs: Move a duplicate hook comment accidentally left behind when its corresponding filter was relocated in [31765].
...
See #31443 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34368
git-svn-id: http://core.svn.wordpress.org/trunk@34332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 23:13:26 +00:00
Helen Hou-Sandí
dd08157024
Notices: Add styles for use against white backgrounds.
...
These colored backgrounds can be accessed by adding the `.notice-alt` class to a notice.
There is also now a large version when using the `.notice-large` class, and a `.notice-title` class that is appropriate for headline text within a large notice.
props paulwilde, hugobaeta, melchoyce.
fixes #32244 .
Built from https://develop.svn.wordpress.org/trunk@34365
git-svn-id: http://core.svn.wordpress.org/trunk@34329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 15:26:25 +00:00
Scott Taylor
f4121923da
Meta Boxes: In post_categories_meta_box()
, convert some spaces to tabs.
...
Props miyauchi.
Fixes #33945 .
Built from https://develop.svn.wordpress.org/trunk@34364
git-svn-id: http://core.svn.wordpress.org/trunk@34328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-21 15:18:26 +00:00
John Blackbourn
f38013229b
Implement a 'Mine' link on post listing screens in the admin area for all users who have authored posts. This feature was previously only available to users who cannot edit other users' posts (namely Authors and Contributors).
...
Props linuxologos, wonderboymusic
Fixes #19609
Built from https://develop.svn.wordpress.org/trunk@34360
git-svn-id: http://core.svn.wordpress.org/trunk@34324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 17:28:24 +00:00
John Blackbourn
970752a351
Remove the ability to view the term editing screen for taxonomies with show_ui
set to false
. It is unexpected and unintended behaviour that this is allowed.
...
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_taxonomy()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu` and `show_in_nav_menus` are false.
Fixes #33938
Built from https://develop.svn.wordpress.org/trunk@34359
git-svn-id: http://core.svn.wordpress.org/trunk@34323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 17:11:25 +00:00
John Blackbourn
86bb996446
Implement some more uses of wp_login_url()
in places where wp-login.php is hard-coded.
...
See #31495
Built from https://develop.svn.wordpress.org/trunk@34358
git-svn-id: http://core.svn.wordpress.org/trunk@34322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 16:54:24 +00:00
Konstantin Obenland
b548119d99
Multisite: Make site status classes available to other elements.
...
Fixes a regression introduced in [31181], where links to user's site would not
have a colored background based on their status anymore.
Fixed during WordCamp Switzerland Contributor Day.
Props psoluch.
Fixes #33595 .
Built from https://develop.svn.wordpress.org/trunk@34356
git-svn-id: http://core.svn.wordpress.org/trunk@34320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 12:53:27 +00:00
Dominik Schilling
ca3e65e20e
Upgrader: Avoid using an HTML tag in a translation string, add translator comments.
...
Props ramiy for initial patch.
Fixes #31860 .
Built from https://develop.svn.wordpress.org/trunk@34352
git-svn-id: http://core.svn.wordpress.org/trunk@34316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 08:59:24 +00:00
Sergey Biryukov
d63bb56030
Pass the current post object to 'page_attributes_meta_box_template'
action added in [34340].
...
Props DrewAPicture.
Fixes #33625 .
Built from https://develop.svn.wordpress.org/trunk@34350
git-svn-id: http://core.svn.wordpress.org/trunk@34314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 08:15:28 +00:00
Drew Jaynes
292243944f
Docs: Use standardized vernacular in the hook doc summary for the page_attributes_meta_box_template
filter, introduced in [34340].
...
See #33625 .
Built from https://develop.svn.wordpress.org/trunk@34349
git-svn-id: http://core.svn.wordpress.org/trunk@34313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 06:38:25 +00:00
Scott Taylor
84da11d918
Pass false
as the 2nd argument to class_exists()
to disable autoloading and to not cause problems for those who define __autoload()
.
...
Fixes #20523 .
Built from https://develop.svn.wordpress.org/trunk@34348
git-svn-id: http://core.svn.wordpress.org/trunk@34312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:52:25 +00:00
Scott Taylor
82709c30d9
The 'get_sample_permalink_html'
filter's second parameter can be a post ID or a post object. This is confusing. We should pass the post ID and post object separately, for consistency with 'get_sample_permalink'
filter added in [34309].
...
Props SergeyBiryukov.
Fixes #33927 .
Built from https://develop.svn.wordpress.org/trunk@34347
git-svn-id: http://core.svn.wordpress.org/trunk@34311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:26:25 +00:00
Scott Taylor
d34b59a5d2
Plugins Admin: Avoid using HTML tags in translation strings, add translator strings.
...
Props swissspidy, voldemortensen.
Fixes #32269 .
Built from https://develop.svn.wordpress.org/trunk@34344
git-svn-id: http://core.svn.wordpress.org/trunk@34308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 03:01:24 +00:00
Scott Taylor
ebb01aae4c
Plugin Editor: Avoid using HTML tags in translation strings and add context.
...
Props ramiy.
Fixes #31862 .
Built from https://develop.svn.wordpress.org/trunk@34341
git-svn-id: http://core.svn.wordpress.org/trunk@34305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 02:42:25 +00:00
Scott Taylor
89a03563c9
In page_attributes_meta_box()
, add an action, 'page_attributes_meta_box_template'
to allow callbacks to be performed and HTML to be inserted after the title of the Template section.
...
Props sgrant.
Fixes #33625 .
Built from https://develop.svn.wordpress.org/trunk@34340
git-svn-id: http://core.svn.wordpress.org/trunk@34304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 02:40:24 +00:00
Scott Taylor
693692af68
Login: apply the same margin to the top and bottom of the Back to {Blog} link.
...
Props MikeHansenMe.
Fixes #29249 .
Built from https://develop.svn.wordpress.org/trunk@34338
git-svn-id: http://core.svn.wordpress.org/trunk@34302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-20 01:41:25 +00:00
Scott Taylor
864b54d46f
Export: Add late-escaping to the contents of several nodes to avoid creating invalid XML and XML parse errors.
...
Props westonruter.
Fixes #33732 .
Built from https://develop.svn.wordpress.org/trunk@34333
git-svn-id: http://core.svn.wordpress.org/trunk@34297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:53:25 +00:00
Scott Taylor
2c4323fc1c
Updates: in Theme list table, set white-space
to normal
for theme titles at appropriate breakpoint to avoid horizontal scrolling on small screens.
...
Fixes #33831 .
Built from https://develop.svn.wordpress.org/trunk@34332
git-svn-id: http://core.svn.wordpress.org/trunk@34296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:43:24 +00:00
Scott Taylor
47fead7a38
Post List Table: 'All' view should be selected when appropriate for paged responses.
...
Props kraftbj, wonderboymusic.
Fixes #33923 .
Built from https://develop.svn.wordpress.org/trunk@34331
git-svn-id: http://core.svn.wordpress.org/trunk@34295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 18:17:24 +00:00
Scott Taylor
fc8c624a61
Reinstate [34327]. minus the unit test deletion.
...
Built from https://develop.svn.wordpress.org/trunk@34329
git-svn-id: http://core.svn.wordpress.org/trunk@34293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 17:49:24 +00:00
Scott Taylor
863fd80150
Revert [34327] to fix the accidental deletion of some unit tests.
...
Built from https://develop.svn.wordpress.org/trunk@34328
git-svn-id: http://core.svn.wordpress.org/trunk@34292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 17:46:24 +00:00
Scott Taylor
003edb6ea7
Export: Add a filer, 'export_wp_filename'
to change the filename of the file to download when exporting.
...
Props MikeHansenMe, wonderboymusic.
Fixes #29500 .
Built from https://develop.svn.wordpress.org/trunk@34327
git-svn-id: http://core.svn.wordpress.org/trunk@34291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 17:44:24 +00:00
Scott Taylor
0fd01b9057
Export: allow Media to exported separately from other types.
...
Props PhilipLakin.
Fixes #32230 .
Built from https://develop.svn.wordpress.org/trunk@34326
git-svn-id: http://core.svn.wordpress.org/trunk@34290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:47:25 +00:00
Scott Taylor
28964445d4
Admin: when toggling select/deselect "all" via JS - :visible
needs to be bound to not toggle disabled inputs.
...
Props tywayne.
Fixes #32309 .
Built from https://develop.svn.wordpress.org/trunk@34325
git-svn-id: http://core.svn.wordpress.org/trunk@34289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:41:24 +00:00
Scott Taylor
e47963d1e7
Edit Post: When a post is "Pending Review", the "View Post" link should behave like ot does for drafts and generate a preview link.
...
Props wpdev101.
Fixes #33541 .
Built from https://develop.svn.wordpress.org/trunk@34324
git-svn-id: http://core.svn.wordpress.org/trunk@34288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:32:24 +00:00
Scott Taylor
60fadd7bdc
List Tables: Ensure that sorting indicators have layout when cell widths are being calculated.
...
See #27743 .
Built from https://develop.svn.wordpress.org/trunk@34323
git-svn-id: http://core.svn.wordpress.org/trunk@34287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:15:24 +00:00
Scott Taylor
6dc9ffc090
Update Core: In list_plugin_updates()
, when listing plugin updates related to $core_update_version
, don't skip the check for $info->tested
.
...
Props MikeHansenMe.
Fixes #27883 .
Built from https://develop.svn.wordpress.org/trunk@34322
git-svn-id: http://core.svn.wordpress.org/trunk@34286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 16:10:26 +00:00
Scott Taylor
d28e914a06
When applying the 'editable_slug'
filter, add a second param that provides more context.
...
Props MikeSchinkel, jesin.
Fixes #31568 .
Built from https://develop.svn.wordpress.org/trunk@34319
git-svn-id: http://core.svn.wordpress.org/trunk@34283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-19 05:49:24 +00:00
Dominik Schilling
33127a3f59
Don't use <code>
in translation strings in wp-admin/options.php
.
...
Props ramiy, wonderboymusic.
Fixes #31861 .
Built from https://develop.svn.wordpress.org/trunk@34315
git-svn-id: http://core.svn.wordpress.org/trunk@34279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:43:25 +00:00
Dominik Schilling
d1bdd59183
Don't use <code>
in translation strings in wp-admin/includes/plugin.php
.
...
Props ramiy.
Fixes #31856 .
Built from https://develop.svn.wordpress.org/trunk@34314
git-svn-id: http://core.svn.wordpress.org/trunk@34278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:29:26 +00:00
Dominik Schilling
622d4bd029
Use correct @since
tag for wp_ajax_generate_password()
.
...
See #33450 .
Built from https://develop.svn.wordpress.org/trunk@34313
git-svn-id: http://core.svn.wordpress.org/trunk@34277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:19:25 +00:00
Scott Taylor
c43f72fbfb
Profile: when clicking "Cancel" after clicking "Generate Password", request and generate a new password to present to the user.
...
Props adamsilverstein, wonderboymusic.
Fixes #33450 .
Built from https://develop.svn.wordpress.org/trunk@34312
git-svn-id: http://core.svn.wordpress.org/trunk@34276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 20:14:24 +00:00
Scott Taylor
04f7a0da2f
Add a 'get_sample_permalink' filter.
...
Props SergeyBiryukov, wenthemes, JustinSainton.
Fixes #22338 .
Built from https://develop.svn.wordpress.org/trunk@34309
git-svn-id: http://core.svn.wordpress.org/trunk@34273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:28:26 +00:00
Sergey Biryukov
a87885262f
Include placeholder in translator comment.
...
See #31863 .
Built from https://develop.svn.wordpress.org/trunk@34306
git-svn-id: http://core.svn.wordpress.org/trunk@34270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:03:25 +00:00
Sergey Biryukov
6a6d8ba4b8
Include placeholder in translator comment.
...
See #31864 .
Built from https://develop.svn.wordpress.org/trunk@34305
git-svn-id: http://core.svn.wordpress.org/trunk@34269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 19:01:24 +00:00
Sergey Biryukov
7adaef50bb
Include placeholders in translator comments.
...
See #31857 .
Built from https://develop.svn.wordpress.org/trunk@34304
git-svn-id: http://core.svn.wordpress.org/trunk@34268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:58:24 +00:00
Scott Taylor
ea0cf44097
Don't use HTML tags in translation strings in edit-tags.php
.
...
Props ramiy.
Fixes #31863 .
Built from https://develop.svn.wordpress.org/trunk@34303
git-svn-id: http://core.svn.wordpress.org/trunk@34267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:53:25 +00:00
Scott Taylor
40c45718af
Don't use HTML tags in translation strings in wp_ajax_add_user()
.
...
Props ramiy.
Fixes #31864 .
Built from https://develop.svn.wordpress.org/trunk@34302
git-svn-id: http://core.svn.wordpress.org/trunk@34266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:51:26 +00:00
Sergey Biryukov
8e353f294c
Add missing translator comment after [34295].
...
See #31853 .
Built from https://develop.svn.wordpress.org/trunk@34301
git-svn-id: http://core.svn.wordpress.org/trunk@34265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:50:24 +00:00
Sergey Biryukov
569dbcfeab
Add missing translator comments after [34294].
...
See #31852 .
Built from https://develop.svn.wordpress.org/trunk@34300
git-svn-id: http://core.svn.wordpress.org/trunk@34264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:46:24 +00:00
Sergey Biryukov
8f0e1e3c72
Add missing translator comment after [34292].
...
See #31840 .
Built from https://develop.svn.wordpress.org/trunk@34299
git-svn-id: http://core.svn.wordpress.org/trunk@34263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:40:24 +00:00
Sergey Biryukov
844586e889
Add missing translator comments after [34293].
...
See #31851 .
Built from https://develop.svn.wordpress.org/trunk@34298
git-svn-id: http://core.svn.wordpress.org/trunk@34262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:39:23 +00:00
Scott Taylor
ec01716bb2
Don't use HTML tags in translation strings for "In Reply To" links for comments in the admin.
...
Props ramiy.
Fixes #31857 .
Built from https://develop.svn.wordpress.org/trunk@34297
git-svn-id: http://core.svn.wordpress.org/trunk@34261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:36:24 +00:00
Scott Taylor
15f2e57a5a
Don't use HTML tags in translation strings in wp-admin/includes/update.php
.
...
Props ramiy.
Fixes #31855 .
Built from https://develop.svn.wordpress.org/trunk@34296
git-svn-id: http://core.svn.wordpress.org/trunk@34260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:31:25 +00:00
Scott Taylor
20a42701f4
Don't use <code>
in translation strings in edit-form-comment.php
.
...
Props ramiy.
Fixes #31853 .
Built from https://develop.svn.wordpress.org/trunk@34295
git-svn-id: http://core.svn.wordpress.org/trunk@34259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:28:26 +00:00
Scott Taylor
defb5bbf43
Don't use <code>
in translation strings in options-general.php
.
...
Props ramiy, SergeyBiryukov.
Fixes #31852 .
Built from https://develop.svn.wordpress.org/trunk@34294
git-svn-id: http://core.svn.wordpress.org/trunk@34258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:24:24 +00:00
Scott Taylor
318cd61abf
Don't use <code>
in translation strings in wp-admin/includes/schema.php
.
...
Props ramiy.
Fixes #31851 .
Built from https://develop.svn.wordpress.org/trunk@34293
git-svn-id: http://core.svn.wordpress.org/trunk@34257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:21:25 +00:00
Scott Taylor
dd6fe1ba32
Network Setup: don't use <code>
in translation strings in wp-admin/network
files.
...
Props ramiy.
Fixes #31840 .
Built from https://develop.svn.wordpress.org/trunk@34292
git-svn-id: http://core.svn.wordpress.org/trunk@34256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 18:18:27 +00:00
Aaron Jorbin
10d03c1ab3
Remove support for my-hacks.php
...
For the last 10 years, my-hacks has been deprecated and has been throwing a deprecation notice. For the last six years, you haven't been able to enable my-hacks.php in the admin UI. That should be enough time to give developers notice. Plugins and themes seem like they might have staying power.
Fixes #33741
Props bobbingwide
Built from https://develop.svn.wordpress.org/trunk@34291
git-svn-id: http://core.svn.wordpress.org/trunk@34255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 17:06:25 +00:00
Dominik Schilling
f3a62b7714
Theme Editor: Change file descriptions of header.php
and footer.php
.
...
`header.php` is now "Theme Header" and `footer.php` is "Theme Footer". This prevents a clash with other "Header" strings in the context of "Custom Header".
Props ramiy.
Fixes #32975 .
Built from https://develop.svn.wordpress.org/trunk@34290
git-svn-id: http://core.svn.wordpress.org/trunk@34254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 16:03:24 +00:00
Sergey Biryukov
b92955b427
Network Admin: Include IDs for users and sites on their respective views.
...
Props danielbachhuber, wonderboymusic.
Fixes #18661 .
Built from https://develop.svn.wordpress.org/trunk@34289
git-svn-id: http://core.svn.wordpress.org/trunk@34253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 15:58:25 +00:00
Dion Hulse
6113e498fc
Updates: FTP: Add a missing PCRE modifer in [34281].
...
See #16026 , #33432x
Built from https://develop.svn.wordpress.org/trunk@34282
git-svn-id: http://core.svn.wordpress.org/trunk@34246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:23:25 +00:00
Dion Hulse
5abc1eaab9
Updates: FTP/PemFTP Library: Remove the usage of deprecated regular expression functions (ereg replaced by PCRE).
...
Props enshrined, aaroncampbell
Fixes #16026 , #33432
Built from https://develop.svn.wordpress.org/trunk@34281
git-svn-id: http://core.svn.wordpress.org/trunk@34245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 08:20:27 +00:00
Scott Taylor
fe6a7e4baa
List Tables: ensure that sortable list table column headers have the same padding/line-height as non-sortable headers.
...
Props drozdz.
Fixes #27945 .
Built from https://develop.svn.wordpress.org/trunk@34276
git-svn-id: http://core.svn.wordpress.org/trunk@34240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 03:26:26 +00:00
Scott Taylor
9b7b7f6dde
Editor: add hide-if-no-js
class to <td id="wp-word-count">
. Word Count no worky with no JavaScript.
...
Props chriscct7.
Fixes #33379 .
Built from https://develop.svn.wordpress.org/trunk@34275
git-svn-id: http://core.svn.wordpress.org/trunk@34239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-18 02:32:26 +00:00
Scott Taylor
48d402a395
Posts List Table: Use a more robust technique for calculating $total_items
so that pagination still appears when items are removed on the last page of results and ->max_num_pages
decreases.
...
Props A5hleyRich.
Fixes #29870 .
Built from https://develop.svn.wordpress.org/trunk@34271
git-svn-id: http://core.svn.wordpress.org/trunk@34235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 21:18:24 +00:00
Weston Ruter
93bcd86b2a
Customize: Reduce peak memory usage by JSON-encoding settings and controls individually.
...
When there are hundreds of settings and controls (e.g. nav menu items and widget instances) the resulting object that is JSON-encoded can become very large, and `wp_json_encode()` can consume a lot of memory to serialize it. By breaking down the serialization into multiple calls the peak memory usage can be kept in line.
Moves logic out of `wp-admin/customize.php` into the `WP_Customize_Manager` class with new methods:
* `is_ios()`
* `get_document_title_template()`
* `get_preview_url()`/`set_preview_url()`
* `get_return_url()`/`set_return_url()`
* `get_autofocus()`/`set_autofocus()`
* `customize_pane_settings()`
Includes unit tests for these methods, for which the logic was formerly untestable in `customize.php`.
Fixes #33898 .
Built from https://develop.svn.wordpress.org/trunk@34269
git-svn-id: http://core.svn.wordpress.org/trunk@34233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 19:42:26 +00:00
Helen Hou-Sandí
48befcf361
Superglobals: Revert [34059] until further notice.
...
see #33837 .
Built from https://develop.svn.wordpress.org/trunk@34265
git-svn-id: http://core.svn.wordpress.org/trunk@34229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 12:33:26 +00:00
Sergey Biryukov
514eb11cf4
Revert unintended change from [34262].
...
See #33910 .
Built from https://develop.svn.wordpress.org/trunk@34263
git-svn-id: http://core.svn.wordpress.org/trunk@34227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:09:28 +00:00
Sergey Biryukov
d91fe61405
Docs: Expand the DocBlock for get_default_post_to_edit()
.
...
Props rabmalin.
Fixes #33910 .
Built from https://develop.svn.wordpress.org/trunk@34262
git-svn-id: http://core.svn.wordpress.org/trunk@34226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 09:06:34 +00:00
Scott Taylor
f3dd19c6e2
Media: In wp_ajax_send_attachment_to_editor()
, the fallback logic for $html
should be tucked into an else
statement so it isn't run needlessly and overwritten.
...
Props tychay.
Fixes #32072 .
Built from https://develop.svn.wordpress.org/trunk@34260
git-svn-id: http://core.svn.wordpress.org/trunk@34224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:55:25 +00:00
Scott Taylor
63efd92b11
Media: In get_image_send_to_editor()
, allow a custom value for $rel
.
...
Props tychay.
Fixes #32074 .
Built from https://develop.svn.wordpress.org/trunk@34259
git-svn-id: http://core.svn.wordpress.org/trunk@34223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 05:46:24 +00:00
Scott Taylor
58ac764859
Media List Table: remove the counts from the "views" portion of the toolbar, which are inconsistent with grid view. Also reduces complexity and removes potentially expensive count query.
...
Related to the toolbar view, remove the `wp_admin_canonical_url()` action in grid mode. Grid views that result from links from the list table view are lenses into the library and need to be indicated as such vs being a full attachment query.
Fixes #29744 .
Built from https://develop.svn.wordpress.org/trunk@34256
git-svn-id: http://core.svn.wordpress.org/trunk@34220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-17 02:30:26 +00:00
Boone Gorges
85c00bd943
Move new user notification emails to add_action()
callbacks.
...
When a new user is created in various places throughout the interface,
notifications are sent to the site admin and the new user. Previously, these
notifications were fired through direct calls to `wp_new_user_notification()`,
making it difficult to stop or modify the messages.
This changeset introduces a number of new action hooks in place of direct calls
to `wp_new_user_notification()`, and hooks the new wrapper function
`wp_send_new_user_notifications()` to these hooks.
Props dshanske, thomaswm, boonebgorges.
Fixes #33587 .
Built from https://develop.svn.wordpress.org/trunk@34251
git-svn-id: http://core.svn.wordpress.org/trunk@34215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 22:19:24 +00:00
Sergey Biryukov
a1050a58dc
Add a missing Oxford comma on Export screen.
...
Props juhise.
Fixes #33906 .
Built from https://develop.svn.wordpress.org/trunk@34249
git-svn-id: http://core.svn.wordpress.org/trunk@34213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 21:34:39 +00:00
Scott Taylor
1e3807c10d
wp-admin/includes/template.php
is now a loader for 3 files made via svn cp
:
...
* `Walker_Category_Checklist` class
* `WP_Internal_Pointers` class
* `template-functions.php`
This is BC for plugins that are loading `wp-admin/includes/template.php` for fun.
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34241
git-svn-id: http://core.svn.wordpress.org/trunk@34205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:35:23 +00:00
Sergey Biryukov
d06f5817f8
Docs: Expand the DocBlock for the WP_Theme::get_edit_link()
method, introduced in [34084].
...
Fixes #32376 .
Built from https://develop.svn.wordpress.org/trunk@34238
git-svn-id: http://core.svn.wordpress.org/trunk@34202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 15:01:27 +00:00
Drew Jaynes
13c25f5f49
Docs: Put "it's" in its place (again).
...
Props kitchin.
Fixes #33894 .
Built from https://develop.svn.wordpress.org/trunk@34234
git-svn-id: http://core.svn.wordpress.org/trunk@34198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 12:46:28 +00:00
Sergey Biryukov
4c019c6aee
Comments: Fix a fatal error in Comments meta box after [34223].
...
Props tyxla.
Fixes #33893 . See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34231
git-svn-id: http://core.svn.wordpress.org/trunk@34195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 11:37:25 +00:00
Drew Jaynes
3c73b53f66
Docs: Remove markdown from the DocBlock summary for WP_List_Table::get_primary_column()
, introduced in [34166].
...
The PHP inline documentation standards for [https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description summaries] call for not using an markup or markdown. Also, using the full Class::method() in this context allows for better clarity in what is being referenced.
See #33854 . See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34229
git-svn-id: http://core.svn.wordpress.org/trunk@34193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:51:25 +00:00
Drew Jaynes
c52a7d863e
Docs: Add a changelog entry for the switch to using wp_get_attachment_url()
instead of the guid for determining the header image URL in Custom_Image_Header::step_3()
.
...
The change was introduced in [34188].
See #33319 .
Built from https://develop.svn.wordpress.org/trunk@34228
git-svn-id: http://core.svn.wordpress.org/trunk@34192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 10:43:25 +00:00
Scott Taylor
5920e8eb13
Move WP_Post_Comments_List_Table
to its own file.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34223
git-svn-id: http://core.svn.wordpress.org/trunk@34187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-16 06:53:24 +00:00
Weston Ruter
628caeb487
Customizer: Smooth animation for closing accordions in the available nav menu items pane.
...
Props tyxla.
Fixes #33360 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34219
git-svn-id: http://core.svn.wordpress.org/trunk@34183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 23:40:24 +00:00
Boone Gorges
a7e229637e
Improve validation of user_login
and user_nicename
length.
...
The `user_login` field only allows 60 characters, and `user_nicename` allows
50. However, there are no protections in the interface, and few in the code,
that prevent the creation of users with values in excess of these limits. Prior
to recent changes in `$wpdb`, users were generally created anyway, MySQL
having performed the necessary truncation. More recently, the `INSERT`s and
`UPDATE`s simply fail, with no real feedback on the nature of the failure.
This changeset addresses the issue in a number of ways:
* On the user-new.php and network/user-new.php panels, don't allow input in excess of the maximum field length.
* In `wp_insert_user()`, throw an error if the value provided for `'user_login'` or `'user_nicename'` exceeds the maximum field length.
* In `wp_insert_user()`, when using `'user_login'` to generate a default value for `'user_nicename'`, ensure that the nicename is properly truncated, even when suffixed for uniqueness (username-2, etc).
Props dipesh.kakadiya, utkarshpatel, tommarshall, boonebgorges.
Fixes #33793 .
Built from https://develop.svn.wordpress.org/trunk@34218
git-svn-id: http://core.svn.wordpress.org/trunk@34182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 22:14:26 +00:00
John Blackbourn
a9e5cfddc7
Implement wp_login_url()
and wp_registration_url()
in places where wp-login.php
is currently hard-coded.
...
See #31495
Props GregLone
Built from https://develop.svn.wordpress.org/trunk@34213
git-svn-id: http://core.svn.wordpress.org/trunk@34177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 17:11:35 +00:00
Scott Taylor
ff3ae0e747
Don't redirect to the Term list table after submitting the form on the Edit Term page.
...
Props chiragswadia, UmeshSingla, rhyswynne, afercia.
Fixes #17455 .
Built from https://develop.svn.wordpress.org/trunk@34202
git-svn-id: http://core.svn.wordpress.org/trunk@34166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 15:59:42 +00:00
Scott Taylor
57d2420ae5
Similar to #33386 , don't use guid
when retrieving URL for a cropped header image in the Customizer.
...
Props polevaultweb.
Fixes #33319 .
Built from https://develop.svn.wordpress.org/trunk@34188
git-svn-id: http://core.svn.wordpress.org/trunk@34156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 14:46:32 +00:00
Sergey Biryukov
80165bfc4a
Comments: When setting the colspan
value for inline edit/reply, make sure it's actually a table and the value is not empty.
...
Props afercia.
Fixes #33596 .
Built from https://develop.svn.wordpress.org/trunk@34179
git-svn-id: http://core.svn.wordpress.org/trunk@34147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 13:44:34 +00:00
John Blackbourn
a5a8ae45a6
Remove outdated references to the preview_post_link
filter docs.
...
See #24345
Props paulwilde
Built from https://develop.svn.wordpress.org/trunk@34178
git-svn-id: http://core.svn.wordpress.org/trunk@34146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 10:32:31 +00:00
John Blackbourn
541dbb2711
Remove the ability to view the post listing screen and post editing screen for post types with show_ui
set to false
. It is unexpected and unintended behaviour that this is allowed.
...
If your plugin or site does rely on this behaviour, the arguments that are passed to `register_post_type()` should be altered so that `show_ui` is `true`, and arguments such as `show_in_menu`, `show_in_nav_menus`, and `show_in_admin_bar` are `false`.
Fixes #33763
Props swissspidy, johnbillion
Built from https://develop.svn.wordpress.org/trunk@34177
git-svn-id: http://core.svn.wordpress.org/trunk@34145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 10:27:29 +00:00
Scott Taylor
ab6d1fa247
Use get_attached_file()
in attachment_submitbox_metadata()
.
...
Props kitchin.
Fixes #33386 .
Built from https://develop.svn.wordpress.org/trunk@34171
git-svn-id: http://core.svn.wordpress.org/trunk@34139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:18:25 +00:00
Scott Taylor
54829b6305
Create a function, get_preview_post_link()
, to DRY the logic for applying the 'preview_post_link'
filter to a URL.
...
Props TomHarrigan, wonderboymusic.
Fixes #24345 .
Built from https://develop.svn.wordpress.org/trunk@34170
git-svn-id: http://core.svn.wordpress.org/trunk@34138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:15:25 +00:00
Scott Taylor
ee42803e21
Move WP_Screen
to its own file.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34169
git-svn-id: http://core.svn.wordpress.org/trunk@34137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:08:24 +00:00
Scott Taylor
fde014e85e
Move the admin Nav Menu Walker subclasses into their own files. Load in nav-menu.php
to remain BC.
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@34168
git-svn-id: http://core.svn.wordpress.org/trunk@34136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 04:02:25 +00:00
Scott Taylor
780487556b
Add a doc block to WP_List_Table::get_primary_column()
.
...
Fixes #33854 .
Built from https://develop.svn.wordpress.org/trunk@34166
git-svn-id: http://core.svn.wordpress.org/trunk@34134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 03:35:25 +00:00
Scott Taylor
ab777c54cc
Ensure that widget carets close when dragging an expanded widget.
...
Props sdavis2702, mindctrl.
Fixes #33578 .
Built from https://develop.svn.wordpress.org/trunk@34165
git-svn-id: http://core.svn.wordpress.org/trunk@34133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 03:10:24 +00:00
Scott Taylor
191400f9e6
Don't ever use the guid
value when retrieving URLs for media, use wp_get_attachment_url()
. Use get_attached_file()
for path to file.
...
Fixes #33386 .
Built from https://develop.svn.wordpress.org/trunk@34163
git-svn-id: http://core.svn.wordpress.org/trunk@34131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 02:50:25 +00:00
Scott Taylor
69e3a390b2
In _wp_ajax_delete_comment_response()
, read the new 'all'
prop returned by get_comment_count()
via wp_count_comments()
when setting $total
. 'all'
doesn't include spam
in its count.
...
Updates unit tests.
Props dipesh.kakadiya.
Fixes #32362 .
Built from https://develop.svn.wordpress.org/trunk@34161
git-svn-id: http://core.svn.wordpress.org/trunk@34129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 01:47:25 +00:00
Scott Taylor
387f271ea5
After [34070], account for the new ID in Quick Edit JS.
...
Props afercia.
Fixes #33770 .
Built from https://develop.svn.wordpress.org/trunk@34159
git-svn-id: http://core.svn.wordpress.org/trunk@34127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 01:31:26 +00:00
Nikolay Bachiyski
097c4fd2f4
List tables: escape user e-mails
...
Better safe than sorry.
Built from https://develop.svn.wordpress.org/trunk@34133
git-svn-id: http://core.svn.wordpress.org/trunk@34101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:33:25 +00:00
Scott Taylor
1a01a9ab55
In the edit-comments.php
admin handler, toggle wp_defer_comment_counting()
so that only unique post IDs have their comment count updated. Currently, if you delete 50 comments from the same post, the count would get reset 50 times. Not joking.
...
See #33875 .
Built from https://develop.svn.wordpress.org/trunk@34132
git-svn-id: http://core.svn.wordpress.org/trunk@34100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 22:24:26 +00:00
Scott Taylor
7639a89a1f
wp_unspam_comment()
can accept a full object instead of comment_ID to reduce cache/db lookups..
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34130
git-svn-id: http://core.svn.wordpress.org/trunk@34098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 21:47:25 +00:00
Scott Taylor
b1bc8a6522
More comment functions can accept a full object instead of comment_ID to reduce cache/db lookups.
...
See ##33638.
Built from https://develop.svn.wordpress.org/trunk@34129
git-svn-id: http://core.svn.wordpress.org/trunk@34097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 21:40:24 +00:00
Scott Taylor
b2a30103ae
In WP_List_Table
, make a new public
method, ->get_primary_column()
, and revert [34101] due to BC issues.
...
Fixes #33854 .
Built from https://develop.svn.wordpress.org/trunk@34128
git-svn-id: http://core.svn.wordpress.org/trunk@34096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 20:29:26 +00:00
Scott Taylor
4d33644373
In WP_Media_List_Table
, fetch all pending comment counts at once, instead of for each row in the loop.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@34127
git-svn-id: http://core.svn.wordpress.org/trunk@34095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 19:25:25 +00:00
Dominik Schilling
4af3a3374e
Passwords: Deprecate second parameter of wp_new_user_notification()
.
...
The second parameter `$plaintext_pass` was removed in [33023] and restored as `$notify` in [33620] with a different behavior. If you have a plugin overriding `wp_new_user_notification()` which hasn't been updated you would get a notification with your username and the password "both".
To prevent this the second parameter is now deprecated and reintroduced as the third parameter.
Adds unit tests.
Props kraftbj, adamsilverstein, welcher, ocean90.
Fixes #33654 .
(Don't ask for new pluggables kthxbye)
Built from https://develop.svn.wordpress.org/trunk@34116
git-svn-id: http://core.svn.wordpress.org/trunk@34084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 12:43:26 +00:00
Dominik Schilling
d36ffeb160
Passwords: Trigger a wp-check-valid-field
event when the password field is filled with a password by generatePassword()
.
...
Updates event handler in `wpAjax.invalidateForm()` to support `wp-check-valid-field`.
See #33406 .
Built from https://develop.svn.wordpress.org/trunk@34114
git-svn-id: http://core.svn.wordpress.org/trunk@34082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 10:39:27 +00:00
Scott Taylor
ecc4106ed1
Add an argument to parent_dropdown()
, $post
, to allow it to be called for an arbitrary post.
...
Fixes #23162 .
Built from https://develop.svn.wordpress.org/trunk@34111
git-svn-id: http://core.svn.wordpress.org/trunk@34079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 03:20:25 +00:00
Scott Taylor
373d73f781
Turn off autocomplete
for the new-post-slug
field.
...
Props johnbillion.
Fixes #32752 .
Built from https://develop.svn.wordpress.org/trunk@34105
git-svn-id: http://core.svn.wordpress.org/trunk@34073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 02:03:25 +00:00
Scott Taylor
ae6a3aee7f
Make WP_List_Table::get_primary_column_name()
public in list table classes that have it.
...
Fixes #33854 .
Built from https://develop.svn.wordpress.org/trunk@34101
git-svn-id: http://core.svn.wordpress.org/trunk@34069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 01:12:25 +00:00
Andrea Fercia
2a6793c7b2
Bump H3 headings to H2 on the Writing Settings screen for better accessibility.
...
Props mrahmadawais.
Fixes #33651 .
Built from https://develop.svn.wordpress.org/trunk@34096
git-svn-id: http://core.svn.wordpress.org/trunk@34064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 16:48:26 +00:00
Helen Hou-Sandí
7f772bdaff
Comments: Fix inline edit/reply on small screens.
...
props ocean90, SergeyBiryukov.
fixes #33596 .
Built from https://develop.svn.wordpress.org/trunk@34094
git-svn-id: http://core.svn.wordpress.org/trunk@34062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:47:27 +00:00
Weston Ruter
bd801ae5db
Customize: Remove redundant aria-label
attributes.
...
Adds an `$options` array argument to `WP_Screen::render_screen_options()` to allow the `div#screen-options-wrap` element to be omitted when `wrap` value is `false`.
Props afercia, westonruter.
Fixes #33182 .
Built from https://develop.svn.wordpress.org/trunk@34093
git-svn-id: http://core.svn.wordpress.org/trunk@34061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 06:16:26 +00:00
Dominik Schilling
720cea8cf9
Themes: Don't use HTML entities for placeholders.
...
See #32875 .
Built from https://develop.svn.wordpress.org/trunk@34086
git-svn-id: http://core.svn.wordpress.org/trunk@34054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 19:48:24 +00:00
Scott Taylor
8591f94b0a
WP_Posts_List_Table
: there are a cadre of edit.php
URLs that are generated by string-building instead of using our handy functions. Create a helper method, ->get_edit_link()
that standardizes the generation and escaping of these URLs.
...
Props BdN3504 for the initial patch on the ticket.
Fixes #32376 .
Built from https://develop.svn.wordpress.org/trunk@34084
git-svn-id: http://core.svn.wordpress.org/trunk@34052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 17:13:25 +00:00
Scott Taylor
a2aca8d063
Use table-layout: auto
(instead of fixed
) on table.fixed
to ensure that things like date/time don't horrendously wrap on small screens. Before/After screenshots attached to the ticket.
...
Props gaelan.
Fixes #32691 .
Built from https://develop.svn.wordpress.org/trunk@34083
git-svn-id: http://core.svn.wordpress.org/trunk@34051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 16:04:25 +00:00
Scott Taylor
281faeb69d
After [34076], fix the logic for post_status
in months dropdown.
...
See #21015 .
Built from https://develop.svn.wordpress.org/trunk@34077
git-svn-id: http://core.svn.wordpress.org/trunk@34045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 08:19:24 +00:00
Scott Taylor
eb230b5424
List Tables: don't render "extra tablenav" if there are no posts. This includes Bulk Actions, Dates Dropdown, Category Dropdowns, Pagination.
...
Also ensure that the Months dropdown, when it is shown, shows months from the proper set of posts.
Props egower, CoenJacobs, MikeHansenMe, mehulkaklotar.
Fixes #33824 , #21015 , #21856 .
Built from https://develop.svn.wordpress.org/trunk@34076
git-svn-id: http://core.svn.wordpress.org/trunk@34044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 08:13:24 +00:00
Scott Taylor
ed83979728
AJAX Reply to Comment: check the edit_comment
cap when parent comment will be auto-approved.
...
Props rachelbaker.
Fixes #23939 .
Built from https://develop.svn.wordpress.org/trunk@34074
git-svn-id: http://core.svn.wordpress.org/trunk@34042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 07:19:25 +00:00
Scott Taylor
4dbaf63b67
Edit Comment screen: remove the "View Comment" button (actually a link) from the publish meta box. Mimic the "Edit URL/Permalink" UI from the Edit Post screen to show the comment link below the screen title, but make it an actual link, not a button.
...
Props ocean90, DrewAPicture, wonderboymusic.
Fixes #19168 .
Built from https://develop.svn.wordpress.org/trunk@34072
git-svn-id: http://core.svn.wordpress.org/trunk@34040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 03:20:24 +00:00
Scott Taylor
821939d6d1
Quick Edit: fix an ID attribute name collision by renaming one of the author fields author-name
.
...
Props afercia.
Fixes #33770 .
Built from https://develop.svn.wordpress.org/trunk@34070
git-svn-id: http://core.svn.wordpress.org/trunk@34038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 02:35:25 +00:00
Scott Taylor
b453af5718
When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on commentsBox
, ->load()
, that resets st
(cool name) to the number of visible <tr>
s before calling ->get()
. This will account for spam'd and trash'd comments when returning comments at the proper offset.
...
Props utkarshpatel.
Fixes #33829 .
Built from https://develop.svn.wordpress.org/trunk@34069
git-svn-id: http://core.svn.wordpress.org/trunk@34037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 02:28:26 +00:00
Andrew Ozz
a69e71fafe
Settings, password field: fix placement of the error icon and removal of the error class.
...
Props liljimmi, adamsilverstein.
Fixes #33406 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34068
git-svn-id: http://core.svn.wordpress.org/trunk@34036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 00:10:25 +00:00
Andrea Fercia
a751eccdf2
Bump H3 headings to H2 on the Plugin Editor screen for better accessibility.
...
Fixes #33839 .
Built from https://develop.svn.wordpress.org/trunk@34067
git-svn-id: http://core.svn.wordpress.org/trunk@34035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 00:08:24 +00:00
Andrea Fercia
f446d01b4c
Bump H3 headings to H2 on the Theme Editor screen for better accessibility.
...
Props mrahmadawais.
Fixes #33660 .
Built from https://develop.svn.wordpress.org/trunk@34066
git-svn-id: http://core.svn.wordpress.org/trunk@34034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-12 00:00:24 +00:00
Andrea Fercia
085d051305
Nav Menus: fix the quick search spinner position on Operating Systems that show scrollbars.
...
Fixes #33290 .
Built from https://develop.svn.wordpress.org/trunk@34065
git-svn-id: http://core.svn.wordpress.org/trunk@34033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:52:25 +00:00
Andrea Fercia
5f5ea8c3e2
Quick Edit: fix the Tags auto-suggest tooltip visibility.
...
Be sure to hide the `jquery.suggest` Tags textarea tooltip also when using the keyboard to Save/Cancel.
Props rommelxcastro for the initial patch.
Fixes #32580 .
Built from https://develop.svn.wordpress.org/trunk@34064
git-svn-id: http://core.svn.wordpress.org/trunk@34032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:34:25 +00:00
Andrew Ozz
e1ccdf760e
Settings: properly set the password field label on loading.
...
See #33778 .
Built from https://develop.svn.wordpress.org/trunk@34062
git-svn-id: http://core.svn.wordpress.org/trunk@34030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 23:05:24 +00:00
Andrew Ozz
0406f50cfb
Settings: reassign the label when switching password fields so it always highlights the visible field.
...
Props umesh.nevase.
Fixes #33778 for trunk.
Built from https://develop.svn.wordpress.org/trunk@34061
git-svn-id: http://core.svn.wordpress.org/trunk@34029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 22:52:26 +00:00
Dominik Schilling
efcdeea2f1
Passwords: Refresh password fields when content is pasted into fields.
...
Use feature detection to determine whether password inputs should use the `keyup` or `input` event.
Props peterwilsoncc, adamsilverstein.
Fixes #33398 .
Built from https://develop.svn.wordpress.org/trunk@34060
git-svn-id: http://core.svn.wordpress.org/trunk@34028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 21:52:27 +00:00
Scott Taylor
cd7c0f0b0d
Introduce wp_validate_action( $action = '' )
, a helper function that checks $_REQUEST
for action
and returns it, or empty string if not present. If $action
is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types.
...
Implementing this removes 27 uses of direct superglobal access in the admin.
For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php
See #33837 .
Built from https://develop.svn.wordpress.org/trunk@34059
git-svn-id: http://core.svn.wordpress.org/trunk@34027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 21:08:26 +00:00
Dominik Schilling
d6f26e4c7c
Site Icon: For preview fall back to full
size URL when thumbnail
size doesn't exist.
...
Prevents a JavaScript error for rare cases when cropping is skipped and the image is smaller than `thumbnail`.
Props tyxla.
Fixes #33417 .
Built from https://develop.svn.wordpress.org/trunk@34056
git-svn-id: http://core.svn.wordpress.org/trunk@34024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 20:13:25 +00:00
Dominik Schilling
09b159e494
About: Remove period from placeholder.
...
The position of periods is different in some languages, like Japanese. This removes the period from the last placeholder for the Template Hierarchy section. It doesn't include a new period to avoid a string change in a minor release.
Props extendwings, chriscct7.
Fixes #33429 .
Built from https://develop.svn.wordpress.org/trunk@34054
git-svn-id: http://core.svn.wordpress.org/trunk@34022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 19:27:24 +00:00
Sergey Biryukov
f130fd6c32
Better align table headers with table cells on success screen after installing.
...
Props umesh.nevase.
Fixes #33796 .
Built from https://develop.svn.wordpress.org/trunk@34043
git-svn-id: http://core.svn.wordpress.org/trunk@34011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 11:26:26 +00:00
Scott Taylor
db4f22bfb5
After [33961], pass $comment
to get_comment_link()
where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34042
git-svn-id: http://core.svn.wordpress.org/trunk@34010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:21:25 +00:00
Scott Taylor
c3f642bea9
After [33961], pass $comment
to get_comment_date()
where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34041
git-svn-id: http://core.svn.wordpress.org/trunk@34009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:15:24 +00:00
Scott Taylor
58c3c30e8d
After [33961], pass $comment
to comment_class()
where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34040
git-svn-id: http://core.svn.wordpress.org/trunk@34008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:12:24 +00:00
Scott Taylor
fc328f5484
After [33961], pass $comment
to get_comment_author_link()
where possible to avoid extra cache/db lookups.
...
See #33638 .
Built from https://develop.svn.wordpress.org/trunk@34039
git-svn-id: http://core.svn.wordpress.org/trunk@34007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 06:05:24 +00:00
Scott Taylor
4465a83b95
After [34015], handle orphaned comments in the Dashboard comments widget. Pass full $comment
versus just passing the comment ID when possible.
...
See #33710 .
Built from https://develop.svn.wordpress.org/trunk@34038
git-svn-id: http://core.svn.wordpress.org/trunk@34006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 05:56:24 +00:00
Scott Taylor
b9bbdabfe7
Create a new file, wp-admin/includes/noop.php
, which loads all of the noop functions for load-script|styles.php
and is only loaded by those files. DRYs in the process.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34037
git-svn-id: http://core.svn.wordpress.org/trunk@34005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 05:04:23 +00:00
Scott Taylor
db9c5c81f5
Move ad hoc functions from wp-admin/credits.php
to wp-admin/includes/credits.php
, which is only included by the former.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34036
git-svn-id: http://core.svn.wordpress.org/trunk@34004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 04:55:26 +00:00
Boone Gorges
39fb7992a9
Require numeric IDs in user deletion functions.
...
`wp_delete_user()` and `wpmu_delete_user()` both require an `$id` parameter.
Previously, the functions did not verify that the value passed was, in fact,
a number. As such, passing an object or any other entity that would be cast
to int `1` would result in user 1 being deleted. We fix this by enforcing
the requirement that `$id` be numeric.
Props dipesh.kakadiya, utkarshpatel, juliobox.
Fixes #33800 .
Built from https://develop.svn.wordpress.org/trunk@34034
git-svn-id: http://core.svn.wordpress.org/trunk@34002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 02:25:23 +00:00
Gary Pendergast
0d85038ce6
Schema: Increase the length of wp_options.option_name
.
...
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.
Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.
Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.
Fixes #13310 .
Built from https://develop.svn.wordpress.org/trunk@34030
git-svn-id: http://core.svn.wordpress.org/trunk@33999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 01:26:24 +00:00
John Blackbourn
9bf86a74d0
Set the secure
flag on the wp-saving-post
cookie when using HTTPS.
...
This cookie doesn't contain any sensitive information, but this change brings its behaviour in line with all other core cookies.
Fixes #31056
Built from https://develop.svn.wordpress.org/trunk@34027
git-svn-id: http://core.svn.wordpress.org/trunk@33996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 22:42:23 +00:00