Drew Jaynes
e2c7542b68
Add a changelog entry to the DocBlock for language_attributes()
noting that it was converted into a wrapper for get_language_attributes()
in 4.3.
...
See [32868]. See #28180 .
Built from https://develop.svn.wordpress.org/trunk@32882
git-svn-id: http://core.svn.wordpress.org/trunk@32853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 23:01:26 +00:00
Scott Taylor
38037c8d62
Add get_language_attributes()
, which is then used by (...drum roll...) language_attributes()
.
...
Props johnbillion, posykrat, PeterRKnight.
Fixes #28180 .
Built from https://develop.svn.wordpress.org/trunk@32868
git-svn-id: http://core.svn.wordpress.org/trunk@32839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:36:28 +00:00
Scott Taylor
f888767c73
$status
shouldn't be loosely compared to true
in wp_xmlrpc_server::wp_deleteComment()
.
...
`$initial` shouldn't be loosely compared to `true` in `get_calendar()`.
`current_user_can()` shouldn't be loosely compared to `false` in `kses_init()`
`$get_all` shouldn't be loosely compared to `true` in `get_blog_details()`.
`is_array()` and `in_array()` shouldn't be loosely compared in `wpmu_validate_user_signup()`.
`$result` should by strictly compared in `check_ajax_referer()`.
`wp_verify_nonce()` should by strictly compared in `_show_post_preview()`.
`is_user_logged_in()` should not be loosly compared against `false` in `wp-signup.php`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32733
git-svn-id: http://core.svn.wordpress.org/trunk@32704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:48:26 +00:00
Scott Taylor
82f5d2e9b5
Cleanup doc blocks in general-template.php
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32598
git-svn-id: http://core.svn.wordpress.org/trunk@32568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:18:26 +00:00
Scott Taylor
af7a017f46
When calling unset()
, it is unnecessary to immediately precede it with a call to isset()
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32545
git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:47:25 +00:00
Boone Gorges
29216371bd
In paginate_links()
, improve handling of custom pagination query vars.
...
Custom pagination query vars, as provided in the 'base' parameter, must be
detected in the current page URL and removed before generating fresh pagination
links. The logic introduced in this changeset ensures that these custom
query vars are properly detected in cases where the 'format' param contains
a `#`.
This is a follow-up to [31203] #30831 .
Fixes #31939 .
Built from https://develop.svn.wordpress.org/trunk@32359
git-svn-id: http://core.svn.wordpress.org/trunk@32330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 21:59:26 +00:00
Helen Hou-Sandí
bfda508c18
Update more instances of default admin blues and grays.
...
props hugobaeta.
fixes #31234 .
Built from https://develop.svn.wordpress.org/trunk@32051
git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Dominik Schilling
502c70ec99
Remove <code>
tags from translatable strings.
...
Uncomment deprecation notice for `get_bloginfo( 'text_direction' )`, see [14360].
props ramiy, DrewAPicture.
fixes #30614 .
Built from https://develop.svn.wordpress.org/trunk@31899
git-svn-id: http://core.svn.wordpress.org/trunk@31878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 15:17:28 +00:00
Drew Jaynes
88c109e919
Document default arguments for paginate_links()
as a hash notation.
...
Props atimmer.
Fixes #31433 .
Built from https://develop.svn.wordpress.org/trunk@31854
git-svn-id: http://core.svn.wordpress.org/trunk@31833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 20:04:27 +00:00
Boone Gorges
48a5bbf8a7
Provide a secondary sort order for wp_get_archives()
when type=postbypost
.
...
Sorting by post_date alone can cause indeterminacy problems on different
versions of MySQL when post_date ties need to be broken. Using `ID` as a
secondary sort ensures that the order is always determinate.
Props herbmillerjr for an initial patch.
Fixes #30480 .
Built from https://develop.svn.wordpress.org/trunk@31452
git-svn-id: http://core.svn.wordpress.org/trunk@31433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 17:00:27 +00:00
Dion Hulse
3745cdc740
Avoid a PHP Warning when add_args
is passed as false
to paginate_links()
.
...
Props boonebgorges for the unit test.
See #30831 [31203].
Built from https://develop.svn.wordpress.org/trunk@31432
git-svn-id: http://core.svn.wordpress.org/trunk@31413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-12 01:39:27 +00:00
Sergey Biryukov
34d06ee6b7
Add a changelog entry for the new parameter added in [31228].
...
props DrewAPicture.
fixes #31015 .
Built from https://develop.svn.wordpress.org/trunk@31229
git-svn-id: http://core.svn.wordpress.org/trunk@31210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 17:31:23 +00:00
Sergey Biryukov
4e90a18c7c
Pass $force_reauth value to the 'login_url' filter.
...
props jfarthing84, MikeHansenMe.
fixes #31015 .
Built from https://develop.svn.wordpress.org/trunk@31228
git-svn-id: http://core.svn.wordpress.org/trunk@31209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-17 17:20:23 +00:00
Boone Gorges
fb691a449b
In paginate_links()
, don't override custom format arguments when setting up default 'add_args'.
...
Since 4.1 [29780], the default value of the 'add_args' argument in
`paginate_links()` has been determined by parsing the current URL. This change
had the side effect of overriding custom values of 'format' that changed the
pagination query var, with the result that plugins using `paginate_links()`
with a custom format generated the incorrect links unless explicitly
declaring 'add_args=false' to prevent the default values from overriding. We
fix this behavior by parsing URL query vars into the 'add_args' array only
after the explicit function params have been parsed, and by skipping the
current page's pagination query var when doing this parsing (to avoid the
override).
Props obenland.
Fixes #30831 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31203
git-svn-id: http://core.svn.wordpress.org/trunk@31184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 15:49:25 +00:00
Scott Taylor
fe6b5983df
In PHP 5.0.0, is_a()
became deprecated in favour of the instanceof
operator. Calling is_a()
would result in an E_STRICT
warning.
...
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.
To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.
`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.
Props markoheijnen, wonderboymusic.
Fixes #25672 .
Built from https://develop.svn.wordpress.org/trunk@31188
git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 01:06:24 +00:00
Drew Jaynes
f2bc30c03f
Ensure we're using the correct @ignore
phpDocumentor tag to mark elements that should be skipped when parsing.
...
Up to this point, various core elements' DocBlocks incorrectly included an `@internal` tag as a means for skipping the parsing process. When paired with a description (inline or otherwise), `@internal` is a valid tag meant to provide internal-only context, but not necessarily to skip parsing the entire element.
See #30987 .
Built from https://develop.svn.wordpress.org/trunk@31170
git-svn-id: http://core.svn.wordpress.org/trunk@31151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 00:51:21 +00:00
Scott Taylor
fc843ce4d0
There are some random add_action()
and add_filter()
calls littered around some files in wp-includes/
. These should be moved to wp-includes/default-filters.php
with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT
- a lot of the hooks registered won't run anyways (that's already the case).
...
See #30947 .
Built from https://develop.svn.wordpress.org/trunk@31168
git-svn-id: http://core.svn.wordpress.org/trunk@31149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-12 16:40:23 +00:00
Scott Taylor
786caa4d55
Correct the @param
docs for arguments that are truthy/falsey.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30983
git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:04:23 +00:00
Scott Taylor
5eb5afac34
For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30982
git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:47:22 +00:00
Andrew Nacin
498be1cae9
Avoid repeatedly calling is_tax( 'post_format', '...' ) in get_the_archive_title().
...
see #21995 .
Built from https://develop.svn.wordpress.org/trunk@30854
git-svn-id: http://core.svn.wordpress.org/trunk@30844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 07:32:26 +00:00
Scott Taylor
37a23b2c73
Improve various @param
docs.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30682
git-svn-id: http://core.svn.wordpress.org/trunk@30672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 02:17:21 +00:00
Scott Taylor
a0df295f5c
Improve various @param
docs.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30674
git-svn-id: http://core.svn.wordpress.org/trunk@30664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 23:24:25 +00:00
Drew Jaynes
bffe95d34c
Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*.
...
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30656
git-svn-id: http://core.svn.wordpress.org/trunk@30646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 12:10:23 +00:00
Drew Jaynes
a4be4f520f
Ensure the private function _wp_render_title_tag()
is marked for internal usage only.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30615
git-svn-id: http://core.svn.wordpress.org/trunk@30605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 11:50:22 +00:00
Drew Jaynes
07c58f5cca
Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
...
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `_deprecated_argument()`
* Markdown-indent a code snippet in the description for `wp_localize_script()`
* Backtick-escape HTML tags in two parameter descriptions for `wp_register()`
* Various DocBlock formatting in the description for `get_bloginfo()`
* Remove HTML tag from the summary for `_wp_render_title_tag()`
* Backtick-escape a HTML tag in the description for `get_archives_link()`
* Markdown-indent a code snippet in the description for `wp_admin_css_color()`
* Markdown-indent a code snippet in the description for the `welcome_panel` hook
Props rarst.
See #30473 .
Built from https://develop.svn.wordpress.org/trunk@30541
git-svn-id: http://core.svn.wordpress.org/trunk@30530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:39:22 +00:00
Drew Jaynes
784e162177
Cross reference get_the_archive_title()
and get_the_archive_description()
in the inline documentation for their corresponding template tags.
...
Also define the default values for `$before` and `$after` in the template tag documentation.
See [30223]. See #21995 .
Built from https://develop.svn.wordpress.org/trunk@30224
git-svn-id: http://core.svn.wordpress.org/trunk@30224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 06:52:23 +00:00
John Blackbourn
6a45f46937
Introduce some new template functions for archive titles and descriptions:
...
* `get_the_archive_title()` and `the_archive_title()` for returning/displaying the title of the current term, date, post type, post format, or author archive.
* `get_the_archive_description()` and `the_archive_description()` for returning/displaying the description associated with the current term archive.
Fixes #21995
Props obenland, DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30223
git-svn-id: http://core.svn.wordpress.org/trunk@30223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 00:35:22 +00:00
Scott Taylor
8d0e8942eb
[28785] introduced a bug, where encoded query arguments were decoded by parse_str()
inside of wp_parse_str()
but never re-encoded later on.
...
This encodes them, adds unit test.
Props obenland.
Fixes #29636 .
Built from https://develop.svn.wordpress.org/trunk@30133
git-svn-id: http://core.svn.wordpress.org/trunk@30133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-01 00:54:23 +00:00
Drew Jaynes
f8657d5890
Remove redundant and erroneous @uses
tag from most core inline documentation.
...
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.
Fixes #30191 .
Built from https://develop.svn.wordpress.org/trunk@30105
git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
John Blackbourn
0f64edb657
Introduce a new means of outputting a <title>
tag in the theme head. Requires a theme to add support by calling add_theme_support( 'title-tag' )
. This is the first step in adding a more robust means of generating and outputting the title tag.
...
See #18548 .
Props obenland, chrisbliss18, joostdevalk.
Built from https://develop.svn.wordpress.org/trunk@30074
git-svn-id: http://core.svn.wordpress.org/trunk@30074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:12:22 +00:00
Mark Jaquith
e1f2b3b9e2
Use HTTPS URLs for trac.wordpress.org (and use core.trac.wordpress.org)
...
see #27115
Built from https://develop.svn.wordpress.org/trunk@29789
git-svn-id: http://core.svn.wordpress.org/trunk@29561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:37:16 +00:00
Mark Jaquith
0d3b83551f
Use HTTPS URLs for core.trac.wordpress.org
...
see #27115
Built from https://develop.svn.wordpress.org/trunk@29788
git-svn-id: http://core.svn.wordpress.org/trunk@29560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 13:28:16 +00:00
Scott Taylor
1967dfe898
In paginate_links()
, ensure that query string args are propagated to the resulting paginated links.
...
Adds unit tests that use `DOMDocument` since `assertTag` is being deprecated - see #29545 , [29746].
Props obenland, wonderboymusic.
Fixes #29636 .
Built from https://develop.svn.wordpress.org/trunk@29780
git-svn-id: http://core.svn.wordpress.org/trunk@29552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 04:03:16 +00:00
Scott Taylor
69dbf4f5df
Clarify that get_the_date()
, get_the_time()
, get_post_time()
and get_post_modified_time()
should return false
when get_post()
is null
.
...
Adds unit tests.
Props GaryJ, SergeyBiryukov, tollmanz.
Fixes #28310 .
Built from https://develop.svn.wordpress.org/trunk@29344
git-svn-id: http://core.svn.wordpress.org/trunk@29122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-01 18:40:16 +00:00
Sergey Biryukov
6628d7dd33
Remove redundant title attributes from get_calendar().
...
props joedolson.
fixes #26561 .
Built from https://develop.svn.wordpress.org/trunk@29244
git-svn-id: http://core.svn.wordpress.org/trunk@29028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 04:41:15 +00:00
Scott Taylor
9e2eb6aa62
Use includes_url()
in wlwmanifest_link()
.
...
Props nacin.
See #14157 .
Built from https://develop.svn.wordpress.org/trunk@28908
git-svn-id: http://core.svn.wordpress.org/trunk@28707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-29 22:27:15 +00:00
Scott Taylor
8dd3c0e909
wlwmanifest_link()
should use the WPINC
constant
...
Props wojtek.szkutnik
See #14157 .
Built from https://develop.svn.wordpress.org/trunk@28905
git-svn-id: http://core.svn.wordpress.org/trunk@28704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-29 22:17:14 +00:00
Scott Taylor
378b4cd896
Cleanup after [28671]:
...
* Set better defaults in `paginate_links()`, so that themes don't have to calculate them on their own, like Twenty Fourteen does now.
* Don't set page 1 to `?page=1` or `/page/1/` - that will force a canonical redirect.
* Add and cleanup unit tests
Props obenland, SergeyBiryukov, wonderboymusic.
Fixes #24606 .
Built from https://develop.svn.wordpress.org/trunk@28785
git-svn-id: http://core.svn.wordpress.org/trunk@28598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-20 17:12:15 +00:00
Sergey Biryukov
dbff41578e
Avoid an empty href attribute in paginate_links(). Add unit tests.
...
props obenland, Nessworthy.
fixes #24606 .
Built from https://develop.svn.wordpress.org/trunk@28671
git-svn-id: http://core.svn.wordpress.org/trunk@28489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 02:10:15 +00:00
Sergey Biryukov
fcd8152496
Add 'wp_title_parts' filter to wp_title().
...
props aaroncampbell, obenland.
fixes #17877 .
Built from https://develop.svn.wordpress.org/trunk@28669
git-svn-id: http://core.svn.wordpress.org/trunk@28487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-05 00:28:15 +00:00
Scott Taylor
f50d5233f3
Truly check for ! empty()
instead of falsey ''
when determining whether to add LIMIT
clause to SQL in wp_get_archives()
.
...
Props jjeaton for the initial patch.
Fixes #27834 .
Built from https://develop.svn.wordpress.org/trunk@28560
git-svn-id: http://core.svn.wordpress.org/trunk@28386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 18:28:14 +00:00
Sergey Biryukov
9b9b8ec413
Use correct variable. see [28534], [28538].
...
see #22400 .
Built from https://develop.svn.wordpress.org/trunk@28540
git-svn-id: http://core.svn.wordpress.org/trunk@28366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:40:14 +00:00
Scott Taylor
b8d469600b
These functions import $wpdb
but do not use it.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28539
git-svn-id: http://core.svn.wordpress.org/trunk@28365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:37:14 +00:00
Sergey Biryukov
f4646b47e7
Remove redundant assignment. see [28379], [28534].
...
see #22400 .
Built from https://develop.svn.wordpress.org/trunk@28538
git-svn-id: http://core.svn.wordpress.org/trunk@28364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 17:35:13 +00:00
Scott Taylor
62f9e7636d
Fix some bad UI recursion in wp_get_archives()
caused by [28379]. It appears that $afterafter
was appropriately named.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28534
git-svn-id: http://core.svn.wordpress.org/trunk@28360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-20 23:09:16 +00:00
Drew Jaynes
11dd3443a2
Improve inline documentation for default arguments in wp_get_archives()
.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@28476
git-svn-id: http://core.svn.wordpress.org/trunk@28303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-18 17:20:15 +00:00
Scott Taylor
d5acdd82c8
Eliminate use of extract()
in paginate_links()
. Adds unit tests. Moves tests/general/template.php
(which only had one method) to tests/general/paginateLinks.php
.
...
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28397
git-svn-id: http://core.svn.wordpress.org/trunk@28225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-14 22:29:14 +00:00
Scott Taylor
b110c7f887
Eliminate use of extract()
in wp_get_archives()
.
...
Adds unit tests: `tests/functions/getArchives.php`.
All other unit tests pass.
Props MikeHansenMe, wonderboymusic.
See #22400 .
Built from https://develop.svn.wordpress.org/trunk@28379
git-svn-id: http://core.svn.wordpress.org/trunk@28207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-13 04:29:26 +00:00
Scott Taylor
3d0eed82f8
In paginate_links()
, break
is unreachable after return
.
...
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28326
git-svn-id: http://core.svn.wordpress.org/trunk@28154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 21:25:15 +00:00
Scott Taylor
9bdbd50ac0
In general-template.php
- remove dead code:
...
* In `get_calendar()`, `$cache` is set twice. The first is useless.
* In `wp_default_editor()`, `$user` is (accidentally) assigned in a condition. Since it is never used, this is unnecessary.
* In `language_attributes()`, `$output` is set twice before it is ever used. The first is unnecessary.
* In `paginate_links()`, `$n` is set twice before it is ever used. The first is unnecessary.
See #27882 .
Built from https://develop.svn.wordpress.org/trunk@28274
git-svn-id: http://core.svn.wordpress.org/trunk@28102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:58:16 +00:00
Scott Taylor
a2067a7324
Set the proper value for wp_title()
when is_author()
and is_post_type_archive()
are both true. post_type
should always win due to the precedence indicated in get_queried_object()
.
...
Props mordauk.
Fixes #25398 .
Built from https://develop.svn.wordpress.org/trunk@28251
git-svn-id: http://core.svn.wordpress.org/trunk@28079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 22:21:22 +00:00
Drew Jaynes
05537ab967
Ensure the register
filter hook is only documented once.
...
See #26869 .
Built from https://develop.svn.wordpress.org/trunk@28208
git-svn-id: http://core.svn.wordpress.org/trunk@28038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-25 06:24:15 +00:00
Drew Jaynes
e8be2a7e1e
Inline documentation for three remaining hooks in wp-includes/general-template.php.
...
Documents the `login_form_top`, `login_form_middle`, and `login_form_bottom` and filters.
That's 184/184 hook docs files complete. Boom!
Props kpdesign, DrewAPicture.
Fixes #27719 .
Built from https://develop.svn.wordpress.org/trunk@28131
git-svn-id: http://core.svn.wordpress.org/trunk@27962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 04:42:16 +00:00
Drew Jaynes
577fe1960a
Inline documentation for hooks in wp-includes/general-template.php.
...
Props jesin, kpdesign.
See #27719 .
Built from https://develop.svn.wordpress.org/trunk@28130
git-svn-id: http://core.svn.wordpress.org/trunk@27961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 04:01:15 +00:00
John Blackbourn
8f5e5941bb
Introduce before_page_number
and after_page_number
arguments for paginate_links()
. Fixes #24709 . Props grahamarmfield.
...
Built from https://develop.svn.wordpress.org/trunk@27600
git-svn-id: http://core.svn.wordpress.org/trunk@27443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 23:31:14 +00:00
John Blackbourn
3ec5d81f97
Improve paginate_links()
performance by not calling number_format_i18n()
unnecessarily. Fixes #25735 with tests. Props johnpbloch.
...
Built from https://develop.svn.wordpress.org/trunk@27523
git-svn-id: http://core.svn.wordpress.org/trunk@27366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-13 17:39:15 +00:00
Andrew Nacin
f1bcaeb35f
Let get_the_date() accept a post object.
...
props tanner-m, adamsilverstein, bigdawggi.
fixes #13771 .
Built from https://develop.svn.wordpress.org/trunk@27380
git-svn-id: http://core.svn.wordpress.org/trunk@27229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 18:00:14 +00:00
Andrew Nacin
d24a109288
Revert [27115] and let cache backends handle the stripping of spaces in cache keys as necessary.
...
microtime() returns greater precision than microtime(true).
see #27000 , #23448 , #26903 , #14485 .
Built from https://develop.svn.wordpress.org/trunk@27300
git-svn-id: http://core.svn.wordpress.org/trunk@27153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-26 22:05:13 +00:00
Drew Jaynes
cb8951b0b3
Remove all @package
and @subpackage
PHPDoc tags not at the file- or class-levels in core.
...
See #27200 .
Built from https://develop.svn.wordpress.org/trunk@27262
git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 17:14:14 +00:00
Sergey Biryukov
46fc082824
Correct @return value for get_the_date().
...
props TobiasBg.
fixes #27181 .
Built from https://develop.svn.wordpress.org/trunk@27231
git-svn-id: http://core.svn.wordpress.org/trunk@27088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-21 22:49:13 +00:00
Sergey Biryukov
68f4f9d5ba
Remove unnecessary assignment and concatenation from the_date() and get_the_date().
...
props juliobox.
fixes #27181 .
Built from https://develop.svn.wordpress.org/trunk@27230
git-svn-id: http://core.svn.wordpress.org/trunk@27087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-21 22:38:13 +00:00
Drew Jaynes
cb3c7997c7
Improve inline documenation for get_the_time()
and `get_post_time().
...
Props ruud@joyo for the initial patch.
Fixes #26682 .
Built from https://develop.svn.wordpress.org/trunk@27148
git-svn-id: http://core.svn.wordpress.org/trunk@27015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-09 21:03:13 +00:00
Andrew Nacin
084a7b50cd
Use a float for last_changed microtime cache values.
...
microtime() by default returns a string with a space, which isn't allowed for keys in some cache backends.
props _jameslee, drozdz.
fixes #27000 . see #23448 .
Built from https://develop.svn.wordpress.org/trunk@27115
git-svn-id: http://core.svn.wordpress.org/trunk@26982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 08:14:12 +00:00
Andrew Nacin
12a64b39db
Fix the conditional enqueueing/printing of colors stylesheets, without breaking dependencies.
...
fixes #18380 .
see #20729 which should properly fix this.
Built from https://develop.svn.wordpress.org/trunk@27111
git-svn-id: http://core.svn.wordpress.org/trunk@26978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-06 22:16:11 +00:00
Andrew Nacin
b7d3166e90
Use the_title_attribute() in feed_links_extra(), rather than get_the_title().
...
props c3mdigital.
fixes #15046 .
Built from https://develop.svn.wordpress.org/trunk@26975
git-svn-id: http://core.svn.wordpress.org/trunk@26854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-17 09:53:09 +00:00
Andrew Ozz
90403aed4b
Deprecate rich_edit_exists(). It doesn't make sense to support deleting the TinyMCE directory when we have auto-updates. Fixes #26786 .
...
Built from https://develop.svn.wordpress.org/trunk@26933
git-svn-id: http://core.svn.wordpress.org/trunk@26814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-13 00:00:12 +00:00
Drew Jaynes
081932443f
Avoid a notice by checking that SCRIPT_DEBUG is defined before evaluating it in register_admin_color_schemes()
.
...
See #26316 .
Built from https://develop.svn.wordpress.org/trunk@26786
git-svn-id: http://core.svn.wordpress.org/trunk@26673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 19:23:11 +00:00
Andrew Nacin
aa1ac65bfc
Admin color schemes: Manually handle RTL and minified versions of the CSS files on registration.
...
This bypasses WP_Styles entirely, which is much simpler for the moment, given that color schemes bypass WP_Styles for plenty already. The script loader is told to stop thinking of colors.css as an RTL-ified file. The colors-fresh handle, used directly on the login screen, needed to be (even before this commit).
fixes #26316 .
Built from https://develop.svn.wordpress.org/trunk@26780
git-svn-id: http://core.svn.wordpress.org/trunk@26667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 09:05:10 +00:00
Andrew Nacin
ce94d432a7
Add four more color schemes to round out our collection at eight.
...
The new schemes are Ectoplasm, Coffee, Ocean, Sunrise. For those following along, the first three were at one point named Ghostbusters, Pixel, and Cape Cod.
See [26137] for the original color schemes.
props ryelle, melchoyce, drw158, littlethingsstudio.
fixes #26468 . see #25858 , #22862 .
Built from https://develop.svn.wordpress.org/trunk@26773
git-svn-id: http://core.svn.wordpress.org/trunk@26660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 07:26:12 +00:00
Andrew Ozz
e6dd5fbf48
Svg-painter:
...
- Clean up the JS, better names, etc.
- Convert the base64 encode/decode code from jQuery plugin to local use.
- Add missing icon colors for the default theme.
- Make it more error-proof.
Fixes #26333 .
Built from https://develop.svn.wordpress.org/trunk@26601
git-svn-id: http://core.svn.wordpress.org/trunk@26491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 04:13:11 +00:00
Andrew Nacin
dd465838e6
Rename colors-fresh.css to colors.css. fixes #26137 .
...
Built from https://develop.svn.wordpress.org/trunk@26570
git-svn-id: http://core.svn.wordpress.org/trunk@26461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 18:16:11 +00:00
Helen Hou-Sandí
7c940061fd
Pass the post type to the post_type_archive_title
filter for better context. Adds lovely docs. props DrewAPicture. fixes #25605 .
...
Built from https://develop.svn.wordpress.org/trunk@26457
git-svn-id: http://core.svn.wordpress.org/trunk@26355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-28 05:24:09 +00:00
Andrew Nacin
f665c7eeb1
Remove SCRIPT_DEBUG reference from register_admin_color_schemes().
...
Instead, script-loader.php handles converting .min.css to .css when SCRIPT_DEBUG is on, and has since r21592. (This was done for compatibility with plugin color schemes that used .css and .dev.css.)
see #25858 .
Built from https://develop.svn.wordpress.org/trunk@26147
git-svn-id: http://core.svn.wordpress.org/trunk@26058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 00:03:10 +00:00
Helen Hou-Sandí
94dfe504f3
Avoid a notice when SCRIPT_DEBUG is not defined. props MikeHansenMe. see #25824 , #25858 .
...
Built from https://develop.svn.wordpress.org/trunk@26146
git-svn-id: http://core.svn.wordpress.org/trunk@26057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 23:59:08 +00:00
Helen Hou-Sandí
603c1aff6d
Merge the color schemes component from MP6. Introduces Light, Blue, and Midnight.
...
Color scheme selection on your own profile page gives you a preview and autosaves the selection.
Also introduces the usage of a preprocessor for core files, namely Sass. For 3.8, we will not expand its implementation past the color schemes. This does require Ruby as well as Sass 3.3.0+ due to the usage of the sourcemap option.
Note that only the default color scheme is available when running out of src. Use build to test the rest as well as the color picker.
props ryelle, melchoyce, tillkruess, drw158, littlethingsstudio, helen. see #25858 , #22862 .
Built from https://develop.svn.wordpress.org/trunk@26137
git-svn-id: http://core.svn.wordpress.org/trunk@26048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:38:38 +00:00
Scott Taylor
d7efe7a3b0
Change nofollow
to follow
in wp_robots_noindex()
. "The noindex is fine, the nofollow stops any link equity from that URL, so that's actually a bad idea."
...
Props joostdevalk.
Fixes #22876 .
Built from https://develop.svn.wordpress.org/trunk@26096
git-svn-id: http://core.svn.wordpress.org/trunk@26011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 22:27:10 +00:00
Helen Hou-Sandí
69d432410a
Say hello to a fresh new look for the WordPress admin.
...
Still to come: more color schemes, a responsive component, and more.
see #25858 .
props iammattthomas, tillkruess, EmpireOfLight, melchoyce, ryelle, joen, mitchoyoshitaka, sirbrillig, andypeatling, isaackeyet, Otto42, dd32, matt, helen.
Built from https://develop.svn.wordpress.org/trunk@26072
git-svn-id: http://core.svn.wordpress.org/trunk@25992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-10 00:27:10 +00:00
Andrew Nacin
5361a8abca
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin
74488bdcb0
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Sergey Biryukov
1863c06879
Escape title in HTML5 search form. props obenland, joostdevalk, scottsweb. fixes #25322 .
...
Built from https://develop.svn.wordpress.org/trunk@25710
git-svn-id: http://core.svn.wordpress.org/trunk@25624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-07 14:14:09 +00:00
Andrew Nacin
ce637bdcb3
Remove redundant title attributes.
...
props sabreuse.
see #24766 .
Built from https://develop.svn.wordpress.org/trunk@25675
git-svn-id: http://core.svn.wordpress.org/trunk@25591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 22:51:10 +00:00
Andrew Nacin
32917eb0bd
Ensure that get_bloginfo( 'pingback_url' ) uses site_url(), for SSL awareness.
...
props technosailor.
fixes #25418 .
Built from https://develop.svn.wordpress.org/trunk@25671
git-svn-id: http://core.svn.wordpress.org/trunk@25587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-02 21:15:09 +00:00
Scott Taylor
8bd9659d0d
Move checks for post_type
being an array inline. See [25291], [25292], #18614 .
...
Built from https://develop.svn.wordpress.org/trunk@25312
git-svn-id: http://core.svn.wordpress.org/trunk@25274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 03:02:10 +00:00
Scott Taylor
d24a3940de
Make sure the queried object is non-null before accessing its properties.
...
Props markoheijnen, ryan.
Fixes #21394 .
Built from https://develop.svn.wordpress.org/trunk@25310
git-svn-id: http://core.svn.wordpress.org/trunk@25272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-10 02:28:11 +00:00
Scott Taylor
a67d551dac
Ensure that the post type object is the queried object when a post type has been registered with has_archive => true
. Ensure it is not stomped when decorated with tax_query
. Adds unit tests.
...
Props nacin.
Fixes #18614 .
Built from https://develop.svn.wordpress.org/trunk@25291
git-svn-id: http://core.svn.wordpress.org/trunk@25255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 22:07:09 +00:00
Sergey Biryukov
02e5cb6f9d
Escape URLs in feed_links(). props Chouby. fixes #25212 .
...
Built from https://develop.svn.wordpress.org/trunk@25207
git-svn-id: http://core.svn.wordpress.org/trunk@25179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 10:11:09 +00:00
Andrew Nacin
daf9fcc07a
Obey $prefix when $display = false in single_term_title(), single_post_title(), and post_type_archive_title(). props yoavf, fixes #16632 .
...
Built from https://develop.svn.wordpress.org/trunk@25041
git-svn-id: http://core.svn.wordpress.org/trunk@25028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-16 20:54:10 +00:00
Andrew Nacin
34a1d5394c
Have get_footer() match get_header() etc in [24616]. fixes #24714 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 20:48:02 +00:00
Andrew Nacin
fb20e3b5bb
In general template functions, cast to string then ensure we actually have a template name before proceeding. Affects get_sidebar(), get_header(), get_footer(), get_template_part().
...
props tivnet for initial patch.
fixes #24714 .
git-svn-id: http://core.svn.wordpress.org/trunk@24616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 20:31:04 +00:00
Ryan Boren
d04bce99e8
Don't sync the blog public option from noindex(). This can cause race conditions.
...
fixes #23155
git-svn-id: http://core.svn.wordpress.org/trunk@24559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 15:17:31 +00:00
Andrew Nacin
ff6dd2b952
Improve the HTML classes for the new html5 format in get_search_form().
...
Update Twenty Thirteen to reflect the changes.
props obenland.
fixes #23850 .
git-svn-id: http://core.svn.wordpress.org/trunk@24524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 20:45:12 +00:00
Andrew Nacin
5969819038
`add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );'
...
props obenland.
see #23850 .
git-svn-id: http://core.svn.wordpress.org/trunk@24417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 15:31:34 +00:00
Sergey Biryukov
351fda2958
Allow to switch get_search_form() to HTML5 with an add_theme_support() call. fixes #23850 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 22:41:30 +00:00
Andrew Nacin
a518fb0c94
Fix usage of undeclared variables.
...
* the_weekday_date() needs the global $currentday
* ms_site_check() needs the global $current_site
* media list table does not need to check for $total_orphans
* upgrader has no $feedback variable, appears to be copypasta from other upgrade APIs
* install_themes_feature_list() has no $features variable, return array() instead of a new return type of WP_Error
see #24210 .
git-svn-id: http://core.svn.wordpress.org/trunk@24189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 16:35:03 +00:00
Andrew Nacin
a9712e0183
Add wp_registration_url() and register_url filter.
...
props scribu, JustinSainton, SergeyBiryukov.
fixes #17950 .
git-svn-id: http://core.svn.wordpress.org/trunk@24053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:21:22 +00:00
Andrew Ozz
49f185ae09
In the HTML outputted from get_search_form(): remove incrementing the IDs for XHTML after the first call, remove the <div> wrapper for HTML5. Props obenland, props bpetty. Fixes #16539
...
git-svn-id: http://core.svn.wordpress.org/trunk@23916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-05 00:26:53 +00:00
Andrew Ozz
651534f24e
Heartbeat: improve setting the errorstate, add ajaxurl to the settings object when loading on the front-end, some code cleanup, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-30 23:32:12 +00:00
Andrew Ozz
edb3712956
In the HTML outputted from get_search_form(): increment the ID connecting <label> to <input> when the function is called multiple times, remove the form and submit button IDs for HTML 5.0 and for XHTML after the first call. Props WraithKenny, fixes #16539
...
git-svn-id: http://core.svn.wordpress.org/trunk@23801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-26 23:18:43 +00:00
Sergey Biryukov
ae48aed870
Rename 'get_search_form' action to 'pre_get_search_form' to prevent collision with the filter of the same name. Make sure the filtered result is not null to prevent search form from disappearing if an action function is attached to the old hook. fixes #19321 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-26 21:08:04 +00:00