Sergey Biryukov
137204b033
In _wp_menu_output()
, $submenu_items
is an array and should be initialized as such.
...
props ipm-frommen.
fixes #31257 .
Built from https://develop.svn.wordpress.org/trunk@31364
git-svn-id: http://core.svn.wordpress.org/trunk@31345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-07 17:57:24 +00:00
Scott Taylor
8ee598169f
After [31105], don't ditch the isset()
calls for BC. Declare $page_hook
as null
so it is initialized for all execution paths but will still fail isset()
checks.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31106
git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:52:22 +00:00
Scott Taylor
60e1dd409b
Properly declare $hook_suffix
, $plugin_page
, $typenow
, and $taxnow
as globals in wp-admin/admin.php
.
...
Fixes #30958 .
Built from https://develop.svn.wordpress.org/trunk@31105
git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 22:15:24 +00:00
Scott Taylor
60b0cd7943
The keyword elseif
should be used instead of else if
so that all control keywords look like single words.
...
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@31090
git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Helen Hou-Sandí
ad646bc183
Accessibility: hide admin menu separators from screen readers.
...
props afercia. fixes #30010 .
Built from https://develop.svn.wordpress.org/trunk@30393
git-svn-id: http://core.svn.wordpress.org/trunk@30389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 19:37:21 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Sergey Biryukov
2fa0de5f6f
Avoid inadvertently adding admin page titles as classes for admin menu submenu items.
...
fixes #28817 .
Built from https://develop.svn.wordpress.org/trunk@29083
git-svn-id: http://core.svn.wordpress.org/trunk@28869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 01:10:15 +00:00
Helen Hou-Sandí
95deee2de5
Restore the ability to pass classes to admin menu submenu items, important for the Customize link. Accidentally left out in [24048]. fixes #28583 .
...
Built from https://develop.svn.wordpress.org/trunk@28778
git-svn-id: http://core.svn.wordpress.org/trunk@28591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-19 02:18:15 +00:00
Dominik Schilling
192afe238a
Admin Menu: Use .dashicons-before
as default $img_class.
...
props kovshenin for noticing and testing.
see #26630 .
Built from https://develop.svn.wordpress.org/trunk@27425
git-svn-id: http://core.svn.wordpress.org/trunk@27272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 23:22:15 +00:00
Dominik Schilling
d23cd0aa50
Introduce a .dashicons-before
CSS class.
...
If you want to use a Dashicon before an element you can use the class because it will not change the elements content styling. With that you don't need to copy the entire `.dashicons` styling to your :before styling anymore.
To demonstrate this change, Admin Menu now uses Dashicons classes directly.
And it fixes a glitch in IE.
fixes #26630 .
Built from https://develop.svn.wordpress.org/trunk@27418
git-svn-id: http://core.svn.wordpress.org/trunk@27265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-05 20:04:14 +00:00
Sergey Biryukov
805d6fe59b
Update comment about structure of items in $menu global.
...
props kitchin.
fixes #26635 .
Built from https://develop.svn.wordpress.org/trunk@27151
git-svn-id: http://core.svn.wordpress.org/trunk@27018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-09 21:43:12 +00:00
Drew Jaynes
cea5ae90f5
Inline documentation for hooks in wp-admin/menu-header.php.
...
Props piontkowski, kpdesign.
Fixes #26051 .
Built from https://develop.svn.wordpress.org/trunk@26893
git-svn-id: http://core.svn.wordpress.org/trunk@26776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-02 02:46:12 +00:00
Helen Hou-Sandí
7f8584d37b
More targeted background image styling for admin menu SVG icons. fixes #25147 .
...
Built from https://develop.svn.wordpress.org/trunk@26671
git-svn-id: http://core.svn.wordpress.org/trunk@26561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 17:53:10 +00:00
Andrew Nacin
9b29ad0529
Allow for Dashicons and base64-encoded data:image/svg+xml URIs when specifying menu icons.
...
Both of these icons can be colored to match the color scheme, including hover states.
Both are accepted for register_post_type()'s menu_icon argument, and also add_menu_page()'s $icon_url argument.
To use a Dashicon, pass the name of the helper class, e.g. 'dashicons-piechart'.
To use an SVG, pass a valid data URI string starting with 'data:image/svg+xml;base64,'.
props helen.
fixes #25147 .
Built from https://develop.svn.wordpress.org/trunk@26664
git-svn-id: http://core.svn.wordpress.org/trunk@26554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 06:38:09 +00:00
Helen Hou-Sandí
70330d468c
Remove now-unused #adminmenushadow. see #25858 .
...
Built from https://develop.svn.wordpress.org/trunk@26182
git-svn-id: http://core.svn.wordpress.org/trunk@26091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 23:49:10 +00:00
Andrew Nacin
82c4745df2
Remove unused variable. props jeremyfelt. fixes #24959 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-05 21:38:24 +00:00
Mark Jaquith
e553e85ebb
Remove $pagenow
global from three functions that don’t use it.
...
Props jeremyfelt. Fixes #24920 .
git-svn-id: http://core.svn.wordpress.org/trunk@24974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-02 04:42:08 +00:00
Andrew Nacin
b11654ce74
Revert [23871] - Customize should be added to the menu, but not hacked in as first. see #21413 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 19:33:39 +00:00
Mark Jaquith
8c4aeb9188
Add "Customize" as first item under Appearance menu.
...
fixes #21413 . props ryanhellyer, obenland, DrewAPicture
git-svn-id: http://core.svn.wordpress.org/trunk@23871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-29 20:39:54 +00:00
Sergey Biryukov
973985c2ce
Prevent plugins with certain filenames from breaking links in the admin menu. props lightningspirit. fixes #22079 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-09 02:48:49 +00:00
Ryan Boren
06ee370814
Pinking shears
...
git-svn-id: http://core.svn.wordpress.org/trunk@22634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 15:11:29 +00:00
Andrew Ozz
b443373e8e
Admin menu: add phpdoc/inline comments describing the usage of the param $icon_url in add_menu_page(), add string 'none' to be used when a menu icon is added from CSS, switch core items in the admin menu to use 'none', fixes #21349
...
git-svn-id: http://core.svn.wordpress.org/trunk@21877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 22:51:44 +00:00
Andrew Ozz
0b92d7c941
Improve the layout and accessibility of the admin menu: simplify the HTML structure, move the submenus off the viewport (still visible for screen readers) instead of hiding them with display: none, make it possible to unfold the menu on small/narrow screens, see #21349
...
git-svn-id: http://core.svn.wordpress.org/trunk@21574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-21 22:46:30 +00:00
azaozz
34535097b7
Remove nearly all tabindex attributes from the admin, leaving them only where absolutely necessary (for now that's only the toolbar).
...
Add tabindex="-1" for the menu images links to avoid double tab stops there when the menu is expanded.
Fix/add auto-focus on the first input fields on the Add/Edit Post, all taxonomy, all edit taxonomy, Log In and Edit Comment screens.
See #21340 .
git-svn-id: http://core.svn.wordpress.org/trunk@21311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-24 00:15:15 +00:00
azaozz
a0beb9a1d1
Admin menu: change to strip_tags() for the aria-label attributes as it's faster, fixes #20373
...
git-svn-id: http://core.svn.wordpress.org/trunk@20698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-02 20:36:07 +00:00
azaozz
46839c23eb
Admin menu: add aria-label attributes to the links around menu images for the sake of screen readers, fixes #20373
...
git-svn-id: http://core.svn.wordpress.org/trunk@20680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-02 01:41:15 +00:00
azaozz
f6047c397e
Remove role="menu" and role="menuitem" for now, fixes #19394
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-05 17:47:23 +00:00
ryan
6bba5a265b
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 04:51:35 +00:00
azaozz
69cd88fc6f
Reset aria_arrtibutes when reaching admin submenu, see #19394
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 02:23:21 +00:00
azaozz
7f81dbfe3f
Add ARIA related attributes (first take), props DrewAPicture, see #19394
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-30 01:27:33 +00:00
duck_
0ca4df123a
Remove dead code left by r18621. Props ocean90. Fixes #19087 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-01 12:36:14 +00:00
ryan
d01f93226d
Fix sub menu highlighting for post type pages. see #13662
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-23 18:45:06 +00:00
koopersmith
e10f6876d4
Create admin menu arrows using CSS3 transforms. props chexee. see #18382 , fixes #18902 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-11 21:25:38 +00:00
azaozz
0e358f2179
Fix menu hover when loaded folded, simplify menu JS and auto-folding, see #18382
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-06 09:18:56 +00:00
duck_
2b11174785
_wp_menu_output() speed up and clean up. Props dragoonis. Fixes #13662 .
...
Attempt file_exists() last and cache an array index lookup for speed up. Whitespace and appropriate parentheses for readability.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-27 10:22:58 +00:00
koopersmith
51fa6f62f2
Switch admin menus to flyouts from dropdowns. First pass, see #18382 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-30 01:12:26 +00:00
azaozz
06fd2002c5
Fix unfolding of the admin menu when no JS, fixes #17897
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-27 20:40:04 +00:00
azaozz
d2e54b7932
Revert [17943] as it breaks plugins, props johnjamesjacoby, fixes #17484
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 06:20:30 +00:00
azaozz
46c545cdba
Remove links from the menu separators, see #17324
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-17 06:19:00 +00:00
koopersmith
7e14a62035
Improve collapsed menu styling. see #17324 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-05 22:13:03 +00:00
koopersmith
892a2a0df4
Add collapse link to admin menu, add new arrow graphics, improve screen meta JS/CSS.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-05 19:51:32 +00:00
markjaquith
8d87f5dcb4
Big UI style update. props koopersmith. see #17324
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 20:15:05 +00:00
azaozz
9ac90e3262
Don't refresh the admin menu after page load, apply the user-state from PHP, fix behaviour after folding the menu, props nacin, props nuxwin, fixes #10646 , fixes #17058
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-07 18:45:22 +00:00
ryan
c087c70a25
Improved self determination. Props PeteMall. see #14435
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-20 14:08:29 +00:00
nacin
c840f4676e
Introduce show_in_menu for register_post_type. Allows post types to be a submenu. Accepts boolean and also a parent base. With help from duck_. fixes #14145 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-19 07:58:02 +00:00
dd32
abcbdf58b2
Escape/texturize Admin menu titles. Fixes page titles such as "Foo & Bar" not being entity encoded. Also includes some basic whitespace/standards cleanup to a related function. Fixes #12039
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-04-18 03:38:47 +00:00
dd32
8f30ffcb9e
Properly escape plugin admin menu URL's for display. Crops up with custom post_type's with a custom submenu item with & instead of &
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-28 01:32:35 +00:00
nacin
30d6eb32c6
Remove redundant isset() and empty() checks.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-19 21:29:21 +00:00
ryan
aa47e83dee
Fix submenus for post types. Props TobiasBg. see #12453
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-04 00:15:55 +00:00
ryan
6da55f7792
Trailing whitespace cleanup
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-15 22:11:12 +00:00