Commit Graph

10655 Commits

Author SHA1 Message Date
Andrew Nacin
60be66457a Only show help for upload_path and upload_url_path if those fields are visible. fixes #21720.
git-svn-id: http://core.svn.wordpress.org/trunk@23134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-09 17:04:08 +00:00
Bot (Assets)
695d624bdd Compress scripts/styles: 3.5-RC4-23127.
git-svn-id: http://core.svn.wordpress.org/trunk@23127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 21:00:25 +00:00
Andrew Nacin
db649fbc8d Remove 'Insert Multiple Images' from the about page as it is now completely invisible in the UI. Requiring shift-click but not mentioning it is a bad omen. props helenyhou. fixes #22455.
git-svn-id: http://core.svn.wordpress.org/trunk@23126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-07 20:58:34 +00:00
Andrew Nacin
a90521652e Final screenshot on the about page for the media manager.
props lessbloat.
props matt for the photos.

fixes #22455.



git-svn-id: http://core.svn.wordpress.org/trunk@23109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 19:49:42 +00:00
Andrew Nacin
cfe6e9ed09 Rip keyboard shortcuts out of the image editor help. props helenyhou. fixes #22786.
git-svn-id: http://core.svn.wordpress.org/trunk@23106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 09:21:27 +00:00
Bot (Assets)
395f2b5073 Compress scripts/styles: 3.5-RC3-23099.
git-svn-id: http://core.svn.wordpress.org/trunk@23099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 06:58:33 +00:00
Mark Jaquith
1419b404a8 Add the ability to click "Edit" and kick out to the advanced image editor from within the Media modal. New window, with "Refresh" offered on your return. fixes #22743. props koopersmith, nacin, helenyhou.
git-svn-id: http://core.svn.wordpress.org/trunk@23095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:52:19 +00:00
Mark Jaquith
68524f7c6f Run the attachment_fields_to_save filter even if we don't get the fields we used to get. props nacin. fixes #22774
git-svn-id: http://core.svn.wordpress.org/trunk@23094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:34:17 +00:00
Bot (Assets)
dd4f8b9273 Compress scripts/styles: 3.5-RC3-23093.
git-svn-id: http://core.svn.wordpress.org/trunk@23093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:26:39 +00:00
Daryl Koopersmith
30440dbb66 Add a canonical location for media frames, an alias to fetch attachments, and frame caching to custom header. fixes #22775.
git-svn-id: http://core.svn.wordpress.org/trunk@23092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 05:06:49 +00:00
Andrew Nacin
08401b9e3c Fix branchhing in edit_post() where attachment_fields_to_save would only run when the alt text was sent. It should run whenever an attachment is saved. props sc0ttclark. fixes #22774.
git-svn-id: http://core.svn.wordpress.org/trunk@23088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:50:31 +00:00
Daryl Koopersmith
8efc323e2e Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769.
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 03:28:21 +00:00
Bot (Assets)
4f3c1bb8f1 Compress scripts/styles: 3.5-RC3-23084.
git-svn-id: http://core.svn.wordpress.org/trunk@23084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:42:44 +00:00
Andrew Nacin
173806d7a1 Restore the Description field to the media UI in 3.5.
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-06 00:41:06 +00:00
Andrew Nacin
a13a011265 Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767.
git-svn-id: http://core.svn.wordpress.org/trunk@23082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:51:24 +00:00
Andrew Nacin
ce11438e77 Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764. see #21240, #21391.
git-svn-id: http://core.svn.wordpress.org/trunk@23081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 22:49:51 +00:00
Andrew Nacin
2763e74dd8 Script loader: Chunk the script names as passed to load-scripts.php into 128-character pieces. Avoids hitting a limit for the length of a single variable, such as suhosin.get.max_value_length which defaults to 512. fixes #22757.
git-svn-id: http://core.svn.wordpress.org/trunk@23074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 18:57:56 +00:00
Mark Jaquith
bc8ddb3e64 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 10:29:24 +00:00
Bot (Assets)
1077e9ce03 Compress scripts/styles: 3.5-RC3-23059.
git-svn-id: http://core.svn.wordpress.org/trunk@23059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:58:34 +00:00
Andrew Nacin
40ae89369f Admin ajax: Roll back new-style error sending in set-post-thumbnail. The JS handlers know to parse an unrecognized response (like -1 or 0) as a failure. see #21776. see #22750.
git-svn-id: http://core.svn.wordpress.org/trunk@23058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 02:34:00 +00:00
Andrew Nacin
dc9e6144be Fix inserting of multiple attachments with captions when the first attachment does not have a caption. props azaozz. fixes #22720.
git-svn-id: http://core.svn.wordpress.org/trunk@23055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:59:25 +00:00
Andrew Nacin
aaf5d77d35 Remove options-privacy.php, as intended by [21838]. see #16416. see #22349.
git-svn-id: http://core.svn.wordpress.org/trunk@23050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-05 00:16:54 +00:00
Andrew Nacin
0bd02ac6bb Use correct button class hierarchy to ensure the 'Update' button is button-large. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@23044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 22:02:25 +00:00
Andrew Nacin
36554dd983 Move utils.js (cookie and user setting functions) to wp-includes to enable front-end use.
Make it a dependency of media-views (and therefore media-editor). Move its userSettings JS object from admin-header to being paired with the script in script loader.

see #22730.



git-svn-id: http://core.svn.wordpress.org/trunk@23036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 19:29:56 +00:00
Ryan Boren
a200c702e0 Only show Delete in media modal if the user can delete.
Props nacin, koopersmith
fixes #22711


git-svn-id: http://core.svn.wordpress.org/trunk@23032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 18:33:51 +00:00
Bot (Assets)
32c83140d0 Compress scripts/styles: 3.5-RC3-23025.
git-svn-id: http://core.svn.wordpress.org/trunk@23025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:25:14 +00:00
Andrew Nacin
d2a9957ad8 Media: Disable 'Insert gallery' and 'Set featured image' if nothing is queued. Converts selection toolbars to use the newer view manager. props koopersmith, fixes #22714.
git-svn-id: http://core.svn.wordpress.org/trunk@23024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 16:21:57 +00:00
Andrew Nacin
f82679b3ad Update the 'Retina Ready' screenshot on the about page to reflect version 3.5, Twenty Twelve, and such. It's the little things. props lessbloat. fixes #22455.
git-svn-id: http://core.svn.wordpress.org/trunk@23022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 15:04:19 +00:00
Andrew Nacin
13c9bb4d38 About page: Update retina screenshot to remove the old Upload/Insert icon from QuickPress. props lessbloat. see #22455.
git-svn-id: http://core.svn.wordpress.org/trunk@23019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 07:28:39 +00:00
Bot (Assets)
a1bb2f0054 Compress scripts/styles: 3.5-RC2-23018.
git-svn-id: http://core.svn.wordpress.org/trunk@23018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:58:31 +00:00
Andrew Ozz
f803bad096 Editor: add sanity limit for editor height of 5000px, save only when resizing the Visual or the Text editor, fixes #22708
git-svn-id: http://core.svn.wordpress.org/trunk@23016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 06:01:47 +00:00
Andrew Nacin
a052c19497 Missing RTL for [21944]. props helenyhou. fixes #22707.
git-svn-id: http://core.svn.wordpress.org/trunk@23014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 05:06:24 +00:00
Andrew Nacin
3e1f7a6ef4 Updated media screenshot for the about page. props lessbloat. fixes #22455.
git-svn-id: http://core.svn.wordpress.org/trunk@23010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:13:30 +00:00
Andrew Nacin
3422c8deb6 RTL support for Masonry on the custom header page. fixes #22709.
git-svn-id: http://core.svn.wordpress.org/trunk@23009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 04:08:32 +00:00
Bot (Assets)
30cf064068 Compress scripts/styles: 3.5-RC2-23007. props koopersmith. :-)
git-svn-id: http://core.svn.wordpress.org/trunk@23007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:29:58 +00:00
Ryan Boren
61a9471024 Final round of media UX improvements.
Props koopersmith
fixes #21390 #22502


git-svn-id: http://core.svn.wordpress.org/trunk@23006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 01:26:03 +00:00
Andrew Nacin
9a1ef788ce RTL fixes for the tags meta box and two search inputs. props SergeyBiryukov. fixes #22707.
git-svn-id: http://core.svn.wordpress.org/trunk@23004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-04 00:47:54 +00:00
Ryan Boren
63662a9b7b In the QuickPress media modal, use the new post id when a post is published.
Props nacin, koopersmith
fixes #22673


git-svn-id: http://core.svn.wordpress.org/trunk@22994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 07:17:10 +00:00
Bot (Assets)
b8a9b78359 Compress scripts/styles: 3.5-RC2-22988.
git-svn-id: http://core.svn.wordpress.org/trunk@22988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 05:42:30 +00:00
Andrew Nacin
105cf57225 In Firefox, style placeholder text a dark gray since the browser doesn't do it for us. props helenyhou, fixes #22689.
git-svn-id: http://core.svn.wordpress.org/trunk@22986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 05:17:23 +00:00
Andrew Nacin
787e7f8347 When creating a network, use get_home_path() to calculate where .htaccess (or web.config) lives. fixes #22639.
git-svn-id: http://core.svn.wordpress.org/trunk@22982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 03:42:02 +00:00
Andrew Nacin
e0587d894e Remove errant space.
git-svn-id: http://core.svn.wordpress.org/trunk@22981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:59:04 +00:00
Andrew Nacin
f74e41b389 Correctly calculate the location of wp-config.php, used in the instructions for setting up a network. see #22639.
git-svn-id: http://core.svn.wordpress.org/trunk@22980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:54:29 +00:00
Andrew Nacin
5d0933d884 Bring Featured Images back into the main media dialog.
Most users don't realize that the Featured Image meta box exists; if they do, few use it.

Restores the old meta box UI, including the admin_post_thumbnail_html filter. If a plugin is using _wp_post_thumbnail_html() in conjunction with Thickbox elsewhere, it will also magically still work.

Specific underlying changes:
 * Converts the modal view to use the view manager, which means that a call to open() will automatically call render and attach if necessary.
 * Doesn't automatically set a state in wp.media, to allow code to customize the states to be added before activation.

props koopersmith.
fixes #21776.



git-svn-id: http://core.svn.wordpress.org/trunk@22979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 02:38:10 +00:00
Andrew Nacin
3f532c3bd8 Customizer: Ensure that the 'Collapse' button is styled properly (overridding the admin button style). props helenyhou. fixes #22684.
git-svn-id: http://core.svn.wordpress.org/trunk@22977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-03 00:42:11 +00:00
Andrew Nacin
27bf82201b Allow the 'Uploaded to this post' view to be sorted, saving the resulting order as menu_order.
This functionality is designed to be backwards compatible with manual querying for attachments by menu_order.

props koopersmith.
see #22607.



git-svn-id: http://core.svn.wordpress.org/trunk@22967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 16:06:31 +00:00
Ryan Boren
b7b54c00e9 Namespace the dashboard widget nonce to avoid collisions with plugins.
git-svn-id: http://core.svn.wordpress.org/trunk@22964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-02 00:12:43 +00:00
Ryan Boren
847f435e9f Directly access post_status instead of using get_post_status() when checking for auto-draft status. Attachments with their inherit post_status were getting the auto-draft status of their parent when using get_post_status(). This caused some things to display improperly on the edit attachment page.
Props nacin, miqrogroove
fixes #22672


git-svn-id: http://core.svn.wordpress.org/trunk@22963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-01 23:12:30 +00:00
Andrew Nacin
cb3b72f3be Remove stray single quote in attachment_submit_meta_box(). props Yogi T. fixes #22674.
git-svn-id: http://core.svn.wordpress.org/trunk@22962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-01 18:59:16 +00:00
Ryan Boren
22bc8cc437 Properly pass WordPress uploading errors to wp.Uploader.
Props koopersmith
fixes #22655


git-svn-id: http://core.svn.wordpress.org/trunk@22954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-30 15:40:09 +00:00