Weston Ruter
5dae1386aa
Customize: Ensure that a setting (especially a multidimensional one) can still be previewed when the post value to preview is set after preview()
is invoked.
...
* Introduce `customize_post_value_set_{$setting_id}` and `customize_post_value_set` actions which are done when `WP_Customize_Manager::set_post_value()` is called.
* Clear the `preview_applied` flag for aggregated multidimensional settings when a post value is set. This ensures the new value is used instead of a previously-cached previewed value.
* Move `$is_preview` property from subclasses to `WP_Customize_Setting` parent class.
* Deferred preview: Ensure that when `preview()` short-circuits due to not being applicable that it will be called again later when the post value is set.
* Populate post value for updated-widget with the (unsanitized) JS-value in `WP_Customize_Widgets::call_widget_update()` so that value will be properly sanitized when accessed in `WP_Customize_Manager::post_value()`.
Includes unit tests with assertions to check the reported issues and validate the fixes.
Fixes defect introduced in [35007].
See #32103 .
Fixes #34738 .
Built from https://develop.svn.wordpress.org/trunk@35724
git-svn-id: http://core.svn.wordpress.org/trunk@35688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-21 02:52:27 +00:00
Sergey Biryukov
fd9bd77fe5
Comments: In comment_form()
, introduce the comment_form_fields
filter for comment fields, including the textarea.
...
Correct the docs for `comment_notes_before` and `comment_notes_after` arguments as well as `comment_form_before_fields` and `comment_form_after_fields` actions to better describe the current behaviour.
Fixes #34731 .
Built from https://develop.svn.wordpress.org/trunk@35723
git-svn-id: http://core.svn.wordpress.org/trunk@35687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 18:56:27 +00:00
Sergey Biryukov
17af54fc7c
Customizer: Use correct context and translator comments for menu location strings.
...
See #33431 .
Built from https://develop.svn.wordpress.org/trunk@35722
git-svn-id: http://core.svn.wordpress.org/trunk@35686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 17:46:25 +00:00
Helen Hou-Sandí
277747f944
Postbox handle buttons don't need a focus outline.
...
see #33808 , #34242 .
Built from https://develop.svn.wordpress.org/trunk@35721
git-svn-id: http://core.svn.wordpress.org/trunk@35685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 15:56:25 +00:00
Dominik Schilling
22fe87c3b3
Build: Update source for includes:embed
after [35718].
...
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@35720
git-svn-id: http://core.svn.wordpress.org/trunk@35684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 15:37:26 +00:00
Dominik Schilling
6fa25ac809
4.4-beta4-35719.
...
Built from https://develop.svn.wordpress.org/trunk@35719
git-svn-id: http://core.svn.wordpress.org/trunk@35683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 13:46:27 +00:00
Andrew Nacin
1579e45d41
Simplify the include graph after work to split out classes.
...
see #33413 . More details there.
Built from https://develop.svn.wordpress.org/trunk@35718
git-svn-id: http://core.svn.wordpress.org/trunk@35682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 07:24:30 +00:00
Helen Hou-Sandí
e549e56f02
Custom fields: Allow for short-circuiting the meta key dropdown.
...
Adds the `postmeta_form_keys` filter which allows for a potentially expensive query against postmeta to be avoided.
props ericmann, tollmanz, nacin.
see #33885 .
Built from https://develop.svn.wordpress.org/trunk@35717
git-svn-id: http://core.svn.wordpress.org/trunk@35681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:16:50 +00:00
Sergey Biryukov
4341637ba6
Docs: Remove redundant type
strings from the wp_calculate_image_srcset
filter DocBlock.
...
Props DH-Shredder, joemcgill.
See #34733 .
Built from https://develop.svn.wordpress.org/trunk@35716
git-svn-id: http://core.svn.wordpress.org/trunk@35680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:16:26 +00:00
Sergey Biryukov
db4a87b0fd
Docs: Add @see
tags for wp_get_attachment_image_srcset()
and wp_get_attachment_image_sizes()
.
...
Update `@see` tags for `wp_make_content_images_responsive()` and `wp_image_add_srcset_and_sizes()`.
Props jaspermdegroot.
See #34733 .
Built from https://develop.svn.wordpress.org/trunk@35715
git-svn-id: http://core.svn.wordpress.org/trunk@35679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 06:13:26 +00:00
Dion Hulse
048f327bfc
Merge the changes to GlotPress's POMO from upstream to WordPress's copy.
...
Fixes #34748
Built from https://develop.svn.wordpress.org/trunk@35714
git-svn-id: http://core.svn.wordpress.org/trunk@35678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 04:34:25 +00:00
Dion Hulse
870cdfb024
Bump the version of MediaElement in script-loader.php to match what we're shipping with.
...
See #33798
Fixes #34743
Built from https://develop.svn.wordpress.org/trunk@35713
git-svn-id: http://core.svn.wordpress.org/trunk@35677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 03:32:26 +00:00
Sergey Biryukov
cc7736a024
ru_RU: In back-compat styles for admin menu, inherit the width from the parent element, #adminmenuwrap
, to account for media queries.
...
See #20974 .
Built from https://develop.svn.wordpress.org/trunk@35712
git-svn-id: http://core.svn.wordpress.org/trunk@35676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 01:40:25 +00:00
Sergey Biryukov
3418279862
ru_RU: After [35710], remove fixed width for admin menu, as it does not account for media queries.
...
See #20974 .
Built from https://develop.svn.wordpress.org/trunk@35711
git-svn-id: http://core.svn.wordpress.org/trunk@35675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 01:04:25 +00:00
Sergey Biryukov
a1116d9534
Add some back-compat styles for ru_RU.
...
This prevents the admin menu from disappearing if an old `ru_RU.php` file is left over after updating directly from 3.1.x or an older version to the latest release.
See #20974 .
Built from https://develop.svn.wordpress.org/trunk@35710
git-svn-id: http://core.svn.wordpress.org/trunk@35674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-20 00:36:27 +00:00
Gary Pendergast
a3cd85eefd
Texturize: Only convert &
to &
within text nodes.
...
Previously, `&` would be converted everywhere, which caused problems when it was converted within a `<script>`, for example.
`convert_chars()` is now removed from the `the_content` filter, as it was doing the same job as `wptexturize()`.
KSES correctly handles converting `&` within HTML attributes, so there's no need for `wptexturize()` and `convert_chars()` to do the same job.
Fixes #34698 .
Built from https://develop.svn.wordpress.org/trunk@35709
git-svn-id: http://core.svn.wordpress.org/trunk@35673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 23:31:26 +00:00
Gary Pendergast
603d3c0013
Embeds: Remove &
characters from the inline embed JS.
...
Older versions of WordPress will convert those `&` characters to `&`, which makes for some non-functional JS. If folks are running an older release, let's not make their lives more difficult than it already is.
Props pento, peterwilsoncc.
See #34698 .
Built from https://develop.svn.wordpress.org/trunk@35708
git-svn-id: http://core.svn.wordpress.org/trunk@35672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 23:06:26 +00:00
John Blackbourn
8951e37f8f
Ensure the count for users with no role remains accurate when users with multiple roles are present.
...
See #34495
Built from https://develop.svn.wordpress.org/trunk@35707
git-svn-id: http://core.svn.wordpress.org/trunk@35671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 17:11:25 +00:00
Konstantin Obenland
595ade87f9
Template: Use template-loader.php
as cononical source of truth for conditional ordering.
...
Reverts [35700] which didn't account for author archives without posts.
Determination of the correct title is now based on the same order of
conditionals that template loader uses to select the right template.
H/t ocean90.
Fixes #34516 .
Built from https://develop.svn.wordpress.org/trunk@35706
git-svn-id: http://core.svn.wordpress.org/trunk@35670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 17:09:26 +00:00
John Blackbourn
c98359ddcf
Clean up the grammarian
role so it doesn't pollute other tests.
...
See #24153
Built from https://develop.svn.wordpress.org/trunk@35705
git-svn-id: http://core.svn.wordpress.org/trunk@35669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 16:47:25 +00:00
John Blackbourn
932236420c
Move the show_ui
logic into the get_edit_post_link()
and get_edit_term_link()
functions to facilitate post types and terms which specify show_ui
as false but provide a custom editing UI via the get_edit_post_link
and get_edit_term_link
filters.
...
Fixes #33763
Fixes #33938
Built from https://develop.svn.wordpress.org/trunk@35704
git-svn-id: http://core.svn.wordpress.org/trunk@35668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 16:25:26 +00:00
Helen Hou-Sandí
f6651352d9
Color picker: update to the new button style.
...
props paulwilde.
fixes #34734 .
Built from https://develop.svn.wordpress.org/trunk@35703
git-svn-id: http://core.svn.wordpress.org/trunk@35667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 14:37:33 +00:00
Gary Pendergast
53acbb936e
Embeds: Remove the allow_insecure_embeds
filter.
...
This reverts [35640]. On further reflection, it really didn't do what it said it did.
Fixes #34588 .
Built from https://develop.svn.wordpress.org/trunk@35702
git-svn-id: http://core.svn.wordpress.org/trunk@35666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 05:02:27 +00:00
Boone Gorges
f173cdfb18
On 4.4 upgrade, remove the unused 'add_users' cap from all roles.
...
Fixes #16719 .
Built from https://develop.svn.wordpress.org/trunk@35701
git-svn-id: http://core.svn.wordpress.org/trunk@35665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 03:53:28 +00:00
Konstantin Obenland
b875cd1b72
Template: Get the author name directly from $authordata
.
...
Since [25574] `$authordata` gets set up in `WP::register_globals()` - no need
to take a detour over the queried object.
Props greenshady for initial patch.
Fixes #34516 .
Built from https://develop.svn.wordpress.org/trunk@35700
git-svn-id: http://core.svn.wordpress.org/trunk@35664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-19 00:06:25 +00:00
Konstantin Obenland
3f2c4fa8d2
Media: Reset box-sizing for input elements in the entire media modal.
...
See [29727].
Props tyxla for initial patch.
Fixes #34556 .
Built from https://develop.svn.wordpress.org/trunk@35699
git-svn-id: http://core.svn.wordpress.org/trunk@35663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:36:28 +00:00
Scott Taylor
a99f7baa5a
List Tables: Fix PHP error notice when $columns
is null
...
Use of `register_column_headers()` and `print_column_headers()` creates a `_WP_List_Table_Compat` without any columns. When the List Table object doesn't have any columns, there's naturally no primary column.
Props danielbachhuber.
Fixes #34148 .
Built from https://develop.svn.wordpress.org/trunk@35698
git-svn-id: http://core.svn.wordpress.org/trunk@35662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 23:01:26 +00:00
Dominik Schilling
68f16dca18
Buttons: Update colors for disabled buttons.
...
Props hugobaeta.
Fixes #31459 .
Built from https://develop.svn.wordpress.org/trunk@35697
git-svn-id: http://core.svn.wordpress.org/trunk@35661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:47:26 +00:00
Drew Jaynes
b10a946c2c
Docs: Clarify some parameter and return descriptions in the DocBlocks for wp_get_attachment_image_srcset()
and wp_calculate_image_srcset()
, wp_get_attachment_image_sizes()
, and the wp_calculate_image_srcset
filter.
...
Props joemcgill.
See #34733 .
Built from https://develop.svn.wordpress.org/trunk@35696
git-svn-id: http://core.svn.wordpress.org/trunk@35660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:44:27 +00:00
Dominik Schilling
d1805c9da8
Customizer: Merge two similar strings.
...
Remove also `{{ data.menu_name }}` since it doesn't print anything.
Fixes #33630 .
Built from https://develop.svn.wordpress.org/trunk@35695
git-svn-id: http://core.svn.wordpress.org/trunk@35659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:25:25 +00:00
Dominik Schilling
dfd30b10b0
Customizer: Remove two unused strings.
...
Fixes #33632 .
Built from https://develop.svn.wordpress.org/trunk@35694
git-svn-id: http://core.svn.wordpress.org/trunk@35658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:12:26 +00:00
John Blackbourn
1368f7d489
Add support for oEmbeds from Speaker Deck.
...
Fixes #28597
Built from https://develop.svn.wordpress.org/trunk@35693
git-svn-id: http://core.svn.wordpress.org/trunk@35657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 22:05:25 +00:00
Jeremy Felt
f7b29ecd1b
Multisite: Re-Account for striped table rows with .site-*
classes.
...
[34356] removed the table row specificity on rules for `.site-deleted`, `.site-spammed`, `.site-archived`, and `.site-matured` so that the styles would be properly applied to other elements. Now, the zebra striping rules override these styles on even rows.
We can account for `tr` specific and more generic applications of these classes.
Fixes #33595 .
Built from https://develop.svn.wordpress.org/trunk@35692
git-svn-id: http://core.svn.wordpress.org/trunk@35656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:59:26 +00:00
Boone Gorges
b17cb707dc
Eliminate a db query when building the admin menu for non-privileged users.
...
Users who cannot `edit_posts` do not see the Comments nav item anyway, so
don't bother running a query that gets a comment count to display in the menu.
Props bordoni, johnbillion.
Fixes #19372 .
Built from https://develop.svn.wordpress.org/trunk@35691
git-svn-id: http://core.svn.wordpress.org/trunk@35655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:34:26 +00:00
Boone Gorges
31219ee677
In WP_Query
, set is_home
to false
during REST requests.
...
Props danielbachhuber.
Fixes #34373 .
Built from https://develop.svn.wordpress.org/trunk@35690
git-svn-id: http://core.svn.wordpress.org/trunk@35654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 21:18:26 +00:00
Drew Jaynes
f94f58fbb1
Embeds: Introduce print_embed_comments_button()
, print_embed_sharing_button()
, and print_embed_sharing_dialog()
, which respectively output the comments button, sharing buttons, and sharing dialog elements in the embed template.
...
This change hooks these new output functions to existing hooks in the embed template, allowing for more straightforward display control of these elements.
Leaves the embed header and footer intact pending further modularization in a future release.
Props juliobox, swissspidy, DrewAPicture.
See #34561 .
Built from https://develop.svn.wordpress.org/trunk@35689
git-svn-id: http://core.svn.wordpress.org/trunk@35653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:51:26 +00:00
Aaron Jorbin
e8d8e79371
Revert [34291] bringing back my-hacks
...
Keeping myhacks support is a small price to pay for not breaking people's sites. Even if it is very very very few sites, breaking sites isn't something that should be encouraged. Even with 10 years of deprecation notices.
https://core.trac.wordpress.org/ticket/33741#comment:18 outlines all the ways that the hack_file and my-hacks options can be setup and thus all the ways that the removal of those options could break sites.
Fixes #33741 .
Built from https://develop.svn.wordpress.org/trunk@35688
git-svn-id: http://core.svn.wordpress.org/trunk@35652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:49:26 +00:00
John Blackbourn
16502d03f2
Remove register_api_field()
from core. This is the only core function that utilises the $wp_rest_additional_fields
global, and doesn't belong as part of the infrastructure.
...
See https://github.com/WP-API/WP-API/pull/1748
Fixes #34730
Built from https://develop.svn.wordpress.org/trunk@35687
git-svn-id: http://core.svn.wordpress.org/trunk@35651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:39:26 +00:00
Sergey Biryukov
5d61c1b8d1
I18N: After [35620], move the code for standardizing on \n
line endings to Translation_Entry::key()
.
...
Props dd32.
Fixes #22172 .
Built from https://develop.svn.wordpress.org/trunk@35686
git-svn-id: http://core.svn.wordpress.org/trunk@35650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:37:25 +00:00
Dominik Schilling
c25efe2d52
Revert [35336] and [35337].
...
See #28344 .
Built from https://develop.svn.wordpress.org/trunk@35685
git-svn-id: http://core.svn.wordpress.org/trunk@35649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:30:25 +00:00
Aaron Jorbin
d507b5636f
Set cssmin compatibility to ie7
...
This matches the autoprefixer setting. This changes all compiled CSS.
Fixes #34540 .
Props christophherr, peterwilsoncc, netweb
Built from https://develop.svn.wordpress.org/trunk@35684
git-svn-id: http://core.svn.wordpress.org/trunk@35648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:28:25 +00:00
Scott Taylor
19834a4c21
List Tables: After [35622] and [34271], improve pagination logic when queries are altered.
...
Props bradyvercher.
Fixes #29870 .
Built from https://develop.svn.wordpress.org/trunk@35683
git-svn-id: http://core.svn.wordpress.org/trunk@35647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:25:26 +00:00
Scott Taylor
af0498989c
List Tables: After [34728], don't try to infer orderby
from query params.
...
List tables are really good.
Props cklosows.
Fixes #25493 .
Built from https://develop.svn.wordpress.org/trunk@35682
git-svn-id: http://core.svn.wordpress.org/trunk@35646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:19:26 +00:00
Scott Taylor
8caf5d9759
Plugins: add dismissible notices to update failures.
...
Adds unit test.
Props afercia, mehulkaklotar.
Fixes #33465 .
Built from https://develop.svn.wordpress.org/trunk@35681
git-svn-id: http://core.svn.wordpress.org/trunk@35645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 20:10:26 +00:00
Boone Gorges
68b8f41780
Allow filtering by non-public taxonomies on edit.php.
...
[35333] enforces protection for taxonomies by preventing non-public taxonomies
from registering query_vars in `register_taxonomy()`. This broke the use of
taxonomy query_vars on edit.php, breaking backward compatibility and
creating inconsistency with the treatment introduced in [34247], which allowed
`taxonomy=foo` filtering on the Dashboard, even when `foo` is non-public. In
this changeset, we make the same Dashboard exception for the query_var.
Fixes #21949 .
Built from https://develop.svn.wordpress.org/trunk@35680
git-svn-id: http://core.svn.wordpress.org/trunk@35644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:59:49 +00:00
Scott Taylor
af0282891d
Rewrite: alleviate conflicts between image attachment pages and posts when permalink structure is /%postname%/
.
...
Adds unit test.
Props SergeyBiryukov.
Fixes #24612 .
Built from https://develop.svn.wordpress.org/trunk@35679
git-svn-id: http://core.svn.wordpress.org/trunk@35643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:59:25 +00:00
Scott Taylor
13ea469061
Media: when making images responsive, check if they already have a sizes
attribute.
...
Adds unit test.
Props jaspermdegroot.
Fixes #34678 .
Built from https://develop.svn.wordpress.org/trunk@35678
git-svn-id: http://core.svn.wordpress.org/trunk@35642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:48:26 +00:00
Scott Taylor
f2e9e98fa6
Media: in media_send_to_editor()
, use wp_json_encode()
instead of addslashes()
.
...
Props TobiasBg.
Fixes #22135 .
Built from https://develop.svn.wordpress.org/trunk@35677
git-svn-id: http://core.svn.wordpress.org/trunk@35641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:40:27 +00:00
Scott Taylor
a9fb6e9ae0
Customizer i18n: provide translator context for current menu name and location.
...
Props ryankienstra.
Fixes #33431 .
Built from https://develop.svn.wordpress.org/trunk@35676
git-svn-id: http://core.svn.wordpress.org/trunk@35640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:21:28 +00:00
Scott Taylor
f1d0763785
Comments: after [35593], extend support to IE8 and improve checking for elements hidden with CSS
...
Props afercia.
Fixes #29974 .
Built from https://develop.svn.wordpress.org/trunk@35675
git-svn-id: http://core.svn.wordpress.org/trunk@35639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-11-18 19:15:28 +00:00