Weston Ruter
a4bc3daa9e
Customizer: Update nav_menu_locations[...]
controls to remove placeholder menus from the dropdown options upon Save & Publish.
...
See #32814 .
Fixes #33176 .
Built from https://develop.svn.wordpress.org/trunk@33496
git-svn-id: http://core.svn.wordpress.org/trunk@33463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 19:34:25 +00:00
Mark Jaquith
61dd2bfdde
Persist (and mask) the password on the install screen if the install does not proceed due to errors.
...
If you forget or enter an invalid username/e-mail, the password choosing shouldn't start over.
fixes #33162
Built from https://develop.svn.wordpress.org/trunk@33495
git-svn-id: http://core.svn.wordpress.org/trunk@33462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 19:22:26 +00:00
Dominik Schilling
8679a93f16
Themes: Remove legacy theme preview.
...
The pre-3.4 theme previewer doesn't work when using a static front page.
We kept the old theme preview for no-JS and some browsers that were less capable. But since browsers are doing a better job today we don't need to continue fixing/shipping this legacy code. Bye!
fixes #33178 .
Built from https://develop.svn.wordpress.org/trunk@33492
git-svn-id: http://core.svn.wordpress.org/trunk@33459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 18:36:26 +00:00
Weston Ruter
bf9d1485ee
Customizer: Ensure that all existing menus are shown in the Custom Menu widget's dropdown.
...
* Ensure that a Custom Menu widget selecting a newly-inserted menu gets updated to use the new menu ID upon Save & Publish.
* Dynamically update the visibility of the Custom Menu widget's "no menus" message when the number of menus changes between 0 and 1+.
* Send all dirty Customized settings in `update-widget` Ajax request and `preview()` them so that the widget update/form callbacks have access to any data dependencies in the current Customizer session (such as newly created unsaved menus).
* Update link in Custom Menu widget to point to Menus panel as opposed to Menus admin page, when in the Customizer.
* Fix an issue with extra space at top immediately after creating new menu.
* Fix doubled `update-widget` Ajax requests when changing select dropdown; prevent initial from being aborted.
* Add missing `wp_get_nav_menus()` hooks to preview Customizer updates/inserts for `nav_menu` settings; includes tests.
* Update `wp_get_nav_menu_object()` to allow a menu object to be passed in (and thus passed through).
Props westonruter, adamsilverstein.
Fixes #32814 .
Built from https://develop.svn.wordpress.org/trunk@33488
git-svn-id: http://core.svn.wordpress.org/trunk@33455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 16:03:24 +00:00
Dominik Schilling
a5ed94ab62
Customizer: Add an aria-expanded
attribute to Edit menu item toggles.
...
props afercia.
fixes #33129 .
Built from https://develop.svn.wordpress.org/trunk@33483
git-svn-id: http://core.svn.wordpress.org/trunk@33450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 09:50:24 +00:00
Mark Jaquith
bca4465edf
Do not re-generate the password after pressing "cancel". Persist the state.
...
Also removes pass2 code not needed since we're generating from one field.
fixes #33164
Built from https://develop.svn.wordpress.org/trunk@33475
git-svn-id: http://core.svn.wordpress.org/trunk@33442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 04:30:24 +00:00
Mark Jaquith
0217951e44
Re-work user-profile.js so the password meter works in IE8 and password managers can fill multiple times.
...
props adamsilverstein
fixes #32886
Built from https://develop.svn.wordpress.org/trunk@33473
git-svn-id: http://core.svn.wordpress.org/trunk@33440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-29 03:27:25 +00:00
Andrew Ozz
fa25fe82ef
Fix updating of nonces on the Edit Post screen after the log in expires and the user logs in again.
...
Props iseulde, azaozz. Fixes #33098 .
Built from https://develop.svn.wordpress.org/trunk@33468
git-svn-id: http://core.svn.wordpress.org/trunk@33435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 22:07:25 +00:00
Mark Jaquith
959f36699b
Lose the clunky setTimeout()
code and just track the password value changes.
...
see #32886
Built from https://develop.svn.wordpress.org/trunk@33465
git-svn-id: http://core.svn.wordpress.org/trunk@33432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 21:11:26 +00:00
Sergey Biryukov
96e340b33a
Plugins list table: Make selector for Details links more specific to prevent the Description header from being announced as "clickable".
...
props afercia.
fixes #32968 .
Built from https://develop.svn.wordpress.org/trunk@33462
git-svn-id: http://core.svn.wordpress.org/trunk@33429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 14:50:25 +00:00
Weston Ruter
a48604e32c
Customizer: Hide empty space in footer on small screens since it is only populated on larger screens.
...
Props obenland.
Fixes #33138 .
Built from https://develop.svn.wordpress.org/trunk@33454
git-svn-id: http://core.svn.wordpress.org/trunk@33421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-28 03:43:24 +00:00
Scott Taylor
d92795db13
Passwords UI: clean up the new JS in wp-admin/js/user-profile.js
.
...
Instead of wrapping `#pass1` in a `<span>` dynamically, add the `<span>` to the HTML in PHP. It currently has no styling.
Fixes #33145 .
Built from https://develop.svn.wordpress.org/trunk@33450
git-svn-id: http://core.svn.wordpress.org/trunk@33417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 21:25:25 +00:00
Konstantin Obenland
94aefe52dc
Customizer: Use correct spelling when instantiating CustomizeImageCropper
.
...
Introduced in [33329].
Built from https://develop.svn.wordpress.org/trunk@33445
git-svn-id: http://core.svn.wordpress.org/trunk@33412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 15:55:24 +00:00
Ella Iseulde Van Dorpe
491c863f35
Editor: word count: better names for types.
...
Also fix it in wp_trim_words().
Fixes #30966 .
Built from https://develop.svn.wordpress.org/trunk@33440
git-svn-id: http://core.svn.wordpress.org/trunk@33407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 11:19:26 +00:00
Mark Jaquith
5abcb6938c
Toggle between dashicons-hidden and dashicons-visibility in the password hide/show button.
...
fixes #33135
Built from https://develop.svn.wordpress.org/trunk@33438
git-svn-id: http://core.svn.wordpress.org/trunk@33405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-27 03:13:24 +00:00
Sergey Biryukov
93baee020c
Comment status box: Move focus back to Edit link when changing the date.
...
props afercia.
fixes #33062 .
Built from https://develop.svn.wordpress.org/trunk@33422
git-svn-id: http://core.svn.wordpress.org/trunk@33390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-26 02:26:24 +00:00
Dominik Schilling
de86d6b18d
Customizer: Add missing text or labels to some nav menu UI controls.
...
props afercia, celloexpressions, westonruter.
fixes #32715 .
Built from https://develop.svn.wordpress.org/trunk@33413
git-svn-id: http://core.svn.wordpress.org/trunk@33381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-24 20:28:25 +00:00
Dominik Schilling
edf256fa96
Customizer: Hide inactive reorder buttons for menu items from assistive technologies.
...
props afercia.
fixes #33114 .
Built from https://develop.svn.wordpress.org/trunk@33412
git-svn-id: http://core.svn.wordpress.org/trunk@33380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-24 17:57:24 +00:00
Weston Ruter
3a97d2a7de
Customizer: Update JS variable to reference renamed data attribute for available nav menu object.
...
Fixes regression for a change that was missed in [33366].
Props valendesigns.
Fixes #32708 .
Built from https://develop.svn.wordpress.org/trunk@33392
git-svn-id: http://core.svn.wordpress.org/trunk@33360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-23 06:02:24 +00:00
Mark Jaquith
9682eb0108
Do not propagate empty passwords from the hidden form field.
...
fixes #32886
Built from https://develop.svn.wordpress.org/trunk@33384
git-svn-id: http://core.svn.wordpress.org/trunk@33353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-23 05:00:25 +00:00
Weston Ruter
d5ce83c94c
Customizer: Introduce customize_nav_menu_available_item_types
and customize_nav_menu_available_items
filters.
...
Allows for new available menu item types/objects to be registered in addition to filtering the available items that are returned for each menu item type/object.
Props valendesigns, imath, westonruter.
See #32832 .
Fixes #32708 .
Built from https://develop.svn.wordpress.org/trunk@33366
git-svn-id: http://core.svn.wordpress.org/trunk@33338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 20:29:25 +00:00
Mark Jaquith
31ca0cd939
Soothe JSHint's rankled spirits
...
Built from https://develop.svn.wordpress.org/trunk@33365
git-svn-id: http://core.svn.wordpress.org/trunk@33337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 18:56:26 +00:00
Mark Jaquith
1ef40251b9
Introduce a Cancel button and onUnload warning for password changes.
...
fixes #33079
props johnjamesjacoby
Built from https://develop.svn.wordpress.org/trunk@33364
git-svn-id: http://core.svn.wordpress.org/trunk@33336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 18:36:24 +00:00
Mark Jaquith
ae03a8a0a2
Make password field toggling work in IE8, and clean up a bunch of password CSS issues.
...
fixes #32886
props peterwilsoncc, adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@33362
git-svn-id: http://core.svn.wordpress.org/trunk@33334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 16:56:27 +00:00
Konstantin Obenland
0f61e187b6
Site Icon: Create custom sizes for images that don't need cropping.
...
This will duplicate an image that doesn't need cropping once and will skip
creating new images and custom sizes if the selected image has the `site-icon`
context.
Fixes #33011 .
Built from https://develop.svn.wordpress.org/trunk@33356
git-svn-id: http://core.svn.wordpress.org/trunk@33328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 02:30:25 +00:00
Andrew Ozz
e5340ea63f
Widgets screen: while dragging a widget over a closed sidebar refresh only the widgets in the current sidebar instead of all widgets in all sidebars.
...
Props chriscct7. Fixes #33015 .
Built from https://develop.svn.wordpress.org/trunk@33354
git-svn-id: http://core.svn.wordpress.org/trunk@33326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 01:25:26 +00:00
Konstantin Obenland
45bfab3aa8
Passwords: Add password strength meter feedback for screen readers.
...
Also gives context to the show/hide button.
Props rianrietveld, afercia.
Fixes #33032 .
Built from https://develop.svn.wordpress.org/trunk@33353
git-svn-id: http://core.svn.wordpress.org/trunk@33325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-22 00:15:25 +00:00
Ella Iseulde Van Dorpe
482f174f2e
Publish box: move focus when the animation is done
...
Also move the focus back to 'edit' when saving changes.
Props afercia.
Fixes #33060 .
Built from https://develop.svn.wordpress.org/trunk@33352
git-svn-id: http://core.svn.wordpress.org/trunk@33324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:46:24 +00:00
Ella Iseulde Van Dorpe
253d9db831
Publish box: focus first date field on edit
...
The order of the fields may change depending on the translation.
Props afercia.
Fixes #33059 .
Built from https://develop.svn.wordpress.org/trunk@33349
git-svn-id: http://core.svn.wordpress.org/trunk@33321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:23:24 +00:00
Ella Iseulde Van Dorpe
d827a71c7f
Publish box: apply changes post.js to comment.js
...
See [22250], [27035], [24046], [33340] and [33341].
Fixes #33063 .
Built from https://develop.svn.wordpress.org/trunk@33348
git-svn-id: http://core.svn.wordpress.org/trunk@33320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 22:09:25 +00:00
Konstantin Obenland
146befe7bf
Customizer: Add label for menu names when editing a menu.
...
Props celloexpressions.
Fixes #32726 .
Built from https://develop.svn.wordpress.org/trunk@33346
git-svn-id: http://core.svn.wordpress.org/trunk@33318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 17:02:24 +00:00
Ella Iseulde Van Dorpe
50159974c9
Editor: word count: exclude HTML comments and entities
...
Also make sure `type` is one of the three allowed types and remove unnecessary regex flags.
See #30966 .
Built from https://develop.svn.wordpress.org/trunk@33344
git-svn-id: http://core.svn.wordpress.org/trunk@33316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 15:24:24 +00:00
Ella Iseulde Van Dorpe
52f6aebdaa
Publish box: fix leading zeros in date format
...
See #30716 .
Built from https://develop.svn.wordpress.org/trunk@33341
git-svn-id: http://core.svn.wordpress.org/trunk@33313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 14:55:24 +00:00
Ella Iseulde Van Dorpe
262c1a7e54
Publish box: fix strange date format after change
...
Part props tyxla.
Fixes #30716 .
Built from https://develop.svn.wordpress.org/trunk@33340
git-svn-id: http://core.svn.wordpress.org/trunk@33312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 11:40:25 +00:00
Dominik Schilling
4dcfd3ec83
Customizer: Avoid duplicate IDs and remove role presentation from menu items reorder button. Follow-up to [33074].
...
props afercia.
fixes #32725 .
Built from https://develop.svn.wordpress.org/trunk@33339
git-svn-id: http://core.svn.wordpress.org/trunk@33311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-21 11:37:26 +00:00
Ella Iseulde Van Dorpe
1d92ed1c79
JSHint: don't redeclare globals listed in .jshintrc
...
See #33021 .
Built from https://develop.svn.wordpress.org/trunk@33337
git-svn-id: http://core.svn.wordpress.org/trunk@33309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 23:39:24 +00:00
Konstantin Obenland
0ccb9c47cb
Site Icon: Center initial crop position.
...
Starting out at the center of the image makes for a better user experience.
Props iseulde.
Fixes #33050 .
Built from https://develop.svn.wordpress.org/trunk@33333
git-svn-id: http://core.svn.wordpress.org/trunk@33305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 19:02:24 +00:00
Konstantin Obenland
3248497cf3
Site Icon: Add crop preview to the media modal.
...
* Monkey patches imgAreaSelect library to support touch events.
* Removes Settings version of Site Icon since it would have been the same flow.
* Removes default value for Customizer setting - there is no default favicon.
Fixes #16434 .
Built from https://develop.svn.wordpress.org/trunk@33329
git-svn-id: http://core.svn.wordpress.org/trunk@33301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-20 15:57:25 +00:00
Andrew Nacin
2166b4a6c1
JSHint: Use 'global' rather than 'globals' for inline configuration.
...
Don't declare a global already listed in .jshintrc.
props johnjamesjacoby.
fixes #33021 .
Built from https://develop.svn.wordpress.org/trunk@33324
git-svn-id: http://core.svn.wordpress.org/trunk@33296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 17:09:26 +00:00
Weston Ruter
910092531b
Customizer: Indicate when there are no nav menu items available for a given type.
...
Props celloexpressions, valendesigns, rittesh.patel.
Fixes #32810 .
Built from https://develop.svn.wordpress.org/trunk@33323
git-svn-id: http://core.svn.wordpress.org/trunk@33295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-19 00:06:24 +00:00
Ella Iseulde Van Dorpe
e9b6d25bcd
Editor: word count: count astrals as one character
...
This makes sure an emoji, for example, is counted as one character.
See #30966 .
Built from https://develop.svn.wordpress.org/trunk@33320
git-svn-id: http://core.svn.wordpress.org/trunk@33292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-18 11:42:25 +00:00
Ella Iseulde Van Dorpe
f00d1e63f1
Editor: word count: exclude shortcodes
...
Props desaiuditd, adamsilverstein, azaozz and iseulde.
Fixes #27386 . See #30966 .
Built from https://develop.svn.wordpress.org/trunk@33299
git-svn-id: http://core.svn.wordpress.org/trunk@33271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 21:09:26 +00:00
Ella Iseulde Van Dorpe
e098c0e9ee
Editor: word count: exclude more characters
...
Also only exclude these characters for the `words` type. They should be counted for other types.
Add the ASCIIOnly option to the uglify config to preserve escaped unicode characters.
See #30966 . Fixes #27391 .
Built from https://develop.svn.wordpress.org/trunk@33292
git-svn-id: http://core.svn.wordpress.org/trunk@33264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-16 09:45:26 +00:00
Ella Iseulde Van Dorpe
bbccb9ca6b
Editor: word count: add all
type
...
This type will count all characters including spaces.
See #30966 .
Built from https://develop.svn.wordpress.org/trunk@33290
git-svn-id: http://core.svn.wordpress.org/trunk@33262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 23:48:24 +00:00
Weston Ruter
0f37c66077
Customizer: Defer updating nav menu item tabIndex
attributes until pane is reflowed.
...
Introduces `pane-contents-reflowed` Customizer event.
Props valendesigns, westonruter.
Fixes #32943 .
Built from https://develop.svn.wordpress.org/trunk@33283
git-svn-id: http://core.svn.wordpress.org/trunk@33255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 20:05:25 +00:00
Weston Ruter
4cb73cf347
Customizer: Fix element focus after menu item is deleted for keyboard accessibility.
...
Also restores box shadow on focus.
Props valendesigns.
Fixes #32740 .
Built from https://develop.svn.wordpress.org/trunk@33279
git-svn-id: http://core.svn.wordpress.org/trunk@33251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-15 18:44:25 +00:00
Konstantin Obenland
e4305c7b28
Passwords: Make show/hide toggle translatable.
...
See #32589 .
Built from https://develop.svn.wordpress.org/trunk@33249
git-svn-id: http://core.svn.wordpress.org/trunk@33221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 22:35:24 +00:00
Weston Ruter
ae50d09585
Customizer: Disambiguate a menu's auto-add pages option from preceding menu location checkboxes.
...
Creates a separate `nav_menu_auto_add` control type following the pattern of the `nav_menu_name` control type.
Props valendesigns.
Fixes #32820 .
Built from https://develop.svn.wordpress.org/trunk@33189
git-svn-id: http://core.svn.wordpress.org/trunk@33161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-13 08:40:26 +00:00
Dominik Schilling
153511f78f
Password UI: The non-breaking space doesn't need to be translatable. Add some context to password strength strings.
...
see #32589 .
Built from https://develop.svn.wordpress.org/trunk@33166
git-svn-id: http://core.svn.wordpress.org/trunk@33138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-11 20:48:24 +00:00
Konstantin Obenland
f29e5044cd
Site Icon: Add Customizer UI.
...
Second part of the Site Icon feature after [32994] introduced it for Settings.
Props celloexpressions.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33154
git-svn-id: http://core.svn.wordpress.org/trunk@33126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:33:24 +00:00
Dominik Schilling
75d6c10b01
Customizer: Use a <button>
for the collapse sidebar … button.
...
props afercia.
fixes #32819 .
Built from https://develop.svn.wordpress.org/trunk@33153
git-svn-id: http://core.svn.wordpress.org/trunk@33125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-10 21:22:26 +00:00
Helen Hou-Sandí
0b046085ae
Show row actions on focus for the dashboard comment list.
...
see #25408 .
Built from https://develop.svn.wordpress.org/trunk@33106
git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:26:24 +00:00
Weston Ruter
a62cc940ea
Customizer: Register controls and settings for nav_menu_locations
even when there are no menus yet.
...
This change ensures that the first menu created can be assigned to a location without first saving and reloading the Customizer.
Props markoheijnen.
Fixes #32858 .
Built from https://develop.svn.wordpress.org/trunk@33094
git-svn-id: http://core.svn.wordpress.org/trunk@33065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 19:13:25 +00:00
Andrew Ozz
b2e725eb27
Fix opening closed widget areas when dragging a widget over them.
...
Props polevaultweb. Fixes #13524 .
Built from https://develop.svn.wordpress.org/trunk@33088
git-svn-id: http://core.svn.wordpress.org/trunk@33059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 18:20:24 +00:00
Dominik Schilling
340f1e121e
Customizer: Fix tabindex
of reorder buttons for menu items with depth 1 and 10.
...
props celloexpressions.
fixes #32767 .
Built from https://develop.svn.wordpress.org/trunk@33077
git-svn-id: http://core.svn.wordpress.org/trunk@33048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 22:21:24 +00:00
Konstantin Obenland
cf22cd7d72
Site Icon: Remove date dropdown from media modal.
...
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.
Props ocean90.
Fixes #32860 .
Built from https://develop.svn.wordpress.org/trunk@33075
git-svn-id: http://core.svn.wordpress.org/trunk@33046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:28:24 +00:00
Dominik Schilling
200463d781
Customizer: Improve descriptive text and focus for menu items reorder button.
...
props afercia.
fixes #32725 .
Built from https://develop.svn.wordpress.org/trunk@33074
git-svn-id: http://core.svn.wordpress.org/trunk@33045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:24:25 +00:00
Weston Ruter
912b434198
Customizer: Fix saving menus with empty names or names that are already used.
...
Adds validation for initially-supplied nav menu name, blocking empty names from being supplied. If later an empty name is supplied and the nav menu is saved, the name "(unnamed)" will be supplied instead and supplied back to the client. If a name is supplied for the menu which is currently used by another menu, then the name conflict is resolved by adding a numerical counter similar to how `post_name` conflicts are resolved. Includes unit tests.
Fixes #32760 .
Built from https://develop.svn.wordpress.org/trunk@33071
git-svn-id: http://core.svn.wordpress.org/trunk@33042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:47:25 +00:00
Dominik Schilling
93a334b361
Customizer: Remove some non-functional code.
...
props afercia.
fixes #32839 .
Built from https://develop.svn.wordpress.org/trunk@33070
git-svn-id: http://core.svn.wordpress.org/trunk@33041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:37:25 +00:00
Dominik Schilling
2ce8d2eea2
Customizer: Accessibility enhancements.
...
* Move tabindex/focus code into `onChangeExpanded` so that it works for cases where `expand()` is called directly.
* Use `visibility: hidden` to hide hidden elements from keyboard focus and screen readers.
props celloexpressions.
fixes #31336 .
Built from https://develop.svn.wordpress.org/trunk@33069
git-svn-id: http://core.svn.wordpress.org/trunk@33040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 20:19:25 +00:00
Konstantin Obenland
2f383536fc
Check if commentReply
exists before trying to work with it.
...
Fixes a bug that caused the save/publish flow to be interrupted by an AYS.
Introduced in [33024].
See #29457 .
Built from https://develop.svn.wordpress.org/trunk@33066
git-svn-id: http://core.svn.wordpress.org/trunk@33037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 15:32:25 +00:00
Ella Iseulde Van Dorpe
12fba44414
Editor: refresh word count quicker
...
2 seconds is a bit slow. Debouncing with 1 second means it can only run maximum once per second. In reality it won't run us much. Even people who type slow will usually type faster than 1 character per second.
See #30966 .
Built from https://develop.svn.wordpress.org/trunk@33060
git-svn-id: http://core.svn.wordpress.org/trunk@33031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 09:15:24 +00:00
Helen Hou-Sandí
f85306c65a
Toolbar: Allow submenus to be closed with a second tap on touch devices.
...
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.
props stephdau, seanchayes.
see #29906 .
Built from https://develop.svn.wordpress.org/trunk@33056
git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Konstantin Obenland
cd7a40bdc7
Site Icon: Improve responsiveness for small screen devices.
...
Using Jcrop's `trueSize` argument also allows us to get rid of all that behind
the scenes temp image creating and back and forth calculating of image sizes.
Props tyxla for initial patch.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33053
git-svn-id: http://core.svn.wordpress.org/trunk@33024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 21:16:24 +00:00
Konstantin Obenland
bcf488fc23
Site Icon: Show correct background preview for transparent images.
...
iOS will show transparent parts as black, where as the icon itself stays
transparent when used as a favicon.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@33049
git-svn-id: http://core.svn.wordpress.org/trunk@33020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-02 17:16:26 +00:00
Mark Jaquith
504101460f
Slow down on calling zxcvbn if it isn't loaded.
...
see #32589
Built from https://develop.svn.wordpress.org/trunk@33033
git-svn-id: http://core.svn.wordpress.org/trunk@33004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 18:13:24 +00:00
Mark Jaquith
cb93e24c62
Add a missing "var". see #32589
...
Built from https://develop.svn.wordpress.org/trunk@33031
git-svn-id: http://core.svn.wordpress.org/trunk@33002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 17:16:25 +00:00
Dominik Schilling
78167b8a4c
Customizer: Make reordering menu items via drag and drop easier.
...
Introduce `wpNavMenu.options.targetTolerance` to define a tolerance when dragging items where no margins between the sortable items exists.
props adamsilverstein.
fixes #32821 .
Built from https://develop.svn.wordpress.org/trunk@33030
git-svn-id: http://core.svn.wordpress.org/trunk@33001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 16:44:24 +00:00
Konstantin Obenland
d03ff4b3d9
Close comment quick edit before updating a post.
...
Fixes a bug where the user gets redirected to the All Posts screen, after
updating a post while quick editing a comment.
Props polevaultweb.
Fixes #29457 .
Built from https://develop.svn.wordpress.org/trunk@33024
git-svn-id: http://core.svn.wordpress.org/trunk@32995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:54:24 +00:00
Mark Jaquith
423a1a7ca4
New password change/set UI.
...
* Generate the password for the user
* More tightly integrate password strength meter
* Warn on weak passwords
see #32589
props MikeHansenMe, adamsilverstein, binarykitten
Built from https://develop.svn.wordpress.org/trunk@33023
git-svn-id: http://core.svn.wordpress.org/trunk@32994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 14:48:24 +00:00
Helen Hou-Sandí
8eb7f71e6b
List tables: A better responsive view.
...
Instead of truncating columns, the data that's already in the markup can now be toggled into view. Only seems appropriate to celebrate four years of contributing by finally doing the first thing I ever mocked up.
Known issues / concerns:
* Custom list tables that don't define a primary column will show nothing at all. These are not extremely common, as `WP_List_Table` isn't really recommended for plugin consumption, but it happens. We need to come up with some kind of fallback.
* Some visual elements, particularly whitespace, could use refining.
* Needs a11y review.
* Touch performance on iOS feels sluggish - is there anything we can do about that?
* Would this be better accordion-style (only one expanded at a time)?
* Is `wp_strip_all_tags()` good enough for column titles that have HTML in them? It's essentially a workaround for the fact that core's comments column does that for the icon, which maybe it shouldn't. Perhaps worth another ticket, as a markup change would be fairly independent.
* Visual hierarchy is not great when expanded (also worthy of another ticket).
* Quick edit now becomes noticeably more annoying to cancel out of, as you have to scroll all the way down and you lose your position from before it was opened. Again, worthy of another ticket.
props Michael Arestad, helen.
see #32395 .
Built from https://develop.svn.wordpress.org/trunk@33016
git-svn-id: http://core.svn.wordpress.org/trunk@32987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:31:25 +00:00
Helen Hou-Sandí
8f85bb1ac5
Bulk/quick edit: Set the correct colspan.
...
`thead` can contain `td`s now, too.
props afercia.
fixes #31654 .
Built from https://develop.svn.wordpress.org/trunk@33015
git-svn-id: http://core.svn.wordpress.org/trunk@32986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 01:06:25 +00:00
Konstantin Obenland
e460d37da0
Open closed widget areas when dragging onto them.
...
Allows dropping Widgets into the correct spot of a given sidebar, no matter
whether that sidebar is open or closed. Removes a step from the setup process
for closed sidebars.
Props polevaultweb.
Fixes #13524 .
Built from https://develop.svn.wordpress.org/trunk@33014
git-svn-id: http://core.svn.wordpress.org/trunk@32985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-01 00:58:24 +00:00
Andrew Ozz
b092defb17
Press This:
...
- Add support for the Text editor.
- Add auto-scrolling when the caret moves out of the viewport while the user is typing (similarly to editor-expand).
- Add auto-resize for the textarea.
See #32706 .
Built from https://develop.svn.wordpress.org/trunk@32999
git-svn-id: http://core.svn.wordpress.org/trunk@32970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 03:58:27 +00:00
Konstantin Obenland
c56a8ae0f7
Introducing Site Icon, favicon management for WordPress.
...
This v1 marries Jetpack's Site Icon module with the Media Modal, reusing code
from the Custom Header admin. For now, the core-provided icons will be limited
to a favicon, an iOS app icon, and a Windows tile icon, leaving `.ico` support
and additional icons to plugins to add.
Props obenland, tyxla, flixos90, jancbeck, markjaquith, scruffian.
See #16434 .
Built from https://develop.svn.wordpress.org/trunk@32994
git-svn-id: http://core.svn.wordpress.org/trunk@32965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-29 12:58:25 +00:00
Aaron Jorbin
c9307fc95a
Update Grunt dev-dependencies
...
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).
Props wonderboymusic
See #31700
Built from https://develop.svn.wordpress.org/trunk@32988
git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
Aaron Jorbin
4bbf254375
Add missing semicolon
...
Introduced in [32983].
see #32757 .
Built from https://develop.svn.wordpress.org/trunk@32986
git-svn-id: http://core.svn.wordpress.org/trunk@32957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 11:41:24 +00:00
Andrew Ozz
275fc220ef
Press This:
...
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32983
git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:59:24 +00:00
Weston Ruter
e162bb8940
Customizer: Improve previewing setting changes for show_on_front
, page_on_front
, and page_for_posts
.
...
When changing the `page_on_front` setting (with `show_on_front`), change the previewed URL to be the home URL so that the effect can be seen. When changing `page_for_posts`, change the previewed URL to be the selected page.
Props valendesigns, westonruter.
Fixes #30677 .
Built from https://develop.svn.wordpress.org/trunk@32976
git-svn-id: http://core.svn.wordpress.org/trunk@32947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 19:59:25 +00:00
Konstantin Obenland
7dc1d06e64
Proper heading for admin screens.
...
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.
Props joedolson, afercia.
Fixes #31650 .
Built from https://develop.svn.wordpress.org/trunk@32974
git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Dominik Schilling
2ecb586214
Customizer: Add an aria-expanded
attribute to the Add Menu button to improve accessibility.
...
props afercia.
fixes #32791 .
Built from https://develop.svn.wordpress.org/trunk@32971
git-svn-id: http://core.svn.wordpress.org/trunk@32942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 10:05:24 +00:00
Andrew Ozz
7715a50c0b
Press This: fix iOS bug that prevents closing of the split button when tapping outside of it.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32966
git-svn-id: http://core.svn.wordpress.org/trunk@32937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 02:15:24 +00:00
Dominik Schilling
a6b7a691be
Customizer: Prevent dragging menu items above the main heading.
...
Improve targeting for the `sortableItems`, resolving an issue where the first `<li>` in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.
props adamsilverstein.
fixes #32738 .
#wceu
Built from https://develop.svn.wordpress.org/trunk@32955
git-svn-id: http://core.svn.wordpress.org/trunk@32926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 17:11:24 +00:00
Andrew Ozz
f4109b0c5d
Press This: convert the Preview | Save | Publish buttons to a split button.
...
See #32757 .
Built from https://develop.svn.wordpress.org/trunk@32920
git-svn-id: http://core.svn.wordpress.org/trunk@32891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 02:46:27 +00:00
Andrew Ozz
e4758f42e5
Update the TinyMCE initialization:
...
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425 .
Built from https://develop.svn.wordpress.org/trunk@32899
git-svn-id: http://core.svn.wordpress.org/trunk@32870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-21 22:01:28 +00:00
Dominik Schilling
baeadbb6fb
Customizer: Accessibility improvements for menu item searches.
...
* Add a description and an `aria-describedby` attribute to inform users this is a "live" search.
* Announce the number of search results via `wp.a11y.speak`.
* Use `aria-busy` attribute to stop screen readers announcing content while the "loading more results" is running.
* Increase the search debounce wait interval to 500ms to be consistent with other live searches.
* If a search fails don't call `wp.a11y.speak` with an undefined variable.
props afercia.
see #32720 .
Built from https://develop.svn.wordpress.org/trunk@32891
git-svn-id: http://core.svn.wordpress.org/trunk@32862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:22:25 +00:00
Dominik Schilling
4a13015c98
Customizer: Don't add a menu item twice when using the keyboard.
...
Buttons don't need keyboard events, they natively support keyboard interaction and they just need a click event.
fixes #32665 .
Built from https://develop.svn.wordpress.org/trunk@32890
git-svn-id: http://core.svn.wordpress.org/trunk@32861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:01:25 +00:00
Scott Taylor
86beb35f6d
Use <button>
instead of <a>
for non-link links in Quick Edit.
...
Props afercia.
Fixes #32213 .
Built from https://develop.svn.wordpress.org/trunk@32869
git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:42:27 +00:00
Konstantin Obenland
4e7c057a5a
Check that current changes can be lost before editing another comment.
...
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.
Props pareshradadiya, chriscct7.
Fixes #21845 .
Built from https://develop.svn.wordpress.org/trunk@32857
git-svn-id: http://core.svn.wordpress.org/trunk@32828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 13:48:25 +00:00
Ella Iseulde Van Dorpe
fd95002b2a
Editor: restructure word count
...
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.
See #30966 . Fixes #26620 .
Built from https://develop.svn.wordpress.org/trunk@32856
git-svn-id: http://core.svn.wordpress.org/trunk@32827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 10:35:26 +00:00
Dominik Schilling
f5fa907f77
Customizer: Improve accessibility of Add Menu Items button and its panel.
...
props afercia, ocean90.
fixes #32682 .
Built from https://develop.svn.wordpress.org/trunk@32848
git-svn-id: http://core.svn.wordpress.org/trunk@32819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 20:52:24 +00:00
Konstantin Obenland
c1a9c4b7b8
Semanticize Help and Screen Options toggle.
...
Links used as UI controls that are not real links but act as buttons, should be buttons.
Props afercia.
Fixes #32494 .
Built from https://develop.svn.wordpress.org/trunk@32844
git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 16:36:25 +00:00
Andrew Ozz
bc2630e099
Press This: Check the embeds list against all of the oembed providers.
...
Props stephdau. Fixes #32069 .
Built from https://develop.svn.wordpress.org/trunk@32828
git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 00:12:26 +00:00
Dominik Schilling
5864a7ad44
Customizer: Fix keyboard events for the menu items search field.
...
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.
props tywayne.
fixes #32677 .
Built from https://develop.svn.wordpress.org/trunk@32824
git-svn-id: http://core.svn.wordpress.org/trunk@32795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:37:27 +00:00
Ella Iseulde Van Dorpe
1a4c6ad45d
JSHint after [32806]
...
See #32576 .
Built from https://develop.svn.wordpress.org/trunk@32815
git-svn-id: http://core.svn.wordpress.org/trunk@32786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 04:15:26 +00:00
Dominik Schilling
ac33d71623
Fix a typo in [32806].
...
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32808
git-svn-id: http://core.svn.wordpress.org/trunk@32779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 23:09:25 +00:00
Dominik Schilling
62e3a0c15c
Add menu management to the Customizer.
...
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/ .
props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32806
git-svn-id: http://core.svn.wordpress.org/trunk@32777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 22:08:26 +00:00
Dion Hulse
629545aaf5
Updates: When an update fails (and it's not during the credential form) allow further updates to continue, with the assumption that the error only affects a single plugin.
...
Props magicroundabout. Fixes #32110 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32780
git-svn-id: http://core.svn.wordpress.org/trunk@32751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 04:28:25 +00:00
Dion Hulse
6eef8a8ff2
Updates: Display the failure reason in addition to 'Update Failed', allows for debugging by site owners.
...
Fixes #32435 , #32473
Built from https://develop.svn.wordpress.org/trunk@32779
git-svn-id: http://core.svn.wordpress.org/trunk@32750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:48:28 +00:00
Dion Hulse
04325cd834
Updates: Better handling when the credential form is long (such as when SSH is active). This adds scrolling to the dialogue, and hides the SSH-specific fields when not using the SSH handler.
...
See #32435
Built from https://develop.svn.wordpress.org/trunk@32777
git-svn-id: http://core.svn.wordpress.org/trunk@32748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-15 03:20:28 +00:00