Sergey Biryukov
aed608b98c
Coding Standards: Remove a one-time $message
variable in WordPress version requirement notices for bundled themes.
...
This makes the formatting of these messages more consistent.
Follow-up to [23816], [51154].
See #52627 .
Built from https://develop.svn.wordpress.org/trunk@51155
git-svn-id: http://core.svn.wordpress.org/trunk@50764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-06-15 15:24:58 +00:00
ryelle
1cef3d1812
Bundled Themes: Introduce block patterns for Twenty Fifteen.
...
Props melchoyce, kjellr, onemaggie.
Fixes #51102 .
Built from https://develop.svn.wordpress.org/trunk@51043
git-svn-id: http://core.svn.wordpress.org/trunk@50652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-05-28 17:21:05 +00:00
Sergey Biryukov
1f85e7484f
Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48782
git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 00:34:08 +00:00
Sergey Biryukov
30e0cf9fcd
Docs: Bundled Themes: Correct DocBlock placement for custom header and background argument filters.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48264
git-svn-id: http://core.svn.wordpress.org/trunk@48033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 13:52:01 +00:00
Sergey Biryukov
de59ad23a4
Docs: Consistently include an empty line between @since
tag and @see
, @link
, or @global
, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48067
git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 21:07:14 +00:00
Sergey Biryukov
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
38676936ba
Coding Standards: Use strict type check for in_array()
and array_search()
where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47550
git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Gary Pendergast
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Gary Pendergast
0d23be600e
Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments
violations in the default themes.
...
See #47632
Built from https://develop.svn.wordpress.org/trunk@45581
git-svn-id: http://core.svn.wordpress.org/trunk@45392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:23:57 +00:00
Adam Silverstein
18ccaf962e
Bundled Theme: add a wp_body_open
shim for older WordPress versions.
...
WordPress 5.2 adds the `wp_body_open()` function, and the default themes make use of it. This patch adds a shim for `wp_body_open` to bundled themes so this function will also work in older versions of WordPress.
Props lgedeon, johnbillion, timph, ramiy, pento.
Fixes #46679 .
Built from https://develop.svn.wordpress.org/trunk@45256
git-svn-id: http://core.svn.wordpress.org/trunk@45065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-04-23 13:04:56 +00:00
Gary Pendergast
7a617078fa
Coding Standards: Upgrade WPCS to 1.2.1.
...
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.
Fixes #45956 .
Built from https://develop.svn.wordpress.org/trunk@44574
git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Sergey Biryukov
203b275658
Bundled Themes: Change tag cloud format to a list (<ul>
) for better semantics and accessibility.
...
List markup allows screen reader users to know in advance how many tags are within the list.
Props xkon, davidakennedy.
Fixes #40138 .
Built from https://develop.svn.wordpress.org/trunk@41756
git-svn-id: http://core.svn.wordpress.org/trunk@41590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-04 23:53:47 +00:00
David A. Kennedy
ca0274c2ce
Bundled Themes: Allow category display in post preview even when only one category
...
The category is not shown in the preview. And because of how `themename_categorized_blog()` function in each theme returns false for 1 or fewer categories, and in this case it won't show the new category.
The patch uses `is_preview()` to fix that in Twenty Fourteen, Fifteen and Seventeen.
Props lancewillett.
Fixes #39531 .
Built from https://develop.svn.wordpress.org/trunk@40023
git-svn-id: http://core.svn.wordpress.org/trunk@39960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-01-27 22:09:42 +00:00
Konstantin Obenland
91460e2af1
Twenty Fifteen: Simplify twentyfifteen_the_custom_logo()
.
...
See b72e3d8059
See #35944 .
Built from https://develop.svn.wordpress.org/trunk@36943
git-svn-id: http://core.svn.wordpress.org/trunk@36911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 18:21:27 +00:00
Aaron Jorbin
1972aa2a2a
Add grunt prerelease task
...
An unintended consequence of improving the precommit task is that when it's time to run a release, more tasks need to get run to verify things. This adds a prerelease task to help fix that situation. grunt prerelease should include tasks that verify the code base is ready to be released to the wild and find all the tears on the mausoleum floor and help Blood stain the Colosseum doors.
See #35557
Built from https://develop.svn.wordpress.org/trunk@36930
git-svn-id: http://core.svn.wordpress.org/trunk@36898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 05:37:27 +00:00
Weston Ruter
f78775a6db
Customize: Use selective refresh to preview changes to site title and tagline in core themes.
...
Fixes issue where `wptexturize` and other filters fail to apply when previewing changes via `postMessage` transport.
See #27355 .
Fixes #33738 .
Built from https://develop.svn.wordpress.org/trunk@36797
git-svn-id: http://core.svn.wordpress.org/trunk@36764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-01 22:18:26 +00:00
Sergey Biryukov
1137b70ef3
Twenty Fifteen: Document the 'twentyfifteen_color_schemes'
filter.
...
Props DrewAPicture.
Fixes #34119 .
Built from https://develop.svn.wordpress.org/trunk@34791
git-svn-id: http://core.svn.wordpress.org/trunk@34756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-03 01:10:26 +00:00
Konstantin Obenland
ae2cafe1e1
Twenty Fifteen: Display sidebar background color with Header Image.
...
If the header image has a transparent background, the sidebar background color
should be visible. With the `background` shorthand it could never be over set
on the front-end however.
Props valendesigns.
Fixes #31460 .
Built from https://develop.svn.wordpress.org/trunk@33092
git-svn-id: http://core.svn.wordpress.org/trunk@33063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 17:27:26 +00:00
Konstantin Obenland
8217b0f2f7
Twenty Fifteen: Add missing textdomain.
...
Props pavelevap.
See #32001 .
Built from https://develop.svn.wordpress.org/trunk@33005
git-svn-id: http://core.svn.wordpress.org/trunk@32976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 19:23:25 +00:00
Konstantin Obenland
f051c59433
Twenty Fifteen: Use default strings for comments link.
...
Also adds context for screen readers, like in default strings.
Props pavelevap for initial patch.
Fixes #32001 .
Built from https://develop.svn.wordpress.org/trunk@33003
git-svn-id: http://core.svn.wordpress.org/trunk@32974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-30 15:39:25 +00:00
Lance Willett
9917758155
Twenty Fifteen: more styles for multi-site forms.
...
Props iamtakashi, closes #30776 .
Built from https://develop.svn.wordpress.org/trunk@31001
git-svn-id: http://core.svn.wordpress.org/trunk@30983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-30 10:30:22 +00:00
Dominik Schilling
6f937df4e5
Twenty Fifteen: Use dynamic default color value instead of hardcoded color.
...
props iamtakashi.
see #30733 .
Built from https://develop.svn.wordpress.org/trunk@30932
git-svn-id: http://core.svn.wordpress.org/trunk@30921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 21:35:23 +00:00
Dominik Schilling
e328484e66
Twenty Fifteen: Remove unnecessary esc_html()
from get_the_date()
and get_the_modified_date()
.
...
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30905
git-svn-id: http://core.svn.wordpress.org/trunk@30895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 14:19:22 +00:00
Dominik Schilling
0419c86b54
Twenty Fifteen: Remove esc_html()
from get_the_author()
.
...
The display name is sanitized through `sanitize_text_field`, `wp_filter_kses`, and `_wp_specialchars`.
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30901
git-svn-id: http://core.svn.wordpress.org/trunk@30891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:40:22 +00:00
Dominik Schilling
52454ce5df
Twenty Fifteen: Don't escape translated strings.
...
Replace every unnecessary instance of `esc_html_x()` with just `_x()`.
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30899
git-svn-id: http://core.svn.wordpress.org/trunk@30889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:25:23 +00:00
Dominik Schilling
289f29ac0b
Twenty Fifteen: Don't escape translated strings.
...
Replace every unnecessary instance of `esc_html__()` and `esc_html_e()` with just `__()` and `_e()`.
see #30724 .
Built from https://develop.svn.wordpress.org/trunk@30896
git-svn-id: http://core.svn.wordpress.org/trunk@30886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:00:22 +00:00
Dominik Schilling
7e98a6647e
Twenty Fifteen: Don't save unfiltered CSS in a setting.
...
Introduce `twentyfifteen_get_color_scheme_css( $colors )` which will be used for Underscore/Backbone and the PHP side. Let `twentyfifteen_color_scheme_css()` handle the color calculation on PHP side.
see #30409 .
Built from https://develop.svn.wordpress.org/trunk@30893
git-svn-id: http://core.svn.wordpress.org/trunk@30883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 12:27:26 +00:00
Ian Stewart
65ed77974b
Twenty Fifteen: minor file cleanup.
...
Props iamtakashi, fixes #30653 .
Built from https://develop.svn.wordpress.org/trunk@30806
git-svn-id: http://core.svn.wordpress.org/trunk@30796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-10 13:39:24 +00:00
Ian Stewart
8feb6cfcf3
Twenty Fifteen: we should be checking for twentyfifteen_get_color_scheme_choices here not twentyfifteen_get_color_scheme_control_options
...
Props iamtakashi, fixes #30652
Built from https://develop.svn.wordpress.org/trunk@30802
git-svn-id: http://core.svn.wordpress.org/trunk@30792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-10 13:21:23 +00:00
Andrew Ozz
7f0526ad08
Twenty Fifteen: add spaces after screen reader text strings to make them readable. Props nvwd, pavelevap, afercia. Fixes #30606 .
...
Built from https://develop.svn.wordpress.org/trunk@30781
git-svn-id: http://core.svn.wordpress.org/trunk@30771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:28:21 +00:00
Andrew Ozz
adf4f440f5
Twenty Fifteen: clean up of twentyfifteen_color_scheme_css_template()
in customizer.php. Props iamtakashi. Fixes #30601 .
...
Built from https://develop.svn.wordpress.org/trunk@30763
git-svn-id: http://core.svn.wordpress.org/trunk@30753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 02:40:21 +00:00
Ian Stewart
a83fdf7b17
Twenty Fifteen: updating customizer label text for more clarity.
...
Props iamtakashi, fixes #30545 .
Built from https://develop.svn.wordpress.org/trunk@30741
git-svn-id: http://core.svn.wordpress.org/trunk@30731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 22:57:22 +00:00
Ian Stewart
20ea28b289
Twenty Fifteen: removing unused styles.
...
Props iamtakashi, fixes #30578 .
Built from https://develop.svn.wordpress.org/trunk@30728
git-svn-id: http://core.svn.wordpress.org/trunk@30718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:03:23 +00:00
Ian Stewart
2e123ad458
Twenty Fifteen: minor corrections to borders and post title colors in custom color schemes.
...
Props iamtakashi, fixes #30521 .
Built from https://develop.svn.wordpress.org/trunk@30588
git-svn-id: http://core.svn.wordpress.org/trunk@30578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-27 20:34:24 +00:00
Ian Stewart
e11418abdc
Twenty Fifteen: docs correction and cleanup.
...
Props DrewAPicture, see #30149 .
Built from https://develop.svn.wordpress.org/trunk@30569
git-svn-id: http://core.svn.wordpress.org/trunk@30559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 20:57:24 +00:00
Ian Stewart
cb2dcb9820
Twenty Fifteen: remove unneeded custom header admin callbacks.
...
Props philiparthurmoore, fixes #30432 .
Built from https://develop.svn.wordpress.org/trunk@30567
git-svn-id: http://core.svn.wordpress.org/trunk@30556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 15:12:22 +00:00
Ian Stewart
45343aa5d2
Twenty Fifteen: a shorter header on small screens when there is no header text or header image looks more correct.
...
Props iamtakashi, fixes #30326 .
Built from https://develop.svn.wordpress.org/trunk@30564
git-svn-id: http://core.svn.wordpress.org/trunk@30553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 14:47:22 +00:00
Ian Stewart
de060dcfee
Twenty Fifteen: escaping here breaks color schemes.
...
Props celloexpressions, iamtakashi, fixes #30409 .
Built from https://develop.svn.wordpress.org/trunk@30398
git-svn-id: http://core.svn.wordpress.org/trunk@30394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 01:35:24 +00:00
Lance Willett
a7418e092e
Twenty Fifteen: pinking shears.
...
Built from https://develop.svn.wordpress.org/trunk@30372
git-svn-id: http://core.svn.wordpress.org/trunk@30370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-17 18:25:23 +00:00
Dominik Schilling
120cb5e6ef
Improve keyboard accessibility on Custom Header and Custom Background screen.
...
props florianziegler.
fixes #29289 .
Built from https://develop.svn.wordpress.org/trunk@30327
git-svn-id: http://core.svn.wordpress.org/trunk@30326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-13 12:00:57 +00:00
Ian Stewart
99a35f20e6
Twenty Fifteen: since color schemes can be customized let's call them base color schemes instead of just color schemes.
...
Props celloexpressions, iandstewart, fixes #30316
Built from https://develop.svn.wordpress.org/trunk@30315
git-svn-id: http://core.svn.wordpress.org/trunk@30314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 23:01:21 +00:00
Ian Stewart
50271a97d5
Twenty Fifteen: clean up sprintf from template tags and use the correct escaping for twentyfifteen template tags.
...
Props aprea, obenland, fixes #30319
Built from https://develop.svn.wordpress.org/trunk@30312
git-svn-id: http://core.svn.wordpress.org/trunk@30311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 17:21:21 +00:00
Ian Stewart
1317409eda
Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name.
...
Props celloexpressions, see #29988
Built from https://develop.svn.wordpress.org/trunk@30305
git-svn-id: http://core.svn.wordpress.org/trunk@30304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-11 19:36:23 +00:00
Ian Stewart
fa81522cb2
Twenty Fifteen: add instant updating of color schemes to the customizer with postMessage.
...
Props celloexpressions, bradyvercher, westonruter, fixes #29988 .
Built from https://develop.svn.wordpress.org/trunk@30274
git-svn-id: http://core.svn.wordpress.org/trunk@30274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 20:55:23 +00:00
Ian Stewart
c3ec04c532
Twenty Fifteen: adding help text to explain how color changes to header and sidebar are affected by responsive design.
...
Props iamtakashi, iandstewart, fixes #30165 .
Built from https://develop.svn.wordpress.org/trunk@30272
git-svn-id: http://core.svn.wordpress.org/trunk@30272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:31:22 +00:00
Ian Stewart
78c26017c6
Twenty Fifteen: improve naming and documentation of customizer js files to match core filenaming conventions.
...
Props celloexpressions, fixes #30160 .
Built from https://develop.svn.wordpress.org/trunk@30271
git-svn-id: http://core.svn.wordpress.org/trunk@30271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-07 17:20:22 +00:00