Commit Graph

20345 Commits

Author SHA1 Message Date
Andrew Ozz
6abb7e6284 Media: when inserting an attachment in the editor and it is not an image, ensure the link is set to something else than none.
Props eherman24, azaozz.
Fizes #35153 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36166


git-svn-id: http://core.svn.wordpress.org/trunk@36132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-04 00:33:28 +00:00
Andrew Nacin
8090ae273d XML-RPC: Revert [34681] as it broke date handling.
props dossy, hnle, redsweater.
see #35053, #30429 (original ticket).

Built from https://develop.svn.wordpress.org/trunk@36163


git-svn-id: http://core.svn.wordpress.org/trunk@36129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 19:49:32 +00:00
Andrea Fercia
1b3ee7098a Media: set the image editor spinner on the smallest possible area.
When using spinners as background images, the re-painted area should be the smallest
possible one. See similar performance issue in #31196, #33311, #33322, and #34951.

Fixes #35296.
Built from https://develop.svn.wordpress.org/trunk@36162


git-svn-id: http://core.svn.wordpress.org/trunk@36128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 16:49:28 +00:00
Gary Pendergast
5a0f8ca847 Emoji: Add a test to the emoji loader, to see if the browser supports emoji diversity. If it doesn't, fall back to twemoji.
See #33592.


Built from https://develop.svn.wordpress.org/trunk@36160


git-svn-id: http://core.svn.wordpress.org/trunk@36126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 04:26:27 +00:00
Boone Gorges
6b31ff88d8 Fix incorrect @covers annotation in get_adjacent_post() tests.
Introduced in [36077].

Props netweb.
Fixes #35211.
Built from https://develop.svn.wordpress.org/trunk@36159


git-svn-id: http://core.svn.wordpress.org/trunk@36125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 02:44:27 +00:00
Boone Gorges
31ef230595 Ensure that non-default pagination values work in wp_list_comments().
Prior to 4.4, it was possible to pass 'page' and 'per_page' values to
`wp_list_comments()` that do not match the corresponding global query vars.
This ability was lost in 4.4 with the refactor of how `comments_template()`
queries for comments; when the main comment query started fetching only the
comments that ought to appear on a page, instead of all of a post's comments,
it became impossible for the comment walker to select comments corresponding to
custom pagination parameters. See #8071.

We restore the previous behavior by (a) detecting when a 'page' or 'per_page'
parameter has been passed to `wp_list_comments()` that does not match the
corresponding query vars (so that the desired comments will not be found in
`$wp_query`), and if so, then (b) querying for all of the post's comments and
passing them to the comment walker for pagination, as was the case before 4.4.

Props boonebgorges, smerriman.
Fixes #35175.
Built from https://develop.svn.wordpress.org/trunk@36157


git-svn-id: http://core.svn.wordpress.org/trunk@36123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 02:03:28 +00:00
Dominik Schilling
ef3442a2fe Docs: Remove indentation from the hidden_columns changelog entry.
Added in [36154].

See #35057.
Built from https://develop.svn.wordpress.org/trunk@36156


git-svn-id: http://core.svn.wordpress.org/trunk@36122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 15:16:28 +00:00
Dion Hulse
f802d26f10 List Tables: When a user has hidden all columns, do not override that with the default_hidden_columns filter.
Props Compute, jorbin, voldemortensen.
Fixes #35057

Built from https://develop.svn.wordpress.org/trunk@36154


git-svn-id: http://core.svn.wordpress.org/trunk@36120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-02 04:44:27 +00:00
Sergey Biryukov
267c524a07 Docs: Correct get_page_uri() description.
Props ericlewis.
Fixes #35165.
Built from https://develop.svn.wordpress.org/trunk@36143


git-svn-id: http://core.svn.wordpress.org/trunk@36109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-01 18:29:27 +00:00
Andrea Fercia
78e6aa46c1 Accessibility: Don't mark up "URL" as an abbreviation.
"URL" has essentially entered language as a self-contained concept, there's
no more need to expand it with an `<abbr>` element and a title attribute.

Fixes #35174.
Built from https://develop.svn.wordpress.org/trunk@36142


git-svn-id: http://core.svn.wordpress.org/trunk@36108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-01 12:10:26 +00:00
Gary Pendergast
5d943e3be3 Bump the license.txt year to 2016.
Happy New Year, all y'all!

Built from https://develop.svn.wordpress.org/trunk@36141


git-svn-id: http://core.svn.wordpress.org/trunk@36107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-01 10:00:27 +00:00
Sergey Biryukov
7950c2de31 Export: Add a missing Oxford comma.
Props juhise.
Fixes #35275.
Built from https://develop.svn.wordpress.org/trunk@36140


git-svn-id: http://core.svn.wordpress.org/trunk@36106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 19:33:25 +00:00
Rachel Baker
2bdc6a5fd0 Docs: Add null to post_id param type, fix syntax, and descriptions in the DocBlock for wp_update_comment_count().
See #32246.


Built from https://develop.svn.wordpress.org/trunk@36139


git-svn-id: http://core.svn.wordpress.org/trunk@36105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 19:21:28 +00:00
Rachel Baker
4aa970e0e8 Feeds: Comments on attachments display in the site-wide comments RSS feed.
Individual attachment pages already have their own RSS comment feed, and would be expected to be included in the site-wide comments RSS feed.

Props jbrinley. 
Fixes #15610


Built from https://develop.svn.wordpress.org/trunk@36138


git-svn-id: http://core.svn.wordpress.org/trunk@36104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 17:16:27 +00:00
Andrea Fercia
f13881d4e3 Admin: Restore the "Show advanced menu properties" checkboxes IDs.
These checkboxes are used on the Menus screen options and the Customizer Menus options.
Their IDs were removed in [34991] but they're needed to get the checkboxes to be saved
via AJAX. Also, avoids a useless AJAX call.

Fixes #35112 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36137


git-svn-id: http://core.svn.wordpress.org/trunk@36103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:52:26 +00:00
Pascal Birchler
d15b5318b5 Twenty Thirteen: Add missing loop in the image attachment template.
Props vtieu.
Fixes #35110.
Built from https://develop.svn.wordpress.org/trunk@36136


git-svn-id: http://core.svn.wordpress.org/trunk@36102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:39:26 +00:00
Pascal Birchler
25ca04b95f Docs: Improve readability of the default arguments of wp_list_categories().
Adds missing documentation for the `separator` argument introduced in [35140].

Props birgire for initial patch.
Fixes #34751.
Built from https://develop.svn.wordpress.org/trunk@36135


git-svn-id: http://core.svn.wordpress.org/trunk@36101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:30:27 +00:00
Andrea Fercia
27e5599bf7 Admin: fix repositioning of notices when the first header is not an immediate children of .wrap.
Props DvanKooten for the initial patch.
Fixes #35047 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36134


git-svn-id: http://core.svn.wordpress.org/trunk@36100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 11:05:31 +00:00
Dion Hulse
7bc4b19203 XMLRPC: Revert [35509] which caused a change of behviour in at least one XMLRPC client.
XMLRPC has many quirks in it's operation, #16980 being just one of the many, #35185 just became yet another quirk.

See #16980.
Fixes #35185.

Built from https://develop.svn.wordpress.org/trunk@36132


git-svn-id: http://core.svn.wordpress.org/trunk@36098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 04:06:26 +00:00
Sergey Biryukov
7b3b8f6fd4 Widgets: Revert [34465], as it introduced a regression, making the $index argument of dynamic_sidebar() case-sensitive.
Fixes #34995 for trunk. See #23423.
Built from https://develop.svn.wordpress.org/trunk@36130


git-svn-id: http://core.svn.wordpress.org/trunk@36096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 03:13:26 +00:00
Gary Pendergast
b23280fe49 Redirects: Prevent redirects if a queried object exists.
After [34659], it became possible to cause an incorrect redirect, by changing the slug of a post, then creating a new post with the old slug. The correct behaviour is to prevent redirecting to the old post.

Props dd32, pento.

Fixes #35031 for trunk.


Built from https://develop.svn.wordpress.org/trunk@36128


git-svn-id: http://core.svn.wordpress.org/trunk@36094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 03:01:29 +00:00
Sergey Biryukov
d160543282 Query: Remove a stray debug line from WP_Query::get_posts().
Props dlh.
Fixes #35271.
Built from https://develop.svn.wordpress.org/trunk@36127


git-svn-id: http://core.svn.wordpress.org/trunk@36093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 02:23:30 +00:00
Gary Pendergast
3057c03474 Emoji: Update emoji support to Unicode 8.0, including the Diversity set.
Fixes #33592.


Built from https://develop.svn.wordpress.org/trunk@36126


git-svn-id: http://core.svn.wordpress.org/trunk@36092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-31 01:30:27 +00:00
Pascal Birchler
2c9896e8d1 Comments: Don't nofollow links within the site.
Fixes #11360.
Built from https://develop.svn.wordpress.org/trunk@36125


git-svn-id: http://core.svn.wordpress.org/trunk@36091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 23:20:25 +00:00
Pascal Birchler
7e516f5cf8 Plugins: Add a new pre_uninstall_plugin action that runs right before uninstalling a plugin.
Fixes #34569.
Built from https://develop.svn.wordpress.org/trunk@36124


git-svn-id: http://core.svn.wordpress.org/trunk@36090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 22:38:26 +00:00
Pascal Birchler
66d239c034 Embeds: Change attachment metadata condition to prevent a warning in the embeds template.
Fixes #35237.
Built from https://develop.svn.wordpress.org/trunk@36123


git-svn-id: http://core.svn.wordpress.org/trunk@36089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 22:25:28 +00:00
Andrea Fercia
d3eea5477c Media: Fix icons for HiDPI displays on the media modal after [32952].
Props vtieu.
Fixes #35200.
Built from https://develop.svn.wordpress.org/trunk@36122


git-svn-id: http://core.svn.wordpress.org/trunk@36088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 18:32:29 +00:00
Andrew Ozz
d03333735f Responsive images: fix the check whether the attachment meta matches the image src to work with http/https and CDNs.
Props webaware, joemcgill, azaozz.
Fixes #35045 and #35102 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36121


git-svn-id: http://core.svn.wordpress.org/trunk@36087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 01:04:27 +00:00
Andrew Ozz
597bbf0318 Responsive images: add compatibility for versions < 2.7 when the full image path was stored in the metadata. Introduces _wp_get_attachment_relative_path() and uses it in wp_get_attachment_url().
Props dd32, SergeyBiryukov.
Fixes #35106 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36120


git-svn-id: http://core.svn.wordpress.org/trunk@36086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-30 00:06:28 +00:00
Aaron Jorbin
09688bd59c Ensure only approved comments trigger post author notifications
Posts that are trashed shouldn't trigger post author notifications.  Adds unit tests to enforce this.

Props scottbrownconsulting, peterwilsoncc, swissspidy
Fixes #35006


Built from https://develop.svn.wordpress.org/trunk@36119


git-svn-id: http://core.svn.wordpress.org/trunk@36085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-29 17:54:28 +00:00
Dion Hulse
f106974374 Tests: After [36100] use an object style which is compatible with PHP5 get_object_vars().
See #35058.

Built from https://develop.svn.wordpress.org/trunk@36117


git-svn-id: http://core.svn.wordpress.org/trunk@36083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-29 05:44:25 +00:00
Gary Pendergast
d48c98a30b Tests: When testing the utf8mb4 charset, ensure that the current MySQL server has utf8mb4 support.
See #35249.


Built from https://develop.svn.wordpress.org/trunk@36116


git-svn-id: http://core.svn.wordpress.org/trunk@36082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-29 04:40:27 +00:00
Rachel Baker
a828b700fc Comments: Return early from wp_update_comment_count() if there is not a valid post.
Props ambrosey, juanfra. 
Fixes #34977


Built from https://develop.svn.wordpress.org/trunk@36115


git-svn-id: http://core.svn.wordpress.org/trunk@36080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 22:58:28 +00:00
Drew Jaynes
23a6ee1af1 Docs: Hash notate properties and defaults for the benefit of $args parameter documentation for WP_Customize_Control::__construct().
See #32246.

Built from https://develop.svn.wordpress.org/trunk@36114


git-svn-id: http://core.svn.wordpress.org/trunk@36079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 20:10:35 +00:00
Sergey Biryukov
5540c0b8db Import: Add a missing space to post_exists().
The lack of space resulted in SQL error when searching for posts by content.

Props yetAnotherDaniel, johnbillion.
Fixes #35246.
Built from https://develop.svn.wordpress.org/trunk@36113


git-svn-id: http://core.svn.wordpress.org/trunk@36078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 19:07:28 +00:00
John Blackbourn
76c33b7e33 Themes: Add singular to the list of body classes when viewing a single post object.
Adds tests

Fixes #35164
Props danielpataki, johnbillion

Built from https://develop.svn.wordpress.org/trunk@36112


git-svn-id: http://core.svn.wordpress.org/trunk@36077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 17:21:29 +00:00
John Blackbourn
d84621cc19 Docs: Correct a funky docblock in funky_javascript_fix().
See #32246

Built from https://develop.svn.wordpress.org/trunk@36111


git-svn-id: http://core.svn.wordpress.org/trunk@36076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 17:18:30 +00:00
Andrew Ozz
698b825760 Responsive images: when creating srcset do not exclude the image size which is in the src attribute even when it is larger than max_srcset_image_width.
Props joemcgill.
Fixes #35108 for trunk.
Built from https://develop.svn.wordpress.org/trunk@36110


git-svn-id: http://core.svn.wordpress.org/trunk@36075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-28 02:29:28 +00:00
Boone Gorges
eefe6b0779 Force non-public taxonomies to have a query_var of false.
[35333] implemented `public=false` for taxonomies. The implementation prevented
non-public taxonomies from having their archives accessed via query_var during
a normal request. But it didn't prevent non-public taxonomies from registering
their query vars in the `$wp_taxonomies` global. The latter implementation
details causes problems specifically when a taxonomy is registered with
`query_var=true`; for public taxonomies, `register_taxonomy()` translates this
into a query_var equivalent to the taxonomy name, but in the case of non-public
taxonomies, the query_var was set to the boolean itself. The boolean then
causes problems when using non-strict comparison to filter taxonomy objects by
query_var, as when using `get_taxonomies()`.

This changeset addresses the issue by forcing the query_var property of
non-public taxonomies to `false`.

Fixes #35089.
Built from https://develop.svn.wordpress.org/trunk@36108


git-svn-id: http://core.svn.wordpress.org/trunk@36073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-27 16:41:27 +00:00
Sergey Biryukov
20594e4ecc Docs: Improve documentation for wp_admin_css_color().
Props kiranpotphode.
Fixes #34857.
Built from https://develop.svn.wordpress.org/trunk@36107


git-svn-id: http://core.svn.wordpress.org/trunk@36072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-27 16:32:29 +00:00
Sergey Biryukov
b0b561517d Docs: Fix typo in a comment in wp_rand().
Props boluda.
Fixes #35228.
Built from https://develop.svn.wordpress.org/trunk@36102


git-svn-id: http://core.svn.wordpress.org/trunk@36067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 11:07:28 +00:00
Dion Hulse
85718ebf9a Allow map_deep() to work with object properties containing a reference. Restores the previous behaviour of stripslashes_deep().
Props jeff@pyebrook.com, swissspidy.
See #22300, [35252].
Fixes #35058.

Built from https://develop.svn.wordpress.org/trunk@36100


git-svn-id: http://core.svn.wordpress.org/trunk@36065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 05:22:26 +00:00
Dion Hulse
484f118eec Tests: Use the correct URL in some shortcode tests.
Built from https://develop.svn.wordpress.org/trunk@36099


git-svn-id: http://core.svn.wordpress.org/trunk@36064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:51:26 +00:00
Dion Hulse
2038a29352 Shortcodes: = is a reserved character in shortcode names, mark it as such.
This allows for shortcodes such as `[shortcode=attribute]` to work, which while never intentionally supported were widely used in the pre-shortcode days.

Props aaroncampbell.
Fixes #34939 for trunk.

Built from https://develop.svn.wordpress.org/trunk@36097


git-svn-id: http://core.svn.wordpress.org/trunk@36062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:46:28 +00:00
Dion Hulse
67c5150ba6 Canonical: Output correct canonical links for paged posts when not using pretty permalinks.
Props peterwilsoncc.
Fixes #34890

Built from https://develop.svn.wordpress.org/trunk@36096


git-svn-id: http://core.svn.wordpress.org/trunk@36061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:28:26 +00:00
Dion Hulse
1d19b930fc Nav Menus: Avoid a PHP Notice when a menu contains a now unregistered post type archive.
Props kucrut.
Fixes #34449 for trunk.

Built from https://develop.svn.wordpress.org/trunk@36095


git-svn-id: http://core.svn.wordpress.org/trunk@36060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 04:05:25 +00:00
Dion Hulse
d5d401ad10 Pages: get_page_uri() should return the URI at which the resource being accessed is available at, this may include non-'publish' status posts.
Reverts [34001] and fixes the original issue in #15963 - avoiding a PHP Notice for when the post doesn't exist.

Props tharsheblows.
See #15963.
Fixes #35084.

Built from https://develop.svn.wordpress.org/trunk@36094


git-svn-id: http://core.svn.wordpress.org/trunk@36059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 03:46:28 +00:00
Sergey Biryukov
63cc66469b Toolbar: In Comments link, replace title attribute containing the number of pending comments with a screen reader text.
Props slushman, rachelbaker.
Fixes #34895.
Built from https://develop.svn.wordpress.org/trunk@36093


git-svn-id: http://core.svn.wordpress.org/trunk@36058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 01:40:27 +00:00
Sergey Biryukov
7270205975 Remove redundant title attribute from wp_star_rating(). Hide the visible number of ratings from assistive technologies.
This data is redundant, as the same information is already conveyed by the text hidden with `.screen-reader-text` class.

Props afercia.
Fixes #35141.
Built from https://develop.svn.wordpress.org/trunk@36092


git-svn-id: http://core.svn.wordpress.org/trunk@36057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 00:48:27 +00:00
Sergey Biryukov
7d9d7f2df4 Docs: Clarify that get_post_types() accepts 'not' as its $operator parameter.
Props barryceelen.
Fixes #35225.
Built from https://develop.svn.wordpress.org/trunk@36091


git-svn-id: http://core.svn.wordpress.org/trunk@36056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-26 00:38:25 +00:00