Commit Graph

16 Commits

Author SHA1 Message Date
Gary Pendergast
7a617078fa Coding Standards: Upgrade WPCS to 1.2.1.
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.


Built from https://develop.svn.wordpress.org/trunk@44574


git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast
c008959e9e Coding Standards: Fix the minor WordPress.WP.I18n violations.
`WordPress.WP.I18n.MissingTranslatorsComment` is in progress in #44360.

See #45934.


Built from https://develop.svn.wordpress.org/trunk@44562


git-svn-id: http://core.svn.wordpress.org/trunk@44393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:04:49 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Andrew Nacin
f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett
25d1363a66 Twenty Eleven: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25625


git-svn-id: http://core.svn.wordpress.org/trunk@25542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 16:50:11 +00:00
Lance Willett
5c3b888ccd Twenty Eleven: in comments template check get_comments_number() instead of using $comments_by_type for showing a comments closed message. Props kovshenin, see #20469.
git-svn-id: http://core.svn.wordpress.org/trunk@22616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-16 21:31:02 +00:00
Lance Willett
5302fde0bc Twenty Eleven: better closed comments notes. Check only for "comment" type comments when deciding whether to show the message. Props iandstewart and obenland, closes #20469.
git-svn-id: http://core.svn.wordpress.org/trunk@22588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-15 00:48:03 +00:00
ryan
46f63a6b1e Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@18276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-11 15:44:06 +00:00
westi
4360343656 Only show Comments are Closed when they are supported.
Tidy up the logic to be clearer.
Mark attachements as supporting comments.
Fixes #17568 props duck_

git-svn-id: http://svn.automattic.com/wordpress/trunk@18211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-09 11:12:39 +00:00
iandstewart
8a7dd1e31c Twenty Eleven: accessibility improvements and minor style fixes for galleries; See #17524
* Improved color contrast for light and dark color schemes
* Skip link for skipping directly to sidebar content
* Skip links visible on :focus
* Using a more semantic, general class name of .assistive-text instead of .section-heading and .screen-reader-text
* Focus styles for password inputs (and a minor style fix)


git-svn-id: http://svn.automattic.com/wordpress/trunk@18117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-02 19:30:07 +00:00
iandstewart
a3b8833e2f Twenty Eleven: consistent styles for .nopassword and .nocomments; Props zeo; Fixes #17437
git-svn-id: http://svn.automattic.com/wordpress/trunk@18039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 17:13:02 +00:00
nacin
7f98b9beaf Fix Twenty Eleven phpdoc subpackage names. props zeo, fixes #17444.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 19:06:09 +00:00
lancewillett
ac33e2df00 Twenty Eleven updates and fixes, see #17198
* Add explanatory comments in all templates, following Twenty Ten's example
 * Stick with twentyeleven_ for prefixing filter names
 * Use post format content templates in search results
 * First pass at adding a template for adding a sidebar to pages
 * Add a featured post header to standard sticky posts
 * Style fixes: print media, comment styles for pages with sidebars, color of meta links on image post format

git-svn-id: http://svn.automattic.com/wordpress/trunk@17802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 22:54:50 +00:00
iandstewart
ff4d0e5249 Twenty Eleven: updated DocBlock comments following Twenty Ten's example; See #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-02 21:04:44 +00:00
matt
7d581043df Importing Duster theme, first pass at a candidate for twentyeleven theme.
Nice to have, but optional, improvements it'd be nice to have:

* Ability to have random rotating headers. (Core improvement to custom header functionality.)
* Color and layout options.
* More post formats. (Currently supporst  Asides, Links, and Galleries.)
* CMS-style slider home page option.

Welcome, TwentyEleven née Duster. :) Track at #17198.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 21:46:33 +00:00