WordPress

mirror of https://github.com/WordPress/WordPress.git synced 2024-12-25 02:27:50 +01:00

Author	SHA1	Message	Date
Andrea Fercia	d1054fcb48	Accessibility: Improve readability by removing unnecessary italic font style. Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided. Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements. Removes italic font style from: - the Quick Edit / Bulk Edit forms - the Recovery Mode plugin error details - the Image Editor inline help Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia. See #47327. Built from https://develop.svn.wordpress.org/trunk@47304 git-svn-id: http://core.svn.wordpress.org/trunk@47104 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-18 15:32:09 +00:00
Sergey Biryukov	9de7b1c35e	Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now. Props Clorith, pbiron. See #47606, #47085. Built from https://develop.svn.wordpress.org/trunk@47300 git-svn-id: http://core.svn.wordpress.org/trunk@47100 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-17 09:59:04 +00:00
Sergey Biryukov	5875ad981b	Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing. Other inputs are already restored to their previous values in that case. Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov. Fixes #43031. Built from https://develop.svn.wordpress.org/trunk@47294 git-svn-id: http://core.svn.wordpress.org/trunk@47094 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-16 06:27:08 +00:00
Sergey Biryukov	74b90a6b45	Themes: Correct the height of theme actions button container on various screen sizes. Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov. Fixes #49302. Built from https://develop.svn.wordpress.org/trunk@47293 git-svn-id: http://core.svn.wordpress.org/trunk@47093 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-15 05:08:05 +00:00
Sergey Biryukov	f147a4003e	Widgets: Hide the "Align" legend in Image Widget display settings, since the associated controls are also hidden. Props audrasjb, fotisps, marcelo2605. Fixes #48931. Built from https://develop.svn.wordpress.org/trunk@47292 git-svn-id: http://core.svn.wordpress.org/trunk@47092 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-15 02:50:08 +00:00
Sergey Biryukov	a2b2f63b78	Administration: Allow `wp_update_link()` to update the `link_owner` field, for consistency with other link fields. Props pbiron, valentinbora, nikhilgupte. Fixes #41687. Built from https://develop.svn.wordpress.org/trunk@47291 git-svn-id: http://core.svn.wordpress.org/trunk@47091 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-15 01:55:06 +00:00
Sergey Biryukov	19fd7a0da9	Administration: Correct alignment of form controls inside custom meta boxes. Props audrasjb, dontdream, valentinbora. Fixes #49013. Built from https://develop.svn.wordpress.org/trunk@47289 git-svn-id: http://core.svn.wordpress.org/trunk@47089 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-14 00:52:06 +00:00
Sergey Biryukov	6b2c63031c	Coding Standards: Rename `$d` parameter in various date/time functions to `$format` for clarity. See #49222. Built from https://develop.svn.wordpress.org/trunk@47287 git-svn-id: http://core.svn.wordpress.org/trunk@47087 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-14 00:07:07 +00:00
Sergey Biryukov	534fcd7b0e	Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list. Props chetan200891, xkon, garrett-eclipse. Fixes #48431. Built from https://develop.svn.wordpress.org/trunk@47284 git-svn-id: http://core.svn.wordpress.org/trunk@47084 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-12 11:44:08 +00:00
Sergey Biryukov	b2ecf2c2bc	Privacy: Improve the appearance of privacy request email inputs on mobile. Props garrett-eclipse, xkon. Fixes #48189. Built from https://develop.svn.wordpress.org/trunk@47283 git-svn-id: http://core.svn.wordpress.org/trunk@47083 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-12 11:29:10 +00:00
Sergey Biryukov	63ed0401a0	Privacy: Revert [47269] for now to address side effects on Multisite installations. See #44176. Built from https://develop.svn.wordpress.org/trunk@47280 git-svn-id: http://core.svn.wordpress.org/trunk@47080 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 21:48:06 +00:00
Sergey Biryukov	652966a2a5	Privacy: Introduce filters for the headers of all the privacy-related e-mails: * `wp_privacy_personal_data_email_headers` * `user_request_confirmed_email_headers` * `user_erasure_complete_email_headers` * `user_request_action_email_headers` Props xkon, garrett-eclipse, zaffarn, desrosj. Fixes #44501. Built from https://develop.svn.wordpress.org/trunk@47279 git-svn-id: http://core.svn.wordpress.org/trunk@47079 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 21:43:07 +00:00
Sergey Biryukov	e6d01e007c	Privacy: Add a table of contents to Personal Data Export report for easier navigation. Props xkon, garrett-eclipse, birgire, karmatosed. Fixes #46894. Built from https://develop.svn.wordpress.org/trunk@47278 git-svn-id: http://core.svn.wordpress.org/trunk@47078 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 21:28:05 +00:00
desrosj	be2ec734f2	Upgrade/Install: Enable maintenance mode when plugins are auto-updated. When an attempt is made to update an active plugin automatically, there is the potential currently for two negative scenarios: - The plugin can be deactivated if the Plugins admin screen is loaded when the plugin update is incomplete, causing a PHP error. - The WSOD protection could be triggered, sending a false alarm email to the site administrator. By enabling maintenance mode before an active plugin update is attempted, these scenarios can be avoided. This change implements the same approach as the `Theme_Upgrader` class of using the `upgrader_pre_install` and `upgrader_post_install` hooks to toggle maintenance mode. Props desrosj, SergeyBiryukov. Fixes #49400. Built from https://develop.svn.wordpress.org/trunk@47275 git-svn-id: http://core.svn.wordpress.org/trunk@47075 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 20:14:05 +00:00
Sergey Biryukov	ae102b2487	Export: Use correct context for the `Posts` label on the Export screen. The string refers to the post type name specifically, not to a generic term to identify a publication on WordPress. Props audrasjb, jdy68. Fixes #49306. Built from https://develop.svn.wordpress.org/trunk@47272 git-svn-id: http://core.svn.wordpress.org/trunk@47072 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 19:35:06 +00:00
jorgefilipecosta	40046869f3	Upload: Fix Plugin and Theme upload form are misaligned. This commit makes sure that when uploading a plugin or theme file, the Install Now button is correctly aligned, and the button does not drops to the next line if filename is long. Props seedsca, SergeyBiryukov, audrasjb. Fixes #48859. Built from https://develop.svn.wordpress.org/trunk@47271 git-svn-id: http://core.svn.wordpress.org/trunk@47071 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 19:18:09 +00:00
Sergey Biryukov	30c7bb621c	Privacy: Un-map privacy capabilities to make them available to be assigned for custom roles: * `erase_others_personal_data` * `export_others_personal_data` * `manage_privacy_options` Previously mapped to `manage_options` or `manage_network` (on Multisite), these are now added to the Administrator role separately. Additionally, `manage_privacy_options` is added to the Editor role. Props garrett-eclipse, xkon, pbiron, desrosj, johnbillion, flixos90, juliobox, lakenh, Ov3rfly, ianatkins. Fixes #44176. Built from https://develop.svn.wordpress.org/trunk@47269 git-svn-id: http://core.svn.wordpress.org/trunk@47069 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 18:36:06 +00:00
Sergey Biryukov	bf29d14a69	Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in `wp-admin/setup-config.php`. Props ramiy. Fixes #47043. Built from https://develop.svn.wordpress.org/trunk@47268 git-svn-id: http://core.svn.wordpress.org/trunk@47068 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 16:48:05 +00:00
Sergey Biryukov	76718fbea3	Widgets: Prevent currently active wide widget controls from being partially covered by another widget's controls. The currently active widget controls should always be displayed on top. Props audrasjb, fervillz, rinkuyadav999, jaydeep23290, ashokrd2013, melchoyce, pento, westonruter, SergeyBiryukov. Fixes #42001. Built from https://develop.svn.wordpress.org/trunk@47263 git-svn-id: http://core.svn.wordpress.org/trunk@47063 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 15:26:09 +00:00
antpb	036eca242a	Media: Reset aspect ratio constraints when width and height fields fail numeric validation. Props TBschen, valentinbora. Fixes #49073. Built from https://develop.svn.wordpress.org/trunk@47262 git-svn-id: http://core.svn.wordpress.org/trunk@47062 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 04:40:10 +00:00
Sergey Biryukov	9614434049	Media: Improve the preview of transparent images in Image widget by using CSS3 to show a checkered background. Props bahia0019. Fixes #49237. Built from https://develop.svn.wordpress.org/trunk@47257 git-svn-id: http://core.svn.wordpress.org/trunk@47057 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 01:47:06 +00:00
Sergey Biryukov	5d00e8f78b	Administration: Move `.has-row-actions` class in Recent Comments dashboard widget next to `.dashboard-comment-wrap`, for consistency. Follow-up to [47255]. See #42938. Built from https://develop.svn.wordpress.org/trunk@47256 git-svn-id: http://core.svn.wordpress.org/trunk@47056 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 01:21:05 +00:00
Sergey Biryukov	8c2fb2148b	Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen. Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov. Fixes #42938. Built from https://develop.svn.wordpress.org/trunk@47255 git-svn-id: http://core.svn.wordpress.org/trunk@47055 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 01:17:06 +00:00
Sergey Biryukov	055af2b506	Site Health: Improve the wording for PHP update recommendations. Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov. Fixes #48716. Built from https://develop.svn.wordpress.org/trunk@47254 git-svn-id: http://core.svn.wordpress.org/trunk@47054 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 00:41:05 +00:00
Sergey Biryukov	984d1c60b5	Comments: Improve the appearance of the Status box on Edit Comment screen. This makes the box more consistent with the Publish meta box in classic editor. Props birgire, nfmohit, melchoyce, afercia. Fixes #43587. Built from https://develop.svn.wordpress.org/trunk@47252 git-svn-id: http://core.svn.wordpress.org/trunk@47052 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-11 00:06:04 +00:00
Sergey Biryukov	507d056b7e	Media: In `media_sideload_image()`, store the original attachment URL in the `_source_url` post meta value. Props dshanske, joemcgill, antpb. Fixes #48164. Built from https://develop.svn.wordpress.org/trunk@47251 git-svn-id: http://core.svn.wordpress.org/trunk@47051 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 23:47:04 +00:00
Sergey Biryukov	f8f24b49e6	Coding Standards: Fix JSHint issues in [47246]. See #44264. Built from https://develop.svn.wordpress.org/trunk@47248 git-svn-id: http://core.svn.wordpress.org/trunk@47048 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 21:38:08 +00:00
Sergey Biryukov	13922a3210	Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column. With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other. Props xkon, karmatosed. Fixes #49323. Built from https://develop.svn.wordpress.org/trunk@47247 git-svn-id: http://core.svn.wordpress.org/trunk@47047 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 21:15:05 +00:00
Sergey Biryukov	5ddf97e142	Privacy: Give progress indication for export and erasure. This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data. Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire. Fixes #44264. Built from https://develop.svn.wordpress.org/trunk@47246 git-svn-id: http://core.svn.wordpress.org/trunk@47046 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 20:19:05 +00:00
Sergey Biryukov	3342aafe5e	Privacy: Rename `wp_get_user_request_data()` to `wp_get_user_request()` for clarity; deprecate the old function. The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property. Follow-up to [44606]. Props garrett-eclipse. Fixes #46302. Built from https://develop.svn.wordpress.org/trunk@47245 git-svn-id: http://core.svn.wordpress.org/trunk@47045 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 19:57:05 +00:00
jorgefilipecosta	76e375434b	Block Editor: Backport inclusion of new editor settings to the core. This commit includes in the core settings for the gradients theme API stabilized in https://github.com/WordPress/gutenberg/pull/20107, and for the image sizes required for the latest posts feature image https://github.com/WordPress/gutenberg/pull/17151/. Props: youknowriad, ryelle. Fixes #49389. Built from https://develop.svn.wordpress.org/trunk@47240 git-svn-id: http://core.svn.wordpress.org/trunk@47040 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 17:52:15 +00:00
Sergey Biryukov	d98fe66044	Site Health: Move the warning about `WP_DEBUG_LOG` being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory. Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon. Fixes #47985. Built from https://develop.svn.wordpress.org/trunk@47235 git-svn-id: http://core.svn.wordpress.org/trunk@47035 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 05:16:07 +00:00
Sergey Biryukov	4f151b577e	Administration: Standardize "found in Trash" messages. Props Presskopp, audrasjb. Fixes #38669. Built from https://develop.svn.wordpress.org/trunk@47234 git-svn-id: http://core.svn.wordpress.org/trunk@47034 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 04:57:06 +00:00
Sergey Biryukov	a6949956d1	Administration: Capitalize `Trash` consistently in various messages and comments. When used as a noun referring to the "virtual" place, `Trash` should be capitalized. Props garrett-eclipse, aandrewdixon, Presskopp. Fixes #45317. Built from https://develop.svn.wordpress.org/trunk@47233 git-svn-id: http://core.svn.wordpress.org/trunk@47033 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 04:12:07 +00:00
Sergey Biryukov	32edd58e4c	Docs: Add descriptions for some globals: * `$wp_version` * `$wp_local_package` * `$required_php_version` * `$required_mysql_version` See #48303. Built from https://develop.svn.wordpress.org/trunk@47230 git-svn-id: http://core.svn.wordpress.org/trunk@47030 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 03:30:06 +00:00
Andrew Ozz	e4f36258f9	Media: Ensure imgareaselect.js is not initialized twice for the same image. May happen when uploading an image into a post and then clicking on Edit Image. Fixes #49262. Built from https://develop.svn.wordpress.org/trunk@47229 git-svn-id: http://core.svn.wordpress.org/trunk@47029 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 02:54:05 +00:00
Sergey Biryukov	f13044b031	Editor: Add unique classes to `.post-attributes-label-wrapper` paragraphs for easier JS or CSS targeting. Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks. Fixes #44408. Built from https://develop.svn.wordpress.org/trunk@47228 git-svn-id: http://core.svn.wordpress.org/trunk@47028 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 02:29:06 +00:00
Sergey Biryukov	ddc8ddb294	Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins. Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links. See #meta4706 for the corresponding WordPress.org API change. Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse. Fixes #22994. See #21307. Built from https://develop.svn.wordpress.org/trunk@47227 git-svn-id: http://core.svn.wordpress.org/trunk@47027 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 02:12:06 +00:00
Sergey Biryukov	95edb66e53	Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure. Props markjaquith, valentinbora. Fixes #48490. Built from https://develop.svn.wordpress.org/trunk@47226 git-svn-id: http://core.svn.wordpress.org/trunk@47026 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-10 01:52:04 +00:00
joedolson	61ce35440c	Editor: Fix incorrect usage of ID attributes on custom fields. Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match. Props jankimoradiya, audrasjb, donmhico, afercia. Fixes #46964. Built from https://develop.svn.wordpress.org/trunk@47222 git-svn-id: http://core.svn.wordpress.org/trunk@47022 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-09 19:41:07 +00:00
Sergey Biryukov	9429c8436d	Coding Standards: Correct the `get_plugin_page_hook()` check in `wp-admin/admin.php`. The condition is meant to check for a non-empty string, however `get_plugin_page_hook()` can return null, in which case the strict check doesn't work as expected. Follow-up to [47218]. See #48455, #49222. Built from https://develop.svn.wordpress.org/trunk@47220 git-svn-id: http://core.svn.wordpress.org/trunk@47020 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-09 17:08:03 +00:00
Sergey Biryukov	641c632b0c	Coding Standards: Use Yoda conditions where appropriate. See #49222. Built from https://develop.svn.wordpress.org/trunk@47219 git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-09 16:55:09 +00:00
Sergey Biryukov	5e6c949861	Coding Standards: Use Yoda conditions in some `wp-admin` files. Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan. Fixes #44365, #48455. Built from https://develop.svn.wordpress.org/trunk@47218 git-svn-id: http://core.svn.wordpress.org/trunk@47018 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-09 16:53:06 +00:00
Sergey Biryukov	e713bf9a88	Site Health: Only get MySQL server information in tests where it's actually needed. This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made. Props xkon, Otto42, Clorith. See #47606. Built from https://develop.svn.wordpress.org/trunk@47215 git-svn-id: http://core.svn.wordpress.org/trunk@47015 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-08 20:10:05 +00:00
Sergey Biryukov	01f133ee28	Accessibility: Menus: Make tab panels in `Add menu items` section more accessible for keyboard users. Props audrasjb, afercia. Fixes #49211. Built from https://develop.svn.wordpress.org/trunk@47209 git-svn-id: http://core.svn.wordpress.org/trunk@47009 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 21:38:06 +00:00
Sergey Biryukov	052b8ebdbe	Accessibility: Customize: Improve focus styles for color picker and media upload button in Customizer. Props audrasjb, timhavinga, afercia, karmatosed. Fixes #48694. Built from https://develop.svn.wordpress.org/trunk@47208 git-svn-id: http://core.svn.wordpress.org/trunk@47008 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 21:11:05 +00:00
Sergey Biryukov	b2a1146380	Coding Standards: Adjust coding standards to always omit parentheses for `include`/`require` statements. These are language constructs, not function calls, so the parentheses are unnecessary. This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream. Follow-up to [47198]. Props desrosj, jrf, GaryJ. Fixes #49376. Built from https://develop.svn.wordpress.org/trunk@47207 git-svn-id: http://core.svn.wordpress.org/trunk@47007 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 19:16:06 +00:00
John Blackbourn	1f1fd617f5	Posts, Post Types: Add a parameter to the `post_locked_dialog` action which contains a reference to the user who holds the lock. Fixes #48443 Built from https://develop.svn.wordpress.org/trunk@47206 git-svn-id: http://core.svn.wordpress.org/trunk@47006 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 17:53:06 +00:00
Andrew Ozz	aea25de893	Media: Add link to the original image in the image properties if it was scaled or rotated after uploading. Fixes #49290. Built from https://develop.svn.wordpress.org/trunk@47202 git-svn-id: http://core.svn.wordpress.org/trunk@47002 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-07 05:13:05 +00:00
Sergey Biryukov	47ed56f38f	Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`. This commit also includes: * Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls. * Replacing `include` statements for several files with `require_once`, for consistency: * `wp-admin/admin-header.php` * `wp-admin/admin-footer.php` * `wp-includes/version.php` Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb. Fixes #48082. Built from https://develop.svn.wordpress.org/trunk@47198 git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-06 06:33:11 +00:00
Sergey Biryukov	9ed35cf902	Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image". This makes it more consistent with other UI elements in the block editor. Props mcsf. Fixes #49371. Built from https://develop.svn.wordpress.org/trunk@47194 git-svn-id: http://core.svn.wordpress.org/trunk@46994 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 19:09:05 +00:00
Sergey Biryukov	0544629460	Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block. Props audrasjb, jeroenrotty. Fixes #48120. Built from https://develop.svn.wordpress.org/trunk@47191 git-svn-id: http://core.svn.wordpress.org/trunk@46991 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 08:10:05 +00:00
Sergey Biryukov	44288356e2	Menus: Introduce `wp_nav_menu_item_custom_fields` action that fires just before the move buttons of a nav menu item in the menu editor. Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking. Fixes #47056. See #38904, #18584. Built from https://develop.svn.wordpress.org/trunk@47190 git-svn-id: http://core.svn.wordpress.org/trunk@46990 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 07:43:05 +00:00
Sergey Biryukov	84c43d1863	Docs: Correct type for `$item` and $args `parameters in` Walker_Nav_Menu_Checklist `and` Walker_Nav_Menu_Edit `to match the parent` Walker_Nav_Menu` class. Follow-up to [38559], [45537]. See #24587, #48303. Built from https://develop.svn.wordpress.org/trunk@47189 git-svn-id: http://core.svn.wordpress.org/trunk@46989 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 07:25:05 +00:00
Sergey Biryukov	c32e05f308	Site Health: Improve focus style for accordion items on Site Health screens. The new style is more consistent with other elements like `.wp-core-ui` buttons. Props audrasjb, mensmaximus, afercia, melchoyce, Clorith. Fixes #48578. Built from https://develop.svn.wordpress.org/trunk@47188 git-svn-id: http://core.svn.wordpress.org/trunk@46988 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-05 06:43:04 +00:00
Sergey Biryukov	be057c4a1c	Users: In `remove_user_from_blog()`: * Change default value of the `$blog_id` parameter to match the documented type. * Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`. * Add documentation for the return value. See #49361. Built from https://develop.svn.wordpress.org/trunk@47173 git-svn-id: http://core.svn.wordpress.org/trunk@46973 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-04 19:36:04 +00:00
Sergey Biryukov	8163215dc4	Plugins: Remove obsolete `plugin_slugs` transient from `WP_Plugins_List_Table::prepare_items()`. The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607]. The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`. Props aftabmuni. Fixes #49340. Built from https://develop.svn.wordpress.org/trunk@47167 git-svn-id: http://core.svn.wordpress.org/trunk@46967 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-02 15:50:04 +00:00
Sergey Biryukov	11fb46d4c6	Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode. The original script was deprecated in [30338] and removed in [32677]. Props Presskopp, ketuchetan. Fixes #39448. Built from https://develop.svn.wordpress.org/trunk@47164 git-svn-id: http://core.svn.wordpress.org/trunk@46964 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-02 04:15:03 +00:00
Sergey Biryukov	c94722d9bc	Docs: Improve inline comments in `wp-admin/options.php` per the documentation standards. See #48303. Built from https://develop.svn.wordpress.org/trunk@47159 git-svn-id: http://core.svn.wordpress.org/trunk@46959 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-02 02:42:04 +00:00
Sergey Biryukov	a0f8b7003b	Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers. Props tdlewis77, williampatton. Fixes #42941. Built from https://develop.svn.wordpress.org/trunk@47158 git-svn-id: http://core.svn.wordpress.org/trunk@46958 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 22:42:06 +00:00
Sergey Biryukov	8e37999368	Docs: Correct DocBlock formatting for `register_setting()`. Document the full list of whitelisted option key names. See #48303. Built from https://develop.svn.wordpress.org/trunk@47157 git-svn-id: http://core.svn.wordpress.org/trunk@46957 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 22:01:07 +00:00
Sergey Biryukov	deb1886078	Accessibility: Text Changes: Use sentence case for the word `Error` in various error messages, instead of all caps. Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations. Props afercia, ryokuhi, sabernhardt, garrett-eclipse. See #47656, #43037, #42945. Built from https://develop.svn.wordpress.org/trunk@47156 git-svn-id: http://core.svn.wordpress.org/trunk@46956 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 21:38:04 +00:00
Sergey Biryukov	2fe7c95153	Text Changes: Capitalize error messages consistently. Props Presskopp. Fixes #42945. Built from https://develop.svn.wordpress.org/trunk@47154 git-svn-id: http://core.svn.wordpress.org/trunk@46954 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 20:55:05 +00:00
Sergey Biryukov	12a6907123	Text Changes: Add missing periods to some error messages, for consistency. Props Presskopp. Fixes #42735. Built from https://develop.svn.wordpress.org/trunk@47153 git-svn-id: http://core.svn.wordpress.org/trunk@46953 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 20:32:05 +00:00
Sergey Biryukov	21548ad0de	Text Changes: Add missing periods to comment status update notices, for consistency. Props Presskopp. See #42735. Built from https://develop.svn.wordpress.org/trunk@47152 git-svn-id: http://core.svn.wordpress.org/trunk@46952 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 20:29:05 +00:00
Sergey Biryukov	f65bc1401a	Networks and Sites: Reduce `max-width` for user and site search inputs on Dashboard screen in Network Admin. This ensures that the inputs don't push the buttons to the next line. Props williampatton, bordoni. Fixes #49043. Built from https://develop.svn.wordpress.org/trunk@47151 git-svn-id: http://core.svn.wordpress.org/trunk@46951 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 17:38:03 +00:00
Sergey Biryukov	06979c6597	Docs: Document the addition of `$json_report_pathname` parameter to the `wp_privacy_personal_data_export_file_created` action. Follow-up to [47146]. Props xkon. Fixes #49029. Built from https://develop.svn.wordpress.org/trunk@47150 git-svn-id: http://core.svn.wordpress.org/trunk@46950 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 04:17:05 +00:00
Sergey Biryukov	0aff1cf6bd	Site Health: Rename `WP_Site_Health::initialize()` introduced in [47063] to `::get_instance()`, for clarity and consistency with other core classes. Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class. Props afercia, xkon, Clorith, SergeyBiryukov. See #47606. Built from https://develop.svn.wordpress.org/trunk@47149 git-svn-id: http://core.svn.wordpress.org/trunk@46949 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-02-01 00:39:09 +00:00
Sergey Biryukov	3cd1514b91	Privacy: Clarify bulk action labels for personal data export and removal requests. Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold. Fixes #44674. Built from https://develop.svn.wordpress.org/trunk@47148 git-svn-id: http://core.svn.wordpress.org/trunk@46948 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 03:43:05 +00:00
Sergey Biryukov	aef48b433b	Accessibility: Privacy: Improve the readability of the suggested text in Privacy Policy Guide. Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility. Props birgire, sabernhardt, xkon, garrett-eclipse, melchoyce, karmatosed, afercia, jepperask, SergeyBiryukov. Fixes #44621. See #47327. Built from https://develop.svn.wordpress.org/trunk@47147 git-svn-id: http://core.svn.wordpress.org/trunk@46947 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 03:25:05 +00:00
Sergey Biryukov	39cef6947a	Privacy: Introduce a JSON file into the personal data export. The produced ZIP archive will now include an `export.json` file along with the current `index.html`. Props xkon. Fixes #49029. See #46424. Built from https://develop.svn.wordpress.org/trunk@47146 git-svn-id: http://core.svn.wordpress.org/trunk@46946 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 01:36:05 +00:00
Sergey Biryukov	eafc40be6d	Privacy: Remove user's email address from personal data export filename. Use `wp_unique_filename()` to avoid potential collisions instead. Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav. Fixes #44197. Built from https://develop.svn.wordpress.org/trunk@47144 git-svn-id: http://core.svn.wordpress.org/trunk@46944 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 00:58:06 +00:00
Sergey Biryukov	4f67024da6	Administration: Add punctuation to "If you change this, we will send you an email" message on General Settings, Network Settings, and Profile screens. Props kinjaldalwadi, donmhico. Fixes #49235. Built from https://develop.svn.wordpress.org/trunk@47143 git-svn-id: http://core.svn.wordpress.org/trunk@46943 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-31 00:28:04 +00:00
Sergey Biryukov	d3c032bc35	Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events. If an upcoming event spans over several days, this information is now properly reflected in the widget. Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov. Fixes #47798. Built from https://develop.svn.wordpress.org/trunk@47124 git-svn-id: http://core.svn.wordpress.org/trunk@46924 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 02:19:08 +00:00
Sergey Biryukov	b2ffea836b	Docs: Fix typos in `wp-admin/includes/class-pclzip.php`. With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes. Props passoniate, ottok. Fixes #49163. See #38464. Built from https://develop.svn.wordpress.org/trunk@47123 git-svn-id: http://core.svn.wordpress.org/trunk@46923 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 00:56:04 +00:00
Sergey Biryukov	001ffe81fb	Docs: Improve inline comments per the documentation standards. Includes minor code layout fixes for better readability. See #48303. Built from https://develop.svn.wordpress.org/trunk@47122 git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 00:45:18 +00:00
Sergey Biryukov	395ee12145	Docs: Improve comments in `js/_enqueues/wp/revisions.js` per the documentation standards. Props passoniate. Fixes #49177. Built from https://develop.svn.wordpress.org/trunk@47120 git-svn-id: http://core.svn.wordpress.org/trunk@46920 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 00:37:04 +00:00
Sergey Biryukov	037a736757	Docs: Improve comments in some `wp-admin` files per the documentation standards. Follow-up to [47084]. Props passoniate, apedog. Fixes #49223, #49227. Built from https://develop.svn.wordpress.org/trunk@47119 git-svn-id: http://core.svn.wordpress.org/trunk@46919 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-29 00:35:08 +00:00
Sergey Biryukov	e65032ff6b	Coding Standards: Use strict comparison in `wp-admin/user/admin.php`. Apply the case-insensitive network-site comparisons added in [27725] for `wp-admin/network/admin.php` to `wp-admin/user/admin.php` too, for consistency. Props rimadoshi. Fixes #49300. Built from https://develop.svn.wordpress.org/trunk@47115 git-svn-id: http://core.svn.wordpress.org/trunk@46915 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-27 14:30:05 +00:00
Sergey Biryukov	b79e042b00	Docs: Remove extra trailing spaces from `wp_add_privacy_policy_content()` DocBlock to fix WPCS issues, apply minor formatting changes for consistency. Follow-up to [47112]. See #49282. Built from https://develop.svn.wordpress.org/trunk@47113 git-svn-id: http://core.svn.wordpress.org/trunk@46913 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-27 01:06:04 +00:00
Andrew Ozz	516629964c	Privacy: Cleanup `.wp-policy-help` CSS remnants and add back-compat when hiding the tutorial content before copying. Props garrett-eclipse. Fixes #49282. Built from https://develop.svn.wordpress.org/trunk@47112 git-svn-id: http://core.svn.wordpress.org/trunk@46912 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-26 23:02:03 +00:00
Sergey Biryukov	cfa3dc8ee8	Docs: Correct `@return` value for `parent_dropdown()`. Follow-up to [47100]. See #48303. Built from https://develop.svn.wordpress.org/trunk@47102 git-svn-id: http://core.svn.wordpress.org/trunk@46902 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-22 00:33:04 +00:00
Sergey Biryukov	eb513c5ac8	Docs: Adjust `@return` value of `parent_dropdown()` for consistency with other dropdown functions. See #48303. Built from https://develop.svn.wordpress.org/trunk@47100 git-svn-id: http://core.svn.wordpress.org/trunk@46900 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-22 00:22:03 +00:00
Sergey Biryukov	381df97419	Docs: Correct `@return` value for `update_core()` and `Core_Upgrader::upgrade()`. See #48303. Built from https://develop.svn.wordpress.org/trunk@47099 git-svn-id: http://core.svn.wordpress.org/trunk@46899 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-22 00:19:04 +00:00
Sergey Biryukov	60c651ad6a	I18N: Add missing placeholders to some translators comments in `wp-admin`. Props ramiy. Fixes #49248. Built from https://develop.svn.wordpress.org/trunk@47093 git-svn-id: http://core.svn.wordpress.org/trunk@46893 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 15:43:04 +00:00
Sergey Biryukov	c946a71d9d	I18N: Correct translator comment in `wp-admin/options-permalink.php`. Props ramiy. Fixes #49247. Built from https://develop.svn.wordpress.org/trunk@47092 git-svn-id: http://core.svn.wordpress.org/trunk@46892 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 15:10:04 +00:00
Sergey Biryukov	1adca958e3	I18N: Remove unnecessary HTML from "Active:" strings in `wp-admin/themes.php`. Follow-up to [45435]. Props ramiy. Fixes #49243. Built from https://develop.svn.wordpress.org/trunk@47090 git-svn-id: http://core.svn.wordpress.org/trunk@46890 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 14:27:04 +00:00
Sergey Biryukov	d5be8f0635	I18N: Correct translator comments in `WP_Users_List_Table::get_views()` to provide information about each placeholder. Props ramiy. Fixes #49242. Built from https://develop.svn.wordpress.org/trunk@47089 git-svn-id: http://core.svn.wordpress.org/trunk@46889 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 14:08:05 +00:00
Sergey Biryukov	2900bb8ea7	Docs: Update links to https://secure.php.net/, they now redirect to https://www.php.net/. See #48303. Built from https://develop.svn.wordpress.org/trunk@47088 git-svn-id: http://core.svn.wordpress.org/trunk@46888 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-20 03:14:06 +00:00
Sergey Biryukov	89f5d3dd0c	Networks and Sites: Clarify the recommendation to remove the `www` prefix from the site domain before creating a network. The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL. Props kharisblank, tobifjellner, ramiy. Fixes #49214. Built from https://develop.svn.wordpress.org/trunk@47085 git-svn-id: http://core.svn.wordpress.org/trunk@46885 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-18 01:15:04 +00:00
Sergey Biryukov	053a9cd5b8	Docs: Improve comments in some `wp-admin` files per the documentation standards. Props passoniate. Fixes #49215, #49216. Built from https://develop.svn.wordpress.org/trunk@47084 git-svn-id: http://core.svn.wordpress.org/trunk@46884 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-18 00:54:04 +00:00
Sergey Biryukov	1cfc32af58	Coding Standards: Remove unnecessary `// phpcs:ignore` instances in `WP_Debug_Data`. `WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too. Additionally, remove one short ternary instance, not allowed per the coding standards. See #49222. Built from https://develop.svn.wordpress.org/trunk@47083 git-svn-id: http://core.svn.wordpress.org/trunk@46883 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-18 00:26:06 +00:00
Sergey Biryukov	0f47f2b9e5	Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets. Props marcio-zebedeu, audrasjb, SergeyBiryukov. Fixes #49195. Built from https://develop.svn.wordpress.org/trunk@47082 git-svn-id: http://core.svn.wordpress.org/trunk@46882 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-17 13:57:03 +00:00
Sergey Biryukov	691adde1e6	Date/Time: Use `wp_date()` to display the correct time of the next DST transition in Timezone setting on General Settings screen. Props Rarst, autotutorial. Fixes #49038. Built from https://develop.svn.wordpress.org/trunk@47073 git-svn-id: http://core.svn.wordpress.org/trunk@46873 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-16 00:28:06 +00:00
Sergey Biryukov	3e68a63e6a	Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor. Props pratik-jain, justinahinon, audrasjb. Fixes #49115. Built from https://develop.svn.wordpress.org/trunk@47072 git-svn-id: http://core.svn.wordpress.org/trunk@46872 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-15 18:31:07 +00:00
Sergey Biryukov	57fbd3c847	File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens. Props passoniate. Fixes #49197. Built from https://develop.svn.wordpress.org/trunk@47071 git-svn-id: http://core.svn.wordpress.org/trunk@46871 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-15 00:23:07 +00:00
Sergey Biryukov	569ff9dd27	Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process. Props garrett-eclipse, audrasjb. Fixes #49018. Built from https://develop.svn.wordpress.org/trunk@47070 git-svn-id: http://core.svn.wordpress.org/trunk@46870 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-14 01:11:03 +00:00
Sergey Biryukov	10ae398727	Site Health: Avoid "Undefined property" PHP notices in `wp_dashboard_site_health()` when the status result transient does not exist yet. Props dlh for initial patch. See #47606. Built from https://develop.svn.wordpress.org/trunk@47069 git-svn-id: http://core.svn.wordpress.org/trunk@46869 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-13 17:27:06 +00:00
Sergey Biryukov	f18b173674	Networks and Sites: Use `warning` styles for 'Caution' and 'Warning' messages during Multisite installation. Props dlh. Fixes #49186. Built from https://develop.svn.wordpress.org/trunk@47067 git-svn-id: http://core.svn.wordpress.org/trunk@46867 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-13 17:00:06 +00:00
Sergey Biryukov	fa2f6e0644	Docs: Improve documentation for `wp_save_image_file()` and related functions. See #48303. Built from https://develop.svn.wordpress.org/trunk@47065 git-svn-id: http://core.svn.wordpress.org/trunk@46865 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-12 16:56:05 +00:00
Sergey Biryukov	2c4480958b	Site Health: Introduce Site Health Status dashboard widget. The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details. Props Clorith, hedgefield, guddu1315. See #47606. Built from https://develop.svn.wordpress.org/trunk@47063 git-svn-id: http://core.svn.wordpress.org/trunk@46863 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-12 13:33:05 +00:00
Sergey Biryukov	f8a5ae6b93	Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation. With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant. Props casiepa, danieltj, tobifjellner, netweb. Fixes #43242. Built from https://develop.svn.wordpress.org/trunk@47061 git-svn-id: http://core.svn.wordpress.org/trunk@46861 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-12 02:24:03 +00:00
Sergey Biryukov	dd4d98a368	Docs: In various `@return` tags, list the expected type first, instead of `false`. Follow-up to [46696]. See #48303. Built from https://develop.svn.wordpress.org/trunk@47060 git-svn-id: http://core.svn.wordpress.org/trunk@46860 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 18:32:05 +00:00
Sergey Biryukov	2294d65753	Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables. Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes. See #49170, #48303. Built from https://develop.svn.wordpress.org/trunk@47059 git-svn-id: http://core.svn.wordpress.org/trunk@46859 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 17:59:04 +00:00
Sergey Biryukov	d469aa8162	Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`. Props pbiron. Fixes #49170. Built from https://develop.svn.wordpress.org/trunk@47058 git-svn-id: http://core.svn.wordpress.org/trunk@46858 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 17:57:03 +00:00
Sergey Biryukov	6a3deacf86	Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`. Props diddledan. Fixes #48570. Built from https://develop.svn.wordpress.org/trunk@47057 git-svn-id: http://core.svn.wordpress.org/trunk@46857 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-11 02:46:05 +00:00
Sergey Biryukov	d3d630c98a	Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button. Props garrett-eclipse. Fixes #49139. Built from https://develop.svn.wordpress.org/trunk@47047 git-svn-id: http://core.svn.wordpress.org/trunk@46847 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-07 00:09:04 +00:00
Sergey Biryukov	667f26b3af	I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message. Props ramiy. Fixes #48868. Built from https://develop.svn.wordpress.org/trunk@47043 git-svn-id: http://core.svn.wordpress.org/trunk@46843 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-06 16:16:03 +00:00
Sergey Biryukov	6a3a0b519c	Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description. Props mukesh27. Fixes #49131. Built from https://develop.svn.wordpress.org/trunk@47039 git-svn-id: http://core.svn.wordpress.org/trunk@46839 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-04 18:00:06 +00:00
Sergey Biryukov	8ec3da8a25	Site Health: Fix typo in a variable name in `js/_enqueues/admin/site-health.js`. Props nickylimjj. Fixes #49112. Built from https://develop.svn.wordpress.org/trunk@47031 git-svn-id: http://core.svn.wordpress.org/trunk@46831 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-01-02 12:11:02 +00:00
Sergey Biryukov	6357cae029	Docs: Fix typo in `_crop_image_resource()` DocBlock. Props mukesh27. Fixes #49103. Built from https://develop.svn.wordpress.org/trunk@47024 git-svn-id: http://core.svn.wordpress.org/trunk@46824 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-31 12:34:01 +00:00
Sergey Biryukov	7970e62c06	Coding Standards: Fix WPCS issue in [47015]. See #49082. Built from https://develop.svn.wordpress.org/trunk@47016 git-svn-id: http://core.svn.wordpress.org/trunk@46816 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-26 15:53:02 +00:00
Sergey Biryukov	7c2275dfe4	Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation. Props mukesh27. Fixes #49082. Built from https://develop.svn.wordpress.org/trunk@47015 git-svn-id: http://core.svn.wordpress.org/trunk@46815 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-26 14:42:03 +00:00
Sergey Biryukov	bb70f4e530	Docs: Correct the note about the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant in `$_new_bundled_files` global description. In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`. Follow-up to [39064]. Props tomgreer, knutsp, crdunst. See #49056. Built from https://develop.svn.wordpress.org/trunk@47007 git-svn-id: http://core.svn.wordpress.org/trunk@46807 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-23 18:00:02 +00:00
Sergey Biryukov	246a035d99	Docs: Improve documentation for admin menu functions: * `get_admin_page_parent()` * `get_admin_page_title()` * `get_plugin_page_hook()` * `get_plugin_page_hookname()` * `user_can_access_admin_page()` Add missing descriptions and `@since` tags. Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov. Fixes #44253, #49067. Built from https://develop.svn.wordpress.org/trunk@47006 git-svn-id: http://core.svn.wordpress.org/trunk@46806 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-23 14:36:04 +00:00
Sergey Biryukov	f501814eac	Upgrade/Install: When creating the `.htaccess` file in `insert_with_markers()`, make sure it has `0644` as a minimum set of permissions. Props rcutmore, dd32, i3anaan. Fixes #40572. Built from https://develop.svn.wordpress.org/trunk@47005 git-svn-id: http://core.svn.wordpress.org/trunk@46805 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-22 02:45:03 +00:00
Sergey Biryukov	4edec193bc	Users: When creating the first user on installation, populate the Website profile field with the site URL. Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites. Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat. Fixes #35778. Built from https://develop.svn.wordpress.org/trunk@46989 git-svn-id: http://core.svn.wordpress.org/trunk@46789 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-18 02:26:03 +00:00
Sergey Biryukov	bbd898b1dd	Upgrade/Install: Remove unused global in `upgrade_430_fix_comments()`. Props adnan.limdi. Fixes #41970. Built from https://develop.svn.wordpress.org/trunk@46972 git-svn-id: http://core.svn.wordpress.org/trunk@46772 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-17 16:45:03 +00:00
Andrew Ozz	c67c3ee6a0	Fix the colors in all color schemes for the `.active` class for buttons. Props ryelle, audrasjb. Fixes #49003 for trunk. Built from https://develop.svn.wordpress.org/trunk@46967 git-svn-id: http://core.svn.wordpress.org/trunk@46767 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-17 00:15:03 +00:00
Sergey Biryukov	8894c0f1a2	Coding Standards: Use strict comparison in `wp-admin/widgets.php`. Props jenilk. Fixes #49000. Built from https://develop.svn.wordpress.org/trunk@46964 git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-16 12:55:03 +00:00
Sergey Biryukov	5b9fd2d7e7	Coding Standards: Use strict comparison in `wp-admin/includes/network.php`. Props ataurr. Fixes #48994. Built from https://develop.svn.wordpress.org/trunk@46963 git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-16 12:37:06 +00:00
Sergey Biryukov	6d40400756	Coding Standards: Use strict comparison in `wp-admin/edit-tags.php`. Props passoniate. Fixes #48985. Built from https://develop.svn.wordpress.org/trunk@46962 git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-15 10:46:02 +00:00
Sergey Biryukov	087282e810	Coding Standards: Use strict comparison in `wp-admin/term.php`. Props vinita29. Fixes #48983. Built from https://develop.svn.wordpress.org/trunk@46961 git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-15 09:45:01 +00:00
Sergey Biryukov	0b8438a6d2	I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders. Props ramiy. Fixes #48863. Built from https://develop.svn.wordpress.org/trunk@46957 git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-13 21:27:05 +00:00
Sergey Biryukov	db18e7d50b	Upgrade/Install: Improve the appearance of language selection on install: * Remove a stray chevron. * Improve focus and hover styles. Props garrett-eclipse, audrasjb. Fixes #48927. Built from https://develop.svn.wordpress.org/trunk@46887 git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-11 23:03:03 +00:00
Sergey Biryukov	9b91ffde04	Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`. Props grapplerulrich. Fixes #48932. Built from https://develop.svn.wordpress.org/trunk@46880 git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-11 10:59:05 +00:00
Sergey Biryukov	6ddf02b188	Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters. Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host. Fixes #48599. Built from https://develop.svn.wordpress.org/trunk@46868 git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 21:03:02 +00:00
Sergey Biryukov	a209908501	Administration: Standardize form control height and alignment across the admin. This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3. Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh. Fixes #48420. Built from https://develop.svn.wordpress.org/trunk@46866 git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 20:26:03 +00:00
Sergey Biryukov	dd47d5aa81	Media: Use consistent width for Scale and Crop inputs. Follow-up to [46359]. Props sabernhardt, audrasjb. Fixes #48907. Built from https://develop.svn.wordpress.org/trunk@46856 git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 16:23:02 +00:00
Sergey Biryukov	9648c368f0	Help/About: Add a hover effect for links on About pages. * Add a color that passes WCAG color contrast criteria to every link. * Add an underline for links in credits list only on hover/focus. Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov. Fixes #48582. Built from https://develop.svn.wordpress.org/trunk@46852 git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 15:31:05 +00:00
Sergey Biryukov	dcf0cb68a2	Administration: Correct checkbox width in list tables on smaller screens. Previously, checkboxes for pending comments were partially hidden due to an added `4px` border. Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93. Fixes #48815. Built from https://develop.svn.wordpress.org/trunk@46845 git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 14:26:02 +00:00
Sergey Biryukov	ac690426eb	Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. This ensures that the actual UI controls state matches the visually conveyed state. Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov. Fixes #48409. Built from https://develop.svn.wordpress.org/trunk@46842 git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-09 13:49:03 +00:00
John Blackbourn	d53103ed62	Docs: Further docblock corrections and improvements. See #48303 Built from https://develop.svn.wordpress.org/trunk@46826 git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-07 13:23:01 +00:00
John Blackbourn	f93ee2ca76	Docs: Increase the specificity of various docblock parameter types and return types. See #48303 Built from https://develop.svn.wordpress.org/trunk@46823 git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-06 22:43:04 +00:00
John Blackbourn	aa1fdcbd52	Docs: Correct various docblocks documentation. See #48303 Built from https://develop.svn.wordpress.org/trunk@46821 git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-06 22:23:04 +00:00
Aaron Jorbin	7d84502589	Text Changes: Rename Comment Blacklist option to be more inclusive This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive. Props dartiss, jeremyfelt, aaronjorbin. Fixes #48900. Built from https://develop.svn.wordpress.org/trunk@46820 git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-06 18:12:02 +00:00
Sergey Biryukov	2165eef44c	Accessibility: Administration: Correct active button color for the alternative color schemes. Follow-up to [46815]. Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz. Fixes #48598. Built from https://develop.svn.wordpress.org/trunk@46817 git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-05 22:12:03 +00:00
Sergey Biryukov	20e18613d0	Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes. This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes. Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt. Fixes #48585. Built from https://develop.svn.wordpress.org/trunk@46815 git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-05 21:32:03 +00:00
Sergey Biryukov	38ad319fdf	I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings. Props ramiy. Fixes #48875. Built from https://develop.svn.wordpress.org/trunk@46812 git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-04 10:36:01 +00:00
Sergey Biryukov	a5e52e04ee	Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`. * Document accepted values for the `$items` parameter. * Use interpolated syntax for the filter name. Props dilipbheda, johnbillion, SergeyBiryukov. Fixes #48857. Built from https://develop.svn.wordpress.org/trunk@46811 git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-03 13:58:05 +00:00
Andrew Ozz	135e608b46	Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original. Fixes #48736. Built from https://develop.svn.wordpress.org/trunk@46809 git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-12-01 18:26:05 +00:00
Sergey Biryukov	0221a593b9	Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile. Props donmhico, jeremyfelt. Fixes #48799. Built from https://develop.svn.wordpress.org/trunk@46807 git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-30 00:42:01 +00:00
Sergey Biryukov	1d1c74385f	REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter. See #48839. Built from https://develop.svn.wordpress.org/trunk@46804 git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-29 22:04:02 +00:00
Sergey Biryukov	2a0489ec49	Docs: Replace `@returns` tags in JS docs with `@return`. Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ See #48303. Built from https://develop.svn.wordpress.org/trunk@46800 git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-29 18:01:03 +00:00
Sergey Biryukov	4a4afbd68c	Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards. Props shital-patel, kalpshit. Fixes #48305. Built from https://develop.svn.wordpress.org/trunk@46799 git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-29 16:56:02 +00:00
Sergey Biryukov	acd0a3ca99	Site Health: Add a test for PHP default timezone. The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`. WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues. Props Rarst, Clorith, TimothyBlynJacobs. Fixes #48692. Built from https://develop.svn.wordpress.org/trunk@46797 git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-28 15:48:03 +00:00
Sergey Biryukov	6f86cedb09	Menus: Improve the wording of instructions for dragging the items into the preferred order. Props amolv, equin0x80, dlh. Fixes #48184. Built from https://develop.svn.wordpress.org/trunk@46791 git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-27 19:51:01 +00:00
Sergey Biryukov	d8b251f0af	Administration: Properly wrap long titles in list tables on smaller screens. Props mukesh27, iihglobal, wpamitkumar. Fixes #48805. Built from https://develop.svn.wordpress.org/trunk@46790 git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-27 16:52:02 +00:00
Dominik Schilling	f4165a697d	Upgrade/Install: Provide a default label for "Continue" button in language selection form. Prevents an empty continue button if a translation isn't yet available. Props sathyapulse. Fixes #48776. Built from https://develop.svn.wordpress.org/trunk@46784 git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-26 15:19:04 +00:00
Sergey Biryukov	63fefb540a	Users: Use correct variable when displaying the Additional Capabilities list in user profile. Addresses a regression in [45926]. Props wpgurudev, aravindajith, anantajitjg, davidbaumwald. Fixes #48725. Built from https://develop.svn.wordpress.org/trunk@46782 git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-25 14:01:03 +00:00
Sergey Biryukov	2a85fe21d8	Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined: * "change your theme completely" * Active theme in the "At a Glance" box * "View all drafts" in the Quick Draft box Split "Manage widgets or menus" into separate items for consistency with other links. For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished. Per accessibility coding standards: > When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined. https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone Props afercia, audrasjb, karmatosed. Fixes #48406. Built from https://develop.svn.wordpress.org/trunk@46770 git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-24 19:57:05 +00:00
Sergey Biryukov	c786eaa1df	Coding Standards: Fix WPCS issue in [46763]. See #48777. Built from https://develop.svn.wordpress.org/trunk@46764 git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-23 19:21:03 +00:00
Sergey Biryukov	26a750e162	Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`. Props sathyapulse, zodiac1978. Fixes #48777. Built from https://develop.svn.wordpress.org/trunk@46763 git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-23 18:51:01 +00:00
Sergey Biryukov	56af5db74f	Editor: Improve the appearance of tag cloud in Tags meta box in classic editor. Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia. Fixes #48592. Built from https://develop.svn.wordpress.org/trunk@46758 git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-22 00:04:02 +00:00
Sergey Biryukov	44d5372825	I18N: Correct translator comment for `By %s` string in Plugins list table. Follow-up to [44541]. See #45898. Built from https://develop.svn.wordpress.org/trunk@46755 git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-21 00:08:02 +00:00
Andrea Fercia	71725aeb95	Accessibility: Add an `aria-current` attribute to the Media Library switch links. The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items. Props mayanksonawat, afercia. Fixes #48271. Built from https://develop.svn.wordpress.org/trunk@46746 git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-18 16:51:02 +00:00
Andrea Fercia	eec579dd86	Widgets: Avoid to move focus to the Image Widget "Insert from URL" field. Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169. Props dufresnesteven. See #43169. Fixes #48588. Built from https://develop.svn.wordpress.org/trunk@46745 git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-18 16:23:02 +00:00
Sergey Biryukov	306045277e	Administration: Switch `rgb()` CSS property for paused plugin error message in Plugins list table to `rgba()`. While technically correct as is, the latter is more consistent with other admin styles and causes less confusion. Props manikmist09. Fixes #48629. Built from https://develop.svn.wordpress.org/trunk@46744 git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-18 13:18:03 +00:00
Sergey Biryukov	5aa3a51264	Docs: Update broken source code link in `WP_Filesystem_SSH2` class. Props mryoga, finchps. Fixes #48467. Built from https://develop.svn.wordpress.org/trunk@46742 git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-17 16:16:02 +00:00
Sergey Biryukov	418db0297e	Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages. Props garrett-eclipse. Fixes #48676. Built from https://develop.svn.wordpress.org/trunk@46739 git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-17 07:43:01 +00:00
Sergey Biryukov	927aa4b44c	Docs: Fix typo in `wp_credits_section_title()` description. Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards. Props hareesh-pillai. Fixes #48674. Built from https://develop.svn.wordpress.org/trunk@46738 git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-16 21:04:01 +00:00
Sergey Biryukov	4ec53dc54c	Docs: Remove incorrect `@return` tags. Props diddledan. Fixes #48613, #48614. Built from https://develop.svn.wordpress.org/trunk@46732 git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-14 09:57:03 +00:00
Sergey Biryukov	6ceb0279af	Help/About: Move images to the CDN. Props ryelle. Fixes #47708. Built from https://develop.svn.wordpress.org/trunk@46724 git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-12 18:30:03 +00:00
Sergey Biryukov	2265c36568	Help/About: Update the 5.3 About page. * Remove extra padding on the Credits tab. Previously [46556], [46572], [46616], [46705]. Props ryelle. See #47708. Built from https://develop.svn.wordpress.org/trunk@46709 git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-11 20:45:04 +00:00
Sergey Biryukov	ba249d8951	Help/About: Update the 5.3 About page. * Remove the SVG from the upper right corner. * Make sure admin notices that should be hidden stay hidden. * Address a11y issues with contrast. * Fix an issue with the active nav tab hover. * Prevent names on the credits from breaking out of the box. * Update two strings with a more accurate information. Previously [46556], [46572], [46616]. Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov. See #47708. Built from https://develop.svn.wordpress.org/trunk@46705 git-svn-id: http://core.svn.wordpress.org/trunk@46505 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-11 16:07:03 +00:00
Sergey Biryukov	3d623995a8	Docs: In various `@return` tags, list the expected type first, instead of `WP_Error`. See #48303. Built from https://develop.svn.wordpress.org/trunk@46696 git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-11 02:43:03 +00:00
Sergey Biryukov	82dfb2d151	Docs: Miscellaneous docblock corrections in `wp-admin/includes/plugin.php`. See #48303. Built from https://develop.svn.wordpress.org/trunk@46695 git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-11 00:05:01 +00:00
Sergey Biryukov	2af39e45cb	Docs: Improve documentation for `deactivate_plugins()` and `activate_plugins()`. Props marekdedic, spenserhale, SergeyBiryukov. Fixes #48352. Built from https://develop.svn.wordpress.org/trunk@46694 git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-10 23:05:03 +00:00
Sergey Biryukov	0e79d4d101	Coding Standards: Fix WPCS issue in [46684]. See #48255. Built from https://develop.svn.wordpress.org/trunk@46687 git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-09 13:33:02 +00:00
Sergey Biryukov	1f816ad18d	Docs: Use the `{@see ...}` tag for the replacement in `@deprecated` tags, so that Developer Reference could automatically link to the replacement. Props jrf. See #48255. Built from https://develop.svn.wordpress.org/trunk@46685 git-svn-id: http://core.svn.wordpress.org/trunk@46485 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-09 13:05:02 +00:00
Sergey Biryukov	f60094679f	Coding Standards: Consistently use `do_action_deprecated()` and `apply_filters_deprecated()` for deprecated hooks. Props jrf. See #48255. Built from https://develop.svn.wordpress.org/trunk@46684 git-svn-id: http://core.svn.wordpress.org/trunk@46484 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-09 12:59:03 +00:00
Sergey Biryukov	ba21b391f6	Docs: Correct some inconsistencies in comments with Dashicon class references in `wp-admin/css/customize-widgets.css`. Prepend all class name references with `dashicons-` for clarity. Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov. Fixes #48417. Built from https://develop.svn.wordpress.org/trunk@46681 git-svn-id: http://core.svn.wordpress.org/trunk@46481 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-09 00:03:02 +00:00
Sergey Biryukov	15a4289c8d	Docs: Correct description for `$recursive` parameter of `::chmod()` and `::delete()` methods in `WP_Filesystem` implementations. Props skithund. Fixes #48422. Built from https://develop.svn.wordpress.org/trunk@46679 git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-08 22:56:02 +00:00
Andrew Ozz	60c2966222	Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold. Props desrosj, azaozz. Fixes #48518 for trunk. Built from https://develop.svn.wordpress.org/trunk@46677 git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-07 18:51:02 +00:00
John Blackbourn	eda6a9e111	Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes. See #48303 Built from https://develop.svn.wordpress.org/trunk@46662 git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-05 21:30:03 +00:00
Andrew Ozz	f9e81c83d5	Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image. Props ianmjones, azaozz. Fixes #48453 for trunk. Built from https://develop.svn.wordpress.org/trunk@46658 git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-05 20:53:03 +00:00
Andrew Ozz	43ed67661a	Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it. See #48472. Built from https://develop.svn.wordpress.org/trunk@46651 git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-04 17:07:03 +00:00
Sergey Biryukov	8b76312eb3	Docs: Correct some array hash notations added in [46644]. See #48303. Built from https://develop.svn.wordpress.org/trunk@46647 git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-04 09:37:02 +00:00
John Blackbourn	b3d6acd6a4	Docs: Fix some incorrect return tags in docblocks. See #48303 Built from https://develop.svn.wordpress.org/trunk@46644 git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-03 22:23:01 +00:00
whyisjake	a87271af60	Login and Registration: Allow email logins to be more flexible. Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen. Fixes #38744 Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake. Built from https://develop.svn.wordpress.org/trunk@46640 git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-03 20:12:02 +00:00
desrosj	583e49d95f	Customize: Formally deprecate unused Customizer classes. The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed. Props weston.ruter, matthias-reuter, jrf. Fixes #42364. Built from https://develop.svn.wordpress.org/trunk@46637 git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-03 16:48:00 +00:00
Sergey Biryukov	2651ff3ae8	Docs: Update URLs in some `@link` tags and switch them to HTTPS. Props tsuyoring. Fixes #48479. Built from https://develop.svn.wordpress.org/trunk@46626 git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-11-01 14:57:02 +00:00
John Blackbourn	d1b23193dd	Docs: Correct some incorrect docblock tags. See #48303 Built from https://develop.svn.wordpress.org/trunk@46623 git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-31 17:51:01 +00:00
Sergey Biryukov	3d76b537d6	Docs: Add `@since` tag for the `$context` parameter added to `wp_generate_attachment_metadata` filter in [46621]. See #48472. Built from https://develop.svn.wordpress.org/trunk@46622 git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-31 00:13:01 +00:00
Andrew Ozz	ed651b17a4	Upload: - Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created. - Add another arg in the `wp_generate_attachment_metadata` filter for additional context. - Fix inline docs and ensure the new image meta is always saved before starting post-processing. Fixes #48472 for trunk. Built from https://develop.svn.wordpress.org/trunk@46621 git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-30 21:10:04 +00:00
desrosj	0b94025ba9	Help/About: Update the 5.3 About page for RC3. Previously [46556], [46572]. Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz. See #47708. Built from https://develop.svn.wordpress.org/trunk@46616 git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-29 20:10:04 +00:00
John Blackbourn	057f661ce3	Docs: Miscellaneous docblock corrections. See #48303 Built from https://develop.svn.wordpress.org/trunk@46610 git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-28 19:48:01 +00:00
John Blackbourn	c8f91f77ac	Docs: Correct invalid hook docblocks. See #48303 Built from https://develop.svn.wordpress.org/trunk@46603 git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-27 19:11:02 +00:00
John Blackbourn	9e2b6902b3	Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection. See #48303 Built from https://develop.svn.wordpress.org/trunk@46597 git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 23:16:04 +00:00
John Blackbourn	3caaa40fc6	Docs: Switch more docs over to typed array notation, plus some fixes. See #48303, #41756 Built from https://develop.svn.wordpress.org/trunk@46596 git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 21:09:04 +00:00
John Blackbourn	7c2b9f2a2e	Docs: Miscellaneous docblock fixes and improvements. See #48303 Built from https://develop.svn.wordpress.org/trunk@46594 git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 20:43:04 +00:00
Sergey Biryukov	67ce1885db	Docs: Improve formatting of various `WP_Screen` DocBlocks. See #48303. Built from https://develop.svn.wordpress.org/trunk@46591 git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 00:36:05 +00:00
Sergey Biryukov	67c73ea3ea	Docs: Improve documentation for `WP_Screen::add_help_tab()`. Props atachibana. Fixes #48395. Built from https://develop.svn.wordpress.org/trunk@46590 git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 00:34:07 +00:00
Sergey Biryukov	49007e52bc	Build/Test Tools: Add banner to RTL CSS and minified JS files. Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated. This is a follow-up to [41271], which added the banner to minified CSS files. Fixes #48424. See #30666. Built from https://develop.svn.wordpress.org/trunk@46589 git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-26 00:17:07 +00:00
Sergey Biryukov	7e11e9d732	Posts, Post Types: Remove unintended change from [46578]. See #48384. Built from https://develop.svn.wordpress.org/trunk@46579 git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-25 12:54:03 +00:00
Sergey Biryukov	0b83bffd45	Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp. Props Rarst. Reviewed by azaozz, SergeyBiryukov. See #48384. Built from https://develop.svn.wordpress.org/trunk@46578 git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-25 12:51:03 +00:00
Andrea Fercia	5b85aa1936	Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241]. Props david.binda, audrasjb, azaozz. See #34904. Fixes #48396. Built from https://develop.svn.wordpress.org/trunk@46575 git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-23 20:57:05 +00:00
desrosj	27994975f9	Help/About: Update the 5.3 About page for RC2. This includes numerous improvements: - Removes the jazzer name. - Ensures `WordPress` is translatable for consistency with other occurrences in Core. - Changes all instances of `Block Editor` to `block editor` to match the spelling best practices. - Updates the PHP 7.4 compatibility section with more suitable text. - Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page. - Fixes the `aria-current` attribute in tab navigation. Reviewed by SergeyBiryukov, desrosj. Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia. See #47708. Built from https://develop.svn.wordpress.org/trunk@46572 git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-22 19:19:07 +00:00
Sergey Biryukov	0609e04266	Administration: Relax the default value check for the `$position` argument added to `add_submenu_page()` and related functions in [46197]. Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues. A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type. Props david.binda, desrosj, 123host, dennis_f, MattyRob. Reviewed by desrosj. Fixes #48249. Built from https://develop.svn.wordpress.org/trunk@46570 git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-22 17:52:04 +00:00
Andrew Ozz	e1560cd1e0	Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append `scaled-` to the file names of the scaled images to make them easier to recognize. Props kraftbj, azaozz. Fixes #48304. Built from https://develop.svn.wordpress.org/trunk@46565 git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-21 21:43:04 +00:00
John Blackbourn	67104bb3f4	Administration: Revert changes to the admin menu styles for long line lengths. This reverts [46555], [46453], and [46332]. See #42201 Built from https://develop.svn.wordpress.org/trunk@46561 git-svn-id: http://core.svn.wordpress.org/trunk@46358 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-17 18:38:03 +00:00
desrosj	1d6bd71ce4	Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing. This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements. Follow up of [46455]. Reviewed by desrosj, jorbin, johnbillion. Fixes #47699. Built from https://develop.svn.wordpress.org/trunk@46560 git-svn-id: http://core.svn.wordpress.org/trunk@46357 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-16 21:03:02 +00:00
Andrea Fercia	44de60e8da	Script Loader: Partially revert [46550] as it brought in unrelated CSS changes. [46550] was meant to revert [46440] but it also merged some unrelated CSS changes. See #47069. Built from https://develop.svn.wordpress.org/trunk@46559 git-svn-id: http://core.svn.wordpress.org/trunk@46356 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-16 17:49:03 +00:00
John Blackbourn	2ab1e4dcd8	Help/About: Let's tell the world about 5.3. Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald Thanks to everyone who provided feedback for this page for 5.3. See #47708 Built from https://develop.svn.wordpress.org/trunk@46556 git-svn-id: http://core.svn.wordpress.org/trunk@46353 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-15 20:42:03 +00:00
John Blackbourn	7cdb93a374	Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed. Props afercia, amolv, sabernhardt Fixes #42201, #48294 Built from https://develop.svn.wordpress.org/trunk@46555 git-svn-id: http://core.svn.wordpress.org/trunk@46352 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-15 19:39:01 +00:00
Andrea Fercia	02810533c4	Accessibility: Script Loader: Remove jQuery as dependency of `admin-bar` after [46440]. A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins. See #47069. Built from https://develop.svn.wordpress.org/trunk@46550 git-svn-id: http://core.svn.wordpress.org/trunk@46347 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-15 17:23:04 +00:00
Andrew Ozz	1940cf7d54	Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging. Fixes #40439. Built from https://develop.svn.wordpress.org/trunk@46507 git-svn-id: http://core.svn.wordpress.org/trunk@46304 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-14 20:05:01 +00:00
Sergey Biryukov	b0e0f69b2e	I18N: Don't capitalize "Extension" in `update_core()`, for consistency with other strings. Follow-up to [46455]. See #47699. Built from https://develop.svn.wordpress.org/trunk@46464 git-svn-id: http://core.svn.wordpress.org/trunk@46262 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-12 02:42:01 +00:00
Sergey Biryukov	e19329bad0	Docs: Add `requires_php` to the list of fields returned by `plugins_api()`. Props ediamin. Fixes #48291. Built from https://develop.svn.wordpress.org/trunk@46463 git-svn-id: http://core.svn.wordpress.org/trunk@46261 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-12 02:35:04 +00:00
antpb	ebd52ce048	Administration: Prevents horizontal scroll jumping around while admin menu is open. This sets the `#adminmenuback` `position` CSS property to `fixed`. Props promz, man4toman. Fixes #47010. Built from https://develop.svn.wordpress.org/trunk@46460 git-svn-id: http://core.svn.wordpress.org/trunk@46258 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-11 19:22:02 +00:00
Mike Schroder	66c8085fc4	Media: Update fallback previews to support `_wp_make_subsizes()` Allows fallback previews (PDF by default, in core) to save image meta after each size is generated to allow for resuming, and make sizes immediately available. Props azaozz, antpb, progremzion, mikeschroder. See #48111. Built from https://develop.svn.wordpress.org/trunk@46459 git-svn-id: http://core.svn.wordpress.org/trunk@46257 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-11 07:54:03 +00:00
desrosj	c6d3987b08	Upgrade/Install: Detect the presence of the native PHP JSON extension before updating. The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]). However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues. Props jrf, jorbin, dd32, desrosj. Fixes #47699. Built from https://develop.svn.wordpress.org/trunk@46455 git-svn-id: http://core.svn.wordpress.org/trunk@46253 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-09 22:22:04 +00:00
whyisjake	ec02d199f4	Administration: Ensure visual consistency with large titles in the sidebar. Custom posts, and other menu titles that are long aren't wrapping correctly. Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald. Fixes #42201 Built from https://develop.svn.wordpress.org/trunk@46453 git-svn-id: http://core.svn.wordpress.org/trunk@46251 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-09 04:58:02 +00:00
Sergey Biryukov	8d1e51e9c7	Docs: Add a `@since` note about new parameters with the spread operator added to function signatures. Props jrf. See #47678. Built from https://develop.svn.wordpress.org/trunk@46451 git-svn-id: http://core.svn.wordpress.org/trunk@46249 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-09 04:28:02 +00:00
Sergey Biryukov	843c39b9bc	Themes: Properly align Close/Previous/Next icons in theme preview overlay. Props chetan200891. Fixes #48248. Built from https://develop.svn.wordpress.org/trunk@46444 git-svn-id: http://core.svn.wordpress.org/trunk@46242 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-08 19:07:04 +00:00
Sergey Biryukov	93279742c1	Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu. Props chetan200891. Fixes #48250. Built from https://develop.svn.wordpress.org/trunk@46443 git-svn-id: http://core.svn.wordpress.org/trunk@46241 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-08 18:49:03 +00:00
johnjamesjacoby	477f0ffd71	Network Admin: Improve Site States in List Table rows. This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.) Fixes #37684. Props pbiron. Built from https://develop.svn.wordpress.org/trunk@46441 git-svn-id: http://core.svn.wordpress.org/trunk@46239 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-08 17:46:02 +00:00
Sergey Biryukov	760a55b310	Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files. Props jrf. Fixes #48254. Built from https://develop.svn.wordpress.org/trunk@46439 git-svn-id: http://core.svn.wordpress.org/trunk@46237 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-08 17:19:04 +00:00
Andrea Fercia	92f09c0496	Accessibility: Improve and modernize user interface controls: Revert the new links focus style. Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus. It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle. Partially reverts [46241] and [46293]. See #34904, #47153. Built from https://develop.svn.wordpress.org/trunk@46425 git-svn-id: http://core.svn.wordpress.org/trunk@46223 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-07 19:57:02 +00:00
Andrea Fercia	3a27f92158	Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class. - improves the buttons `.active` CSS class for buttons that need to be styled as "pressed" - update the alternate color schemes `.active` CSS class accordingly - improves a few icons colors in the alternate color schemes See #34904. Built from https://develop.svn.wordpress.org/trunk@46423 git-svn-id: http://core.svn.wordpress.org/trunk@46221 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-07 18:47:05 +00:00
Andrew Ozz	f793398e4f	Upload: Set custom header with the attachment ID for all uploads from `media_handle_upload()`. Let the REST API endpoint set it separately. Props timothyblynjacobs. Fixes #48200. Built from https://develop.svn.wordpress.org/trunk@46421 git-svn-id: http://core.svn.wordpress.org/trunk@46219 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-07 15:30:02 +00:00
Andrea Fercia	e9065659f4	Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments. - improves input fields height in the customizer - improves input fields height for Internet Explorer 11 - improves input fields height in the Image Editor - improves alignment of selects and buttons in the privacy policy pages - makes the search themes fields font-size consistent Props garrett-eclipse, afercia. See #47477. Built from https://develop.svn.wordpress.org/trunk@46419 git-svn-id: http://core.svn.wordpress.org/trunk@46217 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-07 13:20:03 +00:00
Andrea Fercia	1f3d583825	Accessibility: Media: Improve the search media field labelling. Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels. Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format. Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example: - users with cognitive disabilities may have trouble remembering what the filled field does - speech recognition users cannot see the name they can speak to set focus on the field - low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia. See #40331. Fixes #47138. Built from https://develop.svn.wordpress.org/trunk@46418 git-svn-id: http://core.svn.wordpress.org/trunk@46216 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-07 12:43:03 +00:00
whyisjake	ea5d76fbb2	Privacy: Ensure that sending email, and remove data follow the same user experience. Both personal data request processes should follow the same convention. Fixes: #43974. Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@46412 git-svn-id: http://core.svn.wordpress.org/trunk@46210 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-06 06:56:02 +00:00
whyisjake	4269998771	Administration: Add a max-width to the Privacy Policy Page dropdown. If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width. Fixes #47366 Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07. Built from https://develop.svn.wordpress.org/trunk@46411 git-svn-id: http://core.svn.wordpress.org/trunk@46209 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-06 06:42:02 +00:00
Sergey Biryukov	554b60da76	Docs: Format comments in `wp-admin/includes/plugin.php` as per the documentation standards. Props dkarfa. Fixes #48191. Built from https://develop.svn.wordpress.org/trunk@46410 git-svn-id: http://core.svn.wordpress.org/trunk@46208 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-06 02:23:03 +00:00
Aaron Jorbin	ebd841790b	Build/Test: Update Grunt Uglify options Follow up to [46408] Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously. See #48203. Built from https://develop.svn.wordpress.org/trunk@46409 git-svn-id: http://core.svn.wordpress.org/trunk@46207 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 22:01:04 +00:00
Aaron Jorbin	0e21d32900	Build/Test: Bump devDependencies for WordPress 5.3 This upgrades a number of devDependencies. Some of these include changes to how the tasks are configured. Uglify: There are deprecated options from 2.x to 4.x, see: https://github.com/gruntjs/grunt-contrib-uglify#options Autoprefixer: Browserslist now warns when passing in the browser list, so that is put into package.json As with most changes to uglify, this changes every minified JS file. Fixes #48203. Built from https://develop.svn.wordpress.org/trunk@46408 git-svn-id: http://core.svn.wordpress.org/trunk@46206 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 19:49:10 +00:00
Sergey Biryukov	3520f5234b	Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields. Props garrett-eclipse, dkarfa. Fixes #48188. Built from https://develop.svn.wordpress.org/trunk@46405 git-svn-id: http://core.svn.wordpress.org/trunk@46204 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 15:41:57 +00:00
Aaron Jorbin	a92b23ee61	Build/Test tools: Update grunt-contrib-imagemin and run it Smaller images are good, so is not having npm vulnerabilities. See #48203. Fixes #48206. Props whyisjake, netweb. Built from https://develop.svn.wordpress.org/trunk@46404 git-svn-id: http://core.svn.wordpress.org/trunk@46203 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 14:20:59 +00:00
Sergey Biryukov	f1b5f2aa94	Site Health: Improve the wording for `UTF8MB4` test description. Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans. Fixes #48044. Built from https://develop.svn.wordpress.org/trunk@46402 git-svn-id: http://core.svn.wordpress.org/trunk@46201 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 02:39:58 +00:00
Sergey Biryukov	2237306c2b	Customize: Remove duplicate `attr_title` assignment in `api.Menus.MenuItemControl.renderContent()`. See #47838. Built from https://develop.svn.wordpress.org/trunk@46401 git-svn-id: http://core.svn.wordpress.org/trunk@46200 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 02:32:58 +00:00
Sergey Biryukov	f19ecd19de	Filesystem API: Use strict type check in the `in_array()` call for the `$skip_list` parameter in `copy_dir()` and `_copy_dir()`. This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped. Props codex-m. Fixes #46581. Built from https://develop.svn.wordpress.org/trunk@46400 git-svn-id: http://core.svn.wordpress.org/trunk@46199 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 02:16:56 +00:00
Sergey Biryukov	30913bc9a2	Docs: Correct formatting of the `@return` value description in `_wp_handle_upload()`. See #47110. Built from https://develop.svn.wordpress.org/trunk@46399 git-svn-id: http://core.svn.wordpress.org/trunk@46198 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 02:09:57 +00:00
Sergey Biryukov	60617d471b	Docs: Add missing documentation for the first parameter of the `big_image_size_threshold` filter. Props dkarfa, desrosj, earnjam. Fixes #48214. Built from https://develop.svn.wordpress.org/trunk@46398 git-svn-id: http://core.svn.wordpress.org/trunk@46197 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-05 01:30:58 +00:00
Sergey Biryukov	d2a48496d2	Docs: Add missing description for `$comment` global. Props immeet94, mukesh27. Fixes #46928. See #47110. Built from https://develop.svn.wordpress.org/trunk@46391 git-svn-id: http://core.svn.wordpress.org/trunk@46190 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 22:19:57 +00:00
Sergey Biryukov	f34db2aa7e	I18N: Add missing comma in a translator comment. See #47515. Built from https://develop.svn.wordpress.org/trunk@46390 git-svn-id: http://core.svn.wordpress.org/trunk@46189 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 22:09:57 +00:00
Dominik Schilling	d38d1c2c35	I18N: Fix translator comment for a themes list table string with numbered placeholders. Props garrett-eclipse. Fixes #47515. Built from https://develop.svn.wordpress.org/trunk@46387 git-svn-id: http://core.svn.wordpress.org/trunk@46186 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 20:20:58 +00:00
Dominik Schilling	6f38c7fb81	Docs: Convert 'Block Editor' to lowercase. Props garrett-eclipse. Fixes #45634. Built from https://develop.svn.wordpress.org/trunk@46386 git-svn-id: http://core.svn.wordpress.org/trunk@46185 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 20:12:58 +00:00
Dominik Schilling	cd6110782e	Networks and Sites: Improve newly added strings for i18n. * Remove unnecessary numbered placeholders. * Add context to "All" and "Spam" status. * Add translator comments. Props pedromendonca. Fixes #48210. Built from https://develop.svn.wordpress.org/trunk@46385 git-svn-id: http://core.svn.wordpress.org/trunk@46184 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 19:58:55 +00:00
desrosj	143b5fd080	Networks and Sites: Fix issues processing additional fields displayed for the Sites list table. This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values. Props pbiron. Fixes #45954. Built from https://develop.svn.wordpress.org/trunk@46384 git-svn-id: http://core.svn.wordpress.org/trunk@46183 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-04 14:32:56 +00:00
Andrew Ozz	ff225c8bfc	Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup. Props timothyblynjacobs, clorith, azaozz. Fixes #48200. Built from https://develop.svn.wordpress.org/trunk@46382 git-svn-id: http://core.svn.wordpress.org/trunk@46181 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-03 21:02:00 +00:00
desrosj	efa9da7446	Docs: Fix code example for removing internal pointers. Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj. Fixes #45529. Built from https://develop.svn.wordpress.org/trunk@46381 git-svn-id: http://core.svn.wordpress.org/trunk@46180 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-03 20:39:58 +00:00
desrosj	6a0f3ddae3	Menus: Fix typo in the class attribute for the hidden `title` field in `Walker_Nav_Menu_Checklist`. Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu. The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item. Props yanngarcia, davidbaumwald. See #47838. Built from https://develop.svn.wordpress.org/trunk@46380 git-svn-id: http://core.svn.wordpress.org/trunk@46179 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-03 20:03:56 +00:00
Sergey Biryukov	3e40f12574	Privacy: Remove unused `$wpdb` global in `WP_Privacy_Requests_Table::prepare_items()`. Props david.binda. Fixes #48178. Built from https://develop.svn.wordpress.org/trunk@46374 git-svn-id: http://core.svn.wordpress.org/trunk@46173 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-02 23:22:58 +00:00
Andrea Fercia	4b939d5a93	Login and Registration: Hide the Edge browser "Reveal password" native button. Props Clorith. Fixes #42888. Built from https://develop.svn.wordpress.org/trunk@46372 git-svn-id: http://core.svn.wordpress.org/trunk@46171 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-01 18:01:01 +00:00
Andrea Fercia	da00051294	Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements. - allows the login input fields to better scale with text - improves the input fields layout on Internet Explorer 11 - uses the new focus style on the "Show password" button - adjusts the CSS for the interim login See #47153. See #42888. Built from https://develop.svn.wordpress.org/trunk@46371 git-svn-id: http://core.svn.wordpress.org/trunk@46170 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-01 15:55:57 +00:00
Sergey Biryukov	44c3cefb24	Docs: Fix typo in `wp_get_missing_image_subsizes()` DocBlock. Props david.binda. Fixes #48179. Built from https://develop.svn.wordpress.org/trunk@46368 git-svn-id: http://core.svn.wordpress.org/trunk@46167 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-10-01 01:19:57 +00:00
Andrea Fercia	f86d225d26	Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker. Props audrasjb, garrett-eclipse. Fixes #48131. Built from https://develop.svn.wordpress.org/trunk@46360 git-svn-id: http://core.svn.wordpress.org/trunk@46159 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 18:05:59 +00:00
antpb	6531c237e7	Media: Prevents clipping of text when scaling image edit screen. This reapplies [46354] clean as the previous commit had remnants of an unrelated patch. Props sabernhardt, audrasjb, afercia. See #47115. Built from https://develop.svn.wordpress.org/trunk@46359 git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2019-09-30 17:56:57 +00:00

... 3 4 5 6 7 ...

18316 Commits