Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-05 02:10:45 +01:00
Code Issues Projects Releases Wiki Activity
40,764 Commits 50 Branches 747 Tags 789 MiB
6d40400756
Commit Graph

27971 Commits

Author SHA1 Message Date
Sergey Biryukov
6d40400756 Coding Standards: Use strict comparison in wp-admin/edit-tags.php. 
Props passoniate.
Fixes #48985.
Built from https://develop.svn.wordpress.org/trunk@46962


git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 10:46:02 +00:00
Sergey Biryukov
087282e810 Coding Standards: Use strict comparison in wp-admin/term.php. 
Props vinita29.
Fixes #48983.
Built from https://develop.svn.wordpress.org/trunk@46961


git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 09:45:01 +00:00
Sergey Biryukov
35b29f11b3 Coding Standards: Add missing braces to if conditions in js/_enqueues/wp/util.js. 
Props ankitmaru.
Fixes #48980.
Built from https://develop.svn.wordpress.org/trunk@46960


git-svn-id: http://core.svn.wordpress.org/trunk@46760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-15 08:45:05 +00:00
Sergey Biryukov
1b675c6e4a Formatting: Return early from wp_kses_attr_check() if the element is not in the list of allowed elements and attributes. 
Props krynes, tristanleboss.
Fixes #48549.
Built from https://develop.svn.wordpress.org/trunk@46959


git-svn-id: http://core.svn.wordpress.org/trunk@46759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-14 15:53:06 +00:00
Sergey Biryukov
8260786e64 Docs: Clarify descriptions for get_gmt_from_date() and get_date_from_gmt(). 
Props johnbillion, Rarst.
Fixes #48650.
Built from https://develop.svn.wordpress.org/trunk@46958


git-svn-id: http://core.svn.wordpress.org/trunk@46757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-13 21:45:02 +00:00
Sergey Biryukov
0b8438a6d2 I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders. 
Props ramiy.
Fixes #48863.
Built from https://develop.svn.wordpress.org/trunk@46957


git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-13 21:27:05 +00:00
ianbelanger
48692b6524 Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1. 
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.

Props audrasjb, sinatrateam, SergeyBiryukov
Fixes #48944.
Built from https://develop.svn.wordpress.org/trunk@46902


git-svn-id: http://core.svn.wordpress.org/trunk@46702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 18:26:03 +00:00
whyisjake
317465e2fe Prevent stored XSS in the block editor. 
Prevent escaped unicode characters become unescaped in unsafe HTML during JSON decoding.

Props: aduth, epiqueras, 

Built from https://develop.svn.wordpress.org/trunk@46896


git-svn-id: http://core.svn.wordpress.org/trunk@46696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 18:02:03 +00:00
whyisjake
84e4c8531a Update wp_kses_bad_protocol() to recognize : on uri attributes, 
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Props: xknown, nickdaugherty, peterwilsoncc.

Built from https://develop.svn.wordpress.org/trunk@46895


git-svn-id: http://core.svn.wordpress.org/trunk@46695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:55:05 +00:00
whyisjake
80eab318eb Prevent stored XSS through wp_targeted_link_rel(). 
Props: vortfu, whyisjake, peterwilsoncc, xknown,  SergeyBiryukov, flaviozavan.


Built from https://develop.svn.wordpress.org/trunk@46894


git-svn-id: http://core.svn.wordpress.org/trunk@46694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:54:02 +00:00
whyisjake
9e87c5b7b4 Ensure that a user can publish_posts before making a post sticky. 
Props: danielbachhuber, whyisjake, peterwilson, xknown.


Built from https://develop.svn.wordpress.org/trunk@46893


git-svn-id: http://core.svn.wordpress.org/trunk@46693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 17:52:02 +00:00
Sergey Biryukov
99f11a6af2 Docs: Update description for get_categories() to avoid suggesting the deprecated type argument. 
Follow-up to [13754].

Props dingo_d.
Fixes #48913.
Built from https://develop.svn.wordpress.org/trunk@46891


git-svn-id: http://core.svn.wordpress.org/trunk@46691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-12 16:47:05 +00:00
Sergey Biryukov
db18e7d50b Upgrade/Install: Improve the appearance of language selection on install: 
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Fixes #48927.
Built from https://develop.svn.wordpress.org/trunk@46887


git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 23:03:03 +00:00
Sergey Biryukov
c87fccd74f Comments: Avoid a PHP notice in comment_form() if the email field is not set. 
Follow-up to [46090].

Props mat-lipe.
Fixes #48943.
Built from https://develop.svn.wordpress.org/trunk@46885


git-svn-id: http://core.svn.wordpress.org/trunk@46685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 22:14:02 +00:00
Andrew Ozz
eb38423e22 Fixes in admin-bar.js: 
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.

Props dinhtungdu, azaozz.
Fixes #47069.
Built from https://develop.svn.wordpress.org/trunk@46883


git-svn-id: http://core.svn.wordpress.org/trunk@46683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 18:56:03 +00:00
Sergey Biryukov
f8964463c1 Tests: Docs: Correct @param formatting in SpeedTrapListener after [35226] and [45607]. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46882


git-svn-id: http://core.svn.wordpress.org/trunk@46682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 15:48:03 +00:00
Sergey Biryukov
c48b359227 Tests: Correct the slowThreshold option name for SpeedTrapListener. 
The previous change in [45607] appears to be accidental.

Props Rarst.
Fixes #48933.
Built from https://develop.svn.wordpress.org/trunk@46881


git-svn-id: http://core.svn.wordpress.org/trunk@46681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 15:42:06 +00:00
Sergey Biryukov
9b91ffde04 Docs: Improve documentation for wp_dashboard_browser_nag() and dashboard_browser_nag_class(). 
Props grapplerulrich.
Fixes #48932.
Built from https://develop.svn.wordpress.org/trunk@46880


git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-11 10:59:05 +00:00
Andrew Ozz
b639963d7a TinyMCE: remove CSS map reference from /tinymce/skins/lightgray/skin.min.css. 
Props AlexHolsgrove.
Fixes #48577.
Built from https://develop.svn.wordpress.org/trunk@46879


git-svn-id: http://core.svn.wordpress.org/trunk@46679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 18:33:05 +00:00
Sergey Biryukov
aa919cd160 Comments: Optimize the query for pending comments count in wp_notify_moderator() for better performance on large tables. 
Props sgoen.
Fixes #48514.
Built from https://develop.svn.wordpress.org/trunk@46878


git-svn-id: http://core.svn.wordpress.org/trunk@46678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 13:47:00 +00:00
Sergey Biryukov
ee58f3f3d3 Coding Standards: Fix WPCS and JSHint issues in [46872]. 
See #47069.
Built from https://develop.svn.wordpress.org/trunk@46874


git-svn-id: http://core.svn.wordpress.org/trunk@46674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:34:01 +00:00
Andrew Ozz
d617011afd Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package. 
Props dinhtungdu, audrasjb, azaozz.
Fixes #47069.
Built from https://develop.svn.wordpress.org/trunk@46872


git-svn-id: http://core.svn.wordpress.org/trunk@46672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-10 01:03:02 +00:00
Sergey Biryukov
0524d9b781 Block Editor: Resolve @wordpress/block-directory to the expected version, 1.0.6. 
Follow-up to [46860].

Props aduth, garrett-eclipse, audrasjb, azaozz.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46870


git-svn-id: http://core.svn.wordpress.org/trunk@46670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 22:29:08 +00:00
Sergey Biryukov
6ddf02b188 Menus: Avoid a PHP warning in add_submenu_page() when the same value is passed for both $parent_slug and $menu_slug parameters. 
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599.
Built from https://develop.svn.wordpress.org/trunk@46868


git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 21:03:02 +00:00
Sergey Biryukov
a209908501 Administration: Standardize form control height and alignment across the admin. 
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420.
Built from https://develop.svn.wordpress.org/trunk@46866


git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 20:26:03 +00:00
Sergey Biryukov
1dcf3eef7a Date/Time: XML-RPC: Сalculate the proper offset for GMT in wp.newPost, wp.editComment, mw.newPost, mw.editPost when post_date or comment_date is set. 
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Fixes #30429.
Built from https://develop.svn.wordpress.org/trunk@46864


git-svn-id: http://core.svn.wordpress.org/trunk@46664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 19:56:05 +00:00
Sergey Biryukov
098273f1d3 Date/Time: When determining whether to decline the month name in wp_maybe_decline_date(), take word boundaries into account. 
Add more unit tests.

Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Fixes #48606.
Built from https://develop.svn.wordpress.org/trunk@46862


git-svn-id: http://core.svn.wordpress.org/trunk@46662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 18:50:06 +00:00
Sergey Biryukov
a227c231a2 Block Editor: Bug fixes targeted for WordPress 5.3.1. 
The list of included fixes:

- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Fixes #48884.
Built from https://develop.svn.wordpress.org/trunk@46860


git-svn-id: http://core.svn.wordpress.org/trunk@46660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 17:37:10 +00:00
Sergey Biryukov
d4ef90b236 Upgrade/Install: Update sodium_compat to v1.12.1. 
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Fixes #48371.
Built from https://develop.svn.wordpress.org/trunk@46858


git-svn-id: http://core.svn.wordpress.org/trunk@46658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:42:04 +00:00
Sergey Biryukov
dd47d5aa81 Media: Use consistent width for Scale and Crop inputs. 
Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.
Built from https://develop.svn.wordpress.org/trunk@46856


git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:23:02 +00:00
Sergey Biryukov
303180b392 Twenty Twenty: Adjust the comment in [46851] per the documentation standards. 
See #48876.
Built from https://develop.svn.wordpress.org/trunk@46854


git-svn-id: http://core.svn.wordpress.org/trunk@46654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 16:18:02 +00:00
Sergey Biryukov
9648c368f0 Help/About: Add a hover effect for links on About pages. 
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582.
Built from https://develop.svn.wordpress.org/trunk@46852


git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:31:05 +00:00
ianbelanger
48fbea17d6 Bundled Themes: Misaligned input placeholder text Twenty Twenty. 
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal.
Fixes #48876.
Built from https://develop.svn.wordpress.org/trunk@46851


git-svn-id: http://core.svn.wordpress.org/trunk@46651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:10:00 +00:00
Sergey Biryukov
35985cbf38 Twenty Twenty: Remove redundant echo for bloginfo() call in footer.php. 
Props acosmin.
Fixes #48918.
Built from https://develop.svn.wordpress.org/trunk@46849


git-svn-id: http://core.svn.wordpress.org/trunk@46649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 15:00:01 +00:00
Sergey Biryukov
dcf0cb68a2 Administration: Correct checkbox width in list tables on smaller screens. 
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815.
Built from https://develop.svn.wordpress.org/trunk@46845


git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:26:02 +00:00
ianbelanger
b051b9a0d4 Bundled Themes: Make checkbox in comment form larger Twenty Twenty. 
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb.
Fixes #48652.
Built from https://develop.svn.wordpress.org/trunk@46844


git-svn-id: http://core.svn.wordpress.org/trunk@46644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 14:08:03 +00:00
Sergey Biryukov
ac690426eb Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created. 
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409.
Built from https://develop.svn.wordpress.org/trunk@46842


git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:49:03 +00:00
Sergey Biryukov
23f45f0346 Twenty Twenty: Correct alignment for embedded Instagram posts. 
Props SGr33n, audrasjb, nielslange, JarretC.
Fixes #48688.
Built from https://develop.svn.wordpress.org/trunk@46840


git-svn-id: http://core.svn.wordpress.org/trunk@46640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:39:03 +00:00
Sergey Biryukov
87a759b81c Users: Introduce admin_email_remind_interval filter for dismissing the admin email confirmation screen. 
Props desrosj, birgire.
Fixes #48334.
Built from https://develop.svn.wordpress.org/trunk@46838


git-svn-id: http://core.svn.wordpress.org/trunk@46638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:26:02 +00:00
Sergey Biryukov
adf1792adc Docs: Correct DocBlock formatting for admin_email_confirm and admin_email_confirm_form hooks. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46837


git-svn-id: http://core.svn.wordpress.org/trunk@46637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 13:10:01 +00:00
Sergey Biryukov
4b333de597 Tests: Change group annotation for test_unique_filename_with_dimension_like_filename() to `ticket. 
See #42437.
Built from https://develop.svn.wordpress.org/trunk@46835


git-svn-id: http://core.svn.wordpress.org/trunk@46635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 12:18:01 +00:00
Sergey Biryukov
6c49066de7 Twenty Twenty: Pass $post_meta and $location values to twentytwenty_start_of_post_meta_list and twentytwenty_end_of_post_meta_list actions to provide better context. 
Props msaari, SergeyBiryukov.
Fixes #48906.
Built from https://develop.svn.wordpress.org/trunk@46832


git-svn-id: http://core.svn.wordpress.org/trunk@46632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 11:49:02 +00:00
Sergey Biryukov
8da965a5b8 Tests: Make sure network factory returns an integer ID for created objects, for consistency with other factories and the documented value. 
See #48145.
Built from https://develop.svn.wordpress.org/trunk@46831


git-svn-id: http://core.svn.wordpress.org/trunk@46631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 11:31:01 +00:00
Sergey Biryukov
e70c88213f Tests: Pad incrementors used in factories with leading zeros to make sure MySQL sorting works as expected. 
Previously, tests could create sequential objects with names like `Term 99`, `Term 100`, which by default would be returned in reverse order when sorted by name alphabetically, causing seemingly random test failures that are extremely hard to debug.

See #48145.
Built from https://develop.svn.wordpress.org/trunk@46830


git-svn-id: http://core.svn.wordpress.org/trunk@46630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-09 10:41:05 +00:00
Sergey Biryukov
860fc16954 Tests: Speed up comment submission unit tests by creating less fixtures and reusing them where possible. 
See #30017, #48145.
Built from https://develop.svn.wordpress.org/trunk@46829


git-svn-id: http://core.svn.wordpress.org/trunk@46629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-08 18:02:07 +00:00
Sergey Biryukov
f11d28a779 Twenty Twenty: Use duplicate hook references for page_css_class and page_menu_link_attributes filters in TwentyTwenty_Walker_Page. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46828


git-svn-id: http://core.svn.wordpress.org/trunk@46628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 14:03:03 +00:00
Sergey Biryukov
6677070a13 Bundled Themes: Correct @since tags to refer to the theme version instead of WordPress version. 
This makes `@since` notations in Twenty Seventeen, Twenty Nineteen, and Twenty Twenty consistent with the previous bundled themes.

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46827


git-svn-id: http://core.svn.wordpress.org/trunk@46627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 13:56:06 +00:00
John Blackbourn
d53103ed62 Docs: Further docblock corrections and improvements. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826


git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 13:23:01 +00:00
Sergey Biryukov
0f971e68ec Twenty Twenty: Replace Smooth Scroll JS implementation with scroll-behavior CSS property. 
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Fixes #48763, #48551, #48866.
Built from https://develop.svn.wordpress.org/trunk@46824


git-svn-id: http://core.svn.wordpress.org/trunk@46624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-07 11:05:01 +00:00
John Blackbourn
f93ee2ca76 Docs: Increase the specificity of various docblock parameter types and return types. 
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823


git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-12-06 22:43:04 +00:00