Commit Graph

152 Commits

Author SHA1 Message Date
Drew Jaynes
c3055cc190 Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37488


git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:01:30 +00:00
Pascal Birchler
026ed07458 Admin: Fix default avatar handling in Settings -> Discussion.
By passing the `force_default` argument to `get_avatar()` instead of using `preg_replace`, we make it easier for developers to override the output.

Props henry.wright.
Fixes #34744.
Built from https://develop.svn.wordpress.org/trunk@37227


git-svn-id: http://core.svn.wordpress.org/trunk@37193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-04-17 10:19:28 +00:00
Boone Gorges
3eab09a694 Don't force comment pagination.
[34561] instituted the policy of forcing pagination for comments. This strategy
was intended to avert problems when 'page_comments' is set to 0 - as it is by
default - and the number of comments on a given post rises into the hundreds or
thousands. By forcing pagination in all cases, we ensured that WordPress would
not time out by processing unwieldy numbers of comments on a given pageload.

The strategy proves problematic, however, because comment permalinks are
generated using the page of the comment. Forcing pagination for posts that
were not previously paginated would change the URL of all comments that do not
appear on the default comment page.

This changeset reintroduces the 'page_comments' setting and its corresponding
checkbox on Settings > Discussion. A number of tests, which were written after
[34561], are modified to work now that 'page_comments' will, once again, be
disabled by default.

See #8071.
Built from https://develop.svn.wordpress.org/trunk@35331


git-svn-id: http://core.svn.wordpress.org/trunk@35297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 16:26:42 +00:00
Helen Hou-Sandí
1bacb00c01 Comments: Trash blacklisted comments by default.
If trash is disabled, they wil continue to go into spam like they do now.

props wonderboymusic, solarissmoke, MikeHansenMe.
fixes #7051.

Built from https://develop.svn.wordpress.org/trunk@34726


git-svn-id: http://core.svn.wordpress.org/trunk@34690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-01 01:49:25 +00:00
Boone Gorges
18d6b3c8dc Force comment pagination on single posts.
Previously, the 'page_comments' toggle allowed users to disable comment
pagination. This toggle was only superficial, however. Even with
'page_comments' turned on, `comments_template()` loaded all of a post's
comments into memory, and passed them to `wp_list_comments()` and
`Walker_Comment`, the latter of which produced markup for only the
current page of comments. In other words, it was possible to enable
'page_comments', thereby showing only a subset of a post's comments on a given
page, but all comments continued to be loaded in the background. This technique
scaled poorly. Posts with hundreds or thousands of comments would load slowly,
or not at all, even when the 'comments_per_page' setting was set to a
reasonable number.

Recent changesets have addressed this problem through more efficient tree-
walking, better descendant caching, and more selective queries for top-level
post comments. The current changeset completes the project by addressing the
root issue: that loading a post causes all of its comments to be loaded too.

Here's the breakdown:

* Comment pagination is now forced. Setting 'page_comments' to false leads to evil things when you have many comments. If you want to avoid pagination, set 'comments_per_page' to something high.
* The 'page_comments' setting has been expunged from options-discussion.php, and from places in the codebase where it was referenced. For plugins relying on 'page_comments', we now force the value to `true` with a `pre_option` filter.
* `comments_template()` now queries for an appropriately small number of comments. Usually, this means the `comments_per_page` value.
* To preserve the current (odd) behavior for comment pagination links, some unholy hacks have been inserted into `comments_template()`. The ugliness is insulated in this function for backward compatibility and to minimize collateral damage. A side-effect is that, for certain settings of 'default_comments_page', up to 2x the value of `comments_per_page` might be fetched at a time.
* In support of these changes, a `$format` parameter has been added to `WP_Comment::get_children()`. This param allows you to request a flattened array of comment children, suitable for feeding into `Walker_Comment`.
* `WP_Query` loops are now informed about total available comment counts and comment pages by the `WP_Comment_Query` (`found_comments`, `max_num_pages`), instead of by `Walker_Comment`.

Aside from radical performance improvements in the case of a post with many
comments, this changeset fixes a bug that caused the first page of comments to
be partial (`found_comments` % `comments_per_page`), rather than the last, as
you'd expect.

Props boonebgorges, wonderboymusic.
Fixes #8071.
Built from https://develop.svn.wordpress.org/trunk@34561


git-svn-id: http://core.svn.wordpress.org/trunk@34525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 20:40:25 +00:00
Scott Taylor
1d68ccec25 Move ad hoc Options functions to wp-admin/includes/options.php:
* Move `options_discussion_add_js()` from `wp-admin/options-discussion.php`
* Move `options_general_add_js()` from `wp-admin/options-general.php`
* Move `options_permalink_add_js()` from `wp-admin/options-permalink.php`
* Move `options_reading_add_js()` from `wp-admin/options-reading.php`
* Move `options_reading_blog_charset()` from `wp-admin/options-reading.php`

See #33813.

Built from https://develop.svn.wordpress.org/trunk@34022


git-svn-id: http://core.svn.wordpress.org/trunk@33991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 21:45:24 +00:00
Scott Taylor
acc7f66cf9 Bump H3 headings to H2 on the Discussion Settings screen for better accessibility.
Props mrahmadawais.
Fixes #33609.

Built from https://develop.svn.wordpress.org/trunk@33916


git-svn-id: http://core.svn.wordpress.org/trunk@33885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 20:14:24 +00:00
Helen Hou-Sandí
1f500055a6 Drop the hyphen from e-mail and standardize on email.
The AP Stylebook changed this in 2011, and we're woefully inconsistent, so let's go with the standard.

props morganestes, voldemortensen, niallkennedy (for patching on the previous AP style).
fixes #26156.

Built from https://develop.svn.wordpress.org/trunk@33774


git-svn-id: http://core.svn.wordpress.org/trunk@33742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-28 03:17:21 +00:00
Konstantin Obenland
88e669b6db Use default parameter when getting the default avatar type.
Props johnjamesjacoby.
Fixes #32997.

Built from https://develop.svn.wordpress.org/trunk@33264


git-svn-id: http://core.svn.wordpress.org/trunk@33236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-14 15:39:25 +00:00
Konstantin Obenland
7dc1d06e64 Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Drew Jaynes
4c37f68b79 Fix inline documentation syntax in wp_xmlrpc_server.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32591


git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:25:25 +00:00
Dominik Schilling
4073ff026b Force default avatar for HiDPI avatars on Discussion Settings.
props SergeyBiryukov.
fixes #31972.
Built from https://develop.svn.wordpress.org/trunk@32129


git-svn-id: http://core.svn.wordpress.org/trunk@32108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-14 18:09:26 +00:00
Dominik Schilling
64fc7294b6 Use HTTPS URLs for codex.wordpress.org.
see #27115.
Built from https://develop.svn.wordpress.org/trunk@32116


git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
Drew Jaynes
c477b2c966 Add a more descriptive function summary for options_discussion_add_js().
See [31095]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32005


git-svn-id: http://core.svn.wordpress.org/trunk@31984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 14:16:27 +00:00
Helen Hou-Sandí
bc7cc3bb12 Collapse additional avatar settings if avatars are disabled.
props markjaquith, krogsgard, valendesigns.
 fixes #30168.

Built from https://develop.svn.wordpress.org/trunk@31095


git-svn-id: http://core.svn.wordpress.org/trunk@31076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 17:01:24 +00:00
Mark Jaquith
6de35acf28 Increase both mystery and humanism
Built from https://develop.svn.wordpress.org/trunk@30089


git-svn-id: http://core.svn.wordpress.org/trunk@30089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 03:20:24 +00:00
Drew Jaynes
5e51ea9940 Priority fixes for various existing hook documentation.
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 00:01:15 +00:00
Andrew Nacin
dce0b9adea Use SSL when linking to WordPress.org. see #27115.
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Andrew Ozz
eb1d21d782 Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.
Built from https://develop.svn.wordpress.org/trunk@27029


git-svn-id: http://core.svn.wordpress.org/trunk@26905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-24 19:06:15 +00:00
Andrew Nacin
b9bbf2e814 Use p.description instead of <small> on the discussion settings page. see #26441.
Built from https://develop.svn.wordpress.org/trunk@26724


git-svn-id: http://core.svn.wordpress.org/trunk@26613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 14:22:11 +00:00
Andrew Ozz
8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Drew Jaynes
1178d9a80b Inline documentation for hooks in wp-admin/options-discussion.php.
Props siobhyb, ericlewis.
Fixes #25453.

Built from https://develop.svn.wordpress.org/trunk@25829


git-svn-id: http://core.svn.wordpress.org/trunk@25829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:49 +00:00
Andrew Nacin
8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Drew Jaynes
21b24c1fba Inline documentation for hooks in wp-admin/options-discussion.php.
Props siobhyb, ericlewis.
Fixes #25453.

Built from https://develop.svn.wordpress.org/trunk@25829


git-svn-id: http://core.svn.wordpress.org/trunk@25741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 06:00:09 +00:00
Andrew Nacin
fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Sergey Biryukov
3b08ae25e4 Clarify a string in discussion settings. props Ipstenu, DrewAPicture. fixes #16705.
Built from https://develop.svn.wordpress.org/trunk@25295


git-svn-id: http://core.svn.wordpress.org/trunk@25258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-07 15:36:09 +00:00
Mark Jaquith
755bece0bb Consistently apply class="title" to our options page h3 tags.
props norcross. fixes #24080.

git-svn-id: http://core.svn.wordpress.org/trunk@24002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-16 20:19:29 +00:00
Andrew Nacin
eac5264361 Make 'Show Avatars' a checkbox rather than a yes/no radio button. props tmoorewp, fixes #20889.
git-svn-id: http://core.svn.wordpress.org/trunk@22010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 06:44:26 +00:00
Ryan Boren
fbfa90a2f1 Add labels for all inputs in options-discussion. Props SergeyBiryukov, lessbloat, Latz. fixes #21373
git-svn-id: http://core.svn.wordpress.org/trunk@21746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 21:05:06 +00:00
nacin
c2fc56c67c It is possible for comments_per_page to be 0, which turns off pagination. See sanitize_option(); wp_list_commnts(); get_comment_link(). see #17863.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-16 04:36:12 +00:00
nacin
27c3c56ed6 comment_max_links may be zero to bypass the moderation check entirely. [20168] erred. see #17863.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-16 04:26:25 +00:00
azaozz
f3b63e4537 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin
4c566cebc6 Help text tweaks for the Settings screens. props jane. see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 00:52:31 +00:00
koopersmith
ed2c35ad0a Update help text on settings pages. props Ipstenu, see #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-29 16:58:58 +00:00
nacin
bfb98c193e s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020, #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan
3ad1f67958 Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
ryan
f5762a2aab Remove gratuitous periods. Add some semicolons. Props SergeyBiryukov. fixes #16186
git-svn-id: http://svn.automattic.com/wordpress/trunk@18508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-04 16:07:51 +00:00
nacin
9cb6e158fc Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
nacin
1cd758dc89 Help text edits. props dougwrites, fixes #15346.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:37:03 +00:00
ryan
ad8e837dc2 Add retro gravatar option. Props beaulebens. fixes #15759
git-svn-id: http://svn.automattic.com/wordpress/trunk@16857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-10 14:50:43 +00:00
nbachiyski
e074436af0 Don't forget to echo the result of esc_textarea()
git-svn-id: http://svn.automattic.com/wordpress/trunk@16485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 14:48:11 +00:00
markjaquith
6482610f9a esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
git-svn-id: http://svn.automattic.com/wordpress/trunk@16431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 17:12:01 +00:00
scribu
1cce7d7830 Introduce submit_button(). Props markjaquith for initial patch. See #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@15810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-14 19:58:06 +00:00
nbachiyski
3730d14fa2 Do not include space in the beginning of internationalized string
git-svn-id: http://svn.automattic.com/wordpress/trunk@15448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-19 20:36:30 +00:00
nacin
34c1fa6d0b target=blank for help. props jorbin, see #13467
git-svn-id: http://svn.automattic.com/wordpress/trunk@15132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 21:00:39 +00:00
ryan
17129fb62e Cut 'em out, move 'em on, trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@15116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-02 20:04:07 +00:00
nacin
14b39ec9dc Settings help. props duck_, see #13467.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-27 19:05:59 +00:00
nacin
5463205114 Remove default_comment_status_pages setting. Reverts [14451], [14448] for 3.0. see #12991.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-15 04:56:56 +00:00
wpmuguru
96153a63ae add default comment status setting for pages, props messenlehner, see #12991
git-svn-id: http://svn.automattic.com/wordpress/trunk@14448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-04 19:31:24 +00:00