Commit Graph

21091 Commits

Author SHA1 Message Date
Andrew Nacin
4b9ef4ee05 Remove errant return. props SergeyBiryukov. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 09:48:34 +00:00
Bot (Assets)
fa3497237b Compress scripts/styles: 3.5-beta3-22678.
git-svn-id: http://core.svn.wordpress.org/trunk@22678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:58:31 +00:00
Andrew Nacin
f7aa3ab067 Revert [22675]. wp_mime_type_icon() is more accurate when given a post ID, rather than a mime type. The "speed" mostly comes down to the ordering of cache hits, rather than any performance issues like #22503. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:44:37 +00:00
Andrew Nacin
2f77c7984b This should be a cache add, not a cache set. see #22503.
git-svn-id: http://core.svn.wordpress.org/trunk@22676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:39:52 +00:00
Andrew Nacin
d9d0f9a714 wp_mime_type_icon() is faster when given a mime type, rather than a post ID. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:39:14 +00:00
Andrew Nacin
a1dba4a709 Call wp_cache_set() with a group and then an expiration in wp_mime_type_icon(). fixes #22503. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:31:43 +00:00
Andrew Nacin
bd158c503f Move code from image_attachment_fields_to_edit() to get_attachment_fields_to_edit(). The level of abstraction is unnecessary, and it makes it more difficult to call only the filter in the new media modal. Also, that function is sloooow. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 08:10:38 +00:00
Daryl Koopersmith
fe1e4e3f56 Media: Insert each attachment into the editor individually.
This allows the `wpeditimage` plugin to correctly identify `caption` shortcodes.

fixes #22459, see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 07:30:53 +00:00
Daryl Koopersmith
549b5f61ae Media: Only show the alignment setting when viewing an image. fixes #21836, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 07:24:47 +00:00
Andrew Nacin
479d27013a Avoid doing all of the extra work in get_attachment_fields_to_edit() for fields we will just discard. We just need the filter, and the taxonomies. see #22186.
git-svn-id: http://core.svn.wordpress.org/trunk@22670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 07:20:47 +00:00
Andrew Nacin
622e48092c In get_custom_header(), support a default header that is registered using default-image but not register_default_headers(). fixes #22221.
git-svn-id: http://core.svn.wordpress.org/trunk@22669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:59:25 +00:00
Bot (Assets)
f8b7c4ee59 Compress scripts/styles: 3.5-beta3-22668.
git-svn-id: http://core.svn.wordpress.org/trunk@22668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:58:29 +00:00
Daryl Koopersmith
bda3b4c53d Media: Properly display selected featured image data if the featured image is not in the first section of the library. see #22494, #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:56:54 +00:00
Daryl Koopersmith
a776bcb14d Media: Use correct variable name. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:43:01 +00:00
Daryl Koopersmith
b222046481 Media: Blur the "Add Images" button when the media modal is opened. fixes #22445, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:34:41 +00:00
Andrew Nacin
f5e7edf2f2 Add manual new lines to a string, as double quotes with \n is not optimal due to sprintf-parsing reasons. props SergeyBiryukov, fixes #22486. see #22260.
git-svn-id: http://core.svn.wordpress.org/trunk@22664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:11:42 +00:00
Andrew Nacin
e3069d9d62 Re-enable a .wp-upload-form submit button whenever any file input in that form has a file selected, to minimize the potential for issues. props kovshenin. fixes #20855. see [22459].
git-svn-id: http://core.svn.wordpress.org/trunk@22663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:07:04 +00:00
Daryl Koopersmith
1af6c38db3 Media: Add default render method to views.
* Use default `render` method in the `Frame` view.
* Rename `Views.attach` to `Views.insert`.
* Add `Views.all` to retrieve all subviews.
* Add `Views.detach` to detach all subviews.
* Detect whether views are going to be reused in `View.set` and `detach` them instead of calling `dispose`.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:02:00 +00:00
Bot (Assets)
9e200c91e6 Compress scripts/styles: 3.5-beta3-22661.
git-svn-id: http://core.svn.wordpress.org/trunk@22661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 04:58:32 +00:00
Daryl Koopersmith
473583a4f4 Media: Allow subviews to be inserted at a specific index. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 04:41:57 +00:00
Daryl Koopersmith
795ba27d10 Media: Convert the attachments browser view's destroy method to the newer dispose method. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 03:33:29 +00:00
Daryl Koopersmith
ff204257db Media: Remove unused batch edit states and strings. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 03:11:48 +00:00
Bot (Assets)
29a9b52ca9 Compress scripts/styles: 3.5-beta3-22657. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@22657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 02:58:28 +00:00
Daryl Koopersmith
25ebc64c20 Media: Remove debug cruft from [22655]. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 02:44:34 +00:00
Daryl Koopersmith
561f01bd79 Media: Optimize media models.
* Merge `Composite` model with general `Attachments` model, as `Attachments.validate` and `Composite.evaluate` were functionally equivalent.
* Queries should only watch `wp.Uploader.queue`, as watching `Attachments.all` results in queries attempting to add attachments before their properties are set (which then results a few too many irrelevant adds/removes). `Attachments.all` should potentially be removed or rethought.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 02:43:10 +00:00
Daryl Koopersmith
88f09f7118 Media: Remove redundant sorting logic from composite models. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 02:00:01 +00:00
Andrew Nacin
97032e08aa Revert page on front changes. Reverts [22127] [22129] [22135] [22136]. see #16379.
git-svn-id: http://core.svn.wordpress.org/trunk@22653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 01:28:32 +00:00
Daryl Koopersmith
e3d01cddd0 Media: Make TinyMCE attachment and gallery controls always show when the corresponding view is selected. props SergeyBiryukov. fixes #22463, see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 01:23:45 +00:00
Daryl Koopersmith
10eada54dc Media: Move Attachments view preventDefault handler to the events object. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 01:17:30 +00:00
Bot (Assets)
cae8ce47fc Compress scripts/styles: 3.5-beta3-22650.
git-svn-id: http://core.svn.wordpress.org/trunk@22650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 00:58:49 +00:00
Daryl Koopersmith
13a3cc30b2 Media: Allow for the views manager to be extended. see #21390.
git-svn-id: http://core.svn.wordpress.org/trunk@22649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 00:54:18 +00:00
Daryl Koopersmith
4256ba0b48 Media: Add a base view class.
* Centralizes view and subview management, unifying several disjointed constructs.
* Utilizes the `dispose` functionality found in Backbone master, providing a standard method for memory management.

see #21390.


git-svn-id: http://core.svn.wordpress.org/trunk@22648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 00:36:47 +00:00
Andrew Nacin
47dfed43b4 Blue admin color scheme fixes. Fix admin menu styling. props melchoyce, helenyhou. fixes #22248.
git-svn-id: http://core.svn.wordpress.org/trunk@22647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 23:49:54 +00:00
Andrew Nacin
d0768e2d23 Fix QuickPress submission spinner. props ocean90. fixes #22496.
git-svn-id: http://core.svn.wordpress.org/trunk@22646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 23:46:01 +00:00
Bot (Assets)
5dfefbd1cd Compress scripts/styles: 3.5-beta3-22645. TinyMCE updated.
git-svn-id: http://core.svn.wordpress.org/trunk@22645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 18:58:32 +00:00
Andrew Ozz
f630e12290 TinyMCE: place the caret after/under images with captions when inserting content, fixes #19389
git-svn-id: http://core.svn.wordpress.org/trunk@22644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 18:04:20 +00:00
Andrew Ozz
65c026bcc3 RTL: remove unneeded toolbar border-right, props ocean90, see #22453
git-svn-id: http://core.svn.wordpress.org/trunk@22643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 17:59:27 +00:00
Bot (Assets)
ec8890d9a1 Compress scripts/styles: 3.5-beta3-22642.
git-svn-id: http://core.svn.wordpress.org/trunk@22642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 16:58:30 +00:00
Andrew Ozz
9ae963d9a7 RTL: fix styling of Skip To links, see #22453
git-svn-id: http://core.svn.wordpress.org/trunk@22641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 16:49:17 +00:00
Andrew Ozz
e09ea56a23 RTL fixes and improvements: add-media, image-editor, the spinners, the featured image button, some css cleanup, props ocean90, maor, SergeyBiryukov, ramiy, see #22453
git-svn-id: http://core.svn.wordpress.org/trunk@22640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-18 16:19:37 +00:00
Bot (Assets)
bc796cd26e Compress scripts/styles: 3.5-beta3-22639.
git-svn-id: http://core.svn.wordpress.org/trunk@22639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 22:58:30 +00:00
Andrew Ozz
c4fd7d119b Welcome screen: clean up the css, improve the html, add RTL styles, props helenyhou TobiasBg ocean90, fixes #21368, see #22453
git-svn-id: http://core.svn.wordpress.org/trunk@22638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 21:51:39 +00:00
Bot (Assets)
85afdd2ef7 Compress scripts/styles: 3.5-beta3-22637.
git-svn-id: http://core.svn.wordpress.org/trunk@22637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 20:58:31 +00:00
Andrew Ozz
981419d292 Make the admin menu and toolbar work well on mobile devices (take 2), props georgestephanis, fixes #20614, fixes #22382
git-svn-id: http://core.svn.wordpress.org/trunk@22636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 20:14:17 +00:00
Ryan Boren
cc2ddb8421 Always return a raw filtered post object from WP_Post::get_instance().
Props kovshenin, scribu, ntm
fixes #22448


git-svn-id: http://core.svn.wordpress.org/trunk@22635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 15:14:48 +00:00
Ryan Boren
06ee370814 Pinking shears
git-svn-id: http://core.svn.wordpress.org/trunk@22634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 15:11:29 +00:00
Andrew Nacin
1847d7e85b Trim the option name in get_option() before calling the pre_option_$option filter, not after. props evansolomon. fixes #22358.
git-svn-id: http://core.svn.wordpress.org/trunk@22633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 13:20:57 +00:00
Andrew Nacin
dc0786c0ae Pull the list of popular importers from WordPress.org.
These are the importers we suggest on import.php, prompting the user to
install the relevant plugin for the import they want to go through.

If the API is inaccessible, it falls back to a hard-coded list that should
be kept sync'd with the API with each major version of WordPress. This API
enables us to add new importers between releases, as they are completed or
if services gain quick adoption. As a last resort, we can also temporarily
disable importers that are broken (due to API changes, for example).

The importer currently returns English strings (which are then run through
translate() for existing strings), but the locale is passed to the API,
allowing us to ship translated strings if we wish to be adventurous.

props dllh for the assist.
fixes #18977.



git-svn-id: http://core.svn.wordpress.org/trunk@22632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 07:20:04 +00:00
Bot (Assets)
fbc68cd7c6 Compress scripts/styles: 3.5-beta3-22631.
git-svn-id: http://core.svn.wordpress.org/trunk@22631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:58:29 +00:00
Andrew Nacin
c5f94e316e Media Library list table: Rename 'Attached to' to 'Uploaded to'.
In 3.5, we have chosen to de-emphasize the "attaching" part of the
post-attachment relationship. Existing functionality remains the same,
but UI emphasis is now placed on "parent" being where the item was
originally uploaded.

fixes #22439.



git-svn-id: http://core.svn.wordpress.org/trunk@22630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 06:56:05 +00:00