Commit Graph

30418 Commits

Author SHA1 Message Date
Aaron Jorbin
1525010f74 Deprecate php4 style constructors
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors.  The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).

This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used.  In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."

Upstream: https://wiki.php.net/rfc/remove_php4_constructors

Props jdgrimes, netweb, jorbin
See #31982


Built from https://develop.svn.wordpress.org/trunk@32990


git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:27:24 +00:00
Aaron Jorbin
a6ebaefb92 Add Deprecated Constructor Function
This function is one that can be called in core to indicate that a PHP4 style constructor is used. PHP4 style constructors are deprecated in PHP7.

Props jorbin, DrewAPicture for docs
See #31982


Built from https://develop.svn.wordpress.org/trunk@32989


git-svn-id: http://core.svn.wordpress.org/trunk@32960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:56:24 +00:00
Aaron Jorbin
c9307fc95a Update Grunt dev-dependencies
grunt-browserify : minor version update
grunt-contrib-cssmin : minor version update
grunt-contrib-imagemin : patch version update
grunt-contrib-jshint : patch version update
grunt-contrib-uglify : minor version update (causes some changes to minified JS)
grunt-includes : minor version update
grunt-sass : major version update ( underlying libsass update ).

Props wonderboymusic
See #31700


Built from https://develop.svn.wordpress.org/trunk@32988


git-svn-id: http://core.svn.wordpress.org/trunk@32959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 14:51:30 +00:00
Konstantin Obenland
0704de88ea Customizer: Correct position for menu item delete icon in IE8.
Props valendesigns.
Fixes #32675.


Built from https://develop.svn.wordpress.org/trunk@32987


git-svn-id: http://core.svn.wordpress.org/trunk@32958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 11:49:24 +00:00
Aaron Jorbin
4bbf254375 Add missing semicolon
Introduced in [32983].

see #32757.

Built from https://develop.svn.wordpress.org/trunk@32986


git-svn-id: http://core.svn.wordpress.org/trunk@32957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 11:41:24 +00:00
Sergey Biryukov
bff91cfa5b Menus: Add a Manage in Customizer link, like we did for Widgets screen in [30459].
props celloexpressions.
fixes #32808.
Built from https://develop.svn.wordpress.org/trunk@32985


git-svn-id: http://core.svn.wordpress.org/trunk@32956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 06:08:24 +00:00
Sergey Biryukov
b26accf35a List tables: Select All should not be a column header.
It sets a redundant relationship with all checkboxes in its column and also conveys wrong information for screen readers.

props afercia, valendesigns.
see #31654.
Built from https://develop.svn.wordpress.org/trunk@32984


git-svn-id: http://core.svn.wordpress.org/trunk@32955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 05:46:25 +00:00
Andrew Ozz
275fc220ef Press This:
- Save a draft before opening the standard editor window.
- While saving a post show Saving... instead of Publish for the main visible part of the split button (same as the Save Draft button before).
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32983


git-svn-id: http://core.svn.wordpress.org/trunk@32954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:59:24 +00:00
Sergey Biryukov
9665259675 Customizer: Increase color contrast ratio for menu locations text.
props celloexpressions.
fixes #32727.
Built from https://develop.svn.wordpress.org/trunk@32982


git-svn-id: http://core.svn.wordpress.org/trunk@32953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:45:25 +00:00
Sergey Biryukov
9e445e3c30 Customizer: Add an aria-label attribute to the Add Items button to improve accessibility.
props afercia.
fixes #32713.
Built from https://develop.svn.wordpress.org/trunk@32981


git-svn-id: http://core.svn.wordpress.org/trunk@32952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 04:28:24 +00:00
Scott Taylor
5b9b3cedea When searching for users using the search arg in get_users()/WP_User_Query, also search the user's email, url, and display name.
Adds unit tests.

Props mordauk, wonderboymusic.
Fixes #27304.

Built from https://develop.svn.wordpress.org/trunk@32980


git-svn-id: http://core.svn.wordpress.org/trunk@32951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 00:36:24 +00:00
Scott Taylor
a59b2ffcae Update getID3 to 1.9.9
Changelog:
* https://github.com/JamesHeinrich/getID3/blob/master/changelog.txt
* https://github.com/JamesHeinrich/getID3/compare/v1.9.8...v1.9.9

Fixes #32806.

Built from https://develop.svn.wordpress.org/trunk@32979


git-svn-id: http://core.svn.wordpress.org/trunk@32950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 00:17:25 +00:00
Scott Taylor
f077b3c511 Update jQuery to 1.11.3:
http://blog.jquery.com/2015/04/28/jquery-1-11-3-and-2-1-4-released-ios-fail-safe-edition/

Changelog:
* https://github.com/jquery/jquery/issues?q=milestone%3A1.11.3%2F2.1.4
* https://github.com/jquery/jquery/compare/1.11.2...1.11.3

Props peterwilsoncc.
Fixes #32794.

Built from https://develop.svn.wordpress.org/trunk@32978


git-svn-id: http://core.svn.wordpress.org/trunk@32949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 23:40:23 +00:00
Scott Taylor
36513e9d7d After [32974], tweak some CSS for focus, etc.
See #31650.

Built from https://develop.svn.wordpress.org/trunk@32977


git-svn-id: http://core.svn.wordpress.org/trunk@32948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 23:13:24 +00:00
Weston Ruter
e162bb8940 Customizer: Improve previewing setting changes for show_on_front, page_on_front, and page_for_posts.
When changing the `page_on_front` setting (with `show_on_front`), change the previewed URL to be the home URL so that the effect can be seen. When changing `page_for_posts`, change the previewed URL to be the selected page.

Props valendesigns, westonruter.
Fixes #30677.


Built from https://develop.svn.wordpress.org/trunk@32976


git-svn-id: http://core.svn.wordpress.org/trunk@32947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 19:59:25 +00:00
Konstantin Obenland
77f385e532 Additional style changes to accomodate <h1> headings.
See [32974], #31650.


Built from https://develop.svn.wordpress.org/trunk@32975


git-svn-id: http://core.svn.wordpress.org/trunk@32946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:51:23 +00:00
Konstantin Obenland
7dc1d06e64 Proper heading for admin screens.
First step towards restoring a good heading structure in wp-admin.
The previous `<h1>` contained the site title and a link to the front page and was removed with the toolbar refactoring in 3.2.

Props joedolson, afercia.
Fixes #31650.


Built from https://develop.svn.wordpress.org/trunk@32974


git-svn-id: http://core.svn.wordpress.org/trunk@32945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:41:25 +00:00
Sergey Biryukov
aa6a58f155 Fix the dismissable notice button focus style, broken in [32475].
props afercia.
fixes #32797.
Built from https://develop.svn.wordpress.org/trunk@32973


git-svn-id: http://core.svn.wordpress.org/trunk@32944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 15:07:24 +00:00
Sergey Biryukov
c99db2bc59 Media modal: Use better descriptive text for "Remove" buttons.
props afercia.
fixes #32792.
Built from https://develop.svn.wordpress.org/trunk@32972


git-svn-id: http://core.svn.wordpress.org/trunk@32943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 14:51:26 +00:00
Dominik Schilling
2ecb586214 Customizer: Add an aria-expanded attribute to the Add Menu button to improve accessibility.
props afercia.
fixes #32791.
Built from https://develop.svn.wordpress.org/trunk@32971


git-svn-id: http://core.svn.wordpress.org/trunk@32942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 10:05:24 +00:00
Dominik Schilling
2d9a46b973 Customizer: Remove top margin when dragging menu items.
The markup was changed in [32889].

props tywayne.
fixes #32745.
Built from https://develop.svn.wordpress.org/trunk@32970


git-svn-id: http://core.svn.wordpress.org/trunk@32941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 09:47:23 +00:00
Sergey Biryukov
74c7f59bb2 Revert [32702]. The URL may not have an s parameter as there are filters in place so that a plugin can return a URL with a completely different structure.
see #32572.
Built from https://develop.svn.wordpress.org/trunk@32969


git-svn-id: http://core.svn.wordpress.org/trunk@32940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 08:35:24 +00:00
Andrew Ozz
81d0434421 TinyMCE: prevent undefined error in toolbar.hide().
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32968


git-svn-id: http://core.svn.wordpress.org/trunk@32939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 02:24:25 +00:00
Andrew Ozz
e311b53cfc TinyMCE, inline link toolbar: tweak styling on small screens to fix wrapping in iOS.
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32967


git-svn-id: http://core.svn.wordpress.org/trunk@32938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 02:21:24 +00:00
Andrew Ozz
7715a50c0b Press This: fix iOS bug that prevents closing of the split button when tapping outside of it.
See #32757.
Built from https://develop.svn.wordpress.org/trunk@32966


git-svn-id: http://core.svn.wordpress.org/trunk@32937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 02:15:24 +00:00
Scott Taylor
8b1286417e ob_get_contents() followed by ob_end_clean() can be replaced by ob_get_clean().
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32965


git-svn-id: http://core.svn.wordpress.org/trunk@32936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:12:24 +00:00
Scott Taylor
a0e373ef80 For doc block types, favor bool over the few remaining booleans
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:03:25 +00:00
Scott Taylor
642af1f3f4 Some doc blocks should use bool instead of true|false
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32963


git-svn-id: http://core.svn.wordpress.org/trunk@32934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 00:45:24 +00:00
Scott Taylor
60b8e86b36 In WP_Filesystem_Base::chdir|chgrp|chmod() (all mock abstract methods), modify @return to include string so that subclass @returns match.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32962


git-svn-id: http://core.svn.wordpress.org/trunk@32933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 00:43:24 +00:00
Scott Taylor
40325262ef Declare visibility for WP_Locale methods.
See #32444.


Built from https://develop.svn.wordpress.org/trunk@32961


git-svn-id: http://core.svn.wordpress.org/trunk@32932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 00:32:23 +00:00
Andrew Ozz
b9e796a5c1 TinyMCE: prevent error in the wptextpattern plugin when the first child node in a paragraph is not a text node.
See #31441;
Built from https://develop.svn.wordpress.org/trunk@32960


git-svn-id: http://core.svn.wordpress.org/trunk@32931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 23:19:24 +00:00
Andrew Ozz
4857824377 Update Twemoji to 1.4.1 including up to 3c0c13d3a5 (exclude SVG elements). Remove our hacks and adapt wp-emoji.js to use the new image attributes callback.
Fixes #32203.
Built from https://develop.svn.wordpress.org/trunk@32959


git-svn-id: http://core.svn.wordpress.org/trunk@32930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 22:01:25 +00:00
Andrew Ozz
1f75220e9a TinyMCE, inline link toolbar: fix z-index bug in iOS Safari.
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32958


git-svn-id: http://core.svn.wordpress.org/trunk@32929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 20:29:24 +00:00
Andrew Ozz
7a4c8d8977 TinyMCE: add the editor focusing help the Keyboard Shortcuts modal.
See #31913.
Built from https://develop.svn.wordpress.org/trunk@32957


git-svn-id: http://core.svn.wordpress.org/trunk@32928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 18:49:25 +00:00
Andrew Ozz
5f041b37bf TinyMCE, inline link toolbar: fix styling on small screens so the displayed URL is not needlessly truncated.
See #32604.
Built from https://develop.svn.wordpress.org/trunk@32956


git-svn-id: http://core.svn.wordpress.org/trunk@32927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 17:55:25 +00:00
Dominik Schilling
a6b7a691be Customizer: Prevent dragging menu items above the main heading.
Improve targeting for the `sortableItems`, resolving an issue where the first `<li>` in the control became a sortable target, allowing the user to drag a single top level menu outside the intended sortable area.

props adamsilverstein.
fixes #32738.
#wceu
Built from https://develop.svn.wordpress.org/trunk@32955


git-svn-id: http://core.svn.wordpress.org/trunk@32926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 17:11:24 +00:00
Boone Gorges
d99f9d3a22 Improve error checking in get_edit_term_link().
The function should not throw notices when an improper term or taxonomy is
passed.

Props tmatsuur, MikeHansenMe.
Fixes #32786.
Built from https://develop.svn.wordpress.org/trunk@32954


git-svn-id: http://core.svn.wordpress.org/trunk@32925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 14:13:24 +00:00
Boone Gorges
40ab4567e7 Introduce WP_UnitTestCase::delete_user().
This static method provides a multisite-agnostic way to delete users during
automated testing.

See #32796.
Built from https://develop.svn.wordpress.org/trunk@32953


git-svn-id: http://core.svn.wordpress.org/trunk@32924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 12:59:26 +00:00
Scott Taylor
72bf48f0b9 In Media microtemplates after [32467], use <button> instead of <a> for several more non-links.
Props afercia.
Fixes #26550.

Built from https://develop.svn.wordpress.org/trunk@32952


git-svn-id: http://core.svn.wordpress.org/trunk@32923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 05:01:24 +00:00
Andrew Ozz
561ca94998 TinyMCE: update the Keyboard Shortcuts help modal, use the TinyMCE UI API instead of an iframe.
Props iseulde, azaozz. Fixes #31913.
Built from https://develop.svn.wordpress.org/trunk@32951


git-svn-id: http://core.svn.wordpress.org/trunk@32922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 04:40:24 +00:00
Dion Hulse
4df2bd0b2a Remove an undeeded space concatenation from wpmu_validate_user_signup().
This was previously used to prevent `strpos()` returning 0, which is not needed after r32942.
See #32444

Built from https://develop.svn.wordpress.org/trunk@32950


git-svn-id: http://core.svn.wordpress.org/trunk@32921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-26 01:39:25 +00:00
Scott Taylor
747b1eb713 After [32866], fix doc blocks.
Props DrewAPicture.
See #32363.

Built from https://develop.svn.wordpress.org/trunk@32949


git-svn-id: http://core.svn.wordpress.org/trunk@32920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 21:02:25 +00:00
Scott Taylor
7537240d37 List tables: when post navigation links point to the current page, use <span>s and text instead of <a>s.
Props afercia.
Fixes #32253.

Built from https://develop.svn.wordpress.org/trunk@32948


git-svn-id: http://core.svn.wordpress.org/trunk@32919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 20:32:26 +00:00
Scott Taylor
7a264022e7 After [32896], update ConvertChars.php unit tests and rename to ConvertInvalidEntries.php.
Props boonebgorges.
Fixes #32335.

Built from https://develop.svn.wordpress.org/trunk@32947


git-svn-id: http://core.svn.wordpress.org/trunk@32918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:51:27 +00:00
Scott Taylor
2518b37222 Admin menu: improve accessibility when collapsed.
Props afercia.
Fixes #32346.

Built from https://develop.svn.wordpress.org/trunk@32946


git-svn-id: http://core.svn.wordpress.org/trunk@32917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:33:26 +00:00
Scott Taylor
587c570efa After [32796], improve the accessibility and markup for instances of touch_time().
Props rianrietveld, afercia.
Fixes #31714.

Built from https://develop.svn.wordpress.org/trunk@32945


git-svn-id: http://core.svn.wordpress.org/trunk@32916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:30:25 +00:00
Andrew Ozz
7142248743 Press This: better screen reader text for the arrow part of the split button.
Props afercia. See #32757.
Built from https://develop.svn.wordpress.org/trunk@32944


git-svn-id: http://core.svn.wordpress.org/trunk@32915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:24:25 +00:00
Scott Taylor
26855e651b In get_site_option() and get_option(), ensure that $notoptions is an array before writing to it. Prevents a flood of Cannot use a scalar value as an array, because $notoptions is otherwise set to the result of wp_cache_get(), which returns mixed.
Props hauvong.
Fixes #31147.

Built from https://develop.svn.wordpress.org/trunk@32943


git-svn-id: http://core.svn.wordpress.org/trunk@32914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 19:01:26 +00:00
Scott Taylor
aaa99969e4 wpmu_validate_user_signup() should strictly check against false when using strpos().
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32942


git-svn-id: http://core.svn.wordpress.org/trunk@32913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:57:26 +00:00
Scott Taylor
b3ecfda08d WP_Rewrite::add_rule() should strictly check against false when using strpos().
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32941


git-svn-id: http://core.svn.wordpress.org/trunk@32912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-25 16:56:25 +00:00