Commit Graph

54 Commits

Author SHA1 Message Date
joedolson
b3eb7b301c Editor: Improve accessibility of new custom field UI.
Add labels; change Enter new/Cancel link to a button; move focus to input when creating new field; move Add Custom Field out of fields table. 

Props jane, batmoo, karmatosed, franrosa, sabernhardt, annashopina, oglekler, joedolson.
Fixes #15631.
Built from https://develop.svn.wordpress.org/trunk@56018


git-svn-id: http://core.svn.wordpress.org/trunk@55530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-06-24 14:32:20 +00:00
John Blackbourn
39bff93b6b Docs: Various inline documentation corrections and improvements.
See #53399

Built from https://develop.svn.wordpress.org/trunk@52332


git-svn-id: http://core.svn.wordpress.org/trunk@51924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-12-07 12:20:02 +00:00
Sergey Biryukov
b65d83b872 External Libraries: Further fix jQuery deprecations in WordPress core.
This includes many minor adjustments to a wide array of core files to replace shorthands with full declarations.

Follow-up to [50001], [50270], [50367].

Props Clorith, hellofromTonya, peterwilsoncc, adamsilverstein, aristath.
See #51812.
Built from https://develop.svn.wordpress.org/trunk@50420


git-svn-id: http://core.svn.wordpress.org/trunk@50031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-23 19:45:04 +00:00
whyisjake
3dd9628aae Build/Test Tools: Enable JSDocs to be linted with ESLint.
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/) this add some tooling to lint Javascript docblocks. Two new commands:

* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`

The latter will run the linter and try to fix an possible issues automatically.

Fixes #43828.
Props netweb, atimmer, kamataryo, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@48650


git-svn-id: http://core.svn.wordpress.org/trunk@48412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 23:35:02 +00:00
Sergey Biryukov
56342b8e8f Docs: Replace "AJAX" with "Ajax" in DocBlocks and comments, per the spelling glossary.
Props mukesh27, sabernhardt, SergeyBiryukov.
Fixes #50064.
Built from https://develop.svn.wordpress.org/trunk@48168


git-svn-id: http://core.svn.wordpress.org/trunk@47937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 12:43:07 +00:00
Sergey Biryukov
be16bb9fba Docs: Remove extra spaces from @param tags.
Per the documentation standards, `@param` tags should be aligned with each other, but not with the `@return` tag.

See #49572.
Built from https://develop.svn.wordpress.org/trunk@48110


git-svn-id: http://core.svn.wordpress.org/trunk@47879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:58:10 +00:00
Sergey Biryukov
2a0489ec49 Docs: Replace @returns tags in JS docs with @return.
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/

See #48303.
Built from https://develop.svn.wordpress.org/trunk@46800


git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 18:01:03 +00:00
atimmer
bde558be2f Docs: Add file doc @output annotations.
These annotations make it clear to the reader of a JavaScript source
where the build process outputs to. These annotations can later be
integrated in a webpack configuration. This way there is one source of
truth.

The `build` folder is omitted from the paths, because a single JS file
shouldn't not be responsible of knowing where outputs in general will
end up at. A file only knows its output location relative to the
project.

Props adamsilverstein, herregroen, omarreiss, pento.
Fixes #44361.

Built from https://develop.svn.wordpress.org/trunk@43347


git-svn-id: http://core.svn.wordpress.org/trunk@43175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-06-28 02:30:15 +00:00
Konstantin Obenland
e0669dc255 wpLists: Pass the current element to process() to properly register event handlers.
Fixes a bug where new categories couldn't be added from the post edit screen.
Introduced in [38599].

Props dlh.
Fixes #38174.

Built from https://develop.svn.wordpress.org/trunk@38711


git-svn-id: http://core.svn.wordpress.org/trunk@38654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-03 18:39:30 +00:00
Konstantin Obenland
320fe3a2b6 Make wpList easier to contribute to.
Uses more semantic variable names and adds function and inline documentation.

Props rommelxcastro for parallel work in #34917.
Fixes #36264.

Built from https://develop.svn.wordpress.org/trunk@38599


git-svn-id: http://core.svn.wordpress.org/trunk@38542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-13 22:24:30 +00:00
Dominik Schilling
456c9bea3d Comments: After [37743], prevent a JavaScript error when wpAjax.parseAjaxResponse() returns an error or true.
Props rachelbaker.
Fixes 36742.
Built from https://develop.svn.wordpress.org/trunk@38050


git-svn-id: http://core.svn.wordpress.org/trunk@37991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-13 15:03:28 +00:00
Rachel Baker
d7e743a286 Comments: Wrap or unwrap the List Table comment_date as comment status changes via Ajax.
Introduced in [36521].

Fixes #36742.
Props imath, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@37743


git-svn-id: http://core.svn.wordpress.org/trunk@37708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-17 21:48:27 +00:00
Dominik Schilling
b3d8732c17 jQuery: Replace the use of the .size() method with the .length property.
The `.size()` method is deprecated since jQuery 1.8. The `.length` property is preferred because it doesn't have the overhead of a function call.

See https://api.jquery.com/size/.
See #35380.
Built from https://develop.svn.wordpress.org/trunk@36286


git-svn-id: http://core.svn.wordpress.org/trunk@36253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-13 16:17:27 +00:00
Eric Lewis
b464b01c7e Add documentation for parseData() and ajaxDel() in wp-lists.js.
Fixes #35360.

Built from https://develop.svn.wordpress.org/trunk@36229


git-svn-id: http://core.svn.wordpress.org/trunk@36196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-09 00:05:26 +00:00
Scott Taylor
d4e46e3f8d Fix double avatars and JS errors when spamming/trashing comments.
Props avryl, SergeyBiryukov.
Fixes #27329.
 

Built from https://develop.svn.wordpress.org/trunk@27759


git-svn-id: http://core.svn.wordpress.org/trunk@27596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:14:15 +00:00
Andrew Nacin
a87fec4616 Fix JSHint errors in six files.
props mdbitz.
fixes ##26011, #26012, #26013, #26014, #26038, #26039.

Built from https://develop.svn.wordpress.org/trunk@26195


git-svn-id: http://core.svn.wordpress.org/trunk@26103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 04:42:09 +00:00
Dominik Schilling
c2739d12cc Trim leading whitespace from AJAX responses.
This fixes the warning "$(html) HTML strings must start with '<' character" by jQuery Migrate when adding nav menu items, post custom fields or comment replies.

fixes #23681.
Built from https://develop.svn.wordpress.org/trunk@25546


git-svn-id: http://core.svn.wordpress.org/trunk@25466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 10:51:09 +00:00
Andrew Ozz
cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Andrew Nacin
aa543734b8 Fix adding and updating from the Custom Fields meta box. Broken in [21205]. props SergeyBiryukov. see #21829 for trunk.
git-svn-id: http://core.svn.wordpress.org/trunk@21781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-07 15:49:20 +00:00
Andrew Nacin
daef59322c Modify a few jQuery selectors to prevent overflows and lagging. Todo, rewrite wp-lists and improve all of these selectors.
props SergeyBiryukov. fixes #21106 for trunk. see #21152.



git-svn-id: http://core.svn.wordpress.org/trunk@21737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 20:27:14 +00:00
Andrew Nacin
2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot
de9d8299d8 Compress scripts/styles: 3.5-alpha-21206.
git-svn-id: http://core.svn.wordpress.org/trunk@21206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-04 06:58:20 +00:00
azaozz
e99503cf91 Fix updating of custom fields, fixes #17483
git-svn-id: http://svn.automattic.com/wordpress/trunk@17981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-21 14:38:56 +00:00
azaozz
3938bcc3e7 Fix race condition in the comments river XHR, props mintindeed, fixes #17483
git-svn-id: http://svn.automattic.com/wordpress/trunk@17965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-19 06:09:52 +00:00
azaozz
9c7ce18921 Fix wp-lists.js for jQuery 1.5.2
git-svn-id: http://svn.automattic.com/wordpress/trunk@17808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-05 06:18:52 +00:00
azaozz
1c525018c3 Fix getColor() in wp-lists.js
git-svn-id: http://svn.automattic.com/wordpress/trunk@17780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-30 16:57:20 +00:00
azaozz
9e4bee6c26 Add quotes to [value="some"] selectors, see #16426
git-svn-id: http://svn.automattic.com/wordpress/trunk@17777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-30 02:15:08 +00:00
scribu
8ab7aafec4 Use event delegation in wp-lists.js. Fixes #15488
git-svn-id: http://svn.automattic.com/wordpress/trunk@16486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 16:11:56 +00:00
azaozz
f33e161d18 Tweak colors for trash, spam and undo of comments, fix IE6/7 background for unapproved comments, fix JS error in IE6/7, props caesarsgrunt, see #4529
git-svn-id: http://svn.automattic.com/wordpress/trunk@12291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-29 10:29:12 +00:00
azaozz
d0b8296e23 Smoooth animations for comment move to trash and undo, see #4529
git-svn-id: http://svn.automattic.com/wordpress/trunk@12050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-18 05:59:03 +00:00
azaozz
d20c23e98d Add Undo when moving comments to the trash, remove unneeded nonces, see #4529
git-svn-id: http://svn.automattic.com/wordpress/trunk@12008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-08 08:24:59 +00:00
azaozz
2c2878bc80 Don't bind every form element to form.submit in wp-lists, fixes #7838, see #9696
git-svn-id: http://svn.automattic.com/wordpress/trunk@11201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-05 10:29:37 +00:00
azaozz
4d7ad21379 Make simple form validation and ajax-add new categories compatible with jQuery 1.3.1
git-svn-id: http://svn.automattic.com/wordpress/trunk@10457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-29 07:00:00 +00:00
azaozz
a750885c8e Minify all js and add the non-minified files as .dev.js
git-svn-id: http://svn.automattic.com/wordpress/trunk@10291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-02 15:08:58 +00:00
markjaquith
90ec026142 Prevent hotkeys from clicking hidden links -- keeps U and A from both acting as moderated/approved toggles. Now each one just does its own function.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-05 08:01:10 +00:00
ryan
164546b068 wp-lists: catch the whole class, pending comments: silently accept approval of already approved comment. Props mdawaffe
git-svn-id: http://svn.automattic.com/wordpress/trunk@10057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-12-05 05:10:38 +00:00
ryan
30d7084f60 Fix gravatars for infinite comments. Props mdawaffe. fixes #7432 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@8490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-07-29 22:14:53 +00:00
ryan
8eff77e82d More efficient category and list JS from mdawaffe. fixes #6677 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@7669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-04-14 19:31:20 +00:00
ryan
a370785fbc Fix custom field add/update/delete. Props mdawaffe. fixes #6343
git-svn-id: http://svn.automattic.com/wordpress/trunk@7468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-22 08:15:48 +00:00
markjaquith
d93684e0c1 increment comment moderation counter when unapproving comment from approved comments screen. props mdawaffe. fixes #6338
git-svn-id: http://svn.automattic.com/wordpress/trunk@7462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-21 21:57:25 +00:00
ryan
3d0435bb58 Attachment editing from mdawaffe. fixes #6181
git-svn-id: http://svn.automattic.com/wordpress/trunk@7262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-12 05:50:07 +00:00
ryan
04c9051a7d Remove trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@7130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-03-02 20:17:30 +00:00
ryan
d9aef704a1 Post Edit Collision Detection from mdawaffe. fixes #6043
git-svn-id: http://svn.automattic.com/wordpress/trunk@7103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-29 09:51:36 +00:00
ryan
09f33b6865 Revert [7093]. Need a different method. see #6032
git-svn-id: http://svn.automattic.com/wordpress/trunk@7094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-28 21:57:39 +00:00
ryan
c4bb6ba122 Fade approved comments from moderated list. Props filosofo. fixes #6032
git-svn-id: http://svn.automattic.com/wordpress/trunk@7093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-28 21:51:57 +00:00
ryan
f529aef82d Widget admin layout fixes from mdawaffe. fixes #5997
git-svn-id: http://svn.automattic.com/wordpress/trunk@7086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-28 09:11:11 +00:00
ryan
51a3623aed Unify comment display. Props mdawaffe. fixes #6025
git-svn-id: http://svn.automattic.com/wordpress/trunk@7082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-28 06:50:25 +00:00
ryan
8ebf2db0c6 Ajax tweaks for edit-comments.php from mdawaffe. fixes #6009
git-svn-id: http://svn.automattic.com/wordpress/trunk@7050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-26 22:45:46 +00:00
ryan
db44305ce1 Fixes for new categories interface from mdawaffe. fixes #5618
git-svn-id: http://svn.automattic.com/wordpress/trunk@6591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-10 20:19:58 +00:00
matt
16d42d6ee7 New experimental category interface, fixes #5618. Hat tip: mdawaffe.
git-svn-id: http://svn.automattic.com/wordpress/trunk@6588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-10 09:39:35 +00:00