19118 Commits

Author	SHA1	Message	Date
John Blackbourn	e7cc15b321	Upload: Introduce the {$action}_overrides filter that allows the overrides parameter for file uploads and file sideloads to be filtered. ... The dynamic portion of the hook name, `$action`, refers to the post action. Props iandunn, jakub.tyrcha, nacin, wonderboymusic, Mte90, johnbillion Fixes #16849 Built from https://develop.svn.wordpress.org/trunk@49845 git-svn-id: http://core.svn.wordpress.org/trunk@49564 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-20 16:15:03 +00:00
Sergey Biryukov	0e700c40ea	Docs: Fix typo in getCursorMarkerSpan() DocBlock in js/_enqueues/wp/editor/base.js. ... Props voboghure, mukesh27, audrasjb. Fixes #52128. Built from https://develop.svn.wordpress.org/trunk@49841 git-svn-id: http://core.svn.wordpress.org/trunk@49560 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-20 12:32:11 +00:00
Sergey Biryukov	41c9686313	Docs: Update the reference to Appearance → Theme Editor admin menu item in the inline documentation. ... Follow-up to [42685]. See #51800. Built from https://develop.svn.wordpress.org/trunk@49837 git-svn-id: http://core.svn.wordpress.org/trunk@49556 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-18 15:46:04 +00:00
Andrew Ozz	71ae342050	Editor: Fix improper triggering of the "Are you sure" prompt when navigating away from the old, "classic" Edit Post screen and there are no changes. Was triggered when there is an instance of TinyMCE in the Excerpt postbox. ... Props rodrigosprimo, jonathanstegall, kevin940726, azaozz. Fixes #52038. Built from https://develop.svn.wordpress.org/trunk@49807 git-svn-id: http://core.svn.wordpress.org/trunk@49530 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-16 15:25:09 +00:00
John Blackbourn	7e9060a0e4	Upgrade/Install: Remove a duplicate description for the upgrader_overwrote_package action. ... See #51800, #9757 Built from https://develop.svn.wordpress.org/trunk@49788 git-svn-id: http://core.svn.wordpress.org/trunk@49511 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-10 23:38:04 +00:00
Sergey Biryukov	4a69dfa63a	Docs: Fix typo in some DocBlocks. ... See #51800. Built from https://develop.svn.wordpress.org/trunk@49785 git-svn-id: http://core.svn.wordpress.org/trunk@49508 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-10 18:12:03 +00:00
Helen Hou-Sandí	e516134d10	Update $_old_files for 5.6. ... See #39943. Built from https://develop.svn.wordpress.org/trunk@49774 git-svn-id: http://core.svn.wordpress.org/trunk@49497 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-08 21:50:07 +00:00
TimothyBlynJacobs	a9244a2912	App Passwords: Ensure redirection description is shown on mobile devices. ... Props #core. Fixes #51970. Built from https://develop.svn.wordpress.org/trunk@49772 git-svn-id: http://core.svn.wordpress.org/trunk@49495 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-08 20:28:04 +00:00
ryelle	aaf90076c5	Help/About: Use CDN URLs for About page images. ... See #51415. Built from https://develop.svn.wordpress.org/trunk@49770 git-svn-id: http://core.svn.wordpress.org/trunk@49493 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-08 17:02:06 +00:00
TimothyBlynJacobs	efdba220e6	App Passwords: Store the "in use" option in the main network options. ... Whether App Passwords are being used is a global featurel, not a per-network feature. This fixes issues on Multi Network installs if App Passwords are used on a different network from where they were created. Props spacedmonkey. Fixes #51939. See [49752]. Built from https://develop.svn.wordpress.org/trunk@49764 git-svn-id: http://core.svn.wordpress.org/trunk@49487 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-07 15:59:04 +00:00
TimothyBlynJacobs	aac98aae97	App Passwords: Prevent conflicts when Basic Auth is already used by the site. ... Application Passwords uses Basic Authentication to transfer authentication details. If the site is already using Basic Auth, for instance to implement a private staging environment, then the REST API will treat this as an authentication attempt and would end up generating an error for any REST API request. Now, Application Password authentication will only be attempted if Application Passwords is in use by a site. This is flagged by setting an option whenever an Application Password is created. An upgrade routine is added to set this option if any App Passwords already exist. Lastly, creating an Application Password will be prevented if the site appears to already be using Basic Authentication. Props chexwarrior, georgestephanis, adamsilverstein, helen, Clorith, marybaum, TimothyBlynJacobs. Fixes #51939. Built from https://develop.svn.wordpress.org/trunk@49752 git-svn-id: http://core.svn.wordpress.org/trunk@49475 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-04 21:44:07 +00:00
Sergey Biryukov	e7b601f7c5	Database: Check the correct value for displaying the "Successfully repaired table" or "Failed to repair" messages on Database Repair screen. ... Additionally, rename the variables holding the results of `ANALYZE TABLE` and `OPTIMIZE TABLE` requests, for clarity. Props mehrshaddarzi. Fixes #51932. Built from https://develop.svn.wordpress.org/trunk@49750 git-svn-id: http://core.svn.wordpress.org/trunk@49473 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-04 15:50:12 +00:00
TimothyBlynJacobs	692c6498e9	App Passwords: Ensure the Created At and Last Used dates are properly translated. ... The `date_i18n` function is now used when formatting the dates in PHP instead of `gmdate` which doesn't handle localization properly. Additionally, we now use a translation to get the date format to use instead of pulling from the `date_format` option which is only supposed to affect the front-end. Lastly, when passing the date format to the Backbone JS template, we now use `wp_json_encode()` to format the value for JavaScript. This ensures that backslashes are properly preserved which are used by some locales to escape date formatting control characters. Props pedromendonca, TimothyBlynJacobs, ocean90, hellofromtonya, SergeyBiryukov, antpb. Fixes #51918. See [35811]. Built from https://develop.svn.wordpress.org/trunk@49746 git-svn-id: http://core.svn.wordpress.org/trunk@49469 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-03 21:06:08 +00:00
iandunn	4de6175227	Multisite: Cache absolute dirsize paths to avoid PHP 8 fatal. ... r49212 greatly improved the performance of `get_dirsize()`, but also changed the structure of the data stored in the `dirsize_cache` transient. It stored relative paths instead of absolute ones, and also removed the unnecessary `size` array. That difference in data structures led to a fatal error in the following environment: * PHP 8 * Multisite * A custom `WP_CONTENT_DIR` which is not a child of WP's `ABSPATH` folder (e.g., [https://roots.io/bedrock/ Bedrock]) * The `upload_space_check_disabled` option set to `0` After upgrading to WP 5.6, the `dirsize_cache` transient still had data in the old format. When `wp-admin.php/index.php` was visited, `get_space_used()` received an `array` instead of an `int`, and tried to divide it by another `int`. PHP 7 would silently cast the arguments to match data types, but [https://wiki.php.net/rfc/arithmetic_operator_type_checks PHP 8 throws a fatal error]: `Uncaught TypeError: Unsupported operand types: array / int` `recurse_dirsize()` was using `ABSPATH` to convert the absolute paths to relative ones, but some upload locations are not located under `ABSPATH`. In those cases, `$directory` and `$cache_path` were identical, and that triggered the early return of the old `array`, instead of the expected `int`. In order to avoid that, this commit restores the absolute paths, but without the `size` array. It also adds a type check when returning cached values. Using absolute paths without `size` has the result of overwriting the old data, so that it matches the new format. The type check and upgrade routine are additional safety measures. Props peterwilsoncc, janthiel, helen, hellofromtonya, francina, pbiron. Fixes #51913. See #19879. Built from https://develop.svn.wordpress.org/trunk@49744 git-svn-id: http://core.svn.wordpress.org/trunk@49467 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-03 20:39:02 +00:00
Sergey Biryukov	be2891ef1a	Upgrade/Install: Check $wp_version global for displaying "You are using a development version" message in the admin footer. ... This brings some consistency with the same check in `core_upgrade_preamble()` and avoids a PHP warning if `$cur->version` is not set. Additionally, remove the check for `$cur->url` property, unused since [8595]. Follow-up to [49708], [49709]. Props pbiron, afragen, audrasjb. Fixes #51892. Built from https://develop.svn.wordpress.org/trunk@49736 git-svn-id: http://core.svn.wordpress.org/trunk@49459 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-03 14:06:04 +00:00
John Blackbourn	00680f2e89	REST API: Pass the previous state of the post as a parameter to the wp_after_insert_post hook. ... This enables, for example, the previous post status to be used by this hook without the need to first capture it on an earlier hook. This also fixes the value of the `$fire_after_hooks` parameter in `get_default_post_to_edit()` so the `wp_after_insert_post` action correctly fires just once on the new post screen. Props Collizo4sky, peterwilsoncc, hellofromTonya, TimothyBlynJacobs, SergeyBiryukov Fixes #45114 Built from https://develop.svn.wordpress.org/trunk@49731 git-svn-id: http://core.svn.wordpress.org/trunk@49454 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-01 20:47:06 +00:00
Sergey Biryukov	2c1bfb5baf	Administration: Make sure row actions for recent comments in Activity dashboard widget stay visible when a single row gets focus. ... Follow-up to [49142]. Props sabernhardt, kebbet, hareesh-pillai, pbiron. Fixes #51886. See #51516, #49715. Built from https://develop.svn.wordpress.org/trunk@49725 git-svn-id: http://core.svn.wordpress.org/trunk@49448 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-01 18:16:07 +00:00
Sergey Biryukov	785cb6cc7d	Media: Revert [49567]. ... This addresses a regression with the pagination section in Media Library no longer taking additional query filtering into account. Props iCaleb, trepmal, peterwilsoncc. See #39968. Built from https://develop.svn.wordpress.org/trunk@49720 git-svn-id: http://core.svn.wordpress.org/trunk@49443 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-01 16:33:05 +00:00
TimothyBlynJacobs	c3b40f7f80	Site Health, App Passwords: Ensure REST API responses are properly translated. ... The REST API requests in Site Health and App Passwords now include `_locale=user` in the request URL to ensure the user's locale is used instead of the site locale. Additionally, the `apiRequest` library now sends a JSON `Accept` header which is required by `determine_locale()` to respect the `_locale` query parameter. The Site Health REST API controllers now manually load the default admin textdomain if not `is_admin()`. This allows for the Site Health tests to be translated even though the translations are part of the administration project and the REST API is not. Props oglekler, kebbet, Clorith, TimothyBlynJacobs, ocean90, SergeyBiryukov, adamsilverstein. Fixes #51871. Built from https://develop.svn.wordpress.org/trunk@49716 git-svn-id: http://core.svn.wordpress.org/trunk@49439 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-12-01 03:44:05 +00:00
Andrew Ozz	190b9a0b32	Quick/Bulk Edit: Follow up to [49703]. Improve the logic a bit and always return this (the jQuery object) in wpTagsSuggest. ... Fixes #51872. Built from https://develop.svn.wordpress.org/trunk@49710 git-svn-id: http://core.svn.wordpress.org/trunk@49433 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-30 14:31:04 +00:00
Sergey Biryukov	ce3334571d	Upgrade/Install: Display "You are using a development version" message on WordPress Updates screen for Beta or RC versions. ... This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version. Follow-up to [49245], [49254], [49292], [49638], [49708]. Props afragen, audrasjb, azaozz, SergeyBiryukov. Fixes #51822. Built from https://develop.svn.wordpress.org/trunk@49709 git-svn-id: http://core.svn.wordpress.org/trunk@49432 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-30 13:42:07 +00:00
Sergey Biryukov	95f28a3fd2	Upgrade/Install: Display "You are using a development version" message in the admin footer for Beta or RC versions. ... This ensures that the message is displayed when the `WP_AUTO_UPDATE_CORE` constant is set to `beta` or `rc` and the user is on a development version. Props afragen. Fixes #51892. Built from https://develop.svn.wordpress.org/trunk@49708 git-svn-id: http://core.svn.wordpress.org/trunk@49431 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-29 16:13:06 +00:00
Sergey Biryukov	2797594835	Comments: Correct ending tag placement in the "Search results for: ..." subtitle. ... Follow-up to [49284], [49286]. Props Clorith, kebbet, johnbillion, audrasjb, azaozz. Fixes #51889. See #37353. Built from https://develop.svn.wordpress.org/trunk@49705 git-svn-id: http://core.svn.wordpress.org/trunk@49428 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-28 17:28:05 +00:00
Andrew Ozz	bac1ada04d	Quick/Bulk Edit: Fix undefined error when initializing UI Autocomplete 1.12.1 on non-existing element and then attempting to use the autocomplete instance. ... Example: `jQuery( '#nonexisting' ).autocomplete().autocomplete( 'instance' ).something`. Props _luigi, sabernhardt, donmhico, azaozz. Fixes #51872. Built from https://develop.svn.wordpress.org/trunk@49703 git-svn-id: http://core.svn.wordpress.org/trunk@49426 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-28 12:46:05 +00:00
ryelle	33749fcc74	Help/About: Update URLs in About page ... Replace the placeholder links now that the posts have been published. This also updates the jQuery plugin links to to local-site links, if the user can install plugins. Follow-up to [49640]. Props mukesh27, ocean90. See #51415. Built from https://develop.svn.wordpress.org/trunk@49702 git-svn-id: http://core.svn.wordpress.org/trunk@49425 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-27 17:10:07 +00:00
John Blackbourn	f4cda1b62f	Docs: Upgrade more parameters in docblocks to used typed array notation. ... See #51800, #41756 Built from https://develop.svn.wordpress.org/trunk@49693 git-svn-id: http://core.svn.wordpress.org/trunk@49416 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-24 21:27:05 +00:00
John Blackbourn	780cdb5eb5	Docs: Various docblock corrections relating to parameter types. ... See #51800 Built from https://develop.svn.wordpress.org/trunk@49692 git-svn-id: http://core.svn.wordpress.org/trunk@49415 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-24 21:22:04 +00:00
Sergey Biryukov	771b1048be	Help/About: Move trailing punctuation in the jQuery Migrate Helper plugin link outside of the HTML tag. ... Props psmits1567, audrasjb, tobifjellner, fierevere, markscottrobson. Fixes #51813. Built from https://develop.svn.wordpress.org/trunk@49685 git-svn-id: http://core.svn.wordpress.org/trunk@49408 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-23 19:35:03 +00:00
Sergey Biryukov	5f9cf0141e	Plugins: Check if _error_nonce is set before attempting to verify it. ... This avoids a PHP notice on the Plugins screen when `error` query string is added to the URL. Props wponlinesupport. Fixes #43876. Built from https://develop.svn.wordpress.org/trunk@49683 git-svn-id: http://core.svn.wordpress.org/trunk@49406 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-23 13:36:07 +00:00
Sergey Biryukov	8312762816	Docs: Update syntax for multi-line comment in core_auto_updates_settings() per the documentation standards. ... Follow-up to [49677]. See #51827. Built from https://develop.svn.wordpress.org/trunk@49681 git-svn-id: http://core.svn.wordpress.org/trunk@49404 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-22 15:59:05 +00:00
Andrew Ozz	991114fb57	Upgrade/Install: Replace the conditionals that check the AUTOMATIC_UPDATER_DISABLED constant and the automatic_updater_disabled filter in update-core.php with a call to WP_Automatic_Updater::is_disabled(). This prevents a PHP warning, fixes the logic, and considers wp_is_file_mod_allowed( 'automatic_updater' ) when determining the UI state. ... Props jamesros161, pbiron, audrasjb, azaozz. Fixes #51827. Built from https://develop.svn.wordpress.org/trunk@49677 git-svn-id: http://core.svn.wordpress.org/trunk@49400 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-22 13:03:06 +00:00
Sergey Biryukov	9150652fed	Site Health: Check if $core_updates is an array before iterating on it. ... This avoids a PHP warning if `get_core_updates()` returns `false`. Props paulschreiber. Fixes #51818. Built from https://develop.svn.wordpress.org/trunk@49676 git-svn-id: http://core.svn.wordpress.org/trunk@49399 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-21 14:39:03 +00:00
Sergey Biryukov	5ab5b3e73b	Docs: Add missing @since tags for WP_Upgrader_Skin methods. ... See #51800. Built from https://develop.svn.wordpress.org/trunk@49675 git-svn-id: http://core.svn.wordpress.org/trunk@49398 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-21 12:08:05 +00:00
ryelle	7ded4af960	Help/About: Clarify accessibility features. ... * Captions are uploaded in the block editor, and not created in the editor. * Avoid making an invalid claim of WCAG 2.1 conformance or trivialize the efforts still required to build an accessible and compliant site. Follow-up to [49640]. Props joedolson. See #51415. Built from https://develop.svn.wordpress.org/trunk@49674 git-svn-id: http://core.svn.wordpress.org/trunk@49397 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-21 00:13:07 +00:00
John Blackbourn	6e472178d1	Docs: Add missing @since tags. ... See #51800 Built from https://develop.svn.wordpress.org/trunk@49671 git-svn-id: http://core.svn.wordpress.org/trunk@49394 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-19 17:54:05 +00:00
Sergey Biryukov	da6ab833d5	Coding Standards: Remove redundant isset() check in core_upgrade_preamble(). ... `isset()` can be safely used to check properties and subproperties of objects directly. Follow-up to [49638]. See #51799. Built from https://develop.svn.wordpress.org/trunk@49668 git-svn-id: http://core.svn.wordpress.org/trunk@49391 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-19 12:05:06 +00:00
Sergey Biryukov	6cde96263b	Help/About: Correct placeholder for the accessibility statement feature plugin link. ... Add missing translator comment. Props audrasjb. See #51415. Built from https://develop.svn.wordpress.org/trunk@49651 git-svn-id: http://core.svn.wordpress.org/trunk@49388 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-18 15:51:04 +00:00
Sergey Biryukov	05125ed8bf	Site Health: Add missing i18n for the App Passwords documentation link. ... Follow-up to [49334]. Props tai. Fixes #51815. Built from https://develop.svn.wordpress.org/trunk@49650 git-svn-id: http://core.svn.wordpress.org/trunk@49387 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-18 15:04:05 +00:00
ryelle	6214f61cb1	Help/About: WordPress 5.6 About Page. ... This change introduces the new About page for WordPress 5.6. Props elmastudio, ryelle, melchoyce, karmatosed, webcommsat, marybaum, meher, OGlekler, lmurillom, vimes1984, sabrinazeidan, nalininonstopnewsuk, afshanadiya, michelleames, bmcdede, yvettesonneveld, sarahricker, isabel_brison, helen, hellofromtonya, poena, chanthaboune, cbringmann, joedolson, sabernhardt, garrett-eclipse, audrasjb, marks99. See #51415. Built from https://develop.svn.wordpress.org/trunk@49640 git-svn-id: http://core.svn.wordpress.org/trunk@49378 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-17 21:34:04 +00:00
Helen Hou-Sandí	b456e9c9c8	Upgrade/Install: Consistent layout and accurate messages on the update screen. ... * Clarifies that if you are on maintenance/security auto-updates that you are only on those and therefore there are more options available. * Adds a message if a version control system has been detected, as automatic updates are disabled in that case. * Ensures only one heading between `update available`, `you are on a dev version`, and `you are on latest` appears at any given time, falling back to `you are on latest` if something strange happens with the returned update data. * Removes some older strings related to auto-updates, which greatly simplifies the above. * Strips the `core-major-auto-updates-saved` query arg from the URL, as it is related to a dismissible notice. Props audrasjb, pbiron, helen. Fixes #51742. Built from https://develop.svn.wordpress.org/trunk@49638 git-svn-id: http://core.svn.wordpress.org/trunk@49376 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-17 20:28:04 +00:00
Sergey Biryukov	cf75a715c4	App Passwords: Regenerate the .htaccess file to add a new rule. ... Application Passwords introduced a new Rewrite Rule to handle the Authorization header on certain systems. This bumps the database version and updates the file so the change is applied to sites upon upgrading to 5.6. Follow-up to [49534]. Props pbiron, TimothyBlynJacobs, SergeyBiryukov. Fixes #51723. Built from https://develop.svn.wordpress.org/trunk@49632 git-svn-id: http://core.svn.wordpress.org/trunk@49370 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-17 17:24:06 +00:00
Sergey Biryukov	f97647c207	Plugins: Make sure the HTML ID attributes for plugin checkboxes are unique. ... Follow-up to [48374]. Props helen, sabernhardt, kishanjasani, mukesh27, hareesh-pillai. Fixes #51256. Built from https://develop.svn.wordpress.org/trunk@49631 git-svn-id: http://core.svn.wordpress.org/trunk@49369 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-17 16:48:09 +00:00
noisysocks	9f065de733	Customize: Temporary fix for autosave restore notice not being removed ... Fixes the "There is a more recent autosave of your changes" notice from not being removed when the dismiss button is clicked. The problem is caused by the notice being initialized twice: once by the `common` script and then again by the `customize-controls` script. This temporary fix prevents `customize-controls` from initializing a notice if it has already been initialized. A better fix would be to not initialize notices twice. This can be done by removing `common` as a dependency of `updates` when `deprecateL10nObject` is removed. When this happens (est: 5.7), this temporary fix should be reverted. Fixes #51425. See #51317. Props karthikbhatb, dlh, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@49625 git-svn-id: http://core.svn.wordpress.org/trunk@49363 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-17 04:45:11 +00:00
TimothyBlynJacobs	d9b35c8e98	App Passwords: Unify availability language. ... Previously App Passwords used a mix of "enabled" and "available". We've now standardized on using "available". Additionally, we now use a 501 status code when indicating that App Passwords is not available. Props SergeyBiryukov, ocean90, TimothyBlynJacobs. Fixes #51513. Built from https://develop.svn.wordpress.org/trunk@49617 git-svn-id: http://core.svn.wordpress.org/trunk@49355 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-16 22:42:04 +00:00
Helen Hou-Sandí	aceaf33edd	Multisite: More consistency for clean_dirsize_cache(). ... Props SergeyBiryukov. Fixes #19879. Built from https://develop.svn.wordpress.org/trunk@49616 git-svn-id: http://core.svn.wordpress.org/trunk@49354 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-16 22:31:06 +00:00
Helen Hou-Sandí	14bd8cc469	Posts, Post Types: Go back to "Auto Draft" for CPTs without title support. ... Reverts [49288] due to late point in 5.6 cycle and lack of update in Gutenberg package to account for the string change. See #45516. Built from https://develop.svn.wordpress.org/trunk@49614 git-svn-id: http://core.svn.wordpress.org/trunk@49352 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-16 19:44:07 +00:00
TimothyBlynJacobs	44125fc590	App Passwords: Include authorization rewrite rule in default multisite .htaccess ... This rule was previously added to `WP_Rewrite`, but multisite uses a different .htaccess generation mechanism. Props pbiron. Fixes #51772. See [49109]. Built from https://develop.svn.wordpress.org/trunk@49607 git-svn-id: http://core.svn.wordpress.org/trunk@49345 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-15 17:46:06 +00:00
Sergey Biryukov	df2644a14a	Docs: Add missing descriptions for _WP_List_Table_Compat methods. ... Props johannadevos, SaeedFard, swissspidy, desrosj, SergeyBiryukov. Fixes #46842. Built from https://develop.svn.wordpress.org/trunk@49599 git-svn-id: http://core.svn.wordpress.org/trunk@49337 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-14 16:54:08 +00:00
Sergey Biryukov	185607c417	Docs: Add missing descriptions for Automatic_Upgrader_Skin methods. ... Props johannadevos, dilipbheda. Fixes #44546. Built from https://develop.svn.wordpress.org/trunk@49596 git-svn-id: http://core.svn.wordpress.org/trunk@49334 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-14 16:23:10 +00:00
Andrew Ozz	d817ad9b55	Upgrade/Install: Ensure the current user can update core when saving the auto-update options. ... See #51742. Built from https://develop.svn.wordpress.org/trunk@49593 git-svn-id: http://core.svn.wordpress.org/trunk@49331 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-13 16:57:13 +00:00
Sergey Biryukov	0bc22bb1fc	Upgrade/Install: Account for the automatic_updater_disabled filter in core auto-update settings UI. ... Follow-up to [49587]. Props markparnell, audrasjb. See #51742. Built from https://develop.svn.wordpress.org/trunk@49592 git-svn-id: http://core.svn.wordpress.org/trunk@49330 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-13 11:14:08 +00:00
Sergey Biryukov	d6a597efe2	I18N: Remove HTML tags from translatable strings on WordPress Updates screen. ... Follow-up to [49587]. Props fierevere. See #51742. Built from https://develop.svn.wordpress.org/trunk@49591 git-svn-id: http://core.svn.wordpress.org/trunk@49329 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-13 10:50:08 +00:00
Helen Hou-Sandí	582ca50733	Upgrade/Install: Better UI for auto-update settings on update screen. ... This adds clearer messages about what your current settings mean for updates, uses a more compact link-based action instead of a checkbox to change the setting, and respects constants and filters. Props audrasjb, karmatosed, helen, azaozz, hedgefield, marybaum. Fixes #51742. Built from https://develop.svn.wordpress.org/trunk@49587 git-svn-id: http://core.svn.wordpress.org/trunk@49325 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-12 22:37:10 +00:00
Sergey Biryukov	c5257328b7	Customize: Exclude widget ID attributes from search. ... Having search terms match the ID attributes leads to confusing results, specifically when the admin interface is set to a language other than English. Follow-up to [27650]. Props afercia, dlh, noisysocks. Fixes #46456. Built from https://develop.svn.wordpress.org/trunk@49586 git-svn-id: http://core.svn.wordpress.org/trunk@49324 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-12 22:05:09 +00:00
Sergey Biryukov	f2364f163b	Administration: Make sure auto-update counts properly update when bulk deleting plugins or themes. ... Props pbiron, noisysocks, desrosj, audrasjb, hellofromTonya. Fixes #50870. Built from https://develop.svn.wordpress.org/trunk@49582 git-svn-id: http://core.svn.wordpress.org/trunk@49320 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-12 20:42:10 +00:00
Helen Hou-Sandí	d5fd3bd452	Upgrade/Install: Enable all core autoupdates for new installs. ... Likely needs more work for multisite installs. Reference: https://make.wordpress.org/core/2020/11/10/wp5-6-auto-update-implementation-change/ Props audrasjb, azaozz. See #51743. Built from https://develop.svn.wordpress.org/trunk@49581 git-svn-id: http://core.svn.wordpress.org/trunk@49319 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-12 20:22:09 +00:00
TimothyBlynJacobs	5ee48d6915	App Passwords: MOAR accessibility improvements. ... Corrects the "Application Name" field's aria-describedby attribute and makes the description visible. Props alexstine, SergeyBiryukov. Fixes #51580. Built from https://develop.svn.wordpress.org/trunk@49573 git-svn-id: http://core.svn.wordpress.org/trunk@49311 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-12 18:14:08 +00:00
Sergey Biryukov	d772517fcc	Database: Clean up the post_category column removed from DB schema for new installations in WordPress 2.8. ... Its presence may conflict with `WP_Post::__get()`, which should generally fill the non-existent `post_category` property, but is not triggered if the column exists in the database. Follow-up to [10895]. Props leogermani, davidbaumwald, hellofromTonya. Fixes #51288. Built from https://develop.svn.wordpress.org/trunk@49572 git-svn-id: http://core.svn.wordpress.org/trunk@49310 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-12 17:55:11 +00:00
antpb	8efbef867c	Media: Improve count in Media Library pagination. ... Deleting all visible items on the last page of the media library previously left a blank page with no media items available. Using `wp_count_attachements` instead of `found_posts` solves the problem. Props donsony, karmatosed, desrosj, mista-flo, justinahinon. Fixes #39968. Built from https://develop.svn.wordpress.org/trunk@49567 git-svn-id: http://core.svn.wordpress.org/trunk@49305 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-12 15:40:09 +00:00
Sergey Biryukov	3a1265e188	I18N: Add trailing punctuation to some translator comments. ... Follow-up to [49549]. See #51580. Built from https://develop.svn.wordpress.org/trunk@49562 git-svn-id: http://core.svn.wordpress.org/trunk@49300 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-11 10:41:07 +00:00
Sergey Biryukov	1f984603a2	Help/About: Add Site Health Status dashboard widget to the Help → Content tab. ... Reorder the items in the help tab to align with their default position on the Dashboard screen. Follow-up to [47063], [47300]. Props nlpro. Fixes #51745. Built from https://develop.svn.wordpress.org/trunk@49558 git-svn-id: http://core.svn.wordpress.org/trunk@49296 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-10 19:05:10 +00:00
antpb	64beb3ee49	Media: Removes duplicate alignment fix for browser uploader. ... See #41648 Built from https://develop.svn.wordpress.org/trunk@49555 git-svn-id: http://core.svn.wordpress.org/trunk@49293 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-09 23:43:07 +00:00
antpb	4f2e88a574	Media: Adjusts alignment of file name text in browser uploader. ... Sets a defined size for text alongside the media browser uploader button fixing alignment on popular browsers. Props krupajnanda, mikeschroder, aaroncampbell, lucagrandicelli, andraganescu, samful, sabernhardt, andystitt829, kburgoine. Fixes #41648 Built from https://develop.svn.wordpress.org/trunk@49553 git-svn-id: http://core.svn.wordpress.org/trunk@49291 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-09 23:34:09 +00:00
antpb	9901c9a48d	Media: Adjust box-sizing for audio players. ... Fix cropped container around playhead time in audio player. Props ravipatel, sabernhardt, audrasjb, SergeyBiryukov, Fixes #51685 Built from https://develop.svn.wordpress.org/trunk@49550 git-svn-id: http://core.svn.wordpress.org/trunk@49288 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-09 19:34:08 +00:00
TimothyBlynJacobs	74969e7fbe	App Passwords: Further accessibility improvements. ... - Add a label to the readonly password input. - Handle focus loss after revoking app passwords. - Handle focus loss after dismissing notices. - Mark app name as `aria-required`. - Use `aria-label` for detailed revoke button text instead of `title`. - Use `-1` for `tabindex` instead of `0`. Props alexstine, afercia, sabernhardt, audrasjb, joedolson, TimothyBlynJacobs. Fixes #51580. Built from https://develop.svn.wordpress.org/trunk@49549 git-svn-id: http://core.svn.wordpress.org/trunk@49287 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-09 18:05:08 +00:00
John Blackbourn	34765ddb64	Docs: Docblock corrections relating to WP_Post objects. ... See #51373, #50768 Built from https://develop.svn.wordpress.org/trunk@49544 git-svn-id: http://core.svn.wordpress.org/trunk@49282 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-09 15:15:08 +00:00
Sergey Biryukov	a2d42351c5	Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings. ... Standardize on "Go to..." as a more appropriate option for most cases. Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora. Fixes #47235. Built from https://develop.svn.wordpress.org/trunk@49539 git-svn-id: http://core.svn.wordpress.org/trunk@49277 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-09 10:53:10 +00:00
Sergey Biryukov	5683c46277	Site Health: Validate the test result data format in JS before using it. ... This will discard any invalid responses instead of causing fatal errors. It also makes badges optional, on the same basis as actions are optional. They are expected, but there may be situations where they are not present. Props Clorith, dogwithblog, kraftbj, whyisjake, SergeyBiryukov. Fixes #50145. Built from https://develop.svn.wordpress.org/trunk@49537 git-svn-id: http://core.svn.wordpress.org/trunk@49275 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-08 09:52:10 +00:00
desrosj	5392af9208	Upgrade/Install: Change the notice displayed after saving auto-update settings to .notice-success. ... This better conveys the message of the notice and brings consistency with other success notices throughout Core. Props audrasjb. Fixes #51701. Built from https://develop.svn.wordpress.org/trunk@49490 git-svn-id: http://core.svn.wordpress.org/trunk@49249 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-03 17:55:06 +00:00
Sergey Biryukov	a940c08357	Docs: Document the $linkdata parameter of wp_insert_link() using hash notation. ... Props stevenlinx, peterwilsoncc. Fixes #50853. Built from https://develop.svn.wordpress.org/trunk@49487 git-svn-id: http://core.svn.wordpress.org/trunk@49246 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-03 03:52:10 +00:00
Helen Hou-Sandí	a3581edd84	Upgrade/Install: Update help tab text to include major WordPress updates. ... Props audrasjb. Fixes #51653. Built from https://develop.svn.wordpress.org/trunk@49483 git-svn-id: http://core.svn.wordpress.org/trunk@49242 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-02 20:16:06 +00:00
desrosj	6a39c891b2	Customize: Ensure menu items expand horizontally on large screens. ... Props clorith, garrett-eclipse. Fixes #51647. Built from https://develop.svn.wordpress.org/trunk@49481 git-svn-id: http://core.svn.wordpress.org/trunk@49240 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-02 20:07:05 +00:00
Helen Hou-Sandí	be95ec2c27	About: Optimize freedoms sprite and add 2 column layout. ... Props garrett-eclipse, ryelle. Fixes #46363. Built from https://develop.svn.wordpress.org/trunk@49479 git-svn-id: http://core.svn.wordpress.org/trunk@49238 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-02 19:46:14 +00:00
desrosj	e3a467a55a	Upgrade/Install: Prevent removal of additional data from plugin update info. ... This switches to using `wp_parse_args()` instead of a combination of `array_merge()` and `array_intersect_key()` when ensuring that all expected default keys are present in the update information for a plugin. This prevents non-default data returned by 3rd-party plugins from being unintentionally stripped out. Props peterwilsoncc, chriscct7. Fixes #51609. Built from https://develop.svn.wordpress.org/trunk@49477 git-svn-id: http://core.svn.wordpress.org/trunk@49236 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-02 19:13:07 +00:00
Sergey Biryukov	89ce61835d	Upgrade/Install: Switch "Check again" link on WordPress Updates screen to sentence case. ... This brings some consistency with other text links on the screen, e.g. "View version details" for plugins or themes. Follow-up to [49150]. Props afercia. See #51523. Built from https://develop.svn.wordpress.org/trunk@49471 git-svn-id: http://core.svn.wordpress.org/trunk@49230 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-11-02 01:17:09 +00:00
Adam Silverstein	25918dd10b	Users: Password generation - restore "Cancel" aria label after r49248. ... Restore the "Cancel" button aria label to "Cancel password change" after it was inadvertently changed in r49248. Props SergeyBiryukov. Fixes #42852. Built from https://develop.svn.wordpress.org/trunk@49392 git-svn-id: http://core.svn.wordpress.org/trunk@49151 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-29 18:43:06 +00:00
desrosj	9c5173ffa6	Themes: Ensure that only privileged users can set a background image when a theme is using the deprecated custom background page. ... Props xknown, zieladam, peterwilsoncc, whyisjake. Merges [49379] to trunk. Built from https://develop.svn.wordpress.org/trunk@49388 git-svn-id: http://core.svn.wordpress.org/trunk@49147 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-29 18:09:13 +00:00
desrosj	1050613168	Coding standards: Modify escaping functions to avoid potential false positives. ... Props xknown, zieladam, peterwilsoncc. Merges [49375] to trunk. Built from https://develop.svn.wordpress.org/trunk@49384 git-svn-id: http://core.svn.wordpress.org/trunk@49143 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-29 18:03:11 +00:00
Helen Hou-Sandí	9241624e6c	Menus: Better responsive display for accordion items. ... This only applies to the standalone menu screen; fixes for the customizer will be handled separately. Props audrasjb, garrett-eclipse. See #49375. Built from https://develop.svn.wordpress.org/trunk@49346 git-svn-id: http://core.svn.wordpress.org/trunk@49106 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 20:18:06 +00:00
Sergey Biryukov	a6db16fad0	Upgrade/Install: Adjust a string in core_auto_updates_settings() for consistency. ... Props audrasjb, desrosj. See #50907. Built from https://develop.svn.wordpress.org/trunk@49345 git-svn-id: http://core.svn.wordpress.org/trunk@49105 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 20:12:06 +00:00
Helen Hou-Sandí	7636806a52	Media: Fix styling for MediaElement player in media modal. ... Fixes #43640. Built from https://develop.svn.wordpress.org/trunk@49343 git-svn-id: http://core.svn.wordpress.org/trunk@49103 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 19:40:04 +00:00
Helen Hou-Sandí	85e954aa37	Login: Avoid AJAX error on login screen. ... This has to do with the password generator, which does not need to generate and cache passwords in JS as that's already done in PHP. Props adamsilverstein, sarahricker. Fixes #51613. Built from https://develop.svn.wordpress.org/trunk@49337 git-svn-id: http://core.svn.wordpress.org/trunk@49098 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 18:43:07 +00:00
TimothyBlynJacobs	2df94804d4	Site Health, App Passwords: Test if the Authorization header is populated correctly. ... App Passwords rely on the Authorization header to transport the Basic Auth credentials. For Apache web servers, WordPress automatically includes a RewriteRule to populate the value for servers running in CGI or FastCGI that wouldn't ordinarily populate the value. This tests if the header is being filled with the expected values. For Apache users, we direct the user to visit the Permalinks settings to flush their permalinks. For all other users, we direct them to a help document on developer.wordpress.org. Props Clorith, marybaum, TimothyBlynJacobs. Fixes #51638. Built from https://develop.svn.wordpress.org/trunk@49334 git-svn-id: http://core.svn.wordpress.org/trunk@49095 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 18:32:07 +00:00
Helen Hou-Sandí	219079f7a3	Privacy: Show failures before successes for all bulk actions. ... Props garrett-eclipse. See #44081, [49331]. Built from https://develop.svn.wordpress.org/trunk@49333 git-svn-id: http://core.svn.wordpress.org/trunk@49094 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 18:19:06 +00:00
Helen Hou-Sandí	f4f72498c0	Privacy: Show notices for both failed and successful bulk actions. ... Props javorszky, garrett-eclipse, hellofromTonya. Fixes #44081. Built from https://develop.svn.wordpress.org/trunk@49331 git-svn-id: http://core.svn.wordpress.org/trunk@49092 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 17:47:08 +00:00
Andrew Ozz	7c32cbf990	Revert the improvenents to arranging of postboxes/metaboxes, [49179]. The current patch fixes about half a dozen problems, but seems more general improvements are needed to how Screen Options work. ... See #50699. Built from https://develop.svn.wordpress.org/trunk@49325 git-svn-id: http://core.svn.wordpress.org/trunk@49086 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 10:47:12 +00:00
Sergey Biryukov	18ee84c5c2	Customize: Ensure the New Menu section is properly rendered. ... Follow-up to [30102], [49101]. Props david.binda, boldgrid, dlh, azaozz, Clorith, westonruter, hellofromTonya. Fixes #51592. Built from https://develop.svn.wordpress.org/trunk@49323 git-svn-id: http://core.svn.wordpress.org/trunk@49084 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 02:48:06 +00:00
Sergey Biryukov	0fb5ccd4d0	Docs: Add a @global tag for $user_id in WP_Application_Passwords_List_Table::prepare_items(). ... Props mukesh27. Fixes #51633. Built from https://develop.svn.wordpress.org/trunk@49321 git-svn-id: http://core.svn.wordpress.org/trunk@49082 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-27 02:12:06 +00:00
Helen Hou-Sandí	8b3071bc1a	Administration: Accommodate long translations for "Posts" in list table headers. ... This stems from longer translations on the User table, but this will apply to any posts column in a list table. Hyphenation should typically just apply to the column header, as the cell contents are just a count. This does appear to have some browser inconsistencies, so may need further adjustment in the future. Props audrasjb, justinahinon. Fixes #50838. Built from https://develop.svn.wordpress.org/trunk@49317 git-svn-id: http://core.svn.wordpress.org/trunk@49079 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-26 23:16:05 +00:00
Sergey Biryukov	4bb4107f50	General: Use correct value for the speak property in various CSS files. ... Follow-up to [49263]. Props hareesh-pillai. Fixes #51622. Built from https://develop.svn.wordpress.org/trunk@49309 git-svn-id: http://core.svn.wordpress.org/trunk@49071 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-26 02:25:09 +00:00
Sergey Biryukov	4d695ba6b3	Coding Standards: Remove unused $current_role variable from Add New User form. ... Follow-up to [9614], [28296]. Props ravipatel. Fixes #51619. Built from https://develop.svn.wordpress.org/trunk@49298 git-svn-id: http://core.svn.wordpress.org/trunk@49060 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-24 12:49:05 +00:00
Sergey Biryukov	10091823f1	Coding Standards: Use consistent formatting for <div class="wrap"> sections in wp-admin/update-core.php. ... Follow-up to [28500], [28530]. Props ravipatel. Fixes #51618. Built from https://develop.svn.wordpress.org/trunk@49297 git-svn-id: http://core.svn.wordpress.org/trunk@49059 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-24 12:33:07 +00:00
TimothyBlynJacobs	f6d39d1c51	App Passwords: Improve accessibility. ... - Make form inputs stacked instead of inline. - Provide a visible label for the app name. - Add screen reader text to dismiss button. - Make "Revoke" button label more descriptive. - Use aria-disabled instead of disabled to avoid focus loss. - Display password in a readonly input to assist copy and paste. - Remove large sections of italic text. - Use `.form-wrap` and `.form-field` to give consistent form styling. - Improve labeling and placeholder text. Props alexstine, georgestephanis, afercia, TimothyBlynJacobs. Fixes #51580. Built from https://develop.svn.wordpress.org/trunk@49294 git-svn-id: http://core.svn.wordpress.org/trunk@49056 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-24 03:34:06 +00:00
Sergey Biryukov	d195b0dfbb	Docs: Add missing duplicate hook references for allow_(dev|minor|major)_auto_core_updates filters. ... Follow-up to [49254]. See #50907. Built from https://develop.svn.wordpress.org/trunk@49293 git-svn-id: http://core.svn.wordpress.org/trunk@49055 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-24 00:31:05 +00:00
Sergey Biryukov	bb63c1cbd9	Upgrade/Install: Account for new WP_AUTO_UPDATE_CORE values in auto-updates settings form. ... This updates `core_auto_updates_settings()` to account for the new `beta` and `rc` values for the `WP_AUTO_UPDATE_CORE` constant. Additionally, recognize these new values as acceptable in Site Health tests. Follow-up to [48804], [49245], [49254]. Fixes #51319. See #50907. Built from https://develop.svn.wordpress.org/trunk@49292 git-svn-id: http://core.svn.wordpress.org/trunk@49054 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-24 00:26:05 +00:00
TimothyBlynJacobs	e992757e5b	App Passwords: Include site_url in the success redirect payload. ... Props georgestephanis. Fixes #51602. Built from https://develop.svn.wordpress.org/trunk@49291 git-svn-id: http://core.svn.wordpress.org/trunk@49053 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-24 00:07:08 +00:00
Sergey Biryukov	ce4b1cc8ba	Toolbar: Keep IE 11 scrollbar on the side instead of overlapping the toolbar. ... Props sabernhardt, shital-patel, y_kolev. Fixes #48545. Built from https://develop.svn.wordpress.org/trunk@49290 git-svn-id: http://core.svn.wordpress.org/trunk@49052 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 19:49:08 +00:00
Sergey Biryukov	ee3dac88f0	Privacy: Use more appropriate verbiage when downloading personal data export file from a row action. ... Props garrett-eclipse, bridgetwillard. Fixes #49319. Built from https://develop.svn.wordpress.org/trunk@49289 git-svn-id: http://core.svn.wordpress.org/trunk@49051 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 19:33:07 +00:00
Sergey Biryukov	d9838eed62	Posts, Post Types: Set better default title for custom post types without title support. ... The default title is now set to "(no title supported)" instead of "Auto Draft". Props garrett-eclipse, rajanit2000, bridgetwillard, donmhico, nrqsnchz. Fixes #45516. Built from https://develop.svn.wordpress.org/trunk@49288 git-svn-id: http://core.svn.wordpress.org/trunk@49050 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 19:09:10 +00:00
Sergey Biryukov	36d58abc8e	Help/About: Clarify that discouraging search engines does not prevent them from crawling the site. ... Props carike, garrett-eclipse, hellofromTonya. Fixes #51274. Built from https://develop.svn.wordpress.org/trunk@49287 git-svn-id: http://core.svn.wordpress.org/trunk@49049 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 18:07:13 +00:00
Sergey Biryukov	f83aa63730	Coding Standards: Split long printf() calls for search results for better readability. ... Follow-up to [49284]. See #37353. Built from https://develop.svn.wordpress.org/trunk@49286 git-svn-id: http://core.svn.wordpress.org/trunk@49048 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 17:19:14 +00:00
Aaron Campbell	608ba462dd	Upgrade/Install: Improve copy for opt-in to automatic major version updates. ... Props marybaum, kebbet. See #50907. Built from https://develop.svn.wordpress.org/trunk@49285 git-svn-id: http://core.svn.wordpress.org/trunk@49047 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 16:36:14 +00:00
Helen Hou-Sandí	e0c12cc818	Administration: Unify search results message on list tables. ... This wraps the search string in a `<strong>` tag, which makes easier to parse visually especially when your search string also contains double quotes. Props Mista-Flo, mapk, sergeybiryukov. Fixes #37353. Built from https://develop.svn.wordpress.org/trunk@49284 git-svn-id: http://core.svn.wordpress.org/trunk@49046 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 16:01:15 +00:00
Helen Hou-Sandí	4847fb4263	Administration: Better targeting for required form field highlighting. ... Previously, any `input` or `select` inside of a `.form-invalid` wrapper would get the red border highlighting, including submit buttons which was not visually correct. This now only applies to form elements with a class of `.form-required` inside of the `.form-invalid` wrapper. It also continues to apply the border to elements with both classes (`.form-invalid.form-required`) as that is how some of the admin markup is structured. Plugin authors may need to do the same sort of class application seen in this commit, i.e. add `.form-required` to certain form elements. Props sabernhardt, dilipbheda, helen. Fixes #50686. Built from https://develop.svn.wordpress.org/trunk@49283 git-svn-id: http://core.svn.wordpress.org/trunk@49045 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 15:05:09 +00:00
Sergey Biryukov	298cd04a63	Coding Standards: Update some alignment in wp-admin/authorize-application.php for consistency. ... Save blogs count to a variable for reusing. Follow-up to [49270]. See #51489. Built from https://develop.svn.wordpress.org/trunk@49282 git-svn-id: http://core.svn.wordpress.org/trunk@49042 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-23 01:19:06 +00:00
TimothyBlynJacobs	ce34d0ab00	App Passwords: Support an app_id to uniquely identify instances of an app. ... Apps may now optionally include an `app_id` parameter when directing the user to the Authorize Application screen. This allows for instances of an application to be identified and potentially revoked or blocked. Props TimothyBlynJacobs, georgestephanis. Fixes #51583. Built from https://develop.svn.wordpress.org/trunk@49276 git-svn-id: http://core.svn.wordpress.org/trunk@49038 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-22 15:06:09 +00:00
Sergey Biryukov	83c900e8b3	Upgrade/Install: Add missing </form> tag in auto-updates settings form. ... Props imath, ahortin, dd32, afragen. Fixes #51598. See #50907. Built from https://develop.svn.wordpress.org/trunk@49274 git-svn-id: http://core.svn.wordpress.org/trunk@49036 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-22 03:38:10 +00:00
TimothyBlynJacobs	fe8bb3ea58	App Passwords: Fix success=false not being appended to fallback reject url. ... Props TimothyBlynJacobs, georgestephanis. Fixes #51581. Built from https://develop.svn.wordpress.org/trunk@49272 git-svn-id: http://core.svn.wordpress.org/trunk@49034 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-22 02:44:05 +00:00
TimothyBlynJacobs	85c49351af	App Passwords: Explain that apps can access to all sites in a network. ... Props georgestephanis, spacedmonkey, johnjamesjacoby, SergeyBiryukov, marybaum. Fixes #51489. Built from https://develop.svn.wordpress.org/trunk@49270 git-svn-id: http://core.svn.wordpress.org/trunk@49032 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-22 02:36:11 +00:00
Sergey Biryukov	ecf8e59918	Docs: Add a @since note about async_direct_test key to the site_status_tests filter. ... Follow-up to [49232]. See #51547. Built from https://develop.svn.wordpress.org/trunk@49266 git-svn-id: http://core.svn.wordpress.org/trunk@49028 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-21 14:55:09 +00:00
Sergey Biryukov	fcc04a6a37	Coding Standards: Fix WPCS issues in [49258]. ... See #46619. Built from https://develop.svn.wordpress.org/trunk@49259 git-svn-id: http://core.svn.wordpress.org/trunk@49021 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 21:20:07 +00:00
Helen Hou-Sandí	e1e6e949ff	Privacy: Add "Mark as completed" action. ... Props garrett-eclipse, ocean90, joostdevalk, mista-flo, helen. Fixes #46619. Built from https://develop.svn.wordpress.org/trunk@49258 git-svn-id: http://core.svn.wordpress.org/trunk@49020 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 21:07:07 +00:00
Helen Hou-Sandí	5b4d643d60	Privacy: Add requester IP to password reset emails. ... Props garrett-eclipse, bridgetwillard, isharis, ocean90. Fixes #43856. Built from https://develop.svn.wordpress.org/trunk@49255 git-svn-id: http://core.svn.wordpress.org/trunk@49017 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 20:03:08 +00:00
Helen Hou-Sandí	9ab2f1ae3e	Upgrade/Install: Add UI for opting in to core auto-updates for major versions. ... Props audrasjb, karmatosed, aaroncampbell, paaljoachim, davidbaumwald. Fixes #50907. Built from https://develop.svn.wordpress.org/trunk@49254 git-svn-id: http://core.svn.wordpress.org/trunk@49016 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 19:35:06 +00:00
Helen Hou-Sandí	874b812ce3	Upgrade/Install: Don't show theme update prompts on subsites. ... If you are using `wp_prepare_themes_for_js()` and relying on `updates`/`no_updates` in multisite, you will need to filter that data back in using the `wp_prepare_themes_for_js` hook. Props pbiron, afragen. Fixes #49831. Built from https://develop.svn.wordpress.org/trunk@49253 git-svn-id: http://core.svn.wordpress.org/trunk@49015 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 19:14:09 +00:00
Adam Silverstein	b789b4ae11	Coding Standards: Fix WPCS issues in [49248]. ... See #42852. Built from https://develop.svn.wordpress.org/trunk@49251 git-svn-id: http://core.svn.wordpress.org/trunk@49013 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 19:07:10 +00:00
Sergey Biryukov	806cfea146	Coding Standards: Fix WPCS issues in [49242]. ... See #50774. Built from https://develop.svn.wordpress.org/trunk@49249 git-svn-id: http://core.svn.wordpress.org/trunk@49011 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 18:31:07 +00:00
Adam Silverstein	daa977c495	Users: improve password generation feature. ... On the user edit screen improve handling and clarify language: rename the "Generate Password" and "Show password" buttons to "Set New Password". Clicking it always generates a password. Also: improve inline code comments and descriptions. Props afercia, bookdude13, michaelarestad, pento. Fixes #42852. Built from https://develop.svn.wordpress.org/trunk@49248 git-svn-id: http://core.svn.wordpress.org/trunk@49010 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 18:27:13 +00:00
Sergey Biryukov	6e71523ead	Upgrade/Install: Allow WordPress sites to opt-in to beta & RC releases. ... The `WP_AUTO_UPDATE_CORE` constant now supports `beta` and `rc` values. This makes it possible for sites to opt-in to updating to RC (or beta) releases without having to install a plugin, or run on a development version. Props dd32, knutsp. Fixes #51319. Built from https://develop.svn.wordpress.org/trunk@49245 git-svn-id: http://core.svn.wordpress.org/trunk@49007 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 17:56:06 +00:00
Sergey Biryukov	94b088339c	Upgrade/Install: Restore casting $filter_payload to an object in WP_MS_Themes_List_Table::prepare_items(). ... Follow-up to [48750], [49241]. See #50875. Built from https://develop.svn.wordpress.org/trunk@49243 git-svn-id: http://core.svn.wordpress.org/trunk@49005 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 17:44:06 +00:00
Helen Hou-Sandí	c8fbc04276	Upgrade/Install: Include "from" version for plugins/themes in email. ... This can help with chasing down any issues that may arise and rolling back if necessary. We hope it's not, but it might be. Props dkotter, garrett-eclipse, pbiron, audrasjb. Fixes #50774. Built from https://develop.svn.wordpress.org/trunk@49242 git-svn-id: http://core.svn.wordpress.org/trunk@49004 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 17:41:07 +00:00
Sergey Biryukov	e38c5ca7d4	Upgrade/Install: Introduce a wrapper for the auto_update_{$type} filter checks. ... This allows for cleaner checks whether auto-updates are forced for a plugin or theme. Follow-up to [48750]. Props rebasaurus, garrett-eclipse, SergeyBiryukov. Fixes #50875. Built from https://develop.svn.wordpress.org/trunk@49241 git-svn-id: http://core.svn.wordpress.org/trunk@49003 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 17:39:07 +00:00
Sergey Biryukov	be5fb561ad	Quick/Bulk Edit: Introduce quick_edit_dropdown_authors_args filter. ... This allows for customizing the arguments used to generate the Quick Edit authors drop-down. Additionally, pass the `$bulk` argument to the `quick_edit_dropdown_pages_args` filter, for consistency. Props Mista-Flo, garrett-eclipse, hellofromTonya. Fixes #47685. Built from https://develop.svn.wordpress.org/trunk@49238 git-svn-id: http://core.svn.wordpress.org/trunk@49000 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 16:40:05 +00:00
Sergey Biryukov	35681b0e9a	Site Health: Introduce the WP_Site_Health::is_development_environment() method. ... This allows Site Health tests to check if the current environment type is set to `development` or `local`. Use the new method: * In HTTPS tests, instead of a hardcoded check for `localhost`. * In `WP_DEBUG` and `WP_DEBUG_DISPLAY` tests, to set the status to `recommended` instead of `critical`. Props dkotter, Clorith, DavidAnderson, joyously, knutsp, afragen, SergeyBiryukov. Fixes #47058. Built from https://develop.svn.wordpress.org/trunk@49237 git-svn-id: http://core.svn.wordpress.org/trunk@48999 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 16:23:07 +00:00
desrosj	8778aa8922	Site Health: Improve the reliability of asynchronous tests. ... This change adds additional logic to catch HTTP failures that do not return a `WP_Error` object (for example, a wp-json REST API error error). This also fixes instances where REST API callbacks performed from cron do not work due to a lack of authentication by introducing a direct callback route that asynchronous tests can register. Props dd32, clorith, timothyblynjacobs. Fixes #51547. Built from https://develop.svn.wordpress.org/trunk@49232 git-svn-id: http://core.svn.wordpress.org/trunk@48994 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 14:50:06 +00:00
Sergey Biryukov	0287a48764	Docs: Update the @since note for _media_states(). ... Follow-up to [49223]. Props mukesh27. Fixes #42063. Built from https://develop.svn.wordpress.org/trunk@49231 git-svn-id: http://core.svn.wordpress.org/trunk@48993 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 14:41:05 +00:00
desrosj	b2622d5d8c	Site Health: Use consistent padding around header tags. ... Props vinita29, clorith. Fixes #50638. Built from https://develop.svn.wordpress.org/trunk@49229 git-svn-id: http://core.svn.wordpress.org/trunk@48991 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 14:18:08 +00:00
desrosj	d40c365a30	Coding Standards: Correct some minor coding standards issues. ... Introduced in [49154], [49212], [49223], and [49224]. Built from https://develop.svn.wordpress.org/trunk@49225 git-svn-id: http://core.svn.wordpress.org/trunk@48987 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 13:29:08 +00:00
Helen Hou-Sandí	edb64a3d8e	Media: Indicate if item is or was used as a site option in the details modal. ... Props Mista-Flo, melchoyce. Fixes #42063. Built from https://develop.svn.wordpress.org/trunk@49223 git-svn-id: http://core.svn.wordpress.org/trunk@48985 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 03:14:06 +00:00
desrosj	d2fb6101c4	Bundled Themes: Make Twenty Twenty-One the default theme. ... After being imported in [49216], Twenty Twenty-One can now be set as the default theme in WordPress. See #48110. Built from https://develop.svn.wordpress.org/trunk@49220 git-svn-id: http://core.svn.wordpress.org/trunk@48982 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 02:04:07 +00:00
Sergey Biryukov	9c82dfada2	Help/About: Serve the image on the Freedoms page locally. ... Serving the files locally is beneficial for reasons of privacy and speed. Props garrett-eclipse, pputzer, hellofromTonya. Fixes #46363. Built from https://develop.svn.wordpress.org/trunk@49219 git-svn-id: http://core.svn.wordpress.org/trunk@48981 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 02:02:06 +00:00
Sergey Biryukov	5cbad34501	Help/About: Update Privacy page to include illustration. ... This brings some consistency with the Freedoms page. Follow-up to [43938]. Props melchoyce, garrett-eclipse, hareesh-pillai, ryelle. Fixes #45395. Built from https://develop.svn.wordpress.org/trunk@49218 git-svn-id: http://core.svn.wordpress.org/trunk@48980 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-20 01:47:06 +00:00
Sergey Biryukov	651f426b3a	General: Remove noreferrer from wp_targeted_link_rel() and other uses. ... When `noopener noreferrer` was originally added in #37941 and related tickets, the `noreferrer` bit was specifically included due to Firefox not supporting `noopener` at the time. Since `noopener` has been supported by all major browsers for a while, it should now be safe to remove the `noreferrer` attribute from core. Props Mista-Flo, audrasjb, joostdevalk, jonoaldersonwp, peterwilsoncc, elgameel. Fixes #49558. Built from https://develop.svn.wordpress.org/trunk@49215 git-svn-id: http://core.svn.wordpress.org/trunk@48977 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-19 23:39:04 +00:00
Sergey Biryukov	80be8c138d	Administration: Remove obsolete .ac_results class references. ... Core does not use the jQuery.suggest plugin since [38797]. Props afercia, hareesh-pillai, garrett-eclipse. Fixes #40260. Built from https://develop.svn.wordpress.org/trunk@49213 git-svn-id: http://core.svn.wordpress.org/trunk@48975 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-19 22:33:08 +00:00
Helen Hou-Sandí	bdfd1a954f	Multisite: More specific caching for get_dirsize. ... Instead of one cache entry for all upload folders for a site on multisite, this now caches for each folder and invalidates that cache based on context. In multisite, this should speed up `get_dirsize` calls since older directories that are much less likely to change will no longer have the size recalculated. Props janthiel, A5hleyRich, batmoo. Fixes #19879. Built from https://develop.svn.wordpress.org/trunk@49212 git-svn-id: http://core.svn.wordpress.org/trunk@48974 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-19 21:51:06 +00:00
Sergey Biryukov	e209e00734	Coding Standards: Fix WPCS issues in [49207]. ... See #46866. Built from https://develop.svn.wordpress.org/trunk@49209 git-svn-id: http://core.svn.wordpress.org/trunk@48971 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-19 20:45:06 +00:00
antpb	9556c08b35	Media: Add 'Uploaded to' for individual media items in the media editor. ... Adds a link in the media editor showing which post a media item was uploaded to. Props karmatosed, garrett-eclipse, Mista-Flo, SergeyBiryukov, joemcgill, hellofromTonya. Fixes #46866. Built from https://develop.svn.wordpress.org/trunk@49207 git-svn-id: http://core.svn.wordpress.org/trunk@48969 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-19 20:29:05 +00:00
antpb	9d13ae60e4	Media: Indicate if media is header video in media library. ... This introduces a label to indicate if a piece of media is being used as a video header in the media library. Props desrosj, Mista-Flo, mikeschroder. Fixes #42929. Built from https://develop.svn.wordpress.org/trunk@49205 git-svn-id: http://core.svn.wordpress.org/trunk@48967 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-19 18:32:07 +00:00
Sergey Biryukov	13b1b4bed3	Docs: Add a @deprecated note to WP_Community_Events::format_event_data_time(). ... Follow-up to [49146]. See #51130. Built from https://develop.svn.wordpress.org/trunk@49201 git-svn-id: http://core.svn.wordpress.org/trunk@48963 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-19 13:22:07 +00:00
Sergey Biryukov	2716cc8048	Networks and Sites: Introduce network_site_info_form action. ... The action fires at the end of the site info form in network admin, and complements the existing `network_site_new_form` action. Props virgodesign. Fixes #50704. Built from https://develop.svn.wordpress.org/trunk@49199 git-svn-id: http://core.svn.wordpress.org/trunk@48961 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 21:17:05 +00:00
John Blackbourn	1bcda42567	Media: Add an image_sideload_extensions filter to the list of allowed file extensions when sideloading an image from a URL. ... Props paulschreiber, hellofromTonya Fixes #50695 Built from https://develop.svn.wordpress.org/trunk@49198 git-svn-id: http://core.svn.wordpress.org/trunk@48960 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 21:06:05 +00:00
John Blackbourn	727922c8eb	Docs: Further corrections and promotions for docblocks relating to object types. ... See #50768 Built from https://develop.svn.wordpress.org/trunk@49197 git-svn-id: http://core.svn.wordpress.org/trunk@48959 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 20:53:08 +00:00
John Blackbourn	b2515abd45	Docs: Improve the docs for the globals that are used in the actions and filters API. ... See #50531, #50768 Built from https://develop.svn.wordpress.org/trunk@49196 git-svn-id: http://core.svn.wordpress.org/trunk@48958 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 19:19:06 +00:00
Sergey Biryukov	1faa241fb6	Code Modernization: Use instanceof instead of a comparison with get_class(). ... Includes adjusting external libraries which are no longer maintained externally. Props jrf. See #50767. Built from https://develop.svn.wordpress.org/trunk@49194 git-svn-id: http://core.svn.wordpress.org/trunk@48956 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 17:33:07 +00:00
Sergey Biryukov	0e3147c40e	Coding Standards: Replace alias PHP functions with the canonical names. ... Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning. This replaces all uses of the following: * `join()` with `implode()` * `sizeof()` with `count()` * `is_writeable()` with `is_writable()` * `doubleval()` with a `(float)` cast In part, this is a follow-up to #47746. Props jrf. See #50767. Built from https://develop.svn.wordpress.org/trunk@49193 git-svn-id: http://core.svn.wordpress.org/trunk@48955 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 17:27:06 +00:00
Sergey Biryukov	b6f0882ddd	Coding Standards: Use self when appropriate. ... * `WP_List_Table::get_default_primary_column_name()` is a protected method, so calling it statically with the class name is bad practice. * Similarly, this applies when calling a private constructor in `WP_Screen::get()`. Props jrf. See #50767. Built from https://develop.svn.wordpress.org/trunk@49192 git-svn-id: http://core.svn.wordpress.org/trunk@48954 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 17:18:07 +00:00
John Blackbourn	a01f94cad8	Administration: Allow WP_List_Table::get_bulk_items() to receive a nested array in order to output optgroups. ... The allowed format for bulk actions is now an associative array where each element represents either a top level option value and label, or an array representing an optgroup and its options. For a standard option, the array element key is the field value and the array element value is the field label. For an optgroup, the array element key is the label and the array element value is an associative array of options as above. Props goldenapples, mattkeys, valentinbora, davidbaumwald Fixes #19278 Built from https://develop.svn.wordpress.org/trunk@49190 git-svn-id: http://core.svn.wordpress.org/trunk@48952 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-18 16:22:10 +00:00
John Blackbourn	c16ae60deb	Docs: Fix and upgrade various object docblock notations. ... See #50768 Built from https://develop.svn.wordpress.org/trunk@49183 git-svn-id: http://core.svn.wordpress.org/trunk@48945 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-17 16:05:09 +00:00
John Blackbourn	5a573f28f2	Docs: Miscellaneous docblock fixes. ... See #50768 Built from https://develop.svn.wordpress.org/trunk@49181 git-svn-id: http://core.svn.wordpress.org/trunk@48943 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-17 14:54:05 +00:00
John Blackbourn	ee96f93558	Administration: Fix a coding standards issue after [49179]. ... See #50699 Built from https://develop.svn.wordpress.org/trunk@49180 git-svn-id: http://core.svn.wordpress.org/trunk@48942 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-17 12:34:08 +00:00
Andrew Ozz	59c45c41e4	Fix and improve arranging of postboxes/metaboxes: ... - Enable arranging only when the Screen Options tab is open. - Prevent accidental/unintended dragging. Seen it happen mostly on laptops when using the mousepad/trackpad. - Improve discoverability and usefulness by always showing the "drop zones" outline when postboxes are draggable/arrangeable. - Add some (brief) explanation to the Screen Options tab helping the user understand what options are available and how to change them. This is especially helpful for screen reader users to give an idea how to use the screen options and what to expect. - Fix/enhance some of the code in `postbox.js` and make it coding standards compliant. See #50699. Built from https://develop.svn.wordpress.org/trunk@49179 git-svn-id: http://core.svn.wordpress.org/trunk@48941 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-17 10:00:06 +00:00
Sergey Biryukov	c5f1d21020	Administration: Wrap the list table items count to a new line on small screens. ... This avoids overlapping with action buttons and brings some consistency to bottom paddings across various screens. Props passoniate, afercia, anuj2, rolfsiebers, uxkai, ireneyoast, thijsvanloef, hellofromTonya, audrasjb, helen, SergeyBiryukov. Fixes #49246. Built from https://develop.svn.wordpress.org/trunk@49178 git-svn-id: http://core.svn.wordpress.org/trunk@48940 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-17 01:13:06 +00:00
Peter Wilson	32d193f96f	REST API, Posts: Add a hook to fire once a post, its terms and meta update. ... Introduces the action `wp_after_insert_post` inside a wrapper function of the same name. This hook allows plugin developers to access a posts full data (including its terms and meta data) regardless of the workflow used to save it. A new parameter is introduced to `wp_insert_post()` to indicate whether the hook should be fired within the function call or will be fired afterward. Props aristath, Collizo4sky, danielbachhuber, joyously, kadamwhite, kraftbj, markparnell, mikeschroder, noisysocks, peterwilsoncc, SergeyBiryukov, talldanwp, thewebprincess, TimothyBlynJacobs. Fixes #45114. Built from https://develop.svn.wordpress.org/trunk@49172 git-svn-id: http://core.svn.wordpress.org/trunk@48934 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-16 03:34:08 +00:00
Sergey Biryukov	81ce3c1335	Privacy: Denote removed suggested privacy policy text in a more noticeable way. ... Props garrett-eclipse, sabernhardt, audrasjb. Fixes #51435. Built from https://develop.svn.wordpress.org/trunk@49170 git-svn-id: http://core.svn.wordpress.org/trunk@48932 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-16 01:29:09 +00:00
Sergey Biryukov	df51aa9b6f	Upgrade/Install: Check if plugin or theme update results are available before applying the notification filters. ... This avoids a PHP notice for an undefined index of either `plugin` or `theme` in the `auto_{plugin|theme}_update_send_email` filter hook. Props afragen, audrasjb. Fixes #51400. Built from https://develop.svn.wordpress.org/trunk@49166 git-svn-id: http://core.svn.wordpress.org/trunk@48928 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-15 23:27:03 +00:00
TimothyBlynJacobs	039ce3f16f	Site Health, REST API: Move async tests to REST API endpoints. ... This provides more flexibility when writing tests and benefits from running in a front-end context which is necessary for some tests like checking that updates are supported. Additionally, this provides a more robust interface for developers who want to integrate with Site Health tests. Because the `wp/v2` endpoint is reserved for modeling core entities, site health is registered in its own `wp-site-health/v1` namespace. The existing ajax actions have been maintained for backward compatibility. Props Clorith, chrisvanpatten, afragen, pokhriyal, TimothyBlynJacobs. Fixes #48105. Built from https://develop.svn.wordpress.org/trunk@49154 git-svn-id: http://core.svn.wordpress.org/trunk@48916 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-15 02:00:08 +00:00
iandunn	8d2beacd45	Community Events: Update timezone-related @since tags to 5.5.2. ... r49145 and r49146 were originally planned for 5.6 when they were committed, but are now planned for 5.5.2. See #51130. Built from https://develop.svn.wordpress.org/trunk@49152 git-svn-id: http://core.svn.wordpress.org/trunk@48914 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-14 21:35:05 +00:00
Dominik Schilling	c6f7e0f155	I18N: Use wp.i18n for translatable strings in wp-admin/js/dashboard.js. ... * Deprecate the `l10n` property on `communityEventsData`. * Introduce `version` parameter for `deprecateL10nObject` and backfill the version for deprecated objects in 5.5.0. * Add a noop version of `deprecateL10nObject` for QUnit testing. Fixes #51498. Built from https://develop.svn.wordpress.org/trunk@49151 git-svn-id: http://core.svn.wordpress.org/trunk@48913 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-14 21:13:08 +00:00
Helen Hou-Sandí	8ce5e19a65	Updates: Reduce secondary buttons for less visual complexity. ... Props audrasjb, karmatosed. Fixes #51523. Built from https://develop.svn.wordpress.org/trunk@49150 git-svn-id: http://core.svn.wordpress.org/trunk@48912 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-14 20:27:09 +00:00
Helen Hou-Sandí	0e4d84b105	Admin Menu: Better wrapping for long menu item names. ... Props munyagu, jagirbaheshwp, harshbarach, pratikkry, hareesh-pillai, naveenkharwar, mukesh27, chetan200891, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald, sabernhardt, johnjamesjacoby, garrett-eclipse, garrett-eclipse. Fixes #42201. Built from https://develop.svn.wordpress.org/trunk@49149 git-svn-id: http://core.svn.wordpress.org/trunk@48911 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-14 19:53:08 +00:00
iandunn	5bf0005827	Community Events: Display dates and times in the user's time zone. ... Fixes #51130 Props sippis, hlashbrooke, audrasjb, Rarst, iandunn Built from https://develop.svn.wordpress.org/trunk@49146 git-svn-id: http://core.svn.wordpress.org/trunk@48908 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-14 18:21:06 +00:00
iandunn	5d42748c18	Community Events: Trim events by Unix timestamp for accuracy. ... The `date` and `end_date` fields are ''WP'' timestamps representing the venue's local time. As of meta:changeset:10270 (#meta4480), new `start_unix_timestamp` and `end_unix_timestamp` values are available, providing a proper ''Unix'' timestamp in the UTC timezone. Using those is more precise, and removes the time window where the event has expired but still appears in the Events Widget. To simplify the function, it now only accepts and returns the events themselves, rather than the entire response body. See #51130 See #meta4480 Related: https://make.wordpress.org/core/2019/09/23/date-time-improvements-wp-5-3/ Built from https://develop.svn.wordpress.org/trunk@49145 git-svn-id: http://core.svn.wordpress.org/trunk@48907 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-14 18:19:10 +00:00
Sergey Biryukov	a706c4505e	Administration: Make sure list table row actions in Extended view stay visible when a single row gets focus. ... Follow-up to [48398], [48423], [48424], [48450], [48670]. Props ryelle. Fixes #51516. See #49715. Built from https://develop.svn.wordpress.org/trunk@49142 git-svn-id: http://core.svn.wordpress.org/trunk@48904 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-14 02:02:06 +00:00
Dominik Schilling	7137daec42	Administration: Restore alternative admin menu position for menu items with the same position value as an existing menu item. ... Reverts parts of [49108]. Props johnjamesjacoby. Fixes #42918. Built from https://develop.svn.wordpress.org/trunk@49138 git-svn-id: http://core.svn.wordpress.org/trunk@48900 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-13 19:59:08 +00:00
John Blackbourn	e11accb411	Networks and Sites: Extract into a new function the email that gets sent to the network administrator when a new site is created, and introduce filters to disable and modify its ... contents. * The `send_new_site_email` filter can be used to disable this email. * The `new_site_email` filter can be used to modify its contents. Props Dhruvin, Dharm1025, dharmin16, jipmoors Fixes #42134 Built from https://develop.svn.wordpress.org/trunk@49127 git-svn-id: http://core.svn.wordpress.org/trunk@48889 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-11 19:29:08 +00:00
John Blackbourn	bd1fa2d998	Posts, Post Types: Switch to restoring posts to draft status by default when they are untrashed. ... This allows for edits to be made to a restored post before it goes live again. This also prevents scheduled posts being published unexpectedly if they are untrashed after their originally scheduled date. The old behaviour of restoring untrashed posts to their original status can be reinstated using the `wp_untrash_post_set_previous_status()` helper function. Also fixes an issue where the incorrect post ID gets passed to hooks if no post ID is passed to the function. Props harrym, bananastalktome, jaredcobb, chriscct7, melchoyce, johnbillion, pankajmohale Fixes #23022 Built from https://develop.svn.wordpress.org/trunk@49125 git-svn-id: http://core.svn.wordpress.org/trunk@48887 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-11 13:39:07 +00:00
John Blackbourn	da04189357	Administration: Allow context and priority to be specified when adding dashboard widgets. ... Props davidjlaietta, soulseekah, johnbillion Fixes #42791 Built from https://develop.svn.wordpress.org/trunk@49123 git-svn-id: http://core.svn.wordpress.org/trunk@48885 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-10 20:40:05 +00:00
John Blackbourn	cdd8b2cbfa	Site Health: Remove an unused function that was erroneously added when the site health feature was introduced. ... This function was and is never used as the `is_in_debug_mode` check is a direct one. Fixes #50282 Built from https://develop.svn.wordpress.org/trunk@49122 git-svn-id: http://core.svn.wordpress.org/trunk@48884 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-10 20:24:03 +00:00
John Blackbourn	905460bd5e	Docs: Standardise the type name for booleans and integers. ... This brings these docs inline with the documentation standards. Props ravipatel, justinahinon Fixes #51426 Built from https://develop.svn.wordpress.org/trunk@49120 git-svn-id: http://core.svn.wordpress.org/trunk@48882 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-10 20:02:05 +00:00
John Blackbourn	6b7ba33d68	Docs: Fix the types for some properties and parameters that use the generic object type. ... See #50768 Built from https://develop.svn.wordpress.org/trunk@49119 git-svn-id: http://core.svn.wordpress.org/trunk@48881 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-10 19:14:04 +00:00
Adam Silverstein	e3d280ffd8	Users: prevent saving empty passwords, trim space from password ends on save. ... Fix an issue where users could save a password with only spaces, or spaces at the beginning or end of their password, preventing them from logging in. Props ronakganatra, 1naveengiri, ajensen, oolleegg55, bookdude13, nrqsnchz, aristath. Fixes #42766. Built from https://develop.svn.wordpress.org/trunk@49118 git-svn-id: http://core.svn.wordpress.org/trunk@48880 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-10 16:51:07 +00:00
iandunn	92dacfafaf	Dashboard: Show 2 w.org news items to preserve clustered posts. ... These days there are often 2 posts published close to each other, like a release announcement and a Month In WordPress post. When that happens, the earlier post is often pushed out of the widget before many people have had a chance to see it. Ideally, the number of total items would remain at `4`, to reduce visual clutter. Implementing a conditional item would require a significant refactor, though. Increasing the total number of items to `5` is a practical compromise. Props hlashbrooke, tellyworth. Fixes #43441. Built from https://develop.svn.wordpress.org/trunk@49114 git-svn-id: http://core.svn.wordpress.org/trunk@48876 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-09 16:07:07 +00:00
Sergey Biryukov	c628344422	Accessibility: Widgets: Add a "Cancel" link when editing a widget in accessibility mode. ... This allows the user to go back without saving any changes to the widget. Props garrett-eclipse, audrasjb, afercia. Fixes #49354. Built from https://develop.svn.wordpress.org/trunk@49113 git-svn-id: http://core.svn.wordpress.org/trunk@48875 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-09 15:53:08 +00:00
Sergey Biryukov	5affd982a0	I18N: Add missing placeholders in some translator comments. ... Follow-up to [49109]. See #42790. Built from https://develop.svn.wordpress.org/trunk@49110 git-svn-id: http://core.svn.wordpress.org/trunk@48872 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-09 01:06:03 +00:00
TimothyBlynJacobs	d5ebe12f11	REST API: Introduce Application Passwords for API authentication. ... In WordPress 4.4 the REST API was first introduced. A few releases later in WordPress 4.7, the Content API endpoints were added, paving the way for Gutenberg and countless in-site experiences. In the intervening years, numerous plugins have built on top of the REST API. Many developers shared a common frustration, the lack of external authentication to the REST API. This commit introduces Application Passwords to allow users to connect to external applications to their WordPress website. Users can generate individual passwords for each application, allowing for easy revocation and activity monitoring. An authorization flow is introduced to make the connection flow simple for users and application developers. Application Passwords uses Basic Authentication, and by default is only available over an SSL connection. Props georgestephanis, kasparsd, timothyblynjacobs, afercia, akkspro, andraganescu, arippberger, aristath, austyfrosty, ayesh, batmoo, bradyvercher, brianhenryie, helen, ipstenu, jeffmatson, jeffpaul, joostdevalk, joshlevinson, kadamwhite, kjbenk, koke, michael-arestad, Otto42, pekz0r, salzano, spacedmonkey, valendesigns. Fixes #42790. Built from https://develop.svn.wordpress.org/trunk@49109 git-svn-id: http://core.svn.wordpress.org/trunk@48871 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-08 22:14:06 +00:00
Sergey Biryukov	897f004a9c	General: Replace older-style PHP type conversion functions with type casts. ... This improves performance, readability, and consistency throughout core. * `intval()` → `(int)` * `strval()` → `(string)` * `floatval()` → `(float)` Props ayeshrajans. Fixes #42918. Built from https://develop.svn.wordpress.org/trunk@49108 git-svn-id: http://core.svn.wordpress.org/trunk@48870 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-08 21:15:13 +00:00
Sergey Biryukov	aef2b539cd	Docs: Correct @since version for add_allowed_options(). ... Follow-up to [48121]. Props coffee2code. Fixes #51450. Built from https://develop.svn.wordpress.org/trunk@49096 git-svn-id: http://core.svn.wordpress.org/trunk@48858 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-06 15:55:05 +00:00
Sergey Biryukov	bea55db921	Docs: Add missing @return tag to Language_Pack_Upgrader::check_package(). ... Synchronize documentation of the `::check_package()` method between `Plugin_Upgrader`, `Theme_Upgrader`, and `Language_Pack_Upgrader`. Props ankitmaru, mukesh27, desrosj. Fixes #51448. Built from https://develop.svn.wordpress.org/trunk@49091 git-svn-id: http://core.svn.wordpress.org/trunk@48853 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-05 13:44:11 +00:00
Sergey Biryukov	1651342d2b	Privacy: Improve clarity of privacy error strings. ... Primarily this adds "user privacy" to the strings for privacy requests, so they are more easily distinguished from other system actions within logs. Props garrett-eclipse, carike, birgire. Fixes #51351. Built from https://develop.svn.wordpress.org/trunk@49090 git-svn-id: http://core.svn.wordpress.org/trunk@48852 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-04 03:23:09 +00:00
Adam Silverstein	f426a1fa04	Media: clear inputs after cropping on attachment details screen. ... Clear the crop selection input fields after the crop action is complete. Fixes unexpected re-cropping behavior if the crop button was clicked more than once. Props davidbinda. Fixes #30155. Built from https://develop.svn.wordpress.org/trunk@49087 git-svn-id: http://core.svn.wordpress.org/trunk@48849 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-10-02 15:11:06 +00:00
John Blackbourn	1079647d30	Docs: Various docblock improvements related to user and site signup functionality. ... See #50768 Built from https://develop.svn.wordpress.org/trunk@49078 git-svn-id: http://core.svn.wordpress.org/trunk@48840 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-30 21:54:07 +00:00
Sergey Biryukov	b3b8942dfc	Docs: Correct description for wp_ajax_update_widget(). ... Follow-up to [28355]. Props burhandodhy, sabernhardt. Fixes #44583. Built from https://develop.svn.wordpress.org/trunk@49071 git-svn-id: http://core.svn.wordpress.org/trunk@48833 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-30 09:44:09 +00:00
Sergey Biryukov	2cbcc5d548	Media: Make the "Copy URL" button implementation more consistent with other instances in core: ... * Make the "Copied!" text green. * Make the button verbiage clear that it's copied "to clipboard". Props garrett-eclipse, mukesh27. Fixes #51355. Built from https://develop.svn.wordpress.org/trunk@49064 git-svn-id: http://core.svn.wordpress.org/trunk@48826 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-27 20:48:05 +00:00
Sergey Biryukov	c298458751	Docs: Add missing @return tags for some WP_Automatic_Updater methods: ... * `::is_vcs_checkout()` * `::should_update()` * `::send_core_update_notification_email()` Props ankitmaru, mukesh27. Fixes #51385. Built from https://develop.svn.wordpress.org/trunk@49061 git-svn-id: http://core.svn.wordpress.org/trunk@48823 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-27 08:36:06 +00:00
John Blackbourn	eaf325e386	Upgrade/Install: Introduce the wp_installed_email filter for filtering the contents of the email sent when WordPress is installed, without needing to override the wp_new_blog_notification() pluggable function. ... Props Dharm1025, nikolam, johnbillion Fixes #42133 Built from https://develop.svn.wordpress.org/trunk@49048 git-svn-id: http://core.svn.wordpress.org/trunk@48810 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-25 22:33:08 +00:00
noisysocks	41b456eca9	Editor: Hide Screen Options tab from block editor ... The block editor provides its own interface for managing screen options, so we can safely hide Screen Options tab found in the top right of the page. Props aduth. See #46157. Built from https://develop.svn.wordpress.org/trunk@49040 git-svn-id: http://core.svn.wordpress.org/trunk@48802 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-24 03:00:08 +00:00
desrosj	a16faa6989	Privacy: Ensure bulk action related strings end with periods. ... Props garrett-eclipse, mukesh27. Fixes #51371. Built from https://develop.svn.wordpress.org/trunk@49035 git-svn-id: http://core.svn.wordpress.org/trunk@48797 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-22 18:40:04 +00:00
John Blackbourn	175c2c5b7c	Users: Introduce the invited_user_email filter for filtering the contents of the email sent when an existing user is invited to a site on Multisite. ... Props contact-banker, anand.au14, nikolam, johnbillion Fixes #42132 Built from https://develop.svn.wordpress.org/trunk@49029 git-svn-id: http://core.svn.wordpress.org/trunk@48791 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-21 17:16:07 +00:00
John Blackbourn	aef504acfd	Docs: Correct the indentation for some array type docs. ... See #50768 Built from https://develop.svn.wordpress.org/trunk@49028 git-svn-id: http://core.svn.wordpress.org/trunk@48790 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-21 16:46:06 +00:00
Sergey Biryukov	29c0edfbba	Privacy: Check if the accumulated data in wp_privacy_process_personal_data_export_page() is not empty. ... This avoids an error on PHP 8 caused by passing an empty string to `array_merge()`, instead of an array. See #50913. Built from https://develop.svn.wordpress.org/trunk@49026 git-svn-id: http://core.svn.wordpress.org/trunk@48788 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-21 13:51:03 +00:00
John Blackbourn	aba2165aae	Media: Standardise the description for image size parameters. ... This brings continuity to all the image related functions and filters which accept or pass a size parameter. Props dilipbheda, johnbillion Fixes #47364 Built from https://develop.svn.wordpress.org/trunk@49021 git-svn-id: http://core.svn.wordpress.org/trunk@48783 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 16:23:07 +00:00
John Blackbourn	0b2e31a7f8	Docs: Inline documentation improvements for media related functions and hooks. ... See #47364, #50768 Built from https://develop.svn.wordpress.org/trunk@49020 git-svn-id: http://core.svn.wordpress.org/trunk@48782 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 15:55:10 +00:00
John Blackbourn	43b11121de	Media: Correct some types for attachment ID parameters passed to functions and filters. ... See #47364, #50768 Built from https://develop.svn.wordpress.org/trunk@49017 git-svn-id: http://core.svn.wordpress.org/trunk@48779 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 14:05:05 +00:00
John Blackbourn	7d61c45afc	I18N: Add a language icon next to the Default Language network option. ... Fixes #51359 Built from https://develop.svn.wordpress.org/trunk@49013 git-svn-id: http://core.svn.wordpress.org/trunk@48775 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 13:18:05 +00:00
John Blackbourn	123806ff28	Themes: Remove the ability to delete themes from the single site Appearance screen on Multisite installations. ... This brings theme deletion inline with plugin deletion and theme and plugin editing, which can only be performed from within Network Admin. Props Mista-Flo, williampatton, johnbillion Fixes #41441 Built from https://develop.svn.wordpress.org/trunk@49011 git-svn-id: http://core.svn.wordpress.org/trunk@48773 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-20 12:03:05 +00:00
Sergey Biryukov	d5b8d282e8	Docs: Update the URL for PHP date formats table in translator comments. ... Props hareesh-pillai, iandunn. Fixes #51332. Built from https://develop.svn.wordpress.org/trunk@48991 git-svn-id: http://core.svn.wordpress.org/trunk@48753 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-18 10:37:08 +00:00
Sergey Biryukov	282c813259	Coding Standards: Explicitly declare the $wp_version global used in some core files. ... Props jaydeep-rami, sabernhardt. Fixes #44932. Built from https://develop.svn.wordpress.org/trunk@48971 git-svn-id: http://core.svn.wordpress.org/trunk@48733 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-12 00:12:08 +00:00
Sergey Biryukov	f29d62012d	Coding Standards: Use strict comparison in wp-admin/includes/class-wp-plugin-install-list-table.php. ... See #50767. Built from https://develop.svn.wordpress.org/trunk@48970 git-svn-id: http://core.svn.wordpress.org/trunk@48732 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-11 01:05:08 +00:00
Sergey Biryukov	e36c7f0ba0	Coding Standards: Use strict comparison in wp-admin/includes/class-wp-plugins-list-table.php. ... See #50767. Built from https://develop.svn.wordpress.org/trunk@48968 git-svn-id: http://core.svn.wordpress.org/trunk@48730 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-10 14:23:08 +00:00
Sergey Biryukov	7dada5df2f	Coding Standards: Use strict comparison in wp-admin/includes/class-wp-ms-themes-list-table.php. ... See #50767. Built from https://develop.svn.wordpress.org/trunk@48967 git-svn-id: http://core.svn.wordpress.org/trunk@48729 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-10 14:21:09 +00:00
Helen Hou-Sandí	447b526379	Privacy: Remove extraneous colon from settings screen. ... Props vinita29, garrett-eclipse. Fixes #50414. Built from https://develop.svn.wordpress.org/trunk@48965 git-svn-id: http://core.svn.wordpress.org/trunk@48727 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-09 19:43:08 +00:00
desrosj	04c8217724	Administration: Add the aria-hidden attribute to admin menu icons. ... The admin menu icons are included as a visual element to support the text links. Without the `aria-hidden=“true”` attribute, they are also exposed to assistive technologies (which can process icon fonts in unpredictable ways). This change improves the experience for multiple types of assistive technologies, including screen reading and voice control software. With `aria-hidden=“true”` added, the icons will not be read, and a user can now trigger a click of a top level admin menu item with commands such as “click posts”, or “click plugins”. Props joedolson, afercia, audrasjb, adriantirusli. Fixes #51012. Built from https://develop.svn.wordpress.org/trunk@48963 git-svn-id: http://core.svn.wordpress.org/trunk@48725 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-09 16:15:06 +00:00
Sergey Biryukov	17a4c20d55	Comments: Check if a valid comment ID was passed when editing a comment. ... This avoids a PHP notice after submitting the Edit Comment form. Props regan.khadgi. Fixes #51263. Built from https://develop.svn.wordpress.org/trunk@48958 git-svn-id: http://core.svn.wordpress.org/trunk@48720 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-08 13:41:08 +00:00
Sergey Biryukov	93b8183327	Media: In wp_ajax_image_editor(), check if the error property exists before accessing it. ... This avoids a PHP notice when editing an image. Follow-up to [48375]. Props Mista-Flo. Fixes #51251. Built from https://develop.svn.wordpress.org/trunk@48946 git-svn-id: http://core.svn.wordpress.org/trunk@48708 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-05 18:12:08 +00:00
Sergey Biryukov	e05edbcd53	Comments: Rename WP_Comments_List_Table::comment_status_dropdown() to ::comment_type_dropdown(). ... This better reflects the purpose of the method, which doesn't have anything to do with a comment status. Follow-up to [48521]. Props davidbaumwald, johnbillion, SergeyBiryukov. Fixes #51248. Built from https://develop.svn.wordpress.org/trunk@48943 git-svn-id: http://core.svn.wordpress.org/trunk@48705 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-05 00:33:05 +00:00
Sergey Biryukov	dd03a5a156	Docs: Further correct placement for wp_editor_expand filter DocBlock. ... This ensures that the filter is only applied if the conditions before it are evaluated to true. Follow-up to [48714]. Props johnbillion. See #50768. Built from https://develop.svn.wordpress.org/trunk@48942 git-svn-id: http://core.svn.wordpress.org/trunk@48704 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-04 21:48:07 +00:00
John Blackbourn	d0a32c5111	Docs: Various docblock corrections and improvements. ... See #50768 Built from https://develop.svn.wordpress.org/trunk@48941 git-svn-id: http://core.svn.wordpress.org/trunk@48703 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-04 20:41:07 +00:00
Sergey Biryukov	6d0491119e	Administration: Give the $error variable in wp-admin/admin-header.php a more descriptive name. ... This avoids a conflict with the same global variable used elsewhere, e.g. in Theme Editor. Follow-up to [48850]. Props vinayak.anivase. Fixes #51219. Built from https://develop.svn.wordpress.org/trunk@48938 git-svn-id: http://core.svn.wordpress.org/trunk@48700 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-09-03 01:43:07 +00:00
Sergey Biryukov	68dfbf51d9	Script Loader: Add backward compatibility for JavaScript i18n globals and properties deprecated in WordPress 5.5. ... The recommended approach for any plugins using these globals or properties is to switch to the newer `wp.i18n` functions. In the meantime, this ensures that accessing any of these globals does not break the rest of the code on the page, and an appropriate warning message is logged to the JavaScript console. Follow-up to: https://core.trac.wordpress.org/query?summary=~wp.i18n&milestone=5.5 Props omarreiss, peterwilsoncc, kbjohnson90, johnbillion, TimothyBlynJacobs, joostdevalk, ocean90, desrosj, SergeyBiryukov. Fixes #51123. Built from https://develop.svn.wordpress.org/trunk@48923 git-svn-id: http://core.svn.wordpress.org/trunk@48685 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-31 20:30:03 +00:00
Sergey Biryukov	d4d3e23ad0	Themes: Normalize the installed theme path in Theme_Installer_Skin::do_overwrite() before comparing with the uploaded theme. ... This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows. Follow-up to [48390]. Props bobbingwide, wpamitkumar, mukesh27. Fixes #51182. Built from https://develop.svn.wordpress.org/trunk@48913 git-svn-id: http://core.svn.wordpress.org/trunk@48675 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-31 17:11:04 +00:00
Sergey Biryukov	ee33a7b019	Docs: Add a @since note to the display_post_states filter to clarify that it is now also applied in the Customizer context. ... If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used. Follow-up to [47763], [48620]. Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov. Fixes #51081. Built from https://develop.svn.wordpress.org/trunk@48910 git-svn-id: http://core.svn.wordpress.org/trunk@48672 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-31 13:32:04 +00:00
Sergey Biryukov	94555079eb	Docs: Clarify the usage of null for auto_update_{$type} filter. ... The value is internally used to detect whether nothing has hooked into this filter. Props audrasjb, pbiron, johnbillion, SergeyBiryukov. Fixes #50848. Built from https://develop.svn.wordpress.org/trunk@48909 git-svn-id: http://core.svn.wordpress.org/trunk@48671 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-31 13:20:07 +00:00
Sergey Biryukov	be4ad8548c	Administration: Correct the padding for "Warning: these pages should not be the same" messages on Reading Settings screen. ... Replace the legacy `.error` class with a more appropriate `.notice-warning`. Props musicaljoeker, shital-patel, man4toman, garrett-eclipse, SergeyBiryukov. Fixes #50766. Built from https://develop.svn.wordpress.org/trunk@48906 git-svn-id: http://core.svn.wordpress.org/trunk@48668 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-29 00:42:05 +00:00
Sergey Biryukov	af523447f4	Media: Make the is_gd_image() function available on front end. ... This avoids a fatal error if a plugin calls image creation or editing functions like `wp_imagecreatetruecolor()` outside of the admin. Follow-up to [48798] Props BackuPs. Fixes #51174. See #50833. Built from https://develop.svn.wordpress.org/trunk@48905 git-svn-id: http://core.svn.wordpress.org/trunk@48667 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-28 16:45:06 +00:00
Sergey Biryukov	71ffaac835	Docs: Correct formatting of the auto_theme_update_send_email filter DocBlock. ... Synchronize description of the `$enabled` parameter with the `auto_plugin_update_send_email` filter. Follow-up to [48889]. See #50768, #50988. Built from https://develop.svn.wordpress.org/trunk@48903 git-svn-id: http://core.svn.wordpress.org/trunk@48665 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-28 02:38:05 +00:00
Sergey Biryukov	308f752596	Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature. ... Follow-up to [48669], [48688]. Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov. Fixes #51129. Built from https://develop.svn.wordpress.org/trunk@48899 git-svn-id: http://core.svn.wordpress.org/trunk@48661 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-27 22:24:07 +00:00
desrosj	2aba7550c4	Upgrade/Install: Pass details about the specific plugin and theme updates attempted to filters. ... This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner’s liking. Props audrasjb, Paddy Landau, desrosj. Fixes #50988. Built from https://develop.svn.wordpress.org/trunk@48888 git-svn-id: http://core.svn.wordpress.org/trunk@48650 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-27 19:27:03 +00:00
Sergey Biryukov	604b273c0f	Taxonomy: Make sure wp_terms_checklist() and Walker_Category_Checklist::start_el() properly handle an array of strings as selected_cats or popular_cats values. ... Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results. Add a unit test. Props brianhogg, TimothyBlynJacobs, SergeyBiryukov. Fixes #51137. Built from https://develop.svn.wordpress.org/trunk@48880 git-svn-id: http://core.svn.wordpress.org/trunk@48642 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-27 02:48:06 +00:00
Sergey Biryukov	aa803be1ec	Upgrade/Install: Make the check for empty home option in __get_option() more resilient. ... This addresses a regression in [47808], where the `home` check expected an empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns `null` if the option is empty. Props fjarrett. Fixes #51011. Built from https://develop.svn.wordpress.org/trunk@48868 git-svn-id: http://core.svn.wordpress.org/trunk@48630 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-26 16:57:16 +00:00
Sergey Biryukov	9700ca0f55	Quick/Bulk Edit: Revert [48134] to address the bottom "Bulk actions" dropdown not functioning properly on Posts and Users list tables. ... A better solution for the original issue will be explored in a future release. Props audrasjb, garrett-eclipse, webzunft, Krstarica, chunkysteveo, SergeyBiryukov. Fixes #50882, #50998. See #46872. Built from https://develop.svn.wordpress.org/trunk@48866 git-svn-id: http://core.svn.wordpress.org/trunk@48628 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-26 14:18:04 +00:00
Sergey Biryukov	8c2c812cf9	Administration: Remove non-color related styling from Modern color scheme. ... Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change. Follow-up to [48277], [48286], [48345]. Props Joen, johnbillion, afercia, johnjamesjacoby. Fixes #51127. See #50504. Built from https://develop.svn.wordpress.org/trunk@48862 git-svn-id: http://core.svn.wordpress.org/trunk@48624 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-26 13:19:08 +00:00
Sergey Biryukov	5ce95b7c88	Administration: Don't print the .php-error class in the admin header for PHP notices in wp-config.php. ... Any notices in that file happen before `WP_DEBUG` takes effect, and should not be displayed with the `error_reporting` level previously set in `wp-load.php`. Adding the class when there is no notice displayed results in extra padding under the admin bar, which should be avoided. Follow-up to [20102], [21025], [26620], [47745]. Props akissz, tw2113, laxman-prajapati, sabernhardt, johnbillion, SergeyBiryukov. Fixes #51073. Built from https://develop.svn.wordpress.org/trunk@48850 git-svn-id: http://core.svn.wordpress.org/trunk@48612 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-24 10:48:06 +00:00
Sergey Biryukov	23b4fd4a86	Editor: Use wp_add_inline_script() instead of wp_localize_script() to pass the _wpMetaBoxUrl value to the wp-editor script. ... This fixes a PHP 8 "Only the first byte will be assigned to the string offset" warning on Edit Post screen. The correct usage of `wp_localize_script()` is to pass an array of data, not a string. Fixes #51108. Built from https://develop.svn.wordpress.org/trunk@48841 git-svn-id: http://core.svn.wordpress.org/trunk@48603 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-22 00:04:06 +00:00
Felix Arntz	5918f7e11d	Taxonomy: Allow for wp_count_terms( $args ) signature, making passing a taxonomy optional. ... This brings `wp_count_terms()` in line with other taxonomy functions such as `get_terms()` which technically no longer require a taxonomy. Similar to the previously modified functions, no deprecation warning is triggered when using the legacy signature. Fixes #36399. Built from https://develop.svn.wordpress.org/trunk@48840 git-svn-id: http://core.svn.wordpress.org/trunk@48602 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-21 22:32:06 +00:00
Sergey Biryukov	0c0e39d8bf	Privacy: Avoid a PHP 7.4 notice in WP_Privacy_Policy_Content::text_change_check(). ... When iterating over the items stored in '_wp_suggested_privacy_policy_content` meta value for the Privacy Policy page, make sure the item is an array before accessing its properties. Props treibstoff. Fixes #51084. Built from https://develop.svn.wordpress.org/trunk@48836 git-svn-id: http://core.svn.wordpress.org/trunk@48598 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-21 01:13:05 +00:00
Sergey Biryukov	25b0783629	Docs: Correct references to WP_Filesystem_Base methods in various DocBlocks. ... Props pbiron. Fixes #51087. Built from https://develop.svn.wordpress.org/trunk@48835 git-svn-id: http://core.svn.wordpress.org/trunk@48597 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-21 00:43:05 +00:00
Sergey Biryukov	c66d70f2a5	Comments: Revert unintended changes from [48822]. ... See #51044. Built from https://develop.svn.wordpress.org/trunk@48823 git-svn-id: http://core.svn.wordpress.org/trunk@48585 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-19 01:59:04 +00:00
Sergey Biryukov	3e16f7510a	Comments: Make sure the comment data passed to the preprocess_comment filter includes the comment_agent and comment_author_IP values. ... Props zodiac1978, SergeyBiryukov. Fixes #51044. Built from https://develop.svn.wordpress.org/trunk@48822 git-svn-id: http://core.svn.wordpress.org/trunk@48584 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-19 01:57:08 +00:00
Sergey Biryukov	8b3a813e1a	Plugins: Avoid a PHP notice if the update-supported key in plugin data is not set. ... Props sanzeeb3. Fixes #51052. Built from https://develop.svn.wordpress.org/trunk@48820 git-svn-id: http://core.svn.wordpress.org/trunk@48582 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-18 20:38:09 +00:00
Sergey Biryukov	fdeba269ca	Help/About: Fix typo and remove trailing spaces from some strings. ... Props mukesh27, casiepa, davidbaumwald. Fixes #51028. Built from https://develop.svn.wordpress.org/trunk@48809 git-svn-id: http://core.svn.wordpress.org/trunk@48571 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-17 02:12:04 +00:00
Sergey Biryukov	e50ac120a3	Site Health: Ensure that the tests returned by WP_Site_Health::get_tests() always have the required array keys: direct and async. ... This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter. Props khag7, Ov3rfly, desrosj, Clorith. Fixes #50858. Built from https://develop.svn.wordpress.org/trunk@48808 git-svn-id: http://core.svn.wordpress.org/trunk@48570 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-17 02:03:04 +00:00
Sergey Biryukov	d9135ad9d0	Site Health: Add site environment type to the debug information. ... Follow-up to [47919], [48188], [48372]. Props joostdevalk, Clorith. Fixes #50887. Built from https://develop.svn.wordpress.org/trunk@48802 git-svn-id: http://core.svn.wordpress.org/trunk@48564 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 18:27:04 +00:00
Sergey Biryukov	7cb2ca73a2	Site Health: Rename the $upload_max_size variable to $upload_max_filesize, for consistency with the PHP setting name. ... Follow-up to [48535], [48538], [48539], [48544], [48800]. See #50945. Built from https://develop.svn.wordpress.org/trunk@48801 git-svn-id: http://core.svn.wordpress.org/trunk@48563 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 17:54:05 +00:00
Sergey Biryukov	88e668d8e6	Site Health: Only display the warning about the post_max_size PHP value when it's lower than upload_max_filesize. ... Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match. Props oakesjosh, jeroenrotty, desrosj, Clorith. Fixes #50945. Built from https://develop.svn.wordpress.org/trunk@48800 git-svn-id: http://core.svn.wordpress.org/trunk@48562 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 17:48:08 +00:00
Sergey Biryukov	54184bf872	Docs: Fix typo in the $image parameter description in is_gd_image(). ... Follow-up to [48798]. See #50833. Built from https://develop.svn.wordpress.org/trunk@48799 git-svn-id: http://core.svn.wordpress.org/trunk@48561 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 14:02:03 +00:00
Sergey Biryukov	12c8f0e678	Code Modernization: Introduce is_gd_image() to check for PHP 8 GdImage object instances. ... In PHP 8, the GD extension uses `GdImage` objects instead of resources for its underlying data structures. This updates the existing `is_resource()` calls for image resources in core to accomodate for `GdImage` instances as well. Props ayeshrajans, jrf. Fixes #50833. Built from https://develop.svn.wordpress.org/trunk@48798 git-svn-id: http://core.svn.wordpress.org/trunk@48560 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-16 13:33:09 +00:00
Sergey Biryukov	a5edb2a8a1	Filesystem API: Use correct variable when closing the file handle in WP_Filesystem_FTPext::get_contents(). ... Props gothick@gothick.org.uk. Fixes #51029. Built from https://develop.svn.wordpress.org/trunk@48797 git-svn-id: http://core.svn.wordpress.org/trunk@48559 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-15 20:56:02 +00:00
Sergey Biryukov	440eb31bb7	Site Health: Recognize define( 'WP_AUTO_UPDATE_CORE', 'minor' ) as an acceptable value. ... Previously, it was only incidentally recognized as valid due to a loose comparison with `true`. With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case. Follow-up to [47841]. Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov. Fixes #50912. Built from https://develop.svn.wordpress.org/trunk@48792 git-svn-id: http://core.svn.wordpress.org/trunk@48554 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-14 20:39:08 +00:00
desrosj	dc63fb7c85	Help/About: Final adjustments to the 5.5 About page. ... - Final CDN asset URLs. - Some minor color adjustments. Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman. Fixes #50416. Built from https://develop.svn.wordpress.org/trunk@48783 git-svn-id: http://core.svn.wordpress.org/trunk@48545 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-11 16:53:09 +00:00
Sergey Biryukov	1f85e7484f	Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards. ... See #50768. Built from https://develop.svn.wordpress.org/trunk@48782 git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-11 00:34:08 +00:00
Sergey Biryukov	9214595e90	I18N: Fix typo in a screen reader text string on the About page. ... Follow-up to [48729]. Props pedromendonca. Fixes #50884. Built from https://develop.svn.wordpress.org/trunk@48770 git-svn-id: http://core.svn.wordpress.org/trunk@48532 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-10 13:15:04 +00:00
Sergey Biryukov	5c0361aeb1	Coding Standards: Remove a few more extra brackets from some conditions in wp-admin/includes/plugin.php. ... Follow-up to [48764]. See #50767. Built from https://develop.svn.wordpress.org/trunk@48766 git-svn-id: http://core.svn.wordpress.org/trunk@48528 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-09 01:56:05 +00:00
Sergey Biryukov	004e3f897f	Coding Standards: Fix WPCS issues in wp-admin/includes/plugin.php. ... Includes minor code layout fixes for better readability. Props rnaby for initial patch. See #50767, #43848. Built from https://develop.svn.wordpress.org/trunk@48764 git-svn-id: http://core.svn.wordpress.org/trunk@48526 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-08 21:04:04 +00:00
Sergey Biryukov	f5a4ac614e	Coding Standards: Simplify some parts of user_can_access_admin_page() for better readability. ... Props rnaby, valentinbora, khag7. Fixes #43848. Built from https://develop.svn.wordpress.org/trunk@48762 git-svn-id: http://core.svn.wordpress.org/trunk@48524 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-08 20:24:05 +00:00
Sergey Biryukov	1e5b6101e7	Help/About: Update videos and their descriptions on the About page. ... Follow-up to [48675], [48686], [48721], [48729], [48730], [48736]. Props ryelle, marybaum, estelaris, desrosj, joen, afercia. See #50416. Built from https://develop.svn.wordpress.org/trunk@48761 git-svn-id: http://core.svn.wordpress.org/trunk@48523 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-08 14:16:02 +00:00
Sergey Biryukov	132942b9fa	Docs: Document the return value of get_settings_errors() using hash notation. ... Props stevenlinx, webdevmattcrom, atachibana. Fixes #42786. Built from https://develop.svn.wordpress.org/trunk@48760 git-svn-id: http://core.svn.wordpress.org/trunk@48522 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-08 12:39:06 +00:00
Sergey Biryukov	961f455a00	Comments: Update DB version number used to trigger the upgrade routine for changing the comment_type DB field value in comments table. ... Follow-up to [47597], [47626], [48225], [48227], [48748]. Props desrosj. See #49236. Built from https://develop.svn.wordpress.org/trunk@48751 git-svn-id: http://core.svn.wordpress.org/trunk@48513 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-07 16:32:03 +00:00
Sergey Biryukov	6b5e748dee	Docs: Correct usage of the dynamic auto_update_{$type} filter. ... This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct. Props johnbillion. Fixes #50868. Built from https://develop.svn.wordpress.org/trunk@48750 git-svn-id: http://core.svn.wordpress.org/trunk@48512 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-07 16:14:03 +00:00
Sergey Biryukov	5221a27593	Site Health: Consistently pass an object to the auto_update_{$type} filter in Site Health debug data. ... Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices. Props bpayton, pbiron. Fixes #50852. Built from https://develop.svn.wordpress.org/trunk@48745 git-svn-id: http://core.svn.wordpress.org/trunk@48507 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-07 13:28:05 +00:00
Sergey Biryukov	3a32284b26	Posts, Post Types: Use a consistent wording in messages about a locked post. ... Props ramiy. Fixes #50859. Built from https://develop.svn.wordpress.org/trunk@48743 git-svn-id: http://core.svn.wordpress.org/trunk@48505 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-06 13:14:08 +00:00
Sergey Biryukov	7e1e4f379a	Site Health: Check if session_status() exists before calling it. ... Props bgermann. Fixes #50862. Built from https://develop.svn.wordpress.org/trunk@48742 git-svn-id: http://core.svn.wordpress.org/trunk@48504 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-06 00:25:07 +00:00
Sergey Biryukov	ee213e333b	Comments: Remove a few more unnecessary instances of esc_html() in WP_Comments_List_Table::comment_status_dropdown(). ... Core translations are considered safe, and these labels are not escaped in any other instances. Follow-up to [48521], [48722], [48724]. See #40188, #50815. Built from https://develop.svn.wordpress.org/trunk@48741 git-svn-id: http://core.svn.wordpress.org/trunk@48503 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-05 13:53:06 +00:00
Sergey Biryukov	2f878f1e74	Help/About: Correct header spacing on shorter screens after removing the musician name. ... Remove some unnecessary CSS. Follow-up to [48730]. Props ryelle. See #50416. Built from https://develop.svn.wordpress.org/trunk@48736 git-svn-id: http://core.svn.wordpress.org/trunk@48498 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 18:11:09 +00:00
Sergey Biryukov	aaf49752b2	Plugins: Move the "Successfully installed the plugin" string to the correct Plugin_Upgrader method. ... The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`. Props sswebster, nateinaction, SergeyBiryukov. Fixes #50837. Built from https://develop.svn.wordpress.org/trunk@48734 git-svn-id: http://core.svn.wordpress.org/trunk@48496 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 17:54:04 +00:00
whyisjake	b84d7f1fd3	Site Health: Display auto-update properly for plugins that don't support auto-updates. ... Properly filter `auto_update_plugin` when displaying the table. Fixes #50822. Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48731 git-svn-id: http://core.svn.wordpress.org/trunk@48493 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 17:37:02 +00:00
desrosj	fa9b043313	Help/About: Remove “Musician Name” placeholder. ... The musician name is traditionally not included on the About page due to i18n concerns regarding last minute changes. Props audrasjb, SergeyBiryukov. See #50416. Built from https://develop.svn.wordpress.org/trunk@48730 git-svn-id: http://core.svn.wordpress.org/trunk@48492 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 17:35:06 +00:00
desrosj	527ca5ff78	Help/About: String updates and accessibility improvements to the 5.5 About page. ... Props ryelle, nrqsnchz, desrosj, audrasjb, marybaum, spacedmonkey, SergeyBiryukov, estelaris, afercia, ocean90. See #50416. Built from https://develop.svn.wordpress.org/trunk@48729 git-svn-id: http://core.svn.wordpress.org/trunk@48491 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 17:26:03 +00:00
Sergey Biryukov	315db55458	Comments: Restore the ::has_items() call in WP_Comments_List_Table::extra_tablenav() for now, until unit tests are updated accordingly. ... Follow-up to [48722]. Fixes #40188. See #50815. Built from https://develop.svn.wordpress.org/trunk@48724 git-svn-id: http://core.svn.wordpress.org/trunk@48486 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 16:26:03 +00:00
Sergey Biryukov	b615c45103	Comments: Use the existing static variable instead of calling ::has_items() again in WP_Comments_List_Table::extra_tablenav(). ... Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance. Props whyisjake, SergeyBiryukov. Fixes #40188. Built from https://develop.svn.wordpress.org/trunk@48722 git-svn-id: http://core.svn.wordpress.org/trunk@48484 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 15:58:06 +00:00
whyisjake	500c0118d4	Help/About: String update for 5.5 release. ... We don't use hyphens for the [block editor](https://make.wordpress.org/core/handbook/best-practices/spelling/). See #50416. Props davidbaumwald, marybaum, desrosj. Built from https://develop.svn.wordpress.org/trunk@48721 git-svn-id: http://core.svn.wordpress.org/trunk@48483 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 15:56:02 +00:00
Andrea Fercia	efdd927b48	Accessibility: Administration: Address backward compatibility concerns for the sortable postboxes areas after [48340]. ... Fixes #49288. Built from https://develop.svn.wordpress.org/trunk@48717 git-svn-id: http://core.svn.wordpress.org/trunk@48479 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-04 13:17:02 +00:00
Sergey Biryukov	e2c8e2fa5a	Administration: Allow wp_credits() to accept $version and $locale parameters. ... This can be helpful for plugin developers to get credits information for older versions or different locales. Props ramiy. Fixes #35910. Built from https://develop.svn.wordpress.org/trunk@48715 git-svn-id: http://core.svn.wordpress.org/trunk@48477 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-03 12:53:08 +00:00
Sergey Biryukov	016df3b6c6	Docs: Correct placement for wp_editor_expand filter DocBlock. ... See #50768. Built from https://develop.svn.wordpress.org/trunk@48714 git-svn-id: http://core.svn.wordpress.org/trunk@48476 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-03 12:11:06 +00:00
Sergey Biryukov	8ff7595ae9	Permalinks: Don't show "You should update your .htaccess file now" message when saving permalink settings on Multisite. ... Multisite routing is taken care of by WordPress, not by the web server. Follow-up to [13706], [37747], [38066]. Props boonebgorges. Fixes #39547. Built from https://develop.svn.wordpress.org/trunk@48713 git-svn-id: http://core.svn.wordpress.org/trunk@48475 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-02 12:57:08 +00:00
Sergey Biryukov	0a76cb6240	Permalinks: Simplify the logic for displaying "You should update your .htaccess file now" message. ... See #39547, #50834. Built from https://develop.svn.wordpress.org/trunk@48712 git-svn-id: http://core.svn.wordpress.org/trunk@48474 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-02 12:51:03 +00:00
Sergey Biryukov	c9cf1ba365	Docs: Correct formatting for a comment in wp-admin/options-permalink.php. ... Previously committed in [48694], accidentally reverted in [48710]. See #50768. Built from https://develop.svn.wordpress.org/trunk@48711 git-svn-id: http://core.svn.wordpress.org/trunk@48473 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-02 12:39:07 +00:00
Sergey Biryukov	38f653b639	Permalinks: Correct the check whether .htaccess update is required when saving permalink settings. ... The check should be performed after the permalink structure update, not before. Fixes #50834. Built from https://develop.svn.wordpress.org/trunk@48710 git-svn-id: http://core.svn.wordpress.org/trunk@48472 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-02 12:36:02 +00:00
Sergey Biryukov	85c38d54e6	Upgrade/Install: Show the installed WordPress version number on WordPress Updates screen if there is a newer version available. ... This makes it easier for a user to know how significant of an update the change might be, and helps them make an informed decision about how to proceed. Props tmdesigned, dd32, circlecube, dkarfa, hakre, scribu, MadtownLems, markshep, nbachiyski, dmchale, miqrogroove, ovann86, danieltj, sterndata, seanpaulrasmussen, mrgrt, Commeuneimage, dpacks, puneetsahalot, jonoaldersonwp, SergeyBiryukov. Fixes #15101. See #35554, #47848. Built from https://develop.svn.wordpress.org/trunk@48709 git-svn-id: http://core.svn.wordpress.org/trunk@48471 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-08-01 19:46:04 +00:00
whyisjake	224fdb27b8	Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled. ... As certain plugins may not support updates, this count needs to accurately reflect that in the navbar. Fixes 50808. Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@48703 git-svn-id: http://core.svn.wordpress.org/trunk@48465 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-31 17:21:04 +00:00
whyisjake	b4497ef13f	Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes ... As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons. Fixes #50824. Props dd32, whyisjake, SergeyBiryukov. Built from https://develop.svn.wordpress.org/trunk@48701 git-svn-id: http://core.svn.wordpress.org/trunk@48463 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-31 17:03:05 +00:00
Sergey Biryukov	3f83523b4e	Editor: Correctly back up the global $post in wp-admin/edit-form-blocks.php. ... To create a copy of the object, instead of a reference to the same object, the `clone` keyword should be used. Props scarolan. Fixes #50775. Built from https://develop.svn.wordpress.org/trunk@48700 git-svn-id: http://core.svn.wordpress.org/trunk@48462 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-31 14:00:05 +00:00
whyisjake	078db63c4b	Upgrade/Install: Pass the plugin file path into the plugin_auto_update_debug_string filter. ... Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot. Fixes #50821. Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48696 git-svn-id: http://core.svn.wordpress.org/trunk@48458 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-30 21:50:02 +00:00
Sergey Biryukov	629af79b24	Docs: Correct formatting for a comment in wp-admin/options-permalink.php. ... See #50768. Built from https://develop.svn.wordpress.org/trunk@48694 git-svn-id: http://core.svn.wordpress.org/trunk@48456 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-30 14:02:04 +00:00
Sergey Biryukov	cf137e7c1b	Comments: Pass the $which parameter to the manage_comments_nav action. ... This brings some consistency with the `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions. Props Tkama, wpgurudev. Fixes #50736. Built from https://develop.svn.wordpress.org/trunk@48693 git-svn-id: http://core.svn.wordpress.org/trunk@48455 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-30 13:27:04 +00:00
Sergey Biryukov	72b87b3d74	Themes: Pass correct variable to is_php_version_compatible() in wp_theme_update_row(). ... This applies to the Themes screen in Multisite network admin. Follow-up to [48660]. Props pbiron, afragen. Fixes #48507. See #48491. Built from https://develop.svn.wordpress.org/trunk@48689 git-svn-id: http://core.svn.wordpress.org/trunk@48451 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-29 21:08:02 +00:00
whyisjake	e6bfdde581	Upgrade/Install: Only show auto-update for themes that support the feature. ... Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme. See #50280. Props dd32. Built from https://develop.svn.wordpress.org/trunk@48688 git-svn-id: http://core.svn.wordpress.org/trunk@48450 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-29 20:01:08 +00:00
Sergey Biryukov	1d552ea6b1	Help/About: Adjust two strings on the About page for better i18n. ... Follow-up to [48675]. Props ocean90, audrasjb, kittmedia, nao. See #50416. Built from https://develop.svn.wordpress.org/trunk@48686 git-svn-id: http://core.svn.wordpress.org/trunk@48448 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-29 13:29:04 +00:00
Sergey Biryukov	d351100eba	Upgrade/Install: Pass correct argument to clear_destination in Theme_Upgrader::install(). ... Follow-up to [48390]. Props afragen, sabernhardt. Fixes #9757. Built from https://develop.svn.wordpress.org/trunk@48685 git-svn-id: http://core.svn.wordpress.org/trunk@48447 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-29 13:09:04 +00:00
Sergey Biryukov	c5ef3b7976	Media: Pass the $rel parameter to image_send_to_editor filter. ... Props mihdan, pputzer. Fixes #50765. Built from https://develop.svn.wordpress.org/trunk@48684 git-svn-id: http://core.svn.wordpress.org/trunk@48446 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 21:21:05 +00:00
whyisjake	d8fd6d05a3	Upgrade/Install: Swap auto-update-supported to update-supported in update checks. ... Ensures backwards compatability with external updaters. See #50280. Props everyone-in-the-core-updates-channel. Built from https://develop.svn.wordpress.org/trunk@48678 git-svn-id: http://core.svn.wordpress.org/trunk@48440 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 18:28:06 +00:00
desrosj	6209a40fd9	Upgrade/Install: Clarify the descriptions for install_(plugin|theme)_overwrite_actions. ... See #9757. Built from https://develop.svn.wordpress.org/trunk@48677 git-svn-id: http://core.svn.wordpress.org/trunk@48439 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 18:16:07 +00:00
desrosj	1aa48c68f5	Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes. ... See #9757. Built from https://develop.svn.wordpress.org/trunk@48676 git-svn-id: http://core.svn.wordpress.org/trunk@48438 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 17:56:04 +00:00
whyisjake	7267fc02b0	Help/About: WordPress 5.5 About Page. ... Speed. Search. Security. This is the start of the WordPress 5.5 about page. Fixes #50416. Props ryelle, marybaum, estelaris, yvettesonneveld, michelebutcher-jones, metalandcoffee, melchoyce, marktimemedia, abhanonstopnewsuk, elmastudio, davidbaumwald, audrasjb, afercia, cbringmann, andreamiddleton, desrosj, earnjam, SergeyBiryukov, whyisjake, elrae. Built from https://develop.svn.wordpress.org/trunk@48675 git-svn-id: http://core.svn.wordpress.org/trunk@48437 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 17:46:04 +00:00
Sergey Biryukov	eb0869755e	Administration: Correct alignment of the "PHP Update Required" dashboard box title. ... Restore one instance of `!important` CSS rule for backward compatibility. Follow-up to [48129], [48373]. Props whyisjake, sabernhardt, TimothyBlynJacobs, SergeyBiryukov. Fixes #50788. Built from https://develop.svn.wordpress.org/trunk@48671 git-svn-id: http://core.svn.wordpress.org/trunk@48433 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 17:08:03 +00:00
Sergey Biryukov	e4b2ad02b6	Administration: Don't override the $mode global in WP_Screen::render_view_mode() if it's already set. ... Follow-up to [48398], [48423], [48424], [48450]. See #49715. Built from https://develop.svn.wordpress.org/trunk@48670 git-svn-id: http://core.svn.wordpress.org/trunk@48432 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:55:04 +00:00
whyisjake	0f1f9bdb03	Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates. ... This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available. See #50798. Fixes #50280. Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj. Built from https://develop.svn.wordpress.org/trunk@48669 git-svn-id: http://core.svn.wordpress.org/trunk@48431 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:32:01 +00:00
Sergey Biryukov	2bf5b5749f	Administration: Pull the table_view_mode filter for now. ... The extensibility of list table view modes will be explored in a future release. Props audrasjb. See #49715. Built from https://develop.svn.wordpress.org/trunk@48668 git-svn-id: http://core.svn.wordpress.org/trunk@48430 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:19:03 +00:00
Sergey Biryukov	3db534a988	Upgrade/Install: Disable the plugin/theme auto-updates UI if AUTOMATIC_UPDATER_DISABLED is defined and set as true. ... Props pbiron, dd32. Fixes #50798. See #50280. Built from https://develop.svn.wordpress.org/trunk@48667 git-svn-id: http://core.svn.wordpress.org/trunk@48429 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:15:03 +00:00
Sergey Biryukov	4cfc383544	Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file. ... Props mariovalney, desrosj. See #50593. Built from https://develop.svn.wordpress.org/trunk@48666 git-svn-id: http://core.svn.wordpress.org/trunk@48428 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 16:07:02 +00:00
Sergey Biryukov	0dd2f9f5c5	Docs: Add missing documentation for various upgrade/install class properties and methods. ... Props ramiy. Fixes #42923. Built from https://develop.svn.wordpress.org/trunk@48661 git-svn-id: http://core.svn.wordpress.org/trunk@48423 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 11:57:03 +00:00
Sergey Biryukov	a745f035ab	Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress. ... This applies to the Themes screen in Multisite network admin. Props afragen, SergeyBiryukov. Fixes #48507. See #48491. Built from https://develop.svn.wordpress.org/trunk@48660 git-svn-id: http://core.svn.wordpress.org/trunk@48422 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 11:34:04 +00:00
Sergey Biryukov	e349d92b53	Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages. ... Follow-up to [48652-48654]. See #48491. Built from https://develop.svn.wordpress.org/trunk@48659 git-svn-id: http://core.svn.wordpress.org/trunk@48421 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 11:31:01 +00:00
Mike Schroder	8c3d56919e	Upgrade/Install: Improve wp_opcache_invalidate() performance. ... Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`. Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder. Fixes #50784. Built from https://develop.svn.wordpress.org/trunk@48657 git-svn-id: http://core.svn.wordpress.org/trunk@48419 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 08:09:05 +00:00
whyisjake	26b706e27f	Site Health: Incorrect file path in require_once. ... Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates. Fixes #50793. Props dd32. Built from https://develop.svn.wordpress.org/trunk@48655 git-svn-id: http://core.svn.wordpress.org/trunk@48417 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 02:21:06 +00:00
Sergey Biryukov	db175a9868	Themes: Display a message in theme updates list if an update requires a higher version of PHP or WordPress. ... This applies to the WordPress Updates screen. Props afragen, SergeyBiryukov. Fixes #48491. Built from https://develop.svn.wordpress.org/trunk@48654 git-svn-id: http://core.svn.wordpress.org/trunk@48416 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 01:02:04 +00:00
Sergey Biryukov	ab6c396531	Themes: Correct the logic for displaying a message in theme grid if a theme update requires a higher version of PHP or WordPress. ... This applies to the Themes screen fallback used when JS is turned off. Follow-up to [48652]. See #48491. Built from https://develop.svn.wordpress.org/trunk@48653 git-svn-id: http://core.svn.wordpress.org/trunk@48415 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 00:43:02 +00:00
Sergey Biryukov	0122e035b0	Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress. ... This applies to the Themes screen and the Customizer theme browser. Props afragen, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@48652 git-svn-id: http://core.svn.wordpress.org/trunk@48414 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 00:09:02 +00:00
Sergey Biryukov	6307a7c41c	Docs: Correct alignment for some parameters in JS documentation. ... Follow-up to [48650]. See #43828. Built from https://develop.svn.wordpress.org/trunk@48651 git-svn-id: http://core.svn.wordpress.org/trunk@48413 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-28 00:07:03 +00:00
whyisjake	3dd9628aae	Build/Test Tools: Enable JSDocs to be linted with ESLint. ... As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/) this add some tooling to lint Javascript docblocks. Two new commands: * `npm run lint:jsdoc` * `npm run lint:jsdoc:fix` The latter will run the linter and try to fix an possible issues automatically. Fixes #43828. Props netweb, atimmer, kamataryo, whyisjake. Built from https://develop.svn.wordpress.org/trunk@48650 git-svn-id: http://core.svn.wordpress.org/trunk@48412 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 23:35:02 +00:00
youknowriad	bb54ebcd0d	Administration: Fix the red links on the Media Modal. ... The custom link colors for admin scheme colors were overriding the danger color. Props kebbet, dlh. Fixes #50547. Built from https://develop.svn.wordpress.org/trunk@48643 git-svn-id: http://core.svn.wordpress.org/trunk@48405 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 19:17:05 +00:00
Sergey Biryukov	e071ace6c4	Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress. ... This applies to the Themes screen fallback used when JS is turned off. Props afragen, desrosj, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@48640 git-svn-id: http://core.svn.wordpress.org/trunk@48402 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 15:21:02 +00:00
Sergey Biryukov	4336a2b9a7	Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress. ... This applies to the Themes screen, Add Themes screen, and the Customizer theme browser. Props afragen, desrosj, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@48638 git-svn-id: http://core.svn.wordpress.org/trunk@48400 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 15:04:03 +00:00
Sergey Biryukov	39147698d9	Themes: Display a message in Details & Preview modal on Add Themes screen if a theme requires a higher version of PHP or WordPress. ... Props afragen, desrosj, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@48637 git-svn-id: http://core.svn.wordpress.org/trunk@48399 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 14:26:07 +00:00
Sergey Biryukov	1f89186a3d	Themes: Display a message in Theme Details modal if a theme requires a higher version of PHP or WordPress. ... Props afragen, desrosj, SergeyBiryukov. See #48491. Built from https://develop.svn.wordpress.org/trunk@48636 git-svn-id: http://core.svn.wordpress.org/trunk@48398 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 13:12:04 +00:00
Mike Schroder	9ec7f2febd	Docs: Correct wp_opcache_invalidate_file filter docs. ... Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs. See #36455. Built from https://develop.svn.wordpress.org/trunk@48632 git-svn-id: http://core.svn.wordpress.org/trunk@48394 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-27 09:08:05 +00:00
Sergey Biryukov	df74d8f10d	Revisions: Ensure the global $post remains the same after revision is restored. ... Because `wp_insert_post()` and `wp_transition_post_status()` are called during the process, plugins can unexpectedly modify `$post`. Props markparnell, tofandel, archon810, SergeyBiryukov. Fixes #46671. Built from https://develop.svn.wordpress.org/trunk@48625 git-svn-id: http://core.svn.wordpress.org/trunk@48387 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-26 21:25:02 +00:00
Sergey Biryukov	a6cf8df9d1	Docs: Synchronize some comments in wp-admin/revision.php. ... See #49572. Built from https://develop.svn.wordpress.org/trunk@48624 git-svn-id: http://core.svn.wordpress.org/trunk@48386 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-26 20:43:02 +00:00
Sergey Biryukov	d8c62b5647	Posts, Post Types: Move get_post_states() back to the admin for now, require the file in WP_Customize_Nav_Menus::customize_register() instead. ... This provides a minor performance improvement by only running the function in contexts where it's needed. Follow-up to [47211], [47213], [47763], [48619]. See #46829, #49374. Built from https://develop.svn.wordpress.org/trunk@48620 git-svn-id: http://core.svn.wordpress.org/trunk@48382 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-26 10:51:06 +00:00
Sergey Biryukov	aab535a576	Posts, Post Types: Make get_post_states() available on frontend. ... This allows special pages to be denoted as such when editing a menu in the Customizer. This applies to the Front Page, Posts Page, and Privacy Policy Page. Follow-up to [47211], [47213], [47763]. Props dlh, whyisjake, SergeyBiryukov. Fixes #46829. See #49374. Built from https://develop.svn.wordpress.org/trunk@48619 git-svn-id: http://core.svn.wordpress.org/trunk@48381 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-26 01:14:06 +00:00
Sergey Biryukov	609acd89ed	I18N: Merge duplicate "List view" and "Grid view" strings. ... Props ramiy. Fixes #50757. Built from https://develop.svn.wordpress.org/trunk@48618 git-svn-id: http://core.svn.wordpress.org/trunk@48380 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 21:32:05 +00:00
Sergey Biryukov	c40a645510	Docs: Correct @see references for privacy hooks: ... * `wp_privacy_personal_data_export_page` * `wp_privacy_personal_data_erasure_page` Hooks should be single-quoted when referenced. Props pbiron, coffee2code. See #49572, #meta5318. Built from https://develop.svn.wordpress.org/trunk@48616 git-svn-id: http://core.svn.wordpress.org/trunk@48378 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 19:14:03 +00:00
Sergey Biryukov	7d305c8ff9	Docs: Correct @since tags for some WP_List_Table hooks: ... * `views_{$this->screen->id}` * `bulk_actions-{$this->screen->id}` * `manage_{$this->screen->id}_sortable_columns` Follow-up to [15491], [15578], [26401]. See #49572. Built from https://develop.svn.wordpress.org/trunk@48615 git-svn-id: http://core.svn.wordpress.org/trunk@48377 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 18:55:03 +00:00
Sergey Biryukov	0ef0a1905b	Docs: Remove outdated statement in bulk_actions-{$this->screen->id} filter description. ... As of WordPress 4.7, developers can register their own bulk actions on list table screens. Follow-up to [17297], [38647]. Props joyously, pbiron. See #49572. Built from https://develop.svn.wordpress.org/trunk@48614 git-svn-id: http://core.svn.wordpress.org/trunk@48376 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 18:13:02 +00:00
Sergey Biryukov	ef382e6aaf	Site Health: Escape the displayed result of the request in REST API availability test. ... Props siliconforks, gisselfeldt. Fixes #50588. Built from https://develop.svn.wordpress.org/trunk@48608 git-svn-id: http://core.svn.wordpress.org/trunk@48370 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-25 15:38:06 +00:00
Sergey Biryukov	b6f52721ed	Administration: Use sentence case for "Mark as spam" bulk action links for sites and users, for consistency with comments. ... Follow-up to [48352]. See #40244. Built from https://develop.svn.wordpress.org/trunk@48595 git-svn-id: http://core.svn.wordpress.org/trunk@48357 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-24 00:27:03 +00:00
Sergey Biryukov	703a978a77	Administration: Capitalize Trash consistently in various messages. ... When used as a noun referring to the "virtual" place, `Trash` should be capitalized. Follow-up to [47233], [48352]. See #45317, #40244. Built from https://develop.svn.wordpress.org/trunk@48594 git-svn-id: http://core.svn.wordpress.org/trunk@48356 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-24 00:21:03 +00:00
John Blackbourn	9bc7d0a776	Docs: Another pass at some inline docs fixes mostly made by PHPCBF. ... See #49572, #50744 Built from https://develop.svn.wordpress.org/trunk@48590 git-svn-id: http://core.svn.wordpress.org/trunk@48352 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 21:11:05 +00:00
Sergey Biryukov	3f04e3bf5c	I18N: Further adjust some update/install strings for consistency. ... Follow-up to [48568], [48569]. See #50708, #50714. Built from https://develop.svn.wordpress.org/trunk@48589 git-svn-id: http://core.svn.wordpress.org/trunk@48351 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 21:08:01 +00:00
Sergey Biryukov	5950e15042	I18N: Merge two "Return to top" strings. ... Props ramiy, carike, whyisjake. Fixes #50743. Built from https://develop.svn.wordpress.org/trunk@48588 git-svn-id: http://core.svn.wordpress.org/trunk@48350 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 20:21:07 +00:00
Sergey Biryukov	161821d155	Site Health: Correct the quotes for the tested value of mock plugin data in auto-updates test. ... Follow-up to [48584]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48587 git-svn-id: http://core.svn.wordpress.org/trunk@48349 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 20:13:05 +00:00
John Blackbourn	57a3f803ae	Docs: First pass at some inline docs fixes mostly made by PHPCBF. ... See #49572, #50744 Built from https://develop.svn.wordpress.org/trunk@48586 git-svn-id: http://core.svn.wordpress.org/trunk@48348 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 20:01:04 +00:00
John Blackbourn	7f898dd9c4	Docs: Use more appropriate variable names in the inline docs for action and filter parameters. ... See #49572 Built from https://develop.svn.wordpress.org/trunk@48585 git-svn-id: http://core.svn.wordpress.org/trunk@48347 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 19:06:03 +00:00
desrosj	231d21ebcd	Site Health: Pass all expected parameters to auto_update_{$type}. ... This prevents fatal errors when other hooked functions are expecting both parameters. Props dd32, desrosj, audrasjb, pbiron. Fixes #50662. Built from https://develop.svn.wordpress.org/trunk@48584 git-svn-id: http://core.svn.wordpress.org/trunk@48346 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 19:03:04 +00:00
Sergey Biryukov	0eb1b2a447	I18N: Update "Default Template" string to match the sentence case used in the block editor. ... Props ramiy. Fixes #50742. Built from https://develop.svn.wordpress.org/trunk@48583 git-svn-id: http://core.svn.wordpress.org/trunk@48345 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 18:55:01 +00:00
desrosj	2c2508f98c	General: Ensure the database upgrades from [48575] are run. ... This corrects the database version to match the commit number the upgrade changes were made. See #50413. Built from https://develop.svn.wordpress.org/trunk@48582 git-svn-id: http://core.svn.wordpress.org/trunk@48344 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 18:43:04 +00:00
John Blackbourn	124972f2c6	Docs: Further corrections and improvements to various inline docblocks. ... See #49572 Built from https://develop.svn.wordpress.org/trunk@48576 git-svn-id: http://core.svn.wordpress.org/trunk@48338 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 07:39:02 +00:00
Aaron Jorbin	6cab8cce22	General: Update code for readability and inclusion ... There are two pieces in here: 1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks. 2) This improves backwards compatibility for code that was accessing the now deprecated code. Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566] Props: desrosj, SergeyBiryukov, johnjamesjacoby Fixes: #50413 Built from https://develop.svn.wordpress.org/trunk@48575 git-svn-id: http://core.svn.wordpress.org/trunk@48337 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 03:14:06 +00:00
John Blackbourn	0bf9b04c53	Docs: Various formatting improvements to inline docblocks. ... See #49572 Built from https://develop.svn.wordpress.org/trunk@48574 git-svn-id: http://core.svn.wordpress.org/trunk@48336 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 00:52:05 +00:00
John Blackbourn	1fbcdb2213	Docs: Various corrections to inline docblocks. ... See #49572 Built from https://develop.svn.wordpress.org/trunk@48573 git-svn-id: http://core.svn.wordpress.org/trunk@48335 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-23 00:48:06 +00:00
whyisjake	413fae70e8	i18n: Merge similar translation strings in wp-admin/options.php ... WARNING! is now Warning: You have been warned. Fixes #50715. Props: ramiy, audrasjb, ocean90. Built from https://develop.svn.wordpress.org/trunk@48570 git-svn-id: http://core.svn.wordpress.org/trunk@48332 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 22:21:03 +00:00
whyisjake	dd642e7b00	i18n: Merge similar translation strings to "Update failed". ... Fixes #50714. Props ramiy, ocean90. Built from https://develop.svn.wordpress.org/trunk@48569 git-svn-id: http://core.svn.wordpress.org/trunk@48331 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 22:10:02 +00:00
whyisjake	921ddab889	I18N: Merge similar "Installation failed" strings ... Fixes #50708. Props ramiy, ocean90, audrasjb. Built from https://develop.svn.wordpress.org/trunk@48568 git-svn-id: http://core.svn.wordpress.org/trunk@48330 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 21:59:05 +00:00
whyisjake	d1517a1ad4	I18N: Update some strings to have periods. ... Fixes #50707. Props ramiy, afercia, audrasjb. Built from https://develop.svn.wordpress.org/trunk@48567 git-svn-id: http://core.svn.wordpress.org/trunk@48329 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 21:55:06 +00:00
desrosj	2cebcb6144	General: Rename remove_option_allowed_list() to remove_allowed_options(). ... This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names. See #50413. Built from https://develop.svn.wordpress.org/trunk@48566 git-svn-id: http://core.svn.wordpress.org/trunk@48328 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 18:52:02 +00:00
Sergey Biryukov	3db2c3afd4	Upgrade/Install: Don't trigger database upgrade on Ajax requests via wp-admin/async-upload.php. ... Props schlessera, jgrodel, elrae, davidbaumwald, hareesh-pillai, adamsilverstein, SergeyBiryukov. Fixes #39459. Built from https://develop.svn.wordpress.org/trunk@48565 git-svn-id: http://core.svn.wordpress.org/trunk@48327 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 12:56:04 +00:00
Sergey Biryukov	6f0b8e2b2b	Accessibility: Themes: Consistently use an underline for "Enable auto-updates" link and theme author link in theme overlay. ... Props chetan200891, sabernhardt, afercia. Fixes #50697. Built from https://develop.svn.wordpress.org/trunk@48564 git-svn-id: http://core.svn.wordpress.org/trunk@48326 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 12:19:05 +00:00
Sergey Biryukov	1373b2056d	Docs: Correct type for the $theme parameter of theme_auto_update_debug_string filter. ... Follow-up to [48546], [48549], [48552]. See #50663. Built from https://develop.svn.wordpress.org/trunk@48561 git-svn-id: http://core.svn.wordpress.org/trunk@48323 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:29:03 +00:00
Sergey Biryukov	88e046f1e8	Site Health: Fix some typos in the test for plugin and theme auto-updates. ... Follow-up to [48548], [48558], [48559]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48560 git-svn-id: http://core.svn.wordpress.org/trunk@48322 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:17:04 +00:00
Sergey Biryukov	c6034be779	Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates. ... Follow-up to [48548], [48558]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48559 git-svn-id: http://core.svn.wordpress.org/trunk@48321 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:15:02 +00:00
Sergey Biryukov	93bf0c3b83	Site Health: Add the test for plugin and theme auto-updates to WP_Site_Health::get_tests(). ... This ensures that the test actually runs. Follow-up to [48548]. See #50662. Built from https://develop.svn.wordpress.org/trunk@48558 git-svn-id: http://core.svn.wordpress.org/trunk@48320 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-22 00:07:02 +00:00
Sergey Biryukov	a68d462439	Site Health: Use a consistent label for theme auto-updates in debug data. ... Props audrasjb. Fixes #50728. Built from https://develop.svn.wordpress.org/trunk@48554 git-svn-id: http://core.svn.wordpress.org/trunk@48316 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 21:06:02 +00:00
Sergey Biryukov	94d4561906	Site Health: Simplify the logic for displaying whether auto-updates are enabled for plugins and themes. ... Remove some extra variables. Follow-up to [48546], [48549]. See #50663. Built from https://develop.svn.wordpress.org/trunk@48552 git-svn-id: http://core.svn.wordpress.org/trunk@48314 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 18:44:04 +00:00
Sergey Biryukov	8a58ab36cc	Site Health: Rename the filters added in [48546] for clarity. ... See #50663. Built from https://develop.svn.wordpress.org/trunk@48549 git-svn-id: http://core.svn.wordpress.org/trunk@48311 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 17:09:03 +00:00
whyisjake	9d2b92be26	Site Health: Add tests to check for potential issues with plugin and theme auto-updates. ... Fixes #50662. Props desrosj, audrasjb. Built from https://develop.svn.wordpress.org/trunk@48548 git-svn-id: http://core.svn.wordpress.org/trunk@48310 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 17:07:05 +00:00
whyisjake	32f791da49	Site Health: Add auto-update information to for plugins and themes. ... New filters: * `plugin_auto_update_debug_str` * `theme_auto_update_debug_str` Fixes #50663. Props pbiron, audrasjb, davidbaumwald. Built from https://develop.svn.wordpress.org/trunk@48546 git-svn-id: http://core.svn.wordpress.org/trunk@48308 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 16:54:02 +00:00
Sergey Biryukov	548df4e3e6	I18N: Add context to some theme strings for consistency. ... Props ramiy, ocean90. Fixes #50709. Built from https://develop.svn.wordpress.org/trunk@48545 git-svn-id: http://core.svn.wordpress.org/trunk@48307 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 16:33:05 +00:00
Sergey Biryukov	48841f9ab3	Site Health: Rename upload_max array key in file upload checks to max_effective_size for clarity. ... Follow-up to [48535]. See #50038. Built from https://develop.svn.wordpress.org/trunk@48544 git-svn-id: http://core.svn.wordpress.org/trunk@48306 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 16:20:03 +00:00
Sergey Biryukov	1c52ad8d3f	Site Health: Move post_max_size and upload_max_filesize out of a translatable string in file upload checks. ... Simplify some other strings, use a consistent format for translator comments. Follow-up to [48535]. See #50038. Built from https://develop.svn.wordpress.org/trunk@48539 git-svn-id: http://core.svn.wordpress.org/trunk@48301 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 15:53:04 +00:00
Sergey Biryukov	bec9fa5010	Site Health: Remove parse_ini_size(), use the existing wp_convert_hr_to_bytes() function instead. ... Follow-up to [48535]. See #50038. Built from https://develop.svn.wordpress.org/trunk@48538 git-svn-id: http://core.svn.wordpress.org/trunk@48300 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 15:40:03 +00:00
desrosj	3dda74c337	Editor: Ensure the required assets for the block directory are enqueued. ... This fixes an issue where the block directory appears unstyled due to the stylesheets not being enqueued. Props ryelle, timothyblynjacobs, earnjam. Fixes #50661. Built from https://develop.svn.wordpress.org/trunk@48537 git-svn-id: http://core.svn.wordpress.org/trunk@48299 1a063a9b-81f0-0310-95a4-ce76da25c4cd	2020-07-21 15:38:03 +00:00