John Blackbourn
0fdc7bb582
Implement tests for the upload_mimes
filter to ensure it prevents the upload of disallowed file types.
...
See #32693
Built from https://develop.svn.wordpress.org/trunk@32919
git-svn-id: http://core.svn.wordpress.org/trunk@32890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 00:43:26 +00:00
John Blackbourn
f4ec9be456
Implement canonical and url_to_postid()
tests for child pages which share a post name with other child pages.
...
See #32759
Built from https://develop.svn.wordpress.org/trunk@32918
git-svn-id: http://core.svn.wordpress.org/trunk@32889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 00:41:27 +00:00
John Blackbourn
3c7ea03cb0
Correct the title used on the user dashboard.
...
Fixes #32754
Props johnjamesjacoby
Built from https://develop.svn.wordpress.org/trunk@32917
git-svn-id: http://core.svn.wordpress.org/trunk@32888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-24 00:37:28 +00:00
Scott Taylor
8854256155
Because programming is fun. After [32915], _.find()
will return undefined
if an empty array is passed - in that case, the function should return true
.
...
See #32746 .
Built from https://develop.svn.wordpress.org/trunk@32916
git-svn-id: http://core.svn.wordpress.org/trunk@32887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 19:43:25 +00:00
Scott Taylor
15bfe75f88
When filtering media by type in wp.media.model.Attachments.filters.type()
, account for the library's type
being an array of full mime-types.
...
Fixes #32746 .
Built from https://develop.svn.wordpress.org/trunk@32915
git-svn-id: http://core.svn.wordpress.org/trunk@32886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 19:40:26 +00:00
Scott Taylor
3b88c839f9
In wp_prepare_attachment_for_js()
, when setting filename
, call wp_basename()
on the result of get_attached_file()
, not WP_Post->guid
. guid
can be set to the result get_permalink()
, which is not a file path.
...
Props daxelrod.
Fixes #32531 .
Built from https://develop.svn.wordpress.org/trunk@32914
git-svn-id: http://core.svn.wordpress.org/trunk@32885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 18:30:26 +00:00
Scott Taylor
f61501f57f
The query-attachments
AJAX action immediately errors out if the user doesn't have the upload_files
cap. As such, the Customizer shouldn't show buttons that launch the media modal when the user doesn't have the proper permissions to query attachments.
...
See #32654 .
Built from https://develop.svn.wordpress.org/trunk@32913
git-svn-id: http://core.svn.wordpress.org/trunk@32884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 18:20:27 +00:00
Boone Gorges
3ffe2a059d
Add expectedDeprecated
flags to wp_richedit_pre()
and wp_htmledit_pre()
unit tests.
...
These functions were deprecated in [32899].
See #32425 .
Built from https://develop.svn.wordpress.org/trunk@32912
git-svn-id: http://core.svn.wordpress.org/trunk@32883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 14:42:26 +00:00
Boone Gorges
fdd0917471
In WP_Comment_Query
, parse meta_query vars after the pre_get_comments
hook.
...
[31467] included a change that involved generating meta_query SQL before the
`pre_get_comments` hook, with the result that `pre_get_comments` callbacks were
no longer able to modify comment meta queries. We fix the problem by moving the
SQL generation to after the hook.
This changeset also includes a second call to `meta_query->parse_query_vars()`,
to ensure that modifications to metadata-related query vars (such as `meta_key`
and `meta_value`) performed in `pre_get_comments` callbacks have the expected
effect on the comment query.
Fixes #32762 .
Built from https://develop.svn.wordpress.org/trunk@32911
git-svn-id: http://core.svn.wordpress.org/trunk@32882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 14:36:27 +00:00
Boone Gorges
03be8647c5
Fix PHP notice in WP_Tax_Query::get_sql_for_clause()
.
...
Previously, the `$where` variable was not initialized, so that when an invalid
'operator' was passed, PHP would complain that `$where` was undefined.
Props dlh.
Fixes #32756 .
Built from https://develop.svn.wordpress.org/trunk@32910
git-svn-id: http://core.svn.wordpress.org/trunk@32881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-23 12:44:27 +00:00
Scott Taylor
b30b08fd92
Refresh attachment links in the media modal are unneeded since bringing the image editor into it in [27445].
...
Props rommelxcastro.
Fixes #32550 .
Built from https://develop.svn.wordpress.org/trunk@32909
git-svn-id: http://core.svn.wordpress.org/trunk@32880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 21:33:26 +00:00
Scott Taylor
8c7e1b8ac0
In wp.media.view.UploaderStatus.filename()
, don't truncate the filename.
...
Props helen.
Fixes #31216 .
Built from https://develop.svn.wordpress.org/trunk@32908
git-svn-id: http://core.svn.wordpress.org/trunk@32879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 21:26:26 +00:00
Scott Taylor
994881d211
Add a label to the content field in the Text Widget for screen readers.
...
Props afercia.
Fixes #32736 .
Built from https://develop.svn.wordpress.org/trunk@32907
git-svn-id: http://core.svn.wordpress.org/trunk@32878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 21:22:26 +00:00
Scott Taylor
744cc75cd1
Sanitize the class passed to wp_list_bookmarks()
and allow passing an array.
...
Props ryan, obenland.
Fixes #23150 .
Built from https://develop.svn.wordpress.org/trunk@32906
git-svn-id: http://core.svn.wordpress.org/trunk@32877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:55:28 +00:00
Scott Taylor
00de0e6341
In unregister_setting()
, search for $option_name
in a segment of $new_whitelist_options
keyed by $option_group
.
...
Props nofearinc.
Fixes #26479 .
Built from https://develop.svn.wordpress.org/trunk@32905
git-svn-id: http://core.svn.wordpress.org/trunk@32876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:51:26 +00:00
Scott Taylor
d6c644d8df
After [32884], update the default value for comment_shortcuts
.
...
Props dlh, rachelbaker, DrewAPicture.
Fixes #31588 .
Built from https://develop.svn.wordpress.org/trunk@32904
git-svn-id: http://core.svn.wordpress.org/trunk@32875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:44:26 +00:00
Scott Taylor
b8f49cebee
List table views: fix missing current class for "All" when logged in as an author.
...
Props afercia.
Fixes #32015 .
Built from https://develop.svn.wordpress.org/trunk@32903
git-svn-id: http://core.svn.wordpress.org/trunk@32874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 20:39:27 +00:00
Helen Hou-Sandí
5a07e4bba4
Add "Scheduled" to post states.
...
props rclations.
fixes #32131 .
Built from https://develop.svn.wordpress.org/trunk@32902
git-svn-id: http://core.svn.wordpress.org/trunk@32873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 16:07:26 +00:00
Sergey Biryukov
4332d8dfc0
Avoid a PHP notice in WP_Press_This::get_suggested_content()
after [32828].
...
props kraftbj.
fixes #32751 .
Built from https://develop.svn.wordpress.org/trunk@32901
git-svn-id: http://core.svn.wordpress.org/trunk@32872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-22 15:20:28 +00:00
Andrew Ozz
baa8e833ff
Fix typo/white space in the docs.
...
See #32425 .
Built from https://develop.svn.wordpress.org/trunk@32900
git-svn-id: http://core.svn.wordpress.org/trunk@32871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-21 22:08:28 +00:00
Andrew Ozz
e4758f42e5
Update the TinyMCE initialization:
...
- Replace `wp_htmledit_pre()` and `wp_richedit_pre()` with `format_for_editor()`.
- Replace the `'htmledit_pre'` and `'richedit_pre'` filters with `'format_for_editor'`.
- Do not run the post content through `wpautop()` in PHP when the visual editor is default. Run the textarea content through the JS wpautop on initializing TinyMCE.
- Simplify both editors initialization.
- Improve setting of `wpActiveEditor` in Quicktags.
- Improve editor.js, use `tinymce.$` when possible.
See #32425 .
Built from https://develop.svn.wordpress.org/trunk@32899
git-svn-id: http://core.svn.wordpress.org/trunk@32870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-21 22:01:28 +00:00
Boone Gorges
a680859400
Pass stylesheet URL as an argument to 'style_loader_tag' filter.
...
This change brings the filter's signature in line with 'script_loader_tag'.
Props nicholas_io.
Fixes #32660 .
Built from https://develop.svn.wordpress.org/trunk@32898
git-svn-id: http://core.svn.wordpress.org/trunk@32869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-21 19:35:26 +00:00
Dominik Schilling
4423739c65
Use 3-digit x.x.x style for 4.3.0
@since versions.
...
see #32335 , #32430 .
Built from https://develop.svn.wordpress.org/trunk@32897
git-svn-id: http://core.svn.wordpress.org/trunk@32868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-21 11:41:26 +00:00
Andrew Ozz
b9a4fefb08
Update convert_chars():
...
- Stop trying to remove `<title>` and `<category>` meta tags. They have not been used for many many years.
- Replacement of `<br>` with `<br />` and `<hr>` with `<hr />` is not needed for HTML 5.0. Also, these tags are formatted like that by the visual editor.
- Replace invalid HTML entities that might be pasted in the Text editor on save instead of on display.
Fixes #32335 .
Built from https://develop.svn.wordpress.org/trunk@32896
git-svn-id: http://core.svn.wordpress.org/trunk@32867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-21 00:59:26 +00:00
Dominik Schilling
095dfe5386
Customizer: Fix live preview for menu item titles.
...
Show also a default label for menu items without a label which are assigned to a menu. This is currently only supported in the Customizer, see #24146 for nav menus screen.
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32895
git-svn-id: http://core.svn.wordpress.org/trunk@32866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 22:33:26 +00:00
Andrew Ozz
c13cb27c14
Fix error when dropping files for uploading on the editor before the media modal is initialized.
...
Props rommelxcastro, sebastiantiede. Fixes #32527 .
Built from https://develop.svn.wordpress.org/trunk@32894
git-svn-id: http://core.svn.wordpress.org/trunk@32865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 21:08:26 +00:00
Dominik Schilling
759bcdbad1
Customizer: Escape original title of menu items.
...
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32893
git-svn-id: http://core.svn.wordpress.org/trunk@32864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:55:25 +00:00
Dominik Schilling
f127478bde
Customizer: Improve handling of posts with no title.
...
Use the `#%d (no title)` string as a fallback which is already used on the nav menus screen.
Add a translator comment to all occurrences of the `#%d (no title)` string.
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32892
git-svn-id: http://core.svn.wordpress.org/trunk@32863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:50:26 +00:00
Dominik Schilling
baeadbb6fb
Customizer: Accessibility improvements for menu item searches.
...
* Add a description and an `aria-describedby` attribute to inform users this is a "live" search.
* Announce the number of search results via `wp.a11y.speak`.
* Use `aria-busy` attribute to stop screen readers announcing content while the "loading more results" is running.
* Increase the search debounce wait interval to 500ms to be consistent with other live searches.
* If a search fails don't call `wp.a11y.speak` with an undefined variable.
props afercia.
see #32720 .
Built from https://develop.svn.wordpress.org/trunk@32891
git-svn-id: http://core.svn.wordpress.org/trunk@32862 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:22:25 +00:00
Dominik Schilling
4a13015c98
Customizer: Don't add a menu item twice when using the keyboard.
...
Buttons don't need keyboard events, they natively support keyboard interaction and they just need a click event.
fixes #32665 .
Built from https://develop.svn.wordpress.org/trunk@32890
git-svn-id: http://core.svn.wordpress.org/trunk@32861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 19:01:25 +00:00
Dominik Schilling
2e8245ba0e
Customizer: Use valid markup for menu items.
...
Replace `<d(l|t)>` with `<div>` for `.menu-item-bar` and `.menu-item-handle`.
see #32724 , #32721 , #31817 .
Built from https://develop.svn.wordpress.org/trunk@32889
git-svn-id: http://core.svn.wordpress.org/trunk@32860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 18:47:27 +00:00
Dominik Schilling
1d953f8258
Customizer: Make labels of the menu item reorder buttons translatable.
...
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32888
git-svn-id: http://core.svn.wordpress.org/trunk@32859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 18:40:25 +00:00
Dominik Schilling
8fe9d04bf9
Customizer: Replace wrong usage of _x()
with translator comments.
...
see #32576 .
Built from https://develop.svn.wordpress.org/trunk@32887
git-svn-id: http://core.svn.wordpress.org/trunk@32858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 18:33:26 +00:00
Dominik Schilling
5c2d8c6b07
Customizer: Rename label for custom links to "Custom Links", see [31748].
...
props paulwilde
fixes #32732 .
Built from https://develop.svn.wordpress.org/trunk@32886
git-svn-id: http://core.svn.wordpress.org/trunk@32857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 18:29:26 +00:00
Dominik Schilling
4fdc99d2d1
Customizer: Decode HTML entities in the label property of WP_Customize_Media_Control
.
...
fixes #31631 .
Built from https://develop.svn.wordpress.org/trunk@32885
git-svn-id: http://core.svn.wordpress.org/trunk@32856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 18:15:26 +00:00
Drew Jaynes
1077b83a20
Update the DocBlock for wp_insert_post()
to exclude now-defunct contact method arguments and clarify others.
...
Also clarifies information on available hooks and adds a changelog entry for when the contact method arguments were removed.
Props dlh, rachelbaker.
See #31588 .
Built from https://develop.svn.wordpress.org/trunk@32884
git-svn-id: http://core.svn.wordpress.org/trunk@32855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 02:53:27 +00:00
Andrew Ozz
9828f9056e
Editor: add ARIA labels to the Quicktags buttons to improve accessibility.
...
Props afercia, azaozz. Fixes #31522 .
Built from https://develop.svn.wordpress.org/trunk@32883
git-svn-id: http://core.svn.wordpress.org/trunk@32854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-20 02:16:25 +00:00
Drew Jaynes
e2c7542b68
Add a changelog entry to the DocBlock for language_attributes()
noting that it was converted into a wrapper for get_language_attributes()
in 4.3.
...
See [32868]. See #28180 .
Built from https://develop.svn.wordpress.org/trunk@32882
git-svn-id: http://core.svn.wordpress.org/trunk@32853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 23:01:26 +00:00
Scott Taylor
a28f09a32c
Correct inline doc for $public
in register_post_status()
.
...
Props ericlewis.
Fixes #32061 .
Built from https://develop.svn.wordpress.org/trunk@32881
git-svn-id: http://core.svn.wordpress.org/trunk@32852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:35:25 +00:00
Scott Taylor
ada4394034
Use GPL-2.0+
for the value of license
in package.json
...
Props netweb.
Fixes #32718 .
Built from https://develop.svn.wordpress.org/trunk@32880
git-svn-id: http://core.svn.wordpress.org/trunk@32851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:32:27 +00:00
Scott Taylor
92d67bf395
Use valid markup in Walker_Nav_Menu_Edit::start_el()
- replace <d(l|t)>
with <div>
for .menu-item-bar
and .menu-item-handle
.
...
Props sagarjadhav.
Fixes #31817 .
Built from https://develop.svn.wordpress.org/trunk@32879
git-svn-id: http://core.svn.wordpress.org/trunk@32850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:22:26 +00:00
Scott Taylor
88743c7cd7
Add missing access modifiers in class-wp-customize-setting.php
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32878
git-svn-id: http://core.svn.wordpress.org/trunk@32849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:08:26 +00:00
Scott Taylor
eb4cd4880b
Add missing access modifier to WP_Customize_Sidebar_Section::json()
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32877
git-svn-id: http://core.svn.wordpress.org/trunk@32848 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:06:27 +00:00
Scott Taylor
55b2385cf5
Add missing access modifier to WP_Customize_Nav_Menus_Panel::wp_nav_menu_manage_columns()
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32876
git-svn-id: http://core.svn.wordpress.org/trunk@32847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:05:25 +00:00
Scott Taylor
dd2ec86e87
Add missing access modifiers to WP_Customize_Nav_Menus
.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32875
git-svn-id: http://core.svn.wordpress.org/trunk@32846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:04:28 +00:00
Scott Taylor
5e994cd6a1
Customizer et al, use elseif
in PHP, not else if
.
...
This was corrected via brute force in [31090].
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32874
git-svn-id: http://core.svn.wordpress.org/trunk@32845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 22:01:25 +00:00
Scott Taylor
a75961da89
Add access modifier to WP_Customize_Nav_Menu_Item_Control::json()
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32873
git-svn-id: http://core.svn.wordpress.org/trunk@32844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:55:24 +00:00
Scott Taylor
24bae70080
Add access modifier to WP_Customize_Nav_Menu_Control::json()
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32872
git-svn-id: http://core.svn.wordpress.org/trunk@32843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:54:25 +00:00
Scott Taylor
032ea5b132
Add access modifier to WP_Upgrader::clear_destination()
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32871
git-svn-id: http://core.svn.wordpress.org/trunk@32842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:53:25 +00:00
Scott Taylor
23e02fafce
Edit Post screen messages need to run preview URLs through the preview_post_link
filter.
...
Props pareshradadiya.
Fixes #32191 .
Built from https://develop.svn.wordpress.org/trunk@32870
git-svn-id: http://core.svn.wordpress.org/trunk@32841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:49:25 +00:00
Scott Taylor
86beb35f6d
Use <button>
instead of <a>
for non-link links in Quick Edit.
...
Props afercia.
Fixes #32213 .
Built from https://develop.svn.wordpress.org/trunk@32869
git-svn-id: http://core.svn.wordpress.org/trunk@32840 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:42:27 +00:00
Scott Taylor
38037c8d62
Add get_language_attributes()
, which is then used by (...drum roll...) language_attributes()
.
...
Props johnbillion, posykrat, PeterRKnight.
Fixes #28180 .
Built from https://develop.svn.wordpress.org/trunk@32868
git-svn-id: http://core.svn.wordpress.org/trunk@32839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:36:28 +00:00
Scott Taylor
0c866cfa79
Check is_callable()
in do_shortcode_tag()
, not add_shortcode()
.
...
Add a `_doing_it_wrong()` in `do_shortcode_tag()` when `is_callable()` is `false`.
Props aaroncampbell.
See #32445 .
Built from https://develop.svn.wordpress.org/trunk@32867
git-svn-id: http://core.svn.wordpress.org/trunk@32838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:33:25 +00:00
Scott Taylor
ec6dfc7f2b
Add a filter in wp_get_attachment_image_src()
called attachment_image_src
.
...
Props eclev91, MikeHansenMe.
Fixes #32363 .
Built from https://develop.svn.wordpress.org/trunk@32866
git-svn-id: http://core.svn.wordpress.org/trunk@32837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:27:25 +00:00
Scott Taylor
cfe78e0e95
Cleanup (ms-)?admin-filters.php
...
Props johnjamesjacoby.
Fixes #32529 .
Built from https://develop.svn.wordpress.org/trunk@32865
git-svn-id: http://core.svn.wordpress.org/trunk@32836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 21:18:25 +00:00
Scott Taylor
5e1d796cae
Ugrade MediaElement to 2.17.0
...
Changelog: https://github.com/johndyer/mediaelement/compare/2.16.4...2.17.0
Fixes #32698 .
Built from https://develop.svn.wordpress.org/trunk@32864
git-svn-id: http://core.svn.wordpress.org/trunk@32835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 20:42:26 +00:00
Scott Taylor
777d3ba7e2
wptexturize()
improvements:
...
* Make sure that strings ending with a number and quotation mark get the proper smart quotes
* Introduce `wptexturize_primes()`, a logic tree to determine whether or not "7'." represents seven feet, then converts the special char into either a prime char or a closing quote char.
Adds unit tests.
Props miqrogroove.
Fixes #29256 .
Built from https://develop.svn.wordpress.org/trunk@32863
git-svn-id: http://core.svn.wordpress.org/trunk@32834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 20:06:25 +00:00
Scott Taylor
b212ee67e7
Media Library Bulk Select
button size should be smaller.
...
Props afercia.
Fixes #32325 .
Built from https://develop.svn.wordpress.org/trunk@32862
git-svn-id: http://core.svn.wordpress.org/trunk@32833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:56:27 +00:00
Scott Taylor
c5e088bf0f
Improve focus when previewing an oEmbed from Add Media Panel
...
Props afercia.
Fixes #28820 .
Built from https://develop.svn.wordpress.org/trunk@32861
git-svn-id: http://core.svn.wordpress.org/trunk@32832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:49:27 +00:00
Scott Taylor
32dabc1f90
Don't strip \0
(backslash+zero) from post content for users without "unfiltered_html"
...
Adds unit tests.
Props miqrogroove.
Fixes #28699 .
Built from https://develop.svn.wordpress.org/trunk@32860
git-svn-id: http://core.svn.wordpress.org/trunk@32831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 18:47:27 +00:00
Dominik Schilling
a28586a6d7
Customizer: Improve accessibility of the toggle button in the available menu items panel.
...
Prevents focus lost in Safari because the button was "invisible" until it got focused.
fixes #32709 .
Built from https://develop.svn.wordpress.org/trunk@32859
git-svn-id: http://core.svn.wordpress.org/trunk@32830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 17:24:24 +00:00
Konstantin Obenland
898bb2ed34
Remove allowed tags from comment form.
...
It can be confusing to users and for most it is not relevant.
Commenters comfortable with HTML will know which tags are likely
to be accepted.
Props krogsgard, rachelbaker.
Fixes #30157 .
Built from https://develop.svn.wordpress.org/trunk@32858
git-svn-id: http://core.svn.wordpress.org/trunk@32829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 14:15:26 +00:00
Konstantin Obenland
4e7c057a5a
Check that current changes can be lost before editing another comment.
...
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.
Props pareshradadiya, chriscct7.
Fixes #21845 .
Built from https://develop.svn.wordpress.org/trunk@32857
git-svn-id: http://core.svn.wordpress.org/trunk@32828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 13:48:25 +00:00
Ella Iseulde Van Dorpe
fd95002b2a
Editor: restructure word count
...
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.
See #30966 . Fixes #26620 .
Built from https://develop.svn.wordpress.org/trunk@32856
git-svn-id: http://core.svn.wordpress.org/trunk@32827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 10:35:26 +00:00
Konstantin Obenland
50e32a1969
Keep WP_Customize_Nav_Menus_Panel
with other panels rather than controls.
...
Accidentally merged into the wrong file in [32806].
H/t celloexpressions for noticing.
See https://wordpress.slack.com/archives/core-customize/p1434696254000258 .
See #32576 .
Built from https://develop.svn.wordpress.org/trunk@32855
git-svn-id: http://core.svn.wordpress.org/trunk@32826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 08:37:27 +00:00
Dion Hulse
8593dc3172
When updating plugins/themes verify that the files to be deleted can be modified before starting the deletion process.
...
This will avoid partially deleting an item during update which has inconsistent permissions.
This change only affects those using the direct & ssh transports as FTP's is_writable() currently always returns `true`.
Fixes #30921
Built from https://develop.svn.wordpress.org/trunk@32854
git-svn-id: http://core.svn.wordpress.org/trunk@32825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:49:25 +00:00
Dion Hulse
a21f890abb
Remove a redundant index drop, it'll be dropped and re-created a few lines further down.
...
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk
Built from https://develop.svn.wordpress.org/trunk@32852
git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 03:18:26 +00:00
Andrew Ozz
503b80be0b
Fix using htmlspecialchars()
whit the $double_encode
parameter. PHP < 5.4 doesn't validate the entities.
...
Props miqrogroove. Fixes #17780 .
Built from https://develop.svn.wordpress.org/trunk@32851
git-svn-id: http://core.svn.wordpress.org/trunk@32822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 01:53:26 +00:00
Scott Taylor
d8c93a081d
Since PHP 5.2.3, the htmlspecialchars()
function has an optional $double_encode
parameter, which we can now use. This will save us a few expensive kses/html decoding calls.
...
Adds unit tests.
Props miqrogroove.
Fixes #17780 .
Built from https://develop.svn.wordpress.org/trunk@32850
git-svn-id: http://core.svn.wordpress.org/trunk@32821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 22:00:26 +00:00
John Blackbourn
f632756f16
Correct the docs for the post_type_labels_{$post_type}
filter.
...
Fixes #32707
Props dlh
Built from https://develop.svn.wordpress.org/trunk@32849
git-svn-id: http://core.svn.wordpress.org/trunk@32820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 21:33:27 +00:00
Dominik Schilling
f5fa907f77
Customizer: Improve accessibility of Add Menu Items button and its panel.
...
props afercia, ocean90.
fixes #32682 .
Built from https://develop.svn.wordpress.org/trunk@32848
git-svn-id: http://core.svn.wordpress.org/trunk@32819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 20:52:24 +00:00
Dominik Schilling
f39edce68d
Autoprefixer for [32844].
...
Built from https://develop.svn.wordpress.org/trunk@32847
git-svn-id: http://core.svn.wordpress.org/trunk@32818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 20:49:26 +00:00
Aaron Jorbin
4b7ce555d0
Add singular.php to template hierarchy
...
Singular is the only template context conditional that lacks a corresponding template. This allows some themes to simplify.
Fixes #22314 .
Props chipbennett.
Built from https://develop.svn.wordpress.org/trunk@32846
git-svn-id: http://core.svn.wordpress.org/trunk@32817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 19:01:26 +00:00
Scott Taylor
09c4444150
Make sure that all Gravatars are generated by get_avatar()
or at least run through apply_filters( 'get_avatar', $avatar )
for the sake of extensibility.
...
Props miqrogroove, GlennM, SergeyBiryukov.
Fixes #22650 .
Built from https://develop.svn.wordpress.org/trunk@32845
git-svn-id: http://core.svn.wordpress.org/trunk@32816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 18:36:25 +00:00
Konstantin Obenland
c1a9c4b7b8
Semanticize Help and Screen Options toggle.
...
Links used as UI controls that are not real links but act as buttons, should be buttons.
Props afercia.
Fixes #32494 .
Built from https://develop.svn.wordpress.org/trunk@32844
git-svn-id: http://core.svn.wordpress.org/trunk@32815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 16:36:25 +00:00
Konstantin Obenland
81df9bffc5
Use https for Google API external libraries.
...
Google recommends it and users are more likely to have the https version cached in their browser already.
Props rommelxcastro.
Fixes #32552 .
Built from https://develop.svn.wordpress.org/trunk@32843
git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:51:26 +00:00
Konstantin Obenland
d872f38c31
Show the posts meta box by default in Appearance > Menus.
...
Lessens user confusion and the likelyhood of misusing custom links
to add menu items for posts.
Props bcole808.
Fixes #32440 .
Built from https://develop.svn.wordpress.org/trunk@32842
git-svn-id: http://core.svn.wordpress.org/trunk@32813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:04:26 +00:00
Konstantin Obenland
f7f14ae558
More consistent spacing around the excerpt textarea.
...
Props paulwilde.
Fixes #32242 .
Built from https://develop.svn.wordpress.org/trunk@32841
git-svn-id: http://core.svn.wordpress.org/trunk@32812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 14:19:25 +00:00
Boone Gorges
dd3b146546
Use assertFalse()
rather than assertNull()
in Tests_WP_Customize_Setting::test_is_current_blog_previewed()
.
...
`is_current_blog_previewed()` returns a boolean.
See #31428 .
Built from https://develop.svn.wordpress.org/trunk@32840
git-svn-id: http://core.svn.wordpress.org/trunk@32811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 14:08:25 +00:00
Boone Gorges
92123c15bf
Make sure $_SERVER['SERVER_NAME']
is set whenever wp_mail()
is called in PHPUnit tests.
...
This eliminates PHP notices when `wp_mail()` needs to determine its own From header.
See [25381] for a previous fix, which focused only on the mail-specific tests.
Fixes #32702 .
Built from https://develop.svn.wordpress.org/trunk@32839
git-svn-id: http://core.svn.wordpress.org/trunk@32810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:53:25 +00:00
Boone Gorges
2e5e0bdc78
When updating a user, only send email-change notification if email address is passed.
...
The notification, introduced in [32380], was firing incorrectly (and throwing
a PHP notice) when `wp_update_user()` was called without including 'user_email'
in the update data.
Props imath.
Fixes #32684 . See #32430 .
Built from https://develop.svn.wordpress.org/trunk@32838
git-svn-id: http://core.svn.wordpress.org/trunk@32809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:30:26 +00:00
Boone Gorges
6105fca015
Add filters to wp_unique_term_slug()
.
...
This changeset adds two new filters:
* 'wp_unique_term_slug_is_bad_slug' lets developers control whether a test slug needs to be made unique, before the queries required to build a suffix are performed.
* 'wp_unique_term_slug' filters the output of the function.
These changes introduce parity with the filters in `wp_unique_post_slug()`.
Props coffee2code, bolo1988, boonebgorges.
Fixes #20783 .
Built from https://develop.svn.wordpress.org/trunk@32837
git-svn-id: http://core.svn.wordpress.org/trunk@32808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 13:20:26 +00:00
Ella Iseulde Van Dorpe
ecec2b61cf
TinyMCE: wptextpattern: escape should undo
...
Props azaozz.
See #31441 .
Built from https://develop.svn.wordpress.org/trunk@32836
git-svn-id: http://core.svn.wordpress.org/trunk@32807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:59:28 +00:00
Konstantin Obenland
437b1c2b6a
Revert [32834].
...
It's not ready yet and was a product of misusing vim.
See #30729 .
Built from https://develop.svn.wordpress.org/trunk@32835
git-svn-id: http://core.svn.wordpress.org/trunk@32806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:27:25 +00:00
Konstantin Obenland
598f4cc4ca
Emphasise previewing new themes
...
Built from https://develop.svn.wordpress.org/trunk@32834
git-svn-id: http://core.svn.wordpress.org/trunk@32805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:24:27 +00:00
Konstantin Obenland
c9e1e2be9b
Make posts in the 'Most recent' tab of post type meta boxes filterable.
...
Provides parity with the 'View All' tab of post type meta boxes in Appearance > Menus.
Props jpyper, chriscct7.
Fixes #19365 .
Built from https://develop.svn.wordpress.org/trunk@32833
git-svn-id: http://core.svn.wordpress.org/trunk@32804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:35:28 +00:00
Ella Iseulde Van Dorpe
8b6ff40038
TinyMCE: wptextpattern: fix issue that removes content
...
* If the resulting text node is empty, don't remove all the content from the paragraph.
* If there's an empty text node at the start of the paragraph, ignore it and consider the next node to be the start.
See #31441 .
Built from https://develop.svn.wordpress.org/trunk@32832
git-svn-id: http://core.svn.wordpress.org/trunk@32803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:34:25 +00:00
Ella Iseulde Van Dorpe
1c586b9390
TinyMCE: show inline toolbar after scroll/resize
...
Also:
* Reduce the amount of callbacks.
* Move everything under `preinit` (but prepend to the callback). The API shouldn't be availbale earlier, and some UI is not available yet, neither is `editor.dom`.
* Hide the toolbar if the target is out of view.
See #32604 .
Built from https://develop.svn.wordpress.org/trunk@32831
git-svn-id: http://core.svn.wordpress.org/trunk@32802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:10:25 +00:00
Konstantin Obenland
326c106159
Recommend a user updates keys/salts in maint/repair.php
.
...
Since they are already going into `wp-config.php`, we should also encourage
them to update their unique phrases for keys and salts, assuming they do not
have a complete set of 8 unique ones already.
Props nacin, chriscct7.
Fixes #20779 .
Built from https://develop.svn.wordpress.org/trunk@32830
git-svn-id: http://core.svn.wordpress.org/trunk@32801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:07:25 +00:00
John Blackbourn
768d8507e5
Correct a typo in the inline docs for add_action()
.
...
Props nabil_kadimi, swissspidy
Fixes #32697
Built from https://develop.svn.wordpress.org/trunk@32829
git-svn-id: http://core.svn.wordpress.org/trunk@32800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 08:37:25 +00:00
Andrew Ozz
bc2630e099
Press This: Check the embeds list against all of the oembed providers.
...
Props stephdau. Fixes #32069 .
Built from https://develop.svn.wordpress.org/trunk@32828
git-svn-id: http://core.svn.wordpress.org/trunk@32799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 00:12:26 +00:00
Andrew Ozz
b77a3a33f5
Press This: show error message when the user is attempting to add a category that already exists.
...
Fixes #32339 .
Built from https://develop.svn.wordpress.org/trunk@32827
git-svn-id: http://core.svn.wordpress.org/trunk@32798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:13:26 +00:00
John Blackbourn
b14c6bea0b
Correct a unit test name.
...
See #21212
Built from https://develop.svn.wordpress.org/trunk@32826
git-svn-id: http://core.svn.wordpress.org/trunk@32797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 23:10:25 +00:00
Dominik Schilling
6e44f060ee
Customizer: Remove an overflow: hidden
declaration to prevent cutting off the left and right edge focus style of the "Add a Menu" input field.
...
props paulwilde.
fixes #32680 .
Built from https://develop.svn.wordpress.org/trunk@32825
git-svn-id: http://core.svn.wordpress.org/trunk@32796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:43:26 +00:00
Dominik Schilling
5864a7ad44
Customizer: Fix keyboard events for the menu items search field.
...
Replace the `change` event with `keyup`, see https://core.trac.wordpress.org/ticket/26600#comment:59 for background.
props tywayne.
fixes #32677 .
Built from https://develop.svn.wordpress.org/trunk@32824
git-svn-id: http://core.svn.wordpress.org/trunk@32795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:37:27 +00:00
Dominik Schilling
504db9233b
Customizer: Revert the blue on hover color which was introduced in [32649].
...
Blue is meant to be the primary action which isn't the case in this context. Colors need to be revised in #29158 .
see #31336 .
Built from https://develop.svn.wordpress.org/trunk@32823
git-svn-id: http://core.svn.wordpress.org/trunk@32794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 21:07:27 +00:00
Dominik Schilling
2d2445516c
Customizer: Decode HTML entities of panel/section titles.
...
Titles are now passed into Underscore templates but HTML-escaped, see #30737 .
fixes #32670 .
Built from https://develop.svn.wordpress.org/trunk@32822
git-svn-id: http://core.svn.wordpress.org/trunk@32793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:48:25 +00:00
Dominik Schilling
a1f7f4fe17
Customizer: Replace usage of calc()
with box-sizing: border-box
.
...
IE8 doesn't support `calc()`.
props afercia.
see #31336 .
fixes #32664 .
Built from https://develop.svn.wordpress.org/trunk@32821
git-svn-id: http://core.svn.wordpress.org/trunk@32792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:35:28 +00:00
Mark Jaquith
814865ea9e
Send emails when a user's email address or password is changed.
...
* In case of email change, email goes to the OLD address
* Prevents against issues where an account is compromised (say via cookie interception) and then the attacker silently takes over ownership via pw/email changes — now there will at least be a record that something is up
fixes #32430
props RMarks, MikeHansenMe, tharsheblows, obenland
Built from https://develop.svn.wordpress.org/trunk@32820
git-svn-id: http://core.svn.wordpress.org/trunk@32791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 19:31:27 +00:00
Boone Gorges
f62bf61b2c
Bail out of 4.3 term splitting routine when no shared terms are found.
...
Props dd32.
See #30261 .
Built from https://develop.svn.wordpress.org/trunk@32819
git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 11:40:24 +00:00