Commit Graph

116 Commits

Author SHA1 Message Date
Scott Taylor
7f8b548df1 In HTML5, the action attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Scott Taylor
af0e5cc851 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments.
Props tw2113 for the initial patch.
See #18788.

Built from https://develop.svn.wordpress.org/trunk@31034


git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:46:25 +00:00
John Blackbourn
d88ed475b0 Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors.
Fixes #10551
Props nacin

Built from https://develop.svn.wordpress.org/trunk@30356


git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 06:16:22 +00:00
Scott Taylor
130771a383 hackificator doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28497


git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
Andrew Nacin
11e5eaa6d5 Network Admin: Fix pagination on site-themes and site-users.
props kawauso, jeremyfelt.
fixes #17545.

Built from https://develop.svn.wordpress.org/trunk@27715


git-svn-id: http://core.svn.wordpress.org/trunk@27554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-25 16:57:15 +00:00
Andrew Nacin
dce0b9adea Use SSL when linking to WordPress.org. see #27115.
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Sergey Biryukov
af4f68b410 Use wp_dropdown_roles() in wp-admin/network/site-users.php.
props jeremyfelt.
fixes #27215.
Built from https://develop.svn.wordpress.org/trunk@27310


git-svn-id: http://core.svn.wordpress.org/trunk@27163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 10:22:14 +00:00
Andrew Ozz
8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Drew Jaynes
ceb16bc719 Inline documentation for hooks in wp-admin/network/site-users.php.
Props sboisvert for the initial patch. Props kpdesign.
Fixes #25497.

Built from https://develop.svn.wordpress.org/trunk@25939


git-svn-id: http://core.svn.wordpress.org/trunk@25898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-26 20:33:09 +00:00
Andrew Nacin
fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Sergey Biryukov
5744245cc3 Avoid a fatal error when adding a non-existent user to a site. props duck_. fixes #24460.
git-svn-id: http://core.svn.wordpress.org/trunk@24509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-25 14:24:18 +00:00
Ryan Boren
003941b2e7 Use API instead of bare SQL queries in site-users.php.
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-12 13:35:45 +00:00
Andrew Nacin
087b6ace16 Remove unused edit-site nonce fields from site-users and site-themes. props jeremyfelt, fixes #21277.
git-svn-id: http://core.svn.wordpress.org/trunk@21903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-18 23:06:22 +00:00
Andrew Nacin
d91ae96dc9 Simplify the markup and hierarchy of the Add Existing and Add New user forms on site-users.php. props obenland, fixes #21223.
git-svn-id: http://core.svn.wordpress.org/trunk@21854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-15 19:38:23 +00:00
ryan
5ca54e7d2f Deprecate get_blog_option(), add_blog_option(), update_blog_option(), and delete_blog_option().
Use the regular option functions wrapped in switch_to_blog() and restore_current_blog() instead.

Group multiple operations within a single switch where possible.

fixes #21432


git-svn-id: http://core.svn.wordpress.org/trunk@21414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 17:51:42 +00:00
nacin
7127ed1197 Move most instances of new WP_User to get_userdata(). see #21120.
git-svn-id: http://core.svn.wordpress.org/trunk@21413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 01:06:05 +00:00
nacin
3ebea2f218 Remove user/site suggestions (autocompletion) from search inputs, as the UX isn't proper.
* Removes all instances of site-search, so away it goes. Sidesteps a number of bugs with site-search.
 * Renames user-search to user-suggest, which means it better describes the current behavior (autocompletion) while allowing for future behavior (instant search).
 * Ties user suggestions to a single .wp-suggest-user class.

with help from markjaquith, helenyhou, wonderboymusic. 
fixes #20835.



git-svn-id: http://core.svn.wordpress.org/trunk@21003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:51:33 +00:00
nacin
eb8e069932 Correct the link to http://codex.wordpress.org/Network_Admin_Sites_Screen in the network admin help sidebars. props Nao. fixes #20607.
git-svn-id: http://core.svn.wordpress.org/trunk@20713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-03 13:34:33 +00:00
markjaquith
2a8c7bbc7a Autocomplete site names in Network Admin. More user completion areas. props Japh, DrewAPicture. see #19810.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-24 04:54:58 +00:00
nacin
8c841df86d Revert type="email" (HTML5) as some browsers that do validation on these fields do not work for IDN domains yet. Core does not support these well either, but server-side validation can at least be dealt with by a plugin. see #17863.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-15 18:09:14 +00:00
azaozz
f3b63e4537 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
markjaquith
481959acec Autocomplete for add-user screens in multisite. props boonebgorges, Japh, DrewAPicture, PeteMall, nacin, koopersmith, markjaquith. see #19810.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-10 08:45:17 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan
02a1dd7ccb Best practice, use wp_safe_redirect() when dealing with referrers. Props nacin.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-10 18:26:48 +00:00
ryan
9d03183e6d Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@19577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-08 23:02:33 +00:00
ryan
8ace5a6b4c Use WP_Screen::add_help_tab(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 02:22:07 +00:00
nacin
9cda4c5982 Remove 'update' from site-users.php on redirect. props PeteMall, fixes #18895.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-22 05:55:55 +00:00
nacin
cece838d8f More s/add_help_sidebar/set_help_sidebar/. fixes #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 21:32:16 +00:00
ryan
366db8c10b Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 05:33:53 +00:00
nacin
795ca8d394 Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 04:57:12 +00:00
azaozz
bbafdfa0e5 Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-03 04:00:57 +00:00
azaozz
3575537e5f Add screen_options with contextual content, see #18690
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 06:59:36 +00:00
nacin
dbc5a36a14 Remove duplicated current_action() call. props PeteMall, fixes #18389.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-18 06:26:18 +00:00
ryan
f938faa814 Link to site being edited. Props lloydbudd. fixes #17257
git-svn-id: http://svn.automattic.com/wordpress/trunk@18129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-03 15:35:45 +00:00
ryan
8192d0dae8 Validation fixes. Props ocean90, peaceablewhale. see #17364
git-svn-id: http://svn.automattic.com/wordpress/trunk@18010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-23 23:33:30 +00:00
nacin
37075f7f71 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
nacin
b563e11627 Pass id to the site-users and site-themes search form. props ocean90, fixes #16246.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-15 21:25:33 +00:00
nacin
b1c557fa4b D'oh. Use the proper URL to the multisite support forum. see #15880.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-25 19:21:00 +00:00
westi
faa07b6636 Nonce checks for site-users. See #15969 props PeteMall.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-24 22:37:51 +00:00
nacin
0f2672e53d Move to what will be the new Network Admin Codex page URLs. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-18 18:27:12 +00:00
nacin
661ff40dfe Merge the help strings across the network/site- pages. see #15880.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-18 18:02:11 +00:00
nacin
5fa861493b Network admin contextual help fixes. props SergeyBiryukov, fixes #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-17 23:34:10 +00:00
nacin
761dfa3c34 Final network admin help tweaks. props andrea_r, fixes #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-17 03:34:00 +00:00
scribu
cfe09b99e5 Introduce WP_List_Table::search_box(). See #15353
git-svn-id: http://svn.automattic.com/wordpress/trunk@17006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 20:45:10 +00:00
nacin
cc08068dba Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 08:43:22 +00:00
nacin
f32e4cb961 Network Admin: Rename Options to Settings. Kick the tab to the end as well. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16984 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 07:13:01 +00:00
nacin
9417d79543 Move to 'Documentation on XY' in the network admin. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 07:07:42 +00:00
nacin
d0e27b0935 Network Admin contextual help. props andrea_r (!), see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:52:47 +00:00
PeteMall
e44e212641 Use get_blog_option() isntead of raw SQL in site-users. See #14756
git-svn-id: http://svn.automattic.com/wordpress/trunk@16935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 09:05:10 +00:00
PeteMall
47b8f4a8cc s/Creationism/Evolution/ in site-users. See #14756
git-svn-id: http://svn.automattic.com/wordpress/trunk@16930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 02:22:53 +00:00
westi
70baa41126 Add cap checks. do the action in php. See #15793
git-svn-id: http://svn.automattic.com/wordpress/trunk@16892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 12:08:27 +00:00
westi
54d404134c Add some filters and an action to make this more flexible for plugin extension / modification. See #15793.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 11:58:49 +00:00
nacin
a717edca97 Always exit after wp_redirect. props filosofo, fixes #15518.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 18:02:54 +00:00
nacin
8d00b7b63b s/can_edit_site/can_edit_network/g. see #15720.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 12:36:39 +00:00
westi
381a4f7750 Introduce can_edit_site to replace inline checks on whether or not the site_id is for the current Network. See #15716.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-07 14:28:40 +00:00
PeteMall
8ab241a442 Create new user form for site-users. See #15558
git-svn-id: http://svn.automattic.com/wordpress/trunk@16586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-25 11:12:33 +00:00
PeteMall
a3a57860c4 Exit after wp_redirect(). See #15558
git-svn-id: http://svn.automattic.com/wordpress/trunk@16584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-25 09:25:50 +00:00
PeteMall
cad42deee5 Update and error messages for site-users. See #15558.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-25 09:13:38 +00:00
PeteMall
b27bd5b253 Adapt user-list-table for network admin site-users. See #15558
git-svn-id: http://svn.automattic.com/wordpress/trunk@16560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-24 05:31:25 +00:00
ryan
83c16a74cf Remove debug. Props ocean90. see #15342
git-svn-id: http://svn.automattic.com/wordpress/trunk@16441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 20:08:00 +00:00
ryan
15ded3a936 Add existing user to site form. Props PeteMall, ocean90. see #15342
git-svn-id: http://svn.automattic.com/wordpress/trunk@16440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 19:45:10 +00:00
ryan
06bf76e44f Handle sites that hard-code roles rather than storing them in the DB. Temp hack. see #15411
git-svn-id: http://svn.automattic.com/wordpress/trunk@16370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-14 18:19:07 +00:00
nacin
f269b75d7b Network admin multisite checks and docs. see #14435.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 14:27:15 +00:00
ryan
da54089621 Generalize seletion for h2 and h3 tabs. Props chrisbliss18 fixes #15154
git-svn-id: http://svn.automattic.com/wordpress/trunk@15962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 20:45:58 +00:00
nacin
c93f639f1e Use correct network admin icon. props PeteMall, see #15174.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 20:24:54 +00:00
ryan
012bb5278c Tabbed interface for site editing. see #15174
git-svn-id: http://svn.automattic.com/wordpress/trunk@15903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-21 18:35:52 +00:00