Commit Graph

5273 Commits

Author SHA1 Message Date
Boone Gorges
62450e9f0f After [31114] and [31323], 'View Post' generated in get_sample_permalink_html() should go to pretty permalink.
`get_permalink()` will return a non-pretty permalink for future posts, which
breaks some user workflows that expect View Post to lead to a page with the
pretty permalink.

Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@32002


git-svn-id: http://core.svn.wordpress.org/trunk@31981 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 01:27:28 +00:00
Sergey Biryukov
247fdbfe19 Remove hidden user_id input from wp_comment_reply().
Since [31172], it caused the comment's `user_id` field to be unexpectedly changed to the user who edits the comment.

See [31776] for Edit Comment screen.

props dllh.
fixes #30307.
Built from https://develop.svn.wordpress.org/trunk@31999


git-svn-id: http://core.svn.wordpress.org/trunk@31978 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 13:28:26 +00:00
Andrew Ozz
05a549723c Press This:
- Show a spinner while saving a post.
- Do not redirect after saving a draft.
- Make the unidentified error message clearer.
Fixes #31875.
Built from https://develop.svn.wordpress.org/trunk@31992


git-svn-id: http://core.svn.wordpress.org/trunk@31971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 01:34:26 +00:00
John Blackbourn
d05236f756 Introduce a string representing bulk plugin update success, ready for string freeze. Not used yet.
See #31770.

Built from https://develop.svn.wordpress.org/trunk@31991


git-svn-id: http://core.svn.wordpress.org/trunk@31970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 00:18:27 +00:00
Dion Hulse
02403eadd1 Plugins Browser: Replace the download count with the number of Active installs of the plugin.
Fixes #31865

Built from https://develop.svn.wordpress.org/trunk@31990


git-svn-id: http://core.svn.wordpress.org/trunk@31969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 23:49:27 +00:00
Aaron Jorbin
3ac2f91922 Update aria-label when doing a shiny plugin update
Also updates it again when the shiny plugin update is finished.
Also updates it if the shiny update fails

props mehulkaklotar, afercia
Fixes #31722



Built from https://develop.svn.wordpress.org/trunk@31982


git-svn-id: http://core.svn.wordpress.org/trunk@31961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-02 05:31:26 +00:00
Helen Hou-Sandí
d85f8fe326 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
Scott Taylor
62279ae07d In WP_Posts_List_Table::get_views(), don't add the current class to the all status link if ->user_posts_count has a value, which triggers the additional mine status.
See [31828].
Fixes #24869.

Built from https://develop.svn.wordpress.org/trunk@31959


git-svn-id: http://core.svn.wordpress.org/trunk@31938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:17:28 +00:00
Dominik Schilling
8ab7c076d6 Customizer Theme Switcher: Switch the details/live preview buttons.
props celloexpressions, ocean90.
fixes #31791.
Built from https://develop.svn.wordpress.org/trunk@31954


git-svn-id: http://core.svn.wordpress.org/trunk@31933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:36:26 +00:00
Aaron Jorbin
8f99fbeb8d Refine UI for FTP modal and shiny updates
Numerous changes to make the FTP modal experience a good one.  These include:
 * Update HTML used by both the form here and the form on the standalone screen
 * Allow users to cancel FTP install
 * Focus locking in the modal
 * Focus on modal form on load
 * ARIA Attributes
 * Style Enhancements
 * Add low screen height (such as phone and some tablets) friendly experience for entering credentials

Props ericlewis, afercia 
Fixes #31608


Built from https://develop.svn.wordpress.org/trunk@31949


git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:48:28 +00:00
Sergey Biryukov
efb2740e88 Themes: Add a filter to short-circuit wp_prepare_themes_for_js().
props mattwiebe, DrewAPicture.
fixes #31789.
Built from https://develop.svn.wordpress.org/trunk@31943


git-svn-id: http://core.svn.wordpress.org/trunk@31922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 20:04:25 +00:00
Sergey Biryukov
5fae37471a Media Library: Add a label for attachment type select in list mode.
props afercia.
fixes #31795.
Built from https://develop.svn.wordpress.org/trunk@31942


git-svn-id: http://core.svn.wordpress.org/trunk@31921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 19:57:26 +00:00
Sergey Biryukov
36643388ef Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.

fixes #28502.
Built from https://develop.svn.wordpress.org/trunk@31941


git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 18:45:28 +00:00
Dion Hulse
7e1e32909e Add some logic into wp_tempnam to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress.
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811

Built from https://develop.svn.wordpress.org/trunk@31936


git-svn-id: http://core.svn.wordpress.org/trunk@31915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:11:26 +00:00
Dominik Schilling
289db2d37b Customizer: Revert [31911]. We want to preserve url and return URL parameters to make the experience smoother.
see #31782.
Built from https://develop.svn.wordpress.org/trunk@31933


git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:22:26 +00:00
Sergey Biryukov
e70e4e74fa Press This: Use the error message returned by wp_update_post() instead of a generic one.
props stephdau.
fixes #31808.
Built from https://develop.svn.wordpress.org/trunk@31930


git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 14:39:26 +00:00
Sergey Biryukov
43a99e0f1b Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings.
props SergeyBiryukov, afercia, tyxla.
fixes #30766.
Built from https://develop.svn.wordpress.org/trunk@31928


git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 12:50:29 +00:00
Andrew Ozz
6cd9c9645e Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
Part props afercis, joedolson. Fixes #31575.
Built from https://develop.svn.wordpress.org/trunk@31925


git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:51 +00:00
Andrew Ozz
f663dc73d4 Press This: remove role="application" from the Categories list wrapper. This doesn't make it work better in screen readers.
See #31443.
Built from https://develop.svn.wordpress.org/trunk@31907


git-svn-id: http://core.svn.wordpress.org/trunk@31886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:49:32 +00:00
Dominik Schilling
8daaa09c9b Improve newly added strings for i18n:
* Add context to "Format" string.
* Use "Format" with context for "Post format".

see #31776.
Built from https://develop.svn.wordpress.org/trunk@31906


git-svn-id: http://core.svn.wordpress.org/trunk@31885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 21:19:26 +00:00
Aaron Jorbin
9b23faef07 Remove Shiny Plugin Installs
See #31773, #29820


Built from https://develop.svn.wordpress.org/trunk@31897


git-svn-id: http://core.svn.wordpress.org/trunk@31876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 02:30:28 +00:00
Boone Gorges
60c26865f9 Check that $_POST array index is set before comparing it in post_preview().
This prevents PHP notices in cases where a user with 'edit_others_posts' but
without 'publish_posts' previews another user's posts.

Props tyxla.
Fixes #31760.
Built from https://develop.svn.wordpress.org/trunk@31896


git-svn-id: http://core.svn.wordpress.org/trunk@31875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:45:26 +00:00
Andrew Ozz
6cc20e7095 Press This: on sites that support oEmbed, if the user has selected some text, quote it below the embed.
Props stephdau. Fixes #31763.
Built from https://develop.svn.wordpress.org/trunk@31894


git-svn-id: http://core.svn.wordpress.org/trunk@31873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 01:17:26 +00:00
Dominik Schilling
51854c53b4 Improve alignment of labels and inputs in Quick Edit.
props mattheu, valendesigns.
fixes #31408.
Built from https://develop.svn.wordpress.org/trunk@31890


git-svn-id: http://core.svn.wordpress.org/trunk@31869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:25:26 +00:00
Dominik Schilling
5ef13b688e Comments List: Don't let "Quick Edit" break on smaller screens.
Other class-wp-*-list-table.php files already contain a non-breaking space for the Quick Edit row action.

props kraftbj.
fixes #31482.
Built from https://develop.svn.wordpress.org/trunk@31889


git-svn-id: http://core.svn.wordpress.org/trunk@31868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 22:15:27 +00:00
Drew Jaynes
1ad0eaf416 Clean up DocBlock information and syntax for get_filesystem_method().
Props ericlewis, HarishChaudhari, valendesigns.
Fixes #31267.

Built from https://develop.svn.wordpress.org/trunk@31884


git-svn-id: http://core.svn.wordpress.org/trunk@31863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 16:32:28 +00:00
Dion Hulse
7b5ae90225 When altering the admin URL to reflect the canonical location, keep the existing hash (if present) in the URL.
Fixes #31758. See #23367

Built from https://develop.svn.wordpress.org/trunk@31882


git-svn-id: http://core.svn.wordpress.org/trunk@31861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 04:32:26 +00:00
Andrew Ozz
f5e6f92174 Do not output empty name and id HTML attributes in get_submit_button().
Props afercia. Fixes #31749.
Built from https://develop.svn.wordpress.org/trunk@31880


git-svn-id: http://core.svn.wordpress.org/trunk@31859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-25 03:23:27 +00:00
Sergey Biryukov
ce6c00f140 Fix a typo in [31872].
see #31738.
Built from https://develop.svn.wordpress.org/trunk@31873


git-svn-id: http://core.svn.wordpress.org/trunk@31852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 17:33:27 +00:00
Aaron Jorbin
9c409e31f2 Fill $plugins['upgrade'] with extra info for use in list table
Shiny updates depends upon information from the update_plugins site transient in order to set data- attributes which are used by JavaScript. Since /wp-admin/plugins.php?plugin_status=upgrade uses `$plugin['upgrade']` rather than `$plugins['all']`, we need to fill that information in both places.   

Fixes #31738.


Built from https://develop.svn.wordpress.org/trunk@31872


git-svn-id: http://core.svn.wordpress.org/trunk@31851 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 17:30:26 +00:00
Andrew Ozz
0329852941 Press This:
- Fix the links on inserted images to point to the source site.
- Fix inserting of images above the blockquote when the editor has not been focused.
Fixes #31745.
Built from https://develop.svn.wordpress.org/trunk@31868


git-svn-id: http://core.svn.wordpress.org/trunk@31847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-24 01:33:29 +00:00
Dion Hulse
3dc53770b7 Upgrader: When creating a temporary working directory, strip off .tmp as well as .zip incase we end up using that directory as the items main directory.
Fixes #30945

Built from https://develop.svn.wordpress.org/trunk@31863


git-svn-id: http://core.svn.wordpress.org/trunk@31842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 04:40:27 +00:00
Dion Hulse
cc903c3422 Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified.
* `H:i - 09:54`
* `g:i a - 9:54 am`
* `F j, Y - January 3, 2015`

These shouldn't be used without a/A (am/AM)
* `h:i - 01:23`
* `G:i - 1:23`

Props iseulde. Fixes #31121

Built from https://develop.svn.wordpress.org/trunk@31862


git-svn-id: http://core.svn.wordpress.org/trunk@31841 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-23 02:14:27 +00:00
Helen Hou-Sandí
bc54176af0 Media: Show filename instead of extension in the list table.
This helps differentiate between files with the same or similar image or icon. Extension shows as a part of the filename, and so is not separately needed anymore.

fixes #30943.

Built from https://develop.svn.wordpress.org/trunk@31857


git-svn-id: http://core.svn.wordpress.org/trunk@31836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-22 11:02:29 +00:00
Sergey Biryukov
42b9557137 Remove leading newlines from two translatable strings.
fixes #29480.
Built from https://develop.svn.wordpress.org/trunk@31844


git-svn-id: http://core.svn.wordpress.org/trunk@31826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 02:42:26 +00:00
Sergey Biryukov
e838ab315d After [31730], replace one more instance of array_shift() with reset() for better performance.
see #31259, #15459.
Built from https://develop.svn.wordpress.org/trunk@31841


git-svn-id: http://core.svn.wordpress.org/trunk@31823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 01:57:27 +00:00
Sergey Biryukov
b568da1997 Make a comment clearer (without implying inversed logic) and fix a typo.
see #31645.
Built from https://develop.svn.wordpress.org/trunk@31837


git-svn-id: http://core.svn.wordpress.org/trunk@31819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 00:45:27 +00:00
Andrew Ozz
1666eb5616 Press This: small clean-up when generating the suggested content. Ensure all keys are always set in the array that is passed through the filter.
See #31637.
Built from https://develop.svn.wordpress.org/trunk@31836


git-svn-id: http://core.svn.wordpress.org/trunk@31818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-20 00:18:26 +00:00
Aaron Jorbin
22476bf617 Fix notice that exists for plugins with no slug
Not all plugins have a slug, especially plugins not from the WordPress.org repository. 

Props imath for initial patch. 
Fixes #31694


Built from https://develop.svn.wordpress.org/trunk@31834


git-svn-id: http://core.svn.wordpress.org/trunk@31816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 17:48:29 +00:00
Jeremy Felt
a18118ed7c Make dates in multisite site and user list tables translatable.
Props pavelevap.

Fixes #22302.

Built from https://develop.svn.wordpress.org/trunk@31833


git-svn-id: http://core.svn.wordpress.org/trunk@31815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 16:22:28 +00:00
Aaron Jorbin
a836a32fb4 Ensure that we target the correct plugin row for update updates
The DOM traversal of the plugins list table was less than ideal. By switching to data attributes, we can better target the DOM elements we want to update.

Props ericlewis
Fixes #31621



Built from https://develop.svn.wordpress.org/trunk@31831


git-svn-id: http://core.svn.wordpress.org/trunk@31813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 05:26:28 +00:00
Scott Taylor
55fd3fa791 In the "Send Trackbacks" meta box, the description of how pingbacks work was missing a comma after the introductory clause.
Props cfinke.
Fixes #31668.

Built from https://develop.svn.wordpress.org/trunk@31830


git-svn-id: http://core.svn.wordpress.org/trunk@31812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 04:06:27 +00:00
Scott Taylor
bce851dcf2 Replace array_shift() with reset() where appropriate for performance.
Props SergeyBiryukov.
Fixes #31259.

Built from https://develop.svn.wordpress.org/trunk@31829


git-svn-id: http://core.svn.wordpress.org/trunk@31811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 03:56:27 +00:00
Scott Taylor
55ae3f9ea0 Add WP_Posts_List_Table::is_base_request() to determine if the current "view" is the "All" (default) view.
Fixes #24869.

Built from https://develop.svn.wordpress.org/trunk@31828


git-svn-id: http://core.svn.wordpress.org/trunk@31810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 02:26:26 +00:00
Andrew Ozz
40ebc2784f Press This: check if the URL is to embeddable content on a site that supports oEmbed. Then insert only the URL in the editor. It will trigger a wpView with the embedded content.
Fixes #31637.
Built from https://develop.svn.wordpress.org/trunk@31827


git-svn-id: http://core.svn.wordpress.org/trunk@31809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 00:52:26 +00:00
Andrew Ozz
4303ea5379 Press This: prepend the site domain to root-relative URLs. Reject other relative URLs.
Part props stephdau, kraftbj. Fixes #31645.
Built from https://develop.svn.wordpress.org/trunk@31818


git-svn-id: http://core.svn.wordpress.org/trunk@31800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 20:43:27 +00:00
Dominik Schilling
9b79c36713 WP_Filesystem: Change WP_Filesystem_FTPext::exists() and WP_Filesystem_ftpsockets::exists() to return true for empty directories.
Both methods are using *nlist() which returns a list of files in a given directory or the file itself for a given file. If the result was an empty list we assumed that the file doesn't exists. This includes also cases where $file is actually an empty directory. To prevent this we now check if $file is a directory before returning the result of an empty list.
Other filesystem methods are using `file_exists()` which already checks whether a file or directory exists.

fixes #30815.
Built from https://develop.svn.wordpress.org/trunk@31815


git-svn-id: http://core.svn.wordpress.org/trunk@31797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 19:22:27 +00:00
Aaron Jorbin
2d64637ff8 Request FTP and SSH credentials when needed during shiny updates
This is a restoration of [31749] which was reverted in [31755].

It includes a number of enhancements from the original version.  Namely:
 * Not doing a credential check in src/wp-includes/script-loader.php
 * Add new function `wp_print_request_filesystem_credentials_modal`
 * update the version number in the list table when a plugin is updated

UI still needs further work, but this basic version should enable more testing

Props ericlewis, jorbin
See #31528


Built from https://develop.svn.wordpress.org/trunk@31811


git-svn-id: http://core.svn.wordpress.org/trunk@31793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 03:18:27 +00:00
Andrew Ozz
f26a2e8113 Press This: ignore site descriptions that end with an ellipsis. These are most likely auto-generated.
Props kraftbj. Fixes #31639.
Built from https://develop.svn.wordpress.org/trunk@31810


git-svn-id: http://core.svn.wordpress.org/trunk@31792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:51:27 +00:00
Andrew Ozz
b00ae388c6 Press This: add aria-describedby to the new tag field.
Props afercia. Fixes #31546.
Built from https://develop.svn.wordpress.org/trunk@31808


git-svn-id: http://core.svn.wordpress.org/trunk@31790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:18:27 +00:00
Andrew Ozz
441e1e6ab9 Press This: fix the header styling and add a logo.
Props Michael-Arestad. Fixes #31472.
Built from https://develop.svn.wordpress.org/trunk@31807


git-svn-id: http://core.svn.wordpress.org/trunk@31789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 02:09:27 +00:00
Andrew Ozz
c04a1affd1 Press This: bump bookmarklet's version. See #31657.
Built from https://develop.svn.wordpress.org/trunk@31800


git-svn-id: http://core.svn.wordpress.org/trunk@31782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 01:19:27 +00:00
Andrew Ozz
9e1d17ad36 Press This:
- Strip slashes while running side_load_images(), add slashes after.
- Simplify and clean up side_load_images().
- Add another arg to media_sideload_image() to return the uploaded image src only, and fix it to always return WP_Error on errors.
Fixes #31660.
Built from https://develop.svn.wordpress.org/trunk@31799


git-svn-id: http://core.svn.wordpress.org/trunk@31781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 00:47:28 +00:00
Andrew Ozz
bf34e504dc Press This: change the Publish button text to Submit for Review for contributors (like on the Edit Post screen).
Props stephdau, DrewAPicture. Fixes #31658.
Built from https://develop.svn.wordpress.org/trunk@31798


git-svn-id: http://core.svn.wordpress.org/trunk@31780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 21:07:27 +00:00
Andrew Ozz
c1c29782c9 Press This:
- Test image sizes from JS after Press This loads, before adding them to  "Suggested media".
- Clean up and simplify the HTML and JS a bit.
Fixes #31561.
Built from https://develop.svn.wordpress.org/trunk@31797


git-svn-id: http://core.svn.wordpress.org/trunk@31779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-16 20:51:26 +00:00
Andrew Ozz
634df7e4a4 PressThis: add a wrapped with role = application to the categories section.
Props: afercia. See #31443.
Built from https://develop.svn.wordpress.org/trunk@31775


git-svn-id: http://core.svn.wordpress.org/trunk@31755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 23:41:27 +00:00
Andrew Ozz
805c530cf0 PressThis: simplify and restyle the categories drop-down, remove the checkboxes and use JS to get the selected categories on submitting the form.
Part prop: Michael-Arestad. Fixes #31443.
Built from https://develop.svn.wordpress.org/trunk@31765


git-svn-id: http://core.svn.wordpress.org/trunk@31745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-13 16:57:26 +00:00
Dominik Schilling
474f001c42 Revert [31749], see #31528.
Built from https://develop.svn.wordpress.org/trunk@31755


git-svn-id: http://core.svn.wordpress.org/trunk@31736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 17:51:26 +00:00
Sergey Biryukov
e8a600ac94 Shiny Updates: Don't translate an error code string.
props ericlewis.
fixes #31606.
Built from https://develop.svn.wordpress.org/trunk@31751


git-svn-id: http://core.svn.wordpress.org/trunk@31732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 13:09:27 +00:00
Aaron Jorbin
5b658df402 Request FTP and SSH credentials when needed during shiny updates
This is a first pass at requesting FTP and SSH credentials when needed during shiny updates. Styling and some UX improvements are still needed, but we do show the prompt and use the passed data when doing plugin installs and updates for shiny updates.  There are also a couple of areas that we could improve code wise such how we create the requestFilesystemCredentials part of the localized _wpUpdatesSettings. Over the past half century, we've split the atom, we've spliced the gene and we've roamed Tranquility Base. We've reached for the stars and never have we been closer to having them in our grasp. That has nothing to do with shiny updates. 

Props ericlewis, jorbin, and drewapicture for testing
Fixes #31528


Built from https://develop.svn.wordpress.org/trunk@31749


git-svn-id: http://core.svn.wordpress.org/trunk@31730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 08:53:26 +00:00
Helen Hou-Sandí
296dba2804 Nav menus: Return to calling links "Custom Links".
It was like this before 3.6 and got a bit lost during that development cycle. Also uses the terminology more consistently in the nav menu UI.

props tyxla.
fixes #31344.

Built from https://develop.svn.wordpress.org/trunk@31748


git-svn-id: http://core.svn.wordpress.org/trunk@31729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-12 06:15:27 +00:00
Andrew Ozz
1581ca7092 PressThis: add inline comments and some cleanup for the images and embeds regex.
Props stephdau. Fixes #31373.
Built from https://develop.svn.wordpress.org/trunk@31739


git-svn-id: http://core.svn.wordpress.org/trunk@31720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:37:28 +00:00
Andrew Ozz
ce297a7227 PressThis: update _limit_url(), use esc_url_raw(). Fixes checking of urlencoded strings.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31737


git-svn-id: http://core.svn.wordpress.org/trunk@31718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:23:25 +00:00
Dominik Schilling
4cc85f4da2 Administration: Remove single-use URL parameters and create canonical link based on new URL.
The default removable query args are 'message', 'settings-updated', 'saved', 'update', 'updated','activated', 'activate', 'deactivate', 'locked', 'deleted', 'trashed', 'untrashed', 'enabled', 'disabled', and 'skipped'. 

props morganestes.
fixes #23367.
Built from https://develop.svn.wordpress.org/trunk@31736


git-svn-id: http://core.svn.wordpress.org/trunk@31717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 23:09:26 +00:00
John Blackbourn
bb99536bf5 Introduce a new algorithm for displaying a hierarchical list of post objects in the WP_Posts_List_Table. This reduces processing time, reduces database queries, and substantially reduces memory use on sites with a high number of Pages.
Props nofearinc, rodrigosprimo, nacin, johnbillion.
Fixes #15459

Built from https://develop.svn.wordpress.org/trunk@31730


git-svn-id: http://core.svn.wordpress.org/trunk@31711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 20:46:27 +00:00
Dominik Schilling
50c2cee32d Merge three similar strings.
props pavelevap.
see #31013.
Built from https://develop.svn.wordpress.org/trunk@31717


git-svn-id: http://core.svn.wordpress.org/trunk@31698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 15:25:28 +00:00
Dominik Schilling
13ad2d4e16 Screen Options: Improve items per page option label.
Previously the label just said "Posts", "Pages", or "Comments". This was bad in terms of accessibility and internationalization because of missing context.
This change adds a default label "Number of items per page:" to `WP_Screen->render_per_page_options()` and removes all the existing one-word labels.

props afercia.
fixes #31349, #15576.
Built from https://develop.svn.wordpress.org/trunk@31696


git-svn-id: http://core.svn.wordpress.org/trunk@31677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 15:32:27 +00:00
Sergey Biryukov
19f1d4f402 EXIF/IPTC captions should populate Caption (post_excerpt) on upload, not Description (post_content).
Make sure the caption is always set if found. Previously, if the caption was less than 80 characters, only the Title field would be set.

props beaulebens, ericlewis, bendoh, SergeyBiryukov.
fixes #22768.
Built from https://develop.svn.wordpress.org/trunk@31694


git-svn-id: http://core.svn.wordpress.org/trunk@31675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 05:07:28 +00:00
Andrew Ozz
be24bc3a97 PressThis:
- Filter and select the content on the PHP side. Then pass only the needed data to JS.
- Add the suggested post title and contend directly to the HTML.
- Standardise the data type names.
- Some cleanup/reduction of the code in the bookmarklet.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31693


git-svn-id: http://core.svn.wordpress.org/trunk@31674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 21:49:28 +00:00
Dion Hulse
8a9181d8d4 SSH2 Upgrade transport: Trim the trailing newline character from the ouput of pwd to avoid a PHP Segfault.
Fixes #30802 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31686


git-svn-id: http://core.svn.wordpress.org/trunk@31667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 04:32:27 +00:00
Scott Taylor
0ec87e4584 There are a few functions that have the ability to return false instead of a string, so the return value should be checked before being passed to functions that expect string.
These are trivial, but they clear out some Scrutinizer issues.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31681


git-svn-id: http://core.svn.wordpress.org/trunk@31662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 02:11:28 +00:00
Scott Taylor
dccf5ceb90 Empty return statements are unnecessary at the end of functions.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31679


git-svn-id: http://core.svn.wordpress.org/trunk@31660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 23:09:27 +00:00
Scott Taylor
c1cab11ceb Use $this-> instead of parent:: when calling tablenav() in WP_Theme_Install_List_Table.
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31672


git-svn-id: http://core.svn.wordpress.org/trunk@31653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 23:03:27 +00:00
Andrew Ozz
be207e6550 PressThis: make the Preview button "subtle".
See #31458.
Built from https://develop.svn.wordpress.org/trunk@31655


git-svn-id: http://core.svn.wordpress.org/trunk@31636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 01:50:26 +00:00
Andrew Ozz
9716d171c7 PressThis: add preview functionality. Opens the preview in a new window or a tab next to the source tab.
Fixes #31458.
Built from https://develop.svn.wordpress.org/trunk@31654


git-svn-id: http://core.svn.wordpress.org/trunk@31635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-07 01:17:26 +00:00
Andrew Ozz
a27967aa05 PressThis:
- Close the sidebar on moving the focus outside of it (by clicking or by "tabbing").
- Fix a (weird) structural CSS problem where clicks go through the sidebar when it is open.
- Clean up the JS a bit.
Fixes #31457.
Built from https://develop.svn.wordpress.org/trunk@31651


git-svn-id: http://core.svn.wordpress.org/trunk@31632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 22:57:26 +00:00
Scott Taylor
8f0b626d13 Introduce a function, wp_attachment_is( $type, $post = 0 ), to collapse the logic for determining whether an attachment is an image, audio, or video.
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.

Built from https://develop.svn.wordpress.org/trunk@31645


git-svn-id: http://core.svn.wordpress.org/trunk@31626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 20:26:26 +00:00
Andrew Ozz
5abac389fa PressThis: when server-side parsing, filter small images by the width and height attributes if set.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31637


git-svn-id: http://core.svn.wordpress.org/trunk@31618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 02:03:27 +00:00
Andrew Ozz
bcad925af4 PressThis:
- Fix error when checking for empty array keys.
- Add better DailyMotion embed support.
Props stephdau, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31635


git-svn-id: http://core.svn.wordpress.org/trunk@31616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 01:17:24 +00:00
Scott Taylor
da7359b060 After [31620], when checking for HTTP URLs, make sure we are checking the shortcode body instead of an indexed attribute.
See #31139.

Built from https://develop.svn.wordpress.org/trunk@31626


git-svn-id: http://core.svn.wordpress.org/trunk@31607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 16:26:25 +00:00
Scott Taylor
f9c138b4c4 detached affects the wp() call for the media list table, so switch our new $_GET key to detach.
See #6820.

Built from https://develop.svn.wordpress.org/trunk@31624


git-svn-id: http://core.svn.wordpress.org/trunk@31605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 15:59:27 +00:00
Scott Taylor
cc953717b7 Allow inline editing of width and height parameters while previewing an embed in the media modal:
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* Allow a URL to transition to a shortcode (and vice versa) when returning an embed to TinyMCE
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

This is a first pass to allow broad testing with recent MCE view changes. 

See #31139.

Built from https://develop.svn.wordpress.org/trunk@31620


git-svn-id: http://core.svn.wordpress.org/trunk@31601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 06:00:26 +00:00
Scott Taylor
d3471e9850 Allow attachments to be Detached from their parent in media grid and list modes.
See #6820.

Built from https://develop.svn.wordpress.org/trunk@31619


git-svn-id: http://core.svn.wordpress.org/trunk@31600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 05:35:28 +00:00
Helen Hou-Sandí
df08581656 List tables: Display front and posts page indicators.
fixes #30190.

Built from https://develop.svn.wordpress.org/trunk@31610


git-svn-id: http://core.svn.wordpress.org/trunk@31591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 19:45:25 +00:00
Andrew Ozz
f53199487d PressThis:
- Improve handling of the data, both from the bookmarklet and from server-side parsing.
- Standardize on processing the data in PHP and remove duplicate code from JS.
- Improve the bookmarklet code and remove pre-filtering of the data.
Part props stephdau, see #31373.
Built from https://develop.svn.wordpress.org/trunk@31609


git-svn-id: http://core.svn.wordpress.org/trunk@31590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-04 19:29:25 +00:00
Helen Hou-Sandí
513a038159 Remove the once-placeholder-esque "tag hint", which has not worked in quite some time.
It's not particularly useful, and adds visual noise when in place.

props welcher.
fixes #31485.

Built from https://develop.svn.wordpress.org/trunk@31607


git-svn-id: http://core.svn.wordpress.org/trunk@31588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:53:25 +00:00
Helen Hou-Sandí
5567d03278 Nav menus: Better JS performance on initial load of edit screen.
The accessibility helpers previously processed all items when editing a menu, which was quite slow to the point of being unresponsive for large menus. They now only process items when they are expanded or a user comes near them in some way, such as hover or focus.

Also simplifies a redundant set of click event handlers down to one, which further enhances performance.

props atimmer, sevenspark.
fixes #25698.

Built from https://develop.svn.wordpress.org/trunk@31604


git-svn-id: http://core.svn.wordpress.org/trunk@31585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-03 21:14:25 +00:00
Andrew Ozz
a9f165915f Press This:
- Remove classes from suggested HTML for the editor.
- Improve the filter, pass an associative array as param.
- Use <em> instead of <cite>.
Props Michael-Arestad, kraftbj. Fixes #31493.
Built from https://develop.svn.wordpress.org/trunk@31601


git-svn-id: http://core.svn.wordpress.org/trunk@31582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 23:41:27 +00:00
Drew Jaynes
0b3c3092fc Clean up and refine DocBlocks for a variety of functions and methods in wp-admin/includes/template.php.
* Also documents the default arguments of `wp_terms_checklist()` as a hash notation.

Props ipm-frommen, DrewAPicture.
Fixes #31248.

Built from https://develop.svn.wordpress.org/trunk@31599


git-svn-id: http://core.svn.wordpress.org/trunk@31580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 06:11:40 +00:00
Andrew Ozz
c22307fd9a PressThis: make sure buttons.css is loaded before press-this.css. Use (int) $post_ID instead of $post->ID.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31597


git-svn-id: http://core.svn.wordpress.org/trunk@31578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-02 00:58:25 +00:00
Andrew Ozz
3a124ac2f4 PressThis:
- Replace all `%1$s` and `%2$s` in suggestedHTML in case plugins repeat them.
- Fix docs typo, props kraftbj.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31596


git-svn-id: http://core.svn.wordpress.org/trunk@31577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 23:28:26 +00:00
Andrew Ozz
4e8138cea5 PressThis:
- Simplify `getSuggestedContent()` and helpers. No need to override the global `data`.
- Replace the `press_this_source_string` and `press_this_source_link` filters with `press_this_suggested_html` that allows filtering of the link and the wrapper HTML tags.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31595


git-svn-id: http://core.svn.wordpress.org/trunk@31576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 22:44:25 +00:00
Drew Jaynes
a337c34c4e Fix a typo in the $args parameter hash notation description for add_settings_field().
See #28975, [31592].

Built from https://develop.svn.wordpress.org/trunk@31593


git-svn-id: http://core.svn.wordpress.org/trunk@31574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 07:57:32 +00:00
Drew Jaynes
82fd5e33dd Add a hash notation for the optional $args parameter in add_settings_field(), which includes a description for the new $class argument added in [31560].
Also adds a changelog entry to `add_settings_field()` DocBlock for the new `$class` argument.

See [31560].
Fixes #28975.

Built from https://develop.svn.wordpress.org/trunk@31592


git-svn-id: http://core.svn.wordpress.org/trunk@31573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-01 07:53:25 +00:00
Andrew Ozz
8164f8fe0e PressThis:
- Remove unneeded passing of post formats strings to JS.
- Set the currently selected post format name with jQuery.
See #31373.
Built from https://develop.svn.wordpress.org/trunk@31589


git-svn-id: http://core.svn.wordpress.org/trunk@31570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-28 20:08:27 +00:00
Dominik Schilling
8ecb7f5d1e Press This: Backwards compatibility enhancements.
* Add missing actions for printing styles/scripts.
* Since `$hook_suffix` is null, hardcode `press-this.php`.
* Restore body classes, add filter.
* Use boolean value instead of `__return_false()`.
* Use `wp_json_encode()`.
* Update docs for filters in script-loader.php.
* Make `<a href="%1$s">%2$s</a>` not translatable.

see #31373.
Built from https://develop.svn.wordpress.org/trunk@31588


git-svn-id: http://core.svn.wordpress.org/trunk@31569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-28 10:36:25 +00:00
Dominik Schilling
c7dba8b015 Press This: RTL improvements.
* Load the RTL version of press-this-editor.css.
* Use more semantic class names for the arrows, Makes it easier to swap the arrows in RTL, see #31478.

see #31474.
Built from https://develop.svn.wordpress.org/trunk@31577


git-svn-id: http://core.svn.wordpress.org/trunk@31558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 19:44:24 +00:00
Scott Taylor
f6b1b01ecd Make a new function, wp_delete_file(). Use it.
Props scribu, wonderboymusic.
Fixes #17864.

Built from https://develop.svn.wordpress.org/trunk@31575


git-svn-id: http://core.svn.wordpress.org/trunk@31556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 16:51:25 +00:00
Dominik Schilling
5e47a1f633 Press This: Use boolean value instead of __return_true(). Add missing hook docs.
see #31373.
Built from https://develop.svn.wordpress.org/trunk@31571


git-svn-id: http://core.svn.wordpress.org/trunk@31552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 11:15:25 +00:00
Andrew Ozz
4593319ea7 PressThis: accessibility enhancements:
- Add missing form labels.
- Add some screen-reader-text and aria-hidden attributes.
- Focus handling improvements.
- Change tagcloud-link into a button.
- Add missing ID attribute in tools.php.
Props afercia. Fixes #31449.
Built from https://develop.svn.wordpress.org/trunk@31566


git-svn-id: http://core.svn.wordpress.org/trunk@31547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-27 02:50:25 +00:00