Scott Taylor
786caa4d55
Correct the @param
docs for arguments that are truthy/falsey.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30983
git-svn-id: http://core.svn.wordpress.org/trunk@30969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 23:04:23 +00:00
Scott Taylor
5eb5afac34
For clarity, initialize some arrays that previously were only assigned via short circuit in loops.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30982
git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:47:22 +00:00
Scott Taylor
2dbd0d0a8f
In image_size_input_fields()
:
...
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30981
git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:19:24 +00:00
Scott Taylor
f19bec8754
In wp_import_handle_upload()
:
...
`$file` was essentially getting declared/overwritten 3 times. In lieu of this, return an array containing the error immediately instead of doing a short-circuit array key assignment on error. Rename the local variable to `$upload` and use its properties instead of creating 3 new local vars, one of which stomped the array.
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30980
git-svn-id: http://core.svn.wordpress.org/trunk@30966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 21:10:24 +00:00
Scott Taylor
42f5acd869
Improve some docs for @param
. Remove an unneeded $wpdb
global import.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30979
git-svn-id: http://core.svn.wordpress.org/trunk@30965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:56:22 +00:00
Scott Taylor
574fabf2bc
Improve some wp-admin/includes/class-wp-filesystem-*.php
docs for @param
.
...
See #30799 .
Built from https://develop.svn.wordpress.org/trunk@30978
git-svn-id: http://core.svn.wordpress.org/trunk@30964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 20:40:23 +00:00
Dominik Schilling
eccd5a5eda
Pass locale to wordpress.org theme/plugin API.
...
In the future this will be used to return localized plugin/theme info.
see #30735 .
Built from https://develop.svn.wordpress.org/trunk@30944
git-svn-id: http://core.svn.wordpress.org/trunk@30933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 22:39:22 +00:00
Andrew Nacin
8c3027c3c7
Call it 'Distraction-free writing mode' and update the help string. fixes #30657 .
...
Built from https://develop.svn.wordpress.org/trunk@30890
git-svn-id: http://core.svn.wordpress.org/trunk@30880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:07:23 +00:00
Andrew Nacin
7b015d507d
Update/add plugin recommendation strings.
...
Update [30887], add a translation function to the Vine string.
fixes #30337 . see #30435 .
Built from https://develop.svn.wordpress.org/trunk@30889
git-svn-id: http://core.svn.wordpress.org/trunk@30879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 10:06:24 +00:00
Andrew Nacin
23f4b0f62f
Updates to the 'Log out everywhere' implementation.
...
* Include a message and a disabled button when you're only logged in at one location.
* Avoid leaking the session token in HTML.
* Simplify, simplify, simplify.
see #30264 .
Built from https://develop.svn.wordpress.org/trunk@30888
git-svn-id: http://core.svn.wordpress.org/trunk@30878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 09:15:23 +00:00
Dion Hulse
5661464d35
Background Updates: Pass back whether Group Writable support is being leveraged for an update to the WordPress.org API.
...
See #30245
Built from https://develop.svn.wordpress.org/trunk@30860
git-svn-id: http://core.svn.wordpress.org/trunk@30850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 14:08:23 +00:00
Andrew Nacin
180c596d7b
Rename _wp_clear_update_cache() to wp_clean_update_cache().
...
This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."
wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.
see #30369 .
Built from https://develop.svn.wordpress.org/trunk@30856
git-svn-id: http://core.svn.wordpress.org/trunk@30846 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 08:55:22 +00:00
Andrew Ozz
bb67aa9d5a
Improve text for the DFW admin pointer. Remove the concatenation.
...
Props kpdesign, ianmjones.
See #30671 .
Built from https://develop.svn.wordpress.org/trunk@30837
git-svn-id: http://core.svn.wordpress.org/trunk@30827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-12 22:12:22 +00:00
Andrew Ozz
0aa0016488
Fix the search field width in the media modal, media library grid and on the install new plugins screen. Props helen, fixes #30658 .
...
Built from https://develop.svn.wordpress.org/trunk@30813
git-svn-id: http://core.svn.wordpress.org/trunk@30803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-11 04:12:23 +00:00
Sergey Biryukov
0ef8e683f2
Revert [28948], which caused a regression.
...
see #29573 for trunk. see #28350 .
Built from https://develop.svn.wordpress.org/trunk@30791
git-svn-id: http://core.svn.wordpress.org/trunk@30781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-08 21:14:23 +00:00
Andrew Ozz
a445806c6f
Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337 .
...
Built from https://develop.svn.wordpress.org/trunk@30782
git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 23:40:24 +00:00
Andrew Ozz
ef0501e1bc
Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade()
. Props DrewAPicture. Fixes #29088 .
...
Built from https://develop.svn.wordpress.org/trunk@30762
git-svn-id: http://core.svn.wordpress.org/trunk@30752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 01:19:24 +00:00
Andrew Ozz
1bb4b6a82b
Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade()
. Props jdgrimes. Fixes #29088 .
...
Built from https://develop.svn.wordpress.org/trunk@30761
git-svn-id: http://core.svn.wordpress.org/trunk@30751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:53:23 +00:00
Drew Jaynes
473ebca2af
Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader
, Plugin_Upgrader
, Theme_Upgrader
, Language_Pack_Upgrader
, Core_Upgrader
, and File_upload_Upgrader
.
...
Props jdgrimes, DrewAPicture.
See #29086 .
Built from https://develop.svn.wordpress.org/trunk@30758
git-svn-id: http://core.svn.wordpress.org/trunk@30748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 00:26:22 +00:00
Drew Jaynes
cc4ac906dc
Fix a typo in the return description for get_sample_permalink()
.
...
Props TobiasBg.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30755
git-svn-id: http://core.svn.wordpress.org/trunk@30745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:46:23 +00:00
John Blackbourn
bdd00b3902
Improve various hook and filter docs so they are correctly parsed for the code reference.
...
Fixes #30558
Props DrewAPicture
Built from https://develop.svn.wordpress.org/trunk@30754
git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:32:24 +00:00
Drew Jaynes
23707b1ada
Convert various uses of (optional)
in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP.
...
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.
Props coffee2code.
Fixes #30591 .
Built from https://develop.svn.wordpress.org/trunk@30753
git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-06 21:24:45 +00:00
Andrew Nacin
1cf7a49ffd
Adjust [29806] and revert [29807] to restore placeholder and email copy order.
...
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.
fixes #21089 .
Built from https://develop.svn.wordpress.org/trunk@30742
git-svn-id: http://core.svn.wordpress.org/trunk@30732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-05 01:15:26 +00:00
John Blackbourn
543f408098
Correct the default value of the show_split_view
argument for revisions so they are correctly displayed side by side ins
...
tead of inline.
Fixes #24908
Built from https://develop.svn.wordpress.org/trunk@30739
git-svn-id: http://core.svn.wordpress.org/trunk@30729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 14:36:24 +00:00
Andrew Ozz
1bb20da03b
Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557 .
...
Built from https://develop.svn.wordpress.org/trunk@30734
git-svn-id: http://core.svn.wordpress.org/trunk@30724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 22:00:29 +00:00
Andrew Ozz
5299e95360
Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30730
git-svn-id: http://core.svn.wordpress.org/trunk@30720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 18:18:23 +00:00
Drew Jaynes
8df7115760
Use the correct hash notation syntax for the WP_Filesystem_Base::dirlist()
DocBlock.
...
See #28298 .
Built from https://develop.svn.wordpress.org/trunk@30722
git-svn-id: http://core.svn.wordpress.org/trunk@30712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-03 10:11:22 +00:00
Andrew Ozz
04c2e80c03
Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557 .
...
Built from https://develop.svn.wordpress.org/trunk@30718
git-svn-id: http://core.svn.wordpress.org/trunk@30708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 23:23:23 +00:00
Andrew Ozz
71d0c1c977
Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30717
git-svn-id: http://core.svn.wordpress.org/trunk@30707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 23:11:24 +00:00
Andrew Ozz
f1dcfa9712
Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568 .
...
Built from https://develop.svn.wordpress.org/trunk@30711
git-svn-id: http://core.svn.wordpress.org/trunk@30701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 20:40:22 +00:00
Drew Jaynes
c4b9da857a
Using let's properly in inline comments lets us move on to more pressing matters of inline documentation.
...
Props trepmal.
Fixes #30570 .
Built from https://develop.svn.wordpress.org/trunk@30703
git-svn-id: http://core.svn.wordpress.org/trunk@30693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 04:43:22 +00:00
John Blackbourn
6fcf4ed3c5
Prevent the deletion of a theme while it has an active child theme.
...
Fixes #29580
Props karpstrucking, jesin
Built from https://develop.svn.wordpress.org/trunk@30697
git-svn-id: http://core.svn.wordpress.org/trunk@30687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 02:21:24 +00:00
Drew Jaynes
ad297dab6d
Correctly capitalize JavaScript throughout core docs.
...
Fixes #30569 .
Built from https://develop.svn.wordpress.org/trunk@30695
git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 00:31:22 +00:00
Scott Taylor
37a23b2c73
Improve various @param
docs.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30682
git-svn-id: http://core.svn.wordpress.org/trunk@30672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 02:17:21 +00:00
Scott Taylor
2c32752abd
Improve various @param
docs for src/wp-admin/*
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30680
git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 01:00:22 +00:00
Scott Taylor
65ab522a51
Improve various @param
docs for List Tables.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30679
git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 00:33:23 +00:00
Scott Taylor
da4c39480f
Improve various @param
docs for src/wp-admin/includes/class-wp-filesystem-*.php
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30678
git-svn-id: http://core.svn.wordpress.org/trunk@30668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 00:13:22 +00:00
Scott Taylor
67417897ec
Improve the @param
docs for src/wp-admin/includes/plugin.php
.
...
See #30224 .
Built from https://develop.svn.wordpress.org/trunk@30668
git-svn-id: http://core.svn.wordpress.org/trunk@30658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 22:23:23 +00:00
Scott Taylor
562ddb8316
Use sanitize_mime_type()
instead of urlencode()
when string-building <option>
values in ->get_views()
for media list tables.
...
`urlencode()` was introduced in [28553] via _duck and yours truly.
Got weirder after [29625].
Props birgire.
Fixes #30123 .
Built from https://develop.svn.wordpress.org/trunk@30661
git-svn-id: http://core.svn.wordpress.org/trunk@30651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 20:23:23 +00:00
Drew Jaynes
78bb3e5ff5
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
...
Also adds a few inline `@see` cross-references as they apply.
Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30648
git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:28:24 +00:00
Drew Jaynes
3ceb75bd8e
Specify a type (array) for the $post_data
parameter in the DocBlock for wp_autosave()
.
...
Props tillkruess.
See #30508 .
Built from https://develop.svn.wordpress.org/trunk@30645
git-svn-id: http://core.svn.wordpress.org/trunk@30635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 10:01:23 +00:00
Drew Jaynes
e4425165ff
Improve the inline documentation for image_edit_apply_changes()
.
...
Including:
* Add a correct type (array) for the `$changes` parameter
* Add the `@since` version
* Add proper descriptions for both parameters and the return value.
Props tillkruess for the initial patch.
See #30508 .
Built from https://develop.svn.wordpress.org/trunk@30644
git-svn-id: http://core.svn.wordpress.org/trunk@30634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 09:59:22 +00:00
Andrew Ozz
760e3e5fbd
Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass $post_type
in the wp_editor_expand
filter. See #30458 .
...
Built from https://develop.svn.wordpress.org/trunk@30641
git-svn-id: http://core.svn.wordpress.org/trunk@30631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 06:37:21 +00:00
Drew Jaynes
bb380687fa
Add missing DocBlocks for several functions in wp-admin/includes/ms.php.
...
Props dustyf.
See #30483 .
Built from https://develop.svn.wordpress.org/trunk@30630
git-svn-id: http://core.svn.wordpress.org/trunk@30620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 05:06:23 +00:00
Drew Jaynes
3699ea4155
Use the correct type (integer) for the $menu_id
parameter in the wp_get_nav_menu_to_edit()
DocBlock.
...
Also properly mark the parameter as optional and specify the default value.
Props jaimieolmstead for the initial patch.
Fixes #30540 .
Built from https://develop.svn.wordpress.org/trunk@30627
git-svn-id: http://core.svn.wordpress.org/trunk@30617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 04:25:23 +00:00
Boone Gorges
c6e752b063
In get_default_post_to_edit()
, let 'post_name' be passed to filter.
...
Previously, it was being overridden after the default post had been inserted
into the database, making it cumbersome to override with the 'wp_insert_post_data'
filter.
Props danielbachhuber.
Fixes #29847 .
Built from https://develop.svn.wordpress.org/trunk@30626
git-svn-id: http://core.svn.wordpress.org/trunk@30616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-29 19:26:23 +00:00
Drew Jaynes
4432dc752b
4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30610
git-svn-id: http://core.svn.wordpress.org/trunk@30600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 11:22:23 +00:00
Drew Jaynes
659413eb98
4.1 Docs Audit: Document the $post
global in the DocBlock for wp_print_revision_templates()
.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30602
git-svn-id: http://core.svn.wordpress.org/trunk@30592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 09:05:23 +00:00
Drew Jaynes
da589fc375
4.1 Docs Audit: Fix a variety of issues with the DocBlock for the default_page_template_title
filter.
...
Includes hyphenating 'drop-down', ensuring the DocBlock itself is correctly indented, and wraps lines at an appropriate length.
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30601
git-svn-id: http://core.svn.wordpress.org/trunk@30591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 09:00:24 +00:00
Drew Jaynes
5212725fbe
4.1 Docs Audit: Convert a hook reference to an inline @see
tag in the hook docs for the image_add_caption_text
filter.
...
See #30469 .
Built from https://develop.svn.wordpress.org/trunk@30600
git-svn-id: http://core.svn.wordpress.org/trunk@30590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:56:24 +00:00