Commit Graph

28553 Commits

Author SHA1 Message Date
Sergey Biryukov
764a1761aa Site Health: Correct markup in ::get_test_php_extensions() and ::get_test_background_updates() description.
These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag.

Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests.

Props afercia.
See #48948.
Built from https://develop.svn.wordpress.org/trunk@47528


git-svn-id: http://core.svn.wordpress.org/trunk@47303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-29 03:46:06 +00:00
Sergey Biryukov
d552e475fd Site Health: Add pretty links support information to debug data.
Props valentinbora, afragen.
Fixes #49422.
Built from https://develop.svn.wordpress.org/trunk@47527


git-svn-id: http://core.svn.wordpress.org/trunk@47302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-28 21:20:06 +00:00
John Blackbourn
8f1eddef11 Comments: Ensure all elements in the array returned by get_comment_count() are integers.
Previously elements would be a mixture of strings and integers depending on their numeric value.

Props progremzion, m.usama.masood

Fixes #48093
Built from https://develop.svn.wordpress.org/trunk@47526


git-svn-id: http://core.svn.wordpress.org/trunk@47301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-28 20:44:09 +00:00
Sergey Biryukov
ce2dea9ef6 Help/About: Improve accessibility of the 5.4 About page:
* Remove vertical text and unnecessary italics.
* Update H1 headings on About, Credits, Freedoms, Privacy pages to be unique to each page.

Props sabernhardt, ryelle, melchoyce, karmatosed, audrasjb, afercia, davidbaumwald, SergeyBiryukov.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47521


git-svn-id: http://core.svn.wordpress.org/trunk@47296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 23:41:06 +00:00
Sergey Biryukov
a546a9c35c Coding Standards: Remove some extra tabs in wp-admin/user-new.php.
Follow-up to [47516], [47519].

See #38665.
Built from https://develop.svn.wordpress.org/trunk@47520


git-svn-id: http://core.svn.wordpress.org/trunk@47295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:30:09 +00:00
Sergey Biryukov
ee1bf5a911 Coding Standards: Fix WPCS issues in [47516].
See #38665.
Built from https://develop.svn.wordpress.org/trunk@47519


git-svn-id: http://core.svn.wordpress.org/trunk@47294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:25:08 +00:00
jorgefilipecosta
0a2dad400d Block Editor: Update WordPress Packages WordPress 5.4 RC 5 Take 2.
The following package versions were changed:
@wordpress/edit-post: 3.13.8 -> 3.13.9
Includes PR https://github.com/WordPress/gutenberg/pull/21220

Props aduth, mapk, ItsJonQ.
Fixes: #49717.
Built from https://develop.svn.wordpress.org/trunk@47517


git-svn-id: http://core.svn.wordpress.org/trunk@47292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:08:24 +00:00
John Blackbourn
41ae74f7b4 Users: Add a user language preference option to the "Add New User" form.
This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language.

Props barryceelen, johnbillion

Fixes #38665
Built from https://develop.svn.wordpress.org/trunk@47516


git-svn-id: http://core.svn.wordpress.org/trunk@47291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 21:58:05 +00:00
Sergey Biryukov
38e37b83df Site Health: Remove esc_url() used on "Debugging in WordPress" article URL in WP_Fatal_Error_Handler::display_default_error_template().
The function may not be available in some contexts, for example if a fatal error happens in `advanced-cache.php` drop-in.

Props rob006.
Fixes #49709.
Built from https://develop.svn.wordpress.org/trunk@47515


git-svn-id: http://core.svn.wordpress.org/trunk@47290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 18:22:06 +00:00
jorgefilipecosta
b9ef707d7d Block Editor: Update WordPress Packages WordPress 5.4 RC 5.
The following package versions were changed:
@wordpress/annotations: 1.12.2 -> 1.12.3
@wordpress/block-directory: 1.5.6 -> 1.5.7
@wordpress/block-editor: 3.7.6 -> 3.7.7
@wordpress/block-library: 2.14.6 -> 2.14.7
@wordpress/blocks: 6.12.2 -> 6.12.3
@wordpress/components: 9.2.5 -> 9.2.6
@wordpress/core-data: 2.12.2 -> 2.12.3
@wordpress/edit-post: 3.13.7 -> 3.13.8
@wordpress/editor: 9.12.6 -> 9.12.7
@wordpress/format-library: 1.14.6 -> 1.14.7
@wordpress/list-reusable-blocks: 1.13.5 -> 1.13.6
@wordpress/nux: 3.12.5 -> 3.12.6
@wordpress/server-side-render: 1.8.5 -> 1.8.6
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21210.

Props mcsf, aduth.
Fixes: #49716.
Built from https://develop.svn.wordpress.org/trunk@47513


git-svn-id: http://core.svn.wordpress.org/trunk@47288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 18:10:36 +00:00
Sergey Biryukov
f4f1184deb Build/Test Tools: Update QUnit and Sinon to the latest versions.
Update JS tests per the QUnit 2.x Upgrade Guide.

Fixes #37117.
Built from https://develop.svn.wordpress.org/trunk@47512


git-svn-id: http://core.svn.wordpress.org/trunk@47287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 00:18:22 +00:00
K. Adam White
58d5aad2a3 REST API: Fix _fields filtering of registered rest fields.
Use rest_is_field_included when determining which additional fields to include to permit filtering by nested field properties.

Props Dudo, kadamwhite, TimothyBlynJacobs.
Fixes #49648.

Built from https://develop.svn.wordpress.org/trunk@47511


git-svn-id: http://core.svn.wordpress.org/trunk@47286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-26 17:52:16 +00:00
John Blackbourn
7dbad241cb Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area.
This prevents broken themes being hidden when the `DISALLOW_FILE_MODS` constant is in use.

Props rebasaurus

Fixes #49268
Built from https://develop.svn.wordpress.org/trunk@47510


git-svn-id: http://core.svn.wordpress.org/trunk@47285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-26 17:50:15 +00:00
John Blackbourn
33d4f0573c Query: Introduce an action which gets fired when a 404 is triggered.
Fixes #48061
Built from https://develop.svn.wordpress.org/trunk@47509


git-svn-id: http://core.svn.wordpress.org/trunk@47284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-26 17:43:07 +00:00
Sergey Biryukov
b9869da157 Coding Standards: Fix WPCS issues in wp-includes/class-wp-http-proxy.php.
Props thrijith, mukesh27.
Fixes #46784.
Built from https://develop.svn.wordpress.org/trunk@47508


git-svn-id: http://core.svn.wordpress.org/trunk@47283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-26 07:20:10 +00:00
Sergey Biryukov
2b030a1647 Docs: Add documentation for WP_Comments_List_Table::floated_admin_avatar().
Props akbarhusen, ayeshrajans, Soean, ajayghaghretiya1, netweb, SergeyBiryukov.
Fixes #41491.
Built from https://develop.svn.wordpress.org/trunk@47507


git-svn-id: http://core.svn.wordpress.org/trunk@47282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-25 14:43:11 +00:00
noisysocks
b4e1e8f0d1 Comments: Fix title not updating when replying to a comment
When replying to an existing comment, the comment form is moved to below the
existing comment with JS, but the form heading was not being updated. This
fixes the issue by introducing a new data-attribute to the reply link with the
correct heading string, and applying that string to the heading when the form
is moved.

Props isabel_brison, azaozz, peterwilsoncc.
Fixes #38009.

Built from https://develop.svn.wordpress.org/trunk@47506


git-svn-id: http://core.svn.wordpress.org/trunk@47281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-25 04:55:10 +00:00
Sergey Biryukov
55482506a3 Docs: Revert a type change for the $value parameter of WP_Dependencies::add_data() in [47170].
Although described as a string in several places, it's technically not limited to a particular type.

Props westonruter.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47502


git-svn-id: http://core.svn.wordpress.org/trunk@47277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-24 20:56:09 +00:00
jorgefilipecosta
26cc999d64 Help/About: Fix a typo on the about page and fix a link.
The text "on your" appeared two times. This commit fixes the issue and removes the duplication. It also updates the field guide permalink.

Props garrett-eclipse, ixkaito, karmatosed, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47500


git-svn-id: http://core.svn.wordpress.org/trunk@47275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-24 15:03:08 +00:00
Sergey Biryukov
c4a852af51 Docs: Update inline comment in Tests_DB::test_locale_floats().
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47498


git-svn-id: http://core.svn.wordpress.org/trunk@47273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-24 01:08:06 +00:00
Andrew Ozz
e3b3b5c1b7 Build/Test Tools: Introduce Install-changed. It keeps a hash of package.json and compares it when run. If it has any changes, it runs npm install.
This keeps `node_modules` always updated and is useful not only when the packages have been updated, but also when the working copy has been "reverted" to an earlier revision.

Fixes #49594.
Built from https://develop.svn.wordpress.org/trunk@47497


git-svn-id: http://core.svn.wordpress.org/trunk@47272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-24 01:06:34 +00:00
Andrew Ozz
6ea351bed7 Build/Test Tools: Fix PHPUnit bootstrap to install WP from /build when tests are run with npm run test, grunt test, grunt then phpunit, etc.
Fixes #49663.
Built from https://develop.svn.wordpress.org/trunk@47496


git-svn-id: http://core.svn.wordpress.org/trunk@47271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-24 00:20:06 +00:00
jorgefilipecosta
61ddc8d582 Block Editor: Update WordPress Packages WordPress 5.4 RC 4.
The following package versions were changed:
@wordpress/annotations: 1.12.1 -> 1.12.2
@wordpress/block-directory: 1.5.5 -> 1.5.6
@wordpress/block-editor: 3.7.5 -> 3.7.6
@wordpress/block-library: 2.14.5 -> 2.14.6
@wordpress/blocks: 6.12.1 -> 6.12.2
@wordpress/components: 9.2.4 -> 9.2.5
@wordpress/core-data: 2.12.1 -> 2.12.2
@wordpress/data: 4.14.1 -> 4.14.2
@wordpress/data-controls: 1.8.1 -> 1.8.2
@wordpress/edit-post: 3.13.6 -> 3.13.7
@wordpress/editor: 9.12.5 -> 9.12.6
@wordpress/format-library: 1.14.5 -> 1.14.6
@wordpress/keyboard-shortcuts: 1.1.1 -> 1.1.2
@wordpress/list-reusable-blocks: 1.13.4 -> 1.13.5
@wordpress/notices: 2.0.1 -> 2.0.2
@wordpress/nux: 3.12.4 -> 3.12.5
@wordpress/rich-text: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.4 -> 1.8.5
@wordpress/viewport: 2.13.1 -> 2.13.2
Description of editor changes included in the RC available at https://github.com/WordPress/gutenberg/pull/21083.

Props itsjonq, mcsf, aduth.
Fixes: #49688.
Built from https://develop.svn.wordpress.org/trunk@47495


git-svn-id: http://core.svn.wordpress.org/trunk@47270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-23 23:40:19 +00:00
Sergey Biryukov
3ec189f978 Docs: Add missing @since tags for WP_User_Request properties.
Correct type for `$email`, `$confirmed_timestamp`, and `$completed_timestamp` properties.

Props pbiron, garrett-eclipse.
Fixes #49675.
Built from https://develop.svn.wordpress.org/trunk@47494


git-svn-id: http://core.svn.wordpress.org/trunk@47269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-23 20:20:09 +00:00
Sergey Biryukov
5ce4cc4930 Administration: Add / character to <img> tag in WP_Plugin_Install_List_Table::display_rows().
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.

Props adnan.limdi, Soean.
Fixes #41904.
Built from https://develop.svn.wordpress.org/trunk@47493


git-svn-id: http://core.svn.wordpress.org/trunk@47268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-23 03:03:07 +00:00
Sergey Biryukov
248a115c2b Upgrade/Install: Return a more appropriate HTTP response status code (409 Conflict) if the wp-config.php file already exists.
Props linyows, ocean90.
Fixes #42466.
Built from https://develop.svn.wordpress.org/trunk@47478


git-svn-id: http://core.svn.wordpress.org/trunk@47267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-21 15:44:15 +00:00
Sergey Biryukov
77e32cff47 Coding Standards: Fix WPCS issue in [47475].
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47476


git-svn-id: http://core.svn.wordpress.org/trunk@47265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-20 17:33:07 +00:00
Sergey Biryukov
8f31a95982 Help/About: Add design for 5.4 About page.
Props melchoyce, marybaum, marktimemedia, elmastudio, ryelle, karmatosed, audrasjb, afercia, francina, sabernhardt.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47475


git-svn-id: http://core.svn.wordpress.org/trunk@47264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-20 17:13:10 +00:00
Sergey Biryukov
2fd80efe13 Administration: Escape admin title on output after the admin_title filter runs, not before.
Props lalitpendhare, adnan.limdi, subrataemfluence, andraganescu.
Fixes #41921.
Built from https://develop.svn.wordpress.org/trunk@47474


git-svn-id: http://core.svn.wordpress.org/trunk@47261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-20 02:20:08 +00:00
Sergey Biryukov
ed01dbb89b Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens.
Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570.
Built from https://develop.svn.wordpress.org/trunk@47473


git-svn-id: http://core.svn.wordpress.org/trunk@47260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-19 20:45:10 +00:00
Sergey Biryukov
c6c8862b87 Post Formats: Pass post type to the disable_formats_dropdown filter in WP_Posts_List_Table::formats_dropdown().
Props MatheusFD, birgire.
Fixes #47959.
Built from https://develop.svn.wordpress.org/trunk@47472


git-svn-id: http://core.svn.wordpress.org/trunk@47259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-18 19:13:10 +00:00
Andrew Ozz
e94cd4e1a0 Build Tools: Use the new combinedOutputFile setting for the updated DependencyExtractionWebpackPlugin and output script-loader-packages.php directly in wp-includes/assets/.
Props gziolo, azaozz.
See: #48154.
Built from https://develop.svn.wordpress.org/trunk@47471


git-svn-id: http://core.svn.wordpress.org/trunk@47258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-18 04:50:10 +00:00
Sergey Biryukov
dd12e83491 Docs: Correct the description of $hard parameter in flush_rewrite_rules().
Props david.binda.
Fixes #49660.
Built from https://develop.svn.wordpress.org/trunk@47468


git-svn-id: http://core.svn.wordpress.org/trunk@47255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-17 19:34:08 +00:00
jorgefilipecosta
7c8f8d776f Block Editor: Update WordPress Packages WordPress 5.4 RC 3.
The following package versions were changed:
@wordpress/block-directory: 1.5.4 -> 1.5.5
@wordpress/block-editor: 3.7.4 -> 3.7.5
@wordpress/block-library: 2.14.4 -> 2.14.5
@wordpress/components: 9.2.3 -> 9.2.4
@wordpress/dependency-extraction-webpack-plugin: 2.3.0 -> 2.4.0
@wordpress/edit-post: 3.13.5 -> 3.13.6
@wordpress/editor: 9.12.4 -> 9.12.5
@wordpress/format-library: 1.14.4 -> 1.14.5
@wordpress/list-reusable-blocks: 1.13.3 -> 1.13.4
@wordpress/nux: 3.12.3 -> 3.12.4
@wordpress/server-side-render: 1.8.3 -> 1.8.4

Props aduth.
Fixes: #49657.
Built from https://develop.svn.wordpress.org/trunk@47462


git-svn-id: http://core.svn.wordpress.org/trunk@47249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-16 22:07:16 +00:00
John Blackbourn
7004afe4f4 Docs: Various docblock corrections and improvements.
See #49572
Built from https://develop.svn.wordpress.org/trunk@47461


git-svn-id: http://core.svn.wordpress.org/trunk@47248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-16 18:40:07 +00:00
Sergey Biryukov
0a08229a9b Tests: Use PUPPETEER_SKIP_CHROMIUM_DOWNLOAD environment variable instead of config setting.
This is more consistent with the similar approach in Gutenberg Travis setup.

Follow-up to [47449].

See #49621.
Built from https://develop.svn.wordpress.org/trunk@47459


git-svn-id: http://core.svn.wordpress.org/trunk@47246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-16 12:24:09 +00:00
Sergey Biryukov
25333cc670 Menus: When adding a label for special pages in wp_setup_nav_menu_item() strip all HTML tags, as the label is escaped on output.
Follow-up to [47211], [47213].

Props stiofansisland.
Fixes #49374.
Built from https://develop.svn.wordpress.org/trunk@47458


git-svn-id: http://core.svn.wordpress.org/trunk@47245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-16 01:32:05 +00:00
Sergey Biryukov
73ef224e64 Administration: When editing a plugin or theme file, close any active PHP session.
This prevents HTTP requests from timing out when attempting to connect back to the site.

Props bruandet, vjik, donmhico, SergeyBiryukov.
Fixes #43358.
Built from https://develop.svn.wordpress.org/trunk@47457


git-svn-id: http://core.svn.wordpress.org/trunk@47244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-15 19:45:07 +00:00
Sergey Biryukov
cf75b95197 Site Health: Run the first scheduled site health check a day after the initial site setup.
This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios.

Props Clorith, garrett-eclipse, roytanck, joostdevalk.
Fixes #49577.
Built from https://develop.svn.wordpress.org/trunk@47456


git-svn-id: http://core.svn.wordpress.org/trunk@47243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-14 16:36:07 +00:00
Sergey Biryukov
dacd7a55ea Toolbar: Move the logic for rendering the admin bar on wp_footer to wp_admin_bar_render().
Clarify in the function documentation that it is now called on `wp_body_open` action first, with `wp_footer` as a fallback.

Follow-up to [47221].

Fixes #47053.
Built from https://develop.svn.wordpress.org/trunk@47455


git-svn-id: http://core.svn.wordpress.org/trunk@47242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-14 16:01:08 +00:00
Sergey Biryukov
d5f942d7ba General: Trim the input data in maybe_unserialize(), for consistency with is_serialized().
Props pbearne, mikeschroder.
Fixes #36416.
Built from https://develop.svn.wordpress.org/trunk@47454


git-svn-id: http://core.svn.wordpress.org/trunk@47241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-13 21:13:08 +00:00
Sergey Biryukov
0dc46c0ba5 General: Move maybe_serialize() to a more appropriate place in the file, before maybe_unserialize().
Rename the `$original` parameter of `maybe_unserialize()` to `$data`, for consistency with other serialization functions.

See #36416.
Built from https://develop.svn.wordpress.org/trunk@47453


git-svn-id: http://core.svn.wordpress.org/trunk@47240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-13 21:07:06 +00:00
Sergey Biryukov
045d4face1 Tests: Extract is_serialized() test cases into data providers; reuse them for maybe_serialize() and maybe_unserialize() tests.
Props pbearne, mikeschroder, SergeyBiryukov.
See #36416.
Built from https://develop.svn.wordpress.org/trunk@47452


git-svn-id: http://core.svn.wordpress.org/trunk@47239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-13 20:41:07 +00:00
Sergey Biryukov
c8cc78671b Database: Introduce wpdb::db_server_info() to retrieve full MySQL server information string as supplied by mysqli_get_server_info().
This complements `wpdb::db_version()`, which only returns a numeric version string and strips any additional information, e.g. vendor name.

Props clarinetlord, birgire, webaware, pento.
Fixes #40037. See #27703.
Built from https://develop.svn.wordpress.org/trunk@47451


git-svn-id: http://core.svn.wordpress.org/trunk@47238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-12 15:55:07 +00:00
TimothyBlynJacobs
1367b1175f REST API: Introduce "hex-color" JSON Schema format.
Props spacedmonkey, chrisvanpatten.
Fixes #49270.

Built from https://develop.svn.wordpress.org/trunk@47450


git-svn-id: http://core.svn.wordpress.org/trunk@47237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-12 02:42:08 +00:00
Sergey Biryukov
bcb8ee6dcf Tests: Download Chromium for e2e tests only.
This reduces the chance of random failures due to network timeouts and avoids the overhead of unnecessarily downloading ~120 MB for PHP or JS tests.

Fixes #49621.
Built from https://develop.svn.wordpress.org/trunk@47449


git-svn-id: http://core.svn.wordpress.org/trunk@47236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-11 02:03:11 +00:00
Peter Wilson
a88ac4f003 Media: Introduce preflight filter to wp_delete_attachment().
Introduces the filter `pre_delete_attachment` to allow developers to prevent or modify the deletion of attachments. This improves consistency with `wp_delete_post()` and `wp_trash_post()`.

Props joemcgill, peterwilsoncc.
Fixes #49597.

Built from https://develop.svn.wordpress.org/trunk@47448


git-svn-id: http://core.svn.wordpress.org/trunk@47235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-10 22:48:07 +00:00
Sergey Biryukov
9aa864f1a7 Bundled Themes: Update calendar widget styles for 5.4 markup to fix the alignment of a single month link.
Follow-up to [47405].

Props sabernhardt.
Reviewed by ianbelanger, SergeyBiryukov.
Fixes #49549.
Built from https://develop.svn.wordpress.org/trunk@47444


git-svn-id: http://core.svn.wordpress.org/trunk@47231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-10 20:53:06 +00:00
Sergey Biryukov
70def7fc4a Help/About: Use consistent vertical whitespace between sections on Freedoms page.
Props chetan200891.
Fixes #49619.
Built from https://develop.svn.wordpress.org/trunk@47443


git-svn-id: http://core.svn.wordpress.org/trunk@47230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-10 20:39:16 +00:00
jorgefilipecosta
da43022d3f Block Editor: Update WordPress Packages WordPress 5.4 RC 2.
The following package versions were changed:
@wordpress/block-directory: 1.5.3 -> 1.5.4
@wordpress/block-editor: 3.7.3 -> 3.7.4
@wordpress/block-library: 2.14.3 -> 2.14.4
@wordpress/edit-post: 3.13.4 -> 3.13.5
@wordpress/editor: 9.12.3 -> 9.12.4
@wordpress/format-library: 1.14.3 -> 1.14.4

Props aduth, gziolo, mapk.
Fixes: #49611.
Built from https://develop.svn.wordpress.org/trunk@47441


git-svn-id: http://core.svn.wordpress.org/trunk@47228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-10 14:53:18 +00:00
ianbelanger
4c1b25b5cc Bundled Themes: Twenty Twenty content font CSS selector is too important - updated.
This adds more selectors for headings, tables, addresses, cite, figcaption, file and caption blocks to make the font-family match as before [47133].

Props alexandreb3, SergeyBiryukov.
Fixes #49318.
Built from https://develop.svn.wordpress.org/trunk@47439


git-svn-id: http://core.svn.wordpress.org/trunk@47226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-09 19:48:07 +00:00
Sergey Biryukov
d8a0b6ef2c Help/About: Update and correct some strings for 5.4 About page.
Props garrett-eclipse, Ipstenu, ocean90, tobifjellner, la-geek.
Reviewed by ocean90, SergeyBiryukov.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47436


git-svn-id: http://core.svn.wordpress.org/trunk@47223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-09 00:11:04 +00:00
Sergey Biryukov
9448f5c95e Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens.
Props sagarjadhav, valentinbora.
Fixes #31783.
Built from https://develop.svn.wordpress.org/trunk@47435


git-svn-id: http://core.svn.wordpress.org/trunk@47222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-08 01:52:05 +00:00
Sergey Biryukov
cb5308b0ab Administration: Add missing description for "Page title" element of the admin menu array.
Props ajoah, valentinbora, kaitlin414.
Fixes #42911.
Built from https://develop.svn.wordpress.org/trunk@47434


git-svn-id: http://core.svn.wordpress.org/trunk@47221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-08 00:18:05 +00:00
Sergey Biryukov
9fbd842eb2 Customize: Ensure color picker's Clear button is aligned properly.
Props Cybr.
Fixes #49543.
Built from https://develop.svn.wordpress.org/trunk@47433


git-svn-id: http://core.svn.wordpress.org/trunk@47220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-07 01:13:06 +00:00
Sergey Biryukov
d6178e1dcf REST API: Fix typo in disable-custom-gradients theme feature description.
Props Ipstenu, tobifjellner, pixelverbieger.
Reviewed by ocean90, johnbillion, SergeyBiryukov.
Fixes #49585.
Built from https://develop.svn.wordpress.org/trunk@47432


git-svn-id: http://core.svn.wordpress.org/trunk@47219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-06 00:17:05 +00:00
Sergey Biryukov
6b1e845fca Tests: Remove unnecessary use of wpdb_exposed_methods_for_testing in test_utf8mb3_post_saves_with_emoji().
Props clarinetlord.
Fixes #39998.
Built from https://develop.svn.wordpress.org/trunk@47431


git-svn-id: http://core.svn.wordpress.org/trunk@47218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-05 11:55:05 +00:00
Sergey Biryukov
4b64d587a5 General: Ensure get_tag_regex() always returns a string, to match the documented value.
Props subrataemfluence.
Fixes #45643.
Built from https://develop.svn.wordpress.org/trunk@47430


git-svn-id: http://core.svn.wordpress.org/trunk@47217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-04 12:05:05 +00:00
Sergey Biryukov
eea1fd30c2 General: Correct the default value of the $defaults parameter in wp_parse_args() to match the documented type.
Props subrataemfluence.
See #45643.
Built from https://develop.svn.wordpress.org/trunk@47429


git-svn-id: http://core.svn.wordpress.org/trunk@47216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-04 12:00:06 +00:00
Sergey Biryukov
4a00ea1127 Docs: Reorder @throws tags in WP_Customize_Nav_Menu_Setting and WP_Customize_Nav_Menu_Item_Setting for consistency with WP_Customize_Custom_CSS_Setting.
See #49572.
Built from https://develop.svn.wordpress.org/trunk@47428


git-svn-id: http://core.svn.wordpress.org/trunk@47215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-04 11:36:06 +00:00
Sergey Biryukov
57e91eb89a Docs: Add missing @throws tag to _wp_json_sanity_check() DocBlock.
Props subrataemfluence.
See #45643.
Built from https://develop.svn.wordpress.org/trunk@47427


git-svn-id: http://core.svn.wordpress.org/trunk@47214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-04 11:34:08 +00:00
Peter Wilson
8483056ea1 Trunk is now 5.5 alpha
Built from https://develop.svn.wordpress.org/trunk@47426


git-svn-id: http://core.svn.wordpress.org/trunk@47213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-04 01:20:11 +00:00
jorgefilipecosta
3227238b36 Post WordPress 5.4 RC 1 version bump.
Built from https://develop.svn.wordpress.org/trunk@47424


git-svn-id: http://core.svn.wordpress.org/trunk@47211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 22:02:05 +00:00
jorgefilipecosta
4510afa73e WordPress 5.4 RC 1.
Built from https://develop.svn.wordpress.org/trunk@47423


git-svn-id: http://core.svn.wordpress.org/trunk@47210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 21:43:06 +00:00
Sergey Biryukov
293bc81bf6 Help/About: Add strings for 5.4 About page.
Props elmastudio, chanthaboune, francina, marybaum, audrasjb.
See #49295.
Built from https://develop.svn.wordpress.org/trunk@47422


git-svn-id: http://core.svn.wordpress.org/trunk@47209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 21:22:07 +00:00
jorgefilipecosta
86bafc002d Editor: Update WordPress packages to make editor full-screen by default.
The following package versions were changed:
@wordpress/e2e-test-utils: 4.3.0 -> 4.3.1
@wordpress/edit-post: 3.13.3 -> 3.13.4
This commit update allows the following PR to be part of trunk https://github.com/WordPress/gutenberg/pull/20611.

Props youknowriad, mcsf, mapk.
Fixes: #49574.
Built from https://develop.svn.wordpress.org/trunk@47421


git-svn-id: http://core.svn.wordpress.org/trunk@47208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 20:45:08 +00:00
Sergey Biryukov
18e3aa433c Privacy: Prevent unexpected scrolling when clicking the "Copy this section to clipboard" button on Privacy Policy Guide screen.
Props garrett-eclipse, birgire, davidbaumwald, pbiron.
Fixes #49540.
Built from https://develop.svn.wordpress.org/trunk@47420


git-svn-id: http://core.svn.wordpress.org/trunk@47207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 17:51:05 +00:00
Sergey Biryukov
c30fd0b54d Media: Improve the appearance of image editor on small and medium screens.
This prevents the main area of Edit Media screen from being pushed down too far.

Props sabernhardt, afercia, fierevere, sathyapulse, mikeschroder, johnbillion.
Fixes #48780. See #47136.
Built from https://develop.svn.wordpress.org/trunk@47418


git-svn-id: http://core.svn.wordpress.org/trunk@47205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 17:21:05 +00:00
jorgefilipecosta
cf40905ada Scripts: Use core-js url as polyfill for window.URL.
URL polyfill from the polyfill-library library is not spec-conformant, in a way which negatively impacts its usability for pending revisions to the block editor. Specifically, there were revisions to the implementation of the wp-url script to detect URL validity by relying on thrown errors from the URL constructor, but this specific behavior is not implemented in this version of the polyfill.
There was another issue in r47238, which is that the test used to check whether the polyfill should be included is not accurate. This commit uses a different check and fixes the issue.

Props aduth.
Fixes: #49360.
Built from https://develop.svn.wordpress.org/trunk@47416


git-svn-id: http://core.svn.wordpress.org/trunk@47203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 16:55:07 +00:00
Sergey Biryukov
62ef2d6719 Site Health: Fix typo in Site Health Status dashboard widget.
Follow-up to [47063], [47413].

Props Clorith, dlh.
See #49562.
Built from https://develop.svn.wordpress.org/trunk@47415


git-svn-id: http://core.svn.wordpress.org/trunk@47202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 12:22:07 +00:00
Sergey Biryukov
a9479f31d1 Docs: Correct formatting of some DocBlocks in Plugin_Upgrader and Theme_Upgrader per the documentation standards.
See #49400.
Built from https://develop.svn.wordpress.org/trunk@47414


git-svn-id: http://core.svn.wordpress.org/trunk@47201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 11:39:08 +00:00
Sergey Biryukov
ab854ce518 Site Health: Improve the strings in Site Health Status dashboard widget.
Follow-up to [47063].

Props dlh.
Fixes #49562.
Built from https://develop.svn.wordpress.org/trunk@47413


git-svn-id: http://core.svn.wordpress.org/trunk@47200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 11:21:07 +00:00
John Blackbourn
24567bf775 Privacy: Fix the URLs and legacy redirects for the personal data export and erasure screens.
Props Jurgen Oldenburg, garrett-eclipse

Fixes #49476
Built from https://develop.svn.wordpress.org/trunk@47412


git-svn-id: http://core.svn.wordpress.org/trunk@47199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:50:06 +00:00
John Blackbourn
e12cca1ce8 Privacy: Reintroduce consistency to the styling of suggested privacy text from core and plugins.
Props garrett-eclipse

Fixes #49282
Built from https://develop.svn.wordpress.org/trunk@47411


git-svn-id: http://core.svn.wordpress.org/trunk@47198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:42:06 +00:00
John Blackbourn
da52485cf1 Editor: Revert a fix for incorrect usage of ID attributes on custom fields.
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector.

See #46964
Built from https://develop.svn.wordpress.org/trunk@47410


git-svn-id: http://core.svn.wordpress.org/trunk@47197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:37:06 +00:00
John Blackbourn
9860470360 Upgrade/Install: Improved inline docs for the plugin and theme updater maintenance mode functionality.
Props bookdude13

See #49400
Built from https://develop.svn.wordpress.org/trunk@47409


git-svn-id: http://core.svn.wordpress.org/trunk@47196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:29:06 +00:00
jorgefilipecosta
cc17fee089 Block Editor: Update WordPress Packages WordPress 5.4 RC 1.
The following package versions were changed:
@wordpress/annotations: 1.12.0 -> 1.12.1
@wordpress/block-directory: 1.5.2 -> 1.5.3
@wordpress/block-editor: 3.7.2 -> 3.7.3
@wordpress/block-library: 2.14.2 -> 2.14.3
@wordpress/blocks: 6.12.0 -> 6.12.1
@wordpress/components: 9.2.2 -> 9.2.3
@wordpress/core-data: 2.12.0 -> 2.12.1
@wordpress/data: 4.14.0 -> 4.14.1
@wordpress/data-controls: 1.8.0 -> 1.8.1
@wordpress/edit-post: 3.13.2 -> 3.13.3
@wordpress/editor: 9.12.2 -> 9.12.3
@wordpress/format-library: 1.14.2 -> 1.14.3
@wordpress/keyboard-shortcuts: 1.1.0 -> 1.1.1
@wordpress/list-reusable-blocks: 1.13.2 -> 1.13.3
@wordpress/notices: 2.0.0 -> 2.0.1
@wordpress/nux: 3.12.2 -> 3.12.3
@wordpress/priority-queue: 1.5.0 -> 1.5.1
@wordpress/rich-text: 3.12.0 -> 3.12.1
@wordpress/server-side-render: 1.8.2 -> 1.8.3
@wordpress/viewport: 2.13.0 -> 2.13.1

Props aduth.
Fixes: #49567.
Built from https://develop.svn.wordpress.org/trunk@47408


git-svn-id: http://core.svn.wordpress.org/trunk@47195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-02 23:21:15 +00:00
Andrew Ozz
aa8d4257ea Build Tools: Exclude the src/wp-includes/assets/ directory from copying when building. Its content is generated by Webpack and copied in another task.
See #48154.
Built from https://develop.svn.wordpress.org/trunk@47407


git-svn-id: http://core.svn.wordpress.org/trunk@47194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-02 19:10:06 +00:00
John Blackbourn
aed09845b2 Feeds: Remove an unreachable condition when generating archive feed links.
Props donmhico, pbiron

Fixes #48427
Built from https://develop.svn.wordpress.org/trunk@47406


git-svn-id: http://core.svn.wordpress.org/trunk@47193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-02 18:52:04 +00:00
ianbelanger
27a52dec3e Bundled Themes: Update calendar widget styles for 5.4 markup.
Fixes the alignment of month links in the calendar widget with the changes in version 5.4 for all Bundled Themes, except Twenty Thirteen, which was already fixed in #49546.

Props sabernhardt.
Fixes #49549.
Built from https://develop.svn.wordpress.org/trunk@47405


git-svn-id: http://core.svn.wordpress.org/trunk@47192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-02 16:55:08 +00:00
Sergey Biryukov
26e1072d65 Build/Test Tools: Bump devDependencies for WordPress 5.4.
Props ayeshrajans, garrett-eclipse.
Fixes #49547.
Built from https://develop.svn.wordpress.org/trunk@47404


git-svn-id: http://core.svn.wordpress.org/trunk@47191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-02 01:54:13 +00:00
Sergey Biryukov
b193d0a34b Tests: Add a unit test to ensure the "Supported Versions" section of GitHub Security Policy always includes the latest stable branch.
See #48667, #48521.
Built from https://develop.svn.wordpress.org/trunk@47403


git-svn-id: http://core.svn.wordpress.org/trunk@47190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-02 01:13:03 +00:00
Sergey Biryukov
e041a3a8f3 Docs: Use more specific type in parameter descriptions for is_page(), is_single(), is_singular(), and their WP_Query counterpart methods.
Props marekdedic, shaharia.azam, shaampk1.
Fixes #48354. See #48303.
Built from https://develop.svn.wordpress.org/trunk@47402


git-svn-id: http://core.svn.wordpress.org/trunk@47189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 17:29:06 +00:00
Sergey Biryukov
abce2d8d6c Docs: Synchronize parameter descriptions for conditional tags with their WP_Query counterpart methods.
See #48354, #48303.
Built from https://develop.svn.wordpress.org/trunk@47401


git-svn-id: http://core.svn.wordpress.org/trunk@47188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 17:21:06 +00:00
Sergey Biryukov
f82fd2c436 Docs: Use more specific type in parameter description for wp_unslash().
Props marekdedic.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47400


git-svn-id: http://core.svn.wordpress.org/trunk@47187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 16:26:05 +00:00
Sergey Biryukov
7ca7727ec0 Docs: Use more specific type in description for _WP_Dependency::$deps.
Props marekdedic.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47399


git-svn-id: http://core.svn.wordpress.org/trunk@47186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 16:24:04 +00:00
John Blackbourn
251d77e1a1 Docs: Miscellaneous docs fixes and improvements.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47398


git-svn-id: http://core.svn.wordpress.org/trunk@47185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 10:40:07 +00:00
John Blackbourn
056dad9c2c Docs: Use more specific types in parameter descriptions in place of mixed.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47397


git-svn-id: http://core.svn.wordpress.org/trunk@47184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 10:38:07 +00:00
John Blackbourn
bf8c4ee5c6 Docs: Correct the parameter documentation of the request_filesystem_credentials filter.
See #48303
Built from https://develop.svn.wordpress.org/trunk@47396


git-svn-id: http://core.svn.wordpress.org/trunk@47183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 10:33:04 +00:00
Sergey Biryukov
fcff974c33 Privacy: Make the progress indicator for export and erasure visible even if not hovered over.
Follow-up to [47246].

Props pbiron, garrett-eclipse.
Fixes #44264.
Built from https://develop.svn.wordpress.org/trunk@47395


git-svn-id: http://core.svn.wordpress.org/trunk@47182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-29 23:45:07 +00:00
John Blackbourn
46674e2367 Docs: Correct and improve the docs for some media related functions.
See #48303
Built from https://develop.svn.wordpress.org/trunk@47394


git-svn-id: http://core.svn.wordpress.org/trunk@47181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-29 16:49:07 +00:00
ianbelanger
7f26b262b2 Bundled Themes: Twenty Twenty searchform.php error.
Fixes phpcs error in the searchform.php file. The variables in this file were not prefixed correctly.

Props fahimmurshed.
Fixes #49523.
Built from https://develop.svn.wordpress.org/trunk@47393


git-svn-id: http://core.svn.wordpress.org/trunk@47180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-28 20:56:06 +00:00
ianbelanger
3bfa7b9ef9 Bundled Themes: Twenty Thirteen update calendar widget styles for 5.4 markup.
Fixes the alignment of month links in the calendar widget with the changes in version 5.4

Props sabernhardt.
Fixes #49546.
Built from https://develop.svn.wordpress.org/trunk@47392


git-svn-id: http://core.svn.wordpress.org/trunk@47179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-28 20:07:07 +00:00
Sergey Biryukov
cbe5f9963a Docs: Improve documentation for WP_REST_Attachments_Controller.
This adds a missing DocBlock for `::register_routes()` and parameter descriptions for `::post_process_item()`.

Includes minor documenation fixes in other REST API classes for consistency.

Props dkarfa, mukesh27, SergeyBiryukov.
Fixes #48841.
Built from https://develop.svn.wordpress.org/trunk@47391


git-svn-id: http://core.svn.wordpress.org/trunk@47178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-28 12:31:08 +00:00
Sergey Biryukov
eb524c0b38 Docs: Improve documentation for various metadata functions.
This adds a more specific description for accepted object types: `post`, `comment`, `term`, `user`, or any other object type with an associated meta table.

Props sheparddw, kraftbj, DrewAPicture, SergeyBiryukov.
Fixes #45464.
Built from https://develop.svn.wordpress.org/trunk@47390


git-svn-id: http://core.svn.wordpress.org/trunk@47177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-28 12:14:08 +00:00
Sergey Biryukov
32be7d6460 Coding Standards: Update PHPCS Composer plugin to v0.6.0.
Release log: https://github.com/Dealerdirect/phpcodesniffer-composer-installer/releases/tag/v0.6.0

Props jrf.
See #49222.
Built from https://develop.svn.wordpress.org/trunk@47389


git-svn-id: http://core.svn.wordpress.org/trunk@47176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-28 01:40:05 +00:00
Sergey Biryukov
19268546a5 Twenty Twenty: Replace quotation marks in starter content with HTML entities.
Props fahimmurshed.
Fixes #49534.
Built from https://develop.svn.wordpress.org/trunk@47388


git-svn-id: http://core.svn.wordpress.org/trunk@47175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-27 22:00:07 +00:00
Sergey Biryukov
50afd0aa1b Docs: Add a reference to WP_Customize_Panel::__construct() for information on accepted arguments in WP_Customize_Manager::add_panel().
Synchronize the documentation between two places, use `WP_Customize_Panel::__construct()` as the canonical source.

Props iaaxpage, marekdedic.
Fixes #48344.
Built from https://develop.svn.wordpress.org/trunk@47387


git-svn-id: http://core.svn.wordpress.org/trunk@47174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-27 20:36:07 +00:00
Sergey Biryukov
9043b9833f Docs: Add a reference to WP_Customize_Section::__construct() for information on accepted arguments in WP_Customize_Manager::add_section().
Synchronize the documentation between two places, use `WP_Customize_Section::__construct()` as the canonical source.

Props amolv, marekdedic.
Fixes #48346.
Built from https://develop.svn.wordpress.org/trunk@47386


git-svn-id: http://core.svn.wordpress.org/trunk@47173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-27 20:29:06 +00:00
Sergey Biryukov
569319f553 Docs: Clarify the type of theme_supports argument in various Customizer classes.
Props marekdedic.
See #48347.
Built from https://develop.svn.wordpress.org/trunk@47385


git-svn-id: http://core.svn.wordpress.org/trunk@47172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-27 20:23:06 +00:00
Sergey Biryukov
8c5a8f1811 Docs: Add a reference to WP_Customize_Setting::__construct() for information on accepted arguments in WP_Customize_Manager::add_setting().
Synchronize the documentation between two places, use `WP_Customize_Setting::__construct()` as the canonical source.

Props tmanoilov, marekdedic.
Fixes #48347.
Built from https://develop.svn.wordpress.org/trunk@47384


git-svn-id: http://core.svn.wordpress.org/trunk@47171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-27 20:09:06 +00:00
Sergey Biryukov
ac9b6fcef8 Docs: Use a consistent description for the $manager parameter in various Customizer class constructions.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47383


git-svn-id: http://core.svn.wordpress.org/trunk@47170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-26 15:33:05 +00:00
Sergey Biryukov
3d75b5bac5 Docs: Add a @see reference to WP_Customize_Control::__construct() in child class constructors.
Follow-up to [47363], [47364].

See #48343, #48348.
Built from https://develop.svn.wordpress.org/trunk@47382


git-svn-id: http://core.svn.wordpress.org/trunk@47169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-26 13:30:08 +00:00
Sergey Biryukov
9bb8831642 Build/Test Tools: Remove redundant Tests_Post_Types::register_post_type() helper method, use register_post_type() directly.
Props gh640, varunshanbhag.
Fixes #49365.
Built from https://develop.svn.wordpress.org/trunk@47381


git-svn-id: http://core.svn.wordpress.org/trunk@47168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-26 13:18:07 +00:00
Andrew Ozz
c2bea683a2 Build Tools: Do not delete the (now committed) script-loader-packages.php file when running clean:js and copy it to /build. Fixes cases when running grunt watch or -dev where that file may be deleted and not recreated.
See #48154.
Built from https://develop.svn.wordpress.org/trunk@47380


git-svn-id: http://core.svn.wordpress.org/trunk@47167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-26 05:15:09 +00:00
jorgefilipecosta
218cd5f4c2 Post WordPress 5.4 Beta 3 version bump.
Built from https://develop.svn.wordpress.org/trunk@47379


git-svn-id: http://core.svn.wordpress.org/trunk@47166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 22:13:08 +00:00
jorgefilipecosta
3c8112e912 WordPress 5.4 Beta 3.
Built from https://develop.svn.wordpress.org/trunk@47378


git-svn-id: http://core.svn.wordpress.org/trunk@47165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 21:56:07 +00:00
Sergey Biryukov
3adea27d1c Block Editor: Update wp-includes/assets/script-loader-packages.php.
Follow-up to [47352], [47354].

Props aduth, ocean90, garrett-eclipse.
Fixes #49506.
Built from https://develop.svn.wordpress.org/trunk@47377


git-svn-id: http://core.svn.wordpress.org/trunk@47164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 21:45:06 +00:00
Sergey Biryukov
ab0cf0aa51 Privacy: Switch buttons in Next Steps column of privacy request tables to break-word for better legibility on various screen sizes.
Props garrett-eclipse, afercia, nrqsnchz.
Fixes #46304.
Built from https://develop.svn.wordpress.org/trunk@47376


git-svn-id: http://core.svn.wordpress.org/trunk@47163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 21:01:06 +00:00
Sergey Biryukov
8136532954 Accessibility: Media: Hide the invisible "file upload button" on media views from assistive technologies.
The button is visually hidden, but was announced by screen readers in workflows unrelated to file uploading, leading to confusion.

Props afercia, audrasjb, azaozz.
Fixes #47611.
Built from https://develop.svn.wordpress.org/trunk@47375


git-svn-id: http://core.svn.wordpress.org/trunk@47162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 20:44:06 +00:00
Sergey Biryukov
1a9b7f8737 General: Introduce HTML classes in get_calendar() for easier CSS targeting:
* `.wp-calendar-table` for the `<table>` element.
* `.wp-calendar-nav` for the navigation wrapper.
* `.wp-calendar-nav-prev` for the previous month link.
* `.wp-calendar-nav-next` for the next month link.

Replace `#prev` and `#next` HTML IDs with `.wp-calendar-nav-prev` and `.wp-calendar-nav-next` classes.

Props sabernhardt, BackuPs, audrasjb, jorbin.
Fixes #39763.
Built from https://develop.svn.wordpress.org/trunk@47374


git-svn-id: http://core.svn.wordpress.org/trunk@47161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 20:30:07 +00:00
Sergey Biryukov
153eb7537e Docs: In update_option(), remove an inaccurate statement about the $autoload value for new options.
If the option does not exist, it will be created with whatever was passed to the `$autoload` parameter, `'yes'` being only the default value.

Props leogermani.
Fixes #48357.
Built from https://develop.svn.wordpress.org/trunk@47373


git-svn-id: http://core.svn.wordpress.org/trunk@47160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 20:08:07 +00:00
Sergey Biryukov
3a333ef030 Coding Standards: Use strict comparison for normalize_whitespace() checks when comparing revisions or autosaves.
Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965.
Built from https://develop.svn.wordpress.org/trunk@47372


git-svn-id: http://core.svn.wordpress.org/trunk@47159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 19:35:09 +00:00
Sergey Biryukov
8b0a0c44aa Widgets: Create a unique HTML ID for the <ul> element of Recent Comments widget if more than one instance is displayed on the page.
Props peterwilsoncc, audrasjb, birgire, justinahinon, mbrailer, desrosj.
Fixes #46747.
Built from https://develop.svn.wordpress.org/trunk@47371


git-svn-id: http://core.svn.wordpress.org/trunk@47158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 19:29:06 +00:00
Sergey Biryukov
00f110740b Bootstrap/Load: In wp_magic_quotes(), revert the type change to string for REQUEST_TIME and REQUEST_TIME_FLOAT values, which should retain their proper type.
Among other things, this preserves compatibility of WP with PHPUnit Code Coverage generation.

Props jrf, Veraxus, Rarst.
See #48605.
Built from https://develop.svn.wordpress.org/trunk@47370


git-svn-id: http://core.svn.wordpress.org/trunk@47157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 18:33:06 +00:00
Sergey Biryukov
1e81c20ff5 Docs: In wp_insert_user(), correct @type for rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments.
Follow-up to [47368].

See #49087.
Built from https://develop.svn.wordpress.org/trunk@47369


git-svn-id: http://core.svn.wordpress.org/trunk@47156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 18:20:06 +00:00
Sergey Biryukov
2cd5292def Docs: In wp_insert_user(), clarify that rich_editing, syntax_highlighting, comment_shortcuts, and show_admin_bar_front arguments accept true or false as a string literal, not boolean.
Props garrett-eclipse, audrasjb, valentinbora, bilgilabs, SergeyBiryukov.
Fixes #49087.
Built from https://develop.svn.wordpress.org/trunk@47368


git-svn-id: http://core.svn.wordpress.org/trunk@47155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 18:16:07 +00:00
Sergey Biryukov
89689e5ba9 Docs: Clarify in WP_Customize_Manager::remove_*() methods that removing a setting, panel, section, or control does not destroy the class instance or remove its filters.
Props dlh, fgiannar, jon81, westonruter.
Fixes #48747.
Built from https://develop.svn.wordpress.org/trunk@47367


git-svn-id: http://core.svn.wordpress.org/trunk@47154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 17:50:05 +00:00
Sergey Biryukov
5308f570cb Comments: Restore the fourth parameter of comments_number() as $post_id, for consistency with get_comments_number_text().
The parameter was previously used as the number of comments, marked as deprecated in [5101].

Given that it's been deprecated for the last 13 years, it should be safe to undeprecate and repurpose it for a cleaner function signature, instead of adding a fifth parameter.

Follow-up to [47276].

Fixes #48772.
Built from https://develop.svn.wordpress.org/trunk@47366


git-svn-id: http://core.svn.wordpress.org/trunk@47153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 17:34:08 +00:00
Sergey Biryukov
b7c69ce058 Widgets: Avoid an overflow issue in widget controls that include <select> form fields.
Props alexischenal, audrasjb, dkarfa.
Fixes #49401.
Built from https://develop.svn.wordpress.org/trunk@47365


git-svn-id: http://core.svn.wordpress.org/trunk@47152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 17:04:07 +00:00
Sergey Biryukov
d51c720d2f Docs: Add a reference to WP_Customize_Control::__construct() for information on accepted arguments in WP_Customize_Manager::add_control().
Synchronize the documentation between two places, use `WP_Customize_Control::__construct()` as the canonical source.

Props hAmpzter, marekdedic, SergeyBiryukov.
Fixes #48343.
Built from https://develop.svn.wordpress.org/trunk@47364


git-svn-id: http://core.svn.wordpress.org/trunk@47151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 16:41:07 +00:00
Sergey Biryukov
cfc27d08ce Docs: Add a reference to WP_Customize_Control::__construct() for information on accepted arguments to override class property defaults in child classes.
Props marcio-zebedeu, marekdedic.
Fixes #48348.
Built from https://develop.svn.wordpress.org/trunk@47363


git-svn-id: http://core.svn.wordpress.org/trunk@47150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 16:21:07 +00:00
K. Adam White
44e1bbef85 REST API: Correctly infer empty objects passed via query parameters.
Permit passing an empty object as the string "?obj=". The type of the passed empty argument is inferred from the registered schema.

Props TimothyBlynJacobs, steffanhalv, schlessera, dd32.
Fixes #42961.

Built from https://develop.svn.wordpress.org/trunk@47362


git-svn-id: http://core.svn.wordpress.org/trunk@47149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 15:34:07 +00:00
K. Adam White
a5f16272dd REST API: Permit access to the themes controller if user can edit any post type.
Check a more exhaustive list of post type editing caps beyond "edit_post" to ensure custom user roles with access to to specific post types may still use block editor functionality depending on theme features.

Props miyauchi, TimothyBlynJacobs.
Fixes #46723.

Built from https://develop.svn.wordpress.org/trunk@47361


git-svn-id: http://core.svn.wordpress.org/trunk@47148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 15:20:08 +00:00
K. Adam White
8faf366ab9 REST API: Apply all relevant block rendering filters when rendering block previews.
Several filters were introduced to the render_block method since the initial implementation of the block-renderer/ endpoints, causing the output of those endpoints to diverge from the rendered content of blocks on the frontend.

Props kadamwhite, TimothyBlynJacobs, miinasikk.
Fixes #49387.

Built from https://develop.svn.wordpress.org/trunk@47360


git-svn-id: http://core.svn.wordpress.org/trunk@47147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 15:05:06 +00:00
Sergey Biryukov
67a6527d51 Script Loader: Improve performance of wp_script_is() for scripts registered with complex dependencies.
This switches `WP_Dependencies::recurse_deps()` from recursively checking the same handles over and over again to keep a flattened array of queued items and their dependencies for faster lookup in `WP_Dependencies::query()`.

Props superdav42.
Fixes #46469.
Built from https://develop.svn.wordpress.org/trunk@47359


git-svn-id: http://core.svn.wordpress.org/trunk@47146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 13:42:05 +00:00
Sergey Biryukov
c60ea3261f Docs: Add a @since note for including delete_posts in default capabilities in get_post_type_capabilities().
Follow-up to [47357].

See #30991.
Built from https://develop.svn.wordpress.org/trunk@47358


git-svn-id: http://core.svn.wordpress.org/trunk@47145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 12:55:08 +00:00
Sergey Biryukov
aaccfc063f Posts, Post Types: Ensure delete_posts is included in default post type capabilities regardless of map_meta_cap value.
This resolves PHP notices in a few places in core where this capability is checked.

Props Mte90, johnbillion, dipesh.kakadiya, jipmoors, bamadesigner, dd32, johnjamesjacoby, xedin.unknown, flixos90, SergeyBiryukov.
Fixes #30991.
Built from https://develop.svn.wordpress.org/trunk@47357


git-svn-id: http://core.svn.wordpress.org/trunk@47144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 12:50:06 +00:00
Sergey Biryukov
1a090b3385 Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel.
Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830.
Built from https://develop.svn.wordpress.org/trunk@47356


git-svn-id: http://core.svn.wordpress.org/trunk@47143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 11:14:08 +00:00
Sergey Biryukov
556c6d80d8 Script Loader: Remove unnecessary reference sign from function definitions in script loader.
This resolves PHP warnings when extensions like `php_uopz` or `php_tideways_xhprof` are in use.

Object variables in PHP 5+ contain a reference to the object, and it's the reference that's passed around.

Props jqz, killerbishop, Mte90, TJNowell, jorbin, pento, pcarvalho, valentinbora, SergeyBiryukov.
Fixes #44979.
Built from https://develop.svn.wordpress.org/trunk@47355


git-svn-id: http://core.svn.wordpress.org/trunk@47142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 00:59:06 +00:00
jorgefilipecosta
f616ffb9c1 Block Editor: Update WordPress Packages WordPress 5.4 Beta 3.
The following package versions were changed:
@wordpress/block-directory: 1.5.1 -> 1.5.2
@wordpress/block-editor: 3.7.1 -> 3.7.2
@wordpress/block-library: 2.14.1 -> 2.14.2
@wordpress/components: 9.2.1 -> 9.2.2
@wordpress/edit-post: 3.13.1 -> 3.13.2
@wordpress/editor: 9.12.1 -> 9.12.2
@wordpress/format-library: 1.14.1 -> 1.14.2
@wordpress/list-reusable-blocks: 1.13.1 -> 1.13.2
@wordpress/media-utils: 1.7.1 -> 1.7.2
@wordpress/nux: 3.12.1 -> 3.12.2
@wordpress/server-side-render: 1.8.1 -> 1.8.2

Fixes #49506.
Built from https://develop.svn.wordpress.org/trunk@47354


git-svn-id: http://core.svn.wordpress.org/trunk@47141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 00:18:15 +00:00
Sergey Biryukov
3209729f5f Accessibility: Widgets: Restore missing string in script loader.
The string was previously added in [42794] and accidentally removed in [44163].

Props garrett-eclipse, audrasjb.
Fixes #49505.
Built from https://develop.svn.wordpress.org/trunk@47353


git-svn-id: http://core.svn.wordpress.org/trunk@47140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 23:07:09 +00:00
Andrew Ozz
50be657d81 Build Tools:
- Update the DependencyExtractionWebpackPlugin to 2.3.0 and set it to output a single assets file.
- Grunt: copy the assets file to both `SOURCE_DIR` and `BUILD_DIR` as `wp-includes/assets/script-loader-packages.php`.
- "Unignore" the `wp-includes/assets` directory. Its content will be committed similarly to `wp-includes/blocks`.
- Update `wp_default_packages_scripts()` to use the above file. This also removes the hard-coded lists of packages and packages with translations.

Props gziolo, pbearne, johnbillion, isabel_brison, ocean90, azaozz.
Fixes #48154.
Built from https://develop.svn.wordpress.org/trunk@47352


git-svn-id: http://core.svn.wordpress.org/trunk@47139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 21:22:08 +00:00
K. Adam White
480372b07c REST API: Fix namespace shadowing issue in route matching logic.
Following [47260] a namespace such as "test-ns" prevents any namespace such as "test-ns/v1" from being found when matching routes.
While not best practice, this was an unintentional back-compat break; this patch restores the original behavior.

Props david.binda, TimothyBlynJacobs.
Fixes #48530.


Built from https://develop.svn.wordpress.org/trunk@47351


git-svn-id: http://core.svn.wordpress.org/trunk@47138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 18:07:08 +00:00
Sergey Biryukov
4aeebf03a5 Menus: Introduce wp_nav_menu_item_custom_fields_customize_template action that fires at the end of the form field template for nav menu items in the customizer.
This brings parity with the `wp_nav_menu_item_custom_fields` action added in [47190] for the Menus screen.

Props celloexpressions.
Fixes #47056.
Built from https://develop.svn.wordpress.org/trunk@47350


git-svn-id: http://core.svn.wordpress.org/trunk@47137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-24 14:58:19 +00:00
Sergey Biryukov
735d31ffbb Coding Standards: Add missing braces to if conditions and use strict comparison in js/_enqueues/wp/media/editor.js.
Props ankitmaru.
Fixes #49317.
Built from https://develop.svn.wordpress.org/trunk@47349


git-svn-id: http://core.svn.wordpress.org/trunk@47136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-23 08:58:05 +00:00
Sergey Biryukov
9f8f54bfbb Built/Test Tools: Ignore the node_modules folder in Twenty Nineteen when running grunt jshint:themes.
Follow-up to [45060], [46352], [46450].

Fixes #49494. See #46706.
Built from https://develop.svn.wordpress.org/trunk@47348


git-svn-id: http://core.svn.wordpress.org/trunk@47135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-23 08:28:06 +00:00
Sergey Biryukov
5a23e3fabd Docs: Use third-person singular verbs for function descriptions in wp-includes/option.php, per the documentation standards.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@47347


git-svn-id: http://core.svn.wordpress.org/trunk@47134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-23 01:07:08 +00:00
Sergey Biryukov
30572ef8ed Docs: Add a @staticvar entry for $transports in WP_Http::_dispatch_request().
Props utsav72640.
Fixes #48774.
Built from https://develop.svn.wordpress.org/trunk@47346


git-svn-id: http://core.svn.wordpress.org/trunk@47133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 19:12:06 +00:00
Sergey Biryukov
e0a2660719 I18N: Replace .htaccess with placeholders in the strings for Site Health custom rules check.
Props ramiy.
Fixes #48864.
Built from https://develop.svn.wordpress.org/trunk@47345


git-svn-id: http://core.svn.wordpress.org/trunk@47132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 18:56:06 +00:00
Sergey Biryukov
b4cea6ae93 I18N: Use a consistent wording for "Unable to write to file" strings.
Props ramiy.
Fixes #48862.
Built from https://develop.svn.wordpress.org/trunk@47344


git-svn-id: http://core.svn.wordpress.org/trunk@47131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 18:33:08 +00:00
desrosj
b92155f273 General: Introduce a pull request template.
This ensures that contributors opening a pull request on GitHub for code review have proper guidance.

See https://make.wordpress.org/core/2020/02/21/working-on-trac-tickets-using-github-pull-requests/ and https://meta.trac.wordpress.org/ticket/4903.

Props noisysocks, desrosj.
Fixes #49489.
Built from https://develop.svn.wordpress.org/trunk@47342


git-svn-id: http://core.svn.wordpress.org/trunk@47129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 18:25:07 +00:00
Sergey Biryukov
92050d6499 Build/Test Tools: Remove unused ::assertPostHasTerms() method from tests/term.php.
The associated test was removed in [30241].

See #49485.
Built from https://develop.svn.wordpress.org/trunk@47341


git-svn-id: http://core.svn.wordpress.org/trunk@47128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 17:06:06 +00:00
Adam Silverstein
2c5ebcee68 Comments: improve styling on mobile for comments marked as spam.
Correct an issue where comments marked as spam in a mobile view displayed incorrectly, filling a narrow and very tall column with the notice that a comment was marked as spam. 

Props jeremyfelt, lorenzof, mukesh27, razamalik, xkon.
Fixes #48814.


Built from https://develop.svn.wordpress.org/trunk@47340


git-svn-id: http://core.svn.wordpress.org/trunk@47127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 17:04:08 +00:00
ianbelanger
5a6decf95c Bundled Themes: Twenty Nineteen text color setting in pullquote block not applied.
Fixes the pullquote color setting by adding classes that are more specific to the color options.

Props ianbelanger.
Fixes #49410.
Built from https://develop.svn.wordpress.org/trunk@47339


git-svn-id: http://core.svn.wordpress.org/trunk@47126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 14:59:09 +00:00
Sergey Biryukov
f0dfe42216 I18N: Replace upload_max_filesize, php.ini, MAX_FILE_SIZE with placeholders in upload error strings.
Props ramiy.
Fixes #48869.
Built from https://develop.svn.wordpress.org/trunk@47330


git-svn-id: http://core.svn.wordpress.org/trunk@47123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 17:18:06 +00:00
TimothyBlynJacobs
5031baa32b REST API: Don't assume all item schemas have properties.
All schema types, not just objects, are permitted as the base type of a resource. A future patch could add validation support for those types, but this fix only prevents a PHP warning from being issued.

Props dhavalkasvala, johnwatkins0, birgire.
Fixes #48785.

Built from https://develop.svn.wordpress.org/trunk@47328


git-svn-id: http://core.svn.wordpress.org/trunk@47122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 16:58:06 +00:00
ianbelanger
a5cfb704bd Bundled Themes: Twenty Nineteen Update margins in editor styles to address upcoming block editor margin changes.
Fixes the margins in the block editor to address recent changes in block margins.

Props Joen, SergeyBiryukov, kjellr, jffng, allancole.
Fixes #48526.
Built from https://develop.svn.wordpress.org/trunk@47327


git-svn-id: http://core.svn.wordpress.org/trunk@47121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 16:40:06 +00:00
TimothyBlynJacobs
450d49183b REST API: Fix links format in OPTIONS requests for non-variable routes.
Props nsundberg, johnwatkins0, birgire.
Fixes #49149.

Built from https://develop.svn.wordpress.org/trunk@47326


git-svn-id: http://core.svn.wordpress.org/trunk@47120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 00:55:05 +00:00
TimothyBlynJacobs
808768224d REST API: Warn if registering array settings without an items schema.
The documentation for register_setting has also been clarified to include all of the supported types and the flexibility of the show_in_rest parameter.

Fixes #42875.
Props perrywagle, dshanske, kadamwhite.

Built from https://develop.svn.wordpress.org/trunk@47325


git-svn-id: http://core.svn.wordpress.org/trunk@47119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-19 22:56:07 +00:00