Commit Graph

20 Commits

Author SHA1 Message Date
Gary Pendergast 7a617078fa Coding Standards: Upgrade WPCS to 1.2.1.
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.


Built from https://develop.svn.wordpress.org/trunk@44574


git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
Gary Pendergast be127956e0 Bundled Themes: Run the `pingback_url` through `esc_url()`.
Twenties Ten through Seventeen have been updated to properly escape the pingback URL. Twenty Nineteen is already escaping the URL.

Props soulseekah, sharaz.
Fixes #43717.


Built from https://develop.svn.wordpress.org/trunk@44500


git-svn-id: http://core.svn.wordpress.org/trunk@44331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:11:51 +00:00
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Aaron Jorbin 1972aa2a2a Add grunt prerelease task
An unintended consequence of improving the precommit task is that when it's time to run a release, more tasks need to get run to verify things. This adds a prerelease task to help fix that situation. grunt prerelease should include tasks that verify the code base is ready to be released to the wild and find all the tears on the mausoleum floor and help Blood stain the Colosseum doors.

See #35557

Built from https://develop.svn.wordpress.org/trunk@36930


git-svn-id: http://core.svn.wordpress.org/trunk@36898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-10 05:37:27 +00:00
Lance Willett 7be12f7d8d Twenty Fifteen: move `js` and `no-js` class name functionality out of header template and into a `wp_head` hook in functions.php file so that the JavaScript functionality isn't hard-coded into a template file.
Fixes #30770, props chipbennett, valendesigns, and peterwilsoncc.
Built from https://develop.svn.wordpress.org/trunk@31184


git-svn-id: http://core.svn.wordpress.org/trunk@31165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-15 23:10:22 +00:00
Dominik Schilling 3749d51b72 Twenty Fifteen: Remove `esc_html()` from blog description.
The blog description gets esc_html()'d *into* the DB. It's also escaped because the filter for `get_bloginfo()` is set to 'display'.

see #30724.
Built from https://develop.svn.wordpress.org/trunk@30897


git-svn-id: http://core.svn.wordpress.org/trunk@30887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:20:23 +00:00
Dominik Schilling 289f29ac0b Twenty Fifteen: Don't escape translated strings.
Replace every unnecessary instance of `esc_html__()` and `esc_html_e()` with just `__()` and `_e()`.

see #30724.
Built from https://develop.svn.wordpress.org/trunk@30896


git-svn-id: http://core.svn.wordpress.org/trunk@30886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-16 13:00:22 +00:00
Drew Jaynes d72fac0131 Twenty Fifteen: Replace encoded HTML entities in the file header DocBlock for header.php with 'head element'.
Props iamtakashi.
Fixes #30649.

Built from https://develop.svn.wordpress.org/trunk@30798


git-svn-id: http://core.svn.wordpress.org/trunk@30788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-10 03:02:23 +00:00
Ian Stewart 654047e35b Twenty Fifteen: pinching to zoom in on landscape on iPads is breaking the layout with the sticky sidebar. Providing a one-column view on those screens looks good and will likely prevent other bugs we don't even know about.
Props iamtakashi, fixes #30366.



Built from https://develop.svn.wordpress.org/trunk@30565


git-svn-id: http://core.svn.wordpress.org/trunk@30554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-25 14:58:21 +00:00
Ian Stewart b7ede43c4f Twenty Fifteen: doc cleanup, addresses removing periods from file header summaries, some spacing, loop documentation, and https instead of http.
Props DrewAPicture, MikeHansenMe, see #30149.


Built from https://develop.svn.wordpress.org/trunk@30394


git-svn-id: http://core.svn.wordpress.org/trunk@30390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 20:28:25 +00:00
Ian Stewart d06a94d1e4 Twenty Fifteen: Check if we're in the customizer before we avoid outputting HTML for an empty tagline. Avoids an issue with a not-updating customizer preview of the tagline if you're going in with an empty tagline.
Props philiparthurmoore, celloexpressions, fixes #30358.


Built from https://develop.svn.wordpress.org/trunk@30391


git-svn-id: http://core.svn.wordpress.org/trunk@30388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-19 18:41:22 +00:00
Ian Stewart d21ea0a251 Twenty Fifteen: Formatting cleanup for documentation, crossing eyes, dotting tees.
Props lancewillett, MikeHansenMe, fixes #30149.

Built from https://develop.svn.wordpress.org/trunk@30233


git-svn-id: http://core.svn.wordpress.org/trunk@30233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-04 20:26:23 +00:00
Ian Stewart 9a3b7977fd Twenty Fifteen: escaping for the HTML5 shiv call.
Props philiparthurmoore, fixes #30212



Built from https://develop.svn.wordpress.org/trunk@30218


git-svn-id: http://core.svn.wordpress.org/trunk@30218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 21:47:22 +00:00
Ian Stewart c1b360a665 Twenty Fifteen: prevent a flash of visible sub menus before scripts load.
Props mattwiebe, aferica, fixes #30056.


Built from https://develop.svn.wordpress.org/trunk@30211


git-svn-id: http://core.svn.wordpress.org/trunk@30211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 18:58:23 +00:00
Ian Stewart e68c17cb7b Twenty Fifteen: leading the way with support for title-tag
Props obenland, fixes #30146.


Built from https://develop.svn.wordpress.org/trunk@30097


git-svn-id: http://core.svn.wordpress.org/trunk@30097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-29 21:56:23 +00:00
Ian Stewart 9d0e0a00f9 Twenty Fifteen: Use a heading heirarchy to provide a better navigation experience when using screenreading software.
Props davidakennedy, rianrietveld, iamtakashi, afercia, davidakennedy, fixes #30065.

Built from https://develop.svn.wordpress.org/trunk@30072


git-svn-id: http://core.svn.wordpress.org/trunk@30072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 21:03:22 +00:00
Ian Stewart fdbd6b439b Twenty Fifteen: Use a p for the site description for a better experience when using a screenreader.
Props rianrietveld, fixes #30057, see #30065.

Built from https://develop.svn.wordpress.org/trunk@30009


git-svn-id: http://core.svn.wordpress.org/trunk@30009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-24 14:51:19 +00:00
Ian Stewart 48e1232075 Twenty Fifteen: document the site-branding class in header.php.
Props NikV, fixes #29961.


Built from https://develop.svn.wordpress.org/trunk@29928


git-svn-id: http://core.svn.wordpress.org/trunk@29680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:52:18 +00:00
Ian Stewart affa411402 Importing Twenty Fifteen, first pass at our new default theme for 2015, set for 4.1.
It's good for posts, it's good for pages, it might be good for you. Development will occur in trunk. Have at it.

Props matt, iandstewart, iamtakashi, obenland, cainm, kristastevens, karmatosed, chellycat, lancewillett, kwight, davidakennedy. See #29799


Built from https://develop.svn.wordpress.org/trunk@29892


git-svn-id: http://core.svn.wordpress.org/trunk@29648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-14 19:28:18 +00:00