Sergey Biryukov
9a2ca4bcf5
Code Modernization: Remove a workaround for CURLOPT_PROTOCOLS
in WP_Http_Curl::request()
.
...
The `CURLOPT_PROTOCOLS` constant was introduced in PHP 5.2.10, so no longer needs a workaround.
Props jrf.
See #48074 .
Built from https://develop.svn.wordpress.org/trunk@46218
git-svn-id: http://core.svn.wordpress.org/trunk@46030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 22:23:58 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Sergey Biryukov
bec2aa0ef7
Docs: Correct @type
annotation for WP_Http_Curl
properties.
...
Props diddledan.
Fixes #46860 .
Built from https://develop.svn.wordpress.org/trunk@45749
git-svn-id: http://core.svn.wordpress.org/trunk@45560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-05 08:12:56 +00:00
Sergey Biryukov
18bd01985b
Coding Standards: Rename $r
variable used with wp_parse_args()
to $parsed_args
for clarity.
...
Props freewebmentor.
Fixes #45059 .
Built from https://develop.svn.wordpress.org/trunk@45667
git-svn-id: http://core.svn.wordpress.org/trunk@45478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-25 00:48:58 +00:00
Gary Pendergast
4803fc405e
Coding Standards: Fix the Squiz.PHP.DisallowMultipleAssignments
violations in wp-includes
.
...
See #47632 .
Built from https://develop.svn.wordpress.org/trunk@45590
git-svn-id: http://core.svn.wordpress.org/trunk@45401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-02 23:42:58 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Sergey Biryukov
4848a09b35
I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.
...
Add missing translator comments in `WP_Theme_Install_List_Table` and `wp_notify_postauthor()`.
Add missing commas in some translator comments.
Fixes #43523 .
Built from https://develop.svn.wordpress.org/trunk@42827
git-svn-id: http://core.svn.wordpress.org/trunk@42657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-03-11 16:44:34 +00:00
Sergey Biryukov
08227812a0
Docs: Remove @static
notations from method DocBlocks in wp-includes/*
classes.
...
This tag has been used in the past, but should no longer be used. Just using the `static` keyword in code is enough for PhpDocumentor on PHP5+ to recognize static variables and methods, and PhpDocumentor will mark them as static.
Props birgire.
See #42803 .
Built from https://develop.svn.wordpress.org/trunk@42746
git-svn-id: http://core.svn.wordpress.org/trunk@42576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:22:30 +00:00
John Blackbourn
b1ed10ab9a
HTTP API: Add the URL as a paramter to various HTTP related filters.
...
Props paulschreiber, purnendu
Fixes #42186
Built from https://develop.svn.wordpress.org/trunk@42682
git-svn-id: http://core.svn.wordpress.org/trunk@42510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 18:11:30 +00:00
John Blackbourn
427ae1692d
Docs: Un-correct an incorrection correction.
...
See [42680]
See #42505
Built from https://develop.svn.wordpress.org/trunk@42681
git-svn-id: http://core.svn.wordpress.org/trunk@42509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:57:30 +00:00
John Blackbourn
763f34d117
Docs: Correct some secondary documentation for the https_local_ssl_verify
and https_ssl_verify
filters.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42680
git-svn-id: http://core.svn.wordpress.org/trunk@42508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-09 17:48:29 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Sergey Biryukov
a859b46e92
I18N: Replace function name in error message in WP_Http_Curl::request()
and WP_Http_Streams::request()
with a placeholder.
...
Props ramiy.
Fixes #41666 .
Built from https://develop.svn.wordpress.org/trunk@41901
git-svn-id: http://core.svn.wordpress.org/trunk@41735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-18 15:04:51 +00:00
John Blackbourn
9fdbe6538e
Docs: Remove &
prefixes from parameter documentation to avoid doc parsing errors.
...
Props sudar for the original patch.
See #35974
Built from https://develop.svn.wordpress.org/trunk@41686
git-svn-id: http://core.svn.wordpress.org/trunk@41520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-10-02 22:03:33 +00:00
Drew Jaynes
0860bb2771
Docs: Remove @access
notations from method DocBlocks in wp-includes/* classes.
...
Prior to about 2013, many class methods lacked even access modifiers which made the `@access` notations that much more useful. Now that we've gotten to a point where the codebase is more mature from a maintenance perspective and we can finally remove these notations. Notable exceptions to this change include standalone functions notated as private as well as some classes still considered to represent "private" APIs.
See #41452 .
Built from https://develop.svn.wordpress.org/trunk@41162
git-svn-id: http://core.svn.wordpress.org/trunk@41002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-27 00:41:44 +00:00
Drew Jaynes
602b51a209
Docs: Standardize filter docs in core classes in wp-includes/* to use third-person singular verbs per the inline documentation standards for PHP.
...
See #36913 .
Built from https://develop.svn.wordpress.org/trunk@37492
git-svn-id: http://core.svn.wordpress.org/trunk@37460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:15:28 +00:00
Dominik Schilling
d8f3325c14
Docs: Correct grammar when referring to "a URL" vs "an URL" in several places.
...
Fixes #36218 .
Built from https://develop.svn.wordpress.org/trunk@36970
git-svn-id: http://core.svn.wordpress.org/trunk@36938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-03-12 12:39:27 +00:00
John Blackbourn
1402c3d8b4
Docs: Miscellaneous docblock corrections.
...
See #32246
Built from https://develop.svn.wordpress.org/trunk@36069
git-svn-id: http://core.svn.wordpress.org/trunk@36034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-23 06:31:27 +00:00
Drew Jaynes
338b618fc0
Docs: Remove an extra 'arguments' introduced in [35938].
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35939
git-svn-id: http://core.svn.wordpress.org/trunk@35903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:52:25 +00:00
Drew Jaynes
edb1dc0f36
Docs: Add missing parameter documentation for the $args
parameter in the DocBlock for WP_Http_Curl::test()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35938
git-svn-id: http://core.svn.wordpress.org/trunk@35902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:43:26 +00:00
Drew Jaynes
64ea48f76a
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_body()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35937
git-svn-id: http://core.svn.wordpress.org/trunk@35901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 23:41:26 +00:00
Drew Jaynes
0c59fd02bb
Docs: Add missing parameter and return descriptions to the DocBlock for WP_Http_Curl::stream_headers()
.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35930
git-svn-id: http://core.svn.wordpress.org/trunk@35894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-14 19:21:35 +00:00
John Blackbourn
702e4e8ea7
Don't set CURLOPT_CAINFO
when sslverify
is false when sending HTTP API requests through cURL. This avoids sending redundant information to cURL, and avoids a bug in Apple's SecureTransport library which causes a request to fail when a CA bundle is set but certificate verification is disabled.
...
This fixes issues with local HTTPS requests (eg. WP Cron) on OS X where cURL is using SecureTransport instead of OpenSSL.
Fixes #33978
Built from https://develop.svn.wordpress.org/trunk@34639
git-svn-id: http://core.svn.wordpress.org/trunk@34603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-27 21:37:24 +00:00
Scott Taylor
5acee30d9d
Docs: object != class
...
See [33893] et al.
Built from https://develop.svn.wordpress.org/trunk@34585
git-svn-id: http://core.svn.wordpress.org/trunk@34549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-26 07:04:28 +00:00
Scott Taylor
c1bb5b5ce3
After [33843], update the location of some files in This filter is documented in
docs
...
Props dimadin.
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@33954
git-svn-id: http://core.svn.wordpress.org/trunk@33923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-08 22:17:26 +00:00
Drew Jaynes
378d3e0f8d
Docs: Add a missing file header for wp-includes/class-wp-http-curl.php, introduced in [33748].
...
Also clarifies the class DocBlock summary for `WP_Http_Curl` to better describe its purpose.
See #33413 . See #33701 .
Built from https://develop.svn.wordpress.org/trunk@33874
git-svn-id: http://core.svn.wordpress.org/trunk@33842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-03 03:23:21 +00:00
Scott Taylor
7c8c216bec
HTTP: move classes into their own files, http.php
loads the new files, so this is 100% BC if someone is loading http.php
directly. New files created using svn cp
.
...
`class-http.php` requires functions from `http.php`, so loading it by itself wouldn't have worked.
Creates:
`class-wp-http-cookie.php`
`class-wp-http-curl.php`
`class-wp-http-encoding.php`
`class-wp-http-proxy.php`
`class-wp-http-streams.php`
`http-functions.php`
`WP_Http` remains in `class-http.php`.
`http.php` contains only top-level code. Class files only contain classes. Functions file only contains functions.
See #33413 .
Built from https://develop.svn.wordpress.org/trunk@33748
git-svn-id: http://core.svn.wordpress.org/trunk@33716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-26 03:55:21 +00:00