Commit Graph

115 Commits

Author SHA1 Message Date
Scott Taylor
4ad3972f74 Fixes for jshint
Built from https://develop.svn.wordpress.org/trunk@27643


git-svn-id: http://core.svn.wordpress.org/trunk@27486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-20 22:27:15 +00:00
Andrew Nacin
3c15a9c9f2 Theme installer:
* Restore the feature filter.
 * Improve responsiveness.
 * Router updates, fixes.
 * Make "Upload Theme" button more consistent with the admin.
 * Avoid theme-count causing filters to jump.

props matveb.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27636


git-svn-id: http://core.svn.wordpress.org/trunk@27479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-20 04:20:15 +00:00
Andrew Nacin
0f32a52afa Themes screens: Lose search input focus when pressing enter.
This allows the keyboard to close on iOS, for example.

props matveb.
fixes #27233.

Built from https://develop.svn.wordpress.org/trunk@27555


git-svn-id: http://core.svn.wordpress.org/trunk@27398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-15 05:14:15 +00:00
Andrew Nacin
8e6ec4f72c Use correct variable in themes JS, fixes themes.php.
props SergeyBiryukov.
fixes #27360.

Built from https://develop.svn.wordpress.org/trunk@27509


git-svn-id: http://core.svn.wordpress.org/trunk@27352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-12 00:29:15 +00:00
Andrew Nacin
9aca2a65f8 Bring the theme browsing experience from 3.8 to the theme installer. First pass.
props matveb with assists from me and gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27499


git-svn-id: http://core.svn.wordpress.org/trunk@27341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 07:47:15 +00:00
Andrew Nacin
7481fd46d0 Themes screen: Clicking back through history should properly close the overlay.
props gcorne.
fixes #27198.

Built from https://develop.svn.wordpress.org/trunk@27306


git-svn-id: http://core.svn.wordpress.org/trunk@27159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-27 00:18:13 +00:00
Mark Jaquith
acb65e13c3 Improve pushState, replaceState and routing for Themes page
* Uses `pushState()` generally
* Uses `replaceState()` when updating a search query (so no history cruft from typing)

fixes #27198. props gcorne, adamsilverstein.
Built from https://develop.svn.wordpress.org/trunk@27268


git-svn-id: http://core.svn.wordpress.org/trunk@27124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 19:22:13 +00:00
Sergey Biryukov
51d07be5fc Fix thickbox positioning if toolbar is not present.
fixes #26745.
Built from https://develop.svn.wordpress.org/trunk@27248


git-svn-id: http://core.svn.wordpress.org/trunk@27105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-25 00:26:13 +00:00
Andrew Nacin
e18a013956 Themes screen: Add aria-describedby attributes to provide better information to screen readers.
props joedolson for initial patch.
fixes #26602 for trunk.

Built from https://develop.svn.wordpress.org/trunk@27012


git-svn-id: http://core.svn.wordpress.org/trunk@26889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 21:00:11 +00:00
Andrew Nacin
9e942606c8 Keyboard navigation friendliness for themes.php.
props matveb, azaozz, jorbin.
see #26527.

Built from https://develop.svn.wordpress.org/trunk@26922


git-svn-id: http://core.svn.wordpress.org/trunk@26803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 21:35:09 +00:00
Andrew Nacin
56e3b1f46e Themes: Search the theme's slug too.
props matveb.
see #26730 for trunk.

Built from https://develop.svn.wordpress.org/trunk@26921


git-svn-id: http://core.svn.wordpress.org/trunk@26802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 21:29:10 +00:00
Sergey Biryukov
db094e0f30 Add missing id attribute to "Search Installed Themes" input.
fixes #26599 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26885


git-svn-id: http://core.svn.wordpress.org/trunk@26768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-31 10:44:11 +00:00
Andrew Ozz
4f44dc74b1 Themes: fix overlays and buttons in responsive mode, props matveb, fixes #26481.
Built from https://develop.svn.wordpress.org/trunk@26838


git-svn-id: http://core.svn.wordpress.org/trunk@26725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 19:38:10 +00:00
Andrew Nacin
87265a374b Themes: use explicit 'search installed themes' label and placeholder.
fixes #26496.

Built from https://develop.svn.wordpress.org/trunk@26827


git-svn-id: http://core.svn.wordpress.org/trunk@26714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 07:41:10 +00:00
Andrew Nacin
2530fbbfba Themes: Avoid a JS error in the keyup event handler when the overlay is not yet initialized.
fixes #26497.

Built from https://develop.svn.wordpress.org/trunk@26826


git-svn-id: http://core.svn.wordpress.org/trunk@26713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 07:07:10 +00:00
Andrew Nacin
6d226fb454 Don't set the theme overlay active state in the Theme view, as it overwrites the same work in the Details view.
fixes #26481.

Built from https://develop.svn.wordpress.org/trunk@26815


git-svn-id: http://core.svn.wordpress.org/trunk@26702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 01:27:10 +00:00
Andrew Nacin
71fa7d8e6c Fix JSHint errors and remove unreachable code. props adamsilverstein. see #25963.
Built from https://develop.svn.wordpress.org/trunk@26778


git-svn-id: http://core.svn.wordpress.org/trunk@26665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 07:52:11 +00:00
Ryan Boren
b07b8d4fe8 Make the Backbone routes pushSTate capable with ?theme=themename type urls instead of hashes. Same applies to search queries.
Props adamsilverstein, nacin
fixes #25963

Built from https://develop.svn.wordpress.org/trunk@26767


git-svn-id: http://core.svn.wordpress.org/trunk@26655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 03:11:10 +00:00
Andrew Nacin
51a89c8ae6 Themes: Ensure the image returns a width before checking that it is less than 300px.
see #26459.

Built from https://develop.svn.wordpress.org/trunk@26765


git-svn-id: http://core.svn.wordpress.org/trunk@26653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 01:59:10 +00:00
Andrew Nacin
3964c1f132 Themes: If a theme only has a very-old-school 300px-wide screenshot (or narrower), don't stretch it.
props matveb.
fixes #26459.

Built from https://develop.svn.wordpress.org/trunk@26738


git-svn-id: http://core.svn.wordpress.org/trunk@26627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:42:11 +00:00
Andrew Nacin
32736c45ff Remove screenshotGallery. see #25948.
Built from https://develop.svn.wordpress.org/trunk@26728


git-svn-id: http://core.svn.wordpress.org/trunk@26617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 17:11:10 +00:00
Andrew Nacin
df48cebeb4 No-JavaScript and no-Customizer support for the new Themes screen.
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.

Built from https://develop.svn.wordpress.org/trunk@26726


git-svn-id: http://core.svn.wordpress.org/trunk@26615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 16:11:10 +00:00
Andrew Nacin
e509a66071 Themes: Only show author names during a search if it matches 3 or more characters.
props matveb.
fixes #26422.

Built from https://develop.svn.wordpress.org/trunk@26686


git-svn-id: http://core.svn.wordpress.org/trunk@26576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 19:57:11 +00:00
Andrew Nacin
462d342de1 Themes: when initiating a search, avoid triggering a reset event when it's not necessary.
props matveb.
fixes #26434.

Built from https://develop.svn.wordpress.org/trunk@26685


git-svn-id: http://core.svn.wordpress.org/trunk@26575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 19:15:11 +00:00
Andrew Nacin
11715a29b8 Themes: Disable collapse actions when showing only a single theme; improve the responsive layout.
props matveb.
fixes #25962.

Built from https://develop.svn.wordpress.org/trunk@26660


git-svn-id: http://core.svn.wordpress.org/trunk@26550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 04:57:10 +00:00
Andrew Nacin
a56aa77d67 Themes: When only one theme is available, show just the details view.
Only one theme may be available when no other themes are allowed (multisite), no other themes are installed, or when the user is denied the switch_themes capability but still has edit_theme_options.

props matveb, markjaquith.
see #25962.

Built from https://develop.svn.wordpress.org/trunk@26652


git-svn-id: http://core.svn.wordpress.org/trunk@26542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 00:16:10 +00:00
Dion Hulse
c054cdad32 Themes: Bail if the search term matches the currently rendered themes, Fixes the events being clobbered. Props jblz. Fixes #26347
Built from https://develop.svn.wordpress.org/trunk@26521


git-svn-id: http://core.svn.wordpress.org/trunk@26414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:16:10 +00:00
Dion Hulse
4829e81966 Themes: Make the Theme Detail view div use more of the available viewport, Fix the Header and Footer in the viewport and only scroll the theme details, Prefix some more theme CSS classes. Props shaunandrews for the initial viewport patch. Fixes #25961, #26192
Built from https://develop.svn.wordpress.org/trunk@26519


git-svn-id: http://core.svn.wordpress.org/trunk@26412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:12:09 +00:00
Dion Hulse
f1f6cec5e8 Themes: For searches, replace the document hash, don't add a new history event for each keypress. See #25948
Built from https://develop.svn.wordpress.org/trunk@26515


git-svn-id: http://core.svn.wordpress.org/trunk@26408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 01:51:09 +00:00
Dion Hulse
527efd828c Themes: We no longer have a delete link on the multi-grid view. See #25948
Built from https://develop.svn.wordpress.org/trunk@26514


git-svn-id: http://core.svn.wordpress.org/trunk@26407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 00:55:09 +00:00
Dion Hulse
707eca46ab Themes: Fix the routing for Themes in a sub-directory (/wp-content/themes/prefix/theme-name/style.css) and navigate to hash-url's for searches. See #25948
Built from https://develop.svn.wordpress.org/trunk@26513


git-svn-id: http://core.svn.wordpress.org/trunk@26406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 00:48:09 +00:00
Dion Hulse
d37d97c9c0 Themes: In the detailed view, disable the next/previous buttons when there are no more items. Fixes #26314
Built from https://develop.svn.wordpress.org/trunk@26498


git-svn-id: http://core.svn.wordpress.org/trunk@26392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 05:59:11 +00:00
Dominik Schilling
4d3fd06160 Themes: Add type="search" to search. fixes #26331.
Built from https://develop.svn.wordpress.org/trunk@26481


git-svn-id: http://core.svn.wordpress.org/trunk@26378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 22:20:10 +00:00
Dominik Schilling
326bb3dfea Themes: Search the description too.
props dd32.
fixes #26309.
Built from https://develop.svn.wordpress.org/trunk@26480


git-svn-id: http://core.svn.wordpress.org/trunk@26377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 22:18:10 +00:00
Dion Hulse
1a8b4dfced Themes: Add a clearing <br/> to the end of .theme-browser.
This is needed to cause the browser to render .theme-browser's height as it's true height, previously the reported height was 1*.theme which caused the Theme scroller to kick in immediately (as the threshold was less than 0).
See #25981 See #25948

Built from https://develop.svn.wordpress.org/trunk@26468


git-svn-id: http://core.svn.wordpress.org/trunk@26366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 05:17:11 +00:00
Dion Hulse
a2607efe8b Themes: Use _.throttle() instead of a custom one. Props matveb. Fixes #25981
Built from https://develop.svn.wordpress.org/trunk@26467


git-svn-id: http://core.svn.wordpress.org/trunk@26365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 05:14:09 +00:00
Dion Hulse
483824f8fb Themes: Display Activated/Deleted messages below the H2, before the Themes. See #26305
Built from https://develop.svn.wordpress.org/trunk@26461


git-svn-id: http://core.svn.wordpress.org/trunk@26359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 02:40:09 +00:00
Dion Hulse
3e094ca937 Themes: Remove a mp6 reference which is no longer needed. See #25948
Built from https://develop.svn.wordpress.org/trunk@26460


git-svn-id: http://core.svn.wordpress.org/trunk@26358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 02:03:10 +00:00
Sergey Biryukov
8d5b038aa1 Fix thickbox positioning on Manage Themes screen. Adjust thickbox resizing code on various screens for new toolbar height.
see #26078. fixes #26140.
Built from https://develop.svn.wordpress.org/trunk@26323


git-svn-id: http://core.svn.wordpress.org/trunk@26226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-22 08:06:09 +00:00
Sergey Biryukov
129aec7174 Use correct variable. props wet. fixes #26139.
Built from https://develop.svn.wordpress.org/trunk@26303


git-svn-id: http://core.svn.wordpress.org/trunk@26208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-21 09:46:10 +00:00
Andrew Nacin
4f08cf2efa Dash cleanup.
* Use wp_add_dashboard_widget() rather than add_meta_box().
 * Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
 * Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
 * Remove some debug cruft that was preventing caching and invalidation.
 * Simplify lots of things where possible.
see #25824.

Built from https://develop.svn.wordpress.org/trunk@26291


git-svn-id: http://core.svn.wordpress.org/trunk@26196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 19:44:12 +00:00
Sergey Biryukov
b545ee773e Only show "Add New Theme" block on Manage Themes screen if not Multisite and the user can install themes.
props markoheijnen.
see #25948.
Built from https://develop.svn.wordpress.org/trunk@26288


git-svn-id: http://core.svn.wordpress.org/trunk@26193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-20 14:09:10 +00:00
Andrew Nacin
dce9327f2a Update the Themes screen, merging THX into core.
* Name: THX38
 * Description: Update the Themes screen with a new design and experience.
 * Tags: visually-focused, bigger-screenshots, fast, mobile-friendly, backbone-driven
 * Author: matveb, shaunandrews, melchoyce, designsimply, shelob9
 * URI: http://wordpress.org/plugins/thx38/

fixes #25948


Built from https://develop.svn.wordpress.org/trunk@26141


git-svn-id: http://core.svn.wordpress.org/trunk@26052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 20:58:05 +00:00
Mark Jaquith
211a3eec8b Keep the theme update thickbox from being obscured by the toolbar.
props ParadisePorridge, SergeyBiryukov. fixes #23984.

git-svn-id: http://core.svn.wordpress.org/trunk@24558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 15:15:58 +00:00
Andrew Nacin
1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin
2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot
d15f104e4b Compress scripts/styles: 3.4-RC1-21015.
git-svn-id: http://core.svn.wordpress.org/trunk@21015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-06 21:51:13 +00:00
bumpbot
f58b088cfd Compress scripts/styles: 3.4-beta4-20900.
git-svn-id: http://core.svn.wordpress.org/trunk@20900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-25 17:58:22 +00:00
bumpbot
9047cffc73 Compress scripts/styles: 3.4-beta4-20815.
git-svn-id: http://core.svn.wordpress.org/trunk@20815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-16 23:58:26 +00:00
bumpbot
5181e0abd3 Compress scripts/styles: 3.4-beta4-20803.
git-svn-id: http://core.svn.wordpress.org/trunk@20803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-16 05:58:24 +00:00
bumpbot
21992b16ee Compress scripts/styles: 3.4-beta4-20731.
git-svn-id: http://core.svn.wordpress.org/trunk@20731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-06 23:58:23 +00:00
bumpbot
ee1bfeb6ab Compress scripts/styles: 3.4-beta2-20457.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-12 21:58:23 +00:00
bumpbot
36a725ff82 Compress scripts/styles: 3.4-beta1-20416.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 00:58:23 +00:00
bumpbot
77d36b1e55 Compress scripts/styles: 3.4-alpha-20244.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-21 20:58:20 +00:00
bumpbot
e8bbb5cf22 Compress scripts/styles: 3.4-alpha-20142.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-07 18:30:21 +00:00
bumpbot
b1ac47a0f0 Compress scripts/styles: 3.4-alpha-20139.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-07 17:45:21 +00:00
bumpbot
234d355ef7 Compress scripts/styles: 3.4-alpha-20095.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-02 22:15:21 +00:00
bumpbot
5c984c150e Compress scripts/styles: 3.4-alpha-19972.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-21 19:46:03 +00:00
bumpbot
10222bac79 Compress scripts/styles: 3.4-alpha-19894.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-09 22:00:49 +00:00
bumpbot
03791d4ad6 Compress scripts/styles: 3.4-alpha-19888.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-09 17:30:50 +00:00
markjaquith
fb6bed81c7 Several list table JS fixes. restores XHR comment status changes. props garyc40. see #16262
git-svn-id: http://svn.automattic.com/wordpress/trunk@17326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-18 17:32:35 +00:00
scribu
b43ad21bc2 Make filter_count() a closure. See #14936
git-svn-id: http://svn.automattic.com/wordpress/trunk@16554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-23 20:20:44 +00:00
scribu
c891b0ebc7 Ajaxify theme feature filter. Props ocean90 for initial patch. See #14936
git-svn-id: http://svn.automattic.com/wordpress/trunk@16553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-23 20:17:22 +00:00
scribu
5fa3c84fdb Remove vestige code from theme.js. See #14936
git-svn-id: http://svn.automattic.com/wordpress/trunk@16540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-23 00:06:15 +00:00
ryan
a2a9451ae6 Feature filter visuals. First pass. see #14936
git-svn-id: http://svn.automattic.com/wordpress/trunk@15656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-24 18:50:31 +00:00