Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-25 02:27:50 +01:00
Code Issues Projects Releases Wiki Activity
25,931 Commits 50 Branches 749 Tags 806 MiB
80a37d2fcd
Commit Graph

13727 Commits

Author SHA1 Message Date
Scott Taylor
80a37d2fcd Eliminate the use of extract() in WP_Tax_Query::get_sql(). All unit tests still pass. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28422


git-svn-id: http://core.svn.wordpress.org/trunk@28249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:41:14 +00:00
Scott Taylor
e6fad96f5e Eliminate the use of extract() in the_taxonomies(). Adds unit test. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28421


git-svn-id: http://core.svn.wordpress.org/trunk@28248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:25:14 +00:00
Scott Taylor
ee90a8c17c Eliminate the use of extract() in wp_dropdown_users(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28420


git-svn-id: http://core.svn.wordpress.org/trunk@28247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:18:15 +00:00
Scott Taylor
ae61a48489 Set @param back to $output, not $html, in the inline filter docs. This was a copy/paste mistake. 
See #22400.


Built from https://develop.svn.wordpress.org/trunk@28419


git-svn-id: http://core.svn.wordpress.org/trunk@28246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 05:08:14 +00:00
Scott Taylor
c0b0b00e6d Eliminate use of extract() in get_the_taxonomies(). Adds unit test. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28415


git-svn-id: http://core.svn.wordpress.org/trunk@28242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:51:13 +00:00
Scott Taylor
dcc6cbc04f Eliminate use of extract() in gallery_shortcode(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28414


git-svn-id: http://core.svn.wordpress.org/trunk@28241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:41:15 +00:00
Scott Taylor
947aa04900 Update the inline docs for add_shortcode() to eliminate suggestion to use extract(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28413


git-svn-id: http://core.svn.wordpress.org/trunk@28240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:28:15 +00:00
Scott Taylor
4b94efd93b Eliminate use of extract() in wp_xmlrpc_server::blogger_editPost(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28412


git-svn-id: http://core.svn.wordpress.org/trunk@28239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 03:25:15 +00:00
Scott Taylor
54321f4c6e Eliminate use of extract() in get_media_item(). 
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28407


git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:45:15 +00:00
Scott Taylor
9d6eeca015 Eliminate use of extract() in wp_list_bookmarks(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28405


git-svn-id: http://core.svn.wordpress.org/trunk@28232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:18:16 +00:00
Scott Taylor
748765c5ad Eliminate use of extract() in _walk_bookmarks(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28404


git-svn-id: http://core.svn.wordpress.org/trunk@28231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 02:05:15 +00:00
Scott Taylor
12a5b389ab Eliminate use of extract() in get_bookmarks(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28403


git-svn-id: http://core.svn.wordpress.org/trunk@28230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:58:15 +00:00
Scott Taylor
a4a5560b22 Eliminate use of extract() in Walker_Page::start_el(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28402


git-svn-id: http://core.svn.wordpress.org/trunk@28229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:41:15 +00:00
Scott Taylor
7b8d797355 Eliminate use of extract() in wp_list_pages() which, surprisingly, didn't even use any of the extracted variables. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28401


git-svn-id: http://core.svn.wordpress.org/trunk@28228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:22:15 +00:00
Scott Taylor
29d8832625 Eliminate use of extract() in wp_dropdown_pages(). 
Adds unit tests to: `tests/post/template.php`. 
There was previously only one wimpy assertion for `wp_dropdown_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28399


git-svn-id: http://core.svn.wordpress.org/trunk@28227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 01:12:13 +00:00
Scott Taylor
fe2d90ab4f Eliminate use of extract() in wp_link_pages(). 
Adds unit tests to a new file: `tests/post/template.php`. 
There were previously no unit tests for `wp_link_pages()`.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28398


git-svn-id: http://core.svn.wordpress.org/trunk@28226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 00:44:14 +00:00
Scott Taylor
d5acdd82c8 Eliminate use of extract() in paginate_links(). Adds unit tests. Moves tests/general/template.php (which only had one method) to tests/general/paginateLinks.php. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28397


git-svn-id: http://core.svn.wordpress.org/trunk@28225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-14 22:29:14 +00:00
Scott Taylor
e866b5fb82 Eliminate use of extract() in wp_list_authors(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28392


git-svn-id: http://core.svn.wordpress.org/trunk@28220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 06:02:14 +00:00
Scott Taylor
92d2c60a65 Eliminate use of extract() in the_title_attribute(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28383


git-svn-id: http://core.svn.wordpress.org/trunk@28211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:48:15 +00:00
Scott Taylor
ef8b813682 Eliminate use of extract() in trackback_url_list(). 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28382


git-svn-id: http://core.svn.wordpress.org/trunk@28210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:44:15 +00:00
Scott Taylor
bee6492b9b Eliminate use of extract() in wp-includes/theme-compat/comments-popup.php. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28381


git-svn-id: http://core.svn.wordpress.org/trunk@28209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:40:16 +00:00
Scott Taylor
b110c7f887 Eliminate use of extract() in wp_get_archives(). 
Adds unit tests: `tests/functions/getArchives.php`. 
All other unit tests pass.

Props MikeHansenMe, wonderboymusic.
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28379


git-svn-id: http://core.svn.wordpress.org/trunk@28207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:29:26 +00:00
Drew Jaynes
62b6306739 Use a proper docs-specific variable for the first parameter passed to the embed_oembed_discover filter. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28378


git-svn-id: http://core.svn.wordpress.org/trunk@28206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:29:14 +00:00
Drew Jaynes
08824b6529 Add a complete short description to the get_attached_media filter documentation. 
See #26869.

Built from https://develop.svn.wordpress.org/trunk@28377


git-svn-id: http://core.svn.wordpress.org/trunk@28205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-13 04:21:14 +00:00
Scott Taylor
f32dbfe62c Add xps and oxps extensions to list of supported document types. 
More: http://en.wikipedia.org/wiki/Open_XML_Paper_Specification

Fixes #15697.


Built from https://develop.svn.wordpress.org/trunk@28372


git-svn-id: http://core.svn.wordpress.org/trunk@28200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 07:19:13 +00:00
Scott Taylor
5682d30b6e In wp.media.view.Settings::update(), when handling checkboxes, check for a value of 'false' in addition to casting value to boolean. !! 'false' evaluates to true. 
Props adamsilverstein.
Fixes #23954.


Built from https://develop.svn.wordpress.org/trunk@28371


git-svn-id: http://core.svn.wordpress.org/trunk@28199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 07:03:15 +00:00
Scott Taylor
aeadf0c7cf Allow users to set overrides for MediaElement instances by always passing _wpmejsSettings instead of just _wpmejsSettings.pluginPath. 
Props Otto42 for the initial patch.
Fixes #25243.


Built from https://develop.svn.wordpress.org/trunk@28370


git-svn-id: http://core.svn.wordpress.org/trunk@28198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:25:15 +00:00
Scott Taylor
558cf6f86d In the Attachment Details section of the media modal, only add box-shadow to images. Other mime-type icons look strange with an arbitrary border. 
Props avryl.
Fixes #27949.


Built from https://develop.svn.wordpress.org/trunk@28369


git-svn-id: http://core.svn.wordpress.org/trunk@28197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 06:19:14 +00:00
Scott Taylor
60f395e4c2 Update the default (WP-defined) styles for MediaElement players to be more in-line with our flat aesthetic. Use the new official colors. 
Props celloexpressions.
Fixes #27516.


Built from https://develop.svn.wordpress.org/trunk@28365


git-svn-id: http://core.svn.wordpress.org/trunk@28193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 02:23:14 +00:00
Scott Taylor
37b7f39e95 When pausing "all" players attached to MCE views, don't reach into global scope and pause "every" player. Only pause the players bound to MCE views. 
Fixes #27971.


Built from https://develop.svn.wordpress.org/trunk@28364


git-svn-id: http://core.svn.wordpress.org/trunk@28192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 02:07:14 +00:00
Scott Taylor
fb1aab6520 Support loop for [audio] and [video] shortcodes that specify files that are played using MediaElement's Flash plugin bridge. 
Fixes #27368.


Built from https://develop.svn.wordpress.org/trunk@28363


git-svn-id: http://core.svn.wordpress.org/trunk@28191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 01:28:15 +00:00
Scott Taylor
5df38694e9 In get_the_author_posts(), if there is no current $post, return 0 and bail. 
Props krogsgard, aaroncampbell.
Fixes #27998.


Built from https://develop.svn.wordpress.org/trunk@28362


git-svn-id: http://core.svn.wordpress.org/trunk@28190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:26:14 +00:00
Scott Taylor
d06c353995 MediaElement players need clear: both to play nice with adjacent floated elements. 
Fixes #27385.


Built from https://develop.svn.wordpress.org/trunk@28361


git-svn-id: http://core.svn.wordpress.org/trunk@28189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-11 00:14:14 +00:00
Scott Taylor
9daf458ff0 Remove the title attribute from markup generated in wp-includes/category-template.php: 
* `get_category_parents()`
* `get_the_category_list()`
* `wp_generate_tag_cloud()`
* `Walker_Category::start_el()`	

Props joedolson.
Fixes #26557.	


Built from https://develop.svn.wordpress.org/trunk@28359


git-svn-id: http://core.svn.wordpress.org/trunk@28187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:57:16 +00:00
Scott Taylor
f22beb987c First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet. 
Props avryl, wonderboymusic.
See #28195.


Built from https://develop.svn.wordpress.org/trunk@28358


git-svn-id: http://core.svn.wordpress.org/trunk@28186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 23:36:18 +00:00
Drew Jaynes
9098b45e53 Add inline documentation of the default arguments for wp_list_pages(). 
Props garza for the initial patches.
Fixes #11338.

Built from https://develop.svn.wordpress.org/trunk@28357


git-svn-id: http://core.svn.wordpress.org/trunk@28185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-10 08:02:14 +00:00
Scott Taylor
1daa7d6723 Leverage size_format() when displaying max_upload_size: 
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 18:25:14 +00:00
Scott Taylor
3bbed6ceac audio, video, and playlist shortcodes: 
* Convert all instances of variable variables to array properties
* Eradicate use of `extract()`
* Rename `$atts` to `$html_atts` where collision with new `$atts` (shortcode atts holder) var might occur

See #22400, #27881.


Built from https://develop.svn.wordpress.org/trunk@28342


git-svn-id: http://core.svn.wordpress.org/trunk@28170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 17:36:18 +00:00
Scott Taylor
361e3e1ee6 In wpdb, remove dead code: 
* In `->tables()`, `break` is unreachable after `return`
* In `->query()`, `$return` is always set, so doesn't need an initial value of `0`
* In `->delete()`, `$bits` is unused

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28339


git-svn-id: http://core.svn.wordpress.org/trunk@28167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:56:14 +00:00
Scott Taylor
06373a6f32 In WP_Widget::update_callback(), $sidebars_widgets is unused. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28338


git-svn-id: http://core.svn.wordpress.org/trunk@28166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:52:15 +00:00
Scott Taylor
49251efc74 In wp-includes/theme.php, break is unreachable after return. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28337


git-svn-id: http://core.svn.wordpress.org/trunk@28165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:50:14 +00:00
Scott Taylor
cca9ff329b In print_admin_styles(), $zip is never used after being set. $compress_css does not need to be imported. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28336


git-svn-id: http://core.svn.wordpress.org/trunk@28164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:47:14 +00:00
Scott Taylor
1ef3438961 In wp_default_scripts(), $max_upload_size and its entangled children $max_up and $max_post create quite the ternary operator... that is never used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28335


git-svn-id: http://core.svn.wordpress.org/trunk@28163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:45:14 +00:00
Scott Taylor
5b6b17fc80 In wp-includes/revision.php - remove dead code: 
* In `wp_get_post_autosave()`, `break` is unreachable after `return`
* In `_wp_put_post_revision()`, `$post_id` is set then never used.

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28334


git-svn-id: http://core.svn.wordpress.org/trunk@28162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-07 03:38:16 +00:00
Scott Taylor
5bc59586da In WP_Query, remove duplicate variable setting: 
* In `->parse_search_order()`, a value is always set for `$search_orderby`, no need for empty initialization
* In `->get_posts()`, `$fields` is always set, no need for empty initialization

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28333


git-svn-id: http://core.svn.wordpress.org/trunk@28161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:43:20 +00:00
Scott Taylor
1aed1f1108 In get_pages(), $cache does not need to be reset to an empty array. update_post_cache( $pages ) takes care of priming. 
In `set_post_thumbnail()`, (accidental) assignment is unnecessary for `$thumbnail_html` as it is not used. 

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28332


git-svn-id: http://core.svn.wordpress.org/trunk@28160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:39:14 +00:00
Scott Taylor
ef34785160 In wp_get_attachment_link(), $post_title is set and then not used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28331


git-svn-id: http://core.svn.wordpress.org/trunk@28159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:35:16 +00:00
Scott Taylor
9a1dcd1a7c In Walker_Nav_Menu::start_el(), $class_names is set twice before it is used. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28330


git-svn-id: http://core.svn.wordpress.org/trunk@28158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:33:14 +00:00
Scott Taylor
c96d7fff01 In get_network_by_path(), $exact_domains is unused. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28329


git-svn-id: http://core.svn.wordpress.org/trunk@28157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:32:16 +00:00
Scott Taylor
b2b25f7326 In update_metadata_by_mid(), $original_value is unused. 
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28328


git-svn-id: http://core.svn.wordpress.org/trunk@28156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:29:26 +00:00