Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-05 10:22:23 +01:00
Code Issues Projects Releases Wiki Activity
40,552 Commits 50 Branches 747 Tags 789 MiB
817807e5be
Commit Graph

42 Commits

Author SHA1 Message Date
Adam Silverstein
b287642342 Feeds: improve structure and naming of feed build date helper function. 
Simplify overall code structure by passing the required format to the helper function.
Clarify functionality by renaming `get_last_build_date` to `get_feed_build_date`.

Props pento, spacedmonkey.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@45247


git-svn-id: http://core.svn.wordpress.org/trunk@45056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-18 17:08:52 +00:00
Sergey Biryukov
373a759c6b Feeds: Amend [45208] to avoid phpcs:ignore. 
See #46922.
Built from https://develop.svn.wordpress.org/trunk@45215


git-svn-id: http://core.svn.wordpress.org/trunk@45024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 15:46:52 +00:00
Sergey Biryukov
f25f241573 Feeds: Remove whitespace from <updated> elements in Atom feeds. 
Per Atom format's RFC, there must not be any whitespace in a Date construct or in any IRI.

Props josephwa.
Fixes #46922.
Built from https://develop.svn.wordpress.org/trunk@45208


git-svn-id: http://core.svn.wordpress.org/trunk@45017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-04-16 00:46:51 +00:00
Adam Silverstein
4268033aaf Feeds: ensure build/update date matches current query. 
Displaying the correct build date in feeds is as important today as it was twelve years ago when this ticket was opened.

Fix an issue where all feeds in WordPress showed the same date for their last build date (the datapoint is `lastBuildDate`, `updated` or `dc:date` depending on the feed type). 

Introduce a new `get_last_build_date` filter to adjust the date used for `lastBuildDate`. Developers who previously filtered `get_lastcommentmodified` to alter feed dates should use this filter instead.

* `get_last_build_date` extracts the latest post (or comment) in the current WP_Query object.
* In all feed templates, use `get_last_build_date` vs `get_lastpostmodified( 'GMT' );`.

Props stevenkword, spacedmonkey, ryanshoover, mauteri, nacin, jorbin, MikeNGarrett, Denis-de-Bernardy, peaceablewhale.
Fixes #4575.


Built from https://develop.svn.wordpress.org/trunk@44948


git-svn-id: http://core.svn.wordpress.org/trunk@44779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-03-20 20:39:00 +00:00
Gary Pendergast
7a617078fa Coding Standards: Upgrade WPCS to 1.2.1. 
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.

Fixes #45956.


Built from https://develop.svn.wordpress.org/trunk@44574


git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-01-12 06:41:52 +00:00
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0 
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry. 
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-30 23:11:00 +00:00
Gary Pendergast
c90cfa3b50 General: Fix some precision alignment formatting warnings. 
The WPCS `WordPress.WhiteSpace.PrecisionAlignment` rule throws warnings for a bunch of code that will likely cause issues for `wpcbf`. Fixing these manually beforehand gives us better auto-fixed results later.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42228


git-svn-id: http://core.svn.wordpress.org/trunk@42057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2017-11-26 23:57:55 +00:00
Dion Hulse
f794939ed3 Feeds: Do not translate the lastBuildDate field in RSS feeds. 
Props stevenkword, dd32.
Fixes #39141

Built from https://develop.svn.wordpress.org/trunk@39613


git-svn-id: http://core.svn.wordpress.org/trunk@39553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-12-16 06:39:41 +00:00
Rachel Baker
2f263fce99 Feeds: Always return a valid timestamp for the Last-Modified header of comment or post feeds. 
Fixes bug where an invalid Last-Modified value would be returned in feed requests for sites that had 0 items to return. Comment or post feeds will now return the current timestamp as the Last-Modified header value.  Example: a request for the comments feed for a site without any comments.

Replaced use of the local static variable `$cache_lastcommentmodified` to store the modified date in `get_lastcommentmodified()` with the Object Cache API.  The `get_lastcommentmodified()` function returns early if there is a cached value and returns `false` if there where no comments found. Introduced `_clear_modified_cache_on_transition_comment_status()` to flush the `lastcommentmodified` cache key when a comment enters or leaves approval status. In `get_lastpostmodified()` return early if there is a cached value and return `false` if there are no posts found.

Props swissspidy, rachelbaker, dllh, leobaiano.
Fixes #38027.
Built from https://develop.svn.wordpress.org/trunk@38925


git-svn-id: http://core.svn.wordpress.org/trunk@38868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-10-25 20:48:29 +00:00
Scott Taylor
5e9ed67b82 Feeds: <comments> is optional in RSS2, so don't include it when comments aren't present or open. Same for <wfw:commentRss> and <slash:comments> 
Adds unit test.

Props swissspidy, realloc, hakre, sivel.
Fixes #9134.

Built from https://develop.svn.wordpress.org/trunk@35506


git-svn-id: http://core.svn.wordpress.org/trunk@35470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-04 17:47:25 +00:00
Konstantin Obenland
c69e96422b Themes: Improve document title output. 
Introduces more flexibility in filtering all parts of the document title,the
separator, and a way to short-circuit title generation. Plugins can now also
check for theme support and reliably filter the entire output. See #18548.
Deprecates `wp_title()`.

Fixes #31078.


Built from https://develop.svn.wordpress.org/trunk@35294


git-svn-id: http://core.svn.wordpress.org/trunk@35260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-20 16:21:25 +00:00
Sergey Biryukov
c321e40016 Introduce 'rss_tag_pre' action, which fires between the xml and rss tags in a feed. 
props solarissmoke, wonderboymusic, DrewAPicture.
fixes #19017.
Built from https://develop.svn.wordpress.org/trunk@29014


git-svn-id: http://core.svn.wordpress.org/trunk@28802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 10:18:15 +00:00
Drew Jaynes
5c4e360b26 Inline documentation for hooks in wp-includes/feed-atom.php. 
Props dustyf.
See #25229.

Built from https://develop.svn.wordpress.org/trunk@25531


git-svn-id: http://core.svn.wordpress.org/trunk@25451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-20 22:50:10 +00:00
Andrew Nacin
30d048a1e7 Don't return encoded ampersands from get_post_comments_feed_link() to avoid canonical redirect issues. Apply esc_url() when appropriate. 
props markjaquith, SergeyBiryukov. fixes #21841.



git-svn-id: http://core.svn.wordpress.org/trunk@22431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 19:56:10 +00:00
nacin
95c9b62dfd Use html_type for alternate link elements in atom feeds, as done in atom comment feeds. props niallkennedy. fixes #21305. 
git-svn-id: http://core.svn.wordpress.org/trunk@21289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-20 15:08:45 +00:00
nacin
bdd70470e2 Use the site's locale for the feed language. Provides the same result as language_attributes(). Removes the rss_language option. fixes #13440. see #5517. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-29 19:56:33 +00:00
westi
10084a7fb1 Allow custom author elements such as email. Fixes #17149 props niallkennedy. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-17 07:39:41 +00:00
westi
8b4a635d8b Move the escaping into get_guid() so we don't have to repeat ourselves. See #13555. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 17:27:18 +00:00
westi
b54183ae4c Escape the guid urls when placing them in feeds and other xml locations. See #13555. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 17:01:21 +00:00
westi
d8490aeea2 Add the generator element in feeds through the {rss2|atom|rdf|rss|opml}_head hooks. Fixes #6947 props sivel. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-13 16:45:16 +00:00
westi
9105b46360 Use _deprecated_argument() in get_bloginfo() and then don't pass deprecated argument to get_bloginfo(). Fixes #11652 props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-30 17:05:02 +00:00
ryan
5224680c4d Deprecates the_content_rss(). Add the_content_feed() and get_the_content_feed(). Convert places that called the_content_rss() with an excerpt length to the_excerpt_rss(). Remove the rss_excerpt_length option. Use the_content_feed() where the_content() was previously used in feeds. Props Viper007Bond. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-28 14:36:48 +00:00
ryan
8815dd60c2 Use get_the_author_meta(). Props sivel. see #9393 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-20 21:32:39 +00:00
ryan
1354d0660a Don't localize dates where not appropriate. Props Denis-de-Bernardy, hakre. fixes #9730 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-14 02:00:32 +00:00
ryan
191762762a Remove unneeded spaces. Props Denis-de-Bernardy. fixes #108 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-16 18:47:41 +00:00
azaozz
3949fb7e90 Add support for automatic feed links in themes, props Viper007Bond, see #8878 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-19 05:04:58 +00:00
ryan
4bcb8222b5 Typo fix from peaceablewhale. fixes #6579 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-04-22 21:16:42 +00:00
westi
77c0f608c8 Better self links for feeds. Fixes #5238 props andy. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@7244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-03-11 18:18:22 +00:00
ryan
09f2286a41 Some file level phpdoc from darkdragon. fixes #5527 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-25 20:48:01 +00:00
ryan
8ef0bd232d Support atom threading. Props rubys. fixes #5434 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-12-10 06:57:58 +00:00
ryan
35899c1201 Back out some changes from #5181. Props rubys. fixes #5307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-11-06 18:23:16 +00:00
westi
4c7bfb6a4f Refactor atom support to share code. Fixes #5181 props rubys 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-19 15:42:30 +00:00
westi
e9cfb43133 Centralise generator generation, move theme generator generation to wp-head hook. Fixes #5085, #4803. props docwhat, Viper007Bond. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-10-06 06:55:24 +00:00
westi
cf26b9d049 Make the atom feed updated field actually tell you when the post was updated. Fixes #4816 props lapcat. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@6093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-09-12 16:26:39 +00:00
ryan
9b395107f4 Deprecate permalink_single_rss(). Add the_permalink_rss() with accompanying filter. Props joostdevalk and Otto42. fixes #4654 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-08-21 18:27:45 +00:00
ryan
72c169c2f1 Don't output author uri tag if uri is empty. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-13 18:03:17 +00:00
rob1n
9ce729e656 Content-Type, not Content-type, as headers are case sensitive. Props foolswisdom and Nazgul. fixes #3545 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-06-02 05:21:18 +00:00
rob1n
5b446f7cf7 Show more relevant titles (current category, date, etc.) in feed titles. fixes #1790 
git-svn-id: http://svn.automattic.com/wordpress/trunk@5132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-03-29 01:29:09 +00:00
markjaquith
d0f79bb3f2 trailing tabs and whitespace cleanup. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-02-27 15:24:54 +00:00
ryan
2696432efc Proper atom enclosures. Props rob1n. fixes #1464 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-02-23 23:47:57 +00:00
ryan
dbedd143e4 Relocate feed templates to wp-includes. fixes #3846 
git-svn-id: http://svn.automattic.com/wordpress/trunk@4927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2007-02-23 02:50:05 +00:00