Boone Gorges
09e1239ad6
Remove redundant table alias check in WP_Meta_Query.
...
Also adds documentation for 'meta_query_find_compatible_table_alias' filter.
See #24093 .
Built from https://develop.svn.wordpress.org/trunk@29953
git-svn-id: http://core.svn.wordpress.org/trunk@29701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-18 02:22:19 +00:00
Ian Stewart
1804918131
Twenty Fifteen: Swap order of description and caption so the caption is underneath an image on image attachment pages.
...
Props iamtakashi, fixes #30020 .
Built from https://develop.svn.wordpress.org/trunk@29951
git-svn-id: http://core.svn.wordpress.org/trunk@29700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 21:36:18 +00:00
Dominik Schilling
67c8d7f847
Customizer: Extract content markup for panels to its own method, WP_Customize_Panel::render_content()
.
...
This allows to override the behavior of a panel, or even to completely replace its contents with something other than controls or sections.
props celloexpressions.
fixes #29324 .
Built from https://develop.svn.wordpress.org/trunk@29950
git-svn-id: http://core.svn.wordpress.org/trunk@29699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 21:25:19 +00:00
Ian Stewart
d224b52731
Twenty Fifteen: centre gallery thumbnails
...
Props iamtakashi, fixes #30019
Built from https://develop.svn.wordpress.org/trunk@29949
git-svn-id: http://core.svn.wordpress.org/trunk@29698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 21:23:19 +00:00
Dominik Schilling
bc982b39c1
Customizer: Introduce customize_preview_$setting->type
action to handle multiple settings of the same type.
...
props celloexpressions.
fixes #29165 .
Built from https://develop.svn.wordpress.org/trunk@29948
git-svn-id: http://core.svn.wordpress.org/trunk@29697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 21:21:19 +00:00
Ian Stewart
cbc554946b
Twenty Fifteen: correct escaping to render HTML in no-content admin message.
...
Props dmchale, fixes #30011 .
Built from https://develop.svn.wordpress.org/trunk@29947
git-svn-id: http://core.svn.wordpress.org/trunk@29696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 21:16:20 +00:00
Boone Gorges
43fb0af4f1
Invalidate cache for child terms when parent term is deleted.
...
Props socki03.
Fixes #29911 .
Built from https://develop.svn.wordpress.org/trunk@29945
git-svn-id: http://core.svn.wordpress.org/trunk@29695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 20:59:20 +00:00
Ian Stewart
9ed425438f
Twenty Fifteen: Removing unused custom color controls.
...
Props cainm, fixes #29982 and #29959 .
Built from https://develop.svn.wordpress.org/trunk@29944
git-svn-id: http://core.svn.wordpress.org/trunk@29694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 20:52:19 +00:00
Ian Stewart
507fee2825
Twenty Fifteen: Fix hover and focus style for links in content with custom color schemes.
...
Props iamtakashi, fixes #29978 .
Built from https://develop.svn.wordpress.org/trunk@29942
git-svn-id: http://core.svn.wordpress.org/trunk@29693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 20:32:21 +00:00
Boone Gorges
4ca2996eff
Bail from cleaning meta query clause when it's not an array.
...
Later isset() checks on string values were causing notices on PHP < 5.4.
Props jorbin.
See #29642 .
Built from https://develop.svn.wordpress.org/trunk@29941
git-svn-id: http://core.svn.wordpress.org/trunk@29692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 20:25:19 +00:00
Boone Gorges
9345e9ffa5
Overhaul SQL generating logic in WP_Meta_Query to avoid unnecessary table joins.
...
The logic used to generate clause SQL in `WP_Meta_Query` is somewhat arcane,
stemming mostly from an ongoing effort to eliminate costly table joins when
they are not necessary. By systematizing the process of looking for shareable
joins - as was done in `WP_Tax_Query` [29902] - it becomes possible to simplify
the construction of SQL queries in `get_sql_for_clause()`. Moreover, the
simplified logic is actually considerably better at identifying shareable
joins, such that certain uses of `WP_Meta_Query` will see joins reduced by 50%
or more.
Includes integration tests for a representative cross-section of the query
clause combinations that result in shared table aliases.
Props boonebgorges, sc0ttkclark.
See #24093 .
Built from https://develop.svn.wordpress.org/trunk@29940
git-svn-id: http://core.svn.wordpress.org/trunk@29691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 20:21:18 +00:00
Scott Taylor
ea679e358e
wp_schedule_single_event()
should not prevent scheduling a future duplicate event. It should only reject an event as a duplicate if there is already a similar event scheduled within 10 minutes of the given timestamp.
...
Adds unit tests, fixes existing cron test.
Props tellyworth.
See [9181], #6966 .
Fixes #28213 .
Built from https://develop.svn.wordpress.org/trunk@29939
git-svn-id: http://core.svn.wordpress.org/trunk@29690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 19:17:18 +00:00
Boone Gorges
0f8e7d0e55
Add @since
annotation for 'user_registered' support in 'date_query_valid_columns' documentation.
...
Props DrewAPicture.
Fixes #27283 .
Built from https://develop.svn.wordpress.org/trunk@29938
git-svn-id: http://core.svn.wordpress.org/trunk@29689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 03:51:20 +00:00
Boone Gorges
baff5f2b99
Better "inclusive" support for string values in WP_Date_Query.
...
The 'inclusive' parameter for WP_Date_Query determines whether non-precise
dates for 'before' and 'after' will be rounded up or down. Previously, this was
supported only when 'before' and 'after' were arrays; string-formatted dates
were run through strtotime(), which rounded them all down (inclusive in the
case of after, non-inclusive in the case of before). Now, we attempt to parse
formats that look like MySQL-formatted date strings, and apply inclusive logic
to them if we recognize them successfully.
Fixes #29908 .
string values. Array values support the 'inclusive
Built from https://develop.svn.wordpress.org/trunk@29936
git-svn-id: http://core.svn.wordpress.org/trunk@29688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 02:28:19 +00:00
Boone Gorges
6c6a285091
Comment/post author in/not_in for WP_Comment_Query
.
...
Props nofearinc, chriscct7.
Fixes #29885 .
Built from https://develop.svn.wordpress.org/trunk@29935
git-svn-id: http://core.svn.wordpress.org/trunk@29687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 01:58:18 +00:00
Boone Gorges
bde2c97aee
Support date_query by user_registered in WP_User_Query.
...
Props ChriCo, nacin.
Fixes #27283 .
Built from https://develop.svn.wordpress.org/trunk@29934
git-svn-id: http://core.svn.wordpress.org/trunk@29686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 01:37:18 +00:00
Boone Gorges
fcc82fd671
Use table aliases for columns in SQL generated by WP_Date_Query.
...
The use of non-aliased column names (eg 'post_date' instead of 'wp_posts.post_date')
in WP_Date_Query causes SQL notices and other failures when queries involve
table joins, such as date_query combined with tax_query or meta_query. This
changeset modifies WP_Date_Query::validate_column() to add the table alias when
it can be detected from the column name (ie, in the case of core columns).
A side effect of this change is that it is now possible to use WP_Date_Query
to build WHERE clauses across multiple tables, though there is currently no
core support for the automatic generation of the necessary JOIN clauses. See
Props ew_holmes, wonderboymusic, neoxx, Viper007Bond, boonebgorges.
Fixes #25775 .
Built from https://develop.svn.wordpress.org/trunk@29933
git-svn-id: http://core.svn.wordpress.org/trunk@29685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 01:20:21 +00:00
Boone Gorges
50f1b45594
Add expectedIncorrectUsage flags for unit tests that generate invalid dates.
...
Since [29925], passing an invalid date to WP_Date_Query will generate a
_doing_it_wrong() notice. The current changeset adds the
`@expectedIncorrectUsage` flag to those existing unit tests that generate
invalid dates, such as those that test canonical redirect and is_404()
conditionals.
Fixes #25834 .
Built from https://develop.svn.wordpress.org/trunk@29932
git-svn-id: http://core.svn.wordpress.org/trunk@29684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-17 00:41:18 +00:00
Boone Gorges
3949a8b6cc
Remove invalid continue
calls from WP_Tax_Query::get_sql_for_clause().
...
This was leftover code from the previous implementation, which used a `foreach()`
loop. See [29901].
Props nofearinc.
See #29738 , #29718 .
Built from https://develop.svn.wordpress.org/trunk@29931
git-svn-id: http://core.svn.wordpress.org/trunk@29683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 22:07:20 +00:00
Ian Stewart
31c0fa1c6e
Twenty Fifteen: readable comment details in the dark colour scheme.
...
Props NikV, fixes #29970 .
Built from https://develop.svn.wordpress.org/trunk@29930
git-svn-id: http://core.svn.wordpress.org/trunk@29682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 22:01:18 +00:00
Andrew Ozz
553bb3cf77
Editor-expand:
...
- Better calculation for the caret position when auto-scrolling while typing.
- Fix auto-scrolling for non-WebKit browsers when the caret is above the top of the editor.
Fixes #29954
Built from https://develop.svn.wordpress.org/trunk@29929
git-svn-id: http://core.svn.wordpress.org/trunk@29681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 21:31:18 +00:00
Ian Stewart
48e1232075
Twenty Fifteen: document the site-branding class in header.php.
...
Props NikV, fixes #29961 .
Built from https://develop.svn.wordpress.org/trunk@29928
git-svn-id: http://core.svn.wordpress.org/trunk@29680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:52:18 +00:00
Ian Stewart
f196453cb8
Twenty Fifteen: make sure we don't see borders through transparent linked images.
...
Props iamtakashi, fixes #29963 .
Built from https://develop.svn.wordpress.org/trunk@29927
git-svn-id: http://core.svn.wordpress.org/trunk@29679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:48:18 +00:00
Ian Stewart
2934146919
Twenty Fifteen: Removes flashing of background behind fixed position elements when scrolling in mobile and desktop Safari.
...
Props iamtakashi, fixes #29973 and #29987 .
Built from https://develop.svn.wordpress.org/trunk@29926
git-svn-id: http://core.svn.wordpress.org/trunk@29678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:35:20 +00:00
Boone Gorges
cac92b2876
Throw notices when invalid date values are passed to WP_Date_Query.
...
`_doing_it_wrong()` notices are now generated when passing out-of-range values
(`month=13`) or invalid dates (`2014-02-29`).
Includes unit tests.
Props ChriCo.
Fixes #25834 .
Built from https://develop.svn.wordpress.org/trunk@29925
git-svn-id: http://core.svn.wordpress.org/trunk@29677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 20:12:18 +00:00
Dominik Schilling
e3e1433e9a
Themes: Make it possible to delete broken themes.
...
props ideag, obenland.
fixes #28165 .
Built from https://develop.svn.wordpress.org/trunk@29924
git-svn-id: http://core.svn.wordpress.org/trunk@29676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:46:18 +00:00
Boone Gorges
838444446b
Introduce nested query support to WP_Date_Query.
...
This enhancement makes it possible to filter post, comment, and other queries
by date in ways that are arbitrarily complex, using mixed AND and OR relations.
Includes unit tests for the new syntax. In a few places, the existing unit
tests were slightly too strict (such as when checking the exact syntax of a SQL
string); these existing tests have been narrowed.
Props boonebgorges.
Fixes #29822 .
Built from https://develop.svn.wordpress.org/trunk@29923
git-svn-id: http://core.svn.wordpress.org/trunk@29675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:34:17 +00:00
Ian Stewart
da93ef02b9
Twenty Fifteen: indented nested lists in comments.
...
Props pauldewouters, iamtakashi, fixes #29981 .
Built from https://develop.svn.wordpress.org/trunk@29922
git-svn-id: http://core.svn.wordpress.org/trunk@29674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:32:19 +00:00
Ian Stewart
24e6e8cc0a
Twenty Fifteen: correct margin for pagination.
...
Props kwight; fixes #29964 .
Built from https://develop.svn.wordpress.org/trunk@29921
git-svn-id: http://core.svn.wordpress.org/trunk@29673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:16:18 +00:00
Dominik Schilling
d79cc63828
Update jQuery UI to 1.11.2.
...
Changelog: http://jqueryui.com/changelog/1.11.2/
see #29833 .
Built from https://develop.svn.wordpress.org/trunk@29920
git-svn-id: http://core.svn.wordpress.org/trunk@29672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:02:38 +00:00
Ian Stewart
1a6b4131c7
Twenty Fifteen: add print styles.
...
Props iamtakashi, closes #29967
Built from https://develop.svn.wordpress.org/trunk@29919
git-svn-id: http://core.svn.wordpress.org/trunk@29671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 19:02:20 +00:00
Ian Stewart
747e7189a3
Twenty Fifteen: correct font fallback for Noto Serif in editor styles; Props Manoz69; Fixes #29984
...
Built from https://develop.svn.wordpress.org/trunk@29918
git-svn-id: http://core.svn.wordpress.org/trunk@29670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 18:40:20 +00:00
Scott Taylor
fb019893f9
In wp.Uploader
, when uploader:ready
is triggered, set ready
to true
on the instance. This allows media workflows to check for an existing uploaded instance when opening.
...
Without this check, workflows might wait for `uploader:ready`, which could already have been fired. This would result in an unresponsive editor dropzone.
Fixes #29689 .
Built from https://develop.svn.wordpress.org/trunk@29917
git-svn-id: http://core.svn.wordpress.org/trunk@29669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 05:54:18 +00:00
Scott Taylor
84a26a78a8
Cache get_term_by()
calls:
...
* Add a helper function, `wp_get_last_changed()`, to retrieve a last-modified timestamp by cache group
* When caching a term, also make cache entries for slug and name via `slug:{$term_id}` and `name:{$term_id}` keys in the `$taxonomy:$last_changed` bucket that reference the term_id
* In `clean_term_cache()` and `update_term_cache()`, respect `$_wp_suspend_cache_invalidation`
* Original term cache entries maintain BC
Adds unit tests.
Props wonderboymusic, tollmanz, boonebgorges.
Fixes #21760 .
Built from https://develop.svn.wordpress.org/trunk@29915
git-svn-id: http://core.svn.wordpress.org/trunk@29668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 04:45:17 +00:00
Scott Taylor
72d12b514d
Add a 6th (!) attribute to wp_get_attachment_link()
to allow aria-describedby
to be added to gallery output.
...
Props joedolson, DrewAPicture, rianrietveld.
Fixes #27402 .
Built from https://develop.svn.wordpress.org/trunk@29914
git-svn-id: http://core.svn.wordpress.org/trunk@29667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 04:28:17 +00:00
Boone Gorges
1470990892
Check that search value is scalar before parsing.
...
Prevents PHP notices when non-scalar values are passed.
Includes unit tests.
Props tivnet.
Fixes #29736 .
Built from https://develop.svn.wordpress.org/trunk@29912
git-svn-id: http://core.svn.wordpress.org/trunk@29666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 03:32:20 +00:00
Andrew Ozz
6de7c43ab3
Twenty Fifteen, editor-style.css: revert the font-size back to 19px and margin back to 83px, merge the two body selectors (don't seem needed), remove redundant rtl rules and fix body.rtl selector. See #29799
...
Built from https://develop.svn.wordpress.org/trunk@29911
git-svn-id: http://core.svn.wordpress.org/trunk@29665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-16 00:27:19 +00:00
Andrew Ozz
f6e96fa748
Twenty Fifteen: no rem
in editor-style.css for now, see #29799
...
Built from https://develop.svn.wordpress.org/trunk@29910
git-svn-id: http://core.svn.wordpress.org/trunk@29664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 22:48:18 +00:00
Andrew Ozz
dc0fee4550
Twenty Fifteen: make font-size/line-height in editor-style.css the same as in style.css. Remove margins from the editor body, interferes with autoresize in some browsers and is overriden in the default styles. See #29799
...
Built from https://develop.svn.wordpress.org/trunk@29909
git-svn-id: http://core.svn.wordpress.org/trunk@29663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 22:37:18 +00:00
Dominik Schilling
bf16aac8e1
Comments: Don't print an empty HTML markup when comment_reply_link()
returns no link.
...
props obenland.
fixes #29895 .
Built from https://develop.svn.wordpress.org/trunk@29908
git-svn-id: http://core.svn.wordpress.org/trunk@29662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 21:56:19 +00:00
Dominik Schilling
b89c915ed6
Customizer: Don't trigger a change event if two unchanged object values are equal, second pass.
...
Make Underscore.js a dependency for `customize-base` and use `_.isEqual()` to compare the values.
(Underscore.js was already enqueued via wp-util.js for Widgets.)
props westonruter.
fixes #26061 .
Built from https://develop.svn.wordpress.org/trunk@29907
git-svn-id: http://core.svn.wordpress.org/trunk@29661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 18:26:17 +00:00
Dominik Schilling
4020eacd8b
Customizer: Only POST dirty settings to preview to improve performance.
...
props westonruter.
fixes #29983 .
Built from https://develop.svn.wordpress.org/trunk@29905
git-svn-id: http://core.svn.wordpress.org/trunk@29660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:50:18 +00:00
Dominik Schilling
1ab3190ddc
Theme install: Remove unused strings.
...
fixes #29488 .
Built from https://develop.svn.wordpress.org/trunk@29904
git-svn-id: http://core.svn.wordpress.org/trunk@29659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:22:18 +00:00
Dominik Schilling
61819a36ea
Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
...
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/ .
props studionashvegas, tareq1988.
fixes #29947 .
Built from https://develop.svn.wordpress.org/trunk@29903
git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Boone Gorges
af6beda45b
Avoid redundant table joins in WP_Tax_Query.
...
IN clauses that are connected by OR require only a single table join. To avoid
extraneous joins, keep track of generated table aliases, and let sibling
clauses piggy-back on those aliases when possible.
Introduces WP_Tax_Query::sanitize_relation() to reduce some repeated code.
Adds unit tests to verify the JOIN consolidation, and integration tests for
cases where JOINS are being combined.
Props boonebgorges, otto42, jakub.tyrcha.
Fixes #18105 .
Built from https://develop.svn.wordpress.org/trunk@29902
git-svn-id: http://core.svn.wordpress.org/trunk@29657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 16:40:18 +00:00
Boone Gorges
295f5fc9de
Support nested tax query syntax in redirect_canonical().
...
The proper place to look for a list of queried terms is in the flat
queried_terms array, not in tax_query->queries.
See #29738 .
Built from https://develop.svn.wordpress.org/trunk@29901
git-svn-id: http://core.svn.wordpress.org/trunk@29656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 15:43:19 +00:00
Sergey Biryukov
16a55620c3
Twenty Fifteen: Update some more bundled theme references after [29895].
...
see #29799 .
Built from https://develop.svn.wordpress.org/trunk@29900
git-svn-id: http://core.svn.wordpress.org/trunk@29655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 14:35:18 +00:00
Sergey Biryukov
320ee24a55
Add line breaks at the end of network setup rules to avoid unintended merging with a subsequent line.
...
props socki03.
fixes #29945 .
Built from https://develop.svn.wordpress.org/trunk@29899
git-svn-id: http://core.svn.wordpress.org/trunk@29654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 14:13:20 +00:00
Andrew Ozz
f19ad10571
Admin menu:
...
- Fix pinning after resizing the window.
- Merge the two DOM ready callbacks in common.js
- Fix the submenus position adjustment on focus.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29898
git-svn-id: http://core.svn.wordpress.org/trunk@29653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 06:05:18 +00:00
Andrew Ozz
ca92ca385e
Twenty Fifteen: clean up skip-link-focus-fix.js, see #29799
...
Built from https://develop.svn.wordpress.org/trunk@29897
git-svn-id: http://core.svn.wordpress.org/trunk@29652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 05:49:19 +00:00