Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 22:56:19 +01:00
Code Issues Projects Releases Wiki Activity
38,415 Commits 50 Branches 748 Tags 792 MiB
8428d1077f
Commit Graph

38415 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
laurelfulford
3175c26096 Twenty Ten: Custom colors should override :visited link styles on blocks. 
Make sure the block editor custom colors in the theme also override the theme's `:visited` link styles. This prevents contrast issues, like in the button block -- when the background is dark, the purple `:visited` link can be difficult to read.

Fixes #45434.


Built from https://develop.svn.wordpress.org/branches/5.0@44188


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-15 11:03:50 +00:00
allancole
288bb8f603 Updating Twenty Nineteen, the new default theme for 2019. 
This change adds general code quality and documentation improvements. 

- More info here: https://github.com/WordPress/twentynineteen/pull/546

Props grapplerulrich, iCaleb.


Built from https://develop.svn.wordpress.org/branches/5.0@44187


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-15 11:03:05 +00:00
desrosj
15db443250 PHP 7.3 Compatibility: Fix compact related notices. 
In PHP 7.3, the `compact()` function has been changed to issue an `E_NOTICE` level error if a passed string refers to an unset variable. In previous versions of PHP, this notice was silently skipped. This fixes a few more instances of unset variables in the WordPress admin.

The full RFC can be viewed here: https://wiki.php.net/rfc/compact.

See #44416.
Fixes #45483.
Built from https://develop.svn.wordpress.org/branches/5.0@44185


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-15 11:01:25 +00:00
youknowriad
6137ee183b Block Editor: Upgrade @wordpress packages to the latest version (4.7). 
Updated packages:

 - @wordpress/annotations@1.0.4
 - @wordpress/api-fetch@2.2.6
 - @wordpress/block-library@2.2.10
 - @wordpress/block-serialization-default-parser@2.0.2
 - @wordpress/block-serialization-spec-parser@2.0.2
 - @wordpress/blocks@6.0.4
 - @wordpress/components@7.0.4
 - @wordpress/core-data@2.0.15
 - @wordpress/data@4.1.0
 - @wordpress/date@3.0.1
 - @wordpress/edit-post@3.1.5
 - @wordpress/editor@9.0.5
 - @wordpress/eslint-plugin@1.0.0
 - @wordpress/format-library@1.2.8
 - @wordpress/html-entities@2.0.4
 - @wordpress/list-reusable-blocks@1.1.17
 - @wordpress/notices@1.1.1
 - @wordpress/nux@3.0.5
 - @wordpress/rich-text@3.0.3
 - @wordpress/url@2.3.2
 - @wordpress/viewport@2.0.13

This also includes the updates the Core blocks.
The script loader is updated to match the Gutenberg repository too.

Props atimmer, gziolo, joen.
Fixes #45442, #45637.

Built from https://develop.svn.wordpress.org/branches/5.0@44183


git-svn-id: http://core.svn.wordpress.org/branches/5.0@44013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-15 10:59:46 +00:00
Jeremy Felt
83a466d844 Post-5.0.1 version bump for 5.0 branch. 
Built from https://develop.svn.wordpress.org/branches/5.0@44105


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 03:40:46 +00:00
Jeremy Felt
ccfd64c423 Bump 5.0 branch to version 5.0.1. 
Built from https://develop.svn.wordpress.org/branches/5.0@44077


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 02:11:45 +00:00
Peter Wilson
1f5919e631 Multisite: Validate activation links. 
Merges [44048] to the 5.0 branch.

Built from https://develop.svn.wordpress.org/branches/5.0@44050


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 01:30:45 +00:00
Gary Pendergast
8d463ab37f Editor: Remove unwanted fields before saving posts. 
The `meta_input`, `file`, and `guid` fields are not intended to be updated through user input.


Built from https://develop.svn.wordpress.org/branches/5.0@44047


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 01:25:47 +00:00
Peter Wilson
1894965f3f Multisite: Improve messaging for previously activated users. 
Ensure activation of a site is not attempted multiple times and users are shown the correct message if they follow the link a second time.

Merges [44021] to the 5.0 branch.

Built from https://develop.svn.wordpress.org/branches/5.0@44022


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 00:28:46 +00:00
iandunn
6ae36b3cfd KSES: Correct @since tags for wp_kses_uri_attributes. 
r44014 introduced the `wp_kses_uri_attributes` function and filter, but incorrectly used `4.9.9` instead of `5.0.1`.

Built from https://develop.svn.wordpress.org/branches/5.0@44017


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-13 00:00:46 +00:00
iandunn
fb3c6ea061 KSES: Make the URI attributes DRY. 
This commit introduces the `wp_kses_uri_attributes` function and filter. The function centralizes the list of attributes, in order to prevent inconsistency, and the filter provides a way for plugins to customize the attributes.

Built from https://develop.svn.wordpress.org/branches/5.0@44014


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-12 23:53:45 +00:00
Gary Pendergast
d82b02eb33 KSES: Conditionally remove the <form> element from $allowedposttags. 
To avoid backwards compatibility issues, `<form>` is re-added if a custom filter has added the `<input>` or `<select>` elements to `$allowedposttags`.


Built from https://develop.svn.wordpress.org/branches/5.0@43994


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-12 23:12:45 +00:00
Jeremy Felt
246a70bdbf Media: Improve verification of MIME file types. 
Built from https://develop.svn.wordpress.org/branches/5.0@43988


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-12 23:01:47 +00:00
Gary Pendergast
7bfa0aeb0f WordPress 5.0.1-alpha. 
Built from https://develop.svn.wordpress.org/branches/5.0@43972


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-06 19:46:47 +00:00
Gary Pendergast
671cccefd5 WordPress 5.0. 
Built from https://develop.svn.wordpress.org/branches/5.0@43970


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-06 17:59:45 +00:00
Mel Choyce
f8c6849fb4 Help/About: Upload videos to CDN and remove autoplay/loop. 
Props skithund, afercia, lonelyvegan.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43969


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-06 02:51:45 +00:00
Gary Pendergast
1b4fb4f9f0 About: Move images to the CDN, and use <picture>. 
Ensures the correct assets are used for the device loading the page.

Props joemcgill.
See #45178.


Built from https://develop.svn.wordpress.org/branches/5.0@43968


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-05 22:25:47 +00:00
Gary Pendergast
ebd29f6fb9 About: Add ℹ️ to the classic editor link, to make it stand out a little more. 
Props melchoyce.
See #45178.


Built from https://develop.svn.wordpress.org/branches/5.0@43967


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 23:04:45 +00:00
Gary Pendergast
ad08c43e57 Post WordPress 5.0 RC3 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.0@43966


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 07:06:46 +00:00
Gary Pendergast
0e084deeb0 WordPress 5.0 RC3. 
Built from https://develop.svn.wordpress.org/branches/5.0@43965


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 06:54:46 +00:00
Gary Pendergast
c85b1d8c84 Default Themes: Bump the version numbers and release dates. 
With WordPress 5.0 just a few short days away, the default themes can have their version numbers bumped.

The POT files for Twentys Ten and Eleven have also been updated.

Props laurelfulford, maedahbatool, mrahmadawais, pento.
See #45167.


Built from https://develop.svn.wordpress.org/branches/5.0@43964


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 04:32:46 +00:00
Gary Pendergast
de0e017977 Twenty Nineteen: Update the screenshot. 
The screenshot is now up to date with the theme, and reflects the visuals in the About page.

Props kjellr, allancole.
See #45424.


Built from https://develop.svn.wordpress.org/branches/5.0@43963


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 04:17:46 +00:00
Gary Pendergast
f8ff8642b7 Twenty Nineteen: Fix classic block icons not displaying with non-latin fonts. 
Props kjellr, allancole.
See #45424.


Built from https://develop.svn.wordpress.org/branches/5.0@43962


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 04:12:45 +00:00
Gary Pendergast
ad9b38816c Twenty Nineteen: Fix non-breaking spaces being too wide on the front end. 
This visual issue had been previously fixed in the block editor, is now fixed in the published post, too.

Props kjellr, allancole.
See #45424.


Built from https://develop.svn.wordpress.org/branches/5.0@43961


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 04:10:45 +00:00
Gary Pendergast
3109e8211f Scripts: Ensure sub-directory WordPress installs can load polyfill scripts. 
`wp_get_script_polyfill()` bypasses `WP_Scripts::do_item()`, so didn't transform the script path into its fully qualified URL.

Props swissspidy, ocean90.
See #45469.

Built from https://develop.svn.wordpress.org/branches/5.0@43960


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 02:11:44 +00:00
Gary Pendergast
e99b7b5ed3 l10n: Ensure JavaScript language packages are loaded for the user locale. 
`load_script_textdomain()` had a reversed check to decide if the user locale should be loaded. This check is now replaced with `determine_local()`.

Props ocean90.
See #45465.


Built from https://develop.svn.wordpress.org/branches/5.0@43959


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-12-04 01:13:47 +00:00
desrosj
a2ca9a4d84 Post WordPress 5.0 RC2 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.0@43958


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 23:17:46 +00:00
desrosj
761e77cb88 WordPress 5.0 RC2. 
Built from https://develop.svn.wordpress.org/branches/5.0@43957


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 23:05:45 +00:00
allancole
e24f0eb0cb Updating Twenty Nineteen, our new default theme for 2019, set for 5.0. 
This changes fixes a security issue found in a dependency script used in our build tool. 

- The malicious dependency is now removed and no longer called when running `npm install` or `npm run build`. 
- More info here: https://github.com/WordPress/twentynineteen/pull/675

Props allancole, kjellr, netweb, twoabove.

Built from https://develop.svn.wordpress.org/branches/5.0@43956


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 22:36:45 +00:00
youknowriad
1bc8389763 Block Editor: Update @wordpress package dependencies. 
Updated packages

 - @wordpress/block-library@2.2.9
 - @wordpress/block-serialization-default-parser@2.0.1
 - @wordpress/block-serialization-spec-parser@2.0.1
 - @wordpress/blocks@6.0.3
 - @wordpress/edit-post@3.1.4
 - @wordpress/editor@9.0.4
 - @wordpress/format-library@1.2.7

Other changes:

 - Backport the parser changes.

Fixes #45145.

Built from https://develop.svn.wordpress.org/branches/5.0@43955


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 20:58:46 +00:00
mcsf
73b656936c Update sidebars_widgets to match Twenty Nineteen's single widget area 
* Also update the customizer tests to match it.

Props SergeyBiryukov, pento.


Built from https://develop.svn.wordpress.org/branches/5.0@43954


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 20:25:46 +00:00
Mel Choyce
fa65b25ac7 Help/About: Update "Support for the Classic Editor plugin will remain in WordPress until 2021" to "through 2021" to further clarify timeline. 
Props kjellr.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43953


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 16:27:47 +00:00
Mel Choyce
34e52b90e9 Help/About: Fix the user's saved WordPress.org username from being changed to wordpressdotorg when they click the About page link to install the Classic Editor plugin. 
Props pento.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43952


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 16:23:46 +00:00
youknowriad
d71ccc69e3 Block Editor: Remove the latest "gutenberg" mention in the latest-comments.php file 
Props swissspidy.
See #45145.

Built from https://develop.svn.wordpress.org/branches/5.0@43951


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 13:36:47 +00:00
youknowriad
50b094e3b0 Block Editor: Rename the gutenberg_ functions in blocks/latest-comments.php. 
This was ported manually from https://github.com/WordPress/gutenberg/pull/12326

Props pento, swissspidy.
See #45145. 

Built from https://develop.svn.wordpress.org/branches/5.0@43950


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 13:24:45 +00:00
youknowriad
3dd6578998 Block Editor: Update @wordpress package dependencies. 
Update packages:

 - @wordpress/block-library@2.2.8
 - @wordpress/components@7.0.3
 - @wordpress/edit-post@3.1.3
 - @wordpress/editor@9.0.3
 - @wordpress/format-library@1.2.6
 - @wordpress/list-reusable-blocks@1.1.16
 - @wordpress/nux@3.0.4

Other changes:

Fix a translator comment in edit-form-blocks.php.
Rename the gutenberg_ functions in blocks/latest-comments.php.

Props pento.
Fixes #45145.

Built from https://develop.svn.wordpress.org/branches/5.0@43949


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-30 09:59:52 +00:00
Andrew Ozz
98b042e189 Help/About: Do not show the "Keep it Classic" section and the link to it at the top when the Classic Editor plugin is already installed. 
See #45178.
Built from https://develop.svn.wordpress.org/branches/5.0@43947


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-29 08:30:46 +00:00
Mel Choyce
625cae3537 Help/About: Minor updates. 
- Updated the various images.
- Added new "developer happiness" images.
- Fixed the responsive figcaption styles.
- Added a link to wporg plugin favorites as a shortcode to get to the classic plugin.
- Renamed "cover image" to "cover."
- Updated CSS to account for small-screen issues.

Props desrosj, audrasjb, antpb, jjj, elrae, Otto42, afercia, karmatosed, kjellr, alexislloyd, melchoyce.
See #45178.

Built from https://develop.svn.wordpress.org/branches/5.0@43946


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-28 17:31:47 +00:00
Gary Pendergast
07ebb6262c Block Editor: Clarify a translator comment in meta box handling. 
Props ocean90.
See #45217.


Built from https://develop.svn.wordpress.org/branches/5.0@43945


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-27 06:39:48 +00:00
Gary Pendergast
c52f62f1f5 Post WordPress 5.0 RC1 version bump. 
Built from https://develop.svn.wordpress.org/branches/5.0@43944


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-23 09:41:45 +00:00
Gary Pendergast
3c89b67e4e WordPress 5.0 RC1. 
Built from https://develop.svn.wordpress.org/branches/5.0@43943


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-23 09:14:45 +00:00
youknowriad
91c4d2295b Block Editor: Fix the WordPress packages and vendor script registration. 
The version is set properly and the scripts are automatically loaded in the footer.
This patch also includes a revert for the reusable blocks enqueue script.

Props pento, swissspidy.
Fixes #45402.
See #45396.

Built from https://develop.svn.wordpress.org/branches/5.0@43942


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-23 08:35:45 +00:00
Gary Pendergast
be60664fe1 Block Editor: Add a placeholder for meta boxes that don't work in the block editor. 
If a meta box is registered with the `__block_editor_compatible_meta_box` set to `false`, it's indicating that it doesn't work in the block editor. If that's the case, we can add a place holder to inform the user that they'll need to use the classic interface to work with this meta box.

Props pento, jorgefilipecosta, peterwilsoncc, karmatosed, noisysocks, dd32.
See #45217.


Built from https://develop.svn.wordpress.org/branches/5.0@43941


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-23 08:15:46 +00:00
Gary Pendergast
0a164850fc Query: Remove nextpage block delimiters when setting up global post data. 
`WP_Query::setup_postdata()` splits the post up by `<!--nextpage-->`, which causes invalid block data to be contained in the post content.

This change removes the `<!-- wp:nextpage -->` and `<!-- /wp:nextpage -->`, as well.

Props pento, youknowriad, azaozz, noisysocks.
See #45401.


Built from https://develop.svn.wordpress.org/branches/5.0@43940


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-23 00:42:45 +00:00
youknowriad
97e84f8a03 Block Editor: Refresh nonces used by wp.apiFetch. 
Adds heartbeat nonces refreshing support to wp.apiFetch requests.

Props pento, adamsilverstein, dd32, desrosj.
Fixes #45113. 

Built from https://develop.svn.wordpress.org/branches/5.0@43939


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-22 19:40:46 +00:00
gziolo
a69e8cf788 About: Update Freedoms page to include illustrations. 
@cathibosco has made some great illustrations of the Four Freedoms on https://wordpress.org/about/. Let's bring that over to the admin Freedoms page.

Props @melchoyce, @cathibosco, @boemedia, @karmatosed, @tobifjellner, @helen, @matveb, @mcsf.
Fixes #45386.


Built from https://develop.svn.wordpress.org/branches/5.0@43938


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-22 18:03:45 +00:00
lonelyvegan
eaaa8c7dc6 Help/About: Add copy for new block editor. 
Adds information about the new block editor (Gutenberg) and the Classic Editor
to the about page.

Props @pixelverbieger, @ocean90, @melchoyce, @boemedia, @sami.keijonen, @TimothyBlynJacobs, @xkon, @afercia, @Otto42, @pento.
Fixes #45178.


Built from https://develop.svn.wordpress.org/branches/5.0@43937


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-22 15:24:45 +00:00
youknowriad
db6ae8a9be Block Editor: Fix loading the script handling the "Manage Reusable Blocks" page. 
This ensures the "import from JSON" and "export JSON" buttons are shown properly.
The script is loaded in the footer because it relies on the DOM being already there.

Props noisysocks, mukesh27.
Fixes #45396.

Built from https://develop.svn.wordpress.org/branches/5.0@43936


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-22 07:25:45 +00:00
noisysocks
7ade352f0f Block Editor: Update @wordpress package dependencies 
Updates packages:

- block-library
- components
- edit-post
- editor
- format-library
- list-reusable-blocks
- nux

See #45145

Built from https://develop.svn.wordpress.org/branches/5.0@43935


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-22 06:05:51 +00:00
Gary Pendergast
a7a70768ae WPDB: Check that $wpdb->last_result is countable before counting with it. 
`wpdb::get_col()` iterates over `$wpdb->last_result`, which can be a non-countable value, should the preceeding query have failed.

Props spacedmonkey, desrosj.
See #45299.


Built from https://develop.svn.wordpress.org/branches/5.0@43934


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2018-11-22 03:59:44 +00:00