Commit Graph

624 Commits

Author SHA1 Message Date
Mark Jaquith
ecf9a2b932 Revisions: a tiny one-pixel and z-index tweak for Firefox.
Props adamsilverstein. See #24736.

git-svn-id: http://core.svn.wordpress.org/trunk@24775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-23 03:41:54 +00:00
Mark Jaquith
7aee678e69 Revisions: Bump the tooltips up one pixel to prevent a Firefox hover-loop bug on the upper-border of the scrubber.
See #24736.

git-svn-id: http://core.svn.wordpress.org/trunk@24770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-22 22:04:38 +00:00
Mark Jaquith
991bab45a7 Revisions: tweak how tickmarks are rendered, to play nice with browsers who always round subpixel values down (Safari, Opera).
Also, some IE tweaks.

Fixes #24736. Props adamsilverstein, markjaquith, ocean90.

git-svn-id: http://core.svn.wordpress.org/trunk@24768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-22 21:09:49 +00:00
Mark Jaquith
13c63d211a Revisions: Pinned controls, layout tweaks, copy tweaks, misc.
* When you scroll down the diff view, the controls will pin to the top.
* The revisions meta view was cleaned up. Copy changes.
* Loading indicator in the center of the screen (so it follows as you scroll).
* Tooltips "flip" when you cross the center line, so that they don't hit the container edge and wrap for later revisions.
* The "Restore" button's inactive state is handled on render, instead of after.
* Make sure we always have a current revision, even if the timestamp doesn't work out on the most recent one.

See #24804. Props markjaquith, nacin, ocean90, aaroncampbell.

git-svn-id: http://core.svn.wordpress.org/trunk@24761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-22 05:05:45 +00:00
Mark Jaquith
5bf39803b9 WORLD WAR Z-INDEX: Restoration of sanity to revisions/slider/menu z-index values.
The year is 2013. It is a period of DOM unrest. Sliders have hoarded
all available z-index, leading to an arms race. What started as a local
squabble soon escalated into a global conflict. The flyout menus were
the first of the collateral damage, trodden underfoot by mighty warring
enemies they couldn't effectively challenge. It was said they were
betrayed by one of their own: the z-index-power-hungry non-active
currently-hovered submenu, whose z-index-power level was over 9000!

But there is hope. A small band of heroes has emerged. Using their
powers of "what were you thinking?" and "chill, no one needs a z-index
THAT high", they have begun to restore order and harmony to the DOM.

See #24736. Props markjaquith, aaroncampbell, helen.

git-svn-id: http://core.svn.wordpress.org/trunk@24753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-19 15:47:04 +00:00
Mark Jaquith
65b08eeece Revisions: Re-work how tick marks and tooltips are aligned. IE fixes.
* Pixel-based alignment of tooltips.
* Bottom-based alignment, so arrow lines up using CSS only.
* Better RTL styles (mostly mirror-imaged).
* Better RTL calculations in `revisions.js` (less logic).
* Better IE support.

See #24736. Props markjaquith, adamsilverstein, ocean90.

git-svn-id: http://core.svn.wordpress.org/trunk@24751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-19 13:49:15 +00:00
Andrew Nacin
5bb2f20164 Better 'Connection lost' notice that includes an indication of activity. fixes #24695.
git-svn-id: http://core.svn.wordpress.org/trunk@24743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 21:33:59 +00:00
Mark Jaquith
e9afe4c5d1 Fixes and tweaks for the metabox accordion.
* Fixed hover issues in Customizer.
* Toned down the default active/hover style (as it is normally not the top level menu, and should not be so prominent).
* Allow the active section to be closed.
* Other misc fixes.

Props ocean90, helen. Fixes #23449.

git-svn-id: http://core.svn.wordpress.org/trunk@24734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 17:42:53 +00:00
Mark Jaquith
93514ba101 Revisions: Better error handling.
* Shows an error message if the current diff can't be loaded.
* For bulk pre-loading, catches errors, and cuts subsequent requests in half, until eventually giving up.
* Some CSS fixes related to this, and the loading spinner.
* `wp.revisions.loadAll()` now returns a promise representing whether or not all revisions could be loaded.

Fixes #24758.

git-svn-id: http://core.svn.wordpress.org/trunk@24732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-18 16:35:19 +00:00
Andrew Ozz
b96efc779a Logged out warnings:
- Replace the Close button with an always visible "X" icon in the top/right corner.
- Check if the user is still logged in every 3 min. by default.
- Add 'wp_auth_check_interval' filter so the interval can be set from PHP.
See #23295.

git-svn-id: http://core.svn.wordpress.org/trunk@24695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 23:32:32 +00:00
Mark Jaquith
0e4a817d15 Revisions: force a scroll bar so that everything doesn't jerk around as you scrub due to the scroll bar popping in and out.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 20:44:37 +00:00
Mark Jaquith
4f1f7ee3f2 Revisions: more graceful tooltips
* Use hoverIntent to prevent inadvertent display and provide more forgiving exploration.
* Nice interruptable fading animation.
* Subtle CSS transition when moving the tooltip side-to-side.

Fixes #24734. See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 20:34:14 +00:00
Helen Hou-Sandí
0da48b8335 Tweaks to the accordion:
* Enqueues JS in `do_accordion_sections()`.
* Top and bottom rounded corners for the nav menu accordion.
* Better RTL and no-JS.

props lessbloat, DrewAPicture, aaroncampbell, helen. fixes #23449.


git-svn-id: http://core.svn.wordpress.org/trunk@24680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 18:16:29 +00:00
Mark Jaquith
cf02b10d4b Revisions: pixel perfect tooltips (as far as I can tell), and better checkbox alignment in Firefox.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 17:06:01 +00:00
Mark Jaquith
00fb9bfcb7 Revisions: Tweak the slider image and alignment.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 16:49:14 +00:00
Mark Jaquith
8f1a5dbd98 Revisions: Use all the vendor prefixes for box-sizing.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 15:10:57 +00:00
Mark Jaquith
e8b9088c5f Revisions: Cleanup, bug fixes, refactoring, polish.
* Hide the tooltip initially.
* Fix a bug with routing.
* Further separate the Slider model and view, refactoring its code.
* More reliance on events than direct calls between areas.
* Smarter background diff loading (single mode). Loads the diffs closest to your position first.
* Removed a bunch of manual templating and `render()` methods. Now relies more on the WP Backbone Views functionality.
* include the requested `id` in `ensure:load`.
* new trigger: `ensure`, for `ensure()` attempts, regardless of whether they are already loaded.
* pass along a promise in both `ensure` and `ensure:load`.
* in `ensure`, remove requests for diffs we aready have

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 14:01:39 +00:00
Mark Jaquith
13a7d2a743 Revisions: Loading indicator, cleanup, bug fixes.
* Loading indicator when the user is waiting for a trip to the server.
* Bug fixes for diff priming.
* Fix the date display.
* Forget about local comparator, instead order by `modified` on the server.
* Initialize the frame model before the view (this was the source of a LOT of heartache).

git-svn-id: http://core.svn.wordpress.org/trunk@24667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-12 05:11:56 +00:00
Mark Jaquith
2940a03ae5 Revisions: Use jQuery animation.
The CSS3 animations caused issues because the element was still there, and there is no standard way to know when a CSS3 animation is done.

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 18:43:12 +00:00
Mark Jaquith
ef5e733dbf Revisions: Bunch of refactoring and code cleanup
* Extracted a lot of model-y stuff from the view code.
* Slider now has a proper model, with communication with other models.
* Use of `get( foo )` instead of `findWhere({ id: foo })`.
* Properly set the `from` diff when routing single mode.
* Bind `prev()` and `next()` to their model.
* Tick marks are now percentage based, which means the slider resizes with the browser, without JS resize events.
* When scrubbing, the position of the scrubber is considered a hover, so you can fall off the timeline while still scrubbing and the tooltips will persist.
* Tooltips fade in and out.
* Tooltips hang around for a grace period instead of immediately going away. More forgiving.
* Unused code paths removed.
* Got rid of a bunch of view-to-view communication.
* Use `_.times()` instead of a `for` loop.
* Removed premature `Math.floor()` and `Math.ceil()` calls that were making things not add up to 100%.

See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-11 09:14:14 +00:00
Helen Hou-Sandí
561a323362 Add sliding animations to the accordion. props kovshenin, DrewAPicture, helen. fixes #23890.
git-svn-id: http://core.svn.wordpress.org/trunk@24644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 16:32:09 +00:00
Andrew Nacin
e0ba6b979f Avoid a scrollbar in the iframe used for plugin sandboxing. props kovshenin. see #10840.
git-svn-id: http://core.svn.wordpress.org/trunk@24631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 04:56:28 +00:00
Mark Jaquith
8035bd88ad Revisions: Get rid of an unneccessary ID. IDs are a bad idea.
See #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-10 04:37:50 +00:00
Mark Jaquith
561db4a6da Tick marks are back for revisions
* Simple tick marks
* Tooltips snap to tick marks
* Tooltips arrow reverses side for LTR/RTL
* Fix for routing issue where just the hash is changed in the URL bar relating to compare two mode

see #24425. props adamsilverstein, ocean90.

git-svn-id: http://core.svn.wordpress.org/trunk@24595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 21:37:03 +00:00
Andrew Nacin
22b6c3bcc9 Prevent overflow of the parent term dropdown in the new term form. props desrosj, fixes #23397.
git-svn-id: http://core.svn.wordpress.org/trunk@24588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 16:55:59 +00:00
Dominik Schilling
4fc5e70228 Revisions improvements
* Corrected routing behavior
* Simplified CSS for tooltips
* Compare two mode for RTL
* Support for posts without titles 

props adamsilverstein, ocean90. see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-06 10:48:14 +00:00
Mark Jaquith
5f19c95249 Gracefully slide down the "{Name} is editing" notice portion of the post row, so everything isn't shifting down in an instant and throwing off people's clicks.
fixes #24553. props kadamwhite, johnbillion.

git-svn-id: http://core.svn.wordpress.org/trunk@24576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 23:17:25 +00:00
Dominik Schilling
b95c432870 Revisions: CSS cleanup, see #24425.
git-svn-id: http://core.svn.wordpress.org/trunk@24574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 22:15:37 +00:00
Mark Jaquith
7296424bd2 Push menu settings checkboxes down to a new line to avoid weird overlaps in some languages.
props SergeyBiryukov. see #24546.

git-svn-id: http://core.svn.wordpress.org/trunk@24566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 18:39:21 +00:00
Mark Jaquith
37db654d60 Revisions improvements
* Consolidated router code
* Corrected routing behavior
* Tooltip model
* Removed mouse dragging code

props adamsilverstein, ocean90. see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-05 17:44:47 +00:00
Dominik Schilling
f6ca108240 Revisions UI update:
* Restore Compare two mode
* Restore tooltips
* RTL support
* First pass for URL routing and history

props adamsilverstein, see #24425.

git-svn-id: http://core.svn.wordpress.org/trunk@24549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-03 20:27:19 +00:00
Mark Jaquith
77abb9ff01 Cleanup of the revisions screen, both on the PHP API side, and the JS.
* Much simpler PHP API
* Cleaner and more Backbone-y JS API
* Consequently, does batch queries; this now scales up to hundreds of revisions

Currently missing, but much easier considering the cleaned up base:

* Compare two mode
* RTL

props koopersmith, nacin, adamsilverstein, ocean90. see #24425

git-svn-id: http://core.svn.wordpress.org/trunk@24520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-26 21:06:50 +00:00
Helen Hou-Sandí
bd231c209f Add post format icons to the radio chooser. This also trims empty margins from the sprites to make them usable in RTL and make positioning numbers more sane. props ryelle, kovshenin for the initial patch. fixes #24519.
git-svn-id: http://core.svn.wordpress.org/trunk@24429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-07 17:15:53 +00:00
Helen Hou-Sandí
b9c5b62965 Change the post format icons sprite to be vertical rather than horizontal in order to allow it to be used for wider items such as labels. RTL tweak for the icon in the posts list table. See #16047, #24519.
git-svn-id: http://core.svn.wordpress.org/trunk@24426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-07 15:11:42 +00:00
Helen Hou-Sandí
99c0762fca Remove obsolete CSS related to post formats UI. See #24452, #24502.
git-svn-id: http://core.svn.wordpress.org/trunk@24418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 15:40:17 +00:00
Daryl Koopersmith
49ec824b9f Improve contrast of revision diffs. Fixes #24422.
git-svn-id: http://core.svn.wordpress.org/trunk@24355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-25 16:48:37 +00:00
Sergey Biryukov
d7840ecf2f Auto-expand the menus accordion if JavaScript is disabled. fixes #24402.
git-svn-id: http://core.svn.wordpress.org/trunk@24348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-24 20:50:10 +00:00
Andrew Ozz
a26190eb2e Post locks:
- Change from IDs to classes for the notification-dialog divs so they can be reused.
- Do not check post locks if the dialog's html is not present.
- Do not check post locks if there is only one user on a single site install.
See #23697.

git-svn-id: http://core.svn.wordpress.org/trunk@24304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-20 19:36:29 +00:00
Andrew Ozz
d1c33dea55 Post format retina icons for both color themes, props melchoyce, aaroncampbell. See #24290, see #24331.
git-svn-id: http://core.svn.wordpress.org/trunk@24294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-19 02:05:52 +00:00
Andrew Ozz
2ae4b8e73e Post format image: fix distorted image preview on iPads, see #24046
git-svn-id: http://core.svn.wordpress.org/trunk@24292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-19 00:49:58 +00:00
Andrew Ozz
7255abb66c Fix showing and hiding of UI elements when disabling the Post Formats UI, props kovshenin, see #24327
git-svn-id: http://core.svn.wordpress.org/trunk@24264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 20:43:09 +00:00
Dominik Schilling
6d0173ba11 RTL support for the new post Format UI. see #24326.
git-svn-id: http://core.svn.wordpress.org/trunk@24258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 19:01:57 +00:00
Dominik Schilling
91880a5459 RTL: Fix some issues on nav menu screen. see #24326.
git-svn-id: http://core.svn.wordpress.org/trunk@24256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-14 18:26:41 +00:00
Mark Jaquith
917fbaa81c Improvements of Image format dropzone
* Limit drag-drop Image format zone to HTML5 runtime
* Only keep the first file dropped
* Only upload image files
* Fix CSS for the progress bar

props azaozz. see #24291.

git-svn-id: http://core.svn.wordpress.org/trunk@24236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 18:49:05 +00:00
Mark Jaquith
f63001eb2c Improve the UX and flow of the Image post format.
* Drag-and-drop
* Textarea for HTML/URL hidden to start
* Bigger click target for entering Media modal
* Image preview height-contrained to 300 pixels
* Hid the alignment, size, etc options that didn't have an effect anyway
* Got wp-format-{format} into the <body> class

props DrewAPicture, aaroncampbell, markjaquith, azaozz. see #24291.

git-svn-id: http://core.svn.wordpress.org/trunk@24226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 22:45:14 +00:00
Dominik Schilling
62b1b71b02 Revisions UI: Redesigned slider handlers.
Also:
* Fix diff header styling in grey admin theme
* Prevent an overlap of the compare two checkbox on smaller screens

props melchoyce, DrewAPicture, adamsilverstein. fixes #24276.

git-svn-id: http://core.svn.wordpress.org/trunk@24219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-09 10:07:26 +00:00
Dominik Schilling
cbec9880a7 Revisions UI: RTL support. (And inline docs.)
props DrewAPicture, adamsilverstein. fixes #23897.

git-svn-id: http://core.svn.wordpress.org/trunk@24205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:22:01 +00:00
Dominik Schilling
2f1777986c Revisions UI: Just another update - Now with improved tick marks and tooltips.
props adamsilverstein. see #23935.

git-svn-id: http://core.svn.wordpress.org/trunk@24174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-03 23:17:06 +00:00
Dominik Schilling
ea1cecebee Revisions UI: Add translation contexts and remove unneeded lines.
props nao. fixes #23917.

git-svn-id: http://core.svn.wordpress.org/trunk@24157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 10:12:19 +00:00
Dominik Schilling
0de35b1035 Revisions: Remove the ID from the "restored by" line. props adamsilverstein. see #18733.
git-svn-id: http://core.svn.wordpress.org/trunk@24156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-02 09:35:35 +00:00