Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-18 08:36:04 +01:00
Code Issues Projects Releases Wiki Activity
21,343 Commits 50 Branches 748 Tags 792 MiB
868873da55
Commit Graph

21343 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andrew Nacin
e09094434e Restore captions for non-image attachments. see #22759. 
git-svn-id: http://core.svn.wordpress.org/trunk@23087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 03:36:17 +00:00
Daryl Koopersmith
8efc323e2e Add hidden fields via attachment_fields_to_edit to the existing compat output. props nacin. fixes #22769. 
git-svn-id: http://core.svn.wordpress.org/trunk@23086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 03:28:21 +00:00
Daryl Koopersmith
c75dc67668 Do not alter the body's overflow attribute when the media modal is opened. Fix image insertion in the visual editor in Firefox. props azaozz. fixes #22765. 
git-svn-id: http://core.svn.wordpress.org/trunk@23085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 03:15:39 +00:00
Bot (Assets)
4f3c1bb8f1 Compress scripts/styles: 3.5-RC3-23084. 
git-svn-id: http://core.svn.wordpress.org/trunk@23084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 00:42:44 +00:00
Andrew Nacin
173806d7a1 Restore the Description field to the media UI in 3.5. 
We tried in vain -- a noble but ultimately failed effort -- to reduce the number of fields for attachments from four (title, caption, alt, description) to one (caption for images, title otherwise). Alternative text needed to stay for accessibility reasons, of course.

Eventually title returned due to heavy plugin reliance. Description is too used by too many plugins (often times incorrectly -- the caption is more likely the proper field), hence its less-than-triumphant return today.

Version 3.5 has tried to streamline media in a number of ways. Removing fields may have been too much at once, as it forced not only a user interface change, but a paradigm change as well.

Finally, on upload we populate the description field with IPTC/EXIF captions, rather than the caption field. See #22768, this should be fixed. For now, Description stays.

This commit also restores 'Title' attribute editing to the main tab of the Edit Image dialog. The "Title" field no longer populates title attributes for <img> tags by design (for accessibility and other purposes, see #18984). So, here is a more obvious 'workaround' for the tooltip community.

Finally, this:
 * Cleans up the post.php attachment editor, including by showing a prettier form of the mime type.
 * Enables plugins to specifically hide attachment_fields_to_edit from either post.php (where you can create meta boxes) or the modal (which you may not want to clutter), for compatibility reasons.
 * Hides the 'Describe this file...' placeholder when a field is read-only in the modal.

props nacin, helenyhou.
fixes #22759.



git-svn-id: http://core.svn.wordpress.org/trunk@23083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-06 00:41:06 +00:00
Andrew Nacin
a13a011265 Translate the 'First Steps with WordPress' Codex link. props SergeyBiryukov, fixes #22767. 
git-svn-id: http://core.svn.wordpress.org/trunk@23082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 22:51:24 +00:00
Andrew Nacin
ce11438e77 Media list table: Fix the categories column, hidden thanks to a typo. props eddiemoya, fixes #22764. see #21240, #21391. 
git-svn-id: http://core.svn.wordpress.org/trunk@23081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 22:49:51 +00:00
Bot (Assets)
7dab3d4538 Compress scripts/styles: 3.5-RC3-23080. 
git-svn-id: http://core.svn.wordpress.org/trunk@23080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 21:22:59 +00:00
Ryan Boren
52a9a8cb81 Fix uploads in IE9 
Props koopersmith
fixes #22762


git-svn-id: http://core.svn.wordpress.org/trunk@23079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 21:21:17 +00:00
Bot (Assets)
5927d8a3db Compress scripts/styles: 3.5-RC3-23078. 
git-svn-id: http://core.svn.wordpress.org/trunk@23078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 19:22:54 +00:00
Andrew Nacin
b1ba49f26e Media: Account for the most obvious and common style conflicts that may occur when the media modal is loaded on the frontend. Tested primarily with P2. props lessbloat, helenyhou. fixes #22752. 
git-svn-id: http://core.svn.wordpress.org/trunk@23077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 19:15:40 +00:00
Andrew Nacin
88f61468b3 Media: Final names for the actions in the dialog sidebar: "Insert from URL" and "Set Featured Image" to go with "Insert Media" and "Create Gallery". 
Longer strings (such as a translation) looks excellent when it wraps to another line.

props markjaquith, fixes #22753.



git-svn-id: http://core.svn.wordpress.org/trunk@23076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 19:07:48 +00:00
Andrew Nacin
c42ae7acb6 Media: Use '%d selected' for the selection string, and offer a comment to translators to help them find a workable solution with this would-be plural string. fixes #22749. see #22229. 
git-svn-id: http://core.svn.wordpress.org/trunk@23075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 19:03:38 +00:00
Andrew Nacin
2763e74dd8 Script loader: Chunk the script names as passed to load-scripts.php into 128-character pieces. Avoids hitting a limit for the length of a single variable, such as suhosin.get.max_value_length which defaults to 512. fixes #22757. 
git-svn-id: http://core.svn.wordpress.org/trunk@23074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 18:57:56 +00:00
Bot (Assets)
fb433d2597 Compress scripts/styles: 3.5-RC3-23073. 
git-svn-id: http://core.svn.wordpress.org/trunk@23073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 10:58:32 +00:00
Mark Jaquith
bc8ddb3e64 Intelligently make media fields readonly when the user cannot update or do anything with them. props koopersmith, helenyhou, nacin. fixes #22613 
git-svn-id: http://core.svn.wordpress.org/trunk@23072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 10:29:24 +00:00
Mark Jaquith
298d374b81 Better responsive breakpoints for the Gallery editing screen. props koopersmith. fixes #22741 
git-svn-id: http://core.svn.wordpress.org/trunk@23071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 10:15:42 +00:00
Mark Jaquith
4d35b3409b Implement tabbing between fields in the media modal. props lessbloat, koopersmith. fixes #22659 
git-svn-id: http://core.svn.wordpress.org/trunk@23070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 09:57:58 +00:00
Mark Jaquith
d8d39ff764 When setting the featured image from the dedicated meta box, only show the featured image section in the media chooser. props koopersmith. fixes #22731 
* Less distracting
* Some of these sections won't apply for CPTs without an editor

git-svn-id: http://core.svn.wordpress.org/trunk@23069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 09:43:10 +00:00
Mark Jaquith
e84a4a0c89 Fix the "Uploaded to this post" filter in the "Add to gallery" state. fixes #22723 
Also, use "images" wording instead of generic "media items" when in a gallery (images-only) context. fixes #22722

Both are props koopersmith

git-svn-id: http://core.svn.wordpress.org/trunk@23068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 09:25:17 +00:00
Mark Jaquith
98fb6e45d7 Use data on the ui.item to transport the original Sortable index for the update() function. This way extensions can set/access this info in their own custom Sortable functions. see #22696 
git-svn-id: http://core.svn.wordpress.org/trunk@23067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 09:04:19 +00:00
Bot (Assets)
48382b4b0a Compress scripts/styles: 3.5-RC3-23066. 
git-svn-id: http://core.svn.wordpress.org/trunk@23066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 04:58:33 +00:00
Ryan Boren
c4d04dd476 Clear the From URL view in the media modal after inserting an image. Improve button enable checks. 
Props koopersmith
fixes #22740


git-svn-id: http://core.svn.wordpress.org/trunk@23065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 04:43:51 +00:00
Mark Jaquith
b6982a0804 Allow a sortable options hash to be passed in, so you can override the defaults. props koopersmith. see #22696 
git-svn-id: http://core.svn.wordpress.org/trunk@23064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 04:11:49 +00:00
Andrew Nacin
4676fb1eda Media: Sidebar labels should be display block. Prevents wonkiness like inputs disappearing because Chrome no like you. props helenyhou. fixes #22721. 
git-svn-id: http://core.svn.wordpress.org/trunk@23063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 04:06:45 +00:00
Bot (Assets)
b8e25c09bc Compress scripts/styles: 3.5-RC3-23062. 
git-svn-id: http://core.svn.wordpress.org/trunk@23062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 03:30:48 +00:00
Andrew Nacin
49fd122391 Media IE7 fixes. props azaozz, lessbloat. fixes #22732. 
git-svn-id: http://core.svn.wordpress.org/trunk@23061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 03:15:53 +00:00
Lance Willett
97a180bf77 Twenty Eleven: remove buggy word-break property, use word-wrap instead, for better hyphenation and word breaking in nested comments. Fixes #22751. 
git-svn-id: http://core.svn.wordpress.org/trunk@23060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 03:06:46 +00:00
Bot (Assets)
1077e9ce03 Compress scripts/styles: 3.5-RC3-23059. 
git-svn-id: http://core.svn.wordpress.org/trunk@23059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 02:58:34 +00:00
Andrew Nacin
40ae89369f Admin ajax: Roll back new-style error sending in set-post-thumbnail. The JS handlers know to parse an unrecognized response (like -1 or 0) as a failure. see #21776. see #22750. 
git-svn-id: http://core.svn.wordpress.org/trunk@23058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 02:34:00 +00:00
Andrew Nacin
a914ab2e43 Media models: Trac and ignore deleted attachments. 
Treat an admin-ajax response of 1 as successful for backwards compatibility with existing handlers.

props koopersmith. fixes #22750.



git-svn-id: http://core.svn.wordpress.org/trunk@23057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 02:31:41 +00:00
Andrew Nacin
e1405b6f1d Media: Don't try to resize the bottom selection UI. props koopersmith. fixes #22748. 
git-svn-id: http://core.svn.wordpress.org/trunk@23056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 01:38:44 +00:00
Andrew Nacin
dc9e6144be Fix inserting of multiple attachments with captions when the first attachment does not have a caption. props azaozz. fixes #22720. 
git-svn-id: http://core.svn.wordpress.org/trunk@23055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 00:59:25 +00:00
Bot (Assets)
87d43d7aa9 Compress scripts/styles: 3.5-RC3-23054. 
git-svn-id: http://core.svn.wordpress.org/trunk@23054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 00:58:31 +00:00
Daryl Koopersmith
81d474cda0 Toggle display of plupload overlays when the select files button is hidden. see #22732. 
git-svn-id: http://core.svn.wordpress.org/trunk@23053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 00:45:21 +00:00
Andrew Nacin
c7fee4d3e6 Minimum heights for the media modal to prevent it from scrunching up on tiny devices. (Panning is better.) props helenyhou. fixes #22747. 
git-svn-id: http://core.svn.wordpress.org/trunk@23052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 00:40:13 +00:00
Andrew Nacin
d720772ef3 Media: Return to the library when the editing a selection and all items get de-selected. props koopersmith. fixes #22715. 
git-svn-id: http://core.svn.wordpress.org/trunk@23051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 00:22:11 +00:00
Andrew Nacin
aaf5d77d35 Remove options-privacy.php, as intended by [21838]. see #16416. see #22349. 
git-svn-id: http://core.svn.wordpress.org/trunk@23050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-05 00:16:54 +00:00
Andrew Nacin
b8cd44b0d2 Media views: Better checkbox positioning. props helenyhou. fixes #22724. 
git-svn-id: http://core.svn.wordpress.org/trunk@23049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 23:56:37 +00:00
Ryan Boren
51db7de93b When inserting an image From URL, show the fields only if it looks like we have a valid image. 
Props koopersmith
fixes #22740


git-svn-id: http://core.svn.wordpress.org/trunk@23048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 23:07:41 +00:00
Bot (Assets)
d3b24a0e15 Compress scripts/styles: 3.5-RC3-23047. TinyMCE updated. 
git-svn-id: http://core.svn.wordpress.org/trunk@23047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 22:44:27 +00:00
Ryan Boren
c9db63ab1e When deleting an image in the editor with the delete or backspace keys, hide the edit and delete popup buttons. 
Props azaozz, lessbloat
fixes #22717


git-svn-id: http://core.svn.wordpress.org/trunk@23046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 22:42:26 +00:00
Ryan Boren
edf9769d26 In the media modal, clear attachment details when clearing the selection. 
Props koopersmith
fixes #22718


git-svn-id: http://core.svn.wordpress.org/trunk@23045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 22:19:08 +00:00
Andrew Nacin
0bd02ac6bb Use correct button class hierarchy to ensure the 'Update' button is button-large. see #21598. 
git-svn-id: http://core.svn.wordpress.org/trunk@23044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 22:02:25 +00:00
Bot (Assets)
6cb358e0f4 Compress scripts/styles: 3.5-RC3-23043. 
git-svn-id: http://core.svn.wordpress.org/trunk@23043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 20:58:33 +00:00
Andrew Nacin
bd5956087a Media: When doing a multiple-insert into the editor, separate each inserted item with two line breaks. props tar.gz. see #22720. 
git-svn-id: http://core.svn.wordpress.org/trunk@23042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 20:52:58 +00:00
Andrew Nacin
d47267224c When adding images to a gallery, use "Images" as the filter name, rather than "All media items". props koopersmith. fixes #22722. 
git-svn-id: http://core.svn.wordpress.org/trunk@23041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 20:51:37 +00:00
Bot (Assets)
affabf29f4 Compress scripts/styles: 3.5-RC3-23040. 
git-svn-id: http://core.svn.wordpress.org/trunk@23040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 19:56:16 +00:00
Andrew Ozz
48ef1a9784 RTL: properly align the demo image in the Edit Image popup, props nacin, fixes #22733 
git-svn-id: http://core.svn.wordpress.org/trunk@23039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 19:51:35 +00:00
Andrew Nacin
b20c0a5bd5 Image editor doc fixes. props DH-Shredder. see #6821. 
git-svn-id: http://core.svn.wordpress.org/trunk@23038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-04 19:42:28 +00:00