Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-26 11:08:06 +01:00
Code Issues Projects Releases Wiki Activity
25,877 Commits 50 Branches 749 Tags 806 MiB
88b96dc036
Commit Graph

54 Commits

Author SHA1 Message Date
Scott Taylor
3054b924a3 In WP_Users_List_Table::get_views(), $current_role is set and never used. 
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28296


git-svn-id: http://core.svn.wordpress.org/trunk@28124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 15:33:15 +00:00
Drew Jaynes
16941beac1 Tweak inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props kpdesign.
Fixes #26203.

Built from https://develop.svn.wordpress.org/trunk@27355


git-svn-id: http://core.svn.wordpress.org/trunk@27206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-02 20:32:15 +00:00
Drew Jaynes
15068e1cd4 Inline documentation for hooks in wp-admin/includes/class-wp-users-list-table.php. 
Props leewillis77.
Fixes #26203.

Built from https://develop.svn.wordpress.org/trunk@27342


git-svn-id: http://core.svn.wordpress.org/trunk@27194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-01 15:00:15 +00:00
Drew Jaynes
8dc5888cfa Improve inline documentation for WP_Users_List_Table. 
Props leewillis77 for the initial patch.
Fixes #26564.

Built from https://develop.svn.wordpress.org/trunk@27301


git-svn-id: http://core.svn.wordpress.org/trunk@27154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-26 22:20:17 +00:00
Andrew Nacin
39e32ed1eb Consistently trim and unslash search queries for the users list tables. 
props aubreypwd.
fixes #26115.

Built from https://develop.svn.wordpress.org/trunk@27077


git-svn-id: http://core.svn.wordpress.org/trunk@26950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-02 22:10:12 +00:00
Sergey Biryukov
dace3f0b6d Remove redundant echo calls from list tables. Don't mix string concatenation with direct output. see #24210. 
git-svn-id: http://core.svn.wordpress.org/trunk@24123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-29 01:10:50 +00:00
Ryan Boren
5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:00:25 +00:00
Ryan Boren
43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Ryan Boren
cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Helen Hou-Sandí
b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665. 
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-12-20 15:55:32 +00:00
Andrew Nacin
c185f0c9bd Use correct variable. see #17860. 
git-svn-id: http://core.svn.wordpress.org/trunk@22689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-19 21:43:47 +00:00
Andrew Nacin
d88922565e Less insane multiple role handling in the users list table. 
If the user has more than one role, opt to show the first role that is
'editable', if present. Otherwise, fall back to the remaining roles.

In the future, we should show a comma-separated list of all roles,
editable or otherwise, and this list should be filterable, either by user,
or by the roles which can appear. Probably both.

In multisite, only hide users that have no capabilities (in case they
possess a leftover, empty wp_xx_capabilities key from the MU days),
not users that have no role, as they may have a cap but no role.

see #22361. fixes #17860.



git-svn-id: http://core.svn.wordpress.org/trunk@22686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-19 19:16:31 +00:00
Andrew Nacin
69d63c243d Fix the 'Change' button in the users list table. props c3mdigital. fixes #22034. 
git-svn-id: http://core.svn.wordpress.org/trunk@22423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 18:34:46 +00:00
Andrew Nacin
dd50d7d0e0 restrict_manage_users action. props jakemgold, johnjamesjacoby. fixes #19295. 
git-svn-id: http://core.svn.wordpress.org/trunk@22414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 07:59:46 +00:00
Ryan Boren
a3cfe28527 Reduce reliance on global variables in the list tables. Allow passing a screen ID to the list tables so that ajax handlers can set the needed screen. 
Props nacin
fixes #21871


git-svn-id: http://core.svn.wordpress.org/trunk@21914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-19 12:43:31 +00:00
Andrew Nacin
e914a04335 Trim incoming searches on the users list table. props tollmanz. fixes #21318. 
git-svn-id: http://core.svn.wordpress.org/trunk@21864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-16 16:11:01 +00:00
Daryl Koopersmith
67894a3407 New button styles. 
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: http://core.svn.wordpress.org/trunk@21789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-08 04:58:34 +00:00
nacin
7127ed1197 Move most instances of new WP_User to get_userdata(). see #21120. 
git-svn-id: http://core.svn.wordpress.org/trunk@21413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-03 01:06:05 +00:00
ryan
7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307 
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-30 18:30:03 +00:00
ryan
73addbbd24 More screen reader text for list table checkboxes and theme install search. Props MikeLittle, SergeyBiryukov. see #21325 
git-svn-id: http://core.svn.wordpress.org/trunk@21323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-25 16:18:14 +00:00
ryan
c36145c9aa Add screen reader text to checkboxes in list tables. Props MikeLittle, nacin. see #21325 
git-svn-id: http://core.svn.wordpress.org/trunk@21317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-24 18:01:22 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
nacin
0fd3915e9f number_format_i18n for role user counts. props sirzooro, fixes #18305. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-21 05:35:57 +00:00
ryan
0f06334e11 Introduce metadata_exists(), WP_User::get_data_by(), WP_User::get(), WP_User::has_prop(). Don't fill user objects with meta. Eliminate data duplication in cache and memory. Props scribu. see #15458 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-08-24 19:32:59 +00:00
ryan
6c6db6a54e Don't add search wildcards to an empty string. fixes #17719 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-07 16:05:04 +00:00
ryan
15a6a89eb0 Validation fixes. Props ocean90, xknown. fixes #17364 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-02 17:05:55 +00:00
ryan
8192d0dae8 Validation fixes. Props ocean90, peaceablewhale. see #17364 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-23 23:33:30 +00:00
ryan
04487fc268 Constructor cleanup. Props ocean90. fixes #16768 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-04-29 20:05:12 +00:00
ryan
19afce5e23 Disallow and hide user removal (as opposed to deletion) for single site installs. Removal is a multisite concept. Props nacin. fixes #16501 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-02-10 20:37:26 +00:00
ryan
ba47c80ef7 Add additional promote_users checks. Show Add existing button only for multisite. Don't show bulk actions if user can't promote users. Show add new user menu if user has create_users but not promote_users. Props nacin. fixes #16501 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-02-09 17:30:26 +00:00
markjaquith
df3882ab23 Fix the "Back to Authors and Users" link on Edit Users page. props SergeyBiryukov. fixes #16275 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-17 23:36:23 +00:00
nacin
37075f7f71 Remove AJAX from list tables. first pass. see #16262. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-16 21:47:24 +00:00
nacin
a099ac06a7 Remove assignment that is later overridden. props PeteMall. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-01-16 05:47:21 +00:00
ryan
b6346ae5cd Default to leading and trailing wildcards for site user searches. Require explicit trailing wildcard asterisk request for network user searches. Disallow leading wildcards for network user searches. Move wildcard policy up the stake, allowing more flexibility in WP_User_Query. Props SergeyBiryukov. fixes #16014 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-30 23:38:21 +00:00
ryan
587ea006b5 Translations in title attributes require esc_attr(). 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-21 17:17:58 +00:00
scribu
c1e19baef8 Disable sorting by post count for now. See #15861 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-17 10:25:27 +00:00
scribu
0879929ca7 Make WP_User_Query return regular objects by default. Fixes #15854 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-17 00:38:15 +00:00
nacin
a189f21c45 Replace check_permissions() with ajax_user_can(). New method returns true/false to current_user_can(), which we then handle in admin ajax. see #15326. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 09:18:28 +00:00
nacin
cc08068dba Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-16 08:43:22 +00:00
ryan
3949ce12d0 Pink trailing whites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-13 21:21:50 +00:00
nacin
898e58d568 Fix logic inversion. see #15699. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-08 09:28:20 +00:00
nacin
944f37cd3e Don't check post counts in the network admin. props scribu, fixes #15699. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-07 20:54:04 +00:00
PeteMall
9855ee1aa2 Hide posts column for site-users. Props ocean90, see #15558 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-24 19:51:36 +00:00
PeteMall
652db28fad Add screen option in site-users. Props duck_, see #15558 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-24 16:54:53 +00:00
PeteMall
b27bd5b253 Adapt user-list-table for network admin site-users. See #15558 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-24 05:31:25 +00:00
scribu
0324721ed2 Document url_shorten() and use in more places. Props latz for initial patch. Fixes #15540 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-22 17:17:31 +00:00
nacin
d22cc9bd64 s/Login/Username/ to restore 3.0 string. props demetris, fixes #15453. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-17 16:58:15 +00:00
scribu
e496292ae5 Make manage_users_custom_column hook consistent between WP_(MS)?_Users_List_Table. Fixes #14562 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-13 20:47:34 +00:00
scribu
c0b067fcf5 remove leading <li> from get_views() and add it later. Fixes #15321 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-05 14:34:09 +00:00