Andrea Fercia
88e515fac0
Accessibility: Improve the suggested image size text in the media views.
...
Adds `pixels` as unit, avoiding abbreviation for a clearer pronunciation by screen
readers. Also, adds the word `by` instead of the special character `times`.
Props Presskopp, stormrockwell.
Fixes #38932 .
Built from https://develop.svn.wordpress.org/trunk@40573
git-svn-id: http://core.svn.wordpress.org/trunk@40443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-05 23:29:44 +00:00
Andrea Fercia
471f1e7201
Accessibility: Wrap the installed themes search field within a form element.
...
Valid code is important not just to formally meet the specification, but also to
ensure user agents, including assistive technologies, can accurately interpret
and parse content. When HTML elements are not used in the recommended way,
user agents may render them in unexpected ways. It can also become a problem for
compatibility with older or even future browsers, devices, or other software.
See W3C WCAG 4.1.1.
Props takayukister, aryamaaru.
Fixes #34881 .
Built from https://develop.svn.wordpress.org/trunk@40572
git-svn-id: http://core.svn.wordpress.org/trunk@40442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-05 19:02:45 +00:00
Adam Silverstein
428afdaa5a
REST API: Improve strings added after 4.7 string freeze.
...
Clarify the `rest_orderby_include_missing_include` error message.
Props PranaliPatel.
Fixes #39178 .
Built from https://develop.svn.wordpress.org/trunk@40571
git-svn-id: http://core.svn.wordpress.org/trunk@40441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-05 18:49:47 +00:00
Andrea Fercia
3dab32af54
Accessibility: Improve the color contrast ratio of the dismiss notice buttons.
...
Props chris_dev.
Fixes #39970 .
Built from https://develop.svn.wordpress.org/trunk@40570
git-svn-id: http://core.svn.wordpress.org/trunk@40440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-04 22:32:46 +00:00
Andrea Fercia
3c7698808f
Customize: Fix a visual glitch on the widget control animation introduced in [40480].
...
Also, restores the original design intent that was meant to "compact widget-tops
on smaller laptops, but not tablets".
See #27112 .
Fixes #31476 .
Built from https://develop.svn.wordpress.org/trunk@40569
git-svn-id: http://core.svn.wordpress.org/trunk@40439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-03 22:39:44 +00:00
Dion Hulse
015249df3e
Bump Akismet external to 3.3.1
...
See #40002
git-svn-id: http://core.svn.wordpress.org/trunk@40438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-02 23:36:35 +00:00
Andrea Fercia
1ca3b70929
Accessibility: Avoid a keyboard trap on the date and time custom format settings.
...
Using the `focus` event on the date and time custom format fields made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom format setting. Instead, using `click` and `input` preserves
the original functionality when using any kind of pointing or input device.
Fixes #40515 .
Built from https://develop.svn.wordpress.org/trunk@40568
git-svn-id: http://core.svn.wordpress.org/trunk@40436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-02 20:03:42 +00:00
Weston Ruter
91a8af0ef6
Customize: Allow select
dropdowns to stretch full width in widened controls pane.
...
Props timmydcrawford.
Amends [40511].
Fixes #32296 .
Built from https://develop.svn.wordpress.org/trunk@40567
git-svn-id: http://core.svn.wordpress.org/trunk@40435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-02 19:30:46 +00:00
Sergey Biryukov
4995062686
Menus: Introduce page_menu_link_attributes
filter in Walker_Page::start_el()
for the HTML attributes applied to a page menu item's anchor element.
...
This complements the `nav_menu_link_attributes` filter used in `Walker_Nav_Menu::start_el()`.
Props pbiron.
Fixes #40359 .
Built from https://develop.svn.wordpress.org/trunk@40565
git-svn-id: http://core.svn.wordpress.org/trunk@40434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-01 23:32:42 +00:00
John Blackbourn
42845bcb2d
Build/Test Tools: Automatically skip tests in the ms-required
and ms-excluded
groups.
...
This removes the need to manually call `$this->skipWithMultisite()` and `$this->skipWithoutMultisite()` from within the test when the test only runs without Multisite or only runs on Multisite, respectively.
Props jdgrimes for the suggestion.
Fixes #40531
Built from https://develop.svn.wordpress.org/trunk@40564
git-svn-id: http://core.svn.wordpress.org/trunk@40433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-01 20:35:44 +00:00
John Blackbourn
282408b6c0
Users: Add two missing special cases to the capability tests for non-logged-in users.
...
Also updates a `expectedIncorrectUsage` notation.
See #37405
Built from https://develop.svn.wordpress.org/trunk@40563
git-svn-id: http://core.svn.wordpress.org/trunk@40432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-01 16:19:44 +00:00
John Blackbourn
d24f1f5864
Build/Test Tools: Pin the WordPress Importer plugin to version 0.6.3 when testing on Travis.
...
Fixes #40620
Built from https://develop.svn.wordpress.org/trunk@40562
git-svn-id: http://core.svn.wordpress.org/trunk@40431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-01 11:30:43 +00:00
John Blackbourn
d1647d0b8c
Build/Test Tools: Add object-cache.php to the unit test suite.
...
This removes an unnecessary external dependency from the Travis tests.
Fixes #40619
Built from https://develop.svn.wordpress.org/trunk@40561
git-svn-id: http://core.svn.wordpress.org/trunk@40430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-01 11:21:44 +00:00
John Blackbourn
eb4db0e19c
Users: Ensure user counts remain accurate if users are added to or removed from the users
table without corresponding usermeta
entries being added or removed.
...
This has a slight performance impact on sites with a large number of users when the `time` strategy is used for counting users. Hopefully this impact will be negated by enhancements proposed in #38741 .
Props psoluch, dots, boonebgorges, ptbello, tharsheblows
Fixes #29785
Built from https://develop.svn.wordpress.org/trunk@40560
git-svn-id: http://core.svn.wordpress.org/trunk@40429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-30 13:03:41 +00:00
John Blackbourn
224b88ca42
Posts, Post Types: Revert [40558] pending investigation.
...
See #18375
Built from https://develop.svn.wordpress.org/trunk@40559
git-svn-id: http://core.svn.wordpress.org/trunk@40428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-30 11:19:45 +00:00
John Blackbourn
53acb5b6d4
Posts, Post Types: Correct the attachment post type template unit test introduced in [38951].
...
Also adds additional assertions for the templates.
See #18375
Built from https://develop.svn.wordpress.org/trunk@40558
git-svn-id: http://core.svn.wordpress.org/trunk@40427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-29 21:16:45 +00:00
Boone Gorges
fb0a08c8be
Fix broken check_comment()
test.
...
The test `Tests_Comment_CheckComment::test_should_return_true_when_content_does_not_match_moderation_keys()`
did not, in fact, test for a `true` value, but for a false one.
Switching to `assertTrue()` caused a failure, because the test comment
triggered the 'comment_moderation' test. As in other tests in the file,
the solution is to force 'comment_moderation' to 0 for the purposes of
the test.
Introduced in [32519].
Props stephdau.
Fixes #40584 .
Built from https://develop.svn.wordpress.org/trunk@40557
git-svn-id: http://core.svn.wordpress.org/trunk@40426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-27 16:23:47 +00:00
Andrea Fercia
f1be128cde
Widgets: Improve the News dashboard widget no-js notice.
...
In the rare case this notice was displayed, it was unstyled. Uses the notice
error style to make it prettier and consistent with other no-js notices.
Also, some CSS clean-up.
Fixes #40529 .
Built from https://develop.svn.wordpress.org/trunk@40556
git-svn-id: http://core.svn.wordpress.org/trunk@40425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-25 16:42:44 +00:00
John Blackbourn
d3c74e8ce9
Feeds: Remove an incorrect usage of sizeof()
in a helper class used during unit testing of XML element handling.
...
This also helps tidy up the test output when running PHP 7.2.
See #40109
Built from https://develop.svn.wordpress.org/trunk@40555
git-svn-id: http://core.svn.wordpress.org/trunk@40424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-24 01:23:43 +00:00
John Blackbourn
89b358082e
Build/Test Tools: Remove HHVM from the test infrastructure on Travis.
...
Fixes #40548
Built from https://develop.svn.wordpress.org/trunk@40546
git-svn-id: http://core.svn.wordpress.org/trunk@40422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-24 00:28:44 +00:00
John Blackbourn
79ca3ca178
REST API: Remove a useless unit test.
...
See #35907 , #38373
Built from https://develop.svn.wordpress.org/trunk@40545
git-svn-id: http://core.svn.wordpress.org/trunk@40421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 22:20:41 +00:00
John Blackbourn
37aed623c0
Build/Test Tools: Remove more unnecessary test skipping when erroneous situations occur.
...
See #40533
Built from https://develop.svn.wordpress.org/trunk@40544
git-svn-id: http://core.svn.wordpress.org/trunk@40420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 22:12:42 +00:00
John Blackbourn
1ad93e1db9
Build/Test Tools: Introduce skipWithoutMultisite()
and skipWithMultisite
() methods into the test suite.
...
This brings much needed uniformity to test skipping when a test requires Multisite or when a test should be excluded from running when Multisite is enabled.
Used in conjunction with the `@group ms-required` and `@group ms-excluded` notation, this removes a significant number of skipped tests from the default test suite run.
Fixes #40531
Built from https://develop.svn.wordpress.org/trunk@40543
git-svn-id: http://core.svn.wordpress.org/trunk@40419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 21:58:41 +00:00
John Blackbourn
29b3932430
Build/Test Tools: More tweaks to the deprecated calls assertion. This needs to be triggered when there are unexpected deprecated calls or wrongdoings too.
...
See #40538
Built from https://develop.svn.wordpress.org/trunk@40542
git-svn-id: http://core.svn.wordpress.org/trunk@40418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 21:35:41 +00:00
John Blackbourn
0ec1f5aadf
Build/Test Tools: Only perform an assertion for deprecated calls and wrongdoings if any are expected.
...
This avoids masking risky tests that don't otherwise perform an assertion.
See #40538
Built from https://develop.svn.wordpress.org/trunk@40541
git-svn-id: http://core.svn.wordpress.org/trunk@40417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 21:29:43 +00:00
Sergey Biryukov
2e6e53d26f
Help/About: Fix typo in help text on Reading Settings screen.
...
Props Arena94, bhargavbhandari90.
Fixes #40530 .
Built from https://develop.svn.wordpress.org/trunk@40540
git-svn-id: http://core.svn.wordpress.org/trunk@40416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 14:34:42 +00:00
John Blackbourn
975d00bd54
Build/Test Tools: Move the setExpectedException()
method into the WP_Ajax_UnitTestCase
class to avoid a fatal error when PHPUnit 3.6 is in use.
...
This needs more investigation but it gets the test suite on PHP 5.2 passing again.
See #39822
Built from https://develop.svn.wordpress.org/trunk@40539
git-svn-id: http://core.svn.wordpress.org/trunk@40415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 11:46:42 +00:00
John Blackbourn
36c977b9b1
Build/Test Tools: Add Composer files to the cache on Travis.
...
The Travis cache is specific to the branch and language version (PHP version), so this should speed up each subsequent build once the cache is primed.
Props netweb
Fixes #40539
Built from https://develop.svn.wordpress.org/trunk@40538
git-svn-id: http://core.svn.wordpress.org/trunk@40414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 11:40:43 +00:00
Peter Wilson
717de16c68
Menus: Add filter to sub-menu class in nav menus.
...
Add new filter `nav_menu_submenu_css_class` to the `Walker_Nav_Menu::start_el()` method, allowing themers to modify the sub menu classes output by `wp_nav_menu()`.
Props: csloisel, darthaud, raisonon.
Fixes : #36163 .
Built from https://develop.svn.wordpress.org/trunk@40537
git-svn-id: http://core.svn.wordpress.org/trunk@40413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 07:16:43 +00:00
John Blackbourn
812ac18853
Build/Test Tools: Add support for PHPUnit 6+.
...
This adds a compatibility shim for the new namespaced structure of PHPUnit and the removed `setExpectedException()` method. In addition, this updates the Travis config so PHPUnit 6.1 is used where appropriate.
Props miyauchi, gitlost.
Fixes #39822
Built from https://develop.svn.wordpress.org/trunk@40536
git-svn-id: http://core.svn.wordpress.org/trunk@40412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 02:06:40 +00:00
John Blackbourn
6bcec554c3
Build/Test Tools: Ensure that WP_UnitTestCase::expectedDeprecated()
performs an assertion to avoid risky test notices.
...
See #40538
Built from https://develop.svn.wordpress.org/trunk@40535
git-svn-id: http://core.svn.wordpress.org/trunk@40411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 01:45:43 +00:00
John Blackbourn
3b24784333
Build/Test Tools: Be strict about tests that do not test anything.
...
See #40538
Built from https://develop.svn.wordpress.org/trunk@40534
git-svn-id: http://core.svn.wordpress.org/trunk@40410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-23 01:25:42 +00:00
John Blackbourn
6e4b6591d8
Build/Test Tools: Remove unnecessary checks and skips that should instead cause failures if they ever fail.
...
See #40533
Built from https://develop.svn.wordpress.org/trunk@40533
git-svn-id: http://core.svn.wordpress.org/trunk@40409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 22:55:40 +00:00
John Blackbourn
fe06ac7e39
Build/Test Tools: Convert more test skipping into hard failures. These dependencies should all be present when testing.
...
See #40533
Built from https://develop.svn.wordpress.org/trunk@40532
git-svn-id: http://core.svn.wordpress.org/trunk@40408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 22:12:41 +00:00
John Blackbourn
f1fff0b06e
Build/Test Tools: Convert more test skipping into hard failures. These dependencies should all be present when testing.
...
See #40533
Built from https://develop.svn.wordpress.org/trunk@40531
git-svn-id: http://core.svn.wordpress.org/trunk@40407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 22:01:42 +00:00
John Blackbourn
af587d874d
Build/Test Tools: Correct an incorrect ms-
group name.
...
See #40531
Built from https://develop.svn.wordpress.org/trunk@40530
git-svn-id: http://core.svn.wordpress.org/trunk@40406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 21:44:42 +00:00
John Blackbourn
e76e3d459a
Build/Test Tools: Partially revert [40524].
...
See #40533 , #40535
Built from https://develop.svn.wordpress.org/trunk@40529
git-svn-id: http://core.svn.wordpress.org/trunk@40405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 21:22:43 +00:00
John Blackbourn
69bb8fa5c9
Build/Test Tools: Add some locale debugging to the Travis config so we can determine which locales are available to test with.
...
See #40533 , #19861
Built from https://develop.svn.wordpress.org/trunk@40528
git-svn-id: http://core.svn.wordpress.org/trunk@40404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 21:01:42 +00:00
John Blackbourn
ba88762aa3
Build/Test Tools: Enable verbose mode in PHPUnit so we can see which tests are being skipped, and now that the number of skipped tests has been lowered.
...
See #40533 , #40531
Built from https://develop.svn.wordpress.org/trunk@40527
git-svn-id: http://core.svn.wordpress.org/trunk@40403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 20:25:39 +00:00
John Blackbourn
7696954d91
Build/Test Tools: Don't trigger a skipped test when the built version of wp-embed.min.js
isn't present.
...
The grunt command assertion prior to the check for the existence of the file is enough to safeguard this test.
See #34698 , #40533
Built from https://develop.svn.wordpress.org/trunk@40526
git-svn-id: http://core.svn.wordpress.org/trunk@40402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 20:18:42 +00:00
John Blackbourn
0371277d5a
Build/Test Tools: Replace test skipping with actual assertions when dealing with the DISALLOW_UNFILTERED_HTML
, DISALLOW_FILE_MODS
, and DISALLOW_FILE_EDIT
constants.
...
If any of these constants are set during testing, they should cause the tests to fail, not to be skipped, otherwise we have a situation where failure conditions are never seen.
See #40533
Built from https://develop.svn.wordpress.org/trunk@40525
git-svn-id: http://core.svn.wordpress.org/trunk@40401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 20:13:42 +00:00
John Blackbourn
1cbc2c3857
Build/Test Tools: Remove more skipped tests that should actually be failures if their conditions aren't satisfied.
...
See #40533
Built from https://develop.svn.wordpress.org/trunk@40524
git-svn-id: http://core.svn.wordpress.org/trunk@40400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 19:43:41 +00:00
John Blackbourn
a0e67d3e16
Build/Test Tools: Remove ancient UT ticket handling.
...
See #40533
Built from https://develop.svn.wordpress.org/trunk@40523
git-svn-id: http://core.svn.wordpress.org/trunk@40399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 19:39:43 +00:00
John Blackbourn
f12c419ee3
Build/Test Tools: Add some more tests to the ms-required
and ms-excluded
groups.
...
See #40531
Built from https://develop.svn.wordpress.org/trunk@40522
git-svn-id: http://core.svn.wordpress.org/trunk@40398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 19:22:44 +00:00
John Blackbourn
af6c8d1bc6
Build/Test Tools: Remove a useless test.
...
See #33898 , #40533
Built from https://develop.svn.wordpress.org/trunk@40521
git-svn-id: http://core.svn.wordpress.org/trunk@40397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 19:10:43 +00:00
John Blackbourn
17b73338f1
Build/Test Tools: Introduce ms-required
and ms-excluded
groups for tests.
...
Tests in the `ms-excluded` group are now excluded when running tests with multisite enabled, and tests in the `ms-required` group are excluded when running tests without multisite enabled. The end result is a significantly reduced number of skipped tests polluting PHPUnit's output, which means verbose mode can be used to more easily see which tests are skipped or incomplete, and why.
See #40531
Built from https://develop.svn.wordpress.org/trunk@40520
git-svn-id: http://core.svn.wordpress.org/trunk@40396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 18:59:41 +00:00
John Blackbourn
ed1d714572
Build/Test Tools: Don't skip tests when php.net or dev.mysql.com are unreachable.
...
This sort of behaviour subtly hides the fact that these tests will never fail if the URLs where version number information is fetched from go away for one reason or another.
See #40533
Built from https://develop.svn.wordpress.org/trunk@40519
git-svn-id: http://core.svn.wordpress.org/trunk@40395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 18:45:40 +00:00
John Blackbourn
aa8f871f21
Build/Test Tools: Avoid skipping canonical tests that are connected to open Trac tickets.
...
This is a remnant of the test suite behaviour before #30284 fixed most of it and makes it far too easy to hide failing tests.
If any tests begin to fail as a result of this change then they should be fixed.
Fixes #40534
Built from https://develop.svn.wordpress.org/trunk@40518
git-svn-id: http://core.svn.wordpress.org/trunk@40394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 18:26:42 +00:00
John Blackbourn
dd0346b330
Canonical: Don't skip tests if the test data is invalid.
...
See #40533
Built from https://develop.svn.wordpress.org/trunk@40517
git-svn-id: http://core.svn.wordpress.org/trunk@40393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 17:30:44 +00:00
John Blackbourn
8d3d439684
Posts, Post Types: Correct the fallback value for the label_count
argument of register_post_status()
.
...
While using `_n_noop()` here is technically incorrect, it does correct the fallback value as its usage in `translate_nooped_plural()` expects a correctly formatted associative array.
Props xrmx
Fixes #38686
Built from https://develop.svn.wordpress.org/trunk@40516
git-svn-id: http://core.svn.wordpress.org/trunk@40392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-22 14:17:42 +00:00