Commit Graph

16 Commits

Author SHA1 Message Date
Gary Pendergast
56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast
aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Lance Willett
17f69a89d4 Twenty Fourteen: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31250


git-svn-id: http://core.svn.wordpress.org/trunk@31231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 19:03:23 +00:00
Lance Willett
b66cc87ea4 Twenty Fourteen: correct escaping for parent post link and attachment link in image template. Props philiparthurmoore, see #28251.
Built from https://develop.svn.wordpress.org/trunk@28462


git-svn-id: http://core.svn.wordpress.org/trunk@28289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 22:31:15 +00:00
Lance Willett
6d4eca6cdf Twenty Fourteen: remove unneeded code from image template, see #25946.
Built from https://develop.svn.wordpress.org/trunk@26699


git-svn-id: http://core.svn.wordpress.org/trunk@26589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:51:11 +00:00
Lance Willett
c72bcbe38e Twenty Fourteen: avoid empty markup when no next or previous image in image template. Props MikeHansenMe and jartes, fixes #26208.
Built from https://develop.svn.wordpress.org/trunk@26586


git-svn-id: http://core.svn.wordpress.org/trunk@26476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 20:43:10 +00:00
Lance Willett
e46662b6ae Twenty Fourteen: update comment blocks to match inline docs standards. Props DrewAPicture, see #25837.
Built from https://develop.svn.wordpress.org/trunk@26556


git-svn-id: http://core.svn.wordpress.org/trunk@26447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:06:11 +00:00
Lance Willett
3c0f497fad Twenty Fourteen: general cleanup for spacing, inline comments. Props obenland, see #25946.
Built from https://develop.svn.wordpress.org/trunk@26227


git-svn-id: http://core.svn.wordpress.org/trunk@26134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 21:20:09 +00:00
Lance Willett
c3bd52a52f Twenty Fourteen: remove main-content element where not necessary, props iamtakashi. See #25946.
Built from https://develop.svn.wordpress.org/trunk@26217


git-svn-id: http://core.svn.wordpress.org/trunk@26125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 19:01:09 +00:00
Andrew Nacin
d0cfa40983 Add jshintrc to qunit.
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-30 14:39:10 +00:00
Lance Willett
eaf78d3f7c Twenty Fourteen: first pass for updating code comments to reflect WP inline docs standards, see #25257.
Built from https://develop.svn.wordpress.org/trunk@25769


git-svn-id: http://core.svn.wordpress.org/trunk@25682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-11 22:02:11 +00:00
Lance Willett
66be5edfb5 Twenty Fourteen: remove title attributes for better accessibility. Props sabreuse for original patch, see #25054.
Built from https://develop.svn.wordpress.org/trunk@25743


git-svn-id: http://core.svn.wordpress.org/trunk@25656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 19:07:09 +00:00
Lance Willett
980b81f0b1 Twenty Fourteen: first pass at improving responsive patterns and allowing for a full-width layout when no secondary sidebar is present. Props iamtakashi, see #25332.
Built from https://develop.svn.wordpress.org/trunk@25519


git-svn-id: http://core.svn.wordpress.org/trunk@25439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 18:22:09 +00:00
Lance Willett
a872d95778 Twenty Fourteen: second pass at matching code standards achieved with Twenty Thirteen development. See #24858, props obenland.
Built from https://develop.svn.wordpress.org/trunk@25023


git-svn-id: http://core.svn.wordpress.org/trunk@25014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:44 +00:00
Lance Willett
e5c55b09e9 Twenty Fourteen: first pass at matching code standards achieved with Twenty Thirteen development. See #24858, props obenland.
Built from https://develop.svn.wordpress.org/trunk@25021


git-svn-id: http://core.svn.wordpress.org/trunk@25012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-15 03:13:29 +00:00
Lance Willett
7d35419e62 Importing the Further theme, first pass at the new default theme for 2014.
A magazine theme with clean, responsive design focused on highlighting featured content prominently on home page.

This is slated for 3.8. Development will occur in trunk for the theme, and in plugins for the nice-to-have features.

Nice-to-have improvements include:

- Add a Contributors page template to highlight authors.
- Easy-to-manage featured content.
- Add support for an Authors widget to highlight authors.

Welcome, Twenty Fourteen né Further. Props iamtakashi, see #24858.


git-svn-id: http://core.svn.wordpress.org/trunk@24832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-28 22:55:10 +00:00