Commit Graph

106 Commits

Author SHA1 Message Date
Andrea Fercia
5599164cb7 Toolbar: Reset CSS properties that might be inherited from the active Theme.
The Toolbar search field, when the Toolbar is displayed on the frontend, might
inherit CSS properties from the active Theme stylesheet. For example, this
happened with Twenty Seventeen that sets `display: block;` on all the input
fields. Thus, there's the need to reset some CSS properties to avoid inheritance.

Props @sagarprajapati.
Fixes #40313.

Built from https://develop.svn.wordpress.org/trunk@40418


git-svn-id: http://core.svn.wordpress.org/trunk@40316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-04-12 16:12:43 +00:00
Andrea Fercia
710b4431dd Toolbar: remove some unnecessary CSS lines.
They were commented out in `admin-bar.css` since 3 years, see [26770].

Props kafleg, ketuchetan.

Fixes #39137.

Built from https://develop.svn.wordpress.org/trunk@39533


git-svn-id: http://core.svn.wordpress.org/trunk@39473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-07 17:45:45 +00:00
Andrea Fercia
7b3445c312 Accessibility: Revert [38984] as it needs to be better communicated to plugin authors.
See #37513.

Built from https://develop.svn.wordpress.org/trunk@39147


git-svn-id: http://core.svn.wordpress.org/trunk@39087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-11-05 16:28:33 +00:00
Andrea Fercia
7b0abd1cea Accessibility: Hide the Toolbar sub-menu icons from assistive technologies.
CSS generated content is going to be rendered for speech output more and more in
the next future. When it's not intended to be available for speech output, for
example with font icons, then special care should be used to hide it from
assistive technologies. At the moment, the only reliable way to do this is making 
use of a wrapper element and set `aria-hidden="true"` on it.

Fixes #37513.

Built from https://develop.svn.wordpress.org/trunk@38984


git-svn-id: http://core.svn.wordpress.org/trunk@38927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-27 20:53:30 +00:00
Dominik Schilling
7627255d7e Toolbar: Update links to the about page if current user can't access the dashboard of the current site.
Add missing focus styling for menu items with an icon.

Fixes #37949.
Built from https://develop.svn.wordpress.org/trunk@38660


git-svn-id: http://core.svn.wordpress.org/trunk@38603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-09-27 19:01:29 +00:00
Helen Hou-Sandí
6d28c85bc7 System fonts: Don't quote single-word font names, per our coding standards.
props ocean90, netweb.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@38152


git-svn-id: http://core.svn.wordpress.org/trunk@38093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-26 16:39:30 +00:00
Dominik Schilling
f160f2afd1 Toolbar: Allow 0 as a value for the tabindex property of a menu item.
To enhance accessibility for items without a link you can now define `tabindex="0"`, which makes descendant dropdowns accessible.

Props joedolson, afercia, ocean90.
Fixes #32495.
Built from https://develop.svn.wordpress.org/trunk@38035


git-svn-id: http://core.svn.wordpress.org/trunk@37976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-07-12 11:18:30 +00:00
Helen Hou-Sandí
8776694a33 Use numeric font weights instead of keywords.
When Open Sans was in use, the `300`, `400`, and `600` weights were loaded. `400` is the equivalent of `normal`; however, `bold` is equivalent to `700`, not `600`. With the move to system fonts, we need to be specific rather than relying on the lack of a `700` weight. Not all system fonts include a `600` weight; in those instances, they will use the `bold`/`700` weight.

The WordPress CSS Coding Standards have been updated accordingly.

props coderste.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37740


git-svn-id: http://core.svn.wordpress.org/trunk@37705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-17 18:37:28 +00:00
Helen Hou-Sandí
848501711a System font: The stack does not work with the font shorthand property.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37442


git-svn-id: http://core.svn.wordpress.org/trunk@37410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-17 01:45:27 +00:00
Helen Hou-Sandí
a726a9f51f Admin font: Remove a redundant sans-serif declaration.
props samantha-miller.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37419


git-svn-id: http://core.svn.wordpress.org/trunk@37385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-12 02:14:28 +00:00
Jeremy Felt
ced66ed4e7 Multisite: Use the admin-multisite Dashicon for sites
This icon was added to Dashicons in 4.3, but not applied to anything in our CSS.

Uses the more appropriate `dashicons-admin-multisite` when displaying the sites menu item.

Props Ipstenu, ocean90.
Fixes #36754.

Built from https://develop.svn.wordpress.org/trunk@37365


git-svn-id: http://core.svn.wordpress.org/trunk@37331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 17:13:26 +00:00
Jeremy Felt
db3d5a6bea Revert [37362], which incorrectly changed Dashicons CSS
`dashicons.css` is an external-ish library and the change there is incorrect.

See #36754.

Built from https://develop.svn.wordpress.org/trunk@37364


git-svn-id: http://core.svn.wordpress.org/trunk@37330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:29:27 +00:00
Helen Hou-Sandí
610215ceb1 Revive grunt-rtlcss, which does not appear to enjoy syntax errors.
props netweb.
see #36753, #29792.

Built from https://develop.svn.wordpress.org/trunk@37363


git-svn-id: http://core.svn.wordpress.org/trunk@37329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-05 15:22:27 +00:00
Helen Hou-Sandí
a800cf654b Drop Open Sans in the admin in favor of system fonts.
Rejoice, for your admins will feel more native to your surrounding computing environment and likely load faster, especially when offline, as they no longer have to talk to The Google Overlord.

At the time of introduction in 3.8, there were not good system fonts common to all platforms at the time. In the years since, Windows, Android, OS X, iOS, Firefox OS, and various flavors of Linux have all gotten their own (good) system UI fonts.

There will definitely be visual bugs, mainly around alignment and spacing; these should be documented and reported on the ticket and fixed more atomically so that our current and future selves have a better understanding of what happened and why.

The style remains registered, as it is almost certainly in use by themes and plugins.

props mattmiklic.
see #36753.

Built from https://develop.svn.wordpress.org/trunk@37361


git-svn-id: http://core.svn.wordpress.org/trunk@37327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-04 22:07:37 +00:00
Andrea Fercia
fcb3e5ec2f Accessibility: Improve the color contrast ratio for the input placeholders.
Also, cleans up a bit the CSS removing rules for elements that don't use
placeholders any more.

Fixes #35777.
Built from https://develop.svn.wordpress.org/trunk@36619


git-svn-id: http://core.svn.wordpress.org/trunk@36586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-22 23:29:26 +00:00
Andrea Fercia
30866ceb5d Accessibility: Improve color contrast updating any #999 gray used for text or icons to a darker gray.
Fixes #35660.
Built from https://develop.svn.wordpress.org/trunk@36587


git-svn-id: http://core.svn.wordpress.org/trunk@36554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-19 18:44:27 +00:00
Helen Hou-Sandí
28c77bec72 RIP #21759b, the old WordPress Blue.
The final lingering instances were all for hidden accessibility helper text.

fixes #34388.

Built from https://develop.svn.wordpress.org/trunk@35340


git-svn-id: http://core.svn.wordpress.org/trunk@35306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-21 18:36:28 +00:00
Andrea Fercia
579246ab4a Multisite: Improve the Admin Bar parent menu items color on hover and focus.
Props Nikschavan for the initial patch.
Fixes #34040.
Built from https://develop.svn.wordpress.org/trunk@35265


git-svn-id: http://core.svn.wordpress.org/trunk@35231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 16:22:24 +00:00
Sergey Biryukov
e19cda5c2d Toolbar: Improve padding of toolbar submenu items on small screens.
Props tillkruess.
Fixes #28608.
Built from https://develop.svn.wordpress.org/trunk@35132


git-svn-id: http://core.svn.wordpress.org/trunk@35097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 07:40:25 +00:00
Scott Taylor
596431bd21 Admin Bar: fix the alignment of secondary menu item arrows.
Props juhise.
Fixes #33836.

Built from https://develop.svn.wordpress.org/trunk@35125


git-svn-id: http://core.svn.wordpress.org/trunk@35090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-13 03:54:24 +00:00
John Blackbourn
bc6af23302 Update links to the user profile editing screen in the admin toolbar when the current logged in user has no role on the current site. Covers single site and Multisite and introduces tests.
Fixes #25162

Built from https://develop.svn.wordpress.org/trunk@34122


git-svn-id: http://core.svn.wordpress.org/trunk@34090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-14 17:10:26 +00:00
Scott Taylor
d22fbc7545 Grunt RTL CSS: swap-dashicons-left-right-arrows in rtlcss:properties expects double-quoted content strings in CSS. It doesn't swap single-quoted values.
Props Ankit K Gupta, yoavf, netweb.
Fixes #33786.

Built from https://develop.svn.wordpress.org/trunk@34011


git-svn-id: http://core.svn.wordpress.org/trunk@33980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 20:22:25 +00:00
Scott Taylor
f5c754bfed Dashicons CSS: one-word font families don't need quotes. Font families with a space in the name should use double-quotes (doesn't apply here).
Props afercia.
Fixes #32866.

Built from https://develop.svn.wordpress.org/trunk@33912


git-svn-id: http://core.svn.wordpress.org/trunk@33881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 19:57:25 +00:00
Helen Hou-Sandí
28c1600e6e Toolbar: Disambiguate links to the dashboard vs. to the customizer.
All links in the site name menu now point to admin screens, and Customize is its own top-level link. This makes it clear which context you are about to enter.

fixes #32924. see #32678.

Built from https://develop.svn.wordpress.org/trunk@33130


git-svn-id: http://core.svn.wordpress.org/trunk@33101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 20:03:24 +00:00
Helen Hou-Sandí
f85306c65a Toolbar: Allow submenus to be closed with a second tap on touch devices.
Also closes submenus when the admin menu is toggled open, as it opens below and thus can be obscured.

props stephdau, seanchayes.
see #29906.

Built from https://develop.svn.wordpress.org/trunk@33056


git-svn-id: http://core.svn.wordpress.org/trunk@33027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 03:29:25 +00:00
Dominik Schilling
5ec278f585 Toolbar: Remove a duplicate CSS selector.
props deconf.
fixes #32634.
Built from https://develop.svn.wordpress.org/trunk@32750


git-svn-id: http://core.svn.wordpress.org/trunk@32721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:54:25 +00:00
Helen Hou-Sandí
2636199e54 Toolbar: Search item consistency for focus state and IE8.
props afercia.
fixes #31322.

Built from https://develop.svn.wordpress.org/trunk@32074


git-svn-id: http://core.svn.wordpress.org/trunk@32053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-08 16:08:28 +00:00
Helen Hou-Sandí
bfda508c18 Update more instances of default admin blues and grays.
props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@32051


git-svn-id: http://core.svn.wordpress.org/trunk@32030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-05 21:20:27 +00:00
Helen Hou-Sandí
0d870b2d4e Toolbar: Protect against Firefox font rendering interference by themes.
props cbaldelomar.
fixes #30021.

Built from https://develop.svn.wordpress.org/trunk@31824


git-svn-id: http://core.svn.wordpress.org/trunk@31806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-18 22:04:27 +00:00
Helen Hou-Sandí
bcda24004a Update the default admin color scheme for more unity and refinement.
This removes the red channel from blues and cools the grays a bit for a more cohesive and purposeful color scheme.

props hugobaeta.
fixes #31234.

Built from https://develop.svn.wordpress.org/trunk@31422


git-svn-id: http://core.svn.wordpress.org/trunk@31403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-11 22:18:26 +00:00
Andrew Ozz
1e9f5755aa Admin toolbar: remove unneeded overrides of z-index and left on screens narrower than 782px. Props avryl, babbardel. Fixes #29867.
Built from https://develop.svn.wordpress.org/trunk@30764


git-svn-id: http://core.svn.wordpress.org/trunk@30754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-07 03:01:24 +00:00
Dominik Schilling
c2d9591122 Toolbar: Make Customize support classes work on narrow viewports too.
fixes #30571.
Built from https://develop.svn.wordpress.org/trunk@30713


git-svn-id: http://core.svn.wordpress.org/trunk@30703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 22:01:26 +00:00
John Blackbourn
a5fa87325b Don't fix the position of the admin toolbar submenus when the viewport is below 600px. This avoids them becoming detached from the admin toolbar when scrolling.
Fixes #29905
Props avryl

Built from https://develop.svn.wordpress.org/trunk@30706


git-svn-id: http://core.svn.wordpress.org/trunk@30696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-02 06:49:22 +00:00
Helen Hou-Sandí
06201646c3 Use a brighter blue against dark backgrounds in the admin menu and toolbar.
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.

props melchoyce. fixes #30323.

Built from https://develop.svn.wordpress.org/trunk@30313


git-svn-id: http://core.svn.wordpress.org/trunk@30312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-12 20:28:22 +00:00
Helen Hou-Sandí
2f399f18b7 Remove a toolbar CSS hack for a Chrome bug that no longer appears to exist. props avryl. fixes #28606. see #18868.
Built from https://develop.svn.wordpress.org/trunk@28981


git-svn-id: http://core.svn.wordpress.org/trunk@28770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-03 20:20:15 +00:00
Helen Hou-Sandí
3f1deae10b Don't use the box shadow focus styling for the admin menu or toolbar. see #28267.
Built from https://develop.svn.wordpress.org/trunk@28616


git-svn-id: http://core.svn.wordpress.org/trunk@28440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-29 14:23:15 +00:00
Sergey Biryukov
e269d48b99 Display Dashboard icon instead of the home icon in toolbar when the link leads to Dashboard.
props ghost1227.
fixes #26754.
Built from https://develop.svn.wordpress.org/trunk@28599


git-svn-id: http://core.svn.wordpress.org/trunk@28424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-28 13:42:14 +00:00
Andrew Nacin
11c3695c77 Dev/build tools: Use grunt-autoprefixer for CSS vendor prefixes.
We'll be using it for two distinct tasks:
 * Core CSS files will keep prefixes. `grunt autoprefixer:core` will update files directly in src/ as a pre-commit step, rather than doing it on build.
 * Color CSS files will receive prefixes when they are built.

This commit:
 * Adds prefixes we were missing to core CSS.
 * Removes prefixes that we no longer need from core CSS.
 * Removes all prefixes from colors CSS.

props ocean90.
fixes #27078.

Built from https://develop.svn.wordpress.org/trunk@27174


git-svn-id: http://core.svn.wordpress.org/trunk@27038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-13 08:30:17 +00:00
Matt Thomas
7d002a5e84 Responsive improvements to submenus in the adminbar:
- Remove .ab-sub-wrapper rules in the 782px media query, as they're duplicates of the rules set on line 161.
- Reposition the arrows for submenus at responsive sizes where the menus are taller.
- Set the submenu position to static at smartphone sizes, so it's not positioned outside of its parent (and thus offscreen).

Fixes #26720, props undergroundnetwork, iammattthomas.



Built from https://develop.svn.wordpress.org/trunk@27006


git-svn-id: http://core.svn.wordpress.org/trunk@26883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 18:38:24 +00:00
Dominik Schilling
dea41019ef Dashicons: Update to the latest dashicons files.
props empireoflight, melchoyce.
see #26518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@26925


git-svn-id: http://core.svn.wordpress.org/trunk@26806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 22:26:10 +00:00
Andrew Nacin
ee5fec7c6c Adjust widths of toolbar items at mobile sizes for better fitting on narrow screens. Fixes toolbar wrapping when using multisite.
props iammattthomas.
see #26537 for trunk.

Built from https://develop.svn.wordpress.org/trunk@26920


git-svn-id: http://core.svn.wordpress.org/trunk@26801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 21:24:12 +00:00
Andrew Ozz
448a401f77 Make older mobile browsers and IE7 usable:
- Text labels in the toolbar.
- Image icons in the visual editor.
- Some IE7 structural css fixes.
Fixes #26369.
Built from https://develop.svn.wordpress.org/trunk@26819


git-svn-id: http://core.svn.wordpress.org/trunk@26706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 02:41:10 +00:00
Andrew Nacin
1154c059ef RTL font-family overrides. (Tahoma generally, and Arial for Hebrew.)
props yoavf.
fixes #24977.

Built from https://develop.svn.wordpress.org/trunk@26816


git-svn-id: http://core.svn.wordpress.org/trunk@26703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 01:31:11 +00:00
Matt Thomas
4d48df2d58 Change the site menu icon from a globe to home, which is a better metaphor for what it does. Fixes #25971.
Built from https://develop.svn.wordpress.org/trunk@26812


git-svn-id: http://core.svn.wordpress.org/trunk@26699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:41:09 +00:00
Matt Thomas
01b1a66317 Make the padding added for top-level toolbar items in r26675 more specific and reinstate the previous 10px padding for links within dropdown menus. Fixes #26484.
Built from https://develop.svn.wordpress.org/trunk@26808


git-svn-id: http://core.svn.wordpress.org/trunk@26695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 20:44:10 +00:00
Andrew Ozz
f7c176ca46 Toolbar:
- Fix submenus in responsive mode (were ignoring the .hover class on a parent).
- Improve top level items hiding.
Fixes #26476.
Built from https://develop.svn.wordpress.org/trunk@26803


git-svn-id: http://core.svn.wordpress.org/trunk@26690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-08 17:15:11 +00:00
Matt Thomas
4d1b5e1c32 Comment out these touch-related styles as they break toolbar dropdowns in Chrome for Android. Fixes #25972.
Built from https://develop.svn.wordpress.org/trunk@26770


git-svn-id: http://core.svn.wordpress.org/trunk@26658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 04:59:13 +00:00
Matt Thomas
03ab0cc95f Provide a default generic avatar icon in the My Account menu if avatars are disabled, ensuring that the link is visible at responsive sizes. See #25858.
Built from https://develop.svn.wordpress.org/trunk@26744


git-svn-id: http://core.svn.wordpress.org/trunk@26633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 21:23:10 +00:00
Matt Thomas
c74da427f4 Add new fit-content rules to accompany intrinsic width on adminbar dropdown wrappers. Fixes #26430, props Jayjdk.
Built from https://develop.svn.wordpress.org/trunk@26735


git-svn-id: http://core.svn.wordpress.org/trunk@26624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:16:10 +00:00
Matt Thomas
c31444d1be Make toolbar dropdown submenu links tappable. See #25972, props ninnypants.
Built from https://develop.svn.wordpress.org/trunk@26716


git-svn-id: http://core.svn.wordpress.org/trunk@26605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 05:28:11 +00:00