Commit Graph

2694 Commits

Author SHA1 Message Date
Ella Iseulde Van Dorpe
fd95002b2a Editor: restructure word count
* The WordCounter should only do one thing: count words. This makes it also easier to test.
* Add some really basic unit tests.
* Instead of only refreshing the count on enter and delete, refresh the count when the user stops typing. Also look at paste and content changes in TinyMCE.
* Use `match` instead of `replace` when it is appropriate.
* More readable code.

See #30966. Fixes #26620.


Built from https://develop.svn.wordpress.org/trunk@32856


git-svn-id: http://core.svn.wordpress.org/trunk@32827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 10:35:26 +00:00
Konstantin Obenland
81df9bffc5 Use https for Google API external libraries.
Google recommends it and users are more likely to have the https version cached in their browser already.

Props rommelxcastro.
Fixes #32552.


Built from https://develop.svn.wordpress.org/trunk@32843


git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 15:51:26 +00:00
Ella Iseulde Van Dorpe
ecec2b61cf TinyMCE: wptextpattern: escape should undo
Props azaozz.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32836


git-svn-id: http://core.svn.wordpress.org/trunk@32807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 12:59:28 +00:00
Ella Iseulde Van Dorpe
8b6ff40038 TinyMCE: wptextpattern: fix issue that removes content
* If the resulting text node is empty, don't remove all the content from the paragraph.
* If there's an empty text node at the start of the paragraph, ignore it and consider the next node to be the start.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32832


git-svn-id: http://core.svn.wordpress.org/trunk@32803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:34:25 +00:00
Ella Iseulde Van Dorpe
1c586b9390 TinyMCE: show inline toolbar after scroll/resize
Also:

* Reduce the amount of callbacks.
* Move everything under `preinit` (but prepend to the callback). The API shouldn't be availbale earlier, and some UI is not available yet, neither is `editor.dom`.
* Hide the toolbar if the target is out of view.

See #32604.


Built from https://develop.svn.wordpress.org/trunk@32831


git-svn-id: http://core.svn.wordpress.org/trunk@32802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-18 11:10:25 +00:00
Ella Iseulde Van Dorpe
8fba763f37 TinyMCE: show active inline toolbar after focus
This makes sure that e.g. the image toolbar shows up again after closing the media library modal.

See #32604.

Built from https://develop.svn.wordpress.org/trunk@32818


git-svn-id: http://core.svn.wordpress.org/trunk@32789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 07:08:25 +00:00
Ella Iseulde Van Dorpe
c465640107 TinyMCE: wplink: don't link a URL with a pasted URL
Fixes #32357.


Built from https://develop.svn.wordpress.org/trunk@32817


git-svn-id: http://core.svn.wordpress.org/trunk@32788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 05:05:24 +00:00
Ella Iseulde Van Dorpe
a31d79196d TinyMCE: improve reposition method inline toolbars
* Make sure the toolbar does not overlap the target, unless it is higher than half the visible editor area's height.
* Allow the toolbar to have the preference to position itself above or below the target.
* Cache DOM lookups.
* Simplify the logic and fix various positioning issues.

See #32604.


Built from https://develop.svn.wordpress.org/trunk@32816


git-svn-id: http://core.svn.wordpress.org/trunk@32787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-17 04:42:25 +00:00
Dominik Schilling
62e3a0c15c Add menu management to the Customizer.
This brings in the Menu Customizer plugin: https://wordpress.org/plugins/menu-customizer/.

props celloexpressions, westonruter, valendesigns, voldemortensen, ocean90, adamsilverstein, kucrut, jorbin, designsimply, afercia, davidakennedy, obenland.
see #32576.
Built from https://develop.svn.wordpress.org/trunk@32806


git-svn-id: http://core.svn.wordpress.org/trunk@32777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 22:08:26 +00:00
Scott Taylor
6148f3cd41 Add a class method to wpLink, buildHtml(). This will allows devs to duck-punch the implementation.
Props martinsachse.
Fixes #32180.

Built from https://develop.svn.wordpress.org/trunk@32802


git-svn-id: http://core.svn.wordpress.org/trunk@32773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 20:20:26 +00:00
Ella Iseulde Van Dorpe
dd0bff051a TinyMCE: wptextpattern: Add blockquote and headings
As discussed in the editor meeting 9 June.
We should re-evaluate these additions towards the end of the release.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32795


git-svn-id: http://core.svn.wordpress.org/trunk@32766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-16 13:52:25 +00:00
Scott Taylor
144a28a5c2 Add an abort class method to the Promise instance returned by wp.ajax.send().
Props westonruter.
Fixes #32628.

Built from https://develop.svn.wordpress.org/trunk@32747


git-svn-id: http://core.svn.wordpress.org/trunk@32718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-13 14:30:26 +00:00
Ella Iseulde Van Dorpe
00e4f35300 TinyMCE: wpviews: cache iframe heights
Cache iframe heights per instance so it can be reused. This will prevent to content from moving in the editor when undoing or redoing changes.

Fixes #32593.

Built from https://develop.svn.wordpress.org/trunk@32711


git-svn-id: http://core.svn.wordpress.org/trunk@32681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 21:32:27 +00:00
Ella Iseulde Van Dorpe
e9ac7f5164 TinyMCE: views: fix typo in createInstance
This prevented instances from being reused.

Fixes #32591.

Built from https://develop.svn.wordpress.org/trunk@32710


git-svn-id: http://core.svn.wordpress.org/trunk@32680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 19:54:25 +00:00
Ella Iseulde Van Dorpe
c12af009c2 Editor: link modal: use link as fallback for text
If there is no link text provided, use the link as the text. This is better than silently failing.

Props bcole808.
Fixes #32323.

Built from https://develop.svn.wordpress.org/trunk@32705


git-svn-id: http://core.svn.wordpress.org/trunk@32675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 21:11:24 +00:00
Ella Iseulde Van Dorpe
d74a115e21 TinyMCE: wptextpattern: add docs
Props DrewAPicture and iseulde.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32703


git-svn-id: http://core.svn.wordpress.org/trunk@32673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 20:00:28 +00:00
Ella Iseulde Van Dorpe
6926314730 TinyMCE: wptextpattern: disable for IE 8 and lower
Props azaozz, iseulde.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32700


git-svn-id: http://core.svn.wordpress.org/trunk@32670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-06 22:38:28 +00:00
Ella Iseulde Van Dorpe
356fd0ff81 TinyMCE: add wptextpattern plugin
This plugin can automatically format text patterns as you type. It includes two patterns: unordered (`* ` and `- `) and ordered list (`1. ` and `1) `). If the transformation in unwanted, the user can undo the change by pressing backspace, using the undo shortcut, or the undo button in the toolbar.

This is the first TinyMCE plugin that has unit tests and there's some good groundwork for adding tests to existing plugins in the future.

First run. See #31441.

Built from https://develop.svn.wordpress.org/trunk@32699


git-svn-id: http://core.svn.wordpress.org/trunk@32669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-06 20:07:24 +00:00
Ella Iseulde Van Dorpe
521de0130b Browserify after [32677]
See #30949.

Built from https://develop.svn.wordpress.org/trunk@32697


git-svn-id: http://core.svn.wordpress.org/trunk@32667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-06 19:50:29 +00:00
Andrew Ozz
1c0419071f Emoji: make sure we parse only strings or DOM nodes that have children.
Props peterwilsoncc. Fixes #32300.
Built from https://develop.svn.wordpress.org/trunk@32679


git-svn-id: http://core.svn.wordpress.org/trunk@32649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 18:25:25 +00:00
Andrew Ozz
4f9682f39e TinyMCE wpView: preserve HTML wrapped in shortcodes.
Fixes #32078.
Built from https://develop.svn.wordpress.org/trunk@32678


git-svn-id: http://core.svn.wordpress.org/trunk@32648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 18:09:26 +00:00
Andrew Ozz
b3d04247b7 Editor:
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.
Built from https://develop.svn.wordpress.org/trunk@32677


git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 17:38:29 +00:00
Ella Iseulde Van Dorpe
677c3e53bb Link modal: reset search results appropriately
Reset the search results when the input field is emptied with the
browser's "clear" button inside that field.

Fixes #32174.

Built from https://develop.svn.wordpress.org/trunk@32593


git-svn-id: http://core.svn.wordpress.org/trunk@32563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:41:25 +00:00
Ella Iseulde Van Dorpe
6e0e924de9 TinyMCE: wpeditimage: trim class
Don't add extra spaces to classes. It causes some tests in the TinyMCE QUnit test suite to fail.

Fixes #31764.

Built from https://develop.svn.wordpress.org/trunk@32592


git-svn-id: http://core.svn.wordpress.org/trunk@32562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:35:28 +00:00
Scott Taylor
1c0fa5f73a In tb_show() in thickbox, when loading content into #TB_ajaxContent, make sure a URL with no ? doesn't break when &random= is appended to it.
Thickbox hasn't been updated since 2007, just FYI.

Fixes #31726.

Built from https://develop.svn.wordpress.org/trunk@32503


git-svn-id: http://core.svn.wordpress.org/trunk@32473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 21:42:24 +00:00
Scott Taylor
2f82bbb60d In views/button/select-mode-toggle, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's toggleBulkEditHandler method.
Props afercia.
Fixes #32324.

Built from https://develop.svn.wordpress.org/trunk@32502


git-svn-id: http://core.svn.wordpress.org/trunk@32472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 21:27:27 +00:00
Andrew Ozz
7ad60f3154 Emoji: do not try to replace emoji chars inside dynamic SVGs.
Fixes #32305 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32478


git-svn-id: http://core.svn.wordpress.org/trunk@32448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 23:44:27 +00:00
Scott Taylor
4af6d6f305 Media Grid: clean up our flawed Backbone.Router implementation so that the browser forward/back buttons work the same way as the left/right keys when the Edit Attachment frame is open.
Fixes #31846.

Built from https://develop.svn.wordpress.org/trunk@32466


git-svn-id: http://core.svn.wordpress.org/trunk@32436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 05:42:28 +00:00
Scott Taylor
2c42a665a2 wp.media.view.Button should create <button>s, not <a href="#">s.
Props afercia.
See #32236.

Built from https://develop.svn.wordpress.org/trunk@32464


git-svn-id: http://core.svn.wordpress.org/trunk@32434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:39:27 +00:00
Scott Taylor
a417b2cf1a In EmbedLink, a URL needs to be at least 11 chars to be useful.
Fixes #32059.

Built from https://develop.svn.wordpress.org/trunk@32463


git-svn-id: http://core.svn.wordpress.org/trunk@32433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:30:26 +00:00
Scott Taylor
b7d4685f3d When creating an EmbedLink view, don't add a spinner - it already exists in Embed.
Use the value of `wp.media.controller.Embed.sensitivity` as the sensitivity value for the debounced method in `EmbedLink` to ensure that the spinner toggles don't stutter or overlap.

Fixes #32036.

Built from https://develop.svn.wordpress.org/trunk@32462


git-svn-id: http://core.svn.wordpress.org/trunk@32432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:10:26 +00:00
Scott Taylor
af326241ff When fetching in media/views/embed/link.js, call abort() on any existing XHRs.
Use `$.ajax` instead of `wp.ajax.send()` to allow this.
Pass `this` as `context` to the options to remove the need to bind callbacks.

Fixes #32035.

Built from https://develop.svn.wordpress.org/trunk@32460


git-svn-id: http://core.svn.wordpress.org/trunk@32430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 19:16:25 +00:00
Scott Taylor
31f46f5363 In media/views/embed/link.js, URLs should have a valid protocol before an attempt to fetch them is made.
Fixes #32037.

Built from https://develop.svn.wordpress.org/trunk@32459


git-svn-id: http://core.svn.wordpress.org/trunk@32429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 18:34:28 +00:00
Andrew Ozz
3181cc27a9 TinyMCE: update to 4.1.10.
Fixes #32262.
Built from https://develop.svn.wordpress.org/trunk@32366


git-svn-id: http://core.svn.wordpress.org/trunk@32336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-06 03:23:25 +00:00
Andrew Ozz
67f589654b Emoji: add shorter/faster regex for testing for emoji chars in added nodes.
See #32125.
Built from https://develop.svn.wordpress.org/trunk@32347


git-svn-id: http://core.svn.wordpress.org/trunk@32318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-05 01:41:27 +00:00
Andrew Ozz
a5cee54aea Emoji: rename the exclude class to wp-exclude-emoji.
Props Clorith. See #32197.
Built from https://develop.svn.wordpress.org/trunk@32337


git-svn-id: http://core.svn.wordpress.org/trunk@32308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-04 00:05:28 +00:00
Andrew Ozz
8eb93bc838 Emoji: add an exclude class to wp-emoji checked when monitoring for changes with mutationObserver. Use it for the hidden div used for resizing the Text editor.
See #32197.
Built from https://develop.svn.wordpress.org/trunk@32336


git-svn-id: http://core.svn.wordpress.org/trunk@32307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 20:18:26 +00:00
Andrew Ozz
86674d41af Emoji: before parsing added nodes test if the text in them contains emoji chars. That speeds up the processing quite a bit.
See #32125.
Built from https://develop.svn.wordpress.org/trunk@32335


git-svn-id: http://core.svn.wordpress.org/trunk@32306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 19:08:24 +00:00
Andrew Ozz
4e971bea9f Emoji:
- Fix loading errors in IE9 and IE10.
- Add fallbacks for the loading events.
Fixes #32109 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32334


git-svn-id: http://core.svn.wordpress.org/trunk@32305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-03 18:45:29 +00:00
Scott Taylor
2807b7146f After [32258], restore the parts of [31620] and [31626] that weren't changes to the UI, but were improvements to existing code.
* Use `wp.shortcode()` instead of manually constructing a shortcode in `views/embed/link`
* In `WP_Embed`, store the last URL and last set of attributes requested in class properties
* `wp_ajax_parse_embed()`, allow `[embed]`s to have attributes. Return `attr` in the response.

See #31139.

Built from https://develop.svn.wordpress.org/trunk@32330


git-svn-id: http://core.svn.wordpress.org/trunk@32301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-30 21:40:25 +00:00
Andrew Ozz
01c26527ea Emoji: fix loop when replacement images fail to load.
Props iseulde. Fixes #32128 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32323


git-svn-id: http://core.svn.wordpress.org/trunk@32294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-29 03:19:26 +00:00
Andrew Nacin
b63a76fa4b Fix keyboard shortcut for save from the visual editor.
props iseulde.
see #32122, for trunk.

Built from https://develop.svn.wordpress.org/trunk@32295


git-svn-id: http://core.svn.wordpress.org/trunk@32266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-26 04:51:29 +00:00
Andrew Ozz
60706015e1 Revert editing of video embed parameters in the media modal, [31620] and [31626] for now. Plan on revisiting in 4.3.
Props iseulde. Fixes #31139, fixes #32006.
Built from https://develop.svn.wordpress.org/trunk@32258


git-svn-id: http://core.svn.wordpress.org/trunk@32229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 22:41:26 +00:00
Andrew Ozz
bafd7b98f6 TinyMCE wpView: properly deselect views when hiding the editor. Do not remove selected on PreProcess.
Fixes #32045.
Built from https://develop.svn.wordpress.org/trunk@32257


git-svn-id: http://core.svn.wordpress.org/trunk@32228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 21:32:26 +00:00
Andrew Ozz
f003efc8aa TinyMCE wpView: ensure contentNode is passed to all callbacks.
Props iseulde. Fixes #31669.
Built from https://develop.svn.wordpress.org/trunk@32255


git-svn-id: http://core.svn.wordpress.org/trunk@32226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 18:36:24 +00:00
Helen Hou-Sandí
efef6f8b79 Avoid a PHP notice when adding an embed via Insert from URL.
props iseulde.
see #32006, #29476.

Built from https://develop.svn.wordpress.org/trunk@32247


git-svn-id: http://core.svn.wordpress.org/trunk@32218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 14:36:25 +00:00
Helen Hou-Sandí
d672824273 wpLink: Make the text editor experience the same as in the visual editor.
props azaozz.
fixes #31890.

Built from https://develop.svn.wordpress.org/trunk@32242


git-svn-id: http://core.svn.wordpress.org/trunk@32213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-21 13:59:30 +00:00
Andrew Ozz
955b0bf979 TinyMCE: fix creating a preview when pasting an embeddable URL in Firefox.
Part prop iseulde. Fixes #31988.
Built from https://develop.svn.wordpress.org/trunk@32229


git-svn-id: http://core.svn.wordpress.org/trunk@32203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 20:57:28 +00:00
Helen Hou-Sandí
a581c9851a Media: Date filtering does not need to be on for all contexts.
Affected areas include customizer upload controls and video playlist editing.

props ocean90.
fixes #32004.

Built from https://develop.svn.wordpress.org/trunk@32228


git-svn-id: http://core.svn.wordpress.org/trunk@32202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 19:49:24 +00:00
Gary Pendergast
dea5545032 Update the Plupload Flash file to the latest version.
Props azaozz.


Built from https://develop.svn.wordpress.org/trunk@32168


git-svn-id: http://core.svn.wordpress.org/trunk@32143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 06:13:25 +00:00