Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-01-09 18:08:09 +01:00
Code Issues Projects Releases Wiki Activity
29,811 Commits 50 Branches 749 Tags 807 MiB
8aa163e65a
Commit Graph

3571 Commits

Author SHA1 Message Date
Dominik Schilling
1884ec383c Customizer: Restore showing a login form inside the previewer if an user is logged out. 
Broken since [31370].

props westonruter.
see #31294.
Built from https://develop.svn.wordpress.org/trunk@31421


git-svn-id: http://core.svn.wordpress.org/trunk@31402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 22:13:25 +00:00
Dominik Schilling
46f98473d1 Widgets: Add return param for widgets admin page to the "Manage in Customizer" link. 
props tywayne.
fixes #30888.
Built from https://develop.svn.wordpress.org/trunk@31420


git-svn-id: http://core.svn.wordpress.org/trunk@31401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 20:57:26 +00:00
Dominik Schilling
6adb5c0618 Customizer: Improve [31252] to show the move-widget buttons only if there is more than one *rendered* sidebar. 
fixes #30690.
Built from https://develop.svn.wordpress.org/trunk@31419


git-svn-id: http://core.svn.wordpress.org/trunk@31400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 20:45:26 +00:00
Boone Gorges
44ac816aed Split shared taxonomy terms on term update. 
When updating an existing taxonomy term that shares its `term_id` with
another term, we generate a new row in `wp_terms` and associate the updated
term_taxonomy_id with the new term. This separates the terms, such that
updating the name of one term does not change the name of any others.

In cases where a plugin or theme stores term IDs in the database, term splitting
can cause backward compatibility issues. The current changeset introduces
two utilities to aid developers with the transition. The `'split_shared_term'`
action fires when the split takes place, and should be used to catch changes in
term_id. In cases where `'split_shared_term'` cannot be used, the
`wp_get_split_term()` function gives developers access to data about terms
that have previously been split. Documentation for these functions, with
examples, can be found in the Plugin Developer Handbook. WordPress itself
stores term IDs in this way in two places; `_wp_check_split_default_terms()`
and `_wp_check_split_terms_in_menus()` are hooked to `'split_shared_term'` to
perform the necessary cleanup.

See [30241] for a previous attempt at the split. It was reverted in [30585]
for 4.1.0.

Props boonebgorges, mboynes.
See #5809.
Built from https://develop.svn.wordpress.org/trunk@31418


git-svn-id: http://core.svn.wordpress.org/trunk@31399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 19:42:25 +00:00
John Blackbourn
35f4e719b2 Introduce a logout_redirect filter so the redirect destination can be changed when a user logs out. Parameters: 
* string  $redirect_to           The redirect destination URL.
 * string  $requested_redirect_to The requested redirect destination URL passed as a parameter.
 * WP_User $user                  The WP_User object for the user that's logging out. 

Fixes #27617
Props SergeyBiryukov, johnbillion

Built from https://develop.svn.wordpress.org/trunk@31417


git-svn-id: http://core.svn.wordpress.org/trunk@31398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 19:19:26 +00:00
Scott Taylor
a7e581d991 After [31415], make sure str_replace() only occurs once for each matched tag to avoid overwriting until <pre>s. 
See #31214.

Built from https://develop.svn.wordpress.org/trunk@31416


git-svn-id: http://core.svn.wordpress.org/trunk@31397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 19:15:26 +00:00
Scott Taylor
cb3ef90d24 Protect <pre> tags when parsing oEmbed responses in WP_oEmbed::_strip_newlines() in DOMDocument is available. 
Fixes #31214.

Built from https://develop.svn.wordpress.org/trunk@31415


git-svn-id: http://core.svn.wordpress.org/trunk@31396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 19:11:27 +00:00
John Blackbourn
4d12ccadd8 Add $expiration as a parameter to the pre_set_transient_{$transient} filter. 
Props mgibbs189
Fixes #30576

Built from https://develop.svn.wordpress.org/trunk@31414


git-svn-id: http://core.svn.wordpress.org/trunk@31395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 17:12:26 +00:00
Scott Taylor
cd4fc46cf2 oEmbed discovery fails on encoded link URLs: decode HTML chars in the HTML-encoded URLs that are returned. 
Props cweiske.
Fixes #31213.

Built from https://develop.svn.wordpress.org/trunk@31413


git-svn-id: http://core.svn.wordpress.org/trunk@31394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 16:13:26 +00:00
Sergey Biryukov
7ff18dae4e Add .comment-reply-login class to get_post_reply_link(), for consistency with get_comment_reply_link(). 
props johnjamesjacoby.
fixes #31298.
Built from https://develop.svn.wordpress.org/trunk@31412


git-svn-id: http://core.svn.wordpress.org/trunk@31393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 16:11:28 +00:00
Sergey Biryukov
491ecc4c1c Use require_once() to prevent a fatal error if _wp_admin_bar_init() is called twice. 
props danielbachhuber.
fixes #31287.
Built from https://develop.svn.wordpress.org/trunk@31411


git-svn-id: http://core.svn.wordpress.org/trunk@31392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 15:59:26 +00:00
Gary Pendergast
daf711a338 Shiny Updates: Replace $.post() calls with wp.ajax.post(), and clean up a bunch of the now unnecessary code. 
See #29820


Built from https://develop.svn.wordpress.org/trunk@31409


git-svn-id: http://core.svn.wordpress.org/trunk@31390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 05:06:28 +00:00
Sergey Biryukov
97698eb127 Always pass back the custom classes get_post_class() was called with, even if the post was not found. 
props F J Kaiser, Bueltge.
fixes #22271.
Built from https://develop.svn.wordpress.org/trunk@31408


git-svn-id: http://core.svn.wordpress.org/trunk@31389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 04:00:26 +00:00
Scott Taylor
3cd585a457 oEmbed discovery fails on XHTML head links, adjust the regex to not match /. 
Props cweiske.
Fixes #31212.

Built from https://develop.svn.wordpress.org/trunk@31407


git-svn-id: http://core.svn.wordpress.org/trunk@31388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 23:37:28 +00:00
Scott Taylor
64e19e98a3 Use Math.round() instead of Math.floor() when determining page of attachments to query in wp.media.model.Query.sync. 
This was causing an infinite loop of AJAX requests - so.... good catch!

Props Veritaserum.
Fixes #31116.

Built from https://develop.svn.wordpress.org/trunk@31406


git-svn-id: http://core.svn.wordpress.org/trunk@31387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 22:54:28 +00:00
Scott Taylor
6cb16f7a21 Remove unused media JS files. 
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31405


git-svn-id: http://core.svn.wordpress.org/trunk@31386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 22:45:28 +00:00
Sergey Biryukov
0e65ae6176 Remove redundant string with a typo introduced in [25481]. 
see #31217.
Built from https://develop.svn.wordpress.org/trunk@31404


git-svn-id: http://core.svn.wordpress.org/trunk@31385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 07:53:28 +00:00
Sergey Biryukov
12f4004989 Replace generic "Dear user" greeting in email notifications with a more personalized one. 
props Ipstenu.
fixes #31217.
Built from https://develop.svn.wordpress.org/trunk@31403


git-svn-id: http://core.svn.wordpress.org/trunk@31384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 07:47:27 +00:00
Sergey Biryukov
973d157615 Switch to a string placeholder, as number_format_i18n() returns a string. 
see #26553.
Built from https://develop.svn.wordpress.org/trunk@31402


git-svn-id: http://core.svn.wordpress.org/trunk@31383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 05:45:28 +00:00
Sergey Biryukov
fdfd15aacc Use _n() in comments_popup_link() when setting the default string to display if there are more than one comment. 
see #26553.
Built from https://develop.svn.wordpress.org/trunk@31401


git-svn-id: http://core.svn.wordpress.org/trunk@31382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 02:51:28 +00:00
Sergey Biryukov
f166a51809 Update body class when switching between admin color schemes. 
props valendesigns.
fixes #30488.
Built from https://develop.svn.wordpress.org/trunk@31400


git-svn-id: http://core.svn.wordpress.org/trunk@31381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 02:23:28 +00:00
Sergey Biryukov
65e1a767c4 Set svn:eol-style for [31373]. 
see #28510.
Built from https://develop.svn.wordpress.org/trunk@31399


git-svn-id: http://core.svn.wordpress.org/trunk@31380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 02:13:28 +00:00
Scott Taylor
1235221921 Export the proper class in media/views/image-details.js 
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31393


git-svn-id: http://core.svn.wordpress.org/trunk@31374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 23:46:28 +00:00
Boone Gorges
72f18cb067 Don't parse empty 'tax_input' keys in edit_post(). 
This fixes a bug introduced in [31359] where saving a tax_input that contained
only whitespace would result in a random tag being erroneously added to the
post.

See #30615.
Built from https://develop.svn.wordpress.org/trunk@31392


git-svn-id: http://core.svn.wordpress.org/trunk@31373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 22:54:28 +00:00
Gary Pendergast
980668299c WPDB: When checking to see if we can use utf8mb4, we also need to make sure PHP's MySQL client library is capable of using utf8mb4. 
See #21212


Built from https://develop.svn.wordpress.org/trunk@31391


git-svn-id: http://core.svn.wordpress.org/trunk@31372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 22:28:28 +00:00
John Blackbourn
93fced2d15 Revert [30696] pending further investigation. 
See #31011, #13071

Built from https://develop.svn.wordpress.org/trunk@31390


git-svn-id: http://core.svn.wordpress.org/trunk@31371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 21:50:29 +00:00
Aaron Jorbin
c99149419d Add translator comments for new strings. 
These strings were added in [31388].

Props ocean90.
Fixes 26553.


Built from https://develop.svn.wordpress.org/trunk@31389


git-svn-id: http://core.svn.wordpress.org/trunk@31370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 20:15:27 +00:00
Aaron Jorbin
4f08e9d383 Use screen reader text instead of a title attribute in comments_popup_link 
To better understand screen reader text, check out https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/

Screen Reader text improves the user experience for screen reader users. It provides additional context for links, document forms and other pieces of a page that may exist visually, but are lost when looking only at the html of a site.  This does change the output of comments_popup_link if you don't pass in values for $zero, $one, $more or $none. Theme authors can and should style <code>.screen-reader-text</code> in ways that are recommended in the above article to hide it visually.

Props joedolson
Fixes #26553




Built from https://develop.svn.wordpress.org/trunk@31388


git-svn-id: http://core.svn.wordpress.org/trunk@31369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 19:27:28 +00:00
Scott Taylor
586ff8676a After [31386], this needs to happen in audio-video.manifest.js. 
See #31058.

Built from https://develop.svn.wordpress.org/trunk@31387


git-svn-id: http://core.svn.wordpress.org/trunk@31368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 18:45:26 +00:00
Scott Taylor
afa3a03ff8 Avoid an IE8 JS error when removing a MediaElement player. 
Props afercia.
Fixes #31058.

Built from https://develop.svn.wordpress.org/trunk@31386


git-svn-id: http://core.svn.wordpress.org/trunk@31367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 18:43:27 +00:00
Scott Taylor
b191013198 Media JS files: 
* In media manifests, ditch IIFEs and global injection, these get dynamically scoped via Browserify
* Remove the `debug` option from `browserify:media`
* Add `jshint:media` to `jshint:corejs`
* Add a trailing newline to all new module files

Props iseulde.
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31385


git-svn-id: http://core.svn.wordpress.org/trunk@31366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 16:01:29 +00:00
Dominik Schilling
941075c8ca Improve the Customize experience on mobile. 
Before: https://make.wordpress.org/flow/2015/02/02/a-peek-at-the-customizer-on-an-iphone-6/
After: https://make.wordpress.org/flow/2015/02/03/vizrec-for-28784-improve-the-customize-experience-on-mobile-iphone-6-28784-diff-4-2-alpha-31325/

props celloexpressions.
see #28784.
Built from https://develop.svn.wordpress.org/trunk@31384


git-svn-id: http://core.svn.wordpress.org/trunk@31365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 12:36:28 +00:00
Dion Hulse
502515974c Updates: Display plugin update rows even for plugins which are not hosted by WordPress.org or the HTTP request times out on. 
See #29583.
Fixes #30767 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31382


git-svn-id: http://core.svn.wordpress.org/trunk@31363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 06:32:26 +00:00
Drew Jaynes
947d04f323 Improve return and parameter documentation for check_admin_referer(), check_ajax_referer(), and wp_verify_nonce(). 
Also update and clarify docsfor the `check_admin_referer` and `check_ajax_referer` hooks.

Props johnbillion, DrewAPicture.
Fixes #31055.

Built from https://develop.svn.wordpress.org/trunk@31381


git-svn-id: http://core.svn.wordpress.org/trunk@31362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 04:57:27 +00:00
Scott Taylor
ef12a2cc8c Bind this at calltime instead of letting self spill down into closures. 
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31380


git-svn-id: http://core.svn.wordpress.org/trunk@31361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 04:45:28 +00:00
Scott Taylor
308ae4c887 Make sure that media/views.js doesn't load Models that already exist in media/models.js. 
See #28510.

Built from https://develop.svn.wordpress.org/trunk@31379


git-svn-id: http://core.svn.wordpress.org/trunk@31360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 04:14:26 +00:00
Gary Pendergast
04a0e21734 WPDB: The mysqli_query() call in wpdb::set_charset() had the parameters the wrong way around. 
Built from https://develop.svn.wordpress.org/trunk@31374


git-svn-id: http://core.svn.wordpress.org/trunk@31355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 01:26:29 +00:00
Scott Taylor
d568679946 Split the media JS files into modules: 
* Add a new folder in `wp-includes/js`, `media`
* Create manifest files for `views`, `models`, `grid`, and `audio-video`
* Make `browserify` an `npm` dependency
* Add Grunt tasks for `browserify` and `uglify:media` on `build` and `watch`
* Update the paths loaded for media files in `script-loader`
* All new files were created using `svn cp` from their original location

Please run `npm install`. While developing media JS, you must run `grunt watch`.

See #28510.

Built from https://develop.svn.wordpress.org/trunk@31373


git-svn-id: http://core.svn.wordpress.org/trunk@31354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 00:43:50 +00:00
Gary Pendergast
66af41688c WPDB: Some character set tests were failing if DB_CHARSET was empty, or a non-utf8 character set. 
Built from https://develop.svn.wordpress.org/trunk@31372


git-svn-id: http://core.svn.wordpress.org/trunk@31353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 00:39:22 +00:00
Gary Pendergast
55742904c0 WPDB: When we're removing invalid text text from strings with multiple different character sets, wpdb::strip_invalid_text() wasn't correctly switching connection character sets. 
Fixes #31262


Built from https://develop.svn.wordpress.org/trunk@31371


git-svn-id: http://core.svn.wordpress.org/trunk@31352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 00:34:25 +00:00
Dominik Schilling
3aea5f144b Customizer: Introduce an API to create WP_Customize_Settings for dynamically-created settings. 
* Introduce WP_Customize_Manager::add_dynamic_settings() to register dynamically-created settings.
* Introduce `customize_dynamic_setting_args` filter to pass an array of args to a dynamic setting's constructor.
* Add unit tests for WP_Customize_Manager and WP_Customize_Widgets.
* See WP_Customize_Widgets as an example.

props westonruter.
fixes #30936.
Built from https://develop.svn.wordpress.org/trunk@31370


git-svn-id: http://core.svn.wordpress.org/trunk@31351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-08 23:11:25 +00:00
Boone Gorges
17330354bc Add orderby=meta_value_num support to WP_User_Query. 
Props tyxla, genkisan.
Fixes #27887.
Built from https://develop.svn.wordpress.org/trunk@31369


git-svn-id: http://core.svn.wordpress.org/trunk@31350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-08 16:59:22 +00:00
Sergey Biryukov
623981c8d6 Use a positive wording for translations update notice. 
props DrewAPicture, siobhan, netweb.
fixes #28199.
Built from https://develop.svn.wordpress.org/trunk@31368


git-svn-id: http://core.svn.wordpress.org/trunk@31349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-08 04:09:22 +00:00
Boone Gorges
669fa39005 Late escaping in get_terms() and WP_Tax_Query. 
Props vortfu, dd32.
Built from https://develop.svn.wordpress.org/trunk@31367


git-svn-id: http://core.svn.wordpress.org/trunk@31348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-08 01:59:24 +00:00
Boone Gorges
90639872e8 In WP_Query::get_queried_object(), avoid PHP notices when is_tax is paired with an empty tax_query. 
It's possible to have an empty `tax_query` and `is_tax=true` when the initial
query contains a taxonomy var (and is processed as such during
`WP_Query::parse_query()`) but the taxonomy var is unset during a 'parse_query'
callback. While this kind of behavior is not necessarily something we need to
support, we should continue to avoid PHP notices in such cases, as we did prior
to WP 4.1.

Fixes #31246.
Built from https://develop.svn.wordpress.org/trunk@31366


git-svn-id: http://core.svn.wordpress.org/trunk@31347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-07 19:50:24 +00:00
Sergey Biryukov
09c1d34b96 Remove unnecessary array_shift() usage in get_terms() for better performance. 
props bswatson, VolodymyrC.
fixes #31182.
Built from https://develop.svn.wordpress.org/trunk@31365


git-svn-id: http://core.svn.wordpress.org/trunk@31346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-07 19:45:25 +00:00
Sergey Biryukov
137204b033 In _wp_menu_output(), $submenu_items is an array and should be initialized as such. 
props ipm-frommen.
fixes #31257.
Built from https://develop.svn.wordpress.org/trunk@31364


git-svn-id: http://core.svn.wordpress.org/trunk@31345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-07 17:57:24 +00:00
Sergey Biryukov
1e0905793c Avoid inadvertent stomping of the original $args parameter passed to plugins_api_result and themes_api_result filters in plugins_api() and themes_api(), respectively. 
Fixes a regression introduced in [25956].

props Corphi, obenland.
fixes #29079.
Built from https://develop.svn.wordpress.org/trunk@31363


git-svn-id: http://core.svn.wordpress.org/trunk@31344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-07 06:21:22 +00:00
Andrew Ozz
c8892dfaa2 TinyMCE: ensure the image toolbar stays visible when the image is much wider than the editor. Props iseulde, fixes #20696 for trunk. 
Built from https://develop.svn.wordpress.org/trunk@31362


git-svn-id: http://core.svn.wordpress.org/trunk@31343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 23:00:23 +00:00
Andrew Ozz
c765424ad5 Editor: prevent errors in editor-expand when the Text editor is not used. Props iseulde, fixes #31163. 
Built from https://develop.svn.wordpress.org/trunk@31361


git-svn-id: http://core.svn.wordpress.org/trunk@31342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 22:25:23 +00:00
Dominik Schilling
8fe95c9e65 Customizer: Add changelog entry for the 'default' parameter added in [31329]. 
props westonruter.
see #30988.
Built from https://develop.svn.wordpress.org/trunk@31360


git-svn-id: http://core.svn.wordpress.org/trunk@31341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 21:14:24 +00:00
Boone Gorges
b9e661dcae Parse non-hierarchical tag input into term IDs before sending to wp_insert_post(). 
When editing a post, non-hierarchical taxonomy terms are sent as the
comma-separated list entered into the tax_input metabox. Passing these
values directly to `wp_update_post()` meant that they were interpreted as
term slugs rather than term names, causing mismatches when a typed string
matched the slug of one term and the name of a different term. We fix the
problem by preprocessing tax_input data sent from post.php, converting it to
unambiguous term_ids before saving.

Props boonebgorges, ArminBraun.
Fixes #30615.
Built from https://develop.svn.wordpress.org/trunk@31359


git-svn-id: http://core.svn.wordpress.org/trunk@31340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 20:32:22 +00:00
Gary Pendergast
d7c6ac95bc Upgrades: wp_usermeta is a global table in multisite, so it should only be upgraded by the single site routines when we're not in a multisite install. 
See #21212


Built from https://develop.svn.wordpress.org/trunk@31358


git-svn-id: http://core.svn.wordpress.org/trunk@31339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 13:41:22 +00:00
Drew Jaynes
e5a5992e2c Update the DocBlock for wp_dropdown_categories() to reflect that the entire $args parameter array is optional instead of individual arugments. 
See #30306.

Built from https://develop.svn.wordpress.org/trunk@31357


git-svn-id: http://core.svn.wordpress.org/trunk@31338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 09:04:22 +00:00
Drew Jaynes
15eaa179df Adjust the DocBlock for wp_dropdown_pages() to mark the entire $args parameter array as optional instead of each individual argument. 
See #12494.

Built from https://develop.svn.wordpress.org/trunk@31356


git-svn-id: http://core.svn.wordpress.org/trunk@31337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 08:56:23 +00:00
Drew Jaynes
19ba9e3715 Add documentation for the $value_field argument added to wp_dropdown_pages() in [31338]. 
See #12494.

Built from https://develop.svn.wordpress.org/trunk@31355


git-svn-id: http://core.svn.wordpress.org/trunk@31336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 08:51:23 +00:00
Gary Pendergast
7444799a82 Upgrades: When upgrading a table to utf8mb4, we should run the ALTER TABLE query, even if it doesn't have any text columns. This will update the table's default character set, so that any text columns added in the future will have the expected character set. 
See #21212 


Built from https://develop.svn.wordpress.org/trunk@31354


git-svn-id: http://core.svn.wordpress.org/trunk@31335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:59:23 +00:00
Aaron Jorbin
8c362e1d8d Travis hates tabs. 
Related [31352]

see #30755

Built from https://develop.svn.wordpress.org/trunk@31353


git-svn-id: http://core.svn.wordpress.org/trunk@31334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:58:23 +00:00
Aaron Jorbin
e69b9b1dc5 Update Travis-ci Slack notification token 
see #30755


Built from https://develop.svn.wordpress.org/trunk@31352


git-svn-id: http://core.svn.wordpress.org/trunk@31333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:52:23 +00:00
Gary Pendergast
555a9f0912 Upgrades: When deciding if we can upgrade a table to utf8mb4, make sure we're checking the character set, not the collation. 
Bump the DB version as well, as the update in [31349] wouldn't have triggered for anyone who tried it.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31351


git-svn-id: http://core.svn.wordpress.org/trunk@31332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:26:21 +00:00
Aaron Jorbin
13fcbb5706 Temporarily (I hope) remove PHP 5.2 from tests being run on travis-ci 
Travis-ci has disabled PHP 5.2. This has happened before when 5.2 didn't compile and then was restored when that was fixed.

upstream: https://github.com/travis-ci/travis-ci/issues/3152
related: https://github.com/WP-API/WP-API/issues/846

See #31244.


Built from https://develop.svn.wordpress.org/trunk@31350


git-svn-id: http://core.svn.wordpress.org/trunk@31331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:14:21 +00:00
Gary Pendergast
b2cf823105 WPDB: If a site is using the utf8 charset, and their version of MySQL supports utf8mb4, auto-upgrade them to utf8mb4. 
This patch also resizes some indexes, to allow for the 767 byte index size limit in standard MySQL installs.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31349


git-svn-id: http://core.svn.wordpress.org/trunk@31330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 04:51:22 +00:00
Andrew Nacin
fd70baf919 Remove leading space from the definition of a global cache group. 
This only applied in a rare situation during the switch_to_blog() process where no global groups were currently defined.

see #31243.

Built from https://develop.svn.wordpress.org/trunk@31348


git-svn-id: http://core.svn.wordpress.org/trunk@31329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 03:26:22 +00:00
Andrew Nacin
116d1d354e Add useremail and userslugs as global cache groups. fixes #31243. 
Built from https://develop.svn.wordpress.org/trunk@31347


git-svn-id: http://core.svn.wordpress.org/trunk@31328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 03:24:23 +00:00
Boone Gorges
7560f446f9 Use field-specific sanitization in WP_Tax_Query::transform_query(). 
When terms are entered into the database, term fields are sanitized with
`sanitize_term_field()`. To ensure that the `SELECT ... WHERE` queries in
`WP_Tax_Query::transform_query()` are not broken by overzealous sanitization,
`sanitize_term_field()` should be used in that case as well. This fixes a bug
where a tax_query using 'field=name' would fail if the 'terms' parameter
contained characters (like spaces) that were improperly removed by
`sanitize_title_for_query()`.

Fixes #27810.
Built from https://develop.svn.wordpress.org/trunk@31346


git-svn-id: http://core.svn.wordpress.org/trunk@31327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 02:02:23 +00:00
Gary Pendergast
5e4d135411 Shiny Updates: Fix a PHP warning when installing new plugins. 
Props lgladdy for the initial patch.

See #29820


Built from https://develop.svn.wordpress.org/trunk@31345


git-svn-id: http://core.svn.wordpress.org/trunk@31326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 00:34:21 +00:00
Boone Gorges
4169032f6f Use minified jquery-ui-core file during qunit:compiled Grunt task. 
[30989] made jQuery UI Core a dependency for QUnit tests. This change did not
account for the fact that jQuery JS assets are minimized (and non-minimized
versions unavailable) when `grunt copy` populates the `/build` directory. To
ensure that QUnit tests pass when run during `grunt qunit:compiled`, we
manually fix the asset path to read 'core.min.js'.

See #25781.
Built from https://develop.svn.wordpress.org/trunk@31344


git-svn-id: http://core.svn.wordpress.org/trunk@31325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 20:36:22 +00:00
Helen Hou-Sandí
fa053ea65b MCE views: Always refresh the view after updating a gallery. 
This allows things like caption changes to be synced, as they are tied to the attachment and not the shortcode.

props iseulde.
fixes #31239.

Built from https://develop.svn.wordpress.org/trunk@31343


git-svn-id: http://core.svn.wordpress.org/trunk@31324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 20:12:22 +00:00
Boone Gorges
6c45fe1cac Another array syntax fix for Customizer tests. 
See [31339], #30988.
Built from https://develop.svn.wordpress.org/trunk@31342


git-svn-id: http://core.svn.wordpress.org/trunk@31323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 19:55:23 +00:00
Boone Gorges
69504de9d8 jshint fixes for shiny updates JS. 
As introduced in [31333].

Props iseulde.
See #29820.
Built from https://develop.svn.wordpress.org/trunk@31341


git-svn-id: http://core.svn.wordpress.org/trunk@31322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 19:52:22 +00:00
Boone Gorges
7bde88d02e Modify `meta_query orderby syntax to use array keys as clause "handles". 
The implementation of `meta_query` orderby introduced in [31312] put clause
identifiers into a 'name' parameter of the clause. For greater clarity, this
changeset updates the syntax to use the associative array key used when
defining `meta_query` parameters, instead of the 'name' parameter.

Props Funkatronic, DrewAPicture.
Fixes #31045.
Built from https://develop.svn.wordpress.org/trunk@31340


git-svn-id: http://core.svn.wordpress.org/trunk@31321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 19:38:23 +00:00
Boone Gorges
a8f8813e83 Use temporary variable for array in Tests_Customize_Setting::test_preview_standard_types_multidimensional(). 
The syntax previously used - `call_user_func( 'foo' )['bar']`, where `foo()`
returns an array - is not valid on all supported versions of PHP, and was
breaking the CI builds.

See #30988.
Built from https://develop.svn.wordpress.org/trunk@31339


git-svn-id: http://core.svn.wordpress.org/trunk@31320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 19:19:23 +00:00
Boone Gorges
14767d6c69 Introduce 'value_field' parameter to wp_dropdown_pages(). 
This parameter allows developers to choose the post field that will be used to
fill in the 'option' attribute of the generated dropdown markup.

See [31006] #30306 for a parallel enhancement in `wp_dropdown_categories()`.

Props jfarthing84.
Fixes #12494.
Built from https://develop.svn.wordpress.org/trunk@31338


git-svn-id: http://core.svn.wordpress.org/trunk@31319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 19:04:23 +00:00
Boone Gorges
d1764d86e4 Use hash notation for wp_dropdown_pages() argument documentation. 
Built from https://develop.svn.wordpress.org/trunk@31337


git-svn-id: http://core.svn.wordpress.org/trunk@31318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 19:00:25 +00:00
Drew Jaynes
10eb2173c0 Clarify inline documentation for WP_Date_Query to better explain the relationship between an individual clause's 'compare' argument and various integer-based date arguments. 
If the 'compare' argument equals 'IN' or 'NOT IN', arrays of any number of specific, valid values are accepted and simply considered based on the value of 'operator' (OR or AND). If the 'compare' argument is a range such as 'BETWEEN' or 'NOT BETWEEN', arrays of only two valid values are accepted.
 
Props boonebgorges.
Fixes #31036.

Built from https://develop.svn.wordpress.org/trunk@31336


git-svn-id: http://core.svn.wordpress.org/trunk@31317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 06:17:21 +00:00
Gary Pendergast
27aa3e92d7 Shiny Updates: If the current user is not allowed to install/update plugins, we should return a JSON error, so it can be used by the JS handlers. 
See #29820


Built from https://develop.svn.wordpress.org/trunk@31335


git-svn-id: http://core.svn.wordpress.org/trunk@31316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 06:16:23 +00:00
Gary Pendergast
b7926a518a Shiny Updates: Add capability checks to the ajax callbacks, to ensure the current user is allowed to install/update plugins. 
See #29820


Built from https://develop.svn.wordpress.org/trunk@31334


git-svn-id: http://core.svn.wordpress.org/trunk@31315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 06:05:22 +00:00
Gary Pendergast
9c69213f2b Shiny Updates: Add ajax-y updates to the plugin list page, and ajax-y updates and installs to the plugin card page. 
This also includes JS architecture that can be expanded to support theme, core and language pack updates.

Props pento, ericlewis, lgladdy, adamsilverstein, DrewAPicture

See #29820


Built from https://develop.svn.wordpress.org/trunk@31333


git-svn-id: http://core.svn.wordpress.org/trunk@31314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-05 04:19:23 +00:00
Andrew Ozz
f13cb317a4 Fix displaying long tag names in the Tags postbox. Props trishasalas, carolinegeven, iseulde. Fixes #18946. 
Built from https://develop.svn.wordpress.org/trunk@31332


git-svn-id: http://core.svn.wordpress.org/trunk@31313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-04 22:15:25 +00:00
Helen Hou-Sandí
62e65c3a35 Accessibility: remove remaining instances of accesskey. 
It is a poorly implemented browser feature, not particularly discoverable, and causes more problems than it helps solve.

props afercia.
fixes #29715.

Built from https://develop.svn.wordpress.org/trunk@31331


git-svn-id: http://core.svn.wordpress.org/trunk@31312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-04 03:46:24 +00:00
Helen Hou-Sandí
641f767fd9 Themes: Allow version number in the overlay to be selected. 
props johneckman.
fixes #31205.

Built from https://develop.svn.wordpress.org/trunk@31330


git-svn-id: http://core.svn.wordpress.org/trunk@31311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 15:15:25 +00:00
Dominik Schilling
9d162f0945 Ensure that WP_Customize_Setting::value() returns default value for setting if not dirty. 
There was regression introduced by #28580 where only changed (dirty) settings now are POST'ed to the Customizer preview.

* Allow WP_Customize_Manager::post_value() to accept a second $default argument.
* Introduce WP_Customize_Manager::unsanitized_post_values() for accessing previously-private member variable _post_values.
* Do require_once instead of require for Customizer classes.
* Add unit tests for WP_Customize_Manager and WP_Customize_Setting.

props westonruter.
fixes #30988.
Built from https://develop.svn.wordpress.org/trunk@31329


git-svn-id: http://core.svn.wordpress.org/trunk@31310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 10:15:21 +00:00
Dion Hulse
121f83ab39 Remove an extra indent from most of media-new.php. 
Built from https://develop.svn.wordpress.org/trunk@31328


git-svn-id: http://core.svn.wordpress.org/trunk@31309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 07:47:22 +00:00
Dion Hulse
e8f032c747 WP_Upgrader: Remove references to non-existant variables that have never existed. 
Props jdgrimes. Fixes  #29087

Built from https://develop.svn.wordpress.org/trunk@31327


git-svn-id: http://core.svn.wordpress.org/trunk@31308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 06:18:24 +00:00
Dion Hulse
92cb5936f1 Remove an unused parameter on install_plugins_upload(). 
Props michalzuber. Fixes #28964

Built from https://develop.svn.wordpress.org/trunk@31326


git-svn-id: http://core.svn.wordpress.org/trunk@31307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 06:14:22 +00:00
Sergey Biryukov
7690d9b1aa Add 'widget_nav_menu_args' filter for Custom Menu widget arguments. 
props cyman, DrewAPicture.
fixes #29463.
Built from https://develop.svn.wordpress.org/trunk@31325


git-svn-id: http://core.svn.wordpress.org/trunk@31306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 02:56:23 +00:00
Sergey Biryukov
7c97e59ed6 When using WP_Query's 'fields' => 'ids' (or 'fields' => 'id=>parent'), make sure the returned result is always an array of integers. 
fixes #31194. see #27252.
Built from https://develop.svn.wordpress.org/trunk@31324


git-svn-id: http://core.svn.wordpress.org/trunk@31305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-03 02:29:25 +00:00
Boone Gorges
eec82f9330 In get_sample_permalink(), override 'future' status before generating permalink. 
In [31114], `get_permalink()` was modified to prevent pretty permalinks from
being generated for posts with the 'future' post status. This inadvertently
broke the pretty permalink preview for scheduled posts. The fix is to include
the 'future' status in the list of statuses that `get_sample_permalink()` fakes
as 'publish' before it fetches a permalink.

Props DrewAPicture.
Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@31323


git-svn-id: http://core.svn.wordpress.org/trunk@31304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-02 16:50:22 +00:00
Dominik Schilling
628cec4f1a jQuery UI: Add jquery-ui-core as dependency for jquery-ui-progressbar. 
props tyxla.
fixes #31208.
Built from https://develop.svn.wordpress.org/trunk@31322


git-svn-id: http://core.svn.wordpress.org/trunk@31303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-02 10:34:23 +00:00
Boone Gorges
55dafd966b When querying for a specific post, allow posts with a non-public status to be returned as long as that status is specified. 
This makes it possible to, for example, retrieve a specific post using the
`p` parameter of `WP_Query`, even if the post is in the Trash, by including
the `post_status=trash` parameter.

Props ebinnion.
Fixes #29167.
Built from https://develop.svn.wordpress.org/trunk@31321


git-svn-id: http://core.svn.wordpress.org/trunk@31302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-01 20:26:25 +00:00
Sergey Biryukov
a82763b7b6 Menus: Don't display "Move" text without direction if there is only one menu item. 
props kucrut for initial patch.
fixes #30765.
Built from https://develop.svn.wordpress.org/trunk@31320


git-svn-id: http://core.svn.wordpress.org/trunk@31301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-01 05:29:26 +00:00
Dominik Schilling
5bc0c84c35 i18n tools: Sync makepot.php with i18n.svn. 
fixes #31193.
Built from https://develop.svn.wordpress.org/trunk@31319


git-svn-id: http://core.svn.wordpress.org/trunk@31300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 22:02:23 +00:00
Sergey Biryukov
f824de609d Reduce the size of the WordPress logo tap target on log in screen on mobile, to avoid unexpected redirect away from the form. 
props mzak.
fixes #31185.
Built from https://develop.svn.wordpress.org/trunk@31318


git-svn-id: http://core.svn.wordpress.org/trunk@31299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 21:32:22 +00:00
Andrew Ozz
0a668f1586 Separate the tests for IE conditional comments support in WP_Scripts. Props valendesigns, see 16024. 
Built from https://develop.svn.wordpress.org/trunk@31317


git-svn-id: http://core.svn.wordpress.org/trunk@31298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 20:41:22 +00:00
Sergey Biryukov
7d99c51b3b Themes: Remove a Chrome workaround that causes theme screenshots to look too crisp and no longer appears to be relevant. 
props mzak.
fixes #26584.
Built from https://develop.svn.wordpress.org/trunk@31316


git-svn-id: http://core.svn.wordpress.org/trunk@31297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 20:39:25 +00:00
Dominik Schilling
9d227201eb i18n tools: Exclude wp-includes/class-pop3.php in wp_frontend(). 
The external library uses the underscore alias for the native gettext() function. Makepot extracts these strings too, which results in having 25 unused translations.

fixes #31179.
Built from https://develop.svn.wordpress.org/trunk@31315


git-svn-id: http://core.svn.wordpress.org/trunk@31296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 20:28:23 +00:00
Dominik Schilling
befce33421 i18n tools: Tabs, not spaces for indentation. 
Built from https://develop.svn.wordpress.org/trunk@31314


git-svn-id: http://core.svn.wordpress.org/trunk@31295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 19:52:23 +00:00
Boone Gorges
f345a72c58 Prevent terms in a show_in_quick_edit=false taxonomy from being updated by a faked AJAX request. 
The UI for these taxonomies was hidden in [31308], but it remained possible to
send a direct POST request to the `inline-edit` endpoint to bypass the
restriction. The current changeset fixes this.

Props meloniq.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31313


git-svn-id: http://core.svn.wordpress.org/trunk@31294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 19:38:24 +00:00
Boone Gorges
ca30c725a0 Improve support for ordering WP_Query results by postmeta. 
`WP_Meta_Query` clauses now support a 'name' parameter. When building a
`WP_Query` object, the value of 'orderby' can reference this 'name', so that
it's possible to order by any clause in a meta_query, not just the first one
(as when using 'orderby=meta_value'). This improvement also makes it possible
to order by multiple meta query clauses (or by any other eligible field plus
a meta query clause), using the array syntax for 'orderby' introduced in [29027].

Props Funkatronic, boonebgorges.
Fixes #31045.
Built from https://develop.svn.wordpress.org/trunk@31312


git-svn-id: http://core.svn.wordpress.org/trunk@31293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 15:48:24 +00:00
Sergey Biryukov
3c416b8c87 Remove redundant parameter. 
see #30753.
Built from https://develop.svn.wordpress.org/trunk@31311


git-svn-id: http://core.svn.wordpress.org/trunk@31292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 02:12:22 +00:00
Sergey Biryukov
c17737b7ac Add a unit test that expects wp_parse_args() to treat 'true' and 'false' in a query string as strings. 
props voldemortensen for initial patch.
see #30753.
Built from https://develop.svn.wordpress.org/trunk@31310


git-svn-id: http://core.svn.wordpress.org/trunk@31291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 02:02:23 +00:00
Drew Jaynes
ac4aae99e6 Add changelog entries to the post_gallery and post_playlist hook docs for the $instance variable that was added in [31304]. 
Props ninnypants for the initial patch.
Fixes #31151.

Built from https://develop.svn.wordpress.org/trunk@31309


git-svn-id: http://core.svn.wordpress.org/trunk@31290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-31 00:33:22 +00:00
Boone Gorges
e4f8d5e0bc Fix 'quick_edit_show_taxonomy' filter so that can properly be used for overrides in all cases. 
See #26948.
Built from https://develop.svn.wordpress.org/trunk@31308


git-svn-id: http://core.svn.wordpress.org/trunk@31289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 19:29:22 +00:00
Boone Gorges
abce542e5f Introduce 'show_in_quick_edit' parameter for register_taxonomy(). 
Setting 'show_in_quick_edit' to false when registering a custom taxonomy will
hide the taxonomy when editing posts using Quick Edit.

The new 'quick_edit_show_taxonomy' filter allows this behavior to be filtered
on a finer scale, as when you want a given taxonomy to be hidden for one post
type but not for others.

Props hlashbrooke.
Fixes #26948.
Built from https://develop.svn.wordpress.org/trunk@31307


git-svn-id: http://core.svn.wordpress.org/trunk@31288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 19:18:23 +00:00
Boone Gorges
9b0ee1c6f5 Introduce setExpectedDeprecated() and setExpectedIncorrectUsage() methods to `WP_UnitTestCase. 
These methods provide a procedural alternative to the `@expectedDeprecated`
and `@expectedIncorrectUsage` test annotations, and parallel PHPUnit's native
`setExpectedException()`.

Props prasoon2211, jdgrimes.
Fixes #28486.
Built from https://develop.svn.wordpress.org/trunk@31306


git-svn-id: http://core.svn.wordpress.org/trunk@31287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 16:48:23 +00:00
Sergey Biryukov
5289e92ef5 Rename $instances to $instance in wp_audio_shortcode() and wp_video_shortcode() for consistency with gallery_shortcode() and wp_playlist_shortcode(). 
see #31151.
Built from https://develop.svn.wordpress.org/trunk@31305


git-svn-id: http://core.svn.wordpress.org/trunk@31286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 16:06:22 +00:00
Sergey Biryukov
fa86f3ef9c Pass the current shortcode instance ID to post_gallery and post_playlist filters. 
props justincwatt.
fixes #31151.
Built from https://develop.svn.wordpress.org/trunk@31304


git-svn-id: http://core.svn.wordpress.org/trunk@31285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 16:02:21 +00:00
Sergey Biryukov
b05014805f Don't display the Help tab reference in Page Attributes meta box if Help tab was removed. 
props bananastalktome.
fixes #31164.
Built from https://develop.svn.wordpress.org/trunk@31303


git-svn-id: http://core.svn.wordpress.org/trunk@31284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 15:34:24 +00:00
Boone Gorges
eddf93639b In get_adjacent_post(), return private post if the current user has the capacity to read it. 
This mirrors the check that happens post-query in `WP_Query`. See #30911.

Props bswatson.
Fixes #30287.
Built from https://develop.svn.wordpress.org/trunk@31302


git-svn-id: http://core.svn.wordpress.org/trunk@31283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 02:20:23 +00:00
Boone Gorges
1f51936d8c Add unit tests for 'show_option_all' behavior of wp_list_categories(). 
See #21881.
Built from https://develop.svn.wordpress.org/trunk@31301


git-svn-id: http://core.svn.wordpress.org/trunk@31282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-30 01:40:23 +00:00
Sergey Biryukov
5ac0568ee3 Switch to a 403 response code in places where it is more appropriate than a 500 due to permissions errors. 
props tomdxw.
fixes #30927.
Built from https://develop.svn.wordpress.org/trunk@31300


git-svn-id: http://core.svn.wordpress.org/trunk@31281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 21:15:22 +00:00
Boone Gorges
cf68b77790 Add tests for get_category_parents(). 
See #30415.
Built from https://develop.svn.wordpress.org/trunk@31299


git-svn-id: http://core.svn.wordpress.org/trunk@31280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 20:49:26 +00:00
Dominik Schilling
72229b25c8 Add New User: Remove trailing whitespace from button labels. 
fixes #31175.
Built from https://develop.svn.wordpress.org/trunk@31298


git-svn-id: http://core.svn.wordpress.org/trunk@31279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 14:54:21 +00:00
Drew Jaynes
de1f0a0487 Avoid confusion by clarifying an inline comment on logic for performing multisite upgrades. 
Props dmchale for the initial patch.
Fixes #30837.

Built from https://develop.svn.wordpress.org/trunk@31297


git-svn-id: http://core.svn.wordpress.org/trunk@31278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:53:21 +00:00
Drew Jaynes
9a17233ca1 Fix an inaccurate summary and description in the DocBlock for wpmu_validate_user_signup(). 
Props ericlewis.
Fixes #31141.

Built from https://develop.svn.wordpress.org/trunk@31296


git-svn-id: http://core.svn.wordpress.org/trunk@31277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:46:22 +00:00
Drew Jaynes
db993f6598 Add a missing description for the $_diff_threshold property in the WP_Text_Diff_Renderer_Table class. 
Props ipm-frommen.
Fixes #31008.

Built from https://develop.svn.wordpress.org/trunk@31295


git-svn-id: http://core.svn.wordpress.org/trunk@31276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:36:22 +00:00
Drew Jaynes
d7a51b3fc2 Add missing descriptions to the $blogid and $siteid property DocBlocks in the wpdb class. 
Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31294


git-svn-id: http://core.svn.wordpress.org/trunk@31275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:35:22 +00:00
Drew Jaynes
0f20ecca9c Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/taxonomy.php. 
Also adds a few missing parameter descriptions.

Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31293


git-svn-id: http://core.svn.wordpress.org/trunk@31274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:34:22 +00:00
Drew Jaynes
f3033f34c6 Add missing descriptions to the DocBlocks for various functions in wp-admin/includes/post.php 
Props ipm-frommen.
See #31008.

Built from https://develop.svn.wordpress.org/trunk@31292


git-svn-id: http://core.svn.wordpress.org/trunk@31273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 11:32:22 +00:00
Andrew Nacin
994b57a190 Update readme recommendations. fixes #31173. 
Built from https://develop.svn.wordpress.org/trunk@31291


git-svn-id: http://core.svn.wordpress.org/trunk@31272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 05:10:22 +00:00
Dion Hulse
65e7885c01 HTTP API: Fix an issue where the limit_response_size parameter wasn't working properly with large documents and the cURL transport. 
Fixes #31172

Built from https://develop.svn.wordpress.org/trunk@31290


git-svn-id: http://core.svn.wordpress.org/trunk@31271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 03:58:23 +00:00
Boone Gorges
78e5576ed8 Add basic unit tests for get_page_of_comment(). 
See #11334.
Props jeremyfelt.
Built from https://develop.svn.wordpress.org/trunk@31289


git-svn-id: http://core.svn.wordpress.org/trunk@31270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 02:31:22 +00:00
Boone Gorges
8627216105 When updating the name a hierarchical term with Quick Edit, update the corresponding option in the Parent dropdown. 
Props garyc40, rmarks.
Fixes #14565.
Built from https://develop.svn.wordpress.org/trunk@31288


git-svn-id: http://core.svn.wordpress.org/trunk@31269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-29 01:53:22 +00:00
Boone Gorges
dcca015ffc Don't use term IDs for array indexes when caching object terms. 
Uncached results pulled from `wp_get_object_terms()` are zero-indexed (ie 0,
1, 2...). As a result, `get_the_terms()` was returning a strictly different
array when pulling from the cache and when the cache was empty.

Props joshlevinson.
Fixes #31086.
Built from https://develop.svn.wordpress.org/trunk@31287


git-svn-id: http://core.svn.wordpress.org/trunk@31268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-28 20:43:23 +00:00
Boone Gorges
67d36f845d Improve organiation of tax_query and meta_query unit tests. 
`meta_query` tests have been moved to `tests/phpunit/tests/query/metaQuery.php` and `tax_query` tests to `tests/phpunit/tests/query/taxQuery.php`. This is an improvement because (a) it better corresponds to the way that other `WP_Query` parameter tests are organized, (b) splitting meta and tax tests into separate classes simplifies the required `@group` annotations, and (c) the tests have nothing to do with posts per se, and so do not belong in the `post` subdirectory.

The tests previously found at `tests/phpunit/tests/query/taxQuery.php` have been moved to `isTerm.php` in the same directory. These tests are related to the `is_*` functions that have to do with taxonomy terms, like `is_category()`.

See #26999.
Built from https://develop.svn.wordpress.org/trunk@31286


git-svn-id: http://core.svn.wordpress.org/trunk@31267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-27 20:04:23 +00:00
Boone Gorges
e199d2420f Ensure that 'hierarchical' is respected in get_terms() when multiple taxonomies are passed. 
Previously, attempts to descend the family tree of each term were done using
the first taxonomy in the `$taxonomies` array, with the result that terms not
belonging to that taxonomy were not found and their children not properly
parsed. We fix this bug by fetching each term's taxonomy with the SQL query,
and then using that taxonomy to get the correct children for each term.

Fixes #31118.
Built from https://develop.svn.wordpress.org/trunk@31285


git-svn-id: http://core.svn.wordpress.org/trunk@31266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-26 19:04:21 +00:00
Boone Gorges
af6e0f5c55 Ensure that 'pad_counts' is not discarded when the first of multiple taxonomies passed to get_terms() is non-hierarchical. 
See #31118.
Built from https://develop.svn.wordpress.org/trunk@31284


git-svn-id: http://core.svn.wordpress.org/trunk@31265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-26 18:09:22 +00:00
Lance Willett
cfba917080 Twenty Fifteen: move RSS icon style rule lower to prevent it from being overridden by other social icon rules. 
Props iamtakashi, fixes #31129.

Built from https://develop.svn.wordpress.org/trunk@31283


git-svn-id: http://core.svn.wordpress.org/trunk@31264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-26 15:58:23 +00:00
Sergey Biryukov
5aadff88f6 Remove duplicate label on installation screen. 
props Ankit K Gupta.
fixes #31131.
Built from https://develop.svn.wordpress.org/trunk@31282


git-svn-id: http://core.svn.wordpress.org/trunk@31263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-25 19:39:23 +00:00
Sergey Biryukov
98da858b40 Revert [30027]. These fields are already sufficiently labeled; duplicate labels can lead to confused behavior for screen readers. 
see #31117, #30101.
Built from https://develop.svn.wordpress.org/trunk@31281


git-svn-id: http://core.svn.wordpress.org/trunk@31262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-25 18:33:22 +00:00
Boone Gorges
5bfab3becd Do not run certain cache-hit tests on multisite. 
These tests fail on multisite if run after a test that creates
`wpmu_create_blog()`, because `wpmu_create_blog()` defines `WP_INSTALLING`,
which results in unexpected cache misses. See [28965] for a similar fix.
Built from https://develop.svn.wordpress.org/trunk@31280


git-svn-id: http://core.svn.wordpress.org/trunk@31261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-25 12:59:23 +00:00
Sergey Biryukov
53a704a67a Fix a typo in [30138]. 
see #30224.
Built from https://develop.svn.wordpress.org/trunk@31279


git-svn-id: http://core.svn.wordpress.org/trunk@31260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-25 09:48:21 +00:00
Andrew Nacin
1b8f71041b Allow $autoload in add_option() to receive false. 
props dllh.
fixes #31119.

Built from https://develop.svn.wordpress.org/trunk@31278


git-svn-id: http://core.svn.wordpress.org/trunk@31259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-25 07:51:23 +00:00
Boone Gorges
4b8277237f In Tests_Ajax_ReplytoComment::test_blocked_comment(), don't stop blocking comments until test is complete. 
The test uses the `_block_comments()` method to prevent comment inserts from
happening. Since [31263], failed comment inserts lead to the comment content's
being stripped of invalid characters and inserted again. By immediately
unhooking itself after first being run, `_block_comments()` was causing the
INSERT block to work only for the first attempt, while the second attempt was
going through, causing the test to fail. As a fix, we move the
`remove_filter()` call to the class's `tearDown()` method - sufficient for
cleanup, but late enough that *all* comment inserts will be blocked for the
test method in question.

See #21212.
Since [31263], comment INSERT queries that were pseudo-bl
Built from https://develop.svn.wordpress.org/trunk@31277


git-svn-id: http://core.svn.wordpress.org/trunk@31258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-25 03:39:24 +00:00
Boone Gorges
acef0e2dcc In get_terms(), check hierarchy for all $taxonomies before bailing early from 'parent' or 'child_of'. 
There is a pre-check in `get_terms()` that prevents an unnecessary database
query if the 'parent' or 'child_of' parameter is not found in the cached term
hierarchy (since a term without an index in the hierarchy cache has no
descendants). Previously, only the first item in the `$taxonomies` array was
being checked, with the result that an empty array was being erroneously
returned in cases where the 'parent' or 'child_of' term is in a subsequent
taxonomy.

See #31118.
Built from https://develop.svn.wordpress.org/trunk@31276


git-svn-id: http://core.svn.wordpress.org/trunk@31257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-25 02:46:25 +00:00
Boone Gorges
43fceb39c0 Introduce 'childless' parameter to get_terms(). 
This new parameter allows developers to limit queried terms to terminal nodes -
ie, those without any descendants.

As part of the improvement, some internal logic in `get_terms()` has been
consolidated. Parameters that resolve to a NOT IN clause containing term IDs
('exclude', 'exclude_tree', and 'childless') are now parsed into a single
"exclusions" array before the SQL clause is generated.

Props theMikeD, horike.
Fixes #29839.
Built from https://develop.svn.wordpress.org/trunk@31275


git-svn-id: http://core.svn.wordpress.org/trunk@31256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-24 18:48:23 +00:00
Sergey Biryukov
15fc97b1cf Quick Edit: Don't save the post if Enter is pressed on the Cancel link. 
props afercia.
fixes #30345.
Built from https://develop.svn.wordpress.org/trunk@31274


git-svn-id: http://core.svn.wordpress.org/trunk@31255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-24 15:07:22 +00:00
Dominik Schilling
ee417ec560 jQuery UI: Add missing dependencies for puff and scale effects. 
see #31113.
Built from https://develop.svn.wordpress.org/trunk@31273


git-svn-id: http://core.svn.wordpress.org/trunk@31254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-23 22:39:23 +00:00
Aaron Jorbin
a4a1273d3a Improve accessibility of nav menu locations form. 
A couple of small tweaks to the nav menu locations form that make it friendlier to assistive technology.  These include:
 * labels for selects
 * better context for the "Edit" link.  We hide "edit" from screen readers and instead give them a phrase with context since they may not be able to take advantage of the visual context

Additionally, there are some minor css tweaks to improve the visual alignment of the rows.
We also remove duplicate IDs and use classes instead.

Props afercia.
fixes #31090.


Built from https://develop.svn.wordpress.org/trunk@31272


git-svn-id: http://core.svn.wordpress.org/trunk@31253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-23 18:18:26 +00:00
Boone Gorges
04216633b2 Add classes for custom taxonomy terms in get_post_class(). 
Props sillybean.
Fixes #16223.
Built from https://develop.svn.wordpress.org/trunk@31271


git-svn-id: http://core.svn.wordpress.org/trunk@31252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-23 15:41:22 +00:00
Boone Gorges
d45a650846 Introduce 'parent' parameter to wp_get_object_terms(). 
Props mikeschinkel.
Fixes #15675.
Built from https://develop.svn.wordpress.org/trunk@31270


git-svn-id: http://core.svn.wordpress.org/trunk@31251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-23 14:57:22 +00:00
Sergey Biryukov
a47a5a1779 In wp_update_user(), make sure $userdata['ID'] is set before using it. 
props tyxla.
fixes #31097.
Built from https://develop.svn.wordpress.org/trunk@31269


git-svn-id: http://core.svn.wordpress.org/trunk@31250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-22 14:46:23 +00:00
Lance Willett
3982471a5c Twenty Eleven and Twelve: fill in support for screen-reader-text class. 
Props obenland, fixes #31095.
Built from https://develop.svn.wordpress.org/trunk@31268


git-svn-id: http://core.svn.wordpress.org/trunk@31249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-22 00:56:22 +00:00
Lance Willett
87279ec9ea Twenty Eleven: fix indentation (spaces to tabs). See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31267


git-svn-id: http://core.svn.wordpress.org/trunk@31248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-22 00:44:22 +00:00
Lance Willett
ff5628169e Twenty Ten: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31266


git-svn-id: http://core.svn.wordpress.org/trunk@31247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-22 00:42:44 +00:00
Lance Willett
dcf53d5bbb Twenty Eleven: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31265


git-svn-id: http://core.svn.wordpress.org/trunk@31246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-22 00:42:23 +00:00
Gary Pendergast
dc0f9e0079 Comments: When a comment fails to insert, remove invalid characters from the email and URL fields, too. 
See [31263], #21212


Built from https://develop.svn.wordpress.org/trunk@31264


git-svn-id: http://core.svn.wordpress.org/trunk@31245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 23:18:22 +00:00
Gary Pendergast
8196266d26 Comments: When a comment fails to insert, remove any invalid characters and try again. 
See #21212


Built from https://develop.svn.wordpress.org/trunk@31263


git-svn-id: http://core.svn.wordpress.org/trunk@31244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 23:04:23 +00:00
Lance Willett
d9cda71f18 Twenty Twelve: more fixes for escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31262


git-svn-id: http://core.svn.wordpress.org/trunk@31243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 21:06:23 +00:00
Lance Willett
078de57052 Twenty Twelve: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31261


git-svn-id: http://core.svn.wordpress.org/trunk@31242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 21:00:21 +00:00
Lance Willett
c25f0ae8f8 Twenty Thirteen: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31260


git-svn-id: http://core.svn.wordpress.org/trunk@31241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 20:49:22 +00:00
Boone Gorges
48ff8e7ab4 A few more wordpress.com https assets in unit tests. 
See #31091.
Built from https://develop.svn.wordpress.org/trunk@31259


git-svn-id: http://core.svn.wordpress.org/trunk@31240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 18:58:23 +00:00
Boone Gorges
a121f09d1c Use https URLs for wordpress.com assets in Tests_HTTP_Functions. 
The http->https redirects were breaking some of the tests.

Fixes #31091.
Built from https://develop.svn.wordpress.org/trunk@31258


git-svn-id: http://core.svn.wordpress.org/trunk@31239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 18:44:23 +00:00
Boone Gorges
b690195b0e Move GD-specific resize test to GD-specific resize test file. 
This makes it so that we don't have to mark the test as skipped when running
through Imagick tests.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31257


git-svn-id: http://core.svn.wordpress.org/trunk@31238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 18:28:22 +00:00
Boone Gorges
cf4db26358 Remove skipped unit tests related to proposed map_deep(). 
The tests have been added as a patch to #22300.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31256


git-svn-id: http://core.svn.wordpress.org/trunk@31237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-21 17:58:22 +00:00
Dominik Schilling
b4bb289b5d Customizer: Hide the reorder-widgets button when a widget area is empty. 
props celloexpressions.
fixes #27787.
Built from https://develop.svn.wordpress.org/trunk@31255


git-svn-id: http://core.svn.wordpress.org/trunk@31236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 22:45:22 +00:00
Boone Gorges
81c0f75332 Remove WP_Post_IDs_Iterator tests. 
The tests have been moved to a patch on the ticket where the class has been
proposed, #22435.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31254


git-svn-id: http://core.svn.wordpress.org/trunk@31235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 22:00:23 +00:00
Boone Gorges
be6048aed2 Remove skipped tests related to the proposed Export API. 
These tests have been added as a patch to #22435.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@31253


git-svn-id: http://core.svn.wordpress.org/trunk@31234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 20:58:21 +00:00
Dominik Schilling
0c0675627b Customizer: If there's only one available sidebar, hide the move-widget button. 
props celloexpressions.
fixes #30690.
Built from https://develop.svn.wordpress.org/trunk@31252


git-svn-id: http://core.svn.wordpress.org/trunk@31233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 20:36:21 +00:00
Boone Gorges
9059dc8e88 WP_Date_Query date validation should not fail for hour = 0. 
Props ChriCo, tyxla.
Fixes #31067 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31251


git-svn-id: http://core.svn.wordpress.org/trunk@31232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 19:13:22 +00:00
Lance Willett
17f69a89d4 Twenty Fourteen: fix escaping and minor code style issues. See #29127. 
Built from https://develop.svn.wordpress.org/trunk@31250


git-svn-id: http://core.svn.wordpress.org/trunk@31231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 19:03:23 +00:00
Gary Pendergast
109d87363d Texturize: Add "em" as a cockney term, so that "'em" is texturized with an apostrophe, instead of an open quote. 
Fixes #29813.

Props miqrogroove.


Built from https://develop.svn.wordpress.org/trunk@31249


git-svn-id: http://core.svn.wordpress.org/trunk@31230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-20 18:44:26 +00:00
Boone Gorges
61f5f38dcd Better loop detection for _pad_term_counts(). 
The `$ancestors` check must be reset for each term in order for term counts
to be correct.

Fixes #20635.
Built from https://develop.svn.wordpress.org/trunk@31248


git-svn-id: http://core.svn.wordpress.org/trunk@31229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 16:52:22 +00:00
Sergey Biryukov
067ee8c476 Remove inaccurate part of {$taxonomy}_add_form_fields action description. 
props joostdekeijzer.
fixes #31052.
Built from https://develop.svn.wordpress.org/trunk@31247


git-svn-id: http://core.svn.wordpress.org/trunk@31228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 15:31:23 +00:00
Drew Jaynes
d95586e943 Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php. 
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.

Props morganestes.
Fixes #30825.

Built from https://develop.svn.wordpress.org/trunk@31246


git-svn-id: http://core.svn.wordpress.org/trunk@31227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 09:15:22 +00:00
Drew Jaynes
e0b3db1e09 Remove a stray period introduced in [31242]. 
Props SergeyBiryukov.
See #31048.

Built from https://develop.svn.wordpress.org/trunk@31245


git-svn-id: http://core.svn.wordpress.org/trunk@31226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 08:47:24 +00:00
Drew Jaynes
d41e669efe Ensure the correct list of default tabs for the Plugin Install screen are documented. 
Props stevenkword.
Fixes #31017.

Built from https://develop.svn.wordpress.org/trunk@31244


git-svn-id: http://core.svn.wordpress.org/trunk@31225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 08:44:22 +00:00
Drew Jaynes
3a0726d7b8 Add more complete documentation for parameters, globals, and return values to the DocBlocks for remove_shortcode(), shortcode_exists(), and do_shortcode(). 
Props SergeyBiryukov.
Fixes #31048.

Built from https://develop.svn.wordpress.org/trunk@31243


git-svn-id: http://core.svn.wordpress.org/trunk@31224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 08:40:24 +00:00
Drew Jaynes
a8e2ae2117 Ensure both parameters and the return for has_shortcode() are fully documented. 
Props cais, SergeyBiryukov
See #31048.

Built from https://develop.svn.wordpress.org/trunk@31242


git-svn-id: http://core.svn.wordpress.org/trunk@31223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 08:36:25 +00:00
Sergey Biryukov
eff3b8925b Display correct title in Archives widget if the type of archive was changed using the 'widget_archives_dropdown_args' filter. 
props floriansimeth for initial patch.
fixes #31024.
Built from https://develop.svn.wordpress.org/trunk@31241


git-svn-id: http://core.svn.wordpress.org/trunk@31222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 08:26:24 +00:00
Sergey Biryukov
eedb4857ba Strip HTML tags when searching for installed themes. 
props enej, SergeyBiryukov, obenland.
fixes #27561.
Built from https://develop.svn.wordpress.org/trunk@31240


git-svn-id: http://core.svn.wordpress.org/trunk@31221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-18 20:40:23 +00:00
Sergey Biryukov
247cdad571 attachment_url_to_postid() should always return an integer. 
props nathan_dawson, ashfame.
fixes #31044.
Built from https://develop.svn.wordpress.org/trunk@31239


git-svn-id: http://core.svn.wordpress.org/trunk@31220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-18 20:33:23 +00:00
Drew Jaynes
bee439858b Minor fix for inline doc syntax in a changelog entry for wp_get_object_terms(). 
See #28688.

Built from https://develop.svn.wordpress.org/trunk@31238


git-svn-id: http://core.svn.wordpress.org/trunk@31219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-18 19:05:22 +00:00
Boone Gorges
a639c5905e Add @since annotation for 'orderby' values introduced in [31236]. 
See #28688.
Built from https://develop.svn.wordpress.org/trunk@31237


git-svn-id: http://core.svn.wordpress.org/trunk@31218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-18 19:03:24 +00:00
Boone Gorges
42ec13030c Additional 'orderby' values for wp_get_object_terms(). 
Adds support for ordering by 'taxonomy', 'term_taxonomy_id', and 'parent'.

Props ChriCo.
Fixes #28688.
Built from https://develop.svn.wordpress.org/trunk@31236


git-svn-id: http://core.svn.wordpress.org/trunk@31217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-18 18:57:23 +00:00
Andrew Ozz
00436f6886 TinyMCE: fix vertical positioning of the image toolbar when there are several instances of the editor. Props avryl, fixes #31028. 
Built from https://develop.svn.wordpress.org/trunk@31235


git-svn-id: http://core.svn.wordpress.org/trunk@31216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-18 17:56:23 +00:00
Sergey Biryukov
7d2ec003da Customizer: Replicate behavior from options-reading.php and hide front page options if there are no pages. 
props Clorith.
fixes #27630.
Built from https://develop.svn.wordpress.org/trunk@31234


git-svn-id: http://core.svn.wordpress.org/trunk@31215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-18 06:01:24 +00:00
Boone Gorges
9c99ff8fe3 Add unit tests for 'orderby' and 'order' param of wp_get_object_terms(). 
Built from https://develop.svn.wordpress.org/trunk@31233


git-svn-id: http://core.svn.wordpress.org/trunk@31214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 20:39:44 +00:00
Boone Gorges
a245838c42 Correct wp_get_object_terms() documentation. 
The 'orderby' parameter accepts a number of values that have never been
properly documented.
Built from https://develop.svn.wordpress.org/trunk@31232


git-svn-id: http://core.svn.wordpress.org/trunk@31213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 20:39:23 +00:00
Boone Gorges
03512a2a02 Standardize the docblock for wp_get_object_terms(). 
The enumeration of the `$args` parameter has been moved from the long
description to an array hash associated with the proper `@param` attribute.
Built from https://develop.svn.wordpress.org/trunk@31231


git-svn-id: http://core.svn.wordpress.org/trunk@31212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 20:09:47 +00:00
Boone Gorges
a917a904bd Move wp_get_object_terms() tests into their own file. 
See #26999.
Built from https://develop.svn.wordpress.org/trunk@31230


git-svn-id: http://core.svn.wordpress.org/trunk@31211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 20:09:26 +00:00
Sergey Biryukov
34d06ee6b7 Add a changelog entry for the new parameter added in [31228]. 
props DrewAPicture.
fixes #31015.
Built from https://develop.svn.wordpress.org/trunk@31229


git-svn-id: http://core.svn.wordpress.org/trunk@31210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 17:31:23 +00:00
Sergey Biryukov
4e90a18c7c Pass $force_reauth value to the 'login_url' filter. 
props jfarthing84, MikeHansenMe.
fixes #31015.
Built from https://develop.svn.wordpress.org/trunk@31228


git-svn-id: http://core.svn.wordpress.org/trunk@31209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 17:20:23 +00:00
Sergey Biryukov
8b50aef14c Customizer: Make "Search widgets" input sticky. 
props celloexpressions.
fixes #30751.
Built from https://develop.svn.wordpress.org/trunk@31227


git-svn-id: http://core.svn.wordpress.org/trunk@31208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 13:15:23 +00:00
Sergey Biryukov
823ab1efdf Customizer: Fix form tag replacement in WP_Customize_Widgets::get_widget_control() after [31200]. 
see #30126.
Built from https://develop.svn.wordpress.org/trunk@31226


git-svn-id: http://core.svn.wordpress.org/trunk@31207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 13:11:23 +00:00
Sergey Biryukov
768624cb99 Use the site's local time to create the first post during installation. 
props extendwings.
fixes #29296.
Built from https://develop.svn.wordpress.org/trunk@31225


git-svn-id: http://core.svn.wordpress.org/trunk@31206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 10:07:23 +00:00
Sergey Biryukov
b87b8f2bb3 Introduce has_header_image() to check whether a header image is set. 
props GunGeekATX, voldemortensen.
fixes #16268.
Built from https://develop.svn.wordpress.org/trunk@31224


git-svn-id: http://core.svn.wordpress.org/trunk@31205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 06:34:23 +00:00
Andrew Ozz
9d3ea188d7 Add support for IE conditional comments for WP_Scripts to match the functionality of WP_Styles, including unit tests. Props filosofo, aaroncampbell, ethitter, georgestephanis, valendesigns. Fixes #16024. 
Built from https://develop.svn.wordpress.org/trunk@31223


git-svn-id: http://core.svn.wordpress.org/trunk@31204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 01:37:22 +00:00
Andrew Ozz
f609d9d89a TinyMCE: add breaking out of blockquotes by pressing Enter twice. Togging blockquote on|off with the button and the shortcut is unchanged. Props avryl, fixes #23110. 
Built from https://develop.svn.wordpress.org/trunk@31222


git-svn-id: http://core.svn.wordpress.org/trunk@31203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 23:36:22 +00:00
Scott Taylor
5458a4da21 wp_set_object_terms() takes $taxonomy as a string. Update @param. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31221


git-svn-id: http://core.svn.wordpress.org/trunk@31202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 23:27:25 +00:00
Scott Taylor
02a1f35ac8 Fix some internal types that are passed to functions to avoid changing the acceptable types passed as arguments to those functions: 
* In `WP_Importer->is_user_over_quota()`, the default value for the first argument for `upload_is_user_over_quota()` is `true`. Don't bother passing `1`.
* When calling `submit_button()` with no `$name`, pass empty string instead of `false`.
* The default value for the 2nd argument to `get_edit_post_link()` is `'display'`. Because PHP is PHP, passing `true` is the same as passing `'display'` or nothing. Don't bother passing `true`. 
* In `WP_User_Meta_Session_Tokens::drop_sessions()`, pass `0` instead of `false` to `delete_metadata()` as the value for `$object_id`, which expects an int. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31220


git-svn-id: http://core.svn.wordpress.org/trunk@31201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 22:51:21 +00:00
Scott Taylor
eeda68bbda Fix some erroneous @param annotations. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31219


git-svn-id: http://core.svn.wordpress.org/trunk@31200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 22:44:25 +00:00
Boone Gorges
fffd8c8e2d In get_edit_term_link(), default to a valid $object_type. 
The $object_type param is used to set the 'post_type' query var, which
determines the post type menu that will be expanded when clicking through to
the term edit page. Not all taxonomies are associated with Posts, so it makes
sense to default to a post_type that the taxonomy is actually associated with.

Props DzeryCZ, juliobox.
Fixes #29251.
Built from https://develop.svn.wordpress.org/trunk@31218


git-svn-id: http://core.svn.wordpress.org/trunk@31199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:37:23 +00:00
Scott Taylor
0f6d0b84d1 Remove unused local vars in delete_plugins(), delete_theme(), WP_Date_Query->validate_date_values(), global_terms(), and WP_Text_Diff_Renderer_Table->_changed(). 
This will clear out the "Unused Code" label in the next Scrutinizer report.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31217


git-svn-id: http://core.svn.wordpress.org/trunk@31198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:19:22 +00:00
Scott Taylor
7c5038feb6 Calling ->chown() and ->chgrp() in WP_Filesystem_ftpsockets produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31216


git-svn-id: http://core.svn.wordpress.org/trunk@31197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:10:23 +00:00
Scott Taylor
6fa7021d62 Calling ->chown() and ->chgrp() in WP_Filesystem_FTPext produces no side-effects. Remove the calls. ->chgrp() is defined in the super class, and does nothing, can be removed from the child class. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31215


git-svn-id: http://core.svn.wordpress.org/trunk@31196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 21:07:24 +00:00
Lance Willett
f6fd49b357 Twenty Fifteen: keep sub-menus open when visiting sub-menu pages, to show context when navigating a site. 
Props jartes, fixes #30722.
Built from https://develop.svn.wordpress.org/trunk@31214


git-svn-id: http://core.svn.wordpress.org/trunk@31195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 19:17:22 +00:00
Scott Taylor
b8dd1f9c69 By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors. 
There are plenty of other kinds of errors, but this label will be cleared out.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31213


git-svn-id: http://core.svn.wordpress.org/trunk@31194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 19:13:23 +00:00
Scott Taylor
bc55996a0b @param cleanup: 
* `get_metadata()` will return literally anything, needs to be `mixed`
* `wp()` and `WP_Query::__construct()` no longer just take a query string
* Clarify a few others

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31212


git-svn-id: http://core.svn.wordpress.org/trunk@31193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 19:03:23 +00:00
Scott Taylor
cde4c83091 [31210] broke Supportflow on dotorg, which declares these methods as protected. Switch to protected for the noop methods. The subclasses can make them more visible using public. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31211


git-svn-id: http://core.svn.wordpress.org/trunk@31192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 18:37:24 +00:00
Scott Taylor
3fb283db0a Add 2 noop methods to WP_List_Table: ->column_default() and ->column_cb(). 
`WP_List_Table` is essentially an `abstract` class. Some of its methods throw `die()` warnings if they aren't overridden in a child class.

These noop methods wouldn't be `abstract`, because they are not required in subclasses. However, `WP_List_Table` can call these methods in its own method, `->single_row_columns()`, whether a subclass defined them or not.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31210


git-svn-id: http://core.svn.wordpress.org/trunk@31191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:42:22 +00:00
Scott Taylor
895794f74d In WP_Filesystem_Base subclasses that set $wp_base, remove this dead code. 
Unused since [8009] - "Make WP_Filesystem work with new directory constants"

There is currently no declared field and no `@property` annotation.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31209


git-svn-id: http://core.svn.wordpress.org/trunk@31190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:23:22 +00:00
Scott Taylor
b29a20b90a WP_Filesystem_Base should declare $errors and $options as fields for use by subclasses. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31208


git-svn-id: http://core.svn.wordpress.org/trunk@31189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:10:43 +00:00
Boone Gorges
35f3f7bf63 Bail out of hierarchy loops in _get_term_children(). 
This prevents infinite loops that lead to PHP nesting limit fatal errors.

Props boonebgorges, sgrant.
Fixes #24461.
Built from https://develop.svn.wordpress.org/trunk@31207


git-svn-id: http://core.svn.wordpress.org/trunk@31188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 17:10:22 +00:00
Boone Gorges
991bfdebc1 Bail out of hierarchy loops in _pad_term_counts(). 
Taxonomy hierarchy loops should not occur naturally, but when they do, the
logic of `_pad_term_counts()` could result in infinite loops, leading to
timeouts. We avoid this by breaking when a loop is detected.

Fixes #20635.
Built from https://develop.svn.wordpress.org/trunk@31206


git-svn-id: http://core.svn.wordpress.org/trunk@31187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 16:46:23 +00:00
Scott Taylor
86f29795a4 Add <s> to $allowedtags in KSES. 
From https://developer.mozilla.org/en-US/docs/Web/HTML/Element/s :
"The <strike> element, alter ego of the <s> element is obsolete and should not be used on Web sites any more."

`<strike>` shall remain for BC, but `<s>` should not be stripped from the author (et al) role's HTML input.

Props paulschreiber.
Fixes #30954.

Built from https://develop.svn.wordpress.org/trunk@31205


git-svn-id: http://core.svn.wordpress.org/trunk@31186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 16:07:23 +00:00
Scott Taylor
5f9a800110 In comment_form(), add the HTML5 required attribute next to aria-required in fields that utilize it. 
Props MMN-o.
Fixes #24732.

Built from https://develop.svn.wordpress.org/trunk@31204


git-svn-id: http://core.svn.wordpress.org/trunk@31185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 15:56:23 +00:00
Boone Gorges
fb691a449b In paginate_links(), don't override custom format arguments when setting up default 'add_args'. 
Since 4.1 [29780], the default value of the 'add_args' argument in
`paginate_links()` has been determined by parsing the current URL. This change
had the side effect of overriding custom values of 'format' that changed the
pagination query var, with the result that plugins using `paginate_links()`
with a custom format generated the incorrect links unless explicitly
declaring 'add_args=false' to prevent the default values from overriding. We
fix this behavior by parsing URL query vars into the 'add_args' array only
after the explicit function params have been parsed, and by skipping the
current page's pagination query var when doing this parsing (to avoid the
override).

Props obenland.
Fixes #30831 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31203


git-svn-id: http://core.svn.wordpress.org/trunk@31184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 15:49:25 +00:00
Scott Taylor
3f8d8cec00 Add @ignore to _wp_scripts_maybe_doing_it_wrong(). 
Props DrewAPicture for the thought leadership.
See #20513.

Built from https://develop.svn.wordpress.org/trunk@31202


git-svn-id: http://core.svn.wordpress.org/trunk@31183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 05:38:21 +00:00
Scott Taylor
60c285aa22 In wp_ajax_parse_media_shortcode(), don't require a global $post for all passed shortcodes. 
`embed` is the only shortcode that requires a post ID. This will allow MCE views to work for `playlist`, `audio`, and `video` outside of the Edit Post screen.

See #30835.

Built from https://develop.svn.wordpress.org/trunk@31201


git-svn-id: http://core.svn.wordpress.org/trunk@31182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 05:19:22 +00:00
Scott Taylor
7f8b548df1 In HTML5, the action attribute is no longer required. Remove this attribute when empty. 
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 04:16:24 +00:00
Gary Pendergast
d0c327443c When a hyphen - or double hyphen -- was at the start or the end of a string, it wasn't texturized correctly. 
Fixes #31030


Built from https://develop.svn.wordpress.org/trunk@31199


git-svn-id: http://core.svn.wordpress.org/trunk@31180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 03:54:24 +00:00
Helen Hou-Sandí
798439c273 Media: Prevent filter selects from jiggling when the spinner shows. 
props valendesigns.
fixes #30725 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31197


git-svn-id: http://core.svn.wordpress.org/trunk@31178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 03:00:23 +00:00
Scott Taylor
e760ecfb13 Make _wp_scripts_maybe_doing_it_wrong( $function ) "private". 
Props obenland for the thought leadership.
See #20513.

Built from https://develop.svn.wordpress.org/trunk@31196


git-svn-id: http://core.svn.wordpress.org/trunk@31177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 02:42:22 +00:00
Gary Pendergast
b74f13511a Allow comment_post_ID to be passed to wp_update_comment(), so that a comment can be moved to a different post. 
Props tyxla, rachelbaker

Fixes #30946


Built from https://develop.svn.wordpress.org/trunk@31195


git-svn-id: http://core.svn.wordpress.org/trunk@31176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 02:39:23 +00:00
Scott Taylor
9ee49b130c After [31192], create a function, wp_styles(), to reduce duplicated code in functions.wp-styles.php. The style functions can reuse wp_scripts_maybe_doing_it_wrong( $function ) internally. 
See #20513.

Built from https://develop.svn.wordpress.org/trunk@31194


git-svn-id: http://core.svn.wordpress.org/trunk@31175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 02:31:23 +00:00
Scott Taylor
2849a791b4 In wp_print_scripts(), bail if $handles is false and the $wp_scripts global has not been instantiated. 
See [31192], #20513.

Built from https://develop.svn.wordpress.org/trunk@31193


git-svn-id: http://core.svn.wordpress.org/trunk@31174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 02:28:22 +00:00
Scott Taylor
74a8d68bbf functions.wp-scripts.php contains a lot of duplicated code. Make 2 new functions: wp_scripts() and wp_scripts_maybe_doing_it_wrong( $function ), to encapsulate the repeated logic. 
Props GaryJ, scribu, wonderboymusic.
Fixes #20513.

Built from https://develop.svn.wordpress.org/trunk@31192


git-svn-id: http://core.svn.wordpress.org/trunk@31173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 02:07:22 +00:00
Scott Taylor
378d66f038 After [31186], remove figcaption from the list of inline elements that are autop'd in Tests_Formatting_Autop::test_that_wpautop_treats_inline_elements_as_inline(). 
See #29219.

Built from https://develop.svn.wordpress.org/trunk@31191


git-svn-id: http://core.svn.wordpress.org/trunk@31172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 01:51:24 +00:00
Scott Taylor
6f8e01adf2 In WP_User, ->get_role_caps() and ->update_user_level_from_caps() must be called inside ->add_cap() and ->remove_cap() after updating user meta. ->has_cap() checks are currently failing directly after calling ->add_cap(). 
Adds unit test.

Props rachelbaker.
Fixes #28374.

Built from https://develop.svn.wordpress.org/trunk@31190


git-svn-id: http://core.svn.wordpress.org/trunk@31171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 01:49:25 +00:00
Scott Taylor
cf6adef68f Revert [31032], this did not get much love. 
See #25277.

Built from https://develop.svn.wordpress.org/trunk@31189


git-svn-id: http://core.svn.wordpress.org/trunk@31170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 01:11:23 +00:00
Scott Taylor
fe6b5983df In PHP 5.0.0, is_a() became deprecated in favour of the instanceof operator. Calling is_a() would result in an E_STRICT warning. 
In PHP 5.3.0, `is_a()` is no longer deprecated, and will therefore no longer throw `E_STRICT` warnings.

To avoid warnings in PHP < 5.3.0, convert all `is_a()` calls to `$var instanceof WP_Class` calls.

`instanceof` does not throw any error if the variable being tested is not an object, it simply returns `false`.

Props markoheijnen, wonderboymusic.
Fixes #25672.

Built from https://develop.svn.wordpress.org/trunk@31188


git-svn-id: http://core.svn.wordpress.org/trunk@31169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 01:06:24 +00:00
Scott Taylor
6704875855 Replace the 3 remaining occurrences of wpspin GIF with spinner. 
Props avryl.
Fixes #27482.

Built from https://develop.svn.wordpress.org/trunk@31187


git-svn-id: http://core.svn.wordpress.org/trunk@31168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 00:33:22 +00:00
Scott Taylor
6b84df3bbd Ensure that <figcaption> is not autop'd. 
Fixes #29219.

Built from https://develop.svn.wordpress.org/trunk@31186


git-svn-id: http://core.svn.wordpress.org/trunk@31167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 00:27:21 +00:00
Andrew Ozz
3e529d6753 TinyMCE: remove the fade in/out when opening/closing native modals to match the rest of our UI. Props afercia, avryl. Fixes #27388. 
Built from https://develop.svn.wordpress.org/trunk@31185


git-svn-id: http://core.svn.wordpress.org/trunk@31166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-15 23:29:21 +00:00
Lance Willett
7be12f7d8d Twenty Fifteen: move js and no-js class name functionality out of header template and into a wp_head hook in functions.php file so that the JavaScript functionality isn't hard-coded into a template file. 
Fixes #30770, props chipbennett, valendesigns, and peterwilsoncc.
Built from https://develop.svn.wordpress.org/trunk@31184


git-svn-id: http://core.svn.wordpress.org/trunk@31165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-15 23:10:22 +00:00
Lance Willett
4d00172987 Twenty Fifteen: remove unused CSS rules for wp_page_menu since are not used in the theme. And a bit of CSS cleanup. 
Props iamtakashi, fixes #30957.
Built from https://develop.svn.wordpress.org/trunk@31183


git-svn-id: http://core.svn.wordpress.org/trunk@31164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-15 23:05:22 +00:00
Lance Willett
6960d5ce12 Twenty Fifteen: remove border on post navigation when post thumbnail is available. 
Props jartes, fixes #30918.
Built from https://develop.svn.wordpress.org/trunk@31182


git-svn-id: http://core.svn.wordpress.org/trunk@31163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-15 23:03:26 +00:00
Helen Hou-Sandí
62a197d6bf List tables: Use CSS :nth-child() selectors for zebra striping. 
Note that this does not fix issues related to comment quick edit. Internal linking also continues to use the `.alternate` class for now. IE8 and below gracefully degrade by not having zebra striping.

There is some hoop jumping with adding an extra table row to maintain zebra striping during quick edit. Documenting that here for future reference; it is also in the inline documentation.

fixes #30981 and #26060. see #25060.

Built from https://develop.svn.wordpress.org/trunk@31181


git-svn-id: http://core.svn.wordpress.org/trunk@31162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-14 22:14:22 +00:00
Andrew Ozz
a7dcd2d736 TinyMCE: select the iframe element by id. Needed as some browser extensions insert extra elements in the page. Props avryl, see #30785. 
Built from https://develop.svn.wordpress.org/trunk@31180


git-svn-id: http://core.svn.wordpress.org/trunk@31161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-14 21:33:25 +00:00
Boone Gorges
3f033dc73d Support array values in WP_Date_Query::validate_date_values(). 
Introduced in [29925], `validate_date_values()` throws `_doing_it_wrong()`
notices when values passed as part of a `WP_Date_Query` do not reflect actual
dates. However, the validation did not account properly for the case where an
array of multiple values is passed, as when doing IN or BETWEEN queries.

Props dlh.
Fixes #31001 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31179


git-svn-id: http://core.svn.wordpress.org/trunk@31160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-14 16:51:24 +00:00
Jeremy Felt
8d55b418ec Don't overcheck the expected return from get_blog_details() in get_blogaddress_by_id() 
If `get_blog_details()` is returning something that is not our expected object or `false`, then a notice would already be thrown there.

Also adds proper return docs to `get_blog_details()`.

Props SergeyBiryukov.

Fixes #30566

Built from https://develop.svn.wordpress.org/trunk@31178


git-svn-id: http://core.svn.wordpress.org/trunk@31159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-14 05:33:25 +00:00
Sergey Biryukov
19e51601ab Revert [31173] and target only taxonomy and link manager tables in keyboard focus code. 
props afercia.
fixes #30980.
Built from https://develop.svn.wordpress.org/trunk@31177


git-svn-id: http://core.svn.wordpress.org/trunk@31158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 14:01:22 +00:00
Sergey Biryukov
c3c35cf645 Customizer: Use deep-link for Widgets in toolbar on front-end. 
props caseypatrickdriscoll.
fixes #30971.
Built from https://develop.svn.wordpress.org/trunk@31176


git-svn-id: http://core.svn.wordpress.org/trunk@31157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 07:45:22 +00:00
Sergey Biryukov
b2b4233b7b Twenty Fifteen: Add print section to the table of contents in the stylesheet. 
props iamtakashi.
fixes #30993.
Built from https://develop.svn.wordpress.org/trunk@31175


git-svn-id: http://core.svn.wordpress.org/trunk@31156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 07:21:21 +00:00
Sergey Biryukov
68c50a9e1b Scope attachment selectors in media views to avoid interfering with attachment pages on front-end. 
props valendesigns.
fixes #30878.
Built from https://develop.svn.wordpress.org/trunk@31174


git-svn-id: http://core.svn.wordpress.org/trunk@31155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 07:16:23 +00:00
Sergey Biryukov
3ac60370b8 Reveal row actions on focus on taxonomy screens. 
props afercia.
fixes #30980.
Built from https://develop.svn.wordpress.org/trunk@31173


git-svn-id: http://core.svn.wordpress.org/trunk@31154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 07:02:22 +00:00
Sergey Biryukov
dcaa26c1de Add 'user_id' to the list of fields wp_update_comment() can update. 
props jphase.
fixes #30307.
Built from https://develop.svn.wordpress.org/trunk@31172


git-svn-id: http://core.svn.wordpress.org/trunk@31153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 06:48:22 +00:00
Sergey Biryukov
47b47c4980 Add 'comment_type' to the list of fields wp_update_comment() can update. 
props desaiuditd.
fixes #30627.
Built from https://develop.svn.wordpress.org/trunk@31171


git-svn-id: http://core.svn.wordpress.org/trunk@31152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 06:42:21 +00:00
Drew Jaynes
f2bc30c03f Ensure we're using the correct @ignore phpDocumentor tag to mark elements that should be skipped when parsing. 
Up to this point, various core elements' DocBlocks incorrectly included an `@internal` tag as a means for skipping the parsing process. When paired with a description (inline or otherwise), `@internal` is a valid tag meant to provide internal-only context, but not necessarily to skip parsing the entire element.

See #30987.

Built from https://develop.svn.wordpress.org/trunk@31170


git-svn-id: http://core.svn.wordpress.org/trunk@31151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 00:51:21 +00:00
Drew Jaynes
632c26d142 Remove an erroneous @internal tag from the DocBlock for get_children(). 
Use of the `@internal` tag caused the reference article for this function to be skipped during the parsing process.

Fixes #30987 for trunk.

Built from https://develop.svn.wordpress.org/trunk@31169


git-svn-id: http://core.svn.wordpress.org/trunk@31150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-13 00:08:22 +00:00
Scott Taylor
fc843ce4d0 There are some random add_action() and add_filter() calls littered around some files in wp-includes/. These should be moved to wp-includes/default-filters.php with the rest of the registered hooks. It seems like this was the best practice for awhile and then we randomly stopped. This file loads way before any of the includes, so the hooks will be registered for any request that loads WordPress, even SHORTINIT - a lot of the hooks registered won't run anyways (that's already the case). 
See #30947.

Built from https://develop.svn.wordpress.org/trunk@31168


git-svn-id: http://core.svn.wordpress.org/trunk@31149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:40:23 +00:00
Scott Taylor
b51593763a WP_Themes_List_Table accesses $_pagination_args from the parent class. Switch $_pagination_args to protected in WP_List_Table. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31167


git-svn-id: http://core.svn.wordpress.org/trunk@31148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:26:21 +00:00
Scott Taylor
4f6de09a5b Add a private field to WP_Terms_List_Table, $level. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31166


git-svn-id: http://core.svn.wordpress.org/trunk@31147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:23:22 +00:00
Scott Taylor
194932fd6b Add a private field to WP_Posts_List_Table, $is_trash. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31165


git-svn-id: http://core.svn.wordpress.org/trunk@31146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:22:22 +00:00
Scott Taylor
71f9bc3f42 Add a private field to WP_Plugin_Install_List_Table, $error. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31164


git-svn-id: http://core.svn.wordpress.org/trunk@31145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:19:22 +00:00
Scott Taylor
91312e71cd In lieu of refactoring, add a private field to WP_MS_Themes_List_Table, $has_items. Ideally, this class would overload ->has_items() and not set a private field. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31163


git-svn-id: http://core.svn.wordpress.org/trunk@31144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:17:22 +00:00
Scott Taylor
86c0f63739 Add 2 private fields to WP_Media_List_Table, $detached and $is_trash. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31162


git-svn-id: http://core.svn.wordpress.org/trunk@31143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:08:21 +00:00
Scott Taylor
df09597a65 After [31146], properly declare $user_can as a private field in WP_Comments_List_Table. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31161


git-svn-id: http://core.svn.wordpress.org/trunk@31142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 16:02:24 +00:00
Dion Hulse
af92025162 More concise documentation for wp_install_maybe_enable_pretty_permalinks() 
See #6481. Props ericlewis.

Built from https://develop.svn.wordpress.org/trunk@31160


git-svn-id: http://core.svn.wordpress.org/trunk@31141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 04:33:23 +00:00
Dion Hulse
a114d0929b The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. 
See #6481. Props nacin, valendesigns

Built from https://develop.svn.wordpress.org/trunk@31159


git-svn-id: http://core.svn.wordpress.org/trunk@31140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 04:31:23 +00:00
Jeremy Felt
8f35b191db Use a less complex approach for enforcing path slashes in update_blog_details() 
Ensure leading and traling slashes are in place and don't touch anything in the middle. Validating with `array_filter()` would have missed a possible valid falsy path - `/my-path/0/`.

Props nacin.

Fixes #18117.

Built from https://develop.svn.wordpress.org/trunk@31158


git-svn-id: http://core.svn.wordpress.org/trunk@31139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 04:21:22 +00:00
Jeremy Felt
343a6587cf Check for existence of data from get_blogaddress_by_id() before returning a URL 
* Prevent a notice when an invalid ID is used with `get_blogaddres_by_id()`.
* Return a falsy empty string rather than the previous "http://".
* Add unit tests for `get_blogaddress_by_id()`.

Props nerrad.

Fixes #30566.

Built from https://develop.svn.wordpress.org/trunk@31157


git-svn-id: http://core.svn.wordpress.org/trunk@31138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 02:24:22 +00:00
Jeremy Felt
40bcb404a3 Update home and siteurl after path slashes are validated in update_blog_details() 
When editing a site, if `home` and `siteurl` are checked to be updated along with a site's domain and path, they should receive the results of any modifications in `update_blog_details()` rather than trusting the POST data.

Previously, it was possible to save a value without a leading slash on the path, causing an invalid URL to be stored.

Props earnjam.

Fixes #30417.

Built from https://develop.svn.wordpress.org/trunk@31156


git-svn-id: http://core.svn.wordpress.org/trunk@31137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 01:57:23 +00:00
Jeremy Felt
eaf7f8df74 Enforce leading and trailing slashes on paths updated with update_blog_details() 
In multisite, core expects the stored value for a site's path to have leading and trailing slashes. When these slashes are missing, it becomes impossible to visit the site.

This enforces proper `/path/` creation in `update_blog_details()`, most likely used when updating an existing site through `site-info.php`.

Props earnjam, simonwheatley.

Fixes #18117. Fixes #23865.

Built from https://develop.svn.wordpress.org/trunk@31155


git-svn-id: http://core.svn.wordpress.org/trunk@31136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 01:43:22 +00:00
Gary Pendergast
34636a0e41 If get_avatar_data() is passed an empty value for the default avatar, we should be using the site's avatar_default option instead. 
See #21195

Built from https://develop.svn.wordpress.org/trunk@31154


git-svn-id: http://core.svn.wordpress.org/trunk@31135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 00:23:24 +00:00
Gary Pendergast
3d051df3c9 In get_avatar_data(), there's no need to return false if we couldn't find an avatar, as Gravatar can handle being given an empty email hash. This allows the default avatar to show when no email address is given. 
See #21195


Built from https://develop.svn.wordpress.org/trunk@31153


git-svn-id: http://core.svn.wordpress.org/trunk@31134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 00:20:24 +00:00
Gary Pendergast
4bc89fef32 In get_avatar(), revert the <img> tag attributes to using single quotes, instead of double quotes. This behaviour was changed in [31107], but caused problems for code that attempted to parse the <img> tag. 
See #21195


Built from https://develop.svn.wordpress.org/trunk@31152


git-svn-id: http://core.svn.wordpress.org/trunk@31133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 00:03:24 +00:00
Scott Taylor
eed3698c49 In WP_Query, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. Remove __unset() since __set() is not implemented. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31151


git-svn-id: http://core.svn.wordpress.org/trunk@31132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:41:24 +00:00
Scott Taylor
61e12e00c1 In WP_Comment_Query, only allow __call() to run against ->get_search_sql(). 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31150


git-svn-id: http://core.svn.wordpress.org/trunk@31131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:33:24 +00:00
Scott Taylor
0e84d59de5 In wp_xmlrpc_server, only allow __call() to run against ->_multisite_getUsersBlogs(). 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31149


git-svn-id: http://core.svn.wordpress.org/trunk@31130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:31:22 +00:00
Scott Taylor
ed4e7b01d4 In WP_oEmbed, only allow __call() to run against a whitelist of methods, $compat_methods. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31148


git-svn-id: http://core.svn.wordpress.org/trunk@31129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:27:23 +00:00
Scott Taylor
a4092e90f0 In WP_Roles, only allow __call() to run against ->_init(). 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31147


git-svn-id: http://core.svn.wordpress.org/trunk@31128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:23:23 +00:00
Scott Taylor
e6fc90f973 In WP_List_Table, only call magic method internals again whitelists of properties and methods, $compat_fields and $compat_methods. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31146


git-svn-id: http://core.svn.wordpress.org/trunk@31127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:20:22 +00:00
Scott Taylor
2749e46178 In WP_Filesystem_Base, make the only private member, $cache, public and remove magic methods. $cache was always public until [28487], has been essentially public via a magic method since. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31145


git-svn-id: http://core.svn.wordpress.org/trunk@31126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:04:22 +00:00
Scott Taylor
a79c242038 In WP_User_Query, only call magic method internals against a whitelist of properties, $compat_fields. 
See #30891.

Built from https://develop.svn.wordpress.org/trunk@31144


git-svn-id: http://core.svn.wordpress.org/trunk@31125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 22:00:23 +00:00
Andrew Ozz
d079899553 TinyMCE wpView: when clicking in the editor optimize the caret placement before or after a view. Props avryl, fixes #30938. 
Built from https://develop.svn.wordpress.org/trunk@31143


git-svn-id: http://core.svn.wordpress.org/trunk@31124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 20:42:23 +00:00
Andrew Ozz
49c0b22828 TinyMCE: fix (switch) the indent/outdent icons in RTL mode so the arrow points at the proper direction. Props avryl, fixes #21281. 
Built from https://develop.svn.wordpress.org/trunk@31142


git-svn-id: http://core.svn.wordpress.org/trunk@31123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 20:30:26 +00:00
Boone Gorges
77875a273e Walker::$has_children should be public for backward compatibility. 
See [31137]. See #30891.
Built from https://develop.svn.wordpress.org/trunk@31141


git-svn-id: http://core.svn.wordpress.org/trunk@31122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 01:56:22 +00:00
Boone Gorges
5c0ddb8602 Default $parent in category_exists() should default to null rather than 0. 
[29863] made the corresponding change in `term_exists()`. Failure to change the
default value in `category_exists()` meant that an unspecified value for
`$parent` would limit results to top-level categories.

Includes unit tests and corrected function documentation.

Props hissy.
Fixes #30975 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31140


git-svn-id: http://core.svn.wordpress.org/trunk@31121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 01:26:27 +00:00
Scott Taylor
c9bc1cc46e WP_Ajax_Response has one property only, $responses. It was public until [28508], when it became private in name only. Is it worth 4 magic methods to pretend that this property is private? It is not. 
Make it `public` and remove the magic methods.

See #30891.

Built from https://develop.svn.wordpress.org/trunk@31139


git-svn-id: http://core.svn.wordpress.org/trunk@31120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 00:13:23 +00:00
Scott Taylor
d8e5aabab5 In WP_Error: 
* `wp_send_json_error()` accesses `$errors` on an instance, it must be `public`
* `$error_data` is a local message cache for error codes and doesn't particularly hide info, would be the only non-public field or method in the class

Make `$errors` and `$error_data` public and remove magic methods.

See #30891.

Built from https://develop.svn.wordpress.org/trunk@31138


git-svn-id: http://core.svn.wordpress.org/trunk@31119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-11 00:01:22 +00:00
Scott Taylor
b962499be6 In Walker: 
* Every subclass of `Walker` overrides `$db_fields` and makes it public
* `wp_list_comments()` accesses `->max_pages` on an instance of `Walker`, it must be public
* `$has_children` was added as `protected` in 4.0. doesn't need BC

Make `$db_fields` and `$max_pages` public and remove magic methods.

See #30891.

Built from https://develop.svn.wordpress.org/trunk@31137


git-svn-id: http://core.svn.wordpress.org/trunk@31118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 23:44:23 +00:00
Scott Taylor
eab3aa7802 In WP_MatchesMapRegex: 
* Exactly one method was made private in [28516], and is only used internally.
* 2 properties were made private, but they just store variables passed to the constructor.
* Instances of this class are never created in core. `WP_MatchesMapRegex::apply()` is called statically in `WP->parse_request()` and `url_to_postid()`. 

The chances that: 
1) this class is used as an instance somewhere and 
2) the properties that have always been marked `@access private` and begin with `_` were used publicly

...is extremely low.

Remove the magic methods, I should not have added them.

While we're at it, use the PHP5-style `__construct()` instead of the class name.

See #30891.

Built from https://develop.svn.wordpress.org/trunk@31136


git-svn-id: http://core.svn.wordpress.org/trunk@31117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 23:27:21 +00:00
Scott Taylor
65a459b34f In WP_Text_Diff_Renderer_Table: 
* In [28525], `$_diff_threshold`, `$inline_diff_renderer`, and `$_show_split_view` were marked `protected`; magic methods were also added.
* The magic methods should only perform operations on a whitelisted set of properties, now specified in `$compat_fields`
* Remove `__call()`, is unnecessary and can wreak havoc on the parent class.

This class is used in one place: `wp_text_diff()`.

See #30891.

Built from https://develop.svn.wordpress.org/trunk@31135


git-svn-id: http://core.svn.wordpress.org/trunk@31116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 22:58:24 +00:00
Scott Taylor
a56d920454 In Custom_Image_Header: 
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` values
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 4 properties marked `private`: `$uploaded_headers`, `$default_headers`, `$page`, and `$updated` - `$page` and `$uploaded_headers` are never used and `$updated` was added by me in [30187] during 4.1. `$default_headers` does not necessarily need to be `private`

Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the `$uploaded_headers` property - it is used nowhere and is dead code.
Set `$default_headers` to `public`.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.

See #30891.

Built from https://develop.svn.wordpress.org/trunk@31134


git-svn-id: http://core.svn.wordpress.org/trunk@31115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 22:11:22 +00:00
Scott Taylor
61f5cc459e In Custom_Background: 
* In [28481], `$admin_header_callback` and `$admin_image_div_callback` were set to `private` based on their erroneous `@param` value
* `$admin_header_callback` and `$admin_image_div_callback` are used as hook callbacks - as such, they must be `public`
* In [28521] and [28524], magic methods were added for back-compat
* Currently, there are 2 properties marked `private`, `$page` and `$updated` - `$page` is never used and `$updated` was added by me in [30186] during 4.1

Set `$admin_header_callback` and `$admin_image_div_callback` to `public`.
Remove the `$page` property - it duplicated the `$page` local var and is referenced/used nowhere.
Remove the magic methods - they were beyond overkill and rendered moot by the above changes.

See #30891.

Built from https://develop.svn.wordpress.org/trunk@31133


git-svn-id: http://core.svn.wordpress.org/trunk@31114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 21:59:22 +00:00
Scott Taylor
806b2e9bae get_post() takes $output as its 2nd param. The @return annotation should reflect the function's ability to return an array. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31132


git-svn-id: http://core.svn.wordpress.org/trunk@31113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 21:38:23 +00:00
Scott Taylor
56d6682461 In edit-form-advanced.php: 
* `get_permalink( $post_ID )` can return `false`, set it to a variable and check it
* Using the variable allows us to replace 11 separate calls to `get_permalink( $post_ID )` in the file
* These notices were triggered by the potential for `false` to be passed to `esc_url()`

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31131


git-svn-id: http://core.svn.wordpress.org/trunk@31112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 21:21:22 +00:00
Scott Taylor
a6d6ba957b get_header_image() can return false. In Custom_Image_Header->step_1(), check the value before setting the background-image portion of the style attribute. Setting the the URL to empty string will cause the current request to be set as the source of the background image. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31130


git-svn-id: http://core.svn.wordpress.org/trunk@31111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 21:08:22 +00:00
Scott Taylor
aaae4e9df0 Since get_theme_mod() returns false on failure, $background_image_thumb can be set to it and checked instead of calling get_background_image() 3 times in Custom_Background->admin_page(). 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31129


git-svn-id: http://core.svn.wordpress.org/trunk@31110 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 20:44:22 +00:00
Scott Taylor
2b6b7c0235 Declare $action as a global in wp-admin/comment.php. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31128


git-svn-id: http://core.svn.wordpress.org/trunk@31109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 20:42:24 +00:00
Scott Taylor
5547115dc2 Fix some @param docs that have chars too close them. 
Add `@property` annotations to `WP_User` and `WP_Post`.
Remove erroneous `@param`s from image editor class methods.
Officially add the property `$_column_headers` to `WP_List_Table`.	

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31127


git-svn-id: http://core.svn.wordpress.org/trunk@31108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 06:57:22 +00:00
Scott Taylor
0a511680f4 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Constructors do not have meaningful return values, anything that is returned from here is discarded. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31126


git-svn-id: http://core.svn.wordpress.org/trunk@31107 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 06:54:23 +00:00
Scott Taylor
da99d29a59 Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value - anything that is returned is discarded. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31125


git-svn-id: http://core.svn.wordpress.org/trunk@31106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 06:13:22 +00:00
Scott Taylor
1b3f91f500 Declare $wp_version, $required_php_version, and $required_mysql_version as globals in install and upgrade admin files. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31124


git-svn-id: http://core.svn.wordpress.org/trunk@31105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 05:57:22 +00:00
Scott Taylor
1bac6fb886 In wp-admin/includes/revision.php, $post->modified is a coding error. It should be $post->post_modified. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31123


git-svn-id: http://core.svn.wordpress.org/trunk@31104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 05:50:22 +00:00
Scott Taylor
d6ce5dd553 WP_Upgrader will take any "skin" that is passed to it, and set ->skin via composition. The default type of ->skin is WP_Upgrader_Skin, which doesn't have methods declared for ->bulk_header() and ->bulk_footer(). Add noop methods to WP_Upgrader_Skin. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31122


git-svn-id: http://core.svn.wordpress.org/trunk@31103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 05:42:22 +00:00
Scott Taylor
84867b3e9c Admin globals: 
* Declare `$wp_importers` as a global in `admin.php`
* Declare `$post_type`, `$post_type_object`, and  `$post` as globals where applicable

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31121


git-svn-id: http://core.svn.wordpress.org/trunk@31102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 05:29:22 +00:00
Scott Taylor
ac654632fe Use PHP_SAPI constant instead of php_sapi_name() in iis7_supports_permalinks(), wp_fix_server_vars(), and wp_redirect(). 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31120


git-svn-id: http://core.svn.wordpress.org/trunk@31101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 04:59:22 +00:00
Scott Taylor
afd09f1f04 In wp_ajax_upload_attachment(), wp_check_filetype_and_ext() doesn't need a 3rd param - it already defaults to null. Passing false would fail a strict check 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31119


git-svn-id: http://core.svn.wordpress.org/trunk@31100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 04:55:25 +00:00
Andrew Ozz
3324fb71f6 TinyMCE editor-expand: when kitchensink is off hide the statusbar on loading, and when the editor is shorter then the viewport. Props avryl, fixes #30961. 
Built from https://develop.svn.wordpress.org/trunk@31118


git-svn-id: http://core.svn.wordpress.org/trunk@31099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-10 01:32:26 +00:00
Andrew Ozz
71885dceca Media modal: do not attempt to focus the hidden file input field added by Plupload when tabbing. Props afercia, fixes #30392. 
Built from https://develop.svn.wordpress.org/trunk@31117


git-svn-id: http://core.svn.wordpress.org/trunk@31098 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 21:47:29 +00:00
Scott Taylor
709698a579 In Custom_Background and Custom_Header: 
* In `->init()`, don't check `current_user_can()` since `add_theme_page()` will return `false` immediately if the cap check fails. 
* Bail if `add_theme_page()` returns `false`
* `wp_check_filetype_and_ext()` doesn't need a 3rd param, it already defaults to `null`. Passing `false` would fail a strict check.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31116


git-svn-id: http://core.svn.wordpress.org/trunk@31097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 21:07:22 +00:00
Scott Taylor
236d8ae9dc After [31016], would be cool if we actually included the froogaloop file to interact with Vimeo. 
Props dimadin.
Fixes #29267.

Built from https://develop.svn.wordpress.org/trunk@31115


git-svn-id: http://core.svn.wordpress.org/trunk@31096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 20:04:23 +00:00
Boone Gorges
df945fcdcb In get_permalink(), don't resolve to pretty permalink if post has 'future' status. 
We already do this for other non-public statuses, to prevent leaking non-public
information about unpublished posts.

Props e.mazovetskiy, CalEvans.
Fixes #30910.
Built from https://develop.svn.wordpress.org/trunk@31114


git-svn-id: http://core.svn.wordpress.org/trunk@31095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 16:40:22 +00:00
Sergey Biryukov
7b04e6d4f4 Add variable type for sync_category_tag_slugs() parameters. 
props tillkruess.
fixes #30718.
Built from https://develop.svn.wordpress.org/trunk@31113


git-svn-id: http://core.svn.wordpress.org/trunk@31094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 11:19:22 +00:00
Sergey Biryukov
2be2af7789 Avoid a PHP notice in _WP_Editors::wp_fullscreen_html() when no $post global is set. 
props marcochiesi.
fixes #30071.
Built from https://develop.svn.wordpress.org/trunk@31112


git-svn-id: http://core.svn.wordpress.org/trunk@31093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 10:28:23 +00:00
Sergey Biryukov
a2f9b410f8 Toolbar: Make network admin accessible via keyboard. 
props Cheffheid.
fixes #29422.
Built from https://develop.svn.wordpress.org/trunk@31111


git-svn-id: http://core.svn.wordpress.org/trunk@31092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 09:51:22 +00:00
Sergey Biryukov
e214fce67f Use localized format for Last Updated date in plugin details modal, for consistency with [31055]. 
see #30717.
Built from https://develop.svn.wordpress.org/trunk@31110


git-svn-id: http://core.svn.wordpress.org/trunk@31091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 06:21:22 +00:00
Sergey Biryukov
d5d0b367ab Improve documentation for media_handle_upload(). 
props ericlewis.
fixes #30962.
Built from https://develop.svn.wordpress.org/trunk@31109


git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 05:05:23 +00:00
Sergey Biryukov
e24b443f50 Correct @return value for WP_Theme::load_textdomain() after [30681]. 
see #30224.
Built from https://develop.svn.wordpress.org/trunk@31108


git-svn-id: http://core.svn.wordpress.org/trunk@31089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 04:54:24 +00:00
Gary Pendergast
5ee3ff435d Add get_avatar_url(), for retrieving just the URL of an avatar, rather than the entire <img> tag that get_avatar() produces. 
Unlike `get_avatar()`, `get_avatar_url()` is not pluggable. It can be extended/or modified through the new filters included.

Fixes #21195.

Props mdawaffe, pento, pathawks, DrewAPicture


Built from https://develop.svn.wordpress.org/trunk@31107


git-svn-id: http://core.svn.wordpress.org/trunk@31088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-09 04:43:23 +00:00
Scott Taylor
8ee598169f After [31105], don't ditch the isset() calls for BC. Declare $page_hook as null so it is initialized for all execution paths but will still fail isset() checks. 
Fixes #30958.

Built from https://develop.svn.wordpress.org/trunk@31106


git-svn-id: http://core.svn.wordpress.org/trunk@31087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 22:52:22 +00:00
Scott Taylor
60e1dd409b Properly declare $hook_suffix, $plugin_page, $typenow, and $taxnow as globals in wp-admin/admin.php. 
Fixes #30958.

Built from https://develop.svn.wordpress.org/trunk@31105


git-svn-id: http://core.svn.wordpress.org/trunk@31086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 22:15:24 +00:00
Sergey Biryukov
91297b7a30 If WP_Rewrite::flush_rules() is called on 'init' or earlier, wait until 'wp_loaded' before actually flushing the rules, to make sure all the rules registered on 'init' are included. 
props joostdevalk.
see #30501.
Built from https://develop.svn.wordpress.org/trunk@31104


git-svn-id: http://core.svn.wordpress.org/trunk@31085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 22:00:23 +00:00
Sergey Biryukov
6e29458407 Remove a redundant inline comment with a typo. 
props nicnicnicdevos.
fixes #30956.
Built from https://develop.svn.wordpress.org/trunk@31103


git-svn-id: http://core.svn.wordpress.org/trunk@31084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:29:24 +00:00
Sergey Biryukov
24b3ee8680 Make a hint on Edit Selection view in media modal more accurate, as it applies to all media files, not just images. 
props pavelevap.
see #30931.
Built from https://develop.svn.wordpress.org/trunk@31102


git-svn-id: http://core.svn.wordpress.org/trunk@31083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:24:23 +00:00
Scott Taylor
e4b6265c7a Overriding methods should do more than simply call the same method in the super class. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31101


git-svn-id: http://core.svn.wordpress.org/trunk@31082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:20:22 +00:00
Scott Taylor
4a1ad9acec Jump statements should not be followed by other statements (there were 5 lingering). 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31100


git-svn-id: http://core.svn.wordpress.org/trunk@31081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:15:22 +00:00
Scott Taylor
4feecb922c Use && instead of and in the 3 places where and was used. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31099


git-svn-id: http://core.svn.wordpress.org/trunk@31080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:12:22 +00:00
Sergey Biryukov
dfac056cf1 Pass post type to count_user_posts() in get_the_author_posts(). 
props Caspie, tyxla.
fixes #30904.
Built from https://develop.svn.wordpress.org/trunk@31098


git-svn-id: http://core.svn.wordpress.org/trunk@31079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 19:53:22 +00:00
Sergey Biryukov
ff4968ebc4 Use home_url() instead of hardcoded domain in Tests_Link_GetAdjacentPostLink. 
props CalEvans.
fixes #30955.
Built from https://develop.svn.wordpress.org/trunk@31097


git-svn-id: http://core.svn.wordpress.org/trunk@31078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 18:45:23 +00:00
Sergey Biryukov
e53b581817 Remove non-functional date filter from Edit Selection view in media modal. 
props tyxla.
fixes #30931.
Built from https://develop.svn.wordpress.org/trunk@31096


git-svn-id: http://core.svn.wordpress.org/trunk@31077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 18:23:23 +00:00
Helen Hou-Sandí
bc7cc3bb12 Collapse additional avatar settings if avatars are disabled. 
props markjaquith, krogsgard, valendesigns.
 fixes #30168.

Built from https://develop.svn.wordpress.org/trunk@31095


git-svn-id: http://core.svn.wordpress.org/trunk@31076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 17:01:24 +00:00
Gary Pendergast
c777f6a29c WPDB: When sanity checking a string, check that it's a string, first - PHP notices can occur if an array or object is handled like a string. 
See #21212

Built from https://develop.svn.wordpress.org/trunk@31094


git-svn-id: http://core.svn.wordpress.org/trunk@31075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 08:45:22 +00:00
Gary Pendergast
83a229084f WPDB: When wpdb::query() needs to sanity check a query string, make sure to run wpdb:flush() afterwards, to ensure the results from sanity check queries aren't mixed up with the results for the user query. 
See #21212.

Fixes #30948.

Built from https://develop.svn.wordpress.org/trunk@31093


git-svn-id: http://core.svn.wordpress.org/trunk@31074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 08:32:22 +00:00
Scott Taylor
ac6fddee35 In wp_xmlrpc_server, remove dead code. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31092


git-svn-id: http://core.svn.wordpress.org/trunk@31073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:21:22 +00:00
Scott Taylor
383a5c6c24 In wp-includes/plugin.php, collapse 3 else-newline-tab-if statements. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31091


git-svn-id: http://core.svn.wordpress.org/trunk@31072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:13:24 +00:00
Scott Taylor
60b0cd7943 The keyword elseif should be used instead of else if so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Dion Hulse
a4ed093250 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis

Built from https://develop.svn.wordpress.org/trunk@31089


git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 06:47:23 +00:00
Scott Taylor
bc4cd01190 In wp-includes/taxonomy.php: 
The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31087


git-svn-id: http://core.svn.wordpress.org/trunk@31068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 06:26:23 +00:00
Scott Taylor
29cd3fa5bf PHP keywords and constants "true", "false", "null" should be in lower case - there was one lingering capitalized false in _http_build_query(). 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31086


git-svn-id: http://core.svn.wordpress.org/trunk@31067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 06:14:23 +00:00
Scott Taylor
55fdfb529a There is no need to use the final modifier inside a final class. Everything in it is final by default. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31085


git-svn-id: http://core.svn.wordpress.org/trunk@31066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 06:10:46 +00:00
Scott Taylor
905f35f289 In Customizer classes: 
* `public final function` methods should be `final public function` - confusing Hack and aligns with PSR2
* Some methods were missing access modifiers

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31083


git-svn-id: http://core.svn.wordpress.org/trunk@31064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 06:02:24 +00:00
Scott Taylor
80915aaf16 WP_Query->parse_tax_query() - for BC, this method is not marked as protected. See [28987]. It needs an access modifier, it shall have public. The comment remains. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31081


git-svn-id: http://core.svn.wordpress.org/trunk@31062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:54:44 +00:00
Scott Taylor
ac4e67b82e Perl-style comments should not be used 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31079


git-svn-id: http://core.svn.wordpress.org/trunk@31060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:52:24 +00:00
Scott Taylor
e029005847 Access Modifiers: 
* In `WP_Plugin_Install_List_Table`, use `public` instead of `var`
* In `WP_User`, `->data` is accessed directly on an instance if the constructor receives it: make it `public`
* In `WP_Locale`, every property is exported to a global and is already `public` via `var`, half of the properties are accessed directly already, make them all `public`
* In `WP_Rewrite`, several properties are accessed publicly in functions via the `$wp_rewrite` global, make those props `public`.
* In `WP_Rewrite`, the property `->comment_feed_structure` was misspelled as `->comments_feed_structure`

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31078


git-svn-id: http://core.svn.wordpress.org/trunk@31059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:44:23 +00:00
Scott Taylor
ff98cfcf45 Pinking Shears. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@31077


git-svn-id: http://core.svn.wordpress.org/trunk@31058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 05:03:23 +00:00
Sergey Biryukov
9b0e279e82 In dashboard activity widget, display a front-end link if the user cannot edit the post. 
props UaMV, DrewAPicture.
fixes #29025.
Built from https://develop.svn.wordpress.org/trunk@31075


git-svn-id: http://core.svn.wordpress.org/trunk@31056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 00:26:22 +00:00
Sergey Biryukov
f2b5ac8ef1 Call the init() method for the upgrader in wp_can_install_language_pack() to avoid undefined index notices. 
props ocean90.
fixes #30827 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31074


git-svn-id: http://core.svn.wordpress.org/trunk@31055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 23:43:24 +00:00
Sergey Biryukov
f601e45055 TinyMCE: Remove dashicon-no-alt.png, unused since [30694]. 
props kpdesign, MattyRob.
fixes #30791 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31073


git-svn-id: http://core.svn.wordpress.org/trunk@31054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 23:32:22 +00:00
Sergey Biryukov
da4a8f56f5 Theme install: Display an appropriate string if theme has not been rated yet. 
props kevdotbadger, valendesigns.
fixes #28147.
Built from https://develop.svn.wordpress.org/trunk@31072


git-svn-id: http://core.svn.wordpress.org/trunk@31053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 23:17:22 +00:00
Sergey Biryukov
3dcd0e2119 Add context for 'Previous' and 'Next' strings in get_the_posts_pagination(). 
fixes #30762 for trunk.
Built from https://develop.svn.wordpress.org/trunk@31071


git-svn-id: http://core.svn.wordpress.org/trunk@31052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 23:07:22 +00:00
Andrew Ozz
00ff6675a2 Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167. 
Built from https://develop.svn.wordpress.org/trunk@31070


git-svn-id: http://core.svn.wordpress.org/trunk@31051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 22:48:22 +00:00
Sergey Biryukov
23a5deba53 Customizer: Correctly display "Select" option in Navigation section dropdowns. 
props kucrut.
fixes #30929.
Built from https://develop.svn.wordpress.org/trunk@31069


git-svn-id: http://core.svn.wordpress.org/trunk@31050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 19:50:23 +00:00
Sergey Biryukov
833c148bb5 Dashicons: Fix typo in .dashicons-excerpt-view class. 
props desrosj.
fixes #30832.
Built from https://develop.svn.wordpress.org/trunk@31068


git-svn-id: http://core.svn.wordpress.org/trunk@31049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 09:02:23 +00:00
Sergey Biryukov
1c9e1836ac Remove obsolete help sentence on Edit User screen. 
fixes #30750.
Built from https://develop.svn.wordpress.org/trunk@31067


git-svn-id: http://core.svn.wordpress.org/trunk@31048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 08:23:23 +00:00
Sergey Biryukov
7df3885d2e Don't force newlines around URLs in WP_Embed::autoembed(). 
props chipx86, sgrant.
fixes #23776.
Built from https://develop.svn.wordpress.org/trunk@31066


git-svn-id: http://core.svn.wordpress.org/trunk@31047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 07:51:22 +00:00
Sergey Biryukov
6299d3f617 Fix typo in a comment in slashing tests. 
Built from https://develop.svn.wordpress.org/trunk@31065


git-svn-id: http://core.svn.wordpress.org/trunk@31046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 07:09:23 +00:00
Gary Pendergast
c20f6afb05 Options: When updating options, make sure the user isn't trying to insert characters that aren't supported by the database character set. 
See #30361.

Built from https://develop.svn.wordpress.org/trunk@31064


git-svn-id: http://core.svn.wordpress.org/trunk@31045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 04:15:23 +00:00
Drew Jaynes
727999d6fb Add a description for the $data parameter in the DocBlock for the customize_save_response hook introduced in [31062]. 
Props westonruter.
Fixes #29098.

Built from https://develop.svn.wordpress.org/trunk@31063


git-svn-id: http://core.svn.wordpress.org/trunk@31044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-07 01:48:24 +00:00
Dominik Schilling
56981c7143 Customizer: Send JSON success for customize_save and allow response to be filtered. 
props westonruter.
fixes #29098.
Built from https://develop.svn.wordpress.org/trunk@31062


git-svn-id: http://core.svn.wordpress.org/trunk@31043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 21:47:23 +00:00
Dominik Schilling
c6e7a90331 Autoprefixer for [31038]. 
see #30886.
Built from https://develop.svn.wordpress.org/trunk@31061


git-svn-id: http://core.svn.wordpress.org/trunk@31042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 21:44:25 +00:00
Sergey Biryukov
e253251ef4 Remove space before comma in wp_notify_postauthor() and wp_notify_moderator(). 
see #30930.
Built from https://develop.svn.wordpress.org/trunk@31060


git-svn-id: http://core.svn.wordpress.org/trunk@31041 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 17:17:21 +00:00
Sergey Biryukov
71d255fde1 Remove padding from the comment notification emails in wp_notify_moderator(). 
See [30015] for wp_notify_postauthor().

props pavelevap.
fixes #30930.
Built from https://develop.svn.wordpress.org/trunk@31059


git-svn-id: http://core.svn.wordpress.org/trunk@31040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 17:10:35 +00:00
Sergey Biryukov
7685e9dc97 Skip building the query in wp_count_posts() if cached results are used. 
props MikeHansenMe.
fixes #30928.
Built from https://develop.svn.wordpress.org/trunk@31058


git-svn-id: http://core.svn.wordpress.org/trunk@31039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 16:58:26 +00:00
Sergey Biryukov
da5b68a17e Fix 'compare' parameter description in WP_Date_Query. 
props dlh.
fixes #30925.
Built from https://develop.svn.wordpress.org/trunk@31057


git-svn-id: http://core.svn.wordpress.org/trunk@31038 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 03:36:21 +00:00
Sergey Biryukov
c2260dc85b Remove obsolete inline comment. 
props travisnorthcutt.
fixes #30924.
Built from https://develop.svn.wordpress.org/trunk@31056


git-svn-id: http://core.svn.wordpress.org/trunk@31037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 01:57:22 +00:00
Sergey Biryukov
483e7a36d7 Use localized format for Last Updated date on Add Plugins screen. 
props tyxla.
fixes #30717.
Built from https://develop.svn.wordpress.org/trunk@31055


git-svn-id: http://core.svn.wordpress.org/trunk@31036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-06 01:03:23 +00:00
Sergey Biryukov
291de9cac1 Themes: Fix position of admin notice with .notice class. 
fixes #30895.
Built from https://develop.svn.wordpress.org/trunk@31054


git-svn-id: http://core.svn.wordpress.org/trunk@31035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-05 20:06:23 +00:00
Sergey Biryukov
1541bc1537 Pass comment author name and comment ID to 'get_comment_author_link' filter on Edit Comment screen, for consistency with [30092]. 
props tyxla.
fixes #30894.
Built from https://develop.svn.wordpress.org/trunk@31053


git-svn-id: http://core.svn.wordpress.org/trunk@31034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-05 19:10:23 +00:00
Gary Pendergast
e6a74136f9 size_format() incorrectly included a trailing space for B values: less than 1024 bytes. 
Also add a unit test to check for this, so we don't do it again.

Fixes #30908.

Props tillkruess.
 

Built from https://develop.svn.wordpress.org/trunk@31052


git-svn-id: http://core.svn.wordpress.org/trunk@31033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-05 13:13:23 +00:00
Gary Pendergast
0e806f1695 WPDB: To ensure we're not asking MySQL to read data using queries that it can't handle, make sure that we run all read queries through the character set sanity checks. 
See #21212.


Built from https://develop.svn.wordpress.org/trunk@31051


git-svn-id: http://core.svn.wordpress.org/trunk@31032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-05 04:40:22 +00:00
Gary Pendergast
9704ee2a5c WPDB Docs: Update the @since version from 4.1.0 to 4.2.0, for all the methods/members that were punted from 4.1. 
See #21212.


Built from https://develop.svn.wordpress.org/trunk@31050


git-svn-id: http://core.svn.wordpress.org/trunk@31031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-05 03:51:22 +00:00
Dion Hulse
c975c8eeb0 Preinitialize WP_User::$data to an object in the event an empty user object is created. Avoids a "Creating default object from empty value" PHP Warning. 
Fixes #28019

Built from https://develop.svn.wordpress.org/trunk@31049


git-svn-id: http://core.svn.wordpress.org/trunk@31030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-05 01:41:23 +00:00
Sergey Biryukov
05f1506d93 A couple more tweaks to the post-thumbnail-template.php description. 
see #30867.
Built from https://develop.svn.wordpress.org/trunk@31048


git-svn-id: http://core.svn.wordpress.org/trunk@31029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 23:10:21 +00:00
Boone Gorges
28c918e49c Add tests for the 'post_status' behavior of WP_Query. 
See #29167.
Built from https://develop.svn.wordpress.org/trunk@31047


git-svn-id: http://core.svn.wordpress.org/trunk@31028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 20:36:22 +00:00
Boone Gorges
26436a4374 Remove non-built-in post statuses during each unit test teardown. 
See #29167.
Built from https://develop.svn.wordpress.org/trunk@31046


git-svn-id: http://core.svn.wordpress.org/trunk@31027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 20:06:26 +00:00
Scott Taylor
fb454239fb In Media Views, use this.listenTo( this.model, .... ) instead of this.model.on( .... ) to fix garbage collection and to avoid "ghost views." 
Fixes #30896.

Built from https://develop.svn.wordpress.org/trunk@31045


git-svn-id: http://core.svn.wordpress.org/trunk@31026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 05:25:22 +00:00
Scott Taylor
be59efcfbf ImageMagick expects TIFF files to have .tiff as an extension, so the key in wp_get_mime_types() should be 'tiff|tif' not 'tif|tiff' so the proper extension is returned in WP_Image_Editor->get_extension() subclass invocations. 
Fixes #30211.

Built from https://develop.svn.wordpress.org/trunk@31044


git-svn-id: http://core.svn.wordpress.org/trunk@31025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 03:09:22 +00:00
Scott Taylor
a9302b2e36 If IMAGE_EDIT_OVERWRITE is defined as true, ensure that multiple edits to the same image does not result in the file being deleted (updating the meta fails because the old and new paths are identical). 
Props hew.
Fixes #30394.

Built from https://develop.svn.wordpress.org/trunk@31043


git-svn-id: http://core.svn.wordpress.org/trunk@31024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 02:52:24 +00:00
Scott Taylor
f79eb196df Improve the handling of comma-separated mime-types in wp_match_mime_types(), particularly as pertains to the mime-type selector on the Media list table screen. 
Props mdgl.
Fixes #30788.

Built from https://develop.svn.wordpress.org/trunk@31042


git-svn-id: http://core.svn.wordpress.org/trunk@31023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 02:32:22 +00:00
Scott Taylor
ada7442b9e After [31037], ensure that the library is passed as a map to the Media Grid instance. Remove useless query vars. 
Fixes #30584.

Built from https://develop.svn.wordpress.org/trunk@31041


git-svn-id: http://core.svn.wordpress.org/trunk@31022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-04 02:07:23 +00:00
Scott Taylor
de4d970d77 Preserve alpha transparency when rotating a PNG while GD is the active image editor. 
Adds unit tests.

Props frankpw, voldemortensen.
Fixes #30596.

Built from https://develop.svn.wordpress.org/trunk@31040


git-svn-id: http://core.svn.wordpress.org/trunk@31021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 22:02:24 +00:00
Scott Taylor
e678f9d051 In Media Grid, don't immediately load full size images if the requested size passed to wp.media.view.Attachment.imageSize() does not exist, look for other suitable sizes. 
Fixes #30861.

Built from https://develop.svn.wordpress.org/trunk@31039


git-svn-id: http://core.svn.wordpress.org/trunk@31020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 21:32:23 +00:00
Scott Taylor
a5cd4c0493 Fix spacing of .compat-item .field form widgets in media modal. 
Props trepmal.
Fixes #30886.

Built from https://develop.svn.wordpress.org/trunk@31038


git-svn-id: http://core.svn.wordpress.org/trunk@31019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 20:47:23 +00:00
Scott Taylor
c5f9a7c26a Respect query vars for taxonomies passed as URL parameters when in grid mode of Media Library. 
Fixes #30584.

Built from https://develop.svn.wordpress.org/trunk@31037


git-svn-id: http://core.svn.wordpress.org/trunk@31018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 08:24:22 +00:00
Scott Taylor
f5f3006981 Remove whitespace side effects from comment_form(). 
Props timersys.
Fixes #30500.

Built from https://develop.svn.wordpress.org/trunk@31036


git-svn-id: http://core.svn.wordpress.org/trunk@31017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 06:27:24 +00:00
Scott Taylor
190165cb32 Use the 'not_found' label when there are no items for a taxonomy in the terms list table. 
Props SergeyBiryukov.
Fixes #30586.

Built from https://develop.svn.wordpress.org/trunk@31035


git-svn-id: http://core.svn.wordpress.org/trunk@31016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 06:20:21 +00:00
Scott Taylor
af0e5cc851 Inline <script>s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need CDATA comments. 
Props tw2113 for the initial patch.
See #18788.

Built from https://develop.svn.wordpress.org/trunk@31034


git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 05:46:25 +00:00
Scott Taylor
b39c37ff89 After [31030]: if a callable is passed as the 3rd arg to wp_localize_script()/WP_Scripts->localize(), pass $handle and $object_name to the user func when invoking it. 
Props jtsternberg.
Fixes #26111.

Built from https://develop.svn.wordpress.org/trunk@31033


git-svn-id: http://core.svn.wordpress.org/trunk@31014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 05:13:24 +00:00
Scott Taylor
650a6d1062 Add the ability to print data *after* a script, whether it is concatenated or not: 
* Add a third argument to `WP_Scripts->print_extra_script()`, `$key`, which will be passed to `->get_data()` (no longer passes hardcoded `'data'`)
* When `$key` is set to `'data-after'`, the inline script will be printed after the `<script>` tag. If the scripts are being concatenated, all scripts' `'data-after'` data will be printed after the concatenated `<script>` has been rendered.

Props hakre, wonderboymusic.
Fixes #25277.

Built from https://develop.svn.wordpress.org/trunk@31032


git-svn-id: http://core.svn.wordpress.org/trunk@31013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 05:08:24 +00:00
Scott Taylor
f7aef5b69a Ensure that inline styles attached to conditional stylesheets are also conditional. 
Adds unit test.

Props georgestephanis.
Fixes #29180.

Built from https://develop.svn.wordpress.org/trunk@31031


git-svn-id: http://core.svn.wordpress.org/trunk@31012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 04:10:21 +00:00
Scott Taylor
e649887e40 Allow the 3rd argument to wp_localize_script()/WP_Scripts->localize() to be a callable, allowing data to be lazy-loaded when the script is actually enqueued. 
Props jtsternberg.
Fixes #26111.

Built from https://develop.svn.wordpress.org/trunk@31030


git-svn-id: http://core.svn.wordpress.org/trunk@31011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 03:54:22 +00:00
Scott Taylor
618c5b4333 When outputting JS with a Content-Type header: 
`text/javascript` is obsolete, `application/x-javascript` was experimental. `application/javascript` is the recommended type per RFC 4329.

Props sergej.mueller.
Fixes #29196.

Built from https://develop.svn.wordpress.org/trunk@31029


git-svn-id: http://core.svn.wordpress.org/trunk@31010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 02:57:21 +00:00
Scott Taylor
2d7c3eec73 When calling wp_enqueue_script() with a registered $handle, no $src (using the default value, false), and true as the value for $in_footer, ensure that the script actually loads in the footer. If the handle was registered with $in_footer equal to true, this already worked. Make it work for scripts like where $in_footer was initially false, example: wp_enqueue_script( 'json2', false, array(), false, true ); 
Props SergeyBiryukov.
Fixes #14488.

Built from https://develop.svn.wordpress.org/trunk@31028


git-svn-id: http://core.svn.wordpress.org/trunk@31009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 02:41:23 +00:00
Boone Gorges
a374f9f092 Introduce 'category_css_classes' filter. 
Paralleling the 'page_css_classes' filter, this allows developers to modify
the list of CSS classes used when creating category list markup via
`Walker_Category`.

Props sivel.
Fixes #16497.
Built from https://develop.svn.wordpress.org/trunk@31027


git-svn-id: http://core.svn.wordpress.org/trunk@31008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 02:31:22 +00:00
Boone Gorges
cc8f18b698 Add tests for wp_list_categories() CSS class generation. 
See #16497.
Built from https://develop.svn.wordpress.org/trunk@31026


git-svn-id: http://core.svn.wordpress.org/trunk@31007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 02:23:24 +00:00
Boone Gorges
a0d1faa383 In Walker_Category, don't generate list elements for empty cat names. 
This change allows the 'list_cats' filter to be used to suppress certain
items in category lists, without creating invalid or superfluous markup.

Props samo9789.
Fixes #16792.
Built from https://develop.svn.wordpress.org/trunk@31025


git-svn-id: http://core.svn.wordpress.org/trunk@31006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 02:05:22 +00:00
Boone Gorges
1b63ada83d Introduce 'name' parameter for get_terms(). 
This enhancement requires a modification in the way that `wp_dropdown_categories()`
prepares its arguments for `get_terms()`, so that its unrelated 'name' param is
not mistaken for the new 'name' argument in `get_terms()`.

Props danielbachhuber.
Fixes #30611.
Built from https://develop.svn.wordpress.org/trunk@31024


git-svn-id: http://core.svn.wordpress.org/trunk@31005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-02 21:34:23 +00:00
Andrew Ozz
e0189c3686 Move the (recently added) .notice admin notices below the first H2, same as the .updated and .error notices. Props sippis, fixes #30885. 
Built from https://develop.svn.wordpress.org/trunk@31023


git-svn-id: http://core.svn.wordpress.org/trunk@31004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-02 18:52:23 +00:00
Andrew Ozz
fe0bf57deb Fix the background color in the auth. check modal. Props melchoyce, fixes #30278. 
Built from https://develop.svn.wordpress.org/trunk@31022


git-svn-id: http://core.svn.wordpress.org/trunk@31003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-02 17:21:22 +00:00
Boone Gorges
77e635f8fe Add tests for wp_delete_object_term_relationships(). 
See #30879.
Built from https://develop.svn.wordpress.org/trunk@31021


git-svn-id: http://core.svn.wordpress.org/trunk@31002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-02 14:03:26 +00:00
Scott Taylor
aa26b4c1a0 If you set '_wp_page_template' for a post, and then switch to a theme that doesn't support the template, subsequent calls to wp_insert_post() will bail early without running a plethora of hooks. This shouldn't happen. We should set the template to 'default' and continue through the rest of the function. The function will still bail if $wp_error is true via wp_insert_post( $arr, true ). 
Props nofearinc.
Fixes #25334.

Built from https://develop.svn.wordpress.org/trunk@31020


git-svn-id: http://core.svn.wordpress.org/trunk@31001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-01 20:35:30 +00:00
Scott Taylor
5e4941023b WP_List_Table's constructor registers an 'admin_footer' callback when AJAX is enabled. As such, if you create multiple instances of the class, you get multiple JS blobs on the page when the callbacks fire. Extra instances get made when wp_comment_reply() invokes the class constructor without checking for the existing instance via the $wp_list_table global. 
We shall check the `$wp_list_table` global in `wp_comment_reply()`.

Props sorich87.
Fixes #17413.

Built from https://develop.svn.wordpress.org/trunk@31019


git-svn-id: http://core.svn.wordpress.org/trunk@31000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-01 19:55:35 +00:00
Scott Taylor
a5593a64d3 More-specific docs for wp_embed_handler_youtube(). 
Fixes #30711.

Built from https://develop.svn.wordpress.org/trunk@31018


git-svn-id: http://core.svn.wordpress.org/trunk@30999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-01 19:21:27 +00:00
Sergey Biryukov
f3ef425b11 Update license copyright year to 2015. 
props valendesigns.
fixes #30877.
Built from https://develop.svn.wordpress.org/trunk@31017


git-svn-id: http://core.svn.wordpress.org/trunk@30998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-01 12:25:26 +00:00
Scott Taylor
952a5c9971 Support chromeless Vimeo via MEjs: 
* Bump MediaElement script loader versions to 2.16.2 - missed in [30634], oops!
* Add `Froogaloop` to `js/mediaelement` scripts for Vimeo
* Check for Vimeo in the same locations that YouTube is checked
* Dynamically load Froogaloop script in admin when editing a TinyMCE view
* Edit MediaElement to call `mejs.$.extend` instead of `$.extend` in `mejs.HtmlMediaElementShim.createPlugin()`, since `$` is not available via WP's jQuery (I will report this upstream):
6f9a78e008/src/js/me-shim.js (L631)

Fixes #29267.

Built from https://develop.svn.wordpress.org/trunk@31016


git-svn-id: http://core.svn.wordpress.org/trunk@30997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 20:41:24 +00:00
Boone Gorges
f1a4fd6e85 Support array values for post-related parameters in WP_Comment_Query. 
Props nprasath002, c3mdigital, ianmjones.
Fixes #20006.
Built from https://develop.svn.wordpress.org/trunk@31015


git-svn-id: http://core.svn.wordpress.org/trunk@30996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 19:38:22 +00:00
Boone Gorges
36f36dca77 In remove_all_filters(), only remove callbacks that match the $priority parameter. 
Props GeertDD, valendesigns.
Fixes #20920.
Built from https://develop.svn.wordpress.org/trunk@31014


git-svn-id: http://core.svn.wordpress.org/trunk@30995 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 19:07:24 +00:00
Scott Taylor
586c1ac7bc Fix docs for WP_User::allcaps: 
The `allcaps` property of the `WP_User` class represents all of the caps of the user, not the caps of the user's role. Introduced in [26126].

Props dlh.
Fixes #30852.

Built from https://develop.svn.wordpress.org/trunk@31013


git-svn-id: http://core.svn.wordpress.org/trunk@30994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 18:15:23 +00:00
Scott Taylor
96558ac3c3 Update/fix inline docs for update_object_term_cache(). 
Props DrewAPicture.
Fixes #30731.

Built from https://develop.svn.wordpress.org/trunk@31012


git-svn-id: http://core.svn.wordpress.org/trunk@30993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 18:12:26 +00:00
Scott Taylor
7f94333084 Correct a typo in wp-includes/post-thumbnail-template.php. 
Props ixkaito.
Fixes #30867.

Built from https://develop.svn.wordpress.org/trunk@31011


git-svn-id: http://core.svn.wordpress.org/trunk@30992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 18:09:25 +00:00
Aaron Jorbin
7ea306dd9d Set the type attribute of the buttons for logging out of all sessions to buttons 
By not setting this attribute, the buttons default to submit and as the first
submit button on the page, it causes pressing the enter key to log you out of
all sessions. This change restores the pre 4.1 behavior where pressing enter
while focused on a form field submits the form.

props ocean90
fixes #30871 for trunk


Built from https://develop.svn.wordpress.org/trunk@31010


git-svn-id: http://core.svn.wordpress.org/trunk@30991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 17:33:24 +00:00
Boone Gorges
a170302b36 Back up and restore dropins during get_dropins() tests. 
This change ensures that the `get_dropins()` tests don't detect any actual
dropins that you might be running on your develop.wordpress installation.

Props valendesigns.
Fixes #30860.
Built from https://develop.svn.wordpress.org/trunk@31009


git-svn-id: http://core.svn.wordpress.org/trunk@30990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 15:01:22 +00:00
Andrew Nacin
bc60e63518 Use correct function name in docs for get_plugin_data(). 
props eliorivero.
fixes #30699.

Built from https://develop.svn.wordpress.org/trunk@31008


git-svn-id: http://core.svn.wordpress.org/trunk@30989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 08:08:22 +00:00
Dion Hulse
e165f2caec Add a revision number to $wp_version for nightly update purposes. See [30411] 
Built from https://develop.svn.wordpress.org/trunk@31007


git-svn-id: http://core.svn.wordpress.org/trunk@30988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-31 05:35:22 +00:00
Andrew Nacin
fc1931e7e8 Trunk is now 4.2 alpha. 
Built from https://develop.svn.wordpress.org/trunk@30800


git-svn-id: http://core.svn.wordpress.org/trunk@30790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-10 08:44:22 +00:00
Drew Jaynes
d72fac0131 Twenty Fifteen: Replace encoded HTML entities in the file header DocBlock for header.php with 'head element'. 
Props iamtakashi.
Fixes #30649.

Built from https://develop.svn.wordpress.org/trunk@30798


git-svn-id: http://core.svn.wordpress.org/trunk@30788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-10 03:02:23 +00:00
Dominik Schilling
2428fce4ed Dashicons: Update to the latest files. 
New icons:
* .dashicons-controls-play (f522)
* .dashicons-controls-pause (f523)
* .dashicons-controls-forward (f519)
* .dashicons-controls-skipforward (f517)
* .dashicons-controls-back (f518)
* .dashicons-controls-skipback (f516)
* .dashicons-controls-repeat (f515)
* .dashicons-controls-volumeon (f521)
* .dashicons-controls-volumeoff (f520)
* .dashicons-phone (f525)
* .dashicons-building (f512)
* .dashicons-store (f513)
* .dashicons-album (f514)
* .dashicons-palmtree (f527)
* .dashicons-tickets-alt (f524)
* .dashicons-money (f526)

Updated icons:
* .dashicons-align-left (f135)
* .dashicons-align-right (f136)
* .dashicons-align-center (f134)
* .dashicons-align-none (f138)

props liljimmi, melchoyce, empireoflight.
fixes #29444.
Built from https://develop.svn.wordpress.org/trunk@30797


git-svn-id: http://core.svn.wordpress.org/trunk@30787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-09 19:34:23 +00:00
John Blackbourn
64fb3e7175 In Twenty Fourteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised. 
See #30641

Built from https://develop.svn.wordpress.org/trunk@30796


git-svn-id: http://core.svn.wordpress.org/trunk@30786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-09 18:57:24 +00:00
John Blackbourn
e9f7c78d38 In Twenty Thirteen, move the "Continue Reading" arrows back inside the translatable strings so they can be localised. 
See #30641

Built from https://develop.svn.wordpress.org/trunk@30795


git-svn-id: http://core.svn.wordpress.org/trunk@30785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-09 18:56:22 +00:00
Dominik Schilling
18349e84cf Remove a stray $ from [30793]. 
props ipm-frommen.
see #30553.
Built from https://develop.svn.wordpress.org/trunk@30794


git-svn-id: http://core.svn.wordpress.org/trunk@30784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-09 11:27:22 +00:00
Dominik Schilling
332e0a7f82 Themes: Use Customizer deep-links inside the theme modal. 
props DrewAPicture, ocean90.
see #25569, #25571.
fixes #30553.
Built from https://develop.svn.wordpress.org/trunk@30793


git-svn-id: http://core.svn.wordpress.org/trunk@30783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 22:23:23 +00:00
Dominik Schilling
93078d7d9f Fix JSHint error introduced in [30780]. 
see #30608.
Built from https://develop.svn.wordpress.org/trunk@30792


git-svn-id: http://core.svn.wordpress.org/trunk@30782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 22:07:24 +00:00
Sergey Biryukov
0ef8e683f2 Revert [28948], which caused a regression. 
see #29573 for trunk. see #28350.
Built from https://develop.svn.wordpress.org/trunk@30791


git-svn-id: http://core.svn.wordpress.org/trunk@30781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 21:14:23 +00:00
Ian Stewart
aa9fa42f91 Twenty Fifteen: moving to a single line for tranlator comments to prevent them being missed in i18n tools. 
Props netweb, DrewAPicture, fixes #30603.


Built from https://develop.svn.wordpress.org/trunk@30790


git-svn-id: http://core.svn.wordpress.org/trunk@30780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 18:25:22 +00:00
Ian Stewart
3ec55886cd Twenty Fifteen: layout correction for IE8 and IE7 after r30388 introduced a defect with the header there. 
Props iamtakashi, fixes #30630.


Built from https://develop.svn.wordpress.org/trunk@30789


git-svn-id: http://core.svn.wordpress.org/trunk@30779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 17:46:23 +00:00
Sergey Biryukov
b2185048c6 Move the logic from WP_Image_Editor::get_quality() to WP_Image_Editor::set_quality(), so that 'wp_editor_set_quality' and 'jpeg_quality' filters run when setting the default value. 
props markoheijnen.
fixes #29856.
Built from https://develop.svn.wordpress.org/trunk@30788


git-svn-id: http://core.svn.wordpress.org/trunk@30778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 16:19:23 +00:00
John Blackbourn
fbb5c1f1f5 Improve the doing_it_wrong() text for title-tag theme support. 
Props ocean90
Fixes #18548

Built from https://develop.svn.wordpress.org/trunk@30787


git-svn-id: http://core.svn.wordpress.org/trunk@30777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 16:06:26 +00:00
Jeremy Felt
210b51552c Clean up factory arguments in ms-sites group. 
* Arguments for user, path, and title are only necessary when we need to do something with those arguments later. Most cases in the ms-sites group do not require them.
* In `test_get_blog_id_from_url_is_case_insensitive()`, we should pass a lowercase domain argument.
* A user factory in `test_switch_restore_blog()` is not necessary.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30786


git-svn-id: http://core.svn.wordpress.org/trunk@30776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 02:33:22 +00:00
Jeremy Felt
1e6c83c130 Split current tests for update_blog_status() 
The current tests for `update_blog_status()` mirrored the tests for `update_blog_details()` in many ways and can be split in the same way. A noticeable difference is that the the matching actions fire even when no change is made to a field.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30785


git-svn-id: http://core.svn.wordpress.org/trunk@30775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 02:15:22 +00:00
Jeremy Felt
96bb2247b6 Split current tests for update_blog_details() 
The current tests for `upload_blog_details()` were focused on the actions fired whenever a site is marked as spam, archived, deleted, or matured. This breaks those into individual sections with fewer assertions per test.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30784


git-svn-id: http://core.svn.wordpress.org/trunk@30774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-08 01:44:22 +00:00
Scott Taylor
a702c60e9d Incorporate https://github.com/johndyer/mediaelement/pull/1385 into our custom build of MediaElement 2.16.2. 
Props bradyvercher.
Fixes #30281.

Built from https://develop.svn.wordpress.org/trunk@30783


git-svn-id: http://core.svn.wordpress.org/trunk@30773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 23:59:23 +00:00
Andrew Ozz
a445806c6f Plugins: move the recommender results to a separate tab. Any outstanding quality issues will be fixed on the API side without needing core changes. Props tellyworth, fixes #30337. 
Built from https://develop.svn.wordpress.org/trunk@30782


git-svn-id: http://core.svn.wordpress.org/trunk@30772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 23:40:24 +00:00
Andrew Ozz
7f0526ad08 Twenty Fifteen: add spaces after screen reader text strings to make them readable. Props nvwd, pavelevap, afercia. Fixes #30606. 
Built from https://develop.svn.wordpress.org/trunk@30781


git-svn-id: http://core.svn.wordpress.org/trunk@30771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 23:28:21 +00:00
Andrew Ozz
31990810f4 Media: ensure the toolbar is shown after leaving iframe-based content. Props mcsf, fixes #30608. 
Built from https://develop.svn.wordpress.org/trunk@30780


git-svn-id: http://core.svn.wordpress.org/trunk@30770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 21:12:21 +00:00
Drew Jaynes
24090d065a Fix formatting in the DocBlock for wp_get_sidebars_widgets(). 
See #30315.

Built from https://develop.svn.wordpress.org/trunk@30779


git-svn-id: http://core.svn.wordpress.org/trunk@30769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 20:15:26 +00:00
Drew Jaynes
16e46b2a1e Flesh out and fix formatting in the DocBlock for wp_register_widget_control(). 
Includes:
* Added todos for documenting `$options` in the hash notation style
* Backtick-escaping and general formatting

See #30315.

Built from https://develop.svn.wordpress.org/trunk@30778


git-svn-id: http://core.svn.wordpress.org/trunk@30768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 20:13:23 +00:00
Scott Taylor
845e8ab23d When using the spacebar to select something in "bulk select" mode, don't scroll the page. 
Props avryl.
Fixes #30622.

Built from https://develop.svn.wordpress.org/trunk@30777


git-svn-id: http://core.svn.wordpress.org/trunk@30767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 20:11:43 +00:00
Drew Jaynes
cc4d102260 Flesh out information in the DocBlock for wp_register_sidebar_widget(). 
Includes:
* Documenting the `$options` parameter in hash notation style
* Converting `@uses` tags to `@global`
* Various backtick-escaping.

See #30315.

Built from https://develop.svn.wordpress.org/trunk@30776


git-svn-id: http://core.svn.wordpress.org/trunk@30766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 20:11:22 +00:00
Andrew Ozz
498c5d719c TinyMCE: return focus to the editor after closing the image toolbar. Props afercia, see #27642. 
Built from https://develop.svn.wordpress.org/trunk@30775


git-svn-id: http://core.svn.wordpress.org/trunk@30765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 20:08:42 +00:00
Drew Jaynes
1f8f2e5ba1 Introduce documentation for three methods in WP_Widget_Factory: register(), unregister(), _register_widgets(). 
See #30315.

Built from https://develop.svn.wordpress.org/trunk@30774


git-svn-id: http://core.svn.wordpress.org/trunk@30764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 20:08:21 +00:00
Drew Jaynes
25a65d856b Introduce documentation for the $id_base, $name, $widget_options, $control_options, $number, $id, and $updated properties in `WP_Widget'. 
See #30315.

Built from https://develop.svn.wordpress.org/trunk@30773


git-svn-id: http://core.svn.wordpress.org/trunk@30763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 20:05:22 +00:00
Drew Jaynes
ced94748fa Tweak formatting in the DocBlock for the install_themes_tabs hook. 
Props kpdesign.
See #28578.

Built from https://develop.svn.wordpress.org/trunk@30772


git-svn-id: http://core.svn.wordpress.org/trunk@30762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 18:41:21 +00:00
Boone Gorges
7e69e5484f In WP_Query::get_queried_object(), use the new format for referencing tax query clauses. 
`queried_terms`, rather than `queries`, is the tax_query property where a flat
index of terms is stored.

See [29901] for a similar fix in `redirect_canonical()`. See #29738.

Props dd32.
Fixes #30623.
Built from https://develop.svn.wordpress.org/trunk@30771


git-svn-id: http://core.svn.wordpress.org/trunk@30761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 14:58:22 +00:00
Drew Jaynes
8b83a73511 Document the default arguments for the_widget() in the hash notation style. 
Props coffee2code.
See #28298.

Built from https://develop.svn.wordpress.org/trunk@30770


git-svn-id: http://core.svn.wordpress.org/trunk@30760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 11:04:23 +00:00
Drew Jaynes
2a9c5910c6 Document the default arguments for register_sidebars() in the hash notation style. 
Props coffee2code.
See #28298.

Built from https://develop.svn.wordpress.org/trunk@30769


git-svn-id: http://core.svn.wordpress.org/trunk@30759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 11:01:25 +00:00
Drew Jaynes
7c01a454ce Improve inline documentation for wpdb::has_cap(). 
Adds a changelog entry for the addition of the 'utf8mb4' feature, accepted values for `$db_cap`, and a return description.

Props kpdesign.
See #21212.

Built from https://develop.svn.wordpress.org/trunk@30768


git-svn-id: http://core.svn.wordpress.org/trunk@30758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 05:23:22 +00:00
Drew Jaynes
0cbaa88027 Fix a typo in the DocBlock for WP_Http_Curl::$bytes_written_total introduced in [29968]. 
Props kpdesign.
See #26726.

Built from https://develop.svn.wordpress.org/trunk@30767


git-svn-id: http://core.svn.wordpress.org/trunk@30757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 05:16:24 +00:00
Dion Hulse
e0ac8c0386 In the links_add_base() callback, use a HTTP-aware URL joining function, rather than a filesystem joining function to avoid PHP warnings on certain systems. 
Fixes #29950

Built from https://develop.svn.wordpress.org/trunk@30766


git-svn-id: http://core.svn.wordpress.org/trunk@30756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 03:19:23 +00:00
Dion Hulse
26b85eb9b3 WP_HTTP: Revert r30491 which updated the bundled root certificates. There's a report that this is breaking under certain PHP/OpenSSL versions (which we've encountered before), and we're safer with a slighty out of date CA bundle than breaking HTTPS communication on affected sites. 
See #30434

Built from https://develop.svn.wordpress.org/trunk@30765


git-svn-id: http://core.svn.wordpress.org/trunk@30755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 03:13:22 +00:00
Andrew Ozz
1e9f5755aa Admin toolbar: remove unneeded overrides of z-index and left on screens narrower than 782px. Props avryl, babbardel. Fixes #29867. 
Built from https://develop.svn.wordpress.org/trunk@30764


git-svn-id: http://core.svn.wordpress.org/trunk@30754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 03:01:24 +00:00
Andrew Ozz
adf4f440f5 Twenty Fifteen: clean up of twentyfifteen_color_scheme_css_template() in customizer.php. Props iamtakashi. Fixes #30601. 
Built from https://develop.svn.wordpress.org/trunk@30763


git-svn-id: http://core.svn.wordpress.org/trunk@30753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 02:40:21 +00:00
Andrew Ozz
ef0501e1bc Better docs for Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props DrewAPicture. Fixes #29088. 
Built from https://develop.svn.wordpress.org/trunk@30762


git-svn-id: http://core.svn.wordpress.org/trunk@30752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 01:19:24 +00:00
Andrew Ozz
1bb4b6a82b Always return a value in Plugin_Upgrader::deactivate_plugin_before_upgrade(). Props jdgrimes. Fixes #29088. 
Built from https://develop.svn.wordpress.org/trunk@30761


git-svn-id: http://core.svn.wordpress.org/trunk@30751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 00:53:23 +00:00
Andrew Ozz
53d22ffb10 Customizer - Widgets: add feedback for screen readers when moving up or down. Props adamsilverstein, afercia. Fixes #28892. 
Built from https://develop.svn.wordpress.org/trunk@30760


git-svn-id: http://core.svn.wordpress.org/trunk@30750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 00:45:24 +00:00
Drew Jaynes
337dfe7111 Restore missing line in DocBlock for WP_Tax_Query::get_sql_for_clause(). 
Props kpdesign.
See [30622], #30469.

Built from https://develop.svn.wordpress.org/trunk@30759


git-svn-id: http://core.svn.wordpress.org/trunk@30749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 00:39:24 +00:00
Drew Jaynes
473ebca2af Add missing DocBlocks and parameter descriptions for a wide variety of properties and methods in WP_Upgrader, Plugin_Upgrader, Theme_Upgrader, Language_Pack_Upgrader, Core_Upgrader, and File_upload_Upgrader. 
Props jdgrimes, DrewAPicture.

See #29086.

Built from https://develop.svn.wordpress.org/trunk@30758


git-svn-id: http://core.svn.wordpress.org/trunk@30748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-07 00:26:22 +00:00
Andrew Ozz
efe8fd4694 TinyMCE, improve accessibility: 
- Return focus to the editor on pressing Escape while the image toolbar is focused.
- Add a Close button to the Help modal and close it on Escape.
- Override the title on the editor iframe (read by screen reader apps), replace with the Alt+Shift+H shortcut.
- Add focus shortcuts descriptions to the Help modal.
Fixes #27642.
Built from https://develop.svn.wordpress.org/trunk@30757


git-svn-id: http://core.svn.wordpress.org/trunk@30747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 23:53:22 +00:00
Drew Jaynes
bb27a3c53a Add a blank line preceding a Markdown-formatted ordered list in the DocBlock for the admin_body_class filter. 
Props kpdesign.
See #30558.

Built from https://develop.svn.wordpress.org/trunk@30756


git-svn-id: http://core.svn.wordpress.org/trunk@30746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 23:21:24 +00:00
Drew Jaynes
cc4ac906dc Fix a typo in the return description for get_sample_permalink(). 
Props TobiasBg.
Fixes #30591.

Built from https://develop.svn.wordpress.org/trunk@30755


git-svn-id: http://core.svn.wordpress.org/trunk@30745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:46:23 +00:00
John Blackbourn
bdd00b3902 Improve various hook and filter docs so they are correctly parsed for the code reference. 
Fixes #30558
Props DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30754


git-svn-id: http://core.svn.wordpress.org/trunk@30744 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:32:24 +00:00
Drew Jaynes
23707b1ada Convert various uses of (optional) in core parameter descriptions to use the style prescribed in the inline documentation standards for PHP. 
The style for marking parameters optional in inline PHP docs is: `@param type $var Optional. Description. Accepts. Default.`, where Accepts can be omitted on a case-by-case basis.

Props coffee2code.
Fixes #30591.

Built from https://develop.svn.wordpress.org/trunk@30753


git-svn-id: http://core.svn.wordpress.org/trunk@30743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:24:45 +00:00
Mark Jaquith
14b0899e57 Revert [28719] and no longer math-process multiplication of negative numbers 
see #19308
fixes #30445
props rmccue
Built from https://develop.svn.wordpress.org/trunk@30752


git-svn-id: http://core.svn.wordpress.org/trunk@30742 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 21:24:23 +00:00
Boone Gorges
bc35a81482 Remove <code> tags from translatable string in WP_Date_Query. 
This was missed in [30300]. See #25834.

Props ramiy.
Fixes #30612.
Built from https://develop.svn.wordpress.org/trunk@30751


git-svn-id: http://core.svn.wordpress.org/trunk@30741 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 02:38:22 +00:00
Boone Gorges
44116d4b72 Use wp_checkdate() when checking date validity in WP_Date_Query. 
See #25834.
Built from https://develop.svn.wordpress.org/trunk@30750


git-svn-id: http://core.svn.wordpress.org/trunk@30740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 02:29:24 +00:00
Andrew Ozz
79eb593440 Editor DFW v2: fade out the Screen Options/Help tabs when open. Props avryl, fixes #30593. 
Built from https://develop.svn.wordpress.org/trunk@30749


git-svn-id: http://core.svn.wordpress.org/trunk@30739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 00:50:22 +00:00
Andrew Ozz
91b8617f29 TinyMCE: manually fire ExecCommand when aligning images as we do preventDefault() on BeforeExecCommand for them. Props avryl, fixes #30565. 
Built from https://develop.svn.wordpress.org/trunk@30748


git-svn-id: http://core.svn.wordpress.org/trunk@30738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 00:33:24 +00:00
Andrew Ozz
3826c2de6a Themes screen: fix the position of the search field. Props jesin, fixes #29556. 
Built from https://develop.svn.wordpress.org/trunk@30747


git-svn-id: http://core.svn.wordpress.org/trunk@30737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-06 00:13:23 +00:00
Andrew Ozz
1ce44564aa Twenty Twelve: menu on touch devices: fix jQuery selector for menu items with submenus. props babbardel, fixes #24767. 
Built from https://develop.svn.wordpress.org/trunk@30746


git-svn-id: http://core.svn.wordpress.org/trunk@30736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-05 22:59:23 +00:00
Drew Jaynes
0c7e70604d Document the default arguments for register_sidebar() in the hash notation style. 
Props coffee2code.
See #28298.

Built from https://develop.svn.wordpress.org/trunk@30745


git-svn-id: http://core.svn.wordpress.org/trunk@30735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-05 03:38:22 +00:00
Drew Jaynes
13dab23d23 Add missing documentation for the xmlrpc_element_limit hook in wp-includes/class-IXR.php. 
Props ankitgadertcampcom, kpdesign.
Fixes #29977.

Built from https://develop.svn.wordpress.org/trunk@30744


git-svn-id: http://core.svn.wordpress.org/trunk@30734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-05 03:28:22 +00:00
Andrew Ozz
0a199ff4a8 Editor: fix initial state for editor-expand when TinyMCE is disabled or not supported. Props avryl, fixes #30592. 
Built from https://develop.svn.wordpress.org/trunk@30743


git-svn-id: http://core.svn.wordpress.org/trunk@30733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-05 01:53:22 +00:00
Andrew Nacin
1cf7a49ffd Adjust [29806] and revert [29807] to restore placeholder and email copy order. 
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.

fixes #21089.

Built from https://develop.svn.wordpress.org/trunk@30742


git-svn-id: http://core.svn.wordpress.org/trunk@30732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-05 01:15:26 +00:00
Ian Stewart
a83fdf7b17 Twenty Fifteen: updating customizer label text for more clarity. 
Props iamtakashi, fixes #30545.


Built from https://develop.svn.wordpress.org/trunk@30741


git-svn-id: http://core.svn.wordpress.org/trunk@30731 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 22:57:22 +00:00
Helen Hou-Sandí
f5efcf295b Filter bar: Better field display on smaller screens. 
props TacoVerdo, jesin.
fixes #29556 and #29495.

Built from https://develop.svn.wordpress.org/trunk@30740


git-svn-id: http://core.svn.wordpress.org/trunk@30730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 22:23:25 +00:00
John Blackbourn
543f408098 Correct the default value of the show_split_view argument for revisions so they are correctly displayed side by side ins 
tead of inline.

Fixes #24908

Built from https://develop.svn.wordpress.org/trunk@30739


git-svn-id: http://core.svn.wordpress.org/trunk@30729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 14:36:24 +00:00
Scott Taylor
097e4ede58 Add some inline JS docs for Customizer. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30738


git-svn-id: http://core.svn.wordpress.org/trunk@30728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 02:04:22 +00:00
Scott Taylor
82188f74aa Show title, album, and artist info for audio files displayed in WP_Customize_Upload_Control(). 
See #21483.

Built from https://develop.svn.wordpress.org/trunk@30737


git-svn-id: http://core.svn.wordpress.org/trunk@30727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 01:59:22 +00:00
Scott Taylor
8b1b1a10ed Monkey-patch MediaElement to restore H264 support to Chromium. 
Documented here:
https://core.trac.wordpress.org/ticket/30281#comment:9

See #30281.

Built from https://develop.svn.wordpress.org/trunk@30736


git-svn-id: http://core.svn.wordpress.org/trunk@30726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 00:59:23 +00:00
Scott Taylor
48620242c4 Give up on making uninterrupted hierarchies work in get_page_children() for now, reverts [30159], [30246], [30636]. 
Props boonebgorges.
See #14477.

Built from https://develop.svn.wordpress.org/trunk@30735


git-svn-id: http://core.svn.wordpress.org/trunk@30725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-04 00:24:22 +00:00
Andrew Ozz
1bb20da03b Update better description of the Screen Options checkbox for DFW v2 and editor-expand. Props johnbillion, kpdesign, fixes #30557. 
Built from https://develop.svn.wordpress.org/trunk@30734


git-svn-id: http://core.svn.wordpress.org/trunk@30724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 22:00:29 +00:00
Andrew Ozz
f1385e4031 TinyMCE: remove <address> from the block formats drop-down. Props avryl, mor10. Fixes #30132. 
Built from https://develop.svn.wordpress.org/trunk@30733


git-svn-id: http://core.svn.wordpress.org/trunk@30723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 20:31:24 +00:00
Ian Stewart
f5697a4d62 Twenty Fifteen: updating one point oh version number in .pot. 
Props ocean90, see #30502.


Built from https://develop.svn.wordpress.org/trunk@30732


git-svn-id: http://core.svn.wordpress.org/trunk@30722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 18:32:22 +00:00
Ian Stewart
771c7e1954 Twenty Fifteen: updating everything to one point oh. 
See #30502.


Built from https://develop.svn.wordpress.org/trunk@30731


git-svn-id: http://core.svn.wordpress.org/trunk@30721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 18:24:24 +00:00
Andrew Ozz
5299e95360 Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458. 
Built from https://develop.svn.wordpress.org/trunk@30730


git-svn-id: http://core.svn.wordpress.org/trunk@30720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 18:18:23 +00:00
Ian Stewart
b6ddf3ab5d Twenty Fifteen: It's about time we call it one point oh. 
Closes #30502.


Built from https://develop.svn.wordpress.org/trunk@30729


git-svn-id: http://core.svn.wordpress.org/trunk@30719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 18:08:23 +00:00
Ian Stewart
20ea28b289 Twenty Fifteen: removing unused styles. 
Props iamtakashi, fixes #30578.


Built from https://develop.svn.wordpress.org/trunk@30728


git-svn-id: http://core.svn.wordpress.org/trunk@30718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 18:03:23 +00:00
Sergey Biryukov
1f64435284 Fix a typo in [30546]. 
see #30473.
Built from https://develop.svn.wordpress.org/trunk@30727


git-svn-id: http://core.svn.wordpress.org/trunk@30717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 13:55:24 +00:00
Drew Jaynes
ad1ecf88c5 Only backtick-escape individual HTML entities in the DocBlock for wp_kses_normalize_entities(). 
Props TobiasBg.
Fixes #30473.

Built from https://develop.svn.wordpress.org/trunk@30726


git-svn-id: http://core.svn.wordpress.org/trunk@30716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 11:47:23 +00:00
Drew Jaynes
ad1f226c35 Improve formatting of inline documentation for get_pages(). 
Adds missing default values, corrects several argument types, backtick-escapes argument names used in descriptions.

See #28298.

Built from https://develop.svn.wordpress.org/trunk@30725


git-svn-id: http://core.svn.wordpress.org/trunk@30715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 10:31:23 +00:00
Drew Jaynes
27297bcddf Use the correct hash notation syntax for the wp_insert_term() DocBlock. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@30724


git-svn-id: http://core.svn.wordpress.org/trunk@30714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 10:17:24 +00:00
Drew Jaynes
68ed7af808 Use the correct hash notation syntax for the get_pages() DocBlock. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@30723


git-svn-id: http://core.svn.wordpress.org/trunk@30713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 10:16:23 +00:00
Drew Jaynes
8df7115760 Use the correct hash notation syntax for the WP_Filesystem_Base::dirlist() DocBlock. 
See #28298.

Built from https://develop.svn.wordpress.org/trunk@30722


git-svn-id: http://core.svn.wordpress.org/trunk@30712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 10:11:22 +00:00
Drew Jaynes
3d77f9a816 Remove some now-unnecessary double quotes around HTML entities used in DocBlock comments. 
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30721


git-svn-id: http://core.svn.wordpress.org/trunk@30711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 08:49:23 +00:00
Drew Jaynes
8e5543da53 Backtick-escape three sets of HTML entities used in DocBlock descriptions in wp-includes/kses.php. 
Without the escaping, the Code Reference/browser may inadvertently attempt to convert and display entities.

Fixes #30473.

Built from https://develop.svn.wordpress.org/trunk@30720


git-svn-id: http://core.svn.wordpress.org/trunk@30710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 08:47:22 +00:00
Jeremy Felt
31fa5cd4bc Split tests for get_blog_id_from_url() 
Breaks the many assertions for `get_blog_id_from_url()` into individual tests.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30719


git-svn-id: http://core.svn.wordpress.org/trunk@30709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-03 05:52:23 +00:00
Andrew Ozz
04c2e80c03 Update the description of the Screen Options checkbox for turning editor-expand on/off to include DFW v2. Props kpdesign, fixes #30557. 
Built from https://develop.svn.wordpress.org/trunk@30718


git-svn-id: http://core.svn.wordpress.org/trunk@30708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 23:23:23 +00:00
Andrew Ozz
71d0c1c977 Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458. 
Built from https://develop.svn.wordpress.org/trunk@30717


git-svn-id: http://core.svn.wordpress.org/trunk@30707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 23:11:24 +00:00
Dominik Schilling
858a51273a Customizer: Move private helper functions to wp.customize.utils so they can be unit tested. 
Includes unit tests.

props ryankienstra, westonruter.
see #28709.
Built from https://develop.svn.wordpress.org/trunk@30716


git-svn-id: http://core.svn.wordpress.org/trunk@30706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 22:56:45 +00:00
Jeremy Felt
2c25a4947f Split and improve multisite tests for upload quota 
Break a single test with many assertions into many tests with single assertions.

In the process, provide separate and comprehensive tests for `upload_is_user_over_quota()`, `is_upload_space_available()`, and `get_space_allowed()`.

Also removes a check for `BLOGSUPLOADDIR`, a constant that never existed. New tests will need to be introduced to handle the ms-files group.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30715


git-svn-id: http://core.svn.wordpress.org/trunk@30705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 22:56:22 +00:00
Dominik Schilling
0826f8ede2 Customizer: Add panel/section type as CSS class to the HTML container. 
see #28709.
Built from https://develop.svn.wordpress.org/trunk@30714


git-svn-id: http://core.svn.wordpress.org/trunk@30704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 22:16:23 +00:00
Dominik Schilling
c2d9591122 Toolbar: Make Customize support classes work on narrow viewports too. 
fixes #30571.
Built from https://develop.svn.wordpress.org/trunk@30713


git-svn-id: http://core.svn.wordpress.org/trunk@30703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 22:01:26 +00:00
Dominik Schilling
3db8b08686 Customizer: Enhance Background Image/Upload controls. 
* Adopt the Header Image layout to the Background Image/Upload control.
* Remove templates for interactive audio/video previews. They haven't worked yet.
* Don't show a "Remove" button when the default value is set.
* Avoid calculating of container/placeholder heights which are unrelated to custom headers.

see #21483.
Built from https://develop.svn.wordpress.org/trunk@30712


git-svn-id: http://core.svn.wordpress.org/trunk@30702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 21:55:23 +00:00
Andrew Ozz
f1dcfa9712 Editor: hide the DFW v2 button when editor-expand is off. Fixes #30568. 
Built from https://develop.svn.wordpress.org/trunk@30711


git-svn-id: http://core.svn.wordpress.org/trunk@30701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 20:40:22 +00:00
Andrew Ozz
ab2c480d86 Editor, DFW v2: use a 2D transform to force repaint of the admin toolbar, only on #wp-toolbar. Fixes calculating the position of the right sidebar on fade-in and removes any performance and stacking implications. 
Props joemcgill, see #30516.
Built from https://develop.svn.wordpress.org/trunk@30710


git-svn-id: http://core.svn.wordpress.org/trunk@30700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 20:25:24 +00:00
Ian Stewart
1cb6721c81 Twenty Fifteen: removing unused styles inherited from Twenty Fourteen. 
Props iamtakashi, fixes #30572.


Built from https://develop.svn.wordpress.org/trunk@30709


git-svn-id: http://core.svn.wordpress.org/trunk@30699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 16:05:22 +00:00
John Blackbourn
d58c44dc00 Apply a no-op CSS transformation to the admin toolbar (among other elements) in order to trigger hardware acceleration when focus/DFW deactivates. This helps prevent rendering issues seen in browsers on Retina devices. 
See #30516
Props joemcgill

Built from https://develop.svn.wordpress.org/trunk@30708


git-svn-id: http://core.svn.wordpress.org/trunk@30698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 14:18:27 +00:00
John Blackbourn
e96e165c3a Prevent scrolling beneath modals on mobile devices by removing overflow from #wpwrap when a modal is open. 
Fixes #29909
Props avryl

Built from https://develop.svn.wordpress.org/trunk@30707


git-svn-id: http://core.svn.wordpress.org/trunk@30697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 08:09:25 +00:00
John Blackbourn
a5fa87325b Don't fix the position of the admin toolbar submenus when the viewport is below 600px. This avoids them becoming detached from the admin toolbar when scrolling. 
Fixes #29905
Props avryl

Built from https://develop.svn.wordpress.org/trunk@30706


git-svn-id: http://core.svn.wordpress.org/trunk@30696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 06:49:22 +00:00
John Blackbourn
9b9424aa77 Admin help text changes for the General Settings screen, post editing screen, network settings screen, and user editing screen. 
Fixes #30547
Props kpdesign

Built from https://develop.svn.wordpress.org/trunk@30705


git-svn-id: http://core.svn.wordpress.org/trunk@30695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 05:15:23 +00:00
Gary Pendergast
6501c3c217 Unit Tests: The test_set_allowed_incompatible_sql_mode() test tries to set the NO_ZERO_DATE sql mode, which was removed in MySQL 5.7. This causes the test to incorrectly fail when run against MySQL 5.7. 
Built from https://develop.svn.wordpress.org/trunk@30704


git-svn-id: http://core.svn.wordpress.org/trunk@30694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 05:12:23 +00:00
Drew Jaynes
c4b9da857a Using let's properly in inline comments lets us move on to more pressing matters of inline documentation. 
Props trepmal.
Fixes #30570.

Built from https://develop.svn.wordpress.org/trunk@30703


git-svn-id: http://core.svn.wordpress.org/trunk@30693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 04:43:22 +00:00
John Blackbourn
511489d7e4 Update the tests for get_metadata() to reflect the revert in r30701. 
See #15030

Built from https://develop.svn.wordpress.org/trunk@30702


git-svn-id: http://core.svn.wordpress.org/trunk@30692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 03:44:23 +00:00
John Blackbourn
d28823df33 Revert r30115 which was a breaking change for code which interacts with the return value of get_metadata() when no meta key is specified. 
See #15030

Built from https://develop.svn.wordpress.org/trunk@30701


git-svn-id: http://core.svn.wordpress.org/trunk@30691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 03:35:22 +00:00
John Blackbourn
6f3414ea67 Correct the width of the background vignette in the plugin info modal. 
Fixes #28229

Built from https://develop.svn.wordpress.org/trunk@30700


git-svn-id: http://core.svn.wordpress.org/trunk@30690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 03:19:22 +00:00
Gary Pendergast
de6d84935f WPDB: When looking up the character set for a table or column, make sure we send the table name to MySQL in the correct case, as MySQL can be configured with case sensitive table names. 
Fixes #30538.

Built from https://develop.svn.wordpress.org/trunk@30699


git-svn-id: http://core.svn.wordpress.org/trunk@30689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 03:00:23 +00:00
Helen Hou-Sandí
cb5c43df83 Don't over-target buttons in the publish meta box. 
This selector caused breakage for any custom buttons added.

props ericlewis.
fixes #30035.

Built from https://develop.svn.wordpress.org/trunk@30698


git-svn-id: http://core.svn.wordpress.org/trunk@30688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 02:35:28 +00:00
John Blackbourn
6fcf4ed3c5 Prevent the deletion of a theme while it has an active child theme. 
Fixes #29580
Props karpstrucking, jesin

Built from https://develop.svn.wordpress.org/trunk@30697


git-svn-id: http://core.svn.wordpress.org/trunk@30687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 02:21:24 +00:00
John Blackbourn
b0a2416040 Ensure the theme and plugin update checks are always in sync with the current theme and plugin versions before fetching cached update data. This change only triggers a request to the update API when necessary. 
Fixes #13071
Props bswatson

Built from https://develop.svn.wordpress.org/trunk@30696


git-svn-id: http://core.svn.wordpress.org/trunk@30686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 01:52:23 +00:00
Drew Jaynes
ad297dab6d Correctly capitalize JavaScript throughout core docs. 
Fixes #30569.

Built from https://develop.svn.wordpress.org/trunk@30695


git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 00:31:22 +00:00
Andrew Ozz
d16c8cf1fc TinyMCE: update the wpView toolbar to look the same as the new image toolbar. 
Fixes #30561.
Built from https://develop.svn.wordpress.org/trunk@30694


git-svn-id: http://core.svn.wordpress.org/trunk@30684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 00:26:22 +00:00
Andrew Ozz
16e54ae8c0 Editor DFW v2: do not fade out on using keyboard shortcuts in TinyMCE (Alt+Shift+letter). 
Fixes #30539.
Built from https://develop.svn.wordpress.org/trunk@30693


git-svn-id: http://core.svn.wordpress.org/trunk@30683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 22:53:24 +00:00
Ian Stewart
c9c02be354 Twenty Fifteen: correct stylesheet dependencies. 
Props ocean90, fixes #30532.


Built from https://develop.svn.wordpress.org/trunk@30692


git-svn-id: http://core.svn.wordpress.org/trunk@30682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 19:41:22 +00:00
Drew Jaynes
4bdf9961d4 Improve inline documentation for four methods in WP_Widget: get_field_id(), display_callback(), update_callback(), and form_callback(). 
Props jazzs3quence for the initial patch.
See #30315.

Built from https://develop.svn.wordpress.org/trunk@30691


git-svn-id: http://core.svn.wordpress.org/trunk@30681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 19:35:25 +00:00
Ian Stewart
4c86797ba7 Twenty Fifteen: broader selection of avatars that should catch any plugins adding avatars that use the avatar class. 
Props iamtakashi, fixes #30541.


Built from https://develop.svn.wordpress.org/trunk@30690


git-svn-id: http://core.svn.wordpress.org/trunk@30680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 19:34:22 +00:00
Ian Stewart
20d135f3b2 Twenty Fifteen: correct list indentation inside blockquotes. 
Props iamtakashi, fixes #30543.


Built from https://develop.svn.wordpress.org/trunk@30689


git-svn-id: http://core.svn.wordpress.org/trunk@30679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 19:31:24 +00:00
Boone Gorges
9c047d48ab Use assertEqualSetsWithIndex() as appropriate in get_terms() tests. 
See #30522.
Built from https://develop.svn.wordpress.org/trunk@30688


git-svn-id: http://core.svn.wordpress.org/trunk@30678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 14:25:23 +00:00
Gary Pendergast
e1e546c330 Unit Tests: The assertEqualSets() helper was returning true for some sets that were not equal. assertEqualSets() now behaves correctly, and the new assertEqualSetsWithIndex() helper also checks that the array indexes are the same. 
Fixes #30522.

Built from https://develop.svn.wordpress.org/trunk@30687


git-svn-id: http://core.svn.wordpress.org/trunk@30677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 05:02:23 +00:00
John Blackbourn
389811b3ec Remove the sortable functionality from the selection editing toolbar at the bottom of the media manager. 
Fixes #29934
See #24352
Props jessepollak

Built from https://develop.svn.wordpress.org/trunk@30686


git-svn-id: http://core.svn.wordpress.org/trunk@30676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 04:18:23 +00:00
John Blackbourn
e93105ba9a Clarify the text for the 'Edit Selection' link when multiple media items are selected in the media manager. 
Props adamsilverstein
See #24325

Built from https://develop.svn.wordpress.org/trunk@30685


git-svn-id: http://core.svn.wordpress.org/trunk@30675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 04:15:23 +00:00
John Blackbourn
d614abe3a2 Allow brackets in a URL when it's sanitised for a redirect. Brackets are valid in query parameters. 
Fixes #30308
Props voldemortensen

Built from https://develop.svn.wordpress.org/trunk@30684


git-svn-id: http://core.svn.wordpress.org/trunk@30674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 03:21:22 +00:00
John Blackbourn
17ddc06287 Allow square brackets in a URL when it's sanitised for a redirect. Square brackets are valid in query parameters and IPv6 addresses. 
Fixes #17052
Props voldemortensen

Built from https://develop.svn.wordpress.org/trunk@30683


git-svn-id: http://core.svn.wordpress.org/trunk@30673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 03:16:22 +00:00
Scott Taylor
37a23b2c73 Improve various @param docs. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30682


git-svn-id: http://core.svn.wordpress.org/trunk@30672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 02:17:21 +00:00
Scott Taylor
e619abda6e Improve various @param docs for src/wp-includes/*. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30681


git-svn-id: http://core.svn.wordpress.org/trunk@30671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 01:34:24 +00:00
Scott Taylor
2c32752abd Improve various @param docs for src/wp-admin/*. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30680


git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 01:00:22 +00:00
Scott Taylor
65ab522a51 Improve various @param docs for List Tables. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30679


git-svn-id: http://core.svn.wordpress.org/trunk@30669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 00:33:23 +00:00
Scott Taylor
da4c39480f Improve various @param docs for src/wp-admin/includes/class-wp-filesystem-*.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30678


git-svn-id: http://core.svn.wordpress.org/trunk@30668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 00:13:22 +00:00
Gary Pendergast
a0c12d0c61 WPDB: Before fetching results, make sure we have a valid result resource to fetch them from. 
Fixes #27982.

Built from https://develop.svn.wordpress.org/trunk@30677


git-svn-id: http://core.svn.wordpress.org/trunk@30667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 00:03:22 +00:00
Scott Taylor
a215b8801d Improve various @param docs for src/wp-includes/class-wp-customize*.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30676


git-svn-id: http://core.svn.wordpress.org/trunk@30666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 23:33:23 +00:00
Andrew Ozz
3ad5115eaf TinyMCE: update to 4.1.7, changelog: https://github.com/tinymce/tinymce/blob/master/changelog.txt. Fixes #30560. 
Built from https://develop.svn.wordpress.org/trunk@30675


git-svn-id: http://core.svn.wordpress.org/trunk@30665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 23:28:24 +00:00
Scott Taylor
a0df295f5c Improve various @param docs. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30674


git-svn-id: http://core.svn.wordpress.org/trunk@30664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 23:24:25 +00:00
Scott Taylor
ba914c7df1 Improve various @param docs. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30673


git-svn-id: http://core.svn.wordpress.org/trunk@30663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:56:25 +00:00
Scott Taylor
d097e7cf83 Improve the @param docs for src/includes/theme.php and src/includes/update.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30672


git-svn-id: http://core.svn.wordpress.org/trunk@30662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:44:22 +00:00
Scott Taylor
9a8be964b6 Improve the @param docs for src/wp-includes/post*.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30671


git-svn-id: http://core.svn.wordpress.org/trunk@30661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:37:22 +00:00
Andrew Ozz
41494045a9 TinyMCE: update translatable strings, see #30560. 
Built from https://develop.svn.wordpress.org/trunk@30670


git-svn-id: http://core.svn.wordpress.org/trunk@30660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:27:24 +00:00
Scott Taylor
3752aa7ce8 Improve the @param docs for src/includes/rewrite.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30669


git-svn-id: http://core.svn.wordpress.org/trunk@30659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:25:23 +00:00
Scott Taylor
67417897ec Improve the @param docs for src/wp-admin/includes/plugin.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30668


git-svn-id: http://core.svn.wordpress.org/trunk@30658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:23:23 +00:00
Scott Taylor
04453cbe01 Improve the @param docs for src/wp-includes/pluggable*. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30667


git-svn-id: http://core.svn.wordpress.org/trunk@30657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:19:25 +00:00
Scott Taylor
04a4cf6156 Improve the @param docs for src/wp-includes/user.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30666


git-svn-id: http://core.svn.wordpress.org/trunk@30656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:11:23 +00:00
Scott Taylor
5d75282328 Improve the @param docs for src/wp-includes/widgets.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30665


git-svn-id: http://core.svn.wordpress.org/trunk@30655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 22:05:21 +00:00
Scott Taylor
b63c789e88 Improve the @param docs for src/wp-includes/wp-db.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30664


git-svn-id: http://core.svn.wordpress.org/trunk@30654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 21:55:23 +00:00
Scott Taylor
b35cbbfac7 Add missing @params to src/wp-includes/pomo files. 
See #30224.


Built from https://develop.svn.wordpress.org/trunk@30663


git-svn-id: http://core.svn.wordpress.org/trunk@30653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 21:41:22 +00:00
Scott Taylor
616c5515ce Improve the @param docs for trackback_response() and validate_another_blog_signup(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30662


git-svn-id: http://core.svn.wordpress.org/trunk@30652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 21:23:23 +00:00
Scott Taylor
562ddb8316 Use sanitize_mime_type() instead of urlencode() when string-building <option> values in ->get_views() for media list tables. 
`urlencode()` was introduced in [28553] via _duck and yours truly.

Got weirder after [29625].

Props birgire.
Fixes #30123.

Built from https://develop.svn.wordpress.org/trunk@30661


git-svn-id: http://core.svn.wordpress.org/trunk@30651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 20:23:23 +00:00
Scott Taylor
ce05e4932f Use round() instead of floor() when resizing image dimensions. 
Updates unit tests.

Props SergeyBiryukov, kitchin.
Fixes #18532.

Built from https://develop.svn.wordpress.org/trunk@30660


git-svn-id: http://core.svn.wordpress.org/trunk@30650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 19:54:23 +00:00
Scott Taylor
9ea224b78f The menu items for users.php and profile.php that require the promote_users cap should be wrapped in an is_multisite() conditional a la user-new.php. 
Props SergeyBiryukov.
Fixes #30526.

Built from https://develop.svn.wordpress.org/trunk@30659


git-svn-id: http://core.svn.wordpress.org/trunk@30649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 19:18:23 +00:00
Scott Taylor
3f39605b02 wp_upload_dir() has a (little-known?) side effect: if you call it, it will attempt to create an uploads directory for the current month. As such, tearDown() and cleanup routines have to be in sync with this behavior when deleting bogus directories used in unit tests. 
Examples: if you clean up directories in a test, or a test fails before the directories are cleaned, or a test fails before the `'upload_path'` option is reset, the next call to `wp_upload_dir()` will recreate the directories you just tried to delete.

These changes ensure that `src/foo` and `/tmp/wp-unit-test` directories are deleted immediately after `wp_upload_dir()` is fired in the tests. 
 
Fixes #30513.

Built from https://develop.svn.wordpress.org/trunk@30658


git-svn-id: http://core.svn.wordpress.org/trunk@30648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 19:06:22 +00:00
Dominik Schilling
15df631e76 Make notices added in [30459] less ugly. 
see #25569, #25571, [30505].
Built from https://develop.svn.wordpress.org/trunk@30657


git-svn-id: http://core.svn.wordpress.org/trunk@30647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 12:21:22 +00:00
Drew Jaynes
bffe95d34c Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*. 
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30656


git-svn-id: http://core.svn.wordpress.org/trunk@30646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 12:10:23 +00:00
Drew Jaynes
d6e6dbf086 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-includes/meta.php. 
Affects DocBlocks for the following hooks:
* `add_{$meta_type}_metadata`
* `add_{$meta_type}_meta`
* `added_{$meta_type}_meta`
* `update_{$meta_type}_metadata`
* `update_{$meta_type}_meta`
* `updated_{$meta_type}_meta`
* `delete_{$meta_type}_metadata`
* `delete_{$meta_type}_meta`
* `deleted_{$meta_type}_meta`
* `get_{$meta_type}_metadata`
* `delete_{$meta_type}meta`
* `deleted_{$meta_type}meta`
* `sanitize_{$meta_type}_meta_{$meta_key}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30655


git-svn-id: http://core.svn.wordpress.org/trunk@30645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 12:03:24 +00:00
Drew Jaynes
150f71e3e5 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-includes/taxonomy.php. 
Affects DocBlocks for the following hooks:
* `get_$taxonomy`
* `edit_term_{$field}`
* `edit_{$taxonomy}_{$field}`
* `pre_term_{$field}`
* `pre_{$taxonomy}_{$field}`
* `term_{$field}_rss`
* `{$taxonomy}_{$field}_rss`
* `term_{$field}`
* `{$taxonomy}_{$field}`
* `delete_$taxonomy`
* `create_$taxonomy`
* `edit_$taxonomy`
* `edited_$taxonomy`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30654


git-svn-id: http://core.svn.wordpress.org/trunk@30644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 12:00:23 +00:00
Drew Jaynes
7e532924c3 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-includes/post.php. 
Affects DocBlocks for the following hooks:
* `post_type_labels_{$post_type}`
* `edit_{$field}`
* `{$field_no_prefix}_edit_pre`
* `pre_{$field}`
* `{$field_no_prefix}_save_pre`
* `{$field}_pre`
* `$field`
* `save_post_{$post->post_type}`
* `{$old_status}_to_{$new_status}`
* `{$new_status}_{$post->post_type}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30653


git-svn-id: http://core.svn.wordpress.org/trunk@30643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:56:22 +00:00
Drew Jaynes
439fe48010 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-includes/option.php. 
Affects DocBlocks for the following hooks:
* `pre_option_ . $option`
* `default_option_ . $option`
* `option_ . $option`
* `pre_update_option_ . $option`
* `update_option_{$option}`
* `add_option_{$option}`
* `delete_option_$option`
* `delete_transient_ . $transient`
* `pre_transient_ . $transient`
* `transient_ . $transient`
* `pre_set_transient_ . $transient`
* `set_transient_ . $transient`
* `pre_site_option_ . $option`
* `default_site_option_ . $option`
* `site_option_ . $option`
* `pre_add_site_option_ . $option`
* `add_site_option_{$option}`
* `pre_delete_site_option_ . $option`
* `delete_site_option_{$option}`
* `pre_update_site_option_ . $option`
* `update_site_option_{$option}`
* `delete_site_transient_ . $transient`
* `pre_site_transient_ . $transient`
* `site_transient_ . $transient`
* `pre_set_site_transient_ . $transient`
* `set_site_transient_ . $transient`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30652


git-svn-id: http://core.svn.wordpress.org/trunk@30642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:53:22 +00:00
Drew Jaynes
ab3856619e Docs Formatting: Backtick-escape inline code for the login_form_ . $action dynamic hook in wp-login.php. 
See #30552.

Built from https://develop.svn.wordpress.org/trunk@30651


git-svn-id: http://core.svn.wordpress.org/trunk@30641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:45:23 +00:00
Dominik Schilling
773da4a1e5 Update the Iris color picker to version 1.0.7. 
Includes a fix for multiple pickers on the same page.
Changes: https://github.com/Automattic/Iris/compare/1.0.6...1.0.7

props mattwiebe.
fixes #30537.
Built from https://develop.svn.wordpress.org/trunk@30650


git-svn-id: http://core.svn.wordpress.org/trunk@30640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:44:22 +00:00
Drew Jaynes
2faf449f51 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/*. 
Also includes some changes to move hook docs to directly precede hook lines. This is necessary to prevent DocBlock-matching confusion when core is parsed.

Affects DocBlocks for the following hooks:
* `wp_ajax_ . $_REQUEST['action']`
* `wp_ajax_nopriv_ . $_REQUEST['action']`
* `admin_footer- . $GLOBALS['hook_suffix']`
* `admin_head-$hook_suffix`
* `admin_post_nopriv_{$action}`
* `admin_post_{$action}`
* `load-  . $page_hook`
* `load- . $plugin_page`
* `load-importer- . $importer`
* `load- . $pagenow`
* `admin_action_ . $_REQUEST['action']`
* `async_upload_{$type}`
* `add_meta_boxes_ . $post_type`
* `{$taxonomy}_pre_edit_form`
* `{$taxonomy}_term_edit_form_tag`
* `{$taxonomy}_edit_form_fields`
* `{$taxonomy}_edit_form`
* `after-{$taxonomy}-table`
* `{$taxonomy}_pre_add_form`
* `{$taxonomy}_term_new_form_tag`
* `{$taxonomy}_add_form_fields`
* `{$taxonomy}_add_form`
* `media_upload_$type`
* `media_upload_$tab`
* `install_plugins_pre_$tab`
* `install_plugins_$tab`
* `install_themes_pre_{$tab}`
* `install_themes_{$tab}`
* `update-core-custom_{$action}`
* `update-custom_{$action}`
* `user_{$name}_label`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30649


git-svn-id: http://core.svn.wordpress.org/trunk@30639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:42:24 +00:00
Drew Jaynes
78bb3e5ff5 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*. 
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30648


git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:28:24 +00:00
Drew Jaynes
9ae5e43ac8 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/network/*. 
Affects DocBlocks for the following hooks:
* `network_admin_edit_' . $_GET['action']`
* `network_sites_updated_message_' . $_GET['updated']`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30647


git-svn-id: http://core.svn.wordpress.org/trunk@30637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 11:21:22 +00:00
Drew Jaynes
2f6c0d5e96 Improve inline documentation for image_constrain_size_for_editor(). 
Includes:
* Proper formatting, plus adding a type for the `$context` parameter
* Inline `@see` tags in the description and backtick-escaping inline code
* Parameter, type, and description alignment

Props tillkruess for the initial patch.
Fixes #30508.

Built from https://develop.svn.wordpress.org/trunk@30646


git-svn-id: http://core.svn.wordpress.org/trunk@30636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 10:06:23 +00:00
Drew Jaynes
3ceb75bd8e Specify a type (array) for the $post_data parameter in the DocBlock for wp_autosave(). 
Props tillkruess.
See #30508.

Built from https://develop.svn.wordpress.org/trunk@30645


git-svn-id: http://core.svn.wordpress.org/trunk@30635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 10:01:23 +00:00
Drew Jaynes
e4425165ff Improve the inline documentation for image_edit_apply_changes(). 
Including:
* Add a correct type (array) for the `$changes` parameter
* Add the `@since` version
* Add proper descriptions for both parameters and the return value.

Props tillkruess for the initial patch.
See #30508.

Built from https://develop.svn.wordpress.org/trunk@30644


git-svn-id: http://core.svn.wordpress.org/trunk@30634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 09:59:22 +00:00
Drew Jaynes
5977a7e355 Add an entry to the changelog for the wp_editor_expand hook denoting that the $post_type parameter was added in 4.1.0. 
See #30458.

Built from https://develop.svn.wordpress.org/trunk@30643


git-svn-id: http://core.svn.wordpress.org/trunk@30633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 09:51:23 +00:00
Scott Taylor
f60e85b0e4 When creating audio and video MCE views, listen to the players within each iframe to capture the "play" event. When a player plays, pause the players in every other iframe sandbox. 
Fixes #29384.

Built from https://develop.svn.wordpress.org/trunk@30642


git-svn-id: http://core.svn.wordpress.org/trunk@30632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 08:45:22 +00:00
Andrew Ozz
760e3e5fbd Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass $post_type in the wp_editor_expand filter. See #30458. 
Built from https://develop.svn.wordpress.org/trunk@30641


git-svn-id: http://core.svn.wordpress.org/trunk@30631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:37:21 +00:00
Scott Taylor
4718bf4f76 Adjust the RegEx in wp_check_filetype() to be aware that query strings are thing that exist sometimes in URLs. 
Adds unit tests.

Props voldemortensen.
Fixes #30377.

Built from https://develop.svn.wordpress.org/trunk@30640


git-svn-id: http://core.svn.wordpress.org/trunk@30630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:33:23 +00:00
Scott Taylor
5352f51516 Fix edge-case in media cropping where selection and destination are the same size. 
Adds unit tests.

Props mboynes.
Fixes #19793.

Built from https://develop.svn.wordpress.org/trunk@30639


git-svn-id: http://core.svn.wordpress.org/trunk@30629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:27:23 +00:00
Scott Taylor
67e5d4041c When deleting media grid attachments, wait until the server responds before removing the model from its collection. 
Props 5um17.
Fixes #30457.

Built from https://develop.svn.wordpress.org/trunk@30638


git-svn-id: http://core.svn.wordpress.org/trunk@30628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:19:23 +00:00
Scott Taylor
0b54cfd77b IETF language changes in MediaElement: 
https://github.com/johndyer/mediaelement/pull/1270/

Reverts [28801].
Fixes #29182.

Built from https://develop.svn.wordpress.org/trunk@30637


git-svn-id: http://core.svn.wordpress.org/trunk@30627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:12:23 +00:00
Scott Taylor
d12eb2e38e Ensure uniqueness when returning page lists in get_page_children(). Fixes failing unit tests. 
Props boonebgorges.
Reverts [30246].
Fixes #14477.

Built from https://develop.svn.wordpress.org/trunk@30636


git-svn-id: http://core.svn.wordpress.org/trunk@30626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 06:05:24 +00:00
Drew Jaynes
1e10385a90 Remove an invalid parameter from the DocBlock for the gallery_style hook. 
Props keesiemeijer.
Fixes #30507.

Built from https://develop.svn.wordpress.org/trunk@30635


git-svn-id: http://core.svn.wordpress.org/trunk@30625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 05:58:47 +00:00
Scott Taylor
68f0690aa4 Upgrade to MediaElement 2.16.2 
https://github.com/johndyer/mediaelement/compare/2.15.1...2.16.2

Fixes #30281.

Built from https://develop.svn.wordpress.org/trunk@30634


git-svn-id: http://core.svn.wordpress.org/trunk@30624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 05:58:24 +00:00
Drew Jaynes
c512f1d916 Remove return descriptions from the DocBlocks for add_image_size() and set_post_thumbnail_size() as they don't return anything. 
Also document the `$_wp_additional_image_sizes` global, leveraged in `add_image_size()`.

Props stevegrunwell.
Fixes #30511.

Built from https://develop.svn.wordpress.org/trunk@30633


git-svn-id: http://core.svn.wordpress.org/trunk@30623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 05:49:23 +00:00
Drew Jaynes
74175fb08c Document the $user_id parameter added to the 'admin_color_scheme_picker' hook in 3.8.1. 
Props Ipstenu.
Fixes #30551.

Built from https://develop.svn.wordpress.org/trunk@30632


git-svn-id: http://core.svn.wordpress.org/trunk@30622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 05:42:23 +00:00
Gary Pendergast
5b22a5ba2f WPDB Unit Tests: Fix a fatal error that occurs in the test_strip_invalid_text() test if the mbstring extension isn't activated in PHP. 
Built from https://develop.svn.wordpress.org/trunk@30631


git-svn-id: http://core.svn.wordpress.org/trunk@30621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 05:35:23 +00:00
Drew Jaynes
bb380687fa Add missing DocBlocks for several functions in wp-admin/includes/ms.php. 
Props dustyf.
See #30483.

Built from https://develop.svn.wordpress.org/trunk@30630


git-svn-id: http://core.svn.wordpress.org/trunk@30620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 05:06:23 +00:00
John Blackbourn
db9b25fbc5 Check attachments as well as the current post type when checking for duplicate post slugs. This avoids creating a page with a slug which conflicts with an existing attachment (the inverse is already handled). 
Updates the existing test for pages which should take priority over attachments in cases where an existing clash exists.

Fixes #18962
Props boonebgorges

Built from https://develop.svn.wordpress.org/trunk@30629


git-svn-id: http://core.svn.wordpress.org/trunk@30619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 04:49:22 +00:00
Drew Jaynes
3e922b9687 Add missing return descriptions for a variety of functions in wp-includes/link-template.php. 
Props colorful-tones, dustyf.
See #30406.

Built from https://develop.svn.wordpress.org/trunk@30628


git-svn-id: http://core.svn.wordpress.org/trunk@30618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 04:44:23 +00:00
Drew Jaynes
3699ea4155 Use the correct type (integer) for the $menu_id parameter in the wp_get_nav_menu_to_edit() DocBlock. 
Also properly mark the parameter as optional and specify the default value.

Props jaimieolmstead for the initial patch.
Fixes #30540.

Built from https://develop.svn.wordpress.org/trunk@30627


git-svn-id: http://core.svn.wordpress.org/trunk@30617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 04:25:23 +00:00
Boone Gorges
c6e752b063 In get_default_post_to_edit(), let 'post_name' be passed to filter. 
Previously, it was being overridden after the default post had been inserted
into the database, making it cumbersome to override with the 'wp_insert_post_data'
filter.

Props danielbachhuber.
Fixes #29847.
Built from https://develop.svn.wordpress.org/trunk@30626


git-svn-id: http://core.svn.wordpress.org/trunk@30616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-29 19:26:23 +00:00
Andrew Ozz
2808edf7d1 Editor: fix fading out on Escape in DFW v2. props adamsilverstein, fixes #30528. 
Built from https://develop.svn.wordpress.org/trunk@30625


git-svn-id: http://core.svn.wordpress.org/trunk@30615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-29 02:45:22 +00:00
Drew Jaynes
9d1a4afda8 4.1 Docs Audit: Improve inline documentation for various wpdb methods. 
#30469.

Built from https://develop.svn.wordpress.org/trunk@30624


git-svn-id: http://core.svn.wordpress.org/trunk@30614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:34:25 +00:00
Drew Jaynes
e11c0a9d3e 4.1 Docs Audit: Fix formatting for changelog entries in count_user_posts() and the get_usernumposts hook. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30623


git-svn-id: http://core.svn.wordpress.org/trunk@30613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:29:23 +00:00
Drew Jaynes
ea1ee4369f 4.1 Docs Audit: Improve inline documentation in DocBlocks for various WP_Tax_Query methods, the pre_delete_term hook, and get_ancestors(). 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30622


git-svn-id: http://core.svn.wordpress.org/trunk@30612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:26:24 +00:00
Drew Jaynes
6a7b8f9506 4.1 Docs Audit: Remove a duplicate word from a parameter description in the DocBlock for the wp_save_post_revision_post_has_changed hook. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30621


git-svn-id: http://core.svn.wordpress.org/trunk@30611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:19:23 +00:00
Drew Jaynes
fdb0b54389 4.1 Docs Audit: Improve inline documentation for the new WP_Query::setup_postdata() method. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30620


git-svn-id: http://core.svn.wordpress.org/trunk@30610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:18:22 +00:00
Drew Jaynes
4fd64b94d7 4.1 Docs Audit: Formatting, line-wrap, and other fixes for the wp_get_nav_menus() DocBlock. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30619


git-svn-id: http://core.svn.wordpress.org/trunk@30609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:15:23 +00:00
Drew Jaynes
c31f6c11e9 4.1 Docs Audit: Spell out HTML element names in DocBlock summaries for the nav_menu_css_class, nav_menu_item_id, and nav_menu_link_attributes filters. 
Due to a recent clarification in the core inline documentation standards, HTML tags are no longer allowed in DocBlock summaries as they wreak havoc on displaying pages in the official Code Reference. See #30473.

See #30469.

Built from https://develop.svn.wordpress.org/trunk@30618


git-svn-id: http://core.svn.wordpress.org/trunk@30608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:12:23 +00:00
Drew Jaynes
f6fd6e09b1 4.1 Docs Audit: Improve inline documentation for various WP_Meta_Query methods introduced or modified in 4.1. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30617


git-svn-id: http://core.svn.wordpress.org/trunk@30607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 12:02:22 +00:00
Drew Jaynes
494a15e1cd 4.1 Docs Audit: Ensure optional arguments in get_the_post_navigation(), the_post_navigation(), get_the_posts_navigation(), the_posts_navigation(), get_the_pagination(), and the_pagination() are properly documented with defaults. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30616


git-svn-id: http://core.svn.wordpress.org/trunk@30606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:57:24 +00:00
Drew Jaynes
a4be4f520f Ensure the private function _wp_render_title_tag() is marked for internal usage only. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30615


git-svn-id: http://core.svn.wordpress.org/trunk@30605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:50:22 +00:00
Drew Jaynes
a1f244d454 Improve line-wrapping and formatting in the DocBlock for wp_send_json_error(). 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30614


git-svn-id: http://core.svn.wordpress.org/trunk@30604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:39:22 +00:00
Drew Jaynes
68432b0cd1 4.1 Docs Audit: Ensure optional arguments in wp_json_encode() are properly documented as such. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30613


git-svn-id: http://core.svn.wordpress.org/trunk@30603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:36:23 +00:00
Drew Jaynes
1357e2fd2f Ensure only spaces are used instead of a mixture of tabs and spaces for alignment within the DocBlock for the date_query_valid_columns hook. See [30611]. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30612


git-svn-id: http://core.svn.wordpress.org/trunk@30602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:29:25 +00:00
Drew Jaynes
e0e6c98928 4.1 Docs Audit: Improve inline documentation in various WP_Date_Query methods modified in 4.1. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30611


git-svn-id: http://core.svn.wordpress.org/trunk@30601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:26:23 +00:00
Drew Jaynes
4432dc752b 4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30610


git-svn-id: http://core.svn.wordpress.org/trunk@30600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:22:23 +00:00
Drew Jaynes
21a521db09 4.1 Docs Audit: Fix DocBlock formatting for the customize_preview_{$this->type} hook. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30609


git-svn-id: http://core.svn.wordpress.org/trunk@30599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:13:24 +00:00
Drew Jaynes
49fe81ebeb 4.1 Docs Audit: Improve inline documentation for various properties and methods in the WP_Customize_Section, WP_Customize_Section, and WP_Customize_Sidebar_Section classes. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30608


git-svn-id: http://core.svn.wordpress.org/trunk@30598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:10:22 +00:00
Drew Jaynes
a8fcffa02a 4.1 Docs Audit: Improve inline documentation for various properties and methods in the WP_Customize_Panel class. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30607


git-svn-id: http://core.svn.wordpress.org/trunk@30597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:03:24 +00:00
Drew Jaynes
478f5f1f5d 4.1 Docs Audit: Improve inline documentation for various properties and methods in the WP_Customize_Manager class. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30606


git-svn-id: http://core.svn.wordpress.org/trunk@30596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 10:52:22 +00:00
Drew Jaynes
3bbf79ba92 4.1 Docs Audit: Improve inline documentation for various properties and methods in the WP_Customize_Control and WP_Customize_Upload_Control classes. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30605


git-svn-id: http://core.svn.wordpress.org/trunk@30595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 09:20:23 +00:00
Drew Jaynes
9dcb6daec2 4.1 Docs Audit: Fix some line-wrapping in the DocBlock for WP_Http::parse_url(). 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30604


git-svn-id: http://core.svn.wordpress.org/trunk@30594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 09:14:23 +00:00
Drew Jaynes
374ec33767 4.1 Docs Audit: Clarify the DocBlock summary for network_settings_add_js() to specify that it's specific to the Network Settings screen. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30603


git-svn-id: http://core.svn.wordpress.org/trunk@30593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 09:09:22 +00:00
Drew Jaynes
659413eb98 4.1 Docs Audit: Document the $post global in the DocBlock for wp_print_revision_templates(). 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30602


git-svn-id: http://core.svn.wordpress.org/trunk@30592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 09:05:23 +00:00
Drew Jaynes
da589fc375 4.1 Docs Audit: Fix a variety of issues with the DocBlock for the default_page_template_title filter. 
Includes hyphenating 'drop-down', ensuring the DocBlock itself is correctly indented, and wraps lines at an appropriate length.

See #30469.

Built from https://develop.svn.wordpress.org/trunk@30601


git-svn-id: http://core.svn.wordpress.org/trunk@30591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 09:00:24 +00:00
Drew Jaynes
5212725fbe 4.1 Docs Audit: Convert a hook reference to an inline @see tag in the hook docs for the image_add_caption_text filter. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30600


git-svn-id: http://core.svn.wordpress.org/trunk@30590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 08:56:24 +00:00
Drew Jaynes
087fbce9ae 4.1 Docs Audit: Clarify the DocBlock summary for the edit_form_before_permalink hook. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30599


git-svn-id: http://core.svn.wordpress.org/trunk@30589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 08:52:23 +00:00
Sergey Biryukov
8cc6732b03 Consistently handle an empty site title in Site and My Sites toolbar menus. 
see #28682.
Built from https://develop.svn.wordpress.org/trunk@30598


git-svn-id: http://core.svn.wordpress.org/trunk@30588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 08:13:24 +00:00
Sergey Biryukov
8c091940a3 When live-updating site title in toolbar, fall back to the site url if the title is empty. 
props avryl.
see #28682.
Built from https://develop.svn.wordpress.org/trunk@30597


git-svn-id: http://core.svn.wordpress.org/trunk@30587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 08:12:23 +00:00
Sergey Biryukov
0a8b72866e Add missing periods to strings introduced in [30333]. 
props DrewAPicture.
see #30264.
Built from https://develop.svn.wordpress.org/trunk@30596


git-svn-id: http://core.svn.wordpress.org/trunk@30586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 06:26:22 +00:00
Drew Jaynes
a899bbaee7 Improve inline documentation in wp_ajax_destroy_sessions(). 
If the token is set (`$keep` is a string), this means the user is viewing their own profile-editing screen and destroying their own sessions (except the current one). If it isn't set (`$keep` is null), the user is editing another user's profile and destroying all of their sessions with no exceptions.

See #30264, #30469

Built from https://develop.svn.wordpress.org/trunk@30595


git-svn-id: http://core.svn.wordpress.org/trunk@30585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 03:48:22 +00:00
Andrew Ozz
9a4a968172 Editor: move the DFW v2 transitions CSS from editor.css to wp-admin.css. They are needed only on the Edit Post screen. 
See #30453.
Built from https://develop.svn.wordpress.org/trunk@30594


git-svn-id: http://core.svn.wordpress.org/trunk@30584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 02:36:23 +00:00
Andrew Ozz
9e8f2c7794 Editor: use the Alt+Shift+W keyboard shortcut for new DFW from both the Visual and Text editors. Props afercia, fixes #30450. 
Built from https://develop.svn.wordpress.org/trunk@30593


git-svn-id: http://core.svn.wordpress.org/trunk@30583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 01:44:22 +00:00
John Blackbourn
8f219ed949 Revert [30032] so appropriate PHP warnings aren't masked. 
Fixes #28743

Built from https://develop.svn.wordpress.org/trunk@30592


git-svn-id: http://core.svn.wordpress.org/trunk@30582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 01:29:23 +00:00
Andrew Ozz
9597159393 Better error message when the admin is ssl and non-ssl oEmbed previews are not available in the editor. Props Japh, fixes #30533. 
Built from https://develop.svn.wordpress.org/trunk@30591


git-svn-id: http://core.svn.wordpress.org/trunk@30581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 22:37:24 +00:00
Ian Stewart
85e5ab64a5 Twenty Fifteen: better highlights for tapped links in iOS Safari. 
Props iamtakashi, fixes #30524.



Built from https://develop.svn.wordpress.org/trunk@30590


git-svn-id: http://core.svn.wordpress.org/trunk@30580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 20:41:22 +00:00
Ian Stewart
e2133880c1 Twenty Fifteen: overflow hidden can hide focus outlines here so out it goes. 
Props iamtakashi, fixes #30523.


Built from https://develop.svn.wordpress.org/trunk@30589


git-svn-id: http://core.svn.wordpress.org/trunk@30579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 20:36:24 +00:00
Ian Stewart
2e123ad458 Twenty Fifteen: minor corrections to borders and post title colors in custom color schemes. 
Props iamtakashi, fixes #30521.



Built from https://develop.svn.wordpress.org/trunk@30588


git-svn-id: http://core.svn.wordpress.org/trunk@30578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 20:34:24 +00:00
Gary Pendergast
8990b1c1fc WPDB: Remove the addition of STRICT_ALL_TABLES, added in [30400]. This proved to be incompatible with too many plugins, as well as being incompatible with MySQL 5.7. 
See #21212.

Built from https://develop.svn.wordpress.org/trunk@30587


git-svn-id: http://core.svn.wordpress.org/trunk@30577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 11:00:23 +00:00
Andrew Ozz
4d651b90bb Editor: limit scrolling triggered when TinyMCE is auto-resized to 100px. Prevents auto-scrolling on page load. Fixes #30515. 
Built from https://develop.svn.wordpress.org/trunk@30586


git-svn-id: http://core.svn.wordpress.org/trunk@30576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 01:00:25 +00:00
Boone Gorges
213ecc8a07 Revert shared taxonomy term splitting for 4.1. 
This is a revert of [30494], [30492], [30347], and [30334]. The latter
changeset was a revert of [30336], which was a revert of [30241].

Watch for Term Splitting, Version III in version 4.2, coming soon to a
WordPress trunk near you.

See #30335, #5809.
Built from https://develop.svn.wordpress.org/trunk@30585


git-svn-id: http://core.svn.wordpress.org/trunk@30575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-27 00:05:22 +00:00
Andrew Ozz
92bcf2dbcb Remove unused CSS and JS from wp-mce-help.php, see #30517. 
Built from https://develop.svn.wordpress.org/trunk@30584


git-svn-id: http://core.svn.wordpress.org/trunk@30574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 23:23:23 +00:00
Andrew Ozz
4855f36478 Editor: fix warnings in class-wp-editor.php, see #30453. 
Built from https://develop.svn.wordpress.org/trunk@30583


git-svn-id: http://core.svn.wordpress.org/trunk@30573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 23:04:21 +00:00
Mark Jaquith
1d3b040d7d Remove old DFW width adjustment help text. 
fixes #30517
Built from https://develop.svn.wordpress.org/trunk@30582


git-svn-id: http://core.svn.wordpress.org/trunk@30572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 22:30:23 +00:00
Dominik Schilling
47f89b1d91 Remove unbounded check for "install.php" in wp_not_installed(). 
The check is true for `wp-admin/plugin-install.php` and `wp-admin/theme-install.php` too. This will end in a redirect to `/wp-admin/upgrade.php` or a screen with a bunch of errors.
The `WP_INSTALLING` constant was added in WordPress 1.5.1 to `wp-admin/install.php` which makes the check for "install.php" redundant.

props joemcgill.
fixes #29694.
Built from https://develop.svn.wordpress.org/trunk@30581


git-svn-id: http://core.svn.wordpress.org/trunk@30571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 20:56:23 +00:00
Drew Jaynes
e4f52df62c Fix DocBlock formatting for wp_generate_password(). 
Props stevegrunwell for the initial patch.
Fixes #30509.

Built from https://develop.svn.wordpress.org/trunk@30580


git-svn-id: http://core.svn.wordpress.org/trunk@30570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 20:38:23 +00:00
Dominik Schilling
7e0c893415 Comments: Use proper HTTP response codes for validation errors. 
props miqrogroove, solarissmoke, mackensen.
fixes #11286.
Built from https://develop.svn.wordpress.org/trunk@30579


git-svn-id: http://core.svn.wordpress.org/trunk@30569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 20:17:24 +00:00
Dominik Schilling
184d327ff4 Network Admin: Improve width of input fields on Add New Site and Edit Site screens. 
props honeysilvas.
fixes #16383.
Built from https://develop.svn.wordpress.org/trunk@30578


git-svn-id: http://core.svn.wordpress.org/trunk@30568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 19:51:23 +00:00
John Blackbourn
3a4f742175 Remove the wp_is_trusted_network() function pending further discussion on terminology and behaviour. 
See #30145

Built from https://develop.svn.wordpress.org/trunk@30577


git-svn-id: http://core.svn.wordpress.org/trunk@30567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 19:27:23 +00:00
Dominik Schilling
e002b0fc07 Type cast $nonce to string in wp_verify_nonce(). 
props jesin.
fixes #29542.
Built from https://develop.svn.wordpress.org/trunk@30576


git-svn-id: http://core.svn.wordpress.org/trunk@30566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 19:19:23 +00:00
Dion Hulse
aba2a6bcfd Fix the PHPDoc example for _split_str_by_whitespace(). 
Props voldemortensen. Fixes #30504

Built from https://develop.svn.wordpress.org/trunk@30575


git-svn-id: http://core.svn.wordpress.org/trunk@30565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 03:52:22 +00:00
Andrew Ozz
97c81c4507 Editor: add a pointer for the new DFW button. Remove the wp350_media and wp360_revisions pointers from the same screens. See #30458. 
Built from https://develop.svn.wordpress.org/trunk@30574


git-svn-id: http://core.svn.wordpress.org/trunk@30564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 02:54:25 +00:00
Andrew Ozz
af1e417d4e Editor: 
- Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
- Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
- Reset editor-expand when exiting TinyMCE fullscreen mode.
Fixes #30453.
Built from https://develop.svn.wordpress.org/trunk@30573


git-svn-id: http://core.svn.wordpress.org/trunk@30563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-26 02:50:24 +00:00
Ian Stewart
7e4486803b Twenty Fifteen: docs correction. 
Props rachelbaker, DrewAPicture, fixes #30456


Built from https://develop.svn.wordpress.org/trunk@30572


git-svn-id: http://core.svn.wordpress.org/trunk@30562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 21:11:22 +00:00
Ian Stewart
99c003c35d Twenty Fifteen: update the .pot file. 
Props iamtakashi, fixes #30433.


Built from https://develop.svn.wordpress.org/trunk@30571


git-svn-id: http://core.svn.wordpress.org/trunk@30561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 21:08:23 +00:00
Ian Stewart
a360658866 Twenty Fifteen: make sure the 'says:' in comments is readable by a screen-reader. 
Fixes #30479.


Built from https://develop.svn.wordpress.org/trunk@30570


git-svn-id: http://core.svn.wordpress.org/trunk@30560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 21:05:23 +00:00
Ian Stewart
e11418abdc Twenty Fifteen: docs correction and cleanup. 
Props DrewAPicture, see #30149.


Built from https://develop.svn.wordpress.org/trunk@30569


git-svn-id: http://core.svn.wordpress.org/trunk@30559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 20:57:24 +00:00
Ian Stewart
7a643924c2 Twenty Fifteen: correct number of menus used in comments 
Props jeherve, see #30149


Built from https://develop.svn.wordpress.org/trunk@30568


git-svn-id: http://core.svn.wordpress.org/trunk@30558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 20:38:25 +00:00
Ian Stewart
cb2dcb9820 Twenty Fifteen: remove unneeded custom header admin callbacks. 
Props philiparthurmoore, fixes #30432.


Built from https://develop.svn.wordpress.org/trunk@30567


git-svn-id: http://core.svn.wordpress.org/trunk@30556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 15:12:22 +00:00
Ian Stewart
a88ec3f9de Twenty Fifteen: prevent too-wide tables from popping out of posts. 
Props iamtakashi, fixes #30420


Built from https://develop.svn.wordpress.org/trunk@30566


git-svn-id: http://core.svn.wordpress.org/trunk@30555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 15:04:23 +00:00
Ian Stewart
654047e35b Twenty Fifteen: pinching to zoom in on landscape on iPads is breaking the layout with the sticky sidebar. Providing a one-column view on those screens looks good and will likely prevent other bugs we don't even know about. 
Props iamtakashi, fixes #30366.



Built from https://develop.svn.wordpress.org/trunk@30565


git-svn-id: http://core.svn.wordpress.org/trunk@30554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 14:58:21 +00:00
Ian Stewart
45343aa5d2 Twenty Fifteen: a shorter header on small screens when there is no header text or header image looks more correct. 
Props iamtakashi, fixes #30326.



Built from https://develop.svn.wordpress.org/trunk@30564


git-svn-id: http://core.svn.wordpress.org/trunk@30553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 14:47:22 +00:00
Dominik Schilling
61fd87f1f7 Update embedded.png after running grunt imagemin. 
After [30059] and [30079] we still had four images which could be minified. Three of them are handled by [30562], the last one by this.

fixes #30141.
Built from https://develop.svn.wordpress.org/trunk@30563


git-svn-id: http://core.svn.wordpress.org/trunk@30552 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 14:09:22 +00:00
Andrew Ozz
0517ee7c6e TwentyFifteen: 
- Fix image caption alignment in the editor.
- Remove unused var from functions.js.
Also includes few images that were shrunk a bit when running grunt precommit.
Fixes #30493.
Built from https://develop.svn.wordpress.org/trunk@30562


git-svn-id: http://core.svn.wordpress.org/trunk@30551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 06:12:22 +00:00
Gary Pendergast
a62fc4e4e5 When json_encode() returns a JSON string containing 'null' in PHP 5.4 or earlier, wp_json_encode() will now sanity check the data, as older versions of PHP failed to encode non UTF-8 characters correctly, instead returning 'null'. 
Fixes #30471.

Built from https://develop.svn.wordpress.org/trunk@30561


git-svn-id: http://core.svn.wordpress.org/trunk@30550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 05:01:23 +00:00
Andrew Ozz
f3ba529c2f TinyMCE: don't hide the image toolbar when the iframe window fires onresize. There is a bug in several browsers that triggers onresize when a tooltip is shown, only in RTL mode. Also use better variable name. Fixes #30147. 
Built from https://develop.svn.wordpress.org/trunk@30560


git-svn-id: http://core.svn.wordpress.org/trunk@30549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 04:31:23 +00:00
Jeremy Felt
a71d642a05 Add basic unit tests for is_plugin_active_for_network() 
Props rodrigosprimo
Fixes #30491

Built from https://develop.svn.wordpress.org/trunk@30559


git-svn-id: http://core.svn.wordpress.org/trunk@30548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 04:03:25 +00:00
Andrew Ozz
20e753a8c7 TinyMCE: use the actual image node when calculating the position of the toolbar. Fixes a bug in old IE. See #30147. 
Built from https://develop.svn.wordpress.org/trunk@30558


git-svn-id: http://core.svn.wordpress.org/trunk@30547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 01:22:21 +00:00
Boone Gorges
94b72ccba4 Add basic unit tests for is_plugin_active() and is_plugin_inactive(). 
Props voldemortensen.
Fixes #30489.
Built from https://develop.svn.wordpress.org/trunk@30557


git-svn-id: http://core.svn.wordpress.org/trunk@30546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-25 01:13:23 +00:00
Dominik Schilling
5742174ba8 Remove incorrect documentation for wp.media(). 
props ericlewis.
fixes #30090.
Built from https://develop.svn.wordpress.org/trunk@30556


git-svn-id: http://core.svn.wordpress.org/trunk@30545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 23:12:22 +00:00
Dominik Schilling
f5e4c9ee04 Improve the focus style for review links in the plugin info modal. 
props johnbillion.
fixes #30375.
Built from https://develop.svn.wordpress.org/trunk@30555


git-svn-id: http://core.svn.wordpress.org/trunk@30544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 22:59:21 +00:00
Dominik Schilling
e39c43ad6c Clear update caches when site language is changed. 
The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached. 
Introduce `_wp_clear_update_cache()` as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.
Built from https://develop.svn.wordpress.org/trunk@30554


git-svn-id: http://core.svn.wordpress.org/trunk@30543 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 22:50:22 +00:00
Dominik Schilling
6b51f14c6f Customizer: Only show the default button in the upload control if there is a default attachment. 
props celloexpressions.
see #21483.
Built from https://develop.svn.wordpress.org/trunk@30553


git-svn-id: http://core.svn.wordpress.org/trunk@30542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 22:31:23 +00:00
Dominik Schilling
d187a5eeba Customizer: Don't override Section.isContextuallyActive() in SidebarSection. 
This fixes a bug where empty widget areas get deactivated in the Customizer.

fixes #30378.
see #30235.
props westonruter.
Built from https://develop.svn.wordpress.org/trunk@30552


git-svn-id: http://core.svn.wordpress.org/trunk@30541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 22:26:23 +00:00
Dominik Schilling
aace02c0c0 Update the Iris color picker to version 1.0.6. 
Changes: https://github.com/Automattic/Iris/compare/1.0.4...1.0.6

props mattwiebe.
fixes #30365.
Built from https://develop.svn.wordpress.org/trunk@30551


git-svn-id: http://core.svn.wordpress.org/trunk@30540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 22:17:22 +00:00
Dominik Schilling
3cb1fb9c18 Editor CSS: Add missing semicolons. 
props cfoellmann.
fixes #30487.
Built from https://develop.svn.wordpress.org/trunk@30550


git-svn-id: http://core.svn.wordpress.org/trunk@30539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 21:54:23 +00:00
Boone Gorges
4ba21e7e0b Fix the unit tests for Imagick alpha. 
These tests were written to use the `assertImageAtAlpha()` helper method, whose
internals were specific to GD. As a result, the tests could not pass. This
changeset introduces GD- and Imagick-specific versions of this method.

Props voldemortensen.
Fixes #24871.
Built from https://develop.svn.wordpress.org/trunk@30549


git-svn-id: http://core.svn.wordpress.org/trunk@30538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 20:57:24 +00:00
Boone Gorges
db7b12e25c Declare an explicit 'order' in test_get_comments_by_user(). 
This change fixes broken builds on older versions of MySQL. See #30462.

Assertions regarding indeterminate secondary ORDER BY clauses will go in
separate test methods. See #30478.
Built from https://develop.svn.wordpress.org/trunk@30548


git-svn-id: http://core.svn.wordpress.org/trunk@30537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 14:56:25 +00:00
Peter Westwood
6c40c6f2e2 Fix the passing of commenter cookie data to the comment API so that we don't try and fetch all unapproved comments for users with no-email address when we only have an author. 
Fixes #19623

Built from https://develop.svn.wordpress.org/trunk@30547


git-svn-id: http://core.svn.wordpress.org/trunk@30536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 10:51:22 +00:00
Drew Jaynes
4b6abbaff4 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30546


git-svn-id: http://core.svn.wordpress.org/trunk@30535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 06:31:21 +00:00
Drew Jaynes
3b6c9519a8 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escape HTML tags in several argument descriptions for `wp_link_pages()`
* Remove an HTML tag from the summary for `prepend_attachment()`
* Backtick-escape inline code in the description for `get_extended()`
* Backtick-escape inline code in the description for `get_post_type_labels()`
* Various markdown formatting in the description for `add_rewrite_endpoint()`
* Markdown-indent a code snippet in the file header for wp-includes/shortcodes.php
* Markdown-indent code snippets in the description for `add_shortcode()

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30545


git-svn-id: http://core.svn.wordpress.org/trunk@30534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 06:15:24 +00:00
Drew Jaynes
188e47869f Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `wp_salt()`
* Backtick-escape inline code in the return description for `get_avatar()`
* Various markdown formatting in the description for `add_filter()`
* Markdown-indent a code snippet in the description for `apply_filters()`
* Backtick-escape inline code in the `@see` description for `apply_filters_ref_array()`
* Backtick-escape inline code in the description for `do_action()`
* Backtick-escape variables in the parameter and return descriptions for `do_action_ref_array()`
* Various markdown formatting in the description for `get_plugin_data()`

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30544


git-svn-id: http://core.svn.wordpress.org/trunk@30533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 06:05:23 +00:00
Drew Jaynes
9955384dbe Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30543


git-svn-id: http://core.svn.wordpress.org/trunk@30532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:53:22 +00:00
Drew Jaynes
b8c612ca1c Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the file header for wp-admin/install-helper.php
* Add markdown formatting and two inline `@see` tags to the description for `translate()`
* Markdown-indent a code snippet in the description for `_n_noop()`
* Remove HTML tags from the summary for `get_media_embedded_in_content()`
* Remove an HTML tag from the summary for `wpview_media_sandbox_styles()`

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30542


git-svn-id: http://core.svn.wordpress.org/trunk@30531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:47:23 +00:00
Drew Jaynes
07c58f5cca Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Markdown-indent a code snippet in the description for `_deprecated_argument()`
* Markdown-indent a code snippet in the description for `wp_localize_script()`
* Backtick-escape HTML tags in two parameter descriptions for `wp_register()`
* Various DocBlock formatting in the description for `get_bloginfo()`
* Remove HTML tag from the summary for `_wp_render_title_tag()`
* Backtick-escape a HTML tag in the description for `get_archives_link()`
* Markdown-indent a code snippet in the description for `wp_admin_css_color()`
* Markdown-indent a code snippet in the description for the `welcome_panel` hook

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30541


git-svn-id: http://core.svn.wordpress.org/trunk@30530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:39:22 +00:00
Drew Jaynes
39da8dd15e Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements in wp-includes/formatting.php:
* Markdown-indent code snippets in the description for `wptexturize()`
* Backtick-escape inline code in a parameter description for `_wptexturize_pushpop_element()`
* Backtick-escape inline code in the description for `shortcode_unautop()`
* Backtick-escape HTML tags in the description for `convert_chars()`
* Markdown-indent a code snippet in the description for `_split_str_by_whitespace()`
* Backtick-escape an `<img>` tag in the description for `translate_smiley()`
* Add markdown formatting to the description for `links_add_target()`
* Backtick-escape HTML tags in the description for `wp_strip_all_tags()`

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30540


git-svn-id: http://core.svn.wordpress.org/trunk@30529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:30:25 +00:00
Drew Jaynes
cc68de7006 Ensure the DocBlock directly precedes the hook line for the post_edit_form_tag action in wp-admin/edit-form-advanced.php. 
This fixes the parser getting confused about which DocBlock belongs to which hook or function in this file.

See #30473.

Built from https://develop.svn.wordpress.org/trunk@30539


git-svn-id: http://core.svn.wordpress.org/trunk@30528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:22:23 +00:00
Drew Jaynes
de809a5a86 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30538


git-svn-id: http://core.svn.wordpress.org/trunk@30527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:19:23 +00:00
Drew Jaynes
273396fe1e Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Backtick-escapes a `<link>` tag in a parameter description for the `embed_oembed_discover` hook
* Inline code fixes in the summary and return description for `WP_List_Table::get_table_classes()`
* Removes HTML markup from the summary for `WP_List_Table::display_rows_or_placeholder()`
* Backtick-escapes a `<tr>` tag in a parameter description for `WP_Users_List_Table::single_row()`
* Converts non-DocBlocks into multi-line comments in `WP_Dependencies::do_items()`
* Removes HTML markup from the summary for the `comment_form_top` hook.
* Inline code and snippet fixes in the description for `wp_get_schedules()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30537


git-svn-id: http://core.svn.wordpress.org/trunk@30526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 04:58:22 +00:00
Drew Jaynes
8f6188ae53 Ensure inline code is markdown-escaped as such, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Two arguments in `_walk_bookmarks()`
* A code snippet in the class header for `WP_Roles`
* A code snippet in the class header for `WP_HTTP_Proxy`
* Inline code fixes in the summary and a parameter description for `WP_oEmbed::discover()`
* An argument description in `_WP_Editors::parse_settings()`
* Inline code fixes in the summary and a parameter description the `embed_oembed_discover` hook.

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30536


git-svn-id: http://core.svn.wordpress.org/trunk@30525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 04:42:22 +00:00
Drew Jaynes
6d0cdd7148 Remove HTML <head> tags from DocBlock summaries in wp-admin/admin-header.php. 
Also better-specify the `$hook_suffix` value in the `admin_head-$hook_suffix` hook docs per hook documentation precedent.

Props rarst for the initial patch.
See #30473

Built from https://develop.svn.wordpress.org/trunk@30535


git-svn-id: http://core.svn.wordpress.org/trunk@30524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 04:27:23 +00:00
Gary Pendergast
12684e0ec8 json_encode() returns different results for non UTF-8 strings in PHP 5.5+, versus earlier versions of PHP. 
This fixes the unit tests that fail in earlier versions, see #30471 for fixing this globally in `wp_json_encode()`.

Built from https://develop.svn.wordpress.org/trunk@30534


git-svn-id: http://core.svn.wordpress.org/trunk@30523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 01:56:24 +00:00
Gary Pendergast
18ae2c0b44 Split the tests for wp_json_encode() into smaller chunks (let's all them "units"). Skip a couple of these tests when running on older versions of PHP that don't support the tested functionality. 
See #28786.

Built from https://develop.svn.wordpress.org/trunk@30533


git-svn-id: http://core.svn.wordpress.org/trunk@30522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-23 23:52:23 +00:00
Drew Jaynes
0fb8811fb6 Improve return description for get_file_data() documentation. 
Also convert an incorrect use of `@see` to `@link`.

Props 5um17 for the initial patch.
Fixes #30466.

Built from https://develop.svn.wordpress.org/trunk@30532


git-svn-id: http://core.svn.wordpress.org/trunk@30521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-23 17:57:22 +00:00
Andrew Ozz
e8a4452f05 Color Schemes: fix the pointer UP arrow color, fixes #30460. 
Built from https://develop.svn.wordpress.org/trunk@30531


git-svn-id: http://core.svn.wordpress.org/trunk@30520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-23 01:26:23 +00:00
Boone Gorges
58256224fe Remove failing test_network_limit() XML-RPC test. 
Test added as a patch on #21292.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30530


git-svn-id: http://core.svn.wordpress.org/trunk@30519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-23 01:23:22 +00:00
Boone Gorges
20302cbd82 Better rewrite rule flushing in test_permalink_without_title(). 
This ensures that the test is not polluted by permalink structure changes in
earlier tests.
Built from https://develop.svn.wordpress.org/trunk@30529


git-svn-id: http://core.svn.wordpress.org/trunk@30518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-23 01:20:24 +00:00
Boone Gorges
144d7ed48c Ensure that wpdb_exposed_methods_for_testing is available to all tests. 
It should be defined in a common library file so that all tests have access to
it, even when run in isolation.

See [30345], #21212.
Built from https://develop.svn.wordpress.org/trunk@30528


git-svn-id: http://core.svn.wordpress.org/trunk@30517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-23 00:47:22 +00:00
Boone Gorges
de1f2d6ad7 Ensure sanitize_user() expected test values are lowercase on multisite. 
[30524] neglected to account for the fact that multisite forces user logins to
lowercase.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30527


git-svn-id: http://core.svn.wordpress.org/trunk@30516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 21:30:24 +00:00
Boone Gorges
21771656ea Stop checking Trac to skip tests against open tickets. 
In general, skipped tests should live only in patches, which are committed at
the same time that the corresponding bug is fixed. In cases where it's
necessary to skip a test, use `markTestSkipped()` to declare this fact
explicitly.

We continue to check Trac when using `WP_UnitTestCase` to run non-core tests.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30526


git-svn-id: http://core.svn.wordpress.org/trunk@30515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 21:11:24 +00:00
Boone Gorges
a18e2f68c7 Repair the seems_utf8() tests that use Big5 encoding. 
* Provide sample data that is actually encoded in Big5.
* Do some actual assertions against that data.

Props akumria.
Fixes #30455.
Built from https://develop.svn.wordpress.org/trunk@30525


git-svn-id: http://core.svn.wordpress.org/trunk@30514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:57:24 +00:00
Boone Gorges
503defbf43 Remove failing test related to the 'offset' param of WP_Query. 
This test has been added as a patch to #18897.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30524


git-svn-id: http://core.svn.wordpress.org/trunk@30513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:46:22 +00:00
Boone Gorges
6a5c146953 Remove failing test related to wp_list_pages(). 
The test has been added as a patch to #27326.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30523


git-svn-id: http://core.svn.wordpress.org/trunk@30512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:44:22 +00:00
Boone Gorges
181fec554f Remove failing test related to wp_unique_post_slug(). 
The test has been added as a patch to #18962.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30522


git-svn-id: http://core.svn.wordpress.org/trunk@30511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:42:22 +00:00
Boone Gorges
7481a15ad8 Remove failing is_textdomain_loaded() test. 
The removed test has been added as a patch to the original ticket, #21319.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30521


git-svn-id: http://core.svn.wordpress.org/trunk@30510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:37:22 +00:00
Boone Gorges
4c40127397 Remove failing assertions from is_serialized() tests. 
They have been moved to new test methods, which have been attached as a patch
to the ticket #9930.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30520


git-svn-id: http://core.svn.wordpress.org/trunk@30509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:35:22 +00:00
Boone Gorges
4f47412a03 Remove failing test in the hooks group. 
The removed test has been added as a patch to #21169.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30519


git-svn-id: http://core.svn.wordpress.org/trunk@30508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:26:22 +00:00
Boone Gorges
f1b5a879c5 Remove skipped tests for WP_Export_Query. 
These tests have been added as a patch to the ticket where the new
functionality was originally proposed, #22435.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30518


git-svn-id: http://core.svn.wordpress.org/trunk@30507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:23:22 +00:00
Boone Gorges
550f8ad9e8 Remove skipped tests for unimplemented JS plural functions. 
The tests have been added as a patch for the original ticket, #22229.

Props MikeHansenMe.
See #22229.
Built from https://develop.svn.wordpress.org/trunk@30517


git-svn-id: http://core.svn.wordpress.org/trunk@30506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:12:23 +00:00
Boone Gorges
3042b7afd5 Remove failing test for unimplemented wp_mail() enhancement. 
The removed test has been added as a patch to the original ticket, #15448.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30516


git-svn-id: http://core.svn.wordpress.org/trunk@30505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 20:06:25 +00:00
Boone Gorges
025d1b388b Improvements to encoded character formatting tests. 
In `sanitize_title_with_dashes()` and `sanitize_user()` tests, we break large
test methods into smaller ones in order to isolate those that actually describe
the bug being reported in ticket #10823. The unit tests that are continuing to
fail have been attached as a patch to that ticket.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30515


git-svn-id: http://core.svn.wordpress.org/trunk@30504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 19:54:21 +00:00
Boone Gorges
3422675eda Remove failing tests related to square brackets being stripped in URL sanitizers. 
These tests have been added as a patch to their original ticket, #16859.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30514


git-svn-id: http://core.svn.wordpress.org/trunk@30503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 15:40:22 +00:00
Boone Gorges
c4d9abb74f Remove failing tests related to WP_User::__unset(). 
These tests have been added as a patch to their original ticket, #20043.

Props MikeHansenMe.
See #30284.
Built from https://develop.svn.wordpress.org/trunk@30513


git-svn-id: http://core.svn.wordpress.org/trunk@30502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 15:36:22 +00:00
Boone Gorges
cb4f0c8b8e Declare user_email when setting up fixtures for count_user_posts() tests. 
Because `setUpBeforeClass()` is called statically and creates its own factory
object, the iterator logic from previous tests is not carried over to these
fixtures, and we risk the possibility of user_email clashes when the tests are
run in certain limited configurations.
Built from https://develop.svn.wordpress.org/trunk@30512


git-svn-id: http://core.svn.wordpress.org/trunk@30501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 15:05:22 +00:00
Boone Gorges
cc10fa74a5 Improve performance of post revision order test. 
`test_revision_order()` was written ([28541], #26042) to ensure that revision
order was properly preserved in two different cases: (1) where the post_date
varied (in which case the revisions would be sorted by post_date DESC) and
(2) where the post_date was the same (in which case sorting would fall back on
ID DESC). In an attempt to ensure that both of these scenarios arose in the
context of a single test, 100 posts were created. We can make the process far
more efficient by manually creating the revisions with the post_dates
explicitly declared, and splitting the two different cases into two separate
test methods.

This test was previously the single worst offender in the entire suite, taking
upwards of 15 seconds to run. All that most maddens and torments; all that stirs
up the lees of things; all truth with malice in it; all that cracks the sinews
and cakes the brain; all the subtle demonisms of life and thought; all evil, to
crazy Boone, were visibly personified, and made practically assailable in
`test_revision_order()`.

See #30017.
Built from https://develop.svn.wordpress.org/trunk@30511


git-svn-id: http://core.svn.wordpress.org/trunk@30500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 14:18:23 +00:00
Boone Gorges
9f40944e49 Remove some failing unit tests from the post group. 
These tests have been added as a patch to ticket #19373.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30510


git-svn-id: http://core.svn.wordpress.org/trunk@30499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 12:04:25 +00:00
Andrew Ozz
d3604f485d TinyMCE: set the image toolbar's z-index to be the same as the other TinyMCE panels, or it is under the editor when in fullscreen mode. See #30147. 
Built from https://develop.svn.wordpress.org/trunk@30509


git-svn-id: http://core.svn.wordpress.org/trunk@30498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-22 02:43:24 +00:00
John Blackbourn
78367f22d5 Abstract the theme browser route paths into attributes so they can be easily overridden. 
Fixes #30116
Props matveb

Built from https://develop.svn.wordpress.org/trunk@30508


git-svn-id: http://core.svn.wordpress.org/trunk@30497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 17:30:22 +00:00
John Blackbourn
b66c58f76a Update the inline docs for wp_die() to reflect parameter changes made in r30355 
See #10551

Built from https://develop.svn.wordpress.org/trunk@30507


git-svn-id: http://core.svn.wordpress.org/trunk@30496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 17:08:23 +00:00
John Blackbourn
53a9e3b420 Add support for WP_Error objects passed to wp_send_json_error(). The error object gets output as an array of error codes and messages, rather than as an empty object. 
Fixes #28978
Props paulschreiber

Built from https://develop.svn.wordpress.org/trunk@30506


git-svn-id: http://core.svn.wordpress.org/trunk@30495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 16:56:23 +00:00
Helen Hou-Sandí
97b412af37 Admin notices: Add more variety and make more generically usable. 
There is now a base class of `notice`, with additional classes of `notice-success`, `notice-warning`, `notice-error`, and a new blue `notice-info`.

Also corrects some misleading notice colors, such as plugin tested up to warnings and login messages.

props avryl, melchoyce.
fixes #27418.

Built from https://develop.svn.wordpress.org/trunk@30505


git-svn-id: http://core.svn.wordpress.org/trunk@30494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 16:41:25 +00:00
Helen Hou-Sandí
c83f96ec61 Sessions UI: Ensure screen readers provide feedback on action taken. 
Also fixes some invalid HTML that occurs on DOM changes.

props joedolson.
fixes #30364.

Built from https://develop.svn.wordpress.org/trunk@30504


git-svn-id: http://core.svn.wordpress.org/trunk@30493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 16:25:23 +00:00
Helen Hou-Sandí
541e6d31af oEmbed: Add support for the Vine endpoint. 
props niallkennedy.
fixes #30426.

Built from https://develop.svn.wordpress.org/trunk@30503


git-svn-id: http://core.svn.wordpress.org/trunk@30492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 16:04:23 +00:00
Drew Jaynes
b0db6e6deb Convert <title> to "title tag" in the DocBlock summary for the admin_title hook. 
Fixes #30437.

Built from https://develop.svn.wordpress.org/trunk@30502


git-svn-id: http://core.svn.wordpress.org/trunk@30491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 07:12:23 +00:00
Sergey Biryukov
8f2842a07e Replace invalid use of ltrim() in attachment_url_to_postid() with substr(). 
props bradyvercher.
fixes #30346.
Built from https://develop.svn.wordpress.org/trunk@30501


git-svn-id: http://core.svn.wordpress.org/trunk@30490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 06:35:22 +00:00
Sergey Biryukov
aad05ece16 Set min-height for menu item title. Add a fallback for empty-titled items. 
props philiparthurmoore.
fixes #30283.
Built from https://develop.svn.wordpress.org/trunk@30500


git-svn-id: http://core.svn.wordpress.org/trunk@30489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 05:57:22 +00:00
John Blackbourn
2aabde8f74 Remove whitespace accidentally introduced in r30498 
See #30335

Built from https://develop.svn.wordpress.org/trunk@30499


git-svn-id: http://core.svn.wordpress.org/trunk@30488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 04:01:22 +00:00
John Blackbourn
196e069c5b split_shared_term is an action, not a filter. 
See #30335

Built from https://develop.svn.wordpress.org/trunk@30498


git-svn-id: http://core.svn.wordpress.org/trunk@30487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:51:21 +00:00
Drew Jaynes
a6fc2d610b Minor syntactical adjustments to the inline documentation for the revision_text_diff_options hook. 
Converts backticked-inline-code to inline `@see` tags (for the full benefit of Code Reference automagical behavior).

See [30396]. See #24908.

Built from https://develop.svn.wordpress.org/trunk@30497


git-svn-id: http://core.svn.wordpress.org/trunk@30486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:50:24 +00:00
Drew Jaynes
2fda44cb77 Add an entry to the changelog for wp_make_link_relative() noting that intentional support was added for relative URLs. 
See #30373.

Built from https://develop.svn.wordpress.org/trunk@30496


git-svn-id: http://core.svn.wordpress.org/trunk@30485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:44:23 +00:00
John Blackbourn
3ace1fac81 Only output an optgroup for installed languages in wp_dropdown_languages() if translations are available. 
See #30335

Built from https://develop.svn.wordpress.org/trunk@30495


git-svn-id: http://core.svn.wordpress.org/trunk@30484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:20:22 +00:00
Boone Gorges
57e358da63 Improve cleanup of cached term_ids after shared terms are split. 
* If the split term ID is stored as 'default_category', 'default_link_category', or 'default_email_category', update it to the new ID.
* If the split term ID is associated with a nav menu item, update that piece of postmeta to the new ID.

Props mboynes.
See #30335.
Built from https://develop.svn.wordpress.org/trunk@30494


git-svn-id: http://core.svn.wordpress.org/trunk@30483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:17:22 +00:00
Boone Gorges
14e6c301ea Pass the taxonomy of the split tt_id to the 'split_shared_term' filter. 
Props mboynes.
See #30335.
Built from https://develop.svn.wordpress.org/trunk@30493


git-svn-id: http://core.svn.wordpress.org/trunk@30482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:14:23 +00:00
Boone Gorges
6f9eaf5df5 Store data about old and new term IDs when shared terms are split. 
Props mboynes.
See #30335.
Built from https://develop.svn.wordpress.org/trunk@30492


git-svn-id: http://core.svn.wordpress.org/trunk@30481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:13:22 +00:00
Dion Hulse
330ab9d484 Update the bundled root CA's used for outgoing HTTPS requests. 
Fixes #30434

Built from https://develop.svn.wordpress.org/trunk@30491


git-svn-id: http://core.svn.wordpress.org/trunk@30480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-21 03:03:22 +00:00
Andrew Ozz
c22be8dbe8 TinyMCE: change the default font size from 100% to 16px to fix some back-compat issues, fixes #30038. 
Built from https://develop.svn.wordpress.org/trunk@30490


git-svn-id: http://core.svn.wordpress.org/trunk@30479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 22:23:24 +00:00
Drew Jaynes
fd1f5bb3ad Update the DocBlock changelogs for the nav_menu_css_class, nav_menu_item_id, and nav_menu_link_attributes hooks following [30358], where $depth parameters were added. 
Props kpdesign.
See [30358]. Fixes #19064.

Built from https://develop.svn.wordpress.org/trunk@30485


git-svn-id: http://core.svn.wordpress.org/trunk@30474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 18:26:23 +00:00
Andrew Nacin
f9408af336 4.1-beta2-30484 
Built from https://develop.svn.wordpress.org/trunk@30484


git-svn-id: http://core.svn.wordpress.org/trunk@30473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 17:45:25 +00:00
John Blackbourn
ce6fb536a8 WordPress 4.1-beta2 
Built from https://develop.svn.wordpress.org/trunk@30481


git-svn-id: http://core.svn.wordpress.org/trunk@30469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 16:53:23 +00:00
John Blackbourn
b50cbe1f4f Correct an SQL syntax error introduced in r30158. Adds tests. 
Fixes #30339
See #18962
Props julien731

Built from https://develop.svn.wordpress.org/trunk@30480


git-svn-id: http://core.svn.wordpress.org/trunk@30468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 16:46:22 +00:00
Ian Stewart
a69a12aab1 Twenty Fifteen: bring back the border between post navigation links we lost in the_post_navigation changes. 
Props iamtakashi, fixes #30414.


Built from https://develop.svn.wordpress.org/trunk@30479


git-svn-id: http://core.svn.wordpress.org/trunk@30467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 16:41:22 +00:00
Andrew Nacin
78a310f23b More tests for [30466]. props xknown. 
Built from https://develop.svn.wordpress.org/trunk@30471


git-svn-id: http://core.svn.wordpress.org/trunk@30462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 16:11:23 +00:00
Andrew Nacin
ccf39f33c9 Prevent high resource usage when hashing large passwords. props mdawaffe, pento 
Built from https://develop.svn.wordpress.org/trunk@30466


git-svn-id: http://core.svn.wordpress.org/trunk@30457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 16:03:24 +00:00
Dominik Schilling
12b2ca45ad Simplify selectors in [30374]. 
props wonderboymusic, adamsilverstein.
see #29326.
Built from https://develop.svn.wordpress.org/trunk@30461


git-svn-id: http://core.svn.wordpress.org/trunk@30452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 15:37:22 +00:00
Dominik Schilling
4b65a37244 grunt autoprefixer for [30374]. 
see #29326.
Built from https://develop.svn.wordpress.org/trunk@30460


git-svn-id: http://core.svn.wordpress.org/trunk@30451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 15:31:23 +00:00
Dominik Schilling
cffba3c1ba Customizer: Use deep-links for Backgrounds, Headers, and Widgets. 
Replace links in admin menu and toolbar to Custom Background/Header screen with deep-links to the Customizer section.
On the Widgets screen display a link to the Customizer widgets panel.

props topher1kenobe, rzen, celloexpressions, westonruter
fixes #25569, #25571, #28032.
Built from https://develop.svn.wordpress.org/trunk@30459


git-svn-id: http://core.svn.wordpress.org/trunk@30450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 15:29:23 +00:00
Andrew Nacin
58dfcb9bb0 Validate image data. 
Built from https://develop.svn.wordpress.org/trunk@30458


git-svn-id: http://core.svn.wordpress.org/trunk@30449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 15:25:22 +00:00
John Blackbourn
473324326d Improvements to the output of the new post navigation template functions, including swapping the position of the previous and next links. 
See #29808
Props obenland

Built from https://develop.svn.wordpress.org/trunk@30457


git-svn-id: http://core.svn.wordpress.org/trunk@30448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 15:19:24 +00:00
Andrew Nacin
6e2f41a2a3 Anchor texturize to shortcodes to improve regex efficiency. 
props miqrogroove.
see #29557 for segfault issues.

Built from https://develop.svn.wordpress.org/trunk@30449


git-svn-id: http://core.svn.wordpress.org/trunk@30443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 14:28:23 +00:00
Andrew Nacin
a6103b30f5 Better validation of the URL used in core HTTP requests. 
Built from https://develop.svn.wordpress.org/trunk@30443


git-svn-id: http://core.svn.wordpress.org/trunk@30438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 14:01:23 +00:00
Andrew Nacin
432e4dcb50 Press This: Ensure the error message is printed. props johnbillion 
Built from https://develop.svn.wordpress.org/trunk@30438


git-svn-id: http://core.svn.wordpress.org/trunk@30433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 13:58:23 +00:00
Andrew Nacin
87023d64b4 TinyMCE: Verify HTML in captions. props azaozz 
Built from https://develop.svn.wordpress.org/trunk@30435


git-svn-id: http://core.svn.wordpress.org/trunk@30430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 13:49:22 +00:00
Andrew Nacin
fce07e17eb Invalidate password keys when a user's email changes. 
Built from https://develop.svn.wordpress.org/trunk@30430


git-svn-id: http://core.svn.wordpress.org/trunk@30425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 13:40:23 +00:00
Andrew Nacin
e7614d6c45 Fix typo in style filter. props miqrogroove 
Built from https://develop.svn.wordpress.org/trunk@30425


git-svn-id: http://core.svn.wordpress.org/trunk@30420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 13:15:24 +00:00
Andrew Nacin
c2f334bf3c Playlists are video by default. props duck_ 
Built from https://develop.svn.wordpress.org/trunk@30422


git-svn-id: http://core.svn.wordpress.org/trunk@30417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 13:11:23 +00:00
Andrew Nacin
b271e36f47 Form validation for password resets. 
Built from https://develop.svn.wordpress.org/trunk@30417


git-svn-id: http://core.svn.wordpress.org/trunk@30412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 12:22:22 +00:00
Andrew Nacin
ddb3ee5057 Use hash_equals() for old md5 hashes. 
Built from https://develop.svn.wordpress.org/trunk@30412


git-svn-id: http://core.svn.wordpress.org/trunk@30407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 11:49:23 +00:00
Dion Hulse
871176e42b Bump the $wp_version. 
This version string controls more than you might first imagine, but the important thing to note for now, is that this needs to contain a revision number in order for nightly builds to include a revision number.
If a nightly build doesn't include a revision number, Background Updates won't occur for Development users (after all, 4.1-beta1 == 4.1-beta1, which is already installed).
See #30405

Built from https://develop.svn.wordpress.org/trunk@30411


git-svn-id: http://core.svn.wordpress.org/trunk@30406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 11:36:22 +00:00
Andrew Ozz
d4a36f2c7a TinyMCE: update to the latest dev. version, 4.1.6+. Fixes #30411. 
Built from https://develop.svn.wordpress.org/trunk@30397


git-svn-id: http://core.svn.wordpress.org/trunk@30393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-20 00:50:23 +00:00
John Blackbourn
f561b53695 WordPress 4.1-beta1 
Built from https://develop.svn.wordpress.org/trunk@30348


git-svn-id: http://core.svn.wordpress.org/trunk@30347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 21:57:24 +00:00
Boone Gorges
866cfdf19b Flush cache for newly created term in _split_shared_term(). 
The term itself does not have any cached values yet, but in some cases the new
term's taxonomy may need its cached hierarchy to be refreshed as a result of
the term splitting.

Props jorbin.
See #30335.
Built from https://develop.svn.wordpress.org/trunk@30347


git-svn-id: http://core.svn.wordpress.org/trunk@30346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 21:53:22 +00:00
Gary Pendergast
e61bebdbfc If a saving a post fails, remove any invalid characters (such as emoji) from the primary text fields, then try to save it again. 
See #21212.


Built from https://develop.svn.wordpress.org/trunk@30346


git-svn-id: http://core.svn.wordpress.org/trunk@30345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 21:34:22 +00:00
Gary Pendergast
ecc27d0b27 When creating a post containing emoji, the post can be saved incorrectly if MySQL isn't using a character set that supports emoji. 
This change prevents the save from occurring, so it can be handled correctly in the UI.

See #21212.

Built from https://develop.svn.wordpress.org/trunk@30345


git-svn-id: http://core.svn.wordpress.org/trunk@30344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 21:28:22 +00:00
Boone Gorges
c5bb06dafe Reinstate term splitting on term update. 
Originally introduced in [30241] and reverted in [30336], term splitting is
back and better than ever. Now with *more unit tests* and *improved treatment
of child terms*!

See #30335.
Built from https://develop.svn.wordpress.org/trunk@30344


git-svn-id: http://core.svn.wordpress.org/trunk@30343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 21:27:24 +00:00
Dominik Schilling
fe63317dad Sync our jQuery UI styles with jQuery UI 1.11.2 CSS. 
Removes also our own implementations for touch-action compatibility for IE Touch.

props georgestephanis, ocean90.
fixes #26843.
Built from https://develop.svn.wordpress.org/trunk@30343


git-svn-id: http://core.svn.wordpress.org/trunk@30342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 19:28:22 +00:00
Dominik Schilling
52f51d65ae Media: Remove another unused string. 
props pavelevap.
see #29741.
Built from https://develop.svn.wordpress.org/trunk@30342


git-svn-id: http://core.svn.wordpress.org/trunk@30341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 17:46:22 +00:00
Dominik Schilling
f34d3b1b5a Media: Remove unused string. 
props pavelevap.
fixes #29741.
Built from https://develop.svn.wordpress.org/trunk@30341


git-svn-id: http://core.svn.wordpress.org/trunk@30340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 17:31:23 +00:00
Andrew Nacin
b922be3f71 Only use the 'Installed' optgroup in wp_dropdown_languages() if it's needed. 
see #30335.

Built from https://develop.svn.wordpress.org/trunk@30340


git-svn-id: http://core.svn.wordpress.org/trunk@30339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-14 03:24:23 +00:00
Andrew Ozz
560574da45 TinyMCE: set the image toolbar's z-index higher than the editor when the new DFW is active. See #30147. 
Built from https://develop.svn.wordpress.org/trunk@30339


git-svn-id: http://core.svn.wordpress.org/trunk@30338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 23:29:22 +00:00
Mark Jaquith
7c4b9419f4 Introduce Distraction-Free Writing v2, a re-think of DFW that uses the main editor instance 
* the "DFW" button is now an auto/off toggle
* defaulting to auto during beta, decide later for release
* "auto" means that DFW gets enabled as you start typing in editor
* tabbing and mousing out will bring the full interface back
* there is a slight grace period during which your mouse can quickly return

Feature plugin work happened here: https://github.com/avryl/focus

props avryl, azaozz, Michael Arestad
fixes #29806
Built from https://develop.svn.wordpress.org/trunk@30338


git-svn-id: http://core.svn.wordpress.org/trunk@30337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 22:31:22 +00:00
Aaron Jorbin
95513a0bca When asserting microtime output as a number, make it a number 
microtime is by default a string. Doing a greater then or less than check of that string is a bad idea since it uses the first part (the micro part of microtime) rather then the actual time. This adds a helper to convert microtime output into a float which we can then use to properly compare the output of microtime.

This fixes an intermittent test failure.

fixes #30336


Built from https://develop.svn.wordpress.org/trunk@30337


git-svn-id: http://core.svn.wordpress.org/trunk@30336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 22:04:23 +00:00
Boone Gorges
eb8f89bb13 Don't split shared terms on term update. 
Splitting shared terms means assigning a new term_id to a given term_taxonomy_id.
It was uncovered that this change could cause problems for sites that have
cached the original term_id somehow - say, in postmeta - since future lookups
using that term_id will now fail.

Removing for 4.1-beta1. We'll look at improvements to backward compatibility
to try to get this back into a later beta.

Props mboynes.
See #30335.
Built from https://develop.svn.wordpress.org/trunk@30336


git-svn-id: http://core.svn.wordpress.org/trunk@30335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 20:05:24 +00:00
Dominik Schilling
8fb6f317ff Site Language: Install translations on the fly. 
The language dropdown now includes installed languages and all available translations when the filesystem is writable by WordPress.
Go to wp-admin/options-general.php, select one of the available translations, submit the form and let WordPress handle the rest.
Works for Multisite's Default Language too.

see #29395.
Built from https://develop.svn.wordpress.org/trunk@30335


git-svn-id: http://core.svn.wordpress.org/trunk@30334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 17:01:24 +00:00
Dominik Schilling
4a1cb796fc Improvements to [30333]: 
* Move `.hide-if-no-js` class to table row
* Add a wrapper class
* Add missing translators comment

see #30264.
Built from https://develop.svn.wordpress.org/trunk@30334


git-svn-id: http://core.svn.wordpress.org/trunk@30333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 15:54:20 +00:00
John Blackbourn
c02845330e Introduce a button on the user profile screen which clears all other sessions, and on the user editing screen which clears all sessions. Only appears when there are applicable sessions which can be cleared. 
See #30264.
Props jorbin, ocean90, johnbillion


Built from https://develop.svn.wordpress.org/trunk@30333


git-svn-id: http://core.svn.wordpress.org/trunk@30332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 15:21:21 +00:00
Dominik Schilling
f93a197089 Fix selector for the "Live Widget Previews" feature pointer. 
props rzen.
fixes #30158.
Built from https://develop.svn.wordpress.org/trunk@30332


git-svn-id: http://core.svn.wordpress.org/trunk@30331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:50:22 +00:00
Dominik Schilling
e1cf2b8523 Twenty Fifteen: Add a transparent border to a link in the footer to avoid jumpiness on hover. 
props iamtakashi.
fixes #30332.
Built from https://develop.svn.wordpress.org/trunk@30331


git-svn-id: http://core.svn.wordpress.org/trunk@30330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:42:24 +00:00
Dominik Schilling
b8bfbf42e6 Color Picker: Allow to override mode and width values for Iris via wpColorPicker options. 
props jtsternberg.
fixes #30182.
Built from https://develop.svn.wordpress.org/trunk@30330


git-svn-id: http://core.svn.wordpress.org/trunk@30329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:34:23 +00:00
Dominik Schilling
41197a7c31 Customizer: Improve ability to filter active state for widget area Customizer sections. 
* Mark panels, sections, controls as active if preview explicitly indicates.
* Introduce `WP_Customize_Sidebar_Section` PHP class, and `SidebarSection` JS class.
* Move logic for determining whether a sidebar section is active from the `SidebarControl` to `SidebarSection`.

props westonruter.
fixes #30235.
Built from https://develop.svn.wordpress.org/trunk@30329


git-svn-id: http://core.svn.wordpress.org/trunk@30328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:19:23 +00:00
Boone Gorges
92e3890daa Correct @since tag in count_user_posts() docs. 
Props pavelevap, DrewAPicture.
See #21364.
Built from https://develop.svn.wordpress.org/trunk@30328


git-svn-id: http://core.svn.wordpress.org/trunk@30327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:15:23 +00:00
Dominik Schilling
120cb5e6ef Improve keyboard accessibility on Custom Header and Custom Background screen. 
props florianziegler.
fixes #29289.
Built from https://develop.svn.wordpress.org/trunk@30327


git-svn-id: http://core.svn.wordpress.org/trunk@30326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 12:00:57 +00:00
Dominik Schilling
e0c9ba2d63 Customizer: Prevent double-encoding in WP_Customize_Control. 
Control's label and description may include HTML.

fixes #29572.
Built from https://develop.svn.wordpress.org/trunk@30326


git-svn-id: http://core.svn.wordpress.org/trunk@30325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 11:44:23 +00:00
Ian Stewart
3acf55cf96 Twenty Fifteen: cleaning up JS introduced in r30305 that doesn't pass jshint. 
Props boonebgorges, fixes #29988.


Built from https://develop.svn.wordpress.org/trunk@30325


git-svn-id: http://core.svn.wordpress.org/trunk@30324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 03:18:23 +00:00
Ian Stewart
3f967c8f1a Twenty Fifteen: unfix the sidebar if we have a menu with submenus as there is a chance visitors might not be able to scroll down to see submenus in some situations. 
Props mattwiebe, fixes #30208.


Built from https://develop.svn.wordpress.org/trunk@30324


git-svn-id: http://core.svn.wordpress.org/trunk@30323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 03:09:22 +00:00
Boone Gorges
912cdc5978 Pass query object to 'the_post' filter. 
Props tlovett1.
Fixes #30327.
Built from https://develop.svn.wordpress.org/trunk@30323


git-svn-id: http://core.svn.wordpress.org/trunk@30322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 02:25:22 +00:00
Boone Gorges
a0b8caa29b Introduce $post_type param for count_user_posts(). 
Props Caspie, engelen, DrewAPicture.
Fixes #21364.
Built from https://develop.svn.wordpress.org/trunk@30322


git-svn-id: http://core.svn.wordpress.org/trunk@30321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 02:19:22 +00:00
Andrew Ozz
6b9b865b33 Twenty Fifteen: reduce the margins on the editor body in esitor-style.css. Fixes #30331. 
Built from https://develop.svn.wordpress.org/trunk@30321


git-svn-id: http://core.svn.wordpress.org/trunk@30320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 02:02:24 +00:00
Boone Gorges
d7df822944 Manually delete fixture in test_mysqli_flush_sync(). 
This test creates a dummy post and subsequently runs a query containing
`DROP PROCEDURE`. This latter query implies a `COMMIT`, which means that the
post is not cleaned up for later tests. Manually deleting the post with
`wp_delete_post()` solves this problem.

Fixes #28155.
Built from https://develop.svn.wordpress.org/trunk@30320


git-svn-id: http://core.svn.wordpress.org/trunk@30319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 02:00:21 +00:00
Andrew Ozz
14ae707fd6 Fix typo in translatable string, see #30147. 
Built from https://develop.svn.wordpress.org/trunk@30319


git-svn-id: http://core.svn.wordpress.org/trunk@30318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 01:00:23 +00:00
Andrew Ozz
69105d29e8 TinyMCE: enhance the inline toolbar for images: 
- Add alignment (left, center, right, none) buttons.
- Position the menu above the image when possible, except on iOS.
- Fix selecting images on iOS.
First run, part props avryl. See #30147.
Built from https://develop.svn.wordpress.org/trunk@30318


git-svn-id: http://core.svn.wordpress.org/trunk@30317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-13 00:56:22 +00:00
Ian Stewart
07eba31e0b Twenty Fifteen: improve appearance of page links when there are tons of pages to link to 
Props iamtakashi, fixes #30301


Built from https://develop.svn.wordpress.org/trunk@30317


git-svn-id: http://core.svn.wordpress.org/trunk@30316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 23:39:23 +00:00
Ian Stewart
40c73b7d0d Twenty Fifteen: adding context to pagination links for screenreaders. 
Props afercia, iamtakashi, fixes #30152


Built from https://develop.svn.wordpress.org/trunk@30316


git-svn-id: http://core.svn.wordpress.org/trunk@30315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 23:26:25 +00:00
Ian Stewart
99a35f20e6 Twenty Fifteen: since color schemes can be customized let's call them base color schemes instead of just color schemes. 
Props celloexpressions, iandstewart, fixes #30316


Built from https://develop.svn.wordpress.org/trunk@30315


git-svn-id: http://core.svn.wordpress.org/trunk@30314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 23:01:21 +00:00
Ian Stewart
7f970d53b1 Twenty Fifteen: adding context to page links for screenreaders. 
Props afercia, fixes #30174.


Built from https://develop.svn.wordpress.org/trunk@30314


git-svn-id: http://core.svn.wordpress.org/trunk@30313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 22:55:22 +00:00
Helen Hou-Sandí
06201646c3 Use a brighter blue against dark backgrounds in the admin menu and toolbar. 
Not only does this pass contrast guidelines, but it also visually appears closer to the original highlight blue used against light backgrounds.

props melchoyce. fixes #30323.

Built from https://develop.svn.wordpress.org/trunk@30313


git-svn-id: http://core.svn.wordpress.org/trunk@30312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 20:28:22 +00:00
Ian Stewart
50271a97d5 Twenty Fifteen: clean up sprintf from template tags and use the correct escaping for twentyfifteen template tags. 
Props aprea, obenland, fixes #30319


Built from https://develop.svn.wordpress.org/trunk@30312


git-svn-id: http://core.svn.wordpress.org/trunk@30311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 17:21:21 +00:00
Dion Hulse
e17d09f233 PHP 5.2 compatibility for [30310], __DIR__ wasn't added until PHP 5.3. Props TobiasBg. Fixes #29628 
Built from https://develop.svn.wordpress.org/trunk@30311


git-svn-id: http://core.svn.wordpress.org/trunk@30310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 10:44:23 +00:00
Dion Hulse
3e702d8b52 Always use a full filesystem path when including the FTP handler in PemFTP. This prevents other files in the includes directory being scanned/included accidentally. 
See #29628

Built from https://develop.svn.wordpress.org/trunk@30310


git-svn-id: http://core.svn.wordpress.org/trunk@30309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-12 03:06:23 +00:00
Dominik Schilling
6d83c8c29e Customizer: Add support for the media library in Background Image controls. 
`WP_Customize_Upload_Control` (PHP) and `api.UploadControl` (JS) can now open the media modal.

props celloexpressions, and ericlewis for docs.
see #21483.
Built from https://develop.svn.wordpress.org/trunk@30309


git-svn-id: http://core.svn.wordpress.org/trunk@30308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 23:52:22 +00:00
Dominik Schilling
8b32164b67 Customizer: Trigger widget-added event when initializing. 
Widget controls are now added to the pane dynamically via JavaScript, see #28709.
Remove the event trigger from `SidebarControl.addWidget()` as it's covered by `WidgetControl.ready()`.

props westonruter.
fixes #30236.
Built from https://develop.svn.wordpress.org/trunk@30308


git-svn-id: http://core.svn.wordpress.org/trunk@30307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 22:46:23 +00:00
Dominik Schilling
d21799ee1f Customizer: Use jQuery.fn.toggle() instead of slideUp/slideDown if panel/section/control is not inserted into DOM yet. 
jQuery does nothing when calling `slideUp` on elements that are not inserted into the DOM yet, which can now be the case now when first loading the Customizer as the panels, sections and controls get dynamically inserted, see #28709.

props westonruter.
fixes #30251.
Built from https://develop.svn.wordpress.org/trunk@30307


git-svn-id: http://core.svn.wordpress.org/trunk@30306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 22:37:22 +00:00
Dominik Schilling
b250062311 Customizer: When navigating around the site within the Customizer preview, update the document title. 
props westonruter.
fixes #28542.
Built from https://develop.svn.wordpress.org/trunk@30306


git-svn-id: http://core.svn.wordpress.org/trunk@30305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 22:29:23 +00:00
Ian Stewart
1317409eda Twenty Fifteen: Minor formatting and docs tweaks, clearer variable name. 
Props celloexpressions, see #29988


Built from https://develop.svn.wordpress.org/trunk@30305


git-svn-id: http://core.svn.wordpress.org/trunk@30304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 19:36:23 +00:00
Ian Stewart
87bd82a0ab Twenty Fifteen: simplify the code used to generate screen reader text for the is_home title. 
Props davidakennedy, fixes #30305


Built from https://develop.svn.wordpress.org/trunk@30304


git-svn-id: http://core.svn.wordpress.org/trunk@30303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 19:24:22 +00:00
Ian Stewart
47ec29c1ba Twenty Fifteen: create consistent spacing with embeds and images. 
Props afercia, fixes #30286


Built from https://develop.svn.wordpress.org/trunk@30303


git-svn-id: http://core.svn.wordpress.org/trunk@30302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 19:04:21 +00:00
Ian Stewart
1f2397af34 Twenty Fifteen: simpler CSS by using divs instead of spans for menu descriptions. 
Props philiparthurmoore, fixes #30296


Built from https://develop.svn.wordpress.org/trunk@30302


git-svn-id: http://core.svn.wordpress.org/trunk@30301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 19:02:22 +00:00
Boone Gorges
5fe8fa2b40 Correct grammar error in WP_Date_Query error message. 
Props Offereins.
See #25834.
Built from https://develop.svn.wordpress.org/trunk@30301


git-svn-id: http://core.svn.wordpress.org/trunk@30300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 14:56:24 +00:00
Boone Gorges
4cf91d7c1d Improve localization for WP_Date_Query error strings. 
* Don't create an extra variable for the string when it's only used once.
* Avoid using `<code>` HTML tags inside of translatable string.
* Improve data types and escaping on sprintfed values.

Props dd32.
Fixes #25834.
Built from https://develop.svn.wordpress.org/trunk@30300


git-svn-id: http://core.svn.wordpress.org/trunk@30299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 13:24:24 +00:00
Gary Pendergast
21467af4db wpdb: When flushing results on a mysqli connection, make sure that wpdb::$dbh is a valid mysqli connection handle. 
Fixes a unit test failure introduced in [30297].

Fixes #28155.

Props soulseekah.


Built from https://develop.svn.wordpress.org/trunk@30299


git-svn-id: http://core.svn.wordpress.org/trunk@30298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-11 02:17:28 +00:00
Boone Gorges
dd61164577 Exclude external-http tests when running phpunit. 
The external-http tests are very slow, and `Wp_Http` functionality is fairly
isolated, so the benefits of skipping these tests by default outweigh the
risks.

A `grunt phpunit:external-http` subtask has been added, to ensure that the
tests are executed during exhaustive runs of the test suite, such as in
continuous integration.

Fixes #30304.
Built from https://develop.svn.wordpress.org/trunk@30298


git-svn-id: http://core.svn.wordpress.org/trunk@30297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-10 14:49:24 +00:00
Gary Pendergast
0013150649 wpdb::flush() was not flushing results correctly when using mysqli. 
This change also allows stored procedures or queries made with `mysqli_multi_query()` to be flushed.

Includes unit tests.

Fixes #28155.

Props soulseekah.

Built from https://develop.svn.wordpress.org/trunk@30297


git-svn-id: http://core.svn.wordpress.org/trunk@30296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-10 05:40:23 +00:00
Andrew Ozz
5f27bdc78d TinyMCE: enable direct calls to _WP_Editors::wp_mce_translation(). When using TinyMCE directly, this makes it easier to load the translation of the default strings. Fixes #30293. 
Built from https://develop.svn.wordpress.org/trunk@30296


git-svn-id: http://core.svn.wordpress.org/trunk@30295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-10 02:07:22 +00:00
Boone Gorges
383c75db29 Fix PHP notice in Tests_Feed_RSS2::test_items(). 
A notice was being thrown when `get_the_tags()` returned false, and `foreach()`
was run over that return value.

See [30283].
Built from https://develop.svn.wordpress.org/trunk@30295


git-svn-id: http://core.svn.wordpress.org/trunk@30294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-10 02:05:22 +00:00
Andrew Ozz
b3da068590 TinyMCE: remove strings that are not translated before outputting the translations. Fixes #27797. 
Built from https://develop.svn.wordpress.org/trunk@30294


git-svn-id: http://core.svn.wordpress.org/trunk@30293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-10 02:00:22 +00:00
Andrew Ozz
ba10ab197b Heartbeat: 
- Use the page visibility API (when available) and document.hasFocus() instead of window.onfocus/onblur. Improves speeding up/slowing down the interval and works for iframes by default.
- Add a setting for minimal interval. Maximum value is 10 min. This overrides all other intervals and cannot be changed after setting it at initialization. Can be used to reduce the frequency of requests on hosts that have low limits for used CPU time, etc.
- Extend the setting of interval to support 120 sec. (60 sec, is still the default).
- Always suspend after one hour of keyboard/mouse/touch inactivity.
Fixes #29779.
Built from https://develop.svn.wordpress.org/trunk@30293


git-svn-id: http://core.svn.wordpress.org/trunk@30292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-10 01:47:24 +00:00
Gary Pendergast
f572927353 WPDB's __get() function should perform strict comparisons against member names 
Built from https://develop.svn.wordpress.org/trunk@30292


git-svn-id: http://core.svn.wordpress.org/trunk@30291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-09 12:04:23 +00:00
Aaron Jorbin
2508d31b81 Remove failing Unbalanced tags tests 
Patch with tests added to #6297 for use in the future

Props MikeHansenMe for creating patch of current unit test

see #30284

Built from https://develop.svn.wordpress.org/trunk@30291


git-svn-id: http://core.svn.wordpress.org/trunk@30290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 23:15:23 +00:00
Aaron Jorbin
70416f2225 Remove failing shortcode unit tests 
Test added to #14050 in case we want to include it in a future fix.

see #30284


Built from https://develop.svn.wordpress.org/trunk@30290


git-svn-id: http://core.svn.wordpress.org/trunk@30289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 22:51:22 +00:00
Aaron Jorbin
2ed6de333b Remove failing uploadfile test in trunk 
The test has been added to #11946 and can be readded when that ticket is fixed.

Props MikeHansenMe for creating patch of current unit test

See #30284


Built from https://develop.svn.wordpress.org/trunk@30289


git-svn-id: http://core.svn.wordpress.org/trunk@30288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 21:56:22 +00:00
Drew Jaynes
3e94d3a931 Fix incorrect documentation in the DocBlocks for get_lastpostmodified() and _get_last_post_time(). 
Props ericlewis for the initial patch.
Fixes #30249.

Built from https://develop.svn.wordpress.org/trunk@30287


git-svn-id: http://core.svn.wordpress.org/trunk@30287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 21:08:45 +00:00
Jeremy Felt
112f854021 Move tests for ms_files_rewriting to separate group, ms-files 
When the `ms_files_rewriting` flag is enabled, `ms_upload_constants()` is required to properly set upload directory constants. Once this fires, it is impossible to clean up for a non `ms_files_rewriting` test by turning the option back off.

Excluding these tests by default offer a more consistent environment overall. Any tests written for uploaded files in multisite should ideally have a correspondign test in this area.

This commit also moves existing `ms_files_rewriting` tests for `test_switch_upload_dir()`.

Fixes #30256

Built from https://develop.svn.wordpress.org/trunk@30286


git-svn-id: http://core.svn.wordpress.org/trunk@30286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 21:08:24 +00:00
Boone Gorges
ef442d8224 Remove failing test related to post galleries. 
It relied on the old _WPDataset technique, which is no longer used.

The test has been added to #UT30 as a patch, in case anyone wants to make
future use of it.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30285


git-svn-id: http://core.svn.wordpress.org/trunk@30285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 21:02:22 +00:00
Drew Jaynes
92c153aa8c Fix the syntax for some status-related documentation introduced in [30155]. 
* Variables in DocBlocks should be backtick-escaped
* Parameter and return types should be as specific as possible
* `@param` types and variables should align with each other, but not intentionally with the `@return` description

See #30230.

Built from https://develop.svn.wordpress.org/trunk@30284


git-svn-id: http://core.svn.wordpress.org/trunk@30284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 20:56:22 +00:00
Boone Gorges
77e2821d54 Improve Tests_Feed_RSS2::test_items(). 
* Better reference to post author, to avoid PHP notices.
* Code styling.
* More reliable checking of tags and categories.

Props kurtpayne.
Fixes #UT32. See #30284.
Built from https://develop.svn.wordpress.org/trunk@30283


git-svn-id: http://core.svn.wordpress.org/trunk@30283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 20:55:22 +00:00
Boone Gorges
9e5cb0301c Remove failing unit tests from 'canonical' group. 
Each removed test has been turned into a patch and posted to the open ticket
that it belongs to.

See #30284.
Built from https://develop.svn.wordpress.org/trunk@30282


git-svn-id: http://core.svn.wordpress.org/trunk@30282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 20:37:22 +00:00
Drew Jaynes
e7b465046a Cross-reference WP_Comment_Query::query() as the location for finding information on default arguments for WP_Comment_Query. 
Also updates the return types on `get_comments()` and `get_approved_comments()`, as an integer can also be returned if the `$count` argument is true.

Fixes #30111.

Built from https://develop.svn.wordpress.org/trunk@30281


git-svn-id: http://core.svn.wordpress.org/trunk@30281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 20:35:22 +00:00
Drew Jaynes
35e509b0c8 Document default arguments for WP_Comment_Query class as a hash notation. 
Props boonebgorges, DrewAPicture.
See #30111.

Built from https://develop.svn.wordpress.org/trunk@30280


git-svn-id: http://core.svn.wordpress.org/trunk@30280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 20:19:23 +00:00
Jeremy Felt
bd3a0b33b1 Use remove_added_uploads() in tearDown() for XMLRPC tests 
This cleanup avoids false test failures due to incrementing filenames in the uploads directory.

Fixes #30290

Built from https://develop.svn.wordpress.org/trunk@30279


git-svn-id: http://core.svn.wordpress.org/trunk@30279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 20:18:22 +00:00
Boone Gorges
0b90415e75 In unit tests, use wpmu_delete_user() to delete users when is_multisite(). 
`wp_delete_user()` doesn't remove the user from the database, which causes all
sorts of problems in certain cases.

Props jeremyfelt.
See [30277], #30017.
Built from https://develop.svn.wordpress.org/trunk@30278


git-svn-id: http://core.svn.wordpress.org/trunk@30278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 19:56:22 +00:00
Boone Gorges
b5b923c347 Share fixtures across 'canonical' automated tests. 
Sharing these fixtures results in a speed improvement of almost one minute per
run of the test suite.

My hope is that future WordPress developers will spend this extra minute with
their loved ones, for life on this earth is short, my friends, and the moments
you spend watching WP generate test data can never again be reclaimed from the
grizzled clutches of Time, and none of us are really getting younger, I mean,
geez, have you looked in the mirror lately, Gandalf?

See #30017.
Built from https://develop.svn.wordpress.org/trunk@30277


git-svn-id: http://core.svn.wordpress.org/trunk@30277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 19:29:22 +00:00
Boone Gorges
b6d3190be2 Share fixtures across a number of query-related test classes. 
This shaves 10-20 seconds off the running time for the suite.

See #30017.
Built from https://develop.svn.wordpress.org/trunk@30276


git-svn-id: http://core.svn.wordpress.org/trunk@30276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-08 15:30:25 +00:00
Ian Stewart
68a6a69a91 Twenty Fifteen: updates to customize-preview.js missed in r30274. 
Props celloexpressions, See #29988.


Built from https://develop.svn.wordpress.org/trunk@30275


git-svn-id: http://core.svn.wordpress.org/trunk@30275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 21:11:25 +00:00
Ian Stewart
fa81522cb2 Twenty Fifteen: add instant updating of color schemes to the customizer with postMessage. 
Props celloexpressions, bradyvercher, westonruter, fixes #29988.



Built from https://develop.svn.wordpress.org/trunk@30274


git-svn-id: http://core.svn.wordpress.org/trunk@30274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 20:55:23 +00:00
Ian Stewart
066967be6c Twenty Fifteen: Removing email obfuscation from social links menu. 
We really should be doing this in all menus, at which point this becomes core or plugin functionality, not a theme feature.

Closes #30214.


Built from https://develop.svn.wordpress.org/trunk@30273


git-svn-id: http://core.svn.wordpress.org/trunk@30273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 17:38:21 +00:00
Ian Stewart
c3ec04c532 Twenty Fifteen: adding help text to explain how color changes to header and sidebar are affected by responsive design. 
Props iamtakashi, iandstewart, fixes #30165.


Built from https://develop.svn.wordpress.org/trunk@30272


git-svn-id: http://core.svn.wordpress.org/trunk@30272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 17:31:22 +00:00
Ian Stewart
78c26017c6 Twenty Fifteen: improve naming and documentation of customizer js files to match core filenaming conventions. 
Props celloexpressions, fixes #30160.


Built from https://develop.svn.wordpress.org/trunk@30271


git-svn-id: http://core.svn.wordpress.org/trunk@30271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 17:20:22 +00:00
Ian Stewart
1b0b11b593 Twenty Fifteen: use antispambot to obfuscate email adresses in the social links menu. 
Props tywayne, fixes #30214.


Built from https://develop.svn.wordpress.org/trunk@30270


git-svn-id: http://core.svn.wordpress.org/trunk@30270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 16:46:21 +00:00
Ian Stewart
85fd2fa467 Twenty Fifteen: update earlier patch to borders on linked images so we're not affecting the display of linked icons in widgets. 
Props iamtakashi, fixes #29963.


Built from https://develop.svn.wordpress.org/trunk@30269


git-svn-id: http://core.svn.wordpress.org/trunk@30269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 16:34:24 +00:00
Boone Gorges
7ca9e7d428 Correct variable name in WP_UnitTestCase::temp_filename(). 
Built from https://develop.svn.wordpress.org/trunk@30268


git-svn-id: http://core.svn.wordpress.org/trunk@30268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 01:37:21 +00:00
Boone Gorges
88de93790b Unset the default permalink structure after installing Multisite for automated tests. 
Most of our unit tests that involve permalinks expect non-pretty permalinks;
this is the default setting for WP. However, when the test suite installs
multisite, `populate_network()` is run before WP recogizes itself as multisite,
which leads to pretty permalinks being set. This breaks a number of unit
tests in ways that are difficult to trace.
Built from https://develop.svn.wordpress.org/trunk@30267


git-svn-id: http://core.svn.wordpress.org/trunk@30267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-07 01:25:22 +00:00
Boone Gorges
0b1cd9a67a Use assertEqualSets() for some WP_Comment_Query tests. 
Built from https://develop.svn.wordpress.org/trunk@30266


git-svn-id: http://core.svn.wordpress.org/trunk@30266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-06 22:28:25 +00:00
Boone Gorges
c357de63ef Don't force child_of=0 for non-hierarchical taxonomies in get_terms(). 
This forcing appears to have been introduced to save unnecessary queries, but
(a) in some cases it appeared to be causing *more* queries, and (b) it caused
incorrect results when the 'exclude_tree' param of `get_terms()` called
`get_terms()` on each item in the tree using the 'child_of' param.

Fixes #30275.
Built from https://develop.svn.wordpress.org/trunk@30265


git-svn-id: http://core.svn.wordpress.org/trunk@30265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-06 21:47:23 +00:00
Boone Gorges
5ce7ae59df Add tests for get_adjacent_post_link() wrappers. 
Props MikeHansenMe.
See #29663.
Built from https://develop.svn.wordpress.org/trunk@30264


git-svn-id: http://core.svn.wordpress.org/trunk@30264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-06 20:17:22 +00:00
Boone Gorges
4743ee9326 In get_adjacent_post(), $excluded_terms should check term_id rather than term_taxonom_id. 
See #29663, #22112.
Built from https://develop.svn.wordpress.org/trunk@30263


git-svn-id: http://core.svn.wordpress.org/trunk@30263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-06 20:12:22 +00:00
Ian Stewart
cd0ba24e95 Twenty Fifteen: Our next-previous labels were reversed. 
Props iamtakashi, fixes #30265.


Built from https://develop.svn.wordpress.org/trunk@30247


git-svn-id: http://core.svn.wordpress.org/trunk@30247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 20:31:22 +00:00
Scott Taylor
03ea739661 In get_page_children(), only check $page->ancestors once to avoid duplicates when the function recurses. Adds an argument, $ancestors. 
Fixes #18962.

Built from https://develop.svn.wordpress.org/trunk@30246


git-svn-id: http://core.svn.wordpress.org/trunk@30246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 20:05:24 +00:00
Scott Taylor
d5a9d63114 Improve wp.media documentation. 
Props ericlewis.
See #28459.

Built from https://develop.svn.wordpress.org/trunk@30245


git-svn-id: http://core.svn.wordpress.org/trunk@30245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 19:39:22 +00:00
Scott Taylor
2d1080aed1 Improve wp.Uploader documentation. 
Props ericlewis.
See #30260.

Built from https://develop.svn.wordpress.org/trunk@30244


git-svn-id: http://core.svn.wordpress.org/trunk@30244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 19:37:23 +00:00
Ian Stewart
6ad06ca03d Twenty Fifteen: "detach" widgets from the header in mobile views. 
Props iamtakashi, fixes #30252.


Built from https://develop.svn.wordpress.org/trunk@30243


git-svn-id: http://core.svn.wordpress.org/trunk@30243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 18:03:23 +00:00
Jeremy Felt
c47552dc6d Create new $wp_roles object in install_blog() to avoid protected _init() call 
Our call to `$wp_roles->_init()` relied on the `__call()` method in `WP_Roles` to handle the link to the protected method. This works back to PHP 5.2.9, when a bug was fixed allowing access to protected methods through this exact approach.

`install_blog()` needs a fresh `$wp_roles` object after `populate_roles()` resets everything in its path. We can create this new object from scratch, effectively doing the same thing with the call to `_init()` via the constructor.

Fixes #29692 for trunk.

Built from https://develop.svn.wordpress.org/trunk@30242


git-svn-id: http://core.svn.wordpress.org/trunk@30242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 05:12:22 +00:00
Boone Gorges
3706590afb Split shared taxonomy terms during term update. 
When updating an existing taxonomy term that shares its `term_id` with
another term, we generate a new row in `wp_terms` and associate the updated
term_taxonomy_id with the new term. This separates the terms, such that
updating the name of one term does not change the name of any others.

Note that this term splitting only occurs on installations whose database
schemas have been upgraded to version 30133 or higher. Note also that shared
terms are only split when run through `wp_update_term()`, as on edit-tags.php;
we will wait until a future release of WordPress to force the splitting of all
shared taxonomy terms.

Props boonebgorges, rmccue, greuben, garyc40, wonderboymusic, imath, jesin.
Fixes #5809.
Built from https://develop.svn.wordpress.org/trunk@30241


git-svn-id: http://core.svn.wordpress.org/trunk@30241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 02:03:23 +00:00
Boone Gorges
32db3d1fe5 Do not create shared taxonomy terms. 
A "shared" term occurs when two entries in the `wp_term_taxonomy` table share a
single `term_id`, and thereby correspond to the same row in `wp_terms`. This
changeset stops the practice of creating shared terms: each new row in
`wp_term_taxonomy` will receive its own row in `wp_terms`. The new strategy
for term creation depends on whether the installation's database schema is up
to date for 4.1:

* If so, terms are allowed to be created with the same slug as an existing term, as long as they are in different taxonomies and do not share a parent. Thus, a new tag with the slug 'wordpress' can exist alongside a category with the slug 'wordpress'.
* If not, new terms will be forced to have unique slugs. Thus, on an installation containing a category with the slug 'wordpress', a new tag 'WordPress' will get the slug 'wordpress-2'.

Fixes #21950. See #5809.
Built from https://develop.svn.wordpress.org/trunk@30240


git-svn-id: http://core.svn.wordpress.org/trunk@30240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 01:42:22 +00:00
Boone Gorges
ef13be6f27 Enforce ORDER BY and LIMIT clauses in term_exists() queries. 
In case of edge cases where a duplicate term might exist in a replicated
database for a split second, these explicit query clauses ensure that
`term_exists()` will always recognize the oldest matched term as the
canonical one. See [30238] for background.

Props pento.
See #22023, #5809.
Built from https://develop.svn.wordpress.org/trunk@30239


git-svn-id: http://core.svn.wordpress.org/trunk@30239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 01:09:21 +00:00
Boone Gorges
4ce9db9ce8 In wp_insert_term(), clean up accidental duplicate terms after insert. 
In [30056], the UNIQUE index was removed from the 'slug' column of `wp_terms`.
While we have numerous checks in place to avoid the creation of unwanted
duplicate term+term_taxonomy pairs, it's possible that in certain edge cases -
such as during the lag caused by database replication, or a race condition
involving near-simultaneous creation of more than one term - we'll end up
unwittingly inserting two identical rows.

The current changeset minimizes this risk by introducing a failsafe mechanism
into `wp_insert_term()`. After a term and term_taxonomy are INSERTed, we check
to see whether the term just created is a duplicate of an existing term; if so,
we delete the new one and keep the old one. This prevents problems caused by
replication lag, because SELECT queries that take place after an INSERT will
hit the master database; it mitigates race conditions by enforcing that the
term that was created first (ie, the one with the lowest `term_id`) is
always the "canonical" one.

Props nacin, markjaquith.
See #22023, #5809.
Built from https://develop.svn.wordpress.org/trunk@30238


git-svn-id: http://core.svn.wordpress.org/trunk@30238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-05 01:00:24 +00:00
Ian Stewart
1483e80848 Twenty Fifteen: use continue reading links for auto-generated excerpts to provide a readable link for screenreaders. 
Props davidakennedy, kraftbj, fixes #30135.


Built from https://develop.svn.wordpress.org/trunk@30237


git-svn-id: http://core.svn.wordpress.org/trunk@30237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 21:19:22 +00:00
Ian Stewart
2047ff9e5a Twenty Fifteen: Use the new archive template tags and make archive template titling way simpler! 
Props obenland, fixes #30246.


Built from https://develop.svn.wordpress.org/trunk@30236


git-svn-id: http://core.svn.wordpress.org/trunk@30236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 21:01:23 +00:00
Ian Stewart
0952952ef7 Twenty Fifteen: adding licensing info for the image used in the screenshot. 
Props sakinshrestha, fixes #30156.


Built from https://develop.svn.wordpress.org/trunk@30235


git-svn-id: http://core.svn.wordpress.org/trunk@30235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 20:55:22 +00:00
Scott Taylor
8fa0755584 Add some docs to wp.media.view.EditorUploader. 
Props ericlewis.
See #29951.

Built from https://develop.svn.wordpress.org/trunk@30234


git-svn-id: http://core.svn.wordpress.org/trunk@30234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 20:48:23 +00:00
Ian Stewart
d21ea0a251 Twenty Fifteen: Formatting cleanup for documentation, crossing eyes, dotting tees. 
Props lancewillett, MikeHansenMe, fixes #30149.

Built from https://develop.svn.wordpress.org/trunk@30233


git-svn-id: http://core.svn.wordpress.org/trunk@30233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 20:26:23 +00:00
Ian Stewart
e2d03edb0d Twenty Fifteen: missing spaces for code standards. 
Props Jayjdk, fixes #30076.


Built from https://develop.svn.wordpress.org/trunk@30232


git-svn-id: http://core.svn.wordpress.org/trunk@30232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 20:16:22 +00:00
Ian Stewart
b519db9ffa Twenty Fifteen: accessible alt text for post thumbnail links. 
Props joedolson, fixes #30076.


Built from https://develop.svn.wordpress.org/trunk@30231


git-svn-id: http://core.svn.wordpress.org/trunk@30231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 18:57:27 +00:00
Ian Stewart
17dbe26df9 Twenty Fifteen: Simplify the header, sidebar, background controls and make customization faster for users to do. This has the added benefit of fixing our bug where hidden header text wasn't being updated on color scheme switch. Nice. 
Props celloexpressions, iamtakashi, fixes #30164 and #29980.

Built from https://develop.svn.wordpress.org/trunk@30230


git-svn-id: http://core.svn.wordpress.org/trunk@30230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 18:42:22 +00:00
Ian Stewart
cc9c8edf83 Twenty Fifteen: Crashing chrome if you don't have Noto installed probably isn't the best experience -- removing font kerning. 
Props iamtakashi, fixes #30195

Built from https://develop.svn.wordpress.org/trunk@30229


git-svn-id: http://core.svn.wordpress.org/trunk@30229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 17:41:21 +00:00
Drew Jaynes
7d56be8521 Ensure the requires for the admin bootstrap are documented in all wp-admin/user/ files. 
Props NikV for the initial patch.
Fixes #29111.

Built from https://develop.svn.wordpress.org/trunk@30228


git-svn-id: http://core.svn.wordpress.org/trunk@30228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 16:32:22 +00:00
Drew Jaynes
7081b906f4 Fix a couple of typos in the hook documentation for the $option filter in wp-admin/includes/class-wp-list-table.php. 
Props bobbingwide.
Fixes #30229.

Built from https://develop.svn.wordpress.org/trunk@30227


git-svn-id: http://core.svn.wordpress.org/trunk@30227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 16:05:22 +00:00
Drew Jaynes
d19de136c6 Merge a multi-line comment into a single-line comment in wp-includes/link-template.php. 
See [30166]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@30226


git-svn-id: http://core.svn.wordpress.org/trunk@30226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 15:59:23 +00:00
Drew Jaynes
256bea185d Add parameter and return descriptions to the WP_List_Table::get_pagination_arg() DocBlock. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30225


git-svn-id: http://core.svn.wordpress.org/trunk@30225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 15:55:23 +00:00
Drew Jaynes
784e162177 Cross reference get_the_archive_title() and get_the_archive_description() in the inline documentation for their corresponding template tags. 
Also define the default values for `$before` and `$after` in the template tag documentation.

See [30223]. See #21995.

Built from https://develop.svn.wordpress.org/trunk@30224


git-svn-id: http://core.svn.wordpress.org/trunk@30224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 06:52:23 +00:00
John Blackbourn
6a45f46937 Introduce some new template functions for archive titles and descriptions: 
* `get_the_archive_title()` and `the_archive_title()` for returning/displaying the title of the current term, date, post type, post format, or author archive.
 * `get_the_archive_description()` and `the_archive_description()` for returning/displaying the description associated with the current term archive.

Fixes #21995
Props obenland, DrewAPicture

Built from https://develop.svn.wordpress.org/trunk@30223


git-svn-id: http://core.svn.wordpress.org/trunk@30223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-04 00:35:22 +00:00
Ian Stewart
7a6ea1e83d Twenty Fifteen: correct image alignment for RTL. 
Props iamtakashi, fixes #30239.



Built from https://develop.svn.wordpress.org/trunk@30222


git-svn-id: http://core.svn.wordpress.org/trunk@30222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 23:12:22 +00:00
Ian Stewart
7dfb040dde Twenty Fifteen: check if user-selected custom colors are the same as default so we're not duplicating styles. 
Props iamtakashi, fixes #30234


Built from https://develop.svn.wordpress.org/trunk@30221


git-svn-id: http://core.svn.wordpress.org/trunk@30221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:59:22 +00:00
Ian Stewart
8a930c93a8 Twenty Fifteen: Remove a gap between content and footer when the sidebar is longer than the content. 
Props iamtakashi, fixes #30228.



Built from https://develop.svn.wordpress.org/trunk@30220


git-svn-id: http://core.svn.wordpress.org/trunk@30220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:49:44 +00:00
Dominik Schilling
a17fd23e41 Customizer: Bind input and propertychange events for range input types. 
props voldemortensen, westonruter.
fixes #30223.
Built from https://develop.svn.wordpress.org/trunk@30219


git-svn-id: http://core.svn.wordpress.org/trunk@30219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:49:23 +00:00
Ian Stewart
9a3b7977fd Twenty Fifteen: escaping for the HTML5 shiv call. 
Props philiparthurmoore, fixes #30212



Built from https://develop.svn.wordpress.org/trunk@30218


git-svn-id: http://core.svn.wordpress.org/trunk@30218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:47:22 +00:00
Ian Stewart
3a0b05e5b1 Twenty Fifteen: kern everything -- it reads better. 
Props afercia, fixes #30195.



Built from https://develop.svn.wordpress.org/trunk@30217


git-svn-id: http://core.svn.wordpress.org/trunk@30217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:43:21 +00:00
Ian Stewart
6be421fb37 Twenty Fifteen: Use new core navigation tags. 
Props obenland, iamtakashi, fixes #30189



Built from https://develop.svn.wordpress.org/trunk@30216


git-svn-id: http://core.svn.wordpress.org/trunk@30216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:40:23 +00:00
Ian Stewart
fe241e3fdc Twenty Fifteen: Make sure that the edit link will always be right of it's icon. 
Props iamtakashi, fixes #30171.



Built from https://develop.svn.wordpress.org/trunk@30215


git-svn-id: http://core.svn.wordpress.org/trunk@30215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:36:23 +00:00
Dominik Schilling
73b4f6f449 Customizer: Add stable sorting for panels, sections and controls in JS. Improve sorting in PHP. 
props westonruter.
fixes #30225.
Built from https://develop.svn.wordpress.org/trunk@30214


git-svn-id: http://core.svn.wordpress.org/trunk@30214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 21:35:23 +00:00
Ian Stewart
4b23645ad4 Twenty Fifteen: nicer styles for playlists. 
Props iamtakashi, fixes #30163


Built from https://develop.svn.wordpress.org/trunk@30213


git-svn-id: http://core.svn.wordpress.org/trunk@30213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 19:33:23 +00:00
Ian Stewart
cdfbccddb2 Twenty Fifteen: add a fallback icon for social links where we don't have an icon 
Props iamtakashi, fixes #30148


Built from https://develop.svn.wordpress.org/trunk@30212


git-svn-id: http://core.svn.wordpress.org/trunk@30212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 19:02:22 +00:00
Ian Stewart
c1b360a665 Twenty Fifteen: prevent a flash of visible sub menus before scripts load. 
Props mattwiebe, aferica, fixes #30056.


Built from https://develop.svn.wordpress.org/trunk@30211


git-svn-id: http://core.svn.wordpress.org/trunk@30211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 18:58:23 +00:00
Boone Gorges
7919a6d812 Improve docblocks for get_the_taxonomies() and the_taxonomies(). 
* In `the_taxonomies()`, only document those arguments that are specific to the function. Arguments shared with `get_the_taxonomies()` should be documented in the later function's docblock.
* Add $args hash documentation to `get_the_taxonomies()`.
* Remove the redundant default argument definition in `the_taxonomies()`.

Fixes #27238.
Built from https://develop.svn.wordpress.org/trunk@30210


git-svn-id: http://core.svn.wordpress.org/trunk@30210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 18:49:45 +00:00
Boone Gorges
eec3eea392 Introduce term_template param to get_the_taxonomies(). 
This parameter allows theme and plugin authors to specify the formatting they
would like on the term links as they are parsed into the taxonomy list.

Props hereswhatidid, dlh, davidjlaietta.
See #27238.
Built from https://develop.svn.wordpress.org/trunk@30209


git-svn-id: http://core.svn.wordpress.org/trunk@30209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 18:49:24 +00:00
Ian Stewart
a46c99cf78 Twenty Fifteen: make it clear that a link is a link in post and comment meta by underlining it on hover or focus 
Props morganestes, iamtakashi, fixes #30108


Built from https://develop.svn.wordpress.org/trunk@30208


git-svn-id: http://core.svn.wordpress.org/trunk@30208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 17:01:23 +00:00
Boone Gorges
89526ca7f1 Ignore case when checking string 'false' in wp_validate_boolean(). 
Props TobiasBg, kitchin.
Fixes #30238.
Built from https://develop.svn.wordpress.org/trunk@30207


git-svn-id: http://core.svn.wordpress.org/trunk@30207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 15:55:23 +00:00
Boone Gorges
99c5817822 Add unit tests for wp_validate_boolean(). 
Props TobiasBg.
See #30238.
Built from https://develop.svn.wordpress.org/trunk@30206


git-svn-id: http://core.svn.wordpress.org/trunk@30206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 15:52:21 +00:00
Boone Gorges
fc4b17a5d2 In in_object_in_term(), only check numeric string values against term_id. 
The previous `in_array()` check was playing too loose with mixed types, such
that a string like '10_term_name' would incorrectly match a term_id 10.

Props nobinobi, realloc.
Fixes #29467.
Built from https://develop.svn.wordpress.org/trunk@30205


git-svn-id: http://core.svn.wordpress.org/trunk@30205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 14:25:44 +00:00
Boone Gorges
d2a8ae2544 Add some unit tests for is_object_in_term(). 
These tests check a number of the ways that different kinds of values for
`$terms` (integers that match term_id, strings that match term_id or name or
slug) are handled.

See #29467.
Built from https://develop.svn.wordpress.org/trunk@30204


git-svn-id: http://core.svn.wordpress.org/trunk@30204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 14:25:22 +00:00
Scott Taylor
5e3a64e83d Correct some types in wp-admin/*-location files' doc blocks. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30203


git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 07:09:23 +00:00
Scott Taylor
7d7a8aa0eb Correct all @return unknown instances. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30202


git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 06:17:22 +00:00
Scott Taylor
bd2521d5ee Fill in the @param types for the args for functions missing them in wp-admin/includes/deprecated.php (pour one out). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30201


git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 06:08:22 +00:00
Scott Taylor
196d85a9f6 Fill in the @param types for the args for functions missing them in wp-admin/includes/misc.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30200


git-svn-id: http://core.svn.wordpress.org/trunk@30200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 06:01:24 +00:00
Scott Taylor
37f94bdfd0 Fill in the @param types for the args for functions missing them in wp-admin/includes/plugin.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30199


git-svn-id: http://core.svn.wordpress.org/trunk@30199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:59:22 +00:00
Scott Taylor
64167f0845 Fill in the @param types for the args for functions missing them in wp-admin/includes/post.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30198


git-svn-id: http://core.svn.wordpress.org/trunk@30198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:55:22 +00:00
Scott Taylor
d9d825db72 Fill in the @param types for the args for functions missing them in wp-admin/includes/taxonomy.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30197


git-svn-id: http://core.svn.wordpress.org/trunk@30197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:50:23 +00:00
Scott Taylor
06f49a43a1 Fill in the @param types for the args for functions missing them in wp-admin/includes/template.php. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30196


git-svn-id: http://core.svn.wordpress.org/trunk@30196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:45:24 +00:00
Scott Taylor
5a3256c00b Fill in the @param types for the args for make_site_theme_from_default(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30195


git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:43:21 +00:00
Scott Taylor
ef944e8c19 Fill in the @param types for the args for make_site_theme_from_oldschool(), which is actually the name of a function? 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30194


git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:41:23 +00:00
Scott Taylor
082a1d06ae Fill in the @param types for the args for dbDelta(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30193


git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:40:22 +00:00
Scott Taylor
150b4e5157 Fill in the @param types for the args in WP_Text_Diff_Renderer_Table->interleave_changed_lines(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30192


git-svn-id: http://core.svn.wordpress.org/trunk@30192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:39:22 +00:00
Scott Taylor
3e4ca28eb9 Correct the @param type for the $query arg for remove_query_arg(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30191


git-svn-id: http://core.svn.wordpress.org/trunk@30191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:29:22 +00:00
Scott Taylor
8eee18ec0e Fill in types for the @params for wp_comment_reply(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30190


git-svn-id: http://core.svn.wordpress.org/trunk@30190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:21:22 +00:00
Scott Taylor
63c55ae93c Correct type in the doc block for get_theme_support(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30189


git-svn-id: http://core.svn.wordpress.org/trunk@30189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:18:22 +00:00
Scott Taylor
3535af5b77 Correct the return value doc block for get_theme_support(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30188


git-svn-id: http://core.svn.wordpress.org/trunk@30188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:17:23 +00:00
Scott Taylor
0eb038d97b In Custom_Image_Header: 
* In `->process_default_headers()`, remove check on non-existent `$headers` property. Introduced in [13403]. 
* Declare `$updated` as a property.

See #30224.

Built from https://develop.svn.wordpress.org/trunk@30187


git-svn-id: http://core.svn.wordpress.org/trunk@30187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:15:22 +00:00
Scott Taylor
a14a4fc9a5 In Custom_Background, declare $updated as a property. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30186


git-svn-id: http://core.svn.wordpress.org/trunk@30186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:08:22 +00:00
Scott Taylor
15c062eb79 In wp_audio|video_shortcode(), make sure that autoplay and loop are booleans. Passing 'false' to them will force them to be active, which is bad. 
Fixes #29825.

Built from https://develop.svn.wordpress.org/trunk@30185


git-svn-id: http://core.svn.wordpress.org/trunk@30185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:03:21 +00:00
Scott Taylor
a587ebc946 In WP_Tax_Query, declare $primary_table and $primary_id_column as properties. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30184


git-svn-id: http://core.svn.wordpress.org/trunk@30184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 03:45:22 +00:00
Scott Taylor
2750f0cec7 In WP_Locale, declare $number_format as a property. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30183


git-svn-id: http://core.svn.wordpress.org/trunk@30183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 03:40:22 +00:00
Scott Taylor
a23c230c01 In WP_Comment_Query, declare $query_vars and $comments as properties. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30182


git-svn-id: http://core.svn.wordpress.org/trunk@30182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 03:08:22 +00:00
Scott Taylor
c598d35e41 Almost every method in wp_xmlrpc_server can also return IXR_Error and should be labeled as such. Rehabilitate some return syntax. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30181


git-svn-id: http://core.svn.wordpress.org/trunk@30181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 03:04:22 +00:00
Scott Taylor
e02c724249 WP_Image_Editor_GD and WP_Image_Editor_Imagick should specify type in a doc block for the $image property, instead of inferring bool and null. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30180


git-svn-id: http://core.svn.wordpress.org/trunk@30180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 02:38:23 +00:00
Scott Taylor
a887301869 In WP_HTTP_IXR_Client: 
* declare `$scheme` as a property, it doesn't exist on the parent class
* declare `$error` as a property of type `IXR_Error`, instead of it being inferred as `boolean` from the parent class

See #30224.

Built from https://develop.svn.wordpress.org/trunk@30179


git-svn-id: http://core.svn.wordpress.org/trunk@30179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 02:32:22 +00:00
Scott Taylor
68a67a9b0d Fix the return docs for WP_Embed->maybe_make_link(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30178


git-svn-id: http://core.svn.wordpress.org/trunk@30178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 02:27:23 +00:00
Jeremy Felt
796ceebb25 Use common core syntax for checking DOING_AJAX 
Our current check for a non truthy `DOING_AJAX` is `! DOING_AJAX`.

props TobiasBg
Fixes #29891

Built from https://develop.svn.wordpress.org/trunk@30177


git-svn-id: http://core.svn.wordpress.org/trunk@30177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-02 02:24:23 +00:00
Jeremy Felt
00c86aea63 Delete admin_created_user_subject() rather than deprecate 
As it was never used as anything more than a callback to a filter before the MU merge, and is only available in user-new.php in multisite, it is safe to remove this function entirely.

Fixes #29915

Built from https://develop.svn.wordpress.org/trunk@30176


git-svn-id: http://core.svn.wordpress.org/trunk@30176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-02 02:07:23 +00:00
Jeremy Felt
c3f51ce97a Improve layout of test for cached invalid, then valid site details 
* Rename method to `test_get_blog_details_when_site_does_not_exist()`.
* Always assume `MAX(blog_id)` is 1 and therefore always create a burner.
* Remove tests specific to `wpmu_delete_blog()` and cache, to be handled elsewhere.
* Remove extra asertions.

See #30080, #23405

Built from https://develop.svn.wordpress.org/trunk@30175


git-svn-id: http://core.svn.wordpress.org/trunk@30175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-02 01:05:22 +00:00
Jeremy Felt
132be9d66d Split tests for wp_get_sites() 
Test various arguments for `wp_get_sites()` in a more intentful way rather than in one large test. Leave tests for limit and offset together for convenience.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30174


git-svn-id: http://core.svn.wordpress.org/trunk@30174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:40:22 +00:00
Scott Taylor
783f36f855 In _WP_Editors::editor_settings(), $str1 and $str2 don't need to be initialized empty. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30173


git-svn-id: http://core.svn.wordpress.org/trunk@30173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:22:22 +00:00
Scott Taylor
303d01869c Declare the $uploaded_headers and $default_headers properties for WP_Customize_Header_Image_Control. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30172


git-svn-id: http://core.svn.wordpress.org/trunk@30172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:18:23 +00:00
Scott Taylor
73c8e4cf10 Declare the $update_count and $update_current properties for WP_Upgrader. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30171


git-svn-id: http://core.svn.wordpress.org/trunk@30171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:07:23 +00:00
Scott Taylor
3fc8778359 Declare the $options property for WP_Upgrader_Skin. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30170


git-svn-id: http://core.svn.wordpress.org/trunk@30170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:03:22 +00:00
Scott Taylor
4d0f66854a Fix the return value doc for WP_List_Table->get_pagination_arg(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30169


git-svn-id: http://core.svn.wordpress.org/trunk@30169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 23:00:23 +00:00
Scott Taylor
6a109700d0 In wp_ajax_get_tagcloud(), bail immediately if $_POST['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30168


git-svn-id: http://core.svn.wordpress.org/trunk@30168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:54:22 +00:00
Scott Taylor
a786fb779c In wp_ajax_ajax_tag_search(), bail immediately if $_GET['tax'] isn't set so that all of the variable setting can happen in the same nest scope as the rest of the function - wp_die() confuses Scrutinizer. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30167


git-svn-id: http://core.svn.wordpress.org/trunk@30167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:48:22 +00:00
Scott Taylor
a79b6fdde3 In get_the_pagination(), don't pass $links to _navigation_markup() if it is not a string - paginate_links() can return an array. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30166


git-svn-id: http://core.svn.wordpress.org/trunk@30166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:41:23 +00:00
Scott Taylor
892be738b0 Make the docs type for return in wpmu_create_user() more specific. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30165


git-svn-id: http://core.svn.wordpress.org/trunk@30165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:33:21 +00:00
Scott Taylor
e41e38183d In customize.php, check that $autofocus is an array after running wp_unslash() instead of before. This is admittedly to skip a traversable hint in Scrutinizer. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30164


git-svn-id: http://core.svn.wordpress.org/trunk@30164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:17:22 +00:00
Scott Taylor
106da1e9e6 In WP_Meta_Query->get_sql_for_clause(), the empty initialization of $where is dead code and can be removed. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30163


git-svn-id: http://core.svn.wordpress.org/trunk@30163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:03:22 +00:00
Scott Taylor
fbd6efdfb8 In _wp_json_convert_string(), when $use_mb is false, perhaps pass a variable that actually exists to wp_check_invalid_utf8(). 
Introduced in [30055].
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30162


git-svn-id: http://core.svn.wordpress.org/trunk@30162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 22:00:24 +00:00
Scott Taylor
cd9bb04981 In gallery_shortcode(), when the link attribute is equal to file, make sure to pass $attr as the 6th (!) argument, not 5th, to wp_get_attachment_link(). 
Props bradyvercher.
Fixes #27402.

Built from https://develop.svn.wordpress.org/trunk@30161


git-svn-id: http://core.svn.wordpress.org/trunk@30161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 21:47:24 +00:00
Scott Taylor
382d93ddf9 Remove failing unit test after [30090]. 
Fixes #30194.

Built from https://develop.svn.wordpress.org/trunk@30160


git-svn-id: http://core.svn.wordpress.org/trunk@30160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 21:11:22 +00:00
Scott Taylor
878d074e84 Allow get_pages(), with child_of passed to it, to work with interrupted hierarchies. 
Adds unit test.
Fixes #18962.

Built from https://develop.svn.wordpress.org/trunk@30159


git-svn-id: http://core.svn.wordpress.org/trunk@30159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 20:44:21 +00:00
Scott Taylor
d5e4583475 All duplicate slugs across different post types. 
Adds unit test.

Props mboynes, nacin.
Fixes #18962.

Built from https://develop.svn.wordpress.org/trunk@30158


git-svn-id: http://core.svn.wordpress.org/trunk@30158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 20:37:24 +00:00
Scott Taylor
849a993269 Check $_current_page before using it in Walker_Page->start_el(). 
Props jeremyfelt.
Fixes #26901.

Built from https://develop.svn.wordpress.org/trunk@30157


git-svn-id: http://core.svn.wordpress.org/trunk@30157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 20:29:22 +00:00
Scott Taylor
60b73c589c Display error message when Media Library upload fails. 
Props gcorne.
Fixes #29891.

Built from https://develop.svn.wordpress.org/trunk@30156


git-svn-id: http://core.svn.wordpress.org/trunk@30156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 20:25:23 +00:00
Scott Taylor
be08f576df Improve some post_status-related documentation. 
Props ericlewis.
See #30230.

Built from https://develop.svn.wordpress.org/trunk@30155


git-svn-id: http://core.svn.wordpress.org/trunk@30155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 20:20:23 +00:00
Scott Taylor
0b9c1be743 In WP_List_Table, add a property, $modes, to allow WP_Media_List_Table to inherit ->view_switcher(). 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30154


git-svn-id: http://core.svn.wordpress.org/trunk@30154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 19:56:24 +00:00
Scott Taylor
be707cd614 In wp_xmlrpc_server methods, for comprehensibility: 
* initialize arrays in loops, instead of overriding an uninitialized array each time
* in `->blogger_getRecentPosts()` and `->mw_getRecentPosts()`, remove the extra loops by only setting one `array`

See #30224.

Built from https://develop.svn.wordpress.org/trunk@30153


git-svn-id: http://core.svn.wordpress.org/trunk@30153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 19:45:25 +00:00
Jeremy Felt
0ba8ceb6ea Split tests for is_main_site() 
Break multiple assertions from one method into multiple methods with one assertion each.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30152


git-svn-id: http://core.svn.wordpress.org/trunk@30152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 05:18:22 +00:00
Jeremy Felt
8785f07ee1 Expand and clarify tests for get_blog_post() 
Remove unnecessary user factory use. Be explicit about test scenarios.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30151


git-svn-id: http://core.svn.wordpress.org/trunk@30151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 04:47:22 +00:00
Drew Jaynes
09a1f68f07 Fix a couple of spacing and wrapping indents in the WP_Date_Query::__construct() hash notation. 
See [30142]. See #28063.

Built from https://develop.svn.wordpress.org/trunk@30150


git-svn-id: http://core.svn.wordpress.org/trunk@30150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 04:31:22 +00:00
Drew Jaynes
a929ac44e1 Relocate hook docs so they directly precede the hook lines moved into foreach statements in [30140]. 
It's necessary for hook docs to directly precede hook lines so the parser can correctly match them up. This change relocates hook docs for `update_{$meta_type}_meta`, `update_postmeta`, `updated_{$meta_type}_meta`, and `updated_postmeta`.

Fixes #11683.

Built from https://develop.svn.wordpress.org/trunk@30149


git-svn-id: http://core.svn.wordpress.org/trunk@30149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 04:18:23 +00:00
Boone Gorges
8b18debcd0 Clean up 'post-thumbnail' theme support unit tests. 
* Separate into smaller test methods.
* Remove incorrect tests. A number of assertions in the existing test have always incorrectly described the behavior of `current_theme_supports( 'post-thumbnails' )`, but no one ever noticed because the tests had been designed to bail when `_wp_render_title_tag()` did not exist. The failures finally became visible when that function was introduced in [30074].

See #18548.
Built from https://develop.svn.wordpress.org/trunk@30148


git-svn-id: http://core.svn.wordpress.org/trunk@30148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 04:01:21 +00:00
Lance Willett
df455aa106 Twenty Fourteen: update table styles in editor CSS file for new TinyMCE class names. 
Props slobodanmanic, fixes #28703.

Built from https://develop.svn.wordpress.org/trunk@30147


git-svn-id: http://core.svn.wordpress.org/trunk@30147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 03:47:21 +00:00
Lance Willett
c604fd15b0 Twenty Fourteen: fix keyboard focus on Appearance > Header view. 
Props florianziegler, fixes #29787.

Built from https://develop.svn.wordpress.org/trunk@30146


git-svn-id: http://core.svn.wordpress.org/trunk@30146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 03:44:23 +00:00
Lance Willett
609335eef1 Twenty Ten and Eleven: don't display modified excerpt link in wp-admin. 
Props kraftbj, fixes #30026.

Built from https://develop.svn.wordpress.org/trunk@30145


git-svn-id: http://core.svn.wordpress.org/trunk@30145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 03:40:25 +00:00
Boone Gorges
c07582cb64 Improve default argument formatting in WP_Date_Query::__construct(). 
Built from https://develop.svn.wordpress.org/trunk@30144


git-svn-id: http://core.svn.wordpress.org/trunk@30144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 03:29:21 +00:00
Lance Willett
6ddbf3c8bd Twenty Fourteen: Make featured content in Customizer contextual to the front page. 
Props celloexpressions, fixes #29578.

Built from https://develop.svn.wordpress.org/trunk@30143


git-svn-id: http://core.svn.wordpress.org/trunk@30143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 03:26:21 +00:00
Boone Gorges
92536aae65 Introduced dayofweek_iso time param for WP_Date_Query. 
The initial `dayofweek` param sets day 1 to Sunday. This is out of step with
ISO standards, which calls Monday day 1. To maintain backward compatibility
with the existing parameter, we introduce the new `dayofweek_iso` for the
new, more compliant param.

Props mboynes.
Fixes #28063.
Built from https://develop.svn.wordpress.org/trunk@30142


git-svn-id: http://core.svn.wordpress.org/trunk@30142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 03:24:21 +00:00
Boone Gorges
96b42c2fdc Allow resource_type to be specified in get_ancestors(). 
Being explicit about resource type (taxonomy vs post_type) allows for the
proper resolution of conflicts when a taxonomy and post_type share a slug.

Props filosofo.
Fixes #15029.
Built from https://develop.svn.wordpress.org/trunk@30141


git-svn-id: http://core.svn.wordpress.org/trunk@30141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 02:58:23 +00:00
Boone Gorges
c27548265e Pass all updated meta IDs to filters in update_metadata(). 
Props wonderboymusic.
Fixes #11683.
Built from https://develop.svn.wordpress.org/trunk@30140


git-svn-id: http://core.svn.wordpress.org/trunk@30140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 02:39:24 +00:00
Scott Taylor
65ab0a188e In wp_xmlrpc_server->pingback_ping(), remove the internal variable $way each time it is set and not used. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30139


git-svn-id: http://core.svn.wordpress.org/trunk@30139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:50:21 +00:00
Scott Taylor
4f6745e9aa In wp_xmlrpc_server methods, don't set $blog_id internally if it is never used, which is almost always. Updates the docs. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30138


git-svn-id: http://core.svn.wordpress.org/trunk@30138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:44:23 +00:00
Scott Taylor
0d3270282d In wp_xmlrpc_server->_prepare_comment(), $comment_date is set internally but never used. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30137


git-svn-id: http://core.svn.wordpress.org/trunk@30137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:29:24 +00:00
Scott Taylor
fcbc7b5a78 In Custom_Image_Header->step_2(), $type is set internally but never used. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30136


git-svn-id: http://core.svn.wordpress.org/trunk@30136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:24:22 +00:00
Scott Taylor
02f3c92b39 Fix failing unit tests after [30096]: use assertEqualSets(). 
Built from https://develop.svn.wordpress.org/trunk@30135


git-svn-id: http://core.svn.wordpress.org/trunk@30135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:11:44 +00:00
Boone Gorges
e9f6ee53bb Fix database schema update introduced in [30121]. 
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30134


git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:11:22 +00:00
Scott Taylor
8d0e8942eb [28785] introduced a bug, where encoded query arguments were decoded by parse_str() inside of wp_parse_str() but never re-encoded later on. 
This encodes them, adds unit test.

Props obenland.
Fixes #29636.

Built from https://develop.svn.wordpress.org/trunk@30133


git-svn-id: http://core.svn.wordpress.org/trunk@30133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 00:54:23 +00:00
Scott Taylor
c19b3d1740 Fix unit test for video shortcode after [30082]. 
Fixes #30078.

Built from https://develop.svn.wordpress.org/trunk@30132


git-svn-id: http://core.svn.wordpress.org/trunk@30132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 00:49:21 +00:00
Scott Taylor
29deacc30c Revisions modules should not rely on global settings: 
* Only pass in global settings on `init`, this allows the classes to be used agnostically elsewhere
* Clean up some erroneous/weird Backbone syntax

Props ericlewis, wonderboymusic.
Fixes #30219.

Built from https://develop.svn.wordpress.org/trunk@30131


git-svn-id: http://core.svn.wordpress.org/trunk@30131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 00:39:24 +00:00
Scott Taylor
d1d93b7cda Set revision.settings via short-circuit check for window property: window._wpRevisionsSettings || {} 
Props ericlewis.
Fixes #30218.

Built from https://develop.svn.wordpress.org/trunk@30130


git-svn-id: http://core.svn.wordpress.org/trunk@30130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 00:20:22 +00:00
Scott Taylor
a4963672d6 Add a single responsibility function for outputting Revisions JS templates: wp_print_revision_templates(). 
Use it in `wp-admin/revision.php`.

Props ericlewis.
Fixes #30220.

Built from https://develop.svn.wordpress.org/trunk@30129


git-svn-id: http://core.svn.wordpress.org/trunk@30129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 00:15:24 +00:00
Scott Taylor
7cbb7552da Allow revision Backbone classes to be used on pages other than revision.php. 
Props ericlewis.
Fixes #30221.

Built from https://develop.svn.wordpress.org/trunk@30128


git-svn-id: http://core.svn.wordpress.org/trunk@30128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 00:08:21 +00:00
Scott Taylor
f1634f7c8f Add some JSDoc blocks to revisions.js. 
Props ericlewis.
See #30222.


Built from https://develop.svn.wordpress.org/trunk@30127


git-svn-id: http://core.svn.wordpress.org/trunk@30127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 23:55:22 +00:00
Dominik Schilling
461507452a Customizer: Improve ColorControl's wpColorPicker to update UI based on setting changes. 
Update Twenty Fifteen's `colorScheme` control to properly interact with the API, using `wp.customize.control()` instead of traversing DOM for other controls' container elements and stop manually updating color control UIs.

props westonruter.
fixes #30031.
Built from https://develop.svn.wordpress.org/trunk@30126


git-svn-id: http://core.svn.wordpress.org/trunk@30126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 20:45:22 +00:00
Scott Taylor
7eefc4d1e1 JSHint after [30124]. 
Built from https://develop.svn.wordpress.org/trunk@30125


git-svn-id: http://core.svn.wordpress.org/trunk@30125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 20:38:21 +00:00
Scott Taylor
a6cb067481 JSHint after [30120]. 
Built from https://develop.svn.wordpress.org/trunk@30124


git-svn-id: http://core.svn.wordpress.org/trunk@30124 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 20:35:22 +00:00
Dominik Schilling
2e76a697f6 Fix JSHint errors introduced in [30120]. 
see #30193.
Built from https://develop.svn.wordpress.org/trunk@30123


git-svn-id: http://core.svn.wordpress.org/trunk@30123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 20:28:24 +00:00
Drew Jaynes
66c47f29bb Correct references of @uses $wpdb in core documentation to use @global. 
See #30191, [30105].
Fixes #30217.

Built from https://develop.svn.wordpress.org/trunk@30122


git-svn-id: http://core.svn.wordpress.org/trunk@30122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 17:56:22 +00:00
Boone Gorges
70631df84a Bump db_version and add upgrade routine for schema change in [30056]. 
Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30121


git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 16:03:22 +00:00
Scott Taylor
999e0fbd99 Add verbose docs to media-views.js. 
Props ericlewis.
See #30193.

Built from https://develop.svn.wordpress.org/trunk@30120


git-svn-id: http://core.svn.wordpress.org/trunk@30120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 15:20:23 +00:00
Drew Jaynes
e8f68802c6 Correct two parameter types in the wp_save_post_revision_check_for_changes hook documentation. 
Props johnbillion.
Fixes #30185.

Built from https://develop.svn.wordpress.org/trunk@30119


git-svn-id: http://core.svn.wordpress.org/trunk@30119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 23:50:22 +00:00
Boone Gorges
6745b8a870 Move term_exists() tests to their own file. 
Built from https://develop.svn.wordpress.org/trunk@30118


git-svn-id: http://core.svn.wordpress.org/trunk@30118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 18:53:22 +00:00
Sergey Biryukov
94fa6e1615 Use correct file name in a hook comment. 
props wedi.
fixes #30200.
Built from https://develop.svn.wordpress.org/trunk@30117


git-svn-id: http://core.svn.wordpress.org/trunk@30117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 18:35:28 +00:00
Sergey Biryukov
b823b2f3c1 Twenty Fifteen: Change version compare string to '4.1-alpha' to avoid an error for alpha and beta testers during development. 
fixes #30137.
Built from https://develop.svn.wordpress.org/trunk@30116


git-svn-id: http://core.svn.wordpress.org/trunk@30116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 11:57:22 +00:00
Boone Gorges
93ae51e801 Unserialize get_metadata() results when 'key' is omitted. 
Props mattkeys, nacin.
Fixes #15030.
Built from https://develop.svn.wordpress.org/trunk@30115


git-svn-id: http://core.svn.wordpress.org/trunk@30115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 10:25:22 +00:00
Jeremy Felt
909aa4f1e7 Improve tests for domain_exists() 
* Split existing tests for `domain_exists()` into many smaller tests.
* Make slightly fewer, more accurate assertions.
* Remove unnecessary site creation via factory.

See #30080

Built from https://develop.svn.wordpress.org/trunk@30114


git-svn-id: http://core.svn.wordpress.org/trunk@30114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 05:44:23 +00:00