Commit Graph

223 Commits

Author SHA1 Message Date
Dominik Schilling
f27e762085 Replace the cite element with a b element to markup the comment author in comment_html5().
In HTML5 the `cite` element isn't valid for just an author's name.
"The cite element represents the title of a work [..] A person's name is not the title of a work" (http://www.w3.org/TR/html5/text-level-semantics.html#the-cite-element)

fixed #24522.

git-svn-id: http://core.svn.wordpress.org/trunk@24539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-01 18:26:16 +00:00
Andrew Nacin
ca1e73ca84 Comment form: Add HTML classes.
* #respond gains .comment-respond
 * #reply-title gains .comment-reply-titlw
 * form gains .comment-form

props obenland.
see #23851.



git-svn-id: http://core.svn.wordpress.org/trunk@24525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-27 21:18:08 +00:00
Andrew Nacin
5969819038 `add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );'
props obenland.
see #23850.



git-svn-id: http://core.svn.wordpress.org/trunk@24417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-06-06 15:31:34 +00:00
Sergey Biryukov
4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356.
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-28 03:29:15 +00:00
Andrew Nacin
7cc15a2e7f Remove use of global $id from comment_form() and the media list table. see #24330.
git-svn-id: http://core.svn.wordpress.org/trunk@24337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-23 18:40:16 +00:00
Sergey Biryukov
57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714.
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-08 21:27:31 +00:00
Andrew Nacin
92b4636e17 Required arguments can't follow optional arguments.
Make required arguments optional in confirm_blog_signup().

Mark arguments as required in _future_post_hook(), the walker method display_element(), get_author_link() (deprecated), and the WP_Widget constructor.

props rlerdorf.
see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:26:31 +00:00
Sergey Biryukov
2c63da143b Fix inconsistent spacing in comment_form(). props sim, TravisHoffman. fixes #23878.
git-svn-id: http://core.svn.wordpress.org/trunk@23932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-07 23:57:35 +00:00
Mark Jaquith
b3f6427c6f Improve wp_list_comments() markup.
* Whitespace cleanup
* Accepts format=html5 which uses some of the HTML5 elements
* Some helpful HTML comments to help untangle the HTML
* Other misc code cleanup

props lancewillett, obenland, georgestephanis. fixes #20088.

git-svn-id: http://core.svn.wordpress.org/trunk@23694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-14 04:26:04 +00:00
Mark Jaquith
a1e32d3217 Add the ability to use HTML5 input types in the comment form.
props jorbin, georgestephanis, obenland. fixes #15080

git-svn-id: http://core.svn.wordpress.org/trunk@23689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-13 20:31:43 +00:00
Andrew Nacin
f994ff39ac Add filters to comments_link_feed(), comment_link(), and get_comments_link(). esc_url() the echoed output of comments_link().
props MarcusPope.
fixes #19210.



git-svn-id: http://core.svn.wordpress.org/trunk@23624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-06 19:57:31 +00:00
Ryan Boren
3854fe2e0f Put required field indicators within labels. Update styling of bundled themes to accommodate. Props MikeHansenMe. fixes #21897
git-svn-id: http://core.svn.wordpress.org/trunk@22123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-05 16:34:32 +00:00
Ryan Boren
359de78b7d Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:26:25 +00:00
Ryan Boren
faca571a3a Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865
git-svn-id: http://core.svn.wordpress.org/trunk@22114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-04 18:21:47 +00:00
Ryan Boren
cfb35a9d85 Use get_post() instead of global $post.
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-04 16:29:28 +00:00
ryan
7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-30 18:30:03 +00:00
ryan
50fc51d8d2 Don't attempt to define the COMMENTS_TEMPLATE constant twice. Props kitchin. fixes #21337
git-svn-id: http://core.svn.wordpress.org/trunk@21330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 17:54:35 +00:00
ryan
ef95736bce Set the global comment var before invoking callbacks in wp_list_comments(). Props sirzooro. fixes #21184
git-svn-id: http://core.svn.wordpress.org/trunk@21324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-25 16:27:48 +00:00
ryan
01dd4131b8 Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812
git-svn-id: http://core.svn.wordpress.org/trunk@20974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 20:47:08 +00:00
nacin
5ab06c336e In comment_form(), pass the $post_id to comments_open(). props insertvisionhere. fixes #20572.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 01:47:22 +00:00
ryan
de41bc288b Introduce WP_User::exists(). see #20372
git-svn-id: http://svn.automattic.com/wordpress/trunk@20378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-06 19:18:45 +00:00
ryan
e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan
83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan
fd1393ab7a Clear strict notices for the walkers. fixes #19249
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-04 23:03:46 +00:00
ryan
07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin
30ff37104d Don't use $user_identity global. props duck_. fixes #19146.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-14 21:35:44 +00:00
duck_
e4ed63fc6f Fix typos in documentation (wp-includes/[a-h]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 16:02:41 +00:00
ryan
29592dafb6 Pass post id along to *comment_id_fields(). Props natecook. fixes #17193
git-svn-id: http://svn.automattic.com/wordpress/trunk@17812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-05 19:33:47 +00:00
nacin
e1eec3925a More @since. props SergeyBiryukov, fixes #15445.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-20 09:25:21 +00:00
westi
e69d948ca4 Revert [16649] - The core output on this is for logged out users only - need to rework this if we want to move the output. See #14510
git-svn-id: http://svn.automattic.com/wordpress/trunk@16704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-03 09:44:17 +00:00
ryan
a031db170f Fix comment_notes_before. Props mrmist. fixes #14510
git-svn-id: http://svn.automattic.com/wordpress/trunk@16649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 16:52:32 +00:00
nbachiyski
368eefd69c comments_number() doesn't need to call get_the_ID(), because get_comments_number() does it if post ID is missing
git-svn-id: http://svn.automattic.com/wordpress/trunk@16613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-29 17:34:43 +00:00
scribu
41592d266b Remove nofollow on comment reply links. Fixes #10550
git-svn-id: http://svn.automattic.com/wordpress/trunk@16230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-07 01:06:37 +00:00
nacin
0552424317 Revert submit_button() for wp-includes, setup-config, install, login, signup. see [16061], see #15064, fixes #15247.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-29 00:31:27 +00:00
markjaquith
fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
nacin
a07ec69bce Add a class to 'Your comment is awaiting moderation' in the comment walker and Twenty Ten's callback. fixes #15206.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 03:58:51 +00:00
nacin
76b4a3cac7 Pass comment ID from comment_text to get_comment_text. Also add the comment object as context to the filter. fixes #14261
git-svn-id: http://svn.automattic.com/wordpress/trunk@15957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-25 03:11:01 +00:00
nacin
5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
nacin
650f97e684 Adjustments to [15549]. See #11624.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-04 15:51:04 +00:00
scribu
950901ca92 Don't use the global anymore. Fixes #11624
git-svn-id: http://svn.automattic.com/wordpress/trunk@15549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-08-28 11:57:28 +00:00
westi
64100e8783 Fix the theme compat file require paths to be fully absolute so they don't rely on a particular php path to work. Fixes #14315 for trunk props dougal.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-16 09:40:09 +00:00
nacin
69b10a2948 Restore trackback_rdf(). reverts [13991]. fixes #11139 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-03 05:55:04 +00:00
dd32
a14d289755 Alot more tabs. Props jacobsantos & Viper007bond. See #14147
git-svn-id: http://svn.automattic.com/wordpress/trunk@15355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-30 00:05:18 +00:00
nacin
f60838c8f9 s/echos/echoes/ in phpdoc. props demetris, fixes #13742.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-06 05:16:32 +00:00
nacin
249a6cdd18 Use p instead of definition list for allowed tags in comment_form(). props demetris. Style the new markup in Twenty Ten. see #10910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 06:38:58 +00:00
nacin
a03dfef3fd Fix typos in phpdoc for comment_form(). props demetris, fixes #10910.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-10 08:47:13 +00:00
ryan
7b7243d94a Strip trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 20:26:11 +00:00
nbachiyski
2a1d6e141b Take out the leading space from the translatable string
git-svn-id: http://svn.automattic.com/wordpress/trunk@14378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 18:48:33 +00:00
ryan
172aa06718 Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051
git-svn-id: http://svn.automattic.com/wordpress/trunk@14374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 18:16:22 +00:00
westi
ae468d52ac First pass of compatibility code for old themes which relied on using templates from the default theme without expressly identifying it as the parent theme.
Fixes #12425 and #13009.
The fallback to these template files is now depreceated and will be removed in a future version.


git-svn-id: http://svn.automattic.com/wordpress/trunk@14365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 09:57:24 +00:00