Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-27 03:27:46 +01:00
Code Issues Projects Releases Wiki Activity
40,707 Commits 50 Branches 749 Tags 806 MiB
8d6912dd27
Commit Graph

14411 Commits

Author SHA1 Message Date
Andrew Ozz
60c2966222 Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in wp_get_missing_image_subsizes(). Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold. 
Props desrosj, azaozz.
Fixes #48518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46677


git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-07 18:51:02 +00:00
desrosj
24f21d628d Bundled Themes: Standardize the Required PHP and Tested Up To headers. 
This change makes several changes to ensure consistency and accuracy for default theme headers:

- Removes `WordPress` from `Requires at least` headers.
- Ensures the `Requires at least` and `Requires PHP` headers are present in every default theme’s `style.css` file.
- Ensures `Tested up to` is present in every `readme.txt` file.
- Removes any headers not processed in both the `style.css` and `readme.txt` files for each theme.

Props Otto42, afragen.
Fixes #48517.
Built from https://develop.svn.wordpress.org/trunk@46676


git-svn-id: http://core.svn.wordpress.org/trunk@46476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-07 15:19:04 +00:00
Sergey Biryukov
9088bea749 Docs: Make @param tags in mce_buttons and related filters consistent with the variable names. 
Props upadalavipul, isabel_brison.
Fixes #41456.
Built from https://develop.svn.wordpress.org/trunk@46675


git-svn-id: http://core.svn.wordpress.org/trunk@46475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-07 07:12:06 +00:00
Sergey Biryukov
4a2dc1a1a2 Tests: Properly mark test_submenu_helpers_priority() as skipped for multisite, so it's not categorized as "risky". 
See #39776.
Built from https://develop.svn.wordpress.org/trunk@46674


git-svn-id: http://core.svn.wordpress.org/trunk@46474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-06 01:17:03 +00:00
Sergey Biryukov
46caa0bfe8 Coding Standards: Fix WPCS issues in [46670]. 
See #48145.
Built from https://develop.svn.wordpress.org/trunk@46671


git-svn-id: http://core.svn.wordpress.org/trunk@46471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 23:18:02 +00:00
John Blackbourn
a02c91ca17 REST API: Use explicit dates in a post ordering test to avoid indeterminate ordering. 
See #48145

Built from https://develop.svn.wordpress.org/trunk@46670


git-svn-id: http://core.svn.wordpress.org/trunk@46470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:41:01 +00:00
desrosj
ffbde837e0 Bundled Themes: Update Twenty Twenty. 
This brings Twenty Twenty in sync with GitHub. For a full list of changes since 5.3 RC3, see dea9290...c267289.

Props williampatton, poena, andersnoren.
See #48110, #48386, #48450, #48293.
Fixes #48505.
Built from https://develop.svn.wordpress.org/trunk@46668


git-svn-id: http://core.svn.wordpress.org/trunk@46468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:22:01 +00:00
desrosj
b8a473c834 Emoji: Upgrade Twemoji to 12.1.3. 
This point release does not add any images and only slightly modifies a few images without changing their meanings. Because of this, the same CDN location can be used and has been updated.

Props matstars, desrosj, Otto42, pento.
Fixes #48293.
Built from https://develop.svn.wordpress.org/trunk@46665


git-svn-id: http://core.svn.wordpress.org/trunk@46465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 22:04:02 +00:00
John Blackbourn
9716848c87 Block Editor: Revert [46663] which was itself an erroneous revert. 
See #48502

Built from https://develop.svn.wordpress.org/trunk@46664


git-svn-id: http://core.svn.wordpress.org/trunk@46464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:59:03 +00:00
John Blackbourn
13f3142222 Block Editor: Bug fixes targeted for WordPress 5.3 RC4. 
Merges [46656] to the 5.3 branch.
Fixes #48502

Built from https://develop.svn.wordpress.org/trunk@46663


git-svn-id: http://core.svn.wordpress.org/trunk@46463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:53:03 +00:00
John Blackbourn
eda6a9e111 Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46662


git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:30:03 +00:00
John Blackbourn
9ac1d82f23 Docs: Further improve documentation of known return types, plus other docs fixes. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46661


git-svn-id: http://core.svn.wordpress.org/trunk@46461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:27:02 +00:00
John Blackbourn
f545bb3f63 Docs: Improve documentation of known return types, plus other docs fixes. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46660


git-svn-id: http://core.svn.wordpress.org/trunk@46460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 21:23:02 +00:00
Andrew Ozz
f9e81c83d5 Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image. 
Props ianmjones, azaozz.
Fixes #48453 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46658


git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 20:53:03 +00:00
Sergey Biryukov
ee7ec873ce REST API: Speed up pagination unit tests by creating less fixtures and reusing them where possible. 
Includes minor documentation and code layout fixes for better readability.

See #30017, #48145.
Built from https://develop.svn.wordpress.org/trunk@46657


git-svn-id: http://core.svn.wordpress.org/trunk@46457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 20:43:04 +00:00
jorgefilipecosta
6cdb9d0a37 Block Editor: Bug fixes targeted for WordPress 5.3 RC4. 
The list of included fixes is:

https://github.com/WordPress/gutenberg/pull/18183
https://github.com/WordPress/gutenberg/pull/18194
https://github.com/WordPress/gutenberg/pull/18230
https://github.com/WordPress/gutenberg/pull/18275
https://github.com/WordPress/gutenberg/pull/18287

Updated packages:
 - @wordpress/block-editor@3.2.4
 - @wordpress/block-library@2.9.5
 - @wordpress/edit-post@3.8.5
 - @wordpress/editor@9.7.5
 - @wordpress/format-library@1.9.4

Props @aduth, @mcsf, @youknowriad, @johnbillion.
Fixes #48502.
Built from https://develop.svn.wordpress.org/trunk@46656


git-svn-id: http://core.svn.wordpress.org/trunk@46456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 19:36:07 +00:00
whyisjake
5b4fe55ee8 REST API: Fix for Yoda condition. 
Little coding standards fix for the REST API.

Props mukesh27, spenserhale.

Fixes #48337.

Built from https://develop.svn.wordpress.org/trunk@46654


git-svn-id: http://core.svn.wordpress.org/trunk@46454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-05 17:38:03 +00:00
John Blackbourn
2e22c8292d Docs: Correct and improve the readability of some parameters of WP_Term_Query. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46652


git-svn-id: http://core.svn.wordpress.org/trunk@46452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 17:50:02 +00:00
Andrew Ozz
43ed67661a Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it. 
See #48472.
Built from https://develop.svn.wordpress.org/trunk@46651


git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 17:07:03 +00:00
Sergey Biryukov
4ef6154be2 Login and Registration: Simplify the test for wp_signon() added in [46640]. 
Make sure it actually tests the change in behavior, previously it passed both before and after the patch.

Add `wp_unslash()` to the last remaining instance of `$_POST['user_login']` that didn't have it.

See #38744.
Built from https://develop.svn.wordpress.org/trunk@46650


git-svn-id: http://core.svn.wordpress.org/trunk@46450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 15:06:02 +00:00
Sergey Biryukov
b5bf852dfe Build/Test Tools: Adjust the test for wp_redirect() status codes added in [46641] per the documentation and coding standards. 
Move the test to a more appropriate place for consistency with `wp_sanitize_redirect()` and `wp_validate_redirect()` tests.

See #44317.
Built from https://develop.svn.wordpress.org/trunk@46649


git-svn-id: http://core.svn.wordpress.org/trunk@46449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 12:59:01 +00:00
Sergey Biryukov
8dc75b569c REST API: Set orderby parameter in tax relation unit tests added in [46646]. 
The default value of `date` caused a race condition resulting in random test failures.

See #44326.
Built from https://develop.svn.wordpress.org/trunk@46648


git-svn-id: http://core.svn.wordpress.org/trunk@46448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 12:36:04 +00:00
Sergey Biryukov
8b76312eb3 Docs: Correct some array hash notations added in [46644]. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46647


git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-04 09:37:02 +00:00
TimothyBlynJacobs
5124c542e1 REST API: Add tax relation parameter to posts collection. 
The REST API supports filtering by terms across multiple taxonomies using an AND relation. This adds support for an OR relation by adding "tax_relation=OR" as a query parameter.

Props earnjam.
Fixes #44326.

Built from https://develop.svn.wordpress.org/trunk@46646


git-svn-id: http://core.svn.wordpress.org/trunk@46446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 23:14:02 +00:00
Aaron Jorbin
a4687f9134 Remove Failing Tests added in r46641 
The tests for good redirects send headers that we can't handle in the test suite, so let's just remove them.

Unprops Jorbin.
Fixes #44317.


Built from https://develop.svn.wordpress.org/trunk@46645


git-svn-id: http://core.svn.wordpress.org/trunk@46445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:49:03 +00:00
John Blackbourn
b3d6acd6a4 Docs: Fix some incorrect return tags in docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46644


git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:23:01 +00:00
whyisjake
441a4d752e Coding Standards: Clean up the tests around test_that_you_can_login_with_an_email_that_has_apostrophe. 
Let's use the proper coding standards for the comments.

Fixes #38744.
Props cafenoirdesign.

Built from https://develop.svn.wordpress.org/trunk@46643


git-svn-id: http://core.svn.wordpress.org/trunk@46443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:17:58 +00:00
whyisjake
5e7876622e Toolbar: Use add_node() instead of add_menu() in core. 
This patch replaces all references to the add_menu() method with the add_node() one. (Also some code structure modifications for wp_admin_bar_appearance_menu().)

Fixes: #19647
Props: linuxologos, paulschreiber, morganestes, akibjorklund, nacin, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46642


git-svn-id: http://core.svn.wordpress.org/trunk@46442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:14:01 +00:00
Aaron Jorbin
946217dcca General: wp_safe_redirect() and wp_redirect() shouldn't allow non-3xx status codes 
Redirects should use redirect status codes and if you attempt to call wp_safe_redirect or wp_redirect with a non redirect status it can lead to undesired behavior and head scratching.

Fixes #44317.
Props spenserhale, johnbillion, mjnewman for initial patch.


Built from https://develop.svn.wordpress.org/trunk@46641


git-svn-id: http://core.svn.wordpress.org/trunk@46441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 22:10:02 +00:00
whyisjake
a87271af60 Login and Registration: Allow email logins to be more flexible. 
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.

Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@46640


git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 20:12:02 +00:00
desrosj
44db7e4f6f External Libraries: Revert [46634-46635]. 
On further investigation, Plupload changed it’s license to a non-GPL compatible license. The newest, GPL compatible version is being used already in Core.

Unprops desrosj.
See #48277.
Built from https://develop.svn.wordpress.org/trunk@46638


git-svn-id: http://core.svn.wordpress.org/trunk@46438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 17:09:02 +00:00
desrosj
583e49d95f Customize: Formally deprecate unused Customizer classes. 
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.

Props weston.ruter, matthias-reuter, jrf.
Fixes #42364.
Built from https://develop.svn.wordpress.org/trunk@46637


git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 16:48:00 +00:00
desrosj
be164bf6f4 Add svn:auto-props for eol-style and mime-type to trunk. 
`svn:eol-style` and `svn:mime-type` property default values are now provided for all file types currently in `trunk`.

This also reverts the `eol-style` change to `wp-config-sample.php` made in [46586].

Fixes #42594.
Built from https://develop.svn.wordpress.org/trunk@46636


git-svn-id: http://core.svn.wordpress.org/trunk@46436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 16:21:03 +00:00
desrosj
df7a0f7879 Remove unintended change to svn:ignore in [46634]. 
Built from https://develop.svn.wordpress.org/trunk@46635


git-svn-id: http://core.svn.wordpress.org/trunk@46435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 15:34:00 +00:00
desrosj
d825155631 External Libraries: Update Plupload from 2.1.9 to 2.3.6. 
This change also updates the MoxieJS dependency from 1.3.5 to 1.5.7, converts Plupload to a dependency in NPM, and integrates all relevant parts into the build process.

For a full list of upstream changes, see https://github.com/moxiecode/plupload/compare/v2.1.9...v2.3.6.

Props desrosj, hareesh-pillai.
Fixes #48277.
Built from https://develop.svn.wordpress.org/trunk@46634


git-svn-id: http://core.svn.wordpress.org/trunk@46434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 15:31:02 +00:00
Sergey Biryukov
265bc4fe74 General: Wrap the error message in _deprecated_constructor() in <code> tags instead of <pre>. 
Props aftabmuni.
Fixes #48483.
Built from https://develop.svn.wordpress.org/trunk@46633


git-svn-id: http://core.svn.wordpress.org/trunk@46433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-03 10:56:03 +00:00
Sergey Biryukov
24650cbd68 Code Modernization: Call PHP 5 constructors in methods extending POMO_Reader. 
Follow-up to [46629].

See #48252.
Built from https://develop.svn.wordpress.org/trunk@46632


git-svn-id: http://core.svn.wordpress.org/trunk@46432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:49:01 +00:00
Sergey Biryukov
6cd00d098e Docs: Correct version number in @deprecated tags for PHP 4 constructors in pomo/entry.php and pomo/streams.php. 
Follow-up to [46629].

Props jrf.
See #48252.
Built from https://develop.svn.wordpress.org/trunk@46631


git-svn-id: http://core.svn.wordpress.org/trunk@46431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:30:01 +00:00
Sergey Biryukov
85db3b5090 Docs: Correct @see references for PHP 4 constructors in wp-includes/class-json.php. 
See #48252, #48303.
Built from https://develop.svn.wordpress.org/trunk@46630


git-svn-id: http://core.svn.wordpress.org/trunk@46430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:13:02 +00:00
Sergey Biryukov
a0e7056387 Docs: Add missing @deprecated tags to PHP 4 constructors in pomo/entry.php and pomo/streams.php. 
Props jrf.
Fixes #48252.
Built from https://develop.svn.wordpress.org/trunk@46629


git-svn-id: http://core.svn.wordpress.org/trunk@46429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:11:04 +00:00
Sergey Biryukov
8aae5cb572 Twenty Eleven: Add missing @deprecated tag to PHP 4 constructor in Twenty_Eleven_Ephemera_Widget. 
Props jrf.
See #48252.
Built from https://develop.svn.wordpress.org/trunk@46628


git-svn-id: http://core.svn.wordpress.org/trunk@46428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:08:00 +00:00
Sergey Biryukov
6be425959a Docs: Add missing @deprecated tags to PHP 4 constructors in WP_Widget and WP_Widget_Factory(). 
Correct version number in `_deprecated_constructor()` call in `WP_Widget_Factory()`, see [32990].

Props jrf.
See #48252.
Built from https://develop.svn.wordpress.org/trunk@46627


git-svn-id: http://core.svn.wordpress.org/trunk@46427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-02 20:06:03 +00:00
Sergey Biryukov
2651ff3ae8 Docs: Update URLs in some @link tags and switch them to HTTPS. 
Props tsuyoring.
Fixes #48479.
Built from https://develop.svn.wordpress.org/trunk@46626


git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-01 14:57:02 +00:00
Sergey Biryukov
979a526902 Code Modernization: Pass an appropriate error level to trigger_error() in _doing_it_wrong() and related functions: 
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

The error level passed is `E_USER_DEPRECATED` for the deprecated function group and `E_USER_NOTICE` for `_doing_it_wrong()`.

Props jrf.
Fixes #36561.
Built from https://develop.svn.wordpress.org/trunk@46625


git-svn-id: http://core.svn.wordpress.org/trunk@46422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-11-01 00:41:01 +00:00
John Blackbourn
be91e3e1b9 Docs: Correct some more invalid inline docs. 
See https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#summary-formerly-short-description

See #48303

Built from https://develop.svn.wordpress.org/trunk@46624


git-svn-id: http://core.svn.wordpress.org/trunk@46421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 21:20:02 +00:00
John Blackbourn
d1b23193dd Docs: Correct some incorrect docblock tags. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46623


git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 17:51:01 +00:00
Sergey Biryukov
3d76b537d6 Docs: Add @since tag for the $context parameter added to wp_generate_attachment_metadata filter in [46621]. 
See #48472.
Built from https://develop.svn.wordpress.org/trunk@46622


git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-31 00:13:01 +00:00
Andrew Ozz
ed651b17a4 Upload: 
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.

Fixes #48472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46621


git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-30 21:10:04 +00:00
Sergey Biryukov
e678d5bf28 Docs: Document $error, $interim_login, and $action globals in login_header() and login_footer(). 
Props priyankabehera155, faisal03, mukesh27, SergeyBiryukov.
Fixes #45777.
Built from https://develop.svn.wordpress.org/trunk@46620


git-svn-id: http://core.svn.wordpress.org/trunk@46417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-30 02:59:03 +00:00
desrosj
0b94025ba9 Help/About: Update the 5.3 About page for RC3. 
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46616


git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 20:10:04 +00:00
desrosj
b5cc5b37f7 Bundled Themes: Update Twenty Twenty. 
This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see 4549fd9...dea9290.

Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Fixes #48450.
Built from https://develop.svn.wordpress.org/trunk@46613


git-svn-id: http://core.svn.wordpress.org/trunk@46410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 14:55:05 +00:00
Sergey Biryukov
4935555c70 Build/Test Tools: Ignore EOL differences in tests using multiline string assertions. 
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Fixes #31432. See #42594, #47411.
Built from https://develop.svn.wordpress.org/trunk@46612


git-svn-id: http://core.svn.wordpress.org/trunk@46409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-29 14:28:06 +00:00
John Blackbourn
057f661ce3 Docs: Miscellaneous docblock corrections. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46610


git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 19:48:01 +00:00
John Blackbourn
c08dbe5236 Docs: Coding standards fix after [46608]. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46609


git-svn-id: http://core.svn.wordpress.org/trunk@46406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 19:35:07 +00:00
John Blackbourn
817807e5be Docs: Remove some funky nested filters. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46608


git-svn-id: http://core.svn.wordpress.org/trunk@46405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 19:04:05 +00:00
Sergey Biryukov
3a257f4018 Docs: Restore correct placement for duplicate hook reference in render_block_core_latest_comments(). 
Previously fixed in [46604], accidentally reverted in [46606].

See #48447, #48303.
Built from https://develop.svn.wordpress.org/trunk@46607


git-svn-id: http://core.svn.wordpress.org/trunk@46404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 15:17:03 +00:00
youknowriad
6a713e53bc Block Editor: Bug fixes targetted for WordPress 5.3 RC3. 
The list of included fixes is:

- https://github.com/WordPress/gutenberg/pull/18108
- https://github.com/WordPress/gutenberg/pull/18051
- https://github.com/WordPress/gutenberg/pull/18106
- https://github.com/WordPress/gutenberg/pull/18102

Updated packages:
 - @wordpress/api-fetch@3.6.4
 - @wordpress/block-directory@1.0.4
 - @wordpress/block-library@2.9.4
 - @wordpress/core-data@2.7.4
 - @wordpress/data-controls@1.3.4
 - @wordpress/edit-post@3.8.4
 - @wordpress/editor@9.7.4
 - @wordpress/list-reusable-blocks@1.8.4
 - @wordpress/media-utils@1.2.4
 - @wordpress/server-side-render@1.3.4

Props desrosj.
See #48447.

Built from https://develop.svn.wordpress.org/trunk@46606


git-svn-id: http://core.svn.wordpress.org/trunk@46403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 14:13:09 +00:00
whyisjake
7542543e26 Build/Test Tools: Don't hardcode the directory name of the repo 
When Travis builds the directory, it was looking for a hardcoded `wordpress-develop` directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.
Props pento, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46605


git-svn-id: http://core.svn.wordpress.org/trunk@46402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-28 04:17:02 +00:00
John Blackbourn
f243cd573c Docs: Correct invalid hook docblock placement. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46604


git-svn-id: http://core.svn.wordpress.org/trunk@46401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 19:35:01 +00:00
John Blackbourn
c8f91f77ac Docs: Correct invalid hook docblocks. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46603


git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 19:11:02 +00:00
Sergey Biryukov
c283f8b1ed Docs: Remove "private" designation from _doing_it_wrong() and related functions: 
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

Plugins and themes should be allowed to use these functions to throw appropriate error notices.

This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.

Props jrf.
Fixes #48251.
Built from https://develop.svn.wordpress.org/trunk@46602


git-svn-id: http://core.svn.wordpress.org/trunk@46399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:21:03 +00:00
Sergey Biryukov
e015fbd8bb Editor: Fix typo in an error message in WP_Block_Styles_Registry::register(). 
Props man4toman, alishankhan, shaampk1.
Fixes #48437.
Built from https://develop.svn.wordpress.org/trunk@46601


git-svn-id: http://core.svn.wordpress.org/trunk@46398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:09:02 +00:00
Sergey Biryukov
bb57520713 Docs: Improve DocBlock formatting in WP_Block_Styles_Registry per the documentation standards. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46600


git-svn-id: http://core.svn.wordpress.org/trunk@46397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-27 14:07:02 +00:00
John Blackbourn
d599314349 Docs: Correct and improve inline docs for the file type functions. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46599


git-svn-id: http://core.svn.wordpress.org/trunk@46396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:49:03 +00:00
John Blackbourn
ac6bf7666c Docs: Add missing docs for the auth_cookie_bad_session_token action. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46598


git-svn-id: http://core.svn.wordpress.org/trunk@46395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:46:00 +00:00
John Blackbourn
9e2b6902b3 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46597


git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 23:16:04 +00:00
John Blackbourn
3caaa40fc6 Docs: Switch more docs over to typed array notation, plus some fixes. 
See #48303, #41756

Built from https://develop.svn.wordpress.org/trunk@46596


git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 21:09:04 +00:00
John Blackbourn
9890e68661 Docs: Switch to typed array notation for the docs for asset dependency functions. 
Props marekdedic

See #48303

Built from https://develop.svn.wordpress.org/trunk@46595


git-svn-id: http://core.svn.wordpress.org/trunk@46392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 21:02:02 +00:00
John Blackbourn
7c2b9f2a2e Docs: Miscellaneous docblock fixes and improvements. 
See #48303

Built from https://develop.svn.wordpress.org/trunk@46594


git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 20:43:04 +00:00
Sergey Biryukov
552852d887 Docs: Improve documentation for esc_attr_e(), esc_html_e(), esc_attr_x(), esc_html_x(). 
Props atachibana.
Fixes #48383.
Built from https://develop.svn.wordpress.org/trunk@46593


git-svn-id: http://core.svn.wordpress.org/trunk@46390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 17:30:03 +00:00
Sergey Biryukov
ac3ff7eb1a Docs: Improve documentation for wptexturize(). 
Props atachibana.
Fixes #48397.
Built from https://develop.svn.wordpress.org/trunk@46592


git-svn-id: http://core.svn.wordpress.org/trunk@46389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:58:04 +00:00
Sergey Biryukov
67ce1885db Docs: Improve formatting of various WP_Screen DocBlocks. 
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46591


git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:36:05 +00:00
Sergey Biryukov
67c73ea3ea Docs: Improve documentation for WP_Screen::add_help_tab(). 
Props atachibana.
Fixes #48395.
Built from https://develop.svn.wordpress.org/trunk@46590


git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:34:07 +00:00
Sergey Biryukov
49007e52bc Build/Test Tools: Add banner to RTL CSS and minified JS files. 
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.
Built from https://develop.svn.wordpress.org/trunk@46589


git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-26 00:17:07 +00:00
desrosj
b51327d391 Ensure svn:mime-type is consistently set for appropriate files. 
Continuation of [46586], [46587]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46588


git-svn-id: http://core.svn.wordpress.org/trunk@46385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 19:33:04 +00:00
desrosj
09d8704f0f Ensure svn:eol-style is consistently set for all files (part 2). 
Continuation of [46586]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46587


git-svn-id: http://core.svn.wordpress.org/trunk@46384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 19:29:04 +00:00
desrosj
eca853c79e Ensure svn:eol-style is consistently set for all files. 
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46586


git-svn-id: http://core.svn.wordpress.org/trunk@46383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 16:38:07 +00:00
desrosj
43c6bc6805 Remove the svn:executable property from files that don't need it. 
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46585


git-svn-id: http://core.svn.wordpress.org/trunk@46382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 15:36:05 +00:00
Sergey Biryukov
9ebaa9d522 Date/Time: Remove incomplete and redundant test for get_post_time() added in [46580]. 
There is no functional difference between `gmt_offset` and `timezone_string` timezone modes for the issue.

See #48384.
Built from https://develop.svn.wordpress.org/trunk@46583


git-svn-id: http://core.svn.wordpress.org/trunk@46380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 15:11:04 +00:00
desrosj
a922509f96 Trunk is now 5.4 alpha. 
Built from https://develop.svn.wordpress.org/trunk@46582


git-svn-id: http://core.svn.wordpress.org/trunk@46379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 14:24:04 +00:00
Sergey Biryukov
75c183c248 Date/Time: Make sure get_post_time() keeps UTC time on timezone change. 
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.
Built from https://develop.svn.wordpress.org/trunk@46580


git-svn-id: http://core.svn.wordpress.org/trunk@46377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 13:08:05 +00:00
Sergey Biryukov
7e11e9d732 Posts, Post Types: Remove unintended change from [46578]. 
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46579


git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:54:03 +00:00
Sergey Biryukov
0b83bffd45 Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp. 
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46578


git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 12:51:03 +00:00
Sergey Biryukov
8410526528 Date/Time: Make sure date_i18n() correctly handles zero timestamp after [45901]. 
Props soulseekah, gravityview, Rarst.
Reviewed by azaozz, SergeyBiryukov.
Fixes #28636.
Built from https://develop.svn.wordpress.org/trunk@46577


git-svn-id: http://core.svn.wordpress.org/trunk@46374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 11:05:07 +00:00
desrosj
5e18c8320b Build/Test Tools: Update the https-proxy-agent dependency. 
Fixes #48428.
Built from https://develop.svn.wordpress.org/trunk@46576


git-svn-id: http://core.svn.wordpress.org/trunk@46373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-25 00:24:05 +00:00
Andrea Fercia
5b85aa1936 Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241]. 
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.

Built from https://develop.svn.wordpress.org/trunk@46575


git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-23 20:57:05 +00:00
desrosj
cc73b9a1be Post WordPress 5.3 RC2 version bump. 
Built from https://develop.svn.wordpress.org/trunk@46574


git-svn-id: http://core.svn.wordpress.org/trunk@46371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 20:11:05 +00:00
desrosj
ca5925d6dc WordPress 5.3 RC2. 
Built from https://develop.svn.wordpress.org/trunk@46573


git-svn-id: http://core.svn.wordpress.org/trunk@46370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 19:44:06 +00:00
desrosj
27994975f9 Help/About: Update the 5.3 About page for RC2. 
This includes numerous improvements:

- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.

Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46572


git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 19:19:07 +00:00
desrosj
16e5753b48 Bundled Themes: Update Twenty Twenty. 
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46551], see bc89c51...4549fd9.

Reviewed by SergeyBiryukov, desrosj, ianbelanger.
Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, intimez, itowhid06, decrecementofeliz, aristath, westonruter, mukesh27, jorgefilipecosta, karmatosed.
Fixes #48386.
Built from https://develop.svn.wordpress.org/trunk@46571


git-svn-id: http://core.svn.wordpress.org/trunk@46368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 18:27:08 +00:00
Sergey Biryukov
0609e04266 Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197]. 
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.
Built from https://develop.svn.wordpress.org/trunk@46570


git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 17:52:04 +00:00
Sergey Biryukov
4e06f0ad40 Date/Time: Make sure wp_date() does not unnecessarily escape localized numbers, but keeps localized slashes. 
Props Rarst, tmatsuur, remcotolsma, peterwilsoncc.
Reviewed by peterwilsoncc.
Fixes #48319.
Built from https://develop.svn.wordpress.org/trunk@46569


git-svn-id: http://core.svn.wordpress.org/trunk@46366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 17:31:08 +00:00
Sergey Biryukov
ff65cfcacf Plugins: Restore backward compatibility for PHP4-style passing of array( &$this ) as action argument to do_action(). 
This is a follow-up to [46149] to avoid unnecessary breakage in case of using the old notation.

Props david.binda, jrf.
Reviewed by azaozz.
Fixes #48312.
Built from https://develop.svn.wordpress.org/trunk@46568


git-svn-id: http://core.svn.wordpress.org/trunk@46365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-22 00:11:03 +00:00
Andrew Ozz
b37a2b5c3b Media: After [46237] add the same fix to the .button-group on the "Insert form URL" screen in the media modal. 
Props afercia, sabernhardt.
FIxes #48087.
Built from https://develop.svn.wordpress.org/trunk@46567


git-svn-id: http://core.svn.wordpress.org/trunk@46364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 23:23:04 +00:00
Andrew Ozz
5013b45775 Upload: Expand error codes to include all 5xx HTTP errors when retrying to create image sub-sizes. Some servers may be configured to set HTTP 508 or 504, or possibly other 5 errors. 
Porps mikeschroder, azaozz.
Fixes #48379.
Built from https://develop.svn.wordpress.org/trunk@46566


git-svn-id: http://core.svn.wordpress.org/trunk@46363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 22:44:03 +00:00
Andrew Ozz
e1560cd1e0 Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append scaled- to the file names of the scaled images to make them easier to recognize. 
Props kraftbj, azaozz.
Fixes #48304.
Built from https://develop.svn.wordpress.org/trunk@46565


git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 21:43:04 +00:00
Sergey Biryukov
654c413990 Comments: Add rel="nofollow ugc" attribute when converting plain URLs to <a> tags in comments via make_clickable(). 
Introduce `make_clickable_rel` filter for the `rel` value that is added to URL matches converted to links.

This is a follow-up to [46349], which added the `rel="nofollow ugc"` attribute to existing `<a>` tags in comments via `wp_rel_ugc()`.

UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props blogginglife, SergeyBiryukov.
Reviewed by desrosj, audrasjb.
Fixes #48022.
Built from https://develop.svn.wordpress.org/trunk@46564


git-svn-id: http://core.svn.wordpress.org/trunk@46361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 20:41:04 +00:00
K. Adam White
cfec48cc31 REST API: Cast empty meta values to correct scalar types in REST response. 
Introducing complex meta value handling in [45807] unintentionally removed value casting for empty scalar meta values.

Props TimothyBlynJacobs, chrisvanpatten, rmccue, kadamwhite.
Fixes #48363.


Built from https://develop.svn.wordpress.org/trunk@46563


git-svn-id: http://core.svn.wordpress.org/trunk@46360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 19:10:06 +00:00
youknowriad
21bf3bf8dd Block Editor: Update Packages that include WP 5.3 RC2 fixes. 
Updated packages:
 - @wordpress/api-fetch@3.6.3
 - @wordpress/block-directory@1.0.3
 - @wordpress/block-editor@3.2.3
 - @wordpress/block-library@2.9.3
 - @wordpress/core-data@2.7.3
 - @wordpress/data-controls@1.3.3
 - @wordpress/e2e-test-utils@2.4.3
 - @wordpress/e2e-tests@1.7.3
 - @wordpress/edit-post@3.8.3
 - @wordpress/editor@9.7.3
 - @wordpress/format-library@1.9.3
 - @wordpress/list-reusable-blocks@1.8.3
 - @wordpress/media-utils@1.2.3
 - @wordpress/server-side-render@1.3.3
 - @wordpress/url@2.8.2

Props gziolo.
Fixes #48381.

Built from https://develop.svn.wordpress.org/trunk@46562


git-svn-id: http://core.svn.wordpress.org/trunk@46359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-21 14:02:07 +00:00
John Blackbourn
67104bb3f4 Administration: Revert changes to the admin menu styles for long line lengths. 
This reverts [46555], [46453], and [46332].

See #42201

Built from https://develop.svn.wordpress.org/trunk@46561


git-svn-id: http://core.svn.wordpress.org/trunk@46358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-17 18:38:03 +00:00
desrosj
1d6bd71ce4 Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing. 
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.

Follow up of [46455].

Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699.
Built from https://develop.svn.wordpress.org/trunk@46560


git-svn-id: http://core.svn.wordpress.org/trunk@46357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-16 21:03:02 +00:00
Andrea Fercia
44de60e8da Script Loader: Partially revert [46550] as it brought in unrelated CSS changes. 
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.

See #47069.

Built from https://develop.svn.wordpress.org/trunk@46559


git-svn-id: http://core.svn.wordpress.org/trunk@46356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-16 17:49:03 +00:00
Sergey Biryukov
76fe29b746 Post WordPress 5.3 RC1 version bump 
Built from https://develop.svn.wordpress.org/trunk@46558


git-svn-id: http://core.svn.wordpress.org/trunk@46355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 21:14:01 +00:00
Sergey Biryukov
05cbe81439 WordPress 5.3 RC1 
Built from https://develop.svn.wordpress.org/trunk@46557


git-svn-id: http://core.svn.wordpress.org/trunk@46354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 20:50:05 +00:00
John Blackbourn
2ab1e4dcd8 Help/About: Let's tell the world about 5.3. 
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald

Thanks to everyone who provided feedback for this page for 5.3.

See #47708

Built from https://develop.svn.wordpress.org/trunk@46556


git-svn-id: http://core.svn.wordpress.org/trunk@46353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 20:42:03 +00:00
John Blackbourn
7cdb93a374 Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed. 
Props afercia, amolv, sabernhardt

Fixes #42201, #48294

Built from https://develop.svn.wordpress.org/trunk@46555


git-svn-id: http://core.svn.wordpress.org/trunk@46352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 19:39:01 +00:00
Sergey Biryukov
b052bca67e Shortcodes: Revert [46369] for now to allow more time to investigate and prepare for backward compatibility changes. 
Also reverts follow-up changes in [46370] and [46465].

See #47863.
Built from https://develop.svn.wordpress.org/trunk@46554


git-svn-id: http://core.svn.wordpress.org/trunk@46351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 19:36:02 +00:00
Andrew Ozz
f7968ccb92 Media: Similarly to wp_get_original_image_path() add wp_get_original_image_url() to always retrieve the URL to the original uploaded image. 
Props kraftbj.
Fixes #48302.
Built from https://develop.svn.wordpress.org/trunk@46553


git-svn-id: http://core.svn.wordpress.org/trunk@46350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 19:12:02 +00:00
Sergey Biryukov
93e28555ae Build/Test Tools: Move PHP 7.4 to the top of the list for consistency. 
See #48232.
Built from https://develop.svn.wordpress.org/trunk@46552


git-svn-id: http://core.svn.wordpress.org/trunk@46349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 18:53:02 +00:00
desrosj
908961974e Bundled Themes: Update Twenty Twenty. 
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46445], see 7246fd6...bc89c51.

Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, netweb, joyously, mahesh901122, josephscott, byalextran, amolv, Clorith.
See #48110.
Built from https://develop.svn.wordpress.org/trunk@46551


git-svn-id: http://core.svn.wordpress.org/trunk@46348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 18:47:02 +00:00
Andrea Fercia
02810533c4 Accessibility: Script Loader: Remove jQuery as dependency of admin-bar after [46440]. 
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.

See #47069.

Built from https://develop.svn.wordpress.org/trunk@46550


git-svn-id: http://core.svn.wordpress.org/trunk@46347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 17:23:04 +00:00
Andrea Fercia
d5bfc553b9 Accessibility: Media: Improve the Media Modal spinner position after [46418]. 
Fixes #47138.

Built from https://develop.svn.wordpress.org/trunk@46549


git-svn-id: http://core.svn.wordpress.org/trunk@46346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:47:02 +00:00
Sergey Biryukov
71e8fedf6c Customize: Ensure that WP_Customize_Manager::import_theme_starter_content() properly handles starter content with (nested) arrays as values. 
Previously, searching for symbol references to replace with post or attachment IDs in array values resulted in a PHP warning.

Props timph, JarretC, SergeyBiryukov.
Fixes #45484.
Built from https://develop.svn.wordpress.org/trunk@46548


git-svn-id: http://core.svn.wordpress.org/trunk@46345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:43:01 +00:00
Aaron Jorbin
52dee3c19b Build/Test: Remove PHP 7.4 from allowed failures 
PHP7.4 is supported in WordPress 5.3. 🐘 🎉

Fixes: #48232.


Built from https://develop.svn.wordpress.org/trunk@46547


git-svn-id: http://core.svn.wordpress.org/trunk@46344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:38:03 +00:00
jorgefilipecosta
16571b1bfb Block Editor: Update the WordPress Packages to the ones used in the Gutenberg 6.8 release. 
Updated packages:
@wordpress/a11y@2.5.1
@wordpress/annotations@1.7.2
@wordpress/api-fetch@3.6.2
@wordpress/autop@2.5.1
@wordpress/babel-preset-default@4.6.2
@wordpress/blob@2.5.1
@wordpress/block-directory@1.0.2
@wordpress/block-editor@3.2.2
@wordpress/block-library@2.9.2
@wordpress/block-serialization-default-parser@3.4.1
@wordpress/block-serialization-spec-parser@3.3.1
@wordpress/blocks@6.7.2
@wordpress/components@8.3.2
@wordpress/compose@3.7.2
@wordpress/core-data@2.7.2
@wordpress/data-controls@1.3.2
@wordpress/data@4.9.2
@wordpress/deprecated@2.6.1
@wordpress/dom-ready@2.5.1
@wordpress/dom@2.5.2
@wordpress/e2e-test-utils@2.4.2
@wordpress/e2e-tests@1.7.2
@wordpress/edit-post@3.8.2
@wordpress/editor@9.7.2
@wordpress/element@2.8.2
@wordpress/escape-html@1.5.1
@wordpress/format-library@1.9.2
@wordpress/is-shallow-equal@1.6.1
@wordpress/keycodes@2.6.2
@wordpress/list-reusable-blocks@1.8.2
@wordpress/media-utils@1.2.2
@wordpress/notices@1.8.2
@wordpress/nux@3.7.2
@wordpress/plugins@2.7.2
@wordpress/priority-queue@1.3.1
@wordpress/redux-routine@3.6.2
@wordpress/rich-text@3.7.2
@wordpress/scripts@5.1.0
@wordpress/server-side-render@1.3.2
@wordpress/url@2.8.1
@wordpress/viewport@2.8.2
@wordpress/wordcount@2.6.2

Props gziolo, youknowriad.
Fixes: #48310
Built from https://develop.svn.wordpress.org/trunk@46546


git-svn-id: http://core.svn.wordpress.org/trunk@46343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 16:17:12 +00:00
whyisjake
6c3a387d77 REST API: Allow for multiple Vary: Origin headers in GET responses. 
Simple fix, we pass `false` as the second parameter to the header function.

This is something that we added downstream of the 5.2.4 release, but we missed in 5.2/trunk.

Fixes #48309.
Props xknown, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46544


git-svn-id: http://core.svn.wordpress.org/trunk@46341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 15:47:03 +00:00
gziolo
aca0d9968f Block Editor: Remove experimental Social Links blocks 
We decided to mark Social Links block as an experimental feature in Gutenberg. In effect, we are moving all related code from WordPress 5.3 release.

Props youknowriad.

Fixes #48263.


Built from https://develop.svn.wordpress.org/trunk@46543


git-svn-id: http://core.svn.wordpress.org/trunk@46340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 15:37:08 +00:00
Aaron Jorbin
1740246d2b Build/Test tools use Trunk revision 2170172 of importer 
Update Travis configuration to temporarily use trunk for the importer in order for PHP 7.4 tests to pass. When the new version is released, this will be updated to point to that tag.

See: #48231


Built from https://develop.svn.wordpress.org/trunk@46542


git-svn-id: http://core.svn.wordpress.org/trunk@46339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-15 14:42:04 +00:00
Andrew Ozz
1940cf7d54 Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging. 
Fixes #40439.
Built from https://develop.svn.wordpress.org/trunk@46507


git-svn-id: http://core.svn.wordpress.org/trunk@46304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 20:05:01 +00:00
Andrew Ozz
49686be2ab Uploads: Retry to post-process images after HTTP 500 and HTTP 502 errors. 
Props mikeschroder, azaozz.
Fixes #47872.
Built from https://develop.svn.wordpress.org/trunk@46506


git-svn-id: http://core.svn.wordpress.org/trunk@46303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 19:56:06 +00:00
Andrea Fercia
135bebc55b Accessibility: Media: Improve the text of the Media Modal actions toggle button displayed in the responsive view. 
See #47149.

Built from https://develop.svn.wordpress.org/trunk@46489


git-svn-id: http://core.svn.wordpress.org/trunk@46287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 18:03:04 +00:00
Andrea Fercia
c1d4bf2080 Accessibility: Media: Improve the new Media Modal headings text. 
See #47610.

Built from https://develop.svn.wordpress.org/trunk@46488


git-svn-id: http://core.svn.wordpress.org/trunk@46286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 17:58:04 +00:00
whyisjake
72130f11d0 Administration: Ensure that admin referer nonce is valid. 
Fix for a testing regression.

Props desrosj.

Built from https://develop.svn.wordpress.org/trunk@46485


git-svn-id: http://core.svn.wordpress.org/trunk@46283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 17:15:06 +00:00
whyisjake
89468bfb89 REST API: Ensure that we don't generate warnings from sending extra headers after headers have been sent. 
Fixes issues stemming from [46478].


Built from https://develop.svn.wordpress.org/trunk@46483


git-svn-id: http://core.svn.wordpress.org/trunk@46281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 16:25:04 +00:00
whyisjake
b224c251ad REST API: Send a Vary: Origin header on GET requests. 
Add this header on all GET requests to prevent cached requests.

Props darthhexx, davidbinda, nickdaugherty, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46478


git-svn-id: http://core.svn.wordpress.org/trunk@46276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:43:04 +00:00
whyisjake
b183fd1cca Administration: Ensure that admin referer nonce is valid. 
Coding standards, ensure that nonce is valid with identical, rather then equal operator.

Props vortfu, xknown, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46477


git-svn-id: http://core.svn.wordpress.org/trunk@46275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:40:04 +00:00
whyisjake
2524ba3aec Filesystem API: Prevent directory travelersals when creating new folders. 
Reject file paths that contain sub-directory paths.

Props iandunn, xknown, sstoqnov, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46476


git-svn-id: http://core.svn.wordpress.org/trunk@46274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:31:04 +00:00
whyisjake
608d39faed HTTP API: Protect against hex interpretation. 
Return earlier from wp_http_validate_url().

Props: iandunn, xknown, voldemortensen, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46475


git-svn-id: http://core.svn.wordpress.org/trunk@46273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:27:04 +00:00
whyisjake
946ec8492f Query: Remove the static query property. 
Prevent unauthenticated views of publicly queryables content types.

Props aaroncampbell, whyisjake, nickdaugherty, xknown.

Built from https://develop.svn.wordpress.org/trunk@46474


git-svn-id: http://core.svn.wordpress.org/trunk@46272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 15:20:03 +00:00
Sergey Biryukov
9db44754b9 Formatting: In wp_validate_redirect(), normalize the path when validating the location for relative URLs, to account for Windows paths. 
Props peterwilsoncc, rconde, jmmathc, mat-lipe, Sixes, justinahinon, cmagrin, daxelrod, SergeyBiryukov.
Fixes #47980.
Built from https://develop.svn.wordpress.org/trunk@46472


git-svn-id: http://core.svn.wordpress.org/trunk@46270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-14 10:52:04 +00:00
Sergey Biryukov
e8fcc3fbe7 Docs: Fix typo in a comment in WP_REST_Settings_Controller::prepare_value(). 
Convert the comment to a multi-line format per the documentation standards.

Props itowhid06.
See #48296.
Built from https://develop.svn.wordpress.org/trunk@46471


git-svn-id: http://core.svn.wordpress.org/trunk@46269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-13 10:02:04 +00:00
Peter Wilson
5d6cd13597 Docs: Correct documentation typo in print_emoji_detection_script(). 
Props itowhid06.
Fixes #48298. See #47110.

Built from https://develop.svn.wordpress.org/trunk@46470


git-svn-id: http://core.svn.wordpress.org/trunk@46268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-13 02:48:01 +00:00
Peter Wilson
8730eb34e3 Docs: Correct comment typo in WP_REST_Terms_Controller::update_item(). 
Props manikmist09.
Fixes #48295. See #47110.

Built from https://develop.svn.wordpress.org/trunk@46469


git-svn-id: http://core.svn.wordpress.org/trunk@46267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-13 02:42:01 +00:00
John Blackbourn
41d6b80d03 Docs: Fix and improve inline documentation for the HTTP API. 
See #47110

Built from https://develop.svn.wordpress.org/trunk@46468


git-svn-id: http://core.svn.wordpress.org/trunk@46266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 18:05:04 +00:00
Sergey Biryukov
634242343c Users: Make sure wp_logout() clears current user, so that a subsequent call to is_user_logged_in() works as expected. 
Props sebastian.pisula, donmhico, roytanck, juliobox.
Fixes #35488.
Built from https://develop.svn.wordpress.org/trunk@46467


git-svn-id: http://core.svn.wordpress.org/trunk@46265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 03:10:03 +00:00
Sergey Biryukov
4ca89cecbd Tests: Rename tests methods in tests/pluggable.php per the handbook's naming convention. 
See #47632.
Built from https://develop.svn.wordpress.org/trunk@46466


git-svn-id: http://core.svn.wordpress.org/trunk@46264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 03:02:03 +00:00
Sergey Biryukov
cf1c5e1b54 Docs: Adjust @since note in shortcode_parse_atts() for consistency with similar notes. 
See #47863.
Built from https://develop.svn.wordpress.org/trunk@46465


git-svn-id: http://core.svn.wordpress.org/trunk@46263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:50:03 +00:00
Sergey Biryukov
b0e0f69b2e I18N: Don't capitalize "Extension" in update_core(), for consistency with other strings. 
Follow-up to [46455].

See #47699.
Built from https://develop.svn.wordpress.org/trunk@46464


git-svn-id: http://core.svn.wordpress.org/trunk@46262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:42:01 +00:00
Sergey Biryukov
e19329bad0 Docs: Add requires_php to the list of fields returned by plugins_api(). 
Props ediamin.
Fixes #48291.
Built from https://develop.svn.wordpress.org/trunk@46463


git-svn-id: http://core.svn.wordpress.org/trunk@46261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-12 02:35:04 +00:00
Sergey Biryukov
b78a40aa4c Formatting: Make sure wp_sanitize_redirect() encodes spaces in URLs instead of stripping them out. 
Props donmhico, hlashbrooke, dd32, azaozz.
Fixes #36998.
Built from https://develop.svn.wordpress.org/trunk@46462


git-svn-id: http://core.svn.wordpress.org/trunk@46260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 23:54:03 +00:00
antpb
97356bbd75 Media: Adds Edit Image controller to Media Library select frame. 
This adds the necessary state for `EditImage` views in the `select` frame and listeners for setting that view.

Props fblaser, w3rkjana, afercia, antpb.
See #48028.

Built from https://develop.svn.wordpress.org/trunk@46461


git-svn-id: http://core.svn.wordpress.org/trunk@46259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 20:43:03 +00:00
antpb
ebd52ce048 Administration: Prevents horizontal scroll jumping around while admin menu is open. 
This sets the `#adminmenuback` `position` CSS property to `fixed`.

Props promz, man4toman.
Fixes #47010.

Built from https://develop.svn.wordpress.org/trunk@46460


git-svn-id: http://core.svn.wordpress.org/trunk@46258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 19:22:02 +00:00
Mike Schroder
66c8085fc4 Media: Update fallback previews to support _wp_make_subsizes() 
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.

Props azaozz, antpb, progremzion, mikeschroder.
See #48111.
Built from https://develop.svn.wordpress.org/trunk@46459


git-svn-id: http://core.svn.wordpress.org/trunk@46257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-11 07:54:03 +00:00
Aaron Jorbin
742537ac3d Cron: Prevent sending headers when using ALTERNATE_WP_CRON 
ALTERNATE_WP_CRON echos things which causes a "Headers already sent" warning. This adds a check to ensure headers haven't already been sent.

Previously: [45560]

See: #45560. Fixes #48283.
Props dlh.


Built from https://develop.svn.wordpress.org/trunk@46458


git-svn-id: http://core.svn.wordpress.org/trunk@46256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-10 22:52:03 +00:00
Dominik Schilling
c621d4fb3f Themes: Convert core-provided starter content to block content. 
Props Clorith.
Fixes #48130.
Built from https://develop.svn.wordpress.org/trunk@46457


git-svn-id: http://core.svn.wordpress.org/trunk@46255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-10 19:07:05 +00:00
K. Adam White
1a8aba96e7 REST API: Fix error in _fields filtering logic where only one of several requested sibling properties would be included. 
Props kadamwhite, TimothyBlynJacobs.
Fixes #48266.

Built from https://develop.svn.wordpress.org/trunk@46456


git-svn-id: http://core.svn.wordpress.org/trunk@46254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-10 17:18:03 +00:00
desrosj
c6d3987b08 Upgrade/Install: Detect the presence of the native PHP JSON extension before updating. 
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).

However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.

Props jrf, jorbin, dd32, desrosj.
Fixes #47699.
Built from https://develop.svn.wordpress.org/trunk@46455


git-svn-id: http://core.svn.wordpress.org/trunk@46253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 22:22:04 +00:00
K. Adam White
55560a708f REST API: Do not addslash when receiving meta arrays of non-string values. 
Slashing non-string data caused PUT requests containing unmodified meta arrays of integers to fail the check against the existing stored meta value, causing a 500 when posting an unmodified response body back to the server.

Props TimothyBlynJacobs, augustuswm.
Fixes #48264.

Built from https://develop.svn.wordpress.org/trunk@46454


git-svn-id: http://core.svn.wordpress.org/trunk@46252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 17:36:01 +00:00
whyisjake
ec02d199f4 Administration: Ensure visual consistency with large titles in the sidebar. 
Custom posts, and other menu titles that are long aren't wrapping correctly.

Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201

Built from https://develop.svn.wordpress.org/trunk@46453


git-svn-id: http://core.svn.wordpress.org/trunk@46251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 04:58:02 +00:00
Sergey Biryukov
13eecfc861 Docs: Tweak the @since note in Walker::walk() and ::paged_walk() for better readability and consistency with other notes. 
See #47678.
Built from https://develop.svn.wordpress.org/trunk@46452


git-svn-id: http://core.svn.wordpress.org/trunk@46250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2019-10-09 04:35:01 +00:00