Commit Graph

40707 Commits

Author SHA1 Message Date
desrosj
0b94025ba9 Help/About: Update the 5.3 About page for RC3.
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46616


git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 20:10:04 +00:00
desrosj
b5cc5b37f7 Bundled Themes: Update Twenty Twenty.
This brings trunk’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46571], see 4549fd9...dea9290.

Props anlino, ianbelanger, poena, williampatton, collet, erikkroes, torres126, intimez, byalextran, mehidi258, swapnild, nielslange.
Fixes #48450.
Built from https://develop.svn.wordpress.org/trunk@46613


git-svn-id: http://core.svn.wordpress.org/trunk@46410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 14:55:05 +00:00
Sergey Biryukov
4935555c70 Build/Test Tools: Ignore EOL differences in tests using multiline string assertions.
Unix vs. Windows EOL style mismatches can cause misleading failures in tests using the heredoc syntax (`<<<`) or multiline strings as the expected result.

Fixes #31432. See #42594, #47411.
Built from https://develop.svn.wordpress.org/trunk@46612


git-svn-id: http://core.svn.wordpress.org/trunk@46409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 14:28:06 +00:00
John Blackbourn
057f661ce3 Docs: Miscellaneous docblock corrections.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46610


git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:48:01 +00:00
John Blackbourn
c08dbe5236 Docs: Coding standards fix after [46608].
See #48303

Built from https://develop.svn.wordpress.org/trunk@46609


git-svn-id: http://core.svn.wordpress.org/trunk@46406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:35:07 +00:00
John Blackbourn
817807e5be Docs: Remove some funky nested filters.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46608


git-svn-id: http://core.svn.wordpress.org/trunk@46405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:04:05 +00:00
Sergey Biryukov
3a257f4018 Docs: Restore correct placement for duplicate hook reference in render_block_core_latest_comments().
Previously fixed in [46604], accidentally reverted in [46606].

See #48447, #48303.
Built from https://develop.svn.wordpress.org/trunk@46607


git-svn-id: http://core.svn.wordpress.org/trunk@46404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 15:17:03 +00:00
youknowriad
6a713e53bc Block Editor: Bug fixes targetted for WordPress 5.3 RC3.
The list of included fixes is:

- https://github.com/WordPress/gutenberg/pull/18108
- https://github.com/WordPress/gutenberg/pull/18051
- https://github.com/WordPress/gutenberg/pull/18106
- https://github.com/WordPress/gutenberg/pull/18102

Updated packages:
 - @wordpress/api-fetch@3.6.4
 - @wordpress/block-directory@1.0.4
 - @wordpress/block-library@2.9.4
 - @wordpress/core-data@2.7.4
 - @wordpress/data-controls@1.3.4
 - @wordpress/edit-post@3.8.4
 - @wordpress/editor@9.7.4
 - @wordpress/list-reusable-blocks@1.8.4
 - @wordpress/media-utils@1.2.4
 - @wordpress/server-side-render@1.3.4

Props desrosj.
See #48447.

Built from https://develop.svn.wordpress.org/trunk@46606


git-svn-id: http://core.svn.wordpress.org/trunk@46403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 14:13:09 +00:00
whyisjake
7542543e26 Build/Test Tools: Don't hardcode the directory name of the repo
When Travis builds the directory, it was looking for a hardcoded `wordpress-develop` directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.
Props pento, whyisjake.

Built from https://develop.svn.wordpress.org/trunk@46605


git-svn-id: http://core.svn.wordpress.org/trunk@46402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 04:17:02 +00:00
John Blackbourn
f243cd573c Docs: Correct invalid hook docblock placement.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46604


git-svn-id: http://core.svn.wordpress.org/trunk@46401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 19:35:01 +00:00
John Blackbourn
c8f91f77ac Docs: Correct invalid hook docblocks.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46603


git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 19:11:02 +00:00
Sergey Biryukov
c283f8b1ed Docs: Remove "private" designation from _doing_it_wrong() and related functions:
* `_deprecated_function()`
* `_deprecated_argument()`
* `_deprecated_constructor()`
* `_deprecated_file()`

Plugins and themes should be allowed to use these functions to throw appropriate error notices.

This brings them in line with newer `do_action_deprecated()` and `apply_filters_deprecated()` functions, which are not marked as private.

Props jrf.
Fixes #48251.
Built from https://develop.svn.wordpress.org/trunk@46602


git-svn-id: http://core.svn.wordpress.org/trunk@46399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 14:21:03 +00:00
Sergey Biryukov
e015fbd8bb Editor: Fix typo in an error message in WP_Block_Styles_Registry::register().
Props man4toman, alishankhan, shaampk1.
Fixes #48437.
Built from https://develop.svn.wordpress.org/trunk@46601


git-svn-id: http://core.svn.wordpress.org/trunk@46398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 14:09:02 +00:00
Sergey Biryukov
bb57520713 Docs: Improve DocBlock formatting in WP_Block_Styles_Registry per the documentation standards.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46600


git-svn-id: http://core.svn.wordpress.org/trunk@46397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 14:07:02 +00:00
John Blackbourn
d599314349 Docs: Correct and improve inline docs for the file type functions.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46599


git-svn-id: http://core.svn.wordpress.org/trunk@46396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:49:03 +00:00
John Blackbourn
ac6bf7666c Docs: Add missing docs for the auth_cookie_bad_session_token action.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46598


git-svn-id: http://core.svn.wordpress.org/trunk@46395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:46:00 +00:00
John Blackbourn
9e2b6902b3 Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46597


git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:16:04 +00:00
John Blackbourn
3caaa40fc6 Docs: Switch more docs over to typed array notation, plus some fixes.
See #48303, #41756

Built from https://develop.svn.wordpress.org/trunk@46596


git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 21:09:04 +00:00
John Blackbourn
9890e68661 Docs: Switch to typed array notation for the docs for asset dependency functions.
Props marekdedic

See #48303

Built from https://develop.svn.wordpress.org/trunk@46595


git-svn-id: http://core.svn.wordpress.org/trunk@46392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 21:02:02 +00:00
John Blackbourn
7c2b9f2a2e Docs: Miscellaneous docblock fixes and improvements.
See #48303

Built from https://develop.svn.wordpress.org/trunk@46594


git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 20:43:04 +00:00
Sergey Biryukov
552852d887 Docs: Improve documentation for esc_attr_e(), esc_html_e(), esc_attr_x(), esc_html_x().
Props atachibana.
Fixes #48383.
Built from https://develop.svn.wordpress.org/trunk@46593


git-svn-id: http://core.svn.wordpress.org/trunk@46390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 17:30:03 +00:00
Sergey Biryukov
ac3ff7eb1a Docs: Improve documentation for wptexturize().
Props atachibana.
Fixes #48397.
Built from https://develop.svn.wordpress.org/trunk@46592


git-svn-id: http://core.svn.wordpress.org/trunk@46389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:58:04 +00:00
Sergey Biryukov
67ce1885db Docs: Improve formatting of various WP_Screen DocBlocks.
See #48303.
Built from https://develop.svn.wordpress.org/trunk@46591


git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:36:05 +00:00
Sergey Biryukov
67c73ea3ea Docs: Improve documentation for WP_Screen::add_help_tab().
Props atachibana.
Fixes #48395.
Built from https://develop.svn.wordpress.org/trunk@46590


git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:34:07 +00:00
Sergey Biryukov
49007e52bc Build/Test Tools: Add banner to RTL CSS and minified JS files.
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.

This is a follow-up to [41271], which added the banner to minified CSS files.

Fixes #48424. See #30666.
Built from https://develop.svn.wordpress.org/trunk@46589


git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:17:07 +00:00
desrosj
b51327d391 Ensure svn:mime-type is consistently set for appropriate files.
Continuation of [46586], [46587]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46588


git-svn-id: http://core.svn.wordpress.org/trunk@46385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 19:33:04 +00:00
desrosj
09d8704f0f Ensure svn:eol-style is consistently set for all files (part 2).
Continuation of [46586]

See #42594.
Built from https://develop.svn.wordpress.org/trunk@46587


git-svn-id: http://core.svn.wordpress.org/trunk@46384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 19:29:04 +00:00
desrosj
eca853c79e Ensure svn:eol-style is consistently set for all files.
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46586


git-svn-id: http://core.svn.wordpress.org/trunk@46383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 16:38:07 +00:00
desrosj
43c6bc6805 Remove the svn:executable property from files that don't need it.
See #42594.
Built from https://develop.svn.wordpress.org/trunk@46585


git-svn-id: http://core.svn.wordpress.org/trunk@46382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 15:36:05 +00:00
Sergey Biryukov
9ebaa9d522 Date/Time: Remove incomplete and redundant test for get_post_time() added in [46580].
There is no functional difference between `gmt_offset` and `timezone_string` timezone modes for the issue.

See #48384.
Built from https://develop.svn.wordpress.org/trunk@46583


git-svn-id: http://core.svn.wordpress.org/trunk@46380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 15:11:04 +00:00
desrosj
a922509f96 Trunk is now 5.4 alpha.
Built from https://develop.svn.wordpress.org/trunk@46582


git-svn-id: http://core.svn.wordpress.org/trunk@46379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 14:24:04 +00:00
Sergey Biryukov
75c183c248 Date/Time: Make sure get_post_time() keeps UTC time on timezone change.
Add `$source` parameter to `get_post_datetime()` to instantiate from local or UTC time in database.

Props Rarst, david.binda.
Reviewed by azaozz, SergeyBiryukov.
Fixes #48384.
Built from https://develop.svn.wordpress.org/trunk@46580


git-svn-id: http://core.svn.wordpress.org/trunk@46377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 13:08:05 +00:00
Sergey Biryukov
7e11e9d732 Posts, Post Types: Remove unintended change from [46578].
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46579


git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 12:54:03 +00:00
Sergey Biryukov
0b83bffd45 Date/Time: Correct the logic in WP_Posts_List_Table::column_date() and WP_Media_List_Table::column_date() to check for a valid post timestamp.
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384.
Built from https://develop.svn.wordpress.org/trunk@46578


git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 12:51:03 +00:00
Sergey Biryukov
8410526528 Date/Time: Make sure date_i18n() correctly handles zero timestamp after [45901].
Props soulseekah, gravityview, Rarst.
Reviewed by azaozz, SergeyBiryukov.
Fixes #28636.
Built from https://develop.svn.wordpress.org/trunk@46577


git-svn-id: http://core.svn.wordpress.org/trunk@46374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 11:05:07 +00:00
desrosj
5e18c8320b Build/Test Tools: Update the https-proxy-agent dependency.
Fixes #48428.
Built from https://develop.svn.wordpress.org/trunk@46576


git-svn-id: http://core.svn.wordpress.org/trunk@46373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 00:24:05 +00:00
Andrea Fercia
5b85aa1936 Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241].
Props david.binda, audrasjb, azaozz.
See #34904.
Fixes #48396.

Built from https://develop.svn.wordpress.org/trunk@46575


git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-23 20:57:05 +00:00
desrosj
cc73b9a1be Post WordPress 5.3 RC2 version bump.
Built from https://develop.svn.wordpress.org/trunk@46574


git-svn-id: http://core.svn.wordpress.org/trunk@46371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 20:11:05 +00:00
desrosj
ca5925d6dc WordPress 5.3 RC2.
Built from https://develop.svn.wordpress.org/trunk@46573


git-svn-id: http://core.svn.wordpress.org/trunk@46370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 19:44:06 +00:00
desrosj
27994975f9 Help/About: Update the 5.3 About page for RC2.
This includes numerous improvements:

- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.

Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708.
Built from https://develop.svn.wordpress.org/trunk@46572


git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 19:19:07 +00:00
desrosj
16e5753b48 Bundled Themes: Update Twenty Twenty.
This brings `trunk`’s version of Twenty Twenty in-sync with GitHub.

For a complete list of changes since [46551], see bc89c51...4549fd9.

Reviewed by SergeyBiryukov, desrosj, ianbelanger.
Props anlino, ianbelanger, poena, williampatton, nielslange, acosmin, intimez, itowhid06, decrecementofeliz, aristath, westonruter, mukesh27, jorgefilipecosta, karmatosed.
Fixes #48386.
Built from https://develop.svn.wordpress.org/trunk@46571


git-svn-id: http://core.svn.wordpress.org/trunk@46368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 18:27:08 +00:00
Sergey Biryukov
0609e04266 Administration: Relax the default value check for the $position argument added to add_submenu_page() and related functions in [46197].
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.

A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.

Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249.
Built from https://develop.svn.wordpress.org/trunk@46570


git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 17:52:04 +00:00
Sergey Biryukov
4e06f0ad40 Date/Time: Make sure wp_date() does not unnecessarily escape localized numbers, but keeps localized slashes.
Props Rarst, tmatsuur, remcotolsma, peterwilsoncc.
Reviewed by peterwilsoncc.
Fixes #48319.
Built from https://develop.svn.wordpress.org/trunk@46569


git-svn-id: http://core.svn.wordpress.org/trunk@46366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 17:31:08 +00:00
Sergey Biryukov
ff65cfcacf Plugins: Restore backward compatibility for PHP4-style passing of array( &$this ) as action argument to do_action().
This is a follow-up to [46149] to avoid unnecessary breakage in case of using the old notation.

Props david.binda, jrf.
Reviewed by azaozz.
Fixes #48312.
Built from https://develop.svn.wordpress.org/trunk@46568


git-svn-id: http://core.svn.wordpress.org/trunk@46365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 00:11:03 +00:00
Andrew Ozz
b37a2b5c3b Media: After [46237] add the same fix to the .button-group on the "Insert form URL" screen in the media modal.
Props afercia, sabernhardt.
FIxes #48087.
Built from https://develop.svn.wordpress.org/trunk@46567


git-svn-id: http://core.svn.wordpress.org/trunk@46364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 23:23:04 +00:00
Andrew Ozz
5013b45775 Upload: Expand error codes to include all 5xx HTTP errors when retrying to create image sub-sizes. Some servers may be configured to set HTTP 508 or 504, or possibly other 5 errors.
Porps mikeschroder, azaozz.
Fixes #48379.
Built from https://develop.svn.wordpress.org/trunk@46566


git-svn-id: http://core.svn.wordpress.org/trunk@46363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 22:44:03 +00:00
Andrew Ozz
e1560cd1e0 Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append scaled- to the file names of the scaled images to make them easier to recognize.
Props kraftbj, azaozz.
Fixes #48304.
Built from https://develop.svn.wordpress.org/trunk@46565


git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 21:43:04 +00:00
Sergey Biryukov
654c413990 Comments: Add rel="nofollow ugc" attribute when converting plain URLs to <a> tags in comments via make_clickable().
Introduce `make_clickable_rel` filter for the `rel` value that is added to URL matches converted to links.

This is a follow-up to [46349], which added the `rel="nofollow ugc"` attribute to existing `<a>` tags in comments via `wp_rel_ugc()`.

UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props blogginglife, SergeyBiryukov.
Reviewed by desrosj, audrasjb.
Fixes #48022.
Built from https://develop.svn.wordpress.org/trunk@46564


git-svn-id: http://core.svn.wordpress.org/trunk@46361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 20:41:04 +00:00
K. Adam White
cfec48cc31 REST API: Cast empty meta values to correct scalar types in REST response.
Introducing complex meta value handling in [45807] unintentionally removed value casting for empty scalar meta values.

Props TimothyBlynJacobs, chrisvanpatten, rmccue, kadamwhite.
Fixes #48363.


Built from https://develop.svn.wordpress.org/trunk@46563


git-svn-id: http://core.svn.wordpress.org/trunk@46360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 19:10:06 +00:00
youknowriad
21bf3bf8dd Block Editor: Update Packages that include WP 5.3 RC2 fixes.
Updated packages:
 - @wordpress/api-fetch@3.6.3
 - @wordpress/block-directory@1.0.3
 - @wordpress/block-editor@3.2.3
 - @wordpress/block-library@2.9.3
 - @wordpress/core-data@2.7.3
 - @wordpress/data-controls@1.3.3
 - @wordpress/e2e-test-utils@2.4.3
 - @wordpress/e2e-tests@1.7.3
 - @wordpress/edit-post@3.8.3
 - @wordpress/editor@9.7.3
 - @wordpress/format-library@1.9.3
 - @wordpress/list-reusable-blocks@1.8.3
 - @wordpress/media-utils@1.2.3
 - @wordpress/server-side-render@1.3.3
 - @wordpress/url@2.8.2

Props gziolo.
Fixes #48381.

Built from https://develop.svn.wordpress.org/trunk@46562


git-svn-id: http://core.svn.wordpress.org/trunk@46359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 14:02:07 +00:00