Aaron Jorbin
b778726e74
Improve get_post_permalink
compatibility with non standard post status
...
This adds a new filter named `get_post_status` to the function named `get_post_status` which can be used to make additional post types behave like unpublished post status in `get_post_permalink`.
Props misterbisson, antpb, iamfriendly
Fixes #23458
Built from https://develop.svn.wordpress.org/trunk@35233
git-svn-id: http://core.svn.wordpress.org/trunk@35199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:44:26 +00:00
Sergey Biryukov
7c2919c02b
Merge two strings for expanding accordion and Customizer sections.
...
Props pavelevap.
Fixes #33939 .
Built from https://develop.svn.wordpress.org/trunk@35232
git-svn-id: http://core.svn.wordpress.org/trunk@35198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:28:25 +00:00
Weston Ruter
6bcd8ad757
Customizer: Always show Widgets panel initially if sidebars are registered; show notice to users in panel if no widget areas are in current preview.
...
Widgets panel will not wait to display until the preview loads.
Also fixes problems with `margin-top` in panels where other panels' `active` states change, as well as ensuring sections of deactivated panel collapse before panel is hidden to prevent the pane from becoming empty of controls.
Fixes #33052 .
Fixes #33567 .
Built from https://develop.svn.wordpress.org/trunk@35231
git-svn-id: http://core.svn.wordpress.org/trunk@35197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:48:25 +00:00
Sergey Biryukov
5c8522c022
Merge two warning strings.
...
Props pavelevap.
Fixes #29740 .
Built from https://develop.svn.wordpress.org/trunk@35230
git-svn-id: http://core.svn.wordpress.org/trunk@35196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:31:25 +00:00
Sergey Biryukov
f98136c1b5
Sample permalink: Improve accessibility of changing the permalink on Edit Post screen.
...
Props afercia.
Fixes #34255 .
Built from https://develop.svn.wordpress.org/trunk@35229
git-svn-id: http://core.svn.wordpress.org/trunk@35195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 23:02:25 +00:00
Sergey Biryukov
ac630ba233
Embeds: In print_oembed_embed_styles()
, load non-minified file if SCRIPT_DEBUG
is true.
...
This is consistent with `print_oembed_embed_scripts()`.
Props MikeHansenMe.
Fixes #34321 .
Built from https://develop.svn.wordpress.org/trunk@35228
git-svn-id: http://core.svn.wordpress.org/trunk@35194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 22:43:24 +00:00
Boone Gorges
4430e5dbbb
Return null
from get_term()
on taxonomy mismatch.
...
[34997] caused `get_term()` to return an error object in the case when
`$taxonomy` did not match the taxonomy of the located term. This was an
inadvertant change from the previous behavior, when `get_term()` would return
null in these cases.
Props dlh.
See #14162 . Fixes #34332 .
Built from https://develop.svn.wordpress.org/trunk@35227
git-svn-id: http://core.svn.wordpress.org/trunk@35193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:42:25 +00:00
Scott Taylor
efb224e831
Unit Tests: PHP 5.2, I Hate You and You Are Bringing Me Down.
...
#YOLOFriday
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35226
git-svn-id: http://core.svn.wordpress.org/trunk@35192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:15:25 +00:00
Scott Taylor
a2a65a06bd
Unit Tests: one $factory
to rule them all, and it shall be static
.
...
Using more than one instance of `WP_UnitTest_Factory` causes all kinds of craziness, due to out-of-sync internal generator sequences. Since we want to use `setUpBeforeClass`, we were creating ad hoc instances. To avoid that, we were injecting one `static` instance via Dependency Injection in `wpSetUpBeforeClass`. All tests should really use the `static` instance, so we will remove the instance prop `$factory`.
Replace `$this->factory` with `self::$factory` over 2000 times.
Rewrite all of the tests that were hard-coding dynamic values.
#YOLOFriday
Built from https://develop.svn.wordpress.org/trunk@35225
git-svn-id: http://core.svn.wordpress.org/trunk@35191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 21:05:25 +00:00
Scott Taylor
3693228a9b
Unit Tests: since [32953], we can just use self::delete_user()
instead of using if
logic for Multisite.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35224
git-svn-id: http://core.svn.wordpress.org/trunk@35190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 19:52:27 +00:00
Sergey Biryukov
7fdbebdd7d
In WP_Posts_List_Table
, correct the type for $comment_pending_count
.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@35223
git-svn-id: http://core.svn.wordpress.org/trunk@35189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:25:25 +00:00
Sergey Biryukov
dcf23c5e2a
In WP_Media_List_Table
, rename $pending_count
to $comment_pending_count
and mark it as protected, for consistency with WP_Posts_List_Table
.
...
See #11381 .
Built from https://develop.svn.wordpress.org/trunk@35222
git-svn-id: http://core.svn.wordpress.org/trunk@35188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 18:23:27 +00:00
Drew Jaynes
1cb39b180f
Docs: Standardize the file header summary for wp-admin/includes/file.php.
...
Also adds an `@since` version and corrects the `@subpackage` value.
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35221
git-svn-id: http://core.svn.wordpress.org/trunk@35187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 16:56:26 +00:00
Andrea Fercia
dc0e7e1a79
Accessibility: Improve headings hierarchy in the Theme browser modal dialog.
...
Fixes #34288 .
Built from https://develop.svn.wordpress.org/trunk@35220
git-svn-id: http://core.svn.wordpress.org/trunk@35186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:56:25 +00:00
Andrea Fercia
7f4a0ebbf3
Bump H4 headings to H2 in the Updates screen for better accessibility.
...
Fixes #34265 .
Built from https://develop.svn.wordpress.org/trunk@35219
git-svn-id: http://core.svn.wordpress.org/trunk@35185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 15:45:28 +00:00
Dominik Schilling
0df9abe092
Travis CI: Use a pinned version of the object cache drop-in.
...
Props tollmanz.
See #31491 .
Built from https://develop.svn.wordpress.org/trunk@35218
git-svn-id: http://core.svn.wordpress.org/trunk@35184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 14:16:28 +00:00
Ella Iseulde Van Dorpe
bafdd96ebf
TinyMCE: add lang attribute
...
This is needed to make `hyphens: auto;` work correctly.
Fixes #32555 .
Built from https://develop.svn.wordpress.org/trunk@35217
git-svn-id: http://core.svn.wordpress.org/trunk@35183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 10:11:27 +00:00
Ella Iseulde Van Dorpe
ef01315cac
TinyMCE: make sure markers are removed after first init
...
This is only relevant to non embeddable URLs.
After first init, markers were set but not removed,
causing an edited URL to revert when switching to text mode
or any paragraph after the URL to just contain that URL.
Fixes #33954 .
Built from https://develop.svn.wordpress.org/trunk@35216
git-svn-id: http://core.svn.wordpress.org/trunk@35182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 05:43:26 +00:00
Helen Hou-Sandí
fc02ca2d01
Account for icon alignment using text-indent in RTL.
...
fixes #33808 .
Built from https://develop.svn.wordpress.org/trunk@35215
git-svn-id: http://core.svn.wordpress.org/trunk@35181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 00:58:25 +00:00
Scott Taylor
438c2462e1
Unit Tests: add SpeedTrapListener
to phpunit/includes
and add the config node to phpunit.xml.dist
.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35214
git-svn-id: http://core.svn.wordpress.org/trunk@35180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-16 00:28:23 +00:00
Dominik Schilling
dd753ef3ad
Travis: Extend our test suite with a memcached instance.
...
To test persistent object caching Travis CI runs now a build on PHP 5.6 with memached enabled. The build uses the drop-in from https://github.com/tollmanz/wordpress-pecl-memcached-object-cache which is based on the PECL memcached extension.
Props pento, ocean90.
Fixes #31491 .
Built from https://develop.svn.wordpress.org/trunk@35213
git-svn-id: http://core.svn.wordpress.org/trunk@35179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 22:52:25 +00:00
Dominik Schilling
22874716dd
Multisite: Remove the strictness for $using_paths
in WP_Network::get_by_path()
.
...
The network lookup was broken when using an external object cache because `$using_paths` isn't always a boolean. Added in [34099].
See #31985 , #31491 .
Built from https://develop.svn.wordpress.org/trunk@35212
git-svn-id: http://core.svn.wordpress.org/trunk@35178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 22:07:24 +00:00
Dominik Schilling
272ff97709
Tests: Remove the @runTestsInSeparateProcesses
annotation for Ajax tests.
...
They were added 3 years ago in [846/tests] because tests weren't excluded from the normal runs.
Reverts [35209] because it doesn't work with Xdebug.
`Tests_Ajax_Response::test_response_charset_in_header` is the only test which needs to run in a separate process, see [975/tests].
See #31491 .
Built from https://develop.svn.wordpress.org/trunk@35211
git-svn-id: http://core.svn.wordpress.org/trunk@35177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 21:31:24 +00:00
Drew Jaynes
d4711aff8a
Docs: Fix a typo in an inline comment in wp_get_attachment_image_srcset_array()
.
...
Props neoxx.
Fixes #34319 .
Built from https://develop.svn.wordpress.org/trunk@35210
git-svn-id: http://core.svn.wordpress.org/trunk@35176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 20:52:24 +00:00
Dominik Schilling
bcdad0aa12
Tests: Don't preserve the global state for Ajax tests when using an external object cache.
...
Most of the Ajax tests are running in a separate PHP process, and thus PHPUnit attempts to preserve the global state from the parent process by serializing all globals. But this doesn't work for external object caches so we have to disable this "feature".
See #31491 .
Built from https://develop.svn.wordpress.org/trunk@35209
git-svn-id: http://core.svn.wordpress.org/trunk@35175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 20:35:23 +00:00
Aaron Jorbin
41b21cf23b
Add Twenty Sixteen to travis builds
...
This allows the automated tests to include Twenty Sixteen.
Fixes #34315 . See #34306 .
Built from https://develop.svn.wordpress.org/trunk@35208
git-svn-id: http://core.svn.wordpress.org/trunk@35174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 19:06:25 +00:00
Helen Hou-Sandí
7aabfdaca4
Circular focus styling for widgets and menus in the customizer.
...
see #33808 .
Built from https://develop.svn.wordpress.org/trunk@35207
git-svn-id: http://core.svn.wordpress.org/trunk@35173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 18:53:25 +00:00
Boone Gorges
76a89d95c3
Fix incorrect variable name introduced in [35197].
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35206
git-svn-id: http://core.svn.wordpress.org/trunk@35172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 18:48:24 +00:00
Sergey Biryukov
2d540d0280
In WP::parse_request()
and url_to_postid()
, don't skip objects that have a post status with 'exclude_from_search' => false
, e.g. inherit
.
...
This fixes pretty permalinks for attachments, broken in [35195].
Fixes #21970 .
Built from https://develop.svn.wordpress.org/trunk@35205
git-svn-id: http://core.svn.wordpress.org/trunk@35171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:53:24 +00:00
Helen Hou-Sandí
395258bcaa
Make the database update button primary.
...
see #23738 .
Built from https://develop.svn.wordpress.org/trunk@35204
git-svn-id: http://core.svn.wordpress.org/trunk@35170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:35:24 +00:00
Sergey Biryukov
de730d605f
Twenty Sixteen: Update Gruntfile.js
to ignore the html5 shiv for JSHint.
...
See #34306 , #34315 .
Built from https://develop.svn.wordpress.org/trunk@35203
git-svn-id: http://core.svn.wordpress.org/trunk@35169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:27:24 +00:00
Drew Jaynes
0905e847ae
Docs: Walker_Nav_Menu_Checklist
and Walker_Nav_Menu_Edit
are part of the Navigation Menu API, but intended for use in the scope of administration.
...
See #33701 .
Built from https://develop.svn.wordpress.org/trunk@35202
git-svn-id: http://core.svn.wordpress.org/trunk@35168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:26:24 +00:00
Helen Hou-Sandí
12290303a8
Box shadows still need -webkit-
, turns out.
...
see #33808 , [35200].
Built from https://develop.svn.wordpress.org/trunk@35201
git-svn-id: http://core.svn.wordpress.org/trunk@35167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 17:09:26 +00:00
Helen Hou-Sandí
50288dea5a
Circular focus styling for expand/collapse arrows.
...
Affects postboxes, widgets, and nav menus, all in the admin.
props grvrulz for the initial patch.
see #33808 .
Built from https://develop.svn.wordpress.org/trunk@35200
git-svn-id: http://core.svn.wordpress.org/trunk@35166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 16:47:25 +00:00
Ella Iseulde Van Dorpe
3eb4a57c27
TinyMCE: make captioned images draggable
...
See #28003 .
Built from https://develop.svn.wordpress.org/trunk@35199
git-svn-id: http://core.svn.wordpress.org/trunk@35165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 15:20:25 +00:00
Ella Iseulde Van Dorpe
3babb1682a
Fix close button plugin modal after [18590]
...
See #18590 .
Built from https://develop.svn.wordpress.org/trunk@35198
git-svn-id: http://core.svn.wordpress.org/trunk@35164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 14:52:26 +00:00
Scott Taylor
9d4069e5d9
Unit Tests: add/upgrade the fixtures in Tests_User_Query
.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35197
git-svn-id: http://core.svn.wordpress.org/trunk@35163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 07:29:24 +00:00
Scott Taylor
1603ccad71
Unit Tests: create fewer terms in Tests_Term_getTerms::test_get_terms_parent_zero()
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35196
git-svn-id: http://core.svn.wordpress.org/trunk@35162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:53:24 +00:00
Sergey Biryukov
8a6d07f596
In WP::parse_request()
and url_to_postid()
, if a post slug clashes with a trashed page, return the post instead of the page.
...
Props kovshenin, SergeyBiryukov, igmoweb.
Fixes #21970 .
Built from https://develop.svn.wordpress.org/trunk@35195
git-svn-id: http://core.svn.wordpress.org/trunk@35161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:49:25 +00:00
Scott Taylor
3bf9aa75a4
Unit Tests: upgrade the fixtures in Tests_Post_Thumbnail_Template
.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35194
git-svn-id: http://core.svn.wordpress.org/trunk@35160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:40:24 +00:00
Scott Taylor
274d7f5bb0
Unit Tests: upgrade the fixtures in Tests_Post_Revisions
.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35193
git-svn-id: http://core.svn.wordpress.org/trunk@35159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 06:32:25 +00:00
Scott Taylor
5b49ff3a48
Unit Tests: in Tests_Comment_Query::test_get_comments_for_post()
, create fewer comments (5, instead of 10).
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35192
git-svn-id: http://core.svn.wordpress.org/trunk@35158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:57:25 +00:00
Scott Taylor
53ef754260
Unit Tests: after [35186], "upgrade" the Canonical fixtures.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35191
git-svn-id: http://core.svn.wordpress.org/trunk@35157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:51:24 +00:00
Sergey Biryukov
8aa7fb88f0
Remove a one-time variable from edit_user()
added in [35189].
...
See #27317 .
Built from https://develop.svn.wordpress.org/trunk@35190
git-svn-id: http://core.svn.wordpress.org/trunk@35156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:46:24 +00:00
Sergey Biryukov
7f08716c16
Users: Add 'illegal_user_logins'
filter to allow certain usernames to be blacklisted.
...
Props danielbachhuber, chriscct7, crazycoolcam, SergeyBiryukov.
Fixes #27317 .
Built from https://develop.svn.wordpress.org/trunk@35189
git-svn-id: http://core.svn.wordpress.org/trunk@35155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:43:26 +00:00
Scott Taylor
b6b2baccbd
Unit Tests: create more fixtures for Tests_User
. When using a factory to create ad hoc users, use the inherited static prop $static_factory
instead of the instance prop, $factory
. If 2 factories are used out of sync, the generator sequences diverge and dupes can be created, causing an untold number of unforeseen errors. Yay.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35188
git-svn-id: http://core.svn.wordpress.org/trunk@35154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:30:25 +00:00
Sergey Biryukov
09ee95ea49
Themes: Add Install Parent Theme button for child themes that are missing a parent theme.
...
Props rabmalin for initial patch.
Fixes #32668 .
Built from https://develop.svn.wordpress.org/trunk@35187
git-svn-id: http://core.svn.wordpress.org/trunk@35153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 05:11:24 +00:00
Scott Taylor
5cebd10ced
Unit Tests: implement setUpBeforeClass()
and tearDownAfterClass()
on WP_UnitTestCase
. Use late static binding (plus a gross fallback for PHP 5.2) to check if wpSetUpBeforeClass()
or wpTearDownAfterClass()
exist on the called class, and then call it and pass a static WP_UnitTest_Factory
instance via Dependency Injection, if it exists.
...
This makes it way easier to add fixtures, and tear them down, without needing to instantiate `WP_UnitTest_Factory` in every class - removes the need to call `commit_transaction()` in each individual class.
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35186
git-svn-id: http://core.svn.wordpress.org/trunk@35152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 04:44:25 +00:00
Scott Taylor
e62864ce46
Unit Tests: in Tests_Term
, create fixtures for posts.
...
See #30017 , #33968 .
Built from https://develop.svn.wordpress.org/trunk@35185
git-svn-id: http://core.svn.wordpress.org/trunk@35151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:48:25 +00:00
Sergey Biryukov
e63ba31f93
Acessibility: Add back-compat styles for plugins that use h3
inside the .metabox-holder
container.
...
Props afercia.
Fixes #33557 .
Built from https://develop.svn.wordpress.org/trunk@35184
git-svn-id: http://core.svn.wordpress.org/trunk@35150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-15 03:38:25 +00:00