Commit Graph

17849 Commits

Author SHA1 Message Date
Joe McGill
65fa3acb4b WordPress 5.8.9.
Built from https://develop.svn.wordpress.org/branches/5.8@57432


git-svn-id: http://core.svn.wordpress.org/branches/5.8@56938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-01-30 16:32:03 +00:00
audrasjb
86cdb64878 WordPress 5.8.8.
Built from https://develop.svn.wordpress.org/branches/5.8@56890


git-svn-id: http://core.svn.wordpress.org/branches/5.8@56401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-10-12 18:36:54 +00:00
audrasjb
fdbe707b83 Grouped backports to the 5.8 branch.
- Media: Prevent CSRF setting attachment thumbnails.
- Embeds: Add protocol validation for WordPress Embed code.
- I18N: Introduce sanitization function for locale.
- Editor: Ensure block comments are of a valid form.

Merges [55760-55764] to the 5.8 branch.
Props dd32, isabel_brison, martinkrcho, matveb, ocean90, paulkevan, peterwilsoncc, timothyblynjacobs, xknown, youknowriad.


Built from https://develop.svn.wordpress.org/branches/5.8@55777


git-svn-id: http://core.svn.wordpress.org/branches/5.8@55289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-05-16 15:33:10 +00:00
audrasjb
060a547a9f WordPress 5.8.6.
Built from https://develop.svn.wordpress.org/branches/5.8@54583


git-svn-id: http://core.svn.wordpress.org/branches/5.8@54137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-10-17 19:47:19 +00:00
desrosj
1fe18d5a70 WordPress 5.8.5.
Built from https://develop.svn.wordpress.org/branches/5.8@53989


git-svn-id: http://core.svn.wordpress.org/branches/5.8@53548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-08-30 17:27:06 +00:00
audrasjb
47e5d13a47 WordPress 5.8.4.
Built from https://develop.svn.wordpress.org/branches/5.8@52880


git-svn-id: http://core.svn.wordpress.org/branches/5.8@52469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-03-10 22:08:15 +00:00
desrosj
c4666346ad Post WordPress 5.8.3 version bump.
The 5.8 branch is now 5.8.4 alpha.
Built from https://develop.svn.wordpress.org/branches/5.8@52533


git-svn-id: http://core.svn.wordpress.org/branches/5.8@52123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-01-06 20:56:02 +00:00
desrosj
eea95fdec8 WordPress 5.8.3.
Built from https://develop.svn.wordpress.org/branches/5.8@52487


git-svn-id: http://core.svn.wordpress.org/branches/5.8@52079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2022-01-06 18:45:01 +00:00
desrosj
04a101e4d0 WordPress 5.8.2.
Built from https://develop.svn.wordpress.org/branches/5.8@52112


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-10 17:03:58 +00:00
desrosj
276b489dc9 Post WordPress 5.8.2 RC1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.8@51987


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-02 20:09:57 +00:00
desrosj
4ec018ad06 WordPress 5.8.2 RC1.
Built from https://develop.svn.wordpress.org/branches/5.8@51986


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-02 19:46:58 +00:00
Sergey Biryukov
fb283a3c27 Media: Use WP_Query::get() method to retrieve the posts_per_page value in wp_ajax_query_attachments().
This avoids a PHP notice and ensures that a default value is always provided if none is set by the user.

Follow-up to [51145], [51485].

Props davidwebca, mukesh27, circlecube, desrosj.
Merges [51982] to the 5.8 branch.
Fixes #54129.
Built from https://develop.svn.wordpress.org/branches/5.8@51983


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-02 18:33:59 +00:00
desrosj
dd352f4d54 Script Loader: Correct the number of arguments passed to the closure in enqueue_block_styles_assets().
This avoids an `Uncaught ArgumentCountError: Too few arguments to function {closure}(), 1 passed` PHP fatal error when registering a block style with the `should_load_separate_core_block_assets` filter enabled.

Follow-up to [51471].

Props aristath, shimon246, jrf, gziolo, SergeyBiryukov.
Merges [54323] to the 5.8 branch.
Fixes #54323.
Built from https://develop.svn.wordpress.org/branches/5.8@51981


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-02 18:23:01 +00:00
desrosj
8488afbb66 HTTP: Remove the DST Root CA X3 certificate expired on September 30, 2021.
> The currently recommended certificate chain as presented to Let’s Encrypt ACME clients when new certificates are issued contains an intermediate certificate (ISRG Root X1) that is signed by an old DST Root CA X3 certificate that expires on 2021-09-30. In some cases the OpenSSL 1.0.2 version will regard the certificates issued by the Let’s Encrypt CA as having an expired trust chain.
> 
> Most up-to-date CA cert trusted bundles, as provided by operating systems, contain this soon-to-be-expired certificate. The current CA cert bundles also contain an ISRG Root X1 self-signed certificate. This means that clients verifying certificate chains can find the alternative non-expired path to the ISRG Root X1 self-signed certificate in their trust store.
> 
> Unfortunately this does not apply to OpenSSL 1.0.2 which always prefers the untrusted chain and if that chain contains a path that leads to an expired trusted root certificate (DST Root CA X3), it will be selected for the certificate verification and the expiration will be reported.

References:
* [https://www.openssl.org/blog/blog/2021/09/13/LetsEncryptRootCertExpire/ Old Let’s Encrypt Root Certificate Expiration and OpenSSL 1.0.2]
* [https://letsencrypt.org/docs/dst-root-ca-x3-expiration-september-2021/ DST Root CA X3 Expiration (September 2021)]

Follow-up to [25224], [25426], [25569], [27307], [30491], [30765], [34283], [35919], [36570], [46094].

Props bradleyt, fierevere, SergeyBiryukov.
Merges [51883] to the 5.8 branch.
Fixes #54207. See #50828.
Built from https://develop.svn.wordpress.org/branches/5.8@51948


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-10-28 19:22:00 +00:00
desrosj
d34152cfae Build/Test Tools: Change the patch version used for testing the 5.6 branch of PHP.
This unpins the version of PHP 5.6.20 used when testing the 5.6 branch of PHP.

Using 5.6.20 was an intentional decision in [49162], as that patch version is the oldest version of PHP 5.6 still supported by WordPress. However, as of September 30, 2021, the `5.6.20` image contains a version of OpenSSL with an expired certificate, sometimes resulting in an expired trust chain.

Props Clorith, hellofromTonya, SergeyBiryukov, desrosj.
Fixes #54223.
Built from https://develop.svn.wordpress.org/branches/5.8@51889


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-10-05 17:25:02 +00:00
hellofromTonya
211e1f1156 Build/Test Tools: Fix test forward-compatibility layer.
In [51838], the test wrapper methods were not being called due to the names not being recognized as supported PHPUnit "hook" names for fixtures.

This commit:
- Fixes the problem by adding extra camelCase wrappers to the `WP_UnitTestCase` to call the methods in the right order.
- Adds wrappers for the `assertPreConditions()` and `assertPostConditions()` fixture methods to make the backport feature complete for the fixture wrappers.

Test wrapper methods call fix:

By adding method overloads for the PHPUnit native camelCase fixture methods and letting those call the (camelCase) parent method first and only calling the snake_case fixture methods after, the snake_case methods can be supported and the typical run order safeguarded.

As not all test classes will have declared snake_case fixture methods, the snake_case fixture methods are also declared in the `WP_UnitTestCase`. Why? This prevents having to wrap these method calls in `method_exists()` conditions checking for the existence of the snake_case methods in an unknown Test child class. And with the normal inheritance rules in combination with calling the method using `static`, the right method will be called anyway without fatal "calling undeclared method" errors.

Note: While it will be rare, there ''may'' be cases where a test class does not adhere to the normal execution order for fixtures, i.e. for the setup methods, parent first, own code second; and for the teardown methods, own code first, parent second. For example a test class which has "some code - `parent::setUp()` call - some more code" in their `setUp()` method. In those (rare) cases, the execution order of the code will now be changed, which may have side-effects. This rare case will be identified in the dev note.

Follow-up to [51838].

Props bjorsch, swisspidy, jrf, hellofromTonya.
See #53911.
Built from https://develop.svn.wordpress.org/branches/5.8@51861


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-24 13:20:01 +00:00
desrosj
6d84519fd5 Build/Test Tools: Introduce the PHPUnit Polyfills package for easier cross branch testing.
This backports the PHPUnit Polyfills package and related test infrastructure changes to make it easier for developers to continue testing on multiple versions WordPress while adding tests for newer versions of PHP, which require more modern PHPUnit practices.

One of the changes included is the addition of wrappers for the new snake_case fixture methods in PHPUnit. This allows the native camelCase standard in PHPUnit to be used, but allows for developers to transition to the new naming conventions.

Props hellofromTonya, jrf, SergeyBiryukov, johnbillion, netweb, schlessera, jeherve, lucatume, desrosj.
Merges [51559,51560,51810-51813,51828] to the 5.8 branch.
See #53911.
Built from https://develop.svn.wordpress.org/branches/5.8@51838


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-21 19:06:00 +00:00
desrosj
4fa7af0ce1 Post WordPress 5.8.1 version bump.
The 5.8 branch is now 5.8.2 alpha.
Built from https://develop.svn.wordpress.org/branches/5.8@51778


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-09 03:16:02 +00:00
desrosj
87fd7274b4 WordPress 5.8.1.
Built from https://develop.svn.wordpress.org/branches/5.8@51771


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-09 02:12:58 +00:00
Andrew Ozz
3744b979ad Editor: Revert [51748] and [51649]. They intorduced a bug where wp.editor may be replaced with wp.oldEditor in certain cases.
Props desrosj, davidbinda, azaozz.
Merges [51768] to the 5.8 branch.
Fixes #53762.

Built from https://develop.svn.wordpress.org/branches/5.8@51770


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-09 02:00:57 +00:00
desrosj
71adb4a0bf Help/About: Update the About page for WordPress 5.8.1.
Props audrasjb, circlecube, mukesh27.
Fixes #54083.
Built from https://develop.svn.wordpress.org/branches/5.8@51767


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-08 22:51:59 +00:00
Sergey Biryukov
ca5652bc3e Editor: fix the replacement of wp.editor with wp.oldEditor in the inline script outputted when enqueueing the old editor.
Props fullofcaffeine, davidbinda, grantmkin, get_dave, azaozz.
Merges [51748] to the 5.8 branch.
Fixes #53762.
Built from https://develop.svn.wordpress.org/branches/5.8@51749


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-08 19:24:57 +00:00
Sergey Biryukov
0fdb93612f General: Only use _jsonp_wp_die_handler() for JSONP REST API requests.
Props mdawaffe, peterwilsoncc.
Merges [51740] to the 5.8 branch.
Built from https://develop.svn.wordpress.org/branches/5.8@51741


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-08 17:21:02 +00:00
desrosj
a5a23683a0 Post WordPress 5.8.1 RC1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.8@51723


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 19:57:58 +00:00
desrosj
d71865a750 WordPress 5.8.1 RC1.
Built from https://develop.svn.wordpress.org/branches/5.8@51722


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 19:46:57 +00:00
desrosj
00c29d0f49 Editor: Update block editor packages for WordPress 5.8.1.
The following packages were updated:
- @wordpress/a11y to `3.1.2`
- @wordpress/annotations to `2.1.6`
- @wordpress/api-fetch to `5.1.2`
- @wordpress/autop to `3.1.2`
- @wordpress/babel-preset-default to `6.2.1`
- @wordpress/blob to `3.1.2`
- @wordpress/block-directory to `2.1.21`
- @wordpress/block-editor to `6.1.14`
- @wordpress/block-library to `3.2.19`
- @wordpress/block-serialization-default-parser to `4.1.2`
- @wordpress/blocks to `9.1.8`
- @wordpress/components to `14.1.11`
- @wordpress/compose to `4.1.6`
- @wordpress/core-data to `3.1.12`
- @wordpress/customize-widgets to `1.0.20`
- @wordpress/data-controls to `2.1.6`
- @wordpress/data to `5.1.6`
- @wordpress/date to `4.1.2`
- @wordpress/deprecated to `3.1.2`
- @wordpress/dom-ready to `3.1.2`
- @wordpress/dom to `3.1.5`
- @wordpress/e2e-test-utils to `5.3.1`
- @wordpress/edit-post to `4.1.21`
- @wordpress/edit-widgets to `2.1.21`
- @wordpress/editor to `10.1.17`
- @wordpress/element to `3.1.2`
- @wordpress/escape-html to `2.1.2`
- @wordpress/format-library to `2.1.14`
- @wordpress/html-entities to `3.1.2`
- @wordpress/i18n to `4.1.2`
- @wordpress/icons to `4.0.3`
- @wordpress/interface to `3.1.12`
- @wordpress/keyboard-shortcuts to `2.1.7`
- @wordpress/keycodes to `3.1.2`
- @wordpress/list-reusable-blocks to `2.1.11`
- @wordpress/media-utils to `2.1.2`
- @wordpress/notices to `3.1.6`
- @wordpress/nux to `4.1.11`
- @wordpress/plugins to `3.1.6`
- @wordpress/primitives to `2.1.2`
- @wordpress/priority-queue to `2.1.2`
- @wordpress/react-i18n to `2.1.2`
- @wordpress/redux-routine to `4.1.2`
- @wordpress/reusable-blocks to `2.1.17`
- @wordpress/rich-text to `4.1.6`
- @wordpress/scripts to `16.1.5`
- @wordpress/server-side-render to `2.1.12`
- @wordpress/shortcode to `3.1.2`
- @wordpress/url to `3.1.2`
- @wordpress/viewport to `3.1.6`
- @wordpress/warning to `2.1.2`
- @wordpress/widgets to `1.1.19`
- @wordpress/wordcount to `3.1.2`

Props oandregal, juanmaguitar, gziolo, jblz, talldanwp, ribaricplusplus, peterwisoncc, youknowriad, paaljoachim, kreppar, ellatrix, aristath, walbo, ajlende, kevin940726, mamaduka, ntsekouras, toro_unit, mkaz, joen, noisysocks, zieladam, andraganescu, antonvlasenko, terraling, dariak, vladytimy, circlecube, desrosj.
Merges [51719] to the 5.8 branch.
Fixes #54052, #52818.
Built from https://develop.svn.wordpress.org/branches/5.8@51721


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 19:28:24 +00:00
desrosj
9134e272c6 Customize: Add wp-embed-responsive class to body if using widgets block editor
Appends the wp-embed-responsive class to the body if the widgets block editor is enabled. This fixes a bug preventing embeds (e.g. YouTube embeds) appearing in the widgets block editor.

Props walbo, kevin940726, noisysocks.
Merges [51716] to the 5.8 branch.
Fixes #53609.
Built from https://develop.svn.wordpress.org/branches/5.8@51720


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 19:09:57 +00:00
desrosj
2a23de5be9 Media: Remove documentation detailing specific edge cases in the image_editor_output_format filter.
In [51422], a few specific edge cases were detailed so that developers using the hook were aware of known pitfalls.

These edge cases have been fixed in 5.8.1 through [51653] and [51704], so the documentation is no longer necessary.

Props azaozz, audrasjb.
Merges [51717] to the 5.8 branch.
Fixes #53955.
Built from https://develop.svn.wordpress.org/branches/5.8@51718


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 17:31:58 +00:00
Peter Wilson
bde718d703 Build: Clean css/dist as part of the webpack build step.
Move the cleaning of the `wp-includes/css/dist` folder from `clean:css` to `clean:webpack-assets` to avoid an order of operations issue in which the files were built shortly before been deleted later in the build process.

Follow up to [51689].

Props netweb, ramonopoly, peterwilsoncc.
Merges [51713] to the 5.8 branch.
Fixes #53719.


Built from https://develop.svn.wordpress.org/branches/5.8@51714


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 04:05:58 +00:00
desrosj
9ae8a61247 Media: apply the wp_editor_set_quality filter not only when loading an image in the editor but also when saving an converted image, after the mime-type of the output image has changed.
Props mikeschroder, desrosj, azaozz.
Merges [51704] to the 5.8 branch.
Fixes #53667.
Built from https://develop.svn.wordpress.org/branches/5.8@51712


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 00:44:56 +00:00
desrosj
cc684968ae Widgets: Pass correct context to get_block_categories() calls.
The `get_block_categories()` function expects either a `WP_Post` or a `WP_Block_Editor_Context` instance as the context argument, not a string.

Follow-up to [50996], [50997].

Props Enchiridion, pbearne, audrasjb, SergeyBiryukov.
Merges [51700] to the 5.8 branch.
Fixes #53757.
Built from https://develop.svn.wordpress.org/branches/5.8@51711


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 00:34:58 +00:00
desrosj
a80100db11 Widgets: Show title and media select fields in Accessibility Mode.
This updates the Custom HTML and Media widgets to display the correct fields when adding or editing a widget when using accessibility mode through the Classic Widgets experience.

Follow up to [49973].

Props mark-k, sabernhardt, alexstine, circlecube, audrasjb.
Merges [51701] to the 5.8 branch.
Fixes #53641.
Built from https://develop.svn.wordpress.org/branches/5.8@51710


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 00:29:58 +00:00
desrosj
af2f290084 Media: fix showing of the "Filter Media" filds when replacing an image from the media modal.
Props mhuntdesign, sabernhardt, azaozz.
Merges [51703] to the 5.8 branch.
Fixes #53833.
Built from https://develop.svn.wordpress.org/branches/5.8@51708


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 00:14:59 +00:00
desrosj
03d74022be Coding Standards: Apply some minor alignment fixes.
These are updates caused by running `composer format`.

Follow up to [51653].

Partially merges [51693] to the 5.8 branch.
See #53668.
Built from https://develop.svn.wordpress.org/branches/5.8@51707


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-01 00:11:57 +00:00
desrosj
c909ee1c74 Media: Fix wp_unique_filename() to check for name collisions with all alternate file names when an image may be converted after uploading. This includes possible collinions with pre-existing images whose sub-sizes/thumbnails are regenerated.
Props ianmjones, azaozz.
Merges [51653] to the 5.8 branch.
Fixes #53668.
Built from https://develop.svn.wordpress.org/branches/5.8@51706


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-31 23:57:59 +00:00
desrosj
dc6b47047b Editor: Conditionally load registered styles for block variations
In WordPress 5.8 we added the ability to only load styles for blocks when these blocks are rendered. However, these optimizations left out block-styles that get added using the register_block_style() function/API.

Props aristath, gziolo.
Merges [51471] to the 5.8 branch.
Fixes #53616.
Built from https://develop.svn.wordpress.org/branches/5.8@51696


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-30 15:37:58 +00:00
desrosj
bbda256d9c Filesystem API: Make sure to only call fread() on non-empty files in PclZip::privAddFile().
This avoids a fatal error on PHP 8 caused by passing a zero value to `fread()` as the `$length` argument, which must be greater than zero.

This commit also amends the previous solution for similar issues elsewhere in the file to ensure consistent type for string values, instead of changing the type from `string` to `bool` when trying to read from an empty file.

Follow-up to [50355].

Props DavidAnderson, jrf, SergeyBiryukov.
Merges [51686] to the 5.8 branch.
Fixes #54036.
Built from https://develop.svn.wordpress.org/branches/5.8@51694


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-30 14:28:57 +00:00
desrosj
ccb796fb1e Build: Remove css/dist in grunt clean command.
Modify the `grunt clean:css` command to include the folder `wp-includes/css/dist` to ensure legacy files do not remain if the built files are removed/relocated.

Props desrosj, netweb., peterwilsoncc.
Merges [51689] to the 5.8 branch.
Fixes #53719.
Built from https://develop.svn.wordpress.org/branches/5.8@51691


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-30 13:40:57 +00:00
desrosj
ff0c04e257 Menus: Save display locations for new menus.
Fixes a bug preventing the locations saving when creating a new menu. Introduced in [50938].

Props dlh, andraganescu, mukesh27, desrosj, peterwilsoncc.
Merges [51688] to the 5.8 branch.
Fixes #53877.
Built from https://develop.svn.wordpress.org/branches/5.8@51690


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-30 13:39:56 +00:00
Peter Wilson
eb0d45bb63 Customize: Prevent collapsing expanded panel/section/control when Esc is pressed on a block editor instance.
This ensures that the current panel is not collapsed when hitting `Esc` with the focus on the widget block editor.

Follow-up to [37347], [39120].

Props gwwar, dlh, SergeyBiryukov.
Merges [51682,51683] to the 5.8 branch.
Fixes #54030.

Built from https://develop.svn.wordpress.org/branches/5.8@51687


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-30 03:30:57 +00:00
desrosj
1660108b59 Editor: Ensure block attribute serialization in PHP matches the JavaScript equivalent.
The `serializeAttributes()` function in JavaScript uses `JSON.stringify`, which does not encode slashes and unicode characters by default. This resulted in the PHP serialization through `json_encode()` producing different results.

This also switches from `json_encode()` to `wp_json_encode()` to prevent failures when any non UTF-8 characters are included.

Props kevinfodness, SergeyBiryukov, timothyblynjacobs.
Merges [51674] to the 5.8 branch.
Fixes #53936.
Built from https://develop.svn.wordpress.org/branches/5.8@51681


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-27 19:09:58 +00:00
desrosj
eded09c12f Build/Test Tools: Use list format when defining environment variables in Docker compose file.
This is the correct formatting detailed in the Docker `compose` documentation examples and helps to avoid ambiguities in the yaml parser when values that may cause warnings.

Props pbrearne, ocean90, johnbillion, desrosj.
Merges [51673] to the 5.8 branch.
Fixes #53820.
Built from https://develop.svn.wordpress.org/branches/5.8@51680


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-27 19:07:58 +00:00
desrosj
24d4730dd1 Editor: Replace the remaining references to wp.editor with wp.oldEditor.
Props zieladam, azaozz.
Merges [51649] to the 5.8 branch.
Fixes #53762.
Built from https://develop.svn.wordpress.org/branches/5.8@51656


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-25 18:49:00 +00:00
desrosj
8718b2cae6 Media: Increase number of media items displayed per page.
Increase the number of media items displayed per page from 40 to 80 to improve the experience for users navigating the library on sites with a large quantity of media in the library.

Props AlGala, antpb, hellofromTonya, joedolson, SergeyBiryukov, wb1234, peterwilsoncc.
Merges [51632] to the 5.8 branch.
Fixes #53827.
Built from https://develop.svn.wordpress.org/branches/5.8@51643


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-19 15:01:57 +00:00
desrosj
8145e21ca2 Media: Fix layout of media library modal on narrow screens.
Reduces the right margin of the media library modal on small and medium width screens to remove excess white-space. On very narrow screens this was preventing the media icons from displaying.

Props andraganescu, desrosj, joedolson, moch11, mukesh27, sabernhardt, SergeyBiryukov, zieladam, peterwilsoncc.
Merges [51631] to the 5.8 branch.
Fixes #53679.
Built from https://develop.svn.wordpress.org/branches/5.8@51642


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-19 15:00:59 +00:00
desrosj
b9d1f9170d Customize: Hide native control on background position field.
Hide the browser's native radio button on the custom background position selector in the Customizer and the legacy background screen. This fixes an issue causing both to display.

Props mukesh27, ravipatel, sabernhardt, walbo, peterwilsoncc.
Merges [51637] to the 5.8 branch.
Fixes #53803.
Built from https://develop.svn.wordpress.org/branches/5.8@51640


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-19 13:47:00 +00:00
desrosj
d6c021e728 Docs: Fix typo in the get_block_editor_settings() description.
Follow-up to [50776].

Props tmatsuur, pbearne, SergeyBiryukov.
Merges [51611] to the 5.8 branch.
Fixes #53922.
Built from https://develop.svn.wordpress.org/branches/5.8@51621


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-16 18:42:57 +00:00
desrosj
0609cdd83c Editor: Preserve the original template keys when preparing a list of page templates.
Previously, the original "404" template key was lost when "Default template" is merged into the available templates array, as the `array_merge()` function renumbers numeric keys. Later, when we merge templates on the client side, this caused duplicate "404" templates to appear in the dropdown.

By replacing the `array_merge()` call with `array_replace()`, we make sure to keep the original numeric keys.

Props Mamaduka, Toro_Unit, youknowriad, SergeyBiryukov.
Merges [51595] to the 5.8 branch.
Fixes #53898.
Built from https://develop.svn.wordpress.org/branches/5.8@51620


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-16 18:41:00 +00:00
desrosj
77cdaf8e92 Menus: Hide bulk-select on new menu page.
Prevent the bulk-select option from displaying when adding a new menu. This also prevents the option from displaying when an administrator first visits the menu page and no menus are set.

Props dlh, sabernhardt, peterwilsoncc.
Merges [51539] to the 5.8 branch.
Fixes #53654.
Built from https://develop.svn.wordpress.org/branches/5.8@51596


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-10 19:36:59 +00:00
desrosj
3616f5bf0b Editor: Prevent block-editor JavaScript loading in other editors.
Add a check to `wp_add_iframed_editor_assets_html()` confirming the edit post screen is using the block-editor before including block-editor specific JavaScript. For the classic and other editors the function returns early without any output.

Props swissspidy, desrosj, peterwilsoncc.
Merges [51540] to the 5.8 branch.
Fixes #53696.
Built from https://develop.svn.wordpress.org/branches/5.8@51593


git-svn-id: http://core.svn.wordpress.org/branches/5.8@51204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-08-10 16:35:04 +00:00