This ensures that the reply heading is updated correctly on single post URLs with the `?replytocom` query argument.
Follow-up to [47506], [48876], [48904].
Props mailnew2ster, wpamitkumar, audrasjb, desrosj, SergeyBiryukov.
Merges [49187] to the 5.5 branch.
Fixes#51175.
Built from https://develop.svn.wordpress.org/branches/5.5@49191
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
When the mysql extention isn't loaded and a custom db dropin is not in place, we give folks a nice error. However, we can't assume that the WP_CONTENT_DIR constant is set yet since this runs before we define default constants.
This fixes a PHP8 error.
See: #50913.
Built from https://develop.svn.wordpress.org/branches/5.5@49161
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The recommended approach for any plugins using these globals or properties is to switch to the newer `wp.i18n` functions.
In the meantime, this ensures that accessing any of these globals does not break the rest of the code on the page, and an appropriate warning message is logged to the JavaScript console.
Follow-up to: https://core.trac.wordpress.org/query?summary=~wp.i18n&milestone=5.5
Props omarreiss, peterwilsoncc, kbjohnson90, johnbillion, TimothyBlynJacobs, joostdevalk, ocean90, desrosj, SergeyBiryukov.
Merges [48923] to the 5.5 branch.
Fixes#51123.
Built from https://develop.svn.wordpress.org/branches/5.5@48925
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Technically, the `$format` argument should always be a string, but passing `false` used to work before [47808], so this restores backward compatibility.
The list of affected functions:
- `get_the_date()`
- `get_the_time()`
- `get_comment_date()`
- `get_comment_time()`
Props wittich, Rarst, akabarikalpesh, SergeyBiryukov.
Merges [48912] to the 5.5 branch.
Fixes#51184.
Built from https://develop.svn.wordpress.org/branches/5.5@48921
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used.
Follow-up to [47763], [48620].
Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov.
Merges [48910] to the 5.5 branch.
Fixes#51081.
Built from https://develop.svn.wordpress.org/branches/5.5@48915
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
The intention of `wp_get_environment_type()` is to provide a consistent means of identifying the environment type, not of identifying a specific environment.
Actual environments should fit within one of the existing types: `local`, `development`, `staging`, or `production`. That should cover the types that plugins and themes might be concerned about when toggling functionality.
Props johnbillion, joostdevalk, TimothyBlynJacobs, jeremyfelt, batmoo, claytoncollie, Clorith, markjaquith, garrett-eclipse, GaryJ, elrae.
Merges [48894] and [48895] to the 5.5 branch.
Fixes#50992.
Built from https://develop.svn.wordpress.org/branches/5.5@48896
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that `wp_localize_script( 'jquery', ... )` continues to work as expected, since `WP_Scripts::localize()` rewrites the `jquery` handle to `jquery-core` internally.
Follow-up to [48323].
Props mukesh27, rajeshsingh520, johnbillion, TimothyBlynJacobs, TobiasBg.
Merges [48890] to the 5.5 branch.
Fixes#50919.
Built from https://develop.svn.wordpress.org/branches/5.5@48891
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner's liking.
Props audrasjb, Paddy Landau, desrosj.
Merges [48888] to the 5.5 branch.
Fixes#50988.
Built from https://develop.svn.wordpress.org/branches/5.5@48889
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
In [48306] support for multi-typed schemas was improved to first detect the data type of the value before applying further validation. The `integer` data type was detected using the new `rest_is_integer` function. This function used logic, however, that assumed that the value had already passed an `is_numeric` check. This meant that if `integer` and `string` were both acceptable types, the value would always be considered an `integer` causing the later accurate type validation to fail.
This commit fixes the `rest_is_integer` logic to include an `is_numeric` check.
Props rtagliento, TimothyBlynJacobs.
Merges [48881] to the 5.5 branch.
Fixes#51146.
Built from https://develop.svn.wordpress.org/branches/5.5@48883
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Update `redirect_canonical()` to account for custom pagination and URL format used by sitemaps in order to follow standard practices.
Introduce the function `get_sitemap_url()` to simplify getting the index and provider URLs as needed.
Props jonathanstegall, pbiron, GamerZ, salvoaranzulla, peterwilsoncc.
Merges [48872] to the 5.5 branch.
Fixes#50910.
Built from https://develop.svn.wordpress.org/branches/5.5@48873
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Color schemes should only affect colors, to avoid diverging from a consistent and predictable layout, especially if core CSS rules subsequently change.
Follow-up to [48277], [48286], [48345].
Props Joen, johnbillion, afercia, johnjamesjacoby.
Merges [48862] to the 5.5 branch.
Fixes#51127. See #50504.
Built from https://develop.svn.wordpress.org/branches/5.5@48863
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This gives developers a better control over their existing development workflow and ensures that `local` is not the exact same as `development` if it does not need to be.
Props claytoncollie, johnbillion, jeremyfelt, kreppar, dushakov, TimothyBlynJacobs, Ipstenu, khag7, knutsp, Clorith, markjaquith, joostdevalk, SergeyBiryukov.
Merges [48856] to the 5.5 branch.
Fixes#51064.
Built from https://develop.svn.wordpress.org/branches/5.5@48857
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Any notices in that file happen before `WP_DEBUG` takes effect, and should not be displayed with the `error_reporting` level previously set in `wp-load.php`.
Adding the class when there is no notice displayed results in extra padding under the admin bar, which should be avoided.
Follow-up to [20102], [21025], [26620], [47745].
Props akissz, tw2113, laxman-prajapati, sabernhardt, johnbillion, SergeyBiryukov.
Merges [48850] to the 5.5 branch.
Fixes#51073.
Built from https://develop.svn.wordpress.org/branches/5.5@48851
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This addresses a regression in [47808], which caused excerpts to be generated from post content if an empty string is passed, but not for other values considered empty, e.g. `null` or `false`.
Props riaanlom, laxman-prajapati, SergeyBiryukov.
Merges [48817] to the 5.5 branch.
Fixes#51042.
Built from https://develop.svn.wordpress.org/branches/5.5@48819
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Support for the `uniqueItems` keyword was added in [48357], but wasn't included in the list of permitted keywords for `WP_REST_Controller::get_endpoint_args_for_item_schema()`. This prevented the keyword from being automatically supported if specified in a controller's item schema.
Props TimothyBlynJacobs.
Merges [48796] to the 5.5 branch.
Fixes#51021.
Built from https://develop.svn.wordpress.org/branches/5.5@48807
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.
Props oakesjosh, jeroenrotty, desrosj, Clorith.
Merges [48800] and [48801] to the 5.5 branch.
Fixes#50945.
Built from https://develop.svn.wordpress.org/branches/5.5@48806
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.
With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.
Follow-up to [47841].
Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Merges [48792] to the 5.5 branch.
Fixes#50912.
Built from https://develop.svn.wordpress.org/branches/5.5@48804
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
- Final CDN asset URLs.
- Some minor color adjustments.
Props ryelle, marybaum, davidbaumwald, audrasjb, estelaris, afercia, cbringmann, andreamiddleton, desrosj, SergeyBiryukov, ocean90, nrqsnchz, spacedmonkey, whyisjake, man4toman.
Merges [48783] to the 5.5 branch.
Fixes#50416.
Built from https://develop.svn.wordpress.org/branches/5.5@48784
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.
This brings the changes from [48750] to the 5.5 branch.
Props johnbillion.
Fixes#50868, see [48750].
Built from https://develop.svn.wordpress.org/branches/5.5@48756
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
To accommodate for the change, the custom-logo theme feature now accepts the unlink-homepage-logo parameter.
If and when the logo is linked on the home page, the link has the aria-current attribute for better accessibility.
Follow-up to [48039], [48283], see [48749].
This brings the changes to the 5.5 branch.
Props sabernhardt, audrasjb, johnstonphilip, demetris, SergeyBiryukov.
Fixes#37011.
Built from https://develop.svn.wordpress.org/branches/5.5@48755
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This ensures that comment object cache is cleared after changing the comment type to `comment` instead of an empty string.
Add a unit test for `_wp_batch_update_comment_type()`.
Follow-up to [47597], [47626], [48225], [48227].
Props imath, westonruter.
Reviewed by desrosj, SergeyBiryukov.
Merges [48748] and [48751] to the 5.5 branch.
Fixes#49236.
Built from https://develop.svn.wordpress.org/branches/5.5@48752
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Keep 1024-bit legacy root certificates re-added in [35919], except for those already expired, for compatibility with older OpenSSL versions.
Props barry, ayeshrajans, desrosj, whyisjake.
Reviewed by whyisjake, SergeyBiryukov.
Merges [48707] to the 5.5 branch.
See #50828.
Built from https://develop.svn.wordpress.org/branches/5.5@48708
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.
This brings the changes from [48703] to the WordPress 5.5 branch.
Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/branches/5.5@48704
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.
This brings the changes from [48701] to the 5.5 branch.
Fixes#50824.
Props dd32, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/branches/5.5@48702
git-svn-id: http://core.svn.wordpress.org/branches/5.5@48464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
