Sergey Biryukov
9d6a2d1c33
Feeds: Fix "Only variables should be passed by reference" PHP notice in atomlib.php
.
...
Props jrf.
Fixes #51558 .
Built from https://develop.svn.wordpress.org/trunk@49182
git-svn-id: http://core.svn.wordpress.org/trunk@48944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-17 15:45:06 +00:00
Sergey Biryukov
f14f0c1ddf
XML-RPC: Explicitly unset the reference to the parser resource after calling xml_parser_free()
to avoid memory leaks in PHP 7.0.0 or higher.
...
Props procifer, ayeshrajans.
Fixes #49700 .
Built from https://develop.svn.wordpress.org/trunk@48322
git-svn-id: http://core.svn.wordpress.org/trunk@48091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-05 15:22:01 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Ryan McCue
fbc00b31ef
General: Remove most uses of create_function()
...
create_function() is equivalent to eval(), and most of our uses can be refactored. This is simpler, more secure, and slightly more performant.
Props sgolemon.
Fixes #37082 .
Built from https://develop.svn.wordpress.org/trunk@39591
git-svn-id: http://core.svn.wordpress.org/trunk@39531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-12-13 01:49:39 +00:00
Gary Pendergast
b21d1cb6e6
General: Check to see that the PHP-XML module is enabled before using XML functions.
...
There are a handful of places where we don't check that the XML functions exist before we use them. Ubuntu's PHP 7 packages don't include PHP-XML by default, increasing the chance of this causing issues.
Props kraftbj, markoheijnen.
Fixes #37122 .
Built from https://develop.svn.wordpress.org/trunk@38883
git-svn-id: http://core.svn.wordpress.org/trunk@38826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-10-24 04:45:31 +00:00
Sergey Biryukov
9b56e3b7e4
External Libraries: After [37402], replace two more instances of split()
with explode()
in wp-includes/atomlib.php
.
...
Props josephscott.
Fixes #20673 .
Built from https://develop.svn.wordpress.org/trunk@37461
git-svn-id: http://core.svn.wordpress.org/trunk@37429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-19 00:06:28 +00:00
Dominik Schilling
b5718124c3
External Libraries: Replace split()
with explode()
in the deprecated Atom and MagpieRSS files.
...
Before PHP7 `split()` was throwing a deprecated notice, in PHP7 the function is completely removed and throws a fatal error.
Props achbed.
Fixes #20673 .
Built from https://develop.svn.wordpress.org/trunk@37402
git-svn-id: http://core.svn.wordpress.org/trunk@37368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-07 15:59:29 +00:00
Aaron Jorbin
1525010f74
Deprecate php4 style constructors
...
PHP7 is deprecating PHP4 style constructors, so we need to modify our code to have _construct methods that fire before the named PHP4 style constructors. The PHP4 style constructors will call the PHP5 style constructor in case it is being called directly (usually via parent::METHOD).
This modifies external libraries to add PHP5 style constructors, but doesn't add a notice for when they are used. In WordPress core code, PHP4 style constructors are being given a call to _deprecated_constructor. To the PHP4 style constructor I say "I know that I can't take no more | It ain't no lie | I wanna see you out that door | Baby, bye, bye, bye..."
Upstream: https://wiki.php.net/rfc/remove_php4_constructors
Props jdgrimes, netweb, jorbin
See #31982
Built from https://develop.svn.wordpress.org/trunk@32990
git-svn-id: http://core.svn.wordpress.org/trunk@32961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-28 15:27:24 +00:00
Dominik Schilling
c37bdc3c9e
Merge similar error strings.
...
props pavelevap.
fixes #32327 .
Built from https://develop.svn.wordpress.org/trunk@32471
git-svn-id: http://core.svn.wordpress.org/trunk@32441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 18:27:26 +00:00
Drew Jaynes
cd8cedc40d
First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
...
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713 .
Built from https://develop.svn.wordpress.org/trunk@26868
git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Andrew Nacin
213bb4eb2a
Use correct variable in atomlib library, inside an error message. props rlerdorf, see #24110 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-07 16:37:21 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
westi
e6e0954dbb
Minor phpdoc fixups.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-20 20:56:40 +00:00
westi
437ba6e7b3
** > *.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@8085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-06-14 16:57:20 +00:00
westi
33fffea3f3
Add file level phpdoc to external libraries we use. Fixes #5443 props darkdragon.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-20 22:28:54 +00:00
ryan
321c310717
Remove trailing whitespace
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:32:58 +00:00
ryan
87c4f3a17f
Strip lines that contain only whitespace down to newlines.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6025 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-03 23:19:20 +00:00
markjaquith
d723ff00d8
Escape text titles in AtomParser. Props Sam Ruby. fixes #4892
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@6010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-09-02 20:42:00 +00:00
ryan
f8d09ad828
Bring in atomlib 0.4 and update wp-app to use it. Props eliast and placey. fixes #4191
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@5951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-08-27 19:52:58 +00:00